2988 commits

Author	SHA1	Message	Date
Kurt	f37a587a1c	Minor simplifications ... move some pk3->pk4 stuff into object constructor annotate pk3->pk4 string buffer (trash) quirks split Heal into Party/PP method uses. Setting suggested stats no longer refreshes PP apply current level to Stat Level (wasn't being set previously)	2019-07-12 16:41:13 -07:00
Kurt	d153224af1	Add traded egg allowance for nickname ... store bool for reuse, not any slower :) Closes #2320	2019-07-11 22:55:41 -07:00
Kurt	face8d64a9	Fix gen5 dexflag set ... Add unit tests to check Closes #2356	2019-07-11 00:13:52 -07:00
Kurt	c64ff5dd76	Fix sav5 behavior ... Closes #2356 ty @Ammako	2019-07-10 00:19:59 -07:00
Kurt	ab735de2d9	Revert "Decapitalize non-nicknamed on 4->5 transfer" ... This reverts commit 904dc84b52.	2019-07-09 20:24:47 -07:00
Kurt	1de685c6d8	Add Happy Hour/Hold Hands ... per confirmation from @PP-theSLAYER https://projectpokemon.org/home/forums/topic/53818-these-events-are-flagged/?do=findComment&comment=246918 they probably won't release these two moves tho, LGPE has become stale	2019-07-08 22:18:15 -07:00
Kurt	90cc8ca3ec	Add Celebrate for lgpe valid move filter ... event move only still haven't bothered finding the table in the exefs that results in the pkm with an oob move being dummied. hardcoded based on data for now :)	2019-07-08 22:14:21 -07:00
Kurt	3f4f02cee1	Add string quality tests ... Expect no duplicates in met locations, items, or moves. These are arrays with common duplicate strings (poor localizations). Should help futureproof / help implementation for this type of err: https://projectpokemon.org/home/forums/topic/53818-these-events-are-flagged/	2019-07-08 22:05:59 -07:00
Kurt	605b410d52	Make Distribution Super Training missions invalid ... Was initially implemented as fishy during SM's initial implementation. Any nonzero value in this byte is invalid, don't even bother checking unused/count. Now that Gen6 (and Gen7) are no longer current gen, any hope for them being released is the same as hoping for Gen4's Azure Flute Arceus. Thus we mark as invalid :) Closes #2353 by effect of no longer flagging as Fishy. I think that my initial implementation of VC stuff had assumed the Generation==7, but later used 1/2 for factual correctness.	2019-07-08 12:12:16 -07:00
Kurt	cf0908a21e	Remove check for impossible conditions ... #2354 SUBE is never < 0 with the latest change (blank saves behave same as retail saves).	2019-07-08 10:03:53 -07:00
NotTsunami	e29da1a8e8	Remove check for impossible condition in XY Save (#2354) ... XY can't be ORASDEMO	2019-07-07 22:58:33 -07:00
Kurt	fef4dbb9dc	More super training checks ... Check the secret unlocked/complete flags for eggs Check the count for VC, and flags too (even though they're checked later, just do it here) #2353	2019-07-07 15:04:58 -07:00
Kurt	15c44139c3	Fix record read offset ... Closes #2353 first 100 are u32, second 100 are u16; shift accordingly	2019-07-07 14:54:38 -07:00
Kurt	8f88e630c2	Fix ORAS inventory class type ... now no longer removes items from pouch https://projectpokemon.org/home/forums/topic/53761-oras-item-problems-with-new-version/	2019-07-07 08:43:58 -07:00
Kurt	772a2715c0	Fix SecondsTo* read offset ... copypasted from gen6's, oops Thanks CreamatedReptile2018!	2019-07-07 08:43:04 -07:00
Kurt	f2ac29ff4e	Relocate some logic ... slightly reduces savefile.cs footprint	2019-07-05 22:02:29 -07:00
Kurt	9a61f0de0f	Minor relocation of logic ... and the gradual shift to full-oop continues	2019-07-05 21:39:47 -07:00
Kurt	c0eda5eb61	Add more dex bulk manip options ... unused, not sure how an abstraction can work for all games (needs some virtual methods to actually work, since 1-3 don't have langflags)	2019-07-05 18:49:43 -07:00
Kurt	aa94c70df2	Hide gen6 dex logic behind zukan class ... Same as prior commit for gen5 & gen7	2019-07-05 18:04:36 -07:00
Kurt	adbb3e842a	Hide gen7 dex logic behind zukan class ... Same as prior commit for gen5	2019-07-05 17:05:42 -07:00
Kurt	79a9269fbe	Hide gen5 dex logic in Zukan class ... Didn't change any of the bulk modifications, but the data get/set is now done via the Zukan object rather than raw data manipulation	2019-07-05 16:21:53 -07:00
Kurt	7f186048fb	Really fix dex lang flag offset style ... c345688f6d base(x) -> base(x - y) resulted in incorrect offsets for LGPE. Great. Just make PokeDexLanguageFlags a shift offset instead of absolute; update all usages. Closes #2348	2019-07-05 12:16:09 -07:00
Kurt	599ec4ed45	Fix checksum offset fetch ... #2348	2019-07-05 11:57:40 -07:00
Kurt	810f7271c6	Clear boxes after initialize ... Closes #2349	2019-07-05 11:53:13 -07:00
Kurt	808c1d2992	Update 19.07.05 ... Update event binaries with latest from the Event Gallery	2019-07-04 22:00:48 -07:00
pokecal	6b3d6999d1	update MailBoxEditor (#2344) ... fixed FRLG offset, etc.	2019-07-04 21:48:18 -07:00
Kurt	5a8b421672	Add jp crystal eventflag offset ... was pointing to an FF'd region, was added back via e86b8c670f Closes #2347	2019-07-04 15:07:37 -07:00
Kurt	7a2b27ebbe	Provide min level to evochain fetch ... Feels pretty brittle with all the optional parameters; if things get funky for SW/SH it may warrant a rewrite of this portion Closes #2345 ty @iiippppk !	2019-07-02 08:34:28 -07:00
Kurt	b5945624eb	Add VC2 trade OT gender check ... Closes #2343 ty @WEERSOQUEER ! #2338 was referenced by 4d08e21126 , that commit was incorrect. Looks like these 2 have OT Gender female. Instead of marking every trade MALE except for these two, just update the handling (i'll probably regret this lol)	2019-06-29 17:43:09 -07:00
Kurt	4eb3f8529b	Filter Species & Moves for legal combobox display ... LGPE will missingno your pokemon if it's not a Kanto/M&M, or one of its moves is not obtainable. For the user's benefit, filter down these sources to the non-baddata list. Item filtering and ball filtering might be something to think about for the future, but not much benefit vs effort.	2019-06-29 08:19:01 -07:00
Matt	08ea140f17	Update GO Shiny banlist for GO 3rd Anniversary (#2342) ... * Update GO Shiny banlist for GO 3rd Anniversary	2019-06-28 11:04:23 -07:00
Kurt	c8747d4ede	Apply OT mismatch deferral to gen2 ... Check the OT length for the deferral other encounters are more permissive than trades, hence why we defer unless we know for certain. Same OTs are possible, except for the too-long ones! Closes #2338 , thanks @WEERSOQUEER !	2019-06-27 21:38:24 -07:00
Kurt	4d08e21126	Explicitly check VC in-game trade gender ... can't have Female ever, so check == 0 #2338	2019-06-27 21:24:08 -07:00
Kurt	da93a19c05	Add edge-case transfer OT cases ... Needs to be checked prior to the strict Array Index search, as we can't have an exact string match. can probably be revised to a StartsWith to only check for the specific language match, but that's a little less obvious & extra work :) #2338	2019-06-26 21:19:37 -07:00
Kurt	7e0fc61428	Add unused character encodings to dictionary ... Two of the inaccessible keyboard chars are used by Spanish trades, so they aren't completely unused. #2338	2019-06-26 21:16:18 -07:00
Kurt	71fdd01a93	Fix Stationary haxorus encounter gen ... remove unnecessary %25 check (only applicable for gen4 encounters), unneeded for gen5 method. add a test case to generate a haxorus for all natures, verify shininess Closes #2336	2019-06-26 20:37:26 -07:00
Matt	4ff5fcb25c	Add SM Poké Ride flags (#2341)	2019-06-26 11:39:39 -07:00
Matt	a47036d2f4	Add USUM Poké Ride flags (#2337)	2019-06-26 06:35:27 -07:00
Kurt	444eab0756	Add mystry mew seed table ... no validation for wc3 encounters yet, dunno when that will happen	2019-06-25 21:15:56 -07:00
Matt	7472ba8152	Encounters cleanup (#2335)	2019-06-25 10:55:35 -07:00
Kurt	6b18208ccb	Fix g2 trade OT check ... Closes #2332 thanks @WEERSOQUEER !	2019-06-24 15:45:52 -07:00
Kurt	59ddd4b3dd	Add lure ball to ball color table	2019-06-22 20:00:17 -07:00
Kurt	c345688f6d	Fix dex lang bitflag offset write ... LangFlags is expected to be less than 0x500 or whatever, zero indexed to the start of the dex block; NOT an absolute position. I don't feel like making every usage consistent (gen5, gui editors) which use the absolute position, so just adjust in the zukan constructors	2019-06-22 16:53:25 -07:00
Kurt	cbd039b18c	Extract datasource filtered lists to object ... GameInfo has been the storage for the current Game Language environment When using GameInfo, only one environment is tracked at a time, which is initialized by the PKM editor (items, moves). Rework things to allow multiple filtered sources to exist, and keep the filtering logic in PKHeX.Core for reuse in other programs... ;)	2019-06-22 10:50:32 -07:00
Kurt	e81e5f31da	Remove shadow info index shift ... Thanks @PP-theSLAYER ! https://projectpokemon.org/home/forums/topic/53405-bug-oddity-with-shadow-recognition/?do=findComment&comment=246125	2019-06-20 20:39:34 -07:00
Kurt	63c705061d	Add recognition for Method 3 encounters ... Pass them as Legal for wild encounters similar to M1/M2/M4. Add test cases & test pkm validation Add pid generator support I decided against checking these PIDIVs after all others; inlined methods. Closes #2328 , thanks @pokecal !	2019-06-19 19:15:06 -07:00
Kurt	dc813da2f7	Add DisplayTID/SID getset	2019-06-19 17:49:56 -07:00
Matt	08835d5d97	Fix ORAS held items/personal reference (#2329)	2019-06-19 12:18:09 -07:00
Kurt	5fbf9ba278	Fix cloning of a bad-checksum pk3	2019-06-18 20:55:35 -07:00
Kurt	e02f7ef30f	Reduce allocation required for ability check	2019-06-18 20:54:59 -07:00
Kurt	523c36d982	Add qr parse util ... used in pkhex.mobile, might as well migrate some logic into core I'd rather not untangle the decode-api response parsing to use QRUtil.	2019-06-18 20:10:01 -07:00
Kurt	55d486af31	Extract event block diff logic	2019-06-18 18:10:48 -07:00
Kurt	de77f949da	Prevent assert on non-exportable saves	2019-06-17 20:55:01 -07:00
Matt	59a7e247cb	Update GO Shiny banlist (#2325)	2019-06-13 08:46:53 -07:00
Matt	186adca755	Unban GO Shiny Onix (#2323)	2019-06-10 22:33:34 -07:00
Kurt	7225b2b87b	Add more sav1/2 option properties ... Closes #2321 Closes #2322 no gui as SimpleTrainer is kinda getting overloaded; use linqpad or wait for someone to make a GUI for the specific games	2019-06-09 14:15:42 -07:00
Kurt	455ab32722	Retain override version on clone ... Also hide the pika friend label when YW features hidden #2283	2019-06-09 13:48:51 -07:00
Kurt	a30a00317f	Add missing trainer location overrides ... Was missing from #2319	2019-06-08 20:19:39 -07:00
Kurt	904dc84b52	Decapitalize non-nicknamed on 4->5 transfer ... Closes #2320	2019-06-08 20:16:30 -07:00
Kurt	1b028198ad	Split gen5-7 saves with inheritance (#2319) ... refer to pull request comments for summary	2019-06-08 19:56:11 -07:00
pokecal	84d1354e2f	Update EncounterArea.cs (#2318) ... fix FishingTable of Route12,13(same as R32), R14(water inaccessible). Some issues about Qwilfish will be solved.	2019-06-07 19:24:59 -07:00
Kurt	de774ed131	readonly ComboItem ... create once, never modified after	2019-06-01 19:12:41 -07:00
Kurt	2b8ef9236a	use some explicit dex numbers as enum	2019-06-01 10:22:49 -07:00
Kurt	36114e6ff9	Update checksum on templating ... pk3 loading tries to decrypt shuffle or something; this makes it work	2019-05-29 22:50:34 -07:00
Kurt	9cdbc46740	Relocate apply basic template out of gui	2019-05-29 22:40:39 -07:00
Kurt	a9152d36a4	Minor tweaks ... make some enums non-int (in favor of byte etc) return current nickname if desired clamp nature top bound too	2019-05-29 22:40:07 -07:00
Kurt	5879cc8a18	Extract some pkm gui logic ... probably won't stay this way if things are eventually rewritten; too much business logic in the pkmeditor.cs, would need a ton of abstraction	2019-05-29 21:35:52 -07:00
Kurt	144a78d688	Relocate method	2019-05-29 16:42:48 -07:00
Kurt	8d781fd167	Simplify sorting to remove linq usage ... create custom comparer to do the work reorder some parameters simplify gb hm set (All and FindIndex is duplicate work) only usages of linq remaining are for the bulk action Where filtering (ok)	2019-05-28 22:55:41 -07:00
Kurt	513648638f	Fix incompatible hax conversion (1/2->3 etc) error ... Shared base classes throw a new snag, where the property may be Declared in the shared class. eg: PKM -> _K12 -> PK2 just filter all public ones that have a setter; works well enough idk	2019-05-28 16:52:59 -07:00
Kurt	a45cddd3ed	Add missing hax item clamp early return ... Closes #2281 remove unnecessary "else", and break for visual separation	2019-05-27 21:38:04 -07:00
Kurt	33a07a6fcd	Try and force destination language on transfer ... Closes #2314	2019-05-27 11:23:47 -07:00
PP-theSLAYER	88d7be62d9	Removed Special Funfest Poliwag & updated min Lvl. (#2315) ... According to the link below, the official page states that Poliwag's announcement was a mistake, and they clarified it would not be appearing. This message was echoed across various pages (Sapporo, Fukuoka, Tohoku), not just the Yokohama one. https://voice.pokemon.co.jp/stv/yokohama/2013/08/post-2286.html Additionally, based on tests from me and jojo, Funfest missions forces the grotto encounters to be max level (of the individual grottoes). https://projectpokemon.org/home/forums/topic/39810-unlock-all-funfiesta-missions/?do=findComment&comment=245303	2019-05-27 00:39:36 -07:00
PP-theSLAYER	968f850138	Added Funfest week 3 encounters (#2312)	2019-05-21 23:37:47 -07:00
Kurt	6e8f7fe680	Fix pgf gender criteria roll ... got stuck in an infinite loop for PID (gender invalid from the start) https://projectpokemon.org/home/forums/topic/52873-pkhex-mystery-gift-database-not-working/	2019-05-20 18:35:57 -07:00
Kurt	9b8b8f784a	Revert "Add another vc nature checks" ... This reverts commit b51bdc9230.	2019-05-20 17:05:53 -07:00
Kurt	d1bc1d07c8	Disallow shiny aura ... if hadou were here, it'd get the same anti treatment too	2019-05-17 17:48:45 -07:00
Kurt	827eb94f3c	Add GameSync r/w for lgpe ... https://projectpokemon.org/home/forums/topic/52797-request-lgpe-game-sync-like-value-to-be-added/ ty @PP-theSLAYER !	2019-05-16 22:26:51 -07:00
Kurt	7f9328e883	Fix vivillon comparisons ... Fix template->pkm form fetch too; would return 0 for non-subregion countries rather than the Country Specific form ID https://projectpokemon.org/home/forums/topic/52800-invalid-internal-error-with-the-spewpa-evolution-line/	2019-05-16 22:01:11 -07:00
Kurt	73b61e5bf0	Add gender changed azurill evo pokewalker edge case ... Closes #2311 , thanks @SpiredMoth !	2019-05-15 17:14:48 -07:00
Matt	25985f11e6	Fix Static/Gift IV method call (#2310)	2019-05-15 12:07:48 -07:00
Kurt	b7f024e3ea	Fix arceus held item compare ... https://projectpokemon.org/home/forums/topic/52771-bug-report-pkhex-20190515-arceus-forms-error/	2019-05-15 09:46:52 -07:00
ReignOfComputer	7625ab66b4	Fix Import Count on Load Boxes (#2308) ... Calculation was wrong if non-overwrite is selected. Also fixed OCD-triggering extra space in output message.	2019-05-15 09:11:48 -07:00
Kurt	be8e8851e2	Update 19.05.15	2019-05-14 22:47:48 -07:00
Kurt	1d44136e54	Update xd fateful flag leniency ... not enough documentation to know what every single flag does; just be lenient I assume that flags being present XK3->PK3 will set fateful, so we could remove that logic... Exposing bitflags for editing isn't fun for the editor, so just ignore it behind the fateful bool get/set. fateful required for all xk3 origin #2289	2019-05-14 20:14:15 -07:00
Kurt	555e81205d	Update fateful encounter read location ... Closes #2289	2019-05-14 18:36:48 -07:00
Kurt	091b9e2281	Add g4 poffin editor (misc edits) ... Thanks @sora10pls for docs! https://pastebin.com/jNeVJQi0	2019-05-13 22:56:45 -07:00
Kurt	5140350ceb	Bump to net standard 2	2019-05-13 22:33:24 -07:00
Kurt	76e3174d8c	Add gen4 poffin logic ... 800 bytes starting at Offset = SAV.DP ? 0x5050 : 0x52E0; 8 bytes per poffin, 100 poffins.	2019-05-13 18:42:30 -07:00
ReignOfComputer	6c42e3b1bb	Enhance Invalid Convert Error (#2305) ... Makes it clearer for conversion failure with Pokemon files - prevent confusion with save files.	2019-05-13 15:38:33 -07:00
ReignOfComputer	2b39d75141	Allow Open WB7Full / WB7 (#2304)	2019-05-13 15:35:40 -07:00
ReignOfComputer	9d6127dfc2	Fix C# 7.2 Build Error (#2303) ... Explicitly target LangVersion 7.2.	2019-05-13 15:35:19 -07:00
Kurt	15f93216bd	Fix record flag clearing ... yay missing ~, Closes #2301 ty @CanoeHope ! rewrite flag loading to not use linq	2019-05-12 15:08:04 -07:00
Kurt	bad16adcee	Fix sav7b clone method ... underlying data should be a different reference when cloned	2019-05-12 15:06:50 -07:00
Kurt	4703a3d364	Fix incorrect method call ... IVs for regular trade gifts can have random IVs; only VC-era have purely fixed IVs. Closes #2300	2019-05-11 17:03:22 -07:00
Kurt	4b770e62d9	Simplify and relocate wurmple evo logic	2019-05-11 14:25:58 -07:00
Kurt	feb36f58b5	Minor simplification ... #2298 #2299	2019-05-11 13:10:51 -07:00
Andrew Johnson	b1ad10d8ad	Add shiny check for Ash-Greninja (#2299)	2019-05-11 13:08:22 -07:00
Kurt	21e7f4317e	Minor updates ... increase readability, simplifly some expressions relocate hot path for legality report string creation	2019-05-11 10:12:14 -07:00
Kurt	332784d34b	Misc updates ... parameter name lowercase simplify some comparisons/calcs reuse comparison methods wrap memory dump into readonly struct	2019-05-11 00:59:07 -07:00
Kurt	55189a6967	Extract most common location numbers to class	2019-05-10 20:46:49 -07:00
Kurt	72edb6aa72	Misc tweaks to 3->4+ branching ... more lines, a little clearer	2019-05-09 22:47:37 -07:00
Kurt	b51bdc9230	Add another vc nature checks ... transfer level exp and current exp not being different enough, which limits the amount of natures possible. Could handle the 100&<=2 cases the same way, but keep the branches for faster cases. fix bad test cases	2019-05-09 01:56:44 -07:00
Matt	316430985a	Unban Shiny Seel (#2293)	2019-05-01 14:23:08 -07:00
Kurt	042e5176a6	Remove hardy shuckie & version split ... Not version specific; I'm assuming the 00020003 PID is a result of hacking the save file to change OT gender. Legitimate saves haven't yielded the Hardy PID. Changing gender probably results in a bad pointer, fetching the wrong value. Closes #2290	2019-04-30 17:03:12 -07:00
Kurt	520c9da5c9	Update string loading ... Remove usage of linq for sorting, use array.sort for in-place sorting. Wasteful creating temp sorted buffers then enumerating them to dump into the list.	2019-04-29 21:55:43 -07:00
Kurt	7094132eac	Fix b2w2 fr trade OT name ... Closes #2291 ty @WEERSOQUEER	2019-04-29 17:42:39 -07:00
Kurt	be50830975	Relocate method to extension logic class ... GetLocationString is now right below GetPotentialString PKX no longer has extension methods aside from the two CopyTo sugar	2019-04-29 17:36:29 -07:00
Kurt	300ef4d60a	Minor simplifications ... Use "SetData" method to automatically apply the Edited flag Use appropriate method for CopyTo simplify expressions a tad	2019-04-29 17:21:19 -07:00
Kurt	7c380a29c3	Make sort skip delegate more general	2019-04-29 17:20:16 -07:00
Kurt	9838ea9a2b	Merge branch 'master' of https://github.com/kwsch/PKHeX	2019-04-29 16:40:58 -07:00
Matt	091e64571b	Update GO shiny banlist (#2292)	2019-04-29 15:32:17 -07:00
Kurt	0dc45c00ec	Check block index before calculating ... Missing/Duplicate blocks (???) result in -1, so skip them. https://projectpokemon.org/home/forums/topic/52437-cant-export-unmodified-sav-file/ replace linq with manual allocation	2019-04-27 17:19:54 -07:00
Kurt	0bd6caf927	Fix male-only dex bit wiping ... only wipe the index specific bits, don't wipe everything but the index specific bits	2019-04-22 22:25:14 -07:00
Matt	963cb1aa99	Unban GO Shiny Lapras (#2287)	2019-04-17 22:49:58 -07:00
Kurt	d8f064409f	Fix pk1->pk2 conversion parameters ... https://projectpokemon.org/home/forums/topic/52273-replicable-issue-cant-inject-pk1-in-silvercrystal-save/ Thanks Maddaren!	2019-04-17 18:35:51 -07:00
Matt	b8c490ae2e	Update GO shiny banlist (#2286)	2019-04-17 12:53:13 -07:00
Kurt	35851fcf5c	Simplify and enhance expression ... cache fetch of PersonalInfo (avoid re-fetching) If event, the pkm wasn't bred with ditto If genderless or male-only (except nido/volb), assume ditto	2019-04-16 23:07:47 -07:00
Kurt	ab64eb5850	Trim unused	2019-04-16 22:58:37 -07:00
Kurt	a481757b45	Relocate CheckEncrypted to PKX ... PKX references within the method; no dependence on anything in PKMConverter	2019-04-16 22:51:01 -07:00
Kurt	5a53c2490a	Simplify expression, emit inner error messages ... existing logic had been overwriting the inner error messages with the generic fail message Remove backwards conversion precondition check; the ConvertPKM method has no branches that allow conversion so it'll naturally fail -- end result is the same with less upfront logic.	2019-04-16 22:38:50 -07:00
Kurt	86d10af78b	Minor clean ... cache Generation value, store arceus stuff as ushort	2019-04-16 22:14:21 -07:00
Matt	7e553155e1	Fix PKM conversion prompt order (#2285)	2019-04-16 10:54:29 -07:00
Kurt	934595126f	Simplify qr gender ... use personalinfo object to do majority of work, end result has the 4 sequential bytes set neatly	2019-04-15 15:43:48 -07:00
Kurt	286df71c5a	Hide sound type for nonyellow gen1 saves ... Closes #2283 Fix label name & update translation file for them	2019-04-15 15:38:49 -07:00
Kurt	9736efd332	Updates continued ... Use clone track bool could instead track the result for each pkm step instead, for extending functionality to mass-delete any flagged entry (cleanup).	2019-04-14 16:04:36 -07:00
Kurt	34ea56c2a7	Minor updates ... Fresh day, fresh tests of the new code :) Fix assert conditions Add extra considerations Detected clones should be skipped for PID/EC/TID checks -- should probably detect this a different way rather than checking a computed string (bool array of flags for the clone check results)	2019-04-14 09:06:43 -07:00
Kurt	0fdd9d98e6	Fix xmldoc typo	2019-04-14 09:04:40 -07:00
Kurt	3d60bea245	Add savefile-wide pkm legality checks ... clone checks, duplicate PID/EC/TID untested & no gui access for now	2019-04-14 01:06:34 -07:00
Kurt	74a45c436a	Remove machoke trade catchrate restriction ... reverts to 90 Closes #2282, also evident in RoC's PC files (as 90 catch rate).	2019-04-12 22:46:05 -07:00
Kurt	289a36cbd4	Relocate tables to folder ... less overpopulated folders	2019-04-12 14:12:30 -07:00
Kurt	ba2b9ace8d	Use byte for pp value storage ... more appropriate storage; for 3887 indexes -> saves 11.3KB	2019-04-10 22:05:57 -07:00
Kurt	27dfffd5b2	Add model-gender/starter-gender get/set ... https://projectpokemon.org/home/forums/topic/52127-lgpe-save-research/?tab=comments#comment-243751 Thanks theSlayer! (starter gender not modifiable via gui)	2019-04-10 17:03:05 -07:00
Kurt	82fb95b436	Add ConfigSave language get/set ... This value is what determines what language the game runs with	2019-04-09 21:19:08 -07:00
Kurt	f4740bbe52	Capture reused variables	2019-04-09 20:58:19 -07:00
Kurt	1a343c3b21	Add more xmldoc	2019-04-09 20:57:44 -07:00
Kurt	2f2512b09c	Reduce allocations for checking file write time ... FileInfo inherits from FileSystemInfo, which initializes a bunch of strings that we don't need this isn't a great optimization, just a fun exercise finding a quicker approach to get these values	2019-04-05 18:45:59 -07:00
Kurt	054d498619	Add vc transfer nature checks ... Closes #2279 thanks @SadisticMystic !	2019-04-03 20:13:35 -07:00
Matt	21e7d82468	Update GO shiny banlist (#2278)	2019-04-02 13:59:43 -07:00
Kurt	9e83e13559	Update 19.04.02 ... Update mgdb too	2019-04-01 18:35:01 -07:00
Evan Dixon	1ccbddd442	Merge pull request #2276 from kwsch/nupkg-license ... Add NuGet metadata	2019-04-01 19:47:55 -05:00
Kurt	bbe56a3318	Simplify trade trainer parameters ... Bank was always false, don't try to minimalize gets by fetching before call (be simple) remove unreachable branches now that dust has settled	2019-03-30 22:05:28 -07:00
Kurt	e614aa9ac8	Relocate xd/batrev encryption ... update some xmldoc too	2019-03-30 21:28:32 -07:00
Kurt	f212ba29c9	Misc reductions ... same stuff as previous commit but for Gen2 EventConstMax is always > 0, remove guards	2019-03-30 16:38:52 -07:00
Kurt	4f347fbfa9	Misc reductions ... no functional change	2019-03-30 16:21:45 -07:00
Kurt	609db23dc5	Consolidate pouch load/set	2019-03-30 16:10:14 -07:00
Kurt	db7feaa8eb	Update translations with latest additions	2019-03-30 12:37:18 -07:00
Kurt	e1a3c8edb3	Add RTC reset, allows game to define on continue ... Closes #2273 , thanks @SatoMew !	2019-03-30 12:34:51 -07:00
Kurt	bb8cf5d3d8	Simplify get/decrypt pkm access	2019-03-29 19:43:33 -07:00
Kurt	5dcf2f4dc8	Use enum instead of nullable bool tristate	2019-03-29 17:52:26 -07:00
Kurt	4f2b9baede	Add missing stamp ... Closes #2274	2019-03-29 09:40:31 -07:00
Kurt	86db3e85e7	Unban HA g7 monkeys ... https://twitter.com/SerebiiNet/status/1111223652178112513 bank gift can breed to pass on HA	2019-03-28 21:44:46 -07:00
Kurt	c7a610b02b	Fix typo in method names ... Transferrable->Transferable	2019-03-28 21:44:06 -07:00
Kurt	e83f313281	Remove unnecessary abstraction ... less objects with only 1 property/field, less objects created = faster	2019-03-23 18:59:45 -07:00
Kurt	55c7bf9858	Remove unnecessary abstraction ... EvolutionSet was just an object that hides an array, with no logic was planning to use the EvolutionSet to do the evolution checks, but EvolutionTree was required to connect the evolution chains together	2019-03-23 10:36:28 -07:00
Kurt	41e066c562	Consolidate duplicate logic ... Reformat g1/2 evolution data binaries for easy loading precomputed count => no unnecessary allocation/resizing	2019-03-23 10:05:33 -07:00
Kurt	20f023e619	Reduce allocations ... GetMethod used to create new array every time; reuse static hashset (same arrays) use scan approach to allocate required count	2019-03-23 01:01:04 -07:00
Kurt	4650a6f5b5	Reduce sizes	2019-03-22 21:19:47 -07:00
Kurt	583fcfa449	Use builtin struct instead of anonymous object ... faster overall	2019-03-22 18:46:31 -07:00
Kurt	bc5ed2d218	Misc reductions ... Removes empty trashbyte array allocation (less objects) Change int[] to byte[] (less filesize/mem) (-256*6) Change int[] to ushort[], precompute reverse table in saved space removes dictionary lookup for array index fetch (faster, less memory, no temp obj allocations!) could make the ushort[] arrays into byte[] by changing them to be value shifts? Not worth saving filesize for cpu.	2019-03-22 18:42:03 -07:00
Kurt	687da38e2e	Add pkrs infected/cured setters	2019-03-21 16:48:17 -07:00
Kurt	cce362b98a	Relocate FFFF trim (and 0000) to same location	2019-03-20 22:13:09 -07:00
Kurt	b1ead9e630	Split StringConverter into smaller pieces ... reduces loading time (don't have to allocate conversion arrays when launching a gen7 game), and separates things to easier to manage locations reworks gen3 string encode/decode, no longer does 3->4->5 and 5->4->3; instead goes straight to the end result without an intermediary format. String sanitization should probably be broken up rather than reused, oh well.	2019-03-20 21:50:44 -07:00
Kurt	8bc949152d	Enhance IEncounterable list summarization ... separates by type (wild, egg, etc) then groups by generation, listing the locations and games that can obtain it in that location	2019-03-19 22:05:13 -07:00
Kurt	fad5e4bdee	Expand comboitem loading for simple cases ... slightly less gc pressure, precompute capacity	2019-03-18 21:55:33 -07:00
Kurt	82a40cb965	Misc updates ... add comboitem list to string[] add regions list as cached comboitem list lock resource cache on fetch extract alola time list generating	2019-03-18 21:34:21 -07:00
Kurt	7e8154fa62	Make parsing flexible / diacritic insensitive ... Flabébé if users manually type it :)	2019-03-18 18:09:48 -07:00
Kurt	53dbdf62f7	Add more test cases, case insensitive parse	2019-03-18 00:04:17 -07:00
Kurt	5e3b390fe1	Add learnability API and tests	2019-03-17 22:19:46 -07:00
Kurt	d975081a86	Add short/long name property differentiation	2019-03-17 22:19:37 -07:00
Kurt	9f7f9f9e75	Use glyph dictionary instead of creating 19 strings ... muh optimization	2019-03-16 20:15:12 -07:00
Kurt	3eed1370c1	Minor simplification ... if conditional checks >=3, and all subsequent checks require Valid; add this to the continue condition, and remove unnecessary comparisons update some comments	2019-03-16 20:07:30 -07:00
Kurt	99baca5f5e	Use min parameter count ... PK2 doesn't like getting passed null for the byte[] parameter (rightly so); don't depend on the src code order having the first constructor being the one with the least arguments fix it in pk1/2 so that the first constructor has the least args, anyway	2019-03-16 20:04:44 -07:00
Kurt	8a08d32dff	Simplify pkm constructors ... remove Identifier param. 99% of the time, identifier is not provided, resulting in a useless call end result: provide 'create new' and 'create from' constructors	2019-03-16 18:41:56 -07:00
Kurt	fb76032a39	Remove unnecessary null checks on constructors	2019-03-16 18:23:50 -07:00
Kurt	5765ce8229	Extract gc version IDs to separate logic	2019-03-16 16:48:38 -07:00
Kurt	ebc7c6ae29	Remove PKX.LCRNG method ... Duplicate with RNG.LCRNG reuse cryptarray for gen5 mysterygift r/w	2019-03-16 16:25:25 -07:00
Kurt	fc10fd3d60	Simplify transfer xor, extract glyph conversion	2019-03-16 16:19:00 -07:00
Kurt	9ca4ef1e09	Move pkx hidden power logic to HiddenPower.cs	2019-03-16 12:07:22 -07:00
Kurt	13a6d16cb9	Relocate checksum/dexform logic	2019-03-16 12:01:21 -07:00
Benjamin Sinkula	e4d59b8b98	Add PlayerNames and MatchDate to BV7	2019-03-15 14:35:55 -05:00
Kurt	41bc3f6182	Fix header'ed file export ... For xd, getfinaldata returned a standard 344KB save, but then slapped it together with the inner savedata (0x28000 bytes) rather than using the GCI header. Don't use 'Data'	2019-03-15 10:26:16 -07:00
Kurt	94c80fd32c	Update 19.03.11 ... update mgdb latest	2019-03-10 22:56:30 -07:00
Kurt	e0ca0ac1f4	Add decoration / unown puzzle flags ... UnlockAllDecorations already exists in SAV2.cs , but expose these in the GUI with names	2019-03-09 23:13:07 -08:00
Kurt	e8a5a55323	Add union/berry crush stat ids	2019-03-09 10:26:43 -08:00
Kurt	88e2bce495	Sync gs en flags ... match zh/ja	2019-03-09 00:16:16 -08:00
Kurt	0d5ee9489b	Fix memcard sav cloning ... Closes #2267 , Thanks @PMArkive && @Subject21J !	2019-03-07 18:05:55 -08:00
Kurt	bd00680545	Fix incorrect block index ref ... https://github.com/kwsch/PKHeX/issues/2267 Still doesn't fix the underlying issue	2019-03-07 17:30:50 -08:00
Kurt	ee787a0f71	Fix HoF size check ... now matches the code in ChecksumsValid (< instead of <=)	2019-03-07 15:45:51 -08:00
Kurt	9b783dd047	Unban mankey/machop shiny pgo transfers ... https://pokemongolive.com/en/post/battleshowdown2019/ Mar. 5, 2019, at 1:00 p.m. PST (GMT −8) to Mar. 12, 2019, at 1:00 p.m. PDT (GMT −7)	2019-03-05 23:09:39 -08:00
Kurt	61bf82e2bd	Add gs event flags ... https://projectpokemon.org/home/forums/topic/49717-pkhex-flag-editing/?tab=comments#comment-240804 via pret repo; looks like 2000 event flags, and 0x100 event consts/work-vals (byte) add more rebattle toggles	2019-03-05 23:06:05 -08:00
Kurt	8d49400b07	Change SecondsTo* from int to uint ... having a year > 2050 can result in a 32bit seconds value (top bit set); instead of being negative, keep it as a 32bit number.	2019-03-05 15:55:26 -08:00
Kurt	bb2c7e22cb	Add HoF checksum verification and saving ... Thanks @av🥑cado#0315 (discord)	2019-03-02 09:16:03 -08:00
Kurt	174f9758a1	Fix gen1 hm index check ... Closes #2266	2019-02-28 10:01:28 -08:00
Kurt	e8ade4dd63	Add swsh placeholders ... no point adding for legality until much closer to game release	2019-02-27 06:37:11 -08:00
Kurt	fb818f203d	Add gb pp/stat calc test ... refer #2265	2019-02-25 17:39:41 -08:00
Russell Jones	2909c4afef	Update _K12.cs	2019-02-26 01:26:19 +00:00
Kurt	51bdd7d67c	Unban shiny rattata & pidgey ... available on pokemon day 2019 https://twitter.com/SerebiiNet/status/1100138566833852421	2019-02-25 17:09:03 -08:00
Kurt	925167bd33	Fix Invalid/Missing Ribbon string format swap ... Thanks TORNADO (discord)	2019-02-24 22:20:02 -08:00
Kurt	28823bd437	Split optional into overload	2019-02-24 22:16:30 -08:00
Kurt	30e36579be	Misc updates ... add more xmldoc revise some comments for clarity redo a little bit of logic for perf rename some methods for better description	2019-02-24 13:57:10 -08:00
Kurt	993bb00a61	Remove powersave unused logic ... unused & deprecated in favor of using cfw (powersaves price >>> ntrboot-b9s flashcart)	2019-02-23 18:02:50 -08:00
Kurt	7ba21c5d8c	Use subsection fetch	2019-02-23 17:59:46 -08:00
Kurt	52dd2d6701	Misc tweaks ... replace linq for Encrypt/Decrypt pkmdata fetch with faster length check & optional resize (Span pls!?) update pk6 comment for why affection is not cleared	2019-02-23 16:05:01 -08:00
Kurt	d792c0d3a0	use u/L ... use 'u' to denote uint values, so that less IL ops are required ~(21->17) in the case of IVs no functional change, just a fun exercise looking at generated IL and finding ways to use less ops	2019-02-23 15:36:26 -08:00
Kurt	5b29e71954	Misc tweaks ... no functional change, just rewrite some logic for better flow fix subform popup count restriction (OwnedForms requires forms to be added/removed manually; it doesn't automatically update) sanitize box names when dumping boxes with separate folders (and bad box names)	2019-02-23 14:58:48 -08:00
Kurt	17f954b4e8	Xmldoc ... Reorder to match parameter order add more xmldoc	2019-02-23 14:57:35 -08:00
Kurt	ca51edbdcf	Change sav.LoadBoxes to return int ... make MysteryGift specific method flexible so that any IEncounterable enumerable can be passed.	2019-02-23 14:37:06 -08:00
Kurt	a339cc9289	Extract pouch manipulation logic ... add overloads for API syntactic sugar make ItemConverter internal again	2019-02-22 22:48:34 -08:00
Kurt	05ba7c519c	Misc simplifications ... removed duplicate sorting GUI logic extract grid fetch method	2019-02-21 23:17:50 -08:00
Kurt	df94afa711	Misc updates ... extract some enums to core, use Enum.GetNames to do string fetch make stamp listbox taller clean up Display*ID setters	2019-02-21 21:54:41 -08:00
Kurt	5f4241063f	Misc verbosity reductions ... hide enum name	2019-02-21 20:44:31 -08:00
Kurt	c9e894a46d	Misc reductions ... hide setters for LegalInfo outside assembly (shouldn't overwrite the stored values) update GenNumber to Gen* if appropriate; GenNumber checks for first Gen* to match, is a little more explicit and quicker than calling twice when checking a range	2019-02-21 20:41:04 -08:00
Kurt	ba65580a8c	Rename parameter names for consistency ... pkm->pk	2019-02-20 22:23:54 -08:00
Kurt	f30b2766cb	Use Heal methods	2019-02-20 22:16:38 -08:00
Kurt	941b1b5c47	Extract some reused logic ... Put the methods in Tables4; kinda breaks the 'only arrays here' rule but they only reference values in this file(partial class).	2019-02-20 22:10:15 -08:00
Kurt	1b221e052c	Add PP Heal method	2019-02-20 22:08:28 -08:00
Kurt	cffa6e681d	Add OT name setter	2019-02-20 21:52:22 -08:00
Kurt	ba6a958a1d	Add xmldoc, make manip not fetch all BoxData	2019-02-20 19:39:49 -08:00
Kurt	d3dd4fb2a5	Track slot modified count on sort/delete/mod ... Sorting will always show multiples of boxcount since it repositions empty slots	2019-02-20 17:59:54 -08:00
Kurt	72ec264f4c	Prevent g7 silvally from learning fire/water pledge ... https://bulbapedia.bulbagarden.net/wiki/Silvally_(Pok%C3%A9mon)#Trivia has the two bitflags set but the game only tutors the first bitflag it sees	2019-02-19 22:57:07 -08:00
Kurt	40963c012a	Add sav3 BP Earned editing ... misc editor, first tab (main)	2019-02-19 20:59:47 -08:00
Kurt	fa4318ae2f	Add gen3 record editing ... in misc edits window	2019-02-19 20:46:58 -08:00
Kurt	fb8aa3bba0	Lowercase parameter	2019-02-19 20:26:20 -08:00
Kurt	a385a8481d	Misc tweak to savefile export ... Use flags to request header/footer in the output gets rid of the DSV/GCI bool arguments	2019-02-18 21:59:57 -08:00
Kurt	726f69240a	Update translations ... no localization for new settings/sort options, just expanding from csharp->english	2019-02-18 19:09:31 -08:00
Kurt	fdc97885c5	Speed up clone detection purge ... override Execute's default behavior to use a HashSet	2019-02-18 17:19:25 -08:00
Kurt	98b21eaaa8	Add clone deletion quick action ... kinda slow, if a save has 900 mons, it has to check 900*900 which is O(n^2), takes a few seconds as opposed to just doing a hashset checking contains, would be O(n) gotta do some fun stuff to make it faster	2019-02-18 17:00:16 -08:00
Kurt	9171055fd4	Add box sort by encounter type ... grabs encounter name and orders by that (Egg/Static/Wild etc)	2019-02-18 15:34:55 -08:00
Kurt	7c3e5aa83c	Make RandomGender a method instead of property ... See pkNX for similar change; the functionality is really *method*	2019-02-17 22:13:40 -08:00
Kurt	258f0f0ad4	Minor refactoring ... clean up some gc logic, no functional changes	2019-02-17 10:42:43 -08:00
Kurt	202f911d45	Tidy up comboitem fetch naming	2019-02-15 11:47:35 -08:00
Kurt	d1f6a5a3ff	Misc clean ... no functional change	2019-02-15 11:46:46 -08:00
Kurt	9c521919e5	Reverse array in place	2019-02-15 11:46:02 -08:00
Kurt	858760fa28	Misc updates ... relocate program language enum test that test case is proper move getcompatible & gettemplate to core remove catch rate changing for pk1 (catchrate editor now used instead)	2019-02-15 00:50:23 -08:00
Kurt	7acdf0d16d	Expose parse results for external consumption	2019-02-14 20:14:46 -08:00
Kurt	3d01617c93	Fix safari unlock ... dat 0 -> o Closes #2262	2019-02-14 18:17:16 -08:00
Kurt	c67b774e1e	use enum to decorate rather than comments	2019-02-14 18:12:25 -08:00
Matt	7538a33c81	Update GO shinies (#2260)	2019-02-14 10:49:37 -08:00
Kurt	e7486e4534	Update gender check ... showdownset now no longer leaks nulls	2019-02-13 15:50:48 -08:00
Kurt	e82b4de657	Misc clean ... replace Friendship control click to match shortcut description (used to do nothing) Remove some duplicate translation strings fix gameselect string formatting apparently systemsounds changed in a recent win10 update, Question is now silent?? Exclamation is now the same as Asterisk (same as Beep?) Use hand instead of Exclamation. only use asterisk for notifications	2019-02-11 22:39:12 -08:00
Kurt	684191772f	Misc refactoring (showdownset null) ... Set default values to prevent any properties from being null extract ClearNickname logic for hot path & reusable method extract item conversion and move to appropriate logic class	2019-02-11 21:49:05 -08:00
Kurt	2498b6bf50	Misc updates ... Simplify unknown gen expression allow mutation of FormIndex if desired	2019-02-10 21:31:27 -08:00
Kurt	304203262d	Add species & ability enumerations ... remove hardcoded 810 in unit test, add ability test too	2019-02-10 21:28:32 -08:00
Kurt	182348526c	Add display TID/SID get/set	2019-02-10 10:31:20 -08:00
Kurt	9715a08342	Fix custom hex parse ... hurr dont write your own parsers Closes #2256	2019-02-10 10:19:05 -08:00
Kurt	a39f917f84	Simplify expression ... ternary with a null check and long method signature is pretty ugly	2019-02-09 23:22:22 -08:00
Kurt	54ba9a0312	Update file->open for pb7 filtering ... add pb7 to pkm extension list, ignore it in gen7 (sm/usum), update gg filtering (allow pb7, not bk7) add comments indicating format source game	2019-02-09 20:33:37 -08:00
Kurt	e96ef76dcd	Add xmldoc ... no code changes	2019-02-09 20:24:38 -08:00
Kurt	48e2bbcfed	Refactor DumpBox to return 1 value ... count < 0 implies an error; values >= 0 can be used to indicate actual dumped count	2019-02-09 20:19:55 -08:00
Kurt	9a93b20515	Minor rework ... use hashset instead of new[] every call precompute empty arr allow criteria input for better gen requests	2019-02-09 20:07:15 -08:00
Kurt	ec1d3069a5	Remove SaveFile dependency for wallpaper data fetch ... reusability++	2019-02-09 20:05:32 -08:00
Kurt	dc5cdc34d7	Remove FieldsInitialized and rename check method	2019-02-09 17:07:44 -08:00
Kurt	cb98c83bd2	Remove references to Stat_HPMax ... use computed value to check if Party Stats are present maybe I want to use Span and stop resizing all pkm arrays to party format years from now idk	2019-02-09 13:17:00 -08:00
Kurt	e79f46673c	Refactoring iencounterable->pkm ... SetPINGA{S}(pk, criteria) -> pid,iv, nature, gender, ability (stats future?) memes aside, this is where criteria data is forced Split N encounterstatic (has fixed PID and special flag) from EncounterStaticPID	2019-02-09 11:37:20 -08:00
Kurt	cda06bc701	Increase custom parse speed ... remove double string replace (now less allocations); only add up values if they're valid numbers. builtin int.Parse throws with "1 2", but users can type stupid stuff like that in the program (so we parse as 12).	2019-02-08 18:29:26 -08:00
Kurt	383d4b7700	"" -> string.Empty ... be explicit that the string is empty rather than possibly missing disallow encrypted export for BK4 (they're not encrypted), removes type check simplify replaceall in showdownset (don't call ReplaceAll 4x, just get valid chars and rebuild) simplify get ribbon sprite name (precompute ToLower and appended values	2019-02-07 21:40:20 -08:00
Kurt	3474d97fb2	Weaken float comparison for weight/height ... ThePunish3D was able to find examples with less precise calcs https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?do=findComment&comment=240188 assuming these were unmodified	2019-02-07 16:57:17 -08:00
Dixon, Evan	8f8e8020b7	Add NuGet metadata	2019-02-07 17:39:15 -06:00
Kurt	59b41937e1	Misc variable name changes ... readability++	2019-02-06 23:28:02 -08:00
Kurt	d03ff30140	Fix ita traded lgpe diglett OT ... ty ThePunish3D! https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?do=findComment&comment=240159	2019-02-05 17:09:47 -08:00
Kurt	a97ae79086	Unban m&m go shinies ... https://twitter.com/SerebiiNet/status/1092892163782991873	2019-02-05 15:33:59 -08:00
Kurt	29253ed636	More cleaning	2019-02-03 20:28:03 -08:00
Kurt	264c7d1cbc	Replace null return val ... Closes #2255	2019-02-03 20:01:56 -08:00
Kurt	893f98d667	Misc clarity ... no functional change make batch editor prefix list readonly	2019-02-03 10:28:33 -08:00
Kurt	2eef523475	Misc clean ... meh	2019-02-02 15:20:08 -08:00
Kurt	f481404503	Misc clean	2019-02-02 10:19:41 -08:00
Kurt	6ed9f979de	Continued refactoring ... removing null results as indicators of no data (c# 8 sooooon)	2019-02-01 23:26:43 -08:00
Kurt	aa022fad40	Misc refactoring ... remove some null usages, return an empty array instead reduce as arg	2019-02-01 23:08:03 -08:00
Kurt	d29f670840	Add QRPK7 to PK7 ... roughly converts the data into a PK7	2019-01-29 21:07:42 -08:00
Kurt	8cfd6d5a63	Expose SetBoxData	2019-01-27 21:57:33 -08:00
Kurt	6353e8d84d	Add special set operation for alph rocksmash ... closes #2253 ty @Subject21J & @ReignOfComputer	2019-01-27 11:08:21 -08:00
PMArkive	5cb93be681	add legendary pokemon to wormhole slots (#2252) ... changed slot numbering from 0-4 to 1-15 fixed drapion's pokedex number in wormhole slot table	2019-01-27 10:40:19 -08:00
Kurt	147b676d8c	Misc api accessibility tweaks ... disable GeneratePKMs from throwing an exception (it's a testing flag, not to leak out if someone wants a debug dll I guess) expose FixedGenderFromBiGender expose ribbon interfaces	2019-01-26 14:48:32 -08:00
Kurt	0b5429ebbc	Relocate wormhole edit logic to separate class ... #2250 make arrays static (only spin up one copy ever)	2019-01-25 19:58:00 -08:00
PMArkive	3f0a5b3ffa	Add USUM Wormhole functions (#2250) ... The current wormhole's shiny flag & pokemon can be changed with these functions. The flags & offsets were found by @PP-theSLAYER https://projectpokemon.org/home/forums/topic/39433-gen-7-save-research-thread/?page=3&tab=comments#comment-239090	2019-01-25 19:52:46 -08:00
Kurt	a7323ef484	Misc updates ... Reuse some code in netutil for fetching stream (provide useragent for all uses) make sav4ranch use dynamicly read offsets to handle both variants (quicker) #2248	2019-01-25 16:51:58 -08:00
PMArkive	194ddb7c18	add offsets & save-size for ranch's platinum update (#2248) ... I don't know yet if the OT offset is the same though	2019-01-25 15:24:01 -08:00
Kurt	7bb3f14e1f	Add wishmkr flag fetch ... rs only thx @PMArkive !	2019-01-22 22:28:30 -08:00
Kurt	c033fe2741	Increase precision for cp/size calc ... still isn't close enough, but removes the usage of decimals for cp calc. redd.it/ahac9i CP calc doesn't flag anything I have that is legal, but the calc is still off by 2 bits at most... whyyyy? Even the same code run in cpp results in the same inaccuracy? Maybe this is some arm64 difference?	2019-01-22 21:08:48 -08:00
Kurt	13c13d5f49	Update 1MB invalid savefile message ... trickles down to memcard, which is still invalid. Use a more generic message if a memcard is the same size as a regular savefile.	2019-01-22 19:32:22 -08:00
Kurt	13090c0ced	misc gen1 updates ... sav1: assign personal table based on (detected/provided) version catchrate editor: allow to use savefile personal remove gb era prompt whenever gb/blank loaded; have it as a setting (can be overridden for VC now). keep allowgbera as autodetect personaltable: track format for debugging purposes/info update translations	2019-01-21 20:06:02 -08:00
Kurt	8652677a79	Misc tweaks ... showdownset: contains char instead of string gameinfo: static readonly array instead of redefining new on update legality: order of operation / value reuse / simplification / comments pkx: compare char instead of single character string header/footer: move assignment into method as an out instead of ref	2019-01-20 21:55:28 -08:00
ShadowMario3	3f759058ce	Update SAV3.cs (#2247) ... Fix PC max item count in RSE	2019-01-16 12:13:58 -08:00
Kurt	53b2ca93b8	Update blank sav3 behavior ... can now be selected & loaded without exception/hassle	2019-01-15 22:14:19 -08:00
Kurt	b6261e57a3	update structure docs	2019-01-15 16:47:54 -08:00
Kurt	ae6010f169	Add ranch r(/w?) support ... not gonna edit the metadata properly handle an irregular sized display box	2019-01-14 21:31:53 -08:00
Kurt	f0d9e3f2e5	Fix encounter link wc6's ... Closes #2244 thanks @kamronbatman & @NinFanBoyFTW !	2019-01-14 18:53:05 -08:00
Kurt	2969a42ad4	add missing ot name check ... Closes #2246, needed to mirror wc7 via this commit but failed 41a3989b53	2019-01-14 18:33:00 -08:00
Kurt	ab33f7123b	add null check for invalid relearn scenarios ... Closes #2245	2019-01-14 16:39:11 -08:00
Kurt	d62a69a6a7	Misc fixes ... Provide gen1/2 gb only version origin fetch for personal/moves ty shadowmario (i assume this fixes things) make listbox use ingame font for special characters 2f6e30bb3c (r31924945) ty @pmarkive	2019-01-13 18:12:31 -08:00
Kurt	41a3989b53	Consolidate encounterlink into mysterygift ... use synthetic wondercards to match link gifts	2019-01-12 23:50:31 -08:00
Kurt	ce11bda416	Update mystery gift database	2019-01-12 23:49:16 -08:00
Kurt	f60926d200	Add slotview stuff ... future implementation	2019-01-12 20:53:50 -08:00
Kurt	4f1375ad6a	Add route 1 to sky location table ... Closes #2241 ty @Ninjistix !	2019-01-12 17:21:57 -08:00
Kurt	b5cf02a933	Add more party related properties/methods	2019-01-12 10:54:38 -08:00
Kurt	ca0e012c5c	Add Heal, make status_condition a pkm property ... also split out battle box slot offset fetch if anyone finds where colo&xd store their status bits, lmk 👍	2019-01-11 22:25:48 -08:00
Kurt	c591d2a69d	Misc updates ... condense some logic	2019-01-11 17:44:51 -08:00
Kurt	ec76bd6b03	Fix ability bit inversion ... one of these was not like the other ty TORNADO (discord)	2019-01-11 08:09:52 -08:00
Kurt	19f49eb4a7	Misc update ... remove duplicate pb7 method (present in _K6); note that the fixed length should not be changed to SIZE_STORED comment out useless assignment	2019-01-09 21:11:14 -08:00
Kurt	e08ecb21c1	Bypass tradeevo check for gen1 if sav gen >= 3 ... Closes #2237	2019-01-09 08:52:56 -08:00
Kurt	3bbde6fc19	Merge branch 'master' of https://github.com/kwsch/PKHeX	2019-01-08 18:35:29 -08:00
Kurt	d85bb76208	Mirror order of operations from pb7 ... see prior commit; this doesn't make any difference since CurrentFriendship isn't being called; but we're just matching the flow. Closes #2235	2019-01-08 18:35:26 -08:00
Kurt	fef80d5a05	Fix pb7 trade logic ... Update handler after friendship update (CurrentHandler needs to update afterwards) Fix argument order (gender & nonpresent region data) #2235 side effect	2019-01-08 18:32:42 -08:00
Kurt	bc8b48eb88	Fix sort writeback for locked slots ... clear flag, update properties #2235	2019-01-08 18:31:14 -08:00
Kurt	6bd0e87ea3	Fix copyto discarding elements ... don't continue; instead seek forward #2235 part 1, need surgery for part 2 (starter/locked prevents writing data to the slot, but the slot can still be swapped)	2019-01-08 16:45:16 -08:00
Mitsuki	3c552cc1e7	Update for Latest Berry Event (#2234) ... Because the Berry are now Released on Gen7, allow Items now on Legality Check: Enigma, Micle, Custap, Jaboca	2019-01-08 06:14:41 -08:00
Kurt	c1fa7d3916	Fix fish slot read ... oops, final slot was dropped Closes #2231	2019-01-07 15:41:20 -08:00
Kurt	f97417fe85	Remove some unused bitflag regions ... cuts down memory footprint by quite a bit (bool[] is 4bytes per bool)	2019-01-06 22:21:25 -08:00
Kurt	c42c019149	Fix split-evolution regression ... Closes #2230 ty @NinFanBoyFTW !	2019-01-06 22:18:14 -08:00
Kurt	1095fd0811	misc alloc reductions ... scan the data to determine the size of the result array prevents list buffer resizing-copy (many times) and the final ToArray()	2019-01-06 21:00:27 -08:00
Kurt	950ddcf9fd	Reduce npclock object size ... 24 bytes per object -> 16 bytes 2,624 objects are made for legality checking; reduces from 73KB to 41KB removing unnecessary clone recreation -> count from 2624 -> 414 (41KB to 6.6KB) yay 10x reduction; not huge in the big picture but a fun exercise	2019-01-06 20:58:57 -08:00
Kurt	2a8b43d9c7	Remove temporary test ... Shadow lock checks were finished; teams with 5 locks are working. Relocate member data to the full team verifier.	2019-01-06 20:58:17 -08:00
Kurt	75202c7a89	Misc updates ... reducing allocations, increasing clarity by removing some magic numbers probably can rewrite some of the evo loading/checking for even less, but good for now.	2019-01-06 16:22:45 -08:00
Kurt	744646e30d	Add gold bottle cap bypass for LGPE ... All IVs are flagged in LGPE even if they're perfect :( Might have to revisit this for future games and if LGPE transfer out and maintain these bad flags (this is bad for inspecting parents before breeding). Closes #2229 , thanks @SteelPhase (report) and @sora10pls (verified)!	2019-01-06 16:21:34 -08:00
Kurt	0cdaae1d51	Update cxd antishiny tracking ... check antishiny rerolls as required, reduce allocations	2019-01-06 01:26:18 -08:00
Kurt	154f122369	Allow changing of default savefile type ... kinda have to restrict these to 'valid' choices; should be enough of a selection->result to be adequate for changing version restart the program after changing the setting; won't take effect until rebooted.	2019-01-05 15:42:20 -08:00
Kurt	9a4f12c279	Misc updates ... rearrange pkm version groups for clear break between twins/siblings/family clear pokelist for sav7b on non-exportable saves (prevents b1s1 from showing markings) rename horohoro (pgo) to non romaji lol, hide daycare/party tabs on nonexportable save remove some unnecessary operations rewrite getallcontrolsoftype to remove ToList() and make generic	2019-01-05 15:40:25 -08:00
Kurt	435c429dfc	Allow colo to be a blank savefile	2019-01-05 15:37:06 -08:00
Kurt	174eb81986	Fix xmldoc comment	2019-01-05 15:36:44 -08:00
Kurt	e028214eab	Update dex form handling for dex4 ... still not sure if it's entirely right, but at least there's no more exceptions https://projectpokemon.org/home/forums/topic/48288-pokedex-error-gen-4/	2019-01-05 12:37:41 -08:00
Kurt	0c9b760470	Move GetIV to pkm, misc simplifications ... remove linq for characteristic calc (get max IV) and others remove some reliance on new[] for iv/ev pk5 replace bitmagic with property get->set copy for cleanliness	2019-01-05 10:51:41 -08:00
Kurt	4dad475fcd	Fix colo lock check regression ... oops; tests pass now	2019-01-04 00:10:44 -08:00
Kurt	7ab42e7cc2	Misc improvements ... remove alloc on gc key advancement; advance keys in place make g6 sizes an explicit comparison instead of new[].Contains replace Any/Count with Array.Find calls (removes linq dependency from savetype detection!)	2019-01-04 00:07:37 -08:00
Kurt	bdcabfa573	Update gen4 save detection ... footer is different for Korean saves; checked JP/EN and they use the 2006 date. Probably the same for everyone-but-KO. Simplify check further, only check the 0x4.... sav as it's the first region saved to. No point wasting time checking the other! a previous commit alluded to general/storage being initialized in different slots e8644280a1 , gonna ignore what was stated as I can't find any proof with the few tests I did today (all init on second, and found no backups from that time)	2019-01-03 23:37:49 -08:00
Kurt	90e5776dbc	Update ereader 0IV detection ... the ereader mons are nature/gender locked too, so unroll a little prior to rechecking the overall team (with ereader mon included). Have to do it this way as a lock can pop if the ereader data matches a prior spread before the prior teammate can be generated.	2019-01-03 21:29:19 -08:00
Kurt	272a29a641	Differentiate DP/Pt Shaymin ... fateful isn't on dp shaymin even though it's an illegal encounter	2019-01-03 17:04:32 -08:00
Kurt	bd6494d8c7	recognize gen12 italian trade OT ... https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?page=3 Thanks ThePunish3D!	2019-01-03 15:47:41 -08:00
Kurt	e99c9a0999	Add pokestock gst/stk (3 & 4) bulk r/w ... ezpz @kamronbatman	2019-01-02 21:56:33 -08:00
Kurt	8c05b9f391	add g3 hall of fame r/w ... no GUI var sav3 = new SAV3(File.ReadAllBytes(path)); var hof = HallFame3Entry.GetEntries(sav3); hof.Dump();	2019-01-02 18:15:29 -08:00
Kurt	81a660c2dc	Update 2019.01.02 ... Update event binaries with latest from the Event Gallery	2019-01-01 20:52:25 -08:00
Kurt	b5f82f6535	Update translations with latest	2019-01-01 20:27:00 -08:00
Kurt	6929b637cc	Misc clean ... refactor some common operations	2019-01-01 20:05:36 -08:00
Kurt	80ef196468	fix info output off by one	2019-01-01 20:05:00 -08:00
Kurt	552e7a1a39	Fix pokewalker pid check for female-only ... pidGender check failed as 0xFE (female only) returned male if pid ended in 0xFE or 0xFF jump out early if the pkm is fixed gender rather than genderless only https://projectpokemon.org/home/forums/topic/48956-pokewalker-happiny-pid-mismatch/ Thanks Taargüs Taargüs!	2019-01-01 20:04:29 -08:00
Kurt	2b5272a395	Simplify gen4 save type detection ... footer identifiers work just fine for any legitimately created save file; I might have had the checksum check code for pokesav blank savefiles dropping support for bad-blanks in favor of a non-negligible speedup is favorable :)	2019-01-01 11:16:31 -08:00
Kurt	7ba2860db8	more block details	2019-01-01 00:57:51 -08:00
Kurt	8129e91694	Add more detailed block offset docs	2018-12-31 22:19:40 -08:00
Kurt	92d633e8ad	Allow IsPokeStar=false	2018-12-31 21:04:13 -08:00
Kurt	5fcd8541ba	Add pokestar studio fame / star stat pk5[0x87] ... how did this get forgotten so easily lol added legality check; eggs can't participate in pokestar studio. not editable from GUI, use ExtraBytes editor. Re-add 0x86 (array was copied from pk4?) and reorder/comment	2018-12-31 21:01:58 -08:00
XxPhoenix1996xX	ede44aaa1b	Update text_Ribbons_es.txt (#2225)	2018-12-31 16:07:34 -08:00
Kurt	6c4fdfa559	Merge pull request #2224 from XxPhoenix1996xX/patch-9 ... Update lang_es.txt	2018-12-31 16:07:22 -08:00
Kurt	758ec7f55b	Update MessageStrings_es.txt (#2223)	2018-12-31 16:07:06 -08:00
XxPhoenix1996xX	fe57789160	Update LegalityCheckStrings_es.txt (#2222)	2018-12-31 16:06:59 -08:00
XxPhoenix1996xX	31b5b4eea4	Update lang_es.txt	2018-12-31 19:30:29 -03:00
XxPhoenix1996xX	f6c9c7b265	Update MessageStrings_es.txt	2018-12-31 18:50:00 -03:00
Kurt	bd56999b20	Increase search flexibility ... add more version fetch methods, add reset method to reset encounter priority #2219	2018-12-30 17:30:57 -08:00
Kurt	2ecd3f1f30	Replace IV3 with FlawlessIVCount ... Other games may vary the flawless IV count so best to have consistent declarations (the vc transfer encounter has 5 or 3 depending if it's a mew/celebi)	2018-12-30 10:33:00 -08:00
Kurt	82eae79823	Remove cosplay fixed IV ... Was added a few months ago https://github.com/kwsch/PKHeX/pull/2117 Game ignores the fixed IVs and instead does 3 flawless IVs	2018-12-30 01:10:53 -08:00
Kurt	bf1a56af9d	Add xmldoc	2018-12-29 23:38:59 -08:00
Kurt	4fcee0ae7a	Move wr7 to mysterygift folder	2018-12-29 23:34:34 -08:00
Kurt	e7531dca30	Add wr7->pkm ... Not sure if one of the 'level' fields is a move ID instead. Pound=1, Level=1 Maybe a Chansey record would shed more light.	2018-12-29 23:33:36 -08:00
Kurt	78ff441e8b	Update iencounterable api with new criteria arg ... rearrange some logic for clearer function (extract some methods)	2018-12-29 22:24:34 -08:00
Kurt	c2422d6927	Misc updates ... possibly gonna update the iencounterable api for criteria check/enforcement, rather than just generating random encounter data.	2018-12-29 22:19:44 -08:00
Kurt	03ad20dd16	Improve card title/filename logic ... mystery gift editor still fails to generate a description (heldItem < 0 -> exception), the fallback behavior is fine I guess.	2018-12-29 22:15:40 -08:00
Kurt	8a33a95974	Add mystery gift record getset ... Mystery Gift button now appears for GG, doesn't work yet	2018-12-29 22:09:59 -08:00
Kurt	f5e3358aaf	Split up WR7 to separate files ... settled on the class name; looks like it'll be roughly readable as a mystery gift so inherit some properties. maybe can get r/w in the mystery gift editor :)	2018-12-29 22:09:27 -08:00
Kurt	71dc944cbd	Add wb7 gift record rw ... another block documented ;) https://projectpokemon.org/docs/gen-7/lets-go-pikachu-eevee-wonder-card-album-r109/ names subject to change	2018-12-29 21:24:38 -08:00
Kurt	6f22599baf	Prevent slot overwriting on bulk import ... https://projectpokemon.org/home/forums/topic/48912-how-to-batch-import-pokemon-boxes-without-erasing-existing-pokemon/	2018-12-28 17:58:13 -08:00
Kurt	3e05e9655e	Store hidden power type	2018-12-28 16:54:01 -08:00
Kurt	d5a8d29088	Misc updates ... reduce some allocs, clearer names/enum usage	2018-12-27 20:24:24 -08:00
Kurt	d90f099a68	Next unoccupied after starting position	2018-12-27 13:10:55 -08:00
Kurt	f9eb1746ea	Add NextOpenBoxSlot fetch for empty slot overwrites ... < 0 is storage full	2018-12-27 01:08:42 -08:00
Kurt	2d75e93ef0	Move encounter matching logic to iencounterable ... generator logic is now clean	2018-12-27 01:00:08 -08:00
Kurt	3481780e06	Add initial sizes ... maximum is always 3; sometimes we know the max size so specify. bcl has default size = 0, which then resizes to 4 on first addition wow such optimization	2018-12-26 22:13:04 -08:00
Kurt	988e71bec5	Remove QRText property ... removes PKM<-QRPKM class dependency fix invalid value oob exception (nature & ability fuzz)	2018-12-26 17:31:23 -08:00
Kurt	950d0a8525	Add nature bounds check & legality ... expand string array check to cast and check against length; batch editor Nature>=25 causes problems in hover tooltips. Previous commit fixed for pb7 stat calcs for invalid natures, pretty sure the actual game is exploitable for stat calcs and invalid natures (bad access), but isn't exploitable as it's only used to retrieve an enum to switch against.	2018-12-25 22:59:52 -08:00
Kurt	9db771c0d5	Split out common 6+ pkm format to abstract class ... Didn't really feel like pulling out the shared structure get/set operations, only the derived properties & overall fixer methods. Should be easier to maintain if any handling updates. Clean up pb7 unused stuff; removes ribbon logic since none are used. c# 8.0 interface defaults can maybe pull out more logic (ex making FixRelearn and relearn moves into an interface); multiple inheritance can be useful as features are added/dropped between generations.	2018-12-25 22:56:32 -08:00
Kurt	69a3272036	Remove fossils from key item (count==1) list ... Closes #2215 can't depend on 'key item' item flag since the game allows you to get multiples	2018-12-25 12:31:13 -08:00
Kurt	2cef99e444	Add setter for pk1/2 Language ... https://projectpokemon.org/home/forums/topic/48873-batch-editor-language-is-not-working/	2018-12-22 14:47:31 -08:00
Kurt	75d2b8d0bc	Split out location bank fetch ... Getting a little congested in one method	2018-12-22 14:45:47 -08:00
Kurt	f7cf96be65	Add version name fetch ... only for pkm game IDs that have already been localized; not game groupings. use version name long description if hide-savefile details is enabled.	2018-12-22 13:16:16 -08:00
Kurt	ec140431c0	Fix box sort for empty locked slot(s)	2018-12-22 13:13:06 -08:00
Kurt	0da3fd2aec	Add resource include references for new fr xlation ... #2206	2018-12-20 20:34:51 -08:00
Ntonio36	2e698d99da	Add French translations for ORAS, BW flags (#2206) ... * Add French ORAS Flags * Add French BW Flags	2018-12-20 20:30:23 -08:00
Kurt	2e6466c132	fix wc6full date set ... Closes #2213	2018-12-20 20:30:01 -08:00
Kurt	24e5f70144	Differentiate colo card key ... Closes #2212	2018-12-20 15:23:57 -08:00
Kurt	2d774ac7cc	Allow dynamic default savefile type load ... Make extrabytes a pkm property (don't mutate array pls) reconfigure startup loading to only initialize after initial load of sav & pkm (using blanks if not provided)	2018-12-19 22:10:32 -08:00
Kurt	d7a501c168	Relocate some logic to interfaces	2018-12-18 17:15:35 -08:00
Kurt	ff649009ca	Misc tweaks ... misc perf adjustments add utility for slot locked check (without box argument, absolute slot index) localize dragdrop strings increase dragdrop file delete delay (dropping files into discord waits until you confirm; 10s gives enough time to hit confirm)	2018-12-17 11:17:19 -08:00
Kurt	22b9da58e2	Add priority setting for yielding possible encs	2018-12-15 21:34:50 -08:00
Kurt	ea07b9636d	Speed up pkm data present check for pk3 format ... see 6dbeb24b6f ensure bad egg flag isn't set, and the species flag is set.	2018-12-15 19:37:19 -08:00
Kurt	269524849e	Fix crystal-only base move case ... Qwilfish has crystal-only move for the encounter, and the encounter is available on G,S,C. Check both origin games always, better to be complete & exhaustive than faster & incorrect :) Thanks Brittany! https://projectpokemon.org/home/forums/topic/48802-bugemerald-eggs-crystal-learnsets/	2018-12-15 15:10:20 -08:00
Kurt	5d5259ddd2	edge case for egg OT name length ... https://projectpokemon.org/home/forums/topic/48802-bugemerald-eggs-crystal-learnsets/	2018-12-14 23:30:21 -08:00
Kurt	6dbeb24b6f	Clarify mystery flags ... thanks pret! 0ad332124e/include/pokemon.h (L277-L279)	2018-12-14 23:26:46 -08:00
Kurt	fb10a1f983	add size rating indications when viewing pkm data	2018-12-13 21:10:38 -08:00
Kurt	fc65a65fd9	Add go random IVs method ... https://projectpokemon.org/home/forums/topic/48779-go-park-melmetal/	2018-12-12 18:06:39 -08:00
Kurt	96ec0ff28b	Fix broken tests ... some gen6 cards have bad data? trickled out to tests which failed to generate a celebi revert to old code, add in some year-set safety checks	2018-12-12 18:00:26 -08:00
Kurt	f6da84b699	add batch editor cp/h/w suggest routes ... https://projectpokemon.org/home/forums/topic/48773-problem-with-lets-go-pikachueevee-batch-editor/	2018-12-11 22:27:42 -08:00
Kurt	2c1717a409	Misc updates ... extract programlanguage to enum fix parse fail for settings' version; old syntax fails to parse delete unused file from recent pull	2018-12-10 20:48:21 -08:00
Kurt	efb9b7eba2	Misc cleanup ... removes clickonce logic/reference	2018-12-10 20:32:08 -08:00
Kurt	8a0b9cd88c	Add indication for party/starter slots	2018-12-09 23:18:37 -08:00
Kurt	7054b38e44	Fix bw volcarona spawn flag ... Closes #2201	2018-12-08 10:04:59 -08:00
Kurt	3038c1eedb	Fix pb7 zh string handling ... no remapping ok	2018-12-08 10:02:37 -08:00
Ntonio36	89028b8a41	French Translation update (#2205) ... * translation update * shorten problematic fields	2018-12-08 09:17:59 -08:00
Kurt	d84ceabe93	speculate on unused stat ... there's a value in trainer pokes that gets set to an unused pkm byte this byte is fetched in the stat/cp calc, but is never used (param unused) plans for future? it's right next to friendship in trpoke7b, maybe there might be another stat amp? https://www.serebii.net/magikarpjump/trainerrank.shtml stronger trainer => stronger monz /speculation	2018-12-06 22:58:35 -08:00
Kurt	8a98a89f6e	Add height/weight and float->scalar ... pgo transfer logic disassembly FF 83 02 D1 FC 6F 04 A9 FA 67 05 A9 F8 5F 06 A9	2018-12-06 21:03:33 -08:00
Kurt	eb69e86722	Unban go sandshrew/slash & shiny ... https://twitter.com/serebiinet/status/1070583259875237888?s=21	2018-12-06 07:10:39 -08:00
Kurt	20e3da7e5f	Add pb7 evo check continuation ... oops Closes #2202	2018-12-05 20:55:57 -08:00
Kurt	06d8b6609b	Add outsider evo check for beluga ... Closes #2200	2018-12-05 18:38:05 -08:00
Kurt	71fab815bf	Provide more slot information ... remove lockedslots, store & save all teamslots for sav7 differentiate locked slots from overwrite protected slots by emitting an enum containing info about the slot locked = can't be replaced, period. starter/battleteam = can't be pasted over by bulk-pastes can eventually show more specific sprite layers to denote party indexes/team#/starter	2018-12-04 22:59:28 -08:00
Kurt	4c1232855f	Add getstring method with non-sav data	2018-12-04 22:00:57 -08:00
Kurt	cb8585f423	Minor optimization ... 2d array -> 1d skip copy by cloning instead eliminate %24 (number is 0-31) by duplicating 0-7 as 24-31 dropping a modulo, >1 bounds check, and a half loop unroll should be less cpu cycles :)	2018-12-03 23:12:54 -08:00
Kurt	cc59c3cbe8	Remove variable naming hiding ... new property named Stats update sav7b/pb7 to delete unused handling trainer parameters too	2018-12-03 20:59:48 -08:00
Kurt	1d76d799fd	Add stats get/set and batch editor suggest ... Closes #2196	2018-12-03 20:53:37 -08:00
Kurt	7229ca76f6	Update party stat level on level max mod ... Closes #2194 , pb7 are always stored in party format -- also PK1/2 store it in their box format	2018-12-03 15:40:09 -08:00
Kurt	3d7f3caef8	Add status condition prop to all mainline formats ... Closes #2160 , use Batch Editor to modify slots; it's not worth GUI presence as it's only saved for party format mons and is undocumented for anything besides affliction flags	2018-12-02 21:23:10 -08:00
Kurt	ec4088b1fe	Cleanly lay out hgss swarm data	2018-12-02 14:46:17 -08:00
Kurt	77a4691a58	Add remainder of relicanth swarm data ... https://projectpokemon.org/home/forums/topic/48702-bug-ss-relicanth-encounter-error/ Thanks finalevil151!	2018-12-02 14:39:24 -08:00
Kurt	5750eabcc8	Add user protection for moved starters ... Closes #2191	2018-12-02 11:48:44 -08:00
Kurt	2c2e5f60b3	Fix AV message for go transfers ... formatted now	2018-12-02 09:08:42 -08:00
Kurt	c0960fdedb	Fix hyper trained data editing ... pb7 do have hyper training flags; add interface so code works appropriately. Closes #2190	2018-12-02 09:01:35 -08:00
Kurt	9e23ca6efd	Add met location to version sort chain ... Closes #2189	2018-12-02 08:55:32 -08:00
Kurt	8c73259d9b	Update 2018.12.02 ... Update event binaries with latest from the Event Gallery	2018-12-01 22:39:07 -08:00
Kurt	0f01068d0d	Update mystery match for dppt ... off by one	2018-12-01 10:44:38 -08:00
Kurt	8e3e218d54	Update translations	2018-11-30 17:09:40 -08:00
Kurt	add025798f	update control names	2018-11-30 17:05:13 -08:00
Ntonio36	b3b8bf1d6d	French translation update (#2187) ... * French translation update	2018-11-30 15:16:42 -08:00
Kurt	f6508bec5b	Add dex size record editing via pokedex editor ... Closes #2186	2018-11-29 21:40:20 -08:00
Kurt	660b7cc399	update articuno flag ... turns out there's 2, seems like the second is what's used	2018-11-29 19:05:50 -08:00
Kurt	d41197828b	Misc fixes ... apply version after adding (was previously left as Unknown version ID) add Route 9 to rarespawn flying list (thanks @sora10pls )	2018-11-29 16:06:25 -08:00
Kurt	35a85670b3	Set height/weight dex values ... Closes #2167 Based off sub_71001D16A0 with shortcut modifications: * code marks new entries for evolution processing later using the low bit (hence the << 1); in save files I can't see any bits set, but I can't see anywhere in the code that DOESNT set this bit. Thus the assumption of post-processing. As noted in gameplay, a new capture doesn't set Min and Max; it only sets it if it is above the usual sizing values. Megas apparently don't set until seen in battle, so don't worry about setting the other forme based indexes.	2018-11-27 22:05:36 -08:00
Kurt	15b6ef0597	Increment wild encounter count on add capture	2018-11-27 08:53:56 -08:00
Kurt	20c42a0f01	re-add colo valid override ... Closes #2161 ; can't figure out xd one	2018-11-26 19:24:49 -08:00
Kurt	085a6e2a2b	Misc cxd format updates ... fix friendship for xk3 fix colo fateful read	2018-11-26 19:21:48 -08:00
Kurt	76a2e4f527	Add AltForm parameter to exp/level fetch ... Starter Pikachu & Eevee have different growth rates than their base forms (seriously WHY?) remove old api surface in PKX as a breaking change as adding the parameter is necessary.	2018-11-26 16:55:16 -08:00
Kurt	5ca597d44b	Add height scalar classification	2018-11-25 19:46:32 -08:00
Kurt	5f0d1d423b	Disallow volt tackle tutor for pb7	2018-11-25 19:44:19 -08:00
Kurt	2a51eb1745	Update wb7 def ... AV offsets were incorrect sub_71001C79E0	2018-11-25 15:52:30 -08:00
Kurt	adeaaea0b4	Allow folder import to import mystery gifts & gp1 ... Closes #2176	2018-11-23 12:22:51 -08:00
Kurt	ab4c3fc7ac	Add go park slot delete (&all) ... Closes #2179	2018-11-23 12:15:25 -08:00
Kurt	17b3732a7d	Rework filename / nickname checks ... Closes #2178	2018-11-23 10:31:55 -08:00
Kurt	71f1e6238a	Misc fixes	2018-11-23 10:15:49 -08:00
Kurt	f27816e622	Add party pointer sort ... Pulls party members (and follower index if not already in party?) to the first slot(s) in the (current/all) box.	2018-11-22 23:02:57 -08:00
Kurt	1d27f64235	Allow currentbox to be changed if not overriden ... Now allows modifying/deleting 'current' box.	2018-11-22 10:55:20 -08:00
Kurt	f358c0e4cf	Handle all deviating met location string versions	2018-11-22 10:11:51 -08:00
Kurt	6a62075c47	Fix version check ... Encounter browser entered infinite loop waiting for valid version	2018-11-22 10:10:25 -08:00
Kurt	6c0ad30b9a	Add gp1-pb7 conversion ... Add drop to pkmeditor & drop to saveditor	2018-11-21 20:48:55 -08:00
Kurt	9cf46d5bcb	Add CP and Date to GP1 properties ... thanks theslayer	2018-11-21 15:25:50 -08:00
Kurt	cfbdb7c26c	Add parameter-less constructors ... Removes null check for hot path where data is actually provided	2018-11-21 14:15:48 -08:00
Kurt	95776d8520	Set default savefile to gg	2018-11-21 13:51:26 -08:00
Kurt	03dd61bc58	Reset CP on common modifications	2018-11-21 12:31:05 -08:00
Kurt	58080f36c9	Add WB7 and legality detection logic ... Derived from WC7 with minor alterations (dynamic OT/Nickname which is stored in the Full data). Since the 0x108 is not stored in the save file, just keep the full data around.	2018-11-21 12:24:41 -08:00
Kurt	0cc82edc48	Reset CP on import	2018-11-20 23:57:38 -08:00
Kurt	0ebfb38717	Add Route 20 to sky encounter rarespawn list ... Thanks @ReignOfComputer !	2018-11-20 23:00:16 -08:00
Kurt	eb6e3fbbe9	Don't reset friendship, only for this format ... Friendship affects stats, keep current friendship when updating the trainer.	2018-11-20 19:15:38 -08:00
Kurt	7bd3bfc52e	Update rarespawn restrictions for birds	2018-11-20 13:38:49 -08:00
Kurt	3e711acd05	Disallow egg moves in suggestions for cxd/gg encs ... https://projectpokemon.org/home/forums/topic/48547-remove-eggmoves-from-green-learnables-move-in-lets-go/	2018-11-20 13:38:05 -08:00
Kurt	916ac84a98	Force clear EVs on showdown import pb7 ... Closes #2173	2018-11-19 18:26:46 -08:00
Kurt	ec7fc8e2f0	Fix maxgameID for pkm reference ... threw a snag in pkm generator since it doesn't reference savefile max	2018-11-19 16:15:09 -08:00
Kurt	ba1a7c2bcf	Fix broken tests ... rework getblank for version specific	2018-11-19 16:14:49 -08:00
Kurt	4022d7fea9	Add check for invalid pgo shiny transfer ... Thanks @sora10pls !	2018-11-19 13:07:21 -08:00
Kurt	3841df1234	Temp workaround for cp calc precision ... float -> decimal https://projectpokemon.org/home/forums/topic/48524-cp-height-weight-calculations/	2018-11-18 23:14:08 -08:00
Kurt	70fe7f58ee	Remove eevee, revert porygon	2018-11-18 20:39:15 -08:00
Kurt	34f8a71ad0	Always writeback pointer data ... User sort isn't tracked, and reorganizes pointers. Set it back always, no harm as values should always be sensical. Closes #2171	2018-11-18 20:32:55 -08:00
Kurt	67cc6bdead	Account for wild catch combo/lure level boost ... Route 4 sandshrew captured at level 13 (12 is max) +1 for now, not sure if it can go higher	2018-11-18 16:17:39 -08:00
Matt	04de361792	Update GG flag names (#2169) ... * Update GG flag names	2018-11-18 16:07:44 -08:00
Kurt	65febae125	Clamp max CP at 10k ... ingame max is 10k	2018-11-18 15:32:47 -08:00
Kurt	b818aff48a	Remove evo tree sanitization ... Evo data doesn't provide evolution values for these, fortunately.	2018-11-18 15:25:03 -08:00
Kurt	a1cc1a95c2	Fix species fetch, add altform ... Thanks theSLAYER!	2018-11-18 13:54:47 -08:00
Kurt	17348c1808	Add bird rare spawns	2018-11-18 10:36:28 -08:00
Kurt	1c0b2488ef	Update lapras/porygon gift locationIDs ... Thanks Asia81!	2018-11-18 09:41:52 -08:00
Kurt	c268d5ad05	Set party format values always	2018-11-17 19:42:48 -08:00
Kurt	edce01a857	More strict egg nickname length check ... only fishy if it was traded & within bounds	2018-11-17 18:29:05 -08:00
Kurt	029e0e0a08	Manually add rare slot locations ... placeholder; hopefully this isn't permanent	2018-11-17 15:12:32 -08:00
Kurt	cff1ec68fd	Update filter ... savedata.bin, not extensionless cosmetic fix for the dialog window Closes #2166	2018-11-16 22:17:18 -08:00
Kurt	d3534781db	Allow premier ball for captures	2018-11-16 18:59:18 -08:00
Kurt	1c26c7713f	Fix starter bypass ... lol oops, hotfix inc	2018-11-16 18:17:01 -08:00
Kurt	e619ba41fe	Update 18.11.16 ... Update event binaries with latest from the Event Gallery	2018-11-16 17:53:44 -08:00
Kurt	013bc70ed9	Add more pb7 legality checks ... can give nicknames to chinese mons now! Encoding looks the same @wwwwwwzx :)	2018-11-16 17:42:50 -08:00
Kurt	a2eef9deae	Misc fixes ... it is version exclusive; fix magikarp speed IV	2018-11-16 16:44:25 -08:00
Kurt	43ffde0918	Differentiate past gen moves with same names ... Not sure if there'll be ones for other languages, hopefully not. dupe checker: var langs = new string[] {"en", "ja", "ko", "es", "it", "de", "fr", "zh"}; foreach (var l in langs) { var names = new GameStrings(l).itemlist; var dupe = names .Select((z, i) => new {Index = i, Value = z}) .GroupBy(z => z.Value) .Where(z => z.Key != "???") .Where(z => z.Key != "？？？") .Where(z => z.Key != "(?)") .Where(z => z.Count() >= 2) .ToArray(); if (dupe.Length == 0) continue; l.Dump(); dupe.Dump(); }	2018-11-16 15:15:42 -08:00
Kurt	ea4d9861c8	Disallow starter friendship move in learnset ... Joycon shake only, never actually in moveset	2018-11-16 14:56:20 -08:00
Kurt	720e04ff91	Allow 7b trades to be shiny ... remove the todo, thanks twittersphere remove version exclusivity for puppycat (can be done on either ver)	2018-11-16 14:20:06 -08:00
Kurt	dae4a0a0ae	Add EV/AV verification for pb7	2018-11-16 14:19:24 -08:00
Kurt	7da46623b8	Ignore ball check for invalid encounters ... Defaulting to pokeball isn't entirely appropriate	2018-11-15 18:40:08 -08:00
Kurt	ed5abbd686	Add puppycat NPC location ... Thanks (twitter) thelostdogg!	2018-11-15 18:39:30 -08:00
Kurt	95c5ce08d5	Fix movepool suggestion for go transfers ... needed dict references	2018-11-15 17:37:25 -08:00
Kurt	5652e76728	Split go entities and go storage, rename classes	2018-11-15 17:36:29 -08:00
Kurt	94b924fdfc	Add ingame trade IVs and random AV notes ... exclusive maximum, not inclusive	2018-11-15 17:35:34 -08:00
Kurt	93ff395875	Add more succinct go park IV check string	2018-11-15 17:35:11 -08:00
Kurt	43a9d4eb99	Add gg evolution tree ... turns out it was totally needed; am glad I didn't do the silly stuff of past gen evo tables (gen6/7 is just raw evo data)	2018-11-15 17:34:54 -08:00
Kurt	22063d3907	Add ingame trade met locations	2018-11-14 23:04:40 -08:00
Kurt	6a0a6aa82a	Add methods for 7b quirks ... nidoran m/f when sanitized with the old way show the gender symbols as '?'	2018-11-14 22:51:53 -08:00
Kurt	bf9344087e	Update slot storage compression algo ... now iterates for all boxes, and restores to the correct offset at the end update direct offset pointers to box specific (so that it can work on gen3 rsefrlg saves if ever used on them).	2018-11-14 22:33:30 -08:00
Kurt	644fa4e929	Call slot compression ... Doesn't work correctly (data shifted down still persists)	2018-11-14 22:20:59 -08:00
Kurt	1feecef874	Add go park summarizer	2018-11-14 22:02:01 -08:00
Kurt	fc44022836	Add gopkm block/abstraction	2018-11-14 19:34:21 -08:00
Kurt	a64d08e7e9	Add GO transfer IV verification	2018-11-14 18:25:43 -08:00
Kurt	830c2cbb29	Add GO encounter area/slots ... Level ranges per species TBD	2018-11-14 17:40:41 -08:00
Kurt	adb6b345be	Treat GameVersion.GO like other GG vers	2018-11-14 17:40:11 -08:00
Kurt	0b9b0d5317	Add bulbasaur candy to valid candies ... oops	2018-11-14 17:06:13 -08:00
Kurt	7abe0c8a9e	Add candy pouch type ... reusing free space icon hides the give all button; just add another sprite.	2018-11-13 20:46:48 -08:00
Kurt	1f985d8112	Remove unnecessary/incorrect flags ... copypaste from sm lol uops	2018-11-13 20:46:03 -08:00
Kurt	2fb698805d	Use latest personal table as master	2018-11-13 19:20:37 -08:00
Kurt	181e75818c	Use agreed upon lgpe starter forme name ... Thanks @Marty-D !	2018-11-13 19:20:21 -08:00
Kurt	24c541eeef	Get savefile-context sensitive pkm ... Generating a IEncounterable -> SAV for pb7 can't start with pk7	2018-11-13 19:19:20 -08:00
Kurt	13e1debe3e	Add sav7b object & detection util	2018-11-13 19:18:29 -08:00
Kurt	f62e3f43b3	Add eventwork editing abstractions	2018-11-13 19:18:04 -08:00
Kurt	5f456d705c	Add misc setup objects	2018-11-13 19:16:14 -08:00
Kurt	025a290bc9	Update saveblock template for stored offset fetch	2018-11-13 19:15:27 -08:00
Kurt	486445897e	Add 7b inventory r/w object	2018-11-13 19:15:11 -08:00
Kurt	707f7b5893	Fix displayed dex index for g7 ... off by 1 starting with formes	2018-11-13 19:14:42 -08:00
Kurt	49c4043e19	Update dex abstractions, add gg dex	2018-11-13 19:14:23 -08:00
Kurt	5f9afe83d6	Add pb7 sorting methods	2018-11-13 19:10:43 -08:00
Kurt	28fec9882b	Add pkm variant for beluga	2018-11-13 19:10:31 -08:00
Kurt	f11fa8752c	Use pkm format specific evolutions, gg deviations ... GG has slightly different evos from usum, don't bother adding a new binary.	2018-11-13 19:04:58 -08:00
Kurt	1adbc270ce	Scrub unused data ... empty movesets, empty tmhm bool IsInvalid(int x) { int[] banned = {918, 933, 959, 960, 961,962,963,964,965}; if (banned.Contains(x)) return true; var index = baseForms[x]; if ((x > 151 && x < 808)) return true; if ((index > 151 && index < 808)) return true; return false; }	2018-11-12 18:58:02 -08:00
Kurt	6495dc41af	Add move/enc/loc references	2018-11-11 22:49:17 -08:00
Kurt	ac314fe0d7	add dumped encounters/levelup moves ... waza_oboe was lz4 compressed (gfpak), encounters were in a flatbuffer	2018-11-11 22:46:56 -08:00
Kurt	5abbe6dceb	Add fetching for lgpe encounters (legality checks)	2018-11-11 22:46:03 -08:00
Kurt	101149eb2e	Skip eggs for gg (like cxd)	2018-11-11 14:19:02 -08:00
Kurt	9d2be1da9f	Add beginnings for 7b encounter asset fetch	2018-11-11 13:12:24 -08:00
Kurt	00af735afd	Add personal table for gg	2018-11-11 13:11:07 -08:00
Kurt	1827b32d8f	Add init function for wc7 gg files ... pretty sure these will pop up soon as the pball plus doesn't send the mew itself	2018-11-11 13:09:04 -08:00
Kurt	5ddf6f62ce	Add eventflag notes ... there's some "AHTB" files which contain the internal enum names; dump out a few that seem useful note they come from different tables, will need to figure out spacing & if their order is absolute or uses that weird hash in front???	2018-11-10 21:53:25 -08:00
Kurt	f38c46f5ec	Misc updates	2018-11-10 21:07:31 -08:00
Kurt	010134f6ff	Add references for GG tutoring ... Only pikachu/eevee forms so far, probably none else	2018-11-10 21:04:48 -08:00
Kurt	98ebf4c5cb	Add sort pointer repointing ... LGPE uses a list of pkm for boxes, and has pointers indicating where each party member is at need some logic for handling the sorting. Had suspected this a while back so this pre-work came in handy (untested tho) make eventflags offset ptr virtual, I might end up doing things differently for event flags	2018-11-10 21:04:24 -08:00
Kurt	73ee5e5afd	Add personal info structure update changes ... One field added to indicate the GO species or whatever; the 891/892 meltan values match here. Might not be only for GO species translation, might be for fetching models idk	2018-11-10 20:59:55 -08:00
Kurt	94c8b348c8	Add legal tables for gg ... field_pocket.dat ez pouch indexes	2018-11-10 20:58:41 -08:00
Kurt	e6a9014243	Add text dumps from GG	2018-11-10 20:25:26 -08:00
Kurt	113eb550d4	Add IAwakened interface for future PB7 format	2018-11-10 20:21:36 -08:00
Kurt	453f43edd8	Allow shiny xd duking gifts ... https://projectpokemon.org/home/forums/topic/48279-issue-with-ribbon-legality-shiny-dukings-and-japanese-text/	2018-11-08 18:58:52 -08:00
Evan Dixon	9c87ad2977	Port tests to .Net Core (#2156) ... * Rewrite tests with XUnit and .Net Core * Add better "because" message * Skipping test that was not ready & convert the fact to a theory * Tweak casing * Convert select date tests to theories * Make the GetStringList load lock safer	2018-11-06 15:25:35 -08:00
Kurt	d5c22b1e51	Add gen3 wc3 fixed OT egg length case ... unhatched egg: https://projectpokemon.org/home/forums/topic/48226-pichu-event-ilegal/	2018-11-03 12:44:03 -07:00
Kurt	daf41da91b	Add more pokewalker moves ... Thanks theSlayer!	2018-11-03 12:42:11 -07:00
Admiral-Fish	69b6ea57a3	More nature lock data (#2154) ... * Fix lock data Don't have data on Speal phenac, Spheal post, and Ursaring from colo so can't verify that. * Fix e-reader data	2018-11-01 22:38:33 -07:00
Kurt	fe989d48fe	Misc prep updates ... Update comments / xmldoc Add a savefile storage compressor (ie array[] with empty interstitials -> list); return true if the compression moved anything (repopulate views), and the count of occupied slots in the list. Add saveblock base class; I haven't really liked how SAV6/7 do all the logic; I'll still expose properties that will then point to a saveblock. Cuts down clutter. Add template Dex manipulator, with gen6/7 implementations Speculate sequential gp/ge gameversion IDs	2018-11-01 15:38:09 -07:00
Kurt	b53cc1b7f8	Merge branch 'master' of https://github.com/kwsch/PKHeX	2018-11-01 15:20:45 -07:00
Kurt	43d20581e4	Update some string resources ... In anticipation of 2wks from now, might as well get some easy tedious stuff out of the way	2018-11-01 15:18:33 -07:00
Admiral-Fish	6a5ee7bf6d	Fix Electabuzz data (#2151)	2018-10-31 23:16:13 -07:00
Kurt	f709448220	Update 18.11.01 ... Update event binaries with latest from the Event Gallery	2018-10-31 14:08:58 -07:00
Kurt	8f9cc6cd7e	Fix xmldoc ampersands	2018-10-31 13:52:09 -07:00
Kurt	7a021781e0	Add xmldoc, misc fixes ... Fix compile error (lol github editing) Add XD check CPU-PSV for nonshiny. rename l->current for clearer intent	2018-10-30 17:45:21 -07:00
Kurt	bc788beef0	Fix spelling mistake in var name ... Unused after assignment, but if I rework the validation check to return the teamlock result instead of a bool I can spit out the Species-PID generated list as extra info. Helps identify the as-generated conditions if there are multiple teamlocks possible for an encounter (multiple shadow mons, seen vs unseen).	2018-10-30 09:21:32 -07:00
Kurt	908c98b876	Switch lock checks to newer more complete check obj ... Now accounts for the shiny locks & associated restrictions, abusing the recursion by setting & unsetting the required CPU Trainer's shiny value. Repoint all test methods to use the new obj methods	2018-10-29 22:49:04 -07:00
Kurt	ef16e7037a	Add lock check result object ... A lot of internal information is nice to have saved; create a copy of the static class's logic and pepper in some state variables (Required CPU Shiny Value) to account for the weird edge cases. Code is essentially the same as the static methods, except for more fleshed out logic in the AllLock interrupt checking and the eventual Trainer checks.	2018-10-29 21:28:22 -07:00
Kurt	b124a6e70d	Extract seedframe to separate file ... soon tm	2018-10-29 21:03:29 -07:00
Kurt	afffaaa43c	Enable full shadow lock checks ... If you find any edge cases (the code does not account for shiny locks yet) pls lmk, would be nice to have confirmed tests :) :)	2018-10-29 19:44:30 -07:00
Kurt	35143630a0	Add ereader locks	2018-10-29 19:43:32 -07:00
Kurt	1b57acc6a7	Check all locks for legality checking ... Single->All	2018-10-28 20:28:56 -07:00
Kurt	a728e97d40	Fix Butterfree lock ... Ninetales is female	2018-10-28 20:28:02 -07:00
Kurt	7c0a74337e	Update shadow lock checks ... Passes all 3 lock3 cases in addition to some bulk checks (VerifyPIDResults). Lock4 has an issue on one; will have to investigate why.	2018-10-28 20:10:35 -07:00
Kurt	4268239c12	Continue work on shadow lock checks ... Now gets count=2 tests working yield return new SeedFrame { FrameID = ctr + (l.Seen ? 5 : 7), PID = pid }; used to be ctr + 6, needs to alternate even-odd all 2 lock cases pass, but didn't make lock3's pass. Something else is still amiss :) break out some classes for the solidified lock objects	2018-10-28 11:15:40 -07:00
Kurt	39f98a4a94	Misc qol updates ... Check max case for level first, then iterate upwards (eliminates inner if) change wc* nature to sbyte (update comparisons, 0xFF too magic-y) use Rand.Next(x) instead of (0, x)	2018-10-27 21:59:31 -07:00
Kurt	ed3699fbb4	Update Ho-Oh mattle check ... More languages than Italian have a rule-breaking name. Rework checks a bit Flag eggs more accurately Update force hatch to move Link Trade met location to Egg Location fix Ho-oh -> Ho-Oh text strings (correctness is key!)	2018-10-27 16:06:06 -07:00
Kurt	a3e7c4837e	Rewrite trade OT/Nick verification, g4 shuckie ... Shuckie in HG is not the same as Shuckie in SS. Use the relatively-recent Nick/OT properties instead of digging through the encounter table & strings. Ends up being slightly faster. Thanks theSlayer! https://projectpokemon.org/home/files/file/3048-kirks-shuckie/?tab=comments#comment-1424	2018-10-27 13:37:03 -07:00
Kurt	ed180f1b5f	Allow traded eggs when checking g6+ receivability ... As noted in the EncounterEgg generator, Gen6+ update the origin game to the OT's when hatched. Thanks Zaskarel!	2018-10-27 09:44:47 -07:00
Kurt	f91a1c1d31	Add gg species / maximum placeholder ... Will eventually have to fill these in during gg update pretty sure they've revealed all the new species; total move/item count still unknown	2018-10-27 09:08:39 -07:00
Kurt	359a529870	Misc updates ... Move some logic around, fix style warnings	2018-10-27 08:53:09 -07:00
Kurt	e8ad1e227f	Update shadow lock table ... Thanks @ijuintekka ! Closes #2148 Will check later for commented out tests that should pass. May end up turning on the first-shadow-lock check feature prior to release.	2018-10-26 11:14:42 -05:00
Kurt	3d0d8fa649	Add first shadow lock check ... Currently toggled off, can be optionally toggled on (I'm not sure that it's perfect? Random save files have stuff flagged since they don't match the lock; will have to investigate later)	2018-10-21 21:07:33 -05:00
Kurt	8c4a17335f	Add first shadow lock test method ... Everything should always pass the first lock check; will add shortly to any cxd encounter checks	2018-10-21 20:55:02 -05:00
Ntonio36	ee3889b184	French translation update (#2147)	2018-10-21 08:27:33 -05:00
Kurt	66f082e4a0	Add shadow lugia sprite ... Closes #2145	2018-10-20 23:05:15 -05:00
Kurt	c0aae6ab78	Add cxd lock check info & begin troubleshooting ... commented out test calls = not working will have to debug in more detail later; the first lock is always working at least. data sourced from https://github.com/ijuintekka/Eligor/blob/master/Eligor/Spread.cs , not sure if it's perfect. can't cleanly condense deviating team appearances as double-shadow leads can't be selectively encountered. didn't feel like modding lockfinder's recursive algo to be smarter.	2018-10-20 21:03:04 -05:00
Kurt	06cca185e4	Add edge case for pidiv kor g4 pichu ... Closes #2144 미케나 pichu 12179/20300	2018-10-19 22:27:18 -05:00
Kurt	93af3e61b7	Add handling for Mt Battle Ho-Oh (italian) edgecase ... https://projectpokemon.org/home/forums/topic/47917-colosseum-italian-ho-oh/ there's no shadow ID, so it can have both the short (transferred back) or full name (never transferred) as CK3 without side effects. allow 10chars in pkmeditor	2018-10-13 08:07:15 -07:00
Kurt	f7f5d78beb	Misc perf tweaks ... hopefully resolves the image corruption issue (dont use unsafe?) remove some linq	2018-10-13 08:02:55 -07:00
Kurt	b7acb7fa1d	Add memory rarity table	2018-10-12 17:45:52 -07:00
Kurt	e8552affca	More gb restriction relocations	2018-10-10 16:32:02 -07:00
Kurt	2db8daa07b	Add specified ability no-hidden check ... ability=0 allowed abil1/2 but not 4; catch that scenario	2018-10-10 16:31:40 -07:00
Kurt	2ad103dd46	Extract gb specific core logic to separate class	2018-10-09 21:07:13 -07:00
Kurt	0a62506e11	Micro optimization ... wow such use length eq to max will always pass	2018-10-09 19:28:18 -07:00
Kurt	b481358e92	Add number count check for OT/nick ... https://projectpokemon.org/home/forums/topic/47850-legality-issue-names-with-multiple-numbers/ let me know if there's any implications for transferred content (name reset on 1-3=>n?)	2018-10-08 17:57:34 -07:00
Kurt	47f20b8c0e	Update fixed ability comparison for 6+ ... 4aa44c90c1 only updated it for gens 3-5 Closes #2136	2018-10-08 15:26:43 -07:00
Kurt	f65bc2e984	Reduce allocations for gen1 move parse ... use shared interfaces	2018-10-07 15:36:32 -07:00
Kurt	4aa44c90c1	Update fixed ability comparison ... ignores <= 0 now	2018-10-07 15:36:04 -07:00
Kurt	fd1009476e	Minor logic simplifications ... reduce size of encountermoves, split into separate object only execute gb movedata adjustments for gb	2018-10-06 19:44:50 -07:00
Kurt	4deb5080d1	Misc tweaks ... rearrange getmove with respect to tutors; verifycurrentmoves was getting tutor moves in levelup extract not-found hint fetch Expose gen5 block objects (so I can play with saves in linqpad)	2018-10-06 18:45:15 -07:00
Kurt	dc839333b7	Add more parse settings ... allows consumers to tweak debatable settings	2018-10-06 13:43:05 -07:00
Kurt	66faa43e03	Add gen6+ fixed ability hot path ... Closes #2135	2018-10-06 11:24:46 -07:00
Kurt	f507ab7081	Misc parse settings reorg ... makes it more centralized for defining parsing settings, maybe can have flags to change severity of certain preferential checks	2018-10-05 19:58:30 -07:00
Kurt	59af7fef35	Remove unnecessary properties	2018-10-05 19:57:45 -07:00
Kurt	ce9d3abbe4	Misc reorganization ... Move logical checks using encounter data out of Core.cs might be possible to excise legality checking objects from Legal/PKHeX.Core so that a 'slimmer' core can be made	2018-10-04 18:52:00 -07:00
Kurt	03a05364ab	Update colo suicune ++ ... location ID was originally added by: afde4514e2 (diff-83a32d69355a64376bc77bd07e338a33R446) I have another save file that uses met location 110 (like this one) so I assume it was originally a copypaste error from Sudowoodo. Change Trade strings to not allocate separate empty arrays.	2018-10-04 08:14:53 -07:00
Kurt	4bbb1f54b9	Change burned tower suicune encounter type ... was initially set by this commit 0e3815b048 field test resulted in Cave/HoO type https://projectpokemon.org/home/files/file/2953-burned-tower-suicune/	2018-10-03 16:46:55 -07:00
Kurt	4fe1a5b4e0	Add more frlg flags ... https://www.pokecommunity.com/showthread.php?t=302347	2018-09-30 21:53:06 -07:00
Kurt	2a2361220d	Add more accurate daycare egg detection ... uses eventflag, different index for each game frlg: https://www.pokecommunity.com/showthread.php?t=302347 "Flag 0x266 is set by the game engine if an Egg is in the Daycare." emerald: https://www.pokecommunity.com/showthread.php?t=330008 "0x86 : Daycare Centre has egg" rs: https://gist.github.com/rboninsegna/a4a63c2b66c42e371a94f860eae55361 " 0x86 Egg ready at Daycare"	2018-09-30 21:27:36 -07:00
Kurt	30851a0059	Add a bunch of useful emerald event flag names ... will show up in editor can toggle overworlds back to visible to rebattle	2018-09-30 21:23:15 -07:00
Kurt	5d6c932353	Spit out move learn generation on verbose ... helps indicate any restrictions on learn source outside of the current format	2018-09-30 11:50:08 -07:00
Kurt	78c7535dea	Fix pk1->pk2 conversion	2018-09-29 21:03:34 -07:00
Kurt	827d7f8fb3	Misc tweaks ... repoint to contains	2018-09-29 13:08:53 -07:00
Kurt	90f1d0cb09	Misc cleanup	2018-09-29 12:22:13 -07:00
Kurt	a3421a881d	bounds check record set ... closes #2129	2018-09-27 21:30:20 -07:00
Kurt	ca0a533779	Add frlg flag toggles from thread	2018-09-27 20:01:34 -07:00
Kurt	10d73d1bf3	Redirect eventflag r/w for frlg ... can't just re-call base.SetEventFlag with an adjusted flag ID since the exception checks max. just override the geteventflag method with a silly adjustment -- we can't be sure if Block2 is immediately after Block2, so just adjust the flag r/w to a different offset&flag when appropriate. fixes r/s badgeflag get/set, oops, meant to modify FRLG's value in the last commit.	2018-09-26 21:05:06 -07:00
Kurt	a38a0fed60	Update event flag index for frlg ... was block2+0x64 8*((0xF80-0xEE0)+0x64) = 0x820 this highlights a critical flaw in event flag reading; it expects the region to be contiguous in the savedata. it's not. that's super bad, and event flag r/w for flags >1280 won't work until I work something out	2018-09-26 20:32:38 -07:00
Kurt	62d8abb69c	Update frlg flag/var offset ... https://www.pokecommunity.com/showthread.php?t=349936 https://projectpokemon.org/home/forums/topic/47715-help-frlg-flags-research/	2018-09-26 20:08:25 -07:00
Kurt	4a81f326eb	Update trade/egg/capture record set ... #2128 it's still an imprecise thing, as ingame gifts aren't counted by either release count isn't tracked, so the number should be roughly >= total box+party count.	2018-09-26 19:06:05 -07:00
Kurt	55de21afc4	Add records when setting to slot ... Closes #2128	2018-09-26 19:00:52 -07:00
Kurt	40a0206a5d	Misc style updates ... whitespace / brackets	2018-09-26 18:56:29 -07:00
Kurt	5760860c8e	Add check for uninitialized save data ... a 512KB NDS save can be 'picked up' as a memory card if it's not initialized; this also rejects the binary in that scenario	2018-09-26 12:42:39 -07:00
Kurt	13bcc4bdc7	Add more enum values ... pr video stuff is meh, anyone can contribute that	2018-09-25 16:33:11 -07:00
Kurt	a7f02bf27b	Enumerate some trainer appearance values ... thanks @sora10pls for gathering resources	2018-09-24 21:20:55 -07:00
Kurt	4ac1cccaa1	Move fashion to another folder ... incoming enums	2018-09-24 19:44:12 -07:00
Kurt	e0e628844f	Update copyto protection ... skip over write protected slots (locked/team), may eventually weaken the GUI to allow modding boxdata with locked slots (which will be skipped).	2018-09-24 19:43:59 -07:00
Kurt	164a26e757	Misc reorg + skeleton for slot editor ... SlotChangeManager is pretty glue-y, might eventually shift to this implementation	2018-09-21 21:20:28 -07:00
Kurt	7715d7e14f	Add boolean OrderByCustom overload ... Closes #2125 ; final sorting is skipped as bool only yields two groups instead of many, resulting in a preferentially poor sort result	2018-09-20 17:29:55 -07:00
Kurt	db30fea38c	Remove gsc dodrio trade OT trailing space ... Closes #2126 Rewrite trade OT validation by using the trade's OTs property	2018-09-19 19:09:29 -07:00
Kurt	d5816795bf	Remove split gsc trade levels for tradeevo species ... #2126 Receiving a lower leveled species from GSC will evolve it away from the required species, ruling it unavailable. Receiving a Machoke will evolve it, so can't reuse for Haunter trade	2018-09-19 19:08:10 -07:00
Kurt	39c3a0eea7	Rework sav3 version detect ... Might still be flaky for FRLG, but can now (99.99999999%) determine RS vs E...	2018-09-16 13:57:09 -07:00
Kurt	668b8611d5	Fix sav3 active partition detect logic ... change < to > the lower updated count is the backup partition, not the one to load from Closes #2122 , thanks @FaronBracy !	2018-09-16 12:49:00 -07:00
Kurt	3cd45cf5c4	Continue extracting logic	2018-09-16 12:44:00 -07:00
Kurt	41408a235c	Add filename without extension property ... for encrypting the pkm -> 'ekx'	2018-09-16 10:48:04 -07:00
Kurt	65272d460a	stricter mysterygift references ... results in: - precomputed GetTable() reference - no casting when iterating for matches - no db null checks, as they are initally Array.Empty<T>(); reduces noise a little & slightly faster	2018-09-15 16:22:07 -07:00
Kurt	df321d14b5	Reorder checks ... most common path is now first	2018-09-15 16:13:17 -07:00
Kurt	b280ffcfef	style updates ... should be pretty much it	2018-09-14 22:37:47 -07:00
Kurt	87b270dd17	add more gen7 record labels	2018-09-13 22:06:44 -07:00
Matt	165757d590	Fix Meteorite/Mega Cuff mixup (#2120) ... Meteorite (2) is legal, Mega Cuff is not.	2018-09-12 22:10:13 -07:00
Kurt	ff25e3cbd0	Remove illegal items from legal key items	2018-09-12 21:52:09 -07:00
Kurt	d511fccdb4	Move basement key item ID to illegal group ... no functional change, item is unobtainable but still can be 'give all' and in permitted list	2018-09-12 21:30:24 -07:00
Kurt	9ded3333d0	Correctly identify Basement Key ... welcome back, "Red Scale (HG/SS) (OR/AS)" thanks @sora10pls for finding this	2018-09-12 21:27:25 -07:00
Kurt	9a04109e01	Localize zygarde complete ... form string already there, just repoint	2018-09-12 21:16:14 -07:00
Kurt	930d07c080	Misc simplifications ... reference shared base class reorder arguments to match pk1, remove extra space	2018-09-12 20:55:30 -07:00
Matt	fc91819410	Add XY Magikarp trade IVs (#2117) ... * Add XY Magikarp trade IVs * Add Cosplay Pikachu IVs	2018-09-12 11:02:11 -07:00
Kurt	e77247e652	Fix call order ... new empty party list with empty slots now fills correctly https://projectpokemon.org/home/forums/topic/47453-bug-with-generation-2-party-slot/ Thanks AcroBlade!	2018-09-11 20:33:26 -07:00
Kurt	dad3e59263	update for poipole event ... release has been updated too	2018-09-10 20:04:47 -07:00
Kurt	b20020fbe6	Update 18.09.11 ... Update event binaries with latest from the Event Gallery	2018-09-10 19:10:28 -07:00
Kurt	0c02a0cbbc	Add splitbreed mantine to pastgen alolanoffspring ... thanks kr, beast ball now recognized as legal	2018-09-09 17:19:50 -07:00
Kurt	f444c41ee3	Remove nick req on g5 gigalith trade ... Closes #2114	2018-09-08 10:45:30 -07:00
Kurt	d8c355cf64	use sprite resource name instead of species-form ... Closes #2113	2018-09-07 19:11:22 -07:00
Kurt	316341e140	Misc updates ... Remove unused sav properties Add translatable strings for autodetect SAV error suggestion add speculated gg dex formtable - no eevee forms - increments 1 for pikachu since it already exists in table - stops at mewtwo (no other formed-species available) im currently setting up skeleton stuff for lgpe since we're <70 days from release; by doing some pre-work like prior games I can get a good idea of what needs to be adjusted prior to crunchtime!	2018-09-06 20:35:55 -07:00
Kurt	d02b87a7b2	Expose checkresult properties ... can now check individual strings / identifiers in a LegalityAnalysis object by: var la = new LegalityAnalysis(pkm); var parse = la.Info.Parse; if (parse.Any(z => ReferenceEquals(z.Comment, LegalityCheckStrings.X)) ... should be faster than doing string.Contains	2018-09-05 21:27:52 -07:00
Kurt	1750c69b01	Update pcd version distro check ... some events have fixed version IDs in the gift data https://projectpokemon.org/home/forums/topic/47365-vgc-shiny-milotic-usa-pkhex/	2018-09-05 16:09:30 -07:00
Kurt	189fa5f7b3	Add button to give all seals + illegal ones ... #2112	2018-09-04 15:26:16 -07:00
Kurt	cf3aba4f84	Add gen4 seal data get/set ... closes #2112 adds methods to give/remove all, and get/set to retrieve array or individual.	2018-09-04 15:12:35 -07:00
Kurt	81f6988d3e	Prevent sort/clear reverse on shortcut use ... Closes #2111 by preventing the user error	2018-09-04 15:01:14 -07:00
Kurt	42deb0ad12	Add extra backup locations for savedetect ... Closes #2109 Program boots -> load extra locations rather than constantly fetching. These files won't change location or presence (not an external drive). just store the locations instead of constantly fetching, we already call detect once when loading the form anyway.	2018-09-03 10:40:40 -07:00
Kurt	53216333e6	Misc updates ... extract final pkm manipulation logic from pkm editor add xmldoc to boxmanipulator, add utility class for enum->manip fetching fix xmldoc referencing removed enum member relocate boxmanip overview logic to utility class move SAVPaths file pointer to Main for reuse #2109 , will add to autodetect in a later commit open/save dialog with extra extensions: ignore ones already present	2018-09-03 10:30:35 -07:00
Kurt	493bef75eb	Misc updates ... condense repeated logic extract properties extract reusable methods	2018-09-02 18:02:25 -07:00
Kurt	f57e7bf686	Separate box manipulator to ui-less class ... clear separation of functionality	2018-09-02 11:31:34 -07:00
Kurt	cc20bb38d7	misc updates ... use arrays instead of list when capacity known use enums for const decoration remove unnecessary aliases	2018-09-01 19:55:08 -07:00
Kurt	106a02eedd	Fix infinite loop pk1/2 -> pk<7	2018-09-01 15:09:04 -07:00
Kurt	7e03d1203d	Remove unused legality strings	2018-09-01 14:37:58 -07:00
Kurt	bfc9d99286	Remap legality string files ... need to update exporter to not undo my changes	2018-09-01 14:33:26 -07:00
Kurt	91c37ab573	Update legality check message string style ... V### names weren't enjoyable to work with; use similar verbose style as the program message strings. updating the translation files with the remapped variable names shortly remap list: https://pastebin.com/jybkVDAK	2018-09-01 14:11:12 -07:00
Kurt	45ab331805	Don't remap gen2 item ... https://projectpokemon.org/home/forums/topic/47300-two-more-showdown-importing-errors/ showdown already has format sensitive ID due to pkmconverter format being applied on set load	2018-08-31 15:31:56 -07:00
Kurt	1fe304e78f	Rework mg nick/lang checks ... add common interface https://projectpokemon.org/home/forums/topic/47295-bug-event-golduck-name-not-matching-species/	2018-08-30 18:09:52 -07:00
Kurt	c6e4c39bc5	Fix gen1 single chain for gen2 tradeback scenario ... invalid mon -> make sure array is big enough for later move parsing https://projectpokemon.org/home/forums/topic/47283-unhandled-exception-when-importing-set-from-clipboard-after-opening-gen-i-save-file/	2018-08-29 21:58:44 -07:00
Kurt	ebae14e6ad	Add unnicknamed forced languageID wc7 handling ... https://projectpokemon.org/home/forums/topic/47295-bug-event-golduck-name-not-matching-species/ another edge case	2018-08-29 20:36:32 -07:00
Kurt	6abd60cc5c	Add ball auto suggestion ... click ball sprite/label to cycle through legal balls hold alt to use old behavior (set to pokeball) hold shift to cycle through legal balls randomly (default behavior goes poke->color->poke) want to randomize setting balls? use the ApplyBallLegalRandom method at the end :) can't really get too fancy as only one color is stored in the personal data, pkm aren't one single color.	2018-08-28 21:13:45 -07:00
Kurt	f89d9ca323	Split apart headbutt tree logic ... precompute Index & make readonly when initializing as we use Index at least once when initializing the treesarea	2018-08-28 15:10:08 -07:00
ajtudela	b5089658f7	Update spanish translations (#2106)	2018-08-28 08:04:55 -07:00
Kurt	f74c1e321a	no mo go to yo ... pull goto default into 'when' so other cases continue to default this is a goto free codebase ( ͡° ͜ʖ ͡°)	2018-08-27 20:48:57 -07:00
Kurt	4dc04cb4b9	Add pelago status value check + etc ... 0, [9,19] are set (didn't see 15), but there's also a switch case which references all values 0-19. these values are used by a 80 sbyte array (4*20) in the Resort.cro remove usages of "goto case"	2018-08-27 20:44:26 -07:00
Kurt	102430ebf5	Update trade nickname check ... reorder for simplicity, add test Thanks ThePunish3D!	2018-08-26 18:32:39 -07:00
Kurt	6e41b44047	Add telekensis flag & sprite flags ... next bit on ev yield is for telekenesis immunity 6 bits for color, 2 bits for flags	2018-08-26 17:20:00 -07:00
Kurt	4656909d98	Misc reorg ... use shared class for pk1/2 setnotnicknamed fix extendedeurope values (copypaste from extendedAmericas) move ball out of verifiers, move nature/movetype with ball	2018-08-26 16:29:52 -07:00
Kurt	f7b5a5579d	sync missing content ... yay rename	2018-08-26 11:29:47 -07:00
Kurt	7f87d43c41	Add enum for ball; use in checks ... Increases readability instead of using hex IDs	2018-08-26 11:15:32 -07:00
Kurt	6a225ad091	Add mr mime to usum additions for egg balls	2018-08-26 09:43:11 -07:00
Kurt	9dae7dad67	Misc updates ... move encountertype datasource providing to core fix rerolling EC not updating characteristic remove some repeat logic calls relocate geolocation name fetch to separate class, add tests to ensure functionality, add languageID->country/region fetch method	2018-08-25 17:04:01 -07:00
Kurt	a9f65a4617	add lock for cross thread dictionary manip ... could use concurrentdictionary but after reading some perf drawbacks vs manual locks, just do it manually. regex checking is the real slow part, whatever add some comments to describe	2018-08-25 10:48:37 -07:00
Kurt	5fe9226c62	Ignore fixed language trades for gen4 korean check ... Closes #2103 Thanks @Narithegreat !	2018-08-22 22:36:56 -07:00
Kurt	d40b10f4a4	Remove unused method ... SaveFile already has ModifyBoxes which has better built in checks for locked slots.	2018-08-22 22:35:50 -07:00
Kurt	ab0a792968	Move valid item override to pk1, pk2 uses base ... Closes #2101	2018-08-21 07:47:23 -07:00
Kurt	ebb1e8a704	Update 'cant hold item' message ... #2101	2018-08-21 07:46:55 -07:00
Kurt	19f9765752	Add missing species setter ... Closes #2100	2018-08-21 07:37:15 -07:00
Kurt	29f73993b1	Misc reorg ... simplify gameinfo comments/return move item1->item2 conversion to itemconverter just general upkeep	2018-08-20 22:09:35 -07:00
Kurt	7ccaf8783b	Unban bred HA sableye ... yeah totally genderless https://projectpokemon.org/home/forums/topic/47101-gen-v-hidden-ability-sableye/	2018-08-20 20:08:42 -07:00
Kurt	daf9364fb2	Alphebetize settings ... probably want to switch to a propertygrid later.	2018-08-19 21:25:21 -07:00
Kurt	c7aea9cad2	add option to hide pid/ec ... hides pid & ec in pkmeditor, gamesync & securevalue in saveditor easier to share screenshots/stream without leaking identifying information fix auto-centering of pkmeditor subwindows when a savefile is detected on program load(tab_otmisc isn't initialized and reads an incorrect width)	2018-08-19 18:22:07 -07:00
Kurt	af0b8b2a37	Add egg sprite alternate display + setting ... egg sprites can be a little difficult to see what's underneath (glance value) make the new egg sprite method the new default; adds setting to revert to old behavior adds translation text for the mega rayq control from #2098	2018-08-19 16:45:20 -07:00
Kurt	d307a30cad	misc optimization ... list initial size is 4; oftentimes it's greater, and always padded	2018-08-19 16:26:08 -07:00
Kurt	c0b5d3eef7	Abstract away pk1/pk2 properties to shared class ... some inefficiencies with pk1 altform/iskorean but is much easier to manage	2018-08-19 15:50:15 -07:00
Kurt	7ef5d9e547	Add pk1 current level property party->box setter ... https://projectpokemon.org/home/forums/topic/47086-bug-trades-between-two-saves-1g/?do=findComment&comment=235241 fresh encounters have yet to be boxed and don't have the value; set it whenever setting a Stored slot.	2018-08-19 13:35:20 -07:00
Matt	8c64f378c1	Add Mega Rayquaza unlock to GUI (#2098) ... * Add Mega Rayquaza unlock to GUI	2018-08-19 08:24:59 -07:00
Kurt	a200dc85c7	Add bvid util	2018-08-18 20:10:34 -07:00
Alberto Tudela	58eddd0225	Update spanish translations with new hide savdetail setting	2018-08-18 16:45:39 +02:00
Kurt	633f0e1da9	Extract filetype detection, add xmldoc	2018-08-17 23:23:44 -07:00
Kurt	b526d4657b	rework tile flip check flow, remove goto	2018-08-17 16:22:54 -07:00
Kurt	d7f39ea343	Extract pkm searching to separate classes ... search logic can now be reused by core projects adds option to provide extra filters run at the end (prior to clone check)	2018-08-16 20:06:40 -07:00
Kurt	e366f9a93d	Misc tweaks ... only have one empty forme array object rename method for clarity show version ID for hidden savefile program window titles	2018-08-15 21:15:06 -07:00
Kurt	eec14645ef	Lessen string length severity on egg encounters ... Hatched eggs can have mismatched languages<->OT/Nick restrictions	2018-08-15 15:26:42 -07:00
Kurt	5514530dfb	update OT name edge case ... traded ENG->KOR egg was getting flagged #2094	2018-08-15 15:19:54 -07:00
Kurt	b6de41bfa7	Add OT name max length checks ... Closes #2094	2018-08-15 14:58:55 -07:00
Kurt	bc262a7cdf	Remove Plasma Fists from unsketchable ... Closes #2095 split out unsketchable moves (struggle/chatter) to separate array remove trailing spaces (auto fixed by my visual studio plugin), add space before comment //	2018-08-15 14:52:25 -07:00
Kurt	57c6de2825	Add nickname length check for gen>2 ... Closes #2091	2018-08-14 20:13:15 -07:00
Kurt	75d700c171	Fix sav1 jp load order ... oops	2018-08-14 20:12:10 -07:00
Kurt	f079f62956	Remove fullness/enjoyment check ... Although bank 6->7 deletes the values for these fields, Pokémon Refresh can still reintroduce new values. Closes #2090 , thanks @Lusamine !	2018-08-14 16:45:51 -07:00
Kurt	10f050eb18	Update translations with new hide savdetail setting	2018-08-13 19:40:00 -07:00
Kurt	70a6cd9421	Remove untranslatable content ... sav6 recently added trainer appearance editor, prior commits removed pt translation (only official ingame translations)	2018-08-13 19:24:49 -07:00
Kurt	6edc828cc3	misc style updates	2018-08-12 19:27:11 -07:00
Kurt	d3ec969187	Style updates ... split pcd/pgt add more xmldoc	2018-08-09 21:53:39 -07:00
Kurt	8187606a89	Clarify sav6 boxflag in src ... 7 wallpaper flags (not all used), top bit unlocks box 31 https://projectpokemon.org/home/forums/topic/34466-box-31-is-unlocked-but-not-showing-on-bank-any-ideas/ PCFlags + 2 is just CurrentBox, don't include it anymore.	2018-08-08 22:02:06 -07:00
Kurt	6b62dd29ee	Update xy fashion edits ... different for each gender	2018-08-08 21:27:14 -07:00
Kurt	7403c0f91a	Add more pokewalker moves ... igglybuff wish, happiny heal bell, and the elemental punches to round things out even though they can be tutored https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?do=findComment&comment=234991	2018-08-08 17:35:06 -07:00
Kurt	975759e53c	Update str<->val base32 encoder ... simpler	2018-08-07 16:32:31 -07:00
Kurt	259feae038	re-allow event flag editing on gen1 ... closes #2088	2018-08-07 07:54:14 -07:00
Kurt	421c522eb4	Fix gen1 sav load ... Starter fetches via Offsets, which was null, reorder the init Thanks @Ninjistix ! Closes #2087	2018-08-06 21:29:47 -07:00
Kurt	98f21a12dd	Relocate gen6 trainer stat records to core ... use trainerstat editor control in gen6 editor fill in some details from the disassembly via setrecord usages still slightly fuzzy on some: fureai (based on usum idb name, similar logic) soaring sky counts looks like there's some other usages of the fields which were outside the stat range, throwing an exception when loading to NumericUpDown, added bypass logic Thanks Holla!	2018-08-06 21:27:31 -07:00
Kurt	37e5c9fc69	Add record details for gen6 ... pulled from exefs data	2018-08-06 16:52:43 -07:00
Kurt	48a61a00a2	Relocate record stat id's to core ... can potentially add localization by changing the method of fetching	2018-08-06 16:17:32 -07:00
Kurt	0296f98777	Add offset table for sav1 ... calling Japanese ? X : Y on every single access is too excessive, just compute one layout for each type whenever the first sav1 requires it. could probably reduce the amount of properties by reusing others + shift value; offsets are different due to string lengths being different	2018-08-05 20:27:25 -07:00
Kurt	fc73eee570	Extract PokemonList* to inherited class ... Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little	2018-08-05 17:28:54 -07:00
Kurt	84185dc6c9	misc improvements ... add records class for managing info for trainer records add more b2w2 block docs	2018-08-05 12:39:06 -07:00
Kurt	ca39843046	Length check relearn suggestion ... CLsoes #2086	2018-08-04 17:06:51 -07:00
Kurt	279c9d4665	Fix tradeback detect for gen2->1->2 evolve case ... https://projectpokemon.org/home/forums/topic/46909-certain-gen-i-moves-are-showing-invalid/ Thanks Raptor385!	2018-08-04 13:36:05 -07:00
Kurt	53857df647	Copy addmoves special case to individual fetch ... see prior commits	2018-08-04 10:05:47 -07:00
Kurt	0f63b0a0ee	Allow bw movepool except for kyurem ... workaround provided for kyurem movepool (which is same bw-b2w2) but the AddMoves logic with form != 0 points to the form == 0 data Closes #2085	2018-08-03 07:46:53 -07:00
Kurt	30a614484e	Update STADIUM ot checks again ... jp: 1999 if stadium1, 2000 if stadium2 en: 2000 jp: always same OT en: lowercase if stadium2, uppercase if stadium1 https://projectpokemon.org/home/forums/topic/46893-pkhex-bug-stadium-ot-issue/	2018-08-03 07:38:29 -07:00
Kurt	4103b4d4b0	Update 18.08.03 ... Update event binaries with latest from the Event Gallery	2018-08-02 21:01:17 -07:00
Kurt	1486b7f14a	Misc style & minor tweaks ... Remove move combobox flicker hack (no longer necessary) Add more Array.Empty usages cache mysterygift sizes seal some classes no functionality changes	2018-08-02 20:11:42 -07:00
Kurt	19a897923d	Reference original encounter for sensitive checks ... https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?do=findComment&comment=234360 thanks paf!	2018-08-01 20:39:20 -07:00
Kurt	f4bfdb8311	Remove unnecessary empty array allocations ... yay net 4.6 read more: http://justinvp.com/2015/07/20/array-empty/	2018-08-01 18:30:51 -07:00
Kurt	fe6c071d72	Be more generous on nick parse ... benefits manual-edit users who forget to put a space between nick(species)	2018-08-01 18:28:05 -07:00
Kurt	007ec93d85	Update trade nick check for non-nicknamed ... Closes #2084	2018-07-31 17:27:28 -07:00
Kurt	4c96efb9b7	Update pk2->pk1 party stat transfer logic ... pk1 boxdata stores current level & current hp, which is only present in pk2 party data. if the user drops in pk2(boxdata), the transfer leaves 0 for both values, which isn't correct. detect stat_level to determine if values should be regenerated or not. Thanks HaxAras for finding this :)	2018-07-31 14:29:47 -07:00
Kurt	32b90fab13	Simplify some logic	2018-07-29 21:54:02 -07:00
Kurt	02a6d26e1b	Break apart BAKName into smaller components ... simplifies definition & makes it easier to update bakname usage later	2018-07-29 21:51:45 -07:00
Kurt	f35712fcf2	Extract experience logic to separate file ... add exp bar logic, unused.	2018-07-29 17:43:30 -07:00
Kurt	3fd21db51e	Style & function extracting	2018-07-29 16:39:15 -07:00
Kurt	0de335d52b	Misc reorg	2018-07-29 14:04:16 -07:00
Kurt	b16015e8e5	Split InventoryPouch to inheriting classes	2018-07-29 13:55:07 -07:00
Kurt	d916be1020	Style updates	2018-07-29 13:27:48 -07:00
Kurt	41643a4c86	Use correct language ID for nickname check	2018-07-29 12:47:38 -07:00
Kurt	96484eceb5	Update version logic ... Fixes broken tests (glaceon card can only be received by SM, was getting set to UM).	2018-07-29 11:34:27 -07:00
Kurt	cfa3479a4b	Add egg experience check ... Closes #2083	2018-07-28 18:09:29 -07:00
Kurt	2092d55b23	Update e/fr/lg stats for deoxys formes ... Closes #2082	2018-07-28 09:02:41 -07:00
Kurt	c46924d220	Use wcxfull version/language restriction data ... some cards may permit being recieved on incorrect games some wcxfulls permit games they shouldn't (tapu koko flags permit USUM but games released after the distribution window) lots of wcx lacking restrictions completely tested flagging USUM rockruff & zeraora might be worth discarding MysteryGiftVerifier and instead just using unused fields for prior formats to supply the data.	2018-07-27 22:26:27 -07:00
Kurt	77bd91397a	Update form sizing / es translations ... use some close synonyms (Reiniciar -> Borrar) omit some words (potential / training) to keep layout compact capitalize Equipado to match main window Closes #2080	2018-07-27 17:38:23 -07:00
ajtudela	11ab585368	Big spanish changes (#2081) ... * Update spanish translations	2018-07-27 12:40:30 -07:00
Kurt	3d0a2946eb	Allow only one movepool for BW-B2W2 source ... they're both the same, but bw's pool does not have b2w2 formes Closes #2078	2018-07-26 21:51:11 -07:00
Kurt	c8563a3737	Respacening ... Style guidelines, handle a bunch of files no functional change	2018-07-26 19:34:27 -07:00
Kurt	9551d4e707	Relocate logic to core ... probable/possible lgpe uses similar dex stuff, so best I totally understand it (assuming quirks will be present)	2018-07-26 18:01:16 -07:00
Kurt	d19705f5a9	Fix incorrectly ordered name<->bitindex ... names have sinnoh second not first https://projectpokemon.org/home/forums/topic/46377-invalid-invalid-ribbons-record/	2018-07-26 17:12:27 -07:00
Kurt	75801e22e0	Update egg location -> encounter generating checks ... WasEgg only checks for EncounterEgg valid locations; check for any value instead.	2018-07-26 14:55:49 -07:00
ajtudela	1c05001fb7	Update spanish translations (#2077) ... * Update spanish translations	2018-07-26 07:06:14 -07:00
Kurt	711157f3ea	Refactoring ... Extract trainer pkm origin check to interface extension	2018-07-25 20:40:57 -07:00
Kurt	f0fc4b0693	remove alias'd properties	2018-07-25 19:43:02 -07:00
Kurt	e8644280a1	Update sav4 block detect logic ... #2070 desmume inits a savefile to FFFFFF... others instead init to 00's. check both init states, add IsRangeAll method 5f39118b8a Thanks @Filo97 !	2018-07-25 16:00:52 -07:00
Kurt	609e6b4c43	Add jangmo-o/hakamo-o to dashedspecies group ... importing little cup idk	2018-07-25 15:53:02 -07:00
Kurt	5fbf132615	Add handling for pgt ranger manaphy ... skip out on load if pgt extract pgt pid gen method set gender & PID if rangeregg since PID == 0 not 1. Closes #2075 yay 5k!	2018-07-25 07:34:48 -07:00
Kurt	f0090669bb	Update catch rate related logic ... #2071	2018-07-24 19:33:42 -07:00
Kurt	279f44a645	Simplify GB stat calc, fix pk2->pk1 xfer fainting ... Remove unnecessary floor operation, don't fetch stat arrays for each stat Current HP is a box stat in pk1 format (offset 0x1), which isn't stored in box pk2's. If the hp is zero, set it to the current HP. Thanks HaxAras for the conversion tip!	2018-07-24 16:41:18 -07:00
Kurt	3294805380	Update translations ... Translatable about menu, translatable PKMConverter strings	2018-07-24 15:50:00 -07:00
Kurt	64284eafef	Add pk1/pk2 direct import checks ... dragdrop: check import files from folder: check no other paths convert afaik Closes #2074	2018-07-24 15:49:00 -07:00
Kurt	81355dfaf4	Update translatables for pkm conversion	2018-07-24 15:36:46 -07:00
Archit Date	e52838df37	glow setting (#2073) ... * add PKM glow setting * change setting name for consistency	2018-07-23 19:25:54 -07:00
Kurt	3c4ba0d52b	Misc cleanup	2018-07-22 17:26:19 -07:00
Kurt	b97e967304	Misc cleanup	2018-07-22 17:14:22 -07:00
Kurt	a693ba87ba	Update cosplay sprite handling ... Cosplay are stuck on gen6, cap pikachu can interact with bank; make Cosplay the oddball resource.	2018-07-22 12:06:43 -07:00
Kurt	c9408e6af4	Misc clean	2018-07-22 12:00:03 -07:00
Kurt	abe6ef1be3	Move ribbon verifiers to appropriate folder ... no functional change	2018-07-22 11:50:11 -07:00
Kurt	da839988af	Simplify RBY checksum calc ... utilize unchecked byte overflow remove unnecessary zeroing -- t's immediately after the checksummed region. even if it was included, chk += 0 is still 0.	2018-07-21 19:24:09 -07:00
Kurt	0c5c9bc33c	Misc clean / xmldoc updates ... remove unused label in QR (use window Font) escape & -> &amp; for xmldoc proper style	2018-07-21 19:20:11 -07:00
Kurt	1c49b0681d	Extract dex logic	2018-07-21 11:46:38 -07:00
Kurt	63b9b72a49	Relocate save detection to core ... Environment.GetLogicalDrives is not present in net standard 1.3; relocate code and add it as a parameter	2018-07-21 10:23:15 -07:00
Kurt	0c632604d2	Move files ... Saves now has a similar folder structure to PKM	2018-07-20 21:33:55 -07:00
Kurt	c7175fbdb4	Misc reorg ... bye bye SAVUtil and PKMUtil	2018-07-20 21:32:33 -07:00
Kurt	f27f11bfc8	Clean up pk7/sav6/sav7 simple methods ... extract GetFormDuration to method, remove unused GetIsCompatible specialized variant (there's a generalized version in SAVUtil.cs, IsPKMCompatible -- might do another round of WinForms->Core absorption	2018-07-20 20:25:28 -07:00
Kurt	4b0a2d90b9	Add xmldoc	2018-07-20 20:22:46 -07:00
Kurt	c9abeda508	Update stadium check again ... #2065	2018-07-20 05:57:57 -07:00
Kurt	1ff8ebf777	Misc overload add/use ... Some values are already computed; pass them in to overloads for quicker execution	2018-07-19 19:38:44 -07:00
Kurt	614d2629ce	Remove unnecessary ref passing ... object is already passed byref, don't need to repoint the reference	2018-07-19 18:09:37 -07:00
Kurt	9a91619580	Update vc1 invalid transfer pruning ... Closes #2065 Thanks @WEERSOQUEER ! Single evo species weren't getting flagged in the evolution verification as they early returned (species matched), just move the sanity check before that	2018-07-19 16:42:45 -07:00
Kurt	69e7d49d03	Simplify Stadium OT Check ... TID is always 2000 : #2065	2018-07-19 15:54:34 -07:00
Kurt	ff4ca47ebe	Remove GBEncounterData boxing ... Interfaces implement enough detail, so can simplify extract local methods (likely will be inlined) less obj allocations = faster!	2018-07-18 16:37:21 -07:00
Kurt	1c75093e27	Specify altform for ranch shellos ... 1 not 0 https://projectpokemon.org/home/files/file/336-shellos/?do=findComment&comment=1290&tab=comments	2018-07-18 07:15:46 -07:00
Kurt	01c4ca348f	Allow FolderList to be translated	2018-07-17 21:02:01 -07:00
Kurt	a100488142	add gen12 generator kadabra catch rate case ... https://projectpokemon.org/home/forums/topic/46259-yellow-kadabra/ Thanks Cloud AC ! update misc verifier for catchrate to better indicate for any->nontradeback scenarios	2018-07-17 16:54:23 -07:00
Kurt	fe7fea877b	Replace boolean OrderBy with DeferBy ... orderby consumes the entire input enumerable in 'sorting' the list; since we don't care about the order besides a yes/no, just manage the yield order ourselves. don't bother using this method more than the spot it's in; was a fun exercise but other spots are set up for easier debugging (overall flow is where->deferby->yield), could make things easier to read but meh	2018-07-17 16:28:42 -07:00
Kurt	e4aa16f396	Fill out gen5 hidden ability banlist ... now flags gen5 contrary serperior ;)	2018-07-16 21:53:46 -07:00
Kurt	99c790a4b0	Update File name/path/folder fields ... original file path is not saved with the two listed properties, add FileFolder and relcoate existing FilePath functions to that field move some GetVariantSAV usages to the string method instead of byte[]	2018-07-16 21:00:43 -07:00
Kurt	bdb5aaee36	Ignore mismatch if explicitly permitted by prior check ... Closes #2062	2018-07-16 16:12:19 -07:00
Kurt	7ec1cab9a7	Update gen1/2 trade generator to emit gen1 if match ... Closes #2060	2018-07-16 15:22:40 -07:00
Kurt	f51ac7d1f3	Update translations ... Internal repositioning to match source (auto generated changes)	2018-07-16 15:12:40 -07:00
kang1806	afca1b8145	Update MessageStrings_zh.txt (#2063)	2018-07-16 15:09:01 -07:00
Kurt	9a1695f319	Update 18.07.16 ... Update event binaries with latest from the Event Gallery	2018-07-15 21:44:50 -07:00
Kurt	a81c28f114	Upgrade FolderList to show recent/backups ... sortable grid like the ReportGrid for pkm, can open/browse individual files	2018-07-15 17:48:31 -07:00
Kurt	99673706a0	Rework recent savefile detection ... return a reference to the savefile rather than the path, since a SaveFile has a FilePath property.	2018-07-15 13:35:58 -07:00
Kurt	cc509de83c	Add lgpe properties	2018-07-14 21:55:45 -07:00
Kurt	0f17445ef4	Update gen3 event pidiv method check for eggs ... closes #2057 Thanks @kamronbatman ! (nothing currently implemented uses BACD_U_S)	2018-07-14 20:19:13 -07:00
Kurt	cb80c02011	Check Yellow catchrates when updating species ... https://projectpokemon.org/home/forums/topic/46259-yellow-kadabra/	2018-07-14 18:08:51 -07:00
Kurt	d2eba35504	Update interface parameter names ... sync to previous	2018-07-14 18:08:30 -07:00
Kurt	6c8374f26f	Extract inner sprite building to class ... any romhack maker can replace the behavior with their own builder	2018-07-14 17:53:37 -07:00
Kurt	6b7ba49cba	Remove unnecessary logic ... gamestrings: call but not value used text.cs: use gamestrings method for auto-filtered, now removes korean in Gen3 context	2018-07-14 16:53:14 -07:00
Kurt	8c2b74c149	Refactoring ... max IVs use flawless method directly with 6 IVs specified move color blend/stat calc to ImageUtil move potential string to commonedits expose color properties for pkmeditor don't constantly create/dispose brushes for drawing legal moves	2018-07-14 15:08:14 -07:00
Kurt	baac632218	Enable editing gen1/2 hidden power type	2018-07-14 10:56:11 -07:00
Kurt	625a77589b	Extract geolocation logic to interface ... mixins would be nice but I guess extensions cover this	2018-07-14 10:34:34 -07:00
Kurt	7d1994dc8a	Add xmldoc for public members	2018-07-14 09:55:22 -07:00
Kurt	b039112a1d	Add gen1/2 hidden power setter calc	2018-07-13 20:30:57 -07:00
Kurt	5d20c79568	Add showdownset localization for slot previews ... Localization only for game strings (not Ability/Nature/Stat/etc labels) feels kinda goofy but it works	2018-07-13 19:13:25 -07:00
Kurt	83e61923f7	Add bw/2 jellicent deferral case ... https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/?tab=comments#comment-233860 Thanks paf!	2018-07-13 13:48:27 -07:00
XxPhoenix1996xX	9f2712cf4d	Update text_Mail4_es.txt (#2056)	2018-07-13 08:40:18 -07:00
Kurt	ebed1026cd	Update national dex magic setting ... bulbapedia is wrong, first 4 bytes are info values: 0x0 = dex order (alphabetical, numerical), unused in frlg 0x1 = mode (unused in frlg), regional vs national 0x2 = national magic rse (always set in frlg) 0x3 = national magic frlg (never set in rse) refer to disassembly (pokefirered isn't too helpful, less developed. just compare save files & edit ram!) the other 2 values being set are the eventflag & event const, could use the abstraction for those rather than direct ofs writes	2018-07-12 23:23:36 -07:00
Kurt	d42cc7cacd	Add spinda/unown PID properties	2018-07-12 22:07:44 -07:00
Kurt	98a1677d14	Fix property reference ... oops	2018-07-12 20:36:59 -07:00
Kurt	ea5a981f4a	Add Hidden Power type calculation for pk1/pk2 ... Use format specific for import, with format guess to the current savefile known to pkmconverter.	2018-07-12 18:16:24 -07:00
Kurt	296d1c20ed	Use ITrainerInfo interface for trdata	2018-07-12 18:15:20 -07:00
Kurt	3da4873f94	Bounds check species ID for negative ... certain downstream consumers of the library be doin silly things	2018-07-12 17:09:39 -07:00
Kurt	04765ef411	Add more xmldoc ... Covers all gameversion enum members (whew)	2018-07-12 16:55:24 -07:00
Kurt	d20706dd70	Update xmldoc ... le lenny goes here	2018-07-11 19:19:19 -07:00
Kurt	e4e5018aa7	Extract some methods	2018-07-11 19:13:09 -07:00
Kurt	6816c2de43	Update OT affection check for 3-5 memories ... https://projectpokemon.org/home/forums/topic/46180-oras-transfered-pokemon-invalid-ribbon/ Thanks piplupwater! (there's no other usages of V129)	2018-07-11 17:43:48 -07:00
Kurt	8a83b9bde8	Update manaphy ability check again ... 57250823a8 covered it for format>=6, in 4/5 the abilitynumber is derived from PIDAbility Closes #2052	2018-07-10 21:30:13 -07:00
Kurt	01323c0ee8	Add id7 setters ... can now set TrainerID7 / TrainerSID7 via batch editor	2018-07-10 21:25:03 -07:00
Kurt	7f31fdf874	Simplify string trim ... RemoveRange instead of while {remove last}	2018-07-10 17:54:05 -07:00
Kurt	f8c43d4a06	Rework gen1 trade OT handling ... convert all dictionaries to char-byte instead of string (saves 50KB on compressed dll, lul) update OT string comparison for pre/post transfer specimens Showing "TRAINER" for all languages isn't correct, just show a mapped character Closes #2049 , thanks @egzonqj & @WEERSOQUEER !	2018-07-10 16:45:24 -07:00
Kurt	027d898f3d	Update Yancy Curtis trade OT checks ... Thanks paf! https://projectpokemon.org/home/forums/topic/46143-bug-in-last-update/	2018-07-10 12:37:40 -07:00
Kurt	c8897161b7	Fix gen6 evo tree resize miss ... https://projectpokemon.org/home/forums/topic/46144-a-couple-of-new-problems-in-the-pkhex-version/ Thanks CreamatedReptile2018 !	2018-07-09 22:51:01 -07:00
Kurt	93876d98eb	Fix CanInhabitGen1 comparison ... extracted and forgot to double check the boolean comparison when inverting the return value https://projectpokemon.org/home/forums/topic/46148-bug-gen-1-moves-and-legendaries-incorrectly-flagged-in-gen-2-game/ Thanks Raptor385!	2018-07-09 21:59:38 -07:00
Kurt	d45a8afef2	Remove erroneous chain trim logic ... latter half of the method seems to do everything that is required Closes #2048	2018-07-09 21:26:45 -07:00
Kurt	9a57469ec3	Update shedinja chain handling ... Closes #2045 4ac92b9418 had added it; assuming to undo lvl-1 => lvl for gen3/4. Level Up, Learn Nincada Move, Evolve to Ninjask & spawn Shedinja, then learn any Ninjask Moves. Gen3 reverses the spawn&learnNinjask steps, which is handled separately Thanks @XxPhoenix1996xX !	2018-07-09 20:18:31 -07:00
Kurt	57250823a8	Add ranger manaphy ability check ... PCD != PGT Closes #2044	2018-07-09 17:33:31 -07:00
Kurt	6bb076aecf	Fix mysterygift hidden ability comparison ... Closes #2047	2018-07-09 17:08:26 -07:00
Kurt	d70990f9cc	Fix SOS hidden ability <-> flawless IV count ... 3->2 https://projectpokemon.org/home/forums/topic/46142-two-illegal-pokemon/	2018-07-09 17:02:18 -07:00
XxPhoenix1996xX	3c9b25a662	Update lang_es.txt (#2050) ... * Update lang_es.txt * Update lang_es.txt	2018-07-09 11:54:45 -07:00
Kurt	8b1ec36242	fix volbeat/illumise sport comparison ... #2047	2018-07-09 06:28:29 -07:00
XxPhoenix1996xX	a60d2bd08d	Update MessageStrings_es.txt (#2046)	2018-07-09 06:12:53 -07:00
Kurt	6d0dda1df0	Update 18.07.09 ... Update event binaries with latest from the Event Gallery (surpassed 2.5 million cumulative downloads!)	2018-07-08 21:16:42 -07:00
Kurt	94ad351979	Update translation files ... new release soon -opower6 now fully editable -box export to showdownset added	2018-07-08 18:25:43 -07:00
Kamron Batman	5ecd3b1875	Adds distribution for Negai Boshi Jirachi (#2043) ... * Adds distribution for Negai Boshi Jirachi * Updates negai boshi to have the proper game origins	2018-07-08 16:21:49 -07:00
Kurt	97701787a6	Add sav2 daycare view ... tfw they store full egg data there too -- show that in the sidebar Tested on C & GS (english), assumedly works fine for other languages (based on the disassembly?)	2018-07-08 15:46:37 -07:00
Kurt	3bcda0eb33	Add frlg other daycare slot view ... guess that was easy?	2018-07-08 11:06:39 -07:00
Kurt	1e8dd3c823	Add gen3 daycare offsets ... idc about frlg single mon daycare	2018-07-08 11:00:50 -07:00
Kurt	373b4ffcbb	Add block offset fetch util ... according to the disassembly it all makes more sense; a small block and a large block are stored in RAM util calc helps convert between contiguous section offset to a chunked offset eg: emerald daycare starts at large 0x3030, which converts to chunk4@0x1B0	2018-07-08 09:56:01 -07:00
Kurt	f04bc214ec	Use OT class calc (mod 5) ... remove setter as it's derived from TID's low byte	2018-07-08 09:54:17 -07:00
Kurt	f592be75d1	Add gen3 secret base classes ... don't plan on using them at this time, just an implementation if anyone wants to play with it	2018-07-08 00:26:31 -07:00
Kurt	b745d59552	Rearranging ... group gen3 structures to their own folder	2018-07-07 21:47:29 -07:00
Kurt	0b1ae2ec67	Add pokeblock3 interaction ... no gui but can use core with a rse save file	2018-07-07 21:31:41 -07:00
Kurt	4dcac24f34	Add roamer3 active/level editing	2018-07-07 21:31:07 -07:00
Kurt	ae04218c5f	Update eventflagmax for e/frlg ... globals.h defines as 288 bytes for RS, and 300 for E & FR respectively verified event const vals for Emerald making sense	2018-07-07 18:03:52 -07:00
Kurt	d4c1093dd9	Add RS badge flags ... make logic generic	2018-07-07 17:01:47 -07:00
Kurt	990eb73f8a	Misc simplifications ... recordmax is simplified	2018-07-07 15:38:11 -07:00
Kurt	e46aed4b0b	Relocate bean logic to core	2018-07-07 15:37:47 -07:00
Kurt	e915cd170b	Extract trainer stat to interface / usercontrol	2018-07-07 11:48:03 -07:00
Kurt	2e02ec9719	Refactoring ... Move some logic out of saveditor/subs	2018-07-07 11:20:05 -07:00
Kurt	e588565657	Refactoring ... reduce pk3/ck3/xk3 logic, share AbilityBit property within _K3, and when loading, type check (favored over hardcoding individual load cases) pull some non-gui code from PKMEditor to core/etc for general data fetching	2018-07-06 17:37:07 -07:00
Kurt	fe82fe8eab	Show language name instead of index ... prefer to keep the '0' case as zero	2018-07-06 17:22:56 -07:00
Kurt	e2fd00a27a	Restore while loop ... Yeah forgot that extremely bad RNG rolls (0,0,0,0,0) leaves 510 remaining, and the last EV can't have that much rework loop to be simpler & quicker by checking the last IV for validity only (don't bother keeping it unrolled	2018-07-04 12:23:42 -07:00
Kurt	397de97f3c	Remove excessive references to Util.Rand32() ... all usages besides fetching a 32bit random value should use rand.next remove unnecessary do-while loop for calculating random EVs (always returns 510 in total)	2018-07-04 11:30:43 -07:00
Kurt	326522c76f	Misc simplifications ... cache splitbreed species as another class reduce linq usage in evolution validity check reuse egg hatch method	2018-07-04 09:15:20 -07:00
Kurt	b0990c8a08	Add xmldoc	2018-07-04 08:43:19 -07:00
Kurt	fdc4dd2811	Fix encounter ability comparison ... -1 is the 'no fixed ability parameters defined' Closes #2041 (optimize abilitynumber check for early return)	2018-07-03 18:43:11 -07:00
Kurt	8e950e83b3	Rewrite ability verification ... Closes #2040 , adds test cases: invalid bulbasaur.wc3: hidden ability invalid charmander.pcd: hidden ability valid camerupt: gen3->4 unevolved mismatch valid leafeon: pcd mismatch -> evolved now matching should be much easier to maintain; methods are reused with less overall nesting	2018-07-02 20:34:41 -07:00
Kurt	e495883d87	Reorder marking for speed last ... Closes #2040	2018-07-02 14:37:21 -07:00
Kurt	d11a89d52d	Move relearn required flag to checkmoveresult ... reduce usage for non gen6+ relearn move cases save contains result for later usage instead of recomputing the inverse	2018-07-01 21:34:17 -07:00
Kurt	7f6f7a7bad	Misc simplifications ... reduce nesting (evo.RequiresLevelUp is checked twice, only check once and handle path) compact some methods seal some classes add a little xmldoc to exposed members	2018-07-01 19:55:23 -07:00
Kurt	c40a284174	Misc simplifications / xmldoc	2018-07-01 19:17:37 -07:00
Kurt	3674a11cfe	Misc simplifications ... absorb verifier calls into the parsing methods	2018-07-01 17:07:29 -07:00
Kurt	bc6c361746	Reduce linq usage ... reuse variables instead of re-fetching (pkm.Species) add overload for HashSet<int> contains vs ICollection merge BattleOnly to one hashset	2018-07-01 10:49:11 -07:00
Kurt	e5ac193e8e	Remove unused field ... Encounter used to be used to determine if the original encounter was valid; we now store the encounter object and checking is fast enough -- we don't really care to short-circuit individual verification steps anymore.	2018-07-01 10:15:10 -07:00
Kurt	d477e19cf0	Simplify ball/catchrate lineage checks ... should speed up egg ball checking a bit since we've already computed the original species gen1 catch rate, just move the chain fetch there.	2018-07-01 10:15:10 -07:00
Evan Dixon	8a0a2de7b2	Elaborate on unsupported message (#2038)	2018-07-01 07:37:31 -07:00
Kurt	e4a281b0d9	Generate pgf moves if none present ... Closes #2037 not sure if the cards are hacked, whatever	2018-06-30 21:28:20 -07:00
Kurt	d8c643f9f0	Add plugin initialize order ... wtb c# 8 with default interface values to not break consumers	2018-06-30 15:02:17 -07:00
Kurt	177604e2cb	Refactoring ... Simplify some verifier logic	2018-06-30 15:01:16 -07:00