Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-27 06:20:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

Use min parameter count

Browse source 
PK2 doesn't like getting passed null for the byte[] parameter (rightly
so); don't depend on the src code order having the first constructor
being the one with the least arguments

fix it in pk1/2 so that the first constructor has the least args, anyway
This commit is contained in:
Kurt 2019-03-16 20:04:44 -07:00
parent 8a08d32dff
commit 99baca5f5e
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
PKHeX.Core/PKM/PK1.cs
View file

@ -16,8 +16,8 @@ namespace PKHeX.Core
public override int Format => 1;
public PK1(byte[] decryptedData, bool jp = false) : base(decryptedData, jp) { }
public PK1(bool jp = false) : base(new byte[PKX.SIZE_1PARTY], jp) { }
public PK1(byte[] decryptedData, bool jp = false) : base(decryptedData, jp) { }
public override PKM Clone() => new PK1((byte[])Data.Clone(), Japanese)
{

2
PKHeX.Core/PKM/PK2.cs
View file

@ -15,8 +15,8 @@ namespace PKHeX.Core
public override int Format => 2;
public PK2(byte[] decryptedData, bool jp = false) : base(decryptedData, jp) { }
public PK2(bool jp = false) : base(new byte[PKX.SIZE_2PARTY], jp) { }
public PK2(byte[] decryptedData, bool jp = false) : base(decryptedData, jp) { }
public override PKM Clone() => new PK2((byte[])Data.Clone(), Japanese)
{

2
PKHeX.Core/PKM/Util/PKMConverter.cs
View file

@ -445,7 +445,7 @@ namespace PKHeX.Core
public static PKM GetBlank(Type t)
{
var constructors = t.GetTypeInfo().DeclaredConstructors.Where(z => !z.IsStatic);
var argCount = constructors.First().GetParameters().Length;
var argCount = constructors.Min(z => z.GetParameters().Length);
return (PKM)Activator.CreateInstance(t, new object[argCount]);
}