Aleksey Kladov
e15621482c
Clarify comparison rule
2021-03-03 11:23:05 +03:00
Aleksey Kladov
979c26e1ae
Axe pre-commit
2021-03-01 21:30:21 +03:00
Vincent Esche
c4e2f32d73
Fixed remaining references to AnalysisChange
(now: Change
)
...
(The type was renamed/moved in 8716c4cec3
)
2021-02-28 12:57:41 +01:00
vsrs
5e88436517
Update lsp-extensions.md
2021-02-27 21:07:58 +03:00
azzamsa
ae50b18503
Fix typos
2021-02-20 17:53:19 +07:00
Aleksey Kladov
3f09e3fba6
document offsets
2021-02-16 19:22:09 +03:00
ivan770
13e9d9809a
Remove CodeLensResolveData mention from lsp-extensions.md
2021-02-13 19:36:29 +02:00
ivan770
185da286d2
Moved CodeLens to ide crate
2021-02-13 13:07:47 +02:00
Laurențiu Nicola
8814d1368d
Include a commit log summary in the changelog
2021-02-12 19:53:58 +02:00
bors[bot]
777d936c17
Merge #7653
...
7653: Document config pattern r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-02-12 15:10:50 +00:00
Aleksey Kladov
799810eaaa
Document config pattern
2021-02-12 18:10:16 +03:00
Peter Wischer
f18fc5a0ae
fix nightly warning legacy_derive_helpers
...
see https://github.com/rust-lang/rust/issues/79202
2021-02-12 13:57:38 +01:00
Aleksey Kladov
d932812134
Use track caller in test documentation
2021-02-10 11:26:48 +03:00
Aleksey Kladov
4b1279d0b1
Infra for "unit" benchmarking
2021-02-09 20:25:39 +03:00
Aleksey Kladov
cbebb70313
Add a section on entry points
2021-02-07 10:58:59 +03:00
Erick Tovar
a423a5196c
Fixing architecture image on dark theme
2021-02-07 10:57:39 +03:00
Edwin Cheng
a0475f10d8
Remove redunacny
2021-02-07 12:53:54 +08:00
Edwin Cheng
542e35e397
More information for mbe
2021-02-07 12:51:30 +08:00
Edwin Cheng
504a54b222
Update architecture.md for mbe and proc-macro
2021-02-07 12:31:33 +08:00
Adam Tuck
c2064e8bcf
Update architecture.md
...
Typo
2021-02-06 14:40:23 -08:00
kjeremy
8ff69055b9
Do not overwrite lock file
...
Use `npm ci` instead of `npm install`. `npm install` will overwrite
the lock file if you have a newer npm version than the one that
generated the package-lock.json
2021-02-05 10:57:36 -05:00
Aleksey Kladov
648d99537c
Add howtos
2021-02-05 17:45:14 +03:00
Aleksey Kladov
06aa34cd10
More architecture.md
2021-02-04 13:27:34 +03:00
Kushagra Gupta
b75e85998d
typo fixes
2021-02-03 21:30:42 +05:30
Kushagra Gupta
ed35e516b1
Grammar fixes
...
I think line 235 is still wrong, but I am not sure.
Is the `crated/tt` in line 252 supposed to be `crates/tt`?
2021-02-03 21:05:21 +05:30
Lukas Wirth
f82ce500a9
Fix spelling mistakes in docs/dev
2021-02-03 13:46:51 +01:00
Aleksey Kladov
1008aaae58
Make architecture more informative
...
Call out boundaries and invariants
2021-02-03 14:26:23 +03:00
Aleksey Kladov
283c3b0133
add useless types to the styleguide
2021-02-02 15:41:57 +03:00
Laurențiu Nicola
5e61d62fdc
Explain what to do if a release fails
2021-02-01 16:46:23 +02:00
Edwin Cheng
d069ef60b6
Update lsp-extension.md hash
2021-01-29 01:32:31 +08:00
Edwin Cheng
edcafe7865
Update doc
2021-01-29 01:04:14 +08:00
bors[bot]
fc08fdaf5a
Merge #7457
...
7457: Add no-buffering file logging and wait for a debugger option. r=vsrs a=vsrs
Adds two command line flags: `--no-buffering` and `--wait-dbg`.
Not sure if someone else needs this, but personally I found both flags extremely useful trying to figure out why RA does not work with Visual Studio. Or better to say why Visual Studio does not work with RA.
Co-authored-by: vsrs <vit@conrlab.com>
2021-01-26 22:37:11 +00:00
Aleksey Kladov
d35bda6429
Make always-assert crate reusable
2021-01-26 22:13:42 +03:00
Aleksey Kladov
2be55703d1
Document design label
2021-01-26 14:18:28 +03:00
vsrs
185cd736a6
Add RA_WAIT_DBG and docs
2021-01-25 17:46:03 +03:00
Laurențiu Nicola
f0cffb66b3
Fix typo in style guide
2021-01-25 14:14:43 +02:00
Laurențiu Nicola
83fd639829
Fix RA_LOG example in dev docs
2021-01-25 13:18:24 +02:00
Aleksey Kladov
e54a398bfb
Promote marks
2021-01-22 17:58:00 +03:00
Aleksey Kladov
4c92ef03ac
Style: use the right string
2021-01-22 15:29:31 +03:00
Aleksey Kladov
e5c5c0a040
Include countme
crate to count important data structures.
2021-01-21 19:30:52 +03:00
Aleksey Kladov
74f8201586
Avoid intermediate collections
2021-01-20 14:49:29 +03:00
Aleksey Kladov
724059569b
Don't show runnable suggestions for other files
...
It't be actually great to have these once we have run anything dialog,
but for run the thing at point it makes sense to show a limited set.
2021-01-20 14:30:50 +03:00
Aleksey Kladov
8dc68ecdfc
Introduce more appropriate assertion mechanism
...
rust-analyzer is a long-running program, so we *should* handle assertion
failures.
See also https://www.sqlite.org/assert.html .
2021-01-14 18:25:19 +03:00
Aleksey Kladov
2d0464a6f3
Encourage gifs
2021-01-11 16:29:29 +03:00
Laurențiu Nicola
a7db8abab7
Use T! for bool keywords
2021-01-10 17:47:12 +02:00
Aleksey Kladov
8f994dda68
typo
2021-01-07 20:27:22 +03:00
Aleksey Kladov
5aed769afe
Styleguide readability
2021-01-07 20:11:55 +03:00
Aleksey Kladov
eb710a63ca
Document std::ops
style
2021-01-07 19:27:47 +03:00
bors[bot]
b821264f86
Merge #7195
...
7195: Update remaining serverPath references r=lnicola a=lnicola
Fixes https://github.com/rust-analyzer/rust-analyzer/pull/7156#issuecomment-755487667
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2021-01-07 15:30:23 +00:00
Laurențiu Nicola
56497ce925
Update remaining serverPath references
2021-01-07 17:06:11 +02:00
Kevaundray Wedderburn
72b9a4fbd3
Change <|> to $0 - Rebase
2021-01-07 12:09:23 +00:00
bors[bot]
1cc73d60bb
Merge #7068
...
7068: Add VSCode command to view the hir of a function body r=theotherphil a=theotherphil
Will fix https://github.com/rust-analyzer/rust-analyzer/issues/7061 . Very rough initial version just to work out where I needed to wire everything up.
@matklad would you be happy merging a hir visualiser of some kind? If so, do you have any thoughts on what you'd like it show, and how?
I've spent very little time on this thus far, so I'm fine with throwing away the contents of this PR, but I want to avoid taking the time to make this more polished/interactive/useful only to discover that no-one else has any interest in this functionality.
![image](https://user-images.githubusercontent.com/1974256/103236081-bb58f700-493b-11eb-9d12-55ae1b870f8f.png )
Co-authored-by: Phil Ellison <phil.j.ellison@gmail.com>
2021-01-03 09:03:15 +00:00
Phil Ellison
db53db8046
Address review suggestion, fix tidy tests
2021-01-01 19:25:18 +00:00
Aleksey Kladov
9c0c5f8e37
Improve commit message style
2020-12-28 13:43:07 +03:00
Aleksey Kladov
675390e012
Update docs/dev/README.md
...
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2020-12-16 18:07:21 +03:00
Aleksey Kladov
6e9023c763
Document new permissions
2020-12-16 18:04:24 +03:00
Aleksey Kladov
51f42db1d5
Add #
to canonical test example
2020-12-15 11:49:22 +03:00
Aleksey Kladov
17f236c2b0
Normalize spelling to American English
2020-12-10 17:51:56 +03:00
Daiki Ihara
4f008bf8b2
fix typo of README in dev
2020-12-09 00:30:00 +09:00
Aleksey Kladov
3e00bfce2b
Document statelessness invariant
2020-12-03 18:08:27 +03:00
Jakob Hellermann
7c6c812a74
fix typos in syntax.md
2020-11-17 15:16:52 +01:00
kjeremy
233fdb12ce
Latest LSP 3.16 protocol
...
Pulls in https://github.com/gluon-lang/lsp-types/pull/186
2020-11-16 15:10:13 -05:00
Anatol Liu
b1b7727e04
add open Cargo.toml action
2020-11-12 17:48:07 -08:00
Aleksey Kladov
7d2eb000b0
Switch to upstream protocol for resolving code action
...
Note that we have to maintain custom implementation on the client
side: I don't see how to marry bulitin resolve support with groups and
snippets.
2020-11-10 18:48:46 +01:00
Aleksey Kladov
9b1d4cc8ab
don\t indent tests
2020-11-06 20:29:41 +01:00
Aleksey Kladov
412d6b3db5
Update docs/dev/style.md
...
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-11-02 12:17:34 +01:00
Aleksey Kladov
4318828f21
Document doer object anti-pattern
2020-11-02 12:13:59 +01:00
Laurențiu Nicola
f94d0252b3
Update client install command in dev docs
2020-10-27 09:49:57 +02:00
Adrian Stanciu
5f5b1ffdd1
Update debugging.md
2020-10-22 21:04:09 +03:00
Igor Aleksanov
d718366567
Document change of 'cargo' Runnable kind in lsp-extensions.md
2020-10-16 20:58:57 +03:00
Aleksey Kladov
0c67edc0f7
Expand code order section
2020-10-16 12:50:09 +02:00
Aleksey Kladov
86cc93ebe3
Document awkward names
2020-10-15 18:14:30 +02:00
Aleksey Kladov
dedfaa3844
Cleanup alloc advice
2020-10-15 12:21:38 +02:00
Aleksey Kladov
9c285b0341
Style: default over new
2020-10-14 20:02:03 +02:00
Aleksey Kladov
190011168d
Introduce S-actionable and S-unactionable labels
...
I've noticed that a significant fraction of issues are inert.
They are valid, acknowledged and useful, but effectively can't be
fixed for variety of reasons (no reproduction, dependencies on some
other issues, no review capacity, etc).
Marking issues that can be fixed by just applying some elbow grease
seems useful!
2020-10-14 15:20:31 +02:00
Aleksey Kladov
d852189e56
Add reminder to update lsp-extensions.md
2020-10-14 13:30:06 +02:00
Zac Pullar-Strecker
f1decfc110
Fix send->sent typo
2020-10-08 15:04:57 +13:00
Zac Pullar-Strecker
62b76e7004
Document the protocol extension
2020-10-08 15:04:20 +13:00
Aleksey Kladov
5359e8f742
minor
2020-10-07 13:11:33 +02:00
Aleksey Kladov
1688e481b3
minor
2020-10-07 13:03:13 +02:00
Aleksey Kladov
6976494781
Add comparisons guideline to style
2020-10-07 12:57:49 +02:00
Aleksey Kladov
fdf2f6226b
Reorg style
2020-10-07 12:50:46 +02:00
Aleksey Kladov
0599e64bb2
Document Clippy strategy
2020-10-02 10:13:58 +02:00
Laurențiu Nicola
2233749692
Improve grammar and fix code example in style guide
2020-10-01 21:02:39 +03:00
Aleksey Kladov
af8063fe37
Extend **Status** command to also show dep info for the file
...
This should help with troubleshooting wrong project configuration
2020-09-29 22:13:23 +02:00
Aleksey Kladov
b069c1c69a
More style advice
2020-09-29 14:42:09 +02:00
Yusuke Tanaka
4530b717cb
Fix typo
2020-09-21 01:44:38 +09:00
Yusuke Tanaka
203358a0d5
Fix typo
2020-09-21 00:53:14 +09:00
Aleksey Kladov
4f5d2ffac2
fmt import
2020-08-28 16:53:49 +02:00
Rüdiger Herrmann
3dbe062741
Update mentions of 'ra_vfs' in architecture doc
...
Adjust the paragraph about `ra_vfs` to point to the `vfs` crate that is used now.
2020-08-25 17:57:29 +02:00
bors[bot]
951c7c157a
Merge #5852
...
5852: Add Early Return rule to style r=matklad a=matklad
bors r+
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-24 10:56:04 +00:00
Aleksey Kladov
fc3e591bdb
Avoid monomorphization
2020-08-24 12:49:36 +02:00
Aleksey Kladov
d7ece3028d
Add Early Return rule to style
2020-08-24 12:22:28 +02:00
Aleksey Kladov
0c602bb963
Encourage rebases more
2020-08-18 18:52:12 +02:00
Aleksey Kladov
0d201638d9
Add default names section
2020-08-18 14:31:50 +02:00
bors[bot]
6826dd044a
Merge #5782
...
5782: Fix StatusNotification r=matklad a=vsrs
This PR fixes the following:
As per specification `params` property in [NotificationMessage ](https://microsoft.github.io/language-server-protocol/specifications/specification-current/#notificationMessage ) should be `array | object` while RA uses `"loading" | "ready" | "invalid" | "needsReload"`.
Co-authored-by: vsrs <vit@conrlab.com>
2020-08-17 14:23:03 +00:00
Aleksey Kladov
6a4c9fc9fd
Don't make fields private unless you have to
2020-08-17 16:11:29 +02:00
vsrs
1eed036a6e
Fix StatusNotification
2020-08-17 14:56:27 +03:00
Aleksey Kladov
200161c734
Document the most important CI invariant
2020-08-14 12:27:15 +02:00
Aleksey Kladov
1b0c7701cc
Rename ra_ide -> ide
2020-08-13 17:58:27 +02:00