Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2024-12-25 12:33:33 +00:00
Code Issues Projects Releases Packages Wiki Activity

Clarify comparison rule

Browse source
This commit is contained in:
Aleksey Kladov 2021-03-03 11:23:05 +03:00
parent 0ce539ec96
commit e15621482c
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
docs/dev/style.md
View file

@ -769,14 +769,20 @@ fn foo() -> Option<Bar> {
## Comparisons
Use `<`/`<=`, avoid `>`/`>=`.
When doing multiple comparisons use `<`/`<=`, avoid `>`/`>=`.
```rust
// GOOD
assert!(lo <= x && x <= hi);
assert!(r1 < l2 || r2 < l1);
assert!(x < y);
assert!(x > 0);
// BAD
assert!(x >= lo && x <= hi>);
assert!(r1 < l2 || l1 > r2);
assert!(y > x);
assert!(0 > x);
```
**Rationale:** Less-then comparisons are more intuitive, they correspond spatially to [real line](https://en.wikipedia.org/wiki/Real_line).