Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2024-12-25 20:43:21 +00:00
Code Issues Projects Releases Packages Wiki Activity

add useless types to the styleguide

Browse source
This commit is contained in:
Aleksey Kladov 2021-02-02 15:41:57 +03:00
parent 8720f7f146
commit 283c3b0133
1 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
docs/dev/style.md
View file

@ -267,6 +267,20 @@ Non-local code properties degrade under change, privacy makes invariant local.
Borrowed own data discloses irrelevant details about origin of data.
Irrelevant (neither right nor wrong) things obscure correctness.
## Useless Types
More generally, always prefer types on the left
```rust
// GOOD BAD
&[T] &Vec<T>
&str &String
Option<&T> &Option<T>
```
**Rationale:** types on the left are strictly more general.
Even when generality is not required, consistency is important.
## Constructors
Prefer `Default` to zero-argument `new` function