Kevaundray Wedderburn
72b9a4fbd3
Change <|> to $0 - Rebase
2021-01-07 12:09:23 +00:00
bors[bot]
1cc73d60bb
Merge #7068
...
7068: Add VSCode command to view the hir of a function body r=theotherphil a=theotherphil
Will fix https://github.com/rust-analyzer/rust-analyzer/issues/7061 . Very rough initial version just to work out where I needed to wire everything up.
@matklad would you be happy merging a hir visualiser of some kind? If so, do you have any thoughts on what you'd like it show, and how?
I've spent very little time on this thus far, so I'm fine with throwing away the contents of this PR, but I want to avoid taking the time to make this more polished/interactive/useful only to discover that no-one else has any interest in this functionality.
![image](https://user-images.githubusercontent.com/1974256/103236081-bb58f700-493b-11eb-9d12-55ae1b870f8f.png )
Co-authored-by: Phil Ellison <phil.j.ellison@gmail.com>
2021-01-03 09:03:15 +00:00
Phil Ellison
db53db8046
Address review suggestion, fix tidy tests
2021-01-01 19:25:18 +00:00
Aleksey Kladov
9c0c5f8e37
Improve commit message style
2020-12-28 13:43:07 +03:00
Aleksey Kladov
675390e012
Update docs/dev/README.md
...
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2020-12-16 18:07:21 +03:00
Aleksey Kladov
6e9023c763
Document new permissions
2020-12-16 18:04:24 +03:00
Aleksey Kladov
51f42db1d5
Add #
to canonical test example
2020-12-15 11:49:22 +03:00
Aleksey Kladov
17f236c2b0
Normalize spelling to American English
2020-12-10 17:51:56 +03:00
Daiki Ihara
4f008bf8b2
fix typo of README in dev
2020-12-09 00:30:00 +09:00
Aleksey Kladov
3e00bfce2b
Document statelessness invariant
2020-12-03 18:08:27 +03:00
Jakob Hellermann
7c6c812a74
fix typos in syntax.md
2020-11-17 15:16:52 +01:00
kjeremy
233fdb12ce
Latest LSP 3.16 protocol
...
Pulls in https://github.com/gluon-lang/lsp-types/pull/186
2020-11-16 15:10:13 -05:00
Anatol Liu
b1b7727e04
add open Cargo.toml action
2020-11-12 17:48:07 -08:00
Aleksey Kladov
7d2eb000b0
Switch to upstream protocol for resolving code action
...
Note that we have to maintain custom implementation on the client
side: I don't see how to marry bulitin resolve support with groups and
snippets.
2020-11-10 18:48:46 +01:00
Aleksey Kladov
9b1d4cc8ab
don\t indent tests
2020-11-06 20:29:41 +01:00
Aleksey Kladov
412d6b3db5
Update docs/dev/style.md
...
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-11-02 12:17:34 +01:00
Aleksey Kladov
4318828f21
Document doer object anti-pattern
2020-11-02 12:13:59 +01:00
Laurențiu Nicola
f94d0252b3
Update client install command in dev docs
2020-10-27 09:49:57 +02:00
Adrian Stanciu
5f5b1ffdd1
Update debugging.md
2020-10-22 21:04:09 +03:00
Igor Aleksanov
d718366567
Document change of 'cargo' Runnable kind in lsp-extensions.md
2020-10-16 20:58:57 +03:00
Aleksey Kladov
0c67edc0f7
Expand code order section
2020-10-16 12:50:09 +02:00
Aleksey Kladov
86cc93ebe3
Document awkward names
2020-10-15 18:14:30 +02:00
Aleksey Kladov
dedfaa3844
Cleanup alloc advice
2020-10-15 12:21:38 +02:00
Aleksey Kladov
9c285b0341
Style: default over new
2020-10-14 20:02:03 +02:00
Aleksey Kladov
190011168d
Introduce S-actionable and S-unactionable labels
...
I've noticed that a significant fraction of issues are inert.
They are valid, acknowledged and useful, but effectively can't be
fixed for variety of reasons (no reproduction, dependencies on some
other issues, no review capacity, etc).
Marking issues that can be fixed by just applying some elbow grease
seems useful!
2020-10-14 15:20:31 +02:00
Aleksey Kladov
d852189e56
Add reminder to update lsp-extensions.md
2020-10-14 13:30:06 +02:00
Zac Pullar-Strecker
f1decfc110
Fix send->sent typo
2020-10-08 15:04:57 +13:00
Zac Pullar-Strecker
62b76e7004
Document the protocol extension
2020-10-08 15:04:20 +13:00
Aleksey Kladov
5359e8f742
minor
2020-10-07 13:11:33 +02:00
Aleksey Kladov
1688e481b3
minor
2020-10-07 13:03:13 +02:00
Aleksey Kladov
6976494781
Add comparisons guideline to style
2020-10-07 12:57:49 +02:00
Aleksey Kladov
fdf2f6226b
Reorg style
2020-10-07 12:50:46 +02:00
Aleksey Kladov
0599e64bb2
Document Clippy strategy
2020-10-02 10:13:58 +02:00
Laurențiu Nicola
2233749692
Improve grammar and fix code example in style guide
2020-10-01 21:02:39 +03:00
Aleksey Kladov
af8063fe37
Extend **Status** command to also show dep info for the file
...
This should help with troubleshooting wrong project configuration
2020-09-29 22:13:23 +02:00
Aleksey Kladov
b069c1c69a
More style advice
2020-09-29 14:42:09 +02:00
Yusuke Tanaka
4530b717cb
Fix typo
2020-09-21 01:44:38 +09:00
Yusuke Tanaka
203358a0d5
Fix typo
2020-09-21 00:53:14 +09:00
Aleksey Kladov
4f5d2ffac2
fmt import
2020-08-28 16:53:49 +02:00
Rüdiger Herrmann
3dbe062741
Update mentions of 'ra_vfs' in architecture doc
...
Adjust the paragraph about `ra_vfs` to point to the `vfs` crate that is used now.
2020-08-25 17:57:29 +02:00
bors[bot]
951c7c157a
Merge #5852
...
5852: Add Early Return rule to style r=matklad a=matklad
bors r+
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-24 10:56:04 +00:00
Aleksey Kladov
fc3e591bdb
Avoid monomorphization
2020-08-24 12:49:36 +02:00
Aleksey Kladov
d7ece3028d
Add Early Return rule to style
2020-08-24 12:22:28 +02:00
Aleksey Kladov
0c602bb963
Encourage rebases more
2020-08-18 18:52:12 +02:00
Aleksey Kladov
0d201638d9
Add default names section
2020-08-18 14:31:50 +02:00
bors[bot]
6826dd044a
Merge #5782
...
5782: Fix StatusNotification r=matklad a=vsrs
This PR fixes the following:
As per specification `params` property in [NotificationMessage ](https://microsoft.github.io/language-server-protocol/specifications/specification-current/#notificationMessage ) should be `array | object` while RA uses `"loading" | "ready" | "invalid" | "needsReload"`.
Co-authored-by: vsrs <vit@conrlab.com>
2020-08-17 14:23:03 +00:00
Aleksey Kladov
6a4c9fc9fd
Don't make fields private unless you have to
2020-08-17 16:11:29 +02:00
vsrs
1eed036a6e
Fix StatusNotification
2020-08-17 14:56:27 +03:00
Aleksey Kladov
200161c734
Document the most important CI invariant
2020-08-14 12:27:15 +02:00
Aleksey Kladov
1b0c7701cc
Rename ra_ide -> ide
2020-08-13 17:58:27 +02:00
Aleksey Kladov
fc34403018
Rename ra_assists -> assists
2020-08-13 17:33:38 +02:00
Aleksey Kladov
ae71a631fd
Rename ra_hir -> hir
2020-08-13 16:36:55 +02:00
Aleksey Kladov
ed20a857f4
Rename ra_db -> base_db
2020-08-13 16:29:33 +02:00
Aleksey Kladov
a1c187eef3
Rename ra_syntax -> syntax
2020-08-12 18:30:53 +02:00
Aleksey Kladov
50a02eb359
Rename ra_parser -> parser
2020-08-12 17:14:23 +02:00
Tim Weis
a8beb79a16
Update README.md
...
Fixed formatting.
2020-08-11 01:01:25 +02:00
Laurențiu Nicola
ff60fdc315
Fix typos in syntax.md
2020-08-10 21:31:38 +03:00
Aleksey Kladov
33447e2855
Update docs/dev/README.md
...
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-08-05 14:01:51 +02:00
Aleksey Kladov
36d75f3105
Document release process
2020-08-05 13:50:47 +02:00
Aleksey Kladov
e96bfd812a
Tweak style wording
2020-08-02 14:59:18 +02:00
Aleksey Kladov
edee52fa57
reorg docs
2020-08-02 14:37:50 +02:00
Aleksey Kladov
389ad925ff
Document crates.io deps policy
2020-07-31 17:17:32 +02:00
Aleksey Kladov
1142112c70
Rename FnDef -> Fn
2020-07-30 15:16:05 +02:00
David Lattimore
7d80a49e89
README: Add some instructions for running typescript tests and linter.
2020-07-25 09:35:33 +10:00
David Lattimore
3975952601
SSR: Pass current file position through to SSR code.
...
In a subsequent commit, it will be used for resolving paths.
2020-07-24 21:34:00 +10:00
Jeremy Kolb
9c0ead30b9
Clarify initializationOptions
2020-07-22 10:05:36 -04:00
Aleksey Kladov
deed44a472
Remove support for jemalloc
...
We only used it for measuring memory usage, but now we can use glibc's
allocator for that just fine
2020-07-22 13:40:45 +02:00
Laurențiu Nicola
daab8b2fd0
Remove insta dep
2020-07-21 13:11:51 +03:00
Aleksey Kladov
c88d85bbb4
Update docs/dev/README.md
2020-07-07 11:23:59 +02:00
Laurențiu Nicola
8ab0c7ffd3
Don't ping people in PRs
2020-07-06 13:59:24 +03:00
Aleksey Kladov
3ef7676076
Implement StatusBar
2020-07-02 15:32:14 +02:00
Aleksey Kladov
c9f878962a
Add reload workspace command
2020-07-01 14:57:59 +02:00
Aleksey Kladov
991850bc3c
Unify magic env var name
2020-07-01 12:31:03 +02:00
Aleksey Kladov
4484908a86
Rewrite goto definition tests
2020-06-30 13:03:08 +02:00
Laurențiu Nicola
95d67ec401
Use more of FxHash*
2020-06-29 18:07:52 +03:00
Aleksey Kladov
a1c327ec1c
Document test minimality
2020-06-26 18:41:11 +02:00
Laurențiu Nicola
76ddface08
Fix panic in split and merge import assists
2020-06-23 16:51:07 +03:00
okaneco
3910ea5cbf
Fix typos in docs/dev/README.md
...
Small grammar and spelling changes
2020-06-16 10:44:56 -04:00
Aleksey Kladov
b5c4f2faa2
Update parser tests with env var
2020-06-15 11:02:17 +02:00
Aleksey Kladov
5413a2f962
Var naming
2020-06-15 10:33:17 +02:00
Aleksey Kladov
be0bb857c1
Discourage allocation
2020-06-13 14:27:23 +02:00
Jacek Generowicz
f280407d73
Fix parser test directory name in dev docs
2020-06-10 20:32:29 +02:00
Aleksey Kladov
1538206609
Explain inline tests
2020-06-10 14:12:08 +02:00
Laurențiu Nicola
e3663d60bf
Dev docs nits
2020-06-08 18:50:27 +03:00
Aleksey Kladov
4968321706
Don't @ people in commit messages
2020-06-08 13:19:32 +02:00
Aleksey Kladov
cc07c82fef
Preconditions style
2020-06-08 12:54:48 +02:00
Aleksey Kladov
ee8dec5dc1
IDE API
2020-06-08 12:52:28 +02:00
Aleksey Kladov
81ffe973ac
Document certain invariants
2020-06-06 19:54:41 +02:00
Aleksey Kladov
ae1acbd09c
Document import style
2020-06-06 19:32:45 +02:00
vsrs
da7ec4b339
Add hover actions LSP extension documentation.
2020-06-05 15:00:28 +03:00
Veetaha
41ae7ed79f
Bufgix
2020-06-04 01:48:47 +03:00
Mikhail Rakhmanov
6a0083a519
Merge branch 'master' into compute-lazy-assits
...
# Conflicts:
# crates/rust-analyzer/src/main_loop/handlers.rs
# crates/rust-analyzer/src/to_proto.rs
2020-06-03 19:26:01 +02:00
Mikhail Rakhmanov
1f7de306f5
Add documentation
2020-06-03 18:57:50 +02:00
bors[bot]
1bbbeb886d
Merge #4703
...
4703: Start documenting review process r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-06-03 06:29:33 +00:00
Aleksey Kladov
994006585b
Start documenting review process
2020-06-03 08:28:12 +02:00
Aleksey Kladov
a83ab820a4
Spec better runnables
2020-06-02 17:34:18 +02:00
bors[bot]
131ccd9540
Merge #4580
...
4580: Fix invoking cargo without consulting CARGO env var or standard installation paths r=matklad a=Veetaha
Followup for #4329
The pr essentially fixes [this bug](https://youtu.be/EzQ7YIIo1rY?t=2189 )
cc @lefticus
Co-authored-by: veetaha <veetaha2@gmail.com>
2020-06-02 11:58:28 +00:00
Aleksey Kladov
6370de444d
Subscribe to protocol changes
2020-06-01 17:51:15 +02:00
Aleksey Kladov
aaa288126b
Document initilizationOptions used by rust-analyzer
2020-06-01 17:42:46 +02:00
Aleksey Kladov
d23814bf3d
Drop unused document
2020-06-01 17:29:24 +02:00
veetaha
d605ec9c32
Change Runnable.bin -> Runnable.kind
...
As per matklad, we now pass the responsibility for finding the binary to the frontend.
Also, added caching for finding the binary path to reduce
the amount of filesystem interactions.
2020-05-31 05:21:45 +03:00
Stephan Seitz
49f674480a
Fix typo in docs/dev/lsp-extensions.md: automagiacally -> automagically
2020-05-29 23:43:14 +02:00
Veetaha
bfdcf73b9b
typo
2020-05-27 14:04:57 +03:00
Aleksey Kladov
bb415c1818
Document inlay hints and runnables
...
We want to change those, but let's document what we have in meantime
2020-05-27 12:20:47 +02:00
Aleksey Kladov
0ebb25b29b
Document parentModule
experimental LSP request
2020-05-25 15:59:49 +02:00
Aleksey Kladov
a30bdd9795
Cleanup lsp extensions on the client side
2020-05-25 14:56:26 +02:00
Aleksey Kladov
76e170c3d0
Less rust-analyzer specific onEnter
2020-05-25 14:28:47 +02:00
Aleksey Kladov
dec4ba8023
Document some rust-analyzer specific protocol extensions
2020-05-24 17:01:40 +02:00
Aleksey Kladov
9342273616
Document matchingBrace LSP request
2020-05-24 16:53:18 +02:00
Aleksey Kladov
e4af9f6d8a
Reorgonise extensions docs
2020-05-24 15:49:32 +02:00
Aleksey Kladov
9d31b502b5
Link upstream issues
2020-05-22 19:14:14 +02:00
Aleksey Kladov
2075e77ee5
CodeAction groups
2020-05-22 17:32:46 +02:00
Aleksey Kladov
5ef4ebff20
Use WorkspaceEdit for ssr
2020-05-22 00:28:49 +02:00
Aleksey Kladov
5b5ebec440
Formalize JoinLines protocol extension
2020-05-21 20:05:33 +02:00
Yuki Kodama
d58d6412d8
Fix names of launch configuration in dev docs
2020-05-21 03:01:37 +09:00
Aleksey Kladov
a752853350
Add snippetTextEdit protocol extension
2020-05-19 20:28:27 +02:00
Aleksey Kladov
72e229fcb3
Use RA_LOG instead of RUST_LOG for logging
...
RUST_LOG might be set up for debugging the user's problem, slowing
down rust-analyzer considerably. That's the same reason why rustc uses
RUSTC_LOG.
2020-05-11 19:16:00 +02:00
KENTARO OKUDA
42e2eca921
Update debugging.md
2020-05-03 15:14:56 -04:00
KENTARO OKUDA
4f4d0fd9ac
Update syntax.md
2020-05-02 18:55:04 -04:00
KENTARO OKUDA
9914f7fbb2
Fix Typos
2020-05-02 17:45:46 -04:00
KENTARO OKUDA
f5d20b6525
Fix Typos on guide.md
2020-05-01 14:00:06 -04:00
KENTARO OKUDA
eafb2107dd
Fix Typos
2020-05-01 09:43:08 -04:00
Ömer Sinan Ağacan
742055e29f
Update Roslyn link in syntax.md
...
Eric Lippert has a new blog that he keeps updating, update the link to that
2020-04-30 23:27:06 +03:00
Youngsuk Kim
b40a237baf
tiny fix in markdown ordered list
...
`.3` => `3.`
2020-04-28 10:18:12 -04:00
Aleksey Kladov
8843588fca
Convert tests to text-size
2020-04-25 11:59:18 +02:00
Aleksey Kladov
b1d5817dd1
Convert code to text-size
2020-04-25 11:59:18 +02:00
veetaha
dd5e4d4870
vscode: move docks about syntax tree to dev/README.md
2020-04-02 11:23:56 +03:00
Laurențiu Nicola
48737be857
Fix dev guide broken links
2020-02-18 16:24:04 +02:00
Aleksey Kladov
c855e36696
Rename config value for server Path
2020-02-18 12:35:44 +01:00
Aleksey Kladov
c0fa5e2246
Rename the binary to rust-analyzer
2020-02-18 12:33:16 +01:00
Laurențiu Nicola
b6b8fd9525
Replace ra_cli mentions
2020-02-17 22:07:24 +02:00
Laurențiu Nicola
aadab96c9d
Fix RA_PROFILE typo in docs
2020-02-17 22:05:48 +02:00
Veetaha
2d7fe230f5
docs: Fix grammar mistakes
2020-02-16 23:52:41 +02:00
Veetaha
884e382fb8
Fix typo
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:47:12 +02:00
Veetaha
5bf7e9a455
Remove ptrace note
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:43:13 +02:00
Veetaha
bb9844e195
Add more verbose description
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:42:48 +02:00
Veetaha
7050697871
Add the article
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:42:10 +02:00
Veetaha
3db91db421
Reworded abit
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:40:31 +02:00
Veetaha
329a1b665d
Add an article
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:38:25 +02:00
Veetaha
dc90507dbe
Migrate from 'npm i' to 'npm install'
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:36:16 +02:00
Veetaha
1a96d4c15c
Make Rust Great Again
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:35:41 +02:00
Veetaha
79625e2dc2
Apply better wording as per lnicola
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:35:10 +02:00
Veetaha
351cc9021e
Add the article
...
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 23:33:23 +02:00
Veetaha
200a2475a2
docs: fix typo
2020-02-16 23:21:11 +02:00
Veetaha
64112b0b61
docs: update debugging.md with the freshest VSCode debugging information
2020-02-16 23:00:10 +02:00
Veetaha
43a41819cb
docs: remove obsolescence notice in debugging.md
2020-02-16 21:03:24 +02:00
Veetaha
e18661f62b
docs: Freshen docs for prebuilt binaries and raLspServer setting
2020-02-09 20:19:23 +02:00
Florian Diebold
134cc70097
Docs cleanups
2020-02-08 16:15:58 +01:00
Aleksey Kladov
84dfbfbd1d
Freshen Architecture.md document
2020-01-29 15:08:31 +01:00
Aleksey Kladov
1065c2bf1d
Freshen dev docs a tiny bits
2020-01-29 14:45:32 +01:00