Pavle Goloskokovic
44acc440f4
When hijacking audio form other sounds, sorting them by progress rather than just seek, so that we favorize longer sounds to continue their playback
2018-01-12 18:15:52 +01:00
Richard Davey
c625b8735b
Updated to using Event Emitter for all key managers and game objects. Events are now dispatched directly using arguments instead of Event objects, all managers updated to emit directly.
2018-01-12 17:09:21 +00:00
Pavle Goloskokovic
9bb138f40d
Dispatching event when setting HTML5AudioSoundManager volume property
2018-01-12 17:26:16 +01:00
Pavle Goloskokovic
30027af69e
Dispatching event when setting HTML5AudioSoundManager mute property
2018-01-12 17:25:59 +01:00
Pavle Goloskokovic
8f3f88c24d
Checking for set audio property instead of isPlaying flag
2018-01-12 17:19:03 +01:00
Pavle Goloskokovic
919665dd96
Fixed scope issue
2018-01-12 17:11:12 +01:00
Pavle Goloskokovic
4038291373
Changed the order of defining startTime and previousTime properties
2018-01-12 16:12:15 +01:00
Pavle Goloskokovic
b2eef5b96e
Added a todo
2018-01-12 16:03:15 +01:00
Pavle Goloskokovic
2a76c6eff5
Updating previousTime property when setting seek value
2018-01-12 16:01:19 +01:00
Pavle Goloskokovic
1cdebc80c3
Updating previousTime when picking and playing audio for sound
2018-01-12 16:00:37 +01:00
Pavle Goloskokovic
1180d82c27
Updating previousTime when starting sound with delayed playback
2018-01-12 15:59:40 +01:00
Pavle Goloskokovic
398b337da9
Resetting previousTime property when stopping sound or hijacking audio from another sound
2018-01-12 15:58:43 +01:00
Pavle Goloskokovic
de9e5a0d1f
Updating currentTime to new audio currentTime value while handling looping before assigning that value to previousTime property
2018-01-12 15:57:55 +01:00
Pavle Goloskokovic
a51a0bd543
Setting previousTime property to currentTime value at the end of update method
...
Using condition when current time is less then previous time to indicate sound looping and dispatch an event
2018-01-12 15:39:58 +01:00
Pavle Goloskokovic
1ec66f644f
Added previousTime property to keep track of audio tag's playback position recorded on previous update method call
2018-01-12 15:32:30 +01:00
Pavle Goloskokovic
9ec4d9a829
Fixing sound position if sound loops and starts from the beginning between two update calls
2018-01-12 15:30:11 +01:00
Pavle Goloskokovic
735cf10a3f
Dispatching SOUND_ENDED event when sound ends, obviously :)
2018-01-12 15:28:06 +01:00
Pavle Goloskokovic
72955bfe30
Handling sound ending in update method
2018-01-12 15:27:25 +01:00
Pavle Goloskokovic
0d0df1900b
Added logic for handling looping in update method
2018-01-12 15:23:39 +01:00
Pavle Goloskokovic
81d794b4c6
Setting audio to correct state when starting it since it might be playing already when hijacked form another sound
2018-01-12 15:18:31 +01:00
Pavle Goloskokovic
e68ff2b18a
Saving current position of the sound and stopping and releasing audio tag when calling pause method
2018-01-11 18:55:42 +01:00
Pavle Goloskokovic
f6de613fd0
Added stopAndReleaseAudioTag method to stop sound playback and mark audio tag as unused and release it for other sounds to use
2018-01-11 18:53:54 +01:00
Pavle Goloskokovic
8578319171
requiring SoundEvent class
2018-01-11 18:51:02 +01:00
Pavle Goloskokovic
40b2bf79b7
Calling pickAndPlayAudioTag from resume method
2018-01-11 18:50:25 +01:00
Pavle Goloskokovic
9e7ccb1503
Added helpful flags comment
2018-01-11 18:49:44 +01:00
Pavle Goloskokovic
a6b4066468
Moved logic for setting up and playing audio tag so it can be reused
2018-01-11 18:45:34 +01:00
Pavle Goloskokovic
f9093a2d7e
Disabling setting seek property on a delayed sound
2018-01-11 18:41:43 +01:00
Pavle Goloskokovic
81e8542af7
Resetting startTime property of a hijacked sound
2018-01-11 18:40:36 +01:00
Pavle Goloskokovic
fb29afedae
Preventing resume calls on delayed sounds
2018-01-11 18:39:45 +01:00
Pavle Goloskokovic
c1b24c4adb
Preventing pause calls on delayed sounds
2018-01-11 18:39:19 +01:00
Pavle Goloskokovic
fb6b989035
Handling delayed playback in update method
2018-01-11 18:31:36 +01:00
Pavle Goloskokovic
3388fd018f
Setting startTime based on delay config when calling play method
2018-01-11 18:30:16 +01:00
Pavle Goloskokovic
d6256c47c5
Defined startTime property
2018-01-11 18:23:28 +01:00
Pavle Goloskokovic
82819ec782
Setting sound position, applying config and starting playback if delay is set to 0 when calling play method
2018-01-11 18:20:18 +01:00
Pavle Goloskokovic
11923621ad
Finding available audio tag when calling play method and resetting and returning false if it was not successful
2018-01-11 18:17:50 +01:00
Pavle Goloskokovic
af8666f611
Added reset method that calls super stop method in order to reset sounds state
...
Calling reset method and setting audio to null after hijacking audio tag from another sound
2018-01-11 18:15:42 +01:00
Pavle Goloskokovic
106e32499f
Sorting sounds to hijack audio from by loop and seek properties values
2018-01-11 18:12:52 +01:00
Pavle Goloskokovic
f377b4fa85
Finding another sound to hijack audio tag from if there are no free audio tags and override setting is set to true
2018-01-11 18:11:10 +01:00
Pavle Goloskokovic
fc19a05f0b
Returning false if override setting of sound manager is set to false
2018-01-11 18:05:12 +01:00
Pavle Goloskokovic
935ef78102
Added method for finding unused audio tag for playing sound
2018-01-11 18:04:17 +01:00
Pavle Goloskokovic
6730b3b314
Defined seek property for HTML5AudioSound class
2018-01-11 18:00:42 +01:00
Pavle Goloskokovic
d6b11e2fdb
Defined seek property's setter for HTML5AudioSound class
2018-01-11 17:59:36 +01:00
Pavle Goloskokovic
afb8075379
Defined seek property's setter for HTML5AudioSound class
2018-01-11 17:58:26 +01:00
Pavle Goloskokovic
110c6891dd
Defined volume property for HTML5AudioSound class
2018-01-11 17:57:04 +01:00
Pavle Goloskokovic
8f9eafd315
Defined mute property for HTML5AudioSound class
2018-01-11 17:55:05 +01:00
Pavle Goloskokovic
495a79d4bf
Implemented setRate method
2018-01-11 17:51:58 +01:00
Pavle Goloskokovic
91f9629ed2
Implemented setVolume method
2018-01-11 17:50:20 +01:00
Pavle Goloskokovic
162a063f03
Implemented setMute method
2018-01-11 17:49:40 +01:00
Pavle Goloskokovic
ede81f2a03
Added destroy method
2018-01-11 17:48:23 +01:00
Pavle Goloskokovic
0223019290
Added blank update method
2018-01-11 17:47:01 +01:00
Pavle Goloskokovic
d51156fe94
Added stop method implementation that calls super method and dispatches stop event
2018-01-11 17:45:02 +01:00
Pavle Goloskokovic
196258b8ac
Added resume method implementation that calls super method and dispatches resume event
2018-01-11 17:43:56 +01:00
Pavle Goloskokovic
5e8d0dcaee
Added pause method implementation that calls super method and dispatches pause event
2018-01-11 17:42:18 +01:00
Pavle Goloskokovic
d3c034e5cc
Added play method implementation that calls super method and dispatches play event
2018-01-11 17:40:59 +01:00
Pavle Goloskokovic
b452859b78
Assigning duration and totalDuration values to audio tag duration
2018-01-11 17:38:47 +01:00
Pavle Goloskokovic
1d925105bd
Audio property docs update
2018-01-11 17:37:28 +01:00
Pavle Goloskokovic
ad858d1475
Throwing an error if no sound with given key was loaded
2018-01-11 17:36:51 +01:00
Pavle Goloskokovic
cf83880fb0
Defined tags property that holds reference to audio tags array
2018-01-11 17:35:25 +01:00
Pavle Goloskokovic
b22116e1f8
Updated override property docs
2018-01-11 17:32:49 +01:00
Pavle Goloskokovic
2372fdd812
Completed a TODO to return HTML5AudioSoundManager instance when necessary
2018-01-11 17:29:57 +01:00
Pavle Goloskokovic
7c715f1ba0
Removed detune property since it is already implemented in BaseSound class
2018-01-11 17:28:52 +01:00
Pavle Goloskokovic
be713af155
Removed rate property since it is already implemented in BaseSound class
2018-01-11 17:28:25 +01:00
Pavle Goloskokovic
98700ffff2
Updating play method to return boolean indicating if play call was done successfully
2018-01-11 17:27:19 +01:00
Pavle Goloskokovic
15562a70e3
Updated override property docs
2018-01-11 17:25:55 +01:00
Pavle Goloskokovic
2903417798
Defining detune property on a BaseSound class since it's the shared behaviour between subclasses
2018-01-11 17:24:53 +01:00
Pavle Goloskokovic
15f2717e9b
Defining rate property on a BaseSound class since it's the shared behaviour between subclasses
2018-01-11 17:24:26 +01:00
Pavle Goloskokovic
c0c6e39ccd
Updating play method to return boolean indicating if play call was done successfully
2018-01-11 17:22:57 +01:00
Pavle Goloskokovic
e75871adec
Added override property to HTML5AudioSoundManager
2018-01-11 16:50:50 +01:00
Pavle Goloskokovic
9fc3aaa0da
Moved HTML5AudioSoundManager.js
2018-01-10 16:50:21 +01:00
Pavle Goloskokovic
081908fd7b
Moved HTML5AudioSound.js
2018-01-10 16:50:11 +01:00
Pavle Goloskokovic
d0d3a6473d
Merge remote-tracking branch 'origin/master'
2018-01-10 16:20:13 +01:00
Richard Davey
d8f1ba03e9
Moved repository location
2018-01-09 21:43:56 +00:00
Richard Davey
0d90f75b5f
Splitting the dev branch up into versions.
2016-11-22 01:36:56 +00:00
photonstorm
7b9c4114b2
Preparing for 2.6.2 release.
2016-08-22 12:31:02 +01:00
Richard Davey
33748ece87
Merge pull request #2697 from hilts-vaughan/fix-sound-loop
...
Sound: Fixes an issue where loopFull would not return the soundinstan…
2016-08-18 15:29:18 +01:00
Vaughan Hilts
067f3cca83
Sound: Fixes an issue where loopFull would not return the soundinstance that it looped from
2016-08-17 22:15:45 -04:00
Richard Davey
e955cf4222
Sound.play would throw the error "Uncaught DOMException: Failed to execute 'disconnect' on 'AudioNode': the given destination is not connected." in Chrome, if you tried to play an audio marker that didn't exist, while a valid marker was already playing.
2016-08-03 04:04:22 +01:00
Richard Davey
6f9bcae23e
Docs fixes #2629
2016-07-17 11:23:41 +01:00
photonstorm
521a6c9dbb
Sound.stop will check to see if gainNode exists before trying to disconnect from it.
2016-07-08 12:27:12 +01:00
photonstorm
2310e5dc6f
Sound.volume was accidentally repeated twice in the source (thanks @LoneStranger #2569 )
2016-06-20 12:18:39 +01:00
Richard Davey
1b67850c82
Merge pull request #2529 from TheJasonReynolds/local_dev
...
Set isPlaying to true if no marker (.play is not called again)
2016-06-05 15:51:43 +01:00
John Rees
e75827d6ab
Signal description typo fix
2016-06-04 19:41:54 +01:00
Jason Reynolds
db0a41bedf
Set isPlaying to true if no marker (.play is not called again)
2016-06-03 17:08:07 -05:00
photonstorm
63a1336bd5
Sound.addMarker now has a default value for the duration argument (1 second) to avoid the DOM Exception 11 error if you accidentally miss it out (thanks @mari8i #2508 )
2016-06-02 15:29:51 +01:00
photonstorm
d161a7f6bc
Sounds played using the Audio tag, set to loop, would get caught in an endless pause-play loop cycle (thanks @rroylance #2473 )
2016-05-17 16:43:11 +01:00
photonstorm
54683b7fb2
Sounds played using the Audio tag, that were paused and then resumed again (either directly in code, or via a game pause event) would not resume from the point at which they paused (thanks @rroylance #2473 )
2016-05-16 15:16:19 +01:00
photonstorm
58af40ca92
Added a bit more info to the SoundManager docs re: #2373
2016-04-07 01:07:19 +01:00
photonstorm
896b32a28c
SoundManager.muteOnPause is a new boolean that allows you to control if the Sound system gets muted automatically when a Phaser game pauses, such as when it loses focus. You may need to set this to false if you wish to control the audio system from outside of your Phaser game, i.e. from DOM buttons or similar ( #2382 )
2016-04-06 02:09:22 +01:00
photonstorm
61bc4a8dca
Sound.play when using an AudioTag would ignore the muted state of the SoundManager and play regardless. It now checks the SoundManager.mute state on play, and sets the volume accorindingly (thanks @brianbunch #2139 )
2016-04-06 01:41:54 +01:00
photonstorm
988290631f
When setting a global volume for the SoundManager it would previously incorrectly calculate the volumes of AudioTag based Sound objects that were not played at volume 1. The new approach uses Sound.updateGlobalVolume which adjusts the Sound volume to be a percentage of the global volume. So if the global volume is 0.5 and the Sound volume is 0.5, the Sound will play with an actual volume of 0.25 (thanks @VitaZheltyakov #2325 )
2016-04-06 01:19:32 +01:00
Richard Davey
71056ccb69
Merge pull request #2371 from stoneman1/dev
...
Fixed video for future
2016-04-06 01:08:22 +01:00
photonstorm
f40cfbe2ae
2015 - 2016.
2016-04-04 22:16:16 +01:00
Stoneman1
4a29d5102d
Fixes issue #2325
2016-03-02 11:57:41 +02:00
Silvan Strübi
1b1c4ef0f5
AudioBufferSourceNode - same issue as on play:
...
I was able to reproduce this rare occurrence. It gets triggered by me in some cases when leaving focus and then resuming the sound. Same as we have had it only play, see => https://github.com/photonstorm/phaser/issues/2351
Cheers
2016-03-02 10:06:01 +09:00
photonstorm
08ce659447
Sound.position can no longer become negative, meaning calls to AudioContextNode.start with negative position offsets will no longer throw errors (thanks @Weedshaker #2351 )
2016-02-26 13:36:19 +00:00
photonstorm
15d952171c
SoundManager.destroy doesn't close the context if it's being stored in PhaserGlobal (thanks @brianbunch #2356 )
2016-02-26 13:31:45 +00:00
photonstorm
cc3a07bada
SoundManager.close now validates that context.close is a valid function before calling it (thanks @brianbunch #2355 )
2016-02-26 13:29:35 +00:00
Stoneman1
62f0a52544
Fixed issue with IE crashing on this.context.close() in SoundManager.js (There was no check if context exists)
2016-02-24 13:08:37 +02:00
Richard Davey
332fb6fe68
Fixed window global check.
2016-02-09 11:41:24 +00:00
Richard Davey
0610ddd15f
SoundManager.setTouchLock is no longer set if SoundManager.noAudio is true, or if the PhaserGlobal setting disableAudio is true (thanks @bcjordan #2206 )
2016-02-03 23:23:36 +00:00
