Mirrors/phaser
2
0
Fork 0
mirror of https://github.com/photonstorm/phaser synced 2025-02-17 06:28:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

Updating play method to return boolean indicating if play call was done successfully

Browse source
This commit is contained in:
Pavle Goloskokovic 2018-01-11 17:22:57 +01:00
parent 5aec2e45e4
commit c0c6e39ccd
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/sound/BaseSound.js
View file

@ -260,7 +260,7 @@ var BaseSound = new Class({
* @method Phaser.Sound.BaseSound#play
* @param {string} [markerName=''] - If you want to play a marker then provide the marker name here, otherwise omit it to play the full sound.
* @param {ISoundConfig} [config] - Optional sound config object to be applied to this marker or entire sound if no marker name is provided. It gets memorized for future plays of current section of the sound.
* @returns {ISound | null} This sound instance or 'null' if an error occurred.
* @returns {boolean} Whether the sound started playing successfully.
*/
play: function (markerName, config) {
if (markerName === void 0) { markerName = ''; }
@ -270,7 +270,7 @@ var BaseSound = new Class({
}
if (typeof markerName !== 'string') {
console.error('Sound marker name has to be a string!');
return null;
return false;
}
if (!markerName) {
this.currentMarker = null;
@ -280,7 +280,7 @@ var BaseSound = new Class({
else {
if (!this.markers[markerName]) {
console.error('No marker with name \'' + markerName + '\' found for sound \'' + this.key + '\'!');
return null;
return false;
}
this.currentMarker = this.markers[markerName];
this.currentConfig = this.currentMarker.config;
@ -290,7 +290,7 @@ var BaseSound = new Class({
this.currentConfig = Extend(this.currentConfig, config);
this.isPlaying = true;
this.isPaused = false;
return this;
return true;
},
/**
* Pauses the sound.