rust-clippy

mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-24 12:03:28 +00:00

Author	SHA1	Message	Date
flip1995	adc638ef33	Change Applicability of MISTYPED_LITERAL_SUFFIX	2018-11-27 16:59:39 +01:00
flip1995	4e74eef6e9	Add applicability level to (nearly) every span_lint_and_sugg function	2018-11-27 15:29:23 +01:00
flip1995	3740da203b	Fix bugs and improve documentation Some bugs and some documentation is unrelated to the Applicability change, but these bugs were serious and the documentation was kind of required to understand what's going on.	2018-11-27 15:29:23 +01:00
flip1995	9096269610	Add Applicability::Unspecified to span_lint_and_sugg functions	2018-11-27 15:29:23 +01:00
flip1995	fad267c3b3	Introduce snippet_with_applicability and hir_with_applicability functions	2018-11-27 15:29:14 +01:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	1e2291c90c	Merge pull request #3365 from gnieto/lint/slow-initialization Add slow vector initializations lint	2018-11-26 13:37:46 +01:00
Matthias Krüger	ae32c877a5	constants: add u128 i128 builtin types and fix outdated url	2018-11-26 01:12:12 +01:00
Guillem Nieto	dc35841be4	Update lints	2018-11-25 14:36:04 -08:00
Guillem Nieto	5fa04bc3cd	Lint only the first statment/expression after alloc Instead of searching for all the successive expressions after a vector allocation, check only the first expression. This is done to minimize the amount of false positives of the lint.	2018-11-25 14:34:23 -08:00
Guillem Nieto	39b02fdcd2	Fix some warnings related to Self	2018-11-25 14:34:23 -08:00
Guillem Nieto	5b77ee95dc	Rename some symbols Renamed some symbols in order to make them a little bit more accurate.	2018-11-25 14:34:23 -08:00
Guillem Nieto	2753f1cbd4	Split lint into slow and unsafe vector initalization	2018-11-25 14:34:23 -08:00
Guillem Nieto	9b4bc3b6ef	Add unsafe set_len initialization	2018-11-25 14:34:23 -08:00
Guillem Nieto	e0ccc9d9af	Add slow zero-filled vector initialization lint Add lint to detect slow zero-filled vector initialization. It detects when a vector is zero-filled with extended with `repeat(0).take(len)` or `resize(len, 0)`. This zero-fillings are usually slower than simply using `vec![0; len]`.	2018-11-25 14:34:23 -08:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	69d09fbfc6	Merge pull request #3439 from dtolnay/npbv Downgrade needless_pass_by_value to allow by default	2018-11-24 10:16:38 +01:00
Matthias Krüger	311c8e29b1	rustup https://github.com/rust-lang/rust/pull/54071/	2018-11-23 10:05:51 +01:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	ff7da3264e	Merge pull request #3447 from phansch/small_rename s/file_map/source_map	2018-11-22 15:08:13 +01:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	87ec0580f9	Merge branch 'master' into version_ids	2018-11-22 10:22:25 +01:00
Philipp Hansch	c4b08a5b0c	s/file_map/source_map	2018-11-22 07:53:59 +01:00
Matthias Krüger	f5929e0797	rust-lang-nursery/rust-clippy => rust-lang/rust-clippy	2018-11-22 04:40:09 +01:00
Wayne Warren	1fed72bad4	Address 'clippy::single-match' dogfood lint	2018-11-21 07:52:02 -06:00
Philipp Krones	d4a6ee4a0c	Fix nit Co-Authored-By: waynr <wayne.warren.s@gmail.com>	2018-11-21 07:52:02 -06:00
Wayne Warren	cb5e327c58	Address travis CI lint failure	2018-11-21 07:52:02 -06:00
Wayne Warren	92f7f9061c	issue#3318 run trivially_copy_pass_by_ref for traits	2018-11-21 07:52:02 -06:00
Oliver Scherer	617d861041	Enable rustup clippy to refer to the correct documentation	2018-11-21 13:33:42 +01:00
Matthias Krüger	4aae76464c	rustup https://github.com/rust-lang/rust/pull/52591	2018-11-21 13:29:23 +01:00
David Tolnay	e4be2b4e64	Downgrade needless_pass_by_value to allow by default I noticed that I suppress this lint in many of my projects. https://github.com/search?q=needless_pass_by_value+user%3Adtolnay&type=Code https://github.com/search?q=needless_pass_by_value+user%3Aserde-rs&type=Code Upon further inspection, this lint has a long history of false positives (and several remaining). Generally I feel that this lint is the definition of pedantic and should not be linted by default. #[derive(Debug)] enum How { ThisWay, ThatWay, } // Are we really better off forcing the call sites to write f(&_)...? fn f(how: How) { println!("You want to do it {:?}", how); } fn main() { f(How::ThatWay); }	2018-11-21 03:11:22 -08:00
bors[bot]	64ff255ac6	Merge #3432 3432: match_ref_pats: don't emit suggestions inside of a macro r=Manishearth a=flip1995 Fixes #2636 Co-authored-by: flip1995 <hello@philkrones.com>	2018-11-19 21:07:49 +00:00
Matthias Krüger	3a11cd4289	remove unused allow() attributes, NFC	2018-11-17 13:47:46 +01:00
flip1995	1000fc5120	Don't emit suggestion when inside of a macro	2018-11-15 17:03:17 +01:00
Matthias Krüger	2d0d41ff29	rustup https://github.com/rust-lang/rust/pull/55852/	2018-11-15 16:50:28 +01:00
bors[bot]	a2c9d10da5	Merge #3419 3419: Linter to check that all common metadata is included r=flip1995 a=ysimonson Addresses https://github.com/rust-lang-nursery/rust-clippy/issues/1793 This is not ready to be merged yet. First the associated changes to `cargo_metadata` need to be merged: https://github.com/oli-obk/cargo_metadata/pull/55 Co-authored-by: Yusuf Simonson <simonson@gmail.com>	2018-11-15 14:18:12 +00:00
Anton	93324f1acf	Fix "too" -> "foo" typo in format.rs	2018-11-14 14:08:52 +01:00
Michael Wright	3ba4c3a9b1	Fix `use_self` violation	2018-11-14 08:43:35 +02:00
Michael Wright	e2e892b59b	Fix wrong suggestion for `redundant_closure_call` Fixes #1684	2018-11-14 08:01:39 +02:00
Yusuf Simonson	866caabb7a	Check for common metadata	2018-11-13 08:43:30 -05:00
Michael Wright	5ade9ff44e	Fix `use_self` false positive on `use` statements	2018-11-13 06:15:33 +02:00
Michael Wright	460c2b317b	Fix `use_self` false positive This fixes the first error reported in issue #3410.	2018-11-10 10:57:11 +02:00
Michael Wright	c20e17f8ee	Remove `+` from `has_unary_equivalent` Rust doesn't has a unary + operator!	2018-11-06 07:05:13 +02:00
Michael Wright	2353f24095	Merge branch 'master' into fix-missing-comma-fp	2018-11-06 07:00:54 +02:00
Philipp Hansch	90f31e21ab	RIIR update lints: Add check mode (update_lints.py rewrite complete) This finishes up the rewrite of `update_lints.py` in Rust. More specifically, this * adds the `--check` flag and handling to clippy_dev * tracks file changes over the different calls to `replace_region_in_file` * only writes changes to files if the `--check` flag is not used * runs `./util/dev update_lints --check` on CI instead of the old script * replaces usage of the `update_lints.py` script with an error `./util/dev update_lints` behaves 99% the same as the python script. The only difference that I'm aware of is an ordering change to `clippy_lints/src/lib.rs` because underscores seem to be sorted differently in Rust and in Python. 🏁	2018-11-05 07:18:47 +01:00
bors[bot]	7e417d4cbd	Merge #3353 3353: float support added for mistyped_literal_suffixes lint r=mikerite a=Maxgy I implemented the mistyped_literal_suffixes lint for float literals. ``` #![allow(unused_variables)] fn main() { let x = 1E2_32; let x = 75.22_64; } ``` Given the above, the additional check suggests the variables to be written as `let x = 1E2_f32` and `let x = 75.22_f64`. Fixes #3167 Co-authored-by: Maxwell Anderson <maxwell.brayden.anderson@gmail.com>	2018-11-05 03:58:15 +00:00
Matthias Krüger	396701613e	rustup https://github.com/rust-lang/rust/pull/55665 (pass contexts by reference)	2018-11-04 22:47:20 +01:00
Maxwell Anderson	3e0de1745d	changed into_iter to iter and fixed a lint check	2018-11-04 10:39:54 -07:00
Michael Wright	a3ab512576	Fix `collapsible_if` error	2018-11-04 10:48:24 +02:00
Michael Wright	0c1ffc1d1f	Fix `possible_missing_comma` false positives `possible_missing_comma` should only trigger when the binary operator has unary equivalent. Otherwise, it's not possible to insert a comma without breaking compilation. The operators identified were `+`, `&`, `*` and `-`. This fixes the specific examples given in issues #3244 and #3396 but doesn't address the conflict this lint has with the style of starting a line with a binary operator.	2018-11-04 10:02:49 +02:00
Matthias Krüger	b59b60c8ae	rustup https://github.com/rust-lang/rust/pull/55330/	2018-11-03 18:50:23 +01:00
bors[bot]	486300b89d	Merge #3400 3400: Fix a false-positive of needless_borrow r=phansch a=sinkuu Co-authored-by: Shotaro Yamada <sinkuu@sinkuu.xyz>	2018-11-03 08:34:13 +00:00
flip1995	cadb367a5c	Also lint cfg_attr(.., rustfmt::skip)	2018-11-02 19:50:24 +01:00
flip1995	a770d8edd0	Differ between inner and outer attributes	2018-11-02 19:49:58 +01:00
flip1995	e1cf160e2a	Add cfg_attr(rustfmt) lint	2018-11-02 19:49:57 +01:00
kennytm	5563bd6cc3	Addressed comments.	2018-11-02 22:53:57 +08:00
kennytm	2b2acf1002	Fix dogfood error.	2018-11-02 22:53:57 +08:00
kennytm	2d1c9313b0	Added lints `into_iter_on_ref` and `into_iter_on_array`. Fix #1565 .	2018-11-02 22:53:56 +08:00
flip1995	32396f6e18	Allow single_match_else	2018-11-02 14:00:46 +01:00
flip1995	014cf3d6e0	Fix typos	2018-11-02 13:49:10 +01:00
flip1995	cf89c40e34	Fix dogfood error	2018-11-02 13:49:10 +01:00
flip1995	ea4a80f215	Fix typo and indentation	2018-11-02 13:49:10 +01:00
flip1995	f6d57862c7	Add new lint: unknwon_clippy_lintsg	2018-11-02 13:49:09 +01:00
Matthias Krüger	df7cff31dc	clippy: fix pedantic warnings and run clippy::pedantic lints on the codebase. Turn on pedantic lints in dogfood and base tests. needless_bool: fix clippy::items-after-statements redundant_pattern_matching: fix clippy::similar-names mods.rs: fix clippy::explicit-iter-loop returns.rs: allow clippy::cast-possible-wrap Fixes #3172	2018-11-02 12:16:43 +01:00
bors[bot]	7c86a9c05c	Merge #3387 3387: Replace big if/else expression with match r=flip1995 a=mikerite Co-authored-by: Michael Wright <mikerite@lavabit.com>	2018-11-02 07:58:00 +00:00
Shotaro Yamada	d4370f8b07	Fix a false-positive of needless_borrow	2018-11-02 15:58:54 +09:00
bors[bot]	0ad5b9b9e0	Merge #3388 3388: RIIR update lints: Generate deprecated lints r=phansch a=phansch The update script now also generates the 'register_removed' section in `clippy_lints/src/lib.rs`. Also, instead of using `let mut store ...`, I added a new identifier line so that the replacement will continue to work in case `let mut store ...` ever changes. cc #2882 Co-authored-by: Philipp Hansch <dev@phansch.net>	2018-11-02 06:29:40 +00:00
Maxwell Anderson	b6b97e5c1f	format code	2018-11-01 15:43:40 -06:00
Maxwell Anderson	6c1f89e8dc	Merge remote-tracking branch 'upstream/master'	2018-11-01 15:26:38 -06:00
Philipp Hansch	beb44ef6ca	Fix clippy build failure on latest master	2018-11-01 20:35:23 +01:00
Maxwell Anderson	02340cc891	fix comment spacing	2018-11-01 12:35:01 -06:00
Michael Wright	0a41dfd946	Use slice patterns instead of padding	2018-11-01 07:06:47 +02:00
Maxwell Anderson	98ce3348d9	change single char str to char	2018-10-31 18:09:56 -06:00
Maxwell Anderson	3c22b2314c	Merge remote-tracking branch 'upstream/master'	2018-10-31 16:48:47 -06:00
Maxwell Anderson	f4b919cad7	add lint to lintarray macro	2018-10-31 16:48:24 -06:00
Maxwell Anderson	6b895b8267	Revert "small fix" This reverts commit `b1abc81a60`.	2018-10-31 16:39:12 -06:00
bors[bot]	73458aebe3	Merge #3368 3368: added downsides to "known problems" for get_unwrap lint r=flip1995 a=humean As a beginner I found this lint to be confusing because I was not sure how the `Option` type disappeared as conceptually I know that my `.get()` and Index could fail. Initially I thought maybe the compiler or clippy was smart enough to understand that it was impossible for my `.get()` to fail in this particular case, but it was explained to me that using the Index syntax is just shorthand for directly unwrapping the value: https://doc.rust-lang.org/src/std/collections/hash/map.rs.html#1547 For beginners or users trying to iterate quickly it seems common to litter your code with `unwrap` or `except` as placeholders for where some explicit error handling might need to take place. I think it should be warned that using Index is merely more concise, but doesn't at all reduce the risk of panics and might in fact cause you to miss handling them in a future refactor. Co-authored-by: Michael Rutter <michael.john.rutter@gmail.com> Co-authored-by: Michael Rutter <humean@users.noreply.github.com>	2018-10-31 10:21:51 +00:00
bors[bot]	c8308c92b6	Merge #3378 3378: Fix lint_without_lint_pass r=phansch a=mikerite Co-authored-by: Michael Wright <mikerite@lavabit.com> Co-authored-by: flip1995 <hello@philkrones.com>	2018-10-31 07:18:42 +00:00
Philipp Hansch	64bd658516	RIIR update lints: Generate deprecated lints The update script now also generates the 'register_removed' section in `clippy_lints/src/lib.rs`. Also, instead of using `let mut store ...`, I added a new identifier line so that the replacement will continue to work in case `let mut store ...` ever changes.	2018-10-31 08:03:50 +01:00
bors[bot]	b144c7f35d	Merge #3370 3370: bool_comparison triggers 3 times on same code r=phansch a=mrbuzz Fix #3335 Co-authored-by: Giorgio Gambino <gambnio.giorgio@gmail.com>	2018-10-31 06:48:49 +00:00
Michael Wright	4e054ad320	Replace big if/else expression with match	2018-10-31 06:29:38 +02:00
Matthias Krüger	650eb09981	docs: use_self: hightlight the "should be" code sample as rust code as well.	2018-10-31 01:42:17 +01:00
Manish Goregaokar	a06296f836	Rustup to rustc 1.31.0-nightly (fb2446ad5 2018-10-30)	2018-10-30 04:06:37 +00:00
Giorgio Gambino	c0c1f1f7fa	Fix #3335 rev2: bool_comparison triggers 3 times on same code	2018-10-29 22:23:45 +01:00
flip1995	1e43c3bb9f	Register MISTYPED_LITERAL_SUFFIXES lint	2018-10-29 20:54:21 +01:00
flip1995	a7fc6799df	Rewrite registered lint collection	2018-10-29 20:44:45 +01:00
Michael Wright	267d5d3433	Fix lint_without_lint_pass	2018-10-29 20:28:06 +01:00
bors[bot]	14d2700b6f	Merge #3217 #3366 3217: Fix string_lit_as_bytes lint for macros r=phansch a=yaahallo Prior to this change, string_lit_as_bytes would trigger for constructs like `include_str!("filename").as_bytes()` and would recommend fixing it by rewriting as `binclude_str!("filename")`. This change updates the lint to act as an EarlyLintPass lint. It then differentiates between string literals and macros that have bytes yielding alternatives. Closes #3205 3366: Don't expand macros in some suggestions r=oli-obk a=phansch Fixes #1148 Fixes #1628 Fixes #2455 Fixes #3023 Fixes #3333 Fixes #3360 Co-authored-by: Jane Lusby <jlusby42@gmail.com> Co-authored-by: Philipp Hansch <dev@phansch.net>	2018-10-28 17:13:34 +00:00
Giorgio Gambino	7cfde9cfa9	Fix #3335 : bool_comparison triggers 3 times on same code	2018-10-28 15:37:39 +01:00
Matthias Krüger	6eb1f23555	rustup: fix build with rustc 1.31.0-nightly (cae6efc37 2018-10-27)	2018-10-28 13:56:50 +01:00
Michael Rutter	232a483331	more consistent use of terminology; trait > syntax	2018-10-28 12:31:02 +00:00
Michael Rutter	061a48321c	added downsides to "known problems" for get_unwrap lint	2018-10-28 08:12:47 +00:00
Maxwell Anderson	183e19a1c3	Merge remote-tracking branch 'upstream/master'	2018-10-27 12:50:12 -06:00
Philipp Hansch	840e50e97f	Don't expand macro in or_fun_call suggestion	2018-10-27 15:47:56 +02:00
Philipp Hansch	af1548f58f	Don't expand macro in single_match suggestion	2018-10-27 15:47:56 +02:00
Philipp Hansch	aa7bcb9074	Don't expand macro in identity_conversion suggestion	2018-10-27 15:47:56 +02:00
Jane Lusby	19ac2e94c6	fix: correctly reconstruct raw strings	2018-10-26 09:12:01 -07:00
Jane Lusby	f9020bb2dd	fix: extra semicolon, only create callsite once	2018-10-26 09:12:01 -07:00
Jane Lusby	c209fc9349	Fix string_lit_as_bytes lint for macros Prior to this change, string_lit_as_bytes would trigger for constructs like `include_str!("filename").as_bytes()` and would recommend fixing it by rewriting as `binclude_str!("filename")`. This change updates the lint to act as an EarlyLintPass lint. It then differentiates between string literals and macros that have bytes yielding alternatives. Closes #3205	2018-10-26 09:12:01 -07:00
bors[bot]	457e7f12e9	Merge #3355 3355: Lint to remove redundant `clone()`s r=oli-obk a=sinkuu This PR adds lint `redundant_clone`. It suggests to remove redundant `clone()` that clones a owned value that will be dropped without any usage after that. Real-world example: https://github.com/rust-lang/rust/compare/7b0735a..sinkuu:redundant_clone2 Co-authored-by: Shotaro Yamada <sinkuu@sinkuu.xyz>	2018-10-26 10:36:43 +00:00
bors[bot]	ead29847ff	Merge #3357 3357: Check existential types in `use_self` r=oli-obk a=HMPerson1 Fixes #3231 Co-authored-by: HMPerson1 <hmperson1@gmail.com>	2018-10-26 08:48:12 +00:00
Shotaro Yamada	9034b87a53	Move in_macro check	2018-10-26 03:07:29 +09:00
Shotaro Yamada	a828692780	Use BasicBlockData::terminator	2018-10-26 01:27:28 +09:00
Shotaro Yamada	6d6ff88585	Refactor	2018-10-26 01:16:14 +09:00
Shotaro Yamada	9a150b4aa1	Use lint_root	2018-10-26 01:16:14 +09:00
Shotaro Yamada	24d3f5b48f	Implement visit_basic_block_data	2018-10-26 01:16:14 +09:00
Shotaro Yamada	3ca0895920	Add redundant_clone lint	2018-10-26 01:15:55 +09:00
Matthias Krüger	b8a9099011	Revert "new_ret_no_self: add sample from #3313 to Known Problems section." This reverts commit `fd2f6dd382`. Issue #3313 has been fixed.	2018-10-25 13:39:02 +02:00
bors[bot]	a87e1b02ab	Merge #3331 3331: Disable arithmetic lints in constant items r=oli-obk a=pengowen123 Currently this will not catch cases in associated constants. I'm not sure whether checking spans is the best way to solve this issue, but I don't think it will cause any problems. Fixes #1858 Co-authored-by: Owen Sanchez <pengowen816@gmail.com>	2018-10-25 09:38:00 +00:00
Philipp Krones	5dbca1f6b1	Add `Applicability`	2018-10-24 23:39:54 -04:00
HMPerson1	aabf8083bd	Add lint for calling `mem::discriminant` on a non-enum type	2018-10-24 23:39:54 -04:00
HMPerson1	3db14f182c	Check existential types in `use_self`	2018-10-24 23:32:33 -04:00
Owen Sanchez	0b9e9c9e3d	Disable arithmetic lints in constant items	2018-10-24 20:27:26 -07:00
bors[bot]	4c6201dceb	Merge #3312 3312: OUT_OF_BOUNDS_INDEXING false negative r=phansch a=JoshMcguigan fixes #3102 Co-authored-by: Josh Mcguigan <joshmcg88@gmail.com>	2018-10-24 21:17:43 +00:00
bors[bot]	44fb29a356	Merge #3356 3356: Fix warnings introduced by #3349 r=flip1995 a=flip1995 I missed these warnings during review, should have checked the Travis log first. Co-authored-by: flip1995 <hello@philkrones.com>	2018-10-24 15:25:12 +00:00
bors[bot]	bce190558f	Merge #3338 3338: new_ret_no_self false positives r=flip1995 a=JoshMcguigan ~~WORK IN PROGRESS~~ I plan to fix all of the false positives in #3313 in this PR, but I wanted to open it now to start gathering feedback. In this first commit, I've updated the lint to allow tuple return types as long as `Self` shows up at least once, in any position of the tuple. I believe this is the broadest possible interpretation of what should be allowed for tuple return types, but I would certainly be okay making the lint more strict. fixes #3313 Co-authored-by: Josh Mcguigan <joshmcg88@gmail.com>	2018-10-24 14:42:40 +00:00
flip1995	57a18b6520	Fix warnings introduced by #3349	2018-10-24 16:18:01 +02:00
bors[bot]	319b75c75b	Merge #3349 3349: Fixes #3347: Lint for wildcard dependencies in Cargo.toml r=ordovicia a=ordovicia Add a lint for wildcard dependencies in Cargo.toml. How should I write a test for this lint? Fixes #3347 Co-authored-by: Hidehito Yabuuchi <hdht.ybuc@gmail.com>	2018-10-24 12:21:19 +00:00
Hidehito Yabuuchi	99b78f0650	Replace remaining `krate.span` with `DUMMY_SP`	2018-10-24 21:15:27 +09:00
Hidehito Yabuuchi	0d577c36a9	Use DUMMY_SP in multiple_crate_versions	2018-10-24 20:22:38 +09:00
Hidehito Yabuuchi	663f2cff7e	Some fixes for wildcard_dependencies	2018-10-24 20:19:13 +09:00
bors[bot]	03f8899fa5	Merge #3350 3350: Don't emit `new_without_default_derive` if an impl of Default exists regardless of generics r=oli-obk a=pengowen123 Fixes #2226 Co-authored-by: Owen Sanchez <pengowen816@gmail.com>	2018-10-24 07:59:06 +00:00
Hidehito Yabuuchi	fa6c9f838c	Minor changes on clippy_lints/src/wildcard_dependencies.rs	2018-10-24 15:00:28 +09:00
Hidehito Yabuuchi	0263ddde92	Lint for wildcard dependencies in Cargo.toml	2018-10-24 15:00:28 +09:00
bors[bot]	122da1de3b	Merge #3339 3339: Check for known array length in `needless_range_loop` r=phansch a=HMPerson1 In `VarVisitor`, we now keep track of the type of the thing that was directly indexed and, if it's an array, check if the range's end is (or is past) the array's length. Fixes #3033 Co-authored-by: HMPerson1 <hmperson1@gmail.com>	2018-10-24 05:45:02 +00:00
Owen Sanchez	50b9e7aebc	Don't emit `new_without_default_derive` if an impl of Default exists	2018-10-23 20:44:31 -07:00
Maxwell Anderson	b1abc81a60	small fix	2018-10-23 16:35:09 -06:00
Maxwell Anderson	6a695ffb3d	added float support for mistyped literal lints	2018-10-23 15:54:27 -06:00
Maxwell Anderson	83ca8d4984	Merge remote-tracking branch 'upstream/master'	2018-10-23 15:24:05 -06:00
Guillem Nieto	fd3651a551	Fix inspector pass documentation When using `#[clippy_dump]`, the compiler complains about an unknown attribute. The correct one seems to be `#[clippy::dump]`.	2018-10-23 23:03:23 +02:00
Josh Mcguigan	a624583557	new_ret_no_self added test cases	2018-10-20 06:29:17 -07:00
Josh Mcguigan	079f9f45b5	new_ret_no_self walk return type to check for self	2018-10-19 17:54:25 -07:00
HMPerson1	2e9172aea2	Check for known array length in `needless_range_loop`	2018-10-19 16:34:16 -04:00
HMPerson1	2a9dec681f	Fix suggestion for multiple derefs	2018-10-19 14:51:25 -04:00
Josh Mcguigan	097df8f223	new_ret_no_self correct false positive on raw pointer return types	2018-10-19 05:20:33 -07:00
Josh Mcguigan	6e75050be0	new_ret_no_self correct linting of tuple return types	2018-10-19 04:55:06 -07:00
HMPerson1	a2be050965	Fix `clone_on_copy` not detecting derefs sometimes	2018-10-19 00:03:56 -04:00
Maxwell Anderson	9f637288cf	Merge remote-tracking branch 'upstream/master'	2018-10-18 15:45:05 -06:00
Matthias Krüger	fd2f6dd382	new_ret_no_self: add sample from #3313 to Known Problems section. fix trivial typo on the way	2018-10-18 23:37:43 +02:00
Philipp Hansch	8f5a2484a0	Merge pull request #3303 from shssoichiro/3069-unnecessary-fold-pattern-guard Note known false positives in unnecessary_fold lint	2018-10-18 22:26:33 +02:00
Lukas Stevens	5614dcb4ea	Support multiline comments and hopefully fix panic	2018-10-18 18:57:16 +02:00
Lukas Stevens	8753e568bf	Check for comments in collapsible ifs	2018-10-18 18:00:21 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	1264bb6b7d	Merge pull request #3323 from pengowen123/fix_manual_memcpy Simplify manual_memcpy suggestion in some cases	2018-10-18 09:44:24 +02:00
Philipp Hansch	adbaa85ee9	Merge pull request #3330 from shssoichiro/3309-goblin-ice Resolve ICE in needless range loop lint	2018-10-17 21:01:15 +02:00
Joshua Holmer	4b68c965fe	Resolve ICE in needless range loop lint An ICE would occur if the needless range loop was triggered within a procedural macro, because Clippy would try to produce a code suggestion which was invalid, and caused the compiler to crash. This commit takes the same approach which Clippy currently takes to work around this type of crash in the needless pass by value lint, which is to skip the lint if Clippy is inside of a macro.	2018-10-17 10:43:32 -04:00
Philipp Hansch	284c63e84d	Merge pull request #3281 from CYBAI/redundant-match Add lint for redundant pattern matching for explicit return boolean	2018-10-17 07:31:09 +02:00
CYBAI	66ae3b1249	Rename if_let_redundant_pattern_matching to redundant_pattern_matching Also, making the old one deprecated	2018-10-17 11:20:42 +08:00
CYBAI	3b7c88888b	Add lint for redundant pattern matching for explicit return boolean	2018-10-17 11:14:37 +08:00
Giorgio Gambino	aa88e68902	Fix issue #3322 : reword help message for len_zero	2018-10-16 23:23:31 +02:00
Owen Sanchez	8c902d1cf2	Simplify manual_memcpy suggestion in some cases	2018-10-16 12:38:23 -07:00
Joshua Holmer	33847b579e	Update known problems for unnecessary_fold	2018-10-16 09:04:02 -04:00
Bruno Kirschner	2d8b4f3d5c	Avoid linting `boxed_local` on trait implementations.	2018-10-15 20:34:45 +02:00
Josh Mcguigan	66d3672b26	out_of_bounds_indexing improved reporting of out of bounds value	2018-10-15 04:44:39 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	0f4b13bc1b	Merge pull request #3316 from pengowen123/fix_needless_range_loop Swap order of methods in `needless_range_loop` suggestion for efficiency in some cases	2018-10-15 09:33:21 +02:00
Owen Sanchez	456843f1cd	Swap order of methods in `needless_range_loop` suggestion in some cases	2018-10-14 20:14:16 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	212a4fe4f4	fix for rustc master	2018-10-14 22:55:26 +02:00
Josh Mcguigan	5c39282826	out_of_bounds_indexing refactoring	2018-10-14 07:49:28 -07:00
Matthias Krüger	c492818110	mem_forget: fix syntax error in code sample	2018-10-14 10:30:04 +02:00
Josh Mcguigan	0f3345e8b2	OUT_OF_BOUNDS_INDEXING fix #3102 false negative	2018-10-13 13:51:53 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	601cc9d2c5	Merge pull request #3310 from JoshMcguigan/explicit_counter_loop-3308 explicit_counter_loop fix #3308 false positive	2018-10-13 20:11:50 +02:00
Josh Mcguigan	c6f79c7ba0	explicit_counter_loop fix #3308 false positive	2018-10-13 06:57:52 -07:00
Josh Mcguigan	54506705ce	Added new_ret_no_self exception to clippy to pass dogfood tests	2018-10-13 06:25:10 -07:00
Josh Mcguigan	a5e4805ecf	new_ret_no_self correctly lint impl return	2018-10-13 06:20:39 -07:00
Josh Mcguigan	2ef4af7db2	Removed unused variables	2018-10-13 06:20:39 -07:00
Josh Mcguigan	1c4fa419f3	new_ret_no_self fix false positive for impl trait return with associated type self	2018-10-13 06:20:39 -07:00
Josh Mcguigan	13ce96c4bf	new_ret_no_self corrected panic and added test stderr	2018-10-13 06:20:39 -07:00
Josh Mcguigan	eb854b233c	new_ret_no_self added positive test cases	2018-10-13 06:20:39 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	8b12eee112	Merge pull request #3233 from rust-lang-nursery/unused-unit new lint: unused_unit	2018-10-13 09:30:19 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	78860a71d8	Merge pull request #3298 from devonhollowood/pedantic-dogfood-naming Pedantic dogfood: naming and docs	2018-10-13 09:24:55 +02:00
Devon Hollowood	335bc1e820	Fix some more `stutter` warnings	2018-10-12 17:07:48 -07:00
Andre Bogus	e8687a6677	unused unit lint	2018-10-13 00:42:55 +02:00
Joshua Holmer	863c8e26fc	Revert "Exclude pattern guards from unnecessary_fold lint" This reverts commit `d3c06f7252`.	2018-10-12 13:15:55 -04:00
Joshua Holmer	d3c06f7252	Exclude pattern guards from unnecessary_fold lint Methods like `Iterator::any` borrow the iterator mutably, which is not allowed within a pattern guard and will fail to compile. This commit prevents clippy from suggesting this type of change. Closes #3069	2018-10-12 12:11:56 -04:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	d445dbfe16	Merge pull request #3291 from JoshMcguigan/cmp_owned-3289 cmp_owned wording and false positive	2018-10-12 15:07:12 +02:00
Josh Mcguigan	352863065c	cmp_owned refactor	2018-10-12 04:48:54 -07:00
Josh Mcguigan	c9718fa589	cmp_owned correct error message if rhs is deref	2018-10-12 04:34:41 -07:00
sigustin	4e20625187	Add a comment reminding to update README if the default changes	2018-10-12 12:32:48 +02:00
Maxwell Anderson	63fbeaab68	Merge remote-tracking branch 'upstream/master'	2018-10-11 22:16:05 -06:00
Maxwell Anderson	9fad38dca9	tmp progress	2018-10-11 22:15:01 -06:00
Devon Hollowood	73ba33dd2b	Fix `doc_markdown` lints	2018-10-11 15:43:13 -07:00
Devon Hollowood	dcef9d0795	Fix `stutter` lints	2018-10-11 15:42:22 -07:00
Devon Hollowood	9afd8abbe3	Fix `similar_names` warnings Most of these are just `#![allow]`ed, because they are things like using l vs r to differentiate left vs right. These would be made less clear by taking the advice of `similar_names`	2018-10-11 15:18:58 -07:00
Josh Mcguigan	0b65462ca5	cmp_owned current suggestion for multiple deref	2018-10-11 05:03:02 -07:00
Oliver Scherer	9d3373137b	Remove now-useless `allow(unknown_lints)`	2018-10-11 12:18:27 +02:00
Oliver Scherer	b8654eaa6c	Stabilize tool lints	2018-10-11 12:16:22 +02:00
Philipp Hansch	8b45dd704b	Merge pull request #3294 from mikerite/fix-3276 Fix fn_to_numeric_cast_with_truncation suppression	2018-10-11 10:53:05 +02:00
Philipp Hansch	928a6d3dc7	Merge pull request #3288 from devonhollowood/pedantic-dogfood-casts Pedantic dogfood: casts	2018-10-11 08:07:51 +02:00
Michael Wright	80cf0d7f26	Fix fn_to_numeric_cast_with_truncation suppression Fixes #3276	2018-10-11 07:45:26 +02:00
mikerite	31eb3b73d3	Merge pull request #3127 from mikerite/fix-2937 Fix 2937	2018-10-11 06:22:02 +02:00
Karim SENHAJI	f9e4f5695d	Limit commutative assign op lint to primitive types	2018-10-10 19:10:44 +02:00
Devon Hollowood	289c642d1a	Clarify code Take advantage of the fact that very large regexes are unlikely	2018-10-09 23:35:10 -07:00
Michael Wright	7499cb543d	Fix #2937	2018-10-10 07:52:58 +02:00
Josh Mcguigan	88ee209a1d	Corrected single-character string constant used as pattern found in dogfood test	2018-10-09 20:01:12 -07:00
Josh Mcguigan	b0d7aea946	Fixes 3289, cmp_owned wording and false positive	2018-10-09 19:25:03 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	f6882ede4d	Merge pull request #3287 from JoshMcguigan/cmp_owned-2925 cmp_owned false positive	2018-10-09 10:01:31 +02:00
Devon Hollowood	2b9abc5daa	Fix cast_possible_wrap and cast_sign_loss warnings	2018-10-08 22:34:10 -07:00
Devon Hollowood	eef2e8948b	Fix cast_possible_truncation warnings	2018-10-08 21:40:21 -07:00
Josh Mcguigan	ad5c29a445	Fixes #2925 cmp_owned false positive	2018-10-08 19:04:29 -07:00
Matthias Krüger	a578cb2d62	if_let_redundant_pattern_matching: use Span.to() instead of Span.with_hi() to fix crash. Fixes #3064	2018-10-08 17:34:43 +02:00
Rotem Yaari	1ef32e4096	Improve diagnostics in case of lifetime elision (closes #3284 )	2018-10-08 13:07:21 +03:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	02705d4cf5	Merge pull request #3282 from JoshMcguigan/excessive_precision-2840 Fix excessive_precision false positive	2018-10-08 08:24:13 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	ce2da2c04f	Merge pull request #3283 from etaoins/dont-suggest-cloned-for-map-box-deref Don't suggest cloned() for map Box deref	2018-10-08 08:21:59 +02:00
Philipp Hansch	41e94dd072	Merge pull request #3285 from devonhollowood/pedantic-dogfood-items-after-statements Pedantic dogfood: `items_after_statements`	2018-10-08 06:59:55 +01:00
Devon Hollowood	82638e4dd4	Fix items_after_statements for `const`s	2018-10-07 17:09:32 -07:00
Devon Hollowood	be983fbf52	Fix items_after_statements for sub-functions	2018-10-07 17:09:32 -07:00
Devon Hollowood	6528749083	Fix items_after_statements for `use` statements	2018-10-07 17:09:32 -07:00
Ryan Cumming	9bd4e5469e	Don't suggest cloned() for map Box deref Boxes are a bit magic in that they need to use `` to get an owned value out of the box. They implement `Deref` but that only returns a reference. This means an easy way to convert an `Option<Box<T>>` to an `<Option<T>` is: ``` box_option.map(\|b\| b) ``` However, since `b36bb0a6` the `map_clone` lint is detecting this as an attempt to copy the box. Fix by excluding boxes completely from the deref part of this lint. Fixes #3274	2018-10-08 06:20:32 +11:00
Josh Mcguigan	8a77a25b8a	Fix excessive_precision false positive	2018-10-07 11:38:20 -07:00
Philipp Hansch	63ceabf0cf	Merge pull request #3280 from d-dorazio/fix-new_without_default-should-not-fire-unsafe-new new_without_default should not warn about unsafe new	2018-10-07 13:09:37 +01:00
Manish Goregaokar	5dcb90e29d	Merge pull request #3279 from phansch/fix_fp_in_fn_to_numeric_cast_with_truncation Fix FP in `fn_to_numeric_cast_with_truncation`	2018-10-07 04:27:51 -07:00
Philipp Hansch	d365742bc6	Fix FP in `fn_to_numeric_cast_with_truncation` We only want this lint to check casts to numeric, as per the lint title. Rust already has a built-in check for all other casts [here][rust_check]. [rust_check]: `5472b0718f/src/librustc_typeck/check/cast.rs (L430-L433)`	2018-10-07 12:50:36 +02:00
Daniele D'Orazio	59c4ff77f1	new_without_default should not warn about unsafe new	2018-10-07 12:39:54 +02:00
Dylan Maccora	d129d049c6	Adding more detail to filter_map lint documentation.	2018-10-07 11:24:09 +11:00
Manish Goregaokar	e9c025ea70	Add license header to Rust files	2018-10-06 09:43:08 -07:00
Manish Goregaokar	53d41e5c50	Rustup for https://github.com/rust-lang/rust/pull/54741	2018-10-05 13:41:40 -07:00
Manish Goregaokar	cbde8201c5	Remove unused utils	2018-10-05 13:26:39 -07:00
Manish Goregaokar	75965030c7	Merge pull request #3251 from rust-lang-nursery/relicense-rewrite [do not merge] Relicensing rewrite	2018-10-05 20:14:55 +02:00
Philipp Hansch	1544a1a681	Merge remote-tracking branch 'origin/master' into relicense-rewrite	2018-10-05 07:18:24 +02:00
Joel Gallant	163780ee0b	Solves #3222 by checking the BareFnTy Abi type	2018-10-04 18:49:03 -06:00
Philipp Hansch	391d53db66	Add hidden lifetime parameters to fix warning	2018-10-04 21:59:30 +02:00
Philipp Hansch	c0ab8b2531	Reimplement the `fn_to_numeric_cast_with_truncation` lint	2018-10-04 21:44:16 +02:00
Philipp Hansch	7adf24ebb0	Improve docs of fn_to_numeric_cast Closes #2980	2018-10-04 18:09:09 +02:00
Matthias Krüger	fd5ea0ddf7	resolve build warnings in clippy_lints/src/format.rs	2018-10-04 16:34:41 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	c3e3be374b	Merge pull request #3256 from rust-lang-nursery/fix-2796 Fix 2796 and 3020	2018-10-04 08:51:00 +02:00
mcarton	5173ed0c03	Don't suggest `to_string().to_string` in USELESS_FORMAT	2018-10-03 20:59:59 +02:00
Philipp Hansch	f42272102a	Reimplement the `fn_to_numeric_cast` lint	2018-10-03 12:02:06 +02:00
Manish Goregaokar	c430147942	Fix push_item_path call (rustup to 4cf11765dc98536c6eedf33f2df7f72f6e161263)	2018-10-03 02:06:26 -07:00
mcarton	7eebd5b20c	Ignore `format!` with precision in `USELESS_FORMAT`	2018-10-02 23:57:22 +02:00
Oliver Schneider	913a5c9b56	Trailing newline	2018-10-02 15:18:56 +02:00
Oliver Schneider	696dc369df	FIx dogfood	2018-10-02 15:17:56 +02:00
Oliver Schneider	b36bb0a68d	Reimplement the `map_clone` lint from scratch	2018-10-02 15:13:43 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	11cc8472a9	Merge pull request #3245 from JoshMcguigan/wrong_self_convention-1530 Correct false positive in wrong_self_convention lint for to_mut	2018-10-02 14:54:36 +02:00
Josh Mcguigan	f142098474	Correct false positive in wrong_self_convention lint for to_mut	2018-10-02 04:47:38 -07:00
Manish Goregaokar	057243f16b	relicensing: Remove map_clone This removes the code added in https://github.com/rust-lang-nursery/rust-clippy/pull/427	2018-10-02 12:51:38 +02:00
Manish Goregaokar	fffcd093b2	relicensing: Remove fn_to_numeric_cast, fn_to_numeric_cast_with_truncation This removes the code added in https://github.com/rust-lang-nursery/rust-clippy/pull/2814	2018-10-02 12:49:27 +02:00
Manish Goregaokar	be1094bd8d	ScalarMaybeUndef -> Scalar (Rustup to e812ca472a2a5284e9f15cd9af32285d7ff3fd39)	2018-10-02 10:35:26 +02:00
Philipp Hansch	eb5f146f14	Fix 'impossible case reached' ICE	2018-10-01 22:34:52 +02:00
Michael Wright	50133fbd3a	Merge branch 'master' into unnecessary_filter_map	2018-09-30 06:39:56 +02:00
Josh Mcguigan	e25f884e6f	Fixes #3180 , suppress excessive_precision lint for floats with no decimal part	2018-09-29 07:39:30 -07:00
Michael Wright	c2ee9c29ab	Merge branch 'master' into unnecessary_filter_map	2018-09-29 15:27:47 +02:00
Michael Wright	06f6b36025	rustfmt	2018-09-29 14:18:50 +02:00
Michael Wright	efdc739dfc	Move unnecessary_filter_map to a submodule	2018-09-29 14:12:40 +02:00
Philipp Krones	67d85bc47d	Merge pull request #3224 from matthiaskrgr/clippy_self__use_self fix some clippy::pedantic warnings found in the codebase.	2018-09-28 15:26:50 +02:00
Philipp Hansch	8e808664fa	Merge pull request #3178 from ms2300/bad_unwrap Fix for bad get unwrap suggestion	2018-09-28 07:38:00 +01:00
Michael Wright	4b4d758ce0	Fix warnings in clippy_lints	2018-09-27 06:29:48 +02:00
Michael Wright	2f364d9ac5	Merge branch 'master' into unnecessary_filter_map	2018-09-27 06:12:01 +02:00
Matthias Krüger	9fae4693f9	fix clippy::single-match-else and clippy::match_same_arms warnings in clippys codebase	2018-09-26 22:25:01 +02:00
Matthias Krüger	2a31937cc9	fix all clippy::use_self pedantic warnings found in the codebase. cc #3172	2018-09-26 22:24:18 +02:00
Matthias Krüger	fc35c20a0a	rustup fix breakage by https://github.com/rust-lang/rust/pull/53824 use smallvec crate instead of rustcs type alias.	2018-09-26 15:57:38 +02:00
Michael Wright	f5ffac4fce	Implement unnecesary_filter_map lint	2018-09-26 06:52:36 +02:00
Jane Lusby	14feb3670f	Lint for chaining flatten after map This change adds a lint to check for instances of `map(..).flatten()` that can be trivially shortened to `flat_map(..)` Closes #3196	2018-09-24 14:29:16 -07:00
Michael Wright	ab71f08663	Fix single_char_pattern crash (#3204 ) This commit fixes the crash by removing constant checking from the lint. Closes #3204.	2018-09-24 08:33:57 +02:00
ms2300	523ba2a009	Full fix of get unwrap issue	2018-09-23 19:53:25 -07:00
ms2300	de8d233b06	#3006 : Fixing for .get().unwrap().foo()	2018-09-23 19:53:25 -07:00
Philipp Krones	bc6d85ceaf	Merge pull request #3207 from mikerite/fix-3206 Fix double_parens false positive	2018-09-23 18:24:27 +02:00
Philipp Krones	af2d6a0c14	Merge pull request #3191 from vi/suggest_with_applicability Use span_suggestion_with_applicability instead of span_suggestion	2018-09-23 15:45:55 +02:00
Michael Wright	867ac98d38	Fix double_parens false positive Closes #3206	2018-09-22 17:20:34 +02:00
flip1995	987b34d090	Another Applicability adjustment	2018-09-20 14:38:48 +02:00
Vitaly _Vi Shukela	52fb7d461e	Applicability adjustment per additional comments	2018-09-20 14:38:48 +02:00
Vitaly _Vi Shukela	58729346be	Fill in Applicability from review comments by @flip1995	2018-09-20 14:38:48 +02:00
Vitaly _Vi Shukela	3eccccb367	Fix indents	2018-09-20 14:38:48 +02:00
Vitaly _Vi Shukela	2781cac839	Apply subset of "cargo fmt".	2018-09-20 14:38:47 +02:00
Vitaly _Vi Shukela	3e853a632e	Add forgotten function: span_suggestions to the previous refactoting	2018-09-20 14:38:47 +02:00
Vitaly _Vi Shukela	d4c994e670	Supplement DiagnosticBuilderExt with Applicability	2018-09-20 14:38:47 +02:00
Vitaly _Vi Shukela	92034e20c8	Use span_suggestion_with_applicability instead of span_suggestion	2018-09-20 14:38:47 +02:00
Jay Kickliter	79cda3bb1e	mem_replace: fix grammar.	2018-09-19 14:54:38 -07:00
Jay Kickliter	2f53aaa5bd	mem_replace: match on path.	2018-09-19 14:41:22 -07:00
Jay Kickliter	12c7bc1e58	mem_replace: apply update_lints tool.	2018-09-19 14:41:22 -07:00
Jay Kickliter	1b6d739ce3	mem_replace: make examples compilable.	2018-09-19 14:38:34 -07:00
Jay Kickliter	598df08d88	Add lint for `mem::replace(.., None)`. Suggest `Option::take()` as an alternative.	2018-09-19 14:38:34 -07:00
Philipp Hansch	b6707ffc42	Merge pull request #3187 from flip1995/internal_fn New internal lint: compiler_lint_functions	2018-09-19 19:43:48 +01:00
flip1995	a8b681cc2c	Fix c_void path This got changed in rust-lang/rust#53910	2018-09-17 11:20:27 +02:00
Michael Wright	c78cf042ff	Remove unneeded check for method call The check can be removed because the call to `method_chains_args` already performs this check.	2018-09-16 13:08:00 +02:00
flip1995	021748eb6a	Replace another occurrence of "".to_owned()	2018-09-15 11:25:40 +02:00
Matthias Krüger	f3add4acb4	convert "".to_string() and "".to_owned() to String::new()	2018-09-15 11:20:35 +02:00
flip1995	144281c537	Formatting	2018-09-15 11:02:00 +02:00
flip1995	a4e1a90705	Fix warnings of compiler_lint_functions	2018-09-15 11:02:00 +02:00
flip1995	aaeeaa5330	Add internal lint compiler_lint_functions	2018-09-15 11:01:16 +02:00
Eduard-Mihai Burtescu	85caaf5905	Fix `useless_attribute` to also whitelist `unused_extern_crates`.	2018-09-15 11:16:45 +03:00
Eduard-Mihai Burtescu	9219fc6c5c	Reintroduce `extern crate` for non-Cargo dependencies.	2018-09-15 11:10:51 +03:00
flip1995	f49f133cba	Fix pedantic filter_map warnings	2018-09-14 12:56:25 +02:00
Manish Goregaokar	7b530c79b2	Add match on StructCtor	2018-09-14 12:41:20 +05:30
Philipp Hansch	dac5e2d3a5	Merge pull request #3140 from matthiaskrgr/redundant_casts fix warnings about trivial casts, mostly {i,u}128 -> {i,u}128, such as "i128::min_value() as i128"	2018-09-13 20:37:13 +01:00
Philipp Hansch	07cb45bc85	Merge pull request #3166 from flip1995/travis_internal Run internal lints on the Clippy code base	2018-09-13 17:22:48 +01:00
Matthias Krüger	28424ecbfa	fix warnings about trivial casts, mostly {i,u}128 -> {i,u}128, such as "i128::min_value() as i128"	2018-09-13 07:59:12 +02:00
Philipp Hansch	e8400061bd	Merge pull request #3085 from mikerite/revert-98dbce Revert "Fix E0502 warnings"	2018-09-13 06:33:26 +01:00
Boyu Yang	4827ab978e	Remove a wrong suggestion.	2018-09-13 13:01:23 +08:00
Boyu Yang	60e8da1647	Fix typo in examples.	2018-09-13 11:51:58 +08:00
flip1995	e28440d2e0	Change Hash{Map, Set} to FxHash{Map, Set}	2018-09-12 01:34:52 +02:00
flip1995	cfa3c33b1d	Fix lint_without_lint_pass lint	2018-09-12 01:34:04 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	1c1030f83f	Merge pull request #3152 from PSeitz/master fixes #3151 by skipping the lint instead of crashing	2018-09-10 13:44:47 +02:00
Pascal Seitz	d512c2bcce	add spaces	2018-09-10 09:03:33 +02:00
Philipp Krones	f30cf51a70	Merge pull request #3135 from JoshMcguigan/explicit_counter_loop-1219 Closes #1219 false positive for explicit_counter_loop	2018-09-09 23:49:03 +02:00
Pascal Seitz	43549ebbf8	fixes #3151 by skipping the lint instead of crashing	2018-09-08 15:30:50 +02:00
Josh Mcguigan	9168746c38	Corrected explicit_counter_loop behavior with nested loops	2018-09-07 20:46:36 -07:00
Josh Mcguigan	53c262048c	Fix #1219 false positive for explicit_counter_loop	2018-09-07 19:58:19 -07:00
Matthias Krüger	f6935be71e	clippy_lints: enable crate_visibility_modifier since it is used but no longer part of 2018 edition. Fixes build with https://github.com/rust-lang/rust/pull/53999	2018-09-08 01:32:40 +02:00
flip1995	fa3e3cb6ea	Fix #3145 by removing assert	2018-09-07 17:18:00 +02:00
Josh Mcguigan	ce554267b8	Updated explicit_counter_loop tests based on discussion in #3135	2018-09-07 05:32:56 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	63a46b1e1a	Merge pull request #3129 from mipli/3091-numeric-typo Add lint for misstyped literal casting	2018-09-07 09:54:43 +02:00
Michael A. Plikk	7bf8d8ba09	Simplified boolean expression for checking literal suffixes	2018-09-06 17:19:38 +02:00
Michael A. Plikk	986c772c24	Reduce number of split_at calls	2018-09-06 16:26:17 +02:00
Josh Mcguigan	edfa9feac2	Corrected explicit_counter_loop missing lints if variable used after loop	2018-09-06 06:20:25 -07:00
Matthias Krüger	a0f56edfc3	print_with_newline / write_with_newline: don't warn about string with several `\n`s in them. Fixes #3126	2018-09-06 12:59:34 +02:00
Matthias Krüger	0a8ceaf8b0	rustfmt clippy_lints/src/write.rs	2018-09-06 12:33:00 +02:00
Matthias Krüger	554fe1ed5c	remove "clippy::" lint prefix from lint name in doc url. Fixes #3132	2018-09-06 00:45:57 +02:00
Michael A. Plikk	38d287fecd	Add lint for misstyped literal casting	2018-09-05 19:46:49 +02:00
daubaris	009c29069c	switched to ticks for chars	2018-09-04 18:56:48 +03:00
daubaris	db391c4613	Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one	2018-09-04 18:52:18 +03:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	b7587d8176	Merge pull request #3125 from nrc/pub-conf Make `Default` do what `default` used to do	2018-09-04 10:09:38 +02:00
Josh Holmer	ed9cd1530d	More if_chain	2018-09-03 23:58:10 -04:00
Josh Holmer	48e6be42d7	Rustup	2018-09-03 23:50:24 -04:00
Josh Holmer	061b2f3057	Apply applicability	2018-09-03 23:29:44 -04:00
Josh Holmer	dfed9751bd	Majority of PR changes	2018-09-03 23:29:44 -04:00
Josh Holmer	fbc93c0166	Lint against needless uses of `collect()` Handles cases of `.collect().len()`, `.collect().is_empty()`, and `.collect().contains()`. This lint is intended to be generic enough to be added to at a later time with other similar patterns that could be optimized. Closes #3034	2018-09-03 23:29:44 -04:00
Nick Cameron	4050a68989	Make `Default` do what `default` used to do	2018-09-04 09:13:48 +12:00
daubaris	2f0a99a3a4	fixed known problems expression	2018-09-03 23:01:28 +03:00
daubaris	1f3676f7d0	Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one	2018-09-03 18:24:47 +03:00
daubaris	b825578a4a	backticks and testcase	2018-09-03 18:24:38 +03:00
Philipp Hansch	c0513097ab	Merge pull request #3092 from illicitonion/issue-2879 default_trait_access skips <F as Default>::default()	2018-09-03 17:24:33 +02:00
daubaris	1615a8a2b6	Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one	2018-09-03 17:21:13 +03:00
Josh Triplett	779988303a	iter conservation efforts: save the endangered .iter() and .into_iter() Make explicit_iter_loop and explicit_into_iter_loop allow-by-default, so that people can turn them on if they want to enforce that style; avoid presenting them as the idiomatic Rust style, rather than just a style.	2018-09-03 01:24:46 -07:00
Nick Cameron	d6f01f3a6c	Make `Conf::default` available Fixes RLS	2018-09-03 13:57:50 +12:00
Daniel Wagner-Hall	9f0216d520	Merge branch 'master' into issue-2879	2018-09-03 00:01:57 +01:00
Daniel Wagner-Hall	939d842ea1	Simplify	2018-09-02 23:42:07 +01:00
Daniel Wagner-Hall	368223a341	Use types rather than strings	2018-09-02 23:37:28 +01:00
Michael Wright	19157c02cb	Fix #3112	2018-09-02 09:38:25 +02:00
daubaris	846c3dba2c	resolved conflicts	2018-09-01 09:37:42 +03:00
Manish Goregaokar	c81d70e6bd	Merge pull request #2977 from flip1995/tool_lints Implement tool_lints	2018-09-01 11:22:23 +05:30
Manish Goregaokar	20dfaf7842	declare_lint -> declare_tool_lint	2018-08-31 00:34:48 -07:00
Oliver Schneider	73e8416df3	Merge pull request #3081 from mikerite/fix-3078 Fix #3078	2018-08-31 09:05:39 +02:00
Michael Wright	c6074a94b9	Merge branch 'master' into fix-3078	2018-08-31 06:17:11 +02:00
Michael Wright	daacac6b97	Revert "fix-3078: verify test case" This reverts commit `6256ad05ba`.	2018-08-31 06:15:55 +02:00
daubaris	679bc32f46	range_plus_one suggestion should not remove braces fix	2018-08-30 20:06:13 +03:00
Philipp Hansch	b87ab5ccf2	Merge pull request #3076 from mbrubeck/patch-1 Remove incorrect note from string_add_assign docs	2018-08-29 20:09:38 +01:00
Manish Goregaokar	e0ad732226	Merge pull request #3105 from frewsxcv/frewsxcv-private Make clippy_lints::{utils,consts} modules private, remove unused items.	2018-08-29 11:24:00 -07:00
flip1995	daa4f0ad34	Implement backwards compatibility changes introduced by rust-lang/rust#53762	2018-08-29 11:08:29 -07:00
flip1995	d1f2f0c34c	Fix some rebase fallout	2018-08-29 11:08:29 -07:00
flip1995	f3bb161f0e	Adapt codebase to the tool_lints	2018-08-29 11:08:29 -07:00
flip1995	8c07772dbb	Switch to declare_tool_lint macro	2018-08-29 11:08:29 -07:00
flip1995	392235d6e1	Switch to tool_lints	2018-08-29 11:08:29 -07:00
Corey Farwell	f42442b6e0	dont deref	2018-08-29 09:07:09 -05:00
Corey Farwell	53928d5367	clippy suggestion	2018-08-29 08:27:32 -05:00
Corey Farwell	6445a5d79d	derive copy/clone	2018-08-29 08:01:05 -05:00
Corey Farwell	d5534ca9db	bring back sugg::range	2018-08-29 07:46:03 -05:00
Corey Farwell	9a8f206662	eof newline	2018-08-29 07:43:40 -05:00
Corey Farwell	2a486528ee	utilize carrier	2018-08-29 07:42:43 -05:00
Corey Farwell	2fa7351c1e	suggest wrapping_offset as well	2018-08-29 07:40:00 -05:00
Corey Farwell	61c20c148e	if no suggestion, dont add suggestion	2018-08-29 07:12:22 -05:00
Corey Farwell	f7d1ef90a0	utilize .is_unsafe_ptr	2018-08-29 07:08:59 -05:00
Corey Farwell	a48a6ef10f	utilize cx.tcx.types.usize	2018-08-29 07:07:23 -05:00
Corey Farwell	a7c1ea96c4	tweak comment	2018-08-29 07:03:50 -05:00
Corey Farwell	feb3e9fd5f	switch lint from 'style' to 'complexity'	2018-08-29 07:02:26 -05:00
Corey Farwell	5ebae01c1e	New lint: Suggest `ptr.add([usize])` over `ptr.offset([usize] as isize)`. First part of #3047.	2018-08-28 23:21:29 -05:00
Corey Farwell	05f637cf88	Make clippy_lints::{utils,consts} modules private, remove unused items.	2018-08-28 21:32:20 -05:00
Oliver Schneider	d99cea0f16	Update imports and rustup	2018-08-28 13:13:42 +02:00
Daniel Wagner-Hall	350036a0c7	default_trait_access skips <F as Default>::default() This includes the type name, so is clear, and may be necessary. There doesn't seem to be an obviously cleaner way to pull out the literal text of the named type here. Fixes #2879	2018-08-27 23:22:07 +01:00
Matthias Krüger	fc31dc01de	docs: make example in new_without_default lint syntax highlighted	2018-08-27 17:35:30 +02:00
Philipp Krones	9ce826ade1	Merge pull request #3082 from mikerite/move-range-lints Move some range lints to complexity	2018-08-26 15:08:21 +02:00
Michael Wright	95fedd2273	Revert "Fix E0502 warnings" This reverts commit `98dbce4fe4`. The compiler no longer emits the warnings in #2982 with the original code.	2018-08-26 11:21:22 +02:00
Michael Wright	eef3ffab35	Remove `iterator_find_map` feature attribute Closes #3083	2018-08-26 11:11:47 +02:00
Michael Wright	cc87dc7539	Move some range lints to complexity Recategorize `range_plus_one` and `range_minus_one` to `complexity`. This moves `range_plus_one` out of the nursery as the inclusive range syntax is now stable. Both are moved to `complexity` as it is more consistent with other lints such as `int_plus_one`.	2018-08-26 10:57:04 +02:00
Michael Wright	6256ad05ba	fix-3078: verify test case Check the crash test case by commenting out the fix	2018-08-25 22:35:06 +02:00
Michael Wright	45ceecc79c	Fix #3078	2018-08-25 14:49:56 +02:00
Philipp Krones	b1620f5d3a	Merge pull request #3080 from matthiaskrgr/manual_swap_example add how-to example for std::mem::transmute() usage instead of manual swap	2018-08-24 19:47:17 +02:00
Matthias Krüger	f7be2a0416	add how-to example for std::mem::transmute() usage instead of manual swap	2018-08-24 18:41:49 +02:00
Philipp Krones	e91147832c	Merge pull request #3048 from goodmanjonathan/assign_op deprecate assign_ops lint	2018-08-24 18:29:31 +02:00
Philipp Krones	562c576ed3	Merge pull request #3059 from elpiel/writeln_empty_string_harcoded-suggestion #3016 writeln_empty_string Hardcoded suggestion	2018-08-24 18:28:50 +02:00
Niklas Fiekas	afdf350060	Add copy_iterator lint (#1534 )	2018-08-24 11:57:48 +02:00
Matthias Krüger	c98987f390	fix clippy breakage due to https://github.com/rust-lang/rust/pull/52602	2018-08-23 21:41:30 +02:00
Matt Brubeck	6a0703664b	Remove incorrect note from string_add_assign docs The docs claim that `String::push_str` is better than `String::add` because `String::add` allocates a new string and drops the old one, but this is not true. In fact, `add` reuses the existing string and grows it only if its capacity is exceeded, exactly like `push_str`. Their performance is identical since `add` is just a wrapper for `push_str`: ``` fn add(mut self, other: &str) -> String { self.push_str(other); self } ``` `35bf1ae257/src/liballoc/string.rs (L1922-L1925)`	2018-08-23 08:38:41 -07:00
Matthias Krüger	8ab16b678c	remove macro_vis_matcher feature gate since it is stable now. Warning was: warning: the feature `macro_vis_matcher` has been stable since 1.29.0 and no longer requires an attribute to enable --> src/lib.rs:4:12 \| 4 \| #![feature(macro_vis_matcher)] \| ^^^^^^^^^^^^^^^^^ \| = note: #[warn(stable_features)] on by default	2018-08-23 15:40:51 +02:00
flip1995	37099ae034	Remove now stable tool_attributes feature	2018-08-23 15:36:07 +02:00
Matthias Krüger	712d2d4fa1	rustup, fix breakage introduced by https://github.com/rust-lang/rust/pull/53581	2018-08-22 23:34:52 +02:00
Lachezar Lechev	76f7bfcefd	#3016 Add backticks for the msg	2018-08-20 15:50:15 +02:00
Lachezar Lechev	c292b80783	#3016 Add feedback and implement test for fixed hardcoded suggestion	2018-08-20 15:33:43 +02:00
Lachezar Lechev	3015987f27	#3016 [WIP] Implement feedback and suggestions	2018-08-20 14:03:13 +02:00
Manish Goregaokar	a7bea134d3	Remove implied rust_2018 feature We are already on the edition and this feature is implied.	2018-08-19 19:14:47 -07:00
Manish Goregaokar	76321d3300	codemap -> source_map https://github.com/rust-lang/rust/pull/52953	2018-08-19 19:06:54 -07:00
Lachezar Lechev	6cb94630fb	WIP of #3016 for hardocded suggestion for writeln on empty string	2018-08-16 18:20:06 +02:00
Michael Wright	1c681b6ab6	fix-2927: Update formatting	2018-08-16 07:13:52 +02:00
Michael Wright	bbd67c9b78	Fix #2927	2018-08-15 08:11:07 +02:00
Manish Goregaokar	bac76afb5a	Rustup to rustc 1.30.0-nightly (23f09bbed 2018-08-14)	2018-08-14 11:26:28 -07:00
Philipp Krones	84aa49935d	Merge pull request #3026 from dwijnand/fxhash Add an internal lint for FxHashMap/FxHashSet	2018-08-14 13:04:48 +02:00
Philipp Krones	b2a4013c14	Merge pull request #3014 from estk/allow-write-multi-newline Allow print/write with multiple newlines	2018-08-14 12:54:05 +02:00
Philipp Krones	826d998cd2	Merge pull request #3036 from matthiaskrgr/clippy_self fix 2 clippy warnings	2018-08-14 12:53:01 +02:00
Dale Wijnand	7933d445d1	Move shadow_unrelated to pedantic	2018-08-14 09:52:27 +01:00
Dale Wijnand	22ff5a3ef1	Avoid new_without_default_derive in DefaultHashTypes	2018-08-14 09:25:09 +01:00
Jonathan Goodman	160b41dae3	deprecate assign_ops lint	2018-08-13 16:12:41 -05:00
Dale Wijnand	1812707d39	Use utils::span_lint_and_sugg in default_hash_types	2018-08-13 11:49:57 +01:00
Dale Wijnand	8fc425b676	Add an internal lint for FxHashMap/FxHashSet	2018-08-12 16:15:36 +01:00
Matthias Krüger	88d693918f	docs: add more suggestions on how to fix clippy findings to the online lint list.	2018-08-12 11:29:44 +02:00
Matthias Krüger	66ca3954ec	fix 2 clippy warnings	2018-08-11 23:16:47 +02:00
Oliver Schneider	99a087bea5	Update to rustc master	2018-08-08 13:19:07 +02:00
Oliver Schneider	d722489e71	Merge pull request #2823 from flip1995/thingies_things Replace cfg_attr(rustfmt... with rustfmt::skip	2018-08-08 13:14:20 +02:00
Nick Cameron	b109e10334	Fix build	2018-08-08 18:01:06 +12:00
Evan Simmons	550ff84ecd	Allow print/write with multiple newlines	2018-08-07 12:01:10 -08:00
Oliver Schneider	328fea3e0d	Rustup	2018-08-07 16:34:17 +02:00
Oliver Schneider	77025557f9	Merge pull request #3009 from dwijnand/option-map_or Use Option::map_or	2018-08-07 13:11:30 +02:00
Oliver Schneider	1af90085a1	Merge pull request #3008 from dwijnand/remove-workaround Remove #[allow(rust_2018_idioms)] workaround	2018-08-07 13:10:54 +02:00
Oliver Schneider	dc5ee5aa19	Merge pull request #3010 from mikerite/issue2971 Fix #2971	2018-08-07 13:10:26 +02:00
Scott McMurray	73e097e9f1	Fix the build after https://github.com/rust-lang/rust/pull/53016 In-band lifetimes are no longer in the edition, so update the one place that was using them.	2018-08-07 00:05:09 -07:00
Michael Wright	a3d7698fd9	Fix #2971	2018-08-07 05:37:11 +02:00
Dale Wijnand	7a5ede677b	Use Option::map_or	2018-08-06 17:52:09 +01:00
Dale Wijnand	1a310bfdf7	Remove #[allow(rust_2018_idioms)] workaround	2018-08-06 17:51:04 +01:00
Oliver Schneider	b18a3c5b60	Merge pull request #3007 from mikerite/issue3000 Fix #3000	2018-08-06 09:16:42 +02:00
Michael Wright	ffce3c77e4	Fix #3000	2018-08-06 08:20:50 +02:00
Philipp Hansch	f6c4e303c9	Merge pull request #2999 from flip1995/single_char_pattern Fix single_char_pattern lint for escaped chars	2018-08-06 07:05:04 +01:00
Philipp Hansch	32e4897854	Merge pull request #2975 from aaudiber/lint-identity-into-iter Lint using identity into_iter conversion	2018-08-05 20:38:28 +01:00
Philipp Hansch	a016d4efe0	Merge pull request #2991 from mikerite/issue2979 Fix #2979	2018-08-05 20:35:55 +01:00
Nick Cameron	99dcc70dcd	Fix error in `CrateType` in latest Rust	2018-08-05 09:35:08 +12:00
Manish Goregaokar	0ff762f7cd	Rustup to 59fa6bd6c	2018-08-03 10:14:25 -07:00
flip1995	55672e7e49	Fix single_char_pattern lint for escaped chars	2018-08-03 10:19:29 +02:00
Alex Crichton	8ef759e027	Fix fallout from rust-lang/rust#52841	2018-08-02 18:08:22 -07:00
flip1995	12f2d61fa9	Replace cfg_attr(rustfmt... thingies	2018-08-02 23:04:20 +02:00
Philipp Krones	5d9ca00d94	Merge pull request #2992 from etaoins/allow-pass-by-ref-on-adt-return Allow pass by ref when returning ADT with ref	2018-08-02 22:39:04 +02:00
Alex Crichton	40349b23ea	Fix breakage from rust-lang/rust#52949	2018-08-02 13:00:14 -07:00
Manish Goregaokar	f43d0e53b2	Make indexing_slicing a restriction lint (fixes #2933 )	2018-08-02 10:06:03 -07:00
reujab	1afb7e895b	removed colon	2018-08-02 11:52:46 -04:00
Ryan Cumming	08d6b3d2f6	Allow pass by ref when returning ADT with ref This is a follow-up to #2951 that extends the logic to allow for returning references inside structs/enums/unions. This was a simple oversight in the first version and it's surprisingly easy to handle.	2018-08-02 17:57:49 +10:00
Michael Wright	534d546c81	Fix #2979	2018-08-02 08:56:53 +02:00
Andrew Audibert	3851c0e22b	Address build warning	2018-07-31 23:53:45 -07:00
Philipp Hansch	d7ffaab0fb	Merge pull request #2968 from phansch/first_an_ICE_and_then_some_ice_cream Fix ICE with 'while let Some(..) = x.iter()'	2018-08-01 06:18:34 +01:00
Philipp Hansch	4dbc62baf8	Merge pull request #2983 from mikerite/fix_warnings_20180730 Fix compiler warnings	2018-08-01 06:18:18 +01:00
Michael Wright	98dbce4fe4	Fix E0502 warnings Fixes #2982	2018-08-01 06:33:08 +02:00
flip1995	74fcf7de4a	single_char_pattern: lint only on the argument span	2018-07-31 12:20:32 +02:00
Michael Wright	9c53b1560c	Fix unused_mut warning	2018-07-31 07:45:05 +02:00
Andrew Audibert	0ea1afab3a	Lint using identity into_iter conversion	2018-07-29 21:37:31 -07:00
Philipp Krones	4010788b3a	Merge pull request #2917 from mikerite/issue2894 Fix #2894	2018-07-29 23:54:03 +02:00
Philipp Hansch	0aeb82cb67	Merge pull request #2959 from chrisduerr/master Add known problem to `needless_borrow` lint	2018-07-29 12:15:17 +02:00
Philipp Hansch	946340acfe	Fix ICE with 'while let (..) = x.iter()'	2018-07-29 11:00:26 +02:00
Michael Wright	d7ddb2abba	Add `use_self` comment	2018-07-28 10:42:21 +02:00
Michael Wright	8eeb3feadf	Merge branch 'master' into issue2894	2018-07-28 08:41:10 +02:00
Oliver Schneider	b0dabce478	Merge pull request #2963 from commandline/master Fix regression in print_literal	2018-07-26 10:11:34 +02:00
Thomas Gideon	bf3f976a43	Fix regression in print_literal	2018-07-25 17:31:17 -04:00
Philipp Hansch	e1096391dc	Merge pull request #2960 from matthiaskrgr/typos fix a bunch of typos found by codespell	2018-07-25 22:57:10 +02:00
Philipp Hansch	3bd062e1d9	Merge pull request #2948 from Nemo157/patch-1 Add known problem for redundant_closure lint	2018-07-25 22:55:36 +02:00
Matthias Krüger	2665f10662	fix a bunch of typos found by codespell	2018-07-25 20:02:52 +02:00
Matthias Krüger	cfc9b33f17	Merge branch 'master' into typos	2018-07-25 19:54:45 +02:00
Christian Duerr	13353111da	Add known problem to `needless_borrow` lint The `needless_borrow` lint is temporarily disabled because of some false positives it causes in combination with the `derive` macro. However the documentation does not explain these issues, but instead lists `Known problems: None`. To make it clear why this lint is currently not enabled, a description of the false positives caused by this lint has been added to the `Known problems` section.	2018-07-25 14:54:09 +02:00
Michael Wright	137f944315	Fix warnings	2018-07-25 06:34:29 +02:00
Michael Wright	5e23fcec0b	Merge branch 'master' into issue2894	2018-07-25 06:27:36 +02:00
Dale Wijnand	a1cce2d06a	Inline utils::in_external_macro	2018-07-24 10:38:58 +01:00
Dale Wijnand	b1fa7b91ba	Delegate utils::in_external_macro to rustc::lint::in_external_macro	2018-07-24 10:34:18 +01:00
Philipp Krones	b02e53de34	Merge pull request #2951 from etaoins/allow-pass-by-ref-on-ref-return Allow pass by reference if we return a reference	2018-07-24 11:23:01 +02:00
Philipp Krones	3f9b837ec8	Merge pull request #2953 from dwijnand/misrefactored_assign_op-known-problem-doc Expand on misrefactored_assign_op known problems	2018-07-24 11:19:58 +02:00
Ryan Cumming	0afa5e1e21	Merge branch 'master' into allow-pass-by-ref-on-ref-return	2018-07-24 19:03:43 +10:00
Dale Wijnand	70f5bb1ff6	Tweak misrefactored_assign_op's known problems wording	2018-07-24 09:26:28 +01:00
Dale Wijnand	6ad7a92ff8	Expand on misrefactored_assign_op known problems	2018-07-24 08:39:18 +01:00
Oliver Schneider	afd91248ed	Rustup	2018-07-23 13:01:12 +02:00
Ryan Cumming	7c74c3e508	Wrap comment at 80 columns	2018-07-23 19:37:41 +10:00
Ryan Cumming	89a4558056	Add Known Problem for multiple lifetimes	2018-07-23 19:33:52 +10:00
Ryan Cumming	58459abd0c	Allow pass by reference if we return a reference Currently this code will trigger `trivally_copy_pass_by_ref`: ``` struct OuterStruct { field: [u8; 8], } fn return_inner(outer: &OuterStruct) -> &[u8] { &outer.field } ``` If we change the `outer` to be pass-by-value it will not live long enough for us to return the reference. The above example is trivial but I've hit this in real code that either returns a reference to either the argument or in to `self`. This suppresses the `trivally_copy_pass_by_ref` lint if we return a reference and it has the same lifetime as the argument. This will likely miss complex cases with multiple lifetimes bounded by each other but it should cover the majority of cases with little effort.	2018-07-23 18:44:40 +10:00
Oliver Schneider	ff0e5f967f	Rewrite the print/write macro checks as a PreExpansionPass	2018-07-23 00:19:07 +02:00
Wim	26eea10ec1	Add known problem for redundant_closure lint Documenting https://github.com/rust-lang-nursery/rust-clippy/issues/1439 until it gets fixed.	2018-07-21 18:05:02 +02:00
Oliver Schneider	8085ed733f	Don't invent new magic keywords	2018-07-21 12:36:01 +02:00
Oliver Schneider	2fa85d86e0	Rustup	2018-07-20 22:50:04 +02:00
Manish Goregaokar	1f65617372	Merge branch 'macro-use' into HEAD	2018-07-20 00:52:01 -07:00
Manish Goregaokar	77b0300a55	Merge branch 'pr-2939' into HEAD	2018-07-20 00:51:57 -07:00
Manish Goregaokar	3c2b54870e	Remove warning	2018-07-20 00:50:02 -07:00
Manish Goregaokar	5918a3fc1e	Remove import of if_chain	2018-07-20 00:50:02 -07:00
Alexander Regueiro	4d2c838a32	Update to nightly	2018-07-20 03:59:07 +01:00
flip1995	ac77a26b8a	Skip useless_attribute lint on allow(unused_imports) on extern crate items with macro_use	2018-07-19 13:59:25 +02:00
Manish Goregaokar	c7676356b8	Remove import of matches	2018-07-19 01:06:02 -07:00
Manish Goregaokar	5d74e2096b	Remove import of rustc	2018-07-19 00:53:23 -07:00
Manish Goregaokar	00ba67a12b	Remove import of lazy_static	2018-07-19 00:11:15 -07:00
Manish Goregaokar	c1745cde82	Remove import of serde	2018-07-19 00:02:08 -07:00
Manish Goregaokar	c05adc545c	Temporarily allow macro_use_extern_crate	2018-07-18 20:24:37 -07:00
Michael Wright	a05c9b63ce	use_self: Simplify spanning	2018-07-18 07:57:50 +02:00
Michael Wright	5bb52c4869	Fix use_self regressions	2018-07-17 08:20:49 +02:00
Michael Wright	847e4dcc0d	Merge branch 'master' into issue2894	2018-07-17 06:32:39 +02:00
Oliver Schneider	6992937002	Update for hir renamings in rustc	2018-07-16 15:07:39 +02:00
csmoe	8e929946fd	DeclKind	2018-07-16 11:48:33 +02:00
csmoe	8cf463fe93	StmtKind	2018-07-16 11:48:33 +02:00
csmoe	12ded030b6	TyKind	2018-07-16 11:48:33 +02:00
csmoe	5d4102ee78	BinOpKind	2018-07-16 11:46:37 +02:00
csmoe	1bd17e4fa2	ExprKind	2018-07-16 11:46:37 +02:00
Michael Wright	b90fc5edfa	Fix #2894	2018-07-15 10:38:40 +02:00
Oliver Schneider	5e085e4310	Remove use of ty_to_def_id	2018-07-15 02:04:23 +02:00
Oliver Schneider	1e9f076254	Ignore spans when comparing expressions	2018-07-15 00:00:27 +02:00
Michael Wright	60af4a8e13	Remove duplication in missing_inline	2018-07-08 08:06:24 +02:00
Manish Goregaokar	184b99de39	Merge branch 'pr-2889'	2018-07-06 23:20:01 -07:00
Oliver Schneider	28daee4c91	Rustup	2018-07-05 13:41:51 +02:00
gnzlbg	3fec3b47b6	refactor function	2018-07-05 01:53:40 +02:00
gnzlbg	14cbdf2607	do not apply lint to executable crate type	2018-07-04 16:39:52 +02:00
gnzlbg	999a00bf5e	address reviews	2018-07-04 15:32:55 +02:00
gnzlbg	7c4ec40346	add missing_inline lint When turned on, the lint warns on all exported functions, methods, trait methods (default impls, impls), that are not `#[inline]`. Closes #1503.	2018-07-04 13:50:39 +02:00
Oliver Schneider	547d9ca120	Rustup	2018-07-03 10:52:59 +02:00
Oliver Schneider	141f79f844	Rustup	2018-07-02 19:07:12 +02:00
Oliver Schneider	63041d070b	Rustup	2018-07-01 13:36:14 +02:00
Michael Wright	dfd9e10a2a	Use slightly neater check for static lifetimes	2018-07-01 11:58:29 +02:00
Georg Brandl	949f0d9c72	Fix badly mangled lint message for neg-cmp-op-on-partial-ord	2018-06-29 16:55:31 +02:00
Mateusz Mikuła	a24f77f65a	Bump the version	2018-06-29 09:55:20 +02:00
Mateusz Mikuła	48cb6e273e	Rustup	2018-06-29 09:49:05 +02:00
Mateusz Mikuła	b7d95f486b	Fix warnings	2018-06-28 13:33:11 +02:00
Oliver Schneider	656b26ea4f	Merge pull request #2832 from kennytm/non-copy-const Lint against const items which are interior mutable.	2018-06-28 08:39:54 +02:00
Alex Vermillion	536e7c8f38	Removed placeholder doc-comments There were comments instructing someone to insert an example, but an example was already present	2018-06-26 20:22:36 -05:00
Manish Goregaokar	73a80c5950	Merge pull request #2872 from rust-lang-nursery/pedantic-default Move default_trait_access to pedantic	2018-06-26 13:03:31 -07:00
Oliver Schneider	052427e87a	Merge pull request #2873 from mati865/edition2018_next_step Next step towards Rust 2018...	2018-06-26 11:11:53 +02:00
Oliver Schneider	0de3f36a02	Merge pull request #2849 from mikerite/issue_2741 Fix #2741	2018-06-26 11:08:19 +02:00
Michael Wright	4827bdcc1c	Merge branch 'master' into issue_2741	2018-06-26 07:46:56 +02:00
flip1995	b2fb01f23b	Use utils::opt_def_id() instead of def_id() to prevent ICE	2018-06-25 22:25:15 +02:00
Mateusz Mikuła	df3b9cc350	Format the code	2018-06-25 21:41:24 +02:00
Mateusz Mikuła	1036df5699	Fix clippy_lints doc-tests	2018-06-25 21:22:53 +02:00
Mateusz Mikuła	a6601f2d02	Enable rust_2018_idioms warning	2018-06-25 20:56:25 +02:00
Manish Goregaokar	9f24b9d4b3	Move default_trait_access to pedantic	2018-06-25 11:39:48 -07:00
Oliver Schneider	9f8624e5bf	Version bump	2018-06-25 18:18:50 +02:00
flip1995	203ad28021	resolve merge of NameAndSpan and ExpnInfo rust-lang/rust#51726	2018-06-25 12:25:20 +02:00
flip1995	535c168791	Fix the tests that got broken by the fixes	2018-06-25 12:25:20 +02:00
flip1995	c83fd39e0e	Resolve conflicts produced by GenericArgs Addresses the move/zip of Lifetimes and Types vectors from hir::PathParameters into the args vector of GenericArgs	2018-06-25 12:31:39 +02:00
flip1995	d9a80d2f84	Resolve field, struct and function renaming Addresses the errors produced by (re)moving, merging or renaming structs, fields and methods by rust-lang/rust#48149 and rust-lang/rust#51580	2018-06-25 12:25:20 +02:00
kennytm	88b7603b16	Lint against const items which are interior mutable. Fix #1560 .	2018-06-23 03:35:36 +08:00
flip1995	6224e19b80	Check for arguments before accessing the first arg	2018-06-21 15:46:24 +02:00
Oliver Schneider	25510cfb13	Merge pull request #2790 from shnewto/vectors-to-indexing-slicing-lint Extend `indexing_slicing` lint	2018-06-21 10:30:40 +02:00
Bruno Kirschner	fedd3ef711	Allows neg_cmp_op_on_partial_ord for external macros (fixes #2856 ). The macro always negates the result of the given comparison in its internal check which automatically triggered the lint. As its an external macro there was no chance to do anything about it which lead to a white listing of all external macros to prevent further issues.	2018-06-20 11:58:15 +02:00
Shea Newton	c479b3bc28	Removing lint for constant `usize` array indexing This commit removes the logic in this PR that linted out-of-bounds constant `usize` indexing on arrays. That case is already handled by rustc's `const_err` lint. Beyond removing the linting logic, the test file and its associated stderr were updated to verify that const `usize` indexing operations on arrays are no longer handled by this `indexing_slicing` lint.	2018-06-19 21:30:43 +00:00
Shea Newton	4ec439bef0	Revisiting indexing_slicing test cases This commit contains a few changes. In an attempt to clarify which test cases should and should not produce stderr it became clear that some cases were being handled incorrectly. In order to address these test cases, a minor re-factor was made to the linting logic itself. The re-factor was driven by edge case handling including a need for additional match conditions for `ExprCall` (`&x[0..=4]`) and `ExprBinary` (`x[1 << 3]`). Rather than attempt to account for each potential `Expr*` the code was re-factored into simply "if ranged index" and an "otherwise" conditions.	2018-06-19 16:28:10 +00:00
Shea Newton	8b59542acc	Second pass at addressing changes requested The changes reflected in this commit (requested in PR #2790) are as follows: - Extended `INDEXING_SLICING` documentation to include the array type so that it is clearer when indexing operations are allowed. - Variable `ty` defined identically in multiple scopes was moved to an outer scope so it's only defined once. - Added a missing return statement to ensure only one lint is triggered by a scenario. - Prettified match statement with a `let` clause. (I learned something new!) - Added `&x[5..].iter().map(\|x\| 2 * x).collect::<Vec<i32>>()` and `&x[2..].iter().map(\|x\| 2 * x).collect::<Vec<i32>>()` to the test cases. The first _should trigger the lint/stderr_ and the second _should not_.	2018-06-19 16:28:10 +00:00
Shea Newton	a7c0ff3fa6	This commit represents an attempt to address changes requested in the process of reviewing PR #2790 . The changes reflected in this commit are as follows: - Revised `IndexingSlicingPass` struct name to IndexingSlicing for consistency with the rest of the code base. - Revised match arm condition to use `(..)` shorthand in favor of `(_, _, _)`. - Restored a couple telling variable names. - Calls to `cx.span_lint` were revised to use `utils::span_help_and_lint`. - Took a stab at refactoring some generalizable calls to `utils::span_help_and_lint` to minimize duplicate code. - Revised INDEXING_SLICING declaration to pedantic rather than restriction. - Added `&x[0..].get(..3)` to the test cases.	2018-06-19 16:28:10 +00:00
Shea Newton	5b759efa4c	Rename instances of `array_indexing` This commit renames instances of `array_indexing` to `indexing_slicing` and moves the `indexing_slicing` lint to the `clippy_pedantic` group. The justification for this commit's changes are detailed in the previous commit's message.	2018-06-19 16:27:39 +00:00
Shea Newton	7af0c67855	Extend `indexing_slicing` lint Hey there clippy team! I've made some assumptions in this PR and I'm not at all certain they'll look like the right approach to you. I'm looking forward to any feedback or revision requests you have, thanks! Prior to this commit the `indexing_slicing` lint was limited to indexing/slicing operations on arrays. This meant that the scope of a really useful lint didn't include vectors. In order to include vectors in the `indexing_slicing` lint a few steps were taken. The `array_indexing.rs` source file in `clippy_lints` was renamed to `indexing_slicing.rs` to more accurately reflect the lint's new scope. The `OUT_OF_BOUNDS_INDEXING` lint persists through these changes so if we can know that a constant index or slice on an array is in bounds no lint is triggered. The `array_indexing` tests in the `tests/ui` directory were also extended and moved to `indexing_slicing.rs` and `indexing_slicing.stderr`. The `indexing_slicing` lint was moved to the `clippy_pedantic` lint group. A specific "Consider using" string was added to each of the `indexing_slicing` lint reports. At least one of the test scenarios might look peculiar and I'll leave it up to y'all to decide if it's palatable. It's the result of indexing the array `x` after `let x = [1, 2, 3, 4];` ``` error: slicing may panic. Consider using `.get(..n)`or `.get_mut(..n)`instead --> $DIR/indexing_slicing.rs:23:6 \| 23 \| &x[0..][..3]; \| ^^^^^^^^^^^ ``` The error string reports only on the second half's range-to, because the range-from is in bounds! Again, thanks for taking a look. Closes #2536	2018-06-19 16:27:08 +00:00
uHOOCCOOHu	ce1800d599	Check lifetimes in Fn traits in generic bounds. Add tests.	2018-06-19 21:25:38 +08:00
Oliver Schneider	d761ba78d8	Merge pull request #2837 from fanzier/panicking_unwrap Implement lint checking for `unwrap`s that will always panic.	2018-06-19 13:30:38 +02:00
Oliver Schneider	4839c790ae	Merge pull request #2844 from illicitonion/default_trait_access Add default_trait_access lint	2018-06-19 10:10:20 +02:00
Oliver Schneider	7d672888fe	Version bump	2018-06-19 09:56:37 +02:00
Michael Wright	7df5601f5c	Merge branch 'master' into issue_2741	2018-06-19 07:41:52 +02:00
Michael Wright	0f83c68698	Replace `Constant::partial_cmp`	2018-06-19 07:37:09 +02:00
Daniel Wagner-Hall	b24d75313e	Exclude generated code	2018-06-18 10:29:25 +01:00
Mateusz Mikuła	8625cfb988	Version bump	2018-06-18 09:56:58 +02:00
Michael Wright	7a32c28931	Fix #2741	2018-06-16 18:33:11 +02:00
Wim Looman	621fdcc3bc	Dogfood new trivially_copy_pass_by_ref lint	2018-06-15 16:53:34 +02:00
Wim Looman	700ece5648	Allow configuring the trivial copy size limit	2018-06-15 16:53:34 +02:00
Wim Looman	7547a4ddef	New Lint: Pass small trivially copyable objects by value Fixes #1680 Hardcoded for 64-bit "trivial" size for now	2018-06-15 16:53:34 +02:00
Manish Goregaokar	0c23112846	More doc fixes	2018-06-15 00:20:46 -07:00
Manish Goregaokar	00a0efc566	Doc fix syntax	2018-06-15 00:19:19 -07:00
Daniel Wagner-Hall	4866309f9d	Add default_trait_access lint	2018-06-14 09:11:46 +01:00
Oliver Schneider	26bc88d48c	Merge pull request #2839 from mikerite/duration_subsec_pr_2 Add duration_subsec lint	2018-06-12 06:30:20 -07:00
Fabian Zaiser	817da4c00a	Fix documentation	2018-06-12 15:06:46 +02:00
Fabian Zaiser	35d1b19a03	Fix markdown.	2018-06-12 15:06:46 +02:00
Fabian Zaiser	8682858e2c	Categorize the unwrap lints correctly.	2018-06-12 15:06:46 +02:00
Fabian Zaiser	0c6730d851	Update known problems.	2018-06-12 15:04:44 +02:00
Fabian Zaiser	23404287fc	Implement lint checking for `unwrap`s that will always panic.	2018-06-12 15:04:44 +02:00
Michael Wright	725e9621d0	duration_subsec: Add check for `subsec_micros`	2018-06-12 08:25:10 +02:00
Oliver Schneider	8f0edba6e9	Merge pull request #2815 from darArch/master Warn if non-trivial work is done inside .expect	2018-06-11 06:33:26 -07:00
Donald Robertson	c6fb47331a	Updating docs to reflect more recent changes to expect_fun_call lint	2018-06-11 14:17:40 +01:00
Michael Wright	2d427ea7ee	Merge branch 'master' into duration_subsec_pr_2	2018-06-11 07:48:10 +02:00
Oliver Schneider	8fe90e41d0	Publish preparation	2018-06-10 06:22:07 +02:00
Michael Wright	b0d364cb3e	duration_subsec: fix declaration; correctly classify	2018-06-09 11:04:21 +02:00
Michael Wright	7b2fa2077f	Add duration_subsec lint Closes #2543	2018-06-09 10:21:26 +02:00
Oliver Schneider	91986fa933	Merge pull request #2836 from mati865/upcoming_breakage Upcoming breakage	2018-06-09 06:56:39 +02:00
Fabian Zaiser	54826cf72e	Address review comments.	2018-06-08 06:02:25 +02:00
Fabian Zaiser	81821acd59	Implement lint that checks for unidiomatic `unwrap()` (fixes #1770 ) This checks for things like if x.is_some() { x.unwrap() } which should be written using `if let` or `match` instead. In the process I moved some logic to determine which variables are mutated in an expression to utils/usage.rs.	2018-06-08 05:29:25 +02:00
Mateusz Mikuła	3693a4ea53	Formatting	2018-06-07 22:01:46 +02:00
Oliver Schneider	2a2e602f2a	Merge pull request #2833 from phansch/cannot_relate_bound_region_without_ICE_cream Fix cargo late bound region mismatch ICE	2018-06-07 11:52:32 +02:00
Philipp Hansch	17aff1d774	Fix cargo late bound region mismatch ICE	2018-06-07 07:42:45 +02:00
Donald Robertson	e70632215e	Combining if statements per lint warnings on build	2018-06-06 20:38:13 +01:00
Donald Robertson	9c73f7ff18	Amending use of Some with discarded value to use is_some	2018-06-06 17:13:31 +01:00
Donald Robertson	e67d2b2663	Added check to ensure format macro only being handled, refactored extraction and checks to smaller functions.	2018-06-06 16:53:11 +01:00
Oliver Schneider	7563d8155b	Merge pull request #2804 from utaal/expr-call-author Add support for ExprCall in clippy::author	2018-06-06 15:17:47 +02:00
Donald Robertson	451fd5feb9	Extracting arguments to format to pass directly to panic when appropriate	2018-06-05 21:15:08 +01:00
Oliver Schneider	1e1b4e26ea	Merge pull request #2814 from VKlayd/fn_to_int WIP: Add lint on cast Fn to all numerical except usize.	2018-06-05 17:08:33 +02:00
Donald Robertson	32404741c6	Replacing match block with if block as conditional was boolean	2018-06-04 19:43:03 +01:00
Donald Robertson	1ead12c500	Adding handling and tests for custom type with implemented expect method	2018-06-04 19:43:03 +01:00
Donald Robertson	fe8c9d5965	Ensuring correct lint message is output for Option and Result type	2018-06-04 19:43:03 +01:00
Donald Robertson	2b36017bad	Removing unnecessary allow	2018-06-04 19:43:03 +01:00
Donald Robertson	05c1ccebaf	Warn if non-trivial work is done inside .expect - added tests for common usages of format and as_str arguments to expect - added tests for usages of Option and Result types - given performance impact of passing non literal expressions to expect, added to perf group	2018-06-04 19:43:03 +01:00
Bruno Kirschner	28f735bb26	Cleaned implements_ord helper function in boolean lint file.	2018-06-03 22:56:17 +02:00
Bruno Kirschner	80728a2201	Reduced scope of `nonminimal_bool` so that it doesn't evaluate only partially orded types.	2018-06-03 21:46:09 +02:00
Bruno Kirschner	09ea75bee9	Fixed spelling and indentation issues in neg_cmp_op_on_partial_ord related files.	2018-06-03 21:46:09 +02:00
Bruno Kirschner	86304d8dde	Use declare_clippy_lint instead of declare_lint.	2018-06-03 21:46:09 +02:00
Bruno Kirschner	6d51559f62	Added lint to avoid negated comparisions on partially ordered types.	2018-06-03 21:46:09 +02:00
Oliver Schneider	c6d53ad2c0	Merge pull request #2813 from terry90/master unreadable_literal: Fills hexadecimal values with 0 to allow better grouping	2018-06-03 12:53:45 +02:00
Terry Raimondo	2c1451817c	Compute digits vec only once	2018-06-03 12:26:50 +02:00
Oliver Schneider	1c6c79f92c	Version bump	2018-06-03 08:59:10 +02:00
Victor Korkin	24ab207671	Divide FN_TO_NUMERIC lint into two. FN_TO_NUMERIC_CAST_WITH_TRUNCATION is correctness check FN_TO_NUMERIC_CAST is only style check	2018-06-01 23:08:11 +07:00
Oliver Schneider	1ba658772a	Merge pull request #2816 from mockersf/multiple-impl adding to restriction a lint that check for multiple inherent implementations	2018-05-31 13:33:35 +02:00
Oliver Schneider	41f23f5b4d	Merge pull request #2819 from zayenz/no-op-ref-in-macro avoid op-ref in macros	2018-05-31 12:02:09 +02:00
Oliver Schneider	bb2f6a5011	Merge pull request #2821 from mati865/rust-2018-migration Rust 2018 migration	2018-05-30 15:55:11 +02:00
Victor Korkin	e6811b9c26	Fix 'help' message	2018-05-30 16:55:03 +07:00
Mateusz Mikuła	424a33720d	Run rustfix	2018-05-30 10:15:50 +02:00
Mateusz Mikuła	26f3feb980	Add rust_2018_preview feature and fix rustfmt annotation	2018-05-30 10:10:01 +02:00
Victor Korkin	b69520f5fd	Fixes for suggestion message, tests and lint explanation.	2018-05-30 11:48:46 +07:00
Victor Korkin	e4b2a97401	weird thing	2018-05-30 07:55:48 +07:00
François Mockers	d372f1674d	move lint to restriction group	2018-05-29 21:28:52 +02:00
François Mockers	44f4ea6dbf	adding to pedantic a lint that check for multiple inherent implementations	2018-05-29 21:28:52 +02:00
Devon Hollowood	9118cd633e	Simplify lifetime-differences-only detection Now instead of reinventing the wheel with differ_only_in_lifetimes(), we use TyCtxt's erase_regions()	2018-05-29 09:18:49 -07:00
Devon Hollowood	8134863c13	Fix behavior with generic lifetime parameters	2018-05-29 09:18:49 -07:00
Devon Hollowood	2a606b5220	Don't lint lifetime-only transmutes	2018-05-29 09:18:49 -07:00
Victor Korkin	f6e0388e08	Change lint type to unique and add the suggestion.	2018-05-29 22:56:38 +07:00
Oliver Schneider	400aab9232	Merge pull request #2820 from flip1995/unused_def_conf Remove unused define_conf-macro definitions	2018-05-29 15:30:32 +02:00
flip1995	3a41e0172c	Remove unused define_conf-macro definitions	2018-05-29 14:51:16 +02:00
Oliver Schneider	a338fa9b95	Fix dogfood	2018-05-29 14:45:10 +02:00
Mikael Zayenz Lagerkvist	f97c38de94	avoid op-ref in macros Avoid running op-ref inspection in macros since the macro may be invoked in many different types of contexts. Solves #2818 and incidentally avoids #2689.	2018-05-29 13:17:37 +02:00
Oliver Schneider	ce229b2025	Version bump	2018-05-29 11:58:58 +02:00
Mateusz Mikuła	8ed8ee895a	Update to nightly 2018-05-28	2018-05-29 10:56:58 +02:00
Victor Korkin	cf8f379657	Add lint on cast Fn to numerical.	2018-05-28 23:31:55 +07:00
Andrea Lattuada	e86268e67f	Add support for ExprCall in clippy::author	2018-05-28 14:48:34 +02:00
Terry Raimondo	b81fd202a0	Add tests Fix tests	2018-05-28 14:23:06 +02:00
Terry Raimondo	2033a1eb0e	unreadable_literal: Fills hexadecimal values with 0 to allow grouping (c.f #2300 )	2018-05-28 13:55:27 +02:00
Oliver Schneider	0d1e06d638	Merge pull request #2808 from Aaronepower/master Added lint for unnecessary references.	2018-05-28 13:50:31 +02:00
Aaron Power	8b679176fa	Added lint for unnecessary references	2018-05-28 13:07:19 +02:00
Oliver Schneider	b979f62aab	Merge pull request #2810 from Aaronepower/stable_feature_flags Removed stable feature flags	2018-05-28 12:59:25 +02:00
Oliver Schneider	9d12b04c32	Merge pull request #2806 from mockersf/loop-mut-cond better parsing of condition in while loop for mutability	2018-05-28 12:55:44 +02:00
Oliver Schneider	f30db144dc	Merge pull request #2805 from reiner-dolp/update_lints running update lints script	2018-05-28 12:51:44 +02:00
Aaron Power	1931f53396	Removed stable feature flags	2018-05-28 10:03:27 +02:00
Aaron Power	ceea20153c	Refactored nested if lets to if_chain! macro	2018-05-28 09:50:25 +02:00
François Mockers	5379fc1b28	better parsing of condition in while loop for mutability allow condition to be a block: by calling visit_expr of the visitor directly on the condition instead of walk_expr on the whole expression, we bypass the match to ExprWhile that calls visit_expr on the condition and visit_block on the body. This allow to re-enable visit_block in the visitor, as it won't be called on the while body allow condition to use static variables: maintain a list of static variables used, and if they are mutable	2018-05-27 23:59:07 +02:00
Reiner Dolp	78b8d5cf1a	running update lints script	2018-05-27 16:16:41 +02:00
Oliver Schneider	fc008aa14c	Rustup	2018-05-26 10:23:34 +02:00
Michael A. Plikk	1f10dd2606	Fix note on macro outside current crate. Changed group to restricted	2018-05-24 19:38:40 +02:00
Michael A. Plikk	88c3c2f1c2	Rename panic files to panic_unimplemented	2018-05-24 10:04:18 +02:00
Michael A. Plikk	77794e91e2	Create lint for unimplemented!()	2018-05-24 10:04:18 +02:00
Mateusz Mikuła	a1c44e966e	Update to nightly 2018-05-22 Fixes #2788	2018-05-23 14:47:48 +02:00
Mateusz Mikuła	3c6503eb4b	Format code	2018-05-22 10:21:42 +02:00
Philipp Hansch	74be5632a3	Fix chrono crash due to empty param_env	2018-05-21 17:58:34 +02:00
Oliver Schneider	79d870ef66	Merge pull request #2777 from rust-lang-nursery/scoped_attrs Use the new scoped tool attributes	2018-05-20 09:56:55 +02:00
Cyril Plisko	7b715583d4	rustup to nightly 2018-05-19 clippy_lints does not compile: non-primitive cast: `rustc_target::abi::Size` as `usize` Fixes #2780	2018-05-20 09:20:01 +03:00
Oliver Schneider	e0df4ccfc5	Use the new scoped tool attributes	2018-05-19 14:04:57 +02:00
Philipp Hansch	ed885dc2b3	Fix ICE for issues 2767, 2499, 1782	2018-05-17 21:12:07 +02:00
Philipp Hansch	6eb07cc5b6	Fix ICE for issue 2594	2018-05-17 21:12:06 +02:00
Mateusz Mikuła	f0c823a85e	Rustup to 2018-05-16	2018-05-17 11:21:15 +02:00
Christopher Durham	2c2e7f4d5f	Update for rust-lang/rust#50536 Fixes #2757	2018-05-14 04:34:11 -04:00
Philipp Hansch	ecf4f5128f	Fix two typos	2018-05-13 13:47:54 +02:00
Philipp Hansch	26b48bbdfc	Rustup to 2018-05-13	2018-05-13 10:44:57 +02:00
Oliver Schneider	22bef4ce28	Patterns, locals and matches for author lint	2018-05-11 19:05:34 +02:00
Oliver Schneider	39c0f575f2	Reintroduce the lost (im)mutability checks	2018-05-11 09:53:22 +02:00
Philipp Hansch	665cf96221	Rustup to 2018-05-11	2018-05-11 09:53:21 +02:00
Philipp Hansch	be3cba8852	Merge pull request #2735 from rust-lang-nursery/ice_melting Check that we don't treat any type but a range type as a range	2018-05-09 21:56:34 +02:00
flip1995	db4e7ac725	panic_params: don't lint escaped squigglies	2018-05-09 12:29:28 +02:00
Oliver Schneider	c6e35eae53	Check that we don't treat any type but a range type as a range	2018-05-08 17:16:01 +02:00
NiekGr	e7a6b3e613	Update len_zero to handle comparisions with one I have added test cases for comparisons with zero and one. While implementing handling of one, incorrect handlings of zero were also fixed. fixes rust-lang-nursery/rust-clippy/#2554	2018-05-06 23:54:05 +02:00
Michael Wright	1477f34858	Fixes compilation for rust nightly 2018-05-05 Closes #2725	2018-05-06 14:05:41 +02:00
Evan Simmons	d4b536f540	Fix 1x..x.0 false positive, pretty suggestion	2018-05-05 09:45:14 -07:00
Oliver Schneider	c1b39c4551	Merge pull request #2713 from alexreg/nightly-fix Fixed build for latest rust master	2018-05-04 15:06:59 +02:00
Oliver Schneider	9ce6fb34ca	Satisfy dogfood	2018-05-04 12:59:45 +02:00
Oliver Schneider	8c9bb89608	Update inline_fn_without_body.rs	2018-05-04 10:17:30 +02:00
Alexander Regueiro	00b549ad40	Fixed build for latest nightly (again)	2018-05-03 23:28:48 +01:00
Oliver Schneider	c7ce6c07b1	Rustup field -> method transition of ..=	2018-05-03 15:52:44 +02:00
Oliver Schneider	8f1a98ff08	remove unused crate import	2018-05-03 10:56:02 +02:00
Oliver Schneider	77de1000d7	Merge pull request #2714 from imp/2709_simplify_some_internal_code Simplify some internal code	2018-05-01 22:14:42 +02:00
Oliver Schneider	ee574464c8	Merge pull request #2711 from phansch/fix_2707 Prevent crash when macro was in different file	2018-05-01 21:28:48 +02:00
Cyril Plisko	e94ec44ab3	Simplify some internal code Addresses #2709	2018-05-01 20:33:32 +03:00
Philipp Hansch	5d36edc90d	Prevent crash when macro is in different file This was caused by a macro in a different file. The `target.span` was be in the file of the macro definition and the `item.span` in the file of the calling code.	2018-05-01 18:46:15 +02:00
Alexander Regueiro	c7ff9334a6	Fixed build for latest nightly	2018-05-01 17:10:25 +01:00
Oliver Schneider	f69dd6ad2c	Merge pull request #2672 from ysimonson/multiple-crate-versions Lint for multiple versions of dependencies	2018-05-01 16:48:53 +02:00
Oliver Schneider	ce9715a834	Merge pull request #2701 from nathan/patch-1 Add third variant to {pub_,}enum_variant_names examples	2018-05-01 16:47:53 +02:00
Yusuf Simonson	7de706b34b	Lint for multiple versions of dependencies	2018-04-30 06:20:39 +07:00
Philipp Hansch	1712e18b77	Rustup to latest nightly Due to https://github.com/rust-lang/rust/pull/48995 and https://github.com/rust-lang/rust/pull/49894	2018-04-28 12:56:31 +02:00
Nathan	3373fa97e2	Add third variant to {pub_,}enum_variant_names examples The default value for `enum-variant-name-threshold` is 3, so the old examples (which only have two enum variants) don't actually trigger the lint by default.	2018-04-27 18:47:11 -04:00
Oliver Schneider	d45612e606	Merge pull request #2696 from nathan/patch-1 Fix rustfmt-induced missing line comments in examples	2018-04-27 23:43:57 +02:00
Mateusz Mikuła	cc7d66aa9c	rustup	2018-04-27 14:00:43 +02:00
Nathan	c9c649b315	Remove extraneous `'s in {wrong,crosspointer}_transmute examples	2018-04-27 02:43:16 -04:00
Nathan	78b141d937	Fix missing line comments in {drop,forget}_copy examples	2018-04-27 02:40:19 -04:00
Nathan	7f0f8acb42	Fix missing line comment in drop_ref example	2018-04-27 02:39:14 -04:00
Nathan	8ad5cb6170	Fix missing line comment in crosspointer_transmute example	2018-04-27 02:37:40 -04:00
Nathan	f327f26113	Fix missing line comment in doc_markdown example rustfmt [wrapped the line](`b25b6b3355 (diff-561823671726302d969756ded53a13a7L22)`), so we need a second `///`	2018-04-27 02:31:36 -04:00
Oliver Schneider	3b6440212d	Merge pull request #2673 from estk/excessive_precision Excessive precision	2018-04-25 18:37:42 +02:00
Evan Simmons	9b14ad493b	New excessive precision lint for floats	2018-04-24 15:18:23 -07:00
Devon Hollowood	f0e09d43c9	Make cast_ptr_alignment ignore c_void	2018-04-24 11:37:51 -07:00
Oliver Schneider	faefb4f225	Merge pull request #2684 from 17cupsofcoffee/infallible-destructuring-match Lint for destructuring tuple structs/variants with an infallible single-armed match	2018-04-24 19:08:27 +02:00
Joe Clay	3c38a36d5a	Implement lint for destructuring tuple structs with a let and a match (closes #2671 )	2018-04-24 17:56:13 +01:00
Brad Gibson	1969d423a7	Corrected messaging to warn against less- to more-strictly align types, rather than the other way around. No logic changes required.	2018-04-23 10:59:53 -07:00
Michael Recachinas	54c0edcfe8	Add smaller check_unformatted to write.rs and fix precision,width,align false positive	2018-04-21 19:51:58 +01:00
Oliver Schneider	c5b39a5917	Version bump	2018-04-19 08:36:22 +02:00
Oliver Schneider	f786a36949	Rustup	2018-04-17 10:52:25 +02:00
Oliver Schneider	ae3213747d	Merge pull request #1467 from philipturnbull/option_map_nil_fn Lint `Option.map(f)` where f returns unit	2018-04-15 16:14:25 +02:00
Philipp Hansch	26b9911e07	Refactor out enum and address nits	2018-04-15 15:37:11 +02:00
Oliver Schneider	9dc9487567	Version bump	2018-04-15 15:01:48 +02:00
$MSI\Stew's Laptop$ MSI\Stew's Laptop	d175c797e5	fixing error message for empty println macro	2018-04-15 14:00:28 +02:00
Philipp Hansch	4f4e20c561	Also lint Result.map for unit returns	2018-04-15 13:59:57 +02:00
Philipp Hansch	8307a899e9	Rename option_map_unit_fn to map_unit_fn	2018-04-15 13:01:10 +02:00
Philipp Hansch	d54f70f1f6	Generate let binding variable name for some cases Given a map call like `x.field.map ...` the suggestion will contain: `if let Some(x_field) ...` Given a map call like `x.map ...` the suggestion will contain: `if let Some(_x) ...` Otherwise it will suggest: `if let Some(_) ...`	2018-04-15 13:01:10 +02:00
Philipp Hansch	d87385b406	Use approximate_suggestion for non-reducible closures	2018-04-15 13:01:10 +02:00
Philipp Hansch	7de707fdba	Remove further semicolon reduction	2018-04-15 13:01:10 +02:00
Philipp Hansch	a3ff21f4d6	Rename lint to option_map_unit_fn Rust does not have nil.	2018-04-15 13:01:09 +02:00
Philipp Hansch	fbd71f901f	Use declare_clippy_lint and 'complexity' category	2018-04-15 13:01:09 +02:00
Philipp Hansch	ca60e8a2a0	Cleanup misc::check_nan This was a bit messed up after a bigger rebase.	2018-04-15 13:01:09 +02:00
Philipp Hansch	991a30237a	Make it compile again	2018-04-15 13:01:09 +02:00
Phil Turnbull	d0bdfe5ce3	Handle non-trivial nil closures `reduce_nil_closure` mixed together a) 'is this a nil closure?' and b) 'can it be reduced to a simple expression?'. Split the logic into two functions so we can still generate a basic warning when the closure can't be simplified.	2018-04-15 13:01:09 +02:00
Phil Turnbull	2f52d1d568	Return Spans instead of Cow<&str>'s	2018-04-15 13:01:09 +02:00
Phil Turnbull	30f2480fd8	Lint closures that return nil	2018-04-15 13:01:09 +02:00
Phil Turnbull	302f5d05f5	Lint `Option.map(f)` where f never returns	2018-04-15 13:01:09 +02:00
Phil Turnbull	e5ecbb55ee	Lint `Option.map(f)` where f returns nil	2018-04-15 13:01:09 +02:00
Oliver Schneider	b2e4b88d18	Merge pull request #2662 from mikerite/issue_2546 Fix useless_format false negative	2018-04-15 11:57:57 +02:00
Michael Wright	d171e8987e	Fix clippy error	2018-04-15 05:20:30 +02:00
Michael Wright	a9c8d1bd90	Fix compilation for nightly 2018-04-15 This only fixes compilation and the build. It's possible that the `author` and `inspector` lints are broken but there are no failing tests. Closes #2667	2018-04-15 05:01:43 +02:00
Stefano Probst	01faa906d2	Fix Markdown link syntax in lint doc Currently this link is wrong rendered. See https://rust-lang-nursery.github.io/rust-clippy/v0.0.193/index.html#iter_next_loop	2018-04-14 11:35:52 +02:00
Michael Wright	c7ad71ccf2	Fix clippy warnings	2018-04-12 08:50:42 +02:00
Michael Wright	6ae617b313	Fix useless_format false negative Closes #2546	2018-04-12 08:21:03 +02:00
Oliver Schneider	8ec61a613a	Merge pull request #2661 from devonhollowood/ptr-ptr-casts Replace `misaligned_transmute` lint	2018-04-11 13:23:15 +02:00
Devon Hollowood	b77d74030b	Deprecate misaligned_transmute	2018-04-11 02:50:04 -07:00
Devon Hollowood	c6bc682325	Fix misaligned_transmute lint This is done by adding two new lints: cast_ptr_alignment and transmute_ptr_to_ptr. These will replace misaligned_transmute.	2018-04-11 02:17:59 -07:00
Oliver Schneider	0692b2bb92	Temporarily disable the needless_borrow lint	2018-04-08 11:13:46 +02:00
Oliver Schneider	d247d9c690	Merge pull request #2645 from TimNN/regex-bytes-utf8 Allow invalid UTF-8 in bytes Regexes	2018-04-08 08:58:38 +02:00
Evan Simmons	d712991917	New lints for write! / writeln! macros.	2018-04-07 22:45:26 -07:00
Tim Neumann	fad826f966	allow invalid UTF-8 in bytes Regexes	2018-04-07 22:18:51 +02:00
Philipp Hansch	90e7d93d6c	Fix nonminimal_bool false positive It was checking any is_ok, is_err, is_some, is_none method for negation but it should only perform the check for the built-in types, not custom types.	2018-04-07 12:52:59 +02:00
Oliver Schneider	fbb5050d82	Merge pull request #2641 from rcoh/patch-2 Update hash_xor_eq docs to match behavior	2018-04-07 09:42:54 +02:00
Russell Cohen	4b3326efd0	Fix docs to match behavior	2018-04-06 22:44:25 -07:00
Michael Wright	fe8068c41b	Fix compilation for nightly 2018-04-06 Breakages for introduced by rust pull request 'AST: Give spans to all identifies' - rust-lang/rust/pull#49154 Closes #2639	2018-04-07 07:32:30 +02:00
Oliver Schneider	62d595b3dc	Merge pull request #2632 from phansch/fix_useless_format_false_positive Fix useless_format false positive with macros	2018-04-05 09:59:12 +02:00
Philipp Hansch	ff98e3f9f5	Fix useless_format false positive with macros Clippy was issuing a warning when `format!` was used inside a macro. That's a problem because macros have different syntax and can be outside the control of the user. This skips the `useless_format` check if the `format!` call is inside a macro.	2018-04-05 07:52:26 +02:00
Manish Goregaokar	2046694029	Bump version to 0.0.192	2018-04-04 18:00:21 -07:00
Manish Goregaokar	51336711d3	Remove uses of ExprKind::Inplace	2018-04-04 17:56:44 -07:00
flip1995	cecfdeab19	Don't trigger while_immutable_condition for mutable fields of tuples/structs	2018-04-03 16:41:30 +02:00
Oliver Schneider	90fcdafb79	Merge pull request #2608 from mrecachinas/feature/print-string-literal Check for literals as println! args	2018-04-02 23:34:17 +02:00
Michael Recachinas	d504290839	Add edge case with env! arg to test and known problems	2018-04-02 21:14:29 +01:00
Philipp Hansch	b1b0b36cc0	Document the author lint	2018-04-02 14:55:00 +02:00
Michael Wright	e91404bcc3	Fix clippy warning	2018-04-02 07:35:13 +02:00
Michael Wright	0fbcb30303	Merge branch 'master' into dogfood_target_dir	2018-04-02 07:28:10 +02:00
Michael Wright	fcabbeb251	Fix clippy warning Fix too_many_arguments on `check_general_case` by allowing it. I can't see a sensible way of grouping the parameters.	2018-04-02 07:04:43 +02:00
Michael Wright	89cb053146	Fix clippy warning Fix cyclomatic_complexity warning on `check_expr` by allowing it. This is preferable to increasing the threshold every time the method changes.	2018-04-02 07:04:39 +02:00
Michael Wright	57af95b6f5	Fix clippy warning Fix `option_option` warning on `to_const_range` by taking the entire range as an parameter instead of the start and end.	2018-04-02 07:04:25 +02:00
Michael Wright	6397131f8a	Fix clippy warning Allow `many_single_char_names` on `SpanlessHash::hash_expr`. Each variable has a small scope and the method is readable.	2018-04-02 07:04:06 +02:00
Michael Recachinas	511aa654d7	Change declare_lint! to declare_clippy_lint!	2018-04-02 00:25:57 +01:00
Michael Recachinas	62220abfa6	Add implementation and tests for literal checking in print/println format args	2018-04-01 23:19:53 +01:00
Philipp Hansch	db1ec44616	Handle nested block comments	2018-03-30 12:36:50 +02:00
Philipp Hansch	bb4af196be	Move empty_line_after_outer_attribute to nursery From the clippy side it's difficult to detect empty lines between an attributes and the following item because empty lines and comments are not part of the AST. The parsing currently works for basic cases but is not perfect and can cause false positives. Maybe libsyntax 2.0 will fix some of the problems around attributes but comments will probably be never part of the AST so we would still have to do some manual parsing.	2018-03-30 12:36:50 +02:00
Philipp Hansch	b7929cafe1	Fix false positive in empty_line_after_outer_attr Before, when you had a block comment between an attribute and the following item like this: ```rust \#[crate_type = "lib"] /* */ pub struct Rust; ``` It would cause a false positive on the lint, because there is an empty line inside the block comment. This makes sure that basic block comments are detected and removed from the snippet that was created before.	2018-03-30 12:36:50 +02:00
Manish Goregaokar	83748f5e48	Rustup to rustc 1.26.0-nightly (ae544ee1c 2018-03-29)	2018-03-30 10:35:51 +02:00
Manish Goregaokar	9887b972d4	Merge pull request #2589 from rust-lang-nursery/rangearg Move RangeArgument	2018-03-29 16:21:45 +02:00
Oliver Schneider	c1bbc173da	Address review comments	2018-03-29 13:41:53 +02:00
Manish Goregaokar	b75618206c	Move RangeArgument	2018-03-29 13:13:27 +02:00
Oliver Schneider	eafb9fe8df	Update test suite	2018-03-28 23:49:32 +02:00
Oliver Schneider	d6344c47e3	Categorize all the lints!	2018-03-28 15:24:26 +02:00
Oliver Schneider	ef9fdbb8a9	Implementation + move one lint	2018-03-27 17:13:55 +02:00
Oliver Schneider	96d5af36f8	Version bump	2018-03-27 12:14:46 +02:00
Oliver Schneider	b6e2c47df0	Merge pull request #2572 from flip1995/immut_while Fix check of immutable condition in closure	2018-03-27 07:07:27 +02:00
Michael Wright	546d2fec29	Fix enum_glob_use false positives Closes #2397. This checks the def of the `ItemUse` path instead of checking the capitalization of the path segements. It was noted that this def would sometimes be `Def::Mod` instead of `Def::Enum` but it seems correct now.	2018-03-27 06:34:11 +02:00
flip1995	7d29075132	Skip the mutation in while body case for closures	2018-03-27 02:13:06 +02:00
flip1995	d458f22d89	Fix check of immutable condition in closure	2018-03-27 01:21:25 +02:00
Oliver Schneider	b01b0083ba	Merge pull request #2576 from kimsnj/infinite_loop while_immutable_condition: fix handling of self	2018-03-27 00:06:16 +02:00
Karim Snj	737247e50e	while_immutable_condition: limit suggestion span to condition	2018-03-26 23:24:57 +02:00
Karim Snj	85bcaad412	while_immutable_condition: fix handling of self	2018-03-26 23:16:54 +02:00
Philipp Hansch	034c81b761	Fix false positive in empty_line_after_outer_attribute `empty_line_after_outer_attribute` produced a false positive warning when deriving `Copy` and/or `Clone` for an item. It looks like the second point in [this comment][that_comment] is related, as the attribute that causes the false positive has a path of `rustc_copy_clone_marker`. Fixes #2475 [that_comment]: https://github.com/rust-lang/rust/issues/35900#issuecomment-245978831	2018-03-26 21:57:42 +02:00
Oliver Schneider	9fb63d5fc4	Merge pull request #2574 from mark-i-m/i128 i128 is stabilizing	2018-03-26 07:04:42 +02:00
Mark Mansi	f25d4fd253	make it pass for now	2018-03-25 21:04:05 -05:00
Mark Mansi	a4d869ca76	i128 is stable	2018-03-25 20:35:23 -05:00
Michael Wright	70d8f85e7e	Minor refactoring (walk_ptrs_ty_depth) Replace `walk_ptrs_ty_depth` with `walk_ptrs_ty` when the depth value is ignored.	2018-03-21 20:10:10 +02:00
Oliver Schneider	2d01f42dde	Merge pull request #2539 from Baelyk/master Add suggestion to useless_format	2018-03-20 08:22:04 +01:00
Baelyk	48027105dc	Add suggestion to useless_format Resolves #2505 Suggests that you use `"foo".to_string()` instead of `format!("foo")`.	2018-03-19 09:27:15 -05:00
Oliver Schneider	4edd140e57	Rustup	2018-03-18 13:26:57 +01:00
flip1995	ad459184a3	Don't lint comparison operators in arithmetic impls	2018-03-17 22:02:34 +01:00
flip1995	4fdc81dd7a	Check if the panic message was created by the assert-macro	2018-03-17 21:19:32 +01:00
Mateusz Mikuła	3b387eaabe	Allow float_cmp in consts lint code Signed-off-by: Mateusz Mikuła <mati865@gmail.com>	2018-03-16 11:36:14 +01:00
Mateusz Mikuła	c7770bf907	Remove attributes for stable features Signed-off-by: Mateusz Mikuła <mati865@gmail.com>	2018-03-16 11:09:05 +01:00
Mateusz Mikuła	4c94dd238f	Fix BiRem for floats Signed-off-by: Mateusz Mikuła <mati865@gmail.com>	2018-03-16 10:54:49 +01:00
Mateusz Mikuła	cfb9b982c5	Apply clippy suggestions Signed-off-by: Mateusz Mikuła <mati865@gmail.com>	2018-03-16 10:54:49 +01:00
Oliver Schneider	8749927973	Rustup	2018-03-16 09:44:20 +01:00
Mateusz Mikuła	a54e4661b7	Fix warning Signed-off-by: Mateusz Mikuła <mati865@gmail.com>	2018-03-15 13:24:51 +01:00
Mateusz Mikuła	3662ee76ab	Merge branch 'miri'	2018-03-15 10:49:13 +01:00
Mateusz Mikuła	fd6542d0de	Rustup Signed-off-by: Mateusz Mikuła <mati865@gmail.com>	2018-03-15 10:25:40 +01:00
Oliver Schneider	21f387d278	Update dependencies	2018-03-13 16:54:13 +01:00
Oliver Schneider	f7b2578aea	Update to rustc master	2018-03-13 11:38:21 +01:00
Hidehito Yabuuchi	d637163435	Fix comment	2018-03-11 14:03:09 +09:00
Hidehito Yabuuchi	ed769a3bc4	Ignore all macros in redundant_field_names	2018-03-11 13:57:28 +09:00
Karim Snj	ae5354e6ef	lint: while immutable condition: do not lint constants	2018-03-07 18:25:09 +01:00
Oliver Schneider	4cf02c7e1a	Merge pull request #2483 from kimsnj/infinite_loop immutable while condition	2018-03-07 08:09:48 +01:00
Oliver Schneider	7d5ecd5ad5	Merge pull request #2511 from flip1995/sus_impl UnNeg and UnNot count as additional operations now	2018-03-06 14:35:54 +01:00
Niklas Fiekas	d55890a2b1	Increase unreadable_literal digits (fixes #1958 )	2018-03-06 14:24:01 +01:00
flip1995	ed4535641b	UnNeg and UnNot count as additional operations now	2018-03-06 13:58:03 +01:00
Karim Snj	1ea84c80c1	lint: while immutable condition: refactor to use ExprUseVisitor	2018-03-05 22:42:32 +01:00
Oliver Schneider	7dbf315cde	Merge pull request #2509 from ordovicia/redundant_field_names_range Remove unused variable and a minor refactoring	2018-03-05 11:13:55 +01:00
Hidehito Yabuuchi	8e406760a4	Move call of `is_range_expression()` outside of blocks	2018-03-05 18:20:27 +09:00
Oliver Schneider	05f92b84c9	Merge pull request #2507 from ordovicia/redundant_field_names_range Don't lint range syntax with var name `start` and/or `end`	2018-03-05 09:41:00 +01:00
Hidehito Yabuuchi	e13dcd26e3	Unused variable is left	2018-03-05 17:40:42 +09:00
Oliver Schneider	40ebff8c7a	Merge pull request #2493 from bootandy/fix_cow Lint passing Cow by reference	2018-03-05 09:35:11 +01:00
Hidehito Yabuuchi	cdb60c6547	Make `redundant_field_name` not care range expressions Hand-written `Range` struct family are treated normally.	2018-03-05 17:30:07 +09:00
Oliver Schneider	598acba7d5	Merge pull request #2497 from waywardmonkeys/single-char-pattern Fix single_char_pattern for \n, \t, etc.	2018-03-05 08:43:17 +01:00
Oliver Schneider	6662aa41f9	Merge branch 'master' into fix_cow	2018-03-05 08:42:19 +01:00
Oliver Schneider	f071d1994f	Merge pull request #2504 from flip1995/lit_float_repr Fix unreadable_literal lint for scientific float notation	2018-03-05 08:38:32 +01:00
Hidehito Yabuuchi	7b59557dcd	Don't lint range syntax with var name `start` and `end`	2018-03-05 14:31:37 +09:00
HMPerson1	3045f432c7	Fix #2496	2018-03-04 22:56:03 -05:00
flip1995	86ce897084	Fix unreadable_literal lint for scientific float notation	2018-03-04 16:28:34 +01:00
bootandy	e3c13da830	Change recomendation to: &[type] from Cow<type>	2018-03-03 12:25:20 -05:00
Alex Butler	fc5b377cec	Fix #2494 add suggestion for unreadable_literal Add `rustc --explain E0308` line to relevant tests	2018-03-03 12:25:20 -05:00
Bruce Mitchener	769a1d9b6c	Fix single_char_pattern for \n, \t, etc. Single characters that are escaped weren't being searched / replaced correctly in the hint string, so it was saying to replace, say, `"\n"` with `"\n"` rather than `'\n'`.	2018-03-02 22:00:01 +07:00
Karim Snj	7d35fab304	lint: while loop: detect if no var from the condition is mutated	2018-03-02 00:01:08 +01:00
Karim Snj	37eca59438	lint: while immutable condition: refactor to use hir::Visitor	2018-03-01 22:00:43 +01:00
Alex Butler	42000c6cf9	Fix #2494 add suggestion for unreadable_literal Add `rustc --explain E0308` line to relevant tests	2018-03-01 15:26:39 +00:00
bootandy	9a002e52e5	Lint passing Cow by reference Add lint for reference to Cow to the same place in the code where lint for reference to String lives. https://github.com/rust-lang-nursery/rust-clippy/issues/2405	2018-02-28 10:24:10 -05:00
Manish Goregaokar	539b4b61ec	Bump to 0.0.187	2018-02-26 12:32:18 -08:00
Manish Goregaokar	a512fb265b	oops	2018-02-26 12:31:29 -08:00
Manish Goregaokar	167d978372	Rustup to rustc 1.26.0-nightly (322d7f7b9 2018-02-25)	2018-02-26 11:57:14 -08:00
Karim Snj	5c1be4a4ba	lint: immutable only vars in while condition	2018-02-25 18:25:31 +01:00
Oliver Schneider	6097b8240b	Merge pull request #2479 from gnieto/fix/authorLint Fix author lint	2018-02-24 22:06:25 +01:00
Guillem Nieto	3ac84b2542	Remove explicit visit_qpath method Instead of replacing the default behaviour of the visit_qpath method, I've moved the printing code to private method of PrintVisitor (print_qpath).	2018-02-24 19:34:51 +01:00
Guillem Nieto	8494f57c82	Fix author lint The author lint was generating invalid code as shown on issue: https://github.com/rust-lang-nursery/rust-clippy/issues/2442 I've changed the generated code to properly track cast expressions. Unfortunatelly, I've had to rewrite the `visit_decl` method, to avoid that last if of the chain will be added. After looking at the code, this last line was being added because of the `let x: char` part, but not because of the `0x45df as char` expression. It seems that let statements should not generate code on the author lint, but I'm not sure that this is true or if I'm breaking something on other code generation parts. Finally, I've added a test for the author lint, but I'm not sure that this needs to be added to the testsuite.	2018-02-24 02:19:47 +01:00
Manish Goregaokar	d5e233a720	Merge branch 'rustup'	2018-02-23 09:03:18 -08:00
Manish Goregaokar	f69fcc08d2	Update Rust to 063deba92e	2018-02-23 09:01:26 -08:00
Oliver Schneider	575c3c4b54	Merge pull request #2471 from bootandy/fix_span2 Fix: point to correct problem part of code, update test	2018-02-23 08:31:57 +01:00
bootandy	aef07e3392	Do not pass Span by reference	2018-02-22 10:11:20 -05:00
Oliver Schneider	5e6342d4ae	Merge pull request #2473 from phansch/handle_multiline_attributes Lint multiline attributes properly	2018-02-21 21:44:04 +01:00
Philipp Hansch	d3d3d7d7be	Lint multiline attributes properly This makes it so that the `empty_line_after_outer_attribute` lint only checks for newlines between the end of the attribute and the beginning of the following item. We need to check for the empty line count being bigger than 2 because now the snippet of valid code contains only `\n` and splitting it produces `["", ""]` Invalid code will contain more than 2 empty strings.	2018-02-21 21:29:05 +01:00
bootandy	a7c97256dc	Stop unwanted newlines being applied on unwrap_or	2018-02-21 11:29:08 -05:00
bootandy	c708154c16	Simplify creation of span_replace_word Part of unwrap_or test	2018-02-20 12:38:20 -05:00
bootandy	941e062fd4	Fix: point to correct problem part of code Fix span so it no longer contains the whole train-wreck of code and only points to the problem function (for the unwrap_or lint). https://github.com/rust-lang-nursery/rust-clippy/issues/2422 Update ui test methods - it had several cases where the error message span is now shorter	2018-02-19 12:14:53 -05:00
Philipp Krones	c43e053f3f	Merge branch 'master' into suspicious_impl	2018-02-19 13:04:14 +01:00
flip1995	aa20277a17	Lint for suspicious implementations of arithmetic std::ops traits	2018-02-13 15:40:17 +01:00
TomasKralCZ	42120141bd	Suggestion fixed, simplified lint logic.	2018-02-12 11:26:00 +01:00
TomasKralCZ	85642ddd23	Implement redundant field names lint #2244	2018-02-10 22:52:31 +01:00
Oliver Schneider	6feb0dd982	Fixes #2426 (if_same_then_else false positive)	2018-02-09 15:31:55 +01:00
Oliver Schneider	ff32d5f734	Fix #2427	2018-02-09 15:25:12 +01:00
Oliver Schneider	88970ec8cf	Remove rarely used `type_size` helper function	2018-02-09 15:24:31 +01:00
Oliver Schneider	6f48e37d22	Merge pull request #2444 from phansch/fix_incorrect_useless_attribute_suggestion Partly fix incorrect useless_attribute suggestion	2018-02-07 09:07:46 +01:00
Philipp Hansch	81f5969704	Partly fix incorrect useless_attribute suggestion This fixes an incorrect suggestion from the `useless_attribute` lint when using `cfg_attr`. Additionally, it will not show a suggestion anymore, if the attribute begins on a previous line, because it is much harder to construct the span of multi-line `cfg_attr` attributes as they don't appear in the AST. To fix it completely, one would have to parse upwards into the file, and find the beginning of the `cfg_attr` attribute.	2018-02-06 22:35:11 +01:00
Jonathan Goodman	73f2ba5ded	don't suggest eliding 'static on associated consts	2018-02-06 12:22:34 -06:00
flip1995	63a7daf78c	Make decimal_literal_representation a restriction lint	2018-02-06 13:05:20 +01:00
Guillem Nieto	bcf2e41421	Fix ICE comparing `ExprRange` `eq_expr` on hir::utils was throwing an ICE due to an invalid LateContext being used. Due to this missusage, it was generating an ICE with the code on the following issue: https://github.com/rust-lang-nursery/rust-clippy/issues/2423	2018-02-06 01:06:32 +01:00
Oliver Schneider	503a63390d	Cleanup calls to `layout_of`	2018-02-05 11:28:09 +01:00
Oliver Schneider	30a37efaac	Merge pull request #2433 from kimsnj/matches_sugg Fix suggestions for ref matches	2018-02-05 08:21:21 +01:00
Oliver Schneider	7fddc6116e	Merge pull request #2415 from HMPerson1/fix-2356 Fix `ImplItem`s being ignored	2018-02-05 08:19:11 +01:00
Oliver Schneider	02ee62533d	Merge pull request #2428 from phansch/fix_lint_list_issues Allow empty lines in lint doc examples	2018-02-05 08:18:20 +01:00
Oliver Schneider	bef22006b4	Merge pull request #2419 from phansch/fix_doc_comment_false_positive Fix false positive in empty_line_after_outer_attr	2018-02-05 08:17:29 +01:00
messense	5226b664a1	Rustup to rustc 1.25.0-nightly (0c6091fbd 2018-02-04)	2018-02-05 12:16:17 +08:00
Karim Snj	9575dac491	Fix suggestions for ref matches	2018-02-04 13:41:54 +01:00
Manish Goregaokar	8e8cf2feb1	Bump to 0.0.185	2018-02-02 13:23:32 +05:30
HMPerson1	10d2feddba	Fix `const_static_lifetime`	2018-02-02 02:03:21 -05:00
HMPerson1	ff83b3ecb9	Fix `non_expressive_names`	2018-02-02 01:54:07 -05:00
HMPerson1	3a4ea45821	Fix `get_enclosing_block`	2018-02-02 01:53:48 -05:00
Frederick Zhang	c5ee8b5dfb	set CodeSuggestion approximate to false. fixes #2429	2018-02-02 16:24:32 +11:00
Philipp Hansch	5c28cd259a	Allow empty lines in lint doc examples This makes sure that empty lines in lint examples are preserved. It also fixes the documentation for the invalid_ref lint, which was not shown because of an extra newline before the lint declaration.	2018-02-01 23:21:36 +01:00
Philipp Hansch	a64724fac4	Fix false positive in empty_line_after_outer_attr Doc comments are syntactic sugar for #[doc] attributes, so this lint was catching them, too. This commit makes it so that doc comments are ignored in this lint. I think, for normal attributes it makes sense to warn about following empty lines, for doc comments, less. This way the user has some freedom over the formatting.	2018-02-01 07:43:03 +01:00
Guillem Nieto	74ae9b15b5	Add question mark operator	2018-01-31 00:10:35 +01:00
Oliver Schneider	ee8d32850d	Merge pull request #2413 from flip1995/assign_ops Improved suggestion on misrefactored_assign_op lint	2018-01-30 19:17:38 +01:00
flip1995	bd421cb5a5	Additionally suggest the semantic equal variant	2018-01-30 17:45:35 +01:00
Oliver Schneider	8123495e0f	Version bump	2018-01-30 15:02:47 +01:00
flip1995	b7cb0752ff	Improved suggestion on misrefactored_assign_op lint. Fixes #1239	2018-01-30 14:58:38 +01:00
Oliver Schneider	39d1d6081f	Merge pull request #2340 from phansch/newline_after_attributes Warn on empty lines after outer attributes	2018-01-30 13:09:23 +01:00
Seiichi Uchida	a3c2323767	Add double comparions lint	2018-01-30 10:35:35 +09:00
Seiichi Uchida	c3e9ec65a1	Rustup to rustc 1.25.0-nightly (90eb44a58 2018-01-29)	2018-01-30 10:35:22 +09:00
Philipp Hansch	3d54e56ed4	Add workaround for hidden outer attribute If the snippet is empty, it's an attribute that was inserted during macro expansion and we want to ignore those, because they could come from external sources that the user has no control over. For some reason these attributes don't have any expansion info on them, so we have to check it this way until there is a better way.	2018-01-29 10:03:53 +01:00
Philipp Hansch	aade0d563e	Make lint work on all members of ast::Item_	2018-01-29 10:03:52 +01:00
Philipp Hansch	80827c1f74	Warn on empty lines after outer attributes	2018-01-29 10:03:52 +01:00
Manish Goregaokar	81c5a05648	Bump to 0.0.183	2018-01-29 11:20:29 +05:30
Seiichi Uchida	e40bc64f4f	Rustup to rustc 1.25.0-nightly (7d6e5b9da 2018-01-27)	2018-01-28 16:28:48 +09:00
Michael Wright	daa39b3be1	Fix compilation Fix the compilation broken by these two changes: + `2d56abfbeb (diff-7fceb7ede15b205bf5ad812c31d75384L1459)` + `ccf0d8399e (diff-64b696b0ef6ad44140e973801ed82b25L2771)`	2018-01-27 15:03:17 +02:00
Devon Hollowood	0413b3f6cf	Add misaligned_transmute lint	2018-01-25 00:48:36 -08:00
Oliver Schneider	930a8c6cab	Version Bump	2018-01-25 08:58:47 +01:00
Manish Goregaokar	5437050013	Rustup to rustc 1.25.0-nightly (a0dcecff9 2018-01-24)	2018-01-25 13:14:04 +05:30
Manish Goregaokar	383cc9e545	Add known false positive for enum_glob_use	2018-01-25 12:55:58 +05:30
Oliver Schneider	ea042657e5	Enable more patterns in the author lint	2018-01-24 13:04:06 +01:00
flip1995	31892e205e	let invalid_regex point to the right place for raw strings	2018-01-23 16:52:14 +01:00
Oliver Schneider	8e7f76db9a	Merge pull request #2362 from flip1995/master Lint for numeric literals that have a better representation	2018-01-23 15:54:35 +01:00
flip1995	600147926b	Apply requested changes	2018-01-23 15:29:31 +01:00
flip1995	23f90afa1b	Add configurable threshold, default: 4096	2018-01-23 12:34:40 +01:00
Phil Ellison	29f8cea5fd	Use existing match_var function	2018-01-22 05:46:32 +00:00
Phil Ellison	2132e5c58c	Fix unnecessary_fold bug	2018-01-22 05:34:42 +00:00
Manish Goregaokar	96cba36b46	Rustup to rustc 1.25.0-nightly (97520ccb1 2018-01-21)	2018-01-22 10:35:02 +05:30
mcarton	eb009e2de9	Small documentation formatting fix	2018-01-20 23:32:02 +01:00
Oliver Schneider	70302595a4	Merge branch 'master' of github.com:Manishearth/rust-clippy into fold_any	2018-01-19 12:10:24 +01:00
Oliver Schneider	9a2c50f3d6	Merge pull request #2364 from flip1995/precedence Add macro check to precedence lint	2018-01-19 12:07:00 +01:00
Oliver Schneider	3c6064130b	Merge pull request #2367 from etaoins/inline-fn-without-body-lint Lint for trait methods without bodies	2018-01-19 09:14:46 +01:00
Oliver Schneider	26c415ab2d	Merge pull request #2381 from HMPerson1/remove_is_unit_expr Replace `is_unit_expr`	2018-01-19 09:14:04 +01:00
Michael Wright	fca248957b	Merge branch 'master' into option_option_pr	2018-01-19 07:56:46 +02:00
HMPerson1	e09805e8ca	Use `unit_expr`	2018-01-18 17:33:09 -05:00
HMPerson1	7a6c03f876	Add `is_unit_expr` to deprecated lints list	2018-01-18 17:29:14 -05:00
HMPerson1	8081f6fd6e	Replace `is_unit_expr`	2018-01-18 17:04:26 -05:00
Oliver Schneider	8217e33718	Only suggest implementing Copy if it can actually be done	2018-01-18 14:27:47 +01:00
Ryan Cumming	7467b83377	Suggest removing inline attributes This adds a `suggest_remove_item` helper that will remove an item and all trailing whitespace. This should handle both attributes on the same line as the function and on a separate line; the function takes the position of the original attribute.	2018-01-18 20:02:42 +11:00
Ryan Cumming	5f3c340bfb	Lint for trait methods without bodies As discussed in rust-lang/rust#47475 the #[inline] attribute is currently allowed on trait methods without bodies (i.e. without a default implementation). This is misleading as it could be interpreted as affecting the implementations of the trait method. Add a lint for any use of #[inline] on a trait method without a body. Fixes rust-lang/rust#47475	2018-01-18 20:01:24 +11:00
Manish Goregaokar	552e950080	needless_pass_by_value: Whitelist RangeArgument (fixes #2357 )	2018-01-18 14:30:53 +05:30
Manish Goregaokar	2a30c8a194	needless_pass_by_value: Add suggestion for implementing Copy (fixes #2222 )	2018-01-18 14:30:47 +05:30
Manish Goregaokar	cf1fbaa36a	needless_pass_by_value: Ignore for extern funcs (fixes #1844 )	2018-01-18 14:30:32 +05:30
Michael Wright	bf7efead17	Rename variable Rename `vec` to `ty` in `match_type_parameter`. This variable is a type and not a vector. Previously it would only refer to `Vec<_>` so the name used to make sense.	2018-01-18 07:52:24 +02:00
Michael Wright	ec60baa864	Merge branch 'master' into option_option_pr	2018-01-18 07:21:48 +02:00
Phil Ellison	a324a2bc38	Fix typos	2018-01-17 21:54:09 +00:00
Phil Ellison	b73efad600	Add some reviewer comments	2018-01-17 21:06:16 +00:00
Phil Ellison	9806b31d53	Rename lint, improve documentation	2018-01-17 20:21:29 +00:00
Phil Ellison	1cac693bc7	Lint on folds implementing .all, .sum and .product	2018-01-17 19:12:44 +00:00
Vlad-Shcherbina	ada0d2c548	Document map_clone known problems #498	2018-01-17 21:40:47 +03:00
Oliver Schneider	a2fdfc05d7	Merge pull request #2298 from goodmanjonathan/else_if_without_else add new lint else_if_without_else	2018-01-17 09:35:58 +01:00
Michael Wright	e7567f2eac	Made requested changes	2018-01-17 07:24:33 +02:00
Michael Wright	21fde9a9d1	Merge branch 'master' into option_option_pr	2018-01-17 06:52:00 +02:00
Phil Ellison	a64d19cc0e	Fix error span to play nicely with rustfix	2018-01-16 21:20:55 +00:00
Manish Goregaokar	37f62a54f8	Show wider and more accurate suggestion for const_static_lifetime fixes #2365	2018-01-16 20:46:44 +05:30
flip1995	877321ba32	Add macro check to precedence lint	2018-01-16 15:52:16 +01:00
flip1995	647da97622	Lint for numeric literals that have a better representation in another format	2018-01-16 14:01:07 +01:00
Oliver Schneider	61e2b7a4d6	Merge pull request #2355 from alusch/clone_on_ref_ptr_restriction Fix #2048: Move `clone_on_ref_ptr` to the restriction lints	2018-01-16 10:40:12 +01:00
Oliver Schneider	d011dae96d	Rustup	2018-01-15 12:08:17 +01:00
Jonathan Goodman	40c6f431da	add new lint else_if_without_else	2018-01-14 22:53:00 -06:00
Adam Lusch	f343cd22f6	Adds the missing turbofish	2018-01-14 20:19:55 -08:00
Adam Lusch	1615813960	Moves `clone_on_ref_ptr` to be a restriction lint Also updates the suggestion to include the full type (e.g. `Arc<Foo>::clone(&rc)`) and adds a case using trait objects to the UI tests.	2018-01-14 19:58:09 -08:00
Phil Ellison	ad164939ed	Check that we're calling Iterator::fold	2018-01-14 20:04:34 +00:00
Phil Ellison	70a5535ffa	Address some review comments	2018-01-14 18:18:09 +00:00
Phil Ellison	360f2359d5	Fix name	2018-01-14 15:30:06 +00:00
Oliver Schneider	2f62d803ab	Merge pull request #2349 from rust-lang-nursery/no-main-doc Don't warn about missing docs for main()	2018-01-14 13:16:54 +01:00
Phil Ellison	7e833ea5ce	Add description	2018-01-14 10:07:41 +00:00
Phil Ellison	528be23c07	Move get_arg_name into utils	2018-01-14 10:05:01 +00:00
Phil Ellison	1feb9fd550	Tidy using if_chain and snippet function. Actually check that the initial fold value is false. Remove some unwraps	2018-01-14 09:30:08 +00:00
Phil Ellison	f6e56d2559	First pass at linting for .any expressed as a .fold	2018-01-14 08:27:53 +00:00
Manish Goregaokar	7e63f93d81	Don't warn about missing docs for main() Fixes #2348	2018-01-14 11:35:08 +05:30
Oliver Schneider	cc9008b7d4	Merge pull request #2347 from kimsnj/extrem_comp Fix #1159: avoid comparing fixed and target sized types in lint	2018-01-13 12:27:36 +01:00
kimsnj	53c0ae0169	Fix #1159 : avoid comparing fixed and target sized types in lint	2018-01-12 18:33:25 +01:00
HMPerson1	8505ee7028	Add lint to replace `const`s with `const fn`s	2018-01-11 12:03:46 -05:00
Oliver Schneider	1245de1e46	Don't suggest changing explicit Clone impls if they have generics	2018-01-11 10:28:42 +01:00
Oliver Schneider	41a710e3f4	Version bump	2018-01-10 09:50:58 +01:00
Oliver Schneider	75c92aa2d2	Fix an ICE in HashMap generalization suggestions	2018-01-09 14:57:44 +01:00
Oliver Schneider	4603e60fca	Merge pull request #2316 from tspiteri/doc-names Add "NaNs" and "GitLab" to `doc-valid-idents`	2018-01-09 09:10:18 +01:00
Oliver Schneider	64af362ab0	Merge pull request #2334 from Rantanen/ast-fix Implement nightly libsyntax changes to fix the build	2018-01-08 10:56:07 +01:00
Philipp Hansch	1a16ac058d	Add 'positive' examples for some lints This allows to see at a quick glance what the improved code could look like for these lints.	2018-01-08 10:20:04 +01:00
Mikko Rantanen	91ecb3b8ed	Implement nightly libsyntax changes	2018-01-07 05:58:53 +02:00
Pascal Hertleif	82d91c5fcb	Add auto-fixable `println!()` suggestion Fixes #2319	2018-01-04 12:46:26 +01:00
Trevor Spiteri	a5d0569a20	Add "NaNs" and "GitLab" to `doc-valid-idents`	2018-01-02 13:51:35 +01:00

... 16 17 18 19 20 ...

2744 commits