Stabilize tool lints

This commit is contained in:
Oliver Scherer 2018-10-11 12:16:22 +02:00
parent 8b45dd704b
commit b8654eaa6c
205 changed files with 211 additions and 212 deletions

View file

@ -130,16 +130,15 @@ You can add options to your code to `allow`/`warn`/`deny` Clippy lints:
Note: `deny` produces errors instead of warnings.
Note: To use the new `clippy::lint_name` syntax, `#![feature(tool_lints)]` has to be activated
currently. If you want to compile your code with the stable toolchain you can use a `cfg_attr` to
Note: To use the new `clippy::lint_name` syntax, a recent compiler has to be used
currently. If you want to compile your code with the stable toolchain you can use a `cfg_attr` to
activate the `tool_lints` feature:
```rust
#![cfg_attr(feature = "cargo-clippy", feature(tool_lints))]
#![cfg_attr(feature = "cargo-clippy", allow(clippy::lint_name))]
```
For this to work you have to use Clippy on the nightly toolchain: `cargo +nightly clippy`. If you
want to use Clippy with the stable toolchain, you can stick to the old unscoped method to
For this to work you have to use Clippy on the nightly toolchain: `cargo +nightly clippy`. If you
want to use Clippy with the stable toolchain, you can stick to the old unscoped method to
enable/disable Clippy lints until `tool_lints` are stable:
```rust
#![cfg_attr(feature = "cargo-clippy", allow(clippy_lint))]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(clippy::default_hash_types)]
use itertools::Itertools;

View file

@ -18,7 +18,7 @@
#![allow(unknown_lints, clippy::shadow_reuse, clippy::missing_docs_in_private_items)]
#![recursion_limit = "256"]
#![feature(macro_at_most_once_rep)]
#![feature(tool_lints)]
#![warn(rust_2018_idioms, trivial_casts, trivial_numeric_casts)]
#![feature(crate_visibility_modifier)]
#![feature(try_from)]

View file

@ -11,7 +11,7 @@
// error-pattern:yummy
#![feature(box_syntax)]
#![feature(rustc_private)]
#![feature(tool_lints)]
#![feature(try_from)]
#![allow(unknown_lints, clippy::missing_docs_in_private_items)]

View file

@ -11,7 +11,7 @@
// error-pattern:cargo-clippy
#![feature(plugin_registrar)]
#![feature(rustc_private)]
#![feature(tool_lints)]
#![allow(unknown_lints)]
#![allow(clippy::missing_docs_in_private_items)]
#![warn(rust_2018_idioms)]

View file

@ -11,7 +11,7 @@
// error-pattern:yummy
#![feature(box_syntax)]
#![feature(rustc_private)]
#![feature(tool_lints)]
#![allow(unknown_lints, clippy::missing_docs_in_private_items)]
use rustc_tools_util::*;

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![deny(clippy::all)]
#![allow(unused_imports)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(clippy::all)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(clippy::all)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(dead_code, clippy::char_lit_as_u8, clippy::needless_bool)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(unused_variables, clippy::blacklisted_name,
clippy::needless_pass_by_value, dead_code)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
use std::collections::HashSet;

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![deny(clippy::all)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![deny(clippy::all)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![deny(clippy::if_same_then_else)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![deny(clippy::match_same_arms)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![deny(clippy::mut_mut, clippy::zero_ptr, clippy::cmp_nan)]
#![allow(dead_code)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[deny(clippy::all)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![deny(clippy::needless_lifetimes)]
#![allow(dead_code)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(clippy::blacklisted_name)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::single_match_else)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(clippy::useless_attribute)] //issue #2910

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(dead_code)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(clippy::many_single_char_names)]
#[derive(Copy, Clone)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::absurd_extreme_comparisons)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[warn(clippy::approx_constant)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::integer_arithmetic, clippy::float_arithmetic)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[allow(dead_code, unused_assignments)]
#[warn(clippy::assign_op_pattern)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[allow(unused_assignments)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::inline_always, clippy::deprecated_semver)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
const THREE_BITS : i64 = 7;

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(dead_code, clippy::similar_names, clippy::single_match, clippy::toplevel_ref_arg, unused_mut, unused_variables)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::block_in_if_condition_expr)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[warn(clippy::bool_comparison)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::nonminimal_bool, clippy::logic_bug)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![deny(clippy::borrowed_box)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::all)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::builtin_type_shadow)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[deny(clippy::naive_bytecount)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[warn(clippy::cast_precision_loss, clippy::cast_possible_truncation, clippy::cast_sign_loss, clippy::cast_possible_wrap, clippy::cast_lossless)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
//! Test casts for alignment issues

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[warn(clippy::cast_lossless)]
#[allow(clippy::no_effect, clippy::unnecessary_operation)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[warn(clippy::cast_lossless)]
#[allow(clippy::no_effect, clippy::unnecessary_operation)]
fn main() {

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[warn(clippy::cast_precision_loss, clippy::cast_possible_truncation, clippy::cast_sign_loss, clippy::cast_possible_wrap, clippy::cast_lossless)]
#[allow(clippy::no_effect, clippy::unnecessary_operation)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::char_lit_as_u8)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![deny(clippy::panicking_unwrap, clippy::unnecessary_unwrap)]
#![allow(clippy::if_same_then_else)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
pub fn dec_read_dec(i: &mut i32) -> i32 {
*i -= 1;

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[warn(clippy::cmp_nan)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::cmp_null)]
#![allow(unused_mut)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[warn(clippy::cmp_owned)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[warn(clippy::collapsible_if)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::all)]
#![allow(unused, clippy::needless_pass_by_value)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(clippy::blacklisted_name, clippy::collapsible_if, clippy::cyclomatic_complexity, clippy::eq_op, clippy::needless_continue,
clippy::needless_return, clippy::never_loop, clippy::no_effect, clippy::zero_divided_by_zero)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::copy_iterator)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
fn main() {}

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(clippy::all)]
#![warn(clippy::cyclomatic_complexity)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::cyclomatic_complexity)]
#![warn(unused)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[warn(clippy::decimal_literal_representation)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::default_trait_access)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![feature(untagged_unions)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![feature(never_type)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![feature(alloc)]
#![feature(associated_type_defaults)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
//! This file tests for the DOC_MARKDOWN lint

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[warn(clippy::double_neg)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::double_parens)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::drop_copy, clippy::forget_copy)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::drop_ref, clippy::forget_ref)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::duplicate_underscore_argument)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::duration_subsec)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::all)]
#![warn(clippy::else_if_without_else)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(dead_code)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::empty_line_after_outer_attr)]
// This should produce a warning

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(unused, clippy::needless_pass_by_value)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::all, clippy::pedantic)]
#![allow(unused_imports, dead_code, clippy::missing_docs_in_private_items)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![feature(non_ascii_idents)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
// ignore-x86

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[warn(clippy::eq_op)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[allow(clippy::no_effect)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(unknown_lints, unused, clippy::no_effect, clippy::redundant_closure_call, clippy::many_single_char_names, clippy::needless_pass_by_value, clippy::option_map_unit_fn, clippy::trivially_copy_pass_by_ref)]
#![warn(clippy::redundant_closure, clippy::needless_borrow)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[warn(clippy::eval_order_dependence)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::excessive_precision)]
#![allow(clippy::print_literal)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::explicit_write)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![deny(clippy::fallible_impl_from)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::all, clippy::pedantic)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::float_cmp)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::float_cmp_const)]

View file

@ -9,7 +9,7 @@
// only-64bit
#![feature(tool_lints)]
#![warn(clippy::fn_to_numeric_cast, clippy::fn_to_numeric_cast_with_truncation)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
use std::collections::*;

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(clippy::print_literal)]
#![warn(clippy::useless_format)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::all)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::all)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::default_hash_types)]
#![feature(rustc_private)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![deny(clippy::identity_conversion)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
const ONE : i64 = 1;

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::all)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![warn(clippy::all)]
#![warn(clippy::if_not_else)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![allow(dead_code)]
#![warn(clippy::multiple_inherent_impl)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#[warn(clippy::inconsistent_digit_grouping)]
#[allow(unused_variables)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![feature(plugin)]
#![warn(clippy::indexing_slicing)]

View file

@ -8,7 +8,7 @@
// except according to those terms.
#![feature(tool_lints)]
#![feature(exhaustive_patterns, never_type)]
#![allow(clippy::let_and_return)]

Some files were not shown because too many files have changed in this diff Show more