Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-27 15:11:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2497 from waywardmonkeys/single-char-pattern

Browse source 
Fix single_char_pattern for \n, \t, etc.
This commit is contained in:
Oliver Schneider 2018-03-05 08:43:17 +01:00 committed by GitHub
commit 598acba7d5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
clippy_lints/src/methods.rs
View file

@ -1763,7 +1763,11 @@ fn lint_single_char_pattern<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, expr: &'tcx hi
}) = ConstContext::new(cx.tcx, cx.param_env.and(substs), cx.tables).eval(arg)
{
if r.len() == 1 {
let hint = snippet(cx, expr.span, "..").replace(&format!("\"{}\"", r), &format!("'{}'", r));
let c = r.chars().next().unwrap();
let snip = snippet(cx, expr.span, "..");
let hint = snip.replace(
&format!("\"{}\"", c.escape_default()),
&format!("'{}'", c.escape_default()));
span_lint_and_then(
cx,
SINGLE_CHAR_PATTERN,

2
tests/ui/single_char_pattern.rs
View file

@ -35,6 +35,8 @@ fn main() {
x.rmatch_indices("x");
x.trim_left_matches("x");
x.trim_right_matches("x");
// Make sure we escape characters correctly.
x.split("\n");
let h = HashSet::<String>::new();
h.contains("X"); // should not warn

8
tests/ui/single_char_pattern.stderr
View file

@ -102,5 +102,11 @@ error: single-character string constant used as pattern
37 | x.trim_right_matches("x");
| ---------------------^^^- help: try using a char instead: `x.trim_right_matches('x')`
error: aborting due to 17 previous errors
error: single-character string constant used as pattern
--> $DIR/single_char_pattern.rs:39:13
|
39 | x.split("/n");
| --------^^^^- help: try using a char instead: `x.split('/n')`
error: aborting due to 18 previous errors