Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-18 08:23:12 +00:00
Code Issues Projects Releases Packages Wiki Activity
7359 commits 3 branches 76 tags 119 MiB
Commit graph

3440 commits

Author SHA1 Message Date
Kurt
e72a58bdee Dump latest translatable strings 2020-06-19 20:18:37 -05:00
Kurt
808ca8f307 Add a temp size that isn't 100% dlc sized 
dunno what RoC did but it exists?
 2020-06-19 19:58:56 -05:00
Kurt
5dd98cc9b0 Fix mystic/aurora ticket flag name inversion 
Closes #2862
 2020-06-19 19:00:40 -05:00
Kurt
36dd5ece21 Initial Isle of Armor support 
Co-Authored-By: sciresm <sciresm@users.noreply.github.com>
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
Co-Authored-By: Archit Date <architdate@gmail.com>
 2020-06-19 18:51:15 -05:00
Kurt
db30170cc5 Update EncounterArea7g.cs 
Kinda ugly but works for now
Closes #2861
 2020-06-16 22:40:43 -05:00
Kurt
27cce4dcd2 Disallow galar master rank ribbon on legends 
Closes #2858
 2020-06-16 22:16:21 -05:00
Kurt
f51e3673da Update AbilityVerifier.cs 
incorrectly edited (ability number needs to be bit0/1/2 not none/any other permutation)
Closes #2860
 2020-06-16 22:13:21 -05:00
Kurt
2cdb5d26db Clean up some method signatures 
rename things to be a little more consistent in naming conventions
 2020-06-16 21:46:22 -05:00
Kurt
bfef634a1a Set shiny type regardless of format 
Don't loop if not required to loop
 2020-06-12 11:45:56 -07:00
Kurt
efb628c002 PID Rand: Handle ability bits for gen34 differently from gen5 
quite an old method we have here; used to just maintain both low bits from u16. Need to handle things differently for g34/g5.

Rearrange some variable init for slightly better perf, and clean up parameter names

https://projectpokemon.org/home/forums/topic/55750-pkhex-square-shiny/
 2020-06-11 09:32:43 -07:00
Kurt
fe0ef71e67 Add zh flag names for emerald 
Closes #2848

Co-Authored-By: hard <kamisama6866@users.noreply.github.com>
 2020-06-11 09:29:01 -07:00
XxPhoenix1996xX
2bd33dd7de
Update Spanish Translation (#2850) 
* Update MessageStrings_es.txt

* Update lang_es.txt
 2020-06-06 17:11:35 -07:00
Kurt
f7d2101500 Update Encounters8NestDist.cs 2020-06-06 09:53:14 -07:00
Kurt
9b89ee09ec Fix downlevel comparison 
(for good? pls)
https://i.redd.it/7g2c4d3kisc41.png
ty anubis

remove GetMinimalLevel override, as it's doing the same thing as LevelMin. When regenerating the pkm, we aren't doing anything downlevel related.
 2020-06-06 09:00:52 -07:00
Kurt
c3215083c2 Update ShowdownSet.cs 2020-06-05 09:55:00 -07:00
Kurt
3af369c152 ★Sgr6879 (Copperajah) 2020-06-05 07:31:40 -07:00
Kurt
321a2d120f Add new distribution raids 
Add Copperajah crystal (commented); uncomment when released?
 2020-06-02 07:09:49 -07:00
Kurt
a2996e6b55 Unban gen8 bred HA starters 
HOME gift -> breed
 2020-06-02 07:09:17 -07:00
Kurt
16c9865505 Update EncounterStatic8N.cs 2020-06-01 14:07:26 -07:00
Kurt
ff849b9c5b Allow fullness values for format8 
ty anubis
this totally isn't fullness, but the toys increase the value (saturation?)
 2020-05-31 13:29:13 -07:00
Kurt
5c0d6d0f31 Extract downlevel check for reuse; clamp edge moves to max raid lvl 2020-05-31 13:28:14 -07:00
Kurt
3fcb29e68a Remove some reliance on GenNumber 2020-05-31 12:12:48 -07:00
Kurt
9ff01bccc6 Add ToString override for debugging 2020-05-31 12:12:20 -07:00
Kurt
6aab8ca449 Minor renaming/type change of passed args 
Next commit will have more changes where we remove some reliance on PKM.GenNumber, in favor of the passed encounter's generation
 2020-05-31 12:12:07 -07:00
Kurt
97d8bcebfe Only check Korean if game isn't recognized as Crystal 
https://projectpokemon.org/home/forums/topic/57203-pkhex-error-crystal-save-dont-load/
 2020-05-31 09:18:45 -07:00
Kurt
51a4001ce6
Update RaidSpawnList8.cs 2020-05-29 11:20:28 -07:00
Kurt
7f1039d155
Update RaidSpawnList8.cs 2020-05-29 11:19:49 -07:00
Matt
4d47e4ab83
Pretty up GP1 summary/filename (#2846) 2020-05-29 11:13:49 -07:00
XxPhoenix1996xX
fe8001f991
Update Spanish Translation (#2845) 
* Update LegalityCheckStrings_es.txt

* Update MessageStrings_es.txt

* Update LegalityCheckStrings_es.txt
 2020-05-28 23:30:57 -07:00
Kurt
dc5af9ea57 Add zh frlg event flags 
Closes #2844
Closes #2843 via prior commit

Co-Authored-By: kamisama6866 <kamisama6866@users.noreply.github.com>
 2020-05-28 22:06:33 -07:00
Kurt
940a9cb269 Add zh rs event flags 
Closes #2843

Co-Authored-By: kamisama6866 <kamisama6866@users.noreply.github.com>
 2020-05-28 14:48:44 -07:00
Kurt
afa368823e Minor clean 
handle some compiler messages
 2020-05-26 16:59:47 -07:00
Kurt
043ba3b6f0 Add ability to sideload key names 2020-05-26 15:58:48 -07:00
Matt
9b6190a3e9
Add Gigantamax Meowth Distribution Raids (#2842) 2020-05-25 17:39:07 -07:00
Kurt
46b443903d Fix SM dex form fetch for spewpa 
Closes #2826

It doesn't find it in the SM table, but didn't return -1
rework logic flow to return when found, rather than after loop finishes.

Also fix display off-by-1 since we're not using zero indexing for our entry numbers.

Thanks @Ammako !
 2020-05-24 20:42:45 -07:00
Kurt
7c6ea78c63 Add fullness legality check 
Closes #2836

Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
 2020-05-24 20:00:32 -07:00
Kurt
9619306a8f Update BattleTree7.cs 2020-05-24 18:42:08 -07:00
Kurt
09cbe47240 Add battle tree scout edits 
Closes #2833
 2020-05-24 18:31:52 -07:00
Kurt
053eef2767 Add encount block 
Closes #2840 -- access via Block Editor "Encount"
Tons of undecipherable junk in the roamer struct; looks like a mishmash of past gen code repurposed for their pseudo-stationary|roamer encounter.

ORAS has the same structure (same size/block), but the roamer portion isn't used
 2020-05-24 17:31:10 -07:00
Kurt
8ce4f64239 Move files to their correct location 2020-05-24 17:11:39 -07:00
Kurt
bbe1cf3ee1 Fix gen6 gamesync ID read 2020-05-24 17:10:55 -07:00
Kurt
c4326698a5 Add prompt for loading new save with unsaved changes 
Closes #2823

remove old gen6 powersaves decrypted-xorpad strings (unused logic)
remove gen8 save fixing beta-pkhex-caused corruption (behaved for 6months)
 2020-05-24 11:03:23 -07:00
Kurt
d8cd75908b Handle gen2 gift egg collision with low hatch cycle req 
Closes #2824
ty @KR1dude !

change miscverifier to use OT_Friendship instead of CurrentFriendship.
 2020-05-24 10:46:08 -07:00
Kurt
4a5a913142 Handle downleveled cases correctly 
Downleveled shared nest can't go below 20
Downleveled self nest can only happen for 1 or 3 badges and certain star counts, and the result can't be shiny
 2020-05-23 22:17:47 -07:00
Kurt
64428539bd Fix sav4 active block detect 
Closes #2697 ty @Ammako !

lazy slice check has flaws; just compare the major/minor counters in the save footer and check the uninitialized cases

nobody is gonna save the game 2^32 times, but check for the overflow case too!
first ff'd is preferred when the second is ff'd-1!
 2020-05-23 22:17:03 -07:00
Kurt
0cdc225224 Kecleon: Comment out static in favor of dexnav encounterslot 
Encounter Generator stops yielding if anything was yielded (assumes things that are static encounters can't have anything else that would match).

DexNav boosts the wild level (from 25/27) up to the same level 30 of the static encounter.

Thanks @KR1dude !

Co-Authored-By: KR1dude <kr1dude@users.noreply.github.com>
 2020-05-20 18:24:55 -07:00
Kurt
6970c3a5fb Remove IVersion.set property, as separate interface 
I don't want people to mutate IEncounterable.Version; it's only intended to be set on-load
 2020-05-19 21:46:05 -07:00
Kurt
301350d32b Make IEncounterable expose IVersion get 2020-05-19 21:07:30 -07:00
Kurt
cce3d5d9f5 Handle race condition on get->set new cached string 
overwrite add if it somehow was added from another thread in between lock checks
 2020-05-19 20:40:51 -07:00
Kurt
232a9de32e Add gmax ev 2020-05-18 17:04:31 -07:00
Kurt
6164884700 Merge IGeneration into IEncounterable 
all but egg exposed it; now, just make egg expose it and remove the unnecessary interface

we still need to Set generation for non-eggs/mgift, so have a separate Settable interface for internal purposes.
 2020-05-17 12:32:28 -07:00
Kurt
4f40330af9 Add Dynamax Level = 10 to showdownset if legal 
Closes #2835 ; zacian/zamazenta/eternatus can't have a DynamaxLevel other than 0.

Co-Authored-By: Mikewando <mikewando@users.noreply.github.com>
 2020-05-16 15:15:41 -07:00
Kurt
1b5292cb04 append shared egg-moves rather than early return 
dl[0].Species is the same as pk.Species; more clear && array access might be slower

only append shared egg moves if shared egg moves exist
 2020-05-15 22:49:11 -07:00
Kurt
c8a141534c make enc move gen tree fetch non-pkm specific 
just need to get all evo chains possible

fetching a GO leafeon, need to reverse leafeon->eevee, but the LGPE evo chains don't know about leafeon

works fine now
 2020-05-15 21:59:06 -07:00
ultima-soul
496a3a45ff
Add flag for Foreign DexNav Encounters Unlocked. (#2834) 2020-05-12 11:57:56 -07:00
Kurt
3210ced006 Add new gmax-pikachu distribution details 
can be shiny
can be any ability
still can't evolve

can't wait for gmax-eevee when this bcat expires ;)
 2020-05-11 17:17:27 -07:00
Kurt
045e289c0a Account for antishiny skip on the NPC mon right before shadow 
pretty much a copy from the other method with simplifications
 2020-05-11 16:52:09 -07:00
Kurt
9b0e74dd2a Update ContestStatVerifier.cs 2020-05-11 16:51:10 -07:00
Kirk Scheibelhut
0aa84f3456
Fix minor typos in FormConverter comments (#2831) 2020-05-10 14:27:12 -07:00
Kurt
4decaa73f7 Verify Contest stats on gen5 origin 
extract to separate logic class; only gen3+ call this (was originally called by gen6+); only really needs to include gen5
 2020-05-09 20:47:32 -07:00
Kurt
8650b5ceb2 Verify g4 tower ribbons as invalid on >=g5 origin 
https://projectpokemon.org/home/forums/topic/57026-gen-5-contest-stats-ribbons-bugissue/
 2020-05-09 20:45:19 -07:00
Kurt
5fc15dc9c8 Correctly prevent xd locked shinies 
oops, 7fd7a86074 was not correct (only handled lockless) -- the verifier doesn't check the final shadow pokemon (not a lock).

https://projectpokemon.org/home/forums/topic/57014-shiny-shadow-pok%C3%A9mon-from-xd-shown-as-legal-pkhex-legality-check-error/
 2020-05-08 10:07:21 -07:00
Matt
383cf3e514
Unban GO Shiny Voltorb (#2829) 
Philadelphia Safari Zone.
 2020-05-08 07:48:24 -07:00
Matt
333693775e
Update GO Shiny Banlist (#2827) 
Remove Venonat (Throwback Challenge 2020: Kanto).
Also switch to using enum like SWSH Hidden Ability banlist -- evolution families all on one line.
 2020-04-30 17:05:44 -07:00
Kurt
67b19f7244 Update Encounters8NestDist.cs 
Bye bye invalid drilbur, nice meme GF

The first rotom2 in Shield had its moves changed too. Keep that rotom-2 since Discharge can't be learned at that level.

since sw and sh have the same drilbur, it moves from sw -> common.
 2020-04-28 11:36:03 -07:00
Kurt
2e390573bc Add new meta distribution raids 2020-04-27 17:44:36 -07:00
Kurt
460062a07c add generic sav block editor 2020-04-26 16:23:06 -07:00
Kurt
6cce57d505 Add configsave to accessor 
xy battle background makes up the other 5 bits; good to know!

reorder enum to match comments in properties (switch=0)
 2020-04-26 15:17:58 -07:00
Kurt
a55b4da05c Add evo data for mimejr-0 => mrmime-0 (no gen8) 2020-04-26 12:00:45 -07:00
Kurt
ca48b4e617 Fix nick set 
Closes #2817
 2020-04-25 17:18:04 -07:00
Matt
068f6e2f5f
Fix Big Sprite ItemShiftY (#2816) 
Strange Souvenir and Room Service would get cut off since they're tall.
Also remove Adventure Guide from resources, and add Discount Coupon to Gen 7 unreleased items.
 2020-04-25 11:05:12 -07:00
Kurt
b0c94fc381 Revert "调整细节 (#2720)" 
This reverts commit 8b94794115.
 2020-04-25 08:49:18 -07:00
Kurt
0edbef8ba4 Add more HA banlist 
definitely more
 2020-04-24 08:24:12 -07:00
Kurt
8a0295e4e9 Minor clean 
GetLanguageIndex never returns <0
 2020-04-23 20:54:20 -07:00
Kurt
913d2773bf Pass form when form doesn't match encounter 
This is still a horrible hack, needs to be done similar to encounter slots

handle the galar NFE formchange cases
 2020-04-23 20:53:57 -07:00
Kurt
8a54e8c7b9 psim behavior update: Preserve "Antique" on tea export 
https://github.com/smogon/pokemon-showdown/pull/6429
 2020-04-17 11:41:34 -07:00
Kurt
cc3681c41d Update SAV6AO.cs 2020-04-16 16:38:01 -07:00
Kurt
d6171669e4 Add swsh box wallpapers 
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
 2020-04-16 14:50:41 -07:00
Kurt
47819a87c4 Update SaveBlockAccessor8SWSH.cs 2020-04-16 14:21:11 -07:00
Kurt
70e7c01896 Add more block-key settings 
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
 2020-04-16 13:37:48 -07:00
Kurt
e9406599e0 Remove more unnecessary null checks 2020-04-16 13:11:27 -07:00
Kurt
3100471299 Strip out some unnecessary logic 
notnull => no need to check for null manually
 2020-04-16 12:58:48 -07:00
Kurt
b8814d2448 Split GG into LGPE (GP/GE), GG (LGPE||GO) 
Update usages
 2020-04-16 12:48:18 -07:00
Kurt
a9a748e82d Update EncounterTradeGenerator.cs 2020-04-16 11:06:54 -07:00
Kurt
ba30f33045 Update EncounterStatic.cs 
Closes #2810
 2020-04-16 09:30:20 -07:00
Kurt
9b56eef821 Add deferral case for shiny type 2020-04-15 18:30:29 -07:00
Kurt
1192ff7307 Case insensitive shiny/suggest 
closes #2809 , nothing wrong with existing behavior, just allowing the "suggest" and "shiny" to be any.
 2020-04-15 16:23:20 -07:00
Kurt
66dddc9101 Clean up some method parameters 2020-04-14 10:59:36 -07:00
Kurt
546412e410 Rename class/method name 2020-04-14 10:59:16 -07:00
Kurt
ee1cfa8912 Hanle some compiler messages 2020-04-14 10:52:19 -07:00
Kurt
8936c58417 Skip setdex/modify on box sort 2020-04-14 10:46:21 -07:00
Kurt
40d000fdce Extract reusable method 2020-04-14 10:08:02 -07:00
Matt
be229d03fb
Update GO Shiny Banlist (#2808) 
Forgot to update when the Easter event began. Removes Shiny Exeggcute/Exeggutor.
 2020-04-13 13:57:34 -07:00
Kurt
f22b1c3e52 Update 20.04.14 2020-04-13 10:16:49 -07:00
Kurt
d398ad56d5 Update translations 
Not really much here, but that's all that's been added since last time.
 2020-04-13 09:55:21 -07:00
Kurt
49bdfa7f9d Add date copy $suggest 2020-04-13 09:23:31 -07:00
Kurt
76e1f70b9e Update ShowdownSet.cs 2020-04-12 20:31:44 -07:00
Kurt
67e9809ecd Require exact form matching 2020-04-12 19:41:03 -07:00
Kurt
33bdacebe8 Minor tweaks 
Handle some compiler/extension suggestions
 2020-04-12 16:07:59 -07:00
Kurt
0ada4cbd77 Remove some unnecessary null checks 2020-04-12 13:20:40 -07:00
Kurt
30d21e4532 Extract out showdown set interface 2020-04-12 13:05:29 -07:00
Kurt
a94c754c3f More shedinja edge cases 
Don't allow shedinja evolution moves if it wasn't evolved in that generation
 2020-04-12 11:28:03 -07:00
Kurt
8ac61d7ff7 Allow antishiny CXD spreads for some checks 2020-04-11 23:14:16 -07:00
Kurt
2e0aba55b2 Add Easter distribution raids 
No difference in sword exclusives
 2020-04-09 23:04:29 -07:00
Kurt
7fd7a86074 Shiny check lockless XD shadow encounters 2020-04-09 14:14:48 -07:00
Kurt
4d061c561a Add initial marking checks 2020-04-06 16:32:23 -07:00
Kurt
0b48034f4d && -> || 
we want to decrypt if either are set
(they should be zero as they're the always-null terminators of strings)

ty @Lusamine !
 2020-04-06 15:12:51 -07:00
Kurt
fdc174ea99 Fix raichu-a banned evolution in g7 s/m 
add a comment and parenthesis in something unrelated

Closes #2807 ty @MichiS97 !
 2020-04-06 08:10:49 -07:00
Kurt
270d984130 Minor clean 
Remove unnecessary null checks
Mark some methods with nullable type
 2020-04-04 19:30:50 -07:00
Matt
6f39f25189
Misc changes (#2806) 
Add small Female Hippopotas/Hippowdon sprites (Closes #2789)
Add Pt Togepi Gift Egg Event Constant (Closes #2801)
Remove Pokémon Den from Egg Locations (Closes #2804)
Fix Shiny Dhelmise sprite (as per 3774e0dd34)
 2020-04-04 17:10:41 -07:00
Matt
f7a83dea2c
Force Ability 1 for SWSH Gift Charmander (#2800) 
As per new findings with latest commit of pkNX: 5016baf9ea
 2020-03-27 17:47:13 -07:00
Chris
f6ad77ab04
Fix item check for silvally (pixie plate) 
Remove the comparison, was a copy/paste from Arceus 3y ago
a7339ae26f
 2020-03-27 12:15:22 -07:00
Kurt
d73457a395 Update Encounters8NestDist.cs 2020-03-26 08:40:16 -07:00
Kurt
9e8858ac51 Allow traded gen8 eggs to have OT linktrade mem 
Stupid lacking game checks
 2020-03-25 19:18:52 -07:00
Kurt
84abc04d07 3/25 Wild Area News 
Restrict abilities for crystal raids (corviknight always hidden, everything else can be anything-except-hidden).
 2020-03-25 19:02:09 -07:00
Kurt
a7026236cc Fix order of operations 
underflow behavior is desired; (uint)(10-15/10) results in zero
 2020-03-25 14:37:41 -07:00
Kurt
d65338557e Add hp stat 2020-03-24 11:44:54 -07:00
Kurt
f4952faa6f Add zh2 trade localization 
ye it's different from the zh strings, resulting in different nick/OT

ty @Lusamine !

add another gyarados location while we're here
 2020-03-21 10:48:26 -07:00
Kurt
5402c5d108 Update Analysis.cs 2020-03-20 23:26:45 -07:00
Kurt
aaf6642d31 Rename Data -> BinLinker 2020-03-20 15:18:59 -07:00
Kurt
799e4852cf Minor clean 2020-03-20 13:33:15 -07:00
Kurt
dbfcef2efe Move files to group subfolder 2020-03-20 12:13:37 -07:00
XxPhoenix1996xX
d66d761d3c
Update Spanish Translation (#2795) 
* Update lang_es.txt

* Create flags_gg_es.txt

* Update PKHeX.Core.csproj
 2020-03-20 11:42:58 -07:00
Kurt
cce28df6e3 Update PKMConverter.cs 2020-03-20 09:28:16 -07:00
Archit Date
e3e46209e9
add back watchtower as a legal location (#2796) 
made an oopsie, Watchtower Ruins also apparently includes 2 extra dens that can spawn encounters that are not 8NC. Den 17 is locked to 8NC encounters only, but location-wise there is no difference between Den 15,16,17
 2020-03-20 07:22:44 -07:00
Kurt
c8343e9f5d Update EncounterArea8.cs 2020-03-19 22:15:01 -07:00
Kurt
72e0fbe225 Update EncounterArea8.cs 2020-03-19 21:06:46 -07:00
Kurt
61cbf04c2e Fix comparison to watchtower, not wild area 
unshuffle the IVs for comparison, oops
 2020-03-19 21:04:17 -07:00
Kurt
a188317e84 Add another diggersby location 
ty @Lusamine
 2020-03-19 20:50:58 -07:00
Kurt
27d1feafd7 Revise egg wc3 fateful check to return instead of break 
Emerald has the same met locations too, which doesn't clear fateful. So if it was hatched in an RS(E) location, we can't know for sure.

Closes #2790 , but keep in mind the posted file is illegal anyways -- can't get egg move aromatherapy with wish.
 2020-03-19 17:05:16 -07:00
Kamron Batman
a33fa5efbe
Fixes files (#2792) 2020-03-19 13:48:46 -07:00
Kurt
5e32e9203e Add setting to apply nature to statnature on import 
Co-Authored-By: toim22 <toim22@users.noreply.github.com>

#2794
 2020-03-19 13:47:25 -07:00
CanoeHope
df09868470
Add another SWSH block (#2793) 
Nothing special. Just found it and figured why not add it.
 2020-03-19 11:38:17 -07:00
Kurt
287a2ac5c5 Rework handling of bk4 constructor 
Can't really detect if it's shuffled or not; just assume it's always unshuffled unless it originates from a save file read. Probably not a perfect solution, but achieves better results.

https://projectpokemon.org/home/forums/topic/56217-error-in-archive-bk4/
 2020-03-18 23:34:53 -07:00
Kurt
090f83d197 Unban and337 as held item 2020-03-18 22:31:41 -07:00
Kurt
afeb06d3ae Allow ability 1/2 for wb7 origin 2020-03-18 22:31:27 -07:00
Kurt
093586bb69 Update Encounters8NestDist.cs 2020-03-18 22:23:21 -07:00
Kurt
d06949bdb3 Update min level clamps, actually compare req PID 
Closes #2787
The commit a couple days ago added the missing minimum level restrictions; community documentation was slightly misleading but we should be good now.

The PID check was nonfunctional (compared A==A or A==A*), rather than actually checking the fixed PID.

Co-Authored-By: feralfalcon <feralfalcon@users.noreply.github.com>
 2020-03-18 12:23:09 -07:00
XxPhoenix1996xX
8a1405125e
Add Spanish Event Flags Translation / Update Spanish Translation (#2786) 2020-03-18 10:25:22 -07:00
Kermalis
face69d469
Fix Emerald decorations (#2788) 2020-03-18 00:25:02 -07:00
Kurt
429a3b1a08 Expose decoration list for editing 
Closes #2785 , not making a GUI for this (someone else can do it)

Moves RTC3 to the appropriate folder
 2020-03-17 12:14:01 -07:00
Matt
d004389a3e
Update Gen 4 trade min levels (#2769) 
Eggs hatch at Lv. 1 in Gen 4, and some other Species can be found in the wild at Levels lower than their intended evolution requirement.
Closes #2768
 2020-03-16 18:14:22 -07:00
Kurt
98cd28d5d3
Swap string differentiation for HOME gifts 
30018 is used by the gift; original fake WC's that EventsGallery created used the 40086 (now fixed on their repo)
2180608ed2
 2020-03-16 12:05:33 -07:00
Kurt
1c6b99185d Ignore bits above the first 3 
Some save files use bits 3-7?
 2020-03-15 11:11:55 -07:00
Kurt
3aaf318035 Update event database, handle HOME gifts horribly 2020-03-14 14:22:45 -07:00
Kurt
d21cca7a90 Move gmax strip to top 2020-03-14 12:21:42 -07:00
Kurt
94d8125574 Split up Friend Safari checks & generator 
removes one GetEnumerator call for non-fsafari encounters
 2020-03-14 11:32:27 -07:00
Kurt
6a5bf02126 Add min levels for trades 
Make PIDs readonly for trades
Clone FR/LG Lickitung (different min levels)
 2020-03-13 21:39:35 -07:00
Kurt
c4ce22412a Handle japanese name if egg 
Closes #2756

For eggs that we don't know the OT of, they'll still show invalid (empty string).
ty @PrometheusG !
 2020-03-13 18:37:51 -07:00
Kurt
0a39e0a834 Handle gmax tox with latest showdown logic 2020-03-13 17:43:21 -07:00
pi1024e
8a1e73e5b3
Change OT_Class to have an expression body (#2759) 2020-03-13 10:28:50 -07:00
Kurt
6f0c3c1205 Add 3 more met locations 
Co-Authored-By: Lusamine <lusamine@users.noreply.github.com>
 2020-03-12 20:36:31 -07:00
Kurt
b68e9472cb Break apart value fetch -> compare 
easier to debug
 2020-03-12 15:05:59 -07:00
Kurt
fbd533092d Fix misspelling of the word "Received" 
Closes #2757

Co-Authored-By: pi1024e <pi1024e@users.noreply.github.com>
 2020-03-12 15:05:34 -07:00
Kurt
eb01591861 Remove duplicate method 
Extract magic number 0x40000
 2020-03-11 21:09:36 -07:00
Kurt
b5f1fc71c4 Use original PID for xor flip check 
swap pkm.PID -> pkm.EncryptionConstant, simplify comparison

Co-Authored-By: Lusamine <lusamine@users.noreply.github.com>
 2020-03-11 20:09:09 -07:00
Kurt
dcb7336d92 Hide pika beach on !YW, add a few RS flags 
Closes #2745 , ty @FeralFalcon

hidden items are meh, items can be hacked in.

Co-Authored-By: feralfalcon <feralfalcon@users.noreply.github.com>
 2020-03-11 19:33:17 -07:00
Kurt
1d5f929981 Fix shiny check behavior for XD nonshadows 
XD compares the player TSV against the non-shadow members, which is unnecessary but does result in them being able to cause shiny skips.

Update the VerifyNPC method to remove tsv check, as it's just repeating the logic we've done in the lock generator.

Added a test method that can be stepped through; compare the team results manually since they aren't exposed for interaction.

Closes #2751 , big thanks to @ijuintekka for being so detailed in their investigation/report!

Co-Authored-By: ijuintekka <ijuintekka@users.noreply.github.com>
 2020-03-11 19:18:58 -07:00
qhq
b799819131
Update text_Forms_zh.txt (#2753) 2020-03-11 18:18:27 -07:00
Kurt
efc0a9bcc4 Ban HA Pumpkaboo/Gourgeist Small/Large 
Co-Authored-By: Lusamine <lusamine@users.noreply.github.com>
 2020-03-11 17:38:01 -07:00
Kurt
1c2d9cf84c Add another Lanturn location, level 38 Corviknight 
Yay using bots to collect encounter data from players around the world :P

Co-Authored-By: Lusamine <lusamine@users.noreply.github.com>
 2020-03-11 16:38:04 -07:00
Kurt
0aa6282d73 Sanity check value types via generic method 2020-03-11 16:31:53 -07:00
Kurt
f9bbeba3ad Add get/set for swsh current box 
Closes #2742

Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
 2020-03-10 23:18:51 -07:00
Kurt
eccfb61839 Update BallVerifier.cs 2020-03-10 22:59:46 -07:00
Kurt
9dbc3cd418 Permit galar native species to inherit past-gen balls 2020-03-10 17:53:56 -07:00
Kurt
093ce2a020 Add ★And337 4-Star Gigantamax Corviknight 2020-03-08 17:20:00 -07:00
Kurt
e2c579fbbc 3/8 - Gengar/Machamp nests 
New? Dynamax Crystal: ★And337 - 4-Star Gigantamax Corviknight ???
 2020-03-08 17:14:20 -07:00
qhq
5d63235dee
Update LegalityCheckStrings_zh.txt (#2752) 2020-03-06 05:54:13 -08:00
Kurt
d7cebb9d0c
Update LegalityCheckStrings_es.txt (#2750) 
Making some changes on the previous strings update (not putting away Phoenix's effort tho!)
 2020-03-05 10:59:32 -08:00
Kurt
116962317c
Update LegalityCheckStrings_es.txt (#2748) 2020-03-05 08:01:42 -08:00
Kurt
ed02f39224 Use another overload 
Co-Authored-By: Archit Date <architdate@gmail.com>
 2020-03-04 22:31:07 -08:00
Kurt
4c226340fe Add shiny sprites, alcremie sprites & big sprites for all 
Keeping the 30x40 for now; might change my mind later.
Kept the gmax sprites but they're unused.
 2020-03-03 20:22:57 -08:00
Kurt
7919beaddc Filter out duplicate moves 2020-03-03 18:23:00 -08:00
Kermalis
5a89c6af4c
Gen 3 Flags (Remastered!) (#2744) 2020-03-02 16:44:52 -08:00
Kurt
a83556d612 Heal x->pk8 converts 2020-03-02 16:32:23 -08:00
CanoeHope
e51df9855d
Add blocks for NPC and Friend League Cards (#2741) 
* Add blocks for NPC and Friend League Cards

* Update SaveBlockAccessor8SWSH.cs
 2020-03-01 00:47:56 -08:00
Kurt
4fb33413e3 Only set display shiny of not owned 
Closes #2740 ; we don't want to set display shiny if it's not shiny

we only want to set display-shiny if (!owned && shiny)

Co-Authored-By: canoehope <canoehope@users.noreply.github.com>
 2020-02-28 17:35:50 -08:00
Kurt
d80d1598dc Only set displayed form if not previously owned 
Closes #2739
 2020-02-28 15:31:26 -08:00
Kurt
d58426ebf5 Hide affection fields, remove setters for unused 
#2738
 2020-02-27 20:53:33 -08:00
Kurt
b831d52b79 not capturable 
gotta drip feed content -- tease ppl to migrate from prior games ($$$)
 2020-02-26 17:16:52 -08:00
Kurt
283b7a353b Add mewtwo raids 
Mewtwo encounter has been added; awaiting confirmation that it can be captured (assumed yes)

Gen1 starters can be captured in beast ball in gen7 (scan), so nothing changes for ball legality.
 2020-02-26 17:03:53 -08:00
Matt
0b5116f567
Add Battle Frontier + Facilities to Valid HGSS Met (#2735) 
Accessible in Pt/HGSS, but not DP.
Closes #2734
 2020-02-25 13:15:50 -08:00
Kurt
549e6f616b allow shared eggmoves on format 2020-02-22 23:27:47 -08:00
Kurt
d93b603a31 Merge branch 'master' of https://github.com/kwsch/PKHeX 2020-02-22 19:47:28 -08:00
Kurt
e378821101 Remove duplicate key item list for pc items 
Closes #2733

Co-Authored-By: kermalis <kermalis@users.noreply.github.com>
 2020-02-22 19:47:25 -08:00
Kermalis
441a60a2fb
Some gen 3 flags (#2732) 2020-02-21 21:42:34 -08:00
Matt
7cb80fdbc5
Update GO Shiny Banlist (#2731) 
- Valentine’s Day Event (Chansey)
- Raid Day (Lickitung)
- February Community Day (Rhyhorn)
 2020-02-21 19:40:10 -08:00
Kurt
5240e67a14 Revert "Loop shiny force regardless of format" 
This reverts commit cc8e5d9c32.
 2020-02-21 15:02:16 -08:00
Kurt
509e2f1fa3 Handle more evolution/form checks 
Closes #2726
1. Add variant evolutions to form-match cases
2. Ban LGPE origin alolan raichu
3. Add egg form check for unavailable regional forms
4. Previous commit fixed mew (remove ribbon interface from WB7)

Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
 2020-02-20 22:11:48 -08:00
Kurt
4771158194 Remove ribbon check for mew 
- Data is set to give a Classic ribbon
- The classic ribbon isnt ever applied
- nor does a transferred pb7->pk8 get it

so just remove the interface and treat it as unused (cuz it is, unused.)
 2020-02-20 21:43:02 -08:00
Kurt
4116fb5b9b Fix sprite format for gen3 
Closes #2725

Fix crash if canceling the FRLG version select

Co-Authored-By: Kermalis <kermalis@users.noreply.github.com>
 2020-02-20 19:36:06 -08:00
Kurt
03c58dbe89 Use selected language instead of sav lang 2020-02-19 21:32:01 -08:00
qhq
8b94794115
调整细节 (#2720) 2020-02-17 20:22:36 -08:00
Kurt
66efbaf407 Add box manip for heal all slots 2020-02-17 19:28:20 -08:00
Kurt
15121c2945 Fix shared egg moves for non-galar origin 
Use the private method; we already know the gen and that the egg moves are permitted

Relocate method to MoveEgg
 2020-02-16 19:47:57 -08:00
Kurt
0e2734d2d5 Add evo data for alolan raichu / weezing 
Ban the evolution methods since they can't be triggered in-game
allows the gen8 evo tree to reverse evolve past gen specimens
 2020-02-16 18:16:22 -08:00
Kurt
ee38e6890b Disallow gen7 ribbons on lgpe origin 2020-02-16 17:41:38 -08:00
Kurt
f48a11f013 add 2/17 raids 
milcery gone, toxel appears
 2020-02-16 17:02:53 -08:00
Kurt
fc9d0b4b24 Add hint for pkm with dummied moves 
Closes #2716
 2020-02-16 12:17:36 -08:00
Kurt
cc8e5d9c32 Loop shiny force regardless of format 
https://github.com/kwsch/PKHeX/issues/2717#issuecomment-586741748
 2020-02-16 11:46:06 -08:00
Kurt
0d4cff81c6 Clean 2020-02-15 14:29:23 -08:00
Kurt
5e65df6758 Update egg ball check for galar non-natives 
pretty rough check, but flags the old starters in bad balls now
 2020-02-15 14:22:37 -08:00
Kurt
21eb9cb499 Remove gen7b trade evo if HT present requirement 
lgpe->HOME->lgpe can set the HT details, but it isn't a trade.
 2020-02-15 13:43:58 -08:00
Kurt
3e4bb9f320 Ignore keldeo resolute form check on gen8+ 
can mismatch in gen8+ as the form activates in battle when knowing the move; outside of battle can be either state.
 2020-02-15 13:30:50 -08:00
Kurt
9e16df4970 Only check g6 contest ribbon affection in g6/7 
Affection is discarded on PK7->PK8 in favor of friendship, which can be lowered.
 2020-02-15 11:43:21 -08:00
Kurt
b9e3ddf612 Disallow regular slowpoke 
Closes #2708
Can't be moved into the game (no sprites yet).

To be removed or handled a better whenever DLC comes out.
 2020-02-14 14:52:05 -08:00
Kurt
9efaae0df6 Remove unneded property copy 
eggs didnt exist in lgpe, would be all zero anyways
memories copy in pk7, remove todo
 2020-02-14 14:48:48 -08:00
Kurt
ae0777018c Update PB7.cs 
Co-Authored-By: Chris Feger <piepie62@users.noreply.github.com>
 2020-02-14 11:48:13 -08:00
Kurt
d560fbcf7f Fix typo 
Co-Authored-By: Chris Feger <piepie62@users.noreply.github.com>
 2020-02-13 21:00:07 -08:00
Kurt
0c83c48cef Add MrMime-1 check for past gen origin 
permit mime jr evolving to mr mime-1
 2020-02-13 20:00:41 -08:00
Kurt
f62b6e33f3 handle alolan meowth origin in gen8 
https://projectpokemon.org/home/forums/topic/56267-checks-associated-with-events-or-forms/
 2020-02-13 17:05:06 -08:00
Kurt
3ce590aca8 Don't clear FormArgument on set to box slot 
Closes #2706
removal of isParty prevents the erroneous force-0 behavior

Co-Authored-By: Russell Jones <questiondesk@gmail.com>
 2020-02-13 16:35:37 -08:00
Kurt
c855bb8bcc Expose method for reuse in other projects 2020-02-12 20:42:45 -08:00
Kurt
75d8635580 Fix lgpe moveset restriction 
Closes #2704

Co-Authored-By: BetaLeaf <betaleaf@gmail.com>
 2020-02-12 20:25:39 -08:00
Kurt
6346444db7 Extract home tracker to interface 2020-02-12 18:52:48 -08:00
Kurt
3d6846eb3e Permit more HA breeding 
Remove non-galar species from gen8 banlist
Add Ban_NoHidden8Apricorn -- all of these aren't even breedable in-game anyways, but futureproof for DLC? ;)
 2020-02-12 18:40:41 -08:00
Kurt
258993ad0c Flag missing tracker regardless of setting 2020-02-12 18:29:47 -08:00
Kurt
6ef2950cc4 Add toggleable flag setting for tracker, update translations 2020-02-12 18:14:23 -08:00
Kurt
63044cd3f9 Add tracker unique text & setting 2020-02-12 18:10:24 -08:00
Kurt
e77fa205a0 Add tracker editor 2020-02-12 18:10:03 -08:00
Kurt
fd4690714e Add duplicate tracker SAV check 2020-02-12 16:37:59 -08:00
Kurt
9f6d234c53 Fix hgss box wallpaper read 
lol oops
Closes #2698

Co-Authored-By: ammako <ammako@users.noreply.github.com>
 2020-02-11 23:24:03 -08:00
Kurt
d3c060e1d4 Add pt flags 
Closes #2699

Co-Authored-By: FeralFalcon <feralfalcon@users.noreply.github.com>
 2020-02-11 23:21:21 -08:00
Kurt
3e9262efbb Only check memory feeling restriction if gen6 
dunno restrictions for gen8 memories.
 2020-02-11 22:25:50 -08:00
Kurt
87bb4c4138 Add more met locations 
https: //projectpokemon.org/home/forums/topic/56227-bug-missing-game-encounter-affecting-legality-status/
Co-Authored-By: pp-theslayer <pp-theslayer@users.noreply.github.com>
 2020-02-11 20:50:26 -08:00
Kurt
d97db1cc40 Allow pk7->pk8 pikachu cap transfer 2020-02-11 20:36:10 -08:00
Kurt
ebf20d927b More transfer implications 
Totems are downsized to regular
araquanid, togedemaru, and ribombee totems can't transfer (at the moment)
 2020-02-11 20:11:33 -08:00
Kurt
435953f4e1 Don't transfer locale 2020-02-11 19:04:00 -08:00
Kurt
217156d2b9 Continued comparisons & implications 
pk7->pk8 doesnt assign height/weight (zero), require zero for legal
p*7->pk8 assigns a tracker value, enforce something is present for legal
copy OT friendship (oops)
 2020-02-11 18:35:54 -08:00
Kurt
332f92f5e9 Update p*7 transfer logic 
Add scalars & stat natures

Do note: there is more data that is set and can potentially be used to flag you for cheats. Beware.
 2020-02-11 18:05:07 -08:00
Kurt
7523639b48 Unbanana galar transfers 
Initial restriction removal, probably more implications

Need to reverse transfer logic
 2020-02-11 17:29:10 -08:00
CanoeHope
29814d4251
Change FRLG hatch location (#2700) 
Better location.
 2020-02-11 15:39:27 -08:00
CanoeHope
7ab128de89
Add SwSh Birthday blocks (#2696) 
Because the Switch doesn't have a feature to internally store your B-day like the DS and 3DS does, you set it in-game by the "Fortune Girl" right in front of Wedgehurst's PokeCenter in month and day.
https://www.serebii.net/swordshield/birthdays.shtml
 2020-02-10 18:14:20 -08:00
CanoeHope
d3a284699f
Change Gen 5 hatch location (#2695) 
Skyarrow Bridge is more popular to hatch at legitimately.
 2020-02-10 12:52:55 -08:00
CanoeHope
acb9cc2a9d
Add Gender to Gen 8 Trainer Card (#2694) 2020-02-10 12:02:52 -08:00
Kurt
cb5d8186fd Defer formargument for raids 
Closes #2693
Account for runerigus too, if they ever have a den for it ;)

Co-Authored-By: crzyc <crzyc@users.noreply.github.com>
 2020-02-09 15:04:45 -08:00
Kurt
b94430a89f Ban bred HA voltorb in beast ball 
https://projectpokemon.org/home/forums/topic/56212-legality-ha-voltorb-in-beast-ball/
https://www.reddit.com/r/BankBallExchange/comments/7boi0h/new_apricorn_and_beast_ball_combinations_for_usum/dpwu5in/

ty Prophet丶W
 2020-02-08 20:24:02 -08:00
Kurt
4656978a43 Enforce toxtricity encounters to have restricted nature 2020-02-08 15:08:12 -08:00
Kurt
e9e1e5e166 Fix encounter find for passed egg moves 
https://projectpokemon.org/home/forums/topic/56188-encounter-database-froslass-error/
 2020-02-08 13:36:37 -08:00
Kurt
8e5876b96f Expose item->form methods 2020-02-07 21:34:25 -08:00
Kurt
48bc4ec8fa Don't yield twice 
oops lol
 2020-02-07 21:34:05 -08:00
Kurt
6d24905a7d Update hypertrained IVs on export 
Don't indicate flawed IVs; just pre-compute the hidden power type.
Remove unnecessary language logic (not needed due to prior commit)

Optimize string concat to a single interpolation, because it's totally a performance improvement!!!1
 2020-02-07 17:50:42 -08:00
Kurt
9ffac4382a Replace gender symbols for nidoran with -M/F 2020-02-07 17:42:28 -08:00
Kurt
1cd23e6587 Don't include language name as nickname on set export 2020-02-07 17:42:16 -08:00
Kurt
1bf22467de Add Rental Team (gen8) reader 2020-02-07 17:23:26 -08:00
Kurt
d52366b0d5 Add download rules/comp block labels 
https: //projectpokemon.org/home/forums/topic/56121-swsh-blocks-and-save-research/
Co-Authored-By: pp-theslayer <pp-theslayer@users.noreply.github.com>
 2020-02-07 16:32:05 -08:00
Kurt
a73f14836d Add HoF time block accessor object 
Not gonna add it to the interface
Closes #2691

Co-Authored-By: canoehope <canoehope@users.noreply.github.com>
 2020-02-07 15:59:36 -08:00
Kurt
c08cf9c95f Add rental team hashes 
Co-Authored-By: Archit Date <architdate@gmail.com>
 2020-02-07 15:33:53 -08:00
Kurt
7866958af8 Add dynamax crystal type, exclude from activation 
Closes #2690

Co-Authored-By: slp32 <slp32@users.noreply.github.com>
 2020-02-07 10:16:27 -08:00
Kurt
6e5ef9667f Add female gender check for stadium 
Closes #2687
 2020-02-06 21:25:13 -08:00
Kurt
cc05a38548 Clear team slots on blank load 
Closes #2688
 2020-02-06 20:11:58 -08:00
Kurt
cdd4cb33b2 Add togepi hgss const 
Closes #2689

Co-Authored-By: asterysx <asterysx@users.noreply.github.com>
 2020-02-06 19:36:47 -08:00
Frank
e5286f3325
RaidSpawnList8 fix DenType and Flags (#2686) 
* RaidSpawnList8 use enum RaidType for DenType

fix IsWishingPiece and add WattsHarvested

* Add check between RaidType.Event and IsEvent flag
 2020-02-06 17:12:26 -08:00
Kurt
29258ca501 Add tox nests 2020-02-06 17:11:39 -08:00
Kurt
a004b301d0 Add record count incrementing for sav8 
Closes #2685 ty @CanoeHope
 2020-02-05 19:42:46 -08:00
Kurt
81c78be8c7 Change default gen7 hatch location 
ty @CanoeHope #2685
 2020-02-05 19:42:22 -08:00
Kurt
bc45660f99 Update legal raid clamp 
https: //github.com/kwsch/PKHeX/issues/2681#issuecomment-582215498
Co-Authored-By: slp32 <slp32@users.noreply.github.com>
 2020-02-04 19:06:33 -08:00
Kurt
d3d6225a73 Fix unown ?! order 
Closes #2683
ty @Kermalis !
 2020-02-04 19:03:55 -08:00
Kurt
5ac9782320 Form check wild unown 
Closes #2682
 2020-02-04 17:38:35 -08:00
Kurt
2e1528b199 Merge branch 'master' of https://github.com/kwsch/PKHeX 2020-02-04 16:55:42 -08:00
Kurt
7e6cae4004 Clamp activating raids to available indexes 
Closes #2681
 2020-02-04 16:55:40 -08:00
Yurical
a4e579c49b
Update Korean translation (#2680) 2020-02-04 07:36:40 -08:00
CanoeHope
9b172d2666
Correct Day offset (#2679) 
a1ae14325a (commitcomment-37103852)
 2020-02-04 07:35:02 -08:00
Kurt
867f62c555 Check multi lang stadium OTs 
Closes #2671
really wish the gen1-3 event data was serialized ;)
 2020-02-03 20:10:07 -08:00
Kurt
bdf6afd2f3 Fix egg trainer name logic for wc3 
Closes #2676
 2020-02-03 19:22:16 -08:00
Kurt
0e1fd49be1 Decrement runtime language if appropriate 
Closes #2674
 2020-02-03 19:16:30 -08:00
Kurt
a1ae14325a Add more block documentation 
Ty @CanoeHope !
Closes #2677

To edit these values, use the Block Data editor and select the *Object Trainer Card

Co-Authored-By: CanoeHope <canoehope@users.noreply.github.com>
 2020-02-03 18:56:35 -08:00
Kurt
522dbdbe32 Flute boost/decrease 3->4 
Closes #2678 ty @Rayqo
dat level 1 wild pokemon 👍
 2020-02-03 18:40:31 -08:00
Kurt
b31f0428cf Add raidtype docs & wishing piece indication 2020-02-02 10:21:34 -08:00
Kurt
222d95e742 Add bridge field loc for nest35 
https://projectpokemon.org/home/forums/topic/56154-illegal-theivul/
 2020-02-01 21:45:33 -08:00
Kurt
43036e7e94 Add team index recognition 
lock by default until we find the location that locks team slots
 2020-02-01 18:56:23 -08:00
Matt
cbf6c1e1b6
Unban Star Sweet and Ribbon Sweet (#2670) 
Item drops from the new Milcery distribution Raids.
 2020-01-30 19:30:17 -08:00
Kurt
774dec5123 Add milcery distro nests 2020-01-30 16:44:51 -08:00
Archit Date
c8a16a1f71
fix yamask/runerigus form handling (#2669) 
fixes #2668
 2020-01-29 16:11:56 -08:00
Kurt
b35d53368f Sort blocks by initial value 
allows some lumping of similar-value blocks for easier analysis
 2020-01-28 19:08:26 -08:00
Kurt
dd07126d83 Relocate level suggestions to EncounterSuggestion 2020-01-28 16:21:38 -08:00
Kurt
ee5c033b51 Add dlc block annotations 
ty @pp-theslayer
https://projectpokemon.org/home/forums/topic/56121-swsh-blocks-and-save-research/

add another array detail
 2020-01-28 16:21:11 -08:00
Kurt
3111a8dc62 Cast the array a little safer 
bad hacks with invalid future gen evolutions yield no evolution data, which results in empty arrays.
 2020-01-26 23:58:14 -08:00
Kurt
a3e9649f09 Update 20.01.26 
Update with latest events from EventsGallery
 2020-01-26 00:35:31 -08:00
Kurt
f0fb6a2371 Play with living dex gen a little 
generate altforms too, store in a list
 2020-01-25 22:54:25 -08:00
Kurt
c301ce88ab Update Random to be a bit more thread safe 
Random isn't thread safe; users of PKHeX.Core.dll might run multithreaded operations (see PKSM + ALM), so we need to have a thread-specific RNG available.

Thread Local get; to improve performance, save the random object locally whenever it is used more than once in the method.

https://docs.microsoft.com/en-us/dotnet/api/system.threading.threadlocal-1?redirectedfrom=MSDN&view=netframework-4.8
https://stackoverflow.com/questions/18333885/threadstatic-v-s-threadlocalt-is-generic-better-than-attribute/18337158#18337158
 2020-01-25 21:49:52 -08:00
Kurt
edc95efe95 Add 2 more b2w2 flags 
Closes #2661
Add more clarification for kyogre/groudon const value; not gonna re-localize myself :P
 2020-01-25 18:09:27 -08:00
Kurt
9b062bc770 Remove unused legality check strings 
Fix spanish translation messages not being loaded
 2020-01-25 17:37:47 -08:00
Kurt
ffa70e7626 Move files 
no functional change, just putting stuff in a more appropriate folder
 2020-01-25 17:22:20 -08:00
Kurt
b5d48bc14f Split up portions of CommonEdits 
Cuts out about half the size; there's still a bunch of apply-value logic but it's not really big enough for a separate class.

Rename BallRandomizer->BallApplicator
 2020-01-25 16:47:44 -08:00
Kurt
88dcb59798 Extract language initialization to core 
Call this method whenever you boot a separate app that needs legality strings to be ready.
 2020-01-25 16:27:16 -08:00
Kurt
3813d5dba9 Readonly init EvolutionMethod 
Add xmldoc
 2020-01-25 15:42:17 -08:00
Kurt
9c28ffacc0 Simplify N's pkm encounter handling 
Readonly PID; sparkle is True always, so it's a const instead of a mutable property.
 2020-01-25 12:31:56 -08:00
Kurt
7a7358d0e5 Flag g4 bad met locations for hatched eggs 
Traded eggs in gen4 can have from any game (since version isn't updated on hatch).
Use the hashsets, and remove the incorrect array. The incorrect array allowed stuff like Pokéwalker to be a "valid met location", hah.
 2020-01-25 12:19:59 -08:00
Kurt
527442bb49 Only fetch strings when required for compat check 
if item == 0, don't bother checking. Fetch strings only if there's an issue with the item.
 2020-01-25 12:16:45 -08:00
Kurt
63ee520e75 Fix de ribbon name missing 2020-01-25 10:17:02 -08:00
Kurt
c730dfa1ba Remove empty ushort[1], improve item combo fetch 
held item list now allocates less (concat arrays instead of ienumerables)
item list already prunes out of range items, so simplify data source fetch
simplify item list prune (return as list, so we can call RemoveAll instead of Where.ToList)
 2020-01-24 23:29:45 -08:00
Kurt
6dddb0526f Fix starter order 
Closes #2660
 2020-01-24 20:18:26 -08:00
Kurt
f50ee0f18e Update gen3/4 event flag lists 
Closes #2659 ty @FeralFalcon !
 2020-01-24 18:13:23 -08:00
Kurt
9b6a10df46 Extract metadata-reflection class to PKHeX.Core 
separate GUI logic from non-gui logic :)
 2020-01-24 17:57:47 -08:00
Kurt
94eee74e5c Add another rhydon lvl 46 loc 
Ty @slp32 for reporting in #2633, && anubis (discord) for finding the actual level without being asked /s
 2020-01-24 17:56:42 -08:00
Kurt
92d1ccf3d9 Fix Pokewalker course unlock all 
write to correct location
https://projectpokemon.org/home/forums/topic/56084-pokewalker-courses/
 2020-01-24 17:10:53 -08:00
Kurt
46156b48c6 Add missing generation to accessor type name 
Now matches Interface declaration style (iAccessorGenGame), and is consistently named with the other accessors already using the same naming style
plus they are now ordered in the file tree :)

no functional change
 2020-01-23 23:22:54 -08:00
Kurt
fb02295c70 Use object block names in diff 2020-01-23 23:19:38 -08:00
Kurt
12244909ba Split off SCBlock-logic from SWSH accessor 
In case a future game uses this same setup.
 2020-01-23 23:16:09 -08:00
Kurt
2adbca628b Add raw value edits 
Not done for Array types or Object types
muh reflection, such spooky

mark Offset as non-browsable so it doesn't show up in propertygrid if the block is being edited by a grid :)

I imagine a struct-type-sensitive array property grid edit could be done via Buffer.BlockCopy to a dest array, but there's so few Array blocks... so meh
 2020-01-23 21:30:39 -08:00
Kurt
99baa171f4 Indicate known block types at top 
Uses reflection to grab a list of defined constants (block keys), and a list of defined block reader classes.

Show name of block in red for a more prominent hint that this block is somewhat editable :)
 2020-01-23 20:11:39 -08:00
Kurt
a88c7c4800 Add more trainer card/status fields & stats 
Closes #2658 ty @CanoeHope !
Mostly just serves as documentation; with the amount of fields being editable increasing, hard-coded GUI might not be optimal here. I'm thinking something like a PropertyGrid based on the selected block which will pull up the Block object if the key matches... for fields, something like a dynamically populated list or something.
 2020-01-23 18:31:10 -08:00
Egzon
a5985536e2 Miscelanous fix on Underground Scores (#2657) 
* UG scores are uint32, with max value up to 999999.

* fixing label position

* another positioning fix!
 2020-01-23 16:37:39 -08:00
Kurt
ecfcbbc4cb Verify full raid result with known seed 2020-01-23 00:11:07 -08:00
Kurt
467045e95c Swap rand call order, rename as overload 2020-01-22 19:04:20 -08:00
Kurt
ba5cc26e83 Add indication to which blocks changed 
Use reflection to grab all const declarations (private and public), and grab the name of that const. Whenever that block is mentioned in our diff, use the name instead of the key.

Helps identify what changed / remove noise if you don't care about that block.
 2020-01-22 17:06:23 -08:00
Kurt
4ea2be250f Add TitleScreen8 and Trainer Card team structs 
Closes #2653 , ty @CanoeHope !

Editable from the Trainer Info button, comes with a Copy From Party button for each.
 2020-01-21 23:23:27 -08:00
Egzon
9cce65e937 Fix Subway Super checks (#2652) 
Oops, it's actually a byte...
 2020-01-21 11:00:09 -08:00
Kurt
d9c162b5cf Fix criteria comparison 
Closes #2651
 2020-01-21 09:05:39 -08:00
Kurt
5be9c6bcc8 Remove unnecessary null handling 
objects are no longer null
 2020-01-20 23:32:05 -08:00
Kurt
5bb51b07ac Check Footprint Ribbon for gen8 
gen7 used same as gen6, we just need to restrict gen!=8
add placeholder LGPE origin check; that'll likely throw a wrench into things when HOME happens (next month?).
 2020-01-20 23:09:28 -08:00
Kurt
b84cae9ff5 Fix box name write for sav8swsh 
only used via the view-all-boxes popup when switching boxes
ty anubis!
 2020-01-20 22:04:52 -08:00
Kurt
6fdc71b2e4 Update tower record set 
Record ID const declaration for reuse
Change 255->300 for streak max
Set record as well (ignore currently set value if modified via dropdown)
Closes #2649

Not sure if Money and BP can get a similar record-set treatment.
 2020-01-20 18:16:46 -08:00
Egzon
1a3d8b1fab Fix Seedot and Nuzleaf swarm moves (#2648) 2020-01-20 14:31:59 -08:00
Archit Date
117bb35621 handle smogon sets with multiple moves (#2647) 
sometimes competitive sets have multiple moves in one slot as optional coverage moves. Handle these cases by splitting and trimming over '/'.  Example: https://pastebin.com/raw/jvPziRdC (The dusk mane set)
 2020-01-19 22:30:09 -08:00
Kurt
40e5cd66da Add block diff for swsh, add bool type toggle 
Apparently my copypaste of the class didn't delete all the old unused controls. Ha!

Move non-gui logic to core as separate classes, in case ppl wanted to reuse them in their own projects.
 2020-01-19 22:29:50 -08:00
Kurt
d788af45cd Unban HA mimikyu 
Only one encounter for mimikyu = A4 }, // Mimikyu
Update manual banlist to permit it
Closes #2646
 2020-01-19 19:02:53 -08:00
Kurt
a98ca2351d Don't SetValue to block if not exportable 
blank saves do not have the type metadata for the blocks that are spoofed, nor do they have all blocks spoofed.

I suspect things might get more difficult as more value-blocks are identified, which would throw a wrench into things. We'll figure that out at that time :)

Add a test to ensure that the blank save can be created correctly

Closes #2644
 2020-01-19 10:25:40 -08:00
Kurt
4567bba03f More elegant block read/write 
Removes TONS of unnecessary allocations, and is more simple
 2020-01-19 00:55:10 -08:00
Kurt
0244cc7489 Add more info to exception message 
Closes #2644
 2020-01-18 19:44:34 -08:00
Egzon Qukovci Jusufi
ab5016bf7d Add Subway Scores edition (#2643) 
* Add Subway Scores edition

* Changing the offsets handling

Simply use the block offset as the base and add them to it. Also allow edition on B2W2.
 2020-01-18 19:31:36 -08:00
Kurt
63ea57436f Make the template IV/contest stat array readonly 
See prior commits
no longer need to clone subarrays, they're shared immutable
 2020-01-18 19:11:29 -08:00
Kurt
643c0c1cc7 null/empty check -> check both 2020-01-18 17:33:19 -08:00
Kurt
843330a375 Remove unnecessary null checks 
this is a null free project /s
dont provide null, else u deserve to get an exception
 2020-01-18 16:57:25 -08:00
Kurt
8312c52cc1 Make Move[] readonly list 
contract: don't modify the template movesets
mystery gift now exposes IRelearn, remove unnecessary type checks
 2020-01-18 16:46:38 -08:00
Kurt
0cd9c47953 Make Relearn array for encounters readonly 
No change em
 2020-01-18 16:31:24 -08:00
Kurt
40c2c483fb Common1-3 => Bool1-3 
Blocks that use Bool1/2 toggle to the other state; evident when comparing between two different saves. The key doesn't change, only the Type is toggled.
 2020-01-18 14:19:01 -08:00
Kurt
9b0b0cb1a6 Add misc value r/w for trainer8 
Closes #2639
casting object to generic T : struct isn't valid, so just cast the get/set appropriately
 2020-01-17 23:25:02 -08:00
Kurt
2a7d475b5b Rearrange key list, add syntax sugar methods 2020-01-17 21:53:51 -08:00
Kurt
e4e1681e1c Clamp roto rally score to 99_999 
https://github.com/kwsch/PKHeX/issues/2639#issuecomment-575863541
 2020-01-17 21:09:54 -08:00
Kurt
e3cafe5cd6 Relocate getsize to extension method 
use sizeof for clarity, add test to ensure bool size is 1 byte (which is always true)
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/operators/sizeof
 2020-01-17 21:09:26 -08:00
Kurt
a590d3713b Refine enum with TypeCode names 
Add GetValue/SetValue/GetType extension methods
 2020-01-17 18:59:45 -08:00
Kurt
ff466826af Flip hgss trade flag state meaning 
Closes #2640
 2020-01-17 16:39:19 -08:00
Kurt
bd9ec72d98 Misc tweaks 
Add more direct legality analysis constructors
evo count is >= 1
fix invalid test message
disallow gen2 moves if transferred from gen1
use ^1 instead of len-1 for netcore test project
 2020-01-16 23:22:54 -08:00
Kurt
c739af4767 Extract item restrictions to separate class 
Move similar classes to folder
 2020-01-16 19:27:29 -08:00
Kurt
baf46f9a3a cache form/species/format on first get 
very minor perf consideration, since those values are immutable (except for cross thread shenanigans)
 2020-01-16 19:23:29 -08:00
Kurt
e97970023a Add swsh battle-only forms 2020-01-16 19:03:47 -08:00
Kurt
8315f740cb Merge branch 'master' of https://github.com/kwsch/PKHeX 2020-01-16 18:54:11 -08:00
Kurt
857124acf0 Swap zen galar -> galar zen 
ty showdown for changing your convention over a month ago
a01e2a26bc (diff-58e367765263b7e21df251b3e7619b70L9307)
 2020-01-16 18:54:09 -08:00
Egzon Qukovci Jusufi
deece433a5 Add SWSH Legends to the Tables (#2637) 2020-01-15 20:49:19 -08:00
Archit Date
22ed59d6a3 sanity check necrozma forms (#2638) 
smogon allows Dusk Mane as well as Dusk-Mane as their form argument
 2020-01-15 20:48:53 -08:00
Kurt
41f909c08a Add Roto Rally score, copy Jersey # to other block 
Closes #2635
 2020-01-15 20:48:19 -08:00
Kurt
aecc08f65c Remove duplicate electrode encounter 
3IV requirement isn't required for wild slots that are also at the same level-location
Closes #2636

ty @dstevenson12 !
 2020-01-14 18:39:25 -08:00
Kurt
f4162d2dce Add another corviknight location 
ty anubis
Closes #2633
 2020-01-13 22:36:00 -08:00
Kurt
726947eaf5 Add HGSS starter const/flags 
Closes #2634 ty @asterysx !
 2020-01-13 20:40:44 -08:00
Kurt
a6aabcdc96 Split out a method before crypto step 
Allows for capturing the obtaining the raw decrypted data via the PKHeX.Core api
 2020-01-13 19:03:27 -08:00
Kurt
2e16fb058c Show form arguments in gen6/7 
Clamp form argument load to current list bounds (used to throw arg range exception if invalid)
 2020-01-13 17:09:03 -08:00
Kurt
11978dab4f Make pgt ranger manaphy IsEgg true 2020-01-12 23:00:32 -08:00
Kurt
81f280f4d1 Update EncounterSuggestion.cs 
weaken legality check, we only check moves
 2020-01-12 20:49:33 -08:00
Kurt
5a20dc707d Rewrite encounter suggestions 
Don't clone legality templates, and keep suggested information minimal -- this isn't automod
 2020-01-12 19:40:36 -08:00
Kurt
eaeebea923 Remove another method shortcut 
EncounterSuggestion needs a facelift anyway
 2020-01-12 17:00:03 -08:00
Kurt
3b5c7062ac Minor perf improvement 
pass in, don't constantly fetch
helps generated IL code be slightly more efficient
 2020-01-12 16:49:12 -08:00
Kurt
a8c28369b6 Add Yamask-1 max hp calc for formArg compare 
Closes #2632 ty @CanoeHope
 2020-01-12 16:22:56 -08:00
Kurt
d5948b9dbe Add relearn moves to Except comparison 
Burn Up ho-oh is dumb
 2020-01-12 16:09:35 -08:00
Kurt
48fd36a9a2 Handle g4 shedinja learn case too 
change 291/292 to Shedinja/Ninjask for easy enum reference check
 2020-01-12 14:34:29 -08:00
Kurt
61ecb52347 Remove unnecessary allocation 2020-01-12 12:06:33 -08:00
Kurt
a305c00ac4 Reorder feebas evo for swsh, patch data 
Updated comment in #2394 with byte swap info
Forgot to check tests when importing patched data :)
 2020-01-12 11:48:42 -08:00
Kurt
82eaf39d45 Remove method alias for init mysterygift db 2020-01-12 11:41:23 -08:00
Kurt
9ed441885a Remove manual personal info fix 
Change FDDC from 47 -> 41
SM is 40, as the tutor isn't possible in that game.
 2020-01-12 11:39:43 -08:00
Kurt
f6fb54aecc Move shedinja/egg evo chain short circuit 
Some routes use the evolutiontree directly instead of this method (with the same name); should probably consolidate but meh

This causes Shedinja to yield the correct evolution chain when called directly (because nothing naturally evolves to shedinja; it's created out of thin air as a clone)

Take the egg short circuit with it to keep things simple
 2020-01-11 21:43:58 -08:00
Kurt
0eca1bbd1c g3 shedinja api usage fix 
see comments in src for justification
need ninjask moves if gen3; dl.Count is guaranteed to be >= 1
 2020-01-11 21:41:24 -08:00
Kurt
7cbf8d0fcf Set gen3 count ribbons appropriately 
ty anubis
 2020-01-11 15:51:25 -08:00
Kurt
7e6edbaded Remove unnecessary constructor 
Make key readonly
 2020-01-11 14:18:11 -08:00
Kurt
95f24a9d36 Revise suggested AV set logic 
Closes #2630
 2020-01-11 11:43:53 -08:00
Kurt
62c35194c3 Remove unnecessary form duration code 
probably misinterpreted the furfrou/hoopa stuff; probably is "SetMaxFormDuration"
d3f6d5935f (commitcomment-36754955)

ty @CanoeHope
 2020-01-10 22:16:30 -08:00
Kurt
d3f6d5935f Add form argument legality checks 
Closes #2611 (Alcremie)
Closes #2604 (Runerigus)
 2020-01-10 16:33:40 -08:00
Kurt
507868ce58 Merge branch 'master' of https://github.com/kwsch/PKHeX 2020-01-10 16:08:51 -08:00
Kurt
fdd321dd8c Make memory 6 fishy if textvar present 
Closes #2621
 2020-01-10 16:08:34 -08:00
Egzon Qukovci Jusufi
fe13b3374d Spanish Translations (#2625) 
* Update LegalityCheckStrings_es.txt

* Update lang_es.txt
 2020-01-10 16:03:28 -08:00
Kurt
be92d4436e Rearrange argument check order 
USUM evo table has Meowstic with Arg=-1, which early aborted.
Closes #2627
 2020-01-10 16:02:22 -08:00
Kurt
f291da8f32 Add 2 bw flags 
Closes #2628
 2020-01-10 15:53:26 -08:00
Kurt
718d00f970 Ban ha slowpoke-1 2020-01-09 23:50:15 -08:00
Kurt
cf06335a22 Update 20.01.10 
Update with latest events from EventsGallery
 2020-01-09 21:13:07 -08:00
Kurt
2915692daa Use more performant block lookup strategy 
Rather than storing a dictionary of keys, we can abuse the fact that the SCBlock[] is stored in order of ascending block key.
Binary Search doesn't require extra memory like a Dictionary would; also, we only need to find a few blocks.
 2020-01-09 19:00:49 -08:00
Kurt
51d2fc9d93 Update with slowpoke-1/new raid data 
TransferVerifier: Revise transfer check to allow slowpoke-1 (slowpoke-0 is flagged via next check)
 2020-01-09 18:44:45 -08:00
Kurt
3fa44361e6 Update block fetch & blank init 
blanks: {key,size}
fetch: get block by key (index isnt the same between patches, as blocks with different keys get added). The savefile stores them as a SortedDictionary (by key), hence the shifting.
 2020-01-09 08:59:26 -08:00
Kurt
bbd1aff5fe Add new lengths 
new format still crashes as block absolute index is now different
should do a different way of loading blocks (key instead of index)
 2020-01-09 08:17:41 -08:00
Kurt
0dd4d1fe7a Remove unnecessary casts 2020-01-06 17:50:18 -08:00
Kurt
efbac28b91 Rework accessors for PKMConverter trainer cache 
Might break downstream users, for the better. Internal behavior had to change!
 2020-01-05 21:51:02 -08:00
Kurt
1906a1040f Relocate console-location data setting to PKMConverter 
When adding data, check if the current Trainer has valid console data; if not, use a default value.
 2020-01-05 21:41:32 -08:00
Kurt
3d581283c2 Minor clean 
move Text.cs manual Courier new() to the designer, have it dispose when form is disposed. Set it as the numericupdown's font and just reuse that :)
 2020-01-05 18:46:30 -08:00
Kurt
7caeebd772 Add formcount for scatterbug/spewpa 
USUM had 20 for both, but XY/AO/SM had only 1 (vivillon had 20); make
them consistent so that our generated evolution paths behave correctly

Add meowstic specific evolution form modifier... so silly
simpler to have it inlined with the sSpecies, for jit optimization

could probably do this with silvally but meh, things work fine now

Closes #2603
 2020-01-04 22:31:46 -08:00
Kurt
e21d108fb2 Split PokeCrypto from PKX 
All logic in PokeCrypto is separate from the rest of the PKHeX.Core
library; makes it easy to just rip this portion out and reuse in other
projects without needing the entirety of PKHeX.Core logic

optimize out the CheckEncrypted to the actual path, separate methods.
Only usages of this method were with hardcoded Format values, so no
impact
 2020-01-04 14:48:39 -08:00
Kurt
68e6644d40 Split off shared nest class, deduplicate logic 
use generics to have shared logic in one spot
Handle downleveled distribution/crystal(soon?) data
 2020-01-04 11:44:16 -08:00
Kurt
308e6fa291 Add temp workaround for version encounter fetch 
PKX.Generation is 8, which returns SWSH evo tree; evo tree doesn't have
non-galar-native species data, so stuff like Ambipom don't get reversed
properly.

use math.max for tree fetch when appropriate:
- egg generator: pre-evolutions like pichu should be allowed if pk1
- don't fetch format twice, just do math.max
 2020-01-04 11:14:25 -08:00
Kurt
ecabbfff53 Add individual Move#_PP $suggest 
#2603
add in "secret" heal/healPP actions -- do ".Heal=$suggest" to refresh
all stats like it was healed at the pokecenter. I can't think of a good
way to handle invoking of methods (">", but what about parameters?)
 2020-01-03 20:21:02 -08:00
Kurt
15779513f5 Add stubs for raid correlation verifiers/generators 
Not going to implement this within the base repo as z3 is too large of a
dependency and is platform specific.

If anyone wants to implement as a plugin project, just inject your new
methods via the setters on the static func/action at the top of the 3
classes.

Since z3's searches aren't instant, I'd recommend caching recent results
in a dictionary, as re-parses are common. Something like the Wordfilter
is what you'd be aiming for :)

Closes #2617
 2020-01-03 20:03:04 -08:00
Kurt
a08ebff699 Add gen8 mimikyu form case 
Closes #2618
 2020-01-03 19:20:16 -08:00
Kurt
0788780404 Add bewear motostoke crossover location 
Closes #2619
 2020-01-03 19:14:03 -08:00
Kurt
852bd2af20 Relocate gui-only text files to WinForms project 
Split up the DataUtil method to load text files so that the caching
functionality can be reused
 2020-01-03 15:53:48 -08:00
Kurt
10b2120b93 Update translations with latest translatable fields 2020-01-03 15:29:31 -08:00
Kurt
350895aba6 Use permissive string search, add indeedee-M case 
Manually modified showdown sets can contain errors (capitalization,
etc). Use the string search api to permit weaker matches, since there's
not going to be any exact-matches-with-different-caps/spaces.
 2020-01-02 15:49:35 -08:00
Kurt
fe8e5e3fd9 Add more string search methods 
exposes some common string search operations that can be useful for
parsing user entered data
 2020-01-02 12:06:58 -08:00
Kurt
35c7195d77 Add custom int/uint parse tests 
Correctly handle negative parsing for int by flipping sign at end
optimize out a compare char digit/hex check
 2020-01-02 11:11:31 -08:00
Kurt
b55dc37e05 Extend some logic 
make summary more accessible
 2020-01-02 10:55:37 -08:00
Kurt
166f8d82e5 Misc clean 
Refactor out some logic, make "en" literals reference one spot (where
appropriate)
 2020-01-01 19:07:21 -08:00
Kurt
7e490b8dcc Add lanturn/bronzong alt locations 
Closes #2613
 2019-12-31 21:47:28 -08:00
Kurt
0002f1d1ad Grab CXD location if encounter is COLO or XD 2019-12-31 12:15:48 -08:00
Kurt
14eae5f62d Add magikarp distribution data 2019-12-30 22:32:12 -08:00
Kurt
3b2b86950f Ignore symbols (apostrophe) for string matching 
Farfetch'd vs Farfetch’d
 2019-12-30 15:39:13 -08:00
Kurt
84c5f6e914 Add another met location for gastro-1 
Closes #2612
 2019-12-30 15:11:54 -08:00
Kurt
9864f23427 Handle Bridge Field->Stony Wilderness berry tree 
Closes #2610
 2019-12-29 12:48:34 -08:00
Kurt
d6471e2b3b Add more pelipper & dusclops strong locs 
ty anubis
 2019-12-29 11:28:29 -08:00
Kurt
ce62d63c5a Fix eggmove fetch for move check 
Closes #2609
 2019-12-29 10:17:07 -08:00
Kurt
f4bafe0809 Add extension methods for gym team get/set for all 
Closes #2607

SAV6XY/AO had GymTeams get/set, this now makes similar logic accessible
for even SAV5BW/B2W2.
 2019-12-28 22:32:45 -08:00
Kurt
be50abcc44 Add SubEventLog block object, etc 
Adds gym team records, remove from savefile properties
update block list documentation
 2019-12-28 21:53:58 -08:00
Kurt
0ce6254cee Add GymTeam records for Gen5 saves 2019-12-28 21:51:10 -08:00
Kurt
bfd9bf6b53 Simplify formchange calls 
Don't use the dex chain for certain checks, it's unnecessary.
 2019-12-28 19:00:01 -08:00
Kurt
8493471793 Add alcremie form change case 2019-12-28 18:59:00 -08:00
Kurt
3280adcb9f Add another location for Golurk & Galvantula 
Closes #2606
 2019-12-28 18:03:20 -08:00
Matt
6f1611f360 Add Gen 4-6 Starter Event Constants (#2608) 2019-12-28 17:39:46 -08:00
Kurt
b294eba181 Fix combee gender check 
silly convoluted checks
#2603
 2019-12-27 19:17:08 -08:00
Kurt
f65e0a96a7 repoint sav4 event constant reads 
should work fine now
 2019-12-27 18:30:39 -08:00
Kurt
940cdccb6b Restrict downleveled to lvl % 5 == 0 2019-12-27 00:17:59 -08:00
Kurt
c7e396ef14 Update 19.12.26 
Update with latest event data from the Events Gallery
 2019-12-26 19:07:04 -08:00
Kurt
ceae77c677 Add load-line overlap location for Den 27/42 
The nest is situated right next to the load line, and may be accessed
from either map (across the load line), resulting in a Dusty Bowl
Pumpkaboo-0.

Many thanks to Anubis on Discord for figuring this (very silly) thing
out !
 2019-12-26 18:59:02 -08:00
Kurt
b255937e86 Revise input parameter names 
pk instead of pkm (consistency)
Lowercase anything that started with uppercase (not static state)
 2019-12-26 18:47:31 -08:00
Kurt
d736f24bb7 Heal PP on transfer 
force everything to their current pp count
 2019-12-26 15:28:04 -08:00
Kurt
5cb3556eee Add Move PP verification 
Eggs already had it, adding now for regular pkm
Closes #2602
 2019-12-26 14:28:01 -08:00
Kurt
9ee2b08ce5 Update rare flag logic 
Closes #2601

Add ComponentModel attributes for properties, add u64 typeconverter for
propertygrid
 2019-12-26 13:39:07 -08:00
Kurt
6c7065fb7b Fix bool compare 
oops
https://github.com/kwsch/PKHeX/issues/2600#issuecomment-569134146
ty @slp32 !
 2019-12-26 13:12:10 -08:00
Kurt
bb7c94dadb Add seismitoad location 
https://github.com/kwsch/PKHeX/issues/2570#issuecomment-568235086
 2019-12-26 13:04:44 -08:00
Kurt
baf0f52f06 Handle downleveled raids 
Closes #2573
- self-hosted raids can be downleveled too (see cufant), probably only
by 1 rank
- min-rank check now checks for downleveled cases

- Add extra gyarados/ferrothorn locations
 2019-12-26 12:59:16 -08:00
Kurt
4740fab5ec Have separate encounter yielder for gen8 
the "Strong" static encounters can be near-matches with wild encounter
slots; example is a evolved Cutiefly->Ribombee with Quiver Dance.

Remove unnecessary IsLink/FriendSafari check for this gen8 method

https://github.com/kwsch/PKHeX/issues/2573#issuecomment-569126371
 2019-12-26 12:32:48 -08:00
Kurt
420307d4bf Make non-exportable saves (fake) act as VC saves 
https://github.com/kwsch/PKHeX/issues/2600#issuecomment-569125853
 2019-12-26 12:21:35 -08:00
Kurt
06348096aa Fix block de-referencing issue 
SCBlock is an input to the individual save blocks; changing the SCBlock
byte[] reference won't change the individual save block reference. Just
copy the data and keep the original reference instead.

Repro: trainer data editor, save-close window, then delete a slot.
Export save; reload. Changes to box data were using old byte[]
reference, and didn't get repointed. Works fine with latest commit now.

I think I wanted to avoid copyto since it's slower than just a reference
change; but that didn't work out perfectly :)
 2019-12-25 23:24:40 -08:00
Kurt
0a8c791e10 Pad with null terminators rather than 0 
Can have a single digit (not forced to 3), so null terminate I assume.
 2019-12-25 21:31:49 -08:00
Kurt
0c7d347a29 Add Delibird distribution data, split files 
ROM nest data definitions are already pretty hefty and won't be revised;
split out the future content
 2019-12-25 14:26:49 -08:00
Kurt
827a7649c1 Export PCD/PGT as encrypted format 
add Write method for writing the data outside the program; only use Data
if you know what you're doing!
 2019-12-24 23:24:28 -08:00
Kurt
9d1bfd67b5 Add braces 
style fix, no functional change
 2019-12-24 23:23:42 -08:00
Kurt
e6dcf64abe Disallow Spiky Ear Pichu eggs 
sneaky gen4 bad hacks are bad
 2019-12-24 13:21:56 -08:00
Kurt
97c3c6b610 Add raid/den detail browser 
Hold alt when hitting activate all to dump instead
I've seen DenType=5 Event=2 for at least one raid so far... not sure if
the event/rare properties are accurate.
 2019-12-23 23:30:21 -08:00
Kurt
bc3e84d30e Check high bound of language when generating wb7/8 
Closes #2599 ty @slp32
 2019-12-23 11:27:36 -08:00
Kurt
3b1cab0ab5 Update translation resources 
things are pretty stabilized, so it seems like a good time to allow
translations
 2019-12-22 13:53:16 -08:00
Kurt
ea5ca7b2d2 Add Ingredients to swsh held item list 
Closes #2597
 2019-12-22 12:16:06 -08:00
Kurt
3b2ebbb84f Add PID check for gen4/5 Combee->Vespiquen evo 
Closes #2593
 2019-12-21 16:52:56 -08:00
Kurt
7edfe4543f Flag eggs with HT string 
Closes #2586
Modify PKM Info already clears it, but if disabled, will be flagged.
 2019-12-21 16:01:51 -08:00
Kurt
ce463d057a Add Pikachu Beach Score editing for YW saves 
Closes #2585
 2019-12-21 15:17:05 -08:00
Kurt
8309060298 Add more egg verification for statnature/techrecord 2019-12-21 14:51:52 -08:00
Kurt
7889a0abe6 Simplify form egg move handling 
Closes #2588
 2019-12-21 13:37:20 -08:00
Kurt
d7bc68d7a5 Add HT case for capture memory check 
#2570
https://github.com/kwsch/PKHeX/issues/2570#issuecomment-568149050
 2019-12-20 19:47:40 -08:00
NotTsunami
a05b38ab39 Legality: Add Nature and Gender to Gen 8 Trades (#2591) 
Closes #2589 
https://bulbapedia.bulbagarden.net/wiki/In-game_trade#Sword_and_Shield
 2019-12-20 10:48:46 -08:00
Kurt
4bf71de621 Minor clean 
automatically update total_watt if insufficient
SAV8 is not SAV8SWSH
#2583
 2019-12-12 22:58:18 -08:00
Atzgi
d9c59666e0 Add watt in trainer data editor (#2583) 2019-12-12 16:27:01 -08:00
Kurt
506e64186a Rearrange & re-do "CanHaveMemory" value check 
Closes #2581
 2019-12-11 19:37:57 -08:00
iiippppk
dfa951d76c Update Gen8 Traditional Chinese Species (#2579) 2019-12-11 06:09:41 -08:00
iiippppk
35c0a4d931 Fix Chinese text error (#2578) 2019-12-11 06:09:12 -08:00
Kurt
802b93bb16 Fix xor order 
oops, upper half gets the star/square xor
no real difference since PID is random
 2019-12-10 22:05:47 -08:00
Kurt
108233b45f Add glalie/skuntank locations 
#2570
 2019-12-10 19:54:26 -08:00
Kurt
fcdd7019d3 Add missing shadow yanma location ID 
Closes #2577 thanks @HoppyShnell ! -- this looks like the final met
location ID?!

Not sure if Murkrow (locked) is missing one; moved duplicate-location
Heracross and made it use the same locks.
 2019-12-10 19:22:46 -08:00
Kurt
e9d127f225 Copy console data, copy OT memories 
still hypothetical; we know that memories exist and console data still
has accessors
HT memories should be replaced, so no need to transfer 'em.
 2019-12-10 19:13:32 -08:00
Kurt
9a87647409 Add more static encounter locations 
Some of these are probably crossovers
#2570
 2019-12-09 19:28:57 -08:00
Kurt
c85c8ded5c Fix crossover location compare, add formchange 
Rotom can change forms, first time it's available in the wild. Fun.
Fix crossover location comparison (was always returning false).
 2019-12-09 19:28:28 -08:00
Kurt
281c1ae744 Skip SWSH untraded link trade eggs if trade-memory 
just read the comments & code, this one is an annoying oversight
untraded pkm /should/ never have HT memory data, but sometimes it do be
like that

Closes #2571
 2019-12-09 16:23:29 -08:00
Kurt
aa2241ba66 Fix unchangeable OT friendship to compare correctly 
Closes #2572 ty @sora10pls for confirming that evo chains are necessary
for VC transfer
 2019-12-09 15:50:03 -08:00
Kurt
0fa25b4c8c Fix VC transfer evo chain population 
Move EncounterOriginal to Legal info; needed in order to pass the
correct encounter to the EvoChain fetch.

The EncounterOriginal 'hack' might be unnecessary with the current state
of the legality checker... maybe can see if it can be removed later.
 2019-12-09 15:48:54 -08:00
Matt
5395cf6bab Update UnreleasedHeldItems_8 (#2575) 2019-12-09 12:35:50 -08:00
Kurt
8e1fe5e305 Don't apply template fake console data if invalid 
pkmeditor only for blank data load
 2019-12-08 20:09:45 -08:00
Kurt
5e1fd36b96 Account for memory feeling off-by-one bug 
If the feeling is zero the game's string formatter will treat it as
null, and will newline before the period.

Gen6 (if I recall correctly) had "it was happy" as index 0
Gen8 (new) has "it was happy" as index 1, with 0 being invalid-bad.

Slice the array differently for gen8 to include the empty line as index
0.

Closes #2549 , ty @crzyc && @architdate for testing index 0 :)
 2019-12-08 18:56:37 -08:00
Kurt
f54bc7bf6f Batch editor updates 
.PID=$shiny0 will do squares
anything else will do stars

.RelearnMoves=$suggestAll will give ALL TR moves, not just the ones for
its current movepool.
.Ribbons=$suggest will give all valid ribbons
.Ribbons=$suggestNone will remove all ribbons (except required ones like
event ribbons)
Closes #2568
 2019-12-08 17:52:17 -08:00
Kurt
8acb336d51 Use enum for species comparisons 
slightly easier to read with named values
 2019-12-08 17:39:19 -08:00
Kurt
475dc02101 Add edge case handling for indeedee shared egg moves 
#2416
 2019-12-08 12:08:21 -08:00
Kurt
5ddd59c9aa Fix runerigus/yamask partial load fail 
320 is max hp (31IV 252EV), is this just -60 from max HP (threshold to
evolve at?)
might need some more research to see what is going on with this

only trycatch in release builds; was confused until I stepped thru and
saw the crash
 2019-12-08 00:03:08 -08:00
Kurt
c6ef2a845d Fix ribbon compare 
oops
 2019-12-07 23:39:32 -08:00
Kurt
4611146807 Update memory verifier 
Adds handling for SW/SH quirks
Closes #2545
 2019-12-07 23:36:39 -08:00
Kurt
19b1564eb2 Split history and memory verifiers 
Rewrite a bunch of the history verification stuff
Fix a few test cases with incorrect OT Friendship (transferred), and
missing GeoCountry

Need to rewrite memory verification next
(All test cases currently pass)
#2545
 2019-12-07 18:12:31 -08:00
Kurt
34452c2818 Add gen8 ribbon verification 2019-12-07 11:58:56 -08:00
Kurt
aa3d63e982 Add Mr. Rime to splitbreed table 
Closes #2567
 2019-12-07 00:04:46 -08:00
Kurt
861d7b6014 Remove unnecessary parameters for species fetch 
#2567
 2019-12-07 00:00:49 -08:00
Kurt
2b1aee7c38 Gen8: Update rules for having BestFriends ribbon 
Closes #2562
ty @iiippppk
 2019-12-06 20:22:23 -08:00
Kurt
d08e3a3f81 Fix form change evolution linking 
GetDestinationForm for gen7+ is fine
gen7 and gen8 use the "form" argument as the destination form; -1 means
don't change
espurr-F just gets forced to 1 in gen7 since it's -1

Closes #2564 ty @iiippppk
 2019-12-06 19:31:18 -08:00
Kurt
d24a09f7c9 Make level min/max virtual for nest 
Closes #2566
be sure to set the correct flawless IV count & dynamax level so that the
encounter matches
 2019-12-06 19:17:26 -08:00
Kurt
862a446eb3 Fix form sanitization for de-evolution 
Better to handle things this way, we know for sure the form it HAS to
originate as.
Closes #2565
ty @iiippppk !
 2019-12-06 19:00:41 -08:00
Kurt
be38a60267 Fix handling for get evolutions method 
only used for Zukan7b, but add in handling so that it works for <=gen6
games, and supports form alterations too!

update style to match GetPreEvolutions

could probably update this to yield tuples (species, form) but LGPE/SWSH
only needs species. If there's the need for tuples later, should be ez
tweak.
 2019-12-06 18:16:11 -08:00
Kurt
314d8f6b58 Update form destination handling 
espurr-F evolves to form-1 from form0, even tho the form arg is -1 (gen7
consideration)
gen8 has 0/1 for the two evolutions, dictating the destination form
 2019-12-06 17:36:36 -08:00
Kurt
f7620908df dummy out empty evo species 2019-12-06 17:21:38 -08:00
Kurt
7b6d2bfa48 Fix trainerID trainer card write 2019-12-06 16:59:54 -08:00
Kurt
f07aed904d add missing pokedex offset spoof for gen3 saves 
https://projectpokemon.org/home/forums/topic/55704-drag-drop-to-boxes-not-working-in-blank-gen-3-save/
ty ICanSnake
 2019-12-05 23:08:01 -08:00
Kurt
eac3804c7b Clean up dexlevel/evocriteria constructor usage 
DexLevel was the initial abstraction, which was expanded/reused for
evolution details

I should probably merge the two classes since everything is passed as
EvoCriteria
The encounter generators do some silly form fuzzy match which can now be
more accurately checked since I've moved Form to DexLevel... maybe a
future commit can clean that up.

encounterarea2 was reusing this class, just use a throwaway readonly
struct as our temp value storage
 2019-12-05 23:04:24 -08:00
Kurt
b49c5a5a8a Rewrite evolution lineage generating 
- Use tail recursion and a lookup table (species | form) for reversing
- generate the reversal lookup by extrapolating all species-form
destination values (EvolutionLink)
All tests pass, and no special handling for forms is required. Kinda
suspicious that it works this simply...

Redo evolution banning (no wormhole for non-Alolan evolutions in SM), in
a style that we can ban the Gigantamax event evolutions
(pika/meowth/eevee). Their evolutions can't be resulted from a pre-evo,
because the in-game routine early aborts if the gigantamax flag is set
for those species.

Update gen4 personal tables (formCount was 0, needs to be a minimum of 1
by default)

Closes #2537
 2019-12-05 22:32:47 -08:00
Kurt
786d9c8f18 Handle shedinja encounter balls 
nincada -> spawn shedinja = pokeball (wild encounter rules if gen3)
shedinja encounter = wild encounter rules
 2019-12-05 16:40:14 -08:00
Kurt
b2fc99e50a Update nest dist/crystal location get/check 2019-12-04 19:04:36 -08:00
Kurt
65b921f806
Only apply 3DS geoloc data for 3DS blank saves 
Closes #2560

Different logic in SimpleTrainerInfo applies it to <=Gen5, but that's fine... 414cb2d39e/PKHeX.Core/Legality/Structures/SimpleTrainerInfo.cs
 2019-12-04 14:00:53 -08:00
Kurt
414cb2d39e don't apply rib-markings on all 
legality concerns
 2019-12-03 23:41:24 -08:00
Kurt
d70a234552 Add $suggest for PKM.Ball 
sets a legal ball, with preference for color matching
 2019-12-03 20:14:36 -08:00
Kurt
e333f9b441 Add orbeetle 65 loc 
thanks @sora10pls
 2019-12-03 19:59:10 -08:00
Kurt
f45d730faf Add TrainerID for trainer card 
Closes #2556
 2019-12-03 19:54:34 -08:00
Kurt
71318c9bd5 Add clarification/notes 2019-12-03 19:54:06 -08:00
Kurt
ab7cf3252e Add snorlax raid dist data 2019-12-03 18:25:06 -08:00
Kurt
a0f2aded02 Use more optimized index find 2019-12-03 18:24:28 -08:00
Archit Date
3526c37f1e update forme to showdown strings (#2558) 
* update forme to showdown strings

Galarian is represented as Galar on PS!
Polteageist has no form atall
galarian now called Galar by default to match with Alola as a forme. changed darmanitan forme-strings in form converter. Added sinistea to the forme ignore list when converting to showdown
 2019-12-03 16:41:52 -08:00
Kurt
e9b9141eda
Fix property name typo 
efec331741 (r36246093)

ty @AnalogMan151
 2019-12-03 10:39:57 -08:00
Kurt
d3f7e7bf07 Minor simplifications 
format >= 6 is always true (early return in entry)
don't double-flag/check memory presence in OTs from gen5 and below (hist
and OT verifier)

rename method; I'll probably rework the flow of things for gen6
verification and gen8 verification since the rules are slightly
different
 2019-12-02 16:36:53 -08:00
Frank
efec331741 add some customization options in MyStatus8 (#2552) 2019-12-02 13:40:09 -08:00
Kurt
a844fb5249 Add strong dubwool location 
https://projectpokemon.org/home/forums/topic/55654-new-pokemon-to-fix-on-pkhex/?tab=comments#comment-251010
 2019-12-01 00:02:02 -08:00
Kurt
594c44f6c0 Set Gender for template 
Closes #2548
 2019-11-30 23:44:47 -08:00
Matt
7b7a161ac9 Minor fixes (#2547) 
Fix Sinistea/Polteageist Form names (as per Strategy Guide)
Add Eternamax menu sprite
 2019-11-30 13:19:22 -08:00
Kurt
f3ecff272c Update HA8 banlist 
Closes #2544
Closes #2543
 2019-11-29 22:33:11 -08:00
Kurt
2ee6fbb7e9 Only flag bred stuff for no-breed 
Closes #2542
 2019-11-29 18:54:07 -08:00