Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-09-21 06:41:56 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/PKM/PKM.cs

1139 lines
44 KiB
C#
Raw Normal View History

Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
using System;
Misc tweaks replace linq for Encrypt/Decrypt pkmdata fetch with faster length check & optional resize (Span pls!?) update pk6 comment for why affection is not cleared
2019-02-24 00:05:01 +00:00
using System.Collections.Generic;
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
using System.Linq;
Split winforms to separate project resources still are associated with winforms, eh program still runs fine and I've replicated the mono build options. lmk if this breaks stuff
2017-01-08 07:54:09 +00:00
namespace PKHeX.Core
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
{
add more pkhex.core xml documentation adds a bunch of documentation useful for those unfamiliar with the core library
2017-10-24 06:12:58 +00:00
/// <summary>
/// Object representing a <see cref="PKM"/>'s data and derived properties.
/// </summary>
Rework mg nick/lang checks add common interface https://projectpokemon.org/home/forums/topic/47295-bug-event-golduck-name-not-matching-species/
2018-08-31 01:09:52 +00:00
public abstract class PKM : ITrainerID, ILangNick, IGameValueLimit
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public static readonly string[] Extensions = PKX.GetPKMExtensions();
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
public abstract int SIZE_PARTY { get; }
public abstract int SIZE_STORED { get; }
Fix folder location fetch & x/c/bk# extension fetch Closes #1149
2017-05-18 03:39:06 +00:00
public string Extension => GetType().Name.ToLower();
Add personalinfo references per PKM format Fix possible hang in pk6/pk7 if country/region is unset (continues loop). PersonalInfo references are not to be used when calculating stats (use the savefile table instead)
2016-10-24 05:01:39 +00:00
public abstract PersonalInfo PersonalInfo { get; }
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
public abstract IReadOnlyList<byte> ExtraBytes { get; }
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
// Internal Attributes set on creation
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
public abstract byte[] Data { get; } // Raw Storage
public string? Identifier; // User or Form Custom Attribute
Add Batch Editor => Shiny PID command Also added Box/Slot filtering, for whatever reason is desired. Thanks /u/exegg for the suggestion!
2016-07-29 06:05:26 +00:00
public int Box { get; set; } = -1; // Batch Editor
public int Slot { get; set; } = -1; // Batch Editor
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
Misc tweaks replace linq for Encrypt/Decrypt pkmdata fetch with faster length check & optional resize (Span pls!?) update pk6 comment for why affection is not cleared
2019-02-24 00:05:01 +00:00
public virtual byte[] EncryptedPartyData => Truncate(Encrypt(), SIZE_PARTY);
public virtual byte[] EncryptedBoxData => Truncate(Encrypt(), SIZE_STORED);
public virtual byte[] DecryptedPartyData => Truncate(Write(), SIZE_PARTY);
public virtual byte[] DecryptedBoxData => Truncate(Write(), SIZE_STORED);
private static byte[] Truncate(byte[] data, int newSize)
{
if (data.Length != newSize)
Array.Resize(ref data, newSize);
return data;
}
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public virtual bool Valid { get => ChecksumValid && Sanity == 0; set { if (!value) return; Sanity = 0; RefreshChecksum(); } }
Add C/XD transferring reflection is neat when making c/xd format, recalculate stats
2016-10-02 17:18:31 +00:00
String editing refactor Move all sanitization operations from PK* and SAV* to PKX; add general method for fetching a generation specific string Changes the Text subform editor to show trash bytes when appropriate. Special characters to be shown can be easily inserted in the future.
2017-04-09 21:06:50 +00:00
// Trash Bytes
public abstract byte[] Nickname_Trash { get; set; }
public abstract byte[] OT_Trash { get; set; }
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
public virtual byte[] HT_Trash { get; set; } = Array.Empty<byte>();
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Misc clean split some methods with optional parameters=null add more xmldoc replace some magic numbers -> enum/const references consolidate common array operations (span soon maybe?)
2019-09-10 07:21:51 +00:00
protected byte[] GetData(int Offset, int Length) => Data.Slice(Offset, Length);
String editing refactor Move all sanitization operations from PK* and SAV* to PKX; add general method for fetching a generation specific string Changes the Text subform editor to show trash bytes when appropriate. Special characters to be shown can be easily inserted in the future.
2017-04-09 21:06:50 +00:00
PBR support (#290) * Initial (still buggy) PBR commit * Basic save slot support
2016-09-26 23:14:11 +00:00
protected virtual ushort CalculateChecksum()
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
{
ushort chk = 0;
Sync basic gen3 support Still many things not yet working (item/inventory editing needs new string resources)
2016-06-26 21:23:41 +00:00
switch (Format)
{
case 3:
for (int i = 32; i < SIZE_STORED; i += 2)
chk += BitConverter.ToUInt16(Data, i);
return chk;
default: // 4+
for (int i = 8; i < SIZE_STORED; i += 2)
chk += BitConverter.ToUInt16(Data, i);
return chk;
}
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
protected abstract byte[] Encrypt();
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
public abstract int Format { get; }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private byte[] Write()
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
{
RefreshChecksum();
return Data;
}
// Surface Properties
public abstract int Species { get; set; }
public abstract string Nickname { get; set; }
public abstract int HeldItem { get; set; }
public abstract int Gender { get; set; }
public abstract int Nature { get; set; }
public abstract int Ability { get; set; }
public abstract int CurrentFriendship { get; set; }
public abstract int AltForm { get; set; }
public abstract bool IsEgg { get; set; }
public abstract bool IsNicknamed { get; set; }
public abstract uint EXP { get; set; }
public abstract int TID { get; set; }
public abstract string OT_Name { get; set; }
public abstract int OT_Gender { get; set; }
public abstract int Ball { get; set; }
public abstract int Met_Level { get; set; }
// Battle
public abstract int Move1 { get; set; }
public abstract int Move2 { get; set; }
public abstract int Move3 { get; set; }
public abstract int Move4 { get; set; }
public abstract int Move1_PP { get; set; }
public abstract int Move2_PP { get; set; }
public abstract int Move3_PP { get; set; }
public abstract int Move4_PP { get; set; }
public abstract int Move1_PPUps { get; set; }
public abstract int Move2_PPUps { get; set; }
public abstract int Move3_PPUps { get; set; }
public abstract int Move4_PPUps { get; set; }
public abstract int EV_HP { get; set; }
public abstract int EV_ATK { get; set; }
public abstract int EV_DEF { get; set; }
public abstract int EV_SPE { get; set; }
public abstract int EV_SPA { get; set; }
public abstract int EV_SPD { get; set; }
public abstract int IV_HP { get; set; }
public abstract int IV_ATK { get; set; }
public abstract int IV_DEF { get; set; }
public abstract int IV_SPE { get; set; }
public abstract int IV_SPA { get; set; }
public abstract int IV_SPD { get; set; }
Add Heal, make status_condition a pkm property also split out battle box slot offset fetch if anyone finds where colo&xd store their status bits, lmk :+1:
2019-01-12 06:25:48 +00:00
public abstract int Status_Condition { get; set; }
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
public abstract int Stat_Level { get; set; }
public abstract int Stat_HPMax { get; set; }
public abstract int Stat_HPCurrent { get; set; }
public abstract int Stat_ATK { get; set; }
public abstract int Stat_DEF { get; set; }
public abstract int Stat_SPE { get; set; }
public abstract int Stat_SPA { get; set; }
public abstract int Stat_SPD { get; set; }
// Hidden Properties
public abstract int Version { get; set; }
public abstract int SID { get; set; }
public abstract int PKRS_Strain { get; set; }
public abstract int PKRS_Days { get; set; }
public abstract uint EncryptionConstant { get; set; }
public abstract uint PID { get; set; }
public abstract ushort Sanity { get; set; }
public abstract ushort Checksum { get; set; }
// Misc Properties
public abstract int Language { get; set; }
public abstract bool FatefulEncounter { get; set; }
public abstract int TSV { get; }
public abstract int PSV { get; }
public abstract int Characteristic { get; }
MarkByte => MarkValue Includes marking coloring for main form as well changes type from byte to int
2016-10-31 02:15:48 +00:00
public abstract int MarkValue { get; protected set; }
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
public abstract int Met_Location { get; set; }
public abstract int Egg_Location { get; set; }
public abstract int OT_Friendship { get; set; }
Add LanguageID enum no functional change, just less-magic-numbers for easier to understand src
2017-10-23 04:01:08 +00:00
public virtual bool Japanese => Language == (int)LanguageID.Japanese;
public virtual bool Korean => Language == (int)LanguageID.Korean;
public virtual bool Chinese => Language == (int)LanguageID.ChineseS || Language == (int)LanguageID.ChineseT;
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
// Future Properties
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public virtual int Met_Year { get => 0; set { } }
public virtual int Met_Month { get => 0; set { } }
public virtual int Met_Day { get => 0; set { } }
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
public virtual string HT_Name { get; set; } = string.Empty;
Add more memory checks Mostly gen3-5 checks if they're ever supported; added bad hack check. Check yer battle videos to expose da haxxers.
2016-12-08 02:28:24 +00:00
public virtual int HT_Gender { get; set; }
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public virtual int HT_Affection { get; set; }
public virtual int HT_Friendship { get; set; }
public virtual int HT_Memory { get; set; }
public virtual int HT_TextVar { get; set; }
public virtual int HT_Feeling { get; set; }
public virtual int HT_Intensity { get; set; }
public virtual int OT_Memory { get; set; }
public virtual int OT_TextVar { get; set; }
public virtual int OT_Feeling { get; set; }
public virtual int OT_Intensity { get; set; }
public virtual byte Enjoyment { get; set; }
public virtual byte Fullness { get; set; }
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
public virtual int AbilityNumber { get; set; }
public virtual int Country { get; set; }
public virtual int Region { get; set; }
public virtual int ConsoleRegion { get; set; }
Added MetDate and EggMetDate properties to PKM and others Issue #171
2016-08-10 14:02:31 +00:00
/// <summary>
/// The date the Pokémon was met.
/// </summary>
Misc clean / xmldoc updates remove unused label in QR (use window Font) escape & -> &amp; for xmldoc proper style
2018-07-22 02:20:11 +00:00
/// <returns>
/// A DateTime representing the date the Pokémon was met.
/// Returns null if either the <see cref="PKM"/> format does not support dates or the stored date is invalid.</returns>
/// <remarks>
/// Not all <see cref="PKM"/> types support the <see cref="MetDate"/> property. In these cases, this property will return null.
/// If null is assigned to this property, it will be cleared.
/// </remarks>
public DateTime? MetDate
Added MetDate and EggMetDate properties to PKM and others Issue #171
2016-08-10 14:02:31 +00:00
{
get
{
// Check to see if date is valid
Fixed crash in DateUtil when Year is 0
2016-08-11 00:54:12 +00:00
if (!Util.IsDateValid(2000 + Met_Year, Met_Month, Met_Day))
Added MetDate and EggMetDate properties to PKM and others Issue #171
2016-08-10 14:02:31 +00:00
return null;
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
return new DateTime(2000 + Met_Year, Met_Month, Met_Day);
Added MetDate and EggMetDate properties to PKM and others Issue #171
2016-08-10 14:02:31 +00:00
}
set
{
if (value.HasValue)
{
// Only update the properties if a value is provided.
Fixed errors in implementation
2016-08-10 14:07:16 +00:00
Met_Year = value.Value.Year - 2000;
Added MetDate and EggMetDate properties to PKM and others Issue #171
2016-08-10 14:02:31 +00:00
Met_Month = value.Value.Month;
Met_Day = value.Value.Day;
}
else
{
// Clear the Met Date.
// If code tries to access MetDate again, null will be returned.
Met_Year = 0;
Met_Month = 0;
Met_Day = 0;
}
}
}
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public virtual int Egg_Year { get => 0; set { } }
public virtual int Egg_Month { get => 0; set { } }
public virtual int Egg_Day { get => 0; set { } }
Added MetDate and EggMetDate properties to PKM and others Issue #171
2016-08-10 14:02:31 +00:00
/// <summary>
/// The date a Pokémon was met as an egg.
/// </summary>
Misc clean / xmldoc updates remove unused label in QR (use window Font) escape & -> &amp; for xmldoc proper style
2018-07-22 02:20:11 +00:00
/// <returns>
/// A DateTime representing the date the Pokémon was met as an egg.
/// Returns null if either the <see cref="PKM"/> format does not support dates or the stored date is invalid.</returns>
/// <remarks>
/// Not all <see cref="PKM"/> types support the <see cref="EggMetDate"/> property. In these cases, this property will return null.
/// If null is assigned to this property, it will be cleared.
/// </remarks>
public DateTime? EggMetDate
Added MetDate and EggMetDate properties to PKM and others Issue #171
2016-08-10 14:02:31 +00:00
{
get
{
// Check to see if date is valid
Fixed crash in DateUtil when Year is 0
2016-08-11 00:54:12 +00:00
if (!Util.IsDateValid(2000 + Egg_Year, Egg_Month, Egg_Day))
Added MetDate and EggMetDate properties to PKM and others Issue #171
2016-08-10 14:02:31 +00:00
return null;
misc refactoring simplification / splitting, also more usum prep and other readability updates
2017-10-18 06:19:34 +00:00
return new DateTime(2000 + Egg_Year, Egg_Month, Egg_Day);
Added MetDate and EggMetDate properties to PKM and others Issue #171
2016-08-10 14:02:31 +00:00
}
set
{
if (value.HasValue)
{
// Only update the properties if a value is provided.
Fixed errors in implementation
2016-08-10 14:07:16 +00:00
Egg_Year = value.Value.Year - 2000;
Added MetDate and EggMetDate properties to PKM and others Issue #171
2016-08-10 14:02:31 +00:00
Egg_Month = value.Value.Month;
Egg_Day = value.Value.Day;
}
else
{
// Clear the Met Date.
// If code tries to access MetDate again, null will be returned.
Egg_Year = 0;
Egg_Month = 0;
Egg_Day = 0;
}
}
}
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public virtual int OT_Affection { get => 0; set { } }
public virtual int RelearnMove1 { get => 0; set { } }
public virtual int RelearnMove2 { get => 0; set { } }
public virtual int RelearnMove3 { get => 0; set { } }
public virtual int RelearnMove4 { get => 0; set { } }
public virtual int EncounterType { get => 0; set { } }
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
// Exposed but not Present in all
public abstract int CurrentHandler { get; set; }
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// Maximums
public abstract int MaxMoveID { get; }
public abstract int MaxSpeciesID { get; }
public abstract int MaxItemID { get; }
public abstract int MaxAbilityID { get; }
public abstract int MaxBallID { get; }
public abstract int MaxGameID { get; }
Refactoring Extract game value limits Rearrange GameVersion util logic extensions add better gameversion fetch for generator (equivalent to pkmeditor)
2018-06-15 23:00:28 +00:00
public virtual int MinGameID => 0;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
public abstract int MaxIV { get; }
public abstract int MaxEV { get; }
public abstract int OTLength { get; }
public abstract int NickLength { get; }
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
// Derived
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public int SpecForm { get => Species + (AltForm << 11); set { Species = value & 0x7FF; AltForm = value >> 11; } }
Refactoring Simplify HeldItem / SpriteItem Egg Nicknaming user automation added (checks nicknamed & adds egg if isEgg ticked) Remove some unnecessary data caching Allow QR codes for games NDS+ (for program use only, no QR browser exploit works
2016-10-12 05:59:19 +00:00
public virtual int SpriteItem => HeldItem;
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public virtual bool IsShiny => TSV == PSV;
Fix sort writeback for locked slots clear flag, update properties #2235
2019-01-09 02:31:14 +00:00
public StorageSlotFlag StorageFlags { get; internal set; }
public bool Locked => StorageFlags.HasFlagFast(StorageSlotFlag.Locked);
Add id7 setters can now set TrainerID7 / TrainerSID7 via batch editor
2018-07-11 04:25:03 +00:00
public int TrainerID7 { get => (int)((uint)(TID | (SID << 16)) % 1000000); set => SetID7(TrainerSID7, value); }
public int TrainerSID7 { get => (int)((uint)(TID | (SID << 16)) / 1000000); set => SetID7(value, TrainerID7); }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add display TID/SID get/set
2019-02-10 18:31:20 +00:00
public int DisplayTID
{
get => GenNumber >= 7 ? TrainerID7 : TID;
Misc updates extract some enums to core, use Enum.GetNames to do string fetch make stamp listbox taller clean up Display*ID setters
2019-02-22 05:54:41 +00:00
set { if (GenNumber >= 7) TrainerID7 = value; else TID = value; }
Add display TID/SID get/set
2019-02-10 18:31:20 +00:00
}
public int DisplaySID
{
get => GenNumber >= 7 ? TrainerSID7 : SID;
Misc updates extract some enums to core, use Enum.GetNames to do string fetch make stamp listbox taller clean up Display*ID setters
2019-02-22 05:54:41 +00:00
set { if (GenNumber >= 7) TrainerSID7 = value; else SID = value; }
Add display TID/SID get/set
2019-02-10 18:31:20 +00:00
}
Add id7 setters can now set TrainerID7 / TrainerSID7 via batch editor
2018-07-11 04:25:03 +00:00
private void SetID7(int sid7, int tid7)
{
var oid = (sid7 * 1_000_000) + (tid7 % 1_000_000);
TID = (ushort)oid;
SID = oid >> 16;
}
Update egg location/level checks for 3-5 Extracted some reusable parts
2017-03-20 04:36:03 +00:00
public bool E => Version == (int)GameVersion.E;
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
public bool FRLG => Version == (int)GameVersion.FR || Version == (int)GameVersion.LG;
Update egg location/level checks for 3-5 Extracted some reusable parts
2017-03-20 04:36:03 +00:00
public bool Pt => (int)GameVersion.Pt == Version;
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
public bool HGSS => Version == (int)GameVersion.HG || Version == (int)GameVersion.SS;
Misc languageID legality checking update Checks for max language ID on transferred pkm (gen5 pkm on gen7 can't have CHS/CHT etc) handles edge case for JPN B/W ingame trades update pk5->pk6 transfer logic to bump langID 0 to 1. Thanks HaxAras & Britty for providing samples!
2017-09-16 00:43:31 +00:00
public bool BW => Version == (int)GameVersion.B || Version == (int)GameVersion.W;
Alpha 3-5 legality checking Incorporates files from #190 Skeleton added for future implementations; currently missing gifts, encounter info, and the fine tuning that follows. Basically sets up areas for future implementation... feel free to submit pull requests filling in the EncounterStatic/EncounterTrade blocks with the basic info. I'll probably focus on gen5->4->3 in terms of priority. Encounter slots need to be marked up for encounter slot legality (yay 32bit RNG), and will be used for PIDIV detection too. XD/C is not in this round of implementation. Pretty much every pkm 3-5 will show up as invalid until this round of dev is finished.
2017-03-18 23:50:34 +00:00
public bool B2W2 => Version == (int)GameVersion.B2 || Version == (int)GameVersion.W2;
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
public bool XY => Version == (int)GameVersion.X || Version == (int)GameVersion.Y;
public bool AO => Version == (int)GameVersion.AS || Version == (int)GameVersion.OR;
public bool SM => Version == (int)GameVersion.SN || Version == (int)GameVersion.MN;
More usum prep I think egg hatch location checking is wrong for traded eggs (see gen3 vs future games, origin game shouldn't change but could hatch ORAS egg on XY at XY location?)
2017-09-20 04:35:30 +00:00
public bool USUM => Version == (int)GameVersion.US || Version == (int)GameVersion.UM;
Misc updates rearrange pkm version groups for clear break between twins/siblings/family clear pokelist for sav7b on non-exportable saves (prevents b1s1 from showing markings) rename horohoro (pgo) to non romaji lol, hide daycare/party tabs on nonexportable save remove some unnecessary operations rewrite getallcontrolsoftype to remove ToList() and make generic
2019-01-05 23:40:25 +00:00
public bool GO => Version == (int)GameVersion.GO;
public bool VC1 => Version >= (int)GameVersion.RD && Version <= (int)GameVersion.YW;
public bool VC2 => Version >= (int)GameVersion.GD && Version <= (int)GameVersion.C;
Treat GameVersion.GO like other GG vers
2018-11-15 01:40:11 +00:00
public bool GG => Version == (int)GameVersion.GP || Version == (int)GameVersion.GE || Version == (int)GameVersion.GO;
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
public bool SWSH => Version == (int)GameVersion.SW || Version == (int)GameVersion.SH;
Misc updates rearrange pkm version groups for clear break between twins/siblings/family clear pokelist for sav7b on non-exportable saves (prevents b1s1 from showing markings) rename horohoro (pgo) to non romaji lol, hide daycare/party tabs on nonexportable save remove some unnecessary operations rewrite getallcontrolsoftype to remove ToList() and make generic
2019-01-05 23:40:25 +00:00
Update egg location/level checks for 3-5 Extracted some reusable parts
2017-03-20 04:36:03 +00:00
protected bool PtHGSS => Pt || HGSS;
Cleanup Use S/M met locations for Pokémon GO origin Changing to VC1 or GO now autofills met location Un-alphabetize RGBY games and move to end of games list (+go) Mark unused region names (Kanto string appears twice in text bank 3, 30013 is used) Move hypertraining stat toggling to pkm object shift 1->7 logic to repeat less operations add more 1->7 logic pertaining to memories add RefreshAbility method (0 based input, not 1/2/4)
2017-01-26 06:51:52 +00:00
public bool VC => VC1 || VC2;
use sprite resource name instead of species-form Closes #2113
2018-09-08 02:11:22 +00:00
public bool Gen7 => (Version >= 30 && Version <= 33) || GG;
Update cleared data legality checks Add in a few more, a little bit of shuffling
2017-01-25 17:17:20 +00:00
public bool Gen6 => Version >= 24 && Version <= 29;
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
public bool Gen5 => Version >= 20 && Version <= 23;
Fix pt encounter type vis on load Thanks Ammako!
2016-10-11 14:45:36 +00:00
public bool Gen4 => Version >= 7 && Version <= 12 && Version != 9;
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public bool Gen3 => (Version >= 1 && Version <= 5) || Version == 15;
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
public bool Gen2 => Version == (int)GameVersion.GSC;
public bool Gen1 => Version == (int)GameVersion.RBY;
Misc updates Simplify unknown gen expression allow mutation of FormIndex if desired
2019-02-11 05:31:27 +00:00
public bool GenU => GenNumber <= 0;
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Improve PID/EC rerolling automation
2016-08-09 01:42:42 +00:00
public int GenNumber
{
get
{
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
if (Gen7) return 7;
Improve PID/EC rerolling automation
2016-08-09 01:42:42 +00:00
if (Gen6) return 6;
if (Gen5) return 5;
if (Gen4) return 4;
if (Gen3) return 3;
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
if (Gen2) return Format; // 2
if (Gen1) return Format; // 1
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
if (VC1) return 1;
if (VC2) return 2;
Improve PID/EC rerolling automation
2016-08-09 01:42:42 +00:00
return -1;
Add DebutGeneration get https://projectpokemon.org/home/forums/topic/43378-generation-search-in-pkmdb-andor-batch-editor/ (less than) < and (greater than) > not currently supported (no plan to add, would need to rewrite value eval logic)
2018-01-10 23:40:33 +00:00
}
Improve PID/EC rerolling automation
2016-08-09 01:42:42 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add DebutGeneration get https://projectpokemon.org/home/forums/topic/43378-generation-search-in-pkmdb-andor-batch-editor/ (less than) < and (greater than) > not currently supported (no plan to add, would need to rewrite value eval logic)
2018-01-10 23:40:33 +00:00
public int DebutGeneration => Legal.GetDebutGeneration(Species);
Add pkrs infected/cured setters
2019-03-21 23:48:17 +00:00
public bool PKRS_Infected { get => PKRS_Strain > 0; set => PKRS_Strain = value ? Math.Max(PKRS_Strain, 1) : 0; }
public bool PKRS_Cured
{
get => PKRS_Days == 0 && PKRS_Strain > 0;
set
{
PKRS_Days = value ? 0 : 1;
PKRS_Infected = true;
}
}
Initial support for SAV1 loading...warning: mostly broken
2016-08-28 10:18:22 +00:00
public virtual bool ChecksumValid => Checksum == CalculateChecksum();
Update party stat level on level max mod Closes #2194 , pb7 are always stored in party format -- also PK1/2 store it in their box format
2018-12-03 23:40:09 +00:00
public int CurrentLevel { get => Experience.GetLevel(EXP, Species, AltForm); set => EXP = Experience.GetEXP(Stat_Level = value, Species, AltForm); }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public int MarkCircle { get => Markings[0]; set { var marks = Markings; marks[0] = value; Markings = marks; } }
public int MarkTriangle { get => Markings[1]; set { var marks = Markings; marks[1] = value; Markings = marks; } }
public int MarkSquare { get => Markings[2]; set { var marks = Markings; marks[2] = value; Markings = marks; } }
public int MarkHeart { get => Markings[3]; set { var marks = Markings; marks[3] = value; Markings = marks; } }
public int MarkStar { get => Markings[4]; set { var marks = Markings; marks[4] = value; Markings = marks; } }
public int MarkDiamond { get => Markings[5]; set { var marks = Markings; marks[5] = value; Markings = marks; } }
Relocate hypertraining properties to interface lessen temp array creation, speed++
2018-06-06 04:31:42 +00:00
public int IVTotal => IV_HP + IV_ATK + IV_DEF + IV_SPA + IV_SPD + IV_SPE;
public int EVTotal => EV_HP + EV_ATK + EV_DEF + EV_SPA + EV_SPD + EV_SPE;
Move GetIV to pkm, misc simplifications remove linq for characteristic calc (get max IV) and others remove some reliance on new[] for iv/ev pk5 replace bitmagic with property get->set copy for cleanliness
2019-01-05 18:51:41 +00:00
public int MaximumIV => Math.Max(Math.Max(Math.Max(Math.Max(Math.Max(IV_HP, IV_ATK), IV_DEF), IV_SPA), IV_SPD), IV_SPE);
public int FlawlessIVCount
{
get
{
int max = MaxIV;
int ctr = 0;
if (IV_HP == max) ++ctr;
if (IV_ATK == max) ++ctr;
if (IV_DEF == max) ++ctr;
if (IV_SPA == max) ++ctr;
if (IV_SPD == max) ++ctr;
if (IV_SPE == max) ++ctr;
return ctr;
}
}
Add form# to dumped pkm Closes #479
2016-11-24 04:24:01 +00:00
Add filename without extension property for encrypting the pkm -> 'ekx'
2018-09-16 17:48:04 +00:00
public string FileName => $"{FileNameWithoutExtension}.{Extension}";
public virtual string FileNameWithoutExtension
Add form# to dumped pkm Closes #479
2016-11-24 04:24:01 +00:00
{
get
{
"" -> string.Empty be explicit that the string is empty rather than possibly missing disallow encrypted export for BK4 (they're not encrypted), removes type check simplify replaceall in showdownset (don't call ReplaceAll 4x, just get valid chars and rebuild) simplify get ribbon sprite name (precompute ToLower and appended values
2019-02-08 05:40:20 +00:00
string form = AltForm > 0 ? $"-{AltForm:00}" : string.Empty;
string star = IsShiny ? " ★" : string.Empty;
Add filename without extension property for encrypting the pkm -> 'ekx'
2018-09-16 17:48:04 +00:00
return $"{Species:000}{form}{star} - {Nickname} - {Checksum:X4}{EncryptionConstant:X8}";
Add form# to dumped pkm Closes #479
2016-11-24 04:24:01 +00:00
}
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
public int[] IVs
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => new[] { IV_HP, IV_ATK, IV_DEF, IV_SPE, IV_SPA, IV_SPD };
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
set
{
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
if (value.Length != 6)
return;
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
IV_HP = value[0]; IV_ATK = value[1]; IV_DEF = value[2];
IV_SPE = value[3]; IV_SPA = value[4]; IV_SPD = value[5];
}
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
public int[] EVs
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => new[] { EV_HP, EV_ATK, EV_DEF, EV_SPE, EV_SPA, EV_SPD };
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
set
{
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
if (value.Length != 6)
return;
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
EV_HP = value[0]; EV_ATK = value[1]; EV_DEF = value[2];
EV_SPE = value[3]; EV_SPA = value[4]; EV_SPD = value[5];
}
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add stats get/set and batch editor suggest Closes #2196
2018-12-04 04:53:37 +00:00
public int[] Stats
{
get => new[] { Stat_HPCurrent, Stat_ATK, Stat_DEF, Stat_SPE, Stat_SPA, Stat_SPD };
set
{
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
if (value.Length != 6)
Add stats get/set and batch editor suggest Closes #2196
2018-12-04 04:53:37 +00:00
return;
Stat_HPCurrent = value[0]; Stat_ATK = value[1]; Stat_DEF = value[2];
Stat_SPE = value[3]; Stat_SPA = value[4]; Stat_SPD = value[5];
}
}
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
public int[] Moves
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => new[] { Move1, Move2, Move3, Move4 };
Standardize move setter no longer allow passing null, if array is too small, set zero instead.
2018-03-29 03:34:12 +00:00
set
{
Move1 = value.Length > 0 ? value[0] : 0;
Move2 = value.Length > 1 ? value[1] : 0;
Move3 = value.Length > 2 ? value[2] : 0;
Move4 = value.Length > 3 ? value[3] : 0;
}
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Relocate relearnmoves derived property
2016-08-27 15:43:36 +00:00
public int[] RelearnMoves
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => new[] { RelearnMove1, RelearnMove2, RelearnMove3, RelearnMove4 };
Misc clean split some methods with optional parameters=null add more xmldoc replace some magic numbers -> enum/const references consolidate common array operations (span soon maybe?)
2019-09-10 07:21:51 +00:00
set => SetRelearnMoves(value);
}
public void SetRelearnMoves(IReadOnlyList<int> value)
{
RelearnMove1 = value.Count > 0 ? value[0] : 0;
RelearnMove2 = value.Count > 1 ? value[1] : 0;
RelearnMove3 = value.Count > 2 ? value[2] : 0;
RelearnMove4 = value.Count > 3 ? value[3] : 0;
Relocate relearnmoves derived property
2016-08-27 15:43:36 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Implement PID-Ability corrections Line 2211: When the fields are loaded, if the user modifies the Ability on a <=Gen5 save file, if the ability is modified, the PID will be randomized to fit the new PID. When the Ability combobox is loaded, the personal entry may have 0 for the ability2 (indicating same as ability1); if so, copy ability1 instead of filtering it out. When the Ability index is loaded, hidden ability is checked first, else it tries to match: invalid, hidden (unflagged=illegal), if abilities same use PIDAbility, else use the actual ability index.
2016-08-23 03:37:50 +00:00
public int PIDAbility
{
get
{
if (GenNumber > 5 || Format > 5)
return -1;
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
Misc legality fixes & improvements Recognize gen4/5 events check ability mismatch check nature mismatch
2017-03-24 04:42:33 +00:00
if (Version == (int) GameVersion.CXD)
return Array.IndexOf(PersonalInfo.Abilities, Ability);
Misc tweaks fix roamer3 not setting IVs fix usum z items rightmost pixel getting chopped off use Gen* instead of GenNumber for specific cases (faster) add WasGiftEgg location case for Gen7 remove some unnecessary array allocations
2017-11-18 06:19:23 +00:00
return (int)((Gen5 ? PID >> 16 : PID) & 1);
Implement PID-Ability corrections Line 2211: When the fields are loaded, if the user modifies the Ability on a <=Gen5 save file, if the ability is modified, the PID will be randomized to fit the new PID. When the Ability combobox is loaded, the personal entry may have 0 for the ability2 (indicating same as ability1); if so, copy ability1 instead of filtering it out. When the Ability index is loaded, hidden ability is checked first, else it tries to match: invalid, hidden (unflagged=illegal), if abilities same use PIDAbility, else use the actual ability index.
2016-08-23 03:37:50 +00:00
}
}
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
MarkByte => MarkValue Includes marking coloring for main form as well changes type from byte to int
2016-10-31 02:15:48 +00:00
public virtual int[] Markings
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
{
get
{
MarkByte => MarkValue Includes marking coloring for main form as well changes type from byte to int
2016-10-31 02:15:48 +00:00
int[] mark = new int[8];
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
for (int i = 0; i < 8; i++)
MarkByte => MarkValue Includes marking coloring for main form as well changes type from byte to int
2016-10-31 02:15:48 +00:00
mark[i] = (MarkValue >> i) & 1;
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
return mark;
}
set
{
if (value.Length > 8)
return;
byte b = 0;
for (int i = 0; i < value.Length; i++)
Misc tweaks Fixes marking set #798 sleep deprivation ftw
2017-02-01 03:35:18 +00:00
b |= (byte)(Math.Min(value[i], 1) << i);
MarkByte => MarkValue Includes marking coloring for main form as well changes type from byte to int
2016-10-31 02:15:48 +00:00
MarkValue = b;
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
}
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
protected static int GetHiddenPowerBitVal(int[] ivs)
Add hidden power power calculating Add setter for HPType for gen2 pkm obviously can mess with gender in gen2 also tweaked gen1/2 IsNicknamed setters to clear nickname, as well as use the PKX get species name per format rather than doing it within the class.
2017-03-05 01:19:57 +00:00
{
int sum = 0;
for (int i = 0; i < ivs.Length; i++)
sum |= (ivs[i] & 1) << i;
return sum;
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Remove excessive references to Util.Rand32() all usages besides fetching a 32bit random value should use rand.next remove unnecessary do-while loop for calculating random EVs (always returns 510 in total)
2018-07-04 18:30:43 +00:00
private int HPVal => GetHiddenPowerBitVal(IVs);
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public virtual int HPPower => Format < 6 ? (40 *HPVal/63) + 30 : 60;
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public virtual int HPType
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => 15 * HPVal / 63;
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
set
{
Move pkx hidden power logic to HiddenPower.cs
2019-03-16 19:07:22 +00:00
IV_HP = (IV_HP & ~1) + HiddenPower.DefaultLowBits[value, 0];
IV_ATK = (IV_ATK & ~1) + HiddenPower.DefaultLowBits[value, 1];
IV_DEF = (IV_DEF & ~1) + HiddenPower.DefaultLowBits[value, 2];
IV_SPE = (IV_SPE & ~1) + HiddenPower.DefaultLowBits[value, 3];
IV_SPA = (IV_SPA & ~1) + HiddenPower.DefaultLowBits[value, 4];
IV_SPD = (IV_SPD & ~1) + HiddenPower.DefaultLowBits[value, 5];
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
}
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
// Legality Extensions
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
public TradebackType TradebackStatus { get; set; } = TradebackType.Any;
public bool Gen1_NotTradeback => TradebackStatus == TradebackType.Gen1_NotTradeback;
public bool Gen2_NotTradeback => TradebackStatus == TradebackType.Gen2_NotTradeback;
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
public virtual bool WasLink => false;
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add hot springs as valid egg location for gen6 split table references, remove per-format calculations as they all behaved the same as the main method
2017-07-11 01:56:13 +00:00
public bool WasEgg
Add egg checking for gen2 Delay egg move checking until the end to finish validating moves
2017-02-28 04:57:24 +00:00
{
get
{
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
int loc = Egg_Location;
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
return GenNumber switch
parseMoves functions improvement (#1018) * Add egg locations and gits egg locations for gen 4 and 5 Add WasGiftEgg property and diferenciate from WasEventEgg * Separate parseMoves Pre Relearn and Post Relearn generations Separte parseMoves Pre Relearn egg-encounter for non-egg encounters, a gen3 pokemon can be both Post Relearn IsEgg pokemon should have all moves as relearn moves parseMovesSketch should not be used for Smeargle inside an egg WasGiftEgg should not have egg moves * Fix WasEgg and WasEventEgg functions for Manaphy * Add gen 5 trade egg location Check for generation 3 IsEgg if is a gift egg or an event egg that there is a valid encounter for the egg * Move parseMovesGetGift bellow WasEggPreRelearn. WasEggPreRelearn is already checking for gift encounters, some generation 3 pokemon could be both an egg or an event encounter * Check for gift egg without valid encounter in verifyEncounterEgg * Check WasEventEgg without encounter in verifyEncounterEgg
2017-04-01 16:45:13 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
4 => (Legal.EggLocations4.Contains(loc) || (Species == (int) Core.Species.Manaphy && loc == Locations.Ranger4) || (loc == Locations.Faraway4 && PtHGSS)), // faraway
5 => Legal.EggLocations5.Contains(loc),
6 => Legal.EggLocations6.Contains(loc),
7 => Legal.EggLocations7.Contains(loc),
8 => Legal.EggLocations8.Contains(loc),
// Gen 1/2 and pal park Gen 3
_ => false
};
Cleanup Fix b2w2 tutor tables fix gen5 recognizing of transferred eggs fix xml warnings fix crlf
2017-03-25 01:23:39 +00:00
}
Add egg checking for gen2 Delay egg move checking until the end to finish validating moves
2017-02-28 04:57:24 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Differentiate WasEgg (any egg location) from bred https://projectpokemon.org/home/forums/topic/44838-buggen5-egg/ WasEgg is used for other encounter based checks, so can't reduce the logic usage
2018-04-18 01:54:38 +00:00
public bool WasBredEgg
{
get
{
int loc = Egg_Location;
switch (GenNumber)
{
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
case 4: return loc == Locations.Daycare4 || loc == Locations.LinkTrade4 || (loc == Locations.Faraway4 && PtHGSS); // faraway
case 5: return loc == Locations.Daycare5 || loc == Locations.LinkTrade5;
Differentiate WasEgg (any egg location) from bred https://projectpokemon.org/home/forums/topic/44838-buggen5-egg/ WasEgg is used for other encounter based checks, so can't reduce the logic usage
2018-04-18 01:54:38 +00:00
case 6:
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
case 7:
case 8:
return loc == Locations.Daycare5 || loc == Locations.LinkTrade6;
Remove WasEgg setter WasEgg (aka WasDefinitelyAnEgg) from stored properties is one thing, WasEgg from encounter info is another; don't mix
2019-07-26 00:42:15 +00:00
default: return false; // Gen 1/2 and pal park Gen 3
Differentiate WasEgg (any egg location) from bred https://projectpokemon.org/home/forums/topic/44838-buggen5-egg/ WasEgg is used for other encounter based checks, so can't reduce the logic usage
2018-04-18 01:54:38 +00:00
}
}
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
parseMoves functions improvement (#1018) * Add egg locations and gits egg locations for gen 4 and 5 Add WasGiftEgg property and diferenciate from WasEventEgg * Separate parseMoves Pre Relearn and Post Relearn generations Separte parseMoves Pre Relearn egg-encounter for non-egg encounters, a gen3 pokemon can be both Post Relearn IsEgg pokemon should have all moves as relearn moves parseMovesSketch should not be used for Smeargle inside an egg WasGiftEgg should not have egg moves * Fix WasEgg and WasEventEgg functions for Manaphy * Add gen 5 trade egg location Check for generation 3 IsEgg if is a gift egg or an event egg that there is a valid encounter for the egg * Move parseMovesGetGift bellow WasEggPreRelearn. WasEggPreRelearn is already checking for gift encounters, some generation 3 pokemon could be both an egg or an event encounter * Check for gift egg without valid encounter in verifyEncounterEgg * Check WasEventEgg without encounter in verifyEncounterEgg
2017-04-01 16:45:13 +00:00
public virtual bool WasGiftEgg
{
get
{
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
if (!WasEgg)
return false;
int loc = Egg_Location;
Transfer legality for HGSS eggs Faraway place (3002) can be retained on transfer
2017-04-11 01:46:37 +00:00
switch (GenNumber)
parseMoves functions improvement (#1018) * Add egg locations and gits egg locations for gen 4 and 5 Add WasGiftEgg property and diferenciate from WasEventEgg * Separate parseMoves Pre Relearn and Post Relearn generations Separte parseMoves Pre Relearn egg-encounter for non-egg encounters, a gen3 pokemon can be both Post Relearn IsEgg pokemon should have all moves as relearn moves parseMovesSketch should not be used for Smeargle inside an egg WasGiftEgg should not have egg moves * Fix WasEgg and WasEventEgg functions for Manaphy * Add gen 5 trade egg location Check for generation 3 IsEgg if is a gift egg or an event egg that there is a valid encounter for the egg * Move parseMovesGetGift bellow WasEggPreRelearn. WasEggPreRelearn is already checking for gift encounters, some generation 3 pokemon could be both an egg or an event encounter * Check for gift egg without valid encounter in verifyEncounterEgg * Check WasEventEgg without encounter in verifyEncounterEgg
2017-04-01 16:45:13 +00:00
{
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
case 4: return Legal.GiftEggLocation4.Contains(loc) || (loc == Locations.Faraway4 && HGSS); // faraway
case 5: return loc == 60003;
Misc tweaks fix roamer3 not setting IVs fix usum z items rightmost pixel getting chopped off use Gen* instead of GenNumber for specific cases (faster) add WasGiftEgg location case for Gen7 remove some unnecessary array allocations
2017-11-18 06:19:23 +00:00
case 6:
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
case 7:
case 8:
return loc == 60004;
parseMoves functions improvement (#1018) * Add egg locations and gits egg locations for gen 4 and 5 Add WasGiftEgg property and diferenciate from WasEventEgg * Separate parseMoves Pre Relearn and Post Relearn generations Separte parseMoves Pre Relearn egg-encounter for non-egg encounters, a gen3 pokemon can be both Post Relearn IsEgg pokemon should have all moves as relearn moves parseMovesSketch should not be used for Smeargle inside an egg WasGiftEgg should not have egg moves * Fix WasEgg and WasEventEgg functions for Manaphy * Add gen 5 trade egg location Check for generation 3 IsEgg if is a gift egg or an event egg that there is a valid encounter for the egg * Move parseMovesGetGift bellow WasEggPreRelearn. WasEggPreRelearn is already checking for gift encounters, some generation 3 pokemon could be both an egg or an event encounter * Check for gift egg without valid encounter in verifyEncounterEgg * Check WasEventEgg without encounter in verifyEncounterEgg
2017-04-01 16:45:13 +00:00
}
return false;
}
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
public virtual bool WasEvent => Locations.IsEventLocation5(Met_Location) || FatefulEncounter;
Update Ho-Oh mattle check More languages than Italian have a rule-breaking name. Rework checks a bit Flag eggs more accurately Update force hatch to move Link Trade met location to Egg Location fix Ho-oh -> Ho-Oh text strings (correctness is key!)
2018-10-27 23:06:06 +00:00
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
public virtual bool WasEventEgg
Legality edge case fixes Some incorrect IDs, some additions (unbreedable hidden abilities in genV) https://projectpokemon.org/forums/forums/topic/41407-pkhex-legality-errors-on-gen-6-updated/?tab=comments#comment-219459
2017-09-06 01:28:38 +00:00
{
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
get
Legality edge case fixes Some incorrect IDs, some additions (unbreedable hidden abilities in genV) https://projectpokemon.org/forums/forums/topic/41407-pkhex-legality-errors-on-gen-6-updated/?tab=comments#comment-219459
2017-09-06 01:28:38 +00:00
{
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
if (Gen4)
return WasEgg && Species == (int) Core.Species.Manaphy;
// Gen5+
if (Met_Level != 1)
return false;
int loc = Egg_Location;
return Locations.IsEventLocation5(loc) || (FatefulEncounter && loc != 0);
Legality edge case fixes Some incorrect IDs, some additions (unbreedable hidden abilities in genV) https://projectpokemon.org/forums/forums/topic/41407-pkhex-legality-errors-on-gen-6-updated/?tab=comments#comment-219459
2017-09-06 01:28:38 +00:00
}
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
public bool WasTradedEgg => Egg_Location == GetTradedEggLocation();
public bool IsTradedEgg => Met_Location == GetTradedEggLocation();
private int GetTradedEggLocation() => Locations.TradedEggLocation(GenNumber);
Misc perf tweaks checking untraded should just check for the first character (rather than creating string object) hashset for wild6 balls
2017-12-14 00:12:53 +00:00
public virtual bool IsUntraded => false;
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
public virtual bool IsNative => GenNumber == Format;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public virtual bool IsOriginValid => Species <= Legal.GetMaxSpeciesOrigin(Format);
Handle skipped gens Expand InhabitedGeneration to actually check if it can inhabit generation instead of if species can exist on generation misc behavior tweaks
2017-02-15 08:11:12 +00:00
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
/// Checks if the <see cref="PKM"/> could inhabit a set of games.
/// </summary>
/// <param name="Generation">Set of games.</param>
Handle skipped gens Expand InhabitedGeneration to actually check if it can inhabit generation instead of if species can exist on generation misc behavior tweaks
2017-02-15 08:11:12 +00:00
/// <param name="species"></param>
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <returns>True if could inhabit, False if not.</returns>
Handle skipped gens Expand InhabitedGeneration to actually check if it can inhabit generation instead of if species can exist on generation misc behavior tweaks
2017-02-15 08:11:12 +00:00
public bool InhabitedGeneration(int Generation, int species = -1)
Add personalinfo references per PKM format Fix possible hang in pk6/pk7 if country/region is unset (continues loop). PersonalInfo references are not to be used when calculating stats (use the savefile table instead)
2016-10-24 05:01:39 +00:00
{
Handle skipped gens Expand InhabitedGeneration to actually check if it can inhabit generation instead of if species can exist on generation misc behavior tweaks
2017-02-15 08:11:12 +00:00
if (species < 0)
species = Species;
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
Check future gen evolutions in InhabitedGeneration Return true when format equals generation
2017-02-16 00:33:17 +00:00
if (Format == Generation)
GenU returns should returns false for VC pokemon
2017-02-15 22:11:01 +00:00
return true;
Handle skipped gens Expand InhabitedGeneration to actually check if it can inhabit generation instead of if species can exist on generation misc behavior tweaks
2017-02-15 08:11:12 +00:00
if (!IsOriginValid)
return false;
// Sanity Check Species ID
Tweak level/origin check for moves Valid species/movepools are already determined via the dexlevel and prior methods, no need to check again with current species. edge case: sing froslass from CXD won't check gen3 moves (ie, sing)
2017-06-27 03:30:44 +00:00
if (Legal.GetMaxSpeciesOrigin(Generation) < species && !Legal.GetFutureGenEvolutions(Generation).Contains(species))
Handle skipped gens Expand InhabitedGeneration to actually check if it can inhabit generation instead of if species can exist on generation misc behavior tweaks
2017-02-15 08:11:12 +00:00
return false;
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
// Trade generation 1 -> 2
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
if (Format == 2 && Generation == 1 && !Gen2_NotTradeback)
return true;
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
// Trade generation 2 -> 1
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
if (Format == 1 && Generation == 2 && !Gen1_NotTradeback)
return true;
if (Format < Generation)
return false; // Future
Handle skipped gens Expand InhabitedGeneration to actually check if it can inhabit generation instead of if species can exist on generation misc behavior tweaks
2017-02-15 08:11:12 +00:00
int gen = GenNumber;
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
return Generation switch
Add personalinfo references per PKM format Fix possible hang in pk6/pk7 if country/region is unset (continues loop). PersonalInfo references are not to be used when calculating stats (use the savefile table instead)
2016-10-24 05:01:39 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
1 => (Format == 1 || VC), // species compat checked via sanity above
2 => (Format == 2 || VC),
3 => Gen3,
4 => (3 <= gen && gen <= 4),
5 => (3 <= gen && gen <= 5),
6 => (3 <= gen && gen <= 6),
7 => ((3 <= gen && gen <= 7) || VC),
8 => ((3 <= gen && gen <= 8) || VC),
_ => false
};
Add personalinfo references per PKM format Fix possible hang in pk6/pk7 if country/region is unset (continues loop). PersonalInfo references are not to be used when calculating stats (use the savefile table instead)
2016-10-24 05:01:39 +00:00
}
Change gen4 (egg) met location setter Closes #1135 clear both if zero set value to dp location if a valid dp location, else set faraway place set value to pthgss location if originated from pthgss
2017-05-19 05:40:35 +00:00
/// <summary>
Add rby encounters Includes fishing slots todo on trades/static encounters; feel free to pull request (look at tables6/7 for ref).
2017-02-12 17:52:26 +00:00
/// Checks if the PKM has its original met location.
/// </summary>
/// <returns>Returns false if the Met Location has been overwritten via generational transfer.</returns>
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public virtual bool HasOriginalMetLocation => !(Format < 3 || VC || (GenNumber <= 4 && Format != GenNumber));
Add rby encounters Includes fishing slots todo on trades/static encounters; feel free to pull request (look at tables6/7 for ref).
2017-02-12 17:52:26 +00:00
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
/// Checks if the current <see cref="Gender"/> is valid.
/// </summary>
/// <returns>True if valid, False if invalid.</returns>
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public virtual bool IsGenderValid()
gender check update check gender correctly for transferred species
2017-03-25 07:01:02 +00:00
{
Simplify PID gender checking don't have multiple locations where comparisons are done, just generate the gender and compare only fetch gender once from getter
2017-05-19 02:16:11 +00:00
int gender = Gender;
gender check update check gender correctly for transferred species
2017-03-25 07:01:02 +00:00
int gv = PersonalInfo.Gender;
if (gv == 255)
Simplify PID gender checking don't have multiple locations where comparisons are done, just generate the gender and compare only fetch gender once from getter
2017-05-19 02:16:11 +00:00
return gender == 2;
gender check update check gender correctly for transferred species
2017-03-25 07:01:02 +00:00
if (gv == 254)
Simplify PID gender checking don't have multiple locations where comparisons are done, just generate the gender and compare only fetch gender once from getter
2017-05-19 02:16:11 +00:00
return gender == 1;
gender check update check gender correctly for transferred species
2017-03-25 07:01:02 +00:00
if (gv == 0)
Simplify PID gender checking don't have multiple locations where comparisons are done, just generate the gender and compare only fetch gender once from getter
2017-05-19 02:16:11 +00:00
return gender == 0;
gender check update check gender correctly for transferred species
2017-03-25 07:01:02 +00:00
Add fixed gender checks for non-GBA/NDS games Closes #1912 , genderless ~= fixed gender I guess; shouldn't get these gender-errors unless it's manually tampered data/ShowdownSet remove unnecessary code in: * PKMEditor (>=255 is already covered by == 255 and the fact that gt is always <= 255) * VerifyGender (3 <= x <= 5) check is already early-returned via PIDGender check above Update IsGenderValid knowing that VC mons have a gennumber <= 2
2018-04-24 02:58:29 +00:00
int gen = GenNumber;
Misc updates reducing allocations, increasing clarity by removing some magic numbers probably can rewrite some of the evo loading/checking for even less, but good for now.
2019-01-07 00:22:45 +00:00
if (gen <= 2 || gen >= 6)
Fix gender handling Closes #1933 if not allowed to be genderless, flag as invalid gender only permit valid genders after genderless is ruled out (both done by checking the low bit)
2018-05-11 01:53:23 +00:00
return gender == (gender & 1);
gender check update check gender correctly for transferred species
2017-03-25 07:01:02 +00:00
Misc refactoring expose some useful IEnumerable methods (sorting / bin->pkm / copy) to simplify some common operations change some explicit arrays to IList for flexibility remove old memecrypto bool (no longer necessary as XP is not supported) rename some methods for more clarity
2017-09-29 05:20:27 +00:00
return gender == PKX.GetGenderFromPIDAndRatio(PID, gv);
gender check update check gender correctly for transferred species
2017-03-25 07:01:02 +00:00
}
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
/// Updates the checksum of the <see cref="PKM"/>.
/// </summary>
Clarify mystery flags thanks pret! https://github.com/pret/pokeruby/blob/0ad332124e5bf57d0a43122616a77cd8c9318250/include/pokemon.h#L277-L279
2018-12-15 07:26:46 +00:00
public virtual void RefreshChecksum() => Checksum = CalculateChecksum();
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
/// Reorders moves and fixes PP if necessary.
/// </summary>
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
public void FixMoves()
Fix reorder moves and clear PP values for empty moves.
2016-08-21 16:09:22 +00:00
{
ReorderMoves();
misc refactoring simplification / splitting, also more usum prep and other readability updates
2017-10-18 06:19:34 +00:00
if (Move1 == 0) Move1_PP = Move1_PPUps = 0;
if (Move2 == 0) Move2_PP = Move2_PPUps = 0;
if (Move3 == 0) Move3_PP = Move3_PPUps = 0;
if (Move4 == 0) Move4_PP = Move4_PPUps = 0;
Fix reorder moves and clear PP values for empty moves.
2016-08-21 16:09:22 +00:00
}
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
/// Reorders moves to put Empty entries last.
/// </summary>
Fix reorder moves and clear PP values for empty moves.
2016-08-21 16:09:22 +00:00
private void ReorderMoves()
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
{
Misc updates reducing allocations, increasing clarity by removing some magic numbers probably can rewrite some of the evo loading/checking for even less, but good for now.
2019-01-07 00:22:45 +00:00
if (Move1 == 0 && Move2 != 0)
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
{
Misc updates reducing allocations, increasing clarity by removing some magic numbers probably can rewrite some of the evo loading/checking for even less, but good for now.
2019-01-07 00:22:45 +00:00
Move1 = Move2;
Move1_PP = Move2_PP;
Move1_PPUps = Move2_PPUps;
Move2 = 0;
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
}
Misc updates reducing allocations, increasing clarity by removing some magic numbers probably can rewrite some of the evo loading/checking for even less, but good for now.
2019-01-07 00:22:45 +00:00
if (Move2 == 0 && Move3 != 0)
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
{
Move2 = Move3;
Move2_PP = Move3_PP;
Move2_PPUps = Move3_PPUps;
Fix reorder moves and clear PP values for empty moves.
2016-08-21 16:09:22 +00:00
Move3 = 0;
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
}
Misc updates reducing allocations, increasing clarity by removing some magic numbers probably can rewrite some of the evo loading/checking for even less, but good for now.
2019-01-07 00:22:45 +00:00
if (Move3 == 0 && Move4 != 0)
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
{
Misc updates reducing allocations, increasing clarity by removing some magic numbers probably can rewrite some of the evo loading/checking for even less, but good for now.
2019-01-07 00:22:45 +00:00
Move3 = Move4;
Move3_PP = Move4_PP;
Move3_PPUps = Move4_PPUps;
Move4 = 0;
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
}
}
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
/// Applies the desired Ability option.
/// </summary>
/// <param name="n">Ability Number (0/1/2)</param>
Cleanup Use S/M met locations for Pokémon GO origin Changing to VC1 or GO now autofills met location Un-alphabetize RGBY games and move to end of games list (+go) Mark unused region names (Kanto string appears twice in text bank 3, 30013 is used) Move hypertraining stat toggling to pkm object shift 1->7 logic to repeat less operations add more 1->7 logic pertaining to memories add RefreshAbility method (0 based input, not 1/2/4)
2017-01-26 06:51:52 +00:00
public void RefreshAbility(int n)
{
AbilityNumber = 1 << n;
int[] abilities = PersonalInfo.Abilities;
if (n < abilities.Length)
Misc encounter->pkm generating fixes eggs for Gen1 must be generated in Gen2 gen1 wild encounter initial moves gen4 abilities have 0 for single ability mons
2018-04-28 23:30:56 +00:00
{
Fill empty ability values with ability1 update handling that checked for this case to instead check for equivalence to ability1 instead of 0 was generating a PGF with ability[1] = 0, which is not correct. Just fix the binaries to behave and get rid of all the workarounds since future tables don't have missing values.
2018-06-16 06:41:07 +00:00
if (abilities[n] == abilities[0])
Misc encounter->pkm generating fixes eggs for Gen1 must be generated in Gen2 gen1 wild encounter initial moves gen4 abilities have 0 for single ability mons
2018-04-28 23:30:56 +00:00
n = 0;
Cleanup Use S/M met locations for Pokémon GO origin Changing to VC1 or GO now autofills met location Un-alphabetize RGBY games and move to end of games list (+go) Mark unused region names (Kanto string appears twice in text bank 3, 30013 is used) Move hypertraining stat toggling to pkm object shift 1->7 logic to repeat less operations add more 1->7 logic pertaining to memories add RefreshAbility method (0 based input, not 1/2/4)
2017-01-26 06:51:52 +00:00
Ability = abilities[n];
Misc encounter->pkm generating fixes eggs for Gen1 must be generated in Gen2 gen1 wild encounter initial moves gen4 abilities have 0 for single ability mons
2018-04-28 23:30:56 +00:00
}
Refactoring & finish eevee test case generates a legal pk* for every possible encounter; there's likely other scenarios and more roughness to smooth out, but seems legit for now
2018-04-01 03:37:36 +00:00
if (this is PK5 pk5)
pk5.HiddenAbility = n == 2;
Cleanup Use S/M met locations for Pokémon GO origin Changing to VC1 or GO now autofills met location Un-alphabetize RGBY games and move to end of games list (+go) Mark unused region names (Kanto string appears twice in text bank 3, 30013 is used) Move hypertraining stat toggling to pkm object shift 1->7 logic to repeat less operations add more 1->7 logic pertaining to memories add RefreshAbility method (0 based input, not 1/2/4)
2017-01-26 06:51:52 +00:00
}
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
/// Gets the IV Judge Rating value.
/// </summary>
/// <remarks>IV Judge scales his response 0 (worst) to 3 (best).</remarks>
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
public int PotentialRating
{
get
{
Misc updates Add safari min flawless IVs to reroll (can expand if #2025 is required for egg group15) Use EV/IVTotal (faster, not linq array based) Fix missing pumpkaboo form regression, Closes #2026 Relocate swapbits to appropriate class, unneeded in PKM.cs
2018-06-22 13:24:33 +00:00
int ivTotal = IVTotal;
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
if (ivTotal <= 90)
return 0;
if (ivTotal <= 120)
return 1;
return ivTotal <= 150 ? 2 : 3;
}
}
Move stat calc to PKM object ref PersonalInfo entry to calculate from Fixes species with changed BST between gens. Worked fine before PKX Personal was split from SAV (to fix box report), this fixes by requiring the actual personal reference instead of looking it up.
2016-07-21 03:40:03 +00:00
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
/// Gets the current Battle Stats.
/// </summary>
/// <param name="p"><see cref="PersonalInfo"/> entry containing Base Stat Info</param>
/// <returns>Battle Stats (H/A/B/S/C/D)</returns>
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public virtual ushort[] GetStats(PersonalInfo p)
Move stat calc to PKM object ref PersonalInfo entry to calculate from Fixes species with changed BST between gens. Worked fine before PKX Personal was split from SAV (to fix box report), this fixes by requiring the actual personal reference instead of looking it up.
2016-07-21 03:40:03 +00:00
{
int level = CurrentLevel;
Remove variable naming hiding new property named Stats update sav7b/pb7 to delete unused handling trainer parameters too
2018-12-04 04:59:48 +00:00
ushort[] stats = this is IHyperTrain t ? GetStats(p, t, level) : GetStats(p, level);
Move stat calc to PKM object ref PersonalInfo entry to calculate from Fixes species with changed BST between gens. Worked fine before PKX Personal was split from SAV (to fix box report), this fixes by requiring the actual personal reference instead of looking it up.
2016-07-21 03:40:03 +00:00
// Account for nature
Remove variable naming hiding new property named Stats update sav7b/pb7 to delete unused handling trainer parameters too
2018-12-04 04:59:48 +00:00
PKX.ModifyStatsForNature(stats, Nature);
return stats;
Move stat calc to PKM object ref PersonalInfo entry to calculate from Fixes species with changed BST between gens. Worked fine before PKX Personal was split from SAV (to fix box report), this fixes by requiring the actual personal reference instead of looking it up.
2016-07-21 03:40:03 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Relocate hypertraining properties to interface lessen temp array creation, speed++
2018-06-06 04:31:42 +00:00
private ushort[] GetStats(PersonalInfo p, IHyperTrain t, int level)
{
Remove variable naming hiding new property named Stats update sav7b/pb7 to delete unused handling trainer parameters too
2018-12-04 04:59:48 +00:00
ushort[] stats = new ushort[6];
stats[0] = (ushort)(p.HP == 1 ? 1 : (((t.HT_HP ? 31 : IV_HP) + (2 * p.HP) + (EV_HP / 4) + 100) * level / 100) + 10);
stats[1] = (ushort)((((t.HT_ATK ? 31 : IV_ATK) + (2 * p.ATK) + (EV_ATK / 4)) * level / 100) + 5);
stats[2] = (ushort)((((t.HT_DEF ? 31 : IV_DEF) + (2 * p.DEF) + (EV_DEF / 4)) * level / 100) + 5);
stats[4] = (ushort)((((t.HT_SPA ? 31 : IV_SPA) + (2 * p.SPA) + (EV_SPA / 4)) * level / 100) + 5);
stats[5] = (ushort)((((t.HT_SPD ? 31 : IV_SPD) + (2 * p.SPD) + (EV_SPD / 4)) * level / 100) + 5);
stats[3] = (ushort)((((t.HT_SPE ? 31 : IV_SPE) + (2 * p.SPE) + (EV_SPE / 4)) * level / 100) + 5);
return stats;
Relocate hypertraining properties to interface lessen temp array creation, speed++
2018-06-06 04:31:42 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Relocate hypertraining properties to interface lessen temp array creation, speed++
2018-06-06 04:31:42 +00:00
private ushort[] GetStats(PersonalInfo p, int level)
{
Remove variable naming hiding new property named Stats update sav7b/pb7 to delete unused handling trainer parameters too
2018-12-04 04:59:48 +00:00
ushort[] stats = new ushort[6];
stats[0] = (ushort)(p.HP == 1 ? 1 : ((IV_HP + (2 * p.HP) + (EV_HP / 4) + 100) * level / 100) + 10);
stats[1] = (ushort)(((IV_ATK + (2 * p.ATK) + (EV_ATK / 4)) * level / 100) + 5);
stats[2] = (ushort)(((IV_DEF + (2 * p.DEF) + (EV_DEF / 4)) * level / 100) + 5);
stats[4] = (ushort)(((IV_SPA + (2 * p.SPA) + (EV_SPA / 4)) * level / 100) + 5);
stats[5] = (ushort)(((IV_SPD + (2 * p.SPD) + (EV_SPD / 4)) * level / 100) + 5);
stats[3] = (ushort)(((IV_SPE + (2 * p.SPE) + (EV_SPE / 4)) * level / 100) + 5);
return stats;
Relocate hypertraining properties to interface lessen temp array creation, speed++
2018-06-06 04:31:42 +00:00
}
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
/// Applies the specified stats to the <see cref="PKM"/>.
/// </summary>
Remove variable naming hiding new property named Stats update sav7b/pb7 to delete unused handling trainer parameters too
2018-12-04 04:59:48 +00:00
/// <param name="stats">Battle Stats (H/A/B/S/C/D)</param>
public void SetStats(ushort[] stats)
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
{
Remove variable naming hiding new property named Stats update sav7b/pb7 to delete unused handling trainer parameters too
2018-12-04 04:59:48 +00:00
Stat_HPMax = Stat_HPCurrent = stats[0];
Stat_ATK = stats[1];
Stat_DEF = stats[2];
Stat_SPE = stats[3];
Stat_SPA = stats[4];
Stat_SPD = stats[5];
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
}
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
Add more party related properties/methods
2019-01-12 18:54:38 +00:00
/// <summary>
/// Indicates if Party Stats are present. False if not initialized (from stored format).
/// </summary>
public bool PartyStatsPresent => Stat_HPMax != 0;
/// <summary>
/// Clears any status condition and refreshes the stats.
/// </summary>
Minor simplifications move some pk3->pk4 stuff into object constructor annotate pk3->pk4 string buffer (trash) quirks split Heal into Party/PP method uses. Setting suggested stats no longer refreshes PP apply current level to Stat Level (wasn't being set previously)
2019-07-12 23:41:13 +00:00
public void ResetPartyStats()
Add Heal, make status_condition a pkm property also split out battle box slot offset fetch if anyone finds where colo&xd store their status bits, lmk :+1:
2019-01-12 06:25:48 +00:00
{
SetStats(GetStats(PersonalInfo));
Minor simplifications move some pk3->pk4 stuff into object constructor annotate pk3->pk4 string buffer (trash) quirks split Heal into Party/PP method uses. Setting suggested stats no longer refreshes PP apply current level to Stat Level (wasn't being set previously)
2019-07-12 23:41:13 +00:00
Stat_Level = CurrentLevel;
Add Heal, make status_condition a pkm property also split out battle box slot offset fetch if anyone finds where colo&xd store their status bits, lmk :+1:
2019-01-12 06:25:48 +00:00
Status_Condition = 0;
Minor simplifications move some pk3->pk4 stuff into object constructor annotate pk3->pk4 string buffer (trash) quirks split Heal into Party/PP method uses. Setting suggested stats no longer refreshes PP apply current level to Stat Level (wasn't being set previously)
2019-07-12 23:41:13 +00:00
}
public void Heal()
{
ResetPartyStats();
Add PP Heal method
2019-02-21 06:08:28 +00:00
HealPP();
}
/// <summary>
/// Restores PP to maximum based on the current PP Ups for each move.
/// </summary>
public void HealPP()
{
Move1_PP = GetMovePP(Move1, Move1_PPUps);
Move2_PP = GetMovePP(Move2, Move2_PPUps);
Move3_PP = GetMovePP(Move3, Move3_PPUps);
Move4_PP = GetMovePP(Move4, Move4_PPUps);
Add Heal, make status_condition a pkm property also split out battle box slot offset fetch if anyone finds where colo&xd store their status bits, lmk :+1:
2019-01-12 06:25:48 +00:00
}
Add more party related properties/methods
2019-01-12 18:54:38 +00:00
/// <summary>
/// Enforces that Party Stat values are present.
/// </summary>
/// <returns>True if stats were refreshed, false if stats were already present.</returns>
public bool ForcePartyData()
{
if (PartyStatsPresent)
return false;
Minor simplifications move some pk3->pk4 stuff into object constructor annotate pk3->pk4 string buffer (trash) quirks split Heal into Party/PP method uses. Setting suggested stats no longer refreshes PP apply current level to Stat Level (wasn't being set previously)
2019-07-12 23:41:13 +00:00
ResetPartyStats();
Add more party related properties/methods
2019-01-12 18:54:38 +00:00
return true;
}
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
/// Checks if the <see cref="PKM"/> can hold its <see cref="HeldItem"/>.
/// </summary>
/// <param name="ValidArray">Items that the <see cref="PKM"/> can hold.</param>
/// <returns>True/False if the <see cref="PKM"/> can hold its <see cref="HeldItem"/>.</returns>
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
public virtual bool CanHoldItem(IReadOnlyList<ushort> ValidArray) => ValidArray.Contains((ushort)HeldItem);
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
/// Deep clones the <see cref="PKM"/> object. The clone will not have any shared resources with the source.
/// </summary>
/// <returns>Cloned <see cref="PKM"/> object</returns>
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
public abstract PKM Clone();
Add movepp tables for 3->6 Split from the PKX table (now removed); since PP differs between gens we have to keep track. Not gonna add a separate binary, just use a reference table.
2016-07-22 06:49:52 +00:00
Add gen4/5 synthetic trade logic was previously present for gen6 and gen7 only, resulting in eggs in gen4/5 not getting link trade values applied. that's really all. https://projectpokemon.org/home/forums/topic/44437-bug-eggs-transfer-for-gen-4-dppt-and-hgss/
2018-03-22 04:10:23 +00:00
/// <summary>
/// Sets Link Trade data for an <see cref="IsEgg"/>.
/// </summary>
/// <param name="day">Day the <see cref="PKM"/> was traded.</param>
/// <param name="month">Month the <see cref="PKM"/> was traded.</param>
/// <param name="y">Day the <see cref="PKM"/> was traded.</param>
/// <param name="location">Link Trade location value.</param>
Extract most common location numbers to class
2019-05-11 03:46:49 +00:00
protected void SetLinkTradeEgg(int day, int month, int y, int location)
Add gen4/5 synthetic trade logic was previously present for gen6 and gen7 only, resulting in eggs in gen4/5 not getting link trade values applied. that's really all. https://projectpokemon.org/home/forums/topic/44437-bug-eggs-transfer-for-gen-4-dppt-and-hgss/
2018-03-22 04:10:23 +00:00
{
Met_Day = day;
Met_Month = month;
Met_Year = y - 2000;
Met_Location = location;
}
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
/// Gets the PP of a Move ID with consideration of the amount of PP Ups applied.
/// </summary>
/// <param name="move">Move ID</param>
/// <param name="ppup">PP Ups count</param>
/// <returns>Current PP for the move.</returns>
Misc updates Move some logic around, fix style warnings
2018-10-27 15:53:09 +00:00
public virtual int GetMovePP(int move, int ppup) => GetBasePP(move) * (5 + ppup) / 5;
Add movepp tables for 3->6 Split from the PKX table (now removed); since PP differs between gens we have to keep track. Not gonna add a separate binary, just use a reference table.
2016-07-22 06:49:52 +00:00
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
/// Gets the base PP of a move ID depending on the <see cref="PKM"/>'s format.
/// </summary>
/// <param name="move">Move ID</param>
/// <returns>Amount of PP the move has by default (no PP Ups).</returns>
Misc updates Move some logic around, fix style warnings
2018-10-27 15:53:09 +00:00
private int GetBasePP(int move)
Add movepp tables for 3->6 Split from the PKX table (now removed); since PP differs between gens we have to keep track. Not gonna add a separate binary, just use a reference table.
2016-07-22 06:49:52 +00:00
{
Add pkm variant for beluga
2018-11-14 03:10:31 +00:00
var pptable = Legal.GetPPTable(this, Format);
Misc updates Move some logic around, fix style warnings
2018-10-27 15:53:09 +00:00
if (move >= pptable.Count)
Add movepp tables for 3->6 Split from the PKX table (now removed); since PP differs between gens we have to keep track. Not gonna add a separate binary, just use a reference table.
2016-07-22 06:49:52 +00:00
move = 0;
return pptable[move];
}
Move shiny PID creation to PKM class
2016-07-29 05:33:16 +00:00
Add batch edit pk1/2 .PID=$shiny Closes #1419
2017-08-26 00:44:15 +00:00
/// <summary>
/// Applies a shiny <see cref="PID"/> to the <see cref="PKM"/>.
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// </summary>
/// <remarks>
/// If a <see cref="PKM"/> originated in a generation prior to Generation 6, the <see cref="EncryptionConstant"/> is updated.
Misc updates Move some logic around, fix style warnings
2018-10-27 15:53:09 +00:00
/// If a <see cref="PKM"/> is in the <see cref="_K12"/> format, it will update the <see cref="IVs"/> instead.
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// </remarks>
Misc updates Move some logic around, fix style warnings
2018-10-27 15:53:09 +00:00
public virtual void SetShiny()
Move shiny PID creation to PKM class
2016-07-29 05:33:16 +00:00
{
Misc updates Move some logic around, fix style warnings
2018-10-27 15:53:09 +00:00
while (!IsShiny)
PID = PKX.GetRandomPID(Species, Gender, Version, Nature, AltForm, PID);
Misc reductions hide setters for LegalInfo outside assembly (shouldn't overwrite the stored values) update GenNumber to Gen* if appropriate; GenNumber checks for first Gen* to match, is a little more explicit and quicker than calling twice when checking a range
2019-02-22 04:41:04 +00:00
if (Format >= 6 && (Gen3 || Gen4 || Gen5))
Improve batch randomization allow .EncryptionConstant=PID improve .PID=$rand to use random PID method instead of pure rand switch comparisons to match command appearance in richtextbox
2016-08-15 06:23:38 +00:00
EncryptionConstant = PID;
Move shiny PID creation to PKM class
2016-07-29 05:33:16 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
Add batch edit pk1/2 .PID=$shiny Closes #1419
2017-08-26 00:44:15 +00:00
/// Applies a shiny <see cref="SID"/> to the <see cref="PKM"/>.
Add Control key modifier to set shiny button to change the pokemon SID instead of the PID, that allow the change shiny of gen 3/4 pokemon without turn the pokemon in illegal because PID/IV mistmatch Added Cherrygrove City to surf headbutt encounter locations, the upper right trees on the map can be reach from the water in route 30
2017-06-03 10:02:22 +00:00
/// </summary>
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public void SetShinySID()
Add Control key modifier to set shiny button to change the pokemon SID instead of the PID, that allow the change shiny of gen 3/4 pokemon without turn the pokemon in illegal because PID/IV mistmatch Added Cherrygrove City to surf headbutt encounter locations, the upper right trees on the map can be reach from the water in route 30
2017-06-03 10:02:22 +00:00
{
if (IsShiny) return;
Simplify Shiny SID creation calculates a passing SID and applies random bits to not be too predictable no need to bruteforce
2017-06-03 15:58:30 +00:00
var xor = TID ^ (PID >> 16) ^ (PID & 0xFFFF);
Remove excessive references to Util.Rand32() all usages besides fetching a 32bit random value should use rand.next remove unnecessary do-while loop for calculating random EVs (always returns 510 in total)
2018-07-04 18:30:43 +00:00
SID = (int)(xor & 0xFFF8) | Util.Rand.Next(8);
Add Control key modifier to set shiny button to change the pokemon SID instead of the PID, that allow the change shiny of gen 3/4 pokemon without turn the pokemon in illegal because PID/IV mistmatch Added Cherrygrove City to surf headbutt encounter locations, the upper right trees on the map can be reach from the water in route 30
2017-06-03 10:02:22 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add Control key modifier to set shiny button to change the pokemon SID instead of the PID, that allow the change shiny of gen 3/4 pokemon without turn the pokemon in illegal because PID/IV mistmatch Added Cherrygrove City to surf headbutt encounter locations, the upper right trees on the map can be reach from the water in route 30
2017-06-03 10:02:22 +00:00
/// <summary>
Add batch edit pk1/2 .PID=$shiny Closes #1419
2017-08-26 00:44:15 +00:00
/// Applies a <see cref="PID"/> to the <see cref="PKM"/> according to the specified <see cref="Gender"/>.
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// </summary>
Refactoring more discards & simplifications
2018-05-12 19:28:48 +00:00
/// <param name="gender"><see cref="Gender"/> to apply</param>
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <remarks>
/// If a <see cref="PKM"/> originated in a generation prior to Generation 6, the <see cref="EncryptionConstant"/> is updated.
/// </remarks>
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public void SetPIDGender(int gender)
Add nature/gender recalc PID on <=gen4
2016-07-29 05:54:29 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
do PID = PKX.GetRandomPID(Species, gender, Version, Nature, AltForm, PID); while (IsShiny);
Misc reductions hide setters for LegalInfo outside assembly (shouldn't overwrite the stored values) update GenNumber to Gen* if appropriate; GenNumber checks for first Gen* to match, is a little more explicit and quicker than calling twice when checking a range
2019-02-22 04:41:04 +00:00
if (Format >= 6 && (Gen3 || Gen4 || Gen5))
Improve batch randomization allow .EncryptionConstant=PID improve .PID=$rand to use random PID method instead of pure rand switch comparisons to match command appearance in richtextbox
2016-08-15 06:23:38 +00:00
EncryptionConstant = PID;
Tweak random PID gen on changing fields Fixes quirky behavior of changing nature/gender on gen3/4 games.
2016-07-30 05:30:06 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
Add batch edit pk1/2 .PID=$shiny Closes #1419
2017-08-26 00:44:15 +00:00
/// Applies a <see cref="PID"/> to the <see cref="PKM"/> according to the specified <see cref="Gender"/>.
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// </summary>
Refactoring more discards & simplifications
2018-05-12 19:28:48 +00:00
/// <param name="nature"><see cref="Nature"/> to apply</param>
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <remarks>
/// If a <see cref="PKM"/> originated in a generation prior to Generation 6, the <see cref="EncryptionConstant"/> is updated.
/// </remarks>
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public void SetPIDNature(int nature)
Tweak random PID gen on changing fields Fixes quirky behavior of changing nature/gender on gen3/4 games.
2016-07-30 05:30:06 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
do PID = PKX.GetRandomPID(Species, Gender, Version, nature, AltForm, PID); while (IsShiny);
Misc reductions hide setters for LegalInfo outside assembly (shouldn't overwrite the stored values) update GenNumber to Gen* if appropriate; GenNumber checks for first Gen* to match, is a little more explicit and quicker than calling twice when checking a range
2019-02-22 04:41:04 +00:00
if (Format >= 6 && (Gen3 || Gen4 || Gen5))
Improve batch randomization allow .EncryptionConstant=PID improve .PID=$rand to use random PID method instead of pure rand switch comparisons to match command appearance in richtextbox
2016-08-15 06:23:38 +00:00
EncryptionConstant = PID;
Add nature/gender recalc PID on <=gen4
2016-07-29 05:54:29 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
Add batch edit pk1/2 .PID=$shiny Closes #1419
2017-08-26 00:44:15 +00:00
/// Applies a <see cref="PID"/> to the <see cref="PKM"/> according to the specified <see cref="AltForm"/>.
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// </summary>
Refactoring more discards & simplifications
2018-05-12 19:28:48 +00:00
/// <param name="form"><see cref="AltForm"/> to apply</param>
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <remarks>
/// This method should only be used for Unown originating in Generation 3 games.
/// If a <see cref="PKM"/> originated in a generation prior to Generation 6, the <see cref="EncryptionConstant"/> is updated.
/// </remarks>
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public void SetPIDUnown3(int form)
Fix gen3 unown form change Thanks NinFanBoyFTW!
2016-08-28 01:42:07 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
do PID = Util.Rand32(); while (PKX.GetUnownForm(PID) != form);
Misc reductions hide setters for LegalInfo outside assembly (shouldn't overwrite the stored values) update GenNumber to Gen* if appropriate; GenNumber checks for first Gen* to match, is a little more explicit and quicker than calling twice when checking a range
2019-02-22 04:41:04 +00:00
if (Format >= 6 && (Gen3 || Gen4 || Gen5))
Check EC-PID same for gen1/2 transfers Fix PID->EC on gen<3 transfers https://projectpokemon.org/home/forums/topic/43779-about-vc-pokemons-pid-and-encryptionconstant/
2018-02-09 02:47:52 +00:00
EncryptionConstant = PID;
Fix gen3 unown form change Thanks NinFanBoyFTW!
2016-08-28 01:42:07 +00:00
}
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
/// <summary>
/// Randomizes the IVs within game constraints.
/// </summary>
Refactoring more discards & simplifications
2018-05-12 19:28:48 +00:00
/// <param name="flawless">Count of flawless IVs to set. If none provided, a count will be detected.</param>
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
/// <returns>Randomized IVs if desired.</returns>
misc quality of life improvements set egg friendship allow SetRandomIVs to use a minimum fixed IV count
2018-03-29 03:56:58 +00:00
public int[] SetRandomIVs(int? flawless = null)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
Add go random IVs method https://projectpokemon.org/home/forums/topic/48779-go-park-melmetal/
2018-12-13 02:06:39 +00:00
if (Version == (int)GameVersion.GO && flawless != 6)
return SetRandomIVsGO();
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
int[] ivs = new int[6];
for (int i = 0; i < 6; i++)
Remove excessive references to Util.Rand32() all usages besides fetching a 32bit random value should use rand.next remove unnecessary do-while loop for calculating random EVs (always returns 510 in total)
2018-07-04 18:30:43 +00:00
ivs[i] = Util.Rand.Next(MaxIV + 1);
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
misc quality of life improvements set egg friendship allow SetRandomIVs to use a minimum fixed IV count
2018-03-29 03:56:58 +00:00
int count = flawless ?? GetFlawlessIVCount();
random IVs with specified count Closes #1553 removes duplicate logic in batch editor
2017-11-02 16:05:44 +00:00
if (count != 0)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
{
random IVs with specified count Closes #1553 removes duplicate logic in batch editor
2017-11-02 16:05:44 +00:00
for (int i = 0; i < count; i++)
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
ivs[i] = MaxIV;
Util.Shuffle(ivs); // Randomize IV order
}
Add go random IVs method https://projectpokemon.org/home/forums/topic/48779-go-park-melmetal/
2018-12-13 02:06:39 +00:00
return IVs = ivs;
}
random IVs with specified count Closes #1553 removes duplicate logic in batch editor
2017-11-02 16:05:44 +00:00
Add go random IVs method https://projectpokemon.org/home/forums/topic/48779-go-park-melmetal/
2018-12-13 02:06:39 +00:00
private int[] SetRandomIVsGO()
{
int[] ivs = new int[6];
ivs[0] = (Util.Rand.Next(16) << 1) | 1; // hp
ivs[1] = ivs[4] = (Util.Rand.Next(16) << 1) | 1; // attack
ivs[2] = ivs[5] = (Util.Rand.Next(16) << 1) | 1; // defense
ivs[3] = Util.Rand.Next(MaxIV + 1); // speed
return IVs = ivs;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
}
random IVs with specified count Closes #1553 removes duplicate logic in batch editor
2017-11-02 16:05:44 +00:00
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
/// <summary>
/// Randomizes the IVs within game constraints.
/// </summary>
Refactoring more discards & simplifications
2018-05-12 19:28:48 +00:00
/// <param name="template">IV template to generate from</param>
/// <param name="flawless">Count of flawless IVs to set. If none provided, a count will be detected.</param>
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
/// <returns>Randomized IVs if desired.</returns>
public int[] SetRandomIVs(int[] template, int? flawless = null)
{
int count = flawless ?? GetFlawlessIVCount();
int[] ivs = new int[6];
do
{
for (int i = 0; i < 6; i++)
Remove excessive references to Util.Rand32() all usages besides fetching a 32bit random value should use rand.next remove unnecessary do-while loop for calculating random EVs (always returns 510 in total)
2018-07-04 18:30:43 +00:00
ivs[i] = template[i] < 0 ? Util.Rand.Next(MaxIV + 1) : template[i];
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
} while (ivs.Count(z => z == MaxIV) < count);
More generator updates all the way up to nidorina extract some reusable methods exclude invalid headbutt encounters use built in randomgender
2018-04-30 01:26:36 +00:00
IVs = ivs;
Add other iencounterable->pkm generators not tested
2018-03-31 07:43:41 +00:00
return ivs;
}
random IVs with specified count Closes #1553 removes duplicate logic in batch editor
2017-11-02 16:05:44 +00:00
/// <summary>
/// Gets the amount of flawless IVs that the <see cref="PKM"/> should have.
/// </summary>
/// <returns>Count of IVs that should be max.</returns>
public int GetFlawlessIVCount()
{
if (GenNumber >= 6 && (Legal.Legends.Contains(Species) || Legal.SubLegends.Contains(Species)))
return 3;
Add XY wild undiscovered egg group IV check Closes #2025 add misc updates/simplifications (personal stuff used in pkNX)
2018-06-25 04:55:00 +00:00
if (XY)
{
Misc updates Move some logic around, fix style warnings
2018-10-27 15:53:09 +00:00
if (Met_Location == 148 && Met_Level == 30) // Friend Safari
Add XY wild undiscovered egg group IV check Closes #2025 add misc updates/simplifications (personal stuff used in pkNX)
2018-06-25 04:55:00 +00:00
return 2;
if (PersonalInfo.EggGroup1 == 15) // Undiscovered
return 3;
}
random IVs with specified count Closes #1553 removes duplicate logic in batch editor
2017-11-02 16:05:44 +00:00
if (VC)
return Species == 151 || Species == 251 ? 5 : 3;
return 0;
}
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// <summary>
Fix backwards conversion copy order reflection (now only used for backwards conversion) will use destination order instead of source order so that the destination can order itself for quirks redo method call (probably breaks someone if they update, maybe pk2pk)
2018-02-03 23:32:45 +00:00
/// Applies all shared properties from the current <see cref="PKM"/> to <see cref="Destination"/> <see cref="PKM"/>.
Refactoring Add documentation for PKM/PKX, move some code around
2017-02-05 02:27:28 +00:00
/// </summary>
/// <param name="Destination"><see cref="PKM"/> that receives property values.</param>
Fix backwards conversion copy order reflection (now only used for backwards conversion) will use destination order instead of source order so that the destination can order itself for quirks redo method call (probably breaks someone if they update, maybe pk2pk)
2018-02-03 23:32:45 +00:00
public void TransferPropertiesWithReflection(PKM Destination)
Add C/XD transferring reflection is neat when making c/xd format, recalculate stats
2016-10-02 17:18:31 +00:00
{
Update reflection property fetching Closes #919 Properties fetched would return PKM.cs properties (not declared in XK3 or PK3), such as Hidden Power Type. The setter for Hidden Power type is unused everywhere, but was called via reflection on transfer away from xk3/ck3 format. This caused IVs to be tampered with in most cases. By only fetching Declared properties (ie, within XK3.cs only), only the 'real' shared properties will be transferred. Extending this to the batch editor, we can use this Declared-only filtering to grab more pkm formats. While things are being updated, throw in pk1/pk2/bk4/ck3/xk3 formats to the dropdown.
2017-03-03 05:00:41 +00:00
// Only transfer declared properties not defined in PKM.cs but in the actual type
Fix incompatible hax conversion (1/2->3 etc) error Shared base classes throw a new snag, where the property may be Declared in the shared class. eg: PKM -> _K12 -> PK2 just filter all public ones that have a setter; works well enough idk
2019-05-28 23:52:59 +00:00
var src_t = GetType();
var dst_t = Destination.GetType();
var SourceProperties = ReflectUtil.GetAllPropertyInfoPublic(src_t).Select(z => z.Name);
var DestinationProperties = ReflectUtil.GetAllPropertyInfoPublic(dst_t).Where(z => z.SetMethod != null).Select(z => z.Name);
Fix backwards conversion copy order reflection (now only used for backwards conversion) will use destination order instead of source order so that the destination can order itself for quirks redo method call (probably breaks someone if they update, maybe pk2pk)
2018-02-03 23:32:45 +00:00
// Transfer properties in the order they are defined in the destination PKM format for best conversion
var shared = DestinationProperties.Intersect(SourceProperties);
foreach (string property in shared)
Add C/XD transferring reflection is neat when making c/xd format, recalculate stats
2016-10-02 17:18:31 +00:00
{
Fix incompatible hax conversion (1/2->3 etc) error Shared base classes throw a new snag, where the property may be Declared in the shared class. eg: PKM -> _K12 -> PK2 just filter all public ones that have a setter; works well enough idk
2019-05-28 23:52:59 +00:00
BatchEditing.TryGetHasProperty(this, property, out var src);
Move batch editor logic to core previous hurdle a year ago was propertyinfo fetching not looking at the base class's properties; dig deeper for all properties to mimic existing code for netframework end result is batch editing now possible without gui
2018-05-18 05:43:07 +00:00
var prop = src.GetValue(this);
if (prop != null && !(prop is byte[]) && BatchEditing.TryGetHasProperty(Destination, property, out var pi))
ReflectUtil.SetValue(pi, Destination, prop);
Add C/XD transferring reflection is neat when making c/xd format, recalculate stats
2016-10-02 17:18:31 +00:00
}
}
Clear gen2 exclusive moves on pk2->pk1 Closes #1214
2017-06-10 15:31:31 +00:00
/// <summary>
/// Clears moves that a <see cref="PKM"/> may have, possibly from a future generation.
/// </summary>
public void ClearInvalidMoves()
{
uint invalid = 0;
var moves = Moves;
for (var i = 0; i < moves.Length; i++)
{
if (moves[i] <= MaxMoveID)
continue;
invalid++;
moves[i] = 0;
}
if (invalid == 0)
return;
Ensure cleared move pkms have at least 1 move #1214 user may not be checking legality (bulk transfer)
2017-06-10 15:39:04 +00:00
if (invalid == 4) // no moves remain
{
moves[0] = 1; // Pound
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
Move1_PP = GetMovePP(1, Move1_PPUps);
Ensure cleared move pkms have at least 1 move #1214 user may not be checking legality (bulk transfer)
2017-06-10 15:39:04 +00:00
}
Clear gen2 exclusive moves on pk2->pk1 Closes #1214
2017-06-10 15:31:31 +00:00
Moves = moves;
FixMoves();
}
Move GetIV to pkm, misc simplifications remove linq for characteristic calc (get max IV) and others remove some reliance on new[] for iv/ev pk5 replace bitmagic with property get->set copy for cleanliness
2019-01-05 18:51:41 +00:00
/// <summary>
/// Gets one of the <see cref="EVs"/> based on its index within the array.
/// </summary>
/// <param name="index">Index to get</param>
public int GetEV(int index)
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
return index switch
Move GetIV to pkm, misc simplifications remove linq for characteristic calc (get max IV) and others remove some reliance on new[] for iv/ev pk5 replace bitmagic with property get->set copy for cleanliness
2019-01-05 18:51:41 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
0 => EV_HP,
1 => EV_ATK,
2 => EV_DEF,
3 => EV_SPE,
4 => EV_SPA,
5 => EV_SPD,
_ => throw new ArgumentOutOfRangeException(nameof(index))
};
Move GetIV to pkm, misc simplifications remove linq for characteristic calc (get max IV) and others remove some reliance on new[] for iv/ev pk5 replace bitmagic with property get->set copy for cleanliness
2019-01-05 18:51:41 +00:00
}
/// <summary>
/// Gets one of the <see cref="IVs"/> based on its index within the array.
/// </summary>
/// <param name="index">Index to get</param>
public int GetIV(int index)
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
return index switch
Move GetIV to pkm, misc simplifications remove linq for characteristic calc (get max IV) and others remove some reliance on new[] for iv/ev pk5 replace bitmagic with property get->set copy for cleanliness
2019-01-05 18:51:41 +00:00
{
Use some c#8 sugar static local functions switch expressions using usings :) nullable next?
2019-10-08 01:40:09 +00:00
0 => IV_HP,
1 => IV_ATK,
2 => IV_DEF,
3 => IV_SPE,
4 => IV_SPA,
5 => IV_SPD,
_ => throw new ArgumentOutOfRangeException(nameof(index))
};
Move GetIV to pkm, misc simplifications remove linq for characteristic calc (get max IV) and others remove some reliance on new[] for iv/ev pk5 replace bitmagic with property get->set copy for cleanliness
2019-01-05 18:51:41 +00:00
}
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
}
}
Reference in a new issue Copy permalink