Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2025-02-16 21:38:40 +00:00
Code Issues Projects Releases Packages Wiki Activity

Simplify Shiny SID creation

Browse source 
calculates a passing SID and applies random bits to not be too
predictable
no need to bruteforce
This commit is contained in:
Kurt 2017-06-03 08:58:30 -07:00
parent 5b699a4771
commit 32deb3879a
3 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
PKHeX.Core/PKM/PKM.cs
View file

@ -772,7 +772,8 @@ namespace PKHeX.Core
public void setShinySID()
{
if (IsShiny) return;
do SID = Util.rnd16(); while (!IsShiny);
var xor = TID ^ (PID >> 16) ^ (PID & 0xFFFF);
SID = (int)((xor & 0xFFF8) | (Util.rnd32() & 7));
}
/// <summary>
/// Applies a PID to the <see cref="PKM"/> according to the specified <see cref="Gender"/>.

4
PKHeX.Core/Util/RandUtil.cs
View file

@ -9,10 +9,6 @@ namespace PKHeX.Core
{
return (uint)rand.Next(1 << 30) << 2 | (uint)rand.Next(1 << 2);
}
internal static ushort rnd16()
{
return (ushort)rand.Next(ushort.MaxValue);
}
public static void Shuffle<T>(T[] array)
{
int n = array.Length;

2
PKHeX.WinForms/Controls/PKM Editor/PKMEditor.cs
View file

@ -1487,7 +1487,7 @@ namespace PKHeX.WinForms.Controls
if (pkm.Format > 2)
{
if(PID)
if (PID)
{
pkm.setShinyPID();
TB_PID.Text = pkm.PID.ToString("X8");