rust-clippy

mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-21 10:33:27 +00:00

Author	SHA1	Message	Date
Philipp Hansch	041c49c1ed	Merge pull request #3257 from o01eg/remove-sysroot Don't try to determine sysroot. rustc_driver will use default value.	2018-12-06 22:11:29 +01:00
Philipp Hansch	c4ef06a9b6	Merge pull request #3497 from daxpedda/master Fix bug in `implicit_return`.	2018-12-06 14:13:20 +01:00
daxpedda	973d676cd1	Fix bug in `implicit_return`. Bug was already covered by test, but test was not checked for.	2018-12-06 12:22:54 +01:00
O01eg	278b94e6db	Fix format.	2018-12-06 13:46:23 +03:00
O01eg	5113de90d1	Add sysroot gettinh code to dogfood tests.	2018-12-06 13:21:45 +03:00
Felix Kohlgrüber	a8a0b236b5	fix #3482 and add ui test for it	2018-12-06 11:07:10 +01:00
O01eg	571d4cc7bf	Add sysroot getting code to tests.	2018-12-06 12:23:47 +03:00
Philipp Hansch	f93591294d	Merge pull request #3494 from daxpedda/master Added `IMPLICIT_RETURN` lint.	2018-12-06 07:12:01 +01:00
Wayne Warren	0442bb9ce0	Don't change current working directory of cargo tests	2018-12-05 18:18:17 -06:00
Wayne Warren	87d517df5d	Use cargo's "PROFILE" envvar and set CLIPPY_DOGFOOD	2018-12-05 18:18:17 -06:00
Wayne Warren	66251c3ece	Use dogfood_runner for deterministic test ordering	2018-12-05 18:18:17 -06:00
Wayne Warren	72247d8e2e	Fix dogfood tests.	2018-12-05 18:18:17 -06:00
daxpedda	aed2b986e6	Renamed to `implicit_return`. Covered all other kinds besides `ExprKind::Lit`. Added check for replacing `break` with `return`.	2018-12-05 14:39:09 +01:00
daxpedda	978f8c65ee	Renamed `forced_return` to `missing_returns`. Better clarification in the docs. Ran `update_lints`.	2018-12-05 10:54:21 +01:00
daxpedda	d5d6692288	Added `FORCED_RETURN` lint.	2018-12-05 01:59:09 +01:00
Philipp Krones	3f24cdf10f	Merge pull request #3490 from phansch/extract_single_match_else_ui_test Extract single_match_else UI test	2018-12-04 14:57:19 +01:00
Philipp Hansch	68bb900eba	Merge pull request #3473 from lucasloisp/additional-bool-comparisons Adds inequality cases to bool comparison (#3438)	2018-12-04 07:26:29 +01:00
Philipp Hansch	3f72d4d630	Extract single_match_else UI test There's only one test currently. I also updated the lint doc with a 'good' example and changed the lint help text a bit. cc #2038	2018-12-04 07:20:13 +01:00
Lucas Lois	3930148059	Adds inequality cases to bool comparison lint The lint now checks cases like `y != true`	2018-12-03 16:32:11 -03:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	c00210d7ba	Merge pull request #3478 from dtolnay/setlen Remove unsafe_vector_initialization lint	2018-12-03 12:42:31 +01:00
David Tolnay	e632a1946e	Remove unsafe_vector_initialization lint	2018-12-03 02:48:37 -08:00
David Tolnay	1a14cb3643	Keep testing large_digit_groups as ui test	2018-12-01 17:23:53 -08:00
David Tolnay	67f9d24c1b	Keep testing unsafe_vector_initialization as ui test	2018-12-01 17:19:39 -08:00
flip1995	2953ae0702	Run rustfmt on the tests	2018-11-27 21:11:50 +01:00
flip1995	0c6483bf21	Update stderr file	2018-11-27 15:29:23 +01:00
Guillem Nieto	5fa04bc3cd	Lint only the first statment/expression after alloc Instead of searching for all the successive expressions after a vector allocation, check only the first expression. This is done to minimize the amount of false positives of the lint.	2018-11-25 14:34:23 -08:00
Guillem Nieto	5b77ee95dc	Rename some symbols Renamed some symbols in order to make them a little bit more accurate.	2018-11-25 14:34:23 -08:00
Guillem Nieto	2753f1cbd4	Split lint into slow and unsafe vector initalization	2018-11-25 14:34:23 -08:00
Guillem Nieto	9b4bc3b6ef	Add unsafe set_len initialization	2018-11-25 14:34:23 -08:00
Guillem Nieto	e0ccc9d9af	Add slow zero-filled vector initialization lint Add lint to detect slow zero-filled vector initialization. It detects when a vector is zero-filled with extended with `repeat(0).take(len)` or `resize(len, 0)`. This zero-fillings are usually slower than simply using `vec![0; len]`.	2018-11-25 14:34:23 -08:00
Matthias Krüger	f5929e0797	rust-lang-nursery/rust-clippy => rust-lang/rust-clippy	2018-11-22 04:40:09 +01:00
Wayne Warren	ca4803101f	Update trivially_copy_pass_by_ref with Trait stderr output	2018-11-21 07:52:02 -06:00
Wayne Warren	67c32eb2c4	Update trivially_copy_pass_by_ref with Trait examples	2018-11-21 07:52:02 -06:00
flip1995	655a2b4709	Add regression test	2018-11-15 17:06:36 +01:00
Michael Wright	e2e892b59b	Fix wrong suggestion for `redundant_closure_call` Fixes #1684	2018-11-14 08:01:39 +02:00
Michael Wright	5ade9ff44e	Fix `use_self` false positive on `use` statements	2018-11-13 06:15:33 +02:00
Michael Wright	460c2b317b	Fix `use_self` false positive This fixes the first error reported in issue #3410.	2018-11-10 10:57:11 +02:00
Michael Wright	2353f24095	Merge branch 'master' into fix-missing-comma-fp	2018-11-06 07:00:54 +02:00
bors[bot]	7e417d4cbd	Merge #3353 3353: float support added for mistyped_literal_suffixes lint r=mikerite a=Maxgy I implemented the mistyped_literal_suffixes lint for float literals. ``` #![allow(unused_variables)] fn main() { let x = 1E2_32; let x = 75.22_64; } ``` Given the above, the additional check suggests the variables to be written as `let x = 1E2_f32` and `let x = 75.22_f64`. Fixes #3167 Co-authored-by: Maxwell Anderson <maxwell.brayden.anderson@gmail.com>	2018-11-05 03:58:15 +00:00
Michael Wright	0c1ffc1d1f	Fix `possible_missing_comma` false positives `possible_missing_comma` should only trigger when the binary operator has unary equivalent. Otherwise, it's not possible to insert a comma without breaking compilation. The operators identified were `+`, `&`, `*` and `-`. This fixes the specific examples given in issues #3244 and #3396 but doesn't address the conflict this lint has with the style of starting a line with a binary operator.	2018-11-04 10:02:49 +02:00
bors[bot]	486300b89d	Merge #3400 3400: Fix a false-positive of needless_borrow r=phansch a=sinkuu Co-authored-by: Shotaro Yamada <sinkuu@sinkuu.xyz>	2018-11-03 08:34:13 +00:00
flip1995	318f84ffcf	Update stderr	2018-11-02 19:50:24 +01:00
flip1995	5c1385249e	Rename test files	2018-11-02 19:50:24 +01:00
flip1995	7df7a0a86e	Add tests from rustfmt::skip test file	2018-11-02 19:50:24 +01:00
flip1995	352da1d33d	Add test for non-crate-level inner attributes	2018-11-02 19:49:58 +01:00
flip1995	7bd8c303d3	Add tests	2018-11-02 19:49:58 +01:00
kennytm	2d1c9313b0	Added lints `into_iter_on_ref` and `into_iter_on_array`. Fix #1565 .	2018-11-02 22:53:56 +08:00
flip1995	faa1db3391	Update stderr	2018-11-02 13:49:10 +01:00
flip1995	4e1102f56c	Add copyright statement©	2018-11-02 13:49:10 +01:00
flip1995	ea4a80f215	Fix typo and indentation	2018-11-02 13:49:10 +01:00
flip1995	8d516b36fe	Add tests for unknwon_clippy_lints lint	2018-11-02 13:49:09 +01:00
Matthias Krüger	df7cff31dc	clippy: fix pedantic warnings and run clippy::pedantic lints on the codebase. Turn on pedantic lints in dogfood and base tests. needless_bool: fix clippy::items-after-statements redundant_pattern_matching: fix clippy::similar-names mods.rs: fix clippy::explicit-iter-loop returns.rs: allow clippy::cast-possible-wrap Fixes #3172	2018-11-02 12:16:43 +01:00
bors[bot]	ae137d526c	Merge #3397 #3398 3397: UI test cleanup: Extract expect_fun_call tests r=matthiaskrgr a=phansch Note that the new stderr file does not include a `shadow-unrelated` error, because the new UI test file does not use `#![warn(clippy::all)]` cc #2038 3398: UI test cleanup: Extract match_overlapping_arm tests r=matthiaskrgr a=phansch cc #2038 Co-authored-by: Philipp Hansch <dev@phansch.net>	2018-11-02 07:34:38 +00:00
Shotaro Yamada	d4370f8b07	Fix a false-positive of needless_borrow	2018-11-02 15:58:54 +09:00
Philipp Hansch	e5af43d426	UI test cleanup: Extract match_overlapping_arm tests	2018-11-02 07:19:30 +01:00
Philipp Hansch	26569f3dde	UI test cleanup: Extract expect_fun_call tests Note that the new stderr file does not include a `shadow-unrelated` error, because the new UI test file does not use `#![warn(clippy::all)]`	2018-11-02 07:18:56 +01:00
Maxwell Anderson	3c22b2314c	Merge remote-tracking branch 'upstream/master'	2018-10-31 16:48:47 -06:00
bors[bot]	6a165e5a92	Merge #3392 3392: UI test cleanup: Extract for_loop_over_x tests r=matthiaskrgr a=phansch cc #2038 Co-authored-by: Philipp Hansch <dev@phansch.net>	2018-10-31 21:08:34 +00:00
bors[bot]	c8308c92b6	Merge #3378 3378: Fix lint_without_lint_pass r=phansch a=mikerite Co-authored-by: Michael Wright <mikerite@lavabit.com> Co-authored-by: flip1995 <hello@philkrones.com>	2018-10-31 07:18:42 +00:00
bors[bot]	b144c7f35d	Merge #3370 3370: bool_comparison triggers 3 times on same code r=phansch a=mrbuzz Fix #3335 Co-authored-by: Giorgio Gambino <gambnio.giorgio@gmail.com>	2018-10-31 06:48:49 +00:00
Philipp Hansch	b421f5ad48	UI test cleanup: Extract for_loop_over_x tests	2018-10-30 21:25:34 +01:00
flip1995	3d84ffb5ec	Update .stderr file	2018-10-29 20:55:52 +01:00
flip1995	a7fc6799df	Rewrite registered lint collection	2018-10-29 20:44:45 +01:00
Michael Wright	267d5d3433	Fix lint_without_lint_pass	2018-10-29 20:28:06 +01:00
Matthias Krüger	be7656d992	compiletest: clean rmeta data (from "cargo check") before running compiletest. Fixes #2896 Fixes #2139	2018-10-29 12:29:40 +01:00
bors[bot]	00ed70526a	Merge #3373 3373: UI test cleanup: Extract unnecessary_operation tests r=matthiaskrgr a=phansch cc #2038 Co-authored-by: Philipp Hansch <dev@phansch.net>	2018-10-28 22:52:21 +00:00
Philipp Hansch	18b122005f	UI test cleanup: Extract explicit_counter_loop tests	2018-10-28 18:56:49 +01:00
Philipp Hansch	7adc8dc956	UI test cleanup: Extract unnecessary_operation tests	2018-10-28 18:40:29 +01:00
bors[bot]	14d2700b6f	Merge #3217 #3366 3217: Fix string_lit_as_bytes lint for macros r=phansch a=yaahallo Prior to this change, string_lit_as_bytes would trigger for constructs like `include_str!("filename").as_bytes()` and would recommend fixing it by rewriting as `binclude_str!("filename")`. This change updates the lint to act as an EarlyLintPass lint. It then differentiates between string literals and macros that have bytes yielding alternatives. Closes #3205 3366: Don't expand macros in some suggestions r=oli-obk a=phansch Fixes #1148 Fixes #1628 Fixes #2455 Fixes #3023 Fixes #3333 Fixes #3360 Co-authored-by: Jane Lusby <jlusby42@gmail.com> Co-authored-by: Philipp Hansch <dev@phansch.net>	2018-10-28 17:13:34 +00:00
Giorgio Gambino	62f16803e8	Fix #3335 rev1: bool_comparison triggers 3 times on same code	2018-10-28 16:28:17 +01:00
Giorgio Gambino	7cfde9cfa9	Fix #3335 : bool_comparison triggers 3 times on same code	2018-10-28 15:37:39 +01:00
Maxwell Anderson	183e19a1c3	Merge remote-tracking branch 'upstream/master'	2018-10-27 12:50:12 -06:00
Philipp Hansch	840e50e97f	Don't expand macro in or_fun_call suggestion	2018-10-27 15:47:56 +02:00
Philipp Hansch	af1548f58f	Don't expand macro in single_match suggestion	2018-10-27 15:47:56 +02:00
Philipp Hansch	aa7bcb9074	Don't expand macro in identity_conversion suggestion	2018-10-27 15:47:56 +02:00
Jane Lusby	19ac2e94c6	fix: correctly reconstruct raw strings	2018-10-26 09:12:01 -07:00
Jane Lusby	f9020bb2dd	fix: extra semicolon, only create callsite once	2018-10-26 09:12:01 -07:00
Jane Lusby	c209fc9349	Fix string_lit_as_bytes lint for macros Prior to this change, string_lit_as_bytes would trigger for constructs like `include_str!("filename").as_bytes()` and would recommend fixing it by rewriting as `binclude_str!("filename")`. This change updates the lint to act as an EarlyLintPass lint. It then differentiates between string literals and macros that have bytes yielding alternatives. Closes #3205	2018-10-26 09:12:01 -07:00
bors[bot]	457e7f12e9	Merge #3355 3355: Lint to remove redundant `clone()`s r=oli-obk a=sinkuu This PR adds lint `redundant_clone`. It suggests to remove redundant `clone()` that clones a owned value that will be dropped without any usage after that. Real-world example: https://github.com/rust-lang/rust/compare/7b0735a..sinkuu:redundant_clone2 Co-authored-by: Shotaro Yamada <sinkuu@sinkuu.xyz>	2018-10-26 10:36:43 +00:00
bors[bot]	ead29847ff	Merge #3357 3357: Check existential types in `use_self` r=oli-obk a=HMPerson1 Fixes #3231 Co-authored-by: HMPerson1 <hmperson1@gmail.com>	2018-10-26 08:48:12 +00:00
Shotaro Yamada	9a150b4aa1	Use lint_root	2018-10-26 01:16:14 +09:00
Shotaro Yamada	105ae712f4	update_references indexing_slicing	2018-10-26 01:16:14 +09:00
Shotaro Yamada	3ca0895920	Add redundant_clone lint	2018-10-26 01:15:55 +09:00
bors[bot]	a87e1b02ab	Merge #3331 3331: Disable arithmetic lints in constant items r=oli-obk a=pengowen123 Currently this will not catch cases in associated constants. I'm not sure whether checking spans is the best way to solve this issue, but I don't think it will cause any problems. Fixes #1858 Co-authored-by: Owen Sanchez <pengowen816@gmail.com>	2018-10-25 09:38:00 +00:00
HMPerson1	d53e6f87e9	Add tests for more than one level of reference	2018-10-24 23:39:55 -04:00
HMPerson1	1a6bfecf38	Add test case for `mem::discriminant` inside a macro	2018-10-24 23:39:55 -04:00
HMPerson1	aabf8083bd	Add lint for calling `mem::discriminant` on a non-enum type	2018-10-24 23:39:54 -04:00
HMPerson1	3db14f182c	Check existential types in `use_self`	2018-10-24 23:32:33 -04:00
Owen Sanchez	0b9e9c9e3d	Disable arithmetic lints in constant items	2018-10-24 20:27:26 -07:00
bors[bot]	4c6201dceb	Merge #3312 3312: OUT_OF_BOUNDS_INDEXING false negative r=phansch a=JoshMcguigan fixes #3102 Co-authored-by: Josh Mcguigan <joshmcg88@gmail.com>	2018-10-24 21:17:43 +00:00
bors[bot]	bce190558f	Merge #3338 3338: new_ret_no_self false positives r=flip1995 a=JoshMcguigan ~~WORK IN PROGRESS~~ I plan to fix all of the false positives in #3313 in this PR, but I wanted to open it now to start gathering feedback. In this first commit, I've updated the lint to allow tuple return types as long as `Self` shows up at least once, in any position of the tuple. I believe this is the broadest possible interpretation of what should be allowed for tuple return types, but I would certainly be okay making the lint more strict. fixes #3313 Co-authored-by: Josh Mcguigan <joshmcg88@gmail.com>	2018-10-24 14:42:40 +00:00
Josh Mcguigan	30ffc17ef7	new_ret_no_self added test cases	2018-10-24 06:43:21 -07:00
bors[bot]	03f8899fa5	Merge #3350 3350: Don't emit `new_without_default_derive` if an impl of Default exists regardless of generics r=oli-obk a=pengowen123 Fixes #2226 Co-authored-by: Owen Sanchez <pengowen816@gmail.com>	2018-10-24 07:59:06 +00:00
Owen Sanchez	50b9e7aebc	Don't emit `new_without_default_derive` if an impl of Default exists	2018-10-23 20:44:31 -07:00
Maxwell Anderson	6a695ffb3d	added float support for mistyped literal lints	2018-10-23 15:54:27 -06:00
Josh Mcguigan	a624583557	new_ret_no_self added test cases	2018-10-20 06:29:17 -07:00
HMPerson1	553d01d9c7	Update `ui/for_loop` test output	2018-10-19 17:17:13 -04:00
HMPerson1	2e9172aea2	Check for known array length in `needless_range_loop`	2018-10-19 16:34:16 -04:00
HMPerson1	2a9dec681f	Fix suggestion for multiple derefs	2018-10-19 14:51:25 -04:00
Josh Mcguigan	097df8f223	new_ret_no_self correct false positive on raw pointer return types	2018-10-19 05:20:33 -07:00
Josh Mcguigan	6e75050be0	new_ret_no_self correct linting of tuple return types	2018-10-19 04:55:06 -07:00
HMPerson1	a2be050965	Fix `clone_on_copy` not detecting derefs sometimes	2018-10-19 00:03:56 -04:00
Maxwell Anderson	9f637288cf	Merge remote-tracking branch 'upstream/master'	2018-10-18 15:45:05 -06:00
Lukas Stevens	5614dcb4ea	Support multiline comments and hopefully fix panic	2018-10-18 18:57:16 +02:00
Lukas Stevens	8753e568bf	Check for comments in collapsible ifs	2018-10-18 18:00:21 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	1264bb6b7d	Merge pull request #3323 from pengowen123/fix_manual_memcpy Simplify manual_memcpy suggestion in some cases	2018-10-18 09:44:24 +02:00
Philipp Hansch	284c63e84d	Merge pull request #3281 from CYBAI/redundant-match Add lint for redundant pattern matching for explicit return boolean	2018-10-17 07:31:09 +02:00
CYBAI	66ae3b1249	Rename if_let_redundant_pattern_matching to redundant_pattern_matching Also, making the old one deprecated	2018-10-17 11:20:42 +08:00
CYBAI	3b7c88888b	Add lint for redundant pattern matching for explicit return boolean	2018-10-17 11:14:37 +08:00
Giorgio Gambino	aa88e68902	Fix issue #3322 : reword help message for len_zero	2018-10-16 23:23:31 +02:00
Owen Sanchez	8c902d1cf2	Simplify manual_memcpy suggestion in some cases	2018-10-16 12:38:23 -07:00
Bruno Kirschner	2d8b4f3d5c	Avoid linting `boxed_local` on trait implementations.	2018-10-15 20:34:45 +02:00
Josh Mcguigan	66d3672b26	out_of_bounds_indexing improved reporting of out of bounds value	2018-10-15 04:44:39 -07:00
Owen Sanchez	456843f1cd	Swap order of methods in `needless_range_loop` suggestion in some cases	2018-10-14 20:14:16 -07:00
Josh Mcguigan	0f3345e8b2	OUT_OF_BOUNDS_INDEXING fix #3102 false negative	2018-10-13 13:51:53 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	601cc9d2c5	Merge pull request #3310 from JoshMcguigan/explicit_counter_loop-3308 explicit_counter_loop fix #3308 false positive	2018-10-13 20:11:50 +02:00
Josh Mcguigan	c6f79c7ba0	explicit_counter_loop fix #3308 false positive	2018-10-13 06:57:52 -07:00
Josh Mcguigan	3f386d33f9	new_ret_no_self test remove tool lints cfg flag	2018-10-13 06:33:46 -07:00
Josh Mcguigan	348d18ebd8	Removed new_ret_no_self tests from method.rs	2018-10-13 06:25:10 -07:00
Josh Mcguigan	a5e4805ecf	new_ret_no_self correctly lint impl return	2018-10-13 06:20:39 -07:00
Josh Mcguigan	1c4fa419f3	new_ret_no_self fix false positive for impl trait return with associated type self	2018-10-13 06:20:39 -07:00
Josh Mcguigan	13ce96c4bf	new_ret_no_self corrected panic and added test stderr	2018-10-13 06:20:39 -07:00
Josh Mcguigan	eb854b233c	new_ret_no_self added positive test cases	2018-10-13 06:20:39 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	8b12eee112	Merge pull request #3233 from rust-lang-nursery/unused-unit new lint: unused_unit	2018-10-13 09:30:19 +02:00
Andre Bogus	e8687a6677	unused unit lint	2018-10-13 00:42:55 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	d445dbfe16	Merge pull request #3291 from JoshMcguigan/cmp_owned-3289 cmp_owned wording and false positive	2018-10-12 15:07:12 +02:00
Josh Mcguigan	c9718fa589	cmp_owned correct error message if rhs is deref	2018-10-12 04:34:41 -07:00
Maxwell Anderson	63fbeaab68	Merge remote-tracking branch 'upstream/master'	2018-10-11 22:16:05 -06:00
Maxwell Anderson	9fad38dca9	tmp progress	2018-10-11 22:15:01 -06:00
Josh Mcguigan	0b65462ca5	cmp_owned current suggestion for multiple deref	2018-10-11 05:03:02 -07:00
Oliver Scherer	9d3373137b	Remove now-useless `allow(unknown_lints)`	2018-10-11 12:18:27 +02:00
Oliver Scherer	b8654eaa6c	Stabilize tool lints	2018-10-11 12:16:22 +02:00
mikerite	31eb3b73d3	Merge pull request #3127 from mikerite/fix-2937 Fix 2937	2018-10-11 06:22:02 +02:00
Karim SENHAJI	f9e4f5695d	Limit commutative assign op lint to primitive types	2018-10-10 19:10:44 +02:00
Josh Mcguigan	d41615548e	cmp_owned add test for multiple dereference	2018-10-10 04:51:06 -07:00
Michael Wright	7499cb543d	Fix #2937	2018-10-10 07:52:58 +02:00
Josh Mcguigan	b0d7aea946	Fixes 3289, cmp_owned wording and false positive	2018-10-09 19:25:03 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	f6882ede4d	Merge pull request #3287 from JoshMcguigan/cmp_owned-2925 cmp_owned false positive	2018-10-09 10:01:31 +02:00
Josh Mcguigan	ad5c29a445	Fixes #2925 cmp_owned false positive	2018-10-08 19:04:29 -07:00
Matthias Krüger	a578cb2d62	if_let_redundant_pattern_matching: use Span.to() instead of Span.with_hi() to fix crash. Fixes #3064	2018-10-08 17:34:43 +02:00
Rotem Yaari	1ef32e4096	Improve diagnostics in case of lifetime elision (closes #3284 )	2018-10-08 13:07:21 +03:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	02705d4cf5	Merge pull request #3282 from JoshMcguigan/excessive_precision-2840 Fix excessive_precision false positive	2018-10-08 08:24:13 +02:00
Ryan Cumming	9bd4e5469e	Don't suggest cloned() for map Box deref Boxes are a bit magic in that they need to use `` to get an owned value out of the box. They implement `Deref` but that only returns a reference. This means an easy way to convert an `Option<Box<T>>` to an `<Option<T>` is: ``` box_option.map(\|b\| b) ``` However, since `b36bb0a6` the `map_clone` lint is detecting this as an attempt to copy the box. Fix by excluding boxes completely from the deref part of this lint. Fixes #3274	2018-10-08 06:20:32 +11:00
Josh Mcguigan	8a77a25b8a	Fix excessive_precision false positive	2018-10-07 11:38:20 -07:00
Philipp Hansch	63ceabf0cf	Merge pull request #3280 from d-dorazio/fix-new_without_default-should-not-fire-unsafe-new new_without_default should not warn about unsafe new	2018-10-07 13:09:37 +01:00
Philipp Hansch	d365742bc6	Fix FP in `fn_to_numeric_cast_with_truncation` We only want this lint to check casts to numeric, as per the lint title. Rust already has a built-in check for all other casts [here][rust_check]. [rust_check]: `5472b0718f/src/librustc_typeck/check/cast.rs (L430-L433)`	2018-10-07 12:50:36 +02:00
Daniele D'Orazio	59c4ff77f1	new_without_default should not warn about unsafe new	2018-10-07 12:39:54 +02:00
Manish Goregaokar	e9c025ea70	Add license header to Rust files	2018-10-06 09:43:08 -07:00
Manish Goregaokar	75965030c7	Merge pull request #3251 from rust-lang-nursery/relicense-rewrite [do not merge] Relicensing rewrite	2018-10-05 20:14:55 +02:00
Philipp Hansch	8407957ec6	Fix fn_to_numeric_cast UI tests This collapses both lint tests into one file. Somehow allowing the other lint in the respective files did not work correctly. Maybe that's fixed as part of fixing #3198.	2018-10-05 07:49:08 +02:00
Philipp Hansch	1544a1a681	Merge remote-tracking branch 'origin/master' into relicense-rewrite	2018-10-05 07:18:24 +02:00
Joel Gallant	163780ee0b	Solves #3222 by checking the BareFnTy Abi type	2018-10-04 18:49:03 -06:00
Philipp Hansch	8b3d2073fa	Only run tests if pointer width is 64bit If the pointer width of the architechture is 32bit or something else, then the tests will most likely produce different results.	2018-10-04 22:26:54 +02:00
Philipp Hansch	c0ab8b2531	Reimplement the `fn_to_numeric_cast_with_truncation` lint	2018-10-04 21:44:16 +02:00
mcarton	5173ed0c03	Don't suggest `to_string().to_string` in USELESS_FORMAT	2018-10-03 20:59:59 +02:00
Philipp Hansch	f42272102a	Reimplement the `fn_to_numeric_cast` lint	2018-10-03 12:02:06 +02:00
mcarton	7eebd5b20c	Ignore `format!` with precision in `USELESS_FORMAT`	2018-10-02 23:57:22 +02:00
mcarton	d18c7b2722	Add test for variable width in `USELESS_FORMAT`	2018-10-02 23:54:50 +02:00
Oliver Schneider	b36bb0a68d	Reimplement the `map_clone` lint from scratch	2018-10-02 15:13:43 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	11cc8472a9	Merge pull request #3245 from JoshMcguigan/wrong_self_convention-1530 Correct false positive in wrong_self_convention lint for to_mut	2018-10-02 14:54:36 +02:00
Josh Mcguigan	f142098474	Correct false positive in wrong_self_convention lint for to_mut	2018-10-02 04:47:38 -07:00
Manish Goregaokar	057243f16b	relicensing: Remove map_clone This removes the code added in https://github.com/rust-lang-nursery/rust-clippy/pull/427	2018-10-02 12:51:38 +02:00
Manish Goregaokar	fffcd093b2	relicensing: Remove fn_to_numeric_cast, fn_to_numeric_cast_with_truncation This removes the code added in https://github.com/rust-lang-nursery/rust-clippy/pull/2814	2018-10-02 12:49:27 +02:00
Manish Goregaokar	902aca70bd	Merge pull request #3243 from flip1995/appveyor_disable_dogfood Disable dogfood under windows until rust-lang-nursery/rustup.rs#1499 is merged	2018-10-02 12:20:14 +02:00
Philipp Hansch	eb5f146f14	Fix 'impossible case reached' ICE	2018-10-01 22:34:52 +02:00
flip1995	14335f372b	Disable dogfood until rust-lang-nursery/rustup.rs#1499 is merged	2018-09-30 12:59:15 +02:00
Michael Wright	50133fbd3a	Merge branch 'master' into unnecessary_filter_map	2018-09-30 06:39:56 +02:00
Josh Mcguigan	e25f884e6f	Fixes #3180 , suppress excessive_precision lint for floats with no decimal part	2018-09-29 07:39:30 -07:00
Michael Wright	c2ee9c29ab	Merge branch 'master' into unnecessary_filter_map	2018-09-29 15:27:47 +02:00
Michael Wright	db5c63b77a	Move tests into separate file	2018-09-29 13:57:04 +02:00
Philipp Hansch	8e808664fa	Merge pull request #3178 from ms2300/bad_unwrap Fix for bad get unwrap suggestion	2018-09-28 07:38:00 +01:00
Michael Wright	2f364d9ac5	Merge branch 'master' into unnecessary_filter_map	2018-09-27 06:12:01 +02:00
Matthias Krüger	41d3df7321	tests: dogfood: extend to run with --all-features and clippy::internal enabled. Run it on rustc_tools_util and clippy_dev as well.	2018-09-26 12:32:20 +02:00
Michael Wright	f5ffac4fce	Implement unnecesary_filter_map lint	2018-09-26 06:52:36 +02:00
Jane Lusby	14feb3670f	Lint for chaining flatten after map This change adds a lint to check for instances of `map(..).flatten()` that can be trivially shortened to `flat_map(..)` Closes #3196	2018-09-24 14:29:16 -07:00
Michael Wright	ab71f08663	Fix single_char_pattern crash (#3204 ) This commit fixes the crash by removing constant checking from the lint. Closes #3204.	2018-09-24 08:33:57 +02:00
ms2300	523ba2a009	Full fix of get unwrap issue	2018-09-23 19:53:25 -07:00
ms2300	de8d233b06	#3006 : Fixing for .get().unwrap().foo()	2018-09-23 19:53:25 -07:00
Philipp Krones	bc6d85ceaf	Merge pull request #3207 from mikerite/fix-3206 Fix double_parens false positive	2018-09-23 18:24:27 +02:00
Michael Wright	867ac98d38	Fix double_parens false positive Closes #3206	2018-09-22 17:20:34 +02:00
Jay Kickliter	2f53aaa5bd	mem_replace: match on path.	2018-09-19 14:41:22 -07:00
Jay Kickliter	598df08d88	Add lint for `mem::replace(.., None)`. Suggest `Option::take()` as an alternative.	2018-09-19 14:38:34 -07:00
Eduard-Mihai Burtescu	407ff8d6be	Reintroduce `extern crate` for non-Cargo dependencies, in tests.	2018-09-15 13:37:21 +03:00
Eduard-Mihai Burtescu	85caaf5905	Fix `useless_attribute` to also whitelist `unused_extern_crates`.	2018-09-15 11:16:45 +03:00
Oliver Schneider	3e4f7fc4c0	Don't use the old feature gate	2018-09-10 15:44:41 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	1c1030f83f	Merge pull request #3152 from PSeitz/master fixes #3151 by skipping the lint instead of crashing	2018-09-10 13:44:47 +02:00
Philipp Krones	f30cf51a70	Merge pull request #3135 from JoshMcguigan/explicit_counter_loop-1219 Closes #1219 false positive for explicit_counter_loop	2018-09-09 23:49:03 +02:00
Pascal Seitz	43549ebbf8	fixes #3151 by skipping the lint instead of crashing	2018-09-08 15:30:50 +02:00
Matthias Krüger	160959d27f	add tests for #3057 and #2651 Fixes #3057 Fixes #2651	2018-09-08 09:04:04 +02:00
Josh Mcguigan	9168746c38	Corrected explicit_counter_loop behavior with nested loops	2018-09-07 20:46:36 -07:00
Josh Mcguigan	53c262048c	Fix #1219 false positive for explicit_counter_loop	2018-09-07 19:58:19 -07:00
flip1995	90f7997771	Add regression test	2018-09-07 17:41:03 +02:00
Josh Mcguigan	ce554267b8	Updated explicit_counter_loop tests based on discussion in #3135	2018-09-07 05:32:56 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer	63a46b1e1a	Merge pull request #3129 from mipli/3091-numeric-typo Add lint for misstyped literal casting	2018-09-07 09:54:43 +02:00
Josh Mcguigan	edfa9feac2	Corrected explicit_counter_loop missing lints if variable used after loop	2018-09-06 06:20:25 -07:00
Matthias Krüger	a0f56edfc3	print_with_newline / write_with_newline: don't warn about string with several `\n`s in them. Fixes #3126	2018-09-06 12:59:34 +02:00
Josh Mcguigan	4b668159d2	Closes #1219 false positive for explicit_counter_loop	2018-09-05 19:14:01 -07:00
Michael A. Plikk	38d287fecd	Add lint for misstyped literal casting	2018-09-05 19:46:49 +02:00
Josh Mcguigan	0f6d422817	Added test case for ptr_arg	2018-09-05 05:59:07 -07:00
daubaris	db391c4613	Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one	2018-09-04 18:52:18 +03:00
Josh Holmer	48e6be42d7	Rustup	2018-09-03 23:50:24 -04:00
Josh Holmer	061b2f3057	Apply applicability	2018-09-03 23:29:44 -04:00
Josh Holmer	dfed9751bd	Majority of PR changes	2018-09-03 23:29:44 -04:00
Josh Holmer	fbc93c0166	Lint against needless uses of `collect()` Handles cases of `.collect().len()`, `.collect().is_empty()`, and `.collect().contains()`. This lint is intended to be generic enough to be added to at a later time with other similar patterns that could be optimized. Closes #3034	2018-09-03 23:29:44 -04:00
daubaris	1f3676f7d0	Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one	2018-09-03 18:24:47 +03:00
daubaris	b825578a4a	backticks and testcase	2018-09-03 18:24:38 +03:00
Philipp Hansch	c0513097ab	Merge pull request #3092 from illicitonion/issue-2879 default_trait_access skips <F as Default>::default()	2018-09-03 17:24:33 +02:00
daubaris	1615a8a2b6	Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one	2018-09-03 17:21:13 +03:00
Josh Triplett	779988303a	iter conservation efforts: save the endangered .iter() and .into_iter() Make explicit_iter_loop and explicit_into_iter_loop allow-by-default, so that people can turn them on if they want to enforce that style; avoid presenting them as the idiomatic Rust style, rather than just a style.	2018-09-03 01:24:46 -07:00
Daniel Wagner-Hall	9f0216d520	Merge branch 'master' into issue-2879	2018-09-03 00:01:57 +01:00
daubaris	846c3dba2c	resolved conflicts	2018-09-01 09:37:42 +03:00
Manish Goregaokar	c81d70e6bd	Merge pull request #2977 from flip1995/tool_lints Implement tool_lints	2018-09-01 11:22:23 +05:30
Manish Goregaokar	9abf6fca9c	Fix ptr offset tests	2018-08-31 00:38:27 -07:00
Oliver Schneider	73e8416df3	Merge pull request #3081 from mikerite/fix-3078 Fix #3078	2018-08-31 09:05:39 +02:00
daubaris	679bc32f46	range_plus_one suggestion should not remove braces fix	2018-08-30 20:06:13 +03:00
Manish Goregaokar	e0ad732226	Merge pull request #3105 from frewsxcv/frewsxcv-private Make clippy_lints::{utils,consts} modules private, remove unused items.	2018-08-29 11:24:00 -07:00
flip1995	cfd4c538d4	Adapt ui-toml-tests to the tool_lints	2018-08-29 11:08:29 -07:00
flip1995	ea43fedf9e	Adapt run-pass tests to the tool_lints	2018-08-29 11:08:29 -07:00
flip1995	e9af09c274	Adapt the *.stderr files of the ui-tests to the tool_lints	2018-08-29 11:08:29 -07:00
flip1995	1b6f6051a8	Adapt ui-tests to the tool_lints	2018-08-29 11:08:29 -07:00
Corey Farwell	2fa7351c1e	suggest wrapping_offset as well	2018-08-29 07:40:00 -05:00
Corey Farwell	5ebae01c1e	New lint: Suggest `ptr.add([usize])` over `ptr.offset([usize] as isize)`. First part of #3047.	2018-08-28 23:21:29 -05:00
Corey Farwell	05f637cf88	Make clippy_lints::{utils,consts} modules private, remove unused items.	2018-08-28 21:32:20 -05:00
Daniel Wagner-Hall	350036a0c7	default_trait_access skips <F as Default>::default() This includes the type name, so is clear, and may be necessary. There doesn't seem to be an obviously cleaner way to pull out the literal text of the named type here. Fixes #2879	2018-08-27 23:22:07 +01:00
Michael Wright	45ceecc79c	Fix #3078	2018-08-25 14:49:56 +02:00
Philipp Krones	e91147832c	Merge pull request #3048 from goodmanjonathan/assign_op deprecate assign_ops lint	2018-08-24 18:29:31 +02:00
Philipp Krones	562c576ed3	Merge pull request #3059 from elpiel/writeln_empty_string_harcoded-suggestion #3016 writeln_empty_string Hardcoded suggestion	2018-08-24 18:28:50 +02:00
Niklas Fiekas	afdf350060	Add copy_iterator lint (#1534 )	2018-08-24 11:57:48 +02:00
flip1995	37099ae034	Remove now stable tool_attributes feature	2018-08-23 15:36:07 +02:00
Lachezar Lechev	76f7bfcefd	#3016 Add backticks for the msg	2018-08-20 15:50:15 +02:00
Lachezar Lechev	c292b80783	#3016 Add feedback and implement test for fixed hardcoded suggestion	2018-08-20 15:33:43 +02:00
Manish Goregaokar	76321d3300	codemap -> source_map https://github.com/rust-lang/rust/pull/52953	2018-08-19 19:06:54 -07:00
Michael Wright	bbd67c9b78	Fix #2927	2018-08-15 08:11:07 +02:00
Philipp Krones	84aa49935d	Merge pull request #3026 from dwijnand/fxhash Add an internal lint for FxHashMap/FxHashSet	2018-08-14 13:04:48 +02:00
Philipp Krones	72b8c9b211	Merge pull request #3049 from mikerite/fix-2799 Add a test to ensure that #2799 is fixed	2018-08-14 12:55:13 +02:00
Philipp Krones	b2a4013c14	Merge pull request #3014 from estk/allow-write-multi-newline Allow print/write with multiple newlines	2018-08-14 12:54:05 +02:00
Dale Wijnand	7933d445d1	Move shadow_unrelated to pedantic	2018-08-14 09:52:27 +01:00
Michael Wright	a1f8e129fd	Add a test to ensure that #2799 is fixed Closes #2799	2018-08-14 07:27:56 +02:00
Jonathan Goodman	160b41dae3	deprecate assign_ops lint	2018-08-13 16:12:41 -05:00
Dale Wijnand	1812707d39	Use utils::span_lint_and_sugg in default_hash_types	2018-08-13 11:49:57 +01:00
Dale Wijnand	8fc425b676	Add an internal lint for FxHashMap/FxHashSet	2018-08-12 16:15:36 +01:00
Oliver Schneider	d722489e71	Merge pull request #2823 from flip1995/thingies_things Replace cfg_attr(rustfmt... with rustfmt::skip	2018-08-08 13:14:20 +02:00
Evan Simmons	550ff84ecd	Allow print/write with multiple newlines	2018-08-07 12:01:10 -08:00
Oliver Schneider	328fea3e0d	Rustup	2018-08-07 16:34:17 +02:00
Michael Wright	a3d7698fd9	Fix #2971	2018-08-07 05:37:11 +02:00
Oliver Schneider	b18a3c5b60	Merge pull request #3007 from mikerite/issue3000 Fix #3000	2018-08-06 09:16:42 +02:00
Michael Wright	ffce3c77e4	Fix #3000	2018-08-06 08:20:50 +02:00
Philipp Hansch	f6c4e303c9	Merge pull request #2999 from flip1995/single_char_pattern Fix single_char_pattern lint for escaped chars	2018-08-06 07:05:04 +01:00
Philipp Hansch	32e4897854	Merge pull request #2975 from aaudiber/lint-identity-into-iter Lint using identity into_iter conversion	2018-08-05 20:38:28 +01:00
Philipp Hansch	a016d4efe0	Merge pull request #2991 from mikerite/issue2979 Fix #2979	2018-08-05 20:35:55 +01:00
flip1995	55672e7e49	Fix single_char_pattern lint for escaped chars	2018-08-03 10:19:29 +02:00
Alex Crichton	8ef759e027	Fix fallout from rust-lang/rust#52841	2018-08-02 18:08:22 -07:00
Alex Crichton	ae6ea84924	Fix tests from `40349b23ea`	2018-08-02 14:22:44 -07:00
flip1995	12f2d61fa9	Replace cfg_attr(rustfmt... thingies	2018-08-02 23:04:20 +02:00
Ryan Cumming	08d6b3d2f6	Allow pass by ref when returning ADT with ref This is a follow-up to #2951 that extends the logic to allow for returning references inside structs/enums/unions. This was a simple oversight in the first version and it's surprisingly easy to handle.	2018-08-02 17:57:49 +10:00
Michael Wright	534d546c81	Fix #2979	2018-08-02 08:56:53 +02:00
Philipp Hansch	d7ffaab0fb	Merge pull request #2968 from phansch/first_an_ICE_and_then_some_ice_cream Fix ICE with 'while let Some(..) = x.iter()'	2018-08-01 06:18:34 +01:00
flip1995	74fcf7de4a	single_char_pattern: lint only on the argument span	2018-07-31 12:20:32 +02:00
Andrew Audibert	0ea1afab3a	Lint using identity into_iter conversion	2018-07-29 21:37:31 -07:00
Philipp Hansch	946340acfe	Fix ICE with 'while let (..) = x.iter()'	2018-07-29 11:00:26 +02:00
Michael Wright	8eeb3feadf	Merge branch 'master' into issue2894	2018-07-28 08:41:10 +02:00
Oliver Schneider	b0dabce478	Merge pull request #2963 from commandline/master Fix regression in print_literal	2018-07-26 10:11:34 +02:00
Thomas Gideon	9b11be72c0	Fix copy-paste error	2018-07-25 18:14:11 -04:00
Thomas Gideon	5446e73de6	And the ones annotating the source file name.	2018-07-25 18:00:19 -04:00
Thomas Gideon	457b76cedf	Update line numbers	2018-07-25 17:51:04 -04:00
Thomas Gideon	bf3f976a43	Fix regression in print_literal	2018-07-25 17:31:17 -04:00
Matthias Krüger	2665f10662	fix a bunch of typos found by codespell	2018-07-25 20:02:52 +02:00
Matthias Krüger	cfc9b33f17	Merge branch 'master' into typos	2018-07-25 19:54:45 +02:00
Michael Wright	5e23fcec0b	Merge branch 'master' into issue2894	2018-07-25 06:27:36 +02:00
Ryan Cumming	0afa5e1e21	Merge branch 'master' into allow-pass-by-ref-on-ref-return	2018-07-24 19:03:43 +10:00
Ryan Cumming	58459abd0c	Allow pass by reference if we return a reference Currently this code will trigger `trivally_copy_pass_by_ref`: ``` struct OuterStruct { field: [u8; 8], } fn return_inner(outer: &OuterStruct) -> &[u8] { &outer.field } ``` If we change the `outer` to be pass-by-value it will not live long enough for us to return the reference. The above example is trivial but I've hit this in real code that either returns a reference to either the argument or in to `self`. This suppresses the `trivally_copy_pass_by_ref` lint if we return a reference and it has the same lifetime as the argument. This will likely miss complex cases with multiple lifetimes bounded by each other but it should cover the majority of cases with little effort.	2018-07-23 18:44:40 +10:00
Oliver Schneider	ff0e5f967f	Rewrite the print/write macro checks as a PreExpansionPass	2018-07-23 00:19:07 +02:00
flip1995	ac77a26b8a	Skip useless_attribute lint on allow(unused_imports) on extern crate items with macro_use	2018-07-19 13:59:25 +02:00
Michael Wright	5bb52c4869	Fix use_self regressions	2018-07-17 08:20:49 +02:00
Michael Wright	847e4dcc0d	Merge branch 'master' into issue2894	2018-07-17 06:32:39 +02:00
Oliver Schneider	8f61a792f4	Update test output to changes in rustc	2018-07-16 15:43:30 +02:00
csmoe	8e929946fd	DeclKind	2018-07-16 11:48:33 +02:00
csmoe	8cf463fe93	StmtKind	2018-07-16 11:48:33 +02:00
csmoe	12ded030b6	TyKind	2018-07-16 11:48:33 +02:00
csmoe	5d4102ee78	BinOpKind	2018-07-16 11:46:37 +02:00
csmoe	1bd17e4fa2	ExprKind	2018-07-16 11:46:37 +02:00
Michael Wright	b90fc5edfa	Fix #2894	2018-07-15 10:38:40 +02:00
Manish Goregaokar	184b99de39	Merge branch 'pr-2889'	2018-07-06 23:20:01 -07:00
gnzlbg	14cbdf2607	do not apply lint to executable crate type	2018-07-04 16:39:52 +02:00
gnzlbg	7c4ec40346	add missing_inline lint When turned on, the lint warns on all exported functions, methods, trait methods (default impls, impls), that are not `#[inline]`. Closes #1503.	2018-07-04 13:50:39 +02:00
Oliver Schneider	63041d070b	Rustup	2018-07-01 13:36:14 +02:00
Georg Brandl	949f0d9c72	Fix badly mangled lint message for neg-cmp-op-on-partial-ord	2018-06-29 16:55:31 +02:00
Oliver Schneider	656b26ea4f	Merge pull request #2832 from kennytm/non-copy-const Lint against const items which are interior mutable.	2018-06-28 08:39:54 +02:00
Oliver Schneider	0de3f36a02	Merge pull request #2849 from mikerite/issue_2741 Fix #2741	2018-06-26 11:08:19 +02:00
Michael Wright	4827bdcc1c	Merge branch 'master' into issue_2741	2018-06-26 07:46:56 +02:00
flip1995	b2fb01f23b	Use utils::opt_def_id() instead of def_id() to prevent ICE	2018-06-25 22:25:15 +02:00
kennytm	88b7603b16	Lint against const items which are interior mutable. Fix #1560 .	2018-06-23 03:35:36 +08:00
flip1995	6224e19b80	Check for arguments before accessing the first arg	2018-06-21 15:46:24 +02:00
Oliver Schneider	25510cfb13	Merge pull request #2790 from shnewto/vectors-to-indexing-slicing-lint Extend `indexing_slicing` lint	2018-06-21 10:30:40 +02:00
Bruno Kirschner	fedd3ef711	Allows neg_cmp_op_on_partial_ord for external macros (fixes #2856 ). The macro always negates the result of the given comparison in its internal check which automatically triggered the lint. As its an external macro there was no chance to do anything about it which lead to a white listing of all external macros to prevent further issues.	2018-06-20 11:58:15 +02:00
Shea Newton	c479b3bc28	Removing lint for constant `usize` array indexing This commit removes the logic in this PR that linted out-of-bounds constant `usize` indexing on arrays. That case is already handled by rustc's `const_err` lint. Beyond removing the linting logic, the test file and its associated stderr were updated to verify that const `usize` indexing operations on arrays are no longer handled by this `indexing_slicing` lint.	2018-06-19 21:30:43 +00:00
Shea Newton	e63f5dfedb	Add tests that index with a `const` value. In this commit tests were added to ensure that tests with a `const` index behaved as expected. In order to minimize the changes to the test's corresponding `stderr`, the tests were appended to the end of the file.	2018-06-19 16:28:10 +00:00
Shea Newton	4ec439bef0	Revisiting indexing_slicing test cases This commit contains a few changes. In an attempt to clarify which test cases should and should not produce stderr it became clear that some cases were being handled incorrectly. In order to address these test cases, a minor re-factor was made to the linting logic itself. The re-factor was driven by edge case handling including a need for additional match conditions for `ExprCall` (`&x[0..=4]`) and `ExprBinary` (`x[1 << 3]`). Rather than attempt to account for each potential `Expr*` the code was re-factored into simply "if ranged index" and an "otherwise" conditions.	2018-06-19 16:28:10 +00:00
Shea Newton	8b59542acc	Second pass at addressing changes requested The changes reflected in this commit (requested in PR #2790) are as follows: - Extended `INDEXING_SLICING` documentation to include the array type so that it is clearer when indexing operations are allowed. - Variable `ty` defined identically in multiple scopes was moved to an outer scope so it's only defined once. - Added a missing return statement to ensure only one lint is triggered by a scenario. - Prettified match statement with a `let` clause. (I learned something new!) - Added `&x[5..].iter().map(\|x\| 2 * x).collect::<Vec<i32>>()` and `&x[2..].iter().map(\|x\| 2 * x).collect::<Vec<i32>>()` to the test cases. The first _should trigger the lint/stderr_ and the second _should not_.	2018-06-19 16:28:10 +00:00
Shea Newton	a7c0ff3fa6	This commit represents an attempt to address changes requested in the process of reviewing PR #2790 . The changes reflected in this commit are as follows: - Revised `IndexingSlicingPass` struct name to IndexingSlicing for consistency with the rest of the code base. - Revised match arm condition to use `(..)` shorthand in favor of `(_, _, _)`. - Restored a couple telling variable names. - Calls to `cx.span_lint` were revised to use `utils::span_help_and_lint`. - Took a stab at refactoring some generalizable calls to `utils::span_help_and_lint` to minimize duplicate code. - Revised INDEXING_SLICING declaration to pedantic rather than restriction. - Added `&x[0..].get(..3)` to the test cases.	2018-06-19 16:28:10 +00:00
Shea Newton	5b759efa4c	Rename instances of `array_indexing` This commit renames instances of `array_indexing` to `indexing_slicing` and moves the `indexing_slicing` lint to the `clippy_pedantic` group. The justification for this commit's changes are detailed in the previous commit's message.	2018-06-19 16:27:39 +00:00
Shea Newton	7af0c67855	Extend `indexing_slicing` lint Hey there clippy team! I've made some assumptions in this PR and I'm not at all certain they'll look like the right approach to you. I'm looking forward to any feedback or revision requests you have, thanks! Prior to this commit the `indexing_slicing` lint was limited to indexing/slicing operations on arrays. This meant that the scope of a really useful lint didn't include vectors. In order to include vectors in the `indexing_slicing` lint a few steps were taken. The `array_indexing.rs` source file in `clippy_lints` was renamed to `indexing_slicing.rs` to more accurately reflect the lint's new scope. The `OUT_OF_BOUNDS_INDEXING` lint persists through these changes so if we can know that a constant index or slice on an array is in bounds no lint is triggered. The `array_indexing` tests in the `tests/ui` directory were also extended and moved to `indexing_slicing.rs` and `indexing_slicing.stderr`. The `indexing_slicing` lint was moved to the `clippy_pedantic` lint group. A specific "Consider using" string was added to each of the `indexing_slicing` lint reports. At least one of the test scenarios might look peculiar and I'll leave it up to y'all to decide if it's palatable. It's the result of indexing the array `x` after `let x = [1, 2, 3, 4];` ``` error: slicing may panic. Consider using `.get(..n)`or `.get_mut(..n)`instead --> $DIR/indexing_slicing.rs:23:6 \| 23 \| &x[0..][..3]; \| ^^^^^^^^^^^ ``` The error string reports only on the second half's range-to, because the range-from is in bounds! Again, thanks for taking a look. Closes #2536	2018-06-19 16:27:08 +00:00
uHOOCCOOHu	5b57b5fc61	Add notes for test examples.	2018-06-19 23:18:53 +08:00
uHOOCCOOHu	ce1800d599	Check lifetimes in Fn traits in generic bounds. Add tests.	2018-06-19 21:25:38 +08:00
Oliver Schneider	d761ba78d8	Merge pull request #2837 from fanzier/panicking_unwrap Implement lint checking for `unwrap`s that will always panic.	2018-06-19 13:30:38 +02:00
Oliver Schneider	4839c790ae	Merge pull request #2844 from illicitonion/default_trait_access Add default_trait_access lint	2018-06-19 10:10:20 +02:00
Daniel Wagner-Hall	b24d75313e	Exclude generated code	2018-06-18 10:29:25 +01:00
Michael Wright	7a32c28931	Fix #2741	2018-06-16 18:33:11 +02:00
Wim Looman	700ece5648	Allow configuring the trivial copy size limit	2018-06-15 16:53:34 +02:00
Wim Looman	7547a4ddef	New Lint: Pass small trivially copyable objects by value Fixes #1680 Hardcoded for 64-bit "trivial" size for now	2018-06-15 16:53:34 +02:00
Daniel Wagner-Hall	d3124731b7	Fix some existing test expectations	2018-06-14 23:13:12 +01:00
Daniel Wagner-Hall	4866309f9d	Add default_trait_access lint	2018-06-14 09:11:46 +01:00
Oliver Schneider	26bc88d48c	Merge pull request #2839 from mikerite/duration_subsec_pr_2 Add duration_subsec lint	2018-06-12 06:30:20 -07:00
Fabian Zaiser	8682858e2c	Categorize the unwrap lints correctly.	2018-06-12 15:06:46 +02:00
Fabian Zaiser	23404287fc	Implement lint checking for `unwrap`s that will always panic.	2018-06-12 15:04:44 +02:00
Michael Wright	725e9621d0	duration_subsec: Add check for `subsec_micros`	2018-06-12 08:25:10 +02:00
Oliver Schneider	8f0edba6e9	Merge pull request #2815 from darArch/master Warn if non-trivial work is done inside .expect	2018-06-11 06:33:26 -07:00
Michael Wright	7b2fa2077f	Add duration_subsec lint Closes #2543	2018-06-09 10:21:26 +02:00
Oliver Schneider	91986fa933	Merge pull request #2836 from mati865/upcoming_breakage Upcoming breakage	2018-06-09 06:56:39 +02:00
Fabian Zaiser	54826cf72e	Address review comments.	2018-06-08 06:02:25 +02:00
Fabian Zaiser	81821acd59	Implement lint that checks for unidiomatic `unwrap()` (fixes #1770 ) This checks for things like if x.is_some() { x.unwrap() } which should be written using `if let` or `match` instead. In the process I moved some logic to determine which variables are mutated in an expression to utils/usage.rs.	2018-06-08 05:29:25 +02:00
Mateusz Mikuła	3693a4ea53	Formatting	2018-06-07 22:01:46 +02:00
Oliver Schneider	2a2e602f2a	Merge pull request #2833 from phansch/cannot_relate_bound_region_without_ICE_cream Fix cargo late bound region mismatch ICE	2018-06-07 11:52:32 +02:00
Philipp Hansch	17aff1d774	Fix cargo late bound region mismatch ICE	2018-06-07 07:42:45 +02:00
Oliver Schneider	7563d8155b	Merge pull request #2804 from utaal/expr-call-author Add support for ExprCall in clippy::author	2018-06-06 15:17:47 +02:00
Donald Robertson	451fd5feb9	Extracting arguments to format to pass directly to panic when appropriate	2018-06-05 21:15:08 +01:00
Oliver Schneider	1e1b4e26ea	Merge pull request #2814 from VKlayd/fn_to_int WIP: Add lint on cast Fn to all numerical except usize.	2018-06-05 17:08:33 +02:00
Donald Robertson	1ead12c500	Adding handling and tests for custom type with implemented expect method	2018-06-04 19:43:03 +01:00
Donald Robertson	fe8c9d5965	Ensuring correct lint message is output for Option and Result type	2018-06-04 19:43:03 +01:00
Donald Robertson	05c1ccebaf	Warn if non-trivial work is done inside .expect - added tests for common usages of format and as_str arguments to expect - added tests for usages of Option and Result types - given performance impact of passing non literal expressions to expect, added to perf group	2018-06-04 19:43:03 +01:00
Bruno Kirschner	28f735bb26	Cleaned implements_ord helper function in boolean lint file.	2018-06-03 22:56:17 +02:00
Bruno Kirschner	80728a2201	Reduced scope of `nonminimal_bool` so that it doesn't evaluate only partially orded types.	2018-06-03 21:46:09 +02:00
Bruno Kirschner	09ea75bee9	Fixed spelling and indentation issues in neg_cmp_op_on_partial_ord related files.	2018-06-03 21:46:09 +02:00
Bruno Kirschner	6d51559f62	Added lint to avoid negated comparisions on partially ordered types.	2018-06-03 21:46:09 +02:00
Oliver Schneider	c6d53ad2c0	Merge pull request #2813 from terry90/master unreadable_literal: Fills hexadecimal values with 0 to allow better grouping	2018-06-03 12:53:45 +02:00
Victor Korkin	24ab207671	Divide FN_TO_NUMERIC lint into two. FN_TO_NUMERIC_CAST_WITH_TRUNCATION is correctness check FN_TO_NUMERIC_CAST is only style check	2018-06-01 23:08:11 +07:00
Oliver Schneider	1ba658772a	Merge pull request #2816 from mockersf/multiple-impl adding to restriction a lint that check for multiple inherent implementations	2018-05-31 13:33:35 +02:00
Victor Korkin	ded2576957	Add one more test	2018-05-31 09:00:13 +07:00
Wim Looman	edcb8f6976	Use compiletest::make_tests to allow it to setup the output folders	2018-05-30 21:26:09 +02:00
Wim Looman	3244d122fd	Get compile-test tests for configuration working	2018-05-30 20:37:18 +02:00
Victor Korkin	e6811b9c26	Fix 'help' message	2018-05-30 16:55:03 +07:00
Victor Korkin	b69520f5fd	Fixes for suggestion message, tests and lint explanation.	2018-05-30 11:48:46 +07:00
Victor Korkin	e4b2a97401	weird thing	2018-05-30 07:55:48 +07:00
François Mockers	44f4ea6dbf	adding to pedantic a lint that check for multiple inherent implementations	2018-05-29 21:28:52 +02:00
Devon Hollowood	8134863c13	Fix behavior with generic lifetime parameters	2018-05-29 09:18:49 -07:00
Devon Hollowood	96b11a5888	Test that we allow non-static lifetime transmutes	2018-05-29 09:18:49 -07:00
Devon Hollowood	2a606b5220	Don't lint lifetime-only transmutes	2018-05-29 09:18:49 -07:00
Victor Korkin	f6e0388e08	Change lint type to unique and add the suggestion.	2018-05-29 22:56:38 +07:00
Mateusz Mikuła	8ed8ee895a	Update to nightly 2018-05-28	2018-05-29 10:56:58 +02:00
Victor Korkin	01be53f929	Little fix for test	2018-05-28 23:49:38 +07:00
Victor Korkin	cf8f379657	Add lint on cast Fn to numerical.	2018-05-28 23:31:55 +07:00
Andrea Lattuada	5db444dfed	author tests: update for_loop.stdout file	2018-05-28 14:50:41 +02:00
Andrea Lattuada	bc1de58d26	Test for ExprCall in clippy::author	2018-05-28 14:48:34 +02:00
Terry Raimondo	ed011c45c4	Update other tests	2018-05-28 14:43:44 +02:00
Terry Raimondo	b81fd202a0	Add tests Fix tests	2018-05-28 14:23:06 +02:00
Terry Raimondo	2033a1eb0e	unreadable_literal: Fills hexadecimal values with 0 to allow grouping (c.f #2300 )	2018-05-28 13:55:27 +02:00
Oliver Schneider	0d1e06d638	Merge pull request #2808 from Aaronepower/master Added lint for unnecessary references.	2018-05-28 13:50:31 +02:00
Aaron Power	8b679176fa	Added lint for unnecessary references	2018-05-28 13:07:19 +02:00
Oliver Schneider	b979f62aab	Merge pull request #2810 from Aaronepower/stable_feature_flags Removed stable feature flags	2018-05-28 12:59:25 +02:00
Aaron Power	1931f53396	Removed stable feature flags	2018-05-28 10:03:27 +02:00
François Mockers	5379fc1b28	better parsing of condition in while loop for mutability allow condition to be a block: by calling visit_expr of the visitor directly on the condition instead of walk_expr on the whole expression, we bypass the match to ExprWhile that calls visit_expr on the condition and visit_block on the body. This allow to re-enable visit_block in the visitor, as it won't be called on the while body allow condition to use static variables: maintain a list of static variables used, and if they are mutable	2018-05-27 23:59:07 +02:00
Oliver Schneider	fc008aa14c	Rustup	2018-05-26 10:23:34 +02:00
Michael A. Plikk	1f10dd2606	Fix note on macro outside current crate. Changed group to restricted	2018-05-24 19:38:40 +02:00
Michael A. Plikk	dc8d29be4a	Allow unimplemented in other tests	2018-05-24 16:30:26 +02:00
Michael A. Plikk	88c3c2f1c2	Rename panic files to panic_unimplemented	2018-05-24 10:04:18 +02:00
Michael A. Plikk	77794e91e2	Create lint for unimplemented!()	2018-05-24 10:04:18 +02:00
Mateusz Mikuła	3c6503eb4b	Format code	2018-05-22 10:21:42 +02:00
Philipp Hansch	74be5632a3	Fix chrono crash due to empty param_env	2018-05-21 17:58:34 +02:00
Oliver Schneider	e0df4ccfc5	Use the new scoped tool attributes	2018-05-19 14:04:57 +02:00
Philipp Hansch	ed885dc2b3	Fix ICE for issues 2767, 2499, 1782	2018-05-17 21:12:07 +02:00
Philipp Hansch	21e783d3b6	Add run-pass tests for SpanlessEq/SpanlessHash ICE	2018-05-17 20:47:21 +02:00
Oliver Schneider	18a5b90242	Merge pull request #2712 from rust-lang-nursery/oli-obk-patch-1 Deprecate plugin-clippy	2018-05-12 11:13:37 +02:00
Oliver Schneider	22bef4ce28	Patterns, locals and matches for author lint	2018-05-11 19:05:34 +02:00
Oliver Schneider	fd8a1d20cc	Remove all mention and testing of #[plugin(clippy)] and warn if used	2018-05-11 13:20:39 +02:00
Philipp Hansch	be3cba8852	Merge pull request #2735 from rust-lang-nursery/ice_melting Check that we don't treat any type but a range type as a range	2018-05-09 21:56:34 +02:00
flip1995	db4e7ac725	panic_params: don't lint escaped squigglies	2018-05-09 12:29:28 +02:00
Oliver Schneider	c6e35eae53	Check that we don't treat any type but a range type as a range	2018-05-08 17:16:01 +02:00
NiekGr	e7a6b3e613	Update len_zero to handle comparisions with one I have added test cases for comparisons with zero and one. While implementing handling of one, incorrect handlings of zero were also fixed. fixes rust-lang-nursery/rust-clippy/#2554	2018-05-06 23:54:05 +02:00
Evan Simmons	d4b536f540	Fix 1x..x.0 false positive, pretty suggestion	2018-05-05 09:45:14 -07:00
Oliver Schneider	c1b39c4551	Merge pull request #2713 from alexreg/nightly-fix Fixed build for latest rust master	2018-05-04 15:06:59 +02:00
Oliver Schneider	c7ce6c07b1	Rustup field -> method transition of ..=	2018-05-03 15:52:44 +02:00
Philipp Hansch	5d36edc90d	Prevent crash when macro is in different file This was caused by a macro in a different file. The `target.span` was be in the file of the macro definition and the `item.span` in the file of the calling code.	2018-05-01 18:46:15 +02:00
Mateusz Mikuła	cc7d66aa9c	rustup	2018-04-27 14:00:43 +02:00
Oliver Schneider	3b6440212d	Merge pull request #2673 from estk/excessive_precision Excessive precision	2018-04-25 18:37:42 +02:00
Evan Simmons	9b14ad493b	New excessive precision lint for floats	2018-04-24 15:18:23 -07:00
Devon Hollowood	f0e09d43c9	Make cast_ptr_alignment ignore c_void	2018-04-24 11:37:51 -07:00
Oliver Schneider	faefb4f225	Merge pull request #2684 from 17cupsofcoffee/infallible-destructuring-match Lint for destructuring tuple structs/variants with an infallible single-armed match	2018-04-24 19:08:27 +02:00
Joe Clay	3c38a36d5a	Implement lint for destructuring tuple structs with a let and a match (closes #2671 )	2018-04-24 17:56:13 +01:00
Brad Gibson	1969d423a7	Corrected messaging to warn against less- to more-strictly align types, rather than the other way around. No logic changes required.	2018-04-23 10:59:53 -07:00
Michael Recachinas	a317bc9d23	Update stderrs for print and write_literal	2018-04-21 19:51:58 +01:00
Michael Recachinas	8ccaa83e90	Add more tests to print_ and write_literal Also, move precision, width, and debug fmt tests to 'should pass'	2018-04-21 19:51:35 +01:00
Oliver Schneider	ae3213747d	Merge pull request #1467 from philipturnbull/option_map_nil_fn Lint `Option.map(f)` where f returns unit	2018-04-15 16:14:25 +02:00
$MSI\Stew's Laptop$ MSI\Stew's Laptop	d175c797e5	fixing error message for empty println macro	2018-04-15 14:00:28 +02:00
Philipp Hansch	4f4e20c561	Also lint Result.map for unit returns	2018-04-15 13:59:57 +02:00
Philipp Hansch	8307a899e9	Rename option_map_unit_fn to map_unit_fn	2018-04-15 13:01:10 +02:00
Philipp Hansch	d54f70f1f6	Generate let binding variable name for some cases Given a map call like `x.field.map ...` the suggestion will contain: `if let Some(x_field) ...` Given a map call like `x.map ...` the suggestion will contain: `if let Some(_x) ...` Otherwise it will suggest: `if let Some(_) ...`	2018-04-15 13:01:10 +02:00
Philipp Hansch	d87385b406	Use approximate_suggestion for non-reducible closures	2018-04-15 13:01:10 +02:00
Philipp Hansch	7de707fdba	Remove further semicolon reduction	2018-04-15 13:01:10 +02:00
Philipp Hansch	db60c67c5b	Allow new lint in ui/eta.rs	2018-04-15 13:01:09 +02:00
Philipp Hansch	bcc335fc9c	Move test to new UI test system	2018-04-15 13:01:09 +02:00
Phil Turnbull	d0bdfe5ce3	Handle non-trivial nil closures `reduce_nil_closure` mixed together a) 'is this a nil closure?' and b) 'can it be reduced to a simple expression?'. Split the logic into two functions so we can still generate a basic warning when the closure can't be simplified.	2018-04-15 13:01:09 +02:00
Phil Turnbull	30f2480fd8	Lint closures that return nil	2018-04-15 13:01:09 +02:00
Phil Turnbull	302f5d05f5	Lint `Option.map(f)` where f never returns	2018-04-15 13:01:09 +02:00
Phil Turnbull	e5ecbb55ee	Lint `Option.map(f)` where f returns nil	2018-04-15 13:01:09 +02:00
Oliver Schneider	b2e4b88d18	Merge pull request #2662 from mikerite/issue_2546 Fix useless_format false negative	2018-04-15 11:57:57 +02:00
Philipp Hansch	dfde407f0d	Move unnecessary_fold UI tests to separate file	2018-04-12 22:16:43 +02:00
Michael Wright	6ae617b313	Fix useless_format false negative Closes #2546	2018-04-12 08:21:03 +02:00
Oliver Schneider	8ec61a613a	Merge pull request #2661 from devonhollowood/ptr-ptr-casts Replace `misaligned_transmute` lint	2018-04-11 13:23:15 +02:00
Devon Hollowood	b77d74030b	Deprecate misaligned_transmute	2018-04-11 02:50:04 -07:00
Devon Hollowood	c6bc682325	Fix misaligned_transmute lint This is done by adding two new lints: cast_ptr_alignment and transmute_ptr_to_ptr. These will replace misaligned_transmute.	2018-04-11 02:17:59 -07:00
Oliver Schneider	0692b2bb92	Temporarily disable the needless_borrow lint	2018-04-08 11:13:46 +02:00
Oliver Schneider	d247d9c690	Merge pull request #2645 from TimNN/regex-bytes-utf8 Allow invalid UTF-8 in bytes Regexes	2018-04-08 08:58:38 +02:00
Evan Simmons	d712991917	New lints for write! / writeln! macros.	2018-04-07 22:45:26 -07:00
Tim Neumann	fad826f966	allow invalid UTF-8 in bytes Regexes	2018-04-07 22:18:51 +02:00
Oliver Schneider	22df45f1ac	Merge pull request #2644 from phansch/fix_nonminimal_bool_false_positive Fix nonminimal_bool false positive	2018-04-07 13:17:04 +02:00
Philipp Hansch	90e7d93d6c	Fix nonminimal_bool false positive It was checking any is_ok, is_err, is_some, is_none method for negation but it should only perform the check for the built-in types, not custom types.	2018-04-07 12:52:59 +02:00
Philipp Hansch	5abe34832d	Split up match_bool UI tests	2018-04-07 10:23:27 +02:00
Oliver Schneider	044b3d90c3	Merge pull request #2633 from mikerite/ref_cow_tests Move ref cow tests	2018-04-06 12:15:33 +02:00
Philipp Hansch	641f0685d0	Split up some single_match UI tests This moves only the single_match tests over to the new file.	2018-04-05 22:45:36 +02:00
Michael Wright	2fd671e4bd	Move ref cow tests This commit moves the ref cow tests from needless_borrow.rs to ptr_arg.rs where all the other PTR_ARG tests are.	2018-04-05 18:13:39 +02:00
Oliver Schneider	62d595b3dc	Merge pull request #2632 from phansch/fix_useless_format_false_positive Fix useless_format false positive with macros	2018-04-05 09:59:12 +02:00
Philipp Hansch	ff98e3f9f5	Fix useless_format false positive with macros Clippy was issuing a warning when `format!` was used inside a macro. That's a problem because macros have different syntax and can be outside the control of the user. This skips the `useless_format` check if the `format!` call is inside a macro.	2018-04-05 07:52:26 +02:00
memoryleak47	d9508ba99d	typo	2018-04-05 04:13:14 +02:00
flip1995	cecfdeab19	Don't trigger while_immutable_condition for mutable fields of tuples/structs	2018-04-03 16:41:30 +02:00
Michael Wright	6fc9d90b60	Re-enable dogfood test on Windows This should work now that dogfood uses a separate output directory.	2018-04-03 06:22:42 +02:00
Oliver Schneider	90fcdafb79	Merge pull request #2608 from mrecachinas/feature/print-string-literal Check for literals as println! args	2018-04-02 23:34:17 +02:00
Michael Recachinas	fa8161ba2e	Revert adding env! to tests	2018-04-02 21:34:04 +01:00
Michael Recachinas	d504290839	Add edge case with env! arg to test and known problems	2018-04-02 21:14:29 +01:00
Michael Wright	0fbcb30303	Merge branch 'master' into dogfood_target_dir	2018-04-02 07:28:10 +02:00
Michael Recachinas	ddd75fbfec	Add #![allow(print_literal)] to other test/ui/print_*.rs tests	2018-04-02 00:24:40 +01:00
Michael Recachinas	62220abfa6	Add implementation and tests for literal checking in print/println format args	2018-04-01 23:19:53 +01:00
Michael Wright	1ab96db791	Make dogfood test output to seperate directory This commit makes `cargo clippy` output the build artifacts to a separate directory if the `CLIPPY_DOGFOOD` env var is set. This should prevent dogfood builds from interfering with regular builds. This should help with issue #2595.	2018-04-01 09:44:30 +02:00
Philipp Hansch	db1ec44616	Handle nested block comments	2018-03-30 12:36:50 +02:00
Philipp Hansch	b7929cafe1	Fix false positive in empty_line_after_outer_attr Before, when you had a block comment between an attribute and the following item like this: ```rust \#[crate_type = "lib"] /* */ pub struct Rust; ``` It would cause a false positive on the lint, because there is an empty line inside the block comment. This makes sure that basic block comments are detected and removed from the snippet that was created before.	2018-03-30 12:36:50 +02:00
Oliver Schneider	c1bbc173da	Address review comments	2018-03-29 13:41:53 +02:00
Oliver Schneider	eafb9fe8df	Update test suite	2018-03-28 23:49:32 +02:00
Oliver Schneider	d6344c47e3	Categorize all the lints!	2018-03-28 15:24:26 +02:00
Oliver Schneider	b6e2c47df0	Merge pull request #2572 from flip1995/immut_while Fix check of immutable condition in closure	2018-03-27 07:07:27 +02:00
Michael Wright	546d2fec29	Fix enum_glob_use false positives Closes #2397. This checks the def of the `ItemUse` path instead of checking the capitalization of the path segements. It was noted that this def would sometimes be `Def::Mod` instead of `Def::Enum` but it seems correct now.	2018-03-27 06:34:11 +02:00
flip1995	7d29075132	Skip the mutation in while body case for closures	2018-03-27 02:13:06 +02:00
flip1995	d458f22d89	Fix check of immutable condition in closure	2018-03-27 01:21:25 +02:00
Oliver Schneider	b01b0083ba	Merge pull request #2576 from kimsnj/infinite_loop while_immutable_condition: fix handling of self	2018-03-27 00:06:16 +02:00
Karim Snj	737247e50e	while_immutable_condition: limit suggestion span to condition	2018-03-26 23:24:57 +02:00
Karim Snj	85bcaad412	while_immutable_condition: fix handling of self	2018-03-26 23:16:54 +02:00
Philipp Hansch	034c81b761	Fix false positive in empty_line_after_outer_attribute `empty_line_after_outer_attribute` produced a false positive warning when deriving `Copy` and/or `Clone` for an item. It looks like the second point in [this comment][that_comment] is related, as the attribute that causes the false positive has a path of `rustc_copy_clone_marker`. Fixes #2475 [that_comment]: https://github.com/rust-lang/rust/issues/35900#issuecomment-245978831	2018-03-26 21:57:42 +02:00
Oliver Schneider	1aaeb3f16b	Update needless_lifetimes_impl_trait.rs	2018-03-26 07:05:46 +02:00
Oliver Schneider	9fb63d5fc4	Merge pull request #2574 from mark-i-m/i128 i128 is stabilizing	2018-03-26 07:04:42 +02:00
Mark Mansi	e9f6a7c72f	whitespace	2018-03-25 21:26:10 -05:00
Mark Mansi	e2d7ef9972	attempt fix stderr	2018-03-25 21:17:38 -05:00
Mark Mansi	f25d4fd253	make it pass for now	2018-03-25 21:04:05 -05:00
Mark Mansi	748ad9fb4b	i128 is stable	2018-03-25 20:34:44 -05:00
Michael Wright	2b68f00722	Add tests to ensure that issue #2420 is resolved The issue was probably fixed by `ff32d5f7`. Closes #2420.	2018-03-23 20:26:52 +02:00
Oliver Schneider	2d01f42dde	Merge pull request #2539 from Baelyk/master Add suggestion to useless_format	2018-03-20 08:22:04 +01:00
Baelyk	48027105dc	Add suggestion to useless_format Resolves #2505 Suggests that you use `"foo".to_string()` instead of `format!("foo")`.	2018-03-19 09:27:15 -05:00
flip1995	ad459184a3	Don't lint comparison operators in arithmetic impls	2018-03-17 22:02:34 +01:00
Mateusz Mikuła	23bfa396a0	Format code Signed-off-by: Mateusz Mikuła <mati865@gmail.com>	2018-03-16 10:54:49 +01:00
Oliver Schneider	8749927973	Rustup	2018-03-16 09:44:20 +01:00
Mateusz Mikuła	3662ee76ab	Merge branch 'miri'	2018-03-15 10:49:13 +01:00
Mateusz Mikuła	ca785afc31	Update tests Signed-off-by: Mateusz Mikuła <mati865@gmail.com>	2018-03-15 10:25:57 +01:00
Oliver Schneider	21f387d278	Update dependencies	2018-03-13 16:54:13 +01:00
Oliver Schneider	f7b2578aea	Update to rustc master	2018-03-13 11:38:21 +01:00
Hidehito Yabuuchi	ed769a3bc4	Ignore all macros in redundant_field_names	2018-03-11 13:57:28 +09:00
Karim Snj	ae5354e6ef	lint: while immutable condition: do not lint constants	2018-03-07 18:25:09 +01:00
Oliver Schneider	4cf02c7e1a	Merge pull request #2483 from kimsnj/infinite_loop immutable while condition	2018-03-07 08:09:48 +01:00
Karim Snj	814827113e	lint: immutable condition: add internally mutable test	2018-03-06 18:27:11 +01:00
Oliver Schneider	7d5ecd5ad5	Merge pull request #2511 from flip1995/sus_impl UnNeg and UnNot count as additional operations now	2018-03-06 14:35:54 +01:00
Niklas Fiekas	d55890a2b1	Increase unreadable_literal digits (fixes #1958 )	2018-03-06 14:24:01 +01:00
flip1995	ed4535641b	UnNeg and UnNot count as additional operations now	2018-03-06 13:58:03 +01:00
Oliver Schneider	05f92b84c9	Merge pull request #2507 from ordovicia/redundant_field_names_range Don't lint range syntax with var name `start` and/or `end`	2018-03-05 09:41:00 +01:00
Oliver Schneider	40ebff8c7a	Merge pull request #2493 from bootandy/fix_cow Lint passing Cow by reference	2018-03-05 09:35:11 +01:00
Hidehito Yabuuchi	cdb60c6547	Make `redundant_field_name` not care range expressions Hand-written `Range` struct family are treated normally.	2018-03-05 17:30:07 +09:00
Oliver Schneider	598acba7d5	Merge pull request #2497 from waywardmonkeys/single-char-pattern Fix single_char_pattern for \n, \t, etc.	2018-03-05 08:43:17 +01:00
Oliver Schneider	6662aa41f9	Merge branch 'master' into fix_cow	2018-03-05 08:42:19 +01:00
Oliver Schneider	f071d1994f	Merge pull request #2504 from flip1995/lit_float_repr Fix unreadable_literal lint for scientific float notation	2018-03-05 08:38:32 +01:00
Oliver Schneider	5b48b03375	Typo	2018-03-05 08:33:37 +01:00
Hidehito Yabuuchi	7b59557dcd	Don't lint range syntax with var name `start` and `end`	2018-03-05 14:31:37 +09:00
HMPerson1	3045f432c7	Fix #2496	2018-03-04 22:56:03 -05:00
flip1995	86ce897084	Fix unreadable_literal lint for scientific float notation	2018-03-04 16:28:34 +01:00
bootandy	e3c13da830	Change recomendation to: &[type] from Cow<type>	2018-03-03 12:25:20 -05:00
Alex Butler	fc5b377cec	Fix #2494 add suggestion for unreadable_literal Add `rustc --explain E0308` line to relevant tests	2018-03-03 12:25:20 -05:00
Bruce Mitchener	769a1d9b6c	Fix single_char_pattern for \n, \t, etc. Single characters that are escaped weren't being searched / replaced correctly in the hint string, so it was saying to replace, say, `"\n"` with `"\n"` rather than `'\n'`.	2018-03-02 22:00:01 +07:00
Karim Snj	7d35fab304	lint: while loop: detect if no var from the condition is mutated	2018-03-02 00:01:08 +01:00
Karim Snj	37eca59438	lint: while immutable condition: refactor to use hir::Visitor	2018-03-01 22:00:43 +01:00
Alex Butler	42000c6cf9	Fix #2494 add suggestion for unreadable_literal Add `rustc --explain E0308` line to relevant tests	2018-03-01 15:26:39 +00:00
bootandy	9a002e52e5	Lint passing Cow by reference Add lint for reference to Cow to the same place in the code where lint for reference to String lives. https://github.com/rust-lang-nursery/rust-clippy/issues/2405	2018-02-28 10:24:10 -05:00
Karim Snj	5c1be4a4ba	lint: immutable only vars in while condition	2018-02-25 18:25:31 +01:00
Guillem Nieto	8494f57c82	Fix author lint The author lint was generating invalid code as shown on issue: https://github.com/rust-lang-nursery/rust-clippy/issues/2442 I've changed the generated code to properly track cast expressions. Unfortunatelly, I've had to rewrite the `visit_decl` method, to avoid that last if of the chain will be added. After looking at the code, this last line was being added because of the `let x: char` part, but not because of the `0x45df as char` expression. It seems that let statements should not generate code on the author lint, but I'm not sure that this is true or if I'm breaking something on other code generation parts. Finally, I've added a test for the author lint, but I'm not sure that this needs to be added to the testsuite.	2018-02-24 02:19:47 +01:00
Oliver Schneider	575c3c4b54	Merge pull request #2471 from bootandy/fix_span2 Fix: point to correct problem part of code, update test	2018-02-23 08:31:57 +01:00
Oliver Schneider	5e6342d4ae	Merge pull request #2473 from phansch/handle_multiline_attributes Lint multiline attributes properly	2018-02-21 21:44:04 +01:00
Philipp Hansch	d3d3d7d7be	Lint multiline attributes properly This makes it so that the `empty_line_after_outer_attribute` lint only checks for newlines between the end of the attribute and the beginning of the following item. We need to check for the empty line count being bigger than 2 because now the snippet of valid code contains only `\n` and splitting it produces `["", ""]` Invalid code will contain more than 2 empty strings.	2018-02-21 21:29:05 +01:00
bootandy	a7c97256dc	Stop unwanted newlines being applied on unwrap_or	2018-02-21 11:29:08 -05:00
bootandy	f3d1a0cec2	Add newlines in unwrap_or ui test	2018-02-20 12:37:30 -05:00
bootandy	941e062fd4	Fix: point to correct problem part of code Fix span so it no longer contains the whole train-wreck of code and only points to the problem function (for the unwrap_or lint). https://github.com/rust-lang-nursery/rust-clippy/issues/2422 Update ui test methods - it had several cases where the error message span is now shorter	2018-02-19 12:14:53 -05:00
Philipp Krones	c43e053f3f	Merge branch 'master' into suspicious_impl	2018-02-19 13:04:14 +01:00
flip1995	aa20277a17	Lint for suspicious implementations of arithmetic std::ops traits	2018-02-13 15:40:17 +01:00
TomasKralCZ	42120141bd	Suggestion fixed, simplified lint logic.	2018-02-12 11:26:00 +01:00
TomasKralCZ	85642ddd23	Implement redundant field names lint #2244	2018-02-10 22:52:31 +01:00
Oliver Schneider	6feb0dd982	Fixes #2426 (if_same_then_else false positive)	2018-02-09 15:31:55 +01:00
Oliver Schneider	ff32d5f734	Fix #2427	2018-02-09 15:25:12 +01:00
Jonathan Goodman	44780aca5d	make the copies.rs test actually test the correct lints	2018-02-08 13:26:50 -06:00
Oliver Schneider	6f48e37d22	Merge pull request #2444 from phansch/fix_incorrect_useless_attribute_suggestion Partly fix incorrect useless_attribute suggestion	2018-02-07 09:07:46 +01:00
Philipp Hansch	81f5969704	Partly fix incorrect useless_attribute suggestion This fixes an incorrect suggestion from the `useless_attribute` lint when using `cfg_attr`. Additionally, it will not show a suggestion anymore, if the attribute begins on a previous line, because it is much harder to construct the span of multi-line `cfg_attr` attributes as they don't appear in the AST. To fix it completely, one would have to parse upwards into the file, and find the beginning of the `cfg_attr` attribute.	2018-02-06 22:35:11 +01:00
Jonathan Goodman	73f2ba5ded	don't suggest eliding 'static on associated consts	2018-02-06 12:22:34 -06:00
flip1995	63a7daf78c	Make decimal_literal_representation a restriction lint	2018-02-06 13:05:20 +01:00
Guillem Nieto	bcf2e41421	Fix ICE comparing `ExprRange` `eq_expr` on hir::utils was throwing an ICE due to an invalid LateContext being used. Due to this missusage, it was generating an ICE with the code on the following issue: https://github.com/rust-lang-nursery/rust-clippy/issues/2423	2018-02-06 01:06:32 +01:00
Oliver Schneider	30a37efaac	Merge pull request #2433 from kimsnj/matches_sugg Fix suggestions for ref matches	2018-02-05 08:21:21 +01:00
Oliver Schneider	7fddc6116e	Merge pull request #2415 from HMPerson1/fix-2356 Fix `ImplItem`s being ignored	2018-02-05 08:19:11 +01:00
Oliver Schneider	bef22006b4	Merge pull request #2419 from phansch/fix_doc_comment_false_positive Fix false positive in empty_line_after_outer_attr	2018-02-05 08:17:29 +01:00
Karim Snj	21f606bd68	Removing extra newline	2018-02-04 13:55:37 +01:00
Karim Snj	9575dac491	Fix suggestions for ref matches	2018-02-04 13:41:54 +01:00
HMPerson1	10d2feddba	Fix `const_static_lifetime`	2018-02-02 02:03:21 -05:00
HMPerson1	ff83b3ecb9	Fix `non_expressive_names`	2018-02-02 01:54:07 -05:00
HMPerson1	3a4ea45821	Fix `get_enclosing_block`	2018-02-02 01:53:48 -05:00
Oliver Schneider	d5bac82837	Give travis a guaranteed existing directory for ui test output	2018-02-01 14:35:56 +01:00
Philipp Hansch	a64724fac4	Fix false positive in empty_line_after_outer_attr Doc comments are syntactic sugar for #[doc] attributes, so this lint was catching them, too. This commit makes it so that doc comments are ignored in this lint. I think, for normal attributes it makes sense to warn about following empty lines, for doc comments, less. This way the user has some freedom over the formatting.	2018-02-01 07:43:03 +01:00
Guillem Nieto	05ed421930	Update UI tests	2018-01-31 00:10:35 +01:00
Guillem Nieto	74ae9b15b5	Add question mark operator	2018-01-31 00:10:35 +01:00
flip1995	bd421cb5a5	Additionally suggest the semantic equal variant	2018-01-30 17:45:35 +01:00
flip1995	b7cb0752ff	Improved suggestion on misrefactored_assign_op lint. Fixes #1239	2018-01-30 14:58:38 +01:00
Oliver Schneider	39d1d6081f	Merge pull request #2340 from phansch/newline_after_attributes Warn on empty lines after outer attributes	2018-01-30 13:09:23 +01:00
Seiichi Uchida	a3c2323767	Add double comparions lint	2018-01-30 10:35:35 +09:00
Tim Nielens	0778ac81c8	#1121 : already fixed, adding a test	2018-01-29 16:52:22 +01:00
Philipp Hansch	aade0d563e	Make lint work on all members of ast::Item_	2018-01-29 10:03:52 +01:00
Philipp Hansch	83909398d2	Add test case for comments between item and attr	2018-01-29 10:03:52 +01:00
Philipp Hansch	80827c1f74	Warn on empty lines after outer attributes	2018-01-29 10:03:52 +01:00
Manish Goregaokar	4b9a0b8644	Update spans	2018-01-29 09:48:11 +05:30
Manish Goregaokar	bca80a83a5	mut_mut_macro is missing plugin(clippy)	2018-01-29 09:48:06 +05:30
Devon Hollowood	0413b3f6cf	Add misaligned_transmute lint	2018-01-25 00:48:36 -08:00
Oliver Schneider	ea042657e5	Enable more patterns in the author lint	2018-01-24 13:04:06 +01:00
flip1995	31892e205e	let invalid_regex point to the right place for raw strings	2018-01-23 16:52:14 +01:00
Oliver Schneider	8e7f76db9a	Merge pull request #2362 from flip1995/master Lint for numeric literals that have a better representation	2018-01-23 15:54:35 +01:00
flip1995	600147926b	Apply requested changes	2018-01-23 15:29:31 +01:00
flip1995	d7677fb2b6	Adapt to updated ui tests	2018-01-23 12:52:20 +01:00
flip1995	23f90afa1b	Add configurable threshold, default: 4096	2018-01-23 12:34:40 +01:00
Phil Ellison	2132e5c58c	Fix unnecessary_fold bug	2018-01-22 05:34:42 +00:00
Oliver Schneider	e6428873cb	Merge pull request #2350 from theotherphil/fold_any Lint for using hand-writing a fold with the same behaviour as any	2018-01-19 13:31:00 +01:00
Oliver Schneider	71abd81d22	Update error count	2018-01-19 13:18:44 +01:00
Oliver Schneider	920fc17485	Don't run dogfood on windows or in the rustc test suite	2018-01-19 13:14:43 +01:00
Oliver Schneider	70302595a4	Merge branch 'master' of github.com:Manishearth/rust-clippy into fold_any	2018-01-19 12:10:24 +01:00
Oliver Schneider	9a2c50f3d6	Merge pull request #2364 from flip1995/precedence Add macro check to precedence lint	2018-01-19 12:07:00 +01:00
Oliver Schneider	3c6064130b	Merge pull request #2367 from etaoins/inline-fn-without-body-lint Lint for trait methods without bodies	2018-01-19 09:14:46 +01:00
Oliver Schneider	26c415ab2d	Merge pull request #2381 from HMPerson1/remove_is_unit_expr Replace `is_unit_expr`	2018-01-19 09:14:04 +01:00
Michael Wright	79c6c60f51	Added further tests	2018-01-19 08:10:09 +02:00
Michael Wright	fca248957b	Merge branch 'master' into option_option_pr	2018-01-19 07:56:46 +02:00
HMPerson1	8081f6fd6e	Replace `is_unit_expr`	2018-01-18 17:04:26 -05:00
Oliver Schneider	10c96e50c3	Don't run dogfood tests in the rustc test suite	2018-01-18 22:02:58 +01:00
Oliver Schneider	8217e33718	Only suggest implementing Copy if it can actually be done	2018-01-18 14:27:47 +01:00
Ryan Cumming	7467b83377	Suggest removing inline attributes This adds a `suggest_remove_item` helper that will remove an item and all trailing whitespace. This should handle both attributes on the same line as the function and on a separate line; the function takes the position of the original attribute.	2018-01-18 20:02:42 +11:00
Ryan Cumming	5f3c340bfb	Lint for trait methods without bodies As discussed in rust-lang/rust#47475 the #[inline] attribute is currently allowed on trait methods without bodies (i.e. without a default implementation). This is misleading as it could be interpreted as affecting the implementations of the trait method. Add a lint for any use of #[inline] on a trait method without a body. Fixes rust-lang/rust#47475	2018-01-18 20:01:24 +11:00
Manish Goregaokar	552e950080	needless_pass_by_value: Whitelist RangeArgument (fixes #2357 )	2018-01-18 14:30:53 +05:30
Manish Goregaokar	2a30c8a194	needless_pass_by_value: Add suggestion for implementing Copy (fixes #2222 )	2018-01-18 14:30:47 +05:30
Manish Goregaokar	cf1fbaa36a	needless_pass_by_value: Ignore for extern funcs (fixes #1844 )	2018-01-18 14:30:32 +05:30
Michael Wright	d13af87d8a	Fixed tests	2018-01-18 07:48:03 +02:00
Michael Wright	ec60baa864	Merge branch 'master' into option_option_pr	2018-01-18 07:21:48 +02:00
Phil Ellison	b73efad600	Add some reviewer comments	2018-01-17 21:06:16 +00:00
Phil Ellison	29a2dd4cb8	Fix bug. Don't expect lint when acc is on rhs	2018-01-17 20:11:40 +00:00
Phil Ellison	1cac693bc7	Lint on folds implementing .all, .sum and .product	2018-01-17 19:12:44 +00:00
Oliver Schneider	4f21b5b112	Update changed ui tests	2018-01-17 14:44:40 +01:00
Oliver Schneider	a2fdfc05d7	Merge pull request #2298 from goodmanjonathan/else_if_without_else add new lint else_if_without_else	2018-01-17 09:35:58 +01:00
Michael Wright	e7567f2eac	Made requested changes	2018-01-17 07:24:33 +02:00
Michael Wright	21fde9a9d1	Merge branch 'master' into option_option_pr	2018-01-17 06:52:00 +02:00
Phil Ellison	a64d19cc0e	Fix error span to play nicely with rustfix	2018-01-16 21:20:55 +00:00
Manish Goregaokar	37f62a54f8	Show wider and more accurate suggestion for const_static_lifetime fixes #2365	2018-01-16 20:46:44 +05:30
flip1995	877321ba32	Add macro check to precedence lint	2018-01-16 15:52:16 +01:00
flip1995	647da97622	Lint for numeric literals that have a better representation in another format	2018-01-16 14:01:07 +01:00
Oliver Schneider	61e2b7a4d6	Merge pull request #2355 from alusch/clone_on_ref_ptr_restriction Fix #2048: Move `clone_on_ref_ptr` to the restriction lints	2018-01-16 10:40:12 +01:00
Oliver Schneider	28c3d0321a	Update changed test output from rustc	2018-01-16 08:52:14 +01:00
Jonathan Goodman	40c6f431da	add new lint else_if_without_else	2018-01-14 22:53:00 -06:00
Adam Lusch	f343cd22f6	Adds the missing turbofish	2018-01-14 20:19:55 -08:00
Adam Lusch	30de2e7106	Update UI test expected output	2018-01-14 20:10:36 -08:00
Adam Lusch	1615813960	Moves `clone_on_ref_ptr` to be a restriction lint Also updates the suggestion to include the full type (e.g. `Arc<Foo>::clone(&rc)`) and adds a case using trait objects to the UI tests.	2018-01-14 19:58:09 -08:00
Phil Ellison	ad164939ed	Check that we're calling Iterator::fold	2018-01-14 20:04:34 +00:00
Phil Ellison	70a5535ffa	Address some review comments	2018-01-14 18:18:09 +00:00
Oliver Schneider	2f62d803ab	Merge pull request #2349 from rust-lang-nursery/no-main-doc Don't warn about missing docs for main()	2018-01-14 13:16:54 +01:00
Phil Ellison	1feb9fd550	Tidy using if_chain and snippet function. Actually check that the initial fold value is false. Remove some unwraps	2018-01-14 09:30:08 +00:00
Phil Ellison	f6e56d2559	First pass at linting for .any expressed as a .fold	2018-01-14 08:27:53 +00:00
Manish Goregaokar	7e63f93d81	Don't warn about missing docs for main() Fixes #2348	2018-01-14 11:35:08 +05:30
Oliver Schneider	cc9008b7d4	Merge pull request #2347 from kimsnj/extrem_comp Fix #1159: avoid comparing fixed and target sized types in lint	2018-01-13 12:27:36 +01:00
kimsnj	53c0ae0169	Fix #1159 : avoid comparing fixed and target sized types in lint	2018-01-12 18:33:25 +01:00
Oliver Schneider	b863a00a4e	Merge pull request #2344 from HMPerson1/svar_to_cfn Add lint to replace `const`s with `const fn`s	2018-01-12 14:59:06 +01:00
Oliver Schneider	7e21663f75	Merge pull request #2296 from DarrenTsung/test_types Start regression tests for types.rs	2018-01-12 14:55:39 +01:00
HMPerson1	8505ee7028	Add lint to replace `const`s with `const fn`s	2018-01-11 12:03:46 -05:00
Oliver Schneider	1245de1e46	Don't suggest changing explicit Clone impls if they have generics	2018-01-11 10:28:42 +01:00
Philipp Hansch	fded77d85e	Split up casting UI tests Part of #2038	2018-01-06 11:22:20 +01:00
Pascal Hertleif	82d91c5fcb	Add auto-fixable `println!()` suggestion Fixes #2319	2018-01-04 12:46:26 +01:00
Michael Wright	6737bae9b1	Implemented option_option lint	2017-12-26 09:24:12 +02:00
Darren Tsung	0f4c40b229	Start regression tests for types.rs	2017-12-23 10:15:11 -08:00
Darren Tsung	50eb48e42b	Create failing test for equal inside macro	2017-12-22 10:37:44 -08:00
Oliver Schneider	2179f4d790	Merge pull request #2284 from rust-lang-nursery/new-macro Move mini-macro to proc macro	2017-12-20 21:56:00 +01:00
Manish Goregaokar	775372db90	Move mini-macro to proc macro We can add a bang-style proc macro again once it stabilizes (we can use the proc macro hack, but it's unnecessary for now)	2017-12-20 08:16:44 -08:00
Wilco Kusee	a6ccc6fe3d	Also suggest as_mut for match_as_ref	2017-12-20 10:39:48 +01:00
Wilco Kusee	919601bc51	Lint for matching option as ref	2017-12-19 23:51:06 +01:00
Oliver Schneider	8ddcb81a15	Rustup and lazy_static version mismatch fix fixes #2274	2017-12-15 10:05:32 +01:00
Oliver Schneider	f5f0273f53	Update ui tests to latest rustc changes	2017-12-07 11:21:37 +01:00
laurent	6c18811764	Revert the regex test change.	2017-12-01 19:59:40 +00:00
laurent	904f27a2ea	Do raise a same-arms warning when the two arms are separated by an arm with a guard, fix #1996 .	2017-12-01 19:25:43 +00:00
HMPerson1	c2c324ec65	Update ui test	2017-11-30 19:50:31 -05:00
HMPerson1	e2bc383383	Add linting for empty blocks too	2017-11-30 19:40:40 -05:00
HMPerson1	5fca6eb89e	Fix #2160	2017-11-30 15:31:56 -05:00
Oliver Schneider	7d7fef1690	Fix #1925	2017-11-30 10:55:06 +01:00
Oliver Schneider	1c95a7cf35	Merge pull request #2251 from LaurentMazare/master Add a couple small tests to the match-same-arm lint + fix a small issue in search_same.	2017-11-30 10:53:48 +01:00
Oliver Schneider	4d9c41f566	Use latest compiletest	2017-11-30 09:31:23 +01:00
laurent	c3ae2ddeb3	Fix a bug in search_same + add a test case.	2017-11-29 21:42:58 +00:00
laurent	3eb642bcdd	Add another test.	2017-11-29 20:52:49 +00:00
laurent	f8dbd32433	Add a couple small tests to the match-same-arm lint.	2017-11-29 20:42:37 +00:00
Oliver Schneider	273ddafac5	Fix #2188	2017-11-29 17:20:00 +01:00
Oliver Schneider	d5b73c184b	Fix placement of new_without_default suggestion	2017-11-29 17:10:53 +01:00
Oliver Schneider	317e97bae7	Fix #2196	2017-11-29 17:06:27 +01:00
Oliver Schneider	e62727ee51	Add regression test (fixes #2234 )	2017-11-29 16:05:13 +01:00
Oliver Schneider	0b0337d258	Fix #2247	2017-11-29 15:52:57 +01:00
Oliver Schneider	ad63e4eaef	Update ui output to latest nightly	2017-11-29 15:45:12 +01:00
Oliver Schneider	34da5d93ef	Merge pull request #2246 from lukasstevens/master Check for word beginning in stutter lint	2017-11-27 11:05:37 +01:00
Oliver Schneider	656df3c5ed	Update stderr output to rustc changes	2017-11-27 10:20:38 +01:00
Lukas Stevens	d55d4e5144	Update ui tests	2017-11-26 18:57:34 +01:00
Oliver Schneider	af718413db	Rustup	2017-11-22 10:55:12 +01:00
Oliver Schneider	c5fa86da04	Merge pull request #2203 from clippered/float_cmp_const Fix #1142 float constant comparison lint	2017-11-20 09:51:12 +01:00
Laurent Mazare	e7f4a9bb46	Fix for the new nightly version.	2017-11-20 07:47:28 +00:00
laurent	41a6d015ff	More tests.	2017-11-19 11:29:25 +00:00
laurent	ed202b6055	Bugfix + add test.	2017-11-19 11:29:25 +00:00
Georg Brandl	76324851b5	tests: fixup arg handling for update-all-references This script does not take any args, so $1 being empty is expected.	2017-11-18 16:11:55 +01:00
Georg Brandl	296edda3a9	const_static_lifetime: this applies not only to path types For example, &'static [u8] or &'static (t1, t2).	2017-11-18 16:10:29 +01:00
Oliver Schneider	f975fb54f8	Merge pull request #2216 from LaurentMazare/master Handle methods with an obvious negation in the non-minimal bool lint	2017-11-15 09:08:36 +01:00
laurent	25783fa485	Raise a lint when suggest has simplified the expression.	2017-11-14 21:14:08 +00:00
Oliver Schneider	bdf3887d22	Move 'handle_method_call_in_not' code into 'suggest'	2017-11-14 17:07:04 +01:00
Oliver Schneider	561d47f338	Merge remote-tracking branch 'origin/master' into laurent_master	2017-11-14 16:46:56 +01:00
Oliver Schneider	b464432972	Merge branch 'master' of github.com:Manishearth/rust-clippy into rust-test	2017-11-14 16:31:52 +01:00
Oliver Schneider	127c41f700	Apply changes that were required for running in the rustc test suite	2017-11-14 14:56:00 +01:00
Oliver Schneider	09d988521d	Merge pull request #2214 from rust-lang-nursery/nrlfp Improve `needless_range_loop`	2017-11-10 10:11:20 +01:00
Oliver Schneider	299f1270a6	Rustup	2017-11-10 08:58:54 +01:00
Shotaro Yamada	b17899878f	Build path from current_dir	2017-11-09 14:47:14 +09:00
Shotaro Yamada	5c0b99820b	Use compiletest 0.3	2017-11-09 11:05:49 +09:00
laurent	82793768b7	Handle methods with an immediate negation in the non-minimal boolean lint, fixes #1930 .	2017-11-07 21:43:24 +00:00
Oliver Schneider	1b323b9f35	Don't lint mixed slice indexing and usize indexing in `needless_range_loop`	2017-11-07 15:32:52 +01:00
Oliver Schneider	652df0fb79	Differentiate between mutable iteration and immutable iteration in `needless_range_loop`	2017-11-07 14:41:54 +01:00
Oliver Schneider	088555c4ea	Merge pull request #2209 from sinkuu/trait_methods Fix false positive in needless_pass_by_value trait methods	2017-11-07 08:26:32 +01:00
laurent	c9681905ba	Fix broken tests.	2017-11-06 23:26:44 +00:00
laurent	e2b9cf836a	Fix merge issues.	2017-11-06 23:22:19 +00:00
sinkuu	6fb736bd42	Fix false positive in needless_pass_by_value trait methods	2017-11-07 06:33:49 +09:00
sinkuu	00081be73d	Rustup	2017-11-07 06:32:12 +09:00
clippered	66bc12564a	put back negative tests but allow float_cmp	2017-11-06 21:34:30 +11:00
clippered	ddaf8580d5	remove duplicate tests with float_cmp	2017-11-06 20:23:18 +11:00
clippered	cd3106d99f	add more negative tests	2017-11-06 20:02:42 +11:00
Oliver Schneider	ed589761e6	Merge pull request #2202 from topecongiro/format Run `cargo fmt`	2017-11-06 08:35:52 +01:00
Oliver Schneider	4018b0a495	Merge pull request #2197 from AlexEne/dissalow-underscores-and-numbrers Warns if variable name is composed only of underscores and digits.	2017-11-06 08:11:45 +01:00
laurent	bcdf57e220	Refactor the never-loop detection, fixes #1991 .	2017-11-05 14:43:28 +00:00
clippered	2787a60fc2	Fix #1142 float constant comparison lint	2017-11-05 09:37:17 +11:00
topecongiro	7a06d312fd	Cargo fmt	2017-11-05 04:55:56 +09:00
Alexandru Ene	f92c91601e	Addressed PR comments	2017-11-03 20:54:33 +00:00
sinkuu	d88cc5376e	Add test to take `Self` as an argument	2017-11-03 17:56:26 +09:00
sinkuu	be7c4b4862	Fix test	2017-11-03 17:36:38 +09:00
sinkuu	cad33c0306	Extend needless_pass_by_value to methods	2017-11-03 17:36:38 +09:00
cgm616	3902b836e7	Update tests	2017-11-02 23:54:35 -05:00
cgm616	ee289c9f88	Merge branch 'master' of github.com:rust-lang-nursery/rust-clippy	2017-11-02 22:57:07 -05:00
Alexandru Ene	9d01468bc7	Warns if variable name is composed only of underscores and digits.	2017-11-03 01:01:41 +00:00
Oliver Schneider	cabbc781ca	Merge pull request #2189 from gendx/pr-1590 Start working on #1590	2017-11-02 10:29:30 +01:00
sinkuu	7fa27d9387	Lint `transmute::<&[u8], &str>`	2017-11-01 18:05:46 +09:00
kennytm	44d3ea5308	Fix lint_without_lint_pass	2017-10-31 10:04:02 -07:00
Manish Goregaokar	c526c51923	Update clippy for rustc 1.23.0-nightly (f0fe716db 2017-10-30)	2017-10-31 00:07:10 -07:00
G. Endignoux	87fd68731d	Update UI tests.	2017-10-30 14:10:38 +01:00
G. Endignoux	f0a1eff1c4	Start working on #1590	2017-10-30 13:08:09 +01:00
Manish Goregaokar	09143cdaf0	Update tests; make it work with generics on context	2017-10-29 05:19:24 -04:00
cgm616	fed5a89076	Add tests for pub_restricted	2017-10-28 13:24:39 -05:00
cgm616	d094f98f0b	Merge branch 'master' of github.com:rust-lang-nursery/rust-clippy	2017-10-28 12:55:16 -05:00
Alex Burka	2153d1e560	manual fixups if_let_chain -> if_chain	2017-10-23 17:53:30 -04:00
Oliver Schneider	2771378620	Merge pull request #2136 from ykrivopalov/identity_op_fixing Identity/erasing operation lints	2017-10-23 09:25:08 +02:00
Oliver Schneider	b96639f23a	Merge pull request #2143 from HMPerson1/master Add lint for fallible impls of `From`	2017-10-23 09:21:31 +02:00
Oliver Schneider	6d89798119	Merge pull request #2163 from HMPerson1/useless_asref Add lint for useless `as_ref` calls	2017-10-23 09:16:44 +02:00
cgm616	29626b883e	Merge branch 'master' of github.com:rust-lang-nursery/rust-clippy	2017-10-22 10:14:44 -04:00
HMPerson1	bfa7a9b138	Add tests for generic code	2017-10-21 13:55:12 -04:00
cgm616	60c7bd47a5	Prevent should_implement_trait on private method This should close #2159.	2017-10-21 07:53:57 -04:00
sinkuu	00d35eea26	Fix typo	2017-10-21 19:16:13 +09:00
HMPerson1	7206023b1b	Change to `TryFrom`	2017-10-20 20:47:51 -04:00
HMPerson1	e5076d06db	Add lint for `From<String>`	2017-10-20 20:47:30 -04:00
HMPerson1	ff4a850353	Add lint for useless `as_ref` calls	2017-10-20 20:33:19 -04:00
Oliver Schneider	0e489f3221	Merge pull request #2146 from MaloJaffre/println_empty_string Add PRINTLN_EMPTY_STRING lint.	2017-10-20 17:39:34 +02:00
Malo Jaffré	22f3ca0e2c	Add PRINTLN_EMPTY_STRING lint.	2017-10-20 16:45:32 +02:00
Paul Florence	acdd93a5cc	Final .stderr for `const_static_lifetime`.	2017-10-20 10:17:55 -04:00
Paul Florence	0928168a79	Remove "#![feature(plugin)]" in the test".	2017-10-20 10:17:41 -04:00
Paul Florence	4bbda68d56	Better linting : use of span_lint_and_then.	2017-10-20 10:17:41 -04:00
Paul Florence	fbce504664	Added the test results.	2017-10-20 10:17:41 -04:00
Paul Florence	322effe415	Implementation of the `const_static_lifetime` lint.	2017-10-20 10:17:41 -04:00
Oliver Schneider	9293188b65	Merge pull request #2156 from cgm616/master Deprecate should_assert_eq lint	2017-10-20 15:24:52 +02:00
Oliver Schneider	281bd790de	Merge pull request #2148 from sinkuu/proc_macro needless_pass_by_value false-positive in annotation	2017-10-20 11:12:21 +02:00
cgm616	4960d9de86	Deprecate should_assert_eq lint This should close #2090.	2017-10-19 23:42:04 -05:00
sinkuu	9221bd9c97	Add test	2017-10-18 14:06:38 +09:00
clippered	dfa4cb7ade	Fix #2123 : check that the source and destination are different for manual memcpy	2017-10-18 07:06:01 +11:00
Oliver Schneider	f01e45faa4	Merge pull request #2131 from devonhollowood/suggest-print Suggest print	2017-10-17 15:26:41 +02:00
Oliver Schneider	343e438f9d	Merge pull request #2120 from sinkuu/implicit_hasher Implicit hasher lint	2017-10-17 15:24:20 +02:00
sinkuu	eea30777dd	Type parameter change and type change are now in a multispan suggestion	2017-10-17 21:40:46 +09:00
sinkuu	a4f45e85b1	Use cx.access_levels.exported() instead of visibility	2017-10-17 21:13:17 +09:00
Yury Krivopalov	7b16f4d7ff	Clarify message for erasing_op lint	2017-10-15 10:32:47 +03:00
Devon Hollowood	eda013d3af	Change lint filename suggest_print.rs -> explicit_write.rs	2017-10-14 21:42:14 -03:00
Devon Hollowood	aeeb38dab1	Change lint name From `suggest_print` to `explicit_write`	2017-10-14 21:26:50 -03:00
Yury Krivopalov	033c99b1ba	Add erasing_op lint For expressions that can be replaced by a zero.	2017-10-14 12:34:37 +03:00
Yury Krivopalov	f68e408cb6	identity_op lint fix for '&' with unsigned types	2017-10-14 12:21:23 +03:00
sinkuu	c3332ca92e	Fix panic with fake `Range` type	2017-10-13 21:51:57 +09:00
Devon Hollowood	e31a0941e2	Fix output for write macros	2017-10-12 05:53:20 -03:00
Devon Hollowood	1089380518	Add expected output	2017-10-12 05:33:00 -03:00
Devon Hollowood	888076b698	Add suggest_print lint	2017-10-12 05:30:35 -03:00
sinkuu	31f16b87b7	Use `rustc_typeck::hir_ty_to_ty`	2017-10-11 23:08:36 +09:00

... 12 13 14 15 16 ...

2426 commits