mirror of
https://github.com/bevyengine/bevy
synced 2024-12-19 01:23:09 +00:00
7662b4fe40
# Objective
Fix the following crash when using BRP to insert a malformed component:
```
thread 'main' panicked at /home/purplg/workspaces/evtc-replay/bevy/crates/bevy_remote/src/builtin_methods.rs:926:18:
called `Result::unwrap()` on an `Err` value: Error("invalid type: map, expected f32", line: 0, column: 0)
```
## Solution
Return an error instead of unwrapping.
## Testing
Tested by sending this malformed payload before and after implementing
the fix:
```json
{
"jsonrpc": "2.0",
"id": 0,
"method": "bevy/insert",
"params": {
"entity": 4294967307,
"components": {
"bevy_transform::components::transform::Transform": {
"rotation": [
0.0,
0.0,
0.0,
1.0
],
"scale": [
1.0,
1.0,
1.0
],
"translation": [
{},
0.0,
0.0
]
}
}
}
}
```
After implementing the fix, I receive the following response instead of
a crash:
```json
{
"jsonrpc": "2.0",
"id": 0,
"error": {
"code": -23402,
"message": "bevy_transform::components::transform::Transform is invalid: invalid type: map, expected f32"
}
}
```
|
||
|---|---|---|
| .. | ||
| bevy_a11y | ||
| bevy_animation | ||
| bevy_app | ||
| bevy_asset | ||
| bevy_audio | ||
| bevy_color | ||
| bevy_core | ||
| bevy_core_pipeline | ||
| bevy_derive | ||
| bevy_dev_tools | ||
| bevy_diagnostic | ||
| bevy_dylib | ||
| bevy_ecs | ||
| bevy_encase_derive | ||
| bevy_gilrs | ||
| bevy_gizmos | ||
| bevy_gltf | ||
| bevy_hierarchy | ||
| bevy_image | ||
| bevy_input | ||
| bevy_input_focus | ||
| bevy_internal | ||
| bevy_log | ||
| bevy_macro_utils | ||
| bevy_math | ||
| bevy_mesh | ||
| bevy_mikktspace | ||
| bevy_pbr | ||
| bevy_picking | ||
| bevy_ptr | ||
| bevy_reflect | ||
| bevy_remote | ||
| bevy_render | ||
| bevy_scene | ||
| bevy_sprite | ||
| bevy_state | ||
| bevy_tasks | ||
| bevy_text | ||
| bevy_time | ||
| bevy_transform | ||
| bevy_ui | ||
| bevy_utils | ||
| bevy_window | ||
| bevy_winit | ||