Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-18 00:13:10 +00:00
Code Issues Projects Releases Packages Wiki Activity
4788 commits 3 branches 76 tags 119 MiB
Commit graph

811 commits

Author SHA1 Message Date
Kurt
dd17ba0d3a Add master settings window 
#1864
need to hook into main window & delete old logic; when the logic flow
returns after closing the form, all the propagated settings will need to
be copied (ie where the setting is actually used).
translateinterface will translate the control text to a longform
descriptor per the current language.
 2018-03-22 23:04:04 -07:00
Kurt
aedc0092b4 Rework translations 
instead of:
controls on form->dict of names, look up line to find control
now:
dict of names->look up control to find name

faster overall, simpler, and updates the dictionary with new control
entries. browse thru forms that call translateinterface with one
language (english), then updateall(en) and dump to get the updated
translation files.

#1864
 2018-03-20 22:34:44 -07:00
ReignOfComputer
bf1b685705 Translate Showdown Markings & Fix PT Selection (#1872) 
Added translation strings for Apply Showdown Markings in CHS, French,
and Korean. International schools ftw.

Additionally, Portuguese was not accessible as it is Index 9 ("zh2",
which I assume is CHT, is at 8), so I've just hardcoded this bit since I
don't know if anything else relies on lang_val.
 2018-03-20 08:36:15 -07:00
Kurt
42f5f9b051 Add smart move[] setter 
Closes #1871 (smart-move setting is also done by batch editor)
 2018-03-20 08:35:41 -07:00
Kurt
e4c2b5d77a Split PPMax & PPCurrent edit methods 
As noted in #1866
 2018-03-19 16:21:29 -07:00
Kurt
dc0cf34ed5 Inherit sizing mode 
as noted:

https://projectpokemon.org/home/forums/topic/44417-messed-stat-screen-in-new-version/
 2018-03-19 16:15:46 -07:00
ReignOfComputer
a03a54a331 Fix Suggested Move Set (#1866) 
* Use FieldsLoaded to stop updates
 2018-03-19 09:03:27 -07:00
ReignOfComputer
d41df2420f Fix HaX Mode (#1869) 
- Pass HaX to StatEditor once everything else loads
- Fix Hacked Stats enabled check
 2018-03-19 08:10:20 -07:00
ReignOfComputer
430938d131 Showdown Markings Toggle (#1868) 
Perhaps we could have a temporary toggle while waiting for a master
settings page? :) Related: https://github.com/kwsch/PKHeX/issues/1864
https://github.com/kwsch/PKHeX/issues/1862
 2018-03-19 07:52:16 -07:00
Kurt
9bb4120ff9 add faster pkm slot presence check 
instead of checking if the array is empty, only check PID and species
 2018-03-18 16:22:21 -07:00
Kurt
b0dcdf0948 Update 18.03.19 
Update event binaries with latest from the Event Gallery
 2018-03-18 13:42:29 -07:00
Kurt
26cc266dd1 Move type sprite fetch remapping to pkmutil 
I still don't like it 100%
 2018-03-18 11:25:57 -07:00
Kurt
f55028c1a0 Fix KChart errors 
gen1 & gen2 types aren't laid out contiguously (yay bird type and extra
types)
fix gen2 type accessors looking at the wrong byte

type sprites now load correctly, and 3rd ability no longer throws an
error (forced to None).
 2018-03-18 11:22:20 -07:00
Kurt
1aa70a16a4 Reduce bst green scalar 
average*2 resulted in a value that was too-green relative to the stats.
use the rescaling from KChart
 2018-03-18 11:21:00 -07:00
Kurt
56bd39b336 Add base stat indication (with colors) 
Thanks @zaksabeast for feedback in IRC
 2018-03-18 10:38:29 -07:00
Kurt
d65d9e0b79 Add missing = 
lul oops
 2018-03-16 17:57:24 -07:00
Kurt
d1a789eeab Fix some pokedex4 behavior 
https://projectpokemon.org/home/forums/topic/44347-gen-4-pokédex-forms-incorrectly-readwritten/
 2018-03-16 17:54:47 -07:00
Kurt
102550174e Simplification 
invalid/unknown usages were incorrectly interchangable; dex-sets were
looking at Unknown which was impossible for some cases.

only use GameVersion.Unknown as a temp placeholder for later resolution
by the user.
 2018-03-11 18:07:48 -07:00
Kurt
2bd9d99d9e Refactoring 
WinForms->Core logic absorbing (CommonEdits)
loading ShowdownSet now applies properties to PKM instead of PKMEditor
Contest/IVs for Static/Trades are no longer set by default (less object
allocations), and are now checked by the encounter generator
 2018-03-10 18:03:09 -08:00
Kurt
cbf4038a95 Refactoring 
relocate gift data storage out of legal.cs
 2018-03-05 22:19:56 -08:00
Kurt
e4210e2b3e Misc api improvements 
extract common nature amp logic
generic ienumerable copyto which now returns count of elements copied
(maybe useful later). prior usages never tried to copy an enumerable
larger than the dest array (now length checked).
 2018-02-28 21:50:50 -08:00
Kurt
24982fe8c5 Misc simplifications 2018-02-28 21:05:50 -08:00
ReignOfComputer
faab067f80 Fix Inverted Max PP Shortcut (#1855) 
https://github.com/kwsch/PKHeX/issues/1854#issuecomment-369270152
 2018-02-28 08:58:04 -08:00
Kurt
9fb7268434 Fix hidden power combobox 
closes #1852
 2018-02-27 17:48:19 -08:00
Kurt
1411933e27 Relocate pkm stat controls to separate usercontrol 
splits the logic up
change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
 2018-02-26 21:22:35 -08:00
Kurt
934757eac1 Add Bank7 r/w 2018-02-24 13:03:32 -08:00
Kurt
f9002c6cc9 Add trashbyte copy for OT import on gen1/2 
Closes #1849
NAME_LENGTH is 11 for both gens and the offsets don't vary between
languages, so it's a simple fetch.
 2018-02-22 22:42:50 -08:00
Kurt
8e0ec17e9f Misc refactoring 
no functional changes
 2018-02-21 20:35:07 -08:00
Kurt
d62b34f140 Don't set HiddenAbility if HaX 
have user specify via 0x42 extrabyte as it can only be updated from
there.
closes #1846
 2018-02-19 23:34:07 -08:00
Kurt
26ca111630 Fix SetHPIVs order 
speed IV last -> speed IV first
closes #1844
 2018-02-18 09:54:17 -08:00
Kurt
d7271768b2 Only hyper train if the set level is adequate 
Closes #1841
wasn't clearing if level below
 2018-02-17 16:34:55 -08:00
Kurt
b75313cd87 Sync unsaved changes 
closes #1840
 2018-02-16 17:24:07 -08:00
Kurt
0a0b944de1 Use explicit generation param for forme fetch 
closes #1837
 2018-02-16 16:38:07 -08:00
Kurt
d706d825a9 Handle legal pichu form values 
Closes #1828 , thanks @SpiredMoth !

slightly optimize batrev key init
fix exception for pkm loading switching between gen3->4 saves
 2018-02-10 17:43:00 -08:00
Kurt
033d5baa06 Check EC-PID same for gen1/2 transfers 
Fix PID->EC on gen<3 transfers

https://projectpokemon.org/home/forums/topic/43779-about-vc-pokemons-pid-and-encryptionconstant/
 2018-02-08 18:47:52 -08:00
Evan Dixon
392f01cb3e Fix build error (#1816) 
IEnumerable doesn't support LINQ methods, only the generic variant does. So this commit changes SAV_GameSelect's parameter to a generic IEnumerable of the only type being passed into it. I didn't realize it until afterward, but this is 100% the way it should have been because the databinding members expect ComboItems.
 2018-02-05 12:12:42 -08:00
Pete Rolph
32c650c053 Fix a crash bug when loading Gen 3 saves on mono (#1815) 2018-02-05 07:48:47 -08:00
Kurt
1a5d4efdfe Add database/mgdb -> save importing 
Closes #1804
 2018-02-01 17:29:07 -08:00
Kurt
fabb64705b Split folder->import to multiple overloads 
path, paths, gifts, pkms
removed conversion counter because meh
#1804
 2018-01-31 23:37:01 -08:00
Kurt
afe16dd1a7 Hide mailbox on gc/batrev 
closes #1802
 2018-01-31 20:21:47 -08:00
Kurt
1ca9180e21
use SlotList view to dynamically show slots (#1798) 
Closes #1795 by redoing the controls

Allows for a specified slot type & offset to be passed, can easily add extra slots by updating the GetExtraSlots extension method.
 2018-01-30 18:52:55 -08:00
Kurt
e472bfe278 Refactoring 
move slotchange to core
 2018-01-29 17:52:21 -08:00
Kurt
d7eae51c1f Use showdown specific gender culture for formID 
Closes #1793 , the form was returning -1 because it was expecting ♀ not
F
 2018-01-29 17:20:12 -08:00
Kurt
9085dfd950 Allow backwards conversion on hax 
works somewhat on drag&drop individual files, not guaranteed to work for
all pkm formats
https://i.imgur.com/v3i3ON9.png

Closes #1792
 2018-01-28 22:47:03 -08:00
Kurt
ddf319c713 Set stat level on load 
Closes #1790
lul
 2018-01-28 14:11:12 -08:00
Kurt
2828c89497 Update 18.01.28 
Update event binaries with latest from the Event Gallery
 2018-01-28 00:31:35 -08:00
Kurt
eb505303bb Fix vc backups acting like gb era saves 
ends with .dat only works if the real file ends with dat
load the filename data after stripping off the bak filename data
#1787
 2018-01-28 00:03:49 -08:00
Kurt
3935311988 Add rockruff-1 shiny sprite 
could just add it to the 'sprites don't differ' list instead but
whatever

https://projectpokemon.org/home/forums/topic/43617-usum-bug-report-rockruff-shiny-dusk-form-sprite/
 2018-01-27 18:24:44 -08:00
Kurt
5458b94e50 Resize coin entry 
change 9999 to 65535 for dppt, max gets set on load anyway but just do
it for layout visualization
 2018-01-27 17:50:59 -08:00
Kurt
523dfa32aa Unflip level search <> 
closes #1785
 2018-01-27 13:24:16 -08:00
Kurt
79add8dff1 Update modified check 
takes negligibly longer but accomplishes the necessary task
Closes #1782
 2018-01-27 10:15:56 -08:00
Kurt
f104df6386 Ignore party stats on pkm compare 
Stats were recently added to be calculated on load, thus not matching
the all-zeros when obtained from the save.
Closes #1781
 2018-01-26 21:09:12 -08:00
Kurt
c066df243f Misc fixes/updates 
Fix crystal lacking met level<->current level checks
Fix met location loading for gen2 saves (gen7 sav loaded gen1/2 pkm ->
load gen2 sav)
refactor some logic with pattern matching/consistent method names
 2018-01-26 09:19:20 -08:00
Kurt
98dead5664 Remove out of range box name for no-saves 
oops
closes #1774
 2018-01-25 18:45:11 -08:00
sora10pls
c57f55f31c Fix updated markings not appearing 2018-01-25 17:39:05 -05:00
Kurt
bb20ec49cc load stats prior to searching 
https://projectpokemon.org/home/forums/topic/43579-bug-pkhex-number-fields/
 2018-01-25 09:17:39 -08:00
Kurt
959d598d76 Fix esv searching in database 
only way the filter used to execute was if ESV textbox was empty, which
would throw an exception lul

sync dead code removal for prior pkrs commit (never executes)
475acfaeac
 2018-01-25 08:54:29 -08:00
Kurt
475acfaeac Fix pkrs checkbox behavior 
infecting was incrementing days while the days visibility was hidden

https://projectpokemon.org/home/forums/topic/43518-pokerus/?do=findComment&comment=226611
 2018-01-25 08:48:49 -08:00
Kurt
0edefedc2b Remove gen2->7 auto filtering 
closes #1768
(<7)->7 is now possible so no need to filter further
 2018-01-24 09:19:20 -08:00
Kurt
b16a2f9ad2 Add box rearranging 
enables the left/right arrows on each box to allow switching with the
adjacent box
 2018-01-23 22:37:55 -08:00
Kurt
713e9ea209 Compress box padding 2018-01-23 17:18:37 -08:00
Kurt
18421c66a9 Set box view owner 
shifting focus to another app and back will cause the parent form to be
brought back to the top as well
 2018-01-22 22:39:12 -08:00
Kurt
d65393c6f6 Minor behavior tweaks (preference) 
fix initial box width to 4 with scrollbar, remove always-on-top for main
window
 2018-01-22 21:58:53 -08:00
Kurt
f073585592 Add all-boxes viewer 
removed ability to have multiple single box popups
double click the Box tab when holding shift to bring it up
resize to preferences: https://i.imgur.com/XB2978R.png
 2018-01-22 21:38:42 -08:00
Kurt
6eb0cd17cb fix slot bg image with multiple boxviews open 
main window ignores box, and other windows don't clear. fix both for
accurate indication of what slot was just used by the pkmeditor.
 2018-01-22 21:31:42 -08:00
Kurt
0ee36a655a Simplify bitmap generation 
stride is bpp*width + padding bytes; 0x20 worked for the old code since
8*4=0x20 (width of tile).
 2018-01-21 17:22:31 -08:00
Kurt
f690f4885c Change slot indexing to use an enum 
Still need to figure out how to reconfigure everything to support
ancillary slot displays (3x fused in USUM)
 2018-01-21 15:30:57 -08:00
Kurt
c015c5a337 Shift super training record IDs by 2 
closes #1764 and fix odd behavior by adding an editing flag
 2018-01-18 14:01:58 -08:00
Kurt
69896a3a04 Hide gen1 second daycare slot 
is duplicate with first
the slot is properly hidden but then set visible when the preview is
loaded for it. im sure the set-visible was a very old design decision
 2018-01-16 19:32:54 -08:00
Kurt
c118dc4dae Add SlotList control 
unused, i dont like the saveditor indexing slots from a fixed list
 2018-01-16 19:32:54 -08:00
Kurt
06733d6e34 Refactoring 
Split up c-gear skin bitmap, move generic handling to core
 2018-01-13 21:31:02 -08:00
Kurt
4fb3c22b1c Remove usages of System.Drawing.Color 
Eventually need to remove usages of bitmap
 2018-01-13 19:09:43 -08:00
Kurt
6caefef181 Add cgb->psk & misc clarifications 
Closes #1699
tested on black2 & white, skin isn't corrupt on game boot and appears
correctly

still don't like setpixel/System.Drawing reliance (maybe split logic to
CGearSkin & CGearSkinVisualizer) for PKHeX.Core compat
 2018-01-13 16:32:57 -08:00
Kurt
4f489a720f Refactoring 
move logic back to cgearbackground, initialize the bg regardless of
psk/cgb input format
cache background data to return psk (potentially unintended side effects
if importing bw psk to b2w2, will have to fix cgb->psk first then undo
this tempfix)
#1699
 2018-01-09 23:30:44 -08:00
Kurt
f332e41869 misc updates 
#1699
generally pertaining to detecting a de-obfuscated input (cgb) vs native
(psk)
still issues with saving data (deobf->native)
 2018-01-09 21:47:04 -08:00
Kurt
84a755a8c9 minor simplifications 
#1699
 2018-01-08 22:40:34 -08:00
Kurt
d187370671 fix checksum/footer set 
#1699
checksum in the +0x100 was missing the +SAV.CGearDataOffset
add a few more modifications for better parity

still not 100% fixed
 2018-01-08 22:40:34 -08:00
Evan Dixon
90e3c4a42e Fix thread URL in changelog 
It's probably better to fix this on the server side, but this is easier
 2018-01-08 13:14:52 -06:00
Kurt
701edbc592 Remove KOR language from gen3 selection 
add flag for non japanese lang gen3 eggs
Closes #1747
 2018-01-06 22:43:48 -08:00
Kurt
26015b44bc Add max cap difference for dppt 
#1746
 2018-01-06 14:12:28 -08:00
Kurt
218c20d804 Add sav4 coin edits to misc4 
closes #1746
 2018-01-06 14:02:55 -08:00
Kurt
c006c0cad9 Update pid/ect on showdownset import 
closes #1745
 2018-01-06 09:35:22 -08:00
Kurt
c6089a183c fix designer deletion of sav editor control 
custom constructor parameters aren't expected, needs a default without
optional

(no usages were using a sav provided anyway)
 2018-01-02 23:00:52 -08:00
Kurt
7705c158a9 Allow shiny sprite turning off 
lul oops
 2018-01-02 17:23:43 -08:00
Kurt
1417a6d576 Add shiny sprite fetch & fallback 
pseudo future proofing in the event new species sprites are added and
recolored variants are not
Closes #1735 , thanks @trainboy2019 !
(reimplemented alterations with GUI-saved settings)
 2018-01-02 17:17:30 -08:00
Kurt
853f5f3ce9 Add shiny sprites 
Thanks @msikma (dada)!
Update readme with asset attribution
#1735
 2018-01-02 17:14:22 -08:00
Kurt
ef0453ecf6 Add shiny sprite toggle setting 
not functional yet
#1735
 2018-01-02 17:08:14 -08:00
sora10pls
92854b54f0 Update misc images to match Gen 7 2017-12-31 22:43:08 -05:00
Kurt
fa90ae21df Fix variable reference 
#1731
 2017-12-29 18:30:13 -08:00
Kurt
648f250303 Fix party/other tab loading for sav loads 
loading pbr/rsbox -> loading a game that has party & daycare causes the
daycare tab to be loaded in the incorrect spot.
PartyTab needs to be calculated closer to its use
 2017-12-29 16:50:55 -08:00
Kurt
45eee8575a Only promt roto-OT if OT is changed 
reduces nag
closes #1731
 2017-12-29 10:00:32 -08:00
Kurt
61b65198f2 Allow box name editing on gen2 2017-12-27 15:52:29 -08:00
Kurt
985883e6ae Refactoring 
pull out ability list generating
refactor showdown set to an Action that can be overwritten from
elsewhere
 2017-12-21 22:55:33 -08:00
Kurt
9457db9059 Fix mystery gift qr export text 
closes #1720
 2017-12-21 09:49:40 -08:00
Kurt
9429bc6961 Fix showdown import on gen3 
https://projectpokemon.org/home/forums/topic/43126-problems-with-importing-rse-showdown-files-from-clipboard-in-pkhex/

Sceptile @ Leftovers
EVs: 4 Def / 252 SpA / 252 Spe
Timid Nature
- Leaf Blade
- Leech Seed
- Substitute
- Hidden Power Ice

also fix apricorn form title
 2017-12-19 15:33:23 -08:00
Kurt
9263856845 Add apricorn pouch editing 2017-12-18 09:36:53 -08:00
Kurt
2dbdb35955 Misc tweaks 
possibly fix UI not-1x scaling screwing up drawn pkm images with
items/shiny/illegal.
simplify some logic -> speed improvements (wow so noticable /s)
 2017-12-16 18:29:10 -08:00
Kurt
18796d6f92 Misc tweaks 
fix bk4 ribbon checks (lacked interface inheritance)
change MN -> UM for get blank save (unused in PKHeX solution)
prevent inheriting from derived pkm classes
 2017-12-16 14:11:41 -08:00
Kurt
e5aa39a6bb Refactoring 
get language list now doesn't return new objects (or re-enumerate)
update rand usage to be inclusive for top bound, extend shuffle to
collections
remove unnecessary location overrides (already overriden in legal fetch)
 2017-12-14 20:58:55 -08:00
Kurt
dd21f9375f Misc updates 
Disallow sandygast on US
Add 2 more records
thanks @feralfalcon
Closes #1698
 2017-12-08 08:54:00 -08:00
Kurt
f3cc29df57 Update 17.12.05 
Update event binaries with latest from the Event Gallery
 2017-12-05 09:04:59 -08:00
Kurt
eff8855729 Allow throw type changes to be saved 
move SM/USUM branch inside the method
closes #1695
 2017-12-05 07:26:55 -08:00
Kurt
3d7b2a2b29 Misc tweaks 
RNG frame mismatch -> fishy (for now)
fix xmldoc copypaste
clean up some resharper warnings
 2017-12-04 16:26:26 -08:00
Kurt
a5dbdf91bd Misc tweaks 
detect antishiny cxd
remove unused using
don't set caught for seenAll (gen7 dex)
 2017-12-04 13:18:28 -08:00
pokecal
0f52f94222 fix MailBoxEditor 
add Mail5, almost same as Mail4.
 2017-12-04 00:00:14 +09:00
Kurt
bdc9d7edce fix plaza get set 
closes #1684
 2017-12-02 21:37:46 -08:00
Kurt
2d3203fc1a Refactoring 
extract out Mail classes to core
 2017-12-02 19:12:04 -08:00
pokecal
3e5e49219b fix MailBoxEditor 
fix Gen4 Controls
add Mail .Empty for LegalCheck
add Mail SetBlank() for make BlankMail
 2017-12-03 11:24:57 +09:00
pokecal
c4ca3aba75 add MailBox Editor 
I just wanted to fix PK3 heldMailID.
 2017-12-03 07:21:07 +09:00
Kurt
431c0fc205 Fix hover frost missing pixel 
add alternate coloration for a slot that already has a background color
 2017-11-30 20:35:45 -08:00
Kurt
fdc52e2c19 Add pkm league starter EC for gen7 
Closes #1671
 2017-11-29 20:04:01 -08:00
Kurt
4a898b0829 Leave empty item slots for gen7+ 
game depends on an existing value to check for if the item is truly
"New"
Closes #1670

Don't clear count=0 slots for gen7+
For sorting, put all the count=0 at the near top (any feedback on how
this actually works?)
 2017-11-29 19:47:27 -08:00
Kurt
fa78154df7 Save current facility on save action 
unsaved combobox choices only are saved when the current index is
changed, need to save when the form is closed (saved).
 2017-11-29 08:38:32 -08:00
pokecal
e86b8c670f add Crystal GS EventFlags 
have checked with US ver.
 2017-11-28 03:35:55 +09:00
Kurt
b30cc933e5 Extract festafacility from gui code 
move to core project as a structure/class
 2017-11-26 08:47:25 -08:00
pokecal
8fe81e8610 update FestaPlazaEditor 
add BattleAgent Grade30 reward giving
 2017-11-26 19:40:18 +09:00
Kurt
2be84b6005 Rework encounterslot location fetch 
store ref to area instead of location, useful for fetching sibling slots
from the parent.
 2017-11-25 18:16:50 -08:00
Kurt
bb5456bf9d Update 17.11.25 
Update event binaries with latest from the Event Gallery
 2017-11-24 14:15:01 -08:00
Kurt
0a0a54b59e
Merge pull request #1657 from pokecal/master 
update FestaPlazaEditor
 2017-11-24 12:07:45 -08:00
Kurt
66c038e301 rework program exception handling / detection 
focus the dll not found check to FileNotFoundException for filename
(dll) check; existing checked for targetsite which didn't trigger

define out release methods for debug builds
 2017-11-24 12:03:57 -08:00
pokecal
2c15170844 update FestaPlazaEditor 
Add Result of FortuneTeller
and found that the Unknown Value of FestaID(not introduced)
was mistake, contaminate NPCs.
 2017-11-25 03:14:55 +09:00
Kurt
5ae408c316 cleanup 
no functional changes
 2017-11-23 09:43:43 -08:00
Kurt
5be401cc73
Merge pull request #1652 from pokecal/master 
update FestaPlazaEditor
 2017-11-22 22:12:29 -08:00
Kurt
d57b5a343a sync missing change 
nj resharper; changed sig -> didn't update
 2017-11-22 22:06:08 -08:00
Kurt
b8a5657d5a misc tweaks 
pull out transfer locations to const references
add vc2 & crown beast/celebi met location suggesting
add vc2 crystal sensitive detection
add 2 more usum trainer stats (thanks holla!)
 2017-11-22 21:45:30 -08:00
pokecal
c3716440e6 update FestaPlazaEditor 
I think the form contains almost all controls that needed.
 2017-11-23 09:49:53 +09:00
Kurt
5fd1e85ce6 Refactoring 
are the ace trainer genders swapped? removed the iteration loop in favor
of precomputed values

(pattern goes m/f *n?)

add wormhole max dist val
 2017-11-21 19:08:31 -08:00
Kurt
193c3e8d59 set box info for right click box legality checks 
slot/box data wasn't being set, causing any 'party only' forme checks to
be prevented
 2017-11-21 18:32:27 -08:00
Kurt
f25b4fea9c Add forme range check method to personalinfo 
relocates logic to better location
 2017-11-21 18:32:27 -08:00
Kurt
15496aa9be
Merge pull request #1642 from pokecal/master 
add USUM BattleAgency control
 2017-11-21 15:38:43 -08:00
Kurt
486e5dc4fe Move forme check after species check 
compatibility message of 803-807 dex pkm on S/M needs to say species
first rather than checking forme first
Closes #1643
 2017-11-21 15:22:33 -08:00
pokecal
8c08ec1328 add USUM BattleAgency control 
the NOTE(Giovanni alert) is a little excessive I think,
I will remove it after detect a list of upcoming trainers.
 2017-11-22 03:37:40 +09:00
pokecal
7799450193 fix FestaPlazaEdit value 
When the facility is NOT introduced with visitors
and start FestaPlaza after latest started date,
VisitorFesID become unknown small value.(0/5/7/9/11)
So I stop auto-deletion of visitor data.(and put delete button)
 2017-11-21 05:15:32 +09:00
Kurt
1e5fc96e8e fix gs met location errors 
override current location if format is GB
update GS transfer location ID
 2017-11-20 09:11:37 -08:00
pokecal
16a0abaf62 fix FestaPlazaEdit value 
found "misc value" as used stats.
exchange left count is also up to 255.
(value 0x83 shows "?", 0x103 shows "3")
fix dye#5(blue) color value
 2017-11-20 19:08:41 +09:00
Kurt
6534ef1919 Refactoring 
Reworks festa facility into a get/set object, simplify some operations
naming convention (PascalCase) for methods/properties
closes #1635
 2017-11-19 21:25:46 -08:00
Kurt
2970348de6 fix vc transfer location suggesting 
also fix linux builds case sensitivity
 2017-11-19 20:35:36 -08:00
Kurt
70ec1fda5e cleanup 
wasn't able to view the designer layout so I removed & readded to
project -- works fine now.
uppercase method names
 2017-11-19 16:16:44 -08:00
pokecal
3c85b0ead3 add G7 FestivalPlaza Editor 
There are too many phrases,
I have no plan to complete all list of phrases.
But I think user can edit phrases of each facility
 by using their phrase settings.
 2017-11-20 06:50:39 +09:00
Kurt
469587bbbd Add Rotom OT name 
"nah lets just store the OT in the save file twice"

add a double check if OT != RotOT to remind the user
 2017-11-18 22:26:57 -08:00
Kurt
243f94f02b Add map coordinate writeback check 
same as sav7; apparently some areas in gen6 are also truncation prone
 2017-11-18 12:22:54 -08:00
Kurt
6394dac19f Rework mysterygift pkm sprite generation 
don't bother converting to pkm then generating the sprite off that; use
the overload with int/bool

removes sav/pkm dependency for generating gift descriptions, and
standardizes the names a little. maybe a PKMBase interface would be
useful...
 2017-11-18 11:34:23 -08:00
Kurt
515302381c Verify pkm tabs before exporting to save 
unset fields / illegal fields should be screened
 2017-11-18 08:42:20 -08:00
Kurt
f7e20a3c43 Misc tweaks 
fix roamer3 not setting IVs
fix usum z items rightmost pixel getting chopped off
use Gen* instead of GenNumber for specific cases (faster)
add WasGiftEgg location case for Gen7
remove some unnecessary array allocations
 2017-11-17 22:19:23 -08:00
Kurt
e4b48b2712 Update 17.11.17 
Update event binaries with latest from the Event Gallery
 2017-11-16 19:32:58 -08:00
pokecal
95bbbfaf08 fix Sticker location 
Who is that Pokemon...Steelix!
 2017-11-17 11:53:54 +09:00
Kurt
407f3f06d4 Unbreak clearing dex 
add sound notification that the mass-edit is finished.
refactor slightly for clearer routines
 2017-11-16 17:42:11 -08:00
Kurt
025b8da52c Flag invalid forms on sav compatibility check 
closes #1615
 2017-11-16 14:30:18 -08:00
Kurt
bd08d11597 separate out throw learn/unlocked 
flags and handling is different for USUM, disabled until flags are found
 2017-11-15 17:03:44 -08:00
Kurt
aea1577a11 fix mega venusaur female disabled / meowstic 
<= goes to <
Thanks Holla!

https://projectpokemon.org/home/forums/topic/42332-gen-7-stuff/?tab=comments#comment-222689
 2017-11-14 22:56:45 -08:00
Kurt
1c42cbebb7 Hide debug values 
Closes #1607
wasn't Hall of Fame clear count values, just the 4 bytes prior to the
HoF 2 * 6 * u16 teams that serves an unknown purpose.
 2017-11-14 21:48:38 -08:00
Kurt
dbf10d1c29 Add surf score editing 
trainer7 Ultra tab
Closes #1605
 2017-11-14 21:35:28 -08:00
Kurt
1487f439e8 Default load save to ultra sun 
new set of games
 2017-11-14 21:34:43 -08:00
Kurt
e2dfc8d9f1 update fashion payloads 
closes #1602
thanks Holla!
 2017-11-14 19:48:30 -08:00
Kurt
c4f8dabd26 rework dex getting 
changes iteration to be per-species rather than per list.
uses the internal 'should i set a bitflag' code rather than a banlist.
 2017-11-14 19:14:02 -08:00
Kurt
a6da97ad42 Add debug sensitive date string for qr exports 2017-11-14 08:48:36 -08:00
Kurt
c5cd6728fe Add usum fashion cheats 
Thanks Holla!
 2017-11-13 22:07:41 -08:00
pokecal
955833a1c6 add G7 MapUnmask & FlyDestination 
G7 is not FLY, just consistency with other Gens.
 2017-11-14 11:59:33 +09:00
ReignOfComputer
5259b7546e Totem Stickers Formatting & Window 
Standardized the list of Totem Stickers and expanded the window slightly
to better fit text
 2017-11-13 19:39:51 +08:00
Kurt
dbabcb9ef0 Misc updates 
fix hall of fame fixed offset
fix ball throw type unlock/learned flags using fixed offset
fix current throw type defaulting to -1 when Nihilist (new USUM style)
by adding in for USUM

add fused slot offset fetching
convert event flag combined byte fetch to use Get/SetEventFlag with
event flag references.

add ZRingUnlocked sav properties & checkbox for toggling

set AlolaTime only if the combobox is enabled (only disabled if not yet
set by game)

Closes #1595
 2017-11-12 21:28:34 -08:00
Kurt
7bc316d79c Add "AlolaTime not existing yet" handling 
Savedata::GameTime::IsAlolaOffsetExists
 2017-11-12 16:10:31 -08:00
pokecal
dd83555953
complete USUM TotemSticker location 
easy one have missed.
 2017-11-13 04:54:48 +09:00
ReignOfComputer
69bdcacaec Additional Totem Sticker Locations 
1 left.
 2017-11-12 22:29:44 +08:00
ReignOfComputer
596ff57fc3 Add Extra Zygarde Cell Locations 
Wela Volcano Park (rocks behind sign)
Battle Tree Entrance
 2017-11-12 18:28:39 +08:00
Kurt
6a73b9e6e4 Update zygarde cells 
use const numbers, dynamic count for cells possible
 2017-11-11 22:48:22 -08:00
Kurt
cfb38a771f
Merge pull request #1588 from pokecal/patch-1 
add USUM TotemSticker resource
 2017-11-11 22:36:49 -08:00
Kurt
fbab1cfbe6 Update usum eventflag max 
now these event flags are making sense
 2017-11-11 18:58:57 -08:00
pokecal
8b1c76ea06
add USUM TotemSticker resource 
NPC said there are 100 stickers, so I missed 5, still finding.
 2017-11-12 09:40:38 +09:00
Kurt
d8acdf2aa1 Fix partner pikachu sprite 
fix form+1 overflow (cap7 pikachu in sm accesses gumshoos1! bad!)
 2017-11-10 19:53:11 -08:00
Kurt
f5a6f23161 Add more static enc data 
clear out unused (highly certain) SM encounters
add solgaleo/lunala locations
add partner form pikachu
 2017-11-10 19:43:31 -08:00
Kurt
8ab39cae7b Update dex form handling 2017-11-10 17:08:47 -08:00
Michael Scire
e455aef501 USUM event constants for starter choice/Tapu rebattle 2017-11-10 15:08:20 -08:00
Kurt
a39f92cac6 Add rockruff forme list items 
revert form selection filtering, screwed up scatterbug and other
forced-forme lists. behavior works fine without the list filtering
 2017-11-10 04:01:36 -08:00
Kurt
b99ae92b47 handle mimikyu totem forme edge case 
run totem form code regardless of sprite
 2017-11-09 22:00:36 -08:00
Kurt
b3436cb791 Add totem forms selection/spritemod and req changes 2017-11-09 21:52:11 -08:00
Michael Scire
c9be698d46 Fix Partner Cap pikachu icon 2017-11-09 14:41:00 -08:00
Kurt
665e94b0aa misc cleanup 
add german forme names
truncate some forme names
fix nidoran gender symbols

adds null check for invalid (caught error) pkm

disables accessory giving (needs more research)
 2017-11-08 22:56:42 -08:00
Kurt
9f2899617d add ultra moon encounter legality binaries 
fix an odd edge case going from a bad FRLG save to gen6+ while we're
pushing code
 2017-11-08 21:56:56 -08:00
Kurt
134e676e91 Unlock Pokedex & HoF editors 2017-11-08 18:42:52 -08:00
Kurt
cf35adca6f Add roto blank item handling 
preserve input data
 2017-11-08 14:12:41 -08:00
Kurt
80bedb97c4 Misc tweaks 
Adds game names for languages other than english
adds z crystal sprites for held items
temp-fixes chinese pkm names (need manual translation for the new
species)
remove newline at eof
toggle back on legal item lists, add assumed Key Item list
differentiate duplicate item name strings (-arizers)
 2017-11-08 13:06:20 -08:00
Michael Scire
78acb8e13b Fix save resigning for USUM, add resources for new pokemon 2017-11-08 11:31:09 -08:00
Kurt
543736d568 Early rough USUM compatibility 
need to dump string resources, sprites, and repoint the form list string
fetch later. tons more to do

no guarantee of any working functions
 2017-11-08 00:34:32 -08:00
Kurt
24121553b4 Add savegame sensitive pkm legality checking 
uses the forme count of the savefile (rather than a futureproofed
same-gen forme count)
Closes #1559
 2017-11-06 19:31:24 -08:00
Kurt
4a6ea19a31 Cleanup 2017-11-06 17:12:59 -08:00
Kamron Batman
83e06b4436 Adds WC4 support. 2017-11-06 16:26:34 -08:00
Kurt
0c370fe09e fix skin dialogresult compare 
closes #1557
replace \n with environment specific value
 2017-11-04 12:22:32 -07:00
Kurt
a00f3ed894 random IVs with specified count 
Closes #1553
removes duplicate logic in batch editor
 2017-11-02 09:05:44 -07:00
Kurt
008605c4ff Add Gen5 BP editing to simpletrainer 
a little bit hacky but exposes the values well enough.
moves the coins entry to the Badges groupbox, and makes it visible
looking like a BP editor (lol)

thanks @sora10pls for finding the offsets!
(blockinfo array isn't really used, is sorta just there for
documentation...)
 2017-11-01 21:26:38 -07:00
Kurt
afde4514e2 Add realgam tower / deep colosseum locs 
sudowoodo & gsc dogs
closes #1549

fix loading issue for abilities in gen3 format, copy the gen4
sanitization
 2017-10-29 10:41:12 -07:00
Kurt
021ecbfe47 move pkm load compat check to pkmconverter 
closes #1550 , mgdb/pkmdb throw unconverted files which need conversion;
move main file load conversion to a reusable method and have pkmeditor
call it on every load.

add skip argument to ignore the conversion check (ie if the file is
loaded from an undoubtedly same type source).
 2017-10-28 14:26:27 -07:00
Kurt
02cfeef4cd Uncap low end of purification meter 
apparently values can be -100 (colo) and -1 on xd...?
 2017-10-26 17:55:34 -07:00
Kurt
32abc6daf4 speed up pkm loading slightly 
PreparePKM had the opportunity to be recursive (preparation ->
validating*N -> preparation*N), lock out preview sprite updating (which
calls PreparePKM via Main.cs) while validating all controls

remove uncallable paths (format is checked prior, and checksum check is
never called as fieldsInitialized is forced false)

move gui toggling to loading methods when appropriate
 2017-10-25 19:37:31 -07:00
Kurt
3458924446 Restrict data sources per savefile not pkm 
pkm is not restricted from ORAS (etc) values when on an XY (etc) save
file; use the save file maxes and indication values.

no reference to the pkm anymore!

Closes #1546
 2017-10-24 21:06:21 -07:00
Kurt
8c2dcb2dd3 Use generation specific species name 
nickname resetting should use the generation specific value
 2017-10-24 20:59:58 -07:00
Kurt
933bfba8e1 Misc cleanup 
check gen2 stadium names, use pkm.Japanese when favorable
 2017-10-24 18:27:40 -07:00
Kurt
69cf1eaa9c add more pkhex.core xml documentation 
adds a bunch of documentation useful for those unfamiliar with the core
library
 2017-10-23 23:12:58 -07:00
Kurt
2ad5b19f6c Add mgqr -> tabs 
Closes #1542 and prevents incorrect loading cases (qrpk2jp -> g2en sav
etc)

simplifies things a bit ;)
 2017-10-23 15:49:52 -07:00
Kurt
515a694afa Add LanguageID enum 
no functional change, just less-magic-numbers for easier to understand
src
 2017-10-22 21:01:08 -07:00
Kurt
cd16a7721b Set roamer data back on save 
existing code cloned the savedata reference to a new array, and didn't
copy back

the Roamer3 reader/writer does all the r/w, and writing only happens
with the setter when the form is called to Save.

Thanks TheRealAlphA!
 2017-10-22 17:17:17 -07:00