misc cleanup

add german forme names
truncate some forme names
fix nidoran gender symbols

adds null check for invalid (caught error) pkm

disables accessory giving (needs more research)

PKHeX.Core/Legality/Analysis.cs

@@ -1,4 +1,4 @@
-#define SUPPRESS
+//#define SUPPRESS
 
 using System;
 using System.Collections.Generic;
@@ -294,7 +294,7 @@ namespace PKHeX.Core
         }
         private string GetLegalityReport()
         {
-            if (!Parsed || pkm == null)
+            if (!Parsed || pkm == null || Info == null)
                 return V189;
             
             var lines = new List<string>();
@@ -323,7 +323,7 @@ namespace PKHeX.Core
         }
         private string GetVerboseLegalityReport()
         {
-            if (!Parsed || pkm == null)
+            if (!Parsed || pkm == null || Info == null)
                 return V189;
 
             const string separator = "===";

PKHeX.Core/PKM/FormConverter.cs

@@ -444,7 +444,7 @@ namespace PKHeX.Core
             }
         }
 
-        private static string[] GetFormsAlolan (int generation, IReadOnlyList<string> types, IReadOnlyList<string> forms, int species)
+        private static string[] GetFormsAlolan(int generation, IReadOnlyList<string> types, IReadOnlyList<string> forms, int species)
         {
             if (generation < 7)
                 return new[] { "" };

PKHeX.Core/Resources/text/de/text_Forms_de.txt

@@ -1061,3 +1061,8 @@ Entlarvte
 
 
 Original
+Partner
+Abend
+Abend
+Morgen
+Ultra

PKHeX.Core/Resources/text/de/text_Species_de.txt

@@ -27,10 +27,10 @@ Pikachu
 Raichu
 Sandan
 Sandamer
-Nidoran
+Nidoran♀
 Nidorina
 Nidoqueen
-Nidoran
+Nidoran♂
 Nidorino
 Nidoking
 Piepi

PKHeX.Core/Resources/text/en/text_Species_en.txt

@@ -27,10 +27,10 @@ Pikachu
 Raichu
 Sandshrew
 Sandslash
-Nidoran
+Nidoran♀
 Nidorina
 Nidoqueen
-Nidoran
+Nidoran♂
 Nidorino
 Nidoking
 Clefairy

PKHeX.Core/Resources/text/es/text_Species_es.txt

@@ -27,10 +27,10 @@ Pikachu
 Raichu
 Sandshrew
 Sandslash
-Nidoran
+Nidoran♀
 Nidorina
 Nidoqueen
-Nidoran
+Nidoran♂
 Nidorino
 Nidoking
 Clefairy

PKHeX.Core/Resources/text/fr/text_Species_fr.txt

@@ -27,10 +27,10 @@ Pikachu
 Raichu
 Sabelette
 Sablaireau
-Nidoran
+Nidoran♀
 Nidorina
 Nidoqueen
-Nidoran
+Nidoran♂
 Nidorino
 Nidoking
 Mélofée

PKHeX.Core/Resources/text/it/text_Species_it.txt

@@ -27,10 +27,10 @@ Pikachu
 Raichu
 Sandshrew
 Sandslash
-Nidoran
+Nidoran♀
 Nidorina
 Nidoqueen
-Nidoran
+Nidoran♂
 Nidorino
 Nidoking
 Clefairy

PKHeX.Core/Resources/text/ko/text_Species_ko.txt

@@ -27,10 +27,10 @@
 라이츄
 모래두지
 고지
-니드런
+니드런♀
 니드리나
 니드퀸
-니드런
+니드런♂
 니드리노
 니드킹
 삐삐

PKHeX.WinForms/Subforms/Save Editors/Gen7/SAV_Trainer7.cs

@@ -399,6 +399,11 @@ namespace PKHeX.WinForms
         }
         private void B_Fashion_Click(object sender, EventArgs e)
         {
+            if (SAV.USUM)
+            {
+                WinFormsUtil.Alert("Temporarily disabled, needs research for permissible values.");
+                return;
+            }
             var prompt = WinFormsUtil.Prompt(MessageBoxButtons.YesNo, "Modifying Fashion Items will clear existing data", "Continue?");
             if (DialogResult.Yes != prompt)
                 return;