2431 commits

Author	SHA1	Message	Date
Kurt	e701bf2725	Add Frostpoint Field for dens 175/176 ... Closes #3091	2020-11-20 18:20:00 -08:00
Kurt	dba7dc9911	Forest distribution raids	2020-11-19 16:06:43 -08:00
Kurt	ce17fd4050	Minor tweaks ... Enc static 4 should check met location, since locations are flexible for roamers Simplify expressions Disallow 0 moves in "needed moves" list.	2020-11-19 15:34:06 -08:00
Kurt	9d8b528437	Update EncounterMovesetGenerator.cs	2020-11-19 07:33:35 -08:00
Kurt	0af0c05bac	Update go slot list yield and move fetch	2020-11-18 21:34:40 -08:00
sora10pls	f8dd2cf977	Update PogoType.cs	2020-11-18 21:05:46 -05:00
sora10pls	3b66e2e9b1	Add min. Level requirement for PogoType FieldP ... Mew, Celebi, Jirachi and Victini (one-time Mythicals) require Lv. 15 with at least 10/10/10 IVs.	2020-11-17 21:56:47 -05:00
Kurt	4a8ad8b149	Expose raw evolution chain methods	2020-11-17 14:23:15 -08:00
Kurt	037db7b8a3	Add xmldoc for new obj/func related to GO legality	2020-11-16 21:17:45 -08:00
Kurt	e6a60ec210	Add single day tolerance to end of appearance period	2020-11-16 15:41:39 -08:00
Kurt	26e0f31c95	Include date legality parameters for LGPE ... Extract common abstract class for GO transferred encounters Clamp minlevel instead of met level Add optional parameter for GO IV randomization Update go legality binaries with latest	2020-11-16 15:32:22 -08:00
Kurt	770f7584c9	Behavior tweaks	2020-11-16 14:33:21 -08:00
Kurt	f25a7c7cf2	Apply valid ball on create	2020-11-15 20:51:07 -08:00
Kurt	d393773fb0	Update EncounterSlot8GO.cs	2020-11-15 18:32:30 -08:00
Kurt	d7dc69104b	Fix year check ... still testing	2020-11-15 18:12:58 -08:00
Kurt	0ba2f6a53a	Update EncounterSlot8GO.cs	2020-11-15 17:44:13 -08:00
sora10pls	a4125472f4	Add PogoType for GO Battle League Mythicals ... Covers Darkrai and any other future Mythical rewards from GBL.	2020-11-15 18:48:33 -05:00
Kurt	760adb4945	Check date legality	2020-11-15 08:31:48 -08:00
sora10pls	d5e1447f7c	Add additional PogoType enums, add min Lv/IVs	2020-11-14 19:36:07 -05:00
Kurt	cb57e807ce	Update EncounterSlot8GO.cs	2020-11-14 15:33:32 -08:00
Kurt	377ec02c9b	Minor clean ... Remove GoPark as a "Type" since it is now baked into the encounter object type	2020-11-14 12:55:30 -08:00
Kurt	ad9e9ddfa0	Relocate go encounter maintenance outside of pkhex.core ... PKHeX.Core now accepts generated pkl binaries from PoGoEncounterTool (PGET). Refer to pporg's repo. This will be treated like event data; occasionally updated.	2020-11-14 12:51:24 -08:00
Kurt	5e22c119be	Continued refinements	2020-11-13 08:20:51 -08:00
Kurt	67a796e982	Update EncountersGO.cs	2020-11-12 22:08:13 -08:00
Kurt	82c016639d	Update EncountersGO.cs	2020-11-12 22:00:09 -08:00
Kurt	f366d27bdb	Revert Mothim form	2020-11-12 22:00:02 -08:00
Kurt	3e4d685d37	Update EncountersGO.cs	2020-11-12 20:50:39 -08:00
Kurt	01c597cba7	GO checks round 2	2020-11-12 20:41:01 -08:00
Kurt	98f602fc87	Require tracker for HOME gifts too	2020-11-11 21:27:33 -08:00
Kurt	72e209a156	Split some methods, handle flow for go enc	2020-11-11 21:22:13 -08:00
Kurt	edd9ace51e	More pogo rules	2020-11-11 21:03:47 -08:00
Kurt	df5ebd1f54	Minor clean ... Resolve some messages	2020-11-11 21:01:41 -08:00
Kurt	915727ed67	Add g-kanto formes ... Probably will refactor things when shiny/ball legality is detailed	2020-11-11 13:27:08 -08:00
Kurt	93ff841a1d	Update EncounterMovesetGenerator.cs	2020-11-10 22:17:23 -08:00
Lusamine	86096201e8	Add Route 3 -> Motostoke City crossover (#3085) ... Not related to the location glitch; whistle to lead Zigzagoon. Co-Authored-By: tehvik <40148574+tehvik@users.noreply.github.com>	2020-11-10 22:11:19 -08:00
Kurt	7654ce2123	Add initial legality checks for GO->HOME transfers ... took me less than an hour to do these changes, and i can flag bad form movesets no problemo Expect tightening of restrictions (ball, level, shininess) later if someone wants to curate met date restrictions, go ahead!	2020-11-10 22:10:53 -08:00
ShadowMario3	7b2f76b621	Fix issue #3083 (#3084)	2020-11-07 22:48:46 -08:00
Kurt	cb24c20a44	Remove relearn suggestion logic from relearn move verification ... Sure it's nice to cache a valid array, but the amount of logic was small enough that it can be done with 10 lines of code rather than at the end of each verification method. Reduces parameter passing & removes 1 field from the info object, as relearn suggestions are only done rarely after legality checking. Allows for a simpler api surface (pkm, encounter) rather than a bigger object reference	2020-11-07 12:25:15 -08:00
Kurt	227efc1fc3	Only allow checking if lvl60 when lvl<60	2020-11-05 21:17:13 -08:00
Kurt	ae85097c2d	Allow go shiny xor!0 ... Thanks @Lusamine for bruteforce testing to confirm	2020-11-04 20:55:47 -08:00
Kurt	c5b6c20c7b	Update MarkVerifier.cs	2020-11-04 12:58:56 -08:00
Kurt	8b25af5f85	Enforce xor=0 for go shiny transfers ... Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>	2020-11-03 18:56:58 -08:00
Kurt	d78424a3ad	Hande Ability Patch edge case ... 4 legends have A/A/H on form-0, and B/B/B on form-1. You can get a form-1 by applying the patch on the form-0, and changing it to form-1 will retain the AbilityNumber=4. Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>	2020-11-03 18:48:29 -08:00
Kurt	c60ae57ab0	Handle Ranked Battle Series 7 permissions ... Closes #3070 Exclude all classified as Legends; everything else is permitted assuming it can exist in SW/SH. Co-Authored-By: Chris <28743231+Bappsack@users.noreply.github.com>	2020-11-02 16:38:00 -08:00
Kurt	51c872f4e1	Move more logic closer to where it's used	2020-11-02 14:46:26 -08:00
Kurt	7cb6ee0060	Move some static arrays closer to where they're used ... Split EvolutionRestrictions to its own class Can probably refine things further to clamp down access to these arrays	2020-11-02 13:11:51 -08:00
Kurt	b4c9e90c28	Enhance transparency in failed generator test	2020-11-02 13:03:08 -08:00
Kurt	d257ad1b1a	Update MoveTutor.cs	2020-11-01 19:59:26 -08:00
Kurt	64a6214b82	no nuts here	2020-11-01 16:05:55 -08:00
Kurt	24346cc4e1	Update EncounterTrade1.cs	2020-11-01 15:58:42 -08:00
Kurt	4db6661ffd	Handle JP-Blue trade quirks + stadium2 trade bypass ... Co-Authored-By: ShadowMario3 <36941677+ShadowMario3@users.noreply.github.com>	2020-11-01 15:27:54 -08:00
ShadowMario3	7659b57c4f	Corrected catch rates for the Haunter and Graveler trades. (#3071) ... * Fix catch rate for JP Blue trade evolutions	2020-11-01 14:39:49 -08:00
Lusamine	d5e5df802e	Add Ballimere Lake -> Lakeside Cave crossover (#3069)	2020-10-31 22:29:08 -07:00
Kurt	15348d3fdd	Bypass crustle flag	2020-10-31 11:43:17 -07:00
Kurt	c9ee07e9b9	Update form for friendsafari vivillon ... Closes #3066	2020-10-30 22:23:13 -07:00
Kurt	975c4f8a4a	Prevent nickname change for fateful encounter trades ... Handle empty nickname trades for gen6+ assuming there's a nickname	2020-10-30 20:31:12 -07:00
Kurt	d7042fb19e	Inline parameter passing ... nothing passes anything, so swsh is default shared raids yay	2020-10-30 19:56:37 -07:00
Kurt	a33120c93e	Boo ... Poor Gourgeist-0&2 being left out of the 60-shiny club... Mimikyu is a repeat from the Pikachu Mass Appearance in early August.	2020-10-29 19:34:17 -07:00
Kurt	62d5375f67	Update EncounterStatic8U.cs	2020-10-29 08:52:38 -07:00
Lusamine	5e92b7b5f7	Add crossover and static encounters for CT (#3050) ... * Add crossover encounters for CT * Old Cemetery -> Giant's Foot * Add some static encounters * Add Frostpoint Field -> Freezington crossover	2020-10-27 22:08:49 -07:00
Kurt	cb545781b0	Split off es5dr to separate file, require never shiny ... Shiny check was mistakenly forgotten :)	2020-10-27 18:03:45 -07:00
Kurt	2303077ed1	Expose move source classes for api purposes ... Not guaranteeing the method signature will be stable forever, but allows people to reference the public methods inside. Closes #3056	2020-10-27 09:25:33 -07:00
Kurt	82c579da82	Disallow E birth island deoxys with JP origin ... Closes #3040 Ty @Atrius97 ! "The Japanese Aurora Ticket was only distributed in Summer 2004, before Emerald (Sept 16th 2004) was released. The software at that time had no support for Emerald games."	2020-10-25 21:42:14 -07:00
ReignOfComputer	43d031604f	Static Encounters Update (#3044) ... Alakazam in the Insular Sea (on the Isle of Armor) Zapdos at Watchtower Ruins (in a Wild Area) Zapdos at West Lake Axewell (in a Wild Area) Moltres in the Soothing Wetlands (on the Isle of Armor) Moltres on Challenge Beach (on the Isle of Armor) Moltres in Loop Lagoon (on the Isle of Armor) Dragapult in the Giant’s Bed (in the Crown Tundra) Nidorina in Frostpoint Field (in the Crown Tundra) Glalie on Snowslide Slope (in the Crown Tundra)	2020-10-25 18:10:07 -07:00
Kurt	bb60b140e2	Allow Gen8 balls on gen3-species eggs originating in Gen8	2020-10-25 18:07:13 -07:00
Kurt	2bb399c8e7	Check egg state before allowing gmax toggle ... eggs can't toggle gmax state	2020-10-25 13:41:49 -07:00
Kurt	36051e0f82	Minor clean	2020-10-25 10:02:52 -07:00
Kurt	681d64d007	Update AltFormInfo.cs	2020-10-25 09:35:19 -07:00
Kurt	608e0bb88e	Update AltFormInfo.cs ... Static species enum ref for simplicity	2020-10-25 09:30:42 -07:00
Kurt	691f12ae72	Extract battle form logic into a separate class ... format is included in the method call to futureproof, not currently necessary	2020-10-25 09:15:16 -07:00
Kurt	90b760b9bf	Unban porygon capture-breed ball for eggs ... Shows up in dynamax adventures for capture Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>	2020-10-24 20:46:43 -07:00
Kurt	babf5a48ca	Bounds check species name on report summary	2020-10-24 20:22:08 -07:00
Kurt	6079f53d9a	Handle unfused Calyrex with fused-TR flags ... Thanks CC6174 # 4880 (Discord) !	2020-10-24 19:10:59 -07:00
ReignOfComputer	29408e3ada	Static Encounter Updates (#3043)	2020-10-24 12:33:14 -07:00
Kurt	0c8966796e	Add wild area strong encounters for Crown Tundra ... Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com> Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: Chris <28743231+Bappsack@users.noreply.github.com> Co-Authored-By: ReignOfComputer <2667537+ReignOfComputer@users.noreply.github.com> Co-Authored-By: Archit Date <architdate@gmail.com>	2020-10-24 11:24:01 -07:00
Kurt	2e4af1afc5	Update legality comparisons for Crown Tundra ... Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com> Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>	2020-10-24 11:16:01 -07:00
Kurt	0741c8c035	Handle Calyrex TR bug ... Co-Authored-By: ReignOfComputer <2667537+ReignOfComputer@users.noreply.github.com>	2020-10-24 11:12:25 -07:00
Kurt	9b2d7c0341	Minor tweak ... no functional change, just use Generation instead of recomputing	2020-10-24 11:11:53 -07:00
Kurt	5fa4ddd4a2	Update internal data sources for Crown Tundra ... Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com> Co-Authored-By: ReignOfComputer <2667537+ReignOfComputer@users.noreply.github.com>	2020-10-24 11:11:05 -07:00
Kurt	799dbde1a2	Add Nest Data for Crown Tundra ... Co-Authored-By: SciresM <8676005+SciresM@users.noreply.github.com>	2020-10-24 11:06:05 -07:00
Kurt	24bd796302	Fix erroneous legality message with 0IV ... Revised string now uses string format, will be in the new localization text update.	2020-10-24 10:52:22 -07:00
Kurt	8c4b7e9060	Prefer form match for suggested encounters ... Closes #3038	2020-10-19 11:54:59 -07:00
Kurt	3dd47dc898	Check ability bit for gen3 based on PID	2020-10-19 11:36:57 -07:00
Kurt	83171ab133	Change shininess check ... Encounter definitions should be marked as Never Shiny or not in their definition, rather than assuming	2020-10-18 16:05:01 -07:00
Kurt	a4baec9939	Check shiny state for GB Era events	2020-10-18 10:57:18 -07:00
ShadowMario3	f6476a4737	Add Gen 1 North American Mew Events (#3036)	2020-10-18 10:01:55 -07:00
Kurt	7a01b1249c	Minor clean ... Handle more messages, add more xmldoc	2020-10-18 09:43:41 -07:00
Kurt	c09fb9a0ec	Simplify "Flag" field in move source tracking	2020-10-17 13:40:12 -07:00
Kurt	1bd3ec79cf	Misc tweaks for suggesting moves when IsEgg ... Closes #3032 Don't suggest tutor moves for current moves if it is an egg	2020-10-14 18:55:30 -07:00
Kurt	2e8586f364	Read swarm slots correctly	2020-10-13 15:37:18 -07:00
Kurt	367859c536	Make MoveEgg / MoveTM internal methods public ... Closes #3031	2020-10-13 11:22:13 -07:00
Kurt	1524093099	Revise g5 pid bit check for forced PID statics ... Closes #3027 Roamers: Get PID generated externally NPokemon: Get PID from a fixed value Forced (Anti)Shiny: Get PID altered Thanks @LegoFigure11 && Princess Emily (discord 4650) !	2020-10-12 11:04:29 -07:00
Kurt	ea81bb2c1e	Add swsh items based on DLC1 metadata	2020-10-10 14:14:02 -07:00
Kurt	7132750c9b	Placeholder crown tundra logic ... To be updated: - Tables8: magic numbers for maximums - IGigantamax: any new gigantamax forms? - FormConverter: any new forms? (calyrex)	2020-10-10 13:14:32 -07:00
Kurt	078322f146	Fix logic to fix a broken raid test	2020-10-10 12:59:31 -07:00
Kurt	a0a8dd0f91	Handle Ability Patch changed abilities (#3024) ... Handles conditions when Ability Patch has been used to modify the PKM's ability => hidden ability. Per the description, it goes 1/2=>H, not the other way around. Verify ability bit first, as mystery gift case handling skips the bit check logic :P	2020-10-10 12:30:57 -07:00
Lusamine	e6e3166f13	Add Comfey from Honeycalm Island (#3023)	2020-10-10 10:07:17 -07:00
ShadowMario3	ba4eadfde9	Add location for Stadium 2 Events (#3022) ... * Fix game version for International Gen 2 events * Add Stadium 2 Event location	2020-10-10 08:13:54 -07:00
Kurt	944c47326e	Exclude unobtainable SOS encounters ... Rather than do backtracking logic to see if the slot can be yielded, don't acknowledge the slot exists if it can't be yielded. See pk3DS commit where we check EscapeRate for the base wild slot prior to adding it to the exported slot list.	2020-10-10 00:29:53 -07:00
Kurt	6b1fff05bd	Revise gen6/7 HA banlist to account for altforms	2020-10-09 20:04:09 -07:00
Kurt	20bb2c6a49	Add some species to HA banlists (same as regular) ... Gen6/7 have some species that can't be obtained with A4. Kinda flew under the radar due to their HA being the same as the other abilities.	2020-10-09 17:09:07 -07:00
Kurt	dfbafee506	Add call rate check for SOS hidden ability ... Probably could just yeet the encounter data for these impossible-to-reach SOS's since they're duplicate with the non-SOS slots, but whatever.	2020-10-09 15:38:23 -07:00
Matt	a0d97f6f89	Unban GO Shiny Vulpix (#3020) ... Autumn Event 2020	2020-10-09 08:27:48 -07:00
ShadowMario3	559ec76812	Fix game version for International Gen 2 events (#3018)	2020-10-08 15:57:19 -07:00
Kurt	7cb484834c	Handle max possible level for transferred & evolved-to-new-species ... A Gen3 level 26 sylveon with a met level of 25 in Generation 8: Transferred as Eevee at level 25, and leveled up to 26=>Sylveon If we use met_level (25), we need to decrease 1 as we evolve. No, use Current Level and ensure the max isn't above the bare minimum (met level)	2020-10-08 15:35:50 -07:00
Kurt	3686ee9ec4	Set suggested Encounter Type on Met Location click too ... Closes #3010	2020-10-08 15:01:23 -07:00
Kurt	ea9076ad4c	Account for revised evolution conditions for gen4 new-evos in gen8+	2020-10-08 14:28:34 -07:00
Kurt	9e4ec32e94	Revise nickname check; language-source retained in gen8+	2020-10-08 14:14:59 -07:00
Kurt	b4eeaf847c	Disallow lang-traded eggs mismatching nickname on gen8+ ... Starting in Generation 8, hatched language-traded eggs will take the Language from the trainer that hatched it. Transferring from Gen7->Gen8 realigns the Nickname string to the Language, if not nicknamed.	2020-10-08 14:01:36 -07:00
Kurt	0de76b57b1	Handle incorrect bred stunfisk local form value ... The game uses 0x5E if 0x5A+everstone, otherwise it uses 0x58 For determining the seed species-form, we want to use everstone breeds as that resolves to the correct species-form values. Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com> Co-Authored-By: Marty-D <1645989+Marty-D@users.noreply.github.com>	2020-10-08 13:12:25 -07:00
ShadowMario3	482dbf0b17	Update Encounters2.cs (#3017) ... Fix OT for PCNY eggs	2020-10-08 08:32:18 -07:00
ShadowMario3	9516458491	Changed es1e to allow multi-OT (#3016) ... * es1e allows multi-OT, merged Stadium Psyduck OTs, added Yoshira Mew * fixed spacing on Gen 1 event OTs	2020-10-08 07:10:10 -07:00
ShadowMario3	7aac80769b	Update Encounters2.cs (#3015) ... Met + Current level data for non-Egg PCNY Pokémon and Egg legality for PCNY Pokémon fixed.	2020-10-07 18:42:14 -07:00
Kurt	e3ef9bbbff	Add current level property for met:X current:Y	2020-10-07 15:35:12 -07:00
Kurt	dad01cb522	Check egg state, reduce verbosity for language type	2020-10-07 15:28:58 -07:00
ShadowMario3	a81e675d26	Update Encounters2.cs (#3014) ... Added the remaining PCNY events. Still need to fix shiny Pokemon where Met Level is 5 but current level is 40, 50, or 70 depending on Pokemon).	2020-10-07 11:43:34 -07:00
Kurt	5d40009a0c	Add multi-OT for es2e, apply special details on enc->pkm	2020-10-07 10:36:28 -07:00
ShadowMario3	4bae0e823a	Update Encounters2.cs (#3013) ... Started to add some Gen 2 PCNY Event Pokemon and fixed Stadium 2 events.	2020-10-06 22:12:05 -07:00
Kurt	6616996905	Relocate N OT logic ... Make Legal.cs not care about encounter data :)	2020-10-06 20:09:14 -07:00
Kurt	fe7a4df17e	Clean out some gb era version flagging	2020-10-06 20:05:38 -07:00
Kurt	6e1cbfcfe5	Split GB event types and segregate per VC/GB ... Handle yielding in the moveset generator as well Future commits will trim down unused values/abstractions; probably can get all the stadium stuff handled innately	2020-10-06 19:35:03 -07:00
ShadowMario3	1681fc776b	Update Encounters2.cs (#3011) ... Fix Sing Pichu index number.	2020-10-06 10:59:18 -07:00
Kurt	aa43904869	Add stad2 boxnames, registered flag handling	2020-10-05 08:29:17 -07:00
Kurt	6938d2f94d	Split VivillonTables into two classes ... Indicate that the content is for 3DS specific logic Reduce restriction for parameters requiring IGeoTrack => IRegionOrigin	2020-10-04 14:15:13 -07:00
Kurt	36827f795d	Remove gen1 flagged moves if they can originate from egg ... Revises the tradeback status to remove any index that could have been sourced from egg moves instead. really should refactor this TradebackStatus away, but Move validation still remains one of the un-refined parts of the legality checks :P	2020-10-04 12:21:05 -07:00
Kurt	757456bf06	Move reset action to class	2020-10-04 12:08:16 -07:00
Kurt	f8de9fe1bf	Minor tweaks ... now that stadium saves all expose registered teams, can just call from the parent class rental sk2's have no TID; add that to the requirement to not get flagged for missing OT	2020-10-04 09:26:15 -07:00
Kurt	d13b893351	Use ＰＫＨｅＸ as blanksav language ... Closes #3009 Make QRPK7 implement IEncounterable and remove hardcoded PKHeX strings Let force hatching for WC3 eggs try to hatch from the savefile's language, then revert to english if failed to set an OT.	2020-10-04 08:59:33 -07:00
Kurt	5853888020	Minor Stadium behavior enhancements ... Use underscores for enum for ToString replacing with spaces Don't flag empty-OT as SK2; Stadium0/1 use the "TRAINER" as rental, but leave it blank for SK2. Don't set any terminators for an OT string if the string is empty; just wipe the buffer.	2020-10-03 21:56:57 -07:00
Kurt	833789b1b9	Fix cxd antishiny method detection ... Closes #3008 ty @Sephirona ! Do the tsv-psv compare as uint to remove the need for later casts to int	2020-10-03 09:29:26 -07:00
Kurt	2f04ef7a32	Check PK4.EncounterType for BK4 format	2020-10-02 18:09:00 -07:00
Kurt	52a67f2425	Add Stadium2 Support ... Introducing a new PKM format: SK2 Split ICaughtData2 off of PK2 so it can be shared with SK2 when type-checks occur Add conversion for PK2<->SK2 Split the split-buffer handling for GBPKM to GBPKML (what a name), so that I can reuse shared accessor logic for SK2.	2020-10-02 18:08:40 -07:00
Kurt	af4fa8078e	Add 10/1 raids ... spooky	2020-09-30 17:08:04 -07:00
Kurt	cc3a807fa9	Add default met location for gen3 roamers ... Closes #3004	2020-09-29 23:07:42 -07:00
Matt	4888d2368a	Restrict Isle of Armor Raichu-1 Ability (#3006) ... Only allows Ability 1 (all slots are Surge Surfer).	2020-09-28 12:13:15 -07:00
Kurt	cafcd3df2e	Change affixed ribbon-mark check to also consider ribbons	2020-09-27 18:19:10 -07:00
Kurt	6243135f28	Minor clean ... Move Home8 location to Locations.cs for documentation Move FestaFacility to correct folder Remove unnecessary public modifier on interface method Pass the program's Version to any loaded plugins, if they wanted to check compatibility...?	2020-09-25 23:55:31 -07:00
Kurt	7b19e3fb7f	Add affixed ribbon legality check ... https://github.com/kwsch/PKHeX/issues/3001#issuecomment-698749761	2020-09-25 19:37:38 -07:00
Kurt	6ed60fd35d	Flag suspicious PIDs for shiny VC transfers ... Configurable setting Closes #3002	2020-09-25 18:04:44 -07:00
Kurt	fbf7a3658a	Check species for static enc match ... like all other IEncounterable types, before calling the match method, check species directly	2020-09-24 19:44:48 -07:00
Kurt	fd5e38fdda	Remove artist ribbon restriction requiring master ribbon ... Closes #2997 ty @sarahlicity for an interesting bypass mechanic :P	2020-09-23 20:47:48 -07:00
Lusamine	b915f3c363	Tower of Waters / Tower of Darkness are valid Met Locations (#2996)	2020-09-23 09:15:49 -07:00
Matt	185c499bff	Unban GO Shiny Doduo (#2994) ... Mega Buddy Challenge	2020-09-22 09:23:58 -07:00
Matt	150ff88235	Unban GO Shiny Porygon (#2993) ... September 2020 Community Day	2020-09-19 17:27:25 -07:00
Kurt	b039dd28b6	Use reference to personal info rather than fetching again	2020-09-19 07:52:50 -07:00
Lusamine	b90419ba63	Akala Meadow does not exist (#2992)	2020-09-18 19:50:10 -07:00
Kurt	416f5fe183	Check Winning/Victory ribbons for gen3 origin based on encounter ... Closes #2990 ty @Atrius97 ! Remove the `object Content` accessor only used for Mystery Gifts (used to trickle up the PKM object since the two ribbon interfaces weren't implemented on the IEncounterable). Just make PCD/PGT implement the ribbon interfaces and delegate the get/set to PKM directly. Rewrite the national ribbon check for clarity Optimize invalid/missing ribbon string replace to operate on the final string rather than do linq and replace each input. With this we make 1 temp string only, rather than 1-per-ribbon. Replace hardcoded "Ribbon" strings to use a shared const string in a central spot.	2020-09-18 16:23:17 -07:00
Kurt	1a6f5163a4	Add mid-september raids	2020-09-17 18:16:16 -07:00
Kurt	e125424423	Refine zygarde encounter form checking logic ... Closes #2984 ty atrius & matt via discord Co-Authored-By: Atrius97 <39707481+Atrius97@users.noreply.github.com> Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>	2020-09-13 15:45:15 -07:00
Kurt	2e6d1fce1f	Flag non-Poké Ball XD teddiursa ... Closes #2983 , nice catch @soopercool101 ! Co-Authored-By: soopercool101 <soopercoolstages@gmail.com>	2020-09-13 14:43:48 -07:00
Kurt	7fc8001806	Continued refactoring ... EncounterTrade: don't init Location to -1; keep as default 0 and use that as the pivot for default met location. Move Fateful property to the sub-type that uses it (EncounterTrade4, for Ranch). Move some EncounterStatic->PKM logic that is per-type to the associated type overloaded methods. Rearrange order of properties to be more consistent with interfaces Gen3: Initialize some classes without using post-constructor setters. The `init` setter functionality coming in c#9 won't be usable as the net46 runtime/netstandard2 doesn't support it on current previews. Do it this way so we can explicity initialize some required properties rather than apply version on a second iteration.	2020-09-13 14:40:10 -07:00
Kurt	346c284994	Allow pkrs on gen2 eggs ... See #1257 item 7; it appears this info on Bulbapedia is incorrect -- disassembly does not care if the pkm slot is an egg or not. 5f197c53f4/engine/events/pokerus/pokerus.asm (L7)	2020-09-10 21:53:43 -07:00
Kurt	ec16202f73	Check for missing gen1 OT names ... oops	2020-09-09 22:43:32 -07:00
Kurt	01fb233e48	Minor tweaks ... Extract some interfaces Suppress some warning messages with commented reasons if appropriate	2020-09-09 12:47:24 -07:00
Kurt	5d3bc289b6	seal hunting ... Mark things as sealed as they shouldn't be inherited from or overriden in a derived class.	2020-09-07 13:51:13 -07:00
Kurt	03e227c744	Allow steel-typed magnemite for gbera ... ty MrPerson0!	2020-09-06 18:36:37 -07:00
Kurt	9191f023a3	Minor clean ... Nullability annotations and some logic simplification	2020-09-06 11:24:54 -07:00
Kurt	cf9e5ec37f	Minor refactoring ... Change Ability array to IReadOnlyList, add method to check ability index in personal data Suppress some message warnings Change EvolutionChain short-circuit for VC to jump from gen6 directly down to gen2. There aren't any notradeback 1 situations, so a notradeback1 will always start with g=1, so no need for the other if-continue. Simplify pk5 conversion	2020-09-06 10:53:13 -07:00
Kurt	8a3804e4b3	Reduce static constructor requirements ... Gen1: all are Trade1 objects, and all get the values set; just set the value in the object initializer Gen2: all are Trade2 objects, set the same version Gen2 all static encounters already have a version marked. Only thing remaining is to set the language.	2020-09-05 13:06:08 -07:00
Kurt	81e98b5549	Update EncounterStatic7.cs	2020-09-05 12:33:00 -07:00
Kurt	079ceb2752	Disallow forms completely in gen2	2020-09-05 12:25:32 -07:00
Kurt	c1adab9703	Refactoring ... Move logic closer to where it is used rather than in larger static classes EncounterStatic(7): move VC transfer template creation to class, simplify some sanity checks EvoChain: g==2 case is never hit as the generation check at the top of the loop already skips	2020-09-05 12:11:43 -07:00
Kurt	cf67d156ad	Move Gen1/2 Encounter yielding to separate class ... Specialize some of the methods so that Korean and non-tradeback cases are handled with simplified logic.	2020-09-05 10:07:02 -07:00
Kurt	6b472ffd62	Misc iencounterable->pkm generator fixes ... Still some pending stuff like bad mystery gifts gen2 static encounters on g/s applying met level and not location gen6 ralts trade (no nickname) being flagged as nicknamed when it shouldn't gen4 manaphy egg not having a hatch location (worked fine if you transferred it up) gen3 antishiny gifts not setting their PIDs (jirachi WC3) gen5 N's pkm gifts setting the wrong nature gen3 unown not being generated correctly, cosplay pikachu being allowed form0, non-BugCatchingContest no longer require Sport ball, oras dexnav marill now uses the azurill eggmove table	2020-09-03 19:00:46 -07:00
Kurt	c2ec4d55e4	Minor clean ... Add some xmldoc, remove some empty lines, move some small logic pieces to a better spot	2020-09-03 14:28:51 -07:00
Kurt	90f2ea1749	8/31 - Electric Grass	2020-08-31 18:09:15 -07:00
Kurt	ad4b560071	Minor clean ... Remove RibbonWishing as property, just calc on the fly since it's a single case Update type info for vc transfer to indicate it's an es7 Split up dreamworld encounters as intended, fix logic lol	2020-08-30 22:37:14 -07:00
Kurt	adb74ffed0	Update Trainer Name verifier with template TID/SIDs ... might be better to just have a HashSet<int> and use id32, but eh this isn't some blacklist-checker.	2020-08-30 19:59:21 -07:00
Kurt	9667e86446	Simplify dreamworld encounter init ... precompute result size set Gen5 as lumped group for common encounters remove linq usage (besides Sum call, whatever) GetEncounters now only filters the in-game static encounters rather than the dreamworld too, as those are already filtered by separate arrays.	2020-08-30 19:51:44 -07:00
Kurt	e3ad6ec55d	Make multiple-met locations a single object instance ... make trade have Any again; it's a marker to apply the gameversion since we're lazy	2020-08-30 19:24:24 -07:00
Kurt	9ce09c8b1b	Minor clean	2020-08-30 16:16:22 -07:00
Kurt	5a391bc20c	Make EncounterStatic abstract, make Generation property abstract ... Merge EncounterGift8 with EncounterStatic8 since there isn't much need to have two separate classes	2020-08-30 16:10:24 -07:00
Kurt	75da70069c	Remove access to modified captured variable ... Get the variable rather than indexing into the array each time Simplify some expressions in sav7 for readability Make SAV_EventFlags use comboitem explicitly by type rather than an anonymous type with same member names	2020-08-30 15:48:11 -07:00
Kurt	13ee3745f2	Remove some unecessary setter requirements	2020-08-30 15:44:13 -07:00
Kurt	1bc7994137	Remove usage of linq for duplicate count ... Check successive move slots after the current index rather than doing a count eq >= 2. Flag all empty slots prior to a filled move slot, rather than flagging a full slot as invalid because "empty move".	2020-08-30 15:43:29 -07:00
Kurt	81a693bafe	Make Generation property get-only per class ... don't need to store an int since it's a const-per-class	2020-08-30 15:35:59 -07:00
Kurt	ce5897ff94	Move version value from Slot to Area to reduce member size & value passing ... Restrict some setters to protected only	2020-08-30 11:08:21 -07:00
Kurt	6ee7a8724b	Offload EncounterSlot loading logic to reduce complexity (#2980) ... * Rework gen1 slot loading Slot templates are precomputed from ROM data and just loaded straight in, with tight coupling to the encounter area (grouped by slot types). * Revise fuzzy met check for underleveled wild evos Example: Level 23 poliwhirl in RBY as a level 50 poliwhirl, will assume the chain is 25-50 for poliwhirl (as poliwag evolves at 25). Instead of revising the origin chain, just ignore the evo min level in the comparison. Previous commit fixed it for gen1. * Rework gen2-4 slot loading Gen4 not finished, Type Encounter data and some edge encounters not recognizing yet... * Add feebas slots for old/good encounters * Begin moving properties Great news! Gen5-7 need to be de-dumbed like Gen1-4. Then I can remove the bang (!) on the Area accessor and ensure that it's never null! * Split off XD pokespot slot encounter table type * Set area in constructor * Deduplicate g3 roaming encounters * Deduplicate xd encounter locations (rebattle) Only difference is met location; no need to create 500 extra encounter objects. A simple contains check is ok (rarely in gen3 format). * Make all slots have a readonly reference to their parent area * Minor clean * Remove "Safari" slot type flag Can be determined via other means (generation-location), allows us to reduce the size of SlotType member to a byte Output of slot binaries didn't preserve the Safari flag anyway. * Update SlotType.cs * Handle type encounters correctly * Merge safari area into regular xy area * Merge dexnav accessor logic * fix some logic so that tests pass again rearrange g5 dw init to be done outside of static constructor (initializer instead) PIDGenerator: friend safari slots now generate with required flawless IV count * Add cianwood tentacool gift encounter * Remove unnecessary abstractions Fake area just returned a slot; since Slots have a non-null reference to the area, we can just return the slot and use the API to grab a list of possible slots for the chain. Increase restrictiveness of location/type get-set operations * Minor tweaks, pass parameters DexNav observed state isn't necessary to use, only need to see if it's possible to dexnav. Now that we have metadata for slots, we can. * Remove unused legality tables	2020-08-30 10:23:22 -07:00
Kurt	c1bc371d76	Update EncounterGenerator.cs	2020-08-29 23:50:59 -07:00
Kurt	e532a29e72	Allow gen1 moves on gen2 met data pk2's ... Thanks MrPerson0 on discord for notifying us of this mechanic. Stadium 2 can utilize Gen1 learnset data while keeping them in PK2 format, retaining the met data.	2020-08-29 23:47:03 -07:00
Kurt	780e8bf2bf	Branch to specific iterator ... Similar to fuzzy matches for gen3/4 iterators	2020-08-22 14:52:17 -07:00
Kurt	42453bdcd8	Update EncounterArea8.cs	2020-08-22 14:12:16 -07:00
Kurt	816f35d042	Split file	2020-08-22 11:59:43 -07:00
Kurt	a62324a5a1	Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974)	2020-08-21 16:35:49 -07:00
Kurt	adb55c9e7b	Make CanToggleGigantamax have a form argument ... no more meowth-1/2 and or perrserker Closes #2973	2020-08-16 23:06:49 -07:00
Matt	1d0ca29e8c	Misc changes (#2969) ... Adjust EggItemShift to account for using the big Egg sprite Add Marowak to non-transferrable Totems (none of the USUM Totems can be transferred to SWSH)	2020-08-14 13:56:37 -07:00
Kurt	67cea47b56	Fix move record flag check overflow to tracker ... Would return true if tracker is set; this bool is only checked if is egg. Add a check for eggs with home tracker.	2020-08-11 19:42:40 -07:00
Kurt	71456d98fb	Handle unhatched manaphy egg ... Closes #2965	2020-08-09 20:02:28 -07:00
Kurt	6645481829	Flag gen3 world ribbon as invalid ... Closes #2963 not like anyone actually has this ribbon	2020-08-08 22:55:44 -07:00
Matt	e2b5d9d816	Unban GO Shiny Staryu (#2962) ... Enigma Week 2020	2020-08-08 11:19:51 -07:00
Kurt	12d9397c8c	Split GO from "GG" gameversion ... Make Gen7b as the combined ver for that expression	2020-08-06 18:24:20 -07:00
Kurt	56d1eed483	Ban alolan split evolutions for lgpe origin in gen8	2020-08-06 18:21:40 -07:00
Lusamine	f611d0b780	pika pi (#2960)	2020-08-05 19:10:35 -07:00
Kurt	2b4e2a8fa1	Update Core.cs	2020-08-05 10:57:07 -07:00
Kurt	ad6728fb5c	Minor tweaks ... Check egg encounter for state rather than re-deriving some properties on the fly Only check memories if memories are exposed Remove debug assert (not always true?)	2020-08-04 22:56:55 -07:00
Kurt	85d1b0e7ad	Split gen6/7 affection stats to interface ... not in future formats, doesn't belong	2020-08-02 11:06:30 -07:00
Kurt	497639d48e	7/31 distribution raids	2020-07-31 18:13:29 -07:00
Kurt	e84ce77008	Split memories from main pkm class to interface ... pk6/7/8, not pb7	2020-07-31 17:25:14 -07:00
Kurt	b7211000b0	Split Country/Region/ConsoleRegion from ITrainerInfo ... Only present in mainline gen6/7 game pairs, so it's not wise to have it for all games	2020-07-31 13:53:42 -07:00
Kurt	36684ab867	Minor clean ... Simplify some expressions	2020-07-31 11:20:48 -07:00
Kurt	27f15d2f20	Split Country/Region/ConsoleRegion to interface	2020-07-31 11:17:31 -07:00
Kurt	05ac8acb5f	Phenac City Hexagon Brothers rebattle ... Closes #2951	2020-07-29 13:45:33 -07:00
Kurt	14da3a6539	Unban payapa	2020-07-28 10:26:44 -07:00
Kurt	7bd9ae8aeb	Simplify cxd antishiny pidiv detect ... Only check player ID Closes #2952 Had originally intended to just recognize the PIDIV and check it in the lock verifier, but this is more straightforward since we don't have to check CPU TSV.	2020-07-26 09:49:33 -07:00
Kurt	7bd36ca0c8	Minor clean ... Fix xmldoc, revert ??= because whatever nullable logic plugin I have isn't detecting this right	2020-07-26 08:54:52 -07:00
Matt	3a02bf457f	Update GO minimum Level requirements (#2953) ... GO Fest 2020 made Alolan Marowak available in wild spawns, and further testing has proved that Raid/Research PKM can be downleveled to 15 after trading to low-level accounts. This'll probably end up being deprecated in the future when we have GO->HOME transfer checks, in addition to IV checking.	2020-07-26 08:27:21 -07:00
Matt	f66d8d2ea5	Unban GO Shiny Tangela (#2949) ... GO Fest 2020	2020-07-25 08:37:13 -07:00
Kurt	d3863f9c63	Minor tweaks ... verify relearn: move split check before method call movelist: don't capture pkm in local method; meowstic ID pkm: flip argument for easier understanding	2020-07-19 18:30:46 -05:00
Kurt	a6a3c6eaaa	Refactoring ... change some expressions for better perf/readability	2020-07-19 17:48:45 -05:00
Kurt	40ce63873d	Reduce gen1 encounter legality startup alloc by 5KB ... Use precomputed counts to remove the need to store a cache of read values rename some variables in ReadSlots1FishingYellow	2020-07-19 14:08:56 -05:00
Kurt	eb7ed44b29	Finish splitting gen1/2 encounter types from parent class ... Results in a little more code, but each path is less tangled simplify some expressions remove RBDragonair content in favor of a strict filter for catch rate Move gen1 trade trainer names to stringconverter, since pk1/pk2 shouldn't refer to legality classes	2020-07-19 13:32:40 -05:00
Kurt	e4092e64df	Relocate gen3 ereader berry logic	2020-07-18 22:51:55 -05:00
Kurt	acd97c6287	Pass evolution chain for generation memory check ... chain details are already computed; pass them in	2020-07-18 21:57:15 -05:00
Kurt	35435b539e	Refactoring ... move some logic around	2020-07-18 21:51:38 -05:00
Kurt	085889d419	Pass evolution to trade match check	2020-07-18 21:50:28 -05:00
Kurt	705822c965	Abstract some gen1/2 encounter types from their parent class	2020-07-18 15:36:30 -05:00
Kurt	8fae396b76	Inject matching dexlevel for form comparison	2020-07-18 13:29:16 -05:00
Kurt	0f38478878	Fix gen2 evolution-egg test case	2020-07-18 13:06:14 -05:00
Kurt	1ecafd8db3	Update Encounters8NestDist.cs ... Puts the new encounters in the correct array; the new encounters should now be recognized on the other game version.	2020-07-17 12:18:28 -05:00
Kurt	8c52932bbe	Under da sea ... did they just give up on version exclusive raids? get yo shiny wailord	2020-07-16 21:18:37 -05:00
Kurt	ea609d43a5	Move soup to gmax class (extension methods), fix home gmax starters ... Directly accessing CanEatMaxSoup is now forbidden :) Fixes home galar starters being flagged when gmax-final evos	2020-07-16 21:04:27 -05:00
Matt	10adb9b8c1	Unban GO Shiny Bellsprout (#2945)	2020-07-16 14:59:46 -05:00
Kurt	4d3fd395e1	Add bypass for DP rotom, skip splitbreed if chain doesn't have splitbreed	2020-07-13 22:30:20 -05:00
Kurt	e04b96a9b3	Fix dizzy punch egg recognition & gen2 hatch conter verification ... Closes #2939 Fixes #2938 Inline some logic where appropriate for egg levels	2020-07-12 20:58:07 -05:00
Kurt	53e2432818	Fix gen2 egg species get ... feraligatr isn't in gen8 evolution table yet Closes #2937	2020-07-11 11:40:20 -05:00
Kurt	255498b2f8	Allow chatelaine memory ^ skillful check on format >= 8 ... Check the memory for RibbonTowerMaster; if the memory is present, permit the lack of ribbon if it was granted via past gen and has the other ribbon. Simplify !(x || !y) to !x && y Closes #2926 ty @randomdice101	2020-07-09 22:53:57 -05:00
Lusamine	fdfa10e881	Add a few static/crossover encounters (#2932)	2020-07-08 22:59:08 -05:00
Matt	fa7c8929b1	Update SWSH enc binaries, fix Rotom form/move issues (#2927) ... Some zone names were mislabeled in pkNX -- Staryu are not scripted encounters! Remove altform specific moves from distro/static Rotom, which would erroneously allow illegal mismatches (e.g. Hydro Pump Rotom-1); thanks Abyzab (Discord)!	2020-07-05 11:45:53 -05:00
Lusamine	39040358c1	Add a Whiscash (#2921)	2020-07-03 14:31:19 -05:00
Kurt	e207031920	Shuckle Magic Coat -> Encore ... Nice typo! Ty sora10pls(matt) & too salty (via discord)	2020-07-03 10:48:31 -05:00
Kurt	0198179133	Add fixed raid news content ... no change in species/form from the crownite ore one afaik; common for both games??? fix type of rigel encount so it shows up in block editor, with correct name (ty matt)	2020-06-29 21:10:12 -05:00
Kurt	993673f0de	Minor clean ... no functional change	2020-06-27 23:36:53 -05:00
Kurt	a7ba178005	Remove unreachable/const logic ... Earlier compares result in some logic being unnecessary The Gen7 level up move compare was actually an oversight, so it's a worthwhile fix :)	2020-06-27 22:44:14 -05:00
Kurt	3138fb20c6	Refactor some method signatures ... vs -> chain (clarity on what it is; an evolution chain, rather than e.v.o.s - vs) Clamp origin chain for transferred where we can use the max origin level	2020-06-27 22:18:29 -05:00
Kurt	065c1cc6d4	Specify version on all defined wc3 ... rearrange some setters for visual appearances Closes #2904	2020-06-27 14:21:45 -05:00
Kurt	5f58250b17	Pass species param to exists-in check ... Closes #2905	2020-06-27 14:04:28 -05:00
Kurt	d2ef98f7d4	Add underground staryu encounters ... not in any of our dumps, like crabrawler? why gf Closes #2913	2020-06-27 13:56:29 -05:00
Kurt	c565c7ca2c	Extract move suggest logic, add battleversion clamp ... Closes #2911	2020-06-27 13:06:28 -05:00
Kurt	0836d3191d	Rewrite some magic gender value logic ... it's always been a byte for ratios, but we never know; plus, it's a little more self documenting	2020-06-27 12:01:28 -05:00
Kurt	294d861f86	Set StatNature on IEncounterable->PKM ... Mystery Gift formats already set it appropriately in their individual implementations Closes #2901	2020-06-27 11:46:23 -05:00
Kurt	16cf59c851	Add an evolved formchange case for lycanroc ... things shouldn't be this way, but encounterstatic doesn't currently accept a SpeciesForm evolution link in the matching function, so we can't know when the form changed legally. Encounter Slots do it fine for the most part... might need to refactor the matching API so that it behaves a little smarter Closes #2912	2020-06-27 11:44:56 -05:00
Lusamine	565c9a590e	Add some cross boundary encounters (#2910)	2020-06-26 23:31:23 -05:00
Matt	3f09afd4cb	Update TradeGift_R1 (#2909) ... Both games have a pair of version exclusive trades on The Isle of Armor, as noted on Bulbapedia.	2020-06-26 11:00:45 -05:00
Chris	0c3a95fb19	Specify Legends & Sublegend species explicitly (#2907) ... self documenting don't replace other lists of species IDs tho	2020-06-25 15:11:30 -05:00
Kurt	ce5a09055a	Merge branch 'master' of https://github.com/kwsch/PKHeX	2020-06-24 18:59:30 -05:00
Kurt	1ae9cb7602	Handle pika/meow soup evolutions ... Can lose gmax flag if its current species is able to eat soup, or its origin species could eat soup this handles stuff like charmander->charizard, as charmeleon would not pass hopefully there's never a mid-stage evo that has a gmax form, and its final evo doesn't... (don't get any ideas, gamefreak)	2020-06-24 18:59:26 -05:00
Matt	a5b72bd1ce	Update VerifyVersionEvolution for Gen 8 Lycanroc (#2903) ... SWSH changed Rockruff->Lycanroc to only depend on time of day, not Version as well. Cosmoem still needs both, though.	2020-06-24 07:34:55 -05:00
Lusamine	bc1538efa5	Add some IoA cross-boundary encounters (#2902)	2020-06-24 07:34:26 -05:00
Archit Date	fd48938c8e	fix encounter criteria ability via number (#2898)	2020-06-22 22:41:15 -05:00
Kurt	a2d9f06350	Differentiate AbilityType from AbilityNumber ... invert ability index favoring so that the first ability index is most favored ability num: -1=>0/1/2 0=>0/1, 1=>0 2 =>1 4=>2 Ability Type: 0,1,2=>0,1,2 3=>0/1 4=>0/1/2 Should probably get rid of AbilityNumber definition usage but it's so entwined in the trade/static definitions...	2020-06-22 22:01:42 -05:00
Kurt	93308ca4ae	Account for losing/gaining gmax for comparison ... Don't defer for static, and don't skip for WC8 skip home gifts with player OT when SID7 not 0 (all home OTs have 6digit TID and 0 SID)	2020-06-22 21:29:21 -05:00
Matt	dcb5c1e936	Update IsMatchLocation to allow Isle of Armor Dens (#2895)	2020-06-22 10:07:50 -05:00
Kurt	6fb2ebe039	Minor clean ... add some xmldoc	2020-06-21 19:46:06 -05:00
Kurt	7e69202669	Use criteria for getting ability	2020-06-21 18:16:34 -05:00
Kurt	fc4ba1df35	Bounds check ability requested ... no longer exception's on RefreshAbility(negative number)	2020-06-21 18:16:18 -05:00
Abyzab	a797459543	Additional Cross Boundary Edge Cases (#2891) ... * Additional Cross Boundary Edge Cases The static spawn point right outside Brawlers' cave, all of the pokemon are able to chase the player into the cave and be caught https://cdn.discordapp.com/attachments/401014193211441161/724112694088695918/a0f06577821f60edf119308675de7894.png https://cdn.discordapp.com/attachments/401014193211441161/724117077698281502/JPEG_20200621_002242.jpg Unsure if there were more that spawn in this point that have the same behaviour, but these were the ones I found (w/ Ano0onymouse for Shield ones)	2020-06-21 09:33:29 -05:00
Kurt	523f101c82	Add barraskewda location ... Closes #2889 Co-Authored-By: Abyzab <abyzab@users.noreply.github.com>	2020-06-20 20:26:54 -05:00
Kurt	645db23706	Extract EvoBase and MoveList from Core ... These are really old bloated parts of the original legality checking logic; separating for now to rewrite.	2020-06-20 19:44:05 -05:00
Kurt	17f8ad97a9	Fix neutral mint index ... hardy is index 0. and isn't a mint	2020-06-20 15:05:34 -05:00
Kurt	c36c233e1d	Fix galarian slowbro form compare ... Really should be doing this with evo chain compares rather than edge cases, but whatever	2020-06-20 13:38:12 -05:00
Kurt	4c7c6532bb	Check ability deferral with more scrutiny	2020-06-20 13:14:44 -05:00
Kurt	eedaca8712	Fix mistake ... oops lol	2020-06-20 12:09:03 -05:00
Kurt	8f24477197	Weezing ingame trade can be any ability	2020-06-20 11:37:37 -05:00
ReignOfComputer	19d0f4572c	Unlock IoA Egg Locations (#2880) ... Fixes https://github.com/kwsch/PKHeX/issues/2877.	2020-06-20 07:51:28 -05:00
ReignOfComputer	2e584f43fc	Additional Statics (#2883)	2020-06-20 07:51:04 -05:00
Chris	63add7d929	Fix Master Rank Ribbon (#2874)	2020-06-19 23:20:19 -05:00
Kurt	6002dfb739	Revise master rank ribbon again ... ty terry & chris	2020-06-19 21:51:57 -05:00
Kurt	69dbde1bb4	Check battleversion state for past-gen master rank ribbon	2020-06-19 21:24:58 -05:00
Kurt	e72a58bdee	Dump latest translatable strings	2020-06-19 20:18:37 -05:00
Kurt	36dd5ece21	Initial Isle of Armor support ... Co-Authored-By: sciresm <sciresm@users.noreply.github.com> Co-Authored-By: Matt <sora10pls@users.noreply.github.com> Co-Authored-By: Archit Date <architdate@gmail.com>	2020-06-19 18:51:15 -05:00
Kurt	db30170cc5	Update EncounterArea7g.cs ... Kinda ugly but works for now Closes #2861	2020-06-16 22:40:43 -05:00
Kurt	27cce4dcd2	Disallow galar master rank ribbon on legends ... Closes #2858	2020-06-16 22:16:21 -05:00
Kurt	f51e3673da	Update AbilityVerifier.cs ... incorrectly edited (ability number needs to be bit0/1/2 not none/any other permutation) Closes #2860	2020-06-16 22:13:21 -05:00
Kurt	2cdb5d26db	Clean up some method signatures ... rename things to be a little more consistent in naming conventions	2020-06-16 21:46:22 -05:00
Kurt	f7d2101500	Update Encounters8NestDist.cs	2020-06-06 09:53:14 -07:00
Kurt	9b89ee09ec	Fix downlevel comparison ... (for good? pls) https://i.redd.it/7g2c4d3kisc41.png ty anubis remove GetMinimalLevel override, as it's doing the same thing as LevelMin. When regenerating the pkm, we aren't doing anything downlevel related.	2020-06-06 09:00:52 -07:00
Kurt	3af369c152	★Sgr6879 (Copperajah)	2020-06-05 07:31:40 -07:00
Kurt	321a2d120f	Add new distribution raids ... Add Copperajah crystal (commented); uncomment when released?	2020-06-02 07:09:49 -07:00
Kurt	a2996e6b55	Unban gen8 bred HA starters ... HOME gift -> breed	2020-06-02 07:09:17 -07:00
Kurt	16c9865505	Update EncounterStatic8N.cs	2020-06-01 14:07:26 -07:00
Kurt	ff849b9c5b	Allow fullness values for format8 ... ty anubis this totally isn't fullness, but the toys increase the value (saturation?)	2020-05-31 13:29:13 -07:00
Kurt	5c0d6d0f31	Extract downlevel check for reuse; clamp edge moves to max raid lvl	2020-05-31 13:28:14 -07:00
Kurt	3fcb29e68a	Remove some reliance on GenNumber	2020-05-31 12:12:48 -07:00
Kurt	9ff01bccc6	Add ToString override for debugging	2020-05-31 12:12:20 -07:00
Kurt	6aab8ca449	Minor renaming/type change of passed args ... Next commit will have more changes where we remove some reliance on PKM.GenNumber, in favor of the passed encounter's generation	2020-05-31 12:12:07 -07:00
Kurt	afa368823e	Minor clean ... handle some compiler messages	2020-05-26 16:59:47 -07:00
Matt	9b6190a3e9	Add Gigantamax Meowth Distribution Raids (#2842)	2020-05-25 17:39:07 -07:00
Kurt	7c6ea78c63	Add fullness legality check ... Closes #2836 Co-Authored-By: Matt <sora10pls@users.noreply.github.com>	2020-05-24 20:00:32 -07:00
Kurt	d8cd75908b	Handle gen2 gift egg collision with low hatch cycle req ... Closes #2824 ty @KR1dude ! change miscverifier to use OT_Friendship instead of CurrentFriendship.	2020-05-24 10:46:08 -07:00
Kurt	4a5a913142	Handle downleveled cases correctly ... Downleveled shared nest can't go below 20 Downleveled self nest can only happen for 1 or 3 badges and certain star counts, and the result can't be shiny	2020-05-23 22:17:47 -07:00
Kurt	0cdc225224	Kecleon: Comment out static in favor of dexnav encounterslot ... Encounter Generator stops yielding if anything was yielded (assumes things that are static encounters can't have anything else that would match). DexNav boosts the wild level (from 25/27) up to the same level 30 of the static encounter. Thanks @KR1dude ! Co-Authored-By: KR1dude <kr1dude@users.noreply.github.com>	2020-05-20 18:24:55 -07:00
Kurt	6970c3a5fb	Remove IVersion.set property, as separate interface ... I don't want people to mutate IEncounterable.Version; it's only intended to be set on-load	2020-05-19 21:46:05 -07:00
Kurt	301350d32b	Make IEncounterable expose IVersion get	2020-05-19 21:07:30 -07:00
Kurt	cce3d5d9f5	Handle race condition on get->set new cached string ... overwrite add if it somehow was added from another thread in between lock checks	2020-05-19 20:40:51 -07:00
Kurt	232a9de32e	Add gmax ev	2020-05-18 17:04:31 -07:00
Kurt	6164884700	Merge IGeneration into IEncounterable ... all but egg exposed it; now, just make egg expose it and remove the unnecessary interface we still need to Set generation for non-eggs/mgift, so have a separate Settable interface for internal purposes.	2020-05-17 12:32:28 -07:00
Kurt	4f40330af9	Add Dynamax Level = 10 to showdownset if legal ... Closes #2835 ; zacian/zamazenta/eternatus can't have a DynamaxLevel other than 0. Co-Authored-By: Mikewando <mikewando@users.noreply.github.com>	2020-05-16 15:15:41 -07:00
Kurt	1b5292cb04	append shared egg-moves rather than early return ... dl[0].Species is the same as pk.Species; more clear && array access might be slower only append shared egg moves if shared egg moves exist	2020-05-15 22:49:11 -07:00
Kurt	c8a141534c	make enc move gen tree fetch non-pkm specific ... just need to get all evo chains possible fetching a GO leafeon, need to reverse leafeon->eevee, but the LGPE evo chains don't know about leafeon works fine now	2020-05-15 21:59:06 -07:00
Kurt	3210ced006	Add new gmax-pikachu distribution details ... can be shiny can be any ability still can't evolve can't wait for gmax-eevee when this bcat expires ;)	2020-05-11 17:17:27 -07:00
Kurt	045e289c0a	Account for antishiny skip on the NPC mon right before shadow ... pretty much a copy from the other method with simplifications	2020-05-11 16:52:09 -07:00
Kurt	9b0e74dd2a	Update ContestStatVerifier.cs	2020-05-11 16:51:10 -07:00
Kurt	4decaa73f7	Verify Contest stats on gen5 origin ... extract to separate logic class; only gen3+ call this (was originally called by gen6+); only really needs to include gen5	2020-05-09 20:47:32 -07:00
Kurt	8650b5ceb2	Verify g4 tower ribbons as invalid on >=g5 origin ... https://projectpokemon.org/home/forums/topic/57026-gen-5-contest-stats-ribbons-bugissue/	2020-05-09 20:45:19 -07:00
Kurt	5fc15dc9c8	Correctly prevent xd locked shinies ... oops, 7fd7a86074 was not correct (only handled lockless) -- the verifier doesn't check the final shadow pokemon (not a lock). https://projectpokemon.org/home/forums/topic/57014-shiny-shadow-pok%C3%A9mon-from-xd-shown-as-legal-pkhex-legality-check-error/	2020-05-08 10:07:21 -07:00
Matt	383cf3e514	Unban GO Shiny Voltorb (#2829) ... Philadelphia Safari Zone.	2020-05-08 07:48:24 -07:00
Matt	333693775e	Update GO Shiny Banlist (#2827) ... Remove Venonat (Throwback Challenge 2020: Kanto). Also switch to using enum like SWSH Hidden Ability banlist -- evolution families all on one line.	2020-04-30 17:05:44 -07:00
Kurt	67b19f7244	Update Encounters8NestDist.cs ... Bye bye invalid drilbur, nice meme GF The first rotom2 in Shield had its moves changed too. Keep that rotom-2 since Discharge can't be learned at that level. since sw and sh have the same drilbur, it moves from sw -> common.	2020-04-28 11:36:03 -07:00
Kurt	2e390573bc	Add new meta distribution raids	2020-04-27 17:44:36 -07:00
Kurt	a55b4da05c	Add evo data for mimejr-0 => mrmime-0 (no gen8)	2020-04-26 12:00:45 -07:00
Matt	068f6e2f5f	Fix Big Sprite ItemShiftY (#2816) ... Strange Souvenir and Room Service would get cut off since they're tall. Also remove Adventure Guide from resources, and add Discount Coupon to Gen 7 unreleased items.	2020-04-25 11:05:12 -07:00
Kurt	0edbef8ba4	Add more HA banlist ... definitely more	2020-04-24 08:24:12 -07:00
Kurt	913d2773bf	Pass form when form doesn't match encounter ... This is still a horrible hack, needs to be done similar to encounter slots handle the galar NFE formchange cases	2020-04-23 20:53:57 -07:00
Kurt	e9406599e0	Remove more unnecessary null checks	2020-04-16 13:11:27 -07:00
Kurt	3100471299	Strip out some unnecessary logic ... notnull => no need to check for null manually	2020-04-16 12:58:48 -07:00
Kurt	b8814d2448	Split GG into LGPE (GP/GE), GG (LGPE||GO) ... Update usages	2020-04-16 12:48:18 -07:00
Kurt	a9a748e82d	Update EncounterTradeGenerator.cs	2020-04-16 11:06:54 -07:00
Kurt	ba30f33045	Update EncounterStatic.cs ... Closes #2810	2020-04-16 09:30:20 -07:00
Kurt	9b56eef821	Add deferral case for shiny type	2020-04-15 18:30:29 -07:00
Kurt	ee1cfa8912	Hanle some compiler messages	2020-04-14 10:52:19 -07:00
Kurt	40d000fdce	Extract reusable method	2020-04-14 10:08:02 -07:00
Matt	be229d03fb	Update GO Shiny Banlist (#2808) ... Forgot to update when the Easter event began. Removes Shiny Exeggcute/Exeggutor.	2020-04-13 13:57:34 -07:00
Kurt	67e9809ecd	Require exact form matching	2020-04-12 19:41:03 -07:00
Kurt	33bdacebe8	Minor tweaks ... Handle some compiler/extension suggestions	2020-04-12 16:07:59 -07:00
Kurt	0ada4cbd77	Remove some unnecessary null checks	2020-04-12 13:20:40 -07:00
Kurt	30d21e4532	Extract out showdown set interface	2020-04-12 13:05:29 -07:00
Kurt	a94c754c3f	More shedinja edge cases ... Don't allow shedinja evolution moves if it wasn't evolved in that generation	2020-04-12 11:28:03 -07:00
Kurt	8ac61d7ff7	Allow antishiny CXD spreads for some checks	2020-04-11 23:14:16 -07:00
Kurt	2e0aba55b2	Add Easter distribution raids ... No difference in sword exclusives	2020-04-09 23:04:29 -07:00
Kurt	7fd7a86074	Shiny check lockless XD shadow encounters	2020-04-09 14:14:48 -07:00
Kurt	4d061c561a	Add initial marking checks	2020-04-06 16:32:23 -07:00
Kurt	fdc174ea99	Fix raichu-a banned evolution in g7 s/m ... add a comment and parenthesis in something unrelated Closes #2807 ty @MichiS97 !	2020-04-06 08:10:49 -07:00
Kurt	270d984130	Minor clean ... Remove unnecessary null checks Mark some methods with nullable type	2020-04-04 19:30:50 -07:00
Matt	6f39f25189	Misc changes (#2806) ... Add small Female Hippopotas/Hippowdon sprites (Closes #2789) Add Pt Togepi Gift Egg Event Constant (Closes #2801) Remove Pokémon Den from Egg Locations (Closes #2804) Fix Shiny Dhelmise sprite (as per 3774e0dd34)	2020-04-04 17:10:41 -07:00
Matt	f7a83dea2c	Force Ability 1 for SWSH Gift Charmander (#2800) ... As per new findings with latest commit of pkNX: 5016baf9ea	2020-03-27 17:47:13 -07:00
Chris	f6ad77ab04	Fix item check for silvally (pixie plate) ... Remove the comparison, was a copy/paste from Arceus 3y ago a7339ae26f	2020-03-27 12:15:22 -07:00
Kurt	d73457a395	Update Encounters8NestDist.cs	2020-03-26 08:40:16 -07:00
Kurt	9e8858ac51	Allow traded gen8 eggs to have OT linktrade mem ... Stupid lacking game checks	2020-03-25 19:18:52 -07:00
Kurt	84abc04d07	3/25 Wild Area News ... Restrict abilities for crystal raids (corviknight always hidden, everything else can be anything-except-hidden).	2020-03-25 19:02:09 -07:00
Kurt	a7026236cc	Fix order of operations ... underflow behavior is desired; (uint)(10-15/10) results in zero	2020-03-25 14:37:41 -07:00
Kurt	f4952faa6f	Add zh2 trade localization ... ye it's different from the zh strings, resulting in different nick/OT ty @Lusamine ! add another gyarados location while we're here	2020-03-21 10:48:26 -07:00
Kurt	5402c5d108	Update Analysis.cs	2020-03-20 23:26:45 -07:00
Kurt	aaf6642d31	Rename Data -> BinLinker	2020-03-20 15:18:59 -07:00
Kurt	799e4852cf	Minor clean	2020-03-20 13:33:15 -07:00
Kurt	dbfcef2efe	Move files to group subfolder	2020-03-20 12:13:37 -07:00
Archit Date	e3e46209e9	add back watchtower as a legal location (#2796) ... made an oopsie, Watchtower Ruins also apparently includes 2 extra dens that can spawn encounters that are not 8NC. Den 17 is locked to 8NC encounters only, but location-wise there is no difference between Den 15,16,17	2020-03-20 07:22:44 -07:00
Kurt	c8343e9f5d	Update EncounterArea8.cs	2020-03-19 22:15:01 -07:00
Kurt	72e0fbe225	Update EncounterArea8.cs	2020-03-19 21:06:46 -07:00
Kurt	61cbf04c2e	Fix comparison to watchtower, not wild area ... unshuffle the IVs for comparison, oops	2020-03-19 21:04:17 -07:00
Kurt	a188317e84	Add another diggersby location ... ty @Lusamine	2020-03-19 20:50:58 -07:00
Kurt	27d1feafd7	Revise egg wc3 fateful check to return instead of break ... Emerald has the same met locations too, which doesn't clear fateful. So if it was hatched in an RS(E) location, we can't know for sure. Closes #2790 , but keep in mind the posted file is illegal anyways -- can't get egg move aromatherapy with wish.	2020-03-19 17:05:16 -07:00
Kurt	090f83d197	Unban and337 as held item	2020-03-18 22:31:41 -07:00
Kurt	093586bb69	Update Encounters8NestDist.cs	2020-03-18 22:23:21 -07:00
Kurt	d06949bdb3	Update min level clamps, actually compare req PID ... Closes #2787 The commit a couple days ago added the missing minimum level restrictions; community documentation was slightly misleading but we should be good now. The PID check was nonfunctional (compared A==A or A==A*), rather than actually checking the fixed PID. Co-Authored-By: feralfalcon <feralfalcon@users.noreply.github.com>	2020-03-18 12:23:09 -07:00
Matt	d004389a3e	Update Gen 4 trade min levels (#2769) ... Eggs hatch at Lv. 1 in Gen 4, and some other Species can be found in the wild at Levels lower than their intended evolution requirement. Closes #2768	2020-03-16 18:14:22 -07:00
Kurt	3aaf318035	Update event database, handle HOME gifts horribly	2020-03-14 14:22:45 -07:00
Kurt	94d8125574	Split up Friend Safari checks & generator ... removes one GetEnumerator call for non-fsafari encounters	2020-03-14 11:32:27 -07:00
Kurt	6a5bf02126	Add min levels for trades ... Make PIDs readonly for trades Clone FR/LG Lickitung (different min levels)	2020-03-13 21:39:35 -07:00
Kurt	6f0c3c1205	Add 3 more met locations ... Co-Authored-By: Lusamine <lusamine@users.noreply.github.com>	2020-03-12 20:36:31 -07:00
Kurt	fbd533092d	Fix misspelling of the word "Received" ... Closes #2757 Co-Authored-By: pi1024e <pi1024e@users.noreply.github.com>	2020-03-12 15:05:34 -07:00
Kurt	b5f1fc71c4	Use original PID for xor flip check ... swap pkm.PID -> pkm.EncryptionConstant, simplify comparison Co-Authored-By: Lusamine <lusamine@users.noreply.github.com>	2020-03-11 20:09:09 -07:00
Kurt	1d5f929981	Fix shiny check behavior for XD nonshadows ... XD compares the player TSV against the non-shadow members, which is unnecessary but does result in them being able to cause shiny skips. Update the VerifyNPC method to remove tsv check, as it's just repeating the logic we've done in the lock generator. Added a test method that can be stepped through; compare the team results manually since they aren't exposed for interaction. Closes #2751 , big thanks to @ijuintekka for being so detailed in their investigation/report! Co-Authored-By: ijuintekka <ijuintekka@users.noreply.github.com>	2020-03-11 19:18:58 -07:00
Kurt	efc0a9bcc4	Ban HA Pumpkaboo/Gourgeist Small/Large ... Co-Authored-By: Lusamine <lusamine@users.noreply.github.com>	2020-03-11 17:38:01 -07:00
Kurt	1c2d9cf84c	Add another Lanturn location, level 38 Corviknight ... Yay using bots to collect encounter data from players around the world :P Co-Authored-By: Lusamine <lusamine@users.noreply.github.com>	2020-03-11 16:38:04 -07:00
Kurt	eccfb61839	Update BallVerifier.cs	2020-03-10 22:59:46 -07:00
Kurt	9dbc3cd418	Permit galar native species to inherit past-gen balls	2020-03-10 17:53:56 -07:00
Kurt	093ce2a020	Add ★And337 4-Star Gigantamax Corviknight	2020-03-08 17:20:00 -07:00
Kurt	e2c579fbbc	3/8 - Gengar/Machamp nests ... New? Dynamax Crystal: ★And337 - 4-Star Gigantamax Corviknight ???	2020-03-08 17:14:20 -07:00
Kurt	ed02f39224	Use another overload ... Co-Authored-By: Archit Date <architdate@gmail.com>	2020-03-04 22:31:07 -08:00
Kurt	b831d52b79	not capturable ... gotta drip feed content -- tease ppl to migrate from prior games ($$$)	2020-02-26 17:16:52 -08:00
Kurt	283b7a353b	Add mewtwo raids ... Mewtwo encounter has been added; awaiting confirmation that it can be captured (assumed yes) Gen1 starters can be captured in beast ball in gen7 (scan), so nothing changes for ball legality.	2020-02-26 17:03:53 -08:00
Matt	0b5116f567	Add Battle Frontier + Facilities to Valid HGSS Met (#2735) ... Accessible in Pt/HGSS, but not DP. Closes #2734	2020-02-25 13:15:50 -08:00
Kurt	549e6f616b	allow shared eggmoves on format	2020-02-22 23:27:47 -08:00
Matt	7cb80fdbc5	Update GO Shiny Banlist (#2731) ... - Valentine’s Day Event (Chansey) - Raid Day (Lickitung) - February Community Day (Rhyhorn)	2020-02-21 19:40:10 -08:00
Kurt	509e2f1fa3	Handle more evolution/form checks ... Closes #2726 1. Add variant evolutions to form-match cases 2. Ban LGPE origin alolan raichu 3. Add egg form check for unavailable regional forms 4. Previous commit fixed mew (remove ribbon interface from WB7) Co-Authored-By: Matt <sora10pls@users.noreply.github.com>	2020-02-20 22:11:48 -08:00
Kurt	15121c2945	Fix shared egg moves for non-galar origin ... Use the private method; we already know the gen and that the egg moves are permitted Relocate method to MoveEgg	2020-02-16 19:47:57 -08:00
Kurt	0e2734d2d5	Add evo data for alolan raichu / weezing ... Ban the evolution methods since they can't be triggered in-game allows the gen8 evo tree to reverse evolve past gen specimens	2020-02-16 18:16:22 -08:00
Kurt	ee38e6890b	Disallow gen7 ribbons on lgpe origin	2020-02-16 17:41:38 -08:00
Kurt	f48a11f013	add 2/17 raids ... milcery gone, toxel appears	2020-02-16 17:02:53 -08:00
Kurt	fc9d0b4b24	Add hint for pkm with dummied moves ... Closes #2716	2020-02-16 12:17:36 -08:00
Kurt	0d4cff81c6	Clean	2020-02-15 14:29:23 -08:00
Kurt	5e65df6758	Update egg ball check for galar non-natives ... pretty rough check, but flags the old starters in bad balls now	2020-02-15 14:22:37 -08:00
Kurt	21eb9cb499	Remove gen7b trade evo if HT present requirement ... lgpe->HOME->lgpe can set the HT details, but it isn't a trade.	2020-02-15 13:43:58 -08:00
Kurt	3e4bb9f320	Ignore keldeo resolute form check on gen8+ ... can mismatch in gen8+ as the form activates in battle when knowing the move; outside of battle can be either state.	2020-02-15 13:30:50 -08:00
Kurt	9e16df4970	Only check g6 contest ribbon affection in g6/7 ... Affection is discarded on PK7->PK8 in favor of friendship, which can be lowered.	2020-02-15 11:43:21 -08:00
Kurt	b9e3ddf612	Disallow regular slowpoke ... Closes #2708 Can't be moved into the game (no sprites yet). To be removed or handled a better whenever DLC comes out.	2020-02-14 14:52:05 -08:00
Kurt	0c83c48cef	Add MrMime-1 check for past gen origin ... permit mime jr evolving to mr mime-1	2020-02-13 20:00:41 -08:00
Kurt	f62b6e33f3	handle alolan meowth origin in gen8 ... https://projectpokemon.org/home/forums/topic/56267-checks-associated-with-events-or-forms/	2020-02-13 17:05:06 -08:00
Kurt	c855bb8bcc	Expose method for reuse in other projects	2020-02-12 20:42:45 -08:00
Kurt	75d8635580	Fix lgpe moveset restriction ... Closes #2704 Co-Authored-By: BetaLeaf <betaleaf@gmail.com>	2020-02-12 20:25:39 -08:00
Kurt	6346444db7	Extract home tracker to interface	2020-02-12 18:52:48 -08:00
Kurt	3d6846eb3e	Permit more HA breeding ... Remove non-galar species from gen8 banlist Add Ban_NoHidden8Apricorn -- all of these aren't even breedable in-game anyways, but futureproof for DLC? ;)	2020-02-12 18:40:41 -08:00
Kurt	258993ad0c	Flag missing tracker regardless of setting	2020-02-12 18:29:47 -08:00
Kurt	63044cd3f9	Add tracker unique text & setting	2020-02-12 18:10:24 -08:00
Kurt	fd4690714e	Add duplicate tracker SAV check	2020-02-12 16:37:59 -08:00
Kurt	3e9262efbb	Only check memory feeling restriction if gen6 ... dunno restrictions for gen8 memories.	2020-02-11 22:25:50 -08:00
Kurt	87bb4c4138	Add more met locations ... https: //projectpokemon.org/home/forums/topic/56227-bug-missing-game-encounter-affecting-legality-status/ Co-Authored-By: pp-theslayer <pp-theslayer@users.noreply.github.com>	2020-02-11 20:50:26 -08:00
Kurt	d97db1cc40	Allow pk7->pk8 pikachu cap transfer	2020-02-11 20:36:10 -08:00
Kurt	ebf20d927b	More transfer implications ... Totems are downsized to regular araquanid, togedemaru, and ribombee totems can't transfer (at the moment)	2020-02-11 20:11:33 -08:00
Kurt	217156d2b9	Continued comparisons & implications ... pk7->pk8 doesnt assign height/weight (zero), require zero for legal p*7->pk8 assigns a tracker value, enforce something is present for legal copy OT friendship (oops)	2020-02-11 18:35:54 -08:00
Kurt	7523639b48	Unbanana galar transfers ... Initial restriction removal, probably more implications Need to reverse transfer logic	2020-02-11 17:29:10 -08:00
CanoeHope	29814d4251	Change FRLG hatch location (#2700) ... Better location.	2020-02-11 15:39:27 -08:00
CanoeHope	d3a284699f	Change Gen 5 hatch location (#2695) ... Skyarrow Bridge is more popular to hatch at legitimately.	2020-02-10 12:52:55 -08:00
Kurt	cb5d8186fd	Defer formargument for raids ... Closes #2693 Account for runerigus too, if they ever have a den for it ;) Co-Authored-By: crzyc <crzyc@users.noreply.github.com>	2020-02-09 15:04:45 -08:00
Kurt	b94430a89f	Ban bred HA voltorb in beast ball ... https://projectpokemon.org/home/forums/topic/56212-legality-ha-voltorb-in-beast-ball/ https://www.reddit.com/r/BankBallExchange/comments/7boi0h/new_apricorn_and_beast_ball_combinations_for_usum/dpwu5in/ ty Prophet丶W	2020-02-08 20:24:02 -08:00
Kurt	4656978a43	Enforce toxtricity encounters to have restricted nature	2020-02-08 15:08:12 -08:00
Kurt	e9e1e5e166	Fix encounter find for passed egg moves ... https://projectpokemon.org/home/forums/topic/56188-encounter-database-froslass-error/	2020-02-08 13:36:37 -08:00
Kurt	8e5876b96f	Expose item->form methods	2020-02-07 21:34:25 -08:00
Kurt	6e5ef9667f	Add female gender check for stadium ... Closes #2687	2020-02-06 21:25:13 -08:00
Kurt	29258ca501	Add tox nests	2020-02-06 17:11:39 -08:00
Kurt	81c78be8c7	Change default gen7 hatch location ... ty @CanoeHope #2685	2020-02-05 19:42:22 -08:00
Kurt	d3d6225a73	Fix unown ?! order ... Closes #2683 ty @Kermalis !	2020-02-04 19:03:55 -08:00
Kurt	5ac9782320	Form check wild unown ... Closes #2682	2020-02-04 17:38:35 -08:00
Kurt	867f62c555	Check multi lang stadium OTs ... Closes #2671 really wish the gen1-3 event data was serialized ;)	2020-02-03 20:10:07 -08:00
Kurt	522dbdbe32	Flute boost/decrease 3->4 ... Closes #2678 ty @Rayqo dat level 1 wild pokemon 👍	2020-02-03 18:40:31 -08:00
Kurt	222d95e742	Add bridge field loc for nest35 ... https://projectpokemon.org/home/forums/topic/56154-illegal-theivul/	2020-02-01 21:45:33 -08:00
Matt	cbf6c1e1b6	Unban Star Sweet and Ribbon Sweet (#2670) ... Item drops from the new Milcery distribution Raids.	2020-01-30 19:30:17 -08:00
Kurt	774dec5123	Add milcery distro nests	2020-01-30 16:44:51 -08:00
Archit Date	c8a16a1f71	fix yamask/runerigus form handling (#2669) ... fixes #2668	2020-01-29 16:11:56 -08:00
Kurt	dd07126d83	Relocate level suggestions to EncounterSuggestion	2020-01-28 16:21:38 -08:00
Kurt	3111a8dc62	Cast the array a little safer ... bad hacks with invalid future gen evolutions yield no evolution data, which results in empty arrays.	2020-01-26 23:58:14 -08:00
Kurt	f0fb6a2371	Play with living dex gen a little ... generate altforms too, store in a list	2020-01-25 22:54:25 -08:00
Kurt	c301ce88ab	Update Random to be a bit more thread safe ... Random isn't thread safe; users of PKHeX.Core.dll might run multithreaded operations (see PKSM + ALM), so we need to have a thread-specific RNG available. Thread Local get; to improve performance, save the random object locally whenever it is used more than once in the method. https://docs.microsoft.com/en-us/dotnet/api/system.threading.threadlocal-1?redirectedfrom=MSDN&view=netframework-4.8 https://stackoverflow.com/questions/18333885/threadstatic-v-s-threadlocalt-is-generic-better-than-attribute/18337158#18337158	2020-01-25 21:49:52 -08:00
Kurt	9b062bc770	Remove unused legality check strings ... Fix spanish translation messages not being loaded	2020-01-25 17:37:47 -08:00
Kurt	ffa70e7626	Move files ... no functional change, just putting stuff in a more appropriate folder	2020-01-25 17:22:20 -08:00
Kurt	3813d5dba9	Readonly init EvolutionMethod ... Add xmldoc	2020-01-25 15:42:17 -08:00
Kurt	9c28ffacc0	Simplify N's pkm encounter handling ... Readonly PID; sparkle is True always, so it's a const instead of a mutable property.	2020-01-25 12:31:56 -08:00
Kurt	7a7358d0e5	Flag g4 bad met locations for hatched eggs ... Traded eggs in gen4 can have from any game (since version isn't updated on hatch). Use the hashsets, and remove the incorrect array. The incorrect array allowed stuff like Pokéwalker to be a "valid met location", hah.	2020-01-25 12:19:59 -08:00
Kurt	c730dfa1ba	Remove empty ushort[1], improve item combo fetch ... held item list now allocates less (concat arrays instead of ienumerables) item list already prunes out of range items, so simplify data source fetch simplify item list prune (return as list, so we can call RemoveAll instead of Where.ToList)	2020-01-24 23:29:45 -08:00
Kurt	94eee74e5c	Add another rhydon lvl 46 loc ... Ty @slp32 for reporting in #2633, && anubis (discord) for finding the actual level without being asked /s	2020-01-24 17:56:42 -08:00
Kurt	ecfcbbc4cb	Verify full raid result with known seed	2020-01-23 00:11:07 -08:00
Kurt	d9c162b5cf	Fix criteria comparison ... Closes #2651	2020-01-21 09:05:39 -08:00
Kurt	5be9c6bcc8	Remove unnecessary null handling ... objects are no longer null	2020-01-20 23:32:05 -08:00
Kurt	5bb51b07ac	Check Footprint Ribbon for gen8 ... gen7 used same as gen6, we just need to restrict gen!=8 add placeholder LGPE origin check; that'll likely throw a wrench into things when HOME happens (next month?).	2020-01-20 23:09:28 -08:00
Egzon	1a3d8b1fab	Fix Seedot and Nuzleaf swarm moves (#2648)	2020-01-20 14:31:59 -08:00
Kurt	d788af45cd	Unban HA mimikyu ... Only one encounter for mimikyu = A4 }, // Mimikyu Update manual banlist to permit it Closes #2646	2020-01-19 19:02:53 -08:00
Kurt	63ea57436f	Make the template IV/contest stat array readonly ... See prior commits no longer need to clone subarrays, they're shared immutable	2020-01-18 19:11:29 -08:00
Kurt	843330a375	Remove unnecessary null checks ... this is a null free project /s dont provide null, else u deserve to get an exception	2020-01-18 16:57:25 -08:00
Kurt	8312c52cc1	Make Move[] readonly list ... contract: don't modify the template movesets mystery gift now exposes IRelearn, remove unnecessary type checks	2020-01-18 16:46:38 -08:00
Kurt	0cd9c47953	Make Relearn array for encounters readonly ... No change em	2020-01-18 16:31:24 -08:00
Kurt	bd9ec72d98	Misc tweaks ... Add more direct legality analysis constructors evo count is >= 1 fix invalid test message disallow gen2 moves if transferred from gen1 use ^1 instead of len-1 for netcore test project	2020-01-16 23:22:54 -08:00
Kurt	c739af4767	Extract item restrictions to separate class ... Move similar classes to folder	2020-01-16 19:27:29 -08:00
Kurt	baf46f9a3a	cache form/species/format on first get ... very minor perf consideration, since those values are immutable (except for cross thread shenanigans)	2020-01-16 19:23:29 -08:00
Kurt	e97970023a	Add swsh battle-only forms	2020-01-16 19:03:47 -08:00
Egzon Qukovci Jusufi	deece433a5	Add SWSH Legends to the Tables (#2637)	2020-01-15 20:49:19 -08:00
Kurt	aecc08f65c	Remove duplicate electrode encounter ... 3IV requirement isn't required for wild slots that are also at the same level-location Closes #2636 ty @dstevenson12 !	2020-01-14 18:39:25 -08:00
Kurt	f4162d2dce	Add another corviknight location ... ty anubis Closes #2633	2020-01-13 22:36:00 -08:00
Kurt	11978dab4f	Make pgt ranger manaphy IsEgg true	2020-01-12 23:00:32 -08:00
Kurt	81f280f4d1	Update EncounterSuggestion.cs ... weaken legality check, we only check moves	2020-01-12 20:49:33 -08:00
Kurt	5a20dc707d	Rewrite encounter suggestions ... Don't clone legality templates, and keep suggested information minimal -- this isn't automod	2020-01-12 19:40:36 -08:00
Kurt	eaeebea923	Remove another method shortcut ... EncounterSuggestion needs a facelift anyway	2020-01-12 17:00:03 -08:00
Kurt	3b5c7062ac	Minor perf improvement ... pass in, don't constantly fetch helps generated IL code be slightly more efficient	2020-01-12 16:49:12 -08:00
Kurt	a8c28369b6	Add Yamask-1 max hp calc for formArg compare ... Closes #2632 ty @CanoeHope	2020-01-12 16:22:56 -08:00
Kurt	d5948b9dbe	Add relearn moves to Except comparison ... Burn Up ho-oh is dumb	2020-01-12 16:09:35 -08:00
Kurt	48fd36a9a2	Handle g4 shedinja learn case too ... change 291/292 to Shedinja/Ninjask for easy enum reference check	2020-01-12 14:34:29 -08:00
Kurt	61ecb52347	Remove unnecessary allocation	2020-01-12 12:06:33 -08:00
Kurt	82eaf39d45	Remove method alias for init mysterygift db	2020-01-12 11:41:23 -08:00
Kurt	9ed441885a	Remove manual personal info fix ... Change FDDC from 47 -> 41 SM is 40, as the tutor isn't possible in that game.	2020-01-12 11:39:43 -08:00
Kurt	f6fb54aecc	Move shedinja/egg evo chain short circuit ... Some routes use the evolutiontree directly instead of this method (with the same name); should probably consolidate but meh This causes Shedinja to yield the correct evolution chain when called directly (because nothing naturally evolves to shedinja; it's created out of thin air as a clone) Take the egg short circuit with it to keep things simple	2020-01-11 21:43:58 -08:00
Kurt	0eca1bbd1c	g3 shedinja api usage fix ... see comments in src for justification need ninjask moves if gen3; dl.Count is guaranteed to be >= 1	2020-01-11 21:41:24 -08:00
Kurt	d3f6d5935f	Add form argument legality checks ... Closes #2611 (Alcremie) Closes #2604 (Runerigus)	2020-01-10 16:33:40 -08:00
Kurt	fdd321dd8c	Make memory 6 fishy if textvar present ... Closes #2621	2020-01-10 16:08:34 -08:00
Kurt	be92d4436e	Rearrange argument check order ... USUM evo table has Meowstic with Arg=-1, which early aborted. Closes #2627	2020-01-10 16:02:22 -08:00
Kurt	718d00f970	Ban ha slowpoke-1	2020-01-09 23:50:15 -08:00
Kurt	51d2fc9d93	Update with slowpoke-1/new raid data ... TransferVerifier: Revise transfer check to allow slowpoke-1 (slowpoke-0 is flagged via next check)	2020-01-09 18:44:45 -08:00
Kurt	0dd4d1fe7a	Remove unnecessary casts	2020-01-06 17:50:18 -08:00
Kurt	3d581283c2	Minor clean ... move Text.cs manual Courier new() to the designer, have it dispose when form is disposed. Set it as the numericupdown's font and just reuse that :)	2020-01-05 18:46:30 -08:00
Kurt	7caeebd772	Add formcount for scatterbug/spewpa ... USUM had 20 for both, but XY/AO/SM had only 1 (vivillon had 20); make them consistent so that our generated evolution paths behave correctly Add meowstic specific evolution form modifier... so silly simpler to have it inlined with the sSpecies, for jit optimization could probably do this with silvally but meh, things work fine now Closes #2603	2020-01-04 22:31:46 -08:00
Kurt	68e6644d40	Split off shared nest class, deduplicate logic ... use generics to have shared logic in one spot Handle downleveled distribution/crystal(soon?) data	2020-01-04 11:44:16 -08:00
Kurt	308e6fa291	Add temp workaround for version encounter fetch ... PKX.Generation is 8, which returns SWSH evo tree; evo tree doesn't have non-galar-native species data, so stuff like Ambipom don't get reversed properly. use math.max for tree fetch when appropriate: - egg generator: pre-evolutions like pichu should be allowed if pk1 - don't fetch format twice, just do math.max	2020-01-04 11:14:25 -08:00
Kurt	15779513f5	Add stubs for raid correlation verifiers/generators ... Not going to implement this within the base repo as z3 is too large of a dependency and is platform specific. If anyone wants to implement as a plugin project, just inject your new methods via the setters on the static func/action at the top of the 3 classes. Since z3's searches aren't instant, I'd recommend caching recent results in a dictionary, as re-parses are common. Something like the Wordfilter is what you'd be aiming for :) Closes #2617	2020-01-03 20:03:04 -08:00
Kurt	0788780404	Add bewear motostoke crossover location ... Closes #2619	2020-01-03 19:14:03 -08:00
Kurt	fe8e5e3fd9	Add more string search methods ... exposes some common string search operations that can be useful for parsing user entered data	2020-01-02 12:06:58 -08:00
Kurt	b55dc37e05	Extend some logic ... make summary more accessible	2020-01-02 10:55:37 -08:00
Kurt	166f8d82e5	Misc clean ... Refactor out some logic, make "en" literals reference one spot (where appropriate)	2020-01-01 19:07:21 -08:00
Kurt	7e490b8dcc	Add lanturn/bronzong alt locations ... Closes #2613	2019-12-31 21:47:28 -08:00
Kurt	14eae5f62d	Add magikarp distribution data	2019-12-30 22:32:12 -08:00
Kurt	3b2b86950f	Ignore symbols (apostrophe) for string matching ... Farfetch'd vs Farfetch’d	2019-12-30 15:39:13 -08:00
Kurt	84c5f6e914	Add another met location for gastro-1 ... Closes #2612	2019-12-30 15:11:54 -08:00
Kurt	9864f23427	Handle Bridge Field->Stony Wilderness berry tree ... Closes #2610	2019-12-29 12:48:34 -08:00
Kurt	d6471e2b3b	Add more pelipper & dusclops strong locs ... ty anubis	2019-12-29 11:28:29 -08:00
Kurt	ce62d63c5a	Fix eggmove fetch for move check ... Closes #2609	2019-12-29 10:17:07 -08:00
Kurt	bfd9bf6b53	Simplify formchange calls ... Don't use the dex chain for certain checks, it's unnecessary.	2019-12-28 19:00:01 -08:00
Kurt	8493471793	Add alcremie form change case	2019-12-28 18:59:00 -08:00
Kurt	3280adcb9f	Add another location for Golurk & Galvantula ... Closes #2606	2019-12-28 18:03:20 -08:00
Kurt	b294eba181	Fix combee gender check ... silly convoluted checks #2603	2019-12-27 19:17:08 -08:00
Kurt	940cdccb6b	Restrict downleveled to lvl % 5 == 0	2019-12-27 00:17:59 -08:00
Kurt	ceae77c677	Add load-line overlap location for Den 27/42 ... The nest is situated right next to the load line, and may be accessed from either map (across the load line), resulting in a Dusty Bowl Pumpkaboo-0. Many thanks to Anubis on Discord for figuring this (very silly) thing out !	2019-12-26 18:59:02 -08:00
Kurt	5cb3556eee	Add Move PP verification ... Eggs already had it, adding now for regular pkm Closes #2602	2019-12-26 14:28:01 -08:00
Kurt	6c7065fb7b	Fix bool compare ... oops https://github.com/kwsch/PKHeX/issues/2600#issuecomment-569134146 ty @slp32 !	2019-12-26 13:12:10 -08:00
Kurt	bb7c94dadb	Add seismitoad location ... https://github.com/kwsch/PKHeX/issues/2570#issuecomment-568235086	2019-12-26 13:04:44 -08:00
Kurt	baf0f52f06	Handle downleveled raids ... Closes #2573 - self-hosted raids can be downleveled too (see cufant), probably only by 1 rank - min-rank check now checks for downleveled cases - Add extra gyarados/ferrothorn locations	2019-12-26 12:59:16 -08:00
Kurt	4740fab5ec	Have separate encounter yielder for gen8 ... the "Strong" static encounters can be near-matches with wild encounter slots; example is a evolved Cutiefly->Ribombee with Quiver Dance. Remove unnecessary IsLink/FriendSafari check for this gen8 method https://github.com/kwsch/PKHeX/issues/2573#issuecomment-569126371	2019-12-26 12:32:48 -08:00
Kurt	420307d4bf	Make non-exportable saves (fake) act as VC saves ... https://github.com/kwsch/PKHeX/issues/2600#issuecomment-569125853	2019-12-26 12:21:35 -08:00
Kurt	0c7d347a29	Add Delibird distribution data, split files ... ROM nest data definitions are already pretty hefty and won't be revised; split out the future content	2019-12-25 14:26:49 -08:00
Kurt	e6dcf64abe	Disallow Spiky Ear Pichu eggs ... sneaky gen4 bad hacks are bad	2019-12-24 13:21:56 -08:00
Kurt	ea5ca7b2d2	Add Ingredients to swsh held item list ... Closes #2597	2019-12-22 12:16:06 -08:00
Kurt	3b2ebbb84f	Add PID check for gen4/5 Combee->Vespiquen evo ... Closes #2593	2019-12-21 16:52:56 -08:00
Kurt	7edfe4543f	Flag eggs with HT string ... Closes #2586 Modify PKM Info already clears it, but if disabled, will be flagged.	2019-12-21 16:01:51 -08:00
Kurt	8309060298	Add more egg verification for statnature/techrecord	2019-12-21 14:51:52 -08:00
Kurt	7889a0abe6	Simplify form egg move handling ... Closes #2588	2019-12-21 13:37:20 -08:00
Kurt	d7bc68d7a5	Add HT case for capture memory check ... #2570 https://github.com/kwsch/PKHeX/issues/2570#issuecomment-568149050	2019-12-20 19:47:40 -08:00
NotTsunami	a05b38ab39	Legality: Add Nature and Gender to Gen 8 Trades (#2591) ... Closes #2589 https://bulbapedia.bulbagarden.net/wiki/In-game_trade#Sword_and_Shield	2019-12-20 10:48:46 -08:00
Kurt	506e64186a	Rearrange & re-do "CanHaveMemory" value check ... Closes #2581	2019-12-11 19:37:57 -08:00
Kurt	108233b45f	Add glalie/skuntank locations ... #2570	2019-12-10 19:54:26 -08:00
Kurt	fcdd7019d3	Add missing shadow yanma location ID ... Closes #2577 thanks @HoppyShnell ! -- this looks like the final met location ID?! Not sure if Murkrow (locked) is missing one; moved duplicate-location Heracross and made it use the same locks.	2019-12-10 19:22:46 -08:00
Kurt	9a87647409	Add more static encounter locations ... Some of these are probably crossovers #2570	2019-12-09 19:28:57 -08:00
Kurt	c85c8ded5c	Fix crossover location compare, add formchange ... Rotom can change forms, first time it's available in the wild. Fun. Fix crossover location comparison (was always returning false).	2019-12-09 19:28:28 -08:00
Kurt	281c1ae744	Skip SWSH untraded link trade eggs if trade-memory ... just read the comments & code, this one is an annoying oversight untraded pkm /should/ never have HT memory data, but sometimes it do be like that Closes #2571	2019-12-09 16:23:29 -08:00
Kurt	aa2241ba66	Fix unchangeable OT friendship to compare correctly ... Closes #2572 ty @sora10pls for confirming that evo chains are necessary for VC transfer	2019-12-09 15:50:03 -08:00
Kurt	0fa25b4c8c	Fix VC transfer evo chain population ... Move EncounterOriginal to Legal info; needed in order to pass the correct encounter to the EvoChain fetch. The EncounterOriginal 'hack' might be unnecessary with the current state of the legality checker... maybe can see if it can be removed later.	2019-12-09 15:48:54 -08:00
Matt	5395cf6bab	Update UnreleasedHeldItems_8 (#2575)	2019-12-09 12:35:50 -08:00
Kurt	8acb336d51	Use enum for species comparisons ... slightly easier to read with named values	2019-12-08 17:39:19 -08:00
Kurt	475dc02101	Add edge case handling for indeedee shared egg moves ... #2416	2019-12-08 12:08:21 -08:00
Kurt	c6ef2a845d	Fix ribbon compare ... oops	2019-12-07 23:39:32 -08:00
Kurt	4611146807	Update memory verifier ... Adds handling for SW/SH quirks Closes #2545	2019-12-07 23:36:39 -08:00
Kurt	19b1564eb2	Split history and memory verifiers ... Rewrite a bunch of the history verification stuff Fix a few test cases with incorrect OT Friendship (transferred), and missing GeoCountry Need to rewrite memory verification next (All test cases currently pass) #2545	2019-12-07 18:12:31 -08:00
Kurt	34452c2818	Add gen8 ribbon verification	2019-12-07 11:58:56 -08:00
Kurt	aa3d63e982	Add Mr. Rime to splitbreed table ... Closes #2567	2019-12-07 00:04:46 -08:00
Kurt	861d7b6014	Remove unnecessary parameters for species fetch ... #2567	2019-12-07 00:00:49 -08:00
Kurt	2b1aee7c38	Gen8: Update rules for having BestFriends ribbon ... Closes #2562 ty @iiippppk	2019-12-06 20:22:23 -08:00
Kurt	d08e3a3f81	Fix form change evolution linking ... GetDestinationForm for gen7+ is fine gen7 and gen8 use the "form" argument as the destination form; -1 means don't change espurr-F just gets forced to 1 in gen7 since it's -1 Closes #2564 ty @iiippppk	2019-12-06 19:31:18 -08:00
Kurt	d24a09f7c9	Make level min/max virtual for nest ... Closes #2566 be sure to set the correct flawless IV count & dynamax level so that the encounter matches	2019-12-06 19:17:26 -08:00
Kurt	862a446eb3	Fix form sanitization for de-evolution ... Better to handle things this way, we know for sure the form it HAS to originate as. Closes #2565 ty @iiippppk !	2019-12-06 19:00:41 -08:00
Kurt	be38a60267	Fix handling for get evolutions method ... only used for Zukan7b, but add in handling so that it works for <=gen6 games, and supports form alterations too! update style to match GetPreEvolutions could probably update this to yield tuples (species, form) but LGPE/SWSH only needs species. If there's the need for tuples later, should be ez tweak.	2019-12-06 18:16:11 -08:00
Kurt	314d8f6b58	Update form destination handling ... espurr-F evolves to form-1 from form0, even tho the form arg is -1 (gen7 consideration) gen8 has 0/1 for the two evolutions, dictating the destination form	2019-12-06 17:36:36 -08:00
Kurt	f7620908df	dummy out empty evo species	2019-12-06 17:21:38 -08:00
Kurt	eac3804c7b	Clean up dexlevel/evocriteria constructor usage ... DexLevel was the initial abstraction, which was expanded/reused for evolution details I should probably merge the two classes since everything is passed as EvoCriteria The encounter generators do some silly form fuzzy match which can now be more accurately checked since I've moved Form to DexLevel... maybe a future commit can clean that up. encounterarea2 was reusing this class, just use a throwaway readonly struct as our temp value storage	2019-12-05 23:04:24 -08:00
Kurt	b49c5a5a8a	Rewrite evolution lineage generating ... - Use tail recursion and a lookup table (species | form) for reversing - generate the reversal lookup by extrapolating all species-form destination values (EvolutionLink) All tests pass, and no special handling for forms is required. Kinda suspicious that it works this simply... Redo evolution banning (no wormhole for non-Alolan evolutions in SM), in a style that we can ban the Gigantamax event evolutions (pika/meowth/eevee). Their evolutions can't be resulted from a pre-evo, because the in-game routine early aborts if the gigantamax flag is set for those species. Update gen4 personal tables (formCount was 0, needs to be a minimum of 1 by default) Closes #2537	2019-12-05 22:32:47 -08:00
Kurt	786d9c8f18	Handle shedinja encounter balls ... nincada -> spawn shedinja = pokeball (wild encounter rules if gen3) shedinja encounter = wild encounter rules	2019-12-05 16:40:14 -08:00
Kurt	b2fc99e50a	Update nest dist/crystal location get/check	2019-12-04 19:04:36 -08:00
Kurt	e333f9b441	Add orbeetle 65 loc ... thanks @sora10pls	2019-12-03 19:59:10 -08:00
Kurt	71318c9bd5	Add clarification/notes	2019-12-03 19:54:06 -08:00
Kurt	ab7cf3252e	Add snorlax raid dist data	2019-12-03 18:25:06 -08:00
Kurt	d3f7e7bf07	Minor simplifications ... format >= 6 is always true (early return in entry) don't double-flag/check memory presence in OTs from gen5 and below (hist and OT verifier) rename method; I'll probably rework the flow of things for gen6 verification and gen8 verification since the rules are slightly different	2019-12-02 16:36:53 -08:00
Kurt	a844fb5249	Add strong dubwool location ... https://projectpokemon.org/home/forums/topic/55654-new-pokemon-to-fix-on-pkhex/?tab=comments#comment-251010	2019-12-01 00:02:02 -08:00
Matt	7b7a161ac9	Minor fixes (#2547) ... Fix Sinistea/Polteageist Form names (as per Strategy Guide) Add Eternamax menu sprite	2019-11-30 13:19:22 -08:00
Kurt	f3ecff272c	Update HA8 banlist ... Closes #2544 Closes #2543	2019-11-29 22:33:11 -08:00
Kurt	2ee6fbb7e9	Only flag bred stuff for no-breed ... Closes #2542	2019-11-29 18:54:07 -08:00
Matt	bc9be36123	Add more Gen 8 static encounter locations (#2540) ... Also add West Sea Shellos/Gastrodon to transfer form banlist	2019-11-29 10:03:35 -08:00
Matt	faf936bceb	Update Gen 8 transfer banlist (#2536) ... Alolan Forms can't be obtained yet, same with Hoenn Zigzagoon/Linoone and Unova Stunfisk.	2019-11-28 18:42:22 -08:00
Kurt	f25b36a306	Minor tweaks ... Remove unused stuff add some comments/xmldoc Move Trainer1 to classes that use it	2019-11-28 14:00:55 -08:00
Kurt	ea2f7f338b	Add weather indication to detailed parse output	2019-11-28 12:56:26 -08:00
Kurt	2c0b85ef21	Add form banlist for g8 ... Weezing-0 has no de-evolution path (nothing evolves to it) Just ban these forms existence in SW/SH	2019-11-28 12:09:55 -08:00
Kurt	f0cf28fbad	Flag bred transfer mons ... #2416	2019-11-28 11:51:23 -08:00
Kurt	e8bdc34a18	Tweak gift generator ... Yield ranger manaphy gift as possible (encmoveset generator) Move ranger manaphy equals check to PGT	2019-11-28 10:42:24 -08:00
Archit Date	897b97ceed	comment typo fix (#2535) ... lul	2019-11-28 10:35:18 -08:00
Kurt	7a51e48747	Add wc8 star/square pid types	2019-11-28 09:46:48 -08:00
Kurt	f5307c142b	Use format sensitive move knowable check ... Closes #2534	2019-11-27 23:07:41 -08:00
Kurt	5a1bffb2ba	Split wild encounters for crossover & weather ... Certain Mark values (ribbon) are only obtainable if the encounter was obtained in some weather (I really hope there's no crossover cases for this), and non-symbol encounters can't wander to another zone. I wonder if you can wander from one zone with one exclusive weather, to another zone, and get an 'unobtainable' mark (with the new zone's weather) on the crossover mon's weather. yikes lmao	2019-11-27 22:46:14 -08:00
Kurt	a0ee7a3e51	Add route 2 lapras location ... ty Waves (discord) https://www.serebii.net/pokearth/galar/route2.shtml#xy-lake	2019-11-27 19:44:14 -08:00
Kurt	5761f03f94	Add OT memory details for gen6 ingame trades	2019-11-27 19:30:28 -08:00
Kurt	907f036956	Disregard OT memory values on gen7 origin	2019-11-27 16:01:12 -08:00
Kurt	c4951f1650	Add strong piloswine location ... ty wowjinxy	2019-11-27 11:34:20 -08:00
Kurt	4cd358833a	Add corvisquire static enc location ... https://projectpokemon.org/home/forums/topic/55611-corvisquire-route-3/ thanks ThePunish3D!	2019-11-26 18:20:52 -08:00
Kurt	b95ab53e92	Finalize unreleased item banlist	2019-11-26 17:16:57 -08:00
Kurt	5b932c961f	Merge branch 'master' of https://github.com/kwsch/PKHeX	2019-11-26 16:58:44 -08:00
Kurt	08e293dadc	Add SimpleTrainerInfo constructor ... zeroes out console region data if not present in game	2019-11-26 16:55:28 -08:00
Chris	f23874b1ae	Safari/Sports Ball is also not released	2019-11-27 01:55:15 +01:00
Kurt	4182b22686	Update Unreleased Items(SwSh) (#2529) ... https://www.serebii.net/swordshield/items.shtml only Pixie Plate & Normal Gem are in the Game yet.	2019-11-26 16:13:30 -08:00
Kurt	5883acd5b9	Fix florges/floette evo tree ... No personal stats for those evos different from main species	2019-11-26 16:12:35 -08:00
Chris	ba43631d40	Update Unreleased Items(SwSh) ... https://www.serebii.net/swordshield/items.shtml only Pixie Plate & Normal Gem are in the Game yet.	2019-11-27 01:08:31 +01:00
Kurt	9cb56be3dd	Add bronzong/galvantula strong loc ... previous Bronzong location is likely a crossover case ty wowjinxy	2019-11-26 11:39:17 -08:00
Kurt	15ef6555a8	Add WC8 memory & fix fallthrough ... ty @sora10pls	2019-11-26 11:22:01 -08:00
Kurt	ef425af835	Add memory / console region checks for pb7/pk8 ... yeah your initial hacks were hacks It appears there's a bug (in the game) for link trade memories -- applied to the OT memory instead of HT memory?? Fun!	2019-11-26 11:01:09 -08:00
Kurt	7960f2d748	Don't set console region data for pb7/pk8+	2019-11-26 10:46:32 -08:00
Kurt	445fdee2ba	Add shared memory interface (encounter)	2019-11-26 10:46:16 -08:00
Kurt	0f96b3c4d5	Add Species specific arg memories	2019-11-26 10:44:36 -08:00
Kurt	e8f5ac8a00	Minor clean	2019-11-25 22:51:07 -08:00
Kurt	7a10311207	Unban scrafty/scraggy HA ... new EncounterStatic8N(Nest87,3,4,4) { Species = 560, Ability = A4 }, // Scrafty	2019-11-25 20:31:42 -08:00
Kurt	c416fc5fa1	Update handling for invalid genNumber ... all edge case movepool stuff is IGeneration; we're fine just using IGeneration.Generation	2019-11-25 18:33:38 -08:00
Kurt	5dde0f5c43	Merge Error flag into Parsed ... Simplify some logic with ??=	2019-11-25 18:32:50 -08:00
Kurt	c5593470df	Add 2 more static enc locations, swap yield order ... Private report with 3 specimens, 2 undocumented met locations The other was a Gigantamax which matched another static encounter, resulting in a partial match being accepted (the real match came after, but was never iterated to). Rather than adding deferrals for Enc8, do nest stuff first since it's the most restrictive In the past we didn't really have duplicate static encounters with slightly different permissions. Thanks @ReignOfComputer & {reporting user}!	2019-11-25 17:57:25 -08:00
Kurt	b37a0c5bfe	Add downleveled regular raid movepool verification ... #2416 Not having enough badges pulls the level of the captured mon down need more info if the other raid types behave similarly	2019-11-25 08:52:03 -08:00
Kurt	5dec94d456	Handle banned form eggs with more flexibility ... Closes #2519 better to not generate the encounter as opposed to flagging it after generation	2019-11-25 00:16:16 -08:00
Kurt	6ca8571759	Add stomp min level for Steenee ... Closes #2520	2019-11-24 23:50:10 -08:00
Kurt	b588af8300	Ban meowstic-1 hidden ability ... Closes #2521	2019-11-24 23:14:42 -08:00
Kurt	0dcd9b744a	Include swsh held items to valid items list ... Closes #2518	2019-11-24 22:34:51 -08:00
Kurt	c446ff5b51	Fix non-galar egg moves passing ... Closes #2516	2019-11-24 18:18:26 -08:00
Kurt	e1e7bf321b	Add South Lake Miloch for den 42 ... #2416	2019-11-24 11:07:31 -08:00
Kurt	aeb3ee6cec	Fix shedinja evo chain logic ... #2416	2019-11-24 09:49:54 -08:00
Kurt	64d94903ff	Change fixed ability ... 0=abil1 1=abil2 2=abil4 3=abil1/2 4=any probably same as WC8 etc doesn't have any impact as there's other encounters that allow Hidden	2019-11-24 06:26:33 -08:00
Kurt	113d16fa5d	Fix darumaka->darmanitan blizzard move ... #2416 Looks like the only issues left are: Shedinja Crossover/Bleed locations Static Encounter locations	2019-11-23 22:48:02 -08:00
Kurt	96f6db0e38	Add recognition for distribution raids ... Closes #2457	2019-11-23 22:23:43 -08:00
Kurt	52cd8ae855	Revise HA banlist ... https://www.smogon.com/forums/threads/sword-shield-battle-mechanics-research.3655528/post-8291236	2019-11-23 20:50:56 -08:00
Kurt	09d1d0e799	Add darumaka to galar origin ... lol oops Closes #2508 thanks @iiippppk !	2019-11-23 19:45:18 -08:00
Kurt	5df6565597	Add fast ball ... Closes #2507	2019-11-23 19:12:53 -08:00
Kurt	cccf2a1939	Fix flawless IV count check ... #2506 trapinch	2019-11-23 14:46:09 -08:00
Archit Date	f96eafa682	grab correct evo stage 1 from evocriteria list (#2503) ... EncounterMovesetGenerator was using the de-evolution order in the passed evocriteria list	2019-11-23 09:01:09 -08:00
Kurt	e70a2f40b8	Add den crossover via online share ... fix ability deferral for non-HA (eg. A4 mr rime encounter)	2019-11-23 08:27:50 -08:00
Kurt	b29fc5216e	Add shared moveset transfer ... Closes #2501 for now	2019-11-23 07:27:06 -08:00
Kurt	c27b1d0bb8	Revise hidden ability banlist ... Might need to remove entries once the Distribution raid data is added.	2019-11-23 07:12:50 -08:00
Chris	03ee264d0c	Add Vanilluxe Multiple Encounters (#2499) ... * Add Vanilluxe Multiple Encounters Vanilluxe spawns also on any Lake if its snowing	2019-11-22 21:32:39 -08:00
Kurt	9e4c408ac7	Fix galar form egg move fetch ... Closes #2500	2019-11-22 21:32:05 -08:00
Kurt	26b21d8603	Rewrite reverse evo lineage rectifier ... Closes #2479 Fixes Silvally in swsh not having evo reversal content for each form	2019-11-22 21:04:34 -08:00
Kurt	d25f388bf5	Fix dexnav relearn checks ... Closes #2491 Thanks @NinFanBoyFTW !	2019-11-22 19:59:40 -08:00
Chris	97f156364d	Update Multiple Encounters for Lakes (#2498) ... happens also for: Drifloon, Wingull, Goldeen, Frillish, Magikarp but theese aren't listed, feel free to add new encounters.	2019-11-22 18:26:47 -08:00
Chris	e90d2fbc29	Also Seaking have multiple Locations (#2495) ... ^	2019-11-22 08:05:46 -08:00
Chris	4c9815c17e	Add Multiple Gyarados Spawns (#2493) ... Gyarados Spawns in Area 1: North/East/South/West Lake Miloch, Area 2: the Lake of Outrage (in a Wild Area)	2019-11-22 08:04:17 -08:00
Chris	8bdc110e2b	Added Multiple Lapras Spawns (#2492) ... Lapras Spawns in Area 1: North/East/South/West Lake Miloch, Area 2: the Lake of Outrage (in a Wild Area)	2019-11-22 08:03:16 -08:00
Kurt	4b3d85d5e6	Add multi-location strong encounter handling ... #2484 OH BOY REUSED INDEXES smart to save space, but a small pain for legality feels pretty bad breaking up abstractions for every minor difference in verification...	2019-11-21 21:44:41 -08:00
Kurt	5235c9b252	Revert "Add lapras encounter location?" ... This reverts commit e4e516d1c2.	2019-11-21 21:14:45 -08:00
Kurt	e4e516d1c2	Add lapras encounter location? ... #2484 The other lapras encounter was found by @sora10pls and was lv56; we're assuming this other lapras is the encounter (for now).	2019-11-21 20:59:24 -08:00
Kurt	4c8dd0cb3a	Defer rather than reject ... #2490	2019-11-21 20:05:20 -08:00
Archit Date	e93bc5e67c	Misc Nest Fixes (#2490) ... * fix A3 and A4 ability values private > internal so it can be used in Encounter Nest matching * reject ability number 4 if ability is from A3	2019-11-21 20:03:02 -08:00
Kurt	b9e32c67a0	Add encounter static deferral oop ... We've already been doing something similar for the deferral check; just merge the logic into the base object Closes #2489	2019-11-21 20:02:08 -08:00
Archit Date	93028b3439	modify nest locations based on serebii (#2483) ... https://serebii.net/swordshield/maxraidbattles.shtml	2019-11-20 23:02:54 -08:00
Kurt	f6c6639078	Add online den location ... There's still the down-leveled issue with high level moves. fun.	2019-11-20 23:02:31 -08:00
Kurt	f30a14ebf0	Disallow dynamax level on story legends ... ty @sora10pls	2019-11-20 18:15:21 -08:00
Kurt	473afb8377	Initial rough draft of nest location matching ... nest data doesn't match what's expected, but recognition is ready for tweaks	2019-11-20 17:07:55 -08:00
Kurt	c6f515c755	Use more performat array join	2019-11-20 17:07:55 -08:00
ReignOfComputer	f19193c66f	Static Locations Update (#2475) ... * Static Locations Update - Removed version lock on Motostoke Stadium Vulpix (may want to investigate Growlithe) - Wild Area Updates - Other Static Updates * Squeeze in 2 more Statics * Rhydon Static Location Last one I promise.	2019-11-20 11:38:25 -08:00
Kurt	8294d77464	Add Carkol static loc	2019-11-19 20:24:12 -08:00
Kurt	2c5a7cd5de	Add linoone strong loc	2019-11-19 19:41:30 -08:00
Kurt	feef1c1122	Add 2 more strong locations	2019-11-19 19:27:57 -08:00
Chris	7ef4fce89e	Add Eevveelutions Spawns for Lake of Outrage (#2471) ... All Eeveelutions spawns at the Lake of Outrage, based on the weather?	2019-11-19 19:21:41 -08:00
Kurt	18b20e09d2	Add leafeon location	2019-11-19 19:03:39 -08:00
Kurt	e6476e943b	Change Gender to OT Gender ... ty @sora10pls for confirmation	2019-11-19 18:55:03 -08:00
Kurt	0f4598ff66	Update some comparisons	2019-11-19 18:02:57 -08:00
Kurt	85fa6e0273	Add more strong encounter locations	2019-11-19 17:07:11 -08:00
Matt	ea80718919	Unban GO Shiny Tentacool (#2468) ... * Unban GO Shiny Tentacool * Also unban GO Shiny Meowth	2019-11-19 13:54:29 -08:00
Kurt	fa344208b2	Add crossover location handling ... Closes #2461 by implementing slightly differently Dictionary instead of new[] every area Checks original met location first before attempting the dictionary lookup (missing in pull request) Easy path forward if LGPE crossover is needed Potential issues: Since encounter types aren't marked, shaking trees and fishing encounters are allowed to cross over. Maybe need to have some marking for encounter slots or something...	2019-11-19 08:38:18 -08:00
ReignOfComputer	0230dafe2b	Wild Area Updates from RoC's PC (#2460)	2019-11-19 08:13:53 -08:00
Kurt	a368b81519	Minor clean	2019-11-18 22:48:03 -08:00
ReignOfComputer	0ef6f024d6	Wild Area Updates from #2416 (#2459) ... https://github.com/kwsch/PKHeX/issues/2416	2019-11-18 22:21:13 -08:00
Kurt	f88388cb70	Add Form (AltForm) to IEncounterable interface ... All of the encounterable templates have Form anyway; funny that I was consistent naming them all differently than pkm.AltForm :) Closes #2452	2019-11-18 22:20:55 -08:00
ReignOfComputer	6d95fa5884	Wild Area Updates from RoC's PC (#2456)	2019-11-18 20:26:38 -08:00
Kurt	1df90199e3	Rework GetBaseSpecies to return EvoCriteria ... #2452	2019-11-18 20:26:11 -08:00
Kurt	5a4c026dc7	Restrict egg related species fetch to EvoCriteria ... #2452	2019-11-18 20:10:39 -08:00
Kurt	535397cf5e	Consolidate egg ctor with args ... Form is an absolute requirement for the encounter data. #2452	2019-11-18 20:01:48 -08:00
Kurt	2b76fe148d	Fix property reference for Darmanitan-G ... lul Closes #2453	2019-11-18 19:29:05 -08:00
Kurt	5e1937d8b4	Fix fossil8 to unbreedable ... Not needed in the HA banlist table since it can't breed. Closes #2451 thanks @iiippppk ! (undiscovered egg group)	2019-11-18 19:26:01 -08:00
Kurt	1ea3976805	Split up Encounters8 ... Nests in their own file Encounter types in their own files	2019-11-18 19:23:01 -08:00
Kurt	e9fdc721df	Add chewtle	2019-11-18 18:42:10 -08:00
Kurt	3aa3a29264	Add 3 more static enc locations	2019-11-17 22:04:52 -08:00
Kurt	38abafab99	Catch some evolution edge cases	2019-11-17 22:04:41 -08:00
Kurt	47be249331	Rework evo tree chaining to track form ... Now recognizes & reverses form-changing evolution chains like Sirfetch'd basically the whole process is to build the tree but point in the opposite direction (for de-evolution paths)	2019-11-17 21:45:53 -08:00
Kurt	4bcf60746b	Add egg move sharing checks ... Was referencing wild caught mons that are given a single egg move; this logic handles shared egg moves too via daycare. Probably need to rework SplitBreed into a dictionary; this might not catch Mime/etc split breeds if they have different tables.	2019-11-17 17:14:21 -08:00
Kurt	c2dce518c2	Invert sign of fake met locations ... Suggested encounters check < 0	2019-11-17 16:03:53 -08:00
Kurt	d4c5919e5e	Revisions for some static encounters ... Identified a few more	2019-11-17 15:50:41 -08:00
Kurt	13adc38ee8	Add elemental tutors ... Closes #2443 Capture some array references to avoid re-fetching array -- array reference is readonly so it probably won't matter	2019-11-17 11:13:57 -08:00
Kurt	ea822e9fcd	Add raid flawless IV check (speculation)	2019-11-17 09:55:27 -08:00
Kurt	86a20afe8e	Minor style fix	2019-11-17 09:47:10 -08:00
Kurt	23c04cf809	Add beast ball to wild balls	2019-11-16 22:22:21 -08:00
Kurt	f20f6cd4bb	Only check east asian script chars on gen7&below ... Closes #2437 thanks @iiippppk !	2019-11-16 17:47:26 -08:00
Kurt	31c09c52e8	Add initial nieve check for ball inheritance ... Closes #2438	2019-11-16 17:45:51 -08:00
Kurt	31f9a5f4d8	Correctly locate pk8 foreign transfer checks	2019-11-16 16:05:45 -08:00
Kurt	524ceb7bf9	Fix dracozolt species ID ... heh dunno how that happened	2019-11-16 15:02:32 -08:00
Kurt	dbda5e6934	Update comments ... align all, add location text for motostoke 3(4) encounters	2019-11-16 14:37:00 -08:00
Kurt	e5bd026eec	Add static crustle location ... ty @ReignOfComputer	2019-11-16 12:46:24 -08:00