Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2025-02-17 05:48:44 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add memory / console region checks for pb7/pk8

Browse source 
yeah your initial hacks were hacks

It appears there's a bug (in the game) for link trade memories --
applied to the OT memory instead of HT memory?? Fun!
This commit is contained in:
Kurt 2019-11-26 11:01:09 -08:00
parent 7960f2d748
commit ef425af835
3 changed files with 56 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
PKHeX.Core/Legality/Analysis.cs
View file

@ -309,18 +309,16 @@ namespace PKHeX.Core
if (pkm.Format < 6)
return;
if (pkm.Format < 8 && !(pkm is PB7))
{
Memory.Verify(this);
ConsoleRegion.Verify(this);
Memory.Verify(this);
if (pkm is ISuperTrain)
Medal.Verify(this);
ConsoleRegion.Verify(this);
}
if (pkm.Format >= 7)
{
HyperTraining.Verify(this);
Misc.VerifyVersionEvolution(this);
}
if (pkm.Format < 7)
return;
HyperTraining.Verify(this);
Misc.VerifyVersionEvolution(this);
}
private string GetLegalityReport()

17
PKHeX.Core/Legality/Verifiers/ConsoleRegionVerifier.cs
View file

@ -11,19 +11,32 @@ namespace PKHeX.Core
public override void Verify(LegalityAnalysis data)
{
var result = VerifyConsoleRegion(data.pkm);
var result = VerifyConsoleRegion(data.pkm, data.Info.Generation);
data.AddLine(result);
}
private CheckResult VerifyConsoleRegion(PKM pkm)
private CheckResult VerifyConsoleRegion(PKM pkm, int gen)
{
int consoleRegion = pkm.ConsoleRegion;
if (consoleRegion >= 7)
return GetInvalid(LGeoHardwareRange);
if (gen >= 8 || pkm.GG)
return VerifyNoDataPresent(pkm, consoleRegion);
return Verify3DSDataPresent(pkm, consoleRegion);
}
private CheckResult Verify3DSDataPresent(PKM pkm, int consoleRegion)
{
if (!Legal.IsConsoleRegionCountryValid(consoleRegion, pkm.Country))
return GetInvalid(LGeoHardwareInvalid);
return GetValid(LGeoHardwareValid);
}
private CheckResult VerifyNoDataPresent(PKM pkm, int consoleRegion)
{
if (consoleRegion != 0 || pkm.Country != 0 || pkm.Region != 0)
return GetInvalid(LGeoHardwareInvalid);
return GetValid(LGeoHardwareValid);
}
}

56
PKHeX.Core/Legality/Verifiers/MemoryVerifier.cs
View file

@ -3,6 +3,7 @@ using System.Collections.Generic;
using System.Linq;
using static PKHeX.Core.LegalityCheckStrings;
using static PKHeX.Core.Encounters6;
using static PKHeX.Core.Encounters8;
namespace PKHeX.Core
{
@ -221,19 +222,31 @@ namespace PKHeX.Core
return GetInvalid(string.Format(LMemoryArgBadMove, memory.Handler));
// {0} was able to remember {2} at {1}'s instruction. {4} that {3}.
case 49 when memory.Variable == 0 || !Legal.GetCanRelearnMove(pkm, memory.Variable, 6):
case 49 when memory.Variable == 0 && !GetIsMoveLearnable(pkm, handler, memory.Variable):
return GetInvalid(string.Format(LMemoryArgBadMove, memory.Handler));
}
if (!Memories.CanHaveIntensity(memory.MemoryID, memory.Intensity))
return GetInvalid(string.Format(LMemoryIndexIntensityMin, memory.Handler, Memories.GetMinimumIntensity(memory.MemoryID)));
{
if (pkm.GenNumber < 8) // todo: memory intensity checks for gen8
return GetInvalid(string.Format(LMemoryIndexIntensityMin, memory.Handler, Memories.GetMinimumIntensity(memory.MemoryID)));
}
if (memory.MemoryID != 4 && !Memories.CanHaveFeeling(memory.MemoryID, memory.Feeling))
return GetInvalid(string.Format(LMemoryFeelInvalid, memory.Handler));
{
if (pkm.GenNumber < 8) // todo: memory feeling checks for gen8
return GetInvalid(string.Format(LMemoryFeelInvalid, memory.Handler));
}
return GetValid(string.Format(LMemoryF_0_Valid, memory.Handler));
}
private static bool GetIsMoveLearnable(PKM pkm, int handler, int move)
{
int gen = handler == 0 ? pkm.GenNumber : pkm.Format >= 8 ? 8 : 6;
return Legal.GetCanRelearnMove(pkm, move, gen);
}
private void VerifyOTMemoryIs(LegalityAnalysis data, int m, int i, int t, int f)
{
var pkm = data.pkm;
@ -250,9 +263,6 @@ namespace PKHeX.Core
private void VerifyOTMemory(LegalityAnalysis data)
{
var pkm = data.pkm;
if (pkm.Format < 6)
return;
var Info = data.Info;
if (Info.Generation < 6 || pkm.IsEgg)
{
@ -262,28 +272,16 @@ namespace PKHeX.Core
switch (data.EncounterMatch)
{
case EncounterTrade _:
switch (Info.Generation)
{
case 6:
break; // Undocumented, uncommon, and insignificant -- don't bother.
case 7:
VerifyOTMemoryIs(data, 1, 3, 40, 5);
break;
}
return;
case WC6 g when !g.IsEgg && g.OTGender != 3:
VerifyOTMemoryIs(data, g.OT_Memory, g.OT_Intensity, g.OT_TextVar, g.OT_Feeling);
return;
case WC7 g when !g.IsEgg && g.OTGender != 3:
VerifyOTMemoryIs(data, g.OT_Memory, g.OT_Intensity, g.OT_TextVar, g.OT_Feeling);
return;
}
if (Info.Generation >= 7)
{
VerifyOTMemoryIs(data, 0, 0, 0, 0); // empty
return;
case IMemoryOT t:
VerifyOTMemoryIs(data, t.OT_Memory, t.OT_Intensity, t.OT_TextVar, t.OT_Feeling);
return;
}
switch (pkm.OT_Memory)
@ -293,7 +291,7 @@ namespace PKHeX.Core
data.AddLine(Severity.Invalid, string.Format(LMemoryArgBadHatch, L_XOT), CheckIdentifier.Memory);
break;
case 4: // {0} became {1}’s friend when it arrived via Link Trade at... {2}. {4} that {3}.
case 4 when pkm.Gen6: // {0} became {1}’s friend when it arrived via Link Trade at... {2}. {4} that {3}.
data.AddLine(Severity.Invalid, string.Format(LMemoryArgBadOTEgg, L_XOT), CheckIdentifier.Memory);
return;
@ -330,7 +328,7 @@ namespace PKHeX.Core
return;
var Info = data.Info;
if (pkm.Format >= 7)
if (pkm.Format == 7)
{
/*
* Bank Transfer adds in the Link Trade Memory.
@ -423,6 +421,18 @@ namespace PKHeX.Core
return GetCanBeCaptured(species, SlotsO, StaticO);
}
break;
case 8:
{
switch (version)
{
case GameVersion.SW:
return GetCanBeCaptured(species, SlotsSW, StaticSW);
case GameVersion.SH:
return GetCanBeCaptured(species, SlotsSH, StaticSH);
}
break;
}
}
return false;
}