PKHeX/PKHeX.Core/Legality
Kurt 6ee7a8724b
Offload EncounterSlot loading logic to reduce complexity (#2980)
* Rework gen1 slot loading

Slot templates are precomputed from ROM data and just loaded straight in, with tight coupling to the encounter area (grouped by slot types).

* Revise fuzzy met check for underleveled wild evos

Example: Level 23 poliwhirl in RBY as a level 50 poliwhirl, will assume the chain is 25-50 for poliwhirl (as poliwag evolves at 25). Instead of revising the origin chain, just ignore the evo min level in the comparison.

Previous commit fixed it for gen1.

* Rework gen2-4 slot loading

Gen4 not finished, Type Encounter data and some edge encounters not recognizing yet...

* Add feebas slots for old/good encounters

* Begin moving properties

Great news! Gen5-7 need to be de-dumbed like Gen1-4.

Then I can remove the bang (!) on the Area accessor and ensure that it's never null!

* Split off XD pokespot slot encounter table type

* Set area in constructor

* Deduplicate g3 roaming encounters

* Deduplicate xd encounter locations (rebattle)

Only difference is met location; no need to create 500 extra encounter objects. A simple contains check is ok (rarely in gen3 format).

* Make all slots have a readonly reference to their parent area

* Minor clean

* Remove "Safari" slot type flag

Can be determined via other means (generation-location), allows us to reduce the size of SlotType member to a byte

Output of slot binaries didn't preserve the Safari flag anyway.

* Update SlotType.cs

* Handle type encounters correctly

* Merge safari area into regular xy area

* Merge dexnav accessor logic

* fix some logic so that tests pass again

rearrange g5 dw init to be done outside of static constructor (initializer instead)
PIDGenerator: friend safari slots now generate with required flawless IV count

* Add cianwood tentacool gift encounter

* Remove unnecessary abstractions

Fake area just returned a slot; since Slots have a non-null reference to the area, we can just return the slot and use the API to grab a list of possible slots for the chain.

Increase restrictiveness of location/type get-set operations

* Minor tweaks, pass parameters

DexNav observed state isn't necessary to use, only need to see if it's possible to dexnav. Now that we have metadata for slots, we can.

* Remove unused legality tables
2020-08-30 10:23:22 -07:00
..
Areas Offload EncounterSlot loading logic to reduce complexity (#2980) 2020-08-30 10:23:22 -07:00
Encounters Offload EncounterSlot loading logic to reduce complexity (#2980) 2020-08-30 10:23:22 -07:00
Enums Offload EncounterSlot loading logic to reduce complexity (#2980) 2020-08-30 10:23:22 -07:00
Evolutions Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974) 2020-08-21 16:35:49 -07:00
Learnset PKHeX.Core Nullable cleanup (#2401) 2019-10-16 18:47:31 -07:00
Moves Split GO from "GG" gameversion 2020-08-06 18:24:20 -07:00
Restrictions Allow gen1 moves on gen2 met data pk2's 2020-08-29 23:47:03 -07:00
RNG Offload EncounterSlot loading logic to reduce complexity (#2980) 2020-08-30 10:23:22 -07:00
Structures Split GO from "GG" gameversion 2020-08-06 18:24:20 -07:00
Tables Offload EncounterSlot loading logic to reduce complexity (#2980) 2020-08-30 10:23:22 -07:00
Verifiers Offload EncounterSlot loading logic to reduce complexity (#2980) 2020-08-30 10:23:22 -07:00
Analysis.cs Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974) 2020-08-21 16:35:49 -07:00
BinLinker.cs Strip out some unnecessary logic 2020-04-16 12:58:48 -07:00
BulkAnalysis.cs Remove some reliance on GenNumber 2020-05-31 12:12:48 -07:00
BulkGenerator.cs Minor clean 2020-03-20 13:33:15 -07:00
Checks.cs Verify Contest stats on gen5 origin 2020-05-09 20:47:32 -07:00
Core.cs Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974) 2020-08-21 16:35:49 -07:00
EvoBase.cs Minor clean 2020-06-21 19:46:06 -05:00
LegalityCheckStrings.cs Fix move record flag check overflow to tracker 2020-08-11 19:42:40 -07:00
MoveList.cs Minor tweaks 2020-07-19 18:30:46 -05:00
MoveListSuggest.cs Extract move suggest logic, add battleversion clamp 2020-06-27 13:06:28 -05:00