Kurt
3fd21db51e
Style & function extracting
2018-07-29 16:39:15 -07:00
Kurt
9551d4e707
Relocate logic to core
...
probable/possible lgpe uses similar dex stuff, so best I totally
understand it (assuming quirks will be present)
2018-07-26 18:01:16 -07:00
ajtudela
1c05001fb7
Update spanish translations ( #2077 )
...
* Update spanish translations
2018-07-26 07:06:14 -07:00
Kurt
91f39d74db
Add box scrolling
...
https://projectpokemon.org/home/forums/topic/46370-bug-cant-scroll-between-boxes/
2018-07-25 19:29:41 -07:00
Kurt
8cb82560f6
sync unsaved
...
this closes #2068 , not the prior commit
2018-07-23 19:27:00 -07:00
Kurt
d685fec327
Sanity check listbox formes
...
SM does not have dex flags for totem forms, but pkhex now provides them
in the form dropdown
Closes #2068 thanks @iiippppk !
2018-07-23 19:15:54 -07:00
Kurt
0c5c9bc33c
Misc clean / xmldoc updates
...
remove unused label in QR (use window Font)
escape & -> & for xmldoc proper style
2018-07-21 19:20:11 -07:00
Kurt
1c49b0681d
Extract dex logic
2018-07-21 11:46:38 -07:00
Kurt
c7175fbdb4
Misc reorg
...
bye bye SAVUtil and PKMUtil
2018-07-20 21:32:33 -07:00
Kurt
99c790a4b0
Update File name/path/folder fields
...
original file path is not saved with the two listed properties, add
FileFolder and relcoate existing FilePath functions to that field
move some GetVariantSAV usages to the string method instead of byte[]
2018-07-16 21:00:43 -07:00
Kurt
f51ac7d1f3
Update translations
...
Internal repositioning to match source
(auto generated changes)
2018-07-16 15:12:40 -07:00
Kurt
4d73fa70d8
Simplify binding to ComboItem logic
...
could probably look into better binding but meh
2018-07-14 16:00:28 -07:00
Kurt
94ad351979
Update translation files
...
new release soon
-opower6 now fully editable
-box export to showdownset added
2018-07-08 18:25:43 -07:00
Kurt
4dcac24f34
Add roamer3 active/level editing
2018-07-07 21:31:07 -07:00
Kurt
816c40429b
Reuse language data source for trainer editors
...
provides nice descriptions rather than 3 character codes
2018-07-07 17:02:17 -07:00
Kurt
d4c1093dd9
Add RS badge flags
...
make logic generic
2018-07-07 17:01:47 -07:00
Kurt
990eb73f8a
Misc simplifications
...
recordmax is simplified
2018-07-07 15:38:11 -07:00
Kurt
e46aed4b0b
Relocate bean logic to core
2018-07-07 15:37:47 -07:00
Kurt
ca16f08e36
Use new trainerstat control
...
misc cleanup/reorg inside control
2018-07-07 12:22:30 -07:00
Kurt
e915cd170b
Extract trainer stat to interface / usercontrol
2018-07-07 11:48:03 -07:00
Kurt
2e02ec9719
Refactoring
...
Move some logic out of saveditor/subs
2018-07-07 11:20:05 -07:00
Kurt
397de97f3c
Remove excessive references to Util.Rand32()
...
all usages besides fetching a 32bit random value should use rand.next
remove unnecessary do-while loop for calculating random EVs (always
returns 510 in total)
2018-07-04 11:30:43 -07:00
Kurt
9f8edc89bf
Refactoring
...
put some string[] behind IReadOnlyList to prevent any consumer from
modifying it
2018-06-30 09:59:48 -07:00
Kurt
c6765fd26b
Remove ORAS arg
...
...
2018-06-10 14:07:36 -07:00
Kurt
19cb2cda2e
Remove MAX giveRegular for ORAS
...
level 3 is the legitimate max
2018-06-10 12:27:53 -07:00
Kurt
75f4318335
Split S/MAX from base 1-3 levels
...
ORAS can unlock MAX & Full Recovery flags, add special handling for that
2018-06-10 11:28:20 -07:00
Kurt
26f45d44d0
Rework OPower editor
...
https://projectpokemon.org/home/forums/topic/45683-pkhex-made-odd-number-of-zygarde-cells-usm/?do=findComment&comment=232476
Thanks @sora10pls for documenting what each flag does
2018-06-09 21:04:34 -07:00
Kurt
7ec7ca312d
Don't increment cell count for usum on giveall
...
show cell total for usum
2018-06-09 10:07:35 -07:00
Kurt
01c36bb3ad
Update control anchoring & form minsize
2018-05-28 16:40:36 -07:00
Kurt
5475da05c3
entree forest updates
...
clamp species list based on savefile
fix form control index set
remove slot from list (avoid duplicates, there's 530 slots and both
games have more than that available).
Closes #1974
2018-05-28 12:49:41 -07:00
Kurt
4b8cb9b8fb
Add entree forest editor & randomizer
...
ezpz
(clear trailing spaces from entree forest comments)
2018-05-28 08:26:52 -07:00
Kurt
2a877bfb9e
Better empty-base handling
...
Closes #1952
2018-05-18 16:01:17 -07:00
Kurt
4139299f00
Iterate to last poketch item
...
i-1 => need to use <=
2018-05-13 20:49:27 -07:00
Kurt
3ee6070b98
Fix poketch write
...
1123c24b0c
had addressed the loading, however, it did not address the saving
update pkx to not create a new array every time IsPKM is called
(possibly a lot)
2018-05-13 20:35:09 -07:00
Kurt
75b16393b1
More simplifications
2018-05-12 19:07:32 -07:00
Kurt
0e6db90de2
more minor tweaks
...
add 2 overloads for encounter generator
more simplifications
2018-05-12 18:11:47 -07:00
Kurt
99005d8fc0
Refactoring
...
more discards & simplifications
2018-05-12 12:28:48 -07:00
Kurt
5a3c8f4147
Remove trailing whitespace
2018-05-12 08:41:29 -07:00
wwwwwwzx
997d41b6db
Fix minlevel of Pangoro/Tyrantrum/Aurorus in gen6 ( #1938 )
...
* Fix minlevel of Pangoro/Tyrantrum/Aurorus in gen6
30: level + dark type in the party
32: level + day
33: level + night
34: level + female
Note Meowstic isn't affected due to another entry of level + male (23)
* Minor text usage fix
* Fix xorPID flipping in TransferEC check
2018-05-12 06:57:11 -07:00
Kurt
f060bab844
Use new trainer ID editing control in SAV_Trainer7
2018-04-28 11:52:48 -07:00
Kurt
e25e3fcc19
update joyful dodrio berry offset
...
bc90a4fc1d/include/global.h (L276)
u32 bestScore;
u16 berriesPicked;
u16 berriesPickedInRow;
2018-04-22 20:11:25 -07:00
Kurt
f6dda90f52
Add icons
...
icons are credit to Dave Gandy's Font Awesome pack on flaticon.com
https://www.flaticon.com/packs/font-awesome
2018-04-21 22:31:11 -07:00
Kurt
7a245278ea
Relocate mg description parse to core
2018-04-21 09:55:27 -07:00
Kurt
cb930fcaab
Show g7 tid on mystery gifts originating from g7+
2018-04-21 09:18:53 -07:00
Kurt
b8a5ccdf7d
Simplify shedinja evo move check
...
Closes #1895 , re-verified with pkm provided in #1805
there's no shedinja gift, always is an evolution
seal some forms to remove virt call in constructor warning
2018-04-10 17:00:28 -07:00
Kurt
335379bd2e
Remove unneeded string
...
#1893
2018-04-08 17:54:09 -07:00
Kurt
1d4e815689
Extract more mesage strings
...
all common strings in forms used by multiple generations
would rather rework the individual generation strings to be unnecessary
with better interaction instead (if possible), as translating hundreds
of limited exposure strings is a drag.
2018-04-06 21:23:09 -07:00
Kurt
9ed2c594f2
Reorder form init
2018-04-02 20:36:13 -07:00
Kurt
3052855a70
Add more trainer records
2018-04-01 11:47:02 -07:00
Kurt
828636856c
Change coin cap to fixed 50000
...
#1746
https://projectpokemon.org/home/forums/topic/44503-bug-report-gen-4-coin-counts/
max is 50000
https://bulbapedia.bulbagarden.net/wiki/Coin_Case
The Coin Case can hold up to 9,999 coins in Generations I, II, and III,
and up to 50,000 coins in Generation IV.
2018-03-24 17:29:48 -07:00
Kurt
d65d9e0b79
Add missing =
...
lul oops
2018-03-16 17:57:24 -07:00
Kurt
d1a789eeab
Fix some pokedex4 behavior
...
https://projectpokemon.org/home/forums/topic/44347-gen-4-pokédex-forms-incorrectly-readwritten/
2018-03-16 17:54:47 -07:00
Kurt
24982fe8c5
Misc simplifications
2018-02-28 21:05:50 -08:00
Kurt
b75313cd87
Sync unsaved changes
...
closes #1840
2018-02-16 17:24:07 -08:00
Kurt
0a0b944de1
Use explicit generation param for forme fetch
...
closes #1837
2018-02-16 16:38:07 -08:00
Kurt
d706d825a9
Handle legal pichu form values
...
Closes #1828 , thanks @SpiredMoth !
slightly optimize batrev key init
fix exception for pkm loading switching between gen3->4 saves
2018-02-10 17:43:00 -08:00
Evan Dixon
392f01cb3e
Fix build error ( #1816 )
...
IEnumerable doesn't support LINQ methods, only the generic variant does. So this commit changes SAV_GameSelect's parameter to a generic IEnumerable of the only type being passed into it. I didn't realize it until afterward, but this is 100% the way it should have been because the databinding members expect ComboItems.
2018-02-05 12:12:42 -08:00
Pete Rolph
32c650c053
Fix a crash bug when loading Gen 3 saves on mono ( #1815 )
2018-02-05 07:48:47 -08:00
Kurt
5458b94e50
Resize coin entry
...
change 9999 to 65535 for dppt, max gets set on load anyway but just do
it for layout visualization
2018-01-27 17:50:59 -08:00
Kurt
b16a2f9ad2
Add box rearranging
...
enables the left/right arrows on each box to allow switching with the
adjacent box
2018-01-23 22:37:55 -08:00
Kurt
713e9ea209
Compress box padding
2018-01-23 17:18:37 -08:00
Kurt
18421c66a9
Set box view owner
...
shifting focus to another app and back will cause the parent form to be
brought back to the top as well
2018-01-22 22:39:12 -08:00
Kurt
d65393c6f6
Minor behavior tweaks (preference)
...
fix initial box width to 4 with scrollbar, remove always-on-top for main
window
2018-01-22 21:58:53 -08:00
Kurt
f073585592
Add all-boxes viewer
...
removed ability to have multiple single box popups
double click the Box tab when holding shift to bring it up
resize to preferences: https://i.imgur.com/XB2978R.png
2018-01-22 21:38:42 -08:00
Kurt
0ee36a655a
Simplify bitmap generation
...
stride is bpp*width + padding bytes; 0x20 worked for the old code since
8*4=0x20 (width of tile).
2018-01-21 17:22:31 -08:00
Kurt
c015c5a337
Shift super training record IDs by 2
...
closes #1764 and fix odd behavior by adding an editing flag
2018-01-18 14:01:58 -08:00
Kurt
06733d6e34
Refactoring
...
Split up c-gear skin bitmap, move generic handling to core
2018-01-13 21:31:02 -08:00
Kurt
4fb3c22b1c
Remove usages of System.Drawing.Color
...
Eventually need to remove usages of bitmap
2018-01-13 19:09:43 -08:00
Kurt
6caefef181
Add cgb->psk & misc clarifications
...
Closes #1699
tested on black2 & white, skin isn't corrupt on game boot and appears
correctly
still don't like setpixel/System.Drawing reliance (maybe split logic to
CGearSkin & CGearSkinVisualizer) for PKHeX.Core compat
2018-01-13 16:32:57 -08:00
Kurt
4f489a720f
Refactoring
...
move logic back to cgearbackground, initialize the bg regardless of
psk/cgb input format
cache background data to return psk (potentially unintended side effects
if importing bw psk to b2w2, will have to fix cgb->psk first then undo
this tempfix)
#1699
2018-01-09 23:30:44 -08:00
Kurt
f332e41869
misc updates
...
#1699
generally pertaining to detecting a de-obfuscated input (cgb) vs native
(psk)
still issues with saving data (deobf->native)
2018-01-09 21:47:04 -08:00
Kurt
84a755a8c9
minor simplifications
...
#1699
2018-01-08 22:40:34 -08:00
Kurt
d187370671
fix checksum/footer set
...
#1699
checksum in the +0x100 was missing the +SAV.CGearDataOffset
add a few more modifications for better parity
still not 100% fixed
2018-01-08 22:40:34 -08:00
Kurt
26015b44bc
Add max cap difference for dppt
...
#1746
2018-01-06 14:12:28 -08:00
Kurt
218c20d804
Add sav4 coin edits to misc4
...
closes #1746
2018-01-06 14:02:55 -08:00
Kurt
fa90ae21df
Fix variable reference
...
#1731
2017-12-29 18:30:13 -08:00
Kurt
45eee8575a
Only promt roto-OT if OT is changed
...
reduces nag
closes #1731
2017-12-29 10:00:32 -08:00
Kurt
61b65198f2
Allow box name editing on gen2
2017-12-27 15:52:29 -08:00
Kurt
9457db9059
Fix mystery gift qr export text
...
closes #1720
2017-12-21 09:49:40 -08:00
Kurt
9429bc6961
Fix showdown import on gen3
...
https://projectpokemon.org/home/forums/topic/43126-problems-with-importing-rse-showdown-files-from-clipboard-in-pkhex/
Sceptile @ Leftovers
EVs: 4 Def / 252 SpA / 252 Spe
Timid Nature
- Leaf Blade
- Leech Seed
- Substitute
- Hidden Power Ice
also fix apricorn form title
2017-12-19 15:33:23 -08:00
Kurt
9263856845
Add apricorn pouch editing
2017-12-18 09:36:53 -08:00
Kurt
dd21f9375f
Misc updates
...
Disallow sandygast on US
Add 2 more records
thanks @feralfalcon
Closes #1698
2017-12-08 08:54:00 -08:00
Kurt
eff8855729
Allow throw type changes to be saved
...
move SM/USUM branch inside the method
closes #1695
2017-12-05 07:26:55 -08:00
Kurt
3d7b2a2b29
Misc tweaks
...
RNG frame mismatch -> fishy (for now)
fix xmldoc copypaste
clean up some resharper warnings
2017-12-04 16:26:26 -08:00
Kurt
a5dbdf91bd
Misc tweaks
...
detect antishiny cxd
remove unused using
don't set caught for seenAll (gen7 dex)
2017-12-04 13:18:28 -08:00
pokecal
0f52f94222
fix MailBoxEditor
...
add Mail5, almost same as Mail4.
2017-12-04 00:00:14 +09:00
Kurt
bdc9d7edce
fix plaza get set
...
closes #1684
2017-12-02 21:37:46 -08:00
Kurt
2d3203fc1a
Refactoring
...
extract out Mail classes to core
2017-12-02 19:12:04 -08:00
pokecal
3e5e49219b
fix MailBoxEditor
...
fix Gen4 Controls
add Mail .Empty for LegalCheck
add Mail SetBlank() for make BlankMail
2017-12-03 11:24:57 +09:00
pokecal
c4ca3aba75
add MailBox Editor
...
I just wanted to fix PK3 heldMailID.
2017-12-03 07:21:07 +09:00
Kurt
fdc52e2c19
Add pkm league starter EC for gen7
...
Closes #1671
2017-11-29 20:04:01 -08:00
Kurt
4a898b0829
Leave empty item slots for gen7+
...
game depends on an existing value to check for if the item is truly
"New"
Closes #1670
Don't clear count=0 slots for gen7+
For sorting, put all the count=0 at the near top (any feedback on how
this actually works?)
2017-11-29 19:47:27 -08:00
Kurt
fa78154df7
Save current facility on save action
...
unsaved combobox choices only are saved when the current index is
changed, need to save when the form is closed (saved).
2017-11-29 08:38:32 -08:00
pokecal
e86b8c670f
add Crystal GS EventFlags
...
have checked with US ver.
2017-11-28 03:35:55 +09:00
Kurt
b30cc933e5
Extract festafacility from gui code
...
move to core project as a structure/class
2017-11-26 08:47:25 -08:00
pokecal
8fe81e8610
update FestaPlazaEditor
...
add BattleAgent Grade30 reward giving
2017-11-26 19:40:18 +09:00
pokecal
2c15170844
update FestaPlazaEditor
...
Add Result of FortuneTeller
and found that the Unknown Value of FestaID(not introduced)
was mistake, contaminate NPCs.
2017-11-25 03:14:55 +09:00
Kurt
5ae408c316
cleanup
...
no functional changes
2017-11-23 09:43:43 -08:00
Kurt
5be401cc73
Merge pull request #1652 from pokecal/master
...
update FestaPlazaEditor
2017-11-22 22:12:29 -08:00
Kurt
b8a5657d5a
misc tweaks
...
pull out transfer locations to const references
add vc2 & crown beast/celebi met location suggesting
add vc2 crystal sensitive detection
add 2 more usum trainer stats (thanks holla!)
2017-11-22 21:45:30 -08:00
pokecal
c3716440e6
update FestaPlazaEditor
...
I think the form contains almost all controls that needed.
2017-11-23 09:49:53 +09:00
Kurt
5fd1e85ce6
Refactoring
...
are the ace trainer genders swapped? removed the iteration loop in favor
of precomputed values
(pattern goes m/f *n?)
add wormhole max dist val
2017-11-21 19:08:31 -08:00
Kurt
15496aa9be
Merge pull request #1642 from pokecal/master
...
add USUM BattleAgency control
2017-11-21 15:38:43 -08:00
Kurt
486e5dc4fe
Move forme check after species check
...
compatibility message of 803-807 dex pkm on S/M needs to say species
first rather than checking forme first
Closes #1643
2017-11-21 15:22:33 -08:00
pokecal
8c08ec1328
add USUM BattleAgency control
...
the NOTE(Giovanni alert) is a little excessive I think,
I will remove it after detect a list of upcoming trainers.
2017-11-22 03:37:40 +09:00
pokecal
7799450193
fix FestaPlazaEdit value
...
When the facility is NOT introduced with visitors
and start FestaPlaza after latest started date,
VisitorFesID become unknown small value.(0/5/7/9/11)
So I stop auto-deletion of visitor data.(and put delete button)
2017-11-21 05:15:32 +09:00
pokecal
16a0abaf62
fix FestaPlazaEdit value
...
found "misc value" as used stats.
exchange left count is also up to 255.
(value 0x83 shows "?", 0x103 shows "3")
fix dye#5(blue) color value
2017-11-20 19:08:41 +09:00
Kurt
6534ef1919
Refactoring
...
Reworks festa facility into a get/set object, simplify some operations
naming convention (PascalCase) for methods/properties
closes #1635
2017-11-19 21:25:46 -08:00
Kurt
70ec1fda5e
cleanup
...
wasn't able to view the designer layout so I removed & readded to
project -- works fine now.
uppercase method names
2017-11-19 16:16:44 -08:00
pokecal
3c85b0ead3
add G7 FestivalPlaza Editor
...
There are too many phrases,
I have no plan to complete all list of phrases.
But I think user can edit phrases of each facility
by using their phrase settings.
2017-11-20 06:50:39 +09:00
Kurt
469587bbbd
Add Rotom OT name
...
"nah lets just store the OT in the save file twice"
add a double check if OT != RotOT to remind the user
2017-11-18 22:26:57 -08:00
Kurt
243f94f02b
Add map coordinate writeback check
...
same as sav7; apparently some areas in gen6 are also truncation prone
2017-11-18 12:22:54 -08:00
Kurt
6394dac19f
Rework mysterygift pkm sprite generation
...
don't bother converting to pkm then generating the sprite off that; use
the overload with int/bool
removes sav/pkm dependency for generating gift descriptions, and
standardizes the names a little. maybe a PKMBase interface would be
useful...
2017-11-18 11:34:23 -08:00
Kurt
f7e20a3c43
Misc tweaks
...
fix roamer3 not setting IVs
fix usum z items rightmost pixel getting chopped off
use Gen* instead of GenNumber for specific cases (faster)
add WasGiftEgg location case for Gen7
remove some unnecessary array allocations
2017-11-17 22:19:23 -08:00
pokecal
95bbbfaf08
fix Sticker location
...
Who is that Pokemon...Steelix!
2017-11-17 11:53:54 +09:00
Kurt
407f3f06d4
Unbreak clearing dex
...
add sound notification that the mass-edit is finished.
refactor slightly for clearer routines
2017-11-16 17:42:11 -08:00
Kurt
bd08d11597
separate out throw learn/unlocked
...
flags and handling is different for USUM, disabled until flags are found
2017-11-15 17:03:44 -08:00
Kurt
aea1577a11
fix mega venusaur female disabled / meowstic
...
<= goes to <
Thanks Holla!
https://projectpokemon.org/home/forums/topic/42332-gen-7-stuff/?tab=comments#comment-222689
2017-11-14 22:56:45 -08:00
Kurt
1c42cbebb7
Hide debug values
...
Closes #1607
wasn't Hall of Fame clear count values, just the 4 bytes prior to the
HoF 2 * 6 * u16 teams that serves an unknown purpose.
2017-11-14 21:48:38 -08:00
Kurt
dbf10d1c29
Add surf score editing
...
trainer7 Ultra tab
Closes #1605
2017-11-14 21:35:28 -08:00
Kurt
e2dfc8d9f1
update fashion payloads
...
closes #1602
thanks Holla!
2017-11-14 19:48:30 -08:00
Kurt
c4f8dabd26
rework dex getting
...
changes iteration to be per-species rather than per list.
uses the internal 'should i set a bitflag' code rather than a banlist.
2017-11-14 19:14:02 -08:00
Kurt
c5cd6728fe
Add usum fashion cheats
...
Thanks Holla!
2017-11-13 22:07:41 -08:00
pokecal
955833a1c6
add G7 MapUnmask & FlyDestination
...
G7 is not FLY, just consistency with other Gens.
2017-11-14 11:59:33 +09:00
ReignOfComputer
5259b7546e
Totem Stickers Formatting & Window
...
Standardized the list of Totem Stickers and expanded the window slightly
to better fit text
2017-11-13 19:39:51 +08:00
Kurt
dbabcb9ef0
Misc updates
...
fix hall of fame fixed offset
fix ball throw type unlock/learned flags using fixed offset
fix current throw type defaulting to -1 when Nihilist (new USUM style)
by adding in for USUM
add fused slot offset fetching
convert event flag combined byte fetch to use Get/SetEventFlag with
event flag references.
add ZRingUnlocked sav properties & checkbox for toggling
set AlolaTime only if the combobox is enabled (only disabled if not yet
set by game)
Closes #1595
2017-11-12 21:28:34 -08:00
Kurt
7bc316d79c
Add "AlolaTime not existing yet" handling
...
Savedata::GameTime::IsAlolaOffsetExists
2017-11-12 16:10:31 -08:00
pokecal
dd83555953
complete USUM TotemSticker location
...
easy one have missed.
2017-11-13 04:54:48 +09:00
ReignOfComputer
69bdcacaec
Additional Totem Sticker Locations
...
1 left.
2017-11-12 22:29:44 +08:00
ReignOfComputer
596ff57fc3
Add Extra Zygarde Cell Locations
...
Wela Volcano Park (rocks behind sign)
Battle Tree Entrance
2017-11-12 18:28:39 +08:00
Kurt
6a73b9e6e4
Update zygarde cells
...
use const numbers, dynamic count for cells possible
2017-11-11 22:48:22 -08:00
Kurt
cfb38a771f
Merge pull request #1588 from pokecal/patch-1
...
add USUM TotemSticker resource
2017-11-11 22:36:49 -08:00
Kurt
fbab1cfbe6
Update usum eventflag max
...
now these event flags are making sense
2017-11-11 18:58:57 -08:00
pokecal
8b1c76ea06
add USUM TotemSticker resource
...
NPC said there are 100 stickers, so I missed 5, still finding.
2017-11-12 09:40:38 +09:00
Kurt
8ab39cae7b
Update dex form handling
2017-11-10 17:08:47 -08:00
Michael Scire
e455aef501
USUM event constants for starter choice/Tapu rebattle
2017-11-10 15:08:20 -08:00
Kurt
a39f92cac6
Add rockruff forme list items
...
revert form selection filtering, screwed up scatterbug and other
forced-forme lists. behavior works fine without the list filtering
2017-11-10 04:01:36 -08:00
Kurt
b3436cb791
Add totem forms selection/spritemod and req changes
2017-11-09 21:52:11 -08:00
Kurt
665e94b0aa
misc cleanup
...
add german forme names
truncate some forme names
fix nidoran gender symbols
adds null check for invalid (caught error) pkm
disables accessory giving (needs more research)
2017-11-08 22:56:42 -08:00
Kurt
cf35adca6f
Add roto blank item handling
...
preserve input data
2017-11-08 14:12:41 -08:00
Kurt
543736d568
Early rough USUM compatibility
...
need to dump string resources, sprites, and repoint the form list string
fetch later. tons more to do
no guarantee of any working functions
2017-11-08 00:34:32 -08:00
Kurt
0c370fe09e
fix skin dialogresult compare
...
closes #1557
replace \n with environment specific value
2017-11-04 12:22:32 -07:00
Kurt
008605c4ff
Add Gen5 BP editing to simpletrainer
...
a little bit hacky but exposes the values well enough.
moves the coins entry to the Badges groupbox, and makes it visible
looking like a BP editor (lol)
thanks @sora10pls for finding the offsets!
(blockinfo array isn't really used, is sorta just there for
documentation...)
2017-11-01 21:26:38 -07:00
Kurt
cd16a7721b
Set roamer data back on save
...
existing code cloned the savedata reference to a new array, and didn't
copy back
the Roamer3 reader/writer does all the r/w, and writing only happens
with the setter when the form is called to Save.
Thanks TheRealAlphA!
2017-10-22 17:17:17 -07:00
Kurt
228b0e84fb
Simplify some dex interaction
...
utilize get/set flag method calls, add xml docs for the two methods
2017-10-18 21:43:42 -07:00
Kurt
43d1c7740f
add event flag localization
...
rename files for english indication
allow script text retrieval with current language
simplify resource retrieval a little
2017-10-11 20:00:18 -07:00
Kurt
e845d562fd
Merge branch 'master' of https://github.com/kwsch/PKHeX
2017-10-10 19:30:58 -07:00
Kurt
c3c4336d43
Add gen3 roamer editor
...
Thanks BlackShark!
2017-10-10 18:48:14 -07:00
sora10pls
cc919dbdfc
Fix off-by-one Poketch offsets
2017-10-10 13:02:49 -04:00
Kurt
1a343ead85
Only modify SAV OT name if modified
...
resolves gen1 pikachu forgetting the original OT
2017-10-04 17:36:43 -07:00
Kurt
a9892203c7
Refactoring
...
extract pkm loading routines to smaller methods
reduce code duplication (rely on empty setters to ignore some calls)
should be much easier to understand the load/save process; the original
setup (pk6) was following the structure from 0x00-end, no point still
doing that as everything is now abstracted.
2017-10-02 23:13:40 -07:00
Kurt
9700ee79ad
Add used/unused all toggle to mg form
...
Closes #1503
2017-09-30 18:25:21 -07:00
Kurt
1e377c2963
interpolation++
...
no functional change (assumed)
2017-09-29 22:58:25 -07:00
Kurt
ed1b934374
Misc refactoring
...
expose some useful IEnumerable methods (sorting / bin->pkm / copy) to
simplify some common operations
change some explicit arrays to IList for flexibility
remove old memecrypto bool (no longer necessary as XP is not supported)
rename some methods for more clarity
2017-09-28 22:20:27 -07:00
Kurt
7c58bf0161
frlg eventflag recognition fix
...
referenced wrong string resource
note that frlg has no data so no flags/consts will appear (only custom
mods allowed).
closes #1497
2017-09-27 09:19:31 -07:00
Kurt
532cee406a
Add gen1 overworld respawner
2017-09-25 23:06:16 -07:00
Kurt
12187a5128
Expose gen2 RTC resetkey
...
#1487
also expose gen1 event flags (well, the crappy ones at least)
constants/event_constants.asm
2017-09-23 22:13:48 -07:00
Kurt
b63e53af95
misc tweaks
...
no functional changes
2017-09-19 23:19:22 -07:00
Kurt
c07a36c333
Fix event flag get set
...
yay order of operations
also update prompt messages for more guidance
Closes #1464
2017-09-17 10:16:56 -07:00
Kurt
5665481cab
Reduce machoke trade minlvl gen1
...
Thanks Mewtwo!
https://projectpokemon.org/home/forums/topic/41636-ricky-machamp-unable-to-match-encounter
https://bulbapedia.bulbagarden.net/wiki/Kanto_Safari_Zone
2017-09-15 06:42:00 -07:00
Kurt
d286fe9731
Extract get/set event flag common SAV method
...
throw in a little docs
2017-09-13 20:37:18 -07:00
Kurt
bc2f36c18c
uncap underground stats
...
only may have trouble if the stat gets close to int.MaxValue as it could
really be a uint :)
closes #1449
2017-09-08 09:04:29 -07:00
Archit Date
1123c24b0c
Fix Gen4 Misc options when no Poketch is obtained. ( #1448 )
...
* Fix Gen4 Misc options when no Poketch is obtained.
closes #1447
2017-09-07 12:25:45 -07:00
Kurt
d7b982728c
Disallow min/maximization of boxviewer
...
can double click or use windows keys to minimize
don't want that
other props are just updating themselves with the boxview control prop
additions
2017-09-06 22:02:03 -07:00
Kurt
219c042315
Add unlock all pokewalker courses cheat button
...
Closes #1406
2017-08-27 12:53:57 -07:00
Egzon Qukovci Jusufi
d0b5ceb8ff
Underground Score Editor (help needed) ( #1416 )
...
* Underground Score Editor first commit
* not needed space
* changed anchor points
* added dp offsets, ug scores to underground, underground button click code
2017-08-27 12:32:43 -07:00
Kurt
5b0e431347
Revert "Uncap max box ID for gen6 not-XY saves"
...
This reverts commit 9869335151
.
2017-08-26 08:41:18 -07:00
Kurt
9869335151
Uncap max box ID for gen6 not-XY saves
...
Closes #1411
2017-08-25 17:25:42 -07:00
Kurt
996a219a13
Gen5 international language bits dex fix
...
Closes #1395
Gen5 save files do not store multilang dex entries for gen5 species
https://bulbapedia.bulbagarden.net/wiki/Foreign_Pok%C3%A9dex_entries#In_Generation_V
2017-08-20 17:52:10 -07:00
Kurt
7fb9ce4131
Misc updates
...
Add global link mission stats (thanks Holla!)
remove some ToArray() linq in favor of direct copies
Relocate encounter suggestion logic to separate class
Closes #1396 , addresses other edge cases like entree-non HA & happiny
egg.
2017-08-15 21:16:47 -07:00
Kurt
47dcb56090
Misc fixes
...
static-wild encounter g4 collision (abra gift), closes #1390
off by one pokepuff strings
unshuffle bk4 ribbons
pgt bad sanity events now auto-sanitized
2017-08-10 20:51:27 -07:00
Kurt
8357774635
Disable play time editing on cxd
...
Closes #1292
2017-08-06 17:26:09 -07:00
Kurt
80196f75ef
Refactoring
...
split Core.PKX into smaller classes, only StringConverter is exposed for
outside namespaces
2017-07-31 23:03:51 -07:00
Kurt
2faf6ae8e5
Redo prior g5 roamer commit
...
switch to list to allow/add unknown value option
#1358
2017-07-23 22:44:00 -07:00
Kurt
866e8fd485
Split roamer flags into checkboxes
...
basically there was 0x81 which was not 0-3, and the other roamer had
0x40.
Closes #1358 , thanks @Ninjistix !
2017-07-22 13:15:53 -07:00
Kurt
ee57bc49f0
Add gen3 event flag/variable editing
...
Template files added for e/frlg, no guarantees.
http://i.imgur.com/ER5rRBn.png
(left+select+b when on groudon/kyogre menu screen)
Closes #1328 , thanks @rboninsegna !
Added the ability to prefix flag numbers with 0x, and prefix variable
numbers with 0x40__; will be parsed as hex.
2017-07-13 23:05:59 -07:00
Kurt
c12eba2186
Add Gen6 mega evolution early-unlock edit
...
TrainerCard offset is 0x14000
http://i.imgur.com/XtsZLmL.png
via:
33011937 ekx
182491428 hbg
tyvm anon
2017-07-12 20:38:24 -07:00
Kurt
fa642820b1
Redesign event flag editor
...
split control groups into separate tabs for easier viewing
2017-07-09 14:54:10 -07:00
Kurt
4a2dbe4ad2
Add gen4 ribbon names
...
Closes #1297
fix off by 1 language checking
2017-07-09 14:31:08 -07:00
Kurt
45c891e64f
Add inventory sorting by index number
...
Closes #1312
2017-07-06 17:24:40 -07:00
Kurt
502093b8b2
Misc tweaks
...
fix pcd detection (yield brewk needed to be inside brackets
remove brackets from single line lambda expressions
2017-07-05 23:05:49 -07:00
Kurt
80e2d55999
Tweak alt-click preview sprite behavior
...
Closes #1293
2017-07-02 21:27:22 -07:00
Kurt
4e9b6be8e5
Convert console output to debug output
...
output messages are now no longer in release builds, as they are only
visible when debugging in an IDE.
2017-07-01 19:43:51 -07:00
sora10pls
ef822b12ae
Misc Editor changes
2017-06-29 18:14:42 -04:00
sora10pls
9cd85bf1db
Misc4 updates
2017-06-23 15:47:52 -04:00
Kurt
86e0374efc
Update poketch dropdown/set
...
#1263
2017-06-22 19:18:14 -07:00
Kurt
1815a7f273
Add current poketch app selection
...
Closes #1260
2017-06-21 21:07:07 -07:00
Kurt
5b15483914
Allow Old Sea Map to be skipped on nonJP
...
Closes #1255
2017-06-20 22:24:02 -07:00
Kurt
5b4cedf14b
Refactoring
...
Rewrote showdown set exporting to be much clearer, added auto-fixing of
relearn moves when importing showdown set (applies suggested relearn
moves)
Simplified main form loading routine (from ~160 to ~25 by extracting
methods)
2017-06-18 13:02:02 -07:00
Kurt
da6f880c16
Add Shiny Leaf editing
...
Closes #1236
pk4/bk4 only, obviously
side note, using static events is no-no, designer auto-removed them.
just manually reapply (as well to others that used it)
2017-06-17 21:49:14 -07:00
Kurt
3f38b123a3
Refactoring
...
mostly renaming things, includes a little bit of added sugar and
splitting methods to simplify the codebase.
all methods are now PascalCase
2017-06-17 18:37:19 -07:00
Kurt
8f833d8171
Simplify max item count give/modify
...
999 is true max, set suggested give count to -4 from max (or 1).
Apply giveAll's max value restriction to modifyAll
Prevent giveall/modifyall for PCItems/FreeSpace due to mixed item types.
Closes #1228
Closes #1227
2017-06-14 18:43:28 -07:00
Kurt
86720b547b
Add <=gen3 pouch giveall
...
Closes #1225
Resizes array if too long, allows random set or standard (sequential)
set.
2017-06-14 08:42:49 -07:00
Kurt
5117f3a5c9
cap entry of Yellow pikachu friendship
...
gen1 trainer editor, 0-255
https://projectpokemon.org/forums/forums/topic/40817-request-autoset-yellow-pikachu-friendship-to-255-if-user-inserts-number-higher-than-255/
2017-06-11 00:25:21 -07:00
Kurt
21ab0296f3
small optimizations
...
Add ccitt method to checksum an existing array
reduce linq usage (faster save retrieval)
misc4 line endings?
2017-06-11 00:23:04 -07:00
pokecal
753964c138
fix Gen4 Misc Resources
...
add missing FlyDst and use MetLocation string.
add TrainerCard flags to FlagEditor.
add Pt resources.
fix HoneyTree, the BlockOffset needed.
2017-06-11 03:20:55 +09:00
pokecal
e85e155c65
add FRLG TrainerCard PokemonIcons
...
I don't know why Chimecho is listed at the very end.
2017-06-04 13:54:16 +09:00
pokecal
497f0c62b2
add BW2 FunfestMission controls
...
The entree level can display 9999 in game,
but fixed to 999 when it change.
MAX PassPowers require 9999 costs.
2017-06-03 14:35:24 +09:00
pokecal
c54cd30a3c
add EventFlags resources BW2
...
resources about legendaries
2017-06-03 11:45:24 +09:00
Kurt
858aa50689
Refactor encounter matching
...
exercise in deferred execution/state machine, only calculate possible
matches until a sufficiently valid match is obtained. Previous setup
would try to calculate the 'best match' and had band-aid workarounds in
cases where a subsequent check may determine it to be a false match.
There's still more ways to improve speed:
- precalculate relationships for Encounter Slots rather than iterating
over every area
- yielding individual slots instead of an entire area
- group non-egg wondercards by ID in a dict/hashtable for faster
retrieval
reworked some internals:
- EncounterMatch is always an IEncounterable instead of an object, for
easy pattern matching.
- Splitbreed checking is done per encounter and is stored in the
EncounterEgg result
- Encounter validation uses Encounter/Move/RelearnMove/Evolution to
whittle to the final encounter.
As a part of the encounter matching, a lazy peek is used to check if an
invalid encounter should be retained instead of discarded; if another
encounter has not been checked, it'll stop the invalid checks and move
on. If it is the last encounter, no other valid encounters exist so it
will keep the parse for the invalid encounter.
If no encounters are yielded, then there is no encountermatch. An
EncounterInvalid is created to store basic details, and the parse is
carried out.
Breaks some legality checking features for flagging invalid moves in
more detail, but those can be re-added in a separate check (if
splitbreed & any move invalid -> check for other split moves).
Should now be easier to follow the flow & maintain 😄
2017-05-27 21:17:57 -07:00