Rewrote LayerImage & ChangeOpacity to be faster (graphics & lockbits
instead of manual pixel by pixel changing)
Removed control based string conversion methods
Used linq to parse hex instead of Numerics
No need to shuffle 11*, just have the precomputed final shuffle values
and redirect.
Rearrangement removes PKX/PGT interaction (now only refers to past gen
code base)
Adding two offset ptrs is bad; only use one! Guess I originally intended
to have languageflags be a shift of the PokeDex ptr, but that's not
right!
Thanks DeadSkullzJr!
Transition from modifying byte arrays to just having objects mediate the
conversion.
Farewell pk2pk!
The PK# objects can convert up to the next generation through their own
methods; doing this required having class structures for all generations
:)
Memories won't be modified if the window has it disabled
Geolocations won't be modified if the Pokemon is an event Pokemon and is
so-far untraded.
Misc change: initializing boxes won't do unnecessary calcs.
Fixed reported bugs by Wanderer1391; found a bunch more as a side effect
of refactoring. Didn't like how so many values were hard coded so I
moved them all into the SAV6 class for easier r/w.
Re-enabled the Map Coordinate editing for non-ramsavs.
Updated the Map Coordinate display to the ingame coordinate style (using
NumericUpDowns), the coordinates for player.X and player.Y are divided
by 18 to get the current cell coordinates.
formInitialized is for closing the splash screen and showing the main
form.
fieldsInitialized is for setting up and not running updates until fields
are ready to be updated.
Arceus is now the initial species instead of language dependent
(Abomasnow).
Allows it to be easier used by comboboxes; SelectedValue = (byte) does
not work.
Instead of having these cast to int whenever used, this way is more
preferable.
Added an Edited property for the save
blank slot (encrypted) is initialized once and can be used elsewhere
instead of constantly being recreated for no reason.
Fixed having 32 boxes for non-saves
All SAV editing forms now set the Edited flag when saving->close.
Friendship and Affection are still not modified.
This may cause an issue with users who edit mons with their OT as
current handler and set friendship to 255, and the program makes the HT
with 0 friendship.
Can't really code in an alert as it'd be an annoyance for users. Gotta
think about it more :)
When initializing with a zero-byte array (ie, starting the program and
just having blank data), the box/party have specific offsets.
Also got rid of the silly default switch cases which can just be
achieved earlier.
Probably breaks a thing or two... time to get testing after this new
commit.
Wrapping the stored 'savefile' into an object which handles its use
allows a clearer separation of function and easier maintenance or future
updates.
May eventually move all get/sets for each form to allow property
fetching from any window, all logic handled within the class.
This makes it so that the program can turn off these methods for every
instance unless the implemented method explicitly says otherwise.
Nullable boolzzz
Properly init offsets for inventory, and fix for genderless bit writing.
ORAS PokeDex editor does not save bools for the current entry when
closing the form; fix will be provided in a later commit.
There's a few ways to finish implementing, as the program needs a way to
access Trainer Information on the fly. Quick and dirty way is to add new
global variables and set them when a save file is loaded, and a cleaner
way would be to move the 'savefile' variable into the sav class and do
all accessing from there.
Not yet decided on which. For now, the added items and code still do
nothing.
I don't have TradeFriendshipAffection called by anything; or any of
these methods for that matter. Need to find a solution so that the user
can turn ON/OFF these types of modifications (and ensure that PKHeX
doesn't overwrite any user data).
Eggs cannot have memories, and have all edits disabled.
When a pk6 is saved, memories will be cleared if they should not be
present.
Fixed empty regions showing up with data
Fixed not being able to edit the first georegion for an untraded Pokemon
All lock-outs for editing should be correct now.
'pkx' array was dummied out, resulting in the pk6 data not receiving the
party stats for writing.
Old bug: Having a Moveset with 1--4 (gap of two) would only remove one
of the blank move slots. Added method in the PK6 class for the (now
correct) fix-code; other fixes that are done when saving are now done in
separate methods as well.
Introduced the fully editable PK6 class object, which is now used by
PKHeX's pk6 editor, as well as updated the Box Data Report. Readability
should be increased as no
Includes bug fixes:
Odaxis' report regarding Event Flag Editor
Showdown sets using "Trait" instead of "Ability" (old old style) now can
be read.
Imported showdown sets will not use the imported gender label (instead
uses the current style, same 'value')
Remove numerous inter-form dependencies, remove hard-coded offsets,
update a few spots to use better programming practices.
Should increase the readability of PKHeX's source code.
Set will now import gender and set nickname properly, also will now
import Showdown's stat descriptions.
Latest OT will now write only enough bytes and won't overwrite any
previous names, leading to trash bytes. Fun.
Rock Smash, Distortion World, regular Starter/Gift/Fossil; should match
PokeGen's choices.
Rock Smash is HGSS exclusive; added identifiers to the other version
specific choices.
Yay for workarounds being less code intensive than first thought.
Internet method is easier than doing it in the program; user needs
internet on their 3DS to scan QRs anyway.
