Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-16 09:08:02 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Checks.cs

2103 lines
92 KiB
C#
Raw Normal View History

Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
using System;
using System.Collections.Generic;
using System.Linq;
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
using static PKHeX.Core.LegalityCheckStrings;
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
Split winforms to separate project resources still are associated with winforms, eh program still runs fine and I've replicated the mono build options. lmk if this breaks stuff
2017-01-08 07:54:09 +00:00
namespace PKHeX.Core
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
public partial class LegalityAnalysis
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private void verifyGender()
Add gender legality check dirty cheaters Tweaked ECPID to not bypass illegal flag checking if EC/PID were 0.
2016-07-04 01:36:04 +00:00
{
Personal Table per PKM Not by AO only (now works for species > 721)
2016-10-29 06:41:22 +00:00
if (pkm.PersonalInfo.Gender == 255 && pkm.Gender != 2)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V203, CheckIdentifier.Gender);
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
// Check for PID relationship to Gender & Nature if applicable
int gen = pkm.GenNumber;
bool PIDGender = 3 <= gen && gen <= 5;
if (!PIDGender)
return;
bool genderValid = pkm.getGenderIsValid();
if (!genderValid && pkm.Format > 5 && (pkm.Species == 183 || pkm.Species == 184))
{
var gv = pkm.PID & 0xFF;
if (gv > 63 && pkm.Gender == 1) // evolved from azurill after transferring to keep gender
genderValid = true;
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
}
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
if (genderValid)
AddLine(Severity.Valid, V250, CheckIdentifier.Gender);
else
AddLine(Severity.Invalid, V251, CheckIdentifier.Gender);
bool PIDNature = gen != 5;
if (!PIDNature)
return;
Misc ec/pid tweaks use the encryption constant (pk3-5 return PID on get), fix gen4 using gen5 correlation
2017-05-04 06:14:34 +00:00
if (pkm.EncryptionConstant % 25 == pkm.Nature)
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
AddLine(Severity.Valid, V252, CheckIdentifier.Nature);
else
AddLine(Severity.Invalid, V253, CheckIdentifier.Nature);
Add gender legality check dirty cheaters Tweaked ECPID to not bypass illegal flag checking if EC/PID were 0.
2016-07-04 01:36:04 +00:00
}
Gen 7 Item Legality Checks For https://github.com/kwsch/PKHeX/issues/891.
2017-02-26 15:55:22 +00:00
private void verifyItem()
{
Switch item banlist to allowed list Precompute bool[] to quickly access the allowed status instead of looping for contains.
2017-02-26 19:43:26 +00:00
if (!Legal.getHeldItemAllowed(pkm.Format, pkm.HeldItem))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V204, CheckIdentifier.Form);
E-reader Berry (#1050) * E-Reader berry improvement Load from the savegame the name of the e-reader berry and show in the item list that name instead of enigma berry if there is any e-reader berry data stored Also check Legality of the berry, as enigma berry is unrelead in generation 3, but if there is e-berry data if check if the e-berry name is from one of the released cards * Fix Shedinja moves check in generation 3 format * Update comments, e-berry code is based in Suloku work for the gen 3 wc-tool * Move e-reader comunication with Legality class to Main.cs Remove curly braces in GameInfo * Undo all changes in SaveUtil.cs
2017-04-10 22:59:16 +00:00
if (pkm.Format == 3 && pkm.HeldItem == 175)
verifyEReaderBerry();
}
private void verifyEReaderBerry()
{
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
if (Legal.EReaderBerryIsEnigma) // no E-Reader berry data provided, can't hold berry.
E-reader Berry (#1050) * E-Reader berry improvement Load from the savegame the name of the e-reader berry and show in the item list that name instead of enigma berry if there is any e-reader berry data stored Also check Legality of the berry, as enigma berry is unrelead in generation 3, but if there is e-berry data if check if the e-berry name is from one of the released cards * Fix Shedinja moves check in generation 3 format * Update comments, e-berry code is based in Suloku work for the gen 3 wc-tool * Move e-reader comunication with Legality class to Main.cs Remove curly braces in GameInfo * Undo all changes in SaveUtil.cs
2017-04-10 22:59:16 +00:00
{
AddLine(Severity.Invalid, V204, CheckIdentifier.Form);
return;
}
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
E-reader Berry (#1050) * E-Reader berry improvement Load from the savegame the name of the e-reader berry and show in the item list that name instead of enigma berry if there is any e-reader berry data stored Also check Legality of the berry, as enigma berry is unrelead in generation 3, but if there is e-berry data if check if the e-berry name is from one of the released cards * Fix Shedinja moves check in generation 3 format * Update comments, e-berry code is based in Suloku work for the gen 3 wc-tool * Move e-reader comunication with Legality class to Main.cs Remove curly braces in GameInfo * Undo all changes in SaveUtil.cs
2017-04-10 22:59:16 +00:00
var matchUSA = Legal.EReaderBerriesNames_USA.Contains(Legal.EReaderBerryName);
var matchJP = Legal.EReaderBerriesNames_JP.Contains(Legal.EReaderBerryName);
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
if (!matchJP && !matchUSA) // Does not match any released E-Reader berry
E-reader Berry (#1050) * E-Reader berry improvement Load from the savegame the name of the e-reader berry and show in the item list that name instead of enigma berry if there is any e-reader berry data stored Also check Legality of the berry, as enigma berry is unrelead in generation 3, but if there is e-berry data if check if the e-berry name is from one of the released cards * Fix Shedinja moves check in generation 3 format * Update comments, e-berry code is based in Suloku work for the gen 3 wc-tool * Move e-reader comunication with Legality class to Main.cs Remove curly braces in GameInfo * Undo all changes in SaveUtil.cs
2017-04-10 22:59:16 +00:00
AddLine(Severity.Invalid, V369, CheckIdentifier.Form);
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
else if (matchJP && !Legal.SavegameJapanese) // E-Reader is region locked
E-reader Berry (#1050) * E-Reader berry improvement Load from the savegame the name of the e-reader berry and show in the item list that name instead of enigma berry if there is any e-reader berry data stored Also check Legality of the berry, as enigma berry is unrelead in generation 3, but if there is e-berry data if check if the e-berry name is from one of the released cards * Fix Shedinja moves check in generation 3 format * Update comments, e-berry code is based in Suloku work for the gen 3 wc-tool * Move e-reader comunication with Legality class to Main.cs Remove curly braces in GameInfo * Undo all changes in SaveUtil.cs
2017-04-10 22:59:16 +00:00
AddLine(Severity.Invalid, V370, CheckIdentifier.Form);
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
else if (matchUSA && Legal.SavegameJapanese) // E-Reader is region locked
E-reader Berry (#1050) * E-Reader berry improvement Load from the savegame the name of the e-reader berry and show in the item list that name instead of enigma berry if there is any e-reader berry data stored Also check Legality of the berry, as enigma berry is unrelead in generation 3, but if there is e-berry data if check if the e-berry name is from one of the released cards * Fix Shedinja moves check in generation 3 format * Update comments, e-berry code is based in Suloku work for the gen 3 wc-tool * Move e-reader comunication with Legality class to Main.cs Remove curly braces in GameInfo * Undo all changes in SaveUtil.cs
2017-04-10 22:59:16 +00:00
AddLine(Severity.Invalid, V371, CheckIdentifier.Form);
Gen 7 Item Legality Checks For https://github.com/kwsch/PKHeX/issues/891.
2017-02-26 15:55:22 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private void verifyECPID()
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
if (pkm.Format >= 6)
verifyEC();
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch.Species == 265)
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
verifyECPIDWurmple();
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.PID == 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V207, CheckIdentifier.PID);
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.GenNumber >= 6 && pkm.PID == pkm.EncryptionConstant)
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
AddLine(Severity.Invalid, V208, CheckIdentifier.PID); // better to flag than 1:2^32 odds since RNG is not feasible to yield match
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterStatic s)
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (s.Shiny != null && (bool) s.Shiny ^ pkm.IsShiny)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V209, CheckIdentifier.Shiny);
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
}
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
else if (EncounterMatch is EncounterSlot w)
Misc legality checks (gen5-7) (#1020) * Add Flabebe and Pumkaboo altform HA legality check Fix issue #999 The derived value SpecForm can use for other legality checks * Add N's pkm and Hidden Grotto shiny legality checks -fix early return in verifyMisc -add N's pkm legality check: IVs, OT Name, TID, SID, Shiny -add Hidden Grotto shiny check * Fix spelling * More edge cases for gen6 ball checks Ban several altform hidden ability with gen3 ball * Fix gen4 Formcount for altform Manually fix several bytes (http://i.imgur.com/l0Amuto.png)
2017-04-02 13:39:39 +00:00
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (pkm.IsShiny && w.Type == SlotType.HiddenGrotto)
Misc legality checks (gen5-7) (#1020) * Add Flabebe and Pumkaboo altform HA legality check Fix issue #999 The derived value SpecForm can use for other legality checks * Add N's pkm and Hidden Grotto shiny legality checks -fix early return in verifyMisc -add N's pkm legality check: IVs, OT Name, TID, SID, Shiny -add Hidden Grotto shiny check * Fix spelling * More edge cases for gen6 ball checks Ban several altform hidden ability with gen3 ball * Fix gen4 Formcount for altform Manually fix several bytes (http://i.imgur.com/l0Amuto.png)
2017-04-02 13:39:39 +00:00
AddLine(Severity.Invalid, V221, CheckIdentifier.Shiny);
}
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
}
private void verifyECPIDWurmple()
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
uint evoVal = EncounterGenerator.getWurmpleEvoVal(pkm);
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
if (pkm.Species == 265)
AddLine(Severity.Valid, string.Format(V212, evoVal == 0 ? specieslist[267] : specieslist[269]), CheckIdentifier.EC);
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
int wIndex = Array.IndexOf(Legal.WurmpleEvolutions, pkm.Species) / 2;
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
if (evoVal != wIndex)
AddLine(Severity.Invalid, V210, CheckIdentifier.EC);
}
private void verifyEC()
{
if (pkm.EncryptionConstant == 0)
AddLine(Severity.Fishy, V201, CheckIdentifier.EC);
if (3 <= pkm.GenNumber && pkm.GenNumber <= 5)
verifyTransferEC();
else
More strict checks Only fishy adds. Matching TID/SID Matching PID/EC Matching EXP/Level
2016-04-08 00:56:39 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
int xor = pkm.TSV ^ pkm.PSV;
if (xor < 16 && xor >= 8 && (pkm.PID ^ 0x80000000) == pkm.EncryptionConstant)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V211, CheckIdentifier.EC);
More strict checks Only fishy adds. Matching TID/SID Matching PID/EC Matching EXP/Level
2016-04-08 00:56:39 +00:00
}
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
}
private void verifyTransferEC()
{
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
// When transferred to Generation 6, the Encryption Constant is copied from the PID.
// The PID is then checked to see if it becomes shiny with the new Shiny rules (>>4 instead of >>3)
// If the PID is nonshiny->shiny, the top bit is flipped.
// Check to see if the PID and EC are properly configured.
Fix unused legality check (3/4/5th gen only) Thanks Sabresite!
2016-12-23 02:18:35 +00:00
bool xorPID = ((pkm.TID ^ pkm.SID ^ (int)(pkm.PID & 0xFFFF) ^ (int)(pkm.PID >> 16)) & ~0x7) == 8;
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
bool valid = xorPID
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
? pkm.EncryptionConstant == (pkm.PID ^ 0x8000000)
: pkm.EncryptionConstant == pkm.PID;
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
if (!valid)
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
AddLine(Severity.Invalid, xorPID ? V215 : V216, CheckIdentifier.ECPID);
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#region verifyNickname
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private void verifyNickname()
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
// If the Pokémon is not nicknamed, it should match one of the language strings.
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.Nickname.Length == 0)
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V2, CheckIdentifier.Nickname);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
if (pkm.Species > PKX.SpeciesLang[0].Length)
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Indeterminate, V3, CheckIdentifier.Nickname);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
if (pkm.VC)
{
string pk = pkm.Nickname;
var langset = PKX.SpeciesLang.FirstOrDefault(s => s.Contains(pk)) ?? PKX.SpeciesLang[2];
int lang = Array.IndexOf(PKX.SpeciesLang, langset);
if (pk.Length > (lang == 2 ? 10 : 5))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V1, CheckIdentifier.Nickname);
Add event nicknamed fishy flag Also updates lang translations for incorrect/missing strings (ps: uncomment the line in main to copy the current localization strings to clipboard for ez paste replace into notepad)
2017-04-09 23:38:29 +00:00
}
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
else if (Type == typeof(MysteryGift))
Add event nicknamed fishy flag Also updates lang translations for incorrect/missing strings (ps: uncomment the line in main to copy the current localization strings to clipboard for ez paste replace into notepad)
2017-04-09 23:38:29 +00:00
{
if (pkm.IsNicknamed && (!(EncounterMatch as MysteryGift)?.IsEgg ?? false))
AddLine(Severity.Fishy, V0, CheckIdentifier.Nickname);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
}
Tweak nickname check severity
2016-03-20 01:06:02 +00:00
if (!Encounter.Valid)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
if (pkm.Format <= 6 && pkm.Language > 8)
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Indeterminate, V4, CheckIdentifier.Language);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Add traditional species list & selections
2016-11-09 16:23:47 +00:00
if (pkm.Format <= 7 && pkm.Language > 10)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Indeterminate, V5, CheckIdentifier.Language);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Refactoring Simplify EncounterStatic type check as it is gen4 specific -> gen4 specific child class Checks.cs: Move transfer legality check back to end as Gen4Result needs to be defined (not null) Rename EncounterType of Analysis class to avoid conflict with the EncounterType enum
2017-04-22 20:04:12 +00:00
if (Type == typeof(EncounterTrade))
Add Ingame Trade OT/Nick check
2016-03-27 00:23:53 +00:00
{
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
verifyNicknameTrade();
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add Ingame Trade OT/Nick check
2016-03-27 00:23:53 +00:00
}
Tweak nickname check severity
2016-03-20 01:06:02 +00:00
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.IsEgg)
Add Egg name checks
2016-03-16 04:15:40 +00:00
{
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
verifyNicknameEgg();
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add Egg name checks
2016-03-16 04:15:40 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
string nickname = pkm.Nickname.Replace("'", "’");
if (pkm.IsNicknamed)
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Tweak nickname check severity
2016-03-20 01:06:02 +00:00
for (int i = 0; i < PKX.SpeciesLang.Length; i++)
{
string[] lang = PKX.SpeciesLang[i];
int index = Array.IndexOf(lang, nickname);
if (index < 0)
continue;
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
AddLine(Severity.Fishy, index == pkm.Species && i != pkm.Language
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
? V15
: V16, CheckIdentifier.Nickname);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Tweak nickname check severity
2016-03-20 01:06:02 +00:00
}
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
if (nickname.Any(c => 0x4E00 <= c && c <= 0x9FFF)) // East Asian Scripts
{
AddLine(Severity.Invalid, V222, CheckIdentifier.Nickname);
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V17, CheckIdentifier.Nickname);
Add Nickname legality check
2016-03-16 01:56:18 +00:00
}
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
else if (pkm.Format < 3)
{
// pk1/pk2 IsNicknamed getter checks for match, logic should only reach here if matches.
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V18, CheckIdentifier.Nickname);
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
}
else
Add Nickname legality check
2016-03-16 01:56:18 +00:00
{
Fix foreign traded hatched egg species name Language/Geolocation does not get modified when an egg hatches. Thanks @NotRaia
2016-07-11 05:22:55 +00:00
// Can't have another language name if it hasn't evolved or wasn't a language-traded egg.
Fix nickname check when traded between languages
2017-04-10 01:28:22 +00:00
bool evolved = Legal.getHasEvolved(pkm);
Update nickname text check Generation specific names now show up legal if they are correct (ie all caps)
2017-03-19 22:40:49 +00:00
bool match = PKX.getSpeciesNameGeneration(pkm.Species, pkm.Language, pkm.Format) == nickname;
Fix nickname check when traded between languages
2017-04-10 01:28:22 +00:00
if (pkm.WasTradedEgg || evolved)
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
match |= !PKX.getIsNicknamedAnyLanguage(pkm.Species, nickname, pkm.Format);
Fix nickname check when traded between languages
2017-04-10 01:28:22 +00:00
if (!match && pkm.Format == 5 && !pkm.IsNative) // transfer
{
if (evolved)
match |= !PKX.getIsNicknamedAnyLanguage(pkm.Species, nickname, 4);
else
match |= PKX.getSpeciesNameGeneration(pkm.Species, pkm.Language, 4) == nickname;
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (!match)
Add exclusion for greninja demo gift Closes #869
2017-02-21 06:03:07 +00:00
{
if ((EncounterMatch as MysteryGift)?.CardID == 2046 && (pkm.SID << 16 | pkm.TID) == 0x79F57B49)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V19, CheckIdentifier.Nickname);
Add exclusion for greninja demo gift Closes #869
2017-02-21 06:03:07 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V20, CheckIdentifier.Nickname);
Add exclusion for greninja demo gift Closes #869
2017-02-21 06:03:07 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V18, CheckIdentifier.Nickname);
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
}
}
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
private void verifyNicknameEgg()
{
Handle gen4 egg nickname edge case Egg is not saved as "EGG", it is "Egg". Nice job gf. Instead of ignoring the nickname flag, detect if it should be used or not. Gen4 never uses it. Gen7 doesn't use it when it's a gift, but uses it for daycare eggs (...). Closes #1100
2017-05-10 04:11:13 +00:00
switch (pkm.Format)
{
case 4:
if (pkm.IsNicknamed) // gen4 doesn't use the nickname flag for eggs
AddLine(Severity.Invalid, V224, CheckIdentifier.Egg);
break;
case 7:
if (EncounterMatch is EncounterStatic ^ !pkm.IsNicknamed) // gen7 doesn't use for ingame gifts
AddLine(Severity.Invalid, pkm.IsNicknamed ? V224 : V12, CheckIdentifier.Egg);
break;
default:
if (!pkm.IsNicknamed)
AddLine(Severity.Invalid, V12, CheckIdentifier.Egg);
break;
}
if (PKX.getSpeciesNameGeneration(0, pkm.Language, pkm.GenNumber) != pkm.Nickname)
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
AddLine(Severity.Invalid, V13, CheckIdentifier.Egg);
else
AddLine(Severity.Valid, V14, CheckIdentifier.Egg);
}
private void verifyNicknameTrade()
{
string[] validOT = new string[0];
int index = -1;
if (pkm.XY)
{
validOT = Legal.TradeXY[pkm.Language];
index = Array.IndexOf(Legal.TradeGift_XY, EncounterMatch);
}
else if (pkm.AO)
{
validOT = Legal.TradeAO[pkm.Language];
index = Array.IndexOf(Legal.TradeGift_AO, EncounterMatch);
}
else if (pkm.SM)
{
// TODO
AddLine(Severity.Valid, V194, CheckIdentifier.Nickname);
return;
}
else if (pkm.Format <= 2 || pkm.VC)
{
Gen 1 move analysis improvement. Adapted the valid moves to take into account that move deleter and move reminder do not exits in generation 1 (#1037) * Fix getMoves with min level, when SkipWhile and TakeWhile is used together the index i in TakeWhile is calculated from the enumerator that results of the SkipWhile function, not the index of the initial array, those giving an incorrect index to check Levels array in the TakeWhile * Fix getMoves when levelmin or levelmax is above max level in the levels array, TakeWhile and SkipWhile return empty list if the while goes beyond the last element of the array * Include player hatched egg in the list of possible encounters for parseMoves only if the pokemon was an egg Also change the valur of WasEgg for gen1,2,3 pokemon if the encounter analyzed is not an egg add the non egg encounters to the list instead of checking the non-egg encounter inside parseMovesWasEggPreRelearn * Fix for gen3 egg encounters Remove non-egg encounters without special moves if there is an egg encounter because egg encounter already cover every possible move combination Do not add daycare egg encounter for gen3 unhatched egg if there is another encounter, that means is an event or gift egg, not a daycare egg Remove duplicate encounters * Gift egg should not allow inherited moves even it they dont have special moves Those gift eggs are hatched only with the species base moves * Added getEncounterMoves functions, to be used for generation 1 encounters to find what moves have a pokemon at the moment of being caught because there is no move reminder in generation 1 * Added GBEncounterData, structure for refactor the tuples used in generation 1 and 2 encounters * Add LevelMin and LevelMax to IEncounterable to get the encounter moves by the min level of the generation 1 EncounterLink Add iGeneration to difference generation 1 and generation 2 encounters for GB Era pokemon * Mark generation in gen 1 and 2 encounters There is no need to mark the generation in gen 3 to 7 encounters because in that generations it match the pokemon generation number * Add min level for generation 1 moves in getMoves functions Add function to return the default moves for a GB encounters, for generation 1 games that included both moves from level up table and level 1 moves from personal table Fix getMoves with min level when the moves list is empty, like Raichu generation 1 * Add maxSpecies to getBaseSpecies function for gen1 pokemon with a gen2 egg encounter Refactor VC Encounter changing Tuples for GBData class * Fixed for gen 2 Checks Also do not search for generation1 encounter if the gen2 pokemon have met location from crystal * Fix VC wild encounters, should be stored as array or else other verifyEncounter functions wont work * Add generation 1 parse moves function including default moves * Clean-up get encounters * Verify empty moves for generation 1 encounters, in generation 1 does not exits move deleter That means when a move slot have been used by a level up move or a TM/HM/Tutor move it cant be empty again Does not apply if generation 2 tradeback is allowed, in generation 2 there is a move deleter * Added two edge cases for pokemon that learn in red/blue and yellow different moves at the same level, this combinations can not exits until a later level when they learn again one of the levels in the other game, only happen for flareon and vaporeon * Check incompatible moves between evolution species, it is for species that learn a move in a level as an evolved species and a move at a upper level as a preevolution Also added most edge cases for the min slots used for generation 1 games, i think every weird combination is already covered * Fix gen 1 eevee and evolutions move checks * Cleanup * Move the code to change valid moves for generation 1 to a function * Fix getMoveMinLevelGBEncounter * getUsedMoveSlots, removed wild Butterfree edge case, it is not possible * Filter the min level of the encounter by the possible games the pokemon could be originated, yellow pikachu and kadabra can be detected
2017-04-09 00:17:20 +00:00
var et = EncounterOriginalGB as EncounterTrade;
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
if (et?.TID == 0) // Gen1 Trade
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (!EncounterGenerator.getEncounterTrade1Valid(pkm))
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
AddLine(Severity.Invalid, V10, CheckIdentifier.Trainer);
}
else // Gen2
{
return; // already checked all relevant properties when fetching with getValidEncounterTradeVC2
}
return;
}
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
else if (3 <= pkm.GenNumber && pkm.GenNumber <= 5)
General gen5 fixes - begin to impl ball checking - add white forest for white (move greatmarshalt to table4) - fix several datapoints - fix ability from dream world - add in-game version filtering
2017-03-30 06:31:02 +00:00
{
// Suppressing temporarily
General Fixes (#1005) * Fix FRLG Viapois Chamber Location * Gen 3 In-game Trade Fixes 3rd Gen Trades still need changes to verifyNicknameTrade to work though. Temporarily suppressed the legality warning. It seems Bulbapedia may have some mistakes? * Fix Squirtle Gift in HGSS
2017-03-28 09:02:46 +00:00
return;
}
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
if (validOT.Length == 0)
{
AddLine(Severity.Indeterminate, V7, CheckIdentifier.Trainer);
return;
}
if (index == -1 || validOT.Length < index * 2)
{
AddLine(Severity.Indeterminate, V8, CheckIdentifier.Trainer);
return;
}
string nick = validOT[index];
string OT = validOT[validOT.Length / 2 + index];
if (nick != pkm.Nickname)
AddLine(Severity.Fishy, V9, CheckIdentifier.Nickname);
else if (OT != pkm.OT_Name)
AddLine(Severity.Invalid, V10, CheckIdentifier.Trainer);
else
AddLine(Severity.Valid, V11, CheckIdentifier.Nickname);
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#endregion
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private void verifyEVs()
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
var evs = pkm.EVs;
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
int sum = evs.Sum();
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
if (sum > 0 && pkm.IsEgg)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V22, CheckIdentifier.EVs);
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
if (sum > 510)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V25, CheckIdentifier.EVs);
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
if (pkm.Format >= 6 && evs.Any(ev => ev > 252))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V26, CheckIdentifier.EVs);
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (pkm.Format == 4 && pkm.Gen4 && EncounterMatch.LevelMin == 100)
Various legallity checks added and fixed (#1049) * Fix required move count for Butterfree and Gyarados * Ruby Sapphire Southern Island legendaries do not have fateful encounter * Added missing event egg for generation 3 Filter generation 3 event egg by game origin, an egg pokemon remains with the original game no matter in what game it hached * Filter the event egg static table better than individual pokemon from the table * Generation 4 do not allow to EV train at level 100, for level 100 encounter pokemon (like events) EV only can be trained with vitamins, with a maximum value of 100 * Fix incorrect string * Generation 2 eggs can not be infected with Pokérus * Fix gyarados count slots
2017-04-10 12:11:07 +00:00
{
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
// Cannot EV train at level 100 -- Certain events are distributed at level 100.
if (evs.Any(ev => ev > 100)) // EVs can only be increased by vitamins to a max of 100.
Various legallity checks added and fixed (#1049) * Fix required move count for Butterfree and Gyarados * Ruby Sapphire Southern Island legendaries do not have fateful encounter * Added missing event egg for generation 3 Filter generation 3 event egg by game origin, an egg pokemon remains with the original game no matter in what game it hached * Filter the event egg static table better than individual pokemon from the table * Generation 4 do not allow to EV train at level 100, for level 100 encounter pokemon (like events) EV only can be trained with vitamins, with a maximum value of 100 * Fix incorrect string * Generation 2 eggs can not be infected with Pokérus * Fix gyarados count slots
2017-04-10 12:11:07 +00:00
AddLine(Severity.Invalid, V367, CheckIdentifier.EVs);
}
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
// Only one of the following can be true: 0, 508, and x%6!=0
if (sum == 0 && pkm.CurrentLevel - Math.Max(1, pkm.Met_Level) > 0)
AddLine(Severity.Fishy, V23, CheckIdentifier.EVs);
else if (sum == 508)
AddLine(Severity.Fishy, V24, CheckIdentifier.EVs);
else if (evs[0] != 0 && evs.All(ev => evs[0] == ev))
AddLine(Severity.Fishy, V27, CheckIdentifier.EVs);
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private void verifyIVs()
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (EncounterMatch is EncounterStatic s && s.IV3)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Add gen1->gen7 IV legality check Also fix gen1/2 evo tree trimming error, thanks BeyondTheHorizon! Also fix an exception when no static encounter can be generated for 1->7, match is now generated by checking gen1 and reusing the static encounter creation info (now moved to core).
2017-03-10 04:27:03 +00:00
int IVCount = 3;
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (s.Version == GameVersion.RBY && pkm.Species == 151)
Add gen1->gen7 IV legality check Also fix gen1/2 evo tree trimming error, thanks BeyondTheHorizon! Also fix an exception when no static encounter can be generated for 1->7, match is now generated by checking gen1 and reusing the static encounter creation info (now moved to core).
2017-03-10 04:27:03 +00:00
IVCount = 5; // VC Mew
if (pkm.IVs.Count(iv => iv == 31) < IVCount)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V28, IVCount), CheckIdentifier.IVs);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
}
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterSlot w && w.Type == SlotType.FriendSafari)
Add friend safari IV check 2 IVs have to be flawless
2017-01-01 01:20:13 +00:00
{
if (pkm.IVs.Count(iv => iv == 31) < 2)
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V29, CheckIdentifier.IVs);
Add friend safari IV check 2 IVs have to be flawless
2017-01-01 01:20:13 +00:00
return;
}
}
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (EncounterMatch is MysteryGift g)
Add WC6/WC7 IV check Closes thread 40025
2017-02-02 05:27:14 +00:00
{
int[] IVs;
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
switch (g.Format)
Add WC6/WC7 IV check Closes thread 40025
2017-02-02 05:27:14 +00:00
{
case 7: IVs = ((WC7)EncounterMatch).IVs; break;
Add gen1->gen7 IV legality check Also fix gen1/2 evo tree trimming error, thanks BeyondTheHorizon! Also fix an exception when no static encounter can be generated for 1->7, match is now generated by checking gen1 and reusing the static encounter creation info (now moved to core).
2017-03-10 04:27:03 +00:00
case 6: IVs = ((WC6)EncounterMatch).IVs; break;
case 5: IVs = ((PGF)EncounterMatch).IVs; break;
Add WC6/WC7 IV check Closes thread 40025
2017-02-02 05:27:14 +00:00
default: IVs = null; break;
}
if (IVs != null)
{
var pkIVs = pkm.IVs;
bool valid = true;
for (int i = 0; i < 6; i++)
if (IVs[i] <= 31 && IVs[i] != pkIVs[i])
valid = false;
if (!valid)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V30, CheckIdentifier.IVs);
Misc fixes & Some tweaks for legality check (#1044) * Add gen3-6 unreleased items * Fix string converter fix traditional chinese char offset fix out-of-range crash * Fix ivs and ability check for VC transfer Refetch the static enconter for VC transfer after moves checks update legality string translation impl non-HA ability matching * Add ivs legality check for wc gift
2017-04-10 04:59:44 +00:00
bool IV3 = IVs[0] == 0xFE;
if (IV3 && pkm.IVs.Count(iv => iv == 31) < 3)
AddLine(Severity.Invalid, string.Format(V28, 3), CheckIdentifier.IVs);
Add WC6/WC7 IV check Closes thread 40025
2017-02-02 05:27:14 +00:00
}
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.IVs.Sum() == 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V31, CheckIdentifier.IVs);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else if (pkm.IVs[0] < 30 && pkm.IVs.All(iv => pkm.IVs[0] == iv))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V32, CheckIdentifier.IVs);
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
}
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
private void verifyDVs()
{
// todo
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#region verifyOT
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
private void verifyOT()
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Refactoring Simplify EncounterStatic type check as it is gen4 specific -> gen4 specific child class Checks.cs: Move transfer legality check back to end as Gen4Result needs to be defined (not null) Rename EncounterType of Analysis class to avoid conflict with the EncounterType enum
2017-04-22 20:04:12 +00:00
if (Type == typeof(EncounterTrade))
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return; // Already matches Encounter Trade information
if (pkm.TID == 0 && pkm.SID == 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V33, CheckIdentifier.Trainer);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
else if (pkm.VC)
{
if (pkm.SID != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V34, CheckIdentifier.Trainer);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else if (pkm.TID == pkm.SID)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V35, CheckIdentifier.Trainer);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else if (pkm.TID == 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V36, CheckIdentifier.Trainer);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else if (pkm.SID == 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V37, CheckIdentifier.Trainer);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
if (pkm.VC)
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
verifyG1OT();
}
private void verifyG1OT()
{
string tr = pkm.OT_Name;
string pk = pkm.Nickname;
var langset = PKX.SpeciesLang.FirstOrDefault(s => s.Contains(pk)) ?? PKX.SpeciesLang[2];
int lang = Array.IndexOf(PKX.SpeciesLang, langset);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
if (tr.Length > (lang == 2 ? 7 : 5))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V38, CheckIdentifier.Trainer);
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
if (pkm.Species == 151)
{
if (tr != "GF" && tr != "ゲーフリ") // if there are more events with special OTs, may be worth refactoring
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V39, CheckIdentifier.Trainer);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
}
slight tweaks reduce nesting, formatting; no functional change
2017-05-01 15:25:20 +00:00
if ((EncounterMatch as EncounterStatic)?.Version == GameVersion.Stadium)
Encounter Type fix and detection of pokemon that should have evolve on trade (#1105) * Detect encounter trades that evolve on trade and have not been evolved Detect generation 1 pokemon with special catch rates : krabby trade and Pokemon Stadium Detect generation 1 pokemon that evolve on trade and have been traded but not evolved Detect pokemon with tradeback status any but with only encounters from the other GB generation, that means they are WasTradeback Detect pokemon with moves from the other GB generation, change tradebackstatus to WasTradeback * Fix dppt surfing and fishing encounter type, is is surfing because the battle background is the same as other surfingfishing encounters Fix headbutt encounter type, the encounter type depends on the battle background used when battle a pokemon, for headbutt it changes with the player tile, is the player is in a city it will be building encounter, in a grass tile tall grass, in water it is surfingfishing and cave inside a cave. Some locations have more than one possible encounter type, for example routes with trees near the grass, near the water and near non-combat tiles. Also added slot type headbutt special for the special trees, those trees are all in routes and are only adjacent to non-combat tiles * Fix encounter type for missing areas with multiple grass encounters types: Mt Coronet, Mt Silver Cave and Stark Mountain (Issue # 1095) * Fixes and typos * Check for non-japanese e-reader pokemon, is unreleased
2017-05-01 15:07:20 +00:00
{
slight tweaks reduce nesting, formatting; no functional change
2017-05-01 15:25:20 +00:00
if (tr == "STADIUM" && pkm.TID == 2000)
Encounter Type fix and detection of pokemon that should have evolve on trade (#1105) * Detect encounter trades that evolve on trade and have not been evolved Detect generation 1 pokemon with special catch rates : krabby trade and Pokemon Stadium Detect generation 1 pokemon that evolve on trade and have been traded but not evolved Detect pokemon with tradeback status any but with only encounters from the other GB generation, that means they are WasTradeback Detect pokemon with moves from the other GB generation, change tradebackstatus to WasTradeback * Fix dppt surfing and fishing encounter type, is is surfing because the battle background is the same as other surfingfishing encounters Fix headbutt encounter type, the encounter type depends on the battle background used when battle a pokemon, for headbutt it changes with the player tile, is the player is in a city it will be building encounter, in a grass tile tall grass, in water it is surfingfishing and cave inside a cave. Some locations have more than one possible encounter type, for example routes with trees near the grass, near the water and near non-combat tiles. Also added slot type headbutt special for the special trees, those trees are all in routes and are only adjacent to non-combat tiles * Fix encounter type for missing areas with multiple grass encounters types: Mt Coronet, Mt Silver Cave and Stark Mountain (Issue # 1095) * Fixes and typos * Check for non-japanese e-reader pokemon, is unreleased
2017-05-01 15:07:20 +00:00
AddLine(Severity.Valid, V403, CheckIdentifier.Trainer);
else if (tr == "スタジアム" && pkm.TID == 1999)
AddLine(Severity.Valid, V404, CheckIdentifier.Trainer);
else
AddLine(Severity.Invalid, V402, CheckIdentifier.Trainer);
}
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#endregion
Legality Checking for Hyper Training
2016-11-11 10:31:50 +00:00
private void verifyHyperTraining()
{
if (pkm.Format < 7)
return; // No Hyper Training before Gen VII
var IVs = new[] { pkm.IV_HP, pkm.IV_ATK, pkm.IV_DEF, pkm.IV_SPA, pkm.IV_SPD, pkm.IV_SPE };
var HTs = new[] { pkm.HT_HP, pkm.HT_ATK, pkm.HT_DEF, pkm.HT_SPA, pkm.HT_SPD, pkm.HT_SPE };
Additional Hyper Training Legality Check
2016-11-11 11:23:38 +00:00
if (HTs.Any(ht => ht) && pkm.CurrentLevel != 100)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V40, CheckIdentifier.IVs);
Additional Hyper Training Legality Check
2016-11-11 11:23:38 +00:00
Legality Checking for Hyper Training
2016-11-11 10:31:50 +00:00
if (IVs.All(iv => iv == 31) && HTs.Any(ht => ht))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V41, CheckIdentifier.IVs);
Legality Checking for Hyper Training
2016-11-11 10:31:50 +00:00
else
{
for (int i = 0; i < 6; i++) // Check individual IVs
{
if ((IVs[i] == 31) && HTs[i])
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V42, CheckIdentifier.IVs);
Legality Checking for Hyper Training
2016-11-11 10:31:50 +00:00
}
}
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#region verifyEncounter
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
private void verifyFormFriendSafari()
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
{
static analysis fixes fixes the friend safari form checks (if else were chained incorrectly) argumentorder of some unused sections (BV date, canlearnmachinemove)
2017-03-20 07:03:31 +00:00
switch (pkm.Species)
{
case 670: // Floette
case 671: // Florges
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (!new[] { 0, 1, 3 }.Contains(pkm.AltForm)) // 0/1/3 - RBY
AddLine(Severity.Invalid, V64, CheckIdentifier.Form);
static analysis fixes fixes the friend safari form checks (if else were chained incorrectly) argumentorder of some unused sections (BV date, canlearnmachinemove)
2017-03-20 07:03:31 +00:00
break;
case 710: // Pumpkaboo
case 711: // Goregeist
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
if (pkm.AltForm != 0) // Average
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
AddLine(Severity.Invalid, V6, CheckIdentifier.Form);
static analysis fixes fixes the friend safari form checks (if else were chained incorrectly) argumentorder of some unused sections (BV date, canlearnmachinemove)
2017-03-20 07:03:31 +00:00
break;
case 586: // Sawsbuck
if (pkm.AltForm != 0)
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
AddLine(Severity.Invalid, V65, CheckIdentifier.Form);
static analysis fixes fixes the friend safari form checks (if else were chained incorrectly) argumentorder of some unused sections (BV date, canlearnmachinemove)
2017-03-20 07:03:31 +00:00
break;
}
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
}
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
private void verifyEncounterType()
{
Refactoring r2 Don't calculate suggested moves until prompted Don't check EncounterType for gen7 pkm (no field to check)
2017-04-23 04:00:06 +00:00
if (pkm.Format >= 7)
return;
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
if (!Encounter.Valid)
return;
Refactoring Simplify EncounterStatic type check as it is gen4 specific -> gen4 specific child class Checks.cs: Move transfer legality check back to end as Gen4Result needs to be defined (not null) Rename EncounterType of Analysis class to avoid conflict with the EncounterType enum
2017-04-22 20:04:12 +00:00
EncounterType type = EncounterType.None;
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
// Encounter type data is only stored for gen 4 encounters
4->5/6 transfer encountertype preference fix Add a preference check when appropriate so that invalid encounter types are not preferred over the wild encounters that may follow. Closes #1095
2017-05-11 01:52:14 +00:00
// Gen 6 -> 7 transfer deletes encounter type data
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
// All eggs have encounter type none, even if they are from static encounters
Refactoring r2 Don't calculate suggested moves until prompted Don't check EncounterType for gen7 pkm (no field to check)
2017-04-23 04:00:06 +00:00
if (pkm.Gen4 && !pkm.WasEgg)
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterSlot w)
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
// If there is more than one slot, the get wild encounter have filter for the pkm type encounter like safari/sports ball
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
type = w.TypeEncounter;
if (EncounterMatch is EncounterStaticTyped s)
type = s.TypeEncounter;
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
}
Refactoring r2 Don't calculate suggested moves until prompted Don't check EncounterType for gen7 pkm (no field to check)
2017-04-23 04:00:06 +00:00
Encounter Type fix and detection of pokemon that should have evolve on trade (#1105) * Detect encounter trades that evolve on trade and have not been evolved Detect generation 1 pokemon with special catch rates : krabby trade and Pokemon Stadium Detect generation 1 pokemon that evolve on trade and have been traded but not evolved Detect pokemon with tradeback status any but with only encounters from the other GB generation, that means they are WasTradeback Detect pokemon with moves from the other GB generation, change tradebackstatus to WasTradeback * Fix dppt surfing and fishing encounter type, is is surfing because the battle background is the same as other surfingfishing encounters Fix headbutt encounter type, the encounter type depends on the battle background used when battle a pokemon, for headbutt it changes with the player tile, is the player is in a city it will be building encounter, in a grass tile tall grass, in water it is surfingfishing and cave inside a cave. Some locations have more than one possible encounter type, for example routes with trees near the grass, near the water and near non-combat tiles. Also added slot type headbutt special for the special trees, those trees are all in routes and are only adjacent to non-combat tiles * Fix encounter type for missing areas with multiple grass encounters types: Mt Coronet, Mt Silver Cave and Stark Mountain (Issue # 1095) * Fixes and typos * Check for non-japanese e-reader pokemon, is unreleased
2017-05-01 15:07:20 +00:00
if (!type.Contains(pkm.EncounterType))
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
AddLine(Severity.Invalid, V381, CheckIdentifier.Encounter);
Refactoring r2 Don't calculate suggested moves until prompted Don't check EncounterType for gen7 pkm (no field to check)
2017-04-23 04:00:06 +00:00
else
AddLine(Severity.Valid, V380, CheckIdentifier.Encounter);
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
}
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
private void verifyTransferLegalityG3()
verifyEncounterG3Transfer function For gen 3 transfer pokemon it checks the non egg possible encounter and if the pokemon could have been hatched egg encounter Return the result from one of the two encounters that is valid, with non egg preference but marking WasEgg a True if it can be from an egg In verify moves both possible encounters are considered, there is no way to discart one or another
2017-03-26 22:37:56 +00:00
{
Cleanup refactor out the encounter trade screening; fixes the IV check loop (the continue continued the for loop not the foreach). Similar approach can be applied later for the encounterstatic checks if it is to be converted to ienumerable (in which a secondary screen may be necessary)
2017-03-31 07:04:29 +00:00
if (pkm.Format == 4 && pkm.Met_Location != 0x37) // Pal Park
AddLine(Severity.Invalid, V60, CheckIdentifier.Encounter);
if (pkm.Format != 4 && pkm.Met_Location != 30001)
AddLine(Severity.Invalid, V61, CheckIdentifier.Encounter);
verifyEncounterG3Transfer function For gen 3 transfer pokemon it checks the non egg possible encounter and if the pokemon could have been hatched egg encounter Return the result from one of the two encounters that is valid, with non egg preference but marking WasEgg a True if it can be from an egg In verify moves both possible encounters are considered, there is no way to discart one or another
2017-03-26 22:37:56 +00:00
}
Fix error in transfer legality G4. Transfer legality is not checked if the pokemon is a valid static encounter, also an Entei with invalid encounter is returning null as check encounter making the analysis to throw an exception, reported in the forum. Instead check transfer legality and do not return checkresult until the end to add invalid values if Gen4Result is null.
2017-04-25 00:42:15 +00:00
private void verifyTransferLegalityG4()
{
// Transfer Legality
int loc = pkm.Met_Location;
if (loc != 30001) // PokéTransfer
{
// Crown
switch (pkm.Species)
{
case 251: // Celebi
if (loc != 30010 && loc != 30011) // unused || used
AddLine(Severity.Invalid, V351, CheckIdentifier.Encounter);
break;
case 243: // Raikou
case 244: // Entei
case 245: // Suicune
if (loc != 30012 && loc != 30013) // unused || used
AddLine(Severity.Invalid, V351, CheckIdentifier.Encounter);
break;
default:
AddLine(Severity.Invalid, V61, CheckIdentifier.Encounter);
break;
}
}
}
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
private static IEnumerable<CheckResult> verifyVCEncounter(PKM pkm, int baseSpecies, GBEncounterData encounter)
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
{
// Sanitize Species to non-future species#
int species = pkm.Species;
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (pkm.VC1 && species > Legal.MaxSpeciesID_1 ||
pkm.VC2 && species > Legal.MaxSpeciesID_2)
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
species = baseSpecies;
Tweak gen1+transfer checking Add stadium exclusives (surfchu / amnesiaduck) which are flagged on gen7
2017-02-14 02:06:01 +00:00
// Check existing EncounterMatch
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (encounter == null)
yield break; // Avoid duplicate invaild message
Further tweaks Handle terminated strings better for 1->7 Indicate RBY encounter origins when transferred to 7+. Remove check duplication
2017-02-15 06:06:15 +00:00
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (encounter.Encounter is EncounterStatic v && (GameVersion.GBCartEraOnly.Contains(v.Version) || v.Version == GameVersion.VCEvents))
Further tweaks Handle terminated strings better for 1->7 Indicate RBY encounter origins when transferred to 7+. Remove check duplication
2017-02-15 06:06:15 +00:00
{
bool exceptions = false;
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
exceptions |= v.Version == GameVersion.VCEvents && baseSpecies == 151 && pkm.TID == 22796;
Further tweaks Handle terminated strings better for 1->7 Indicate RBY encounter origins when transferred to 7+. Remove check duplication
2017-02-15 06:06:15 +00:00
if (!exceptions)
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
yield return new CheckResult(Severity.Invalid, V79, CheckIdentifier.Encounter);
Further tweaks Handle terminated strings better for 1->7 Indicate RBY encounter origins when transferred to 7+. Remove check duplication
2017-02-15 06:06:15 +00:00
}
Add gen1->gen7 IV legality check Also fix gen1/2 evo tree trimming error, thanks BeyondTheHorizon! Also fix an exception when no static encounter can be generated for 1->7, match is now generated by checking gen1 and reusing the static encounter creation info (now moved to core).
2017-03-10 04:27:03 +00:00
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
var ematch = EncounterGenerator.getRBYStaticTransfer(species);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
if (pkm.Met_Location != ematch.Location)
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
yield return new CheckResult(Severity.Invalid, V81, CheckIdentifier.Encounter);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
if (pkm.Egg_Location != ematch.EggLocation)
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
yield return new CheckResult(Severity.Invalid, V59, CheckIdentifier.Encounter);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
Add trophy garden encounters (dppt) Refactor addExtraTableSlots to instead combine encounter tables slightly faster due to not repeating the where comparison and over multiple calls select all tables from array -> group by location -> combine slots if many tables -> return combined array fixes transferred 4->5 event met level check
2017-03-26 08:25:21 +00:00
if (species == 150 && pkm.Moves.Contains(6)) // pay day
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
yield return new CheckResult(Severity.Invalid, V82, CheckIdentifier.Encounter);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#endregion
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private void verifyLevel()
Add level check Met level > Current Level
2016-03-19 05:49:21 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
MysteryGift MatchedGift = EncounterMatch as MysteryGift;
if (MatchedGift != null && MatchedGift.Level != pkm.Met_Level)
{
Add trophy garden encounters (dppt) Refactor addExtraTableSlots to instead combine encounter tables slightly faster due to not repeating the where comparison and over multiple calls select all tables from array -> group by location -> combine slots if many tables -> return combined array fixes transferred 4->5 event met level check
2017-03-26 08:25:21 +00:00
if (pkm.HasOriginalMetLocation && (!(MatchedGift is WC7) || ((WC7) MatchedGift).MetLevel != pkm.Met_Level))
Misc event legality updates They're finally using metlevel
2016-11-13 23:40:34 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(new CheckResult(Severity.Invalid, V83, CheckIdentifier.Level));
Misc event legality updates They're finally using metlevel
2016-11-13 23:40:34 +00:00
return;
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
}
Add greninja variable PID edge case game programmer should have used the nonshiny mode option instead of randomly coming up with a PID closes #458 added missing gift check for level (was 'deferred' but never implemented)
2016-12-12 01:13:59 +00:00
if (MatchedGift != null && MatchedGift.Level > pkm.CurrentLevel)
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(new CheckResult(Severity.Invalid, V84, CheckIdentifier.Level));
Add greninja variable PID edge case game programmer should have used the nonshiny mode option instead of randomly coming up with a PID closes #458 added missing gift check for level (was 'deferred' but never implemented)
2016-12-12 01:13:59 +00:00
return;
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
int lvl = pkm.CurrentLevel;
Start recognizing some gen3 encounters Add overrides for detecting encounter type Will need to come up with something more intelligent for when this met location info is lost on transfer. Probably some re-parse guessing like was done for Gen1/2. Fix hitmonlee/chan level Noticed that Aerodacytl is met at level 5 with current level 30; will have to figure out a way to work around Current!=Met level
2017-03-19 23:52:56 +00:00
if (pkm.IsEgg)
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
int elvl = pkm.Format <= 3 ? 5 : 1;
if (elvl != lvl)
AddLine(Severity.Invalid, string.Format(V52, elvl), CheckIdentifier.Level);
Start recognizing some gen3 encounters Add overrides for detecting encounter type Will need to come up with something more intelligent for when this met location info is lost on transfer. Probably some re-parse guessing like was done for Gen1/2. Fix hitmonlee/chan level Noticed that Aerodacytl is met at level 5 with current level 30; will have to figure out a way to work around Current!=Met level
2017-03-19 23:52:56 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else if (lvl < pkm.Met_Level)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V85, CheckIdentifier.Level);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else if (lvl > pkm.Met_Level && lvl > 1 && lvl != 100 && pkm.EXP == PKX.getEXP(pkm.Stat_Level, pkm.Species))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V87, CheckIdentifier.Level);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V88, CheckIdentifier.Level);
Encounter Type fix and detection of pokemon that should have evolve on trade (#1105) * Detect encounter trades that evolve on trade and have not been evolved Detect generation 1 pokemon with special catch rates : krabby trade and Pokemon Stadium Detect generation 1 pokemon that evolve on trade and have been traded but not evolved Detect pokemon with tradeback status any but with only encounters from the other GB generation, that means they are WasTradeback Detect pokemon with moves from the other GB generation, change tradebackstatus to WasTradeback * Fix dppt surfing and fishing encounter type, is is surfing because the battle background is the same as other surfingfishing encounters Fix headbutt encounter type, the encounter type depends on the battle background used when battle a pokemon, for headbutt it changes with the player tile, is the player is in a city it will be building encounter, in a grass tile tall grass, in water it is surfingfishing and cave inside a cave. Some locations have more than one possible encounter type, for example routes with trees near the grass, near the water and near non-combat tiles. Also added slot type headbutt special for the special trees, those trees are all in routes and are only adjacent to non-combat tiles * Fix encounter type for missing areas with multiple grass encounters types: Mt Coronet, Mt Silver Cave and Stark Mountain (Issue # 1095) * Fixes and typos * Check for non-japanese e-reader pokemon, is unreleased
2017-05-01 15:07:20 +00:00
slight tweaks reduce nesting, formatting; no functional change
2017-05-01 15:25:20 +00:00
// There is no way to prevent a gen1 trade evolution as held items (everstone) did not exist.
// Machoke, Graveler, Haunter and Kadabra captured in the second phase evolution, excluding in-game trades, are already checked
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (pkm.Format <= 2 && Type != typeof (EncounterTrade) && EncounterMatch.Species == pkm.Species && Legal.Trade_Evolution1.Contains(EncounterMatch.Species))
slight tweaks reduce nesting, formatting; no functional change
2017-05-01 15:25:20 +00:00
verifyG1TradeEvo();
}
private void verifyG1TradeEvo()
{
var mustevolve = pkm.TradebackStatus == TradebackType.WasTradeback || (pkm.Format == 1 && Legal.IsOutsider(pkm));
if (!mustevolve)
return;
// Pokemon have been traded but it is not evolved, trade evos are sequential dex numbers
var unevolved = specieslist[pkm.Species];
var evolved = specieslist[pkm.Species + 1];
AddLine(Severity.Invalid, string.Format(V405, unevolved, evolved), CheckIdentifier.Level);
Add level check Met level > Current Level
2016-03-19 05:49:21 +00:00
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#region verifyMedals
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
private void verifyMedals()
{
if (pkm.Format < 6)
return;
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
verifyMedalsRegular();
verifyMedalsEvent();
}
private void verifyMedalsRegular()
{
Remove reflection for super training checks Offset is constant, just interpret the raw data instead of the properties. speed++; Adds check for unused super training flags.
2017-04-15 19:22:29 +00:00
uint data = BitConverter.ToUInt32(pkm.Data, 0x2C);
if ((data & 3) != 0) // 2 unused flags
AddLine(Severity.Invalid, V98, CheckIdentifier.Training);
int TrainCount = 0;
data >>= 2;
for (int i = 2; i < 32; i++)
{
if ((data & 1) != 0)
TrainCount++;
data >>= 1;
}
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
if (pkm.IsEgg && TrainCount > 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Invalid, V89, CheckIdentifier.Training); }
else if (TrainCount > 0 && pkm.GenNumber > 6)
{ AddLine(Severity.Invalid, V90, CheckIdentifier.Training); }
Update cleared data legality checks Add in a few more, a little bit of shuffling
2017-01-25 17:17:20 +00:00
else
{
if (pkm.Format >= 7)
{
if (pkm.SecretSuperTrainingUnlocked)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Invalid, V91, CheckIdentifier.Training); }
Update cleared data legality checks Add in a few more, a little bit of shuffling
2017-01-25 17:17:20 +00:00
if (pkm.SecretSuperTrainingComplete)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Invalid, V92, CheckIdentifier.Training); }
Update cleared data legality checks Add in a few more, a little bit of shuffling
2017-01-25 17:17:20 +00:00
}
else
{
if (TrainCount == 30 ^ pkm.SecretSuperTrainingComplete)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Invalid, V93, CheckIdentifier.Training); }
Update cleared data legality checks Add in a few more, a little bit of shuffling
2017-01-25 17:17:20 +00:00
}
}
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
}
private void verifyMedalsEvent()
{
Remove reflection for super training checks Offset is constant, just interpret the raw data instead of the properties. speed++; Adds check for unused super training flags.
2017-04-15 19:22:29 +00:00
byte data = pkm.Data[0x3A];
if ((data & 0xC0) != 0) // 2 unused flags highest bits
AddLine(Severity.Invalid, V98, CheckIdentifier.Training);
int TrainCount = 0;
for (int i = 0; i < 6; i++)
{
if ((data & 1) != 0)
TrainCount++;
data >>= 1;
}
if (pkm.IsEgg && TrainCount > 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Invalid, V89, CheckIdentifier.Training); }
Remove reflection for super training checks Offset is constant, just interpret the raw data instead of the properties. speed++; Adds check for unused super training flags.
2017-04-15 19:22:29 +00:00
else if (TrainCount > 0 && pkm.GenNumber > 6)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Invalid, V90, CheckIdentifier.Training); }
Remove reflection for super training checks Offset is constant, just interpret the raw data instead of the properties. speed++; Adds check for unused super training flags.
2017-04-15 19:22:29 +00:00
else if (TrainCount > 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Fishy, V94, CheckIdentifier.Training); }
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#endregion
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private void verifyRibbons()
Add ribbon legality check
2016-03-20 22:20:11 +00:00
{
if (!Encounter.Valid)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
9/18/16 - New Update Changelog, shortcut list, version, and wc6db updated. Slide in a legality check for super training.
2016-09-17 19:21:23 +00:00
Add ribbon legality check
2016-03-20 22:20:11 +00:00
List<string> missingRibbons = new List<string>();
List<string> invalidRibbons = new List<string>();
Add Egg & Super Training legality checks Closes #220 Thanks @sora10pls !
2016-09-03 15:10:22 +00:00
Update gift egg ribbon checking Closes #1074 Check ribbons for the gift, then check for all ribbons except the ones already checked. Refactored out the ribbonset checking methods
2017-04-18 02:11:01 +00:00
// Check Event Ribbons
var encounterContent = (EncounterMatch as MysteryGift)?.Content ?? EncounterMatch;
var set1 = pkm as IRibbonSet1;
var set2 = pkm as IRibbonSet2;
if (set1 != null)
verifyRibbonSet1(set1, encounterContent, missingRibbons, invalidRibbons);
if (set2 != null)
verifyRibbonSet2(set2, encounterContent, missingRibbons, invalidRibbons);
// Check Unobtainable Ribbons
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.IsEgg)
Add Egg & Super Training legality checks Closes #220 Thanks @sora10pls !
2016-09-03 15:10:22 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
var RibbonNames = ReflectUtil.getPropertiesStartWithPrefix(pkm.GetType(), "Ribbon");
Update gift egg ribbon checking Closes #1074 Check ribbons for the gift, then check for all ribbons except the ones already checked. Refactored out the ribbonset checking methods
2017-04-18 02:11:01 +00:00
if (set1 != null)
RibbonNames = RibbonNames.Except(RibbonSetHelper.getRibbonNames(set1));
if (set2 != null)
RibbonNames = RibbonNames.Except(RibbonSetHelper.getRibbonNames(set2));
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
foreach (object RibbonValue in RibbonNames.Select(RibbonName => ReflectUtil.GetValue(pkm, RibbonName)))
Add Egg & Super Training legality checks Closes #220 Thanks @sora10pls !
2016-09-03 15:10:22 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (RibbonValue as bool? == true) // Boolean
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Invalid, V95, CheckIdentifier.Ribbon); return; }
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if ((RibbonValue as int?) > 0) // Count
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Invalid, V95, CheckIdentifier.Ribbon); return; }
Add Egg & Super Training legality checks Closes #220 Thanks @sora10pls !
2016-09-03 15:10:22 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add Egg & Super Training legality checks Closes #220 Thanks @sora10pls !
2016-09-03 15:10:22 +00:00
}
Add ribbon legality check
2016-03-20 22:20:11 +00:00
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
// Unobtainable ribbons for Gen Origin
if (pkm.GenNumber > 3)
{
Misc update Remove 2 sun SOS evo chain hidden ability bans - closes #629 update shortcuts list update unobtainable ribbon checks for gen3; switch to nameof as well
2016-12-11 18:30:41 +00:00
if (ReflectUtil.getBooleanState(pkm, nameof(PK3.RibbonChampionG3Hoenn)) == true)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
invalidRibbons.Add(V96); // RSE HoF
Misc update Remove 2 sun SOS evo chain hidden ability bans - closes #629 update shortcuts list update unobtainable ribbon checks for gen3; switch to nameof as well
2016-12-11 18:30:41 +00:00
if (ReflectUtil.getBooleanState(pkm, nameof(PK3.RibbonArtist)) == true)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
invalidRibbons.Add(V97); // RSE Master Rank Portrait
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
}
Update gift egg ribbon checking Closes #1074 Check ribbons for the gift, then check for all ribbons except the ones already checked. Refactored out the ribbonset checking methods
2017-04-18 02:11:01 +00:00
if (pkm.Format >= 4 && pkm.GenNumber > 4)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Misc update Remove 2 sun SOS evo chain hidden ability bans - closes #629 update shortcuts list update unobtainable ribbon checks for gen3; switch to nameof as well
2016-12-11 18:30:41 +00:00
if (ReflectUtil.getBooleanState(pkm, nameof(PK4.RibbonChampionSinnoh)) == true)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
invalidRibbons.Add(V99); // DPPt HoF
Misc update Remove 2 sun SOS evo chain hidden ability bans - closes #629 update shortcuts list update unobtainable ribbon checks for gen3; switch to nameof as well
2016-12-11 18:30:41 +00:00
if (ReflectUtil.getBooleanState(pkm, nameof(PK4.RibbonLegend)) == true)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
invalidRibbons.Add(V100); // HGSS Defeat Red @ Mt.Silver
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
}
if (pkm.Format >= 6 && pkm.GenNumber >= 6)
{
Misc update Remove 2 sun SOS evo chain hidden ability bans - closes #629 update shortcuts list update unobtainable ribbon checks for gen3; switch to nameof as well
2016-12-11 18:30:41 +00:00
if (ReflectUtil.getBooleanState(pkm, nameof(PK6.RibbonCountMemoryContest)) == true)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
invalidRibbons.Add(V106); // Gen3/4 Contest
Misc update Remove 2 sun SOS evo chain hidden ability bans - closes #629 update shortcuts list update unobtainable ribbon checks for gen3; switch to nameof as well
2016-12-11 18:30:41 +00:00
if (ReflectUtil.getBooleanState(pkm, nameof(PK6.RibbonCountMemoryBattle)) == true)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
invalidRibbons.Add(V105); // Gen3/4 Battle
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
}
Misc update Remove 2 sun SOS evo chain hidden ability bans - closes #629 update shortcuts list update unobtainable ribbon checks for gen3; switch to nameof as well
2016-12-11 18:30:41 +00:00
if (ReflectUtil.getBooleanState(pkm, nameof(PK6.RibbonRecord)) == true)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
invalidRibbons.Add(V104); // Unobtainable
Add ribbon legality check
2016-03-20 22:20:11 +00:00
if (missingRibbons.Count + invalidRibbons.Count == 0)
Add Egg & Super Training legality checks Closes #220 Thanks @sora10pls !
2016-09-03 15:10:22 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V103, CheckIdentifier.Ribbon);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add Egg & Super Training legality checks Closes #220 Thanks @sora10pls !
2016-09-03 15:10:22 +00:00
}
Add ribbon legality check
2016-03-20 22:20:11 +00:00
string[] result = new string[2];
if (missingRibbons.Count > 0)
Tuck event ribbons behind interface Reduces amount of reflection per legality check (faster checks!), can be expressed a little clearer now with a bool array loop comparison. Closes #1061
2017-04-15 08:20:29 +00:00
result[0] = string.Format(V101, string.Join(", ", missingRibbons.Select(z => z.Replace("Ribbon", ""))));
Add ribbon legality check
2016-03-20 22:20:11 +00:00
if (invalidRibbons.Count > 0)
Tuck event ribbons behind interface Reduces amount of reflection per legality check (faster checks!), can be expressed a little clearer now with a bool array loop comparison. Closes #1061
2017-04-15 08:20:29 +00:00
result[1] = string.Format(V102, string.Join(", ", invalidRibbons.Select(z => z.Replace("Ribbon", ""))));
Refactoring Pre 3-5 moving of useful arrays Reduce footprint of unpackMini (was taking 88ms, now <1us)
2017-03-17 06:16:11 +00:00
AddLine(Severity.Invalid, string.Join(Environment.NewLine, result.Where(s => !string.IsNullOrEmpty(s))), CheckIdentifier.Ribbon);
Add ribbon legality check
2016-03-20 22:20:11 +00:00
}
Update gift egg ribbon checking Closes #1074 Check ribbons for the gift, then check for all ribbons except the ones already checked. Refactored out the ribbonset checking methods
2017-04-18 02:11:01 +00:00
private void verifyRibbonSet1(IRibbonSet1 set1, object encounterContent, List<string> missingRibbons, List<string> invalidRibbons)
{
var names = RibbonSetHelper.getRibbonNames(set1);
var sb = RibbonSetHelper.getRibbonBits(set1);
var eb = RibbonSetHelper.getRibbonBits(encounterContent as IRibbonSet1);
if (pkm.Gen3)
Add C/XD specific checks Pokespot: a given PID will satisfy ~37% of the time, flag pokespot encounters I can see hatching eggs being a problem, no idea how this would work
2017-04-30 23:53:54 +00:00
{
Update gift egg ribbon checking Closes #1074 Check ribbons for the gift, then check for all ribbons except the ones already checked. Refactored out the ribbonset checking methods
2017-04-18 02:11:01 +00:00
eb[0] = sb[0]; // permit Earth Ribbon
Add gen3 force shiny event PIDIV detection matches for berry fix zigzagoon use correct type comparison for checking if national ribbon is to be set or not; change XDC to CXD for parity with other references
2017-05-01 05:11:51 +00:00
if (pkm.Version == 15 && MatchedType == typeof(EncounterStaticShadow)) // only require national ribbon if no longer on C/XD
Add C/XD specific checks Pokespot: a given PID will satisfy ~37% of the time, flag pokespot encounters I can see hatching eggs being a problem, no idea how this would work
2017-04-30 23:53:54 +00:00
eb[1] = (pkm as CK3)?.RibbonNational ?? (pkm as XK3)?.RibbonNational ?? true;
}
Update gift egg ribbon checking Closes #1074 Check ribbons for the gift, then check for all ribbons except the ones already checked. Refactored out the ribbonset checking methods
2017-04-18 02:11:01 +00:00
for (int i = 0; i < sb.Length; i++)
if (sb[i] != eb[i])
(eb[i] ? missingRibbons : invalidRibbons).Add(names[i]);
}
private void verifyRibbonSet2(IRibbonSet2 set2, object encounterContent, List<string> missingRibbons, List<string> invalidRibbons)
{
var names = RibbonSetHelper.getRibbonNames(set2);
var sb = RibbonSetHelper.getRibbonBits(set2);
var eb = RibbonSetHelper.getRibbonBits(encounterContent as IRibbonSet2);
if (EncounterMatch is EncounterLink)
eb[0] = true; // require Classic Ribbon
if ((EncounterMatch as EncounterStatic)?.RibbonWishing ?? false)
eb[1] = true; // require Wishing Ribbon
for (int i = 0; i < sb.Length; i++)
if (sb[i] != eb[i])
(eb[i] ? missingRibbons : invalidRibbons).Add(names[i]);
}
Add C/XD specific checks Pokespot: a given PID will satisfy ~37% of the time, flag pokespot encounters I can see hatching eggs being a problem, no idea how this would work
2017-04-30 23:53:54 +00:00
private void verifyCXD()
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterSlot w) // pokespot
Add C/XD specific checks Pokespot: a given PID will satisfy ~37% of the time, flag pokespot encounters I can see hatching eggs being a problem, no idea how this would work
2017-04-30 23:53:54 +00:00
{
// find origin info, if nothing returned then the PID is unobtainable
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
var slot = w.SlotNumber;
Add C/XD specific checks Pokespot: a given PID will satisfy ~37% of the time, flag pokespot encounters I can see hatching eggs being a problem, no idea how this would work
2017-04-30 23:53:54 +00:00
var pidiv = MethodFinder.getPokeSpotSeeds(pkm, slot);
if (!pidiv.Any())
AddLine(Severity.Invalid, V400, CheckIdentifier.PID);
}
else if (Type == typeof (EncounterStatic))
{
Add cxd starter TID/SID correlation check
2017-05-11 07:32:31 +00:00
var pidiv = MethodFinder.Analyze(pkm);
if (pidiv == null || pidiv.Type != PIDType.CXD)
AddLine(Severity.Invalid, V400, CheckIdentifier.PID);
Flag any cxd origin with bad pidiv
2017-05-13 07:03:35 +00:00
else // Starters have a correlation to the Trainer ID numbers
verifyCXDStarterCorrelation(pidiv);
Add C/XD specific checks Pokespot: a given PID will satisfy ~37% of the time, flag pokespot encounters I can see hatching eggs being a problem, no idea how this would work
2017-04-30 23:53:54 +00:00
}
Handle CXD egg encounters There are none. But the detection routine for gen3 can assign cxd pkm as egg if no other possible encounter is matched, thus we'll flag if the failure case occurs. add missing spacing formatting, simplify break->return for egg game retrieval
2017-05-03 02:08:16 +00:00
else if (pkm.WasEgg) // can't obtain eggs in CXD
{
AddLine(Severity.Invalid, V80, CheckIdentifier.Encounter); // invalid encounter
}
Add C/XD specific checks Pokespot: a given PID will satisfy ~37% of the time, flag pokespot encounters I can see hatching eggs being a problem, no idea how this would work
2017-04-30 23:53:54 +00:00
}
Flag any cxd origin with bad pidiv
2017-05-13 07:03:35 +00:00
private void verifyCXDStarterCorrelation(PIDIV pidiv)
{
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
var spec = EncounterMatch.Species;
unroll cxd seed completely re-letter for clearer order of RNG results, don't unroll 3x to roll forward 2x (just unroll 1,1 then 1). Put origin seed in RNG Reporter => frame 1 result Closes #1169
2017-05-28 05:18:04 +00:00
int rev; // pidiv reversed 2x yields SID, 3x yields TID. shift by 7 if another PKM is generated prior
Flag any cxd origin with bad pidiv
2017-05-13 07:03:35 +00:00
switch (spec)
{
// XD
case 133: // Eevee
unroll cxd seed completely re-letter for clearer order of RNG results, don't unroll 3x to roll forward 2x (just unroll 1,1 then 1). Put origin seed in RNG Reporter => frame 1 result Closes #1169
2017-05-28 05:18:04 +00:00
rev = 2;
Flag any cxd origin with bad pidiv
2017-05-13 07:03:35 +00:00
break;
// Colosseum
case 197: // Umbreon (generated before Espeon)
unroll cxd seed completely re-letter for clearer order of RNG results, don't unroll 3x to roll forward 2x (just unroll 1,1 then 1). Put origin seed in RNG Reporter => frame 1 result Closes #1169
2017-05-28 05:18:04 +00:00
rev = 2;
Flag any cxd origin with bad pidiv
2017-05-13 07:03:35 +00:00
break;
case 196: // Espeon (generated after Umbreon)
unroll cxd seed completely re-letter for clearer order of RNG results, don't unroll 3x to roll forward 2x (just unroll 1,1 then 1). Put origin seed in RNG Reporter => frame 1 result Closes #1169
2017-05-28 05:18:04 +00:00
rev = 2+7;
Flag any cxd origin with bad pidiv
2017-05-13 07:03:35 +00:00
break;
default:
return;
}
var seed = pidiv.OriginSeed;
var SIDf = pidiv.RNG.Reverse(seed, rev);
var TIDf = pidiv.RNG.Prev(SIDf);
if (SIDf >> 16 != pkm.SID || TIDf >> 16 != pkm.TID)
AddLine(Severity.Invalid, V400, CheckIdentifier.PID);
}
Add C/XD specific checks Pokespot: a given PID will satisfy ~37% of the time, flag pokespot encounters I can see hatching eggs being a problem, no idea how this would work
2017-04-30 23:53:54 +00:00
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private void verifyAbility()
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
{
Personal Table per PKM Not by AO only (now works for species > 721)
2016-10-29 06:41:22 +00:00
int[] abilities = pkm.PersonalInfo.Abilities;
Fix egg move gen6+ requirement for relearnmoves Thanks TJGameplay!
2017-03-18 23:17:42 +00:00
if (abilities[1] == 0)
abilities[1] = abilities[0];
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
int abilval = Array.IndexOf(abilities, pkm.Ability);
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
if (abilval < 0)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V107, CheckIdentifier.Ability);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
bool? AbilityUnchanged = true;
// 3 states flag: true for unchanged, false for changed, null for uncertain/allowing PID mismatch
// if true, check encounter ability
// if true or false, check PID/AbilityNumber
if (3 <= pkm.Format && pkm.Format <= 5 && abilities[0] != abilities[1]) // 3-5 and have 2 distinct ability now
AbilityUnchanged = verifyAbilityPreCapsule(abilities, abilval);
if (EncounterMatch != null)
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
{
Misc fixes & Some tweaks for legality check (#1044) * Add gen3-6 unreleased items * Fix string converter fix traditional chinese char offset fix out-of-range crash * Fix ivs and ability check for VC transfer Refetch the static enconter for VC transfer after moves checks update legality string translation impl non-HA ability matching * Add ivs legality check for wc gift
2017-04-10 04:59:44 +00:00
// Check Ability Mismatches
int? EncounterAbility = (EncounterMatch as EncounterStatic)?.Ability ??
(EncounterMatch as EncounterTrade)?.Ability ??
(EncounterMatch as EncounterLink)?.Ability;
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
Add hidden ability mismatch check for fixed abils minor refactoring remove GameVersion.Pt unreachable code for eggmoves
2017-05-09 03:35:06 +00:00
if (EncounterAbility != null && verifySetAbility(EncounterAbility, AbilityUnchanged, abilities, abilval))
return; // result added via verifySetAbility
Misc fixes & Some tweaks for legality check (#1044) * Add gen3-6 unreleased items * Fix string converter fix traditional chinese char offset fix out-of-range crash * Fix ivs and ability check for VC transfer Refetch the static enconter for VC transfer after moves checks update legality string translation impl non-HA ability matching * Add ivs legality check for wc gift
2017-04-10 04:59:44 +00:00
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
switch (pkm.GenNumber)
Add Hidden Grotto Ability checking
2017-03-22 23:47:14 +00:00
{
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
case 5: verifyAbility5(abilities); break;
case 6: verifyAbility6(abilities); break;
case 7: verifyAbility7(abilities); break;
DexNav Hidden Ability Thanks Wanderer1391!
2016-03-31 02:55:27 +00:00
}
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
}
Add Ingame Trade ability, chk Fix Egg Ball chk Missed the return at the end
2016-03-22 04:50:39 +00:00
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
if (3 <= pkm.GenNumber && pkm.GenNumber <= 4 && pkm.AbilityNumber == 4)
AddLine(Severity.Invalid, V112, CheckIdentifier.Ability);
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
else if (AbilityUnchanged != null && abilities[pkm.AbilityNumber >> 1] != pkm.Ability)
AddLine(Severity.Invalid, pkm.Format < 6 ? V113 : V114, CheckIdentifier.Ability);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
AddLine(Severity.Valid, V115, CheckIdentifier.Ability);
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
}
Add hidden ability mismatch check for fixed abils minor refactoring remove GameVersion.Pt unreachable code for eggmoves
2017-05-09 03:35:06 +00:00
private bool verifySetAbility(int? EncounterAbility, bool? AbilityUnchanged, int[] abilities, int abilval)
{
if (pkm.AbilityNumber == 4 && EncounterAbility != 4)
{
AddLine(Severity.Invalid, V108, CheckIdentifier.Ability);
return true;
}
if (!(AbilityUnchanged ?? false) || EncounterAbility == 0 || pkm.AbilityNumber == EncounterAbility)
return false;
Update encountertrade ability legality check check for encountertrade edge case first, then ability capsule Closes #1163
2017-05-24 03:10:57 +00:00
if (EncounterMatch is EncounterTrade z && EncounterAbility == 1 << abilval && z.Species == pkm.Species) // Edge case (Static PID?)
Add hidden ability mismatch check for fixed abils minor refactoring remove GameVersion.Pt unreachable code for eggmoves
2017-05-09 03:35:06 +00:00
AddLine(Severity.Valid, V115, CheckIdentifier.Ability);
Update encountertrade ability legality check check for encountertrade edge case first, then ability capsule Closes #1163
2017-05-24 03:10:57 +00:00
else if (pkm.Format >= 6 && abilities[0] != abilities[1] && pkm.AbilityNumber < 4) // Ability Capsule
AddLine(Severity.Valid, V109, CheckIdentifier.Ability);
Add hidden ability mismatch check for fixed abils minor refactoring remove GameVersion.Pt unreachable code for eggmoves
2017-05-09 03:35:06 +00:00
else
AddLine(Severity.Invalid, V223, CheckIdentifier.Ability);
return true;
}
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
private bool? verifyAbilityPreCapsule(int[] abilities, int abilval)
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
{
cleanup no functional change
2017-04-15 02:55:40 +00:00
// CXD pokemon could have any ability without maching PID
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
if (pkm.Version == (int)GameVersion.CXD && pkm.Format == 3)
return null;
// gen3 native or gen4/5 origin
if (pkm.Format == 3 || !pkm.InhabitedGeneration(3))
return true;
// Evovled in gen4/5
if (pkm.Species > Legal.MaxSpeciesID_3)
return false;
// gen3Species will be zero for pokemon with illegal gen 3 encounters, like Infernape with gen 3 "origin"
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
var gen3Species = info.EvoChainsAllGens[3].FirstOrDefault()?.Species ?? 0;
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
if (gen3Species == 0)
return true;
// Fall through when gen3 pkm transferred to gen4/5
return verifyAbilityGen3Transfer(abilities, abilval, gen3Species);
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
}
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
private bool? verifyAbilityGen3Transfer(int[] abilities, int abilval, int Species_g3)
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
{
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
var abilities_g3 = PersonalTable.E[Species_g3].Abilities.Where(a => a != 0).Distinct().ToArray();
Add hidden ability mismatch check for fixed abils minor refactoring remove GameVersion.Pt unreachable code for eggmoves
2017-05-09 03:35:06 +00:00
if (abilities_g3.Length == 2) // Excluding Colosseum/XD, a gen3 pkm must match PID if it has 2 unique abilities
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
return pkm.Version != (int)GameVersion.CXD;
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
int Species_g4 = info.EvoChainsAllGens[4].FirstOrDefault()?.Species ?? 0;
int Species_g5 = pkm.Format == 5 ? info.EvoChainsAllGens[5].FirstOrDefault()?.Species ?? 0 : 0;
Add hidden ability mismatch check for fixed abils minor refactoring remove GameVersion.Pt unreachable code for eggmoves
2017-05-09 03:35:06 +00:00
if (Math.Max(Species_g5, Species_g4) > Species_g3) // it has evolved in either gen 4 or gen 5; the ability must match PID
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
return false;
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
var Evolutions_g45 = Math.Max(info.EvoChainsAllGens[4].Length, pkm.Format == 5 ? info.EvoChainsAllGens[5].Length : 0);
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
if (Evolutions_g45 > 1)
{
// Evolutions_g45 > 1 and Species_g45 = Species_g3 with means both options, evolve in gen 4-5 or not evolve, are possible
if (pkm.Ability == abilities_g3[0])
// It could evolve in gen 4-5 an have generation 3 only ability
// that means it have not actually evolved in gen 4-5, ability do not need to match PID
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
return null;
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
if (pkm.Ability == abilities[1])
// It could evolve in gen4-5 an have generation 4 second ability
// that means it have actually evolved in gen 4-5, ability must match PID
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
return false;
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
}
// Evolutions_g45 == 1 means it have not evolved in gen 4-5 games,
// ability do not need to match PID, but only generation 3 ability is allowed
if (pkm.Ability != abilities_g3[0])
// Not evolved in gen4-5 but do not have generation 3 only ability
AddLine(Severity.Invalid, V373, CheckIdentifier.Ability);
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
return null;
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
}
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
private void verifyAbility5(int[] abilities)
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterSlot w)
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
{
// Hidden Abilities for Wild Encounters are only available at a Hidden Grotto
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
bool grotto = w.Type == SlotType.HiddenGrotto;
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
if (pkm.AbilityNumber == 4 ^ grotto)
AddLine(Severity.Invalid, grotto ? V217 : V108, CheckIdentifier.Ability);
}
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
else if (Type == typeof(MysteryGift))
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
verifyAbilityMG456(abilities, ((PGF)EncounterMatch).AbilityType);
}
private void verifyAbility6(int[] abilities)
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterSlot slot && pkm.AbilityNumber == 4)
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
bool valid = slot.DexNav || slot.Type == SlotType.FriendSafari || slot.Type == SlotType.Horde;
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
if (!valid)
AddLine(Severity.Invalid, V300, CheckIdentifier.Ability);
}
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
else if (Type == typeof(MysteryGift))
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
verifyAbilityMG456(abilities, ((WC6)EncounterMatch).AbilityType);
else if (Legal.Ban_NoHidden6.Contains(pkm.SpecForm) && pkm.AbilityNumber == 4)
AddLine(Severity.Invalid, V112, CheckIdentifier.Ability);
}
private void verifyAbility7(int[] abilities)
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterSlot slot && pkm.AbilityNumber == 4)
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
bool valid = slot.Type == SlotType.SOS;
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
if (!valid)
AddLine(Severity.Invalid, V111, CheckIdentifier.Ability);
}
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
else if (Type == typeof(MysteryGift))
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
verifyAbilityMG456(abilities, ((WC7)EncounterMatch).AbilityType);
else if (Legal.Ban_NoHidden7.Contains(pkm.SpecForm) && pkm.AbilityNumber == 4)
AddLine(Severity.Invalid, V112, CheckIdentifier.Ability);
}
private void verifyAbilityMG456(int[] abilities, int cardtype)
{
int abilNumber = pkm.AbilityNumber;
if (cardtype < 3 && abilNumber != 1 << cardtype) // set number
{
// Ability can be flipped 0/1 if Ability Capsule is available, is not Hidden Ability, and Abilities are different.
if (pkm.Format >= 6 && cardtype < 2 && abilNumber < 3 && abilities[0] != abilities[1])
AddLine(Severity.Valid, V109, CheckIdentifier.Ability);
else
AddLine(Severity.Invalid, V110, CheckIdentifier.Ability);
}
else if (cardtype == 3 && abilNumber == 4) // 1/2 only
AddLine(Severity.Invalid, V110, CheckIdentifier.Ability);
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#region verifyBall
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
private void verifyBallEquals(params int[] balls)
{
int ball = pkm.Ball;
if (balls.Any(b => b == ball))
AddLine(Severity.Valid, V119, CheckIdentifier.Ball);
else
AddLine(Severity.Invalid, V118, CheckIdentifier.Ball);
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private void verifyBall()
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
{
Add egg checking for gen2 Delay egg move checking until the end to finish validating moves
2017-02-28 04:57:24 +00:00
if (pkm.Format < 3)
return; // no ball info saved
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
if (!Encounter.Valid)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (EncounterMatch is MysteryGift g)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (pkm.Species == 490 && g.Ball == 0)
Fix for Manaphy Egg Gen 4 event encounter - changed trade egg location in mystery gift search - adapted getMinLevelEncounter to take into account gen 4 eggs in gen 4 games - remvoed manaphy for static encounters, is already included in event database - fix no hatching for an egg check for gen 4 manaphy
2017-03-30 18:58:30 +00:00
// there is no ball data in Manaphy Mystery Gift
verifyBallEquals(4); // Pokeball
else
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
verifyBallEquals(g.Ball);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (EncounterMatch is EncounterLink l)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
verifyBallEquals(l.Ball);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Refactoring Simplify EncounterStatic type check as it is gen4 specific -> gen4 specific child class Checks.cs: Move transfer legality check back to end as Gen4Result needs to be defined (not null) Rename EncounterType of Analysis class to avoid conflict with the EncounterType enum
2017-04-22 20:04:12 +00:00
if (Type == typeof (EncounterTrade))
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
verifyBallEquals(4); // Pokeball
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Heavy ball legality checks.
2017-03-13 19:12:55 +00:00
Several minor fixes Fix Moves of EnconterStatic NullReferenceException Error Fix ball checking of shedinja Add missing legality check string
2017-04-08 00:45:22 +00:00
if (pkm.Species == 292 && pkm.GenNumber > 3) // Shedinja. For gen3, copy the ball from Nincada
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
{
Several minor fixes Fix Moves of EnconterStatic NullReferenceException Error Fix ball checking of shedinja Add missing legality check string
2017-04-08 00:45:22 +00:00
verifyBallEquals(4); // Pokeball Only
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
return;
}
Fix heavy ball code.
2017-03-13 19:28:39 +00:00
if (pkm.Ball == 0x14 && pkm.Gen7) // Heavy Ball
Heavy ball legality checks.
2017-03-13 19:12:55 +00:00
{
Misc heavy ball tweak/fix Legends weren't in inherit table (no breeding) Move lineage fetch into check so that it is not calculated & unused for other pkms Instead of iterating over inherit table, just use a precomputed list only 5 possible encounters are stored in the int[], there's more cases where heavy ball is invalid but there's no possible encounter for them which would already be flagged by another check.
2017-03-14 01:38:56 +00:00
var lineage = Legal.getLineage(pkm);
if (lineage.Any(e => Legal.AlolanCaptureNoHeavyBall.Contains(e)))
Remove heavy ball early return Continue onward to the appropriate checks. Closes #939
2017-03-15 04:13:39 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V116, CheckIdentifier.Ball);
Remove heavy ball early return Continue onward to the appropriate checks. Closes #939
2017-03-15 04:13:39 +00:00
return;
}
Heavy ball legality checks.
2017-03-13 19:12:55 +00:00
}
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterStatic s)
Defer Gift ball check Now returns invalid ball instead of invalid encounter
2016-04-21 03:46:18 +00:00
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (s.Gift)
verifyBallEquals(s.Ball);
General gen5 fixes - begin to impl ball checking - add white forest for white (move greatmarshalt to table4) - fix several datapoints - fix ability from dream world - add in-game version filtering
2017-03-30 06:31:02 +00:00
else if (pkm.Met_Location == 75 && pkm.Gen5) // DreamWorld
verifyBallEquals(Legal.DreamWorldBalls);
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
verifyBallEquals(Legal.getWildBalls(pkm));
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterSlot w)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Add Poké Pelago ball check Thanks Holla!
2017-01-25 03:49:40 +00:00
if (pkm.Met_Location == 30016 && pkm.Gen7) // Poké Pelago
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
verifyBallEquals(4); // Pokeball
Correction in the comments
2017-03-30 11:24:38 +00:00
// For gen3/4 safari zones and BCC getValidWildEncounters already filter to not return
Safari ball and sport ball checking
2017-03-30 11:18:05 +00:00
// mixed possible encounters between safari, BCC and other encounters
// That means is the first encounter is not safari then there is no safari encounter in the array
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
else if (3 <= pkm.GenNumber && pkm.GenNumber <= 4 && EncounterGenerator.IsSafariSlot(w.Type))
Misc simplifications only species outside of the NohatchFromEgg is manaphy; if it's a recognized encounter it's okay. Safer to check generally than having to update explicitly if there's a mew egg (lol) remove HGSS check for BugContest, simpler to express as cant be BugContest without HGSS anyway (implied) pull out strings from trainer7 (localization cantidate), identify common operations (getBits from ListBox), use |= instead of +=
2017-03-31 08:12:49 +00:00
verifyBallEquals(5); // Safari Ball
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
else if (pkm.GenNumber == 4 && w.Type == SlotType.BugContest)
Misc simplifications only species outside of the NohatchFromEgg is manaphy; if it's a recognized encounter it's okay. Safer to check generally than having to update explicitly if there's a mew egg (lol) remove HGSS check for BugContest, simpler to express as cant be BugContest without HGSS anyway (implied) pull out strings from trainer7 (localization cantidate), identify common operations (getBits from ListBox), use |= instead of +=
2017-03-31 08:12:49 +00:00
verifyBallEquals(0x18); // Sport Ball
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
verifyBallEquals(Legal.getWildBalls(pkm));
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
if (pkm.WasEgg)
{
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
verifyBallEgg();
return;
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
}
Add more strict ball checks Sport/Apricorn/Safari/Dream checked Also snuck in encountertype tracking for readability/calcOnce
2016-03-28 05:05:51 +00:00
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
verifyBallEquals(4); // Pokeball
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
}
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
private void verifyBallEgg()
{
if (pkm.GenNumber < 6) // No inheriting Balls
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
verifyBallEquals(4); // Must be Pokéball -- no ball inheritance.
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
return;
}
if (pkm.Ball == 0x01) // Master Ball
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Invalid, V117, CheckIdentifier.Ball); return; }
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
if (pkm.Ball == 0x10) // Cherish Ball
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Invalid, V120, CheckIdentifier.Ball); return; }
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
if (pkm.Ball == 0x04) // Poké Ball
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Valid, V119, CheckIdentifier.Ball); return; }
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
switch (pkm.GenNumber)
{
case 6: // Gen6 Inheritance Rules
verifyBallEggGen6();
return;
case 7: // Gen7 Inheritance Rules
verifyBallEggGen7();
return;
}
}
private void verifyBallEggGen6()
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
if (pkm.Gender == 2) // Genderless
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
verifyBallEquals(4); // Must be Pokéball as ball can only pass via mother (not Ditto!)
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
if (Legal.BreedMaleOnly.Contains(pkm.Species))
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
verifyBallEquals(4); // Must be Pokéball as ball can only pass via mother (not Ditto!)
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
int ball = pkm.Ball;
if (ball >= 26)
{
AddLine(Severity.Invalid, V126, CheckIdentifier.Ball);
return;
}
if (ball == 0x05) // Safari Ball
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
if (Legal.getLineage(pkm).All(e => !Legal.Inherit_Safari.Contains(e)))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else if (pkm.AbilityNumber == 4)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (0x10 < ball && ball < 0x18) // Apricorn Ball
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
Tweak apricorn inherit legality best to store separate tables due to reusing inherit6 in inherit7, move so that the compiler has them in the same file (doesn't cause exception)
2017-02-04 18:42:56 +00:00
if (Legal.getLineage(pkm).All(e => !Legal.Inherit_Apricorn6.Contains(e)))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
if (pkm.AbilityNumber == 4)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (ball == 0x18) // Sport Ball
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
if (Legal.getLineage(pkm).All(e => !Legal.Inherit_Sport.Contains(e)))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else if (pkm.AbilityNumber == 4)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (ball == 0x19) // Dream Ball
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (Legal.getLineage(pkm).Any(e => Legal.Inherit_Dream.Contains(e)))
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
Add unobtainable dream/hidden combo gen6 Closes #432
2016-11-26 01:54:32 +00:00
if (pkm.AbilityNumber == 4 && Legal.Ban_DreamHidden.Contains(pkm.Species))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
Add unobtainable dream/hidden combo gen6 Closes #432
2016-11-26 01:54:32 +00:00
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (0x0D <= ball && ball <= 0x0F)
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (!Legal.Ban_Gen4Ball_6.Contains(pkm.Species))
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
Add Gen3/4 Ball exclusions Additional Changes: Removed duplicate EncounterLink check Moved RelearnBase resetting to the verifyRelearn() method.
2016-03-29 05:30:23 +00:00
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (0x02 <= ball && ball <= 0x0C) // Don't worry, Ball # 0x05 was already checked.
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
if (Legal.Ban_Gen3Ball.Contains(pkm.Species))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Misc legality checks (gen5-7) (#1020) * Add Flabebe and Pumkaboo altform HA legality check Fix issue #999 The derived value SpecForm can use for other legality checks * Add N's pkm and Hidden Grotto shiny legality checks -fix early return in verifyMisc -add N's pkm legality check: IVs, OT Name, TID, SID, Shiny -add Hidden Grotto shiny check * Fix spelling * More edge cases for gen6 ball checks Ban several altform hidden ability with gen3 ball * Fix gen4 Formcount for altform Manually fix several bytes (http://i.imgur.com/l0Amuto.png)
2017-04-02 13:39:39 +00:00
else if (pkm.AbilityNumber == 4 && Legal.Ban_Gen3BallHidden.Contains(pkm.SpecForm))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
if (pkm.Species > 650 && pkm.Species != 700) // Sylveon
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (Legal.getWildBalls(pkm).Contains(pkm.Ball))
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
Add beyond range ball checks
2016-11-12 14:52:40 +00:00
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V125, CheckIdentifier.Ball);
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
}
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
private void verifyBallEggGen7()
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
var Lineage = Legal.getLineage(pkm).ToArray();
Add a slew of extra legality checks for gen7 Mostly bank related (unobtainable) and hidden ability availability (against my best judgement) to mimic online checks. Closes #529
2016-12-02 02:48:38 +00:00
if (722 <= pkm.Species && pkm.Species <= 730) // G7 Starters
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
verifyBallEquals(4);
Add a slew of extra legality checks for gen7 Mostly bank related (unobtainable) and hidden ability availability (against my best judgement) to mimic online checks. Closes #529
2016-12-02 02:48:38 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
int ball = pkm.Ball;
if (ball == 0x05) // Safari Ball
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
{
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
if (!Lineage.Any(e => Legal.Inherit_Safari.Contains(e) || Legal.Inherit_SafariMale.Contains(e)))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
else if (pkm.AbilityNumber == 4 && Lineage.Any(e => Legal.Ban_SafariBallHidden_7.Contains(e)))
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
else
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (0x10 < ball && ball < 0x18) // Apricorn Ball
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
{
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
if (!Lineage.Any(e => Legal.Inherit_Apricorn7.Contains(e)))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
else if (pkm.AbilityNumber == 4 && (Lineage.Contains(029) || Lineage.Contains(032))) // Nido
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
else
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (ball == 0x18) // Sport Ball
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
{
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
if (!Lineage.Any(e => Legal.Inherit_Sport.Contains(e)))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
else if (pkm.AbilityNumber == 4 && (Lineage.Contains(313) || Lineage.Contains(314))) // Volbeat/Illumise
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
else
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (ball == 0x19) // Dream Ball
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (Lineage.Any(e => Legal.Inherit_Dream.Contains(e) || Legal.Inherit_DreamMale.Contains(e)))
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (0x0D <= ball && ball <= 0x0F) // Dusk Heal Quick
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (!Legal.Ban_Gen4Ball_7.Contains(pkm.Species))
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (0x02 <= ball && ball <= 0x0C) // Don't worry, Ball # 0x05 was already checked.
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (!Legal.Ban_Gen3Ball_7.Contains(pkm.Species))
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
return;
}
Add beyond range ball checks
2016-11-12 14:52:40 +00:00
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (ball == 26)
Add beyond range ball checks
2016-11-12 14:52:40 +00:00
{
Add uncapturable edge case beast ball can't catch these in a beast ball as the only encounter is a gift (porygon & evos, and aerodactyl) #1100
2017-05-10 02:27:30 +00:00
if ((pkm.Species > 731 && pkm.Species <= 785) || Lineage.Any(e => Legal.PastGenAlolanNatives.Contains(e) && !Legal.PastGenAlolanNativesUncapturable.Contains(e)))
Add beyond range ball checks
2016-11-12 14:52:40 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Add beyond range ball checks
2016-11-12 14:52:40 +00:00
return;
}
if (Lineage.Any(e => Legal.PastGenAlolanScans.Contains(e)))
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Add beyond range ball checks
2016-11-12 14:52:40 +00:00
return;
}
// next statement catches all new alolans
}
if (pkm.Species > 721)
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
verifyBallEquals(Legal.getWildBalls(pkm));
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
Add beyond range ball checks
2016-11-12 14:52:40 +00:00
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (ball >= 27)
{
AddLine(Severity.Invalid, V126, CheckIdentifier.Ball);
return;
}
AddLine(Severity.Invalid, V125, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#endregion
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private CheckResult verifyHistory()
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
{
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
if (!Encounter.Valid)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Valid, V127, CheckIdentifier.History);
Add more memory checks Mostly gen3-5 checks if they're ever supported; added bad hack check. Check yer battle videos to expose da haxxers.
2016-12-08 02:28:24 +00:00
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.GenNumber < 6)
Add more memory checks Mostly gen3-5 checks if they're ever supported; added bad hack check. Check yer battle videos to expose da haxxers.
2016-12-08 02:28:24 +00:00
{
if (pkm.Format < 6)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Valid, V128, CheckIdentifier.History);
Add more memory checks Mostly gen3-5 checks if they're ever supported; added bad hack check. Check yer battle videos to expose da haxxers.
2016-12-08 02:28:24 +00:00
if (pkm.OT_Affection > 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V129, CheckIdentifier.History);
Add more memory checks Mostly gen3-5 checks if they're ever supported; added bad hack check. Check yer battle videos to expose da haxxers.
2016-12-08 02:28:24 +00:00
if (pkm.OT_Memory > 0 || pkm.OT_Feeling > 0 || pkm.OT_Intensity > 0 || pkm.OT_TextVar > 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V130, CheckIdentifier.History);
Add more memory checks Mostly gen3-5 checks if they're ever supported; added bad hack check. Check yer battle videos to expose da haxxers.
2016-12-08 02:28:24 +00:00
}
Improve file loaded transfer preference use last char of file extension if available. edge case for pk[m] considered: pk[m] => 0x6D, -0x30 = 61d, &7 = 5, which prefers 6 instead of 7+ :) adds a check for transferred pkm not having their CurrentHandler being flagged as the save file (impossible for a transferred PKM to be still handled by the OT).
2017-02-07 06:19:10 +00:00
if (pkm.Format >= 6 && pkm.GenNumber != pkm.Format && pkm.CurrentHandler != 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V124, CheckIdentifier.History);
Improve file loaded transfer preference use last char of file extension if available. edge case for pk[m] considered: pk[m] => 0x6D, -0x30 = 61d, &7 = 5, which prefers 6 instead of 7+ :) adds a check for transferred pkm not having their CurrentHandler being flagged as the save file (impossible for a transferred PKM to be still handled by the OT).
2017-02-07 06:19:10 +00:00
Add more memory checks Mostly gen3-5 checks if they're ever supported; added bad hack check. Check yer battle videos to expose da haxxers.
2016-12-08 02:28:24 +00:00
if (pkm.HT_Gender > 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, string.Format(V131, pkm.HT_Gender), CheckIdentifier.History);
Update cleared data legality checks Add in a few more, a little bit of shuffling
2017-01-25 17:17:20 +00:00
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
MysteryGift mg = EncounterMatch as MysteryGift;
Move MatchedWC6 into EncounterMatch
2016-03-23 05:49:46 +00:00
WC6 MatchedWC6 = EncounterMatch as WC6;
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
WC7 MatchedWC7 = EncounterMatch as WC7;
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
if (MatchedWC6?.OT.Length > 0) // Has Event OT -- null propagation yields false if MatchedWC6=null
{
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
if (pkm.OT_Friendship != PersonalTable.AO[MatchedWC6.Species].BaseFriendship)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V132, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.OT_Affection != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V133, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.CurrentHandler != 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V134, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
}
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
else if (MatchedWC7?.OT.Length > 0) // Has Event OT -- null propagation yields false if MatchedWC7=null
{
if (pkm.OT_Friendship != PersonalTable.SM[MatchedWC7.Species].BaseFriendship)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V132, CheckIdentifier.History);
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
if (pkm.OT_Affection != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V133, CheckIdentifier.History);
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
if (pkm.CurrentHandler != 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V134, CheckIdentifier.History);
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
}
else if (mg != null && mg.Format < 6 && pkm.Format >= 6)
{
if (pkm.OT_Affection != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V133, CheckIdentifier.History);
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
if (pkm.CurrentHandler != 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V134, CheckIdentifier.History);
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
}
Misc legality updates Add ゲーフリ to valid 151 OTs Revise logic for split-forme egg moves (Closes #777) Save config on closing instead of option change Remove geolocation setting for 6->7 and associated legality check, move geolocation validity check higher (Closes #776)
2017-01-31 01:49:28 +00:00
// Geolocations
var geo = new[]
Add encountertrades
2016-11-11 03:29:00 +00:00
{
Misc legality updates Add ゲーフリ to valid 151 OTs Revise logic for split-forme egg moves (Closes #777) Save config on closing instead of option change Remove geolocation setting for 6->7 and associated legality check, move geolocation validity check higher (Closes #776)
2017-01-31 01:49:28 +00:00
pkm.Geo1_Country, pkm.Geo2_Country, pkm.Geo3_Country, pkm.Geo4_Country, pkm.Geo5_Country,
pkm.Geo1_Region, pkm.Geo2_Region, pkm.Geo3_Region, pkm.Geo4_Region, pkm.Geo5_Region,
};
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
Misc legality updates Add ゲーフリ to valid 151 OTs Revise logic for split-forme egg moves (Closes #777) Save config on closing instead of option change Remove geolocation setting for 6->7 and associated legality check, move geolocation validity check higher (Closes #776)
2017-01-31 01:49:28 +00:00
// Check sequential order (no zero gaps)
bool geoEnd = false;
for (int i = 0; i < 5; i++)
{
if (geoEnd && geo[i] != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V135, CheckIdentifier.History);
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
Misc legality updates Add ゲーフリ to valid 151 OTs Revise logic for split-forme egg moves (Closes #777) Save config on closing instead of option change Remove geolocation setting for 6->7 and associated legality check, move geolocation validity check higher (Closes #776)
2017-01-31 01:49:28 +00:00
if (geo[i] != 0)
continue;
if (geo[i + 5] != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V136, CheckIdentifier.History);
Misc legality updates Add ゲーフリ to valid 151 OTs Revise logic for split-forme egg moves (Closes #777) Save config on closing instead of option change Remove geolocation setting for 6->7 and associated legality check, move geolocation validity check higher (Closes #776)
2017-01-31 01:49:28 +00:00
geoEnd = true;
}
if (pkm.Format >= 7)
{
if (pkm.VC1)
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
{
var hasGeo = geo.Any(d => d != 0);
if (!hasGeo)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V137, CheckIdentifier.History);
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
}
Add geolocation memory checks for g7
2016-12-03 03:50:02 +00:00
Update cleared data legality checks Add in a few more, a little bit of shuffling
2017-01-25 17:17:20 +00:00
if (pkm.GenNumber >= 7 && pkm.CNTs.Any(stat => stat > 0))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V138, CheckIdentifier.History);
Add geolocation memory checks for g7
2016-12-03 03:50:02 +00:00
if (!pkm.WasEvent && pkm.HT_Name.Length == 0) // Is not Traded
{
if (pkm.CurrentHandler != 0) // Badly edited; PKHeX doesn't trip this.
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V139, CheckIdentifier.History);
Add geolocation memory checks for g7
2016-12-03 03:50:02 +00:00
if (pkm.HT_Friendship != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V140, CheckIdentifier.History);
Add geolocation memory checks for g7
2016-12-03 03:50:02 +00:00
if (pkm.HT_Affection != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V141, CheckIdentifier.History);
Add geolocation memory checks for g7
2016-12-03 03:50:02 +00:00
// We know it is untraded (HT is empty), if it must be trade evolved flag it.
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (Legal.getHasTradeEvolved(pkm) && EncounterMatch.Species != pkm.Species)
Add geolocation memory checks for g7
2016-12-03 03:50:02 +00:00
{
if (pkm.Species != 350) // Milotic
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V142, CheckIdentifier.History);
Add geolocation memory checks for g7
2016-12-03 03:50:02 +00:00
if (pkm.CNT_Beauty < 170) // Beauty Contest Stat Requirement
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V143, CheckIdentifier.History);
Add geolocation memory checks for g7
2016-12-03 03:50:02 +00:00
if (pkm.CurrentLevel == 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V144, CheckIdentifier.History);
Add geolocation memory checks for g7
2016-12-03 03:50:02 +00:00
}
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Valid, V145, CheckIdentifier.History);
Add encountertrades
2016-11-11 03:29:00 +00:00
}
Fix deoxys handling on gen6+ WasEvent was not yielding true for a past gen specimen as the deoxys exclusion for ORAS was present. Remove and change handling.
2017-04-01 21:20:00 +00:00
// Determine if we should check for Handling Trainer Memories
// A Pokémon is untraded if...
bool untraded = pkm.HT_Name.Length == 0 || pkm.Geo1_Country == 0;
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
if (Type == typeof(MysteryGift))
Fix deoxys handling on gen6+ WasEvent was not yielding true for a past gen specimen as the deoxys exclusion for ORAS was present. Remove and change handling.
2017-04-01 21:20:00 +00:00
{
untraded |= !pkm.WasEventEgg;
untraded &= pkm.WasEgg;
}
if (pkm.WasLink && (EncounterMatch as EncounterLink)?.OT == false)
untraded = false;
else if (pkm.GenNumber < 6)
untraded = false;
if (untraded) // Is not Traded
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
if (pkm.HT_Name.Length != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V146, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.Geo1_Country != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V147, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.HT_Memory != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V148, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.CurrentHandler != 0) // Badly edited; PKHeX doesn't trip this.
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V139, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.HT_Friendship != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V140, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.HT_Affection != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V141, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.XY && pkm.CNTs.Any(stat => stat > 0))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V138, CheckIdentifier.History);
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
// We know it is untraded (HT is empty), if it must be trade evolved flag it.
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (Legal.getHasTradeEvolved(pkm) && EncounterMatch.Species != pkm.Species)
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.Species != 350) // Milotic
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V142, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.CNT_Beauty < 170) // Beauty Contest Stat Requirement
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V143, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.CurrentLevel == 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V144, CheckIdentifier.History);
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
}
}
else // Is Traded
{
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
if (pkm.Format == 6 && pkm.HT_Memory == 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V150, CheckIdentifier.History);
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
}
Check memories for eggs/transfer Catches some of those jan2014 banked pentagon mons without OT memories The last check is unused; the last two checks are designed in case past gen pkm are checked.
2016-03-31 01:53:34 +00:00
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
// Memory ChecksResult
if (pkm.IsEgg)
Check memories for eggs/transfer Catches some of those jan2014 banked pentagon mons without OT memories The last check is unused; the last two checks are designed in case past gen pkm are checked.
2016-03-31 01:53:34 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.HT_Memory != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V149, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.OT_Memory != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V151, CheckIdentifier.History);
Check memories for eggs/transfer Catches some of those jan2014 banked pentagon mons without OT memories The last check is unused; the last two checks are designed in case past gen pkm are checked.
2016-03-31 01:53:34 +00:00
}
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
else if (MatchedType != typeof(WC6))
Check memories for eggs/transfer Catches some of those jan2014 banked pentagon mons without OT memories The last check is unused; the last two checks are designed in case past gen pkm are checked.
2016-03-31 01:53:34 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.OT_Memory == 0 ^ !pkm.Gen6)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V152, CheckIdentifier.History);
Fix gen7 affection set Closes #365
2016-11-11 06:11:53 +00:00
if (pkm.GenNumber < 6 && pkm.OT_Affection != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V129, CheckIdentifier.History);
Check memories for eggs/transfer Catches some of those jan2014 banked pentagon mons without OT memories The last check is unused; the last two checks are designed in case past gen pkm are checked.
2016-03-31 01:53:34 +00:00
}
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
// Unimplemented: Ingame Trade Memories
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Valid, V145, CheckIdentifier.History);
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private CheckResult verifyCommonMemory(int handler)
Add legality checks for HM-specific memories Pokemon which have memories of using moves that they cannot learn will be flagged as illegal.
2016-05-07 06:16:35 +00:00
{
int m = 0;
Checks for PKM Center memories
2016-05-09 23:09:40 +00:00
int t = 0;
Add legality checks for HM-specific memories Pokemon which have memories of using moves that they cannot learn will be flagged as illegal.
2016-05-07 06:16:35 +00:00
string resultPrefix = "";
switch (handler)
{
case 0:
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
m = pkm.OT_Memory;
t = pkm.OT_TextVar;
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
resultPrefix = V205;
Add legality checks for HM-specific memories Pokemon which have memories of using moves that they cannot learn will be flagged as illegal.
2016-05-07 06:16:35 +00:00
break;
case 1:
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
m = pkm.HT_Memory;
t = pkm.HT_TextVar;
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
resultPrefix = V206;
Add legality checks for HM-specific memories Pokemon which have memories of using moves that they cannot learn will be flagged as illegal.
2016-05-07 06:16:35 +00:00
break;
}
int matchingMoveMemory = Array.IndexOf(Legal.MoveSpecificMemories[0], m);
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
if (matchingMoveMemory != -1 && pkm.Species != 235 && !Legal.getCanLearnMachineMove(pkm, Legal.MoveSpecificMemories[1][matchingMoveMemory], 6))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, string.Format(V153, resultPrefix), CheckIdentifier.Memory);
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
Checks for PKM Center memories
2016-05-09 23:09:40 +00:00
if (m == 6 && !Legal.LocationsWithPKCenter[0].Contains(t))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, string.Format(V154, resultPrefix), CheckIdentifier.Memory);
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
Add Memory 21 None of my database mons even had this memory :\
2016-05-10 01:19:31 +00:00
if (m == 21) // {0} saw {2} carrying {1} on its back. {4} that {3}.
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
if (!Legal.getCanLearnMachineMove(new PK6 {Species = t, EXP = PKX.getEXP(100, t)}, 19, 6))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, string.Format(V153, resultPrefix), CheckIdentifier.Memory);
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
if ((m == 16 || m == 48) && (t == 0 || !Legal.getCanKnowMove(pkm, t, 6)))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, string.Format(V153, resultPrefix), CheckIdentifier.Memory);
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
if (m == 49 && (t == 0 || !Legal.getCanRelearnMove(pkm, t, 6))) // {0} was able to remember {2} at {1}'s instruction. {4} that {3}.
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, string.Format(V153, resultPrefix), CheckIdentifier.Memory);
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Valid, string.Format(V155, resultPrefix), CheckIdentifier.Memory);
}
private void verifyOTMemoryIs(int[] values)
{
if (pkm.OT_Memory != values[0])
AddLine(Severity.Invalid, string.Format(V197, V205, values[0]), CheckIdentifier.Memory);
if (pkm.OT_Intensity != values[1])
AddLine(Severity.Invalid, string.Format(V198, V205, values[1]), CheckIdentifier.Memory);
if (pkm.OT_TextVar != values[2])
AddLine(Severity.Invalid, string.Format(V199, V205, values[2]), CheckIdentifier.Memory);
if (pkm.OT_Feeling != values[3])
AddLine(Severity.Invalid, string.Format(V200, V205, values[3]), CheckIdentifier.Memory);
Add legality checks for HM-specific memories Pokemon which have memories of using moves that they cannot learn will be flagged as illegal.
2016-05-07 06:16:35 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private void verifyOTMemory()
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
{
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
if (pkm.Format < 6)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
if (!History.Valid)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
if (pkm.GenNumber < 6)
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
{
Handle CXD egg encounters There are none. But the detection routine for gen3 can assign cxd pkm as egg if no other possible encounter is matched, thus we'll flag if the failure case occurs. add missing spacing formatting, simplify break->return for egg game retrieval
2017-05-03 02:08:16 +00:00
verifyOTMemoryIs(new [] {0, 0, 0, 0}); // empty
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
}
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
Refactoring Simplify EncounterStatic type check as it is gen4 specific -> gen4 specific child class Checks.cs: Move transfer legality check back to end as Gen4Result needs to be defined (not null) Rename EncounterType of Analysis class to avoid conflict with the EncounterType enum
2017-04-22 20:04:12 +00:00
if (Type == typeof(EncounterTrade))
Update cleared data legality checks Add in a few more, a little bit of shuffling
2017-01-25 17:17:20 +00:00
{
// Undocumented, uncommon, and insignificant -- don't bother.
return;
}
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
if (MatchedType == typeof(WC6))
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
WC6 g = EncounterMatch as WC6;
verifyOTMemoryIs(new[] {g.OT_Memory, g.OT_Intensity, g.OT_TextVar, g.OT_Feeling});
return;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
}
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
if (MatchedType == typeof(WC7))
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
WC7 g = EncounterMatch as WC7;
verifyOTMemoryIs(new[] {g.OT_Memory, g.OT_Intensity, g.OT_TextVar, g.OT_Feeling});
return;
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (pkm.GenNumber >= 7)
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
verifyOTMemoryIs(new[] {0, 0, 0, 0}); // empty
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
return;
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
switch (pkm.OT_Memory)
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
{
Hatch memory check for memories of OT Memory will be flagged as illegal if Pokemon did not hatch from an egg
2016-05-25 05:20:19 +00:00
case 2: // {0} hatched from an Egg and saw {1} for the first time at... {2}. {4} that {3}.
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (!pkm.WasEgg && pkm.Egg_Location != 60004)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V160, V205), CheckIdentifier.Memory);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
break;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
case 4: // {0} became {1}’s friend when it arrived via Link Trade at... {2}. {4} that {3}.
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V161, V205), CheckIdentifier.Memory);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Checks for PKM Center memories
2016-05-09 23:09:40 +00:00
case 6: // {0} went to the Pokémon Center in {2} with {1} and had its tired body healed there. {4} that {3}.
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
int matchingOriginGame = Array.IndexOf(Legal.LocationsWithPKCenter[0], pkm.OT_TextVar);
Rearrange logic for Location Get game ID once, check pk6 game first. Will be easy to insert a third case if/when the time comes.
2016-05-10 00:51:35 +00:00
if (matchingOriginGame != -1)
{
int gameID = Legal.LocationsWithPKCenter[1][matchingOriginGame];
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.XY && gameID != 0 || pkm.AO && gameID != 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V162, V205), CheckIdentifier.Memory);
Rearrange logic for Location Get game ID once, check pk6 game first. Will be easy to insert a third case if/when the time comes.
2016-05-10 00:51:35 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
AddLine(verifyCommonMemory(0));
return;
Add memorycheck 14 (species can be captured)
2016-05-06 03:35:18 +00:00
case 14:
Finish fix for gameversion passing
2016-11-09 06:10:32 +00:00
if (!Legal.getCanBeCaptured(pkm.OT_TextVar, pkm.GenNumber, (GameVersion)pkm.Version))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V165, V205), CheckIdentifier.Memory);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, string.Format(V164, V205), CheckIdentifier.Memory);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.XY && Legal.Memory_NotXY.Contains(pkm.OT_Memory))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V163, V205), CheckIdentifier.Memory);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.AO && Legal.Memory_NotAO.Contains(pkm.OT_Memory))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V163, V205), CheckIdentifier.Memory);
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
AddLine(verifyCommonMemory(0));
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private void verifyHTMemory()
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.Format < 6)
return;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
if (!History.Valid)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
Misc updates Closes #860 by adding in prompt for Gen1 saves to determine if the save originated from VC. Will disable Gen2 legality sources when checking pk1 files. -- Fixes froslass/gallade evolution tree pruning movesets. For whatever reason, the level argument of the Evolution is not 0 when using the item; I manually edited the evos_sm.pkl binary to set the 2 evolutions from [XX] -> 00. Fixes gen1 ingame trades slipping through the getEncounter12 preference. Gen2 has set TIDs, so check if TID is set. Loosens checks for Gen7 trades (including prior transfers) as trading between games clears the memory. Add 3 more g7 trainer stat records too. Thanks Holla! -- Add getMoves(100) optimization as gen7 learnsets can grab 1->100, better than looping over the range every time it's checked.
2017-03-12 23:36:23 +00:00
if (pkm.Format >= 7)
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
{
Misc updates Closes #860 by adding in prompt for Gen1 saves to determine if the save originated from VC. Will disable Gen2 legality sources when checking pk1 files. -- Fixes froslass/gallade evolution tree pruning movesets. For whatever reason, the level argument of the Evolution is not 0 when using the item; I manually edited the evos_sm.pkl binary to set the 2 evolutions from [XX] -> 00. Fixes gen1 ingame trades slipping through the getEncounter12 preference. Gen2 has set TIDs, so check if TID is set. Loosens checks for Gen7 trades (including prior transfers) as trading between games clears the memory. Add 3 more g7 trainer stat records too. Thanks Holla! -- Add getMoves(100) optimization as gen7 learnsets can grab 1->100, better than looping over the range every time it's checked.
2017-03-12 23:36:23 +00:00
/*
* Bank Transfer adds in the Link Trade Memory.
* Trading 7<->7 between games (not Bank) clears this data.
*/
if (pkm.HT_Memory == 0)
{
if (pkm.HT_TextVar != 0 || pkm.HT_Intensity != 0 || pkm.HT_Feeling != 0)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V329, CheckIdentifier.Memory);
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
return;
Misc updates Closes #860 by adding in prompt for Gen1 saves to determine if the save originated from VC. Will disable Gen2 legality sources when checking pk1 files. -- Fixes froslass/gallade evolution tree pruning movesets. For whatever reason, the level argument of the Evolution is not 0 when using the item; I manually edited the evos_sm.pkl binary to set the 2 evolutions from [XX] -> 00. Fixes gen1 ingame trades slipping through the getEncounter12 preference. Gen2 has set TIDs, so check if TID is set. Loosens checks for Gen7 trades (including prior transfers) as trading between games clears the memory. Add 3 more g7 trainer stat records too. Thanks Holla! -- Add getMoves(100) optimization as gen7 learnsets can grab 1->100, better than looping over the range every time it's checked.
2017-03-12 23:36:23 +00:00
}
Update gen7 memory checks y u give vc mons memories? add HT memory check for transported mons
2017-01-27 04:13:27 +00:00
Ignore memory restriction for past gen same OT xfrs Closes #1145
2017-05-19 00:38:26 +00:00
// Transfer 6->7 & withdraw to same HT => keeps past gen memory
// Don't require link trade memory for these past gen cases
int gen = pkm.GenNumber;
if (3 <= gen && gen < 7 && pkm.CurrentHandler == 1)
return;
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
if (pkm.HT_Memory != 4)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V156, CheckIdentifier.Memory);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
if (pkm.HT_TextVar != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V157, CheckIdentifier.Memory);
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
if (pkm.HT_Intensity != 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V158, CheckIdentifier.Memory);
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
if (pkm.HT_Feeling > 10)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V159, CheckIdentifier.Memory);
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
return;
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
switch (pkm.HT_Memory)
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
{
Update gen7 memory checks y u give vc mons memories? add HT memory check for transported mons
2017-01-27 04:13:27 +00:00
case 0:
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
if (string.IsNullOrEmpty(pkm.HT_Name))
Update gen7 memory checks y u give vc mons memories? add HT memory check for transported mons
2017-01-27 04:13:27 +00:00
return;
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V150, CheckIdentifier.Memory); return;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
case 1: // {0} met {1} at... {2}. {1} threw a Poké Ball at it, and they started to travel together. {4} that {3}.
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V202, V206), CheckIdentifier.Memory); return;
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
case 2: // {0} hatched from an Egg and saw {1} for the first time at... {2}. {4} that {3}.
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V160, V206), CheckIdentifier.Memory); return;
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
Add memorycheck 14 (species can be captured)
2016-05-06 03:35:18 +00:00
case 14:
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (Legal.getCanBeCaptured(pkm.HT_TextVar, pkm.GenNumber))
AddLine(Severity.Valid, string.Format(V164, V206), CheckIdentifier.Memory);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V165, V206), CheckIdentifier.Memory);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
AddLine(verifyCommonMemory(1));
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private void verifyRegion()
Check if the country is avalaible on the 3DS region
2016-05-11 23:20:31 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.Format < 6)
return;
bool pass;
switch (pkm.ConsoleRegion)
Check if the country is avalaible on the 3DS region
2016-05-11 23:20:31 +00:00
{
Cleanup Condense code to instead indicate if it is valid or not, remove duplicate returns, handle ConsoleRegion values that are not 012456 (init valid to false!).
2016-05-12 04:18:05 +00:00
case 0: // Japan
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
pass = pkm.Country == 1;
Check if the country is avalaible on the 3DS region
2016-05-11 23:20:31 +00:00
break;
Cleanup Condense code to instead indicate if it is valid or not, remove duplicate returns, handle ConsoleRegion values that are not 012456 (init valid to false!).
2016-05-12 04:18:05 +00:00
case 1: // Americas
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
pass = 8 <= pkm.Country && pkm.Country <= 52 || new[] {153, 156, 168, 174, 186}.Contains(pkm.Country);
Check if the country is avalaible on the 3DS region
2016-05-11 23:20:31 +00:00
break;
Cleanup Condense code to instead indicate if it is valid or not, remove duplicate returns, handle ConsoleRegion values that are not 012456 (init valid to false!).
2016-05-12 04:18:05 +00:00
case 2: // Europe
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
pass = 64 <= pkm.Country && pkm.Country <= 127 || new[] {169, 184, 185}.Contains(pkm.Country);
Check if the country is avalaible on the 3DS region
2016-05-11 23:20:31 +00:00
break;
Cleanup Condense code to instead indicate if it is valid or not, remove duplicate returns, handle ConsoleRegion values that are not 012456 (init valid to false!).
2016-05-12 04:18:05 +00:00
case 4: // China
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
pass = pkm.Country == 144 || pkm.Country == 160;
Check if the country is avalaible on the 3DS region
2016-05-11 23:20:31 +00:00
break;
Cleanup Condense code to instead indicate if it is valid or not, remove duplicate returns, handle ConsoleRegion values that are not 012456 (init valid to false!).
2016-05-12 04:18:05 +00:00
case 5: // Korea
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
pass = pkm.Country == 136;
Check if the country is avalaible on the 3DS region
2016-05-11 23:20:31 +00:00
break;
Cleanup Condense code to instead indicate if it is valid or not, remove duplicate returns, handle ConsoleRegion values that are not 012456 (init valid to false!).
2016-05-12 04:18:05 +00:00
case 6: // Taiwan
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
pass = pkm.Country == 128;
Check if the country is avalaible on the 3DS region
2016-05-11 23:20:31 +00:00
break;
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
default:
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(new CheckResult(Severity.Invalid, V301, CheckIdentifier.Geography));
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Check if the country is avalaible on the 3DS region
2016-05-11 23:20:31 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (!pass)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V302, CheckIdentifier.Geography);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Valid, V303, CheckIdentifier.Geography);
Check if the country is avalaible on the 3DS region
2016-05-11 23:20:31 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private void verifyForm()
Add Form checks
2016-04-14 10:17:03 +00:00
{
if (!Encounter.Valid)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add Form checks
2016-04-14 10:17:03 +00:00
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.Format < 4)
return;
Refactoring Add placeholder met location list for hatched eggs Moved generation nonspecific tables to the master Tables.
2016-11-09 05:43:22 +00:00
if (pkm.AltForm > pkm.PersonalInfo.FormeCount)
{
Add form personalinfo check exclusions
2016-11-14 15:33:39 +00:00
bool valid = false;
int species = pkm.Species;
if (species == 201) // Unown
{
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
int maxCount = pkm.GenNumber == 2 ? 26 : 28; // A-Z : A-Z?!
if (pkm.AltForm < maxCount)
Add form personalinfo check exclusions
2016-11-14 15:33:39 +00:00
valid = true;
}
if (species == 414 && pkm.AltForm < 3) // Wormadam base form kept
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
valid = true;
Add form personalinfo check exclusions
2016-11-14 15:33:39 +00:00
if ((species == 664 || species == 665) && pkm.AltForm < 18) // Vivillon Pre-evolutions
valid = true;
if (!valid) // ignore list
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
{ AddLine(Severity.Invalid, string.Format(V304, pkm.PersonalInfo.FormeCount, pkm.AltForm), CheckIdentifier.Form); return; }
Refactoring Add placeholder met location list for hatched eggs Moved generation nonspecific tables to the master Tables.
2016-11-09 05:43:22 +00:00
}
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterSlot w && w.Type == SlotType.FriendSafari)
verifyFormFriendSafari();
Refactoring Add placeholder met location list for hatched eggs Moved generation nonspecific tables to the master Tables.
2016-11-09 05:43:22 +00:00
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
switch (pkm.Species)
Add Form checks
2016-04-14 10:17:03 +00:00
{
Invert minior form check Shields down outside of battle, only up while in battle. Also add some comments to relate speciesID<->species Closes #399
2016-11-14 02:25:33 +00:00
case 25: // Pikachu
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
if (pkm.Format == 6 && pkm.AltForm != 0 ^ Type == typeof(EncounterStatic))
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
string msg = Type == typeof(EncounterStatic) ? V305 : V306;
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
AddLine(Severity.Invalid, msg, CheckIdentifier.Form);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
if (pkm.Format == 7 && pkm.AltForm != 0 ^ Type == typeof(MysteryGift))
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
More c#7 shorthand outs & pattern matching, other simplifications
2017-05-13 17:20:25 +00:00
if (EncounterMatch is WC7 gift && gift.Form != pkm.AltForm)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V307, CheckIdentifier.Form);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
}
Cosplay pikachu fixes Form can be changed only for the received cosplay Pikachu. Can be obtained in any location. Regular Pikachu cannot be given a cosplay-only form Cosplay Pikachu cannot have a non-cosplay form.
2016-04-23 21:16:12 +00:00
break;
Fix for Giratina's Origin form only with specific held item
2017-01-31 22:01:32 +00:00
case 487: // Giratina
Simplify giratina check No need to check both cases when we're really just checking for a mismatch
2017-02-03 03:30:17 +00:00
if (pkm.AltForm == 1 ^ pkm.HeldItem == 112) // Origin form only with Griseous Orb
Fix for Giratina's Origin form only with specific held item
2017-01-31 22:01:32 +00:00
{
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V308, CheckIdentifier.Form);
Fix for Giratina's Origin form only with specific held item
2017-01-31 22:01:32 +00:00
return;
}
break;
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
case 493: // Arceus
{
int item = pkm.HeldItem;
int form = 0;
if ((298 <= item && item <= 313) || item == 644)
form = Array.IndexOf(Legal.Arceus_Plate, item) + 1;
else if (777 <= item && item <= 793)
form = Array.IndexOf(Legal.Arceus_ZCrystal, item) + 1;
if (form != pkm.AltForm)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V308, CheckIdentifier.Form);
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
else if (form != 0)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Valid, V309, CheckIdentifier.Form);
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
}
Add Genesect item/form check Closes #850
2017-02-13 01:06:09 +00:00
break;
Refactor move legality checking With the refactoring of result strings outside of Checks.cs, the logic became harder to follow as the result strings functioned as comments. This commit splits up the large move checking methods into smaller parts and added comments. Moved keldeo move check to a form check and simplifies the check to only search once.
2017-03-23 06:34:35 +00:00
case 647: // Keldeo
{
int index = Array.IndexOf(pkm.Moves, 548); // Secret Sword
bool noSword = index < 0;
if (pkm.AltForm == 0 ^ noSword) // mismatch
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
info.vMoves[noSword ? 0 : index] = new CheckResult(Severity.Invalid, V169, CheckIdentifier.Move);
Refactor move legality checking With the refactoring of result strings outside of Checks.cs, the logic became harder to follow as the result strings functioned as comments. This commit splits up the large move checking methods into smaller parts and added comments. Moved keldeo move check to a form check and simplifies the check to only search once.
2017-03-23 06:34:35 +00:00
break;
}
Add Genesect item/form check Closes #850
2017-02-13 01:06:09 +00:00
case 649: // Genesect
{
int item = pkm.HeldItem;
int form = 0;
if (116 <= item && item <= 119)
form = item - 115;
if (form != pkm.AltForm)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V308, CheckIdentifier.Form);
Add Genesect item/form check Closes #850
2017-02-13 01:06:09 +00:00
else
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Valid, V309, CheckIdentifier.Form);
Add Genesect item/form check Closes #850
2017-02-13 01:06:09 +00:00
}
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
break;
Invert minior form check Shields down outside of battle, only up while in battle. Also add some comments to relate speciesID<->species Closes #399
2016-11-14 02:25:33 +00:00
case 658: // Greninja
Refactoring Add placeholder met location list for hatched eggs Moved generation nonspecific tables to the master Tables.
2016-11-09 05:43:22 +00:00
if (pkm.AltForm > 1) // Ash Battle Bond active
{
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V310, CheckIdentifier.Form);
Refactoring Add placeholder met location list for hatched eggs Moved generation nonspecific tables to the master Tables.
2016-11-09 05:43:22 +00:00
return;
}
break;
Invert minior form check Shields down outside of battle, only up while in battle. Also add some comments to relate speciesID<->species Closes #399
2016-11-14 02:25:33 +00:00
case 664: // Scatterbug
case 665: // Spewpa
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.AltForm > 17) // Fancy & Pokéball
{
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V311, CheckIdentifier.Form);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
if (!Legal.CheckVivillonPattern(pkm.AltForm, pkm.Country, pkm.Region))
AddLine(Severity.Fishy, V312, CheckIdentifier.Form);
Add Form checks
2016-04-14 10:17:03 +00:00
break;
Invert minior form check Shields down outside of battle, only up while in battle. Also add some comments to relate speciesID<->species Closes #399
2016-11-14 02:25:33 +00:00
case 666: // Vivillon
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.AltForm > 17) // Fancy & Pokéball
{
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
if (Type != typeof(MysteryGift))
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V312, CheckIdentifier.Form);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Valid, V313, CheckIdentifier.Form);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
if (!Legal.CheckVivillonPattern(pkm.AltForm, pkm.Country, pkm.Region))
AddLine(Severity.Fishy, V312, CheckIdentifier.Form);
Add Form checks
2016-04-14 10:17:03 +00:00
break;
Invert minior form check Shields down outside of battle, only up while in battle. Also add some comments to relate speciesID<->species Closes #399
2016-11-14 02:25:33 +00:00
case 670: // Floette
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.AltForm == 5) // Eternal Flower -- Never Released
{
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
if (Type != typeof(MysteryGift))
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V314, CheckIdentifier.Form);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Valid, V315, CheckIdentifier.Form);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Add Form checks
2016-04-14 10:17:03 +00:00
break;
Invert minior form check Shields down outside of battle, only up while in battle. Also add some comments to relate speciesID<->species Closes #399
2016-11-14 02:25:33 +00:00
case 718: // Zygarde
Refactoring Add placeholder met location list for hatched eggs Moved generation nonspecific tables to the master Tables.
2016-11-09 05:43:22 +00:00
if (pkm.AltForm >= 4)
{
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V310, CheckIdentifier.Form);
Refactoring Add placeholder met location list for hatched eggs Moved generation nonspecific tables to the master Tables.
2016-11-09 05:43:22 +00:00
return;
}
break;
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
case 773: // Silvally
{
int item = pkm.HeldItem;
int form = 0;
if ((904 <= item && item <= 920) || item == 644)
form = item - 903;
if (form != pkm.AltForm)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V308, CheckIdentifier.Form);
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
else if (form != 0)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Valid, V309, CheckIdentifier.Form);
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
break;
}
Invert minior form check Shields down outside of battle, only up while in battle. Also add some comments to relate speciesID<->species Closes #399
2016-11-14 02:25:33 +00:00
case 774: // Minior
if (pkm.AltForm < 7)
Refactoring Add placeholder met location list for hatched eggs Moved generation nonspecific tables to the master Tables.
2016-11-09 05:43:22 +00:00
{
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V310, CheckIdentifier.Form);
Refactoring Add placeholder met location list for hatched eggs Moved generation nonspecific tables to the master Tables.
2016-11-09 05:43:22 +00:00
return;
}
break;
Add party-only form legality checks Closes #806
2017-02-03 03:27:48 +00:00
// Party Only Forms
case 492: // Shaymin
case 676: // Furfrou
case 720: // Hoopa
Fix party only battle form legality check Only set box value if in box Only check party-only if <= gen6 Closes #1060 , thanks @White-Canary !
2017-04-15 00:49:13 +00:00
if (pkm.AltForm != 0 && pkm.Box > -1 && pkm.Format <= 6) // has form but stored in box
Simplify giratina check No need to check both cases when we're really just checking for a mismatch
2017-02-03 03:30:17 +00:00
{
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V316, CheckIdentifier.Form);
Simplify giratina check No need to check both cases when we're really just checking for a mismatch
2017-02-03 03:30:17 +00:00
return;
}
Add party-only form legality checks Closes #806
2017-02-03 03:27:48 +00:00
break;
Add Form checks
2016-04-14 10:17:03 +00:00
}
Add alolan exclusive form check Marowak and Exeggutor are exempt due to their pre-evolutions not having a form and past gen pkm evolving into the alolan variant.
2016-11-14 02:19:09 +00:00
Add evolve-to-form check Espurr->Meowstic1 Pikachu->Raichu1 etc
2017-02-02 05:59:39 +00:00
if (pkm.Format >= 7 && pkm.GenNumber < 7 && pkm.AltForm != 0)
{
if (pkm.Species == 25 || Legal.AlolanOriginForms.Contains(pkm.Species))
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
{ AddLine(Severity.Invalid, V317, CheckIdentifier.Form); return; }
Add evolve-to-form check Espurr->Meowstic1 Pikachu->Raichu1 etc
2017-02-02 05:59:39 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.AltForm > 0 && new[] {Legal.BattleForms, Legal.BattleMegas, Legal.BattlePrimals}.Any(arr => arr.Contains(pkm.Species)))
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
{ AddLine(Severity.Invalid, V310, CheckIdentifier.Form); return; }
Add Form checks
2016-04-14 10:17:03 +00:00
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Valid, V318, CheckIdentifier.Form);
Add Form checks
2016-04-14 10:17:03 +00:00
}
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
private void verifyMiscG1()
{
if (pkm.Format > 1)
return;
var Type_A = (pkm as PK1).Type_A;
var Type_B = (pkm as PK1).Type_B;
if (pkm.Species == 137)
{
// Porygon can have any type combination of any generation 1 species because of the move Conversion,
// that change Porygon type to match the oponent types
var Type_A_Match = Legal.Types_Gen1.Any(t => t == Type_A);
var Type_B_Match = Legal.Types_Gen1.Any(t => t == Type_B);
if (!Type_A_Match)
AddLine(Severity.Invalid, V386, CheckIdentifier.Misc);
if (!Type_B_Match)
AddLine(Severity.Invalid, V387, CheckIdentifier.Misc);
if (Type_A_Match && Type_B_Match)
{
var TypesAB_Match = PersonalTable.RB.IsValidTypeCombination(Type_A, Type_B);
if (TypesAB_Match)
AddLine(Severity.Valid, V391, CheckIdentifier.Misc);
else
AddLine(Severity.Invalid, V388, CheckIdentifier.Misc);
}
}
else // Types must match species types
{
var Type_A_Match = Type_A == PersonalTable.RB[pkm.Species].Types[0];
var Type_B_Match = Type_B == PersonalTable.RB[pkm.Species].Types[1];
AddLine(Type_A_Match ? Severity.Valid : Severity.Invalid, Type_A_Match ? V392 : V389, CheckIdentifier.Misc);
AddLine(Type_B_Match ? Severity.Valid : Severity.Invalid, Type_B_Match ? V393 : V390, CheckIdentifier.Misc);
}
var catch_rate =(pkm as PK1).Catch_Rate;
switch (pkm.TradebackStatus)
{
case TradebackType.Any:
case TradebackType.WasTradeback:
if (catch_rate == 0 || Legal.HeldItems_GSC.Any(h => h == catch_rate))
{ AddLine(Severity.Valid, V394, CheckIdentifier.Misc); }
else if (pkm.TradebackStatus == TradebackType.WasTradeback)
{ AddLine(Severity.Invalid, V395, CheckIdentifier.Misc); }
else
goto case TradebackType.Gen1_NotTradeback;
break;
case TradebackType.Gen1_NotTradeback:
slight tweaks reduce nesting, formatting; no functional change
2017-05-01 15:25:20 +00:00
if ((EncounterMatch as EncounterStatic)?.Version == GameVersion.Stadium || EncounterMatch is EncounterTradeCatchRate)
Encounter Type fix and detection of pokemon that should have evolve on trade (#1105) * Detect encounter trades that evolve on trade and have not been evolved Detect generation 1 pokemon with special catch rates : krabby trade and Pokemon Stadium Detect generation 1 pokemon that evolve on trade and have been traded but not evolved Detect pokemon with tradeback status any but with only encounters from the other GB generation, that means they are WasTradeback Detect pokemon with moves from the other GB generation, change tradebackstatus to WasTradeback * Fix dppt surfing and fishing encounter type, is is surfing because the battle background is the same as other surfingfishing encounters Fix headbutt encounter type, the encounter type depends on the battle background used when battle a pokemon, for headbutt it changes with the player tile, is the player is in a city it will be building encounter, in a grass tile tall grass, in water it is surfingfishing and cave inside a cave. Some locations have more than one possible encounter type, for example routes with trees near the grass, near the water and near non-combat tiles. Also added slot type headbutt special for the special trees, those trees are all in routes and are only adjacent to non-combat tiles * Fix encounter type for missing areas with multiple grass encounters types: Mt Coronet, Mt Silver Cave and Stark Mountain (Issue # 1095) * Fixes and typos * Check for non-japanese e-reader pokemon, is unreleased
2017-05-01 15:07:20 +00:00
// Encounters detected by the catch rate, cant be invalid if match this encounters
{ AddLine(Severity.Valid, V398, CheckIdentifier.Misc); }
More c#7 shorthand outs & pattern matching, other simplifications
2017-05-13 17:20:25 +00:00
if (pkm.Species == 149 && catch_rate == PersonalTable.Y[149].CatchRate ||
Legal.Species_NotAvailable_CatchRate.Contains(pkm.Species) && catch_rate == PersonalTable.RB[pkm.Species].CatchRate)
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
{ AddLine(Severity.Invalid, V396, CheckIdentifier.Misc); }
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
else if (!info.EvoChainsAllGens[1].Any(e => catch_rate == PersonalTable.RB[e.Species].CatchRate || catch_rate == PersonalTable.Y[e.Species].CatchRate))
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
{ AddLine(Severity.Invalid, pkm.Gen1_NotTradeback? V397: V399, CheckIdentifier.Misc); }
else
{ AddLine(Severity.Valid, V398, CheckIdentifier.Misc); }
break;
}
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
private void verifyMisc()
Add Fateful Encounter check Cleared up the Event check a little to allow Fateful Encounters to slip through.
2016-04-22 02:32:22 +00:00
{
Byte 0x2A in PK7 is PelagoEventStatus See pml::pokepara::CoreParam::GetResortEventStatus Also see: #741. Needs testing to see what values are legal.
2017-01-26 19:16:21 +00:00
if (pkm.Format == 7 && ((PK7)pkm).PelagoEventStatus != 0)
{
// TODO: Figure out what PelagoEventStati are legal.
}
Add incorrect transfer check Flags pk6->pk7 imports that were not converted (no data changes)
2017-01-25 07:34:50 +00:00
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.IsEgg)
Add Egg & Super Training legality checks Closes #220 Thanks @sora10pls !
2016-09-03 15:10:22 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (new[] {pkm.Move1_PPUps, pkm.Move2_PPUps, pkm.Move3_PPUps, pkm.Move4_PPUps}.Any(ppup => ppup > 0))
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
{ AddLine(Severity.Invalid, V319, CheckIdentifier.Misc); }
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.CNTs.Any(stat => stat > 0))
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
{ AddLine(Severity.Invalid, V320, CheckIdentifier.Misc); }
cleanup no functional change
2017-04-15 02:55:40 +00:00
if (pkm.Format == 2 && (pkm.PKRS_Cured || pkm.PKRS_Infected))
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
{ AddLine(Severity.Invalid, V368, CheckIdentifier.Misc); }
var HatchCycles = (EncounterMatch as EncounterStatic)?.EggCycles;
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (HatchCycles == 0 || HatchCycles == null)
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
HatchCycles = pkm.PersonalInfo.HatchCycles;
allow insta-hatch eggs pelago can drain to 0, will hatch immediately on current gen im sure there's some ways to force-walk to trip to 0 on prior gens, but this is such a minor check and has no impact for online play Thanks @Kirzi !
2017-05-28 05:50:10 +00:00
if (pkm.CurrentFriendship > HatchCycles)
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
{ AddLine(Severity.Invalid, V374, CheckIdentifier.Misc); }
Add Egg & Super Training legality checks Closes #220 Thanks @sora10pls !
2016-09-03 15:10:22 +00:00
}
Add more detailed fateful encounter checks find more oddballs Closes #626
2016-12-11 02:55:04 +00:00
if (Encounter.Valid)
Add Fateful Encounter check Cleared up the Event check a little to allow Fateful Encounters to slip through.
2016-04-22 02:32:22 +00:00
{
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
if (Type == typeof(MysteryGift))
Add more detailed fateful encounter checks find more oddballs Closes #626
2016-12-11 02:55:04 +00:00
{
if (pkm.FatefulEncounter)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Valid, V321, CheckIdentifier.Fateful);
Add more detailed fateful encounter checks find more oddballs Closes #626
2016-12-11 02:55:04 +00:00
else
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V322, CheckIdentifier.Fateful);
Add more detailed fateful encounter checks find more oddballs Closes #626
2016-12-11 02:55:04 +00:00
return;
}
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (EncounterMatch is EncounterStatic s)
Add magearna Add fallthrough for events that do not match (fateful/event location) so that magearna can be caught in the static encounter check Add fateful/wishing ribbon checks for Static Encounters Add Gen7 WC6DB beginnings
2016-11-13 17:37:28 +00:00
{
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
var fateful = s.Fateful;
Misc fixes Add a few more locations for cxd, restrict balls for gift pkm, fix cxd fateful gifts (loc 254 not first entry in combobox), add special gift pkm moves (bite for umbreon/eevee), add xd mt battle starters probably needs more work for fateful determination (obedience flag vs 254 met loc).
2017-05-11 07:15:17 +00:00
var shadow = EncounterMatch is EncounterStaticShadow;
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
if (pkm.Gen3 && pkm.WasEgg && !pkm.IsEgg)
Misc fixes Add a few more locations for cxd, restrict balls for gift pkm, fix cxd fateful gifts (loc 254 not first entry in combobox), add special gift pkm moves (bite for umbreon/eevee), add xd mt battle starters probably needs more work for fateful determination (obedience flag vs 254 met loc).
2017-05-11 07:15:17 +00:00
fateful = false; // lost after hatching
else if (shadow && !(pkm is XK3 || pkm is CK3))
fateful = true; // purification required for transfer
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
if (fateful)
Add more detailed fateful encounter checks find more oddballs Closes #626
2016-12-11 02:55:04 +00:00
{
if (pkm.FatefulEncounter)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Valid, V323, CheckIdentifier.Fateful);
Add more detailed fateful encounter checks find more oddballs Closes #626
2016-12-11 02:55:04 +00:00
else
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V324, CheckIdentifier.Fateful);
Add more detailed fateful encounter checks find more oddballs Closes #626
2016-12-11 02:55:04 +00:00
}
Misc fixes Add a few more locations for cxd, restrict balls for gift pkm, fix cxd fateful gifts (loc 254 not first entry in combobox), add special gift pkm moves (bite for umbreon/eevee), add xd mt battle starters probably needs more work for fateful determination (obedience flag vs 254 met loc).
2017-05-11 07:15:17 +00:00
else if (pkm.FatefulEncounter && !shadow)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V325, CheckIdentifier.Fateful);
Add magearna Add fallthrough for events that do not match (fateful/event location) so that magearna can be caught in the static encounter check Add fateful/wishing ribbon checks for Static Encounters Add Gen7 WC6DB beginnings
2016-11-13 17:37:28 +00:00
}
Misc legality checks (gen5-7) (#1020) * Add Flabebe and Pumkaboo altform HA legality check Fix issue #999 The derived value SpecForm can use for other legality checks * Add N's pkm and Hidden Grotto shiny legality checks -fix early return in verifyMisc -add N's pkm legality check: IVs, OT Name, TID, SID, Shiny -add Hidden Grotto shiny check * Fix spelling * More edge cases for gen6 ball checks Ban several altform hidden ability with gen3 ball * Fix gen4 Formcount for altform Manually fix several bytes (http://i.imgur.com/l0Amuto.png)
2017-04-02 13:39:39 +00:00
else if (pkm.FatefulEncounter)
Revert unnecessary change
2017-03-30 22:14:52 +00:00
AddLine(Severity.Invalid, V325, CheckIdentifier.Fateful);
Misc legality checks (gen5-7) (#1020) * Add Flabebe and Pumkaboo altform HA legality check Fix issue #999 The derived value SpecForm can use for other legality checks * Add N's pkm and Hidden Grotto shiny legality checks -fix early return in verifyMisc -add N's pkm legality check: IVs, OT Name, TID, SID, Shiny -add Hidden Grotto shiny check * Fix spelling * More edge cases for gen6 ball checks Ban several altform hidden ability with gen3 ball * Fix gen4 Formcount for altform Manually fix several bytes (http://i.imgur.com/l0Amuto.png)
2017-04-02 13:39:39 +00:00
if (pkm.GenNumber == 5)
Cleanup resharper pretty gud add n sparkle check
2017-03-19 17:44:46 +00:00
{
var enc = EncounterMatch as EncounterStatic;
bool req = enc?.NSparkle ?? false;
Misc legality checks (gen5-7) (#1020) * Add Flabebe and Pumkaboo altform HA legality check Fix issue #999 The derived value SpecForm can use for other legality checks * Add N's pkm and Hidden Grotto shiny legality checks -fix early return in verifyMisc -add N's pkm legality check: IVs, OT Name, TID, SID, Shiny -add Hidden Grotto shiny check * Fix spelling * More edge cases for gen6 ball checks Ban several altform hidden ability with gen3 ball * Fix gen4 Formcount for altform Manually fix several bytes (http://i.imgur.com/l0Amuto.png)
2017-04-02 13:39:39 +00:00
if (pkm.Format == 5)
{
bool has = ((PK5)pkm).NPokémon;
if (req && !has)
AddLine(Severity.Invalid, V326, CheckIdentifier.Fateful);
if (!req && has)
AddLine(Severity.Invalid, V327, CheckIdentifier.Fateful);
}
if (req)
{
if (pkm.IVs.Any(iv => iv != 30))
AddLine(Severity.Invalid, V218, CheckIdentifier.IVs);
if (pkm.OT_Name != "N" || pkm.TID != 00002 || pkm.SID != 00000)
AddLine(Severity.Invalid, V219, CheckIdentifier.Trainer);
if (pkm.IsShiny)
AddLine(Severity.Invalid, V220, CheckIdentifier.Shiny);
}
Cleanup resharper pretty gud add n sparkle check
2017-03-19 17:44:46 +00:00
}
Add Fateful Encounter check Cleared up the Event check a little to allow Fateful Encounters to slip through.
2016-04-22 02:32:22 +00:00
}
}
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
private void verifyVersionEvolution()
{
if (pkm.Format < 7)
return;
// No point using the evolution tree. Just handle certain species.
switch (pkm.Species)
{
case 745: // Lycanroc
if (!pkm.WasEgg)
break;
if (pkm.AltForm == 0 && pkm.Version == 31 // Moon
|| pkm.AltForm == 1 && pkm.Version == 30) // Sun
if (pkm.IsUntraded)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V328, CheckIdentifier.Evolution);
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
break;
case 791: // Solgaleo
if (pkm.Version == 31 && pkm.IsUntraded)
{
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (EncounterMatch is MysteryGift g && g.Species == pkm.Species) // Gifted via Mystery Gift
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
break;
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V328, CheckIdentifier.Evolution);
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
}
break;
case 792: // Lunala
if (pkm.Version == 30 && pkm.IsUntraded)
{
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (EncounterMatch is MysteryGift g && g.Species == pkm.Species) // Gifted via Mystery Gift
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
break;
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V328, CheckIdentifier.Evolution);
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
}
break;
}
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#region verifyMoves
#endregion
Split winforms to separate project resources still are associated with winforms, eh program still runs fine and I've replicated the mono build options. lmk if this breaks stuff
2017-01-08 07:54:09 +00:00
public static string[] movelist = Util.getMovesList("en");
Cleanup reduce nesting & complexity by splitting into smaller methods fetch species list on boot instead of every gen1pkm misc style fixes
2017-04-10 00:43:05 +00:00
public static string[] specieslist = Util.getMovesList("en");
Add CheckIdentifier tostring method Closes #984
2017-03-25 23:38:40 +00:00
/// <summary>
/// Converts a Check result Severity determination (Valid/Invalid/etc) to the localized string.
/// </summary>
/// <param name="s"><see cref="Severity"/> value to convert to string.</param>
/// <returns>Localized <see cref="string"/>.</returns>
private static string getString(Severity s)
{
switch (s)
{
case Severity.Indeterminate: return V500;
case Severity.Invalid: return V501;
case Severity.Fishy: return V502;
case Severity.Valid: return V503;
default: return V504;
}
}
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
}
}
Reference in a new issue Copy permalink