Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-16 00:58:01 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Legality/Checks.cs

2301 lines
100 KiB
C#
Raw Normal View History

Move Legality check rewrite Moved to checks Returns why it's invalid Added base egg move checks -- all eggs need level1 moves, can only be pushed out. The move table acts as a sliding window; grab a list of level1 moves, tack on relearn moves, then observe window view (last 4). Added egg met level check
2016-03-12 17:16:41 +00:00
using System;
using System.Collections.Generic;
using System.Linq;
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
using static PKHeX.Core.LegalityCheckStrings;
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
Split winforms to separate project resources still are associated with winforms, eh program still runs fine and I've replicated the mono build options. lmk if this breaks stuff
2017-01-08 07:54:09 +00:00
namespace PKHeX.Core
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
public partial class LegalityAnalysis
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyGender()
Add gender legality check dirty cheaters Tweaked ECPID to not bypass illegal flag checking if EC/PID were 0.
2016-07-04 01:36:04 +00:00
{
Personal Table per PKM Not by AO only (now works for species > 721)
2016-10-29 06:41:22 +00:00
if (pkm.PersonalInfo.Gender == 255 && pkm.Gender != 2)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V203, CheckIdentifier.Gender);
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
// Check for PID relationship to Gender & Nature if applicable
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
int gen = Info.Generation;
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
bool PIDGender = 3 <= gen && gen <= 5;
if (!PIDGender)
return;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
bool genderValid = pkm.IsGenderValid();
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
if (!genderValid && pkm.Format > 5 && (pkm.Species == 183 || pkm.Species == 184))
{
var gv = pkm.PID & 0xFF;
if (gv > 63 && pkm.Gender == 1) // evolved from azurill after transferring to keep gender
genderValid = true;
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
}
Detect mixed->fixed gender incompatibility Calculate and compare the original encounter's gender's as well. exclude azurill gender change (only case where this can happen) by continuing the if-else. Add Snorunt-Froslass to FixedGenderFromBiGender. Thanks Davil !
2017-10-20 03:56:59 +00:00
else if (3 <= Info.Generation && Info.Generation <= 5)
{
// check for mixed->fixed gender incompatibility by checking the gender of the original species
if (Legal.FixedGenderFromBiGender.Contains(EncounterMatch.Species) && pkm.Gender != 2) // shedinja
{
var gender = PKX.GetGenderFromPID(EncounterMatch.Species, pkm.EncryptionConstant);
genderValid &= gender == pkm.Gender; // gender must not be different from original
}
}
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
if (genderValid)
AddLine(Severity.Valid, V250, CheckIdentifier.Gender);
else
AddLine(Severity.Invalid, V251, CheckIdentifier.Gender);
bool PIDNature = gen != 5;
if (!PIDNature)
return;
Misc ec/pid tweaks use the encryption constant (pk3-5 return PID on get), fix gen4 using gen5 correlation
2017-05-04 06:14:34 +00:00
if (pkm.EncryptionConstant % 25 == pkm.Nature)
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
AddLine(Severity.Valid, V252, CheckIdentifier.Nature);
else
AddLine(Severity.Invalid, V253, CheckIdentifier.Nature);
Add gender legality check dirty cheaters Tweaked ECPID to not bypass illegal flag checking if EC/PID were 0.
2016-07-04 01:36:04 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyItem()
Gen 7 Item Legality Checks For https://github.com/kwsch/PKHeX/issues/891.
2017-02-26 15:55:22 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (!Legal.IsHeldItemAllowed(pkm.HeldItem, pkm.Format))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V204, CheckIdentifier.Form);
E-reader Berry (#1050) * E-Reader berry improvement Load from the savegame the name of the e-reader berry and show in the item list that name instead of enigma berry if there is any e-reader berry data stored Also check Legality of the berry, as enigma berry is unrelead in generation 3, but if there is e-berry data if check if the e-berry name is from one of the released cards * Fix Shedinja moves check in generation 3 format * Update comments, e-berry code is based in Suloku work for the gen 3 wc-tool * Move e-reader comunication with Legality class to Main.cs Remove curly braces in GameInfo * Undo all changes in SaveUtil.cs
2017-04-10 22:59:16 +00:00
if (pkm.Format == 3 && pkm.HeldItem == 175)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyEReaderBerry();
More egg related check changes Properly check for actual held item move unhittable check (verifyMisc isnt called when parsing pk1/pk2; verifyMiscG1 is) add egg PP check, add common method to be shared between gen1 checks and GBA+ #1257
2017-06-21 16:18:33 +00:00
if (pkm.IsEgg && pkm.HeldItem != 0)
Add egg held item check no hold pls #1257
2017-06-21 05:55:05 +00:00
AddLine(Severity.Invalid, V419, CheckIdentifier.Egg);
E-reader Berry (#1050) * E-Reader berry improvement Load from the savegame the name of the e-reader berry and show in the item list that name instead of enigma berry if there is any e-reader berry data stored Also check Legality of the berry, as enigma berry is unrelead in generation 3, but if there is e-berry data if check if the e-berry name is from one of the released cards * Fix Shedinja moves check in generation 3 format * Update comments, e-berry code is based in Suloku work for the gen 3 wc-tool * Move e-reader comunication with Legality class to Main.cs Remove curly braces in GameInfo * Undo all changes in SaveUtil.cs
2017-04-10 22:59:16 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyEReaderBerry()
E-reader Berry (#1050) * E-Reader berry improvement Load from the savegame the name of the e-reader berry and show in the item list that name instead of enigma berry if there is any e-reader berry data stored Also check Legality of the berry, as enigma berry is unrelead in generation 3, but if there is e-berry data if check if the e-berry name is from one of the released cards * Fix Shedinja moves check in generation 3 format * Update comments, e-berry code is based in Suloku work for the gen 3 wc-tool * Move e-reader comunication with Legality class to Main.cs Remove curly braces in GameInfo * Undo all changes in SaveUtil.cs
2017-04-10 22:59:16 +00:00
{
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
if (Legal.EReaderBerryIsEnigma) // no E-Reader berry data provided, can't hold berry.
E-reader Berry (#1050) * E-Reader berry improvement Load from the savegame the name of the e-reader berry and show in the item list that name instead of enigma berry if there is any e-reader berry data stored Also check Legality of the berry, as enigma berry is unrelead in generation 3, but if there is e-berry data if check if the e-berry name is from one of the released cards * Fix Shedinja moves check in generation 3 format * Update comments, e-berry code is based in Suloku work for the gen 3 wc-tool * Move e-reader comunication with Legality class to Main.cs Remove curly braces in GameInfo * Undo all changes in SaveUtil.cs
2017-04-10 22:59:16 +00:00
{
AddLine(Severity.Invalid, V204, CheckIdentifier.Form);
return;
}
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
E-reader Berry (#1050) * E-Reader berry improvement Load from the savegame the name of the e-reader berry and show in the item list that name instead of enigma berry if there is any e-reader berry data stored Also check Legality of the berry, as enigma berry is unrelead in generation 3, but if there is e-berry data if check if the e-berry name is from one of the released cards * Fix Shedinja moves check in generation 3 format * Update comments, e-berry code is based in Suloku work for the gen 3 wc-tool * Move e-reader comunication with Legality class to Main.cs Remove curly braces in GameInfo * Undo all changes in SaveUtil.cs
2017-04-10 22:59:16 +00:00
var matchUSA = Legal.EReaderBerriesNames_USA.Contains(Legal.EReaderBerryName);
var matchJP = Legal.EReaderBerriesNames_JP.Contains(Legal.EReaderBerryName);
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
if (!matchJP && !matchUSA) // Does not match any released E-Reader berry
E-reader Berry (#1050) * E-Reader berry improvement Load from the savegame the name of the e-reader berry and show in the item list that name instead of enigma berry if there is any e-reader berry data stored Also check Legality of the berry, as enigma berry is unrelead in generation 3, but if there is e-berry data if check if the e-berry name is from one of the released cards * Fix Shedinja moves check in generation 3 format * Update comments, e-berry code is based in Suloku work for the gen 3 wc-tool * Move e-reader comunication with Legality class to Main.cs Remove curly braces in GameInfo * Undo all changes in SaveUtil.cs
2017-04-10 22:59:16 +00:00
AddLine(Severity.Invalid, V369, CheckIdentifier.Form);
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
else if (matchJP && !Legal.SavegameJapanese) // E-Reader is region locked
E-reader Berry (#1050) * E-Reader berry improvement Load from the savegame the name of the e-reader berry and show in the item list that name instead of enigma berry if there is any e-reader berry data stored Also check Legality of the berry, as enigma berry is unrelead in generation 3, but if there is e-berry data if check if the e-berry name is from one of the released cards * Fix Shedinja moves check in generation 3 format * Update comments, e-berry code is based in Suloku work for the gen 3 wc-tool * Move e-reader comunication with Legality class to Main.cs Remove curly braces in GameInfo * Undo all changes in SaveUtil.cs
2017-04-10 22:59:16 +00:00
AddLine(Severity.Invalid, V370, CheckIdentifier.Form);
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
else if (matchUSA && Legal.SavegameJapanese) // E-Reader is region locked
E-reader Berry (#1050) * E-Reader berry improvement Load from the savegame the name of the e-reader berry and show in the item list that name instead of enigma berry if there is any e-reader berry data stored Also check Legality of the berry, as enigma berry is unrelead in generation 3, but if there is e-berry data if check if the e-berry name is from one of the released cards * Fix Shedinja moves check in generation 3 format * Update comments, e-berry code is based in Suloku work for the gen 3 wc-tool * Move e-reader comunication with Legality class to Main.cs Remove curly braces in GameInfo * Undo all changes in SaveUtil.cs
2017-04-10 22:59:16 +00:00
AddLine(Severity.Invalid, V371, CheckIdentifier.Form);
Gen 7 Item Legality Checks For https://github.com/kwsch/PKHeX/issues/891.
2017-02-26 15:55:22 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyECPID()
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
if (pkm.Format >= 6)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyEC();
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch.Species == 265)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyECPIDWurmple();
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.PID == 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V207, CheckIdentifier.PID);
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (Info.Generation >= 6 && pkm.PID == pkm.EncryptionConstant)
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
AddLine(Severity.Invalid, V208, CheckIdentifier.PID); // better to flag than 1:2^32 odds since RNG is not feasible to yield match
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
switch (EncounterMatch)
Misc legality checks (gen5-7) (#1020) * Add Flabebe and Pumkaboo altform HA legality check Fix issue #999 The derived value SpecForm can use for other legality checks * Add N's pkm and Hidden Grotto shiny legality checks -fix early return in verifyMisc -add N's pkm legality check: IVs, OT Name, TID, SID, Shiny -add Hidden Grotto shiny check * Fix spelling * More edge cases for gen6 ball checks Ban several altform hidden ability with gen3 ball * Fix gen4 Formcount for altform Manually fix several bytes (http://i.imgur.com/l0Amuto.png)
2017-04-02 13:39:39 +00:00
{
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
case EncounterStatic s:
if (s.Shiny != null && (bool)s.Shiny ^ pkm.IsShiny)
AddLine(Severity.Invalid, V209, CheckIdentifier.Shiny);
Misc updates Add global link mission stats (thanks Holla!) remove some ToArray() linq in favor of direct copies Relocate encounter suggestion logic to separate class Closes #1396, addresses other edge cases like entree-non HA & happiny egg.
2017-08-16 04:16:47 +00:00
// gen5 correlation
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (Info.Generation != 5)
Misc updates Add global link mission stats (thanks Holla!) remove some ToArray() linq in favor of direct copies Relocate encounter suggestion logic to separate class Closes #1396, addresses other edge cases like entree-non HA & happiny egg.
2017-08-16 04:16:47 +00:00
break;
if (s.Location == 75) // Entree Forest
break;
if (s.Gift || s.Roaming || s.Ability != 4)
break;
if (s.NSparkle)
break;
VerifyG5PID_IDCorrelation();
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
break;
case EncounterSlot w:
if (pkm.IsShiny && w.Type == SlotType.HiddenGrotto)
AddLine(Severity.Invalid, V221, CheckIdentifier.Shiny);
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (Info.Generation == 5 && w.Type != SlotType.HiddenGrotto)
Misc fixes/improvements Reduce memory usage for evo method banlist (static banlist references) Fix gen6 mega evo flag truncation simplify QR encode/decode logic a little Don't apply transparency if transparency is already 100% (skip the loop) Add gen5 wild pid/tid-sid correlation check Fix validation value reset (loading gen3-4 pkm without looking at met tab causes the met location to get reset); fixed by prematurely validating before setting the value Fix gen3 pkm with gen4 contest ribbons in gen4/5 getting flagged incorrectly
2017-08-13 07:21:42 +00:00
VerifyG5PID_IDCorrelation();
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
break;
case PCD d: // fixed PID
if (d.Gift.PK.PID != 1 && pkm.EncryptionConstant != d.Gift.PK.PID)
AddLine(Severity.Invalid, V410, CheckIdentifier.Shiny);
break;
Misc legality checks (gen5-7) (#1020) * Add Flabebe and Pumkaboo altform HA legality check Fix issue #999 The derived value SpecForm can use for other legality checks * Add N's pkm and Hidden Grotto shiny legality checks -fix early return in verifyMisc -add N's pkm legality check: IVs, OT Name, TID, SID, Shiny -add Hidden Grotto shiny check * Fix spelling * More edge cases for gen6 ball checks Ban several altform hidden ability with gen3 ball * Fix gen4 Formcount for altform Manually fix several bytes (http://i.imgur.com/l0Amuto.png)
2017-04-02 13:39:39 +00:00
}
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
}
Misc fixes/improvements Reduce memory usage for evo method banlist (static banlist references) Fix gen6 mega evo flag truncation simplify QR encode/decode logic a little Don't apply transparency if transparency is already 100% (skip the loop) Add gen5 wild pid/tid-sid correlation check Fix validation value reset (loading gen3-4 pkm without looking at met tab causes the met location to get reset); fixed by prematurely validating before setting the value Fix gen3 pkm with gen4 contest ribbons in gen4/5 getting flagged incorrectly
2017-08-13 07:21:42 +00:00
private void VerifyG5PID_IDCorrelation()
{
var pid = pkm.EncryptionConstant;
var result = (pid & 1) ^ (pid >> 31) ^ (pkm.TID & 1) ^ (pkm.SID & 1);
if (result != 0)
AddLine(Severity.Invalid, V411, CheckIdentifier.PID);
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyECPIDWurmple()
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
{
Fix wurmple evo gen3/4 yeah it was never the lowest 16 bits as every-internet-source claims. 1D9C9130 silcoon => 3716[8] = cascoon (nope) #1330 was correct!
2017-07-17 22:58:09 +00:00
uint evoVal = PKX.GetWurmpleEvoVal(pkm.EncryptionConstant);
Current progress Still a few milestones left to hit before official release.
2016-06-20 04:22:43 +00:00
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
if (pkm.Species == 265)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
AddLine(Severity.Valid, string.Format(V212, evoVal == 0 ? SpeciesStrings[267] : SpeciesStrings[269]), CheckIdentifier.EC);
Misc gen3 related legal check fixes
2017-05-28 22:49:20 +00:00
else if (evoVal != Array.IndexOf(Legal.WurmpleEvolutions, pkm.Species) / 2)
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
AddLine(Severity.Invalid, V210, CheckIdentifier.EC);
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyEC()
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
{
if (pkm.EncryptionConstant == 0)
AddLine(Severity.Fishy, V201, CheckIdentifier.EC);
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (3 <= Info.Generation && Info.Generation <= 5)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyTransferEC();
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
else
More strict checks Only fishy adds. Matching TID/SID Matching PID/EC Matching EXP/Level
2016-04-08 00:56:39 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
int xor = pkm.TSV ^ pkm.PSV;
if (xor < 16 && xor >= 8 && (pkm.PID ^ 0x80000000) == pkm.EncryptionConstant)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V211, CheckIdentifier.EC);
More strict checks Only fishy adds. Matching TID/SID Matching PID/EC Matching EXP/Level
2016-04-08 00:56:39 +00:00
}
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyTransferEC()
Simplify some legality checks wurmple check expanded to work for all gens, ECPID broken up into smaller methods silcoon/cascoon string use the specieslist to fetch localized name
2017-04-11 02:00:58 +00:00
{
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
// When transferred to Generation 6, the Encryption Constant is copied from the PID.
// The PID is then checked to see if it becomes shiny with the new Shiny rules (>>4 instead of >>3)
// If the PID is nonshiny->shiny, the top bit is flipped.
// Check to see if the PID and EC are properly configured.
Fix unused legality check (3/4/5th gen only) Thanks Sabresite!
2016-12-23 02:18:35 +00:00
bool xorPID = ((pkm.TID ^ pkm.SID ^ (int)(pkm.PID & 0xFFFF) ^ (int)(pkm.PID >> 16)) & ~0x7) == 8;
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
bool valid = xorPID
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
? pkm.EncryptionConstant == (pkm.PID ^ 0x8000000)
: pkm.EncryptionConstant == pkm.PID;
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
if (!valid)
Refactoring Rewrote showdown set exporting to be much clearer, added auto-fixing of relearn moves when importing showdown set (applies suggested relearn moves) Simplified main form loading routine (from ~160 to ~25 by extracting methods)
2017-06-18 20:02:02 +00:00
AddLine(Severity.Invalid, xorPID ? V215 : V216, CheckIdentifier.EC);
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
}
Korean language restrictions Restriction happens because Korean can not trade with non-Korean GB era games - There is no Korean release for gen 1 pokemon, included VC - With no gen1 pokemon means any Korean gen2 is Gen2_NotTradeback, that means no gen1 origin nor moves are Legal - Crystal was never released in Korean - Pokemon Stadium 2 was never released in Korean, that means no move reminder for gen 2 korean pokemon - Generation 4 can not trade between Korean and not Korean games, but Korean games can use the palpark with any language Chinese language restrictions There is no Chinese release for gen 1 and 2 pokemon games, VC Chinese games are in Japanese
2017-09-23 18:46:10 +00:00
#region verifyLanguage
Refactoring slight simplification related to #1486
2017-09-23 23:24:22 +00:00
private bool VerifyLanguage()
Korean language restrictions Restriction happens because Korean can not trade with non-Korean GB era games - There is no Korean release for gen 1 pokemon, included VC - With no gen1 pokemon means any Korean gen2 is Gen2_NotTradeback, that means no gen1 origin nor moves are Legal - Crystal was never released in Korean - Pokemon Stadium 2 was never released in Korean, that means no move reminder for gen 2 korean pokemon - Generation 4 can not trade between Korean and not Korean games, but Korean games can use the palpark with any language Chinese language restrictions There is no Chinese release for gen 1 and 2 pokemon games, VC Chinese games are in Japanese
2017-09-23 18:46:10 +00:00
{
int maxLanguageID = Legal.GetMaxLanguageID(Info.Generation);
Refactoring slight simplification related to #1486
2017-09-23 23:24:22 +00:00
// Language ID 6 is unused; flag if an impossible language is used
Add LanguageID enum no functional change, just less-magic-numbers for easier to understand src
2017-10-23 04:01:08 +00:00
if (pkm.Language == (int)LanguageID.UNUSED_6 || pkm.Language > maxLanguageID)
Korean language restrictions Restriction happens because Korean can not trade with non-Korean GB era games - There is no Korean release for gen 1 pokemon, included VC - With no gen1 pokemon means any Korean gen2 is Gen2_NotTradeback, that means no gen1 origin nor moves are Legal - Crystal was never released in Korean - Pokemon Stadium 2 was never released in Korean, that means no move reminder for gen 2 korean pokemon - Generation 4 can not trade between Korean and not Korean games, but Korean games can use the palpark with any language Chinese language restrictions There is no Chinese release for gen 1 and 2 pokemon games, VC Chinese games are in Japanese
2017-09-23 18:46:10 +00:00
{
interpolation++ no functional change (assumed)
2017-09-30 05:58:25 +00:00
AddLine(Severity.Invalid, string.Format(V5, $"<={maxLanguageID}", pkm.Language), CheckIdentifier.Language);
Korean language restrictions Restriction happens because Korean can not trade with non-Korean GB era games - There is no Korean release for gen 1 pokemon, included VC - With no gen1 pokemon means any Korean gen2 is Gen2_NotTradeback, that means no gen1 origin nor moves are Legal - Crystal was never released in Korean - Pokemon Stadium 2 was never released in Korean, that means no move reminder for gen 2 korean pokemon - Generation 4 can not trade between Korean and not Korean games, but Korean games can use the palpark with any language Chinese language restrictions There is no Chinese release for gen 1 and 2 pokemon games, VC Chinese games are in Japanese
2017-09-23 18:46:10 +00:00
return false;
}
Refactoring slight simplification related to #1486
2017-09-23 23:24:22 +00:00
// Korean Gen4 games can not trade with other Gen4 languages, but can use Pal Park with any Gen3 game/language.
Add LanguageID enum no functional change, just less-magic-numbers for easier to understand src
2017-10-23 04:01:08 +00:00
if (pkm.Format == 4 && pkm.Gen4 &&
(pkm.Language == (int)LanguageID.Korean) ^ (Legal.SavegameLanguage == (int)LanguageID.Korean))
Refactoring slight simplification related to #1486
2017-09-23 23:24:22 +00:00
{
Add LanguageID enum no functional change, just less-magic-numbers for easier to understand src
2017-10-23 04:01:08 +00:00
bool kor = pkm.Language == (int) LanguageID.Korean;
var currentpkm = kor ? V611 : V612;
var currentsav = kor ? V612 : V611;
Refactoring slight simplification related to #1486
2017-09-23 23:24:22 +00:00
AddLine(Severity.Invalid, string.Format(V610, currentpkm, currentsav), CheckIdentifier.Language);
return false;
}
// Korean Crystal does not exist
if (pkm.Version == (int)GameVersion.C && pkm.Korean)
Korean language restrictions Restriction happens because Korean can not trade with non-Korean GB era games - There is no Korean release for gen 1 pokemon, included VC - With no gen1 pokemon means any Korean gen2 is Gen2_NotTradeback, that means no gen1 origin nor moves are Legal - Crystal was never released in Korean - Pokemon Stadium 2 was never released in Korean, that means no move reminder for gen 2 korean pokemon - Generation 4 can not trade between Korean and not Korean games, but Korean games can use the palpark with any language Chinese language restrictions There is no Chinese release for gen 1 and 2 pokemon games, VC Chinese games are in Japanese
2017-09-23 18:46:10 +00:00
{
interpolation++ no functional change (assumed)
2017-09-30 05:58:25 +00:00
AddLine(Severity.Invalid, string.Format(V5, $"!={pkm.Language}", pkm.Language), CheckIdentifier.Language);
Korean language restrictions Restriction happens because Korean can not trade with non-Korean GB era games - There is no Korean release for gen 1 pokemon, included VC - With no gen1 pokemon means any Korean gen2 is Gen2_NotTradeback, that means no gen1 origin nor moves are Legal - Crystal was never released in Korean - Pokemon Stadium 2 was never released in Korean, that means no move reminder for gen 2 korean pokemon - Generation 4 can not trade between Korean and not Korean games, but Korean games can use the palpark with any language Chinese language restrictions There is no Chinese release for gen 1 and 2 pokemon games, VC Chinese games are in Japanese
2017-09-23 18:46:10 +00:00
return false;
}
return true;
}
#endregion
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#region verifyNickname
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyNickname()
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
// If the Pokémon is not nicknamed, it should match one of the language strings.
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.Nickname.Length == 0)
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V2, CheckIdentifier.Nickname);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
if (pkm.Species > PKX.SpeciesLang[0].Length)
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Indeterminate, V3, CheckIdentifier.Nickname);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Improve gen1/2 invalid string detection also spit out recommended TID/SID for c/xd starters Closes #1443
2017-09-08 04:42:05 +00:00
if (pkm.VC && pkm.IsNicknamed)
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
{
Improve gen1/2 invalid string detection also spit out recommended TID/SID for c/xd starters Closes #1443
2017-09-08 04:42:05 +00:00
VerifyG1NicknameWithinBounds(pkm.Nickname);
Add event nicknamed fishy flag Also updates lang translations for incorrect/missing strings (ps: uncomment the line in main to copy the current localization strings to clipboard for ez paste replace into notepad)
2017-04-09 23:38:29 +00:00
}
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
else if (EncounterMatch is MysteryGift m)
Add event nicknamed fishy flag Also updates lang translations for incorrect/missing strings (ps: uncomment the line in main to copy the current localization strings to clipboard for ez paste replace into notepad)
2017-04-09 23:38:29 +00:00
{
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
if (pkm.IsNicknamed && !m.IsEgg)
Add event nicknamed fishy flag Also updates lang translations for incorrect/missing strings (ps: uncomment the line in main to copy the current localization strings to clipboard for ez paste replace into notepad)
2017-04-09 23:38:29 +00:00
AddLine(Severity.Fishy, V0, CheckIdentifier.Nickname);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
}
Tweak nickname check severity
2016-03-20 01:06:02 +00:00
if (!Encounter.Valid)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Refactoring slight simplification related to #1486
2017-09-23 23:24:22 +00:00
if (!VerifyLanguage())
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Refactoring Simplify EncounterStatic type check as it is gen4 specific -> gen4 specific child class Checks.cs: Move transfer legality check back to end as Gen4Result needs to be defined (not null) Rename EncounterType of Analysis class to avoid conflict with the EncounterType enum
2017-04-22 20:04:12 +00:00
if (Type == typeof(EncounterTrade))
Add Ingame Trade OT/Nick check
2016-03-27 00:23:53 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyNicknameTrade();
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add Ingame Trade OT/Nick check
2016-03-27 00:23:53 +00:00
}
Tweak nickname check severity
2016-03-20 01:06:02 +00:00
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.IsEgg)
Add Egg name checks
2016-03-16 04:15:40 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyNicknameEgg();
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add Egg name checks
2016-03-16 04:15:40 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
string nickname = pkm.Nickname.Replace("'", "’");
if (pkm.IsNicknamed)
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Tweak nickname check severity
2016-03-20 01:06:02 +00:00
for (int i = 0; i < PKX.SpeciesLang.Length; i++)
{
misc tweaks dictionary species check, max deviation beginnings for USUM simplification for gen1/2 pokemonlists
2017-10-06 05:37:45 +00:00
if (!PKX.SpeciesDict[i].TryGetValue(nickname, out int index))
Tweak nickname check severity
2016-03-20 01:06:02 +00:00
continue;
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
AddLine(Severity.Fishy, index == pkm.Species && i != pkm.Language
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
? V15
: V16, CheckIdentifier.Nickname);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Tweak nickname check severity
2016-03-20 01:06:02 +00:00
}
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
if (nickname.Any(c => 0x4E00 <= c && c <= 0x9FFF)) // East Asian Scripts
{
AddLine(Severity.Invalid, V222, CheckIdentifier.Nickname);
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V17, CheckIdentifier.Nickname);
Add Nickname legality check
2016-03-16 01:56:18 +00:00
}
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
else if (pkm.Format < 3)
{
// pk1/pk2 IsNicknamed getter checks for match, logic should only reach here if matches.
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V18, CheckIdentifier.Nickname);
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
}
else
Add Nickname legality check
2016-03-16 01:56:18 +00:00
{
Fix foreign traded hatched egg species name Language/Geolocation does not get modified when an egg hatches. Thanks @NotRaia
2016-07-11 05:22:55 +00:00
// Can't have another language name if it hasn't evolved or wasn't a language-traded egg.
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
bool evolved = Legal.IsNotBaseSpecies(pkm);
bool match = PKX.GetSpeciesNameGeneration(pkm.Species, pkm.Language, pkm.Format) == nickname;
Fix nickname check when traded between languages
2017-04-10 01:28:22 +00:00
if (pkm.WasTradedEgg || evolved)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
match |= !PKX.IsNicknamedAnyLanguage(pkm.Species, nickname, pkm.Format);
Fix nickname check when traded between languages
2017-04-10 01:28:22 +00:00
if (!match && pkm.Format == 5 && !pkm.IsNative) // transfer
{
if (evolved)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
match |= !PKX.IsNicknamedAnyLanguage(pkm.Species, nickname, 4);
Fix nickname check when traded between languages
2017-04-10 01:28:22 +00:00
else
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
match |= PKX.GetSpeciesNameGeneration(pkm.Species, pkm.Language, 4) == nickname;
Fix nickname check when traded between languages
2017-04-10 01:28:22 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (!match)
Add exclusion for greninja demo gift Closes #869
2017-02-21 06:03:07 +00:00
{
if ((EncounterMatch as MysteryGift)?.CardID == 2046 && (pkm.SID << 16 | pkm.TID) == 0x79F57B49)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V19, CheckIdentifier.Nickname);
Add exclusion for greninja demo gift Closes #869
2017-02-21 06:03:07 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V20, CheckIdentifier.Nickname);
Add exclusion for greninja demo gift Closes #869
2017-02-21 06:03:07 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V18, CheckIdentifier.Nickname);
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
}
Add wordfilter legality checking WordFilter checking is enabled by default, and is absolutely slow (regex checking 3,800 patterns for 3 different strings). Utilize a dictionary to store previously computed values. Seems to alleviate the massive slow-down. Closes #1442
2017-09-06 06:31:24 +00:00
// Non-nicknamed strings have already been checked.
if (Legal.CheckWordFilter && pkm.IsNicknamed && WordFilter.IsFiltered(nickname, out string bad))
AddLine(Severity.Invalid, $"Wordfilter: {bad}", CheckIdentifier.Nickname);
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyNicknameEgg()
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
{
Handle gen4 egg nickname edge case Egg is not saved as "EGG", it is "Egg". Nice job gf. Instead of ignoring the nickname flag, detect if it should be used or not. Gen4 never uses it. Gen7 doesn't use it when it's a gift, but uses it for daycare eggs (...). Closes #1100
2017-05-10 04:11:13 +00:00
switch (pkm.Format)
{
case 4:
if (pkm.IsNicknamed) // gen4 doesn't use the nickname flag for eggs
AddLine(Severity.Invalid, V224, CheckIdentifier.Egg);
break;
case 7:
if (EncounterMatch is EncounterStatic ^ !pkm.IsNicknamed) // gen7 doesn't use for ingame gifts
AddLine(Severity.Invalid, pkm.IsNicknamed ? V224 : V12, CheckIdentifier.Egg);
break;
default:
if (!pkm.IsNicknamed)
AddLine(Severity.Invalid, V12, CheckIdentifier.Egg);
break;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (pkm.Format == 2 && pkm.IsEgg && !PKX.IsNicknamedAnyLanguage(0, pkm.Nickname, 2))
Misc gen2 fixes still a few problems left: surf encounters roamer met locations national park encounters lake of rage all-gyarados encounters (?) #1221
2017-06-13 05:16:20 +00:00
AddLine(Severity.Valid, V14, CheckIdentifier.Egg);
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
else if (PKX.GetSpeciesNameGeneration(0, pkm.Language, Info.Generation) != pkm.Nickname)
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
AddLine(Severity.Invalid, V13, CheckIdentifier.Egg);
else
AddLine(Severity.Valid, V14, CheckIdentifier.Egg);
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyNicknameTrade()
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
{
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
switch (Info.Generation)
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
{
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
case 1:
case 2: VerifyTrade12(); return;
encounter additions add ingame trade data add placeholder SOS data containers add refs to all wild encounters (pelago is same as sm) unmark some todo's
2017-11-08 23:07:04 +00:00
case 3: VerifyTrade3(); return;
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
case 4: VerifyTrade4(); return;
encounter additions add ingame trade data add placeholder SOS data containers add refs to all wild encounters (pelago is same as sm) unmark some todo's
2017-11-08 23:07:04 +00:00
case 5: VerifyTrade5(); return;
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
case 6: VerifyTrade6(); return;
case 7: VerifyTrade7(); return;
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
}
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
}
private void VerifyTrade12()
{
var et = (EncounterOriginalGB ?? EncounterMatch) as EncounterTrade;
if (et?.TID != 0) // Gen2 Trade
return; // already checked all relevant properties when fetching with getValidEncounterTradeVC2
if (!EncounterGenerator.IsEncounterTrade1Valid(pkm))
AddLine(Severity.Invalid, V10, CheckIdentifier.Trainer);
}
Add gen3 nick/OT info #1249
2017-10-29 02:51:55 +00:00
private void VerifyTrade3()
{
if (pkm.FRLG)
VerifyTradeTable(Encounters3.TradeFRLG, Encounters3.TradeGift_FRLG);
else
VerifyTradeTable(Encounters3.TradeRSE, Encounters3.TradeGift_RSE);
}
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
private void VerifyTrade4()
{
if (pkm.TID == 1000)
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
{
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
VerifyTrade4Ranch();
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
return;
}
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
if (pkm.HGSS)
Add gen4 nick/OT info #1249
2017-10-29 02:02:18 +00:00
VerifyTradeTable(Encounters4.TradeHGSS, Encounters4.TradeGift_HGSS);
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
else
Add gen4 nick/OT info #1249
2017-10-29 02:02:18 +00:00
{
if (EncounterMatch.Species == 129) // Magikarp
Add gen5 nick/OT info (trades) #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.
2017-10-29 04:43:47 +00:00
VerifyTradeTable(Encounters4.TradeDPPt, Encounters4.TradeGift_DPPt, pkm.Nickname);
Add gen4 nick/OT info #1249
2017-10-29 02:02:18 +00:00
else
VerifyTradeTable(Encounters4.TradeDPPt, Encounters4.TradeGift_DPPt);
}
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
}
private void VerifyTrade5()
{
// Trades for JPN games have language ID of 0, not 1.
if (pkm.BW)
Misc languageID legality checking update Checks for max language ID on transferred pkm (gen5 pkm on gen7 can't have CHS/CHT etc) handles edge case for JPN B/W ingame trades update pk5->pk6 transfer logic to bump langID 0 to 1. Thanks HaxAras & Britty for providing samples!
2017-09-16 00:43:31 +00:00
{
Add gen5 nick/OT info (trades) #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.
2017-10-29 04:43:47 +00:00
int lang = pkm.Language;
if (pkm.Format == 5 && lang == (int)LanguageID.Japanese)
Add LanguageID enum no functional change, just less-magic-numbers for easier to understand src
2017-10-23 04:01:08 +00:00
AddLine(Severity.Invalid, string.Format(V5, 0, (int)LanguageID.Japanese), CheckIdentifier.Language);
Misc languageID legality checking update Checks for max language ID on transferred pkm (gen5 pkm on gen7 can't have CHS/CHT etc) handles edge case for JPN B/W ingame trades update pk5->pk6 transfer logic to bump langID 0 to 1. Thanks HaxAras & Britty for providing samples!
2017-09-16 00:43:31 +00:00
Add gen5 nick/OT info (trades) #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.
2017-10-29 04:43:47 +00:00
lang = Math.Max(lang, 1);
VerifyTradeTable(Encounters5.TradeBW, Encounters5.TradeGift_BW, lang);
General Fixes (#1005) * Fix FRLG Viapois Chamber Location * Gen 3 In-game Trade Fixes 3rd Gen Trades still need changes to verifyNicknameTrade to work though. Temporarily suppressed the legality warning. It seems Bulbapedia may have some mistakes? * Fix Squirtle Gift in HGSS
2017-03-28 09:02:46 +00:00
}
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
else // B2W2
Add gen5 nick/OT info (trades) #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.
2017-10-29 04:43:47 +00:00
{
if (Encounters5.TradeGift_B2W2_YancyCurtis.Contains(EncounterMatch))
VerifyTradeOTOnly(pkm.OT_Gender == 0 ? Encounters5.TradeOT_B2W2_M : Encounters5.TradeOT_B2W2_F);
else
VerifyTradeTable(Encounters5.TradeB2W2, Encounters5.TradeGift_B2W2);
}
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
}
private void VerifyTrade6()
{
if (pkm.XY)
Add gen5 nick/OT info (trades) #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.
2017-10-29 04:43:47 +00:00
VerifyTradeTable(Encounters6.TradeXY, Encounters6.TradeGift_XY, pkm.Language);
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
else if (pkm.AO)
Add gen5 nick/OT info (trades) #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.
2017-10-29 04:43:47 +00:00
VerifyTradeTable(Encounters6.TradeAO, Encounters6.TradeGift_AO, pkm.Language);
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
}
private void VerifyTrade7()
{
if (pkm.SM)
add gen7 nick ot (trades) #1249 todo usum table when appropriate
2017-10-29 06:04:02 +00:00
VerifyTradeTable(Encounters7.TradeSM, Encounters7.TradeGift_SM, pkm.Language);
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
else if (pkm.USUM)
add gen7 nick ot (trades) #1249 todo usum table when appropriate
2017-10-29 06:04:02 +00:00
VerifyTradeTable(Encounters7.TradeUSUM, Encounters7.TradeGift_USUM, pkm.Language);
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
}
Add gen5 nick/OT info (trades) #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.
2017-10-29 04:43:47 +00:00
private void VerifyTrade4Ranch() => VerifyTradeOTOnly(Encounters4.RanchOTNames);
private void VerifyTradeTable(string[][] ots, EncounterTrade[] table) => VerifyTradeTable(ots, table, pkm.Language);
private void VerifyTradeTable(string[][] ots, EncounterTrade[] table, int language)
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
{
Add gen5 nick/OT info (trades) #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.
2017-10-29 04:43:47 +00:00
var validOT = language >= ots.Length ? ots[0] : ots[pkm.Language];
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
var index = Array.IndexOf(table, EncounterMatch);
VerifyTradeOTNick(validOT, index);
}
Add gen5 nick/OT info (trades) #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.
2017-10-29 04:43:47 +00:00
private void VerifyTradeTable(string[][] ots, EncounterTrade[] table, string nickname)
Add gen4 nick/OT info #1249
2017-10-29 02:02:18 +00:00
{
// edge case method for Foppa (DPPt Magikarp Trade)
var index = Array.IndexOf(table, EncounterMatch);
Add gen5 nick/OT info (trades) #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.
2017-10-29 04:43:47 +00:00
var validOT = ots.FirstOrDefault(z => index < z.Length && z[index] == nickname);
Add gen4 nick/OT info #1249
2017-10-29 02:02:18 +00:00
VerifyTradeOTNick(validOT, index);
}
Add gen5 nick/OT info (trades) #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.
2017-10-29 04:43:47 +00:00
private void VerifyTradeOTOnly(string[] validOT)
{
if (pkm.IsNicknamed)
AddLine(Severity.Invalid, V9, CheckIdentifier.Nickname);
int lang = pkm.Language;
Flip Valid Trade OT Compare Operator Related: https://projectpokemon.org/home/forums/topic/42528-bw2-in-game-trades-yancycurtis-20171117/
2017-11-17 15:57:55 +00:00
if (validOT.Length <= lang)
Add gen5 nick/OT info (trades) #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.
2017-10-29 04:43:47 +00:00
AddLine(Severity.Invalid, V8, CheckIdentifier.Trainer);
else if (validOT[lang] != pkm.OT_Name)
AddLine(Severity.Invalid, V10, CheckIdentifier.Trainer);
else
AddLine(Severity.Valid, V11, CheckIdentifier.Nickname);
}
Split trade encounter nick/OT verification methods #1249
2017-10-28 20:15:51 +00:00
private void VerifyTradeOTNick(string[] validOT, int index)
{
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
if (validOT.Length == 0)
{
AddLine(Severity.Indeterminate, V7, CheckIdentifier.Trainer);
return;
}
if (index == -1 || validOT.Length < index * 2)
{
AddLine(Severity.Indeterminate, V8, CheckIdentifier.Trainer);
return;
}
string nick = validOT[index];
string OT = validOT[validOT.Length / 2 + index];
Add nickname flag override for encountertrade closes #1649
2017-11-22 16:11:53 +00:00
if (nick != pkm.Nickname
&& !(nick == "Quacklin’" && pkm.Nickname == "Quacklin'") // apostrophe farfetch'd edge case
&& ((EncounterTrade)EncounterMatch).IsNicknamed) // trades that are not nicknamed (but are present in a table with others being named)
Add gen5 nick/OT info (trades) #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.
2017-10-29 04:43:47 +00:00
AddLine(Severity.Invalid, V9, CheckIdentifier.Nickname);
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
else
AddLine(Severity.Valid, V11, CheckIdentifier.Nickname);
Add gen4 nick/OT info #1249
2017-10-29 02:02:18 +00:00
if (OT != pkm.OT_Name)
AddLine(Severity.Invalid, V10, CheckIdentifier.Trainer);
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#endregion
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyEVs()
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
var evs = pkm.EVs;
Refactoring Tanabata Jirachi has an underleveled move (illegal), so we have to track some data. Move LegalityCheck back into LegalityAnalysis, but in a separate file still.
2016-03-14 03:19:04 +00:00
int sum = evs.Sum();
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
if (sum > 0 && pkm.IsEgg)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V22, CheckIdentifier.EVs);
Add gen1/2 EV checks
2017-06-27 03:12:49 +00:00
if (pkm.Format >= 3 && sum > 510)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V25, CheckIdentifier.EVs);
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
if (pkm.Format >= 6 && evs.Any(ev => ev > 252))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V26, CheckIdentifier.EVs);
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (pkm.Format == 4 && pkm.Gen4 && EncounterMatch.LevelMin == 100)
Various legallity checks added and fixed (#1049) * Fix required move count for Butterfree and Gyarados * Ruby Sapphire Southern Island legendaries do not have fateful encounter * Added missing event egg for generation 3 Filter generation 3 event egg by game origin, an egg pokemon remains with the original game no matter in what game it hached * Filter the event egg static table better than individual pokemon from the table * Generation 4 do not allow to EV train at level 100, for level 100 encounter pokemon (like events) EV only can be trained with vitamins, with a maximum value of 100 * Fix incorrect string * Generation 2 eggs can not be infected with Pokérus * Fix gyarados count slots
2017-04-10 12:11:07 +00:00
{
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
// Cannot EV train at level 100 -- Certain events are distributed at level 100.
if (evs.Any(ev => ev > 100)) // EVs can only be increased by vitamins to a max of 100.
Various legallity checks added and fixed (#1049) * Fix required move count for Butterfree and Gyarados * Ruby Sapphire Southern Island legendaries do not have fateful encounter * Added missing event egg for generation 3 Filter generation 3 event egg by game origin, an egg pokemon remains with the original game no matter in what game it hached * Filter the event egg static table better than individual pokemon from the table * Generation 4 do not allow to EV train at level 100, for level 100 encounter pokemon (like events) EV only can be trained with vitamins, with a maximum value of 100 * Fix incorrect string * Generation 2 eggs can not be infected with Pokérus * Fix gyarados count slots
2017-04-10 12:11:07 +00:00
AddLine(Severity.Invalid, V367, CheckIdentifier.EVs);
}
Fix misc legality issues Closes #1273 not noted anywhere was encounterstatic pikachu on gen6 (pokewalker->6) would get flagged.
2017-06-25 00:24:32 +00:00
else if (pkm.Format < 5)
Add gen1-4 EV check for untrained pkm Rework some checks for eggs, closes #1248 GetEggHatchLevel uses Format instead of Generation; should only be used on IsEgg=true pkm
2017-06-19 04:13:53 +00:00
{
Allow EV yields for gen1/2 untrained abusing daycare https://projectpokemon.org/home/forums/topic/41788-pk2-gets-dinged-for-having-too-many-evs-at-starting-levelxp/
2017-10-07 15:23:05 +00:00
// In Generations I and II, when a Pokémon is taken out of the Day Care, its experience will lower to the minimum value for its current level.
if (pkm.Format < 3) // can abuse daycare for EV training without EXP gain
return;
const int maxEV = 100; // Vitamin Max
Add gen1-4 EV check for untrained pkm Rework some checks for eggs, closes #1248 GetEggHatchLevel uses Format instead of Generation; should only be used on IsEgg=true pkm
2017-06-19 04:13:53 +00:00
if (PKX.GetEXP(EncounterMatch.LevelMin, pkm.Species) == pkm.EXP && evs.Any(ev => ev > maxEV))
AddLine(Severity.Invalid, string.Format(V418, maxEV), CheckIdentifier.EVs);
}
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
// Only one of the following can be true: 0, 508, and x%6!=0
Tighten met level check with hasoriginal #1261
2017-06-22 03:47:07 +00:00
if (sum == 0 && !EncounterMatch.IsWithinRange(pkm))
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
AddLine(Severity.Fishy, V23, CheckIdentifier.EVs);
else if (sum == 508)
AddLine(Severity.Fishy, V24, CheckIdentifier.EVs);
else if (evs[0] != 0 && evs.All(ev => evs[0] == ev))
AddLine(Severity.Fishy, V27, CheckIdentifier.EVs);
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyIVs()
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (EncounterMatch is EncounterStatic s && s.IV3)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Add gen1->gen7 IV legality check Also fix gen1/2 evo tree trimming error, thanks BeyondTheHorizon! Also fix an exception when no static encounter can be generated for 1->7, match is now generated by checking gen1 and reusing the static encounter creation info (now moved to core).
2017-03-10 04:27:03 +00:00
int IVCount = 3;
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (s.Version == GameVersion.RBY && pkm.Species == 151)
Add gen1->gen7 IV legality check Also fix gen1/2 evo tree trimming error, thanks BeyondTheHorizon! Also fix an exception when no static encounter can be generated for 1->7, match is now generated by checking gen1 and reusing the static encounter creation info (now moved to core).
2017-03-10 04:27:03 +00:00
IVCount = 5; // VC Mew
if (pkm.IVs.Count(iv => iv == 31) < IVCount)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V28, IVCount), CheckIdentifier.IVs);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
}
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterSlot w && w.Type == SlotType.FriendSafari)
Add friend safari IV check 2 IVs have to be flawless
2017-01-01 01:20:13 +00:00
{
if (pkm.IVs.Count(iv => iv == 31) < 2)
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V29, CheckIdentifier.IVs);
Add friend safari IV check 2 IVs have to be flawless
2017-01-01 01:20:13 +00:00
return;
}
}
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (EncounterMatch is MysteryGift g)
Add WC6/WC7 IV check Closes thread 40025
2017-02-02 05:27:14 +00:00
{
int[] IVs;
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
switch (g.Format)
Add WC6/WC7 IV check Closes thread 40025
2017-02-02 05:27:14 +00:00
{
case 7: IVs = ((WC7)EncounterMatch).IVs; break;
Add gen1->gen7 IV legality check Also fix gen1/2 evo tree trimming error, thanks BeyondTheHorizon! Also fix an exception when no static encounter can be generated for 1->7, match is now generated by checking gen1 and reusing the static encounter creation info (now moved to core).
2017-03-10 04:27:03 +00:00
case 6: IVs = ((WC6)EncounterMatch).IVs; break;
case 5: IVs = ((PGF)EncounterMatch).IVs; break;
Add WC6/WC7 IV check Closes thread 40025
2017-02-02 05:27:14 +00:00
default: IVs = null; break;
}
if (IVs != null)
{
var pkIVs = pkm.IVs;
bool valid = true;
for (int i = 0; i < 6; i++)
if (IVs[i] <= 31 && IVs[i] != pkIVs[i])
valid = false;
if (!valid)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V30, CheckIdentifier.IVs);
Misc fixes & Some tweaks for legality check (#1044) * Add gen3-6 unreleased items * Fix string converter fix traditional chinese char offset fix out-of-range crash * Fix ivs and ability check for VC transfer Refetch the static enconter for VC transfer after moves checks update legality string translation impl non-HA ability matching * Add ivs legality check for wc gift
2017-04-10 04:59:44 +00:00
bool IV3 = IVs[0] == 0xFE;
if (IV3 && pkm.IVs.Count(iv => iv == 31) < 3)
AddLine(Severity.Invalid, string.Format(V28, 3), CheckIdentifier.IVs);
Add WC6/WC7 IV check Closes thread 40025
2017-02-02 05:27:14 +00:00
}
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.IVs.Sum() == 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V31, CheckIdentifier.IVs);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else if (pkm.IVs[0] < 30 && pkm.IVs.All(iv => pkm.IVs[0] == iv))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V32, CheckIdentifier.IVs);
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyDVs()
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
{
// todo
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
#region VerifyOT
private void VerifyOT()
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
{
Refactoring Simplify EncounterStatic type check as it is gen4 specific -> gen4 specific child class Checks.cs: Move transfer legality check back to end as Gen4Result needs to be defined (not null) Rename EncounterType of Analysis class to avoid conflict with the EncounterType enum
2017-04-22 20:04:12 +00:00
if (Type == typeof(EncounterTrade))
Misc fixes gen5 N pkm already checked, don't flag SID mystery gift non-eggs already checked, don't flag SID add used DNA splicers to b2w2 permitted key item list fix b2w2 new-altform movesets; kyurem is tricky where the form does not exist in bw's moveset, so both indexes have to be used. Closes #1211 , thanks @sora10pls !
2017-06-10 00:52:20 +00:00
return; // Already matches Encounter information
if (EncounterMatch is MysteryGift g && !g.IsEgg)
return; // Already matches Encounter information
if (EncounterMatch is EncounterStatic s && s.NSparkle)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return; // Already checked by VerifyMisc
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
Add OT too short check apparently some people can be this oblivious
2017-10-16 01:11:20 +00:00
var ot = pkm.OT_Name;
if (ot.Length == 0)
AddLine(Severity.Invalid, V106, CheckIdentifier.Trainer);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.TID == 0 && pkm.SID == 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V33, CheckIdentifier.Trainer);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
else if (pkm.VC)
{
if (pkm.SID != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V34, CheckIdentifier.Trainer);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else if (pkm.TID == pkm.SID)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V35, CheckIdentifier.Trainer);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else if (pkm.TID == 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V36, CheckIdentifier.Trainer);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else if (pkm.SID == 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V37, CheckIdentifier.Trainer);
Add OT too short check apparently some people can be this oblivious
2017-10-16 01:11:20 +00:00
else if (pkm.TID == 12345 && pkm.SID == 54321 || ot.StartsWith("PKHeX"))
Add suspicious OT check Closes #1246
2017-06-18 23:47:23 +00:00
AddLine(Severity.Fishy, V417, CheckIdentifier.Trainer);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
if (pkm.VC)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyG1OT();
Add wordfilter legality checking WordFilter checking is enabled by default, and is absolutely slow (regex checking 3,800 patterns for 3 different strings). Utilize a dictionary to store previously computed values. Seems to alleviate the massive slow-down. Closes #1442
2017-09-06 06:31:24 +00:00
if (Legal.CheckWordFilter)
{
Add OT too short check apparently some people can be this oblivious
2017-10-16 01:11:20 +00:00
if (WordFilter.IsFiltered(ot, out string bad))
Update fateful/shiny lock check gen3 wc3 VerifyFatefulMysteryGift wasn't hitting for WC3's (g.Format == 3); simplify that branch and reintroduce the shiny check as a separate method Thanks Davil!
2017-10-19 01:18:23 +00:00
AddLine(Severity.Invalid, $"Wordfilter: {bad}", CheckIdentifier.Trainer);
Add wordfilter legality checking WordFilter checking is enabled by default, and is absolutely slow (regex checking 3,800 patterns for 3 different strings). Utilize a dictionary to store previously computed values. Seems to alleviate the massive slow-down. Closes #1442
2017-09-06 06:31:24 +00:00
if (WordFilter.IsFiltered(pkm.HT_Name, out bad))
Update fateful/shiny lock check gen3 wc3 VerifyFatefulMysteryGift wasn't hitting for WC3's (g.Format == 3); simplify that branch and reintroduce the shiny check as a separate method Thanks Davil!
2017-10-19 01:18:23 +00:00
AddLine(Severity.Invalid, $"Wordfilter: {bad}", CheckIdentifier.Trainer);
Add wordfilter legality checking WordFilter checking is enabled by default, and is absolutely slow (regex checking 3,800 patterns for 3 different strings). Utilize a dictionary to store previously computed values. Seems to alleviate the massive slow-down. Closes #1442
2017-09-06 06:31:24 +00:00
}
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyG1OT()
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
{
string tr = pkm.OT_Name;
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
Improve gen1/2 invalid string detection also spit out recommended TID/SID for c/xd starters Closes #1443
2017-09-08 04:42:05 +00:00
VerifyG1OTWithinBounds(tr);
Misc cleanup check gen2 stadium names, use pkm.Japanese when favorable
2017-10-25 01:27:40 +00:00
if (EncounterMatch is EncounterStatic s && (s.Version == GameVersion.Stadium || s.Version == GameVersion.Stadium2))
Improve gen1/2 invalid string detection also spit out recommended TID/SID for c/xd starters Closes #1443
2017-09-08 04:42:05 +00:00
VerifyG1OTStadium(tr);
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
if (pkm.Species == 151)
{
Misc gen1/gen2 fixes - G1/G2 only have Hiragana letter he -> fixed Houndoom(ヘルガー) /Heracross (ヘラクロス) default name mismatch - Fixed Stadium2 Farfetch'd move (Thrash -> Slash) - Added VC Mew TID check - Update Chinese legality strings
2017-10-04 07:14:50 +00:00
if (tr != "GF" && tr != "ゲーフリ" || pkm.TID != 22796) // if there are more events with special OTs, may be worth refactoring
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V39, CheckIdentifier.Trainer);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
}
Relocate female gender checks Per discussion in #1170 Revise message descriptions Gen1 err message now used
2017-05-28 17:35:41 +00:00
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
if (pkm.OT_Gender == 1 && (pkm.Format == 2 && pkm.Met_Location == 0 || !Info.Game.Contains(GameVersion.C)))
Relocate female gender checks Per discussion in #1170 Revise message descriptions Gen1 err message now used
2017-05-28 17:35:41 +00:00
AddLine(Severity.Invalid, V408, CheckIdentifier.Trainer);
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
}
Improve gen1/2 invalid string detection also spit out recommended TID/SID for c/xd starters Closes #1443
2017-09-08 04:42:05 +00:00
private void VerifyG1OTWithinBounds(string str)
{
if (StringConverter.GetIsG1English(str))
{
if (str.Length > 7)
AddLine(Severity.Invalid, V38, CheckIdentifier.Trainer);
}
else if (StringConverter.GetIsG1Japanese(str))
{
if (str.Length > 5)
AddLine(Severity.Invalid, V38, CheckIdentifier.Trainer);
}
misc kor improvements pk2 objects now detect if they are korean or not
2017-09-11 05:30:41 +00:00
else if (pkm is PK2 pk2 && pk2.Korean)
{
if (str.Length > 5)
AddLine(Severity.Invalid, V38, CheckIdentifier.Trainer);
}
Improve gen1/2 invalid string detection also spit out recommended TID/SID for c/xd starters Closes #1443
2017-09-08 04:42:05 +00:00
else
{
AddLine(Severity.Invalid, V421, CheckIdentifier.Trainer);
}
}
private void VerifyG1NicknameWithinBounds(string str)
{
if (StringConverter.GetIsG1English(str))
{
if (str.Length > 10)
AddLine(Severity.Invalid, V1, CheckIdentifier.Trainer);
}
else if (StringConverter.GetIsG1Japanese(str))
{
if (str.Length > 5)
AddLine(Severity.Invalid, V1, CheckIdentifier.Trainer);
}
else
{
AddLine(Severity.Invalid, V422, CheckIdentifier.Trainer);
}
}
private void VerifyG1OTStadium(string tr)
{
Misc cleanup check gen2 stadium names, use pkm.Japanese when favorable
2017-10-25 01:27:40 +00:00
bool jp = pkm.Japanese;
Improve gen1/2 invalid string detection also spit out recommended TID/SID for c/xd starters Closes #1443
2017-09-08 04:42:05 +00:00
bool valid = GetIsStadiumOTIDValid(jp, tr);
if (!valid)
AddLine(Severity.Invalid, V402, CheckIdentifier.Trainer);
else
AddLine(Severity.Valid, jp ? V404 : V403, CheckIdentifier.Trainer);
}
Check stadium OT/ID based on pkm language not really necessary (character table not shared, assuming no transfer) but easier to understand
2017-08-16 23:57:17 +00:00
private bool GetIsStadiumOTIDValid(bool jp, string tr)
{
if (jp)
return tr == "スタジアム" && pkm.TID == 1999;
Misc cleanup check gen2 stadium names, use pkm.Japanese when favorable
2017-10-25 01:27:40 +00:00
return tr == (Info.Generation == 1 ? "STADIUM" : "Stadium") && pkm.TID == 2000;
Check stadium OT/ID based on pkm language not really necessary (character table not shared, assuming no transfer) but easier to understand
2017-08-16 23:57:17 +00:00
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#endregion
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyHyperTraining()
Legality Checking for Hyper Training
2016-11-11 10:31:50 +00:00
{
if (pkm.Format < 7)
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
return; // No Hyper Training before Gen7
Legality Checking for Hyper Training
2016-11-11 10:31:50 +00:00
var IVs = new[] { pkm.IV_HP, pkm.IV_ATK, pkm.IV_DEF, pkm.IV_SPA, pkm.IV_SPD, pkm.IV_SPE };
var HTs = new[] { pkm.HT_HP, pkm.HT_ATK, pkm.HT_DEF, pkm.HT_SPA, pkm.HT_SPD, pkm.HT_SPE };
Additional Hyper Training Legality Check
2016-11-11 11:23:38 +00:00
if (HTs.Any(ht => ht) && pkm.CurrentLevel != 100)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V40, CheckIdentifier.IVs);
Additional Hyper Training Legality Check
2016-11-11 11:23:38 +00:00
Legality Checking for Hyper Training
2016-11-11 10:31:50 +00:00
if (IVs.All(iv => iv == 31) && HTs.Any(ht => ht))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V41, CheckIdentifier.IVs);
Legality Checking for Hyper Training
2016-11-11 10:31:50 +00:00
else
{
for (int i = 0; i < 6; i++) // Check individual IVs
{
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
if (!HTs[i] || IVs[i] != 31)
continue;
AddLine(Severity.Invalid, V42, CheckIdentifier.IVs);
break;
Legality Checking for Hyper Training
2016-11-11 10:31:50 +00:00
}
}
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
#region VerifyEncounter
private void VerifyFormFriendSafari()
Initial Gen1 legality checks (WIP) Have only tested pk1 format so far; there's still a few cases that are unhandled (move discrepancies between games, trade gifts, event mew, tmhm). pls no report bugs unless you are very detailed (include WHY it is wrong).
2017-02-13 01:00:03 +00:00
{
static analysis fixes fixes the friend safari form checks (if else were chained incorrectly) argumentorder of some unused sections (BV date, canlearnmachinemove)
2017-03-20 07:03:31 +00:00
switch (pkm.Species)
{
case 670: // Floette
case 671: // Florges
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (!new[] { 0, 1, 3 }.Contains(pkm.AltForm)) // 0/1/3 - RBY
AddLine(Severity.Invalid, V64, CheckIdentifier.Form);
static analysis fixes fixes the friend safari form checks (if else were chained incorrectly) argumentorder of some unused sections (BV date, canlearnmachinemove)
2017-03-20 07:03:31 +00:00
break;
case 710: // Pumpkaboo
case 711: // Goregeist
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
if (pkm.AltForm != 0) // Average
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
AddLine(Severity.Invalid, V6, CheckIdentifier.Form);
static analysis fixes fixes the friend safari form checks (if else were chained incorrectly) argumentorder of some unused sections (BV date, canlearnmachinemove)
2017-03-20 07:03:31 +00:00
break;
case 586: // Sawsbuck
if (pkm.AltForm != 0)
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
AddLine(Severity.Invalid, V65, CheckIdentifier.Form);
static analysis fixes fixes the friend safari form checks (if else were chained incorrectly) argumentorder of some unused sections (BV date, canlearnmachinemove)
2017-03-20 07:03:31 +00:00
break;
}
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyEncounterType()
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
{
Refactoring r2 Don't calculate suggested moves until prompted Don't check EncounterType for gen7 pkm (no field to check)
2017-04-23 04:00:06 +00:00
if (pkm.Format >= 7)
return;
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
if (!Encounter.Valid)
return;
Refactoring Simplify EncounterStatic type check as it is gen4 specific -> gen4 specific child class Checks.cs: Move transfer legality check back to end as Gen4Result needs to be defined (not null) Rename EncounterType of Analysis class to avoid conflict with the EncounterType enum
2017-04-22 20:04:12 +00:00
EncounterType type = EncounterType.None;
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
// Encounter type data is only stored for gen 4 encounters
4->5/6 transfer encountertype preference fix Add a preference check when appropriate so that invalid encounter types are not preferred over the wild encounters that may follow. Closes #1095
2017-05-11 01:52:14 +00:00
// Gen 6 -> 7 transfer deletes encounter type data
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
// All eggs have encounter type none, even if they are from static encounters
Refactoring r2 Don't calculate suggested moves until prompted Don't check EncounterType for gen7 pkm (no field to check)
2017-04-23 04:00:06 +00:00
if (pkm.Gen4 && !pkm.WasEgg)
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterSlot w)
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
// If there is more than one slot, the get wild encounter have filter for the pkm type encounter like safari/sports ball
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
type = w.TypeEncounter;
if (EncounterMatch is EncounterStaticTyped s)
type = s.TypeEncounter;
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
}
Refactoring r2 Don't calculate suggested moves until prompted Don't check EncounterType for gen7 pkm (no field to check)
2017-04-23 04:00:06 +00:00
Encounter Type fix and detection of pokemon that should have evolve on trade (#1105) * Detect encounter trades that evolve on trade and have not been evolved Detect generation 1 pokemon with special catch rates : krabby trade and Pokemon Stadium Detect generation 1 pokemon that evolve on trade and have been traded but not evolved Detect pokemon with tradeback status any but with only encounters from the other GB generation, that means they are WasTradeback Detect pokemon with moves from the other GB generation, change tradebackstatus to WasTradeback * Fix dppt surfing and fishing encounter type, is is surfing because the battle background is the same as other surfingfishing encounters Fix headbutt encounter type, the encounter type depends on the battle background used when battle a pokemon, for headbutt it changes with the player tile, is the player is in a city it will be building encounter, in a grass tile tall grass, in water it is surfingfishing and cave inside a cave. Some locations have more than one possible encounter type, for example routes with trees near the grass, near the water and near non-combat tiles. Also added slot type headbutt special for the special trees, those trees are all in routes and are only adjacent to non-combat tiles * Fix encounter type for missing areas with multiple grass encounters types: Mt Coronet, Mt Silver Cave and Stark Mountain (Issue # 1095) * Fixes and typos * Check for non-japanese e-reader pokemon, is unreleased
2017-05-01 15:07:20 +00:00
if (!type.Contains(pkm.EncounterType))
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
AddLine(Severity.Invalid, V381, CheckIdentifier.Encounter);
Refactoring r2 Don't calculate suggested moves until prompted Don't check EncounterType for gen7 pkm (no field to check)
2017-04-23 04:00:06 +00:00
else
AddLine(Severity.Valid, V380, CheckIdentifier.Encounter);
Special Eggs improvement and Generation 4 Encounter Type legal analysis (#1083) * Ignore relearn level 2-100 moves from Phione * Cave encounter types DPPt * Generation 4 EncounterType filter and validation Not every generation 4 static encounter have yet their encounter type defined, i temporally included Any to those encounters Generation 4 roaaming static encounters have been splitted in two, grass and surf * Added new legality texts * Added unreleased event DP Darkai, added check for surf in jhoto route 45, is impossible Moved unreleased DP locations to valid Platinum locations only * Improved generation 3 special egg check. Only check special egg if pokemon knows any of the special egg moves, also in that case do check for normal egg before special egg because special eggs will explicitly check for normal egg moves but normal eggs will not check special egg moves, it will improve the error output * Clean up * Fix gen 5 pokemon from issue #1011 Those pokemon have generation 4 static gift encounters and also wild encounters, the analysis was selecting the static encounter, but if there is a valid wild encounter and the static encounter does not match the pokemon ball the willd encounter should be selected instead Also move the transfer legality to check it before the static encounters and make that check to work like generation 3 transfer legality * Another fix for Issue 1011, suppress temporally OT and pokemon name analysis for generations 3 to 5 instead of format 3 to 5, there is no data stored yet to make those analysis * Do not make wild encounters prevail static encounter if the pokemon was an egg * Changed type of WildEncounter variable to EncounterSlot[] * Fix Jhoto Route 45 to avoid return error with fishing encounters
2017-04-22 18:49:49 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyTransferLegalityG3()
verifyEncounterG3Transfer function For gen 3 transfer pokemon it checks the non egg possible encounter and if the pokemon could have been hatched egg encounter Return the result from one of the two encounters that is valid, with non egg preference but marking WasEgg a True if it can be from an egg In verify moves both possible encounters are considered, there is no way to discart one or another
2017-03-26 22:37:56 +00:00
{
Cleanup refactor out the encounter trade screening; fixes the IV check loop (the continue continued the for loop not the foreach). Similar approach can be applied later for the encounterstatic checks if it is to be converted to ienumerable (in which a secondary screen may be necessary)
2017-03-31 07:04:29 +00:00
if (pkm.Format == 4 && pkm.Met_Location != 0x37) // Pal Park
AddLine(Severity.Invalid, V60, CheckIdentifier.Encounter);
if (pkm.Format != 4 && pkm.Met_Location != 30001)
AddLine(Severity.Invalid, V61, CheckIdentifier.Encounter);
verifyEncounterG3Transfer function For gen 3 transfer pokemon it checks the non egg possible encounter and if the pokemon could have been hatched egg encounter Return the result from one of the two encounters that is valid, with non egg preference but marking WasEgg a True if it can be from an egg In verify moves both possible encounters are considered, there is no way to discart one or another
2017-03-26 22:37:56 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyTransferLegalityG4()
Fix error in transfer legality G4. Transfer legality is not checked if the pokemon is a valid static encounter, also an Entei with invalid encounter is returning null as check encounter making the analysis to throw an exception, reported in the forum. Instead check transfer legality and do not return checkresult until the end to add invalid values if Gen4Result is null.
2017-04-25 00:42:15 +00:00
{
// Transfer Legality
int loc = pkm.Met_Location;
if (loc != 30001) // PokéTransfer
{
// Crown
switch (pkm.Species)
{
case 251: // Celebi
if (loc != 30010 && loc != 30011) // unused || used
AddLine(Severity.Invalid, V351, CheckIdentifier.Encounter);
break;
case 243: // Raikou
case 244: // Entei
case 245: // Suicune
if (loc != 30012 && loc != 30013) // unused || used
AddLine(Severity.Invalid, V351, CheckIdentifier.Encounter);
break;
default:
AddLine(Severity.Invalid, V61, CheckIdentifier.Encounter);
break;
}
}
}
Simplify vc transfer checks supply met level so the static encounter has a level to work with instead of 0 Closes #1316 in other areas: level 48 charizard VC1 transfer changed to mewtwo causes minlvl > maxlevel, handle instead of throwing exception.
2017-07-09 15:47:17 +00:00
private static IEnumerable<CheckResult> VerifyVCEncounter(PKM pkm, int baseSpecies, GBEncounterData encounter, EncounterStatic transfer)
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
{
Tweak gen1+transfer checking Add stadium exclusives (surfchu / amnesiaduck) which are flagged on gen7
2017-02-14 02:06:01 +00:00
// Check existing EncounterMatch
Simplify vc transfer checks supply met level so the static encounter has a level to work with instead of 0 Closes #1316 in other areas: level 48 charizard VC1 transfer changed to mewtwo causes minlvl > maxlevel, handle instead of throwing exception.
2017-07-09 15:47:17 +00:00
if (encounter == null || transfer == null)
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
yield break; // Avoid duplicate invaild message
Further tweaks Handle terminated strings better for 1->7 Indicate RBY encounter origins when transferred to 7+. Remove check duplication
2017-02-15 06:06:15 +00:00
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (encounter.Encounter is EncounterStatic v && (GameVersion.GBCartEraOnly.Contains(v.Version) || v.Version == GameVersion.VCEvents))
Further tweaks Handle terminated strings better for 1->7 Indicate RBY encounter origins when transferred to 7+. Remove check duplication
2017-02-15 06:06:15 +00:00
{
bool exceptions = false;
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
exceptions |= v.Version == GameVersion.VCEvents && baseSpecies == 151 && pkm.TID == 22796;
Further tweaks Handle terminated strings better for 1->7 Indicate RBY encounter origins when transferred to 7+. Remove check duplication
2017-02-15 06:06:15 +00:00
if (!exceptions)
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
yield return new CheckResult(Severity.Invalid, V79, CheckIdentifier.Encounter);
Further tweaks Handle terminated strings better for 1->7 Indicate RBY encounter origins when transferred to 7+. Remove check duplication
2017-02-15 06:06:15 +00:00
}
Add gen1->gen7 IV legality check Also fix gen1/2 evo tree trimming error, thanks BeyondTheHorizon! Also fix an exception when no static encounter can be generated for 1->7, match is now generated by checking gen1 and reusing the static encounter creation info (now moved to core).
2017-03-10 04:27:03 +00:00
Simplify vc transfer checks supply met level so the static encounter has a level to work with instead of 0 Closes #1316 in other areas: level 48 charizard VC1 transfer changed to mewtwo causes minlvl > maxlevel, handle instead of throwing exception.
2017-07-09 15:47:17 +00:00
if (pkm.Met_Location != transfer.Location)
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
yield return new CheckResult(Severity.Invalid, V81, CheckIdentifier.Encounter);
Simplify vc transfer checks supply met level so the static encounter has a level to work with instead of 0 Closes #1316 in other areas: level 48 charizard VC1 transfer changed to mewtwo causes minlvl > maxlevel, handle instead of throwing exception.
2017-07-09 15:47:17 +00:00
if (pkm.Egg_Location != transfer.EggLocation)
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
yield return new CheckResult(Severity.Invalid, V59, CheckIdentifier.Encounter);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
Simplify vc transfer checks supply met level so the static encounter has a level to work with instead of 0 Closes #1316 in other areas: level 48 charizard VC1 transfer changed to mewtwo causes minlvl > maxlevel, handle instead of throwing exception.
2017-07-09 15:47:17 +00:00
if (baseSpecies == 150 && pkm.Moves.Contains(6)) // pay day
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
yield return new CheckResult(Severity.Invalid, V82, CheckIdentifier.Encounter);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#endregion
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyLevel()
Add level check Met level > Current Level
2016-03-19 05:49:21 +00:00
{
Add gen1-4 EV check for untrained pkm Rework some checks for eggs, closes #1248 GetEggHatchLevel uses Format instead of Generation; should only be used on IsEgg=true pkm
2017-06-19 04:13:53 +00:00
if (EncounterMatch is MysteryGift gift)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Misc gen3 related updates detect gen3 event eggs better
2017-06-29 05:09:26 +00:00
if (gift.Level != pkm.Met_Level && pkm.HasOriginalMetLocation)
Misc event legality updates They're finally using metlevel
2016-11-13 23:40:34 +00:00
{
Misc gen3 related updates detect gen3 event eggs better
2017-06-29 05:09:26 +00:00
switch (gift)
{
Misc updates Detect channel, only detect Channel PIDIV for RS origin (only really care about method1/2/4 being used when it shouldn't) Channel does this weird thing called not setting the met level. Refactor set suggested met location to a method that can suppress popups.
2017-06-30 02:32:29 +00:00
case WC3 wc3 when wc3.Met_Level == pkm.Met_Level:
Misc gen3 related updates detect gen3 event eggs better
2017-06-29 05:09:26 +00:00
break;
case WC7 wc7 when wc7.MetLevel == pkm.Met_Level:
break;
default:
AddLine(new CheckResult(Severity.Invalid, V83, CheckIdentifier.Level));
return;
}
Misc event legality updates They're finally using metlevel
2016-11-13 23:40:34 +00:00
}
Add gen1-4 EV check for untrained pkm Rework some checks for eggs, closes #1248 GetEggHatchLevel uses Format instead of Generation; should only be used on IsEgg=true pkm
2017-06-19 04:13:53 +00:00
if (gift.Level > pkm.CurrentLevel)
{
AddLine(new CheckResult(Severity.Invalid, V84, CheckIdentifier.Level));
return;
}
Add greninja variable PID edge case game programmer should have used the nonshiny mode option instead of randomly coming up with a PID closes #458 added missing gift check for level (was 'deferred' but never implemented)
2016-12-12 01:13:59 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
Start recognizing some gen3 encounters Add overrides for detecting encounter type Will need to come up with something more intelligent for when this met location info is lost on transfer. Probably some re-parse guessing like was done for Gen1/2. Fix hitmonlee/chan level Noticed that Aerodacytl is met at level 5 with current level 30; will have to figure out a way to work around Current!=Met level
2017-03-19 23:52:56 +00:00
if (pkm.IsEgg)
{
Add gen1-4 EV check for untrained pkm Rework some checks for eggs, closes #1248 GetEggHatchLevel uses Format instead of Generation; should only be used on IsEgg=true pkm
2017-06-19 04:13:53 +00:00
int elvl = Legal.GetEggHatchLevel(pkm);
if (elvl != pkm.CurrentLevel)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V52, elvl), CheckIdentifier.Level);
Add gen1-4 EV check for untrained pkm Rework some checks for eggs, closes #1248 GetEggHatchLevel uses Format instead of Generation; should only be used on IsEgg=true pkm
2017-06-19 04:13:53 +00:00
return;
Start recognizing some gen3 encounters Add overrides for detecting encounter type Will need to come up with something more intelligent for when this met location info is lost on transfer. Probably some re-parse guessing like was done for Gen1/2. Fix hitmonlee/chan level Noticed that Aerodacytl is met at level 5 with current level 30; will have to figure out a way to work around Current!=Met level
2017-03-19 23:52:56 +00:00
}
Add gen1-4 EV check for untrained pkm Rework some checks for eggs, closes #1248 GetEggHatchLevel uses Format instead of Generation; should only be used on IsEgg=true pkm
2017-06-19 04:13:53 +00:00
int lvl = pkm.CurrentLevel;
if (lvl < pkm.Met_Level)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V85, CheckIdentifier.Level);
Tighten met level check with hasoriginal #1261
2017-06-22 03:47:07 +00:00
else if (!EncounterMatch.IsWithinRange(pkm) && lvl != 100 && pkm.EXP == PKX.GetEXP(lvl, pkm.Species))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Fishy, V87, CheckIdentifier.Level);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V88, CheckIdentifier.Level);
Encounter Type fix and detection of pokemon that should have evolve on trade (#1105) * Detect encounter trades that evolve on trade and have not been evolved Detect generation 1 pokemon with special catch rates : krabby trade and Pokemon Stadium Detect generation 1 pokemon that evolve on trade and have been traded but not evolved Detect pokemon with tradeback status any but with only encounters from the other GB generation, that means they are WasTradeback Detect pokemon with moves from the other GB generation, change tradebackstatus to WasTradeback * Fix dppt surfing and fishing encounter type, is is surfing because the battle background is the same as other surfingfishing encounters Fix headbutt encounter type, the encounter type depends on the battle background used when battle a pokemon, for headbutt it changes with the player tile, is the player is in a city it will be building encounter, in a grass tile tall grass, in water it is surfingfishing and cave inside a cave. Some locations have more than one possible encounter type, for example routes with trees near the grass, near the water and near non-combat tiles. Also added slot type headbutt special for the special trees, those trees are all in routes and are only adjacent to non-combat tiles * Fix encounter type for missing areas with multiple grass encounters types: Mt Coronet, Mt Silver Cave and Stark Mountain (Issue # 1095) * Fixes and typos * Check for non-japanese e-reader pokemon, is unreleased
2017-05-01 15:07:20 +00:00
slight tweaks reduce nesting, formatting; no functional change
2017-05-01 15:25:20 +00:00
// There is no way to prevent a gen1 trade evolution as held items (everstone) did not exist.
// Machoke, Graveler, Haunter and Kadabra captured in the second phase evolution, excluding in-game trades, are already checked
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (pkm.Format <= 2 && Type != typeof (EncounterTrade) && EncounterMatch.Species == pkm.Species && Legal.Trade_Evolution1.Contains(EncounterMatch.Species))
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyG1TradeEvo();
slight tweaks reduce nesting, formatting; no functional change
2017-05-01 15:25:20 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyG1TradeEvo()
slight tweaks reduce nesting, formatting; no functional change
2017-05-01 15:25:20 +00:00
{
New legallity checks (#1196) * Add move source to the check result for current moves, it will be used for analysis of evolution with move to determine how many egg moves had the pokemon and determine if the evolution move could be a egg move that was forgotten * Verify evolution for species that evolved leveling up with an specific move learned, the evolution must be at least one level after the pokemon could legally learn the move or one level after transfer to the first generation where it can evolve * Check to detect traded unevolved Kadabra based in catch rate and moves exclusive from yellow or red/blue If pokemon have data exclusive from one version but is in another version that means it should be evolved * Check no tradeback moves for preevolutions, like Pichu exclusive non tradeback moves for a Pikachu, that Pikachu could not have at the same time Pichu gen 2 moves and gen 1 moves because move reminder do not allow to relearn Pichu moves and gen 2 moves must be forgotten to trade into generation 1 games * Legallity strings for non tradeback checks * https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_breeding#Passing_moves_down Eggs only inherit a level up move if both parents know the move, that means genderless and male only moves could not have any level up move as an egg except the base egg moves because Ditto is one parent Nidoran male and Volbeat excluded because they can breed with Nidoran female and Illusime * Small check to not search for egg moves in genderless pokemon, generation 2 data include egg moves for Starmie * Fix female only species * Stomp is not a possible egg moves of Stanee * Fix Steenee evolution move, it cant be inherited as an egg
2017-06-07 03:10:05 +00:00
var mustevolve = pkm.TradebackStatus == TradebackType.WasTradeback || (pkm.Format == 1 && Legal.IsOutsider(pkm)) || Legal.IsTradedKadabraG1(pkm);
slight tweaks reduce nesting, formatting; no functional change
2017-05-01 15:25:20 +00:00
if (!mustevolve)
return;
// Pokemon have been traded but it is not evolved, trade evos are sequential dex numbers
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
var unevolved = SpeciesStrings[pkm.Species];
var evolved = SpeciesStrings[pkm.Species + 1];
slight tweaks reduce nesting, formatting; no functional change
2017-05-01 15:25:20 +00:00
AddLine(Severity.Invalid, string.Format(V405, unevolved, evolved), CheckIdentifier.Level);
Add level check Met level > Current Level
2016-03-19 05:49:21 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
#region VerifyMedals
private void VerifyMedals()
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
{
if (pkm.Format < 6)
return;
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyMedalsRegular();
VerifyMedalsEvent();
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyMedalsRegular()
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
{
Remove reflection for super training checks Offset is constant, just interpret the raw data instead of the properties. speed++; Adds check for unused super training flags.
2017-04-15 19:22:29 +00:00
uint data = BitConverter.ToUInt32(pkm.Data, 0x2C);
if ((data & 3) != 0) // 2 unused flags
AddLine(Severity.Invalid, V98, CheckIdentifier.Training);
Next round of ribbon checking Returned messages are slightly misleading since missing/invalid are mixed together with the static method. #1250 ~322 lines to check ribbons, on top of the interface abstraction... so much required... kinda understandable as there's over 100 ribbons to check.
2017-06-21 04:57:00 +00:00
int TrainCount = pkm.SuperTrainingMedalCount();
Remove reflection for super training checks Offset is constant, just interpret the raw data instead of the properties. speed++; Adds check for unused super training flags.
2017-04-15 19:22:29 +00:00
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
if (pkm.IsEgg && TrainCount > 0)
Next round of ribbon checking Returned messages are slightly misleading since missing/invalid are mixed together with the static method. #1250 ~322 lines to check ribbons, on top of the interface abstraction... so much required... kinda understandable as there's over 100 ribbons to check.
2017-06-21 04:57:00 +00:00
AddLine(Severity.Invalid, V89, CheckIdentifier.Training);
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
else if (TrainCount > 0 && Info.Generation > 6)
Next round of ribbon checking Returned messages are slightly misleading since missing/invalid are mixed together with the static method. #1250 ~322 lines to check ribbons, on top of the interface abstraction... so much required... kinda understandable as there's over 100 ribbons to check.
2017-06-21 04:57:00 +00:00
AddLine(Severity.Invalid, V90, CheckIdentifier.Training);
Update cleared data legality checks Add in a few more, a little bit of shuffling
2017-01-25 17:17:20 +00:00
else
{
if (pkm.Format >= 7)
{
if (pkm.SecretSuperTrainingUnlocked)
Next round of ribbon checking Returned messages are slightly misleading since missing/invalid are mixed together with the static method. #1250 ~322 lines to check ribbons, on top of the interface abstraction... so much required... kinda understandable as there's over 100 ribbons to check.
2017-06-21 04:57:00 +00:00
AddLine(Severity.Invalid, V91, CheckIdentifier.Training);
Update cleared data legality checks Add in a few more, a little bit of shuffling
2017-01-25 17:17:20 +00:00
if (pkm.SecretSuperTrainingComplete)
Next round of ribbon checking Returned messages are slightly misleading since missing/invalid are mixed together with the static method. #1250 ~322 lines to check ribbons, on top of the interface abstraction... so much required... kinda understandable as there's over 100 ribbons to check.
2017-06-21 04:57:00 +00:00
AddLine(Severity.Invalid, V92, CheckIdentifier.Training);
Update cleared data legality checks Add in a few more, a little bit of shuffling
2017-01-25 17:17:20 +00:00
}
else
{
if (TrainCount == 30 ^ pkm.SecretSuperTrainingComplete)
Next round of ribbon checking Returned messages are slightly misleading since missing/invalid are mixed together with the static method. #1250 ~322 lines to check ribbons, on top of the interface abstraction... so much required... kinda understandable as there's over 100 ribbons to check.
2017-06-21 04:57:00 +00:00
AddLine(Severity.Invalid, V93, CheckIdentifier.Training);
Update cleared data legality checks Add in a few more, a little bit of shuffling
2017-01-25 17:17:20 +00:00
}
}
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
}
Next round of ribbon checking Returned messages are slightly misleading since missing/invalid are mixed together with the static method. #1250 ~322 lines to check ribbons, on top of the interface abstraction... so much required... kinda understandable as there's over 100 ribbons to check.
2017-06-21 04:57:00 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyMedalsEvent()
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
{
Remove reflection for super training checks Offset is constant, just interpret the raw data instead of the properties. speed++; Adds check for unused super training flags.
2017-04-15 19:22:29 +00:00
byte data = pkm.Data[0x3A];
if ((data & 0xC0) != 0) // 2 unused flags highest bits
AddLine(Severity.Invalid, V98, CheckIdentifier.Training);
int TrainCount = 0;
for (int i = 0; i < 6; i++)
{
if ((data & 1) != 0)
TrainCount++;
data >>= 1;
}
if (pkm.IsEgg && TrainCount > 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Invalid, V89, CheckIdentifier.Training); }
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
else if (TrainCount > 0 && Info.Generation > 6)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Invalid, V90, CheckIdentifier.Training); }
Remove reflection for super training checks Offset is constant, just interpret the raw data instead of the properties. speed++; Adds check for unused super training flags.
2017-04-15 19:22:29 +00:00
else if (TrainCount > 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Fishy, V94, CheckIdentifier.Training); }
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#endregion
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyRibbons()
Add ribbon legality check
2016-03-20 22:20:11 +00:00
{
if (!Encounter.Valid)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
9/18/16 - New Update Changelog, shortcut list, version, and wc6db updated. Slide in a legality check for super training.
2016-09-17 19:21:23 +00:00
Initial ribbon refactor remove legality check's use of reflection which checked individual properties; add interfaces to interact with the ribbons of each PKM type. With this, every ribbon attribute is accessible via its corresponding interface (cast) will have to add checks for individual interfaces as per #1250 I didn't feel like adding much documentation, is pretty straightforward. Cast a pkm object to the desired ribbon set; if not null, can access ribbons regardless of pkm format.
2017-06-20 04:43:44 +00:00
// Check Unobtainable Ribbons
var encounterContent = (EncounterMatch as MysteryGift)?.Content ?? EncounterMatch;
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.IsEgg)
Add Egg & Super Training legality checks Closes #220 Thanks @sora10pls !
2016-09-03 15:10:22 +00:00
{
Flag invalid nsparkle previously would only flag if it was missing on npokemon also fix gen5 traded egg locations move egg ribbon verification to the new class
2017-09-06 03:32:07 +00:00
if (RibbonVerifier.GetIncorrectRibbonsEgg(pkm, encounterContent))
AddLine(Severity.Invalid, V603, CheckIdentifier.Ribbon);
Initial ribbon refactor remove legality check's use of reflection which checked individual properties; add interfaces to interact with the ribbons of each PKM type. With this, every ribbon attribute is accessible via its corresponding interface (cast) will have to add checks for individual interfaces as per #1250 I didn't feel like adding much documentation, is pretty straightforward. Cast a pkm object to the desired ribbon set; if not null, can access ribbons regardless of pkm format.
2017-06-20 04:43:44 +00:00
return;
}
Update gift egg ribbon checking Closes #1074 Check ribbons for the gift, then check for all ribbons except the ones already checked. Refactored out the ribbonset checking methods
2017-04-18 02:11:01 +00:00
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
List<string> result = RibbonVerifier.GetIncorrectRibbons(pkm, encounterContent, Info.Generation);
if (result.Any())
AddLine(Severity.Invalid, string.Join(Environment.NewLine, result.Where(s => !string.IsNullOrEmpty(s))), CheckIdentifier.Ribbon);
else
Initial ribbon refactor remove legality check's use of reflection which checked individual properties; add interfaces to interact with the ribbons of each PKM type. With this, every ribbon attribute is accessible via its corresponding interface (cast) will have to add checks for individual interfaces as per #1250 I didn't feel like adding much documentation, is pretty straightforward. Cast a pkm object to the desired ribbon set; if not null, can access ribbons regardless of pkm format.
2017-06-20 04:43:44 +00:00
AddLine(Severity.Valid, V602, CheckIdentifier.Ribbon);
Next round of ribbon checking Returned messages are slightly misleading since missing/invalid are mixed together with the static method. #1250 ~322 lines to check ribbons, on top of the interface abstraction... so much required... kinda understandable as there's over 100 ribbons to check.
2017-06-21 04:57:00 +00:00
}
Update gift egg ribbon checking Closes #1074 Check ribbons for the gift, then check for all ribbons except the ones already checked. Refactored out the ribbonset checking methods
2017-04-18 02:11:01 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyCXD()
Add C/XD specific checks Pokespot: a given PID will satisfy ~37% of the time, flag pokespot encounters I can see hatching eggs being a problem, no idea how this would work
2017-04-30 23:53:54 +00:00
{
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
if (EncounterMatch is EncounterStatic)
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
VerifyCXDStarterCorrelation(Info.PIDIV);
Handle CXD egg encounters There are none. But the detection routine for gen3 can assign cxd pkm as egg if no other possible encounter is matched, thus we'll flag if the failure case occurs. add missing spacing formatting, simplify break->return for egg game retrieval
2017-05-03 02:08:16 +00:00
else if (pkm.WasEgg) // can't obtain eggs in CXD
AddLine(Severity.Invalid, V80, CheckIdentifier.Encounter); // invalid encounter
Relocate female gender checks Per discussion in #1170 Revise message descriptions Gen1 err message now used
2017-05-28 17:35:41 +00:00
if (pkm.OT_Gender == 1)
AddLine(Severity.Invalid, V407, CheckIdentifier.Trainer);
Add C/XD specific checks Pokespot: a given PID will satisfy ~37% of the time, flag pokespot encounters I can see hatching eggs being a problem, no idea how this would work
2017-04-30 23:53:54 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyCXDStarterCorrelation(PIDIV pidiv)
Flag any cxd origin with bad pidiv
2017-05-13 07:03:35 +00:00
{
Let pkmdb fetch from save backups Only if compiled in debug; bumps my searchables to 6 figures lol bulk legality scan yielded one exception (bad CXD pidiv for starters) bullk sav fetch yielded one exception (unknown type didn't define SeenFlagOffsets)
2017-06-10 06:13:41 +00:00
if (pidiv.Type != PIDType.CXD)
return;
Rework colo starter PIDIV detection force colo starters to be male only use some c# lang features for EncounterType flags add edge case PIDIV detection for starter gender/shiny lock scenario adds a little documentation for those unfamiliar with the NPC PKM generation quirks. Colosseum Starters will now be recognized with a different PIDIV type which is specific to them & them only.
2017-11-02 04:12:44 +00:00
bool valid;
switch (EncounterMatch.Species)
Flag any cxd origin with bad pidiv
2017-05-13 07:03:35 +00:00
{
Rework colo starter PIDIV detection force colo starters to be male only use some c# lang features for EncounterType flags add edge case PIDIV detection for starter gender/shiny lock scenario adds a little documentation for those unfamiliar with the NPC PKM generation quirks. Colosseum Starters will now be recognized with a different PIDIV type which is specific to them & them only.
2017-11-02 04:12:44 +00:00
case 133:
valid = LockFinder.IsXDStarterValid(pidiv.OriginSeed, pkm.TID, pkm.SID); break;
case 196: case 197:
valid = pidiv.Type == PIDType.CXD_ColoStarter; break;
Flag any cxd origin with bad pidiv
2017-05-13 07:03:35 +00:00
default:
return;
}
Rework colo starter PIDIV detection force colo starters to be male only use some c# lang features for EncounterType flags add edge case PIDIV detection for starter gender/shiny lock scenario adds a little documentation for those unfamiliar with the NPC PKM generation quirks. Colosseum Starters will now be recognized with a different PIDIV type which is specific to them & them only.
2017-11-02 04:12:44 +00:00
if (!valid)
AddLine(Severity.Invalid, V400, CheckIdentifier.PID);
Flag any cxd origin with bad pidiv
2017-05-13 07:03:35 +00:00
}
Add C/XD specific checks Pokespot: a given PID will satisfy ~37% of the time, flag pokespot encounters I can see hatching eggs being a problem, no idea how this would work
2017-04-30 23:53:54 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyAbility()
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
{
Personal Table per PKM Not by AO only (now works for species > 721)
2016-10-29 06:41:22 +00:00
int[] abilities = pkm.PersonalInfo.Abilities;
Fix egg move gen6+ requirement for relearnmoves Thanks TJGameplay!
2017-03-18 23:17:42 +00:00
if (abilities[1] == 0)
abilities[1] = abilities[0];
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
int abilval = Array.IndexOf(abilities, pkm.Ability);
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
if (abilval < 0)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V107, CheckIdentifier.Ability);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
bool? AbilityUnchanged = true;
// 3 states flag: true for unchanged, false for changed, null for uncertain/allowing PID mismatch
// if true, check encounter ability
// if true or false, check PID/AbilityNumber
if (3 <= pkm.Format && pkm.Format <= 5 && abilities[0] != abilities[1]) // 3-5 and have 2 distinct ability now
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
AbilityUnchanged = VerifyAbilityPreCapsule(abilities, abilval);
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
Flag Hidden Ability -> other change (hacked) Closes #1535
2017-10-21 03:10:56 +00:00
if (Encounter.Valid)
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
{
Misc fixes & Some tweaks for legality check (#1044) * Add gen3-6 unreleased items * Fix string converter fix traditional chinese char offset fix out-of-range crash * Fix ivs and ability check for VC transfer Refetch the static enconter for VC transfer after moves checks update legality string translation impl non-HA ability matching * Add ivs legality check for wc gift
2017-04-10 04:59:44 +00:00
// Check Ability Mismatches
int? EncounterAbility = (EncounterMatch as EncounterStatic)?.Ability ??
(EncounterMatch as EncounterTrade)?.Ability ??
(EncounterMatch as EncounterLink)?.Ability;
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (EncounterAbility != null && VerifySetAbility(EncounterAbility, AbilityUnchanged, abilities, abilval))
return; // result added via VerifySetAbility
Misc fixes & Some tweaks for legality check (#1044) * Add gen3-6 unreleased items * Fix string converter fix traditional chinese char offset fix out-of-range crash * Fix ivs and ability check for VC transfer Refetch the static enconter for VC transfer after moves checks update legality string translation impl non-HA ability matching * Add ivs legality check for wc gift
2017-04-10 04:59:44 +00:00
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
switch (Info.Generation)
Add Hidden Grotto Ability checking
2017-03-22 23:47:14 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
case 5: VerifyAbility5(abilities); break;
case 6: VerifyAbility6(abilities); break;
case 7: VerifyAbility7(abilities); break;
DexNav Hidden Ability Thanks Wanderer1391!
2016-03-31 02:55:27 +00:00
}
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
}
Add Ingame Trade ability, chk Fix Egg Ball chk Missed the return at the end
2016-03-22 04:50:39 +00:00
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (3 <= Info.Generation && Info.Generation <= 4 && pkm.AbilityNumber == 4)
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
AddLine(Severity.Invalid, V112, CheckIdentifier.Ability);
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
else if (AbilityUnchanged != null && abilities[pkm.AbilityNumber >> 1] != pkm.Ability)
AddLine(Severity.Invalid, pkm.Format < 6 ? V113 : V114, CheckIdentifier.Ability);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
AddLine(Severity.Valid, V115, CheckIdentifier.Ability);
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private bool VerifySetAbility(int? EncounterAbility, bool? AbilityUnchanged, int[] abilities, int abilval)
Add hidden ability mismatch check for fixed abils minor refactoring remove GameVersion.Pt unreachable code for eggmoves
2017-05-09 03:35:06 +00:00
{
if (pkm.AbilityNumber == 4 && EncounterAbility != 4)
{
AddLine(Severity.Invalid, V108, CheckIdentifier.Ability);
return true;
}
if (!(AbilityUnchanged ?? false) || EncounterAbility == 0 || pkm.AbilityNumber == EncounterAbility)
return false;
Update encountertrade ability legality check check for encountertrade edge case first, then ability capsule Closes #1163
2017-05-24 03:10:57 +00:00
if (EncounterMatch is EncounterTrade z && EncounterAbility == 1 << abilval && z.Species == pkm.Species) // Edge case (Static PID?)
Add hidden ability mismatch check for fixed abils minor refactoring remove GameVersion.Pt unreachable code for eggmoves
2017-05-09 03:35:06 +00:00
AddLine(Severity.Valid, V115, CheckIdentifier.Ability);
Flag Hidden Ability -> other change (hacked) Closes #1535
2017-10-21 03:10:56 +00:00
else if (pkm.Format >= 6 && abilities[0] != abilities[1] && pkm.AbilityNumber < 4 && EncounterAbility != 4) // Ability Capsule can change between 1/2
Update encountertrade ability legality check check for encountertrade edge case first, then ability capsule Closes #1163
2017-05-24 03:10:57 +00:00
AddLine(Severity.Valid, V109, CheckIdentifier.Ability);
Add hidden ability mismatch check for fixed abils minor refactoring remove GameVersion.Pt unreachable code for eggmoves
2017-05-09 03:35:06 +00:00
else
AddLine(Severity.Invalid, V223, CheckIdentifier.Ability);
return true;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private bool? VerifyAbilityPreCapsule(int[] abilities, int abilval)
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
{
cleanup no functional change
2017-04-15 02:55:40 +00:00
// CXD pokemon could have any ability without maching PID
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
if (pkm.Version == (int)GameVersion.CXD && pkm.Format == 3)
return null;
// gen3 native or gen4/5 origin
if (pkm.Format == 3 || !pkm.InhabitedGeneration(3))
return true;
// Evovled in gen4/5
if (pkm.Species > Legal.MaxSpeciesID_3)
return false;
// gen3Species will be zero for pokemon with illegal gen 3 encounters, like Infernape with gen 3 "origin"
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
var gen3Species = Info.EvoChainsAllGens[3].FirstOrDefault()?.Species ?? 0;
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
if (gen3Species == 0)
return true;
// Fall through when gen3 pkm transferred to gen4/5
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
return VerifyAbilityGen3Transfer(abilities, abilval, gen3Species);
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private bool? VerifyAbilityGen3Transfer(int[] abilities, int abilval, int Species_g3)
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
{
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
var abilities_g3 = PersonalTable.E[Species_g3].Abilities.Where(a => a != 0).Distinct().ToArray();
Add hidden ability mismatch check for fixed abils minor refactoring remove GameVersion.Pt unreachable code for eggmoves
2017-05-09 03:35:06 +00:00
if (abilities_g3.Length == 2) // Excluding Colosseum/XD, a gen3 pkm must match PID if it has 2 unique abilities
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
return pkm.Version != (int)GameVersion.CXD;
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
int Species_g4 = Info.EvoChainsAllGens[4].FirstOrDefault()?.Species ?? 0;
int Species_g5 = pkm.Format == 5 ? Info.EvoChainsAllGens[5].FirstOrDefault()?.Species ?? 0 : 0;
Add hidden ability mismatch check for fixed abils minor refactoring remove GameVersion.Pt unreachable code for eggmoves
2017-05-09 03:35:06 +00:00
if (Math.Max(Species_g5, Species_g4) > Species_g3) // it has evolved in either gen 4 or gen 5; the ability must match PID
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
return false;
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
var Evolutions_g45 = Math.Max(Info.EvoChainsAllGens[4].Length, pkm.Format == 5 ? Info.EvoChainsAllGens[5].Length : 0);
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
if (Evolutions_g45 > 1)
{
// Evolutions_g45 > 1 and Species_g45 = Species_g3 with means both options, evolve in gen 4-5 or not evolve, are possible
if (pkm.Ability == abilities_g3[0])
// It could evolve in gen 4-5 an have generation 3 only ability
// that means it have not actually evolved in gen 4-5, ability do not need to match PID
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
return null;
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
if (pkm.Ability == abilities[1])
// It could evolve in gen4-5 an have generation 4 second ability
// that means it have actually evolved in gen 4-5, ability must match PID
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
return false;
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
}
// Evolutions_g45 == 1 means it have not evolved in gen 4-5 games,
// ability do not need to match PID, but only generation 3 ability is allowed
if (pkm.Ability != abilities_g3[0])
// Not evolved in gen4-5 but do not have generation 3 only ability
AddLine(Severity.Invalid, V373, CheckIdentifier.Ability);
Gen3/5 Ability Check Fixes (#1056) * Fix gen3 abiltiy legality check Seperate Ability (AbilityBit i.e top bit of IV32) and AbilityNumber (PID) Fix in-game trade Electrode's ability * Fix function deal with "encountermatch is int" Keep encountermatch as null after UpdateEncounterInfo * Fix gen5-7 ability check Consider ability capsule gen5 personal table have HA, ability_count won't work Some simplification and avoid duplicate invalid message * Simplify ability check Use bool? to mark 3 states GameVersion CXD needs more info * Temp fix gen3 in-game trade ability check Lickitung have 2 regular ability at gen3, there is a AbilityBit and AbilityNumber mismatch Guess those ingame trade have static PID * Change abilitybit to bool and revert change revert change in UpdateEncounterChain. let egg encounter / null encounter choose vs.Last().Species as before * Update Chinese legality translation strings
2017-04-14 23:24:41 +00:00
return null;
Varios legal analysis improvements and fixes (#1051) * Ignore Shedinja evolution moves if the encounter species was a Shedinja * Phione and Manaphy can not inherit level up moves, they hatch only with level 1 moves * Verify ability for generation 5 events * Removed unused sevii isle locations for FRLG valid met location * Verify ability for generation 3 transfer pokemon * Ability error text * Fix gender validation * Cleanup * Check egg hatch cycles are not greater than species/ gift egg encounter hatch cycles * Fix FiredRed Charmander moveset, have 67 moves when it only learns 11 moves * Reduced redundant condition in ability checking
2017-04-12 03:11:58 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyAbility5(int[] abilities)
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
{
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
switch (EncounterMatch)
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
{
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
case PGF g:
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyAbilityMG456(abilities, g.AbilityType);
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
break;
case EncounterSlot w:
// Hidden Abilities for Wild Encounters are only available at a Hidden Grotto
bool grotto = w.Type == SlotType.HiddenGrotto;
if (pkm.AbilityNumber == 4 ^ grotto)
AddLine(Severity.Invalid, grotto ? V217 : V108, CheckIdentifier.Ability);
break;
Legality edge case fixes Some incorrect IDs, some additions (unbreedable hidden abilities in genV) https://projectpokemon.org/forums/forums/topic/41407-pkhex-legality-errors-on-gen-6-updated/?tab=comments#comment-219459
2017-09-06 01:28:38 +00:00
case EncounterEgg e when pkm.AbilityNumber == 4:
// Hidden Abilities for some are unbreedable (male only distribution)
Fix gen5 HA checking for male only species
2017-09-23 14:58:55 +00:00
if (Legal.MixedGenderBreeding.Contains(e.Species) || Legal.FixedGenderFromBiGender.Contains(e.Species))
Refactor split gender breeding logic Inherit Levelup moves & hidden ability (gen5) issues addressed
2017-09-15 01:52:31 +00:00
break; // from female
Legality edge case fixes Some incorrect IDs, some additions (unbreedable hidden abilities in genV) https://projectpokemon.org/forums/forums/topic/41407-pkhex-legality-errors-on-gen-6-updated/?tab=comments#comment-219459
2017-09-06 01:28:38 +00:00
if ((pkm.PersonalInfo.Gender & 0xFF) == 0 || Legal.Ban_BreedHidden.Contains(e.Species))
AddLine(Severity.Invalid, V112, CheckIdentifier.Ability);
break;
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
}
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyAbility6(int[] abilities)
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterSlot slot && pkm.AbilityNumber == 4)
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
bool valid = slot.Permissions.DexNav || slot.Type == SlotType.FriendSafari || slot.Type == SlotType.Horde;
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
if (!valid)
AddLine(Severity.Invalid, V300, CheckIdentifier.Ability);
}
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
else if (EncounterMatch is WC6 g)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyAbilityMG456(abilities, g.AbilityType);
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
else if (Legal.Ban_NoHidden6.Contains(pkm.SpecForm) && pkm.AbilityNumber == 4)
AddLine(Severity.Invalid, V112, CheckIdentifier.Ability);
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyAbility7(int[] abilities)
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterSlot slot && pkm.AbilityNumber == 4)
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
bool valid = slot.Type == SlotType.SOS;
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
if (!valid)
AddLine(Severity.Invalid, V111, CheckIdentifier.Ability);
}
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
else if (EncounterMatch is WC7 g)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyAbilityMG456(abilities, g.AbilityType);
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
else if (Legal.Ban_NoHidden7.Contains(pkm.SpecForm) && pkm.AbilityNumber == 4)
AddLine(Severity.Invalid, V112, CheckIdentifier.Ability);
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyAbilityMG456(int[] abilities, int cardtype)
Simplify ability checks Broken into smaller methods, adjusted flow. Gen5/6/7 mystery gift ability check was typical so just use one repeatable method. Also... Short circuit unflagged EV check fixed; case where 255 & 248 EVs used will trip the 508 fishy flag but does not check the Format >= 6 for the >252 check. Fixed by arranging all the Invalid checks without an if-else.
2017-04-12 03:55:34 +00:00
{
int abilNumber = pkm.AbilityNumber;
if (cardtype < 3 && abilNumber != 1 << cardtype) // set number
{
// Ability can be flipped 0/1 if Ability Capsule is available, is not Hidden Ability, and Abilities are different.
if (pkm.Format >= 6 && cardtype < 2 && abilNumber < 3 && abilities[0] != abilities[1])
AddLine(Severity.Valid, V109, CheckIdentifier.Ability);
else
AddLine(Severity.Invalid, V110, CheckIdentifier.Ability);
}
else if (cardtype == 3 && abilNumber == 4) // 1/2 only
AddLine(Severity.Invalid, V110, CheckIdentifier.Ability);
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
#region VerifyBall
hashset contains over array contains faster++, reduces some linq ToArray() allocations
2017-09-30 21:08:35 +00:00
private void VerifyBallEquals(int ball) => AddBallLine(ball == pkm.Ball);
private void VerifyBallEquals(ICollection<int> balls) => AddBallLine(balls.Contains(pkm.Ball));
private void AddBallLine(bool valid)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{
hashset contains over array contains faster++, reduces some linq ToArray() allocations
2017-09-30 21:08:35 +00:00
if (valid)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V119, CheckIdentifier.Ball);
else
AddLine(Severity.Invalid, V118, CheckIdentifier.Ball);
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyBall()
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
{
Add egg checking for gen2 Delay egg move checking until the end to finish validating moves
2017-02-28 04:57:24 +00:00
if (pkm.Format < 3)
return; // no ball info saved
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
if (!Encounter.Valid)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (EncounterMatch is MysteryGift g)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (pkm.Species == 490 && g.Ball == 0)
Fix for Manaphy Egg Gen 4 event encounter - changed trade egg location in mystery gift search - adapted getMinLevelEncounter to take into account gen 4 eggs in gen 4 games - remvoed manaphy for static encounters, is already included in event database - fix no hatching for an egg check for gen 4 manaphy
2017-03-30 18:58:30 +00:00
// there is no ball data in Manaphy Mystery Gift
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(4); // Pokeball
Fix for Manaphy Egg Gen 4 event encounter - changed trade egg location in mystery gift search - adapted getMinLevelEncounter to take into account gen 4 eggs in gen 4 games - remvoed manaphy for static encounters, is already included in event database - fix no hatching for an egg check for gen 4 manaphy
2017-03-30 18:58:30 +00:00
else
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(g.Ball);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (EncounterMatch is EncounterLink l)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(l.Ball);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
if (EncounterMatch is EncounterTrade t)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(t.Ball); // Pokeball
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Heavy ball legality checks.
2017-03-13 19:12:55 +00:00
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (pkm.Species == 292 && Info.Generation > 3) // Shedinja. For gen3, copy the ball from Nincada
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(4); // Pokeball Only
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
return;
}
Add heavy ball permissions for USUM heavy ball now works in USUM
2017-11-12 00:26:22 +00:00
if (pkm.Ball == 0x14 && !Info.EncounterMatch.EggEncounter && pkm.SM) // Heavy Ball
Heavy ball legality checks.
2017-03-13 19:12:55 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
var lineage = Legal.GetLineage(pkm);
Misc heavy ball tweak/fix Legends weren't in inherit table (no breeding) Move lineage fetch into check so that it is not calculated & unused for other pkms Instead of iterating over inherit table, just use a precomputed list only 5 possible encounters are stored in the int[], there's more cases where heavy ball is invalid but there's no possible encounter for them which would already be flagged by another check.
2017-03-14 01:38:56 +00:00
if (lineage.Any(e => Legal.AlolanCaptureNoHeavyBall.Contains(e)))
Remove heavy ball early return Continue onward to the appropriate checks. Closes #939
2017-03-15 04:13:39 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V116, CheckIdentifier.Ball);
Remove heavy ball early return Continue onward to the appropriate checks. Closes #939
2017-03-15 04:13:39 +00:00
return;
}
Heavy ball legality checks.
2017-03-13 19:12:55 +00:00
}
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterStatic s)
Defer Gift ball check Now returns invalid ball instead of invalid encounter
2016-04-21 03:46:18 +00:00
{
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (s.Gift)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(s.Ball);
General gen5 fixes - begin to impl ball checking - add white forest for white (move greatmarshalt to table4) - fix several datapoints - fix ability from dream world - add in-game version filtering
2017-03-30 06:31:02 +00:00
else if (pkm.Met_Location == 75 && pkm.Gen5) // DreamWorld
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(Legal.DreamWorldBalls);
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
else
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(Legal.GetWildBalls(pkm));
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterSlot w)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Add Poké Pelago ball check Thanks Holla!
2017-01-25 03:49:40 +00:00
if (pkm.Met_Location == 30016 && pkm.Gen7) // Poké Pelago
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(4); // Pokeball
Fix typo https://github.com/kwsch/PKHeX/commit/461fb70f9043fbe5f9404bc25d4f9b6c72c0b42d#commitcomment-22965638
2017-07-07 05:05:54 +00:00
// For gen3/4 Safari Zones and BCC getValidWildEncounters already filter to not return
Safari ball and sport ball checking
2017-03-30 11:18:05 +00:00
// mixed possible encounters between safari, BCC and other encounters
// That means is the first encounter is not safari then there is no safari encounter in the array
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
else if (3 <= Info.Generation && Info.Generation <= 4 && EncounterGenerator.IsSafariSlot(w.Type))
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(5); // Safari Ball
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
else if (Info.Generation == 4 && w.Type == SlotType.BugContest)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(0x18); // Sport Ball
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
else
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(Legal.GetWildBalls(pkm));
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
if (pkm.WasEgg)
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEgg();
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
return;
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
}
Add more strict ball checks Sport/Apricorn/Safari/Dream checked Also snuck in encountertype tracking for readability/calcOnce
2016-03-28 05:05:51 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(4); // Pokeball
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyBallEgg()
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
{
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (Info.Generation < 6) // No inheriting Balls
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(4); // Must be Pokéball -- no ball inheritance.
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
return;
}
if (pkm.Ball == 0x01) // Master Ball
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Invalid, V117, CheckIdentifier.Ball); return; }
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
if (pkm.Ball == 0x10) // Cherish Ball
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Invalid, V120, CheckIdentifier.Ball); return; }
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
if (pkm.Ball == 0x04) // Poké Ball
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{ AddLine(Severity.Valid, V119, CheckIdentifier.Ball); return; }
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
switch (Info.Generation)
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
{
case 6: // Gen6 Inheritance Rules
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEggGen6();
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
return;
case 7: // Gen7 Inheritance Rules
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEggGen7();
Add RBY ingame trades A little bit of logic reorganization
2017-02-23 05:19:29 +00:00
return;
}
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyBallEggGen6()
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
if (pkm.Gender == 2) // Genderless
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(4); // Must be Pokéball as ball can only pass via mother (not Ditto!)
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
if (Legal.BreedMaleOnly.Contains(pkm.Species))
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(4); // Must be Pokéball as ball can only pass via mother (not Ditto!)
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
int ball = pkm.Ball;
if (ball >= 26)
{
AddLine(Severity.Invalid, V126, CheckIdentifier.Ball);
return;
}
if (ball == 0x05) // Safari Ball
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (Legal.GetLineage(pkm).All(e => !Legal.Inherit_Safari.Contains(e)))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else if (pkm.AbilityNumber == 4)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (0x10 < ball && ball < 0x18) // Apricorn Ball
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (Legal.GetLineage(pkm).All(e => !Legal.Inherit_Apricorn6.Contains(e)))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
if (pkm.AbilityNumber == 4)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (ball == 0x18) // Sport Ball
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (Legal.GetLineage(pkm).All(e => !Legal.Inherit_Sport.Contains(e)))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else if (pkm.AbilityNumber == 4)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (ball == 0x19) // Dream Ball
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (Legal.GetLineage(pkm).Any(e => Legal.Inherit_Dream.Contains(e)))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
Add unobtainable dream/hidden combo gen6 Closes #432
2016-11-26 01:54:32 +00:00
if (pkm.AbilityNumber == 4 && Legal.Ban_DreamHidden.Contains(pkm.Species))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
Add unobtainable dream/hidden combo gen6 Closes #432
2016-11-26 01:54:32 +00:00
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (0x0D <= ball && ball <= 0x0F)
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (!Legal.Ban_Gen4Ball_6.Contains(pkm.Species))
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
Add Gen3/4 Ball exclusions Additional Changes: Removed duplicate EncounterLink check Moved RelearnBase resetting to the verifyRelearn() method.
2016-03-29 05:30:23 +00:00
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (0x02 <= ball && ball <= 0x0C) // Don't worry, Ball # 0x05 was already checked.
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
if (Legal.Ban_Gen3Ball.Contains(pkm.Species))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Misc legality checks (gen5-7) (#1020) * Add Flabebe and Pumkaboo altform HA legality check Fix issue #999 The derived value SpecForm can use for other legality checks * Add N's pkm and Hidden Grotto shiny legality checks -fix early return in verifyMisc -add N's pkm legality check: IVs, OT Name, TID, SID, Shiny -add Hidden Grotto shiny check * Fix spelling * More edge cases for gen6 ball checks Ban several altform hidden ability with gen3 ball * Fix gen4 Formcount for altform Manually fix several bytes (http://i.imgur.com/l0Amuto.png)
2017-04-02 13:39:39 +00:00
else if (pkm.AbilityNumber == 4 && Legal.Ban_Gen3BallHidden.Contains(pkm.SpecForm))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
if (pkm.Species > 650 && pkm.Species != 700) // Sylveon
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (Legal.GetWildBalls(pkm).Contains(pkm.Ball))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
Add beyond range ball checks
2016-11-12 14:52:40 +00:00
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V125, CheckIdentifier.Ball);
Add Ball/Ability checks & wc6 PID check Probably am going to move the WC6 fetch logic out
2016-03-21 15:01:08 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyBallEggGen7()
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
var Lineage = Legal.GetLineage(pkm).ToArray();
Add a slew of extra legality checks for gen7 Mostly bank related (unobtainable) and hidden ability availability (against my best judgement) to mimic online checks. Closes #529
2016-12-02 02:48:38 +00:00
if (722 <= pkm.Species && pkm.Species <= 730) // G7 Starters
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(4);
Add a slew of extra legality checks for gen7 Mostly bank related (unobtainable) and hidden ability availability (against my best judgement) to mimic online checks. Closes #529
2016-12-02 02:48:38 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
int ball = pkm.Ball;
if (ball == 0x05) // Safari Ball
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
{
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
if (!Lineage.Any(e => Legal.Inherit_Safari.Contains(e) || Legal.Inherit_SafariMale.Contains(e)))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
else if (pkm.AbilityNumber == 4 && Lineage.Any(e => Legal.Ban_SafariBallHidden_7.Contains(e)))
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
else
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (0x10 < ball && ball < 0x18) // Apricorn Ball
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
{
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
if (!Lineage.Any(e => Legal.Inherit_Apricorn7.Contains(e)))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
else if (pkm.AbilityNumber == 4 && (Lineage.Contains(029) || Lineage.Contains(032))) // Nido
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
else
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (ball == 0x18) // Sport Ball
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
{
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
if (!Lineage.Any(e => Legal.Inherit_Sport.Contains(e)))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Misc gen4 legality checking fixes (#1025) * Fix hgss safari zone encounters * Add fishing slots at night (hgss) * Fix Japanese Special Character (gen 4) * Add gen4 ball with HA legality checking (gen7) Males can pass the ball with HA females ONLY when they have the same pokedex number * Add safari ball with HA checking (gen7) * Fix ball legality checking for shedninja Poke Ball only * Map Unicode Chinese characters to in-game chars Chinese species names in sun/moon were remapped by GF. * Add nickname legality check for east asia language Can not give Chinese or Japanese kanji nickname to pkm. * Remove hiding nickname textbox for chs/cht Since remapping and legality checking are implemented, There will be no strange character or misunderstanding.
2017-04-04 03:02:40 +00:00
else if (pkm.AbilityNumber == 4 && (Lineage.Contains(313) || Lineage.Contains(314))) // Volbeat/Illumise
AddLine(Severity.Invalid, V122, CheckIdentifier.Ball);
else
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (ball == 0x19) // Dream Ball
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (Lineage.Any(e => Legal.Inherit_Dream.Contains(e) || Legal.Inherit_DreamMale.Contains(e)))
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (0x0D <= ball && ball <= 0x0F) // Dusk Heal Quick
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (!Legal.Ban_Gen4Ball_7.Contains(pkm.Species))
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
return;
}
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (0x02 <= ball && ball <= 0x0C) // Don't worry, Ball # 0x05 was already checked.
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (!Legal.Ban_Gen3Ball_7.Contains(pkm.Species))
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V121, CheckIdentifier.Ball);
Update met locations for hatching Add the two invalid met locations (mystery zone, faraway place) to the dropdown anyway Also add some ball checks for gen7 (may be wrong, but better than nothing)
2016-11-12 05:23:33 +00:00
return;
}
Add beyond range ball checks
2016-11-12 14:52:40 +00:00
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (ball == 26)
Add beyond range ball checks
2016-11-12 14:52:40 +00:00
{
Add uncapturable edge case beast ball can't catch these in a beast ball as the only encounter is a gift (porygon & evos, and aerodactyl) #1100
2017-05-10 02:27:30 +00:00
if ((pkm.Species > 731 && pkm.Species <= 785) || Lineage.Any(e => Legal.PastGenAlolanNatives.Contains(e) && !Legal.PastGenAlolanNativesUncapturable.Contains(e)))
Add beyond range ball checks
2016-11-12 14:52:40 +00:00
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Add beyond range ball checks
2016-11-12 14:52:40 +00:00
return;
}
if (Lineage.Any(e => Legal.PastGenAlolanScans.Contains(e)))
{
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, V123, CheckIdentifier.Ball);
Add beyond range ball checks
2016-11-12 14:52:40 +00:00
return;
}
// next statement catches all new alolans
}
if (pkm.Species > 721)
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyBallEquals(Legal.GetWildBalls(pkm));
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
return;
}
Add beyond range ball checks
2016-11-12 14:52:40 +00:00
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
if (ball >= 27)
{
AddLine(Severity.Invalid, V126, CheckIdentifier.Ball);
return;
}
AddLine(Severity.Invalid, V125, CheckIdentifier.Ball);
Split egg ball check logic per generation Expect false flagging of bred balls until this is more researched.
2016-11-11 05:10:28 +00:00
}
Fix gen7 Eevee eggs checking and cleanup (#1028) * Fix Eevee eggs in gen7 and cleanup Needs to mark EncounterstaticMatch as null after verifyencounterstatic failure Egg moves were checked in parseMovesWasEggPreRelearn, so verifyeggmoves function is unnecessay No need to search friend safari for gen4 transfer Simplify parsing special egg moves Skip level-up moves when checking higher level moves * Add PokePark Encounter * Fix eggmoves and eventmoves conflict checking * Add Egg Pokémon Present Eggs Solve issue #987 Use special move to distinguish eventegg * Fix Transferred gen3 egg Checking Refactoring location in gen4transfer * Fix species recognition of event eggs include preevolutions checking * Check encounter before egg for transferred pkm Remove prerelearnencouner function. The existence of RelearnMoves is checked in parseMovesSpecialMoveset
2017-04-07 00:41:25 +00:00
#endregion
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private CheckResult VerifyHistory()
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
{
Refactoring & Fixes Add tracking for wild / link encounters Fixed sylveon ball check Added Demo link pkm Added Horde Hidden Ability checks
2016-03-23 02:47:13 +00:00
if (!Encounter.Valid)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Valid, V127, CheckIdentifier.History);
Add more memory checks Mostly gen3-5 checks if they're ever supported; added bad hack check. Check yer battle videos to expose da haxxers.
2016-12-08 02:28:24 +00:00
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (Info.Generation < 6)
Add more memory checks Mostly gen3-5 checks if they're ever supported; added bad hack check. Check yer battle videos to expose da haxxers.
2016-12-08 02:28:24 +00:00
{
if (pkm.Format < 6)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Valid, V128, CheckIdentifier.History);
Add more memory checks Mostly gen3-5 checks if they're ever supported; added bad hack check. Check yer battle videos to expose da haxxers.
2016-12-08 02:28:24 +00:00
if (pkm.OT_Affection > 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V129, CheckIdentifier.History);
Add more memory checks Mostly gen3-5 checks if they're ever supported; added bad hack check. Check yer battle videos to expose da haxxers.
2016-12-08 02:28:24 +00:00
if (pkm.OT_Memory > 0 || pkm.OT_Feeling > 0 || pkm.OT_Intensity > 0 || pkm.OT_TextVar > 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V130, CheckIdentifier.History);
Add more memory checks Mostly gen3-5 checks if they're ever supported; added bad hack check. Check yer battle videos to expose da haxxers.
2016-12-08 02:28:24 +00:00
}
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (pkm.Format >= 6 && Info.Generation != pkm.Format && pkm.CurrentHandler != 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V124, CheckIdentifier.History);
Improve file loaded transfer preference use last char of file extension if available. edge case for pk[m] considered: pk[m] => 0x6D, -0x30 = 61d, &7 = 5, which prefers 6 instead of 7+ :) adds a check for transferred pkm not having their CurrentHandler being flagged as the save file (impossible for a transferred PKM to be still handled by the OT).
2017-02-07 06:19:10 +00:00
Add more memory checks Mostly gen3-5 checks if they're ever supported; added bad hack check. Check yer battle videos to expose da haxxers.
2016-12-08 02:28:24 +00:00
if (pkm.HT_Gender > 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, string.Format(V131, pkm.HT_Gender), CheckIdentifier.History);
Update cleared data legality checks Add in a few more, a little bit of shuffling
2017-01-25 17:17:20 +00:00
Rework mysterygift pkm sprite generation don't bother converting to pkm then generating the sprite off that; use the overload with int/bool removes sav/pkm dependency for generating gift descriptions, and standardizes the names a little. maybe a PKMBase interface would be useful...
2017-11-18 19:34:23 +00:00
if (EncounterMatch is WC6 wc6 && wc6.OT_Name.Length > 0)
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
{
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
if (pkm.OT_Friendship != PersonalTable.AO[EncounterMatch.Species].BaseFriendship)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V132, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.OT_Affection != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V133, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.CurrentHandler != 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V134, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
}
Rework mysterygift pkm sprite generation don't bother converting to pkm then generating the sprite off that; use the overload with int/bool removes sav/pkm dependency for generating gift descriptions, and standardizes the names a little. maybe a PKMBase interface would be useful...
2017-11-18 19:34:23 +00:00
else if (EncounterMatch is WC7 wc7 && wc7.OT_Name.Length > 0)
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
{
more usum prep species added requires the 'latest personal table' reference to be USUM's; the other referencs for .SM are fine as there's no possibility to have a species ID high enough for it to matter.
2017-09-19 05:36:06 +00:00
if (pkm.OT_Friendship != PersonalTable.USUM[EncounterMatch.Species].BaseFriendship)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V132, CheckIdentifier.History);
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
if (pkm.OT_Affection != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V133, CheckIdentifier.History);
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
if (pkm.CurrentHandler != 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V134, CheckIdentifier.History);
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
}
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
else if (EncounterMatch is MysteryGift mg && mg.Format < 6 && pkm.Format >= 6)
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
{
if (pkm.OT_Affection != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V133, CheckIdentifier.History);
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
if (pkm.CurrentHandler != 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V134, CheckIdentifier.History);
Fix event OT friendship check Should compare to the original species not to the current Added corresponding wc7 checks (and 4/5->6+ checks, unused).
2017-01-11 01:14:48 +00:00
}
Misc legality updates Add ゲーフリ to valid 151 OTs Revise logic for split-forme egg moves (Closes #777) Save config on closing instead of option change Remove geolocation setting for 6->7 and associated legality check, move geolocation validity check higher (Closes #776)
2017-01-31 01:49:28 +00:00
// Geolocations
var geo = new[]
Add encountertrades
2016-11-11 03:29:00 +00:00
{
Misc legality updates Add ゲーフリ to valid 151 OTs Revise logic for split-forme egg moves (Closes #777) Save config on closing instead of option change Remove geolocation setting for 6->7 and associated legality check, move geolocation validity check higher (Closes #776)
2017-01-31 01:49:28 +00:00
pkm.Geo1_Country, pkm.Geo2_Country, pkm.Geo3_Country, pkm.Geo4_Country, pkm.Geo5_Country,
pkm.Geo1_Region, pkm.Geo2_Region, pkm.Geo3_Region, pkm.Geo4_Region, pkm.Geo5_Region,
};
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
Misc legality updates Add ゲーフリ to valid 151 OTs Revise logic for split-forme egg moves (Closes #777) Save config on closing instead of option change Remove geolocation setting for 6->7 and associated legality check, move geolocation validity check higher (Closes #776)
2017-01-31 01:49:28 +00:00
// Check sequential order (no zero gaps)
bool geoEnd = false;
for (int i = 0; i < 5; i++)
{
if (geoEnd && geo[i] != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V135, CheckIdentifier.History);
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
Misc legality updates Add ゲーフリ to valid 151 OTs Revise logic for split-forme egg moves (Closes #777) Save config on closing instead of option change Remove geolocation setting for 6->7 and associated legality check, move geolocation validity check higher (Closes #776)
2017-01-31 01:49:28 +00:00
if (geo[i] != 0)
continue;
if (geo[i + 5] != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V136, CheckIdentifier.History);
Misc legality updates Add ゲーフリ to valid 151 OTs Revise logic for split-forme egg moves (Closes #777) Save config on closing instead of option change Remove geolocation setting for 6->7 and associated legality check, move geolocation validity check higher (Closes #776)
2017-01-31 01:49:28 +00:00
geoEnd = true;
}
if (pkm.Format >= 7)
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
return VerifyHistory7(geo);
Fix deoxys handling on gen6+ WasEvent was not yielding true for a past gen specimen as the deoxys exclusion for ORAS was present. Remove and change handling.
2017-04-01 21:20:00 +00:00
// Determine if we should check for Handling Trainer Memories
// A Pokémon is untraded if...
bool untraded = pkm.HT_Name.Length == 0 || pkm.Geo1_Country == 0;
Misc event egg tweaks Thanks Kirzi!
2017-10-06 06:13:48 +00:00
if (EncounterMatch is MysteryGift gift)
Fix deoxys handling on gen6+ WasEvent was not yielding true for a past gen specimen as the deoxys exclusion for ORAS was present. Remove and change handling.
2017-04-01 21:20:00 +00:00
{
untraded |= !pkm.WasEventEgg;
Misc event egg tweaks Thanks Kirzi!
2017-10-06 06:13:48 +00:00
untraded &= gift.IsEgg;
Fix deoxys handling on gen6+ WasEvent was not yielding true for a past gen specimen as the deoxys exclusion for ORAS was present. Remove and change handling.
2017-04-01 21:20:00 +00:00
}
if (pkm.WasLink && (EncounterMatch as EncounterLink)?.OT == false)
untraded = false;
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
else if (Info.Generation < 6)
Fix deoxys handling on gen6+ WasEvent was not yielding true for a past gen specimen as the deoxys exclusion for ORAS was present. Remove and change handling.
2017-04-01 21:20:00 +00:00
untraded = false;
if (untraded) // Is not Traded
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
if (pkm.HT_Name.Length != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V146, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.Geo1_Country != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V147, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.HT_Memory != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V148, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.CurrentHandler != 0) // Badly edited; PKHeX doesn't trip this.
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V139, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.HT_Friendship != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V140, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.HT_Affection != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V141, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.XY && pkm.CNTs.Any(stat => stat > 0))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V138, CheckIdentifier.History);
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
if (VerifyHistoryUntradedHandler(pkm, out CheckResult chk1))
return chk1;
if (EncounterMatch.Species != pkm.Species && VerifyHistoryUntradedEvolution(pkm, out CheckResult chk2))
return chk2;
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
}
else // Is Traded
{
Reorder mysterygift 5+ egg generating logic Closes #1331 where IsEgg was checked before it was set handle legality cases (set nickname & flag)
2017-07-14 04:05:20 +00:00
if (pkm.Format == 6 && pkm.HT_Memory == 0 && !pkm.IsEgg)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V150, CheckIdentifier.History);
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
}
Check memories for eggs/transfer Catches some of those jan2014 banked pentagon mons without OT memories The last check is unused; the last two checks are designed in case past gen pkm are checked.
2016-03-31 01:53:34 +00:00
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
// Memory ChecksResult
if (pkm.IsEgg)
Check memories for eggs/transfer Catches some of those jan2014 banked pentagon mons without OT memories The last check is unused; the last two checks are designed in case past gen pkm are checked.
2016-03-31 01:53:34 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.HT_Memory != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V149, CheckIdentifier.History);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.OT_Memory != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V151, CheckIdentifier.History);
Check memories for eggs/transfer Catches some of those jan2014 banked pentagon mons without OT memories The last check is unused; the last two checks are designed in case past gen pkm are checked.
2016-03-31 01:53:34 +00:00
}
Refactoring +docs Add some documentation for the high-level encounter finding Fix encounterstatics not being filtered for the associated game version (closes #1372) was a side effect of refactoring this week
2017-07-30 19:31:17 +00:00
else if (!(EncounterMatch is WC6))
Check memories for eggs/transfer Catches some of those jan2014 banked pentagon mons without OT memories The last check is unused; the last two checks are designed in case past gen pkm are checked.
2016-03-31 01:53:34 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.OT_Memory == 0 ^ !pkm.Gen6)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V152, CheckIdentifier.History);
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (Info.Generation < 6 && pkm.OT_Affection != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, V129, CheckIdentifier.History);
Check memories for eggs/transfer Catches some of those jan2014 banked pentagon mons without OT memories The last check is unused; the last two checks are designed in case past gen pkm are checked.
2016-03-31 01:53:34 +00:00
}
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
// Unimplemented: Ingame Trade Memories
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Valid, V145, CheckIdentifier.History);
Add History check, Expand ball check
2016-03-22 04:31:06 +00:00
}
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
private CheckResult VerifyHistory7(int[] geo)
{
if (pkm.VC1)
{
var hasGeo = geo.Any(d => d != 0);
if (!hasGeo)
return new CheckResult(Severity.Invalid, V137, CheckIdentifier.History);
}
if (Info.Generation >= 7 && pkm.CNTs.Any(stat => stat > 0))
return new CheckResult(Severity.Invalid, V138, CheckIdentifier.History);
if (!pkm.WasEvent && pkm.HT_Name.Length == 0) // Is not Traded
{
if (VerifyHistoryUntradedHandler(pkm, out CheckResult chk1))
return chk1;
if (EncounterMatch.Species != pkm.Species && VerifyHistoryUntradedEvolution(pkm, out CheckResult chk2))
return chk2;
}
return new CheckResult(Severity.Valid, V145, CheckIdentifier.History);
}
private static bool VerifyHistoryUntradedHandler(PKM pkm, out CheckResult result)
{
result = null;
if (pkm.CurrentHandler != 0) // Badly edited; PKHeX doesn't trip this.
result = new CheckResult(Severity.Invalid, V139, CheckIdentifier.History);
else if (pkm.HT_Friendship != 0)
result = new CheckResult(Severity.Invalid, V140, CheckIdentifier.History);
else if (pkm.HT_Affection != 0)
result = new CheckResult(Severity.Invalid, V141, CheckIdentifier.History);
else
return false;
return true;
}
private static bool VerifyHistoryUntradedEvolution(PKM pkm, out CheckResult result)
{
result = null;
// Handling Trainer string is empty implying it has not been traded.
// If it must be trade evolved, flag it.
if (pkm.Species == 350) // Milotic
{
Fix trade evolution check incorrect behavior; check for milotic case if appropriate first Closes #1609
2017-11-15 18:11:05 +00:00
if (Legal.IsTradeEvolved(pkm))
return false;
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
if (pkm.CNT_Beauty < 170) // Beauty Contest Stat Requirement
result = new CheckResult(Severity.Invalid, V143, CheckIdentifier.History);
else if (pkm.CurrentLevel == 1)
result = new CheckResult(Severity.Invalid, V144, CheckIdentifier.History);
else
return false;
Fix trade evolution check incorrect behavior; check for milotic case if appropriate first Closes #1609
2017-11-15 18:11:05 +00:00
return true;
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
}
Fix trade evolution check incorrect behavior; check for milotic case if appropriate first Closes #1609
2017-11-15 18:11:05 +00:00
if (!Legal.IsTradeEvolved(pkm))
return false;
result = new CheckResult(Severity.Invalid, V142, CheckIdentifier.History);
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
return true;
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private CheckResult VerifyCommonMemory(int handler)
Add legality checks for HM-specific memories Pokemon which have memories of using moves that they cannot learn will be flagged as illegal.
2016-05-07 06:16:35 +00:00
{
int m = 0;
Checks for PKM Center memories
2016-05-09 23:09:40 +00:00
int t = 0;
Add legality checks for HM-specific memories Pokemon which have memories of using moves that they cannot learn will be flagged as illegal.
2016-05-07 06:16:35 +00:00
string resultPrefix = "";
switch (handler)
{
case 0:
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
m = pkm.OT_Memory;
t = pkm.OT_TextVar;
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
resultPrefix = V205;
Add legality checks for HM-specific memories Pokemon which have memories of using moves that they cannot learn will be flagged as illegal.
2016-05-07 06:16:35 +00:00
break;
case 1:
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
m = pkm.HT_Memory;
t = pkm.HT_TextVar;
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
resultPrefix = V206;
Add legality checks for HM-specific memories Pokemon which have memories of using moves that they cannot learn will be flagged as illegal.
2016-05-07 06:16:35 +00:00
break;
}
int matchingMoveMemory = Array.IndexOf(Legal.MoveSpecificMemories[0], m);
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (matchingMoveMemory != -1 && pkm.Species != 235 && !Legal.GetCanLearnMachineMove(pkm, Legal.MoveSpecificMemories[1][matchingMoveMemory], 6))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, string.Format(V153, resultPrefix), CheckIdentifier.Memory);
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
Checks for PKM Center memories
2016-05-09 23:09:40 +00:00
if (m == 6 && !Legal.LocationsWithPKCenter[0].Contains(t))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, string.Format(V154, resultPrefix), CheckIdentifier.Memory);
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
Add Memory 21 None of my database mons even had this memory :\
2016-05-10 01:19:31 +00:00
if (m == 21) // {0} saw {2} carrying {1} on its back. {4} that {3}.
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (!Legal.GetCanLearnMachineMove(new PK6 {Species = t, EXP = PKX.GetEXP(100, t)}, 19, 6))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, string.Format(V153, resultPrefix), CheckIdentifier.Memory);
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if ((m == 16 || m == 48) && (t == 0 || !Legal.GetCanKnowMove(pkm, t, 6)))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, string.Format(V153, resultPrefix), CheckIdentifier.Memory);
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
if (m == 49 && (t == 0 || !Legal.GetCanRelearnMove(pkm, t, 6))) // {0} was able to remember {2} at {1}'s instruction. {4} that {3}.
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Invalid, string.Format(V153, resultPrefix), CheckIdentifier.Memory);
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
return new CheckResult(Severity.Valid, string.Format(V155, resultPrefix), CheckIdentifier.Memory);
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyOTMemoryIs(int[] values)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
{
if (pkm.OT_Memory != values[0])
AddLine(Severity.Invalid, string.Format(V197, V205, values[0]), CheckIdentifier.Memory);
if (pkm.OT_Intensity != values[1])
AddLine(Severity.Invalid, string.Format(V198, V205, values[1]), CheckIdentifier.Memory);
if (pkm.OT_TextVar != values[2])
AddLine(Severity.Invalid, string.Format(V199, V205, values[2]), CheckIdentifier.Memory);
if (pkm.OT_Feeling != values[3])
AddLine(Severity.Invalid, string.Format(V200, V205, values[3]), CheckIdentifier.Memory);
Add legality checks for HM-specific memories Pokemon which have memories of using moves that they cannot learn will be flagged as illegal.
2016-05-07 06:16:35 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyOTMemory()
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
{
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
if (pkm.Format < 6)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
if (!History.Valid)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (Info.Generation < 6)
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyOTMemoryIs(new [] {0, 0, 0, 0}); // empty
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
}
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
Misc event egg tweaks Thanks Kirzi!
2017-10-06 06:13:48 +00:00
switch (EncounterMatch)
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
{
Misc event egg tweaks Thanks Kirzi!
2017-10-06 06:13:48 +00:00
case EncounterTrade _:
switch (Info.Generation)
{
case 6:
break; // Undocumented, uncommon, and insignificant -- don't bother.
case 7:
VerifyOTMemoryIs(new[] { 1, 3, 40, 5 });
break;
}
return;
case WC6 g when !g.IsEgg:
VerifyOTMemoryIs(new[] { g.OT_Memory, g.OT_Intensity, g.OT_TextVar, g.OT_Feeling });
return;
case WC7 g when !g.IsEgg:
VerifyOTMemoryIs(new[] { g.OT_Memory, g.OT_Intensity, g.OT_TextVar, g.OT_Feeling });
return;
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
}
Misc event egg tweaks Thanks Kirzi!
2017-10-06 06:13:48 +00:00
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (Info.Generation >= 7)
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyOTMemoryIs(new[] {0, 0, 0, 0}); // empty
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
return;
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
switch (pkm.OT_Memory)
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
{
Hatch memory check for memories of OT Memory will be flagged as illegal if Pokemon did not hatch from an egg
2016-05-25 05:20:19 +00:00
case 2: // {0} hatched from an Egg and saw {1} for the first time at... {2}. {4} that {3}.
Misc event egg tweaks Thanks Kirzi!
2017-10-06 06:13:48 +00:00
if (pkm.Egg_Location == 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V160, V205), CheckIdentifier.Memory);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
break;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
case 4: // {0} became {1}’s friend when it arrived via Link Trade at... {2}. {4} that {3}.
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V161, V205), CheckIdentifier.Memory);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Checks for PKM Center memories
2016-05-09 23:09:40 +00:00
case 6: // {0} went to the Pokémon Center in {2} with {1} and had its tired body healed there. {4} that {3}.
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
int matchingOriginGame = Array.IndexOf(Legal.LocationsWithPKCenter[0], pkm.OT_TextVar);
Rearrange logic for Location Get game ID once, check pk6 game first. Will be easy to insert a third case if/when the time comes.
2016-05-10 00:51:35 +00:00
if (matchingOriginGame != -1)
{
int gameID = Legal.LocationsWithPKCenter[1][matchingOriginGame];
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.XY && gameID != 0 || pkm.AO && gameID != 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V162, V205), CheckIdentifier.Memory);
Rearrange logic for Location Get game ID once, check pk6 game first. Will be easy to insert a third case if/when the time comes.
2016-05-10 00:51:35 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
AddLine(VerifyCommonMemory(0));
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add memorycheck 14 (species can be captured)
2016-05-06 03:35:18 +00:00
case 14:
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (!Legal.GetCanBeCaptured(pkm.OT_TextVar, Info.Generation, (GameVersion)pkm.Version))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V165, V205), CheckIdentifier.Memory);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, string.Format(V164, V205), CheckIdentifier.Memory);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.XY && Legal.Memory_NotXY.Contains(pkm.OT_Memory))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V163, V205), CheckIdentifier.Memory);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.AO && Legal.Memory_NotAO.Contains(pkm.OT_Memory))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V163, V205), CheckIdentifier.Memory);
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
AddLine(VerifyCommonMemory(0));
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyHTMemory()
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
{
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.Format < 6)
return;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
if (!History.Valid)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
Misc updates Closes #860 by adding in prompt for Gen1 saves to determine if the save originated from VC. Will disable Gen2 legality sources when checking pk1 files. -- Fixes froslass/gallade evolution tree pruning movesets. For whatever reason, the level argument of the Evolution is not 0 when using the item; I manually edited the evos_sm.pkl binary to set the 2 evolutions from [XX] -> 00. Fixes gen1 ingame trades slipping through the getEncounter12 preference. Gen2 has set TIDs, so check if TID is set. Loosens checks for Gen7 trades (including prior transfers) as trading between games clears the memory. Add 3 more g7 trainer stat records too. Thanks Holla! -- Add getMoves(100) optimization as gen7 learnsets can grab 1->100, better than looping over the range every time it's checked.
2017-03-12 23:36:23 +00:00
if (pkm.Format >= 7)
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
{
Misc updates Closes #860 by adding in prompt for Gen1 saves to determine if the save originated from VC. Will disable Gen2 legality sources when checking pk1 files. -- Fixes froslass/gallade evolution tree pruning movesets. For whatever reason, the level argument of the Evolution is not 0 when using the item; I manually edited the evos_sm.pkl binary to set the 2 evolutions from [XX] -> 00. Fixes gen1 ingame trades slipping through the getEncounter12 preference. Gen2 has set TIDs, so check if TID is set. Loosens checks for Gen7 trades (including prior transfers) as trading between games clears the memory. Add 3 more g7 trainer stat records too. Thanks Holla! -- Add getMoves(100) optimization as gen7 learnsets can grab 1->100, better than looping over the range every time it's checked.
2017-03-12 23:36:23 +00:00
/*
* Bank Transfer adds in the Link Trade Memory.
* Trading 7<->7 between games (not Bank) clears this data.
*/
if (pkm.HT_Memory == 0)
{
if (pkm.HT_TextVar != 0 || pkm.HT_Intensity != 0 || pkm.HT_Feeling != 0)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V329, CheckIdentifier.Memory);
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
return;
Misc updates Closes #860 by adding in prompt for Gen1 saves to determine if the save originated from VC. Will disable Gen2 legality sources when checking pk1 files. -- Fixes froslass/gallade evolution tree pruning movesets. For whatever reason, the level argument of the Evolution is not 0 when using the item; I manually edited the evos_sm.pkl binary to set the 2 evolutions from [XX] -> 00. Fixes gen1 ingame trades slipping through the getEncounter12 preference. Gen2 has set TIDs, so check if TID is set. Loosens checks for Gen7 trades (including prior transfers) as trading between games clears the memory. Add 3 more g7 trainer stat records too. Thanks Holla! -- Add getMoves(100) optimization as gen7 learnsets can grab 1->100, better than looping over the range every time it's checked.
2017-03-12 23:36:23 +00:00
}
Update gen7 memory checks y u give vc mons memories? add HT memory check for transported mons
2017-01-27 04:13:27 +00:00
Ignore memory restriction for past gen same OT xfrs Closes #1145
2017-05-19 00:38:26 +00:00
// Transfer 6->7 & withdraw to same HT => keeps past gen memory
// Don't require link trade memory for these past gen cases
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
int gen = Info.Generation;
Ignore memory restriction for past gen same OT xfrs Closes #1145
2017-05-19 00:38:26 +00:00
if (3 <= gen && gen < 7 && pkm.CurrentHandler == 1)
return;
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
if (pkm.HT_Memory != 4)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V156, CheckIdentifier.Memory);
Add basic VC legality checks I may use VC and VC1 a little too interchangeably; things would have to be updated if GSC were ever released anyway. Usage of VC is for generic stuff while VC1 allows VC2 to slip by. no shiny mew :cactus: memories + geolocation, gee thanks bank. Would need to be updated with gen1 legality checking to add moves/finer encounter details, but this will do for now. Please don't report things marked 'legal' that have invalid moves/levels.
2017-01-27 05:35:26 +00:00
if (pkm.HT_TextVar != 0)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V157, CheckIdentifier.Memory);
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
if (pkm.HT_Intensity != 1)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V158, CheckIdentifier.Memory);
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
if (pkm.HT_Feeling > 10)
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V159, CheckIdentifier.Memory);
Add gen7 memory checks No memories, should not have any. Closes #481
2016-11-26 01:30:39 +00:00
return;
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
switch (pkm.HT_Memory)
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
{
Update gen7 memory checks y u give vc mons memories? add HT memory check for transported mons
2017-01-27 04:13:27 +00:00
case 0:
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
if (string.IsNullOrEmpty(pkm.HT_Name))
Update gen7 memory checks y u give vc mons memories? add HT memory check for transported mons
2017-01-27 04:13:27 +00:00
return;
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, V150, CheckIdentifier.Memory); return;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
case 1: // {0} met {1} at... {2}. {1} threw a Poké Ball at it, and they started to travel together. {4} that {3}.
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V202, V206), CheckIdentifier.Memory); return;
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
case 2: // {0} hatched from an Egg and saw {1} for the first time at... {2}. {4} that {3}.
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V160, V206), CheckIdentifier.Memory); return;
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
Add memorycheck 14 (species can be captured)
2016-05-06 03:35:18 +00:00
case 14:
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (Legal.GetCanBeCaptured(pkm.HT_TextVar, Info.Generation))
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Valid, string.Format(V164, V206), CheckIdentifier.Memory);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else
Refactory legality strings For future translation feature as per #959 3 helper methods provided to facilitate the localization (import / export / update) I decided to simplify some duplicate-function sections
2017-03-21 07:18:38 +00:00
AddLine(Severity.Invalid, string.Format(V165, V206), CheckIdentifier.Memory);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
AddLine(VerifyCommonMemory(1));
Add basic memory checks Thanks Eskuero. WIP.
2016-05-06 03:05:22 +00:00
}
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
private void VerifyConsoleRegion()
Check if the country is avalaible on the 3DS region
2016-05-11 23:20:31 +00:00
{
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
AddLine(VerifyConsoleRegion(pkm));
}
private static CheckResult VerifyConsoleRegion(PKM pkm)
{
int consoleRegion = pkm.ConsoleRegion;
if (consoleRegion >= 7)
return new CheckResult(Severity.Invalid, V301, CheckIdentifier.Geography);
return IsConsoleRegionCountryValid(consoleRegion, pkm.Country)
? new CheckResult(Severity.Valid, V303, CheckIdentifier.Geography)
: new CheckResult(Severity.Invalid, V302, CheckIdentifier.Geography);
}
private static bool IsConsoleRegionCountryValid(int consoleRegion, int country)
{
switch (consoleRegion)
Check if the country is avalaible on the 3DS region
2016-05-11 23:20:31 +00:00
{
Cleanup Condense code to instead indicate if it is valid or not, remove duplicate returns, handle ConsoleRegion values that are not 012456 (init valid to false!).
2016-05-12 04:18:05 +00:00
case 0: // Japan
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
return country == 1;
Cleanup Condense code to instead indicate if it is valid or not, remove duplicate returns, handle ConsoleRegion values that are not 012456 (init valid to false!).
2016-05-12 04:18:05 +00:00
case 1: // Americas
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
return 8 <= country && country <= 52 || new[] {153, 156, 168, 174, 186}.Contains(country);
Cleanup Condense code to instead indicate if it is valid or not, remove duplicate returns, handle ConsoleRegion values that are not 012456 (init valid to false!).
2016-05-12 04:18:05 +00:00
case 2: // Europe
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
return 64 <= country && country <= 127 || new[] {169, 184, 185}.Contains(country);
Cleanup Condense code to instead indicate if it is valid or not, remove duplicate returns, handle ConsoleRegion values that are not 012456 (init valid to false!).
2016-05-12 04:18:05 +00:00
case 4: // China
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
return country == 144 || country == 160;
Cleanup Condense code to instead indicate if it is valid or not, remove duplicate returns, handle ConsoleRegion values that are not 012456 (init valid to false!).
2016-05-12 04:18:05 +00:00
case 5: // Korea
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
return country == 136;
Cleanup Condense code to instead indicate if it is valid or not, remove duplicate returns, handle ConsoleRegion values that are not 012456 (init valid to false!).
2016-05-12 04:18:05 +00:00
case 6: // Taiwan
Add Hong Kong to Taiwan countries list Closes #1473
2017-09-20 22:18:33 +00:00
return country == 144 || country == 128;
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
default:
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
return false;
Check if the country is avalaible on the 3DS region
2016-05-11 23:20:31 +00:00
}
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyForm()
Add Form checks
2016-04-14 10:17:03 +00:00
{
if (!Encounter.Valid)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
Add Form checks
2016-04-14 10:17:03 +00:00
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.Format < 4)
Refactoring fixes Fix misc refactoring errors Don't early abort gen4->5+ encounter generation (need to check ingame trades for abra/gengar). Can avoid by PID dictionary to check for trades first, but unimplemented. Closes #1377 , not fixing Pokewalker PID mismatch as algorithm needs to be ironed out separately.
2017-08-01 21:55:10 +00:00
return; // no forms exist
Add savegame sensitive pkm legality checking uses the forme count of the savefile (rather than a futureproofed same-gen forme count) Closes #1559
2017-11-07 03:31:24 +00:00
int count = PersonalInfo.FormeCount;
early abort on altforms < 1 prior generations store 0 instead of 1 for some cases https://github.com/kwsch/PKHeX/commit/24121553b4c988f1670261355dbe38681e9906df#commitcomment-25445089
2017-11-07 05:08:39 +00:00
if (count <= 1 && pkm.AltForm == 0)
Refactoring fixes Fix misc refactoring errors Don't early abort gen4->5+ encounter generation (need to check ingame trades for abra/gengar). Can avoid by PID dictionary to check for trades first, but unimplemented. Closes #1377 , not fixing Pokewalker PID mismatch as algorithm needs to be ironed out separately.
2017-08-01 21:55:10 +00:00
return; // no forms to check
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
Add forme range check method to personalinfo relocates logic to better location
2017-11-22 02:31:24 +00:00
if (!PersonalInfo.IsFormeWithinRange(pkm.AltForm) && !FormConverter.IsValidOutOfBoundsForme(pkm.Species, pkm.AltForm, Info.Generation))
Refactoring Add placeholder met location list for hatched eggs Moved generation nonspecific tables to the master Tables.
2016-11-09 05:43:22 +00:00
{
Flag invalid forms on sav compatibility check closes #1615
2017-11-16 22:30:18 +00:00
AddLine(Severity.Invalid, string.Format(V304, count-1, pkm.AltForm), CheckIdentifier.Form);
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
return;
Refactoring Add placeholder met location list for hatched eggs Moved generation nonspecific tables to the master Tables.
2016-11-09 05:43:22 +00:00
}
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
Refactor encounter matching exercise in deferred execution/state machine, only calculate possible matches until a sufficiently valid match is obtained. Previous setup would try to calculate the 'best match' and had band-aid workarounds in cases where a subsequent check may determine it to be a false match. There's still more ways to improve speed: - precalculate relationships for Encounter Slots rather than iterating over every area - yielding individual slots instead of an entire area - group non-egg wondercards by ID in a dict/hashtable for faster retrieval reworked some internals: - EncounterMatch is always an IEncounterable instead of an object, for easy pattern matching. - Splitbreed checking is done per encounter and is stored in the EncounterEgg result - Encounter validation uses Encounter/Move/RelearnMove/Evolution to whittle to the final encounter. As a part of the encounter matching, a lazy peek is used to check if an invalid encounter should be retained instead of discarded; if another encounter has not been checked, it'll stop the invalid checks and move on. If it is the last encounter, no other valid encounters exist so it will keep the parse for the invalid encounter. If no encounters are yielded, then there is no encountermatch. An EncounterInvalid is created to store basic details, and the parse is carried out. Breaks some legality checking features for flagging invalid moves in more detail, but those can be re-added in a separate check (if splitbreed & any move invalid -> check for other split moves). Should now be easier to follow the flow & maintain :smile:
2017-05-28 04:17:53 +00:00
if (EncounterMatch is EncounterSlot w && w.Type == SlotType.FriendSafari)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyFormFriendSafari();
Refactoring Add placeholder met location list for hatched eggs Moved generation nonspecific tables to the master Tables.
2016-11-09 05:43:22 +00:00
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
switch (pkm.Species)
Add Form checks
2016-04-14 10:17:03 +00:00
{
Invert minior form check Shields down outside of battle, only up while in battle. Also add some comments to relate speciesID<->species Closes #399
2016-11-14 02:25:33 +00:00
case 25: // Pikachu
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (Info.Generation == 6 && pkm.AltForm != 0 ^ Type == typeof(EncounterStatic))
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
string msg = Type == typeof(EncounterStatic) ? V305 : V306;
Minor refactoring Memories are only set by generation 6 games (bank i/o is a single memory). Only check for gen6 situations. Generation=2 and Format=1 is not possible, as for 1/2 it's dependent on format. Would need to detect encounters for gen2 games to determine what game it originated from. Tabs->Spaces
2017-02-21 03:40:50 +00:00
AddLine(Severity.Invalid, msg, CheckIdentifier.Form);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (Info.Generation == 7 && pkm.AltForm != 0 ^ Type == typeof(MysteryGift))
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
More c#7 shorthand outs & pattern matching, other simplifications
2017-05-13 17:20:25 +00:00
if (EncounterMatch is WC7 gift && gift.Form != pkm.AltForm)
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
{
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V307, CheckIdentifier.Form);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
}
Cosplay pikachu fixes Form can be changed only for the received cosplay Pikachu. Can be obtained in any location. Regular Pikachu cannot be given a cosplay-only form Cosplay Pikachu cannot have a non-cosplay form.
2016-04-23 21:16:12 +00:00
break;
Add unown gen2 invalid form check closes #1565
2017-11-07 01:13:16 +00:00
case 201 when Info.Generation == 2 && pkm.AltForm >= 26:
AddLine(Severity.Invalid, string.Format(V304, "Z", pkm.AltForm == 26 ? "!" : "?"), CheckIdentifier.Form);
break;
Fix for Giratina's Origin form only with specific held item
2017-01-31 22:01:32 +00:00
case 487: // Giratina
Simplify giratina check No need to check both cases when we're really just checking for a mismatch
2017-02-03 03:30:17 +00:00
if (pkm.AltForm == 1 ^ pkm.HeldItem == 112) // Origin form only with Griseous Orb
Fix for Giratina's Origin form only with specific held item
2017-01-31 22:01:32 +00:00
{
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V308, CheckIdentifier.Form);
Fix for Giratina's Origin form only with specific held item
2017-01-31 22:01:32 +00:00
return;
}
break;
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
case 493: // Arceus
{
int item = pkm.HeldItem;
int form = 0;
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
if (298 <= item && item <= 313 || item == 644)
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
form = Array.IndexOf(Legal.Arceus_Plate, item) + 1;
else if (777 <= item && item <= 793)
form = Array.IndexOf(Legal.Arceus_ZCrystal, item) + 1;
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
if (form != pkm.AltForm)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V308, CheckIdentifier.Form);
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
else if (form != 0)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Valid, V309, CheckIdentifier.Form);
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
}
Add Genesect item/form check Closes #850
2017-02-13 01:06:09 +00:00
break;
Refactor move legality checking With the refactoring of result strings outside of Checks.cs, the logic became harder to follow as the result strings functioned as comments. This commit splits up the large move checking methods into smaller parts and added comments. Moved keldeo move check to a form check and simplifies the check to only search once.
2017-03-23 06:34:35 +00:00
case 647: // Keldeo
{
Ignore secret sword mismatch in gen5 Closes #1361
2017-07-26 03:39:54 +00:00
if (pkm.Format == 5) // can mismatch in gen5 via BW tutor
break;
Refactor move legality checking With the refactoring of result strings outside of Checks.cs, the logic became harder to follow as the result strings functioned as comments. This commit splits up the large move checking methods into smaller parts and added comments. Moved keldeo move check to a form check and simplifies the check to only search once.
2017-03-23 06:34:35 +00:00
int index = Array.IndexOf(pkm.Moves, 548); // Secret Sword
bool noSword = index < 0;
if (pkm.AltForm == 0 ^ noSword) // mismatch
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
Info.Moves[noSword ? 0 : index] = new CheckMoveResult(Info.Moves[noSword ? 0 : index], Severity.Invalid, V169, CheckIdentifier.Move);
Refactor move legality checking With the refactoring of result strings outside of Checks.cs, the logic became harder to follow as the result strings functioned as comments. This commit splits up the large move checking methods into smaller parts and added comments. Moved keldeo move check to a form check and simplifies the check to only search once.
2017-03-23 06:34:35 +00:00
break;
}
Add Genesect item/form check Closes #850
2017-02-13 01:06:09 +00:00
case 649: // Genesect
{
int item = pkm.HeldItem;
int form = 0;
if (116 <= item && item <= 119)
form = item - 115;
if (form != pkm.AltForm)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V308, CheckIdentifier.Form);
Add Genesect item/form check Closes #850
2017-02-13 01:06:09 +00:00
else
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Valid, V309, CheckIdentifier.Form);
Add Genesect item/form check Closes #850
2017-02-13 01:06:09 +00:00
}
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
break;
Invert minior form check Shields down outside of battle, only up while in battle. Also add some comments to relate speciesID<->species Closes #399
2016-11-14 02:25:33 +00:00
case 658: // Greninja
Refactoring Add placeholder met location list for hatched eggs Moved generation nonspecific tables to the master Tables.
2016-11-09 05:43:22 +00:00
if (pkm.AltForm > 1) // Ash Battle Bond active
{
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V310, CheckIdentifier.Form);
Block bred Ash Greninja Closes #1329
2017-07-14 04:12:16 +00:00
return;
}
Simplify greninja gift check form is already checked in the encounter generator, so the only case where it has not been thoroughly checked is if it is not a mystery gift. it will always be the default form (in that case).
2017-08-30 15:14:42 +00:00
if (pkm.AltForm != 0 && Type != typeof(MysteryGift)) // Formes are not breedable, MysteryGift already checked
Block bred Ash Greninja Closes #1329
2017-07-14 04:12:16 +00:00
{
AddLine(Severity.Invalid, string.Format(V304, 0, pkm.AltForm), CheckIdentifier.Form);
Refactoring Add placeholder met location list for hatched eggs Moved generation nonspecific tables to the master Tables.
2016-11-09 05:43:22 +00:00
return;
}
break;
Invert minior form check Shields down outside of battle, only up while in battle. Also add some comments to relate speciesID<->species Closes #399
2016-11-14 02:25:33 +00:00
case 664: // Scatterbug
case 665: // Spewpa
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.AltForm > 17) // Fancy & Pokéball
{
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V311, CheckIdentifier.Form);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
if (!Legal.CheckVivillonPattern(pkm.AltForm, pkm.Country, pkm.Region))
AddLine(Severity.Fishy, V312, CheckIdentifier.Form);
Add Form checks
2016-04-14 10:17:03 +00:00
break;
Invert minior form check Shields down outside of battle, only up while in battle. Also add some comments to relate speciesID<->species Closes #399
2016-11-14 02:25:33 +00:00
case 666: // Vivillon
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.AltForm > 17) // Fancy & Pokéball
{
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
if (Type != typeof(MysteryGift))
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V312, CheckIdentifier.Form);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Valid, V313, CheckIdentifier.Form);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Merge branch 'kwsch' # Conflicts: # PKHeX/Legality/Checks.cs # PKHeX/PKM/PKM.cs
2017-03-25 17:24:56 +00:00
if (!Legal.CheckVivillonPattern(pkm.AltForm, pkm.Country, pkm.Region))
AddLine(Severity.Fishy, V312, CheckIdentifier.Form);
Add Form checks
2016-04-14 10:17:03 +00:00
break;
Invert minior form check Shields down outside of battle, only up while in battle. Also add some comments to relate speciesID<->species Closes #399
2016-11-14 02:25:33 +00:00
case 670: // Floette
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.AltForm == 5) // Eternal Flower -- Never Released
{
Store base type and matched type parent class via Type, actual class via MatchedType. It's better to have a general solution for future additions/separations (like EncounterStaticShadow) or EncounterTradePID add more encounter type recognition override gen4 transferred encounter detection to prefer EncounterTrades skip encountertype check if encounter is not valid Closes #1091 Closes #1092
2017-04-24 00:53:22 +00:00
if (Type != typeof(MysteryGift))
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V314, CheckIdentifier.Form);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
else
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Valid, V315, CheckIdentifier.Form);
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
return;
}
Add Form checks
2016-04-14 10:17:03 +00:00
break;
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
case 773: // Silvally
{
int item = pkm.HeldItem;
int form = 0;
if ((904 <= item && item <= 920) || item == 644)
form = item - 903;
if (form != pkm.AltForm)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V308, CheckIdentifier.Form);
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
else if (form != 0)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Valid, V309, CheckIdentifier.Form);
Add Arceus/Silvally checks #793 Closes #792 pls no more item checks
2017-02-01 04:11:11 +00:00
break;
}
Add party-only form legality checks Closes #806
2017-02-03 03:27:48 +00:00
Add dusk form rockruff check Repurposes "alolan only form" to specify that the form cannot be obtained with the current game of origin. Closes #1611 sorry for butchering any translation
2017-11-16 00:28:47 +00:00
case 744 when Info.EncounterMatch.EggEncounter && pkm.AltForm == 1 && pkm.SM:
case 745 when Info.EncounterMatch.EggEncounter && pkm.AltForm == 2 && pkm.SM:
AddLine(Severity.Invalid, V317, CheckIdentifier.Form);
return;
Add party-only form legality checks Closes #806
2017-02-03 03:27:48 +00:00
// Party Only Forms
case 492: // Shaymin
case 676: // Furfrou
case 720: // Hoopa
Fix party only battle form legality check Only set box value if in box Only check party-only if <= gen6 Closes #1060 , thanks @White-Canary !
2017-04-15 00:49:13 +00:00
if (pkm.AltForm != 0 && pkm.Box > -1 && pkm.Format <= 6) // has form but stored in box
Simplify giratina check No need to check both cases when we're really just checking for a mismatch
2017-02-03 03:30:17 +00:00
{
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V316, CheckIdentifier.Form);
Simplify giratina check No need to check both cases when we're really just checking for a mismatch
2017-02-03 03:30:17 +00:00
return;
}
Add party-only form legality checks Closes #806
2017-02-03 03:27:48 +00:00
break;
Group forms with special battle formes check
2017-11-09 00:27:35 +00:00
// Battle only Forms with other legal forms allowed
case 718 when pkm.AltForm >= 4: // Zygarde Complete
case 774 when pkm.AltForm < 7: // Minior Shield
case 800 when pkm.AltForm == 3: // Ultra Necrozma
AddLine(Severity.Invalid, V310, CheckIdentifier.Form);
return;
permit necrozma formes 1&2 and 0. was eventually reaching the Battle Megas list so insert this abort-early detection.
2017-11-10 17:22:41 +00:00
case 800 when pkm.AltForm < 3: // Necrozma Fused forms & default
Permit totem mimikyu forme (not battle forme)
2017-11-10 03:26:47 +00:00
case 778 when pkm.AltForm == 2: // Totem disguise Mimikyu
AddLine(Severity.Valid, V315, CheckIdentifier.Form);
return;
Add Form checks
2016-04-14 10:17:03 +00:00
}
Add alolan exclusive form check Marowak and Exeggutor are exempt due to their pre-evolutions not having a form and past gen pkm evolving into the alolan variant.
2016-11-14 02:19:09 +00:00
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
if (pkm.Format >= 7 && Info.Generation < 7 && pkm.AltForm != 0)
Add evolve-to-form check Espurr->Meowstic1 Pikachu->Raichu1 etc
2017-02-02 05:59:39 +00:00
{
if (pkm.Species == 25 || Legal.AlolanOriginForms.Contains(pkm.Species))
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
{ AddLine(Severity.Invalid, V317, CheckIdentifier.Form); return; }
Add evolve-to-form check Espurr->Meowstic1 Pikachu->Raichu1 etc
2017-02-02 05:59:39 +00:00
}
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.AltForm > 0 && new[] {Legal.BattleForms, Legal.BattleMegas, Legal.BattlePrimals}.Any(arr => arr.Contains(pkm.Species)))
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
{ AddLine(Severity.Invalid, V310, CheckIdentifier.Form); return; }
Add Form checks
2016-04-14 10:17:03 +00:00
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Valid, V318, CheckIdentifier.Form);
Add Form checks
2016-04-14 10:17:03 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyMiscG1()
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
{
More egg related check changes Properly check for actual held item move unhittable check (verifyMisc isnt called when parsing pk1/pk2; verifyMiscG1 is) add egg PP check, add common method to be shared between gen1 checks and GBA+ #1257
2017-06-21 16:18:33 +00:00
if (pkm.IsEgg)
{
VerifyMiscEggCommon();
if (pkm.PKRS_Cured || pkm.PKRS_Infected)
AddLine(Severity.Invalid, V368, CheckIdentifier.Egg);
}
Remove old (GF fixed) shiny correlation Transporter was updated
2017-09-06 16:12:56 +00:00
Add VC1 tradeback shiny check tradeback implies it was transferred to GS for a bit, thus had to be transported with the new transporter
2017-09-07 03:02:41 +00:00
if (pkm.Format > 2)
{
// Female Shinies for a 12.5%-F species are not possible with the 'correct' correlation
// Original Transporter code generated a random nature (VC1 only), so we can ignore in this case
bool checkShiny = pkm.VC2 || pkm.TradebackStatus == TradebackType.WasTradeback && pkm.VC1;
if (checkShiny && pkm.Gender == 1 && pkm.PersonalInfo.Gender == 31 && pkm.IsShiny)
AddLine(Severity.Invalid, V209, CheckIdentifier.PID);
}
Remove old (GF fixed) shiny correlation Transporter was updated
2017-09-06 16:12:56 +00:00
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
if (!(pkm is PK1 pk1))
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
return;
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
VerifyMiscG1Types(pk1);
VerifyMiscG1CatchRate(pk1);
}
private void VerifyMiscG1Types(PK1 pk1)
{
var Type_A = pk1.Type_A;
var Type_B = pk1.Type_B;
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
if (pkm.Species == 137)
{
// Porygon can have any type combination of any generation 1 species because of the move Conversion,
// that change Porygon type to match the oponent types
var Type_A_Match = Legal.Types_Gen1.Any(t => t == Type_A);
var Type_B_Match = Legal.Types_Gen1.Any(t => t == Type_B);
if (!Type_A_Match)
AddLine(Severity.Invalid, V386, CheckIdentifier.Misc);
if (!Type_B_Match)
AddLine(Severity.Invalid, V387, CheckIdentifier.Misc);
if (Type_A_Match && Type_B_Match)
{
var TypesAB_Match = PersonalTable.RB.IsValidTypeCombination(Type_A, Type_B);
if (TypesAB_Match)
AddLine(Severity.Valid, V391, CheckIdentifier.Misc);
else
AddLine(Severity.Invalid, V388, CheckIdentifier.Misc);
}
}
else // Types must match species types
{
var Type_A_Match = Type_A == PersonalTable.RB[pkm.Species].Types[0];
var Type_B_Match = Type_B == PersonalTable.RB[pkm.Species].Types[1];
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
AddLine(Type_A_Match ? Severity.Valid : Severity.Invalid, Type_A_Match ? V392 : V389, CheckIdentifier.Misc);
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
AddLine(Type_B_Match ? Severity.Valid : Severity.Invalid, Type_B_Match ? V393 : V390, CheckIdentifier.Misc);
}
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
}
private void VerifyMiscG1CatchRate(PK1 pk1)
{
var catch_rate = pk1.Catch_Rate;
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
switch (pkm.TradebackStatus)
{
case TradebackType.Any:
case TradebackType.WasTradeback:
if (catch_rate == 0 || Legal.HeldItems_GSC.Any(h => h == catch_rate))
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
AddLine(Severity.Valid, V394, CheckIdentifier.Misc);
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
else if (pkm.TradebackStatus == TradebackType.WasTradeback)
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
AddLine(Severity.Invalid, V395, CheckIdentifier.Misc);
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
else
goto case TradebackType.Gen1_NotTradeback;
break;
case TradebackType.Gen1_NotTradeback:
slight tweaks reduce nesting, formatting; no functional change
2017-05-01 15:25:20 +00:00
if ((EncounterMatch as EncounterStatic)?.Version == GameVersion.Stadium || EncounterMatch is EncounterTradeCatchRate)
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
// Encounters detected by the catch rate, cant be invalid if match this encounters
AddLine(Severity.Valid, V398, CheckIdentifier.Misc);
if (pkm.Species == 149 && catch_rate == PersonalTable.Y[149].CatchRate || Legal.Species_NotAvailable_CatchRate.Contains(pkm.Species) && catch_rate == PersonalTable.RB[pkm.Species].CatchRate)
AddLine(Severity.Invalid, V396, CheckIdentifier.Misc);
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
else if (!Info.EvoChainsAllGens[1].Any(e => catch_rate == PersonalTable.RB[e.Species].CatchRate || catch_rate == PersonalTable.Y[e.Species].CatchRate))
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
AddLine(Severity.Invalid, pkm.Gen1_NotTradeback ? V397 : V399, CheckIdentifier.Misc);
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
else
Refactoring Split some large methods into smaller pieces
2017-09-05 01:55:15 +00:00
AddLine(Severity.Valid, V398, CheckIdentifier.Misc);
Generation 1 and 2 legal Improvements (#1099) * Refactor parseMovesForEncounter to gather valid moves for species encounter, some Pokemon can have valid encounters with different source species from the encounter, the valid moves change if the encounter species change because some preevolutions moves are illegal if pokemon caught already evolved. Example, generation 1 Pikachu that can have a RBY Pikachu encounter and GSC Pichu encounter, the valid moves for the first encounters should not have any Pichu exclusive evolution moves Also assign the encounter match from gb when parsing moves like the variable Encounter Match, to store the encounter that is valid for the pokemon moves instead the first encounter. Store the species encounter, this will be needed to check if the evolution is valid for species that evolve leveling with a given learned move * Add Tradeback Status to the pokemon, this variable for generations 1 and 2 use data like the catch rate to determine if trade between generations 1 and 2 was possible. If analysis is for VC games tradeback have value NotTradeback for every gen 1 pokemon, but for cart saves some pokemon can be determine that have not been tradeback, if catch rate match species catch rate but do not match a valid generation 2 held item that means the pokemon habe been never traded to generation 2 games, that allow to discart encounters and moves from generation 2. Also if is not tradeback catch rate is used to filter encounters, catch rate determine in what species was captured the pokemon discarting some preevolutions moves Also add option for generation 1 cart save analysis to check legal status not allowing generation 2 games, like VC games but with Stadium allowed, like the generation 1 non tradeback rules from Smogon Also change evolution chains to included generation 2 preevolutions for gen 1 pokemon if tradeback was possible, it is needed to avoid parsemoves to check illegal pokemon like Hitmonchan with Tyrogue level up moves * Check legal values of generation 1 type and catch rate Replace pokemon catch rate after changind pokemon species always if pokemon was not tradeback from generation 2, the catch rate will keep unchanged only if it can be a held item and do not match species catch rate (default item) Also if catch rate is changed use base species catch rate to avoid legal errors if the catch rate of the evolution species if is not possible with the current moves * Filter ingame trades and static encounters with catch rate for generation 1 non tradeback * Fix min moves for generation 1 metapod encounter * Clean up * Fix encounter level for generation 1, valid moves are those with one level after the encounter level, pokemon can not learn a new move until level up Clean up type validation Fix generation 3 fatefull encounter eggs, the pokemon lost the fatefull mark when it hatch * Clean-up * Use new variable EncounterSpecies when it is needed to detect the species of the encounter, the old code wont work if the encounter is a wild slots array * Fix generation 1 evolution chains and catch rate as default held item * Fix Generation 1 Yellow Pikachu and Kadabra catch rates
2017-04-27 04:27:59 +00:00
break;
}
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyMisc()
Add Fateful Encounter check Cleared up the Event check a little to allow Fateful Encounters to slip through.
2016-04-22 02:32:22 +00:00
{
Byte 0x2A in PK7 is PelagoEventStatus See pml::pokepara::CoreParam::GetResortEventStatus Also see: #741. Needs testing to see what values are legal.
2017-01-26 19:16:21 +00:00
if (pkm.Format == 7 && ((PK7)pkm).PelagoEventStatus != 0)
{
// TODO: Figure out what PelagoEventStati are legal.
}
Add incorrect transfer check Flags pk6->pk7 imports that were not converted (no data changes)
2017-01-25 07:34:50 +00:00
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.IsEgg)
Add Egg & Super Training legality checks Closes #220 Thanks @sora10pls !
2016-09-03 15:10:22 +00:00
{
More egg related check changes Properly check for actual held item move unhittable check (verifyMisc isnt called when parsing pk1/pk2; verifyMiscG1 is) add egg PP check, add common method to be shared between gen1 checks and GBA+ #1257
2017-06-21 16:18:33 +00:00
VerifyMiscEggCommon();
Refactor Legality engine Beginnings of multi-generational support; removed all references to PK6 (child) and changed to PKM (abstract parent). The core portion still needs revision to not be hard-coded for XY/ORAS info tables.
2016-10-23 19:48:49 +00:00
if (pkm.CNTs.Any(stat => stat > 0))
Update gen3 fateful encounter checks Closes #1230 Colosseum pokemon do not get fateful encounter, all pkm from XD (except the starters) are fateful. Add requirement for National ribbon if shadow CK3 is transferred to XK3 and vice versa; actually check for national ribbon during CK3/XK3 (RibbonSet1 interface)
2017-06-15 04:07:42 +00:00
AddLine(Severity.Invalid, V320, CheckIdentifier.Egg);
Add shinyleaf/pokeathlon stat legality check #1236
2017-06-18 05:16:24 +00:00
if (pkm is PK4 pk4)
{
if (pk4.ShinyLeaf != 0)
AddLine(Severity.Invalid, V414, CheckIdentifier.Egg);
if (pk4.PokéathlonStat != 0)
AddLine(Severity.Invalid, V415, CheckIdentifier.Egg);
}
Add Egg & Super Training legality checks Closes #220 Thanks @sora10pls !
2016-09-03 15:10:22 +00:00
}
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
if (!Encounter.Valid)
return;
Flag invalid nsparkle previously would only flag if it was missing on npokemon also fix gen5 traded egg locations move egg ribbon verification to the new class
2017-09-06 03:32:07 +00:00
if (Info.Generation == 5)
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyNsPKM();
Add PGF forced shiny check Moved ability forcing to be above shininess forcing as ability bits shouldn't be set back after a PID has been forced.
2017-06-04 01:40:44 +00:00
Add gen3 fateful bypass no flagging that it's missing (via ingame clearing), implying that it was traded to RS to hatch. Thanks @kamronbatman ! Closes #1469
2017-09-20 02:18:13 +00:00
VerifyMiscFatefulEncounter();
}
private void VerifyMiscFatefulEncounter()
{
Update gen3 fateful encounter checks Closes #1230 Colosseum pokemon do not get fateful encounter, all pkm from XD (except the starters) are fateful. Add requirement for National ribbon if shadow CK3 is transferred to XK3 and vice versa; actually check for national ribbon during CK3/XK3 (RibbonSet1 interface)
2017-06-15 04:07:42 +00:00
switch (EncounterMatch)
{
Add c/xd ingame trades as wc3 as it's the closest structure without creating a new encountertrade subtype
2017-06-15 04:57:23 +00:00
case WC3 w when w.Fateful:
Add gen3 fateful bypass no flagging that it's missing (via ingame clearing), implying that it was traded to RS to hatch. Thanks @kamronbatman ! Closes #1469
2017-09-20 02:18:13 +00:00
if (w.IsEgg)
{
// Eggs hatched in RS clear the obedience flag!
if (pkm.Format != 3)
return; // possible hatched in either game, don't bother checking
if (pkm.Met_Location <= 087) // hatched in RS
break; // ensure fateful is not active
// else, ensure fateful is active (via below)
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyFatefulIngameActive();
Update fateful/shiny lock check gen3 wc3 VerifyFatefulMysteryGift wasn't hitting for WC3's (g.Format == 3); simplify that branch and reintroduce the shiny check as a separate method Thanks Davil!
2017-10-19 01:18:23 +00:00
VerifyWC3Shiny(w);
Add c/xd ingame trades as wc3 as it's the closest structure without creating a new encountertrade subtype
2017-06-15 04:57:23 +00:00
return;
Update fateful/shiny lock check gen3 wc3 VerifyFatefulMysteryGift wasn't hitting for WC3's (g.Format == 3); simplify that branch and reintroduce the shiny check as a separate method Thanks Davil!
2017-10-19 01:18:23 +00:00
case WC3 w:
VerifyWC3Shiny(w);
break;
Update gen3 fateful checks met location FE doesn't propagate to future games, only obedience flag
2017-06-17 04:45:03 +00:00
case MysteryGift g when g.Format != 3: // WC3
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyFatefulMysteryGift(g);
Update gen3 fateful encounter checks Closes #1230 Colosseum pokemon do not get fateful encounter, all pkm from XD (except the starters) are fateful. Add requirement for National ribbon if shadow CK3 is transferred to XK3 and vice versa; actually check for national ribbon during CK3/XK3 (RibbonSet1 interface)
2017-06-15 04:07:42 +00:00
return;
case EncounterStatic s when s.Fateful: // ingame fateful
case EncounterSlot _ when pkm.Version == 15: // ingame pokespot
Add ranch ingame trades debut of the long awaited EncounterTradePID class gist to generate trades from folder (using LINQPad): https://gist.github.com/kwsch/d778f1f63e4c393e5440dfb0e14cfcc3 Closes #1458 , although Mew/Phione's PIDIV method is unknown.
2017-09-21 04:28:29 +00:00
case EncounterTrade t when t.Fateful:
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
VerifyFatefulIngameActive();
Update gen3 fateful encounter checks Closes #1230 Colosseum pokemon do not get fateful encounter, all pkm from XD (except the starters) are fateful. Add requirement for National ribbon if shadow CK3 is transferred to XK3 and vice versa; actually check for national ribbon during CK3/XK3 (RibbonSet1 interface)
2017-06-15 04:07:42 +00:00
return;
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
}
Add gen3 fateful bypass no flagging that it's missing (via ingame clearing), implying that it was traded to RS to hatch. Thanks @kamronbatman ! Closes #1469
2017-09-20 02:18:13 +00:00
if (pkm.FatefulEncounter)
AddLine(Severity.Invalid, V325, CheckIdentifier.Fateful);
Update gen3 fateful encounter checks Closes #1230 Colosseum pokemon do not get fateful encounter, all pkm from XD (except the starters) are fateful. Add requirement for National ribbon if shadow CK3 is transferred to XK3 and vice versa; actually check for national ribbon during CK3/XK3 (RibbonSet1 interface)
2017-06-15 04:07:42 +00:00
}
More egg related check changes Properly check for actual held item move unhittable check (verifyMisc isnt called when parsing pk1/pk2; verifyMiscG1 is) add egg PP check, add common method to be shared between gen1 checks and GBA+ #1257
2017-06-21 16:18:33 +00:00
private void VerifyMiscEggCommon()
{
if (new[] {pkm.Move1_PPUps, pkm.Move2_PPUps, pkm.Move3_PPUps, pkm.Move4_PPUps}.Any(ppup => ppup > 0))
AddLine(Severity.Invalid, V319, CheckIdentifier.Egg);
if (pkm.Move1_PP != pkm.GetMovePP(pkm.Move1, 0) || pkm.Move2_PP != pkm.GetMovePP(pkm.Move2, 0)
|| pkm.Move3_PP != pkm.GetMovePP(pkm.Move3, 0) || pkm.Move4_PP != pkm.GetMovePP(pkm.Move4, 0))
AddLine(Severity.Invalid, V420, CheckIdentifier.Egg);
var HatchCycles = (EncounterMatch as EncounterStatic)?.EggCycles;
if (HatchCycles == 0 || HatchCycles == null)
HatchCycles = pkm.PersonalInfo.HatchCycles;
if (pkm.CurrentFriendship > HatchCycles)
AddLine(Severity.Invalid, V374, CheckIdentifier.Egg);
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyFatefulMysteryGift(MysteryGift g)
Update gen3 fateful encounter checks Closes #1230 Colosseum pokemon do not get fateful encounter, all pkm from XD (except the starters) are fateful. Add requirement for National ribbon if shadow CK3 is transferred to XK3 and vice versa; actually check for national ribbon during CK3/XK3 (RibbonSet1 interface)
2017-06-15 04:07:42 +00:00
{
if (g is PGF p && p.IsShiny)
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
{
Misc updates fields->properties, capitalize fix pkm fields toggle referencing old pkm file, simplify that process instead of constantly referencing Format
2017-06-21 00:57:23 +00:00
Info.PIDIV = MethodFinder.Analyze(pkm);
if (Info.PIDIV.Type != PIDType.G5MGShiny)
Update gen3 fateful encounter checks Closes #1230 Colosseum pokemon do not get fateful encounter, all pkm from XD (except the starters) are fateful. Add requirement for National ribbon if shadow CK3 is transferred to XK3 and vice versa; actually check for national ribbon during CK3/XK3 (RibbonSet1 interface)
2017-06-15 04:07:42 +00:00
AddLine(Severity.Invalid, V411, CheckIdentifier.PID);
}
Misc cleanup Add PCD fixed PID check improve PID matching for CXD pkm hide no-pidiv match seed (00000000) fix matching fateful for wild pokespot pkm don't generate eggs for c/xd
2017-06-03 22:16:24 +00:00
Update fateful/shiny lock check gen3 wc3 VerifyFatefulMysteryGift wasn't hitting for WC3's (g.Format == 3); simplify that branch and reintroduce the shiny check as a separate method Thanks Davil!
2017-10-19 01:18:23 +00:00
if (pkm.FatefulEncounter)
Update gen3 fateful encounter checks Closes #1230 Colosseum pokemon do not get fateful encounter, all pkm from XD (except the starters) are fateful. Add requirement for National ribbon if shadow CK3 is transferred to XK3 and vice versa; actually check for national ribbon during CK3/XK3 (RibbonSet1 interface)
2017-06-15 04:07:42 +00:00
AddLine(Severity.Valid, V321, CheckIdentifier.Fateful);
else
AddLine(Severity.Invalid, V322, CheckIdentifier.Fateful);
}
Update fateful/shiny lock check gen3 wc3 VerifyFatefulMysteryGift wasn't hitting for WC3's (g.Format == 3); simplify that branch and reintroduce the shiny check as a separate method Thanks Davil!
2017-10-19 01:18:23 +00:00
private void VerifyWC3Shiny(WC3 g3)
{
// check for shiny locked gifts
if (g3.Shiny != null && g3.Shiny != pkm.IsShiny)
AddLine(Severity.Invalid, V409, CheckIdentifier.Fateful);
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyFatefulIngameActive()
Update gen3 fateful encounter checks Closes #1230 Colosseum pokemon do not get fateful encounter, all pkm from XD (except the starters) are fateful. Add requirement for National ribbon if shadow CK3 is transferred to XK3 and vice versa; actually check for national ribbon during CK3/XK3 (RibbonSet1 interface)
2017-06-15 04:07:42 +00:00
{
Add xk3 fateful check Closes #1410
2017-08-21 15:59:26 +00:00
if (pkm.Version == 15 && pkm is XK3 xk3 && Info.WasXD)
{
// can't have fateful until traded away, which clears ShadowID
if (xk3.FatefulEncounter && xk3.ShadowID != 0)
AddLine(Severity.Invalid, V325, CheckIdentifier.Fateful);
Set fateful for xd pkm transferred away Only way to know if it originated in XD is to check the matched encounter data Closes #1290
2017-07-04 20:24:12 +00:00
return; // fateful is set when transferred away
Add xk3 fateful check Closes #1410
2017-08-21 15:59:26 +00:00
}
Set fateful for xd pkm transferred away Only way to know if it originated in XD is to check the matched encounter data Closes #1290
2017-07-04 20:24:12 +00:00
Update gen3 fateful encounter checks Closes #1230 Colosseum pokemon do not get fateful encounter, all pkm from XD (except the starters) are fateful. Add requirement for National ribbon if shadow CK3 is transferred to XK3 and vice versa; actually check for national ribbon during CK3/XK3 (RibbonSet1 interface)
2017-06-15 04:07:42 +00:00
if (pkm.FatefulEncounter)
AddLine(Severity.Valid, V323, CheckIdentifier.Fateful);
else
AddLine(Severity.Invalid, V324, CheckIdentifier.Fateful);
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyNsPKM()
Update gen3 fateful encounter checks Closes #1230 Colosseum pokemon do not get fateful encounter, all pkm from XD (except the starters) are fateful. Add requirement for National ribbon if shadow CK3 is transferred to XK3 and vice versa; actually check for national ribbon during CK3/XK3 (RibbonSet1 interface)
2017-06-15 04:07:42 +00:00
{
Flag invalid nsparkle previously would only flag if it was missing on npokemon also fix gen5 traded egg locations move egg ribbon verification to the new class
2017-09-06 03:32:07 +00:00
bool req = EncounterMatch is EncounterStatic s && s.NSparkle;
Update gen3 fateful encounter checks Closes #1230 Colosseum pokemon do not get fateful encounter, all pkm from XD (except the starters) are fateful. Add requirement for National ribbon if shadow CK3 is transferred to XK3 and vice versa; actually check for national ribbon during CK3/XK3 (RibbonSet1 interface)
2017-06-15 04:07:42 +00:00
if (pkm.Format == 5)
{
bool has = ((PK5)pkm).NPokémon;
if (req && !has)
AddLine(Severity.Invalid, V326, CheckIdentifier.Fateful);
if (!req && has)
AddLine(Severity.Invalid, V327, CheckIdentifier.Fateful);
}
if (req)
{
if (pkm.IVs.Any(iv => iv != 30))
AddLine(Severity.Invalid, V218, CheckIdentifier.IVs);
Misc lc fixes inheritable apricorn balls for baby-tree pkm japanese N ot g5 traded event egg location
2017-08-12 08:30:19 +00:00
if (!VerifyNsPKMOTValid())
Update gen3 fateful encounter checks Closes #1230 Colosseum pokemon do not get fateful encounter, all pkm from XD (except the starters) are fateful. Add requirement for National ribbon if shadow CK3 is transferred to XK3 and vice versa; actually check for national ribbon during CK3/XK3 (RibbonSet1 interface)
2017-06-15 04:07:42 +00:00
AddLine(Severity.Invalid, V219, CheckIdentifier.Trainer);
if (pkm.IsShiny)
AddLine(Severity.Invalid, V220, CheckIdentifier.Shiny);
Add Fateful Encounter check Cleared up the Event check a little to allow Fateful Encounters to slip through.
2016-04-22 02:32:22 +00:00
}
}
Misc lc fixes inheritable apricorn balls for baby-tree pkm japanese N ot g5 traded event egg location
2017-08-12 08:30:19 +00:00
private bool VerifyNsPKMOTValid()
{
if (pkm.TID != 00002 || pkm.SID != 00000)
return false;
Add LanguageID enum no functional change, just less-magic-numbers for easier to understand src
2017-10-23 04:01:08 +00:00
var OT = pkm.Language == (int)LanguageID.Japanese ? "Ｎ" : "N";
More usum prep I think egg hatch location checking is wrong for traded eggs (see gen3 vs future games, origin game shouldn't change but could hatch ORAS egg on XY at XY location?)
2017-09-20 04:35:30 +00:00
return OT == pkm.OT_Name;
Misc lc fixes inheritable apricorn balls for baby-tree pkm japanese N ot g5 traded event egg location
2017-08-12 08:30:19 +00:00
}
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private void VerifyVersionEvolution()
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
{
if (pkm.Format < 7)
return;
// No point using the evolution tree. Just handle certain species.
More usum prep I think egg hatch location checking is wrong for traded eggs (see gen3 vs future games, origin game shouldn't change but could hatch ORAS egg on XY at XY location?)
2017-09-20 04:35:30 +00:00
bool Sun() => pkm.Version == (int)GameVersion.SN || pkm.Version == (int)GameVersion.US;
bool Moon() => pkm.Version == (int)GameVersion.MN || pkm.Version == (int)GameVersion.UM;
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
switch (pkm.Species)
{
case 745: // Lycanroc
if (!pkm.WasEgg)
break;
More usum prep I think egg hatch location checking is wrong for traded eggs (see gen3 vs future games, origin game shouldn't change but could hatch ORAS egg on XY at XY location?)
2017-09-20 04:35:30 +00:00
if (pkm.AltForm == 0 && Moon()
|| pkm.AltForm == 1 && Sun())
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
if (pkm.IsUntraded)
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V328, CheckIdentifier.Evolution);
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
break;
case 791: // Solgaleo
More usum prep I think egg hatch location checking is wrong for traded eggs (see gen3 vs future games, origin game shouldn't change but could hatch ORAS egg on XY at XY location?)
2017-09-20 04:35:30 +00:00
if (Moon() && pkm.IsUntraded)
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
{
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (EncounterMatch is MysteryGift g && g.Species == pkm.Species) // Gifted via Mystery Gift
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
break;
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V328, CheckIdentifier.Evolution);
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
}
break;
case 792: // Lunala
More usum prep I think egg hatch location checking is wrong for traded eggs (see gen3 vs future games, origin game shouldn't change but could hatch ORAS egg on XY at XY location?)
2017-09-20 04:35:30 +00:00
if (Sun() && pkm.IsUntraded)
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
{
Cleanup throw in more c#7 lang sugar to checks flag invalid hatch cycles (over species max || 0); existing wouldn't flag for non-static encounters.
2017-05-28 05:40:21 +00:00
if (EncounterMatch is MysteryGift g && g.Species == pkm.Species) // Gifted via Mystery Gift
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
break;
Refactor remaining strings out
2017-03-23 03:12:45 +00:00
AddLine(Severity.Invalid, V328, CheckIdentifier.Evolution);
Add Version Evolution check Closes #540 indirectly as noted in the comment section.
2016-12-01 03:37:53 +00:00
}
break;
}
}
Refactoring relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)
2017-09-04 02:51:29 +00:00
public static string[] MoveStrings { internal get; set; } = Util.GetMovesList("en");
public static string[] SpeciesStrings { internal get; set; } = Util.GetSpeciesList("en");
internal static IEnumerable<string> getMoveNames(IEnumerable<int> moves) => moves.Select(m => m >= MoveStrings.Length ? V190 : MoveStrings[m]);
Add some basic legality checks Besides moves/encounters, we can check validity of certain traits.
2016-03-11 04:36:32 +00:00
}
}
Reference in a new issue Copy permalink