rust-clippy/clippy_lints/src/utils/mod.rs

1154 lines
34 KiB
Rust
Raw Normal View History

2018-05-30 08:15:50 +00:00
use crate::reexport::*;
use rustc::hir;
use rustc::hir::*;
use rustc::hir::def_id::{DefId, CRATE_DEF_INDEX};
use rustc::hir::def::Def;
use rustc::hir::intravisit::{NestedVisitorMap, Visitor};
use rustc::hir::map::Node;
2017-09-05 09:33:04 +00:00
use rustc::lint::{LateContext, Level, Lint, LintContext};
use rustc::session::Session;
use rustc::traits;
use rustc::ty::{self, Binder, Ty, TyCtxt, layout::{self, IntegerExt}, subst::Kind};
2018-05-01 16:10:25 +00:00
use rustc_errors::{Applicability, CodeSuggestion, Substitution, SubstitutionPart};
use std::borrow::Cow;
use std::env;
use std::mem;
use std::str::FromStr;
use std::rc::Rc;
use syntax::ast::{self, LitKind};
use syntax::attr;
2017-08-19 08:03:29 +00:00
use syntax::codemap::{CompilerDesugaringKind, ExpnFormat, ExpnInfo, Span, DUMMY_SP};
2015-12-31 20:39:03 +00:00
use syntax::errors::DiagnosticBuilder;
use syntax::ptr::P;
use syntax::symbol::keywords;
2016-03-26 05:57:03 +00:00
pub mod comparisons;
2016-03-06 14:17:51 +00:00
pub mod conf;
2016-08-27 23:52:01 +00:00
pub mod constants;
mod hir_utils;
2016-04-14 16:13:15 +00:00
pub mod paths;
pub mod sugg;
pub mod inspector;
pub mod internal_lints;
pub mod author;
2017-10-08 08:51:44 +00:00
pub mod ptr;
pub mod usage;
pub use self::hir_utils::{SpanlessEq, SpanlessHash};
2016-04-14 16:13:15 +00:00
pub type MethodArgs = HirVec<P<Expr>>;
2016-06-29 22:08:43 +00:00
pub mod higher;
2017-08-09 07:30:56 +00:00
/// Returns true if the two spans come from differing expansions (i.e. one is
/// from a macro and one
2016-01-12 22:17:54 +00:00
/// isn't).
pub fn differing_macro_contexts(lhs: Span, rhs: Span) -> bool {
rhs.ctxt() != lhs.ctxt()
}
pub fn in_constant(cx: &LateContext, id: NodeId) -> bool {
let parent_id = cx.tcx.hir.get_parent(id);
2017-11-15 07:38:43 +00:00
match cx.tcx.hir.body_owner_kind(parent_id) {
hir::BodyOwnerKind::Fn => false,
hir::BodyOwnerKind::Const | hir::BodyOwnerKind::Static(..) => true,
}
}
2016-01-12 22:17:54 +00:00
/// Returns true if this `expn_info` was expanded by any macro.
pub fn in_macro(span: Span) -> bool {
span.ctxt().outer().expn_info().map_or(false, |info| {
match info.format {
2017-09-05 09:33:04 +00:00
// don't treat range expressions desugared to structs as "in_macro"
2017-08-19 08:03:29 +00:00
ExpnFormat::CompilerDesugaring(kind) => kind != CompilerDesugaringKind::DotFill,
_ => true,
2016-12-20 17:21:30 +00:00
}
2017-04-06 14:49:13 +00:00
})
2015-06-01 20:30:34 +00:00
}
/// Returns true if `expn_info` was expanded by range expressions.
pub fn is_range_expression(span: Span) -> bool {
span.ctxt().outer().expn_info().map_or(false, |info| {
match info.format {
ExpnFormat::CompilerDesugaring(CompilerDesugaringKind::DotFill) => true,
_ => false,
}
})
}
2017-08-09 07:30:56 +00:00
/// Returns true if the macro that expanded the crate was outside of the
/// current crate or was a
2016-01-12 22:17:54 +00:00
/// compiler plugin.
pub fn in_external_macro<'a, T: LintContext<'a>>(cx: &T, span: Span) -> bool {
2017-08-09 07:30:56 +00:00
/// Invokes `in_macro` with the expansion info of the given span slightly
/// heavy, try to use
2016-03-19 16:48:29 +00:00
/// this after other checks have already happened.
fn in_macro_ext<'a, T: LintContext<'a>>(cx: &T, info: &ExpnInfo) -> bool {
2015-09-17 05:27:18 +00:00
// no ExpnInfo = no macro
if let ExpnFormat::MacroAttribute(..) = info.format {
// these are all plugins
return true;
}
// no span for the callee = external macro
info.def_site.map_or(true, |span| {
// no snippet = external macro or compiler-builtin expansion
2017-09-05 09:33:04 +00:00
cx.sess()
.codemap()
.span_to_snippet(span)
.ok()
.map_or(true, |code| !code.starts_with("macro_rules"))
2015-09-17 05:27:18 +00:00
})
}
2015-09-06 08:53:55 +00:00
2017-09-05 09:33:04 +00:00
span.ctxt()
.outer()
.expn_info()
.map_or(false, |info| in_macro_ext(cx, &info))
}
2016-01-12 22:17:54 +00:00
/// Check if a `DefId`'s path matches the given absolute type path usage.
///
/// # Examples
2016-12-21 09:00:13 +00:00
/// ```rust,ignore
2017-01-13 16:04:56 +00:00
/// match_def_path(cx.tcx, id, &["core", "option", "Option"])
2016-01-12 22:17:54 +00:00
/// ```
///
/// See also the `paths` module.
pub fn match_def_path(tcx: TyCtxt, def_id: DefId, path: &[&str]) -> bool {
use syntax::symbol;
struct AbsolutePathBuffer {
names: Vec<symbol::LocalInternedString>,
}
impl ty::item_path::ItemPathBuffer for AbsolutePathBuffer {
fn root_mode(&self) -> &ty::item_path::RootMode {
const ABSOLUTE: &ty::item_path::RootMode = &ty::item_path::RootMode::Absolute;
ABSOLUTE
}
fn push(&mut self, text: &str) {
self.names.push(symbol::Symbol::intern(text).as_str());
}
}
2016-02-22 19:00:51 +00:00
let mut apb = AbsolutePathBuffer { names: vec![] };
2017-01-13 16:04:56 +00:00
tcx.push_item_path(&mut apb, def_id);
2017-11-04 19:55:56 +00:00
apb.names.len() == path.len()
&& apb.names
2017-09-05 09:33:04 +00:00
.into_iter()
.zip(path.iter())
.all(|(a, &b)| *a == *b)
}
/// Check if type is struct, enum or union type with given def path.
pub fn match_type(cx: &LateContext, ty: Ty, path: &[&str]) -> bool {
match ty.sty {
2017-01-13 16:04:56 +00:00
ty::TyAdt(adt, _) => match_def_path(cx.tcx, adt.did, path),
2016-01-04 04:26:12 +00:00
_ => false,
}
}
/// Check if the method call given in `expr` belongs to given type.
2015-10-17 18:16:54 +00:00
pub fn match_impl_method(cx: &LateContext, expr: &Expr, path: &[&str]) -> bool {
2017-08-15 09:10:49 +00:00
let method_call = cx.tables.type_dependent_defs()[expr.hir_id];
let trt_id = cx.tcx.impl_of_method(method_call.def_id());
2015-10-17 18:16:54 +00:00
if let Some(trt_id) = trt_id {
2017-01-13 16:04:56 +00:00
match_def_path(cx.tcx, trt_id, path)
2015-10-17 18:16:54 +00:00
} else {
false
}
}
2016-01-12 22:17:54 +00:00
/// Check if the method call given in `expr` belongs to given trait.
pub fn match_trait_method(cx: &LateContext, expr: &Expr, path: &[&str]) -> bool {
2017-08-15 09:10:49 +00:00
let method_call = cx.tables.type_dependent_defs()[expr.hir_id];
let trt_id = cx.tcx.trait_of_item(method_call.def_id());
if let Some(trt_id) = trt_id {
2017-01-13 16:04:56 +00:00
match_def_path(cx.tcx, trt_id, path)
} else {
false
}
}
/// Check if an expression references a variable of the given name.
pub fn match_var(expr: &Expr, var: Name) -> bool {
if let ExprPath(QPath::Resolved(None, ref path)) = expr.node {
2018-06-28 13:46:58 +00:00
if path.segments.len() == 1 && path.segments[0].ident.name == var {
return true;
}
}
false
}
2016-12-02 16:38:31 +00:00
pub fn last_path_segment(path: &QPath) -> &PathSegment {
match *path {
2017-09-05 09:33:04 +00:00
QPath::Resolved(_, ref path) => path.segments
.last()
.expect("A path must have at least one segment"),
2016-12-02 21:33:16 +00:00
QPath::TypeRelative(_, ref seg) => seg,
2016-12-02 16:38:31 +00:00
}
}
pub fn single_segment_path(path: &QPath) -> Option<&PathSegment> {
match *path {
QPath::Resolved(_, ref path) if path.segments.len() == 1 => Some(&path.segments[0]),
QPath::Resolved(..) => None,
2016-12-02 21:33:16 +00:00
QPath::TypeRelative(_, ref seg) => Some(seg),
2016-12-02 16:38:31 +00:00
}
}
2016-01-12 22:17:54 +00:00
/// Match a `Path` against a slice of segment string literals.
///
/// # Examples
2016-12-21 09:00:13 +00:00
/// ```rust,ignore
/// match_qpath(path, &["std", "rt", "begin_unwind"])
2016-01-12 22:17:54 +00:00
/// ```
pub fn match_qpath(path: &QPath, segments: &[&str]) -> bool {
2016-12-02 16:38:31 +00:00
match *path {
QPath::Resolved(_, ref path) => match_path(path, segments),
2017-09-05 09:33:04 +00:00
QPath::TypeRelative(ref ty, ref segment) => match ty.node {
TyPath(ref inner_path) => {
2017-11-04 19:55:56 +00:00
!segments.is_empty() && match_qpath(inner_path, &segments[..(segments.len() - 1)])
2018-06-28 13:46:58 +00:00
&& segment.ident.name == segments[segments.len() - 1]
2017-09-05 09:33:04 +00:00
},
_ => false,
2016-12-02 16:38:31 +00:00
},
}
}
pub fn match_path(path: &Path, segments: &[&str]) -> bool {
2017-09-05 09:33:04 +00:00
path.segments
.iter()
.rev()
.zip(segments.iter().rev())
2018-06-28 13:46:58 +00:00
.all(|(a, b)| a.ident.name == *b)
}
2016-01-12 22:17:54 +00:00
/// Match a `Path` against a slice of segment string literals, e.g.
///
/// # Examples
2016-12-21 09:00:13 +00:00
/// ```rust,ignore
/// match_qpath(path, &["std", "rt", "begin_unwind"])
2016-01-12 22:17:54 +00:00
/// ```
pub fn match_path_ast(path: &ast::Path, segments: &[&str]) -> bool {
2017-09-05 09:33:04 +00:00
path.segments
.iter()
.rev()
.zip(segments.iter().rev())
.all(|(a, b)| a.ident.name == *b)
}
/// Get the definition associated to a path.
pub fn path_to_def(cx: &LateContext, path: &[&str]) -> Option<def::Def> {
let crates = cx.tcx.crates();
2017-09-05 09:33:04 +00:00
let krate = crates
.iter()
.find(|&&krate| cx.tcx.crate_name(krate) == path[0]);
if let Some(krate) = krate {
2016-12-20 17:21:30 +00:00
let krate = DefId {
krate: *krate,
index: CRATE_DEF_INDEX,
};
let mut items = cx.tcx.item_children(krate);
let mut path_it = path.iter().skip(1).peekable();
loop {
let segment = match path_it.next() {
Some(segment) => segment,
2016-01-30 12:48:39 +00:00
None => return None,
};
for item in mem::replace(&mut items, Rc::new(vec![])).iter() {
if item.ident.name == *segment {
if path_it.peek().is_none() {
return Some(item.def);
}
items = cx.tcx.item_children(item.def.def_id());
break;
}
}
}
2016-01-30 12:48:39 +00:00
} else {
None
}
}
/// Convenience function to get the `DefId` of a trait by path.
pub fn get_trait_def_id(cx: &LateContext, path: &[&str]) -> Option<DefId> {
let def = match path_to_def(cx, path) {
Some(def) => def,
None => return None,
};
match def {
def::Def::Trait(trait_id) => Some(trait_id),
_ => None,
}
}
/// Check whether a type implements a trait.
/// See also `get_trait_def_id`.
pub fn implements_trait<'a, 'tcx>(
cx: &LateContext<'a, 'tcx>,
ty: Ty<'tcx>,
trait_id: DefId,
ty_params: &[Kind<'tcx>],
) -> bool {
let ty = cx.tcx.erase_regions(&ty);
2017-09-05 09:33:04 +00:00
let obligation =
cx.tcx
.predicate_for_trait_def(cx.param_env, traits::ObligationCause::dummy(), trait_id, 0, ty, ty_params);
cx.tcx.infer_ctxt().enter(|infcx| infcx.predicate_must_hold(&obligation))
}
2017-09-19 20:38:35 +00:00
/// Check whether this type implements Drop.
pub fn has_drop(cx: &LateContext, expr: &Expr) -> bool {
let struct_ty = cx.tables.expr_ty(expr);
match struct_ty.ty_adt_def() {
Some(def) => def.has_dtor(cx.tcx),
_ => false,
}
}
2017-08-15 09:10:49 +00:00
/// Resolve the definition of a node from its `HirId`.
pub fn resolve_node(cx: &LateContext, qpath: &QPath, id: HirId) -> def::Def {
2017-01-13 16:04:56 +00:00
cx.tables.qpath_def(qpath, id)
}
2016-01-12 22:17:54 +00:00
/// Match an `Expr` against a chain of methods, and return the matched `Expr`s.
///
/// For example, if `expr` represents the `.baz()` in `foo.bar().baz()`,
2017-08-09 07:30:56 +00:00
/// `matched_method_chain(expr, &["bar", "baz"])` will return a `Vec`
/// containing the `Expr`s for
2016-01-12 22:17:54 +00:00
/// `.bar()` and `.baz()`
pub fn method_chain_args<'a>(expr: &'a Expr, methods: &[&str]) -> Option<Vec<&'a [Expr]>> {
let mut current = expr;
let mut matched = Vec::with_capacity(methods.len());
2016-01-04 04:26:12 +00:00
for method_name in methods.iter().rev() {
// method chains are stored last -> first
if let ExprMethodCall(ref path, _, ref args) = current.node {
2018-06-28 13:46:58 +00:00
if path.ident.name == *method_name {
2017-04-06 14:48:48 +00:00
if args.iter().any(|e| in_macro(e.span)) {
return None;
}
matched.push(&**args); // build up `matched` backwards
current = &args[0] // go to parent expression
2016-01-04 04:26:12 +00:00
} else {
return None;
}
2016-01-04 04:26:12 +00:00
} else {
return None;
}
}
matched.reverse(); // reverse `matched`, so that it is in the same order as `methods`
Some(matched)
}
2016-01-12 22:17:54 +00:00
/// Get the name of the item the expression is in, if available.
pub fn get_item_name(cx: &LateContext, expr: &Expr) -> Option<Name> {
2017-02-02 16:53:28 +00:00
let parent_id = cx.tcx.hir.get_parent(expr.id);
match cx.tcx.hir.find(parent_id) {
2018-06-28 13:46:58 +00:00
Some(Node::NodeItem(&Item { ref name, .. })) => Some(*name),
Some(Node::NodeTraitItem(&TraitItem { ident, .. })) |
Some(Node::NodeImplItem(&ImplItem { ident, .. })) => Some(ident.name),
_ => None,
}
}
/// Get the name of a `Pat`, if any
pub fn get_pat_name(pat: &Pat) -> Option<Name> {
match pat.node {
2018-06-28 13:46:58 +00:00
PatKind::Binding(_, _, ref spname, _) => Some(spname.name),
PatKind::Path(ref qpath) => single_segment_path(qpath).map(|ps| ps.ident.name),
PatKind::Box(ref p) | PatKind::Ref(ref p, _) => get_pat_name(&*p),
_ => None,
}
}
struct ContainsName {
name: Name,
result: bool,
}
impl<'tcx> Visitor<'tcx> for ContainsName {
fn visit_name(&mut self, _: Span, name: Name) {
if self.name == name {
self.result = true;
}
}
fn nested_visit_map<'this>(&'this mut self) -> NestedVisitorMap<'this, 'tcx> {
NestedVisitorMap::None
}
}
/// check if an `Expr` contains a certain name
pub fn contains_name(name: Name, expr: &Expr) -> bool {
let mut cn = ContainsName {
name,
result: false,
};
cn.visit_expr(expr);
cn.result
}
2016-01-12 22:17:54 +00:00
/// Convert a span to a code snippet if available, otherwise use default.
///
/// # Example
2016-12-21 09:00:13 +00:00
/// ```rust,ignore
2016-01-12 22:17:54 +00:00
/// snippet(cx, expr.span, "..")
/// ```
pub fn snippet<'a, 'b, T: LintContext<'b>>(cx: &T, span: Span, default: &'a str) -> Cow<'a, str> {
snippet_opt(cx, span).map_or_else(|| Cow::Borrowed(default), From::from)
}
2016-01-12 22:17:54 +00:00
/// Convert a span to a code snippet. Returns `None` if not available.
pub fn snippet_opt<'a, T: LintContext<'a>>(cx: &T, span: Span) -> Option<String> {
2015-12-08 06:03:01 +00:00
cx.sess().codemap().span_to_snippet(span).ok()
}
2017-08-09 07:30:56 +00:00
/// Convert a span (from a block) to a code snippet if available, otherwise use
/// default.
/// This trims the code of indentation, except for the first line. Use it for
/// blocks or block-like
2016-01-12 22:17:54 +00:00
/// things which need to be printed as such.
///
/// # Example
2016-12-21 09:00:13 +00:00
/// ```rust,ignore
2016-01-12 22:17:54 +00:00
/// snippet(cx, expr.span, "..")
/// ```
pub fn snippet_block<'a, 'b, T: LintContext<'b>>(cx: &T, span: Span, default: &'a str) -> Cow<'a, str> {
let snip = snippet(cx, span, default);
trim_multiline(snip, true)
}
/// Returns a new Span that covers the full last line of the given Span
pub fn last_line_of_span<'a, T: LintContext<'a>>(cx: &T, span: Span) -> Span {
let file_map_and_line = cx.sess().codemap().lookup_line(span.lo()).unwrap();
let line_no = file_map_and_line.line;
2018-06-28 13:46:58 +00:00
let line_start = &file_map_and_line.fm.lines[line_no];
Span::new(*line_start, span.hi(), span.ctxt())
}
2016-01-12 22:17:54 +00:00
/// Like `snippet_block`, but add braces if the expr is not an `ExprBlock`.
/// Also takes an `Option<String>` which can be put inside the braces.
pub fn expr_block<'a, 'b, T: LintContext<'b>>(
cx: &T,
expr: &Expr,
option: Option<String>,
2017-08-09 07:30:56 +00:00
default: &'a str,
) -> Cow<'a, str> {
let code = snippet_block(cx, expr.span, default);
2016-01-12 22:17:54 +00:00
let string = option.unwrap_or_default();
2018-05-17 09:21:15 +00:00
if let ExprBlock(_, _) = expr.node {
Cow::Owned(format!("{}{}", code, string))
} else if string.is_empty() {
Cow::Owned(format!("{{ {} }}", code))
} else {
Cow::Owned(format!("{{\n{};\n{}\n}}", code, string))
}
}
2017-08-09 07:30:56 +00:00
/// Trim indentation from a multiline string with possibility of ignoring the
/// first line.
2015-08-13 17:50:00 +00:00
pub fn trim_multiline(s: Cow<str>, ignore_first: bool) -> Cow<str> {
2015-08-21 15:11:34 +00:00
let s_space = trim_multiline_inner(s, ignore_first, ' ');
let s_tab = trim_multiline_inner(s_space, ignore_first, '\t');
trim_multiline_inner(s_tab, ignore_first, ' ')
2015-08-13 07:57:30 +00:00
}
2015-08-13 17:50:00 +00:00
fn trim_multiline_inner(s: Cow<str>, ignore_first: bool, ch: char) -> Cow<str> {
2016-01-04 04:26:12 +00:00
let x = s.lines()
2016-12-20 17:21:30 +00:00
.skip(ignore_first as usize)
.filter_map(|l| {
if l.is_empty() {
None
} else {
// ignore empty lines
2017-08-09 07:30:56 +00:00
Some(
l.char_indices()
.find(|&(_, x)| x != ch)
.unwrap_or((l.len(), ch))
.0,
)
2016-12-20 17:21:30 +00:00
}
})
.min()
.unwrap_or(0);
if x > 0 {
2017-08-09 07:30:56 +00:00
Cow::Owned(
s.lines()
.enumerate()
2017-11-04 19:55:56 +00:00
.map(|(i, l)| {
if (ignore_first && i == 0) || l.is_empty() {
l
} else {
l.split_at(x).1
}
2017-08-09 07:30:56 +00:00
})
.collect::<Vec<_>>()
.join("\n"),
)
} else {
s
}
}
2016-01-12 22:17:54 +00:00
/// Get a parent expressions if any this is useful to constrain a lint.
pub fn get_parent_expr<'c>(cx: &'c LateContext, e: &Expr) -> Option<&'c Expr> {
2017-02-02 16:53:28 +00:00
let map = &cx.tcx.hir;
2016-01-04 04:26:12 +00:00
let node_id: NodeId = e.id;
let parent_id: NodeId = map.get_parent_node(node_id);
if node_id == parent_id {
return None;
}
2017-11-04 19:55:56 +00:00
map.find(parent_id).and_then(|node| {
if let Node::NodeExpr(parent) = node {
2017-08-09 07:30:56 +00:00
Some(parent)
} else {
None
2017-11-04 19:55:56 +00:00
}
})
}
pub fn get_enclosing_block<'a, 'tcx: 'a>(cx: &LateContext<'a, 'tcx>, node: NodeId) -> Option<&'tcx Block> {
2017-02-02 16:53:28 +00:00
let map = &cx.tcx.hir;
2017-09-05 09:33:04 +00:00
let enclosing_node = map.get_enclosing_scope(node)
.and_then(|enclosing_id| map.find(enclosing_id));
if let Some(node) = enclosing_node {
match node {
2016-08-01 14:59:14 +00:00
Node::NodeBlock(block) => Some(block),
2017-09-05 09:33:04 +00:00
Node::NodeItem(&Item {
node: ItemFn(_, _, _, eid),
2017-09-05 09:33:04 +00:00
..
2018-01-30 19:52:45 +00:00
}) | Node::NodeImplItem(&ImplItem {
node: ImplItemKind::Method(_, eid),
..
2017-09-05 09:33:04 +00:00
}) => match cx.tcx.hir.body(eid).value.node {
2018-05-17 09:21:15 +00:00
ExprBlock(ref block, _) => Some(block),
2017-09-05 09:33:04 +00:00
_ => None,
2016-12-20 17:21:30 +00:00
},
2016-01-04 04:26:12 +00:00
_ => None,
}
2016-01-04 04:26:12 +00:00
} else {
None
}
}
2015-12-31 20:39:03 +00:00
pub struct DiagnosticWrapper<'a>(pub DiagnosticBuilder<'a>);
impl<'a> Drop for DiagnosticWrapper<'a> {
fn drop(&mut self) {
self.0.emit();
}
}
impl<'a> DiagnosticWrapper<'a> {
2017-09-01 08:29:49 +00:00
fn docs_link(&mut self, lint: &'static Lint) {
if env::var("CLIPPY_DISABLE_DOCS_LINKS").is_err() {
2017-08-09 07:30:56 +00:00
self.0.help(&format!(
"for further information visit https://rust-lang-nursery.github.io/rust-clippy/v{}/index.html#{}",
env!("CARGO_PKG_VERSION"),
2017-08-09 07:30:56 +00:00
lint.name_lower()
));
}
}
}
pub fn span_lint<'a, T: LintContext<'a>>(cx: &T, lint: &'static Lint, sp: Span, msg: &str) {
2017-09-01 08:29:49 +00:00
DiagnosticWrapper(cx.struct_span_lint(lint, sp, msg)).docs_link(lint);
}
pub fn span_help_and_lint<'a, 'tcx: 'a, T: LintContext<'tcx>>(
cx: &'a T,
lint: &'static Lint,
span: Span,
msg: &str,
2017-08-09 07:30:56 +00:00
help: &str,
) {
let mut db = DiagnosticWrapper(cx.struct_span_lint(lint, span, msg));
2017-08-11 12:11:46 +00:00
db.0.help(help);
2017-09-01 08:29:49 +00:00
db.docs_link(lint);
2015-07-26 14:53:11 +00:00
}
pub fn span_note_and_lint<'a, 'tcx: 'a, T: LintContext<'tcx>>(
cx: &'a T,
lint: &'static Lint,
span: Span,
msg: &str,
note_span: Span,
2017-08-09 07:30:56 +00:00
note: &str,
) {
let mut db = DiagnosticWrapper(cx.struct_span_lint(lint, span, msg));
2017-08-11 12:11:46 +00:00
if note_span == span {
db.0.note(note);
} else {
db.0.span_note(note_span, note);
2015-09-02 06:19:47 +00:00
}
2017-09-01 08:29:49 +00:00
db.docs_link(lint);
2015-09-02 06:19:47 +00:00
}
pub fn span_lint_and_then<'a, 'tcx: 'a, T: LintContext<'tcx>, F>(
cx: &'a T,
lint: &'static Lint,
sp: Span,
msg: &str,
2017-08-09 07:30:56 +00:00
f: F,
) where
F: for<'b> FnOnce(&mut DiagnosticBuilder<'b>),
2016-01-04 04:26:12 +00:00
{
2015-12-31 20:39:03 +00:00
let mut db = DiagnosticWrapper(cx.struct_span_lint(lint, sp, msg));
2017-08-11 12:11:46 +00:00
f(&mut db.0);
2017-09-01 08:29:49 +00:00
db.docs_link(lint);
2015-12-08 16:28:35 +00:00
}
2018-01-14 18:18:09 +00:00
/// Add a span lint with a suggestion on how to fix it.
///
/// These suggestions can be parsed by rustfix to allow it to automatically fix your code.
/// In the example below, `help` is `"try"` and `sugg` is the suggested replacement `".any(|x| x > 2)"`.
///
2018-06-25 19:22:53 +00:00
/// ```ignore
2018-01-14 18:18:09 +00:00
/// error: This `.fold` can be more succinctly expressed as `.any`
/// --> $DIR/methods.rs:390:13
/// |
/// 390 | let _ = (0..3).fold(false, |acc, x| acc || x > 2);
/// | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.any(|x| x > 2)`
2018-01-14 18:18:09 +00:00
/// |
/// = note: `-D fold-any` implied by `-D warnings`
2018-01-17 21:06:16 +00:00
/// ```
pub fn span_lint_and_sugg<'a, 'tcx: 'a, T: LintContext<'tcx>>(
cx: &'a T,
lint: &'static Lint,
sp: Span,
msg: &str,
help: &str,
2017-08-09 07:30:56 +00:00
sugg: String,
) {
2017-11-04 19:55:56 +00:00
span_lint_and_then(cx, lint, sp, msg, |db| {
db.span_suggestion(sp, help, sugg);
});
}
2016-07-01 16:38:50 +00:00
/// Create a suggestion made from several `span → replacement`.
///
2017-08-09 07:30:56 +00:00
/// Note: in the JSON format (used by `compiletest_rs`), the help message will
/// appear once per
/// replacement. In human-readable format though, it only appears once before
/// the whole suggestion.
2017-10-11 03:10:10 +00:00
pub fn multispan_sugg<I>(db: &mut DiagnosticBuilder, help_msg: String, sugg: I)
where
2017-11-04 19:55:56 +00:00
I: IntoIterator<Item = (Span, String)>,
2017-10-11 03:10:10 +00:00
{
2018-05-01 16:10:25 +00:00
let sugg = CodeSuggestion {
2017-11-10 07:58:54 +00:00
substitutions: vec![
2018-05-01 16:10:25 +00:00
Substitution {
2017-11-10 07:58:54 +00:00
parts: sugg.into_iter()
.map(|(span, snippet)| {
2018-05-01 16:10:25 +00:00
SubstitutionPart {
2017-11-10 07:58:54 +00:00
snippet,
span,
}
})
.collect(),
}
],
2017-05-02 14:56:36 +00:00
msg: help_msg,
show_code_when_inline: true,
2018-05-01 16:10:25 +00:00
applicability: Applicability::Unspecified,
2016-07-01 16:38:50 +00:00
};
db.suggestions.push(sugg);
2016-07-01 16:38:50 +00:00
}
2017-09-10 17:32:24 +00:00
/// Return the base type for HIR references and pointers.
pub fn walk_ptrs_hir_ty(ty: &hir::Ty) -> &hir::Ty {
match ty.node {
2017-11-04 19:55:56 +00:00
TyPtr(ref mut_ty) | TyRptr(_, ref mut_ty) => walk_ptrs_hir_ty(&mut_ty.ty),
_ => ty,
2017-09-10 17:32:24 +00:00
}
}
2016-01-12 22:17:54 +00:00
/// Return the base type for references and raw pointers.
pub fn walk_ptrs_ty(ty: Ty) -> Ty {
match ty.sty {
2018-05-11 06:37:48 +00:00
ty::TyRef(_, ty, _) => walk_ptrs_ty(ty),
2016-01-04 04:26:12 +00:00
_ => ty,
}
}
2017-08-09 07:30:56 +00:00
/// Return the base type for references and raw pointers, and count reference
/// depth.
pub fn walk_ptrs_ty_depth(ty: Ty) -> (Ty, usize) {
fn inner(ty: Ty, depth: usize) -> (Ty, usize) {
match ty.sty {
2018-05-11 06:37:48 +00:00
ty::TyRef(_, ty, _) => inner(ty, depth + 1),
2016-01-04 04:26:12 +00:00
_ => (ty, depth),
}
}
inner(ty, 0)
}
/// Check whether the given expression is a constant literal of the given value.
pub fn is_integer_literal(expr: &Expr, value: u128) -> bool {
// FIXME: use constant folding
if let ExprLit(ref spanned) = expr.node {
2016-02-12 17:35:44 +00:00
if let LitKind::Int(v, _) = spanned.node {
return v == value;
}
}
false
}
2015-11-04 03:11:40 +00:00
pub fn is_adjusted(cx: &LateContext, e: &Expr) -> bool {
2017-08-15 09:10:49 +00:00
cx.tables.adjustments().get(e.hir_id).is_some()
2015-11-04 03:11:40 +00:00
}
pub struct LimitStack {
stack: Vec<u64>,
}
impl Drop for LimitStack {
fn drop(&mut self) {
assert_eq!(self.stack.len(), 1);
}
}
impl LimitStack {
2017-08-21 11:32:12 +00:00
pub fn new(limit: u64) -> Self {
Self { stack: vec![limit] }
}
pub fn limit(&self) -> u64 {
2017-09-05 09:33:04 +00:00
*self.stack
.last()
.expect("there should always be a value in the stack")
}
pub fn push_attrs(&mut self, sess: &Session, attrs: &[ast::Attribute], name: &'static str) {
let stack = &mut self.stack;
2016-01-04 04:26:12 +00:00
parse_attrs(sess, attrs, name, |val| stack.push(val));
}
pub fn pop_attrs(&mut self, sess: &Session, attrs: &[ast::Attribute], name: &'static str) {
let stack = &mut self.stack;
2016-01-04 04:26:12 +00:00
parse_attrs(sess, attrs, name, |val| assert_eq!(stack.pop(), Some(val)));
}
}
2018-05-19 12:04:57 +00:00
pub fn get_attr<'a>(attrs: &'a [ast::Attribute], name: &'static str) -> impl Iterator<Item = &'a ast::Attribute> {
attrs.iter().filter_map(move |attr| {
if attr.path.segments.len() == 2 && attr.path.segments[0].ident.to_string() == "clippy" && attr.path.segments[1].ident.to_string() == name {
Some(attr)
} else {
None
2016-01-04 04:26:12 +00:00
}
2018-05-19 12:04:57 +00:00
})
}
fn parse_attrs<F: FnMut(u64)>(sess: &Session, attrs: &[ast::Attribute], name: &'static str, mut f: F) {
for attr in get_attr(attrs, name) {
if let Some(ref value) = attr.value_str() {
2018-05-19 12:04:57 +00:00
if let Ok(value) = FromStr::from_str(&value.as_str()) {
f(value)
} else {
sess.span_err(attr.span, "not a number");
}
2018-05-19 12:04:57 +00:00
} else {
sess.span_err(attr.span, "bad clippy attribute");
}
}
}
2016-01-03 14:49:25 +00:00
2017-08-09 07:30:56 +00:00
/// Return the pre-expansion span if is this comes from an expansion of the
/// macro `name`.
/// See also `is_direct_expn_of`.
pub fn is_expn_of(mut span: Span, name: &str) -> Option<Span> {
loop {
2017-09-05 09:33:04 +00:00
let span_name_span = span.ctxt()
.outer()
.expn_info()
.map(|ei| (ei.format.name(), ei.call_site));
2016-01-30 12:48:39 +00:00
2016-02-01 10:28:39 +00:00
match span_name_span {
Some((mac_name, new_span)) if mac_name == name => return Some(new_span),
2016-02-01 10:28:39 +00:00
None => return None,
Some((_, new_span)) => span = new_span,
}
}
}
2017-08-09 07:30:56 +00:00
/// Return the pre-expansion span if is this directly comes from an expansion
/// of the macro `name`.
/// The difference with `is_expn_of` is that in
/// ```rust,ignore
/// foo!(bar!(42));
/// ```
2017-08-09 07:30:56 +00:00
/// `42` is considered expanded from `foo!` and `bar!` by `is_expn_of` but only
/// `bar!` by
/// `is_direct_expn_of`.
pub fn is_direct_expn_of(span: Span, name: &str) -> Option<Span> {
2017-09-05 09:33:04 +00:00
let span_name_span = span.ctxt()
.outer()
.expn_info()
.map(|ei| (ei.format.name(), ei.call_site));
match span_name_span {
Some((mac_name, new_span)) if mac_name == name => Some(new_span),
_ => None,
}
}
2017-08-09 07:30:56 +00:00
/// Return the index of the character after the first camel-case component of
/// `s`.
pub fn camel_case_until(s: &str) -> usize {
let mut iter = s.char_indices();
if let Some((_, first)) = iter.next() {
if !first.is_uppercase() {
return 0;
}
} else {
return 0;
}
let mut up = true;
let mut last_i = 0;
for (i, c) in iter {
if up {
if c.is_lowercase() {
up = false;
} else {
return last_i;
}
} else if c.is_uppercase() {
up = true;
last_i = i;
} else if !c.is_lowercase() {
return i;
}
}
2017-09-05 09:33:04 +00:00
if up {
last_i
} else {
s.len()
}
}
2016-03-19 16:48:29 +00:00
/// Return index of the last camel-case component of `s`.
pub fn camel_case_from(s: &str) -> usize {
let mut iter = s.char_indices().rev();
if let Some((_, first)) = iter.next() {
if !first.is_lowercase() {
return s.len();
}
} else {
return s.len();
}
let mut down = true;
let mut last_i = s.len();
for (i, c) in iter {
if down {
if c.is_uppercase() {
down = false;
last_i = i;
} else if !c.is_lowercase() {
return last_i;
}
} else if c.is_lowercase() {
down = true;
} else {
return last_i;
}
}
last_i
}
2016-08-17 15:58:15 +00:00
/// Convenience function to get the return type of a function
pub fn return_ty<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, fn_item: NodeId) -> Ty<'tcx> {
2017-02-02 16:53:28 +00:00
let fn_def_id = cx.tcx.hir.local_def_id(fn_item);
let ret_ty = cx.tcx.fn_sig(fn_def_id).output();
cx.tcx.erase_late_bound_regions(&ret_ty)
}
2016-03-03 18:46:10 +00:00
/// Check if two types are the same.
///
/// This discards any lifetime annotations, too.
2017-08-09 07:30:56 +00:00
// FIXME: this works correctly for lifetimes bounds (`for <'a> Foo<'a>` == `for
// <'b> Foo<'b>` but
2016-03-03 18:46:10 +00:00
// not for type parameters.
2017-06-11 04:46:26 +00:00
pub fn same_tys<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, a: Ty<'tcx>, b: Ty<'tcx>) -> bool {
let a = cx.tcx.erase_late_bound_regions(&Binder::bind(a));
let b = cx.tcx.erase_late_bound_regions(&Binder::bind(b));
2017-09-05 09:33:04 +00:00
cx.tcx
.infer_ctxt()
.enter(|infcx| infcx.can_eq(cx.param_env, a, b).is_ok())
2016-03-03 18:46:10 +00:00
}
/// Return whether the given type is an `unsafe` function.
pub fn type_is_unsafe_function<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, ty: Ty<'tcx>) -> bool {
match ty.sty {
2017-06-29 14:07:43 +00:00
ty::TyFnDef(..) | ty::TyFnPtr(_) => ty.fn_sig(cx.tcx).unsafety() == Unsafety::Unsafe,
_ => false,
}
}
pub fn is_copy<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, ty: Ty<'tcx>) -> bool {
!ty.moves_by_default(cx.tcx.global_tcx(), cx.param_env, DUMMY_SP)
}
/// Return whether a pattern is refutable.
pub fn is_refutable(cx: &LateContext, pat: &Pat) -> bool {
2017-08-15 09:10:49 +00:00
fn is_enum_variant(cx: &LateContext, qpath: &QPath, id: HirId) -> bool {
2017-08-09 07:30:56 +00:00
matches!(
2017-08-15 09:10:49 +00:00
cx.tables.qpath_def(qpath, id),
2017-08-09 07:30:56 +00:00
def::Def::Variant(..) | def::Def::VariantCtor(..)
)
}
2016-12-20 17:21:30 +00:00
fn are_refutable<'a, I: Iterator<Item = &'a Pat>>(cx: &LateContext, mut i: I) -> bool {
i.any(|pat| is_refutable(cx, pat))
}
match pat.node {
2017-09-05 09:33:04 +00:00
PatKind::Binding(..) | PatKind::Wild => false,
PatKind::Box(ref pat) | PatKind::Ref(ref pat, _) => is_refutable(cx, pat),
PatKind::Lit(..) | PatKind::Range(..) => true,
2017-08-15 09:10:49 +00:00
PatKind::Path(ref qpath) => is_enum_variant(cx, qpath, pat.hir_id),
PatKind::Tuple(ref pats, _) => are_refutable(cx, pats.iter().map(|pat| &**pat)),
2017-09-05 09:33:04 +00:00
PatKind::Struct(ref qpath, ref fields, _) => if is_enum_variant(cx, qpath, pat.hir_id) {
true
} else {
are_refutable(cx, fields.iter().map(|field| &*field.node.pat))
2016-12-20 17:21:30 +00:00
},
2017-09-05 09:33:04 +00:00
PatKind::TupleStruct(ref qpath, ref pats, _) => if is_enum_variant(cx, qpath, pat.hir_id) {
true
} else {
are_refutable(cx, pats.iter().map(|pat| &**pat))
2016-12-20 17:21:30 +00:00
},
2017-09-05 09:33:04 +00:00
PatKind::Slice(ref head, ref middle, ref tail) => are_refutable(
cx,
head.iter()
.chain(middle)
.chain(tail.iter())
.map(|pat| &**pat),
),
}
}
2017-08-09 07:30:56 +00:00
/// Checks for the `#[automatically_derived]` attribute all `#[derive]`d
/// implementations have.
pub fn is_automatically_derived(attrs: &[ast::Attribute]) -> bool {
attr::contains_name(attrs, "automatically_derived")
}
/// Remove blocks around an expression.
///
2017-08-09 07:30:56 +00:00
/// Ie. `x`, `{ x }` and `{{{{ x }}}}` all give `x`. `{ x; y }` and `{}` return
/// themselves.
pub fn remove_blocks(expr: &Expr) -> &Expr {
2018-05-17 09:21:15 +00:00
if let ExprBlock(ref block, _) = expr.node {
if block.stmts.is_empty() {
if let Some(ref expr) = block.expr {
remove_blocks(expr)
} else {
expr
}
} else {
expr
}
} else {
expr
}
}
pub fn opt_def_id(def: Def) -> Option<DefId> {
match def {
2016-12-20 17:21:30 +00:00
Def::Fn(id) |
Def::Mod(id) |
Def::Static(id, _) |
Def::Variant(id) |
Def::VariantCtor(id, ..) |
Def::Enum(id) |
Def::TyAlias(id) |
Def::AssociatedTy(id) |
Def::TyParam(id) |
2017-10-29 09:21:25 +00:00
Def::TyForeign(id) |
2016-12-20 17:21:30 +00:00
Def::Struct(id) |
Def::StructCtor(id, ..) |
Def::Union(id) |
Def::Trait(id) |
Def::TraitAlias(id) |
2016-12-20 17:21:30 +00:00
Def::Method(id) |
Def::Const(id) |
Def::AssociatedConst(id) |
Def::Macro(id, ..) |
2018-06-19 07:56:37 +00:00
Def::Existential(id) |
Def::GlobalAsm(id) => Some(id),
2016-12-20 17:21:30 +00:00
2017-09-12 12:26:40 +00:00
Def::Upvar(..) | Def::Local(_) | Def::Label(..) | Def::PrimTy(..) | Def::SelfTy(..) | Def::Err => None,
}
}
pub fn is_self(slf: &Arg) -> bool {
if let PatKind::Binding(_, _, name, _) = slf.pat.node {
2018-06-28 13:46:58 +00:00
name.name == keywords::SelfValue.name()
} else {
false
}
}
pub fn is_self_ty(slf: &hir::Ty) -> bool {
if_chain! {
if let TyPath(ref qp) = slf.node;
if let QPath::Resolved(None, ref path) = *qp;
if let Def::SelfTy(..) = path.def;
then {
return true
}
}
false
}
2017-01-04 23:53:16 +00:00
pub fn iter_input_pats<'tcx>(decl: &FnDecl, body: &'tcx Body) -> impl Iterator<Item = &'tcx Arg> {
(0..decl.inputs.len()).map(move |i| &body.arguments[i])
2017-01-04 23:53:16 +00:00
}
/// Check if a given expression is a match expression
/// expanded from `?` operator or `try` macro.
pub fn is_try(expr: &Expr) -> Option<&Expr> {
fn is_ok(arm: &Arm) -> bool {
if_chain! {
if let PatKind::TupleStruct(ref path, ref pat, None) = arm.pats[0].node;
if match_qpath(path, &paths::RESULT_OK[1..]);
if let PatKind::Binding(_, defid, _, None) = pat[0].node;
if let ExprPath(QPath::Resolved(None, ref path)) = arm.body.node;
if let Def::Local(lid) = path.def;
if lid == defid;
then {
return true;
}
}
false
}
fn is_err(arm: &Arm) -> bool {
if let PatKind::TupleStruct(ref path, _, _) = arm.pats[0].node {
match_qpath(path, &paths::RESULT_ERR[1..])
} else {
false
}
}
if let ExprMatch(_, ref arms, ref source) = expr.node {
// desugared from a `?` operator
if let MatchSource::TryDesugar = *source {
return Some(expr);
}
if_chain! {
if arms.len() == 2;
if arms[0].pats.len() == 1 && arms[0].guard.is_none();
if arms[1].pats.len() == 1 && arms[1].guard.is_none();
if (is_ok(&arms[0]) && is_err(&arms[1])) ||
(is_ok(&arms[1]) && is_err(&arms[0]));
then {
return Some(expr);
}
}
}
None
}
2017-08-11 12:11:46 +00:00
/// Returns true if the lint is allowed in the current context
///
/// Useful for skipping long running code when it's unnecessary
pub fn is_allowed(cx: &LateContext, lint: &'static Lint, id: NodeId) -> bool {
cx.tcx.lint_level_at_node(lint, id).0 == Level::Allow
}
2018-01-14 10:05:01 +00:00
pub fn get_arg_name(pat: &Pat) -> Option<ast::Name> {
match pat.node {
2018-06-28 13:46:58 +00:00
PatKind::Binding(_, _, ident, None) => Some(ident.name),
2018-01-14 10:05:01 +00:00
PatKind::Ref(ref subpat, _) => get_arg_name(subpat),
_ => None,
}
}
2018-03-13 10:38:11 +00:00
2018-06-28 13:46:58 +00:00
pub fn get_arg_ident(pat: &Pat) -> Option<ast::Ident> {
match pat.node {
PatKind::Binding(_, _, ident, None) => Some(ident),
PatKind::Ref(ref subpat, _) => get_arg_ident(subpat),
_ => None,
}
}
2018-03-13 10:38:11 +00:00
pub fn int_bits(tcx: TyCtxt, ity: ast::IntTy) -> u64 {
layout::Integer::from_attr(tcx, attr::IntType::SignedInt(ity)).size().bits()
}
/// Turn a constant int byte representation into an i128
pub fn sext(tcx: TyCtxt, u: u128, ity: ast::IntTy) -> i128 {
let amt = 128 - int_bits(tcx, ity);
((u as i128) << amt) >> amt
}
/// clip unused bytes
pub fn unsext(tcx: TyCtxt, u: i128, ity: ast::IntTy) -> u128 {
let amt = 128 - int_bits(tcx, ity);
((u as u128) << amt) >> amt
}
/// clip unused bytes
pub fn clip(tcx: TyCtxt, u: u128, ity: ast::UintTy) -> u128 {
let bits = layout::Integer::from_attr(tcx, attr::IntType::UnsignedInt(ity)).size().bits();
let amt = 128 - bits;
(u << amt) >> amt
}
/// Remove block comments from the given Vec of lines
///
/// # Examples
///
/// ```rust,ignore
/// without_block_comments(vec!["/*", "foo", "*/"]);
/// // => vec![]
///
/// without_block_comments(vec!["bar", "/*", "foo", "*/"]);
/// // => vec!["bar"]
/// ```
pub fn without_block_comments(lines: Vec<&str>) -> Vec<&str> {
let mut without = vec![];
2018-03-30 10:36:30 +00:00
let mut nest_level = 0;
2018-04-02 05:35:13 +00:00
for line in lines {
if line.contains("/*") {
2018-03-30 10:36:30 +00:00
nest_level += 1;
continue;
} else if line.contains("*/") {
2018-03-30 10:36:30 +00:00
nest_level -= 1;
continue;
}
2018-03-30 10:36:30 +00:00
if nest_level == 0 {
without.push(line);
}
}
without
}
2018-06-17 21:58:08 +00:00
pub fn any_parent_is_automatically_derived(tcx: TyCtxt, node: NodeId) -> bool {
let map = &tcx.hir;
let mut prev_enclosing_node = None;
let mut enclosing_node = node;
while Some(enclosing_node) != prev_enclosing_node {
if is_automatically_derived(map.attrs(enclosing_node)) {
return true;
}
prev_enclosing_node = Some(enclosing_node);
enclosing_node = map.get_parent(enclosing_node);
}
false
}