2015-09-03 14:42:17 +00:00
|
|
|
|
use reexport::*;
|
2016-04-07 15:46:48 +00:00
|
|
|
|
use rustc::hir::*;
|
|
|
|
|
use rustc::hir::def_id::DefId;
|
|
|
|
|
use rustc::hir::map::Node;
|
|
|
|
|
use rustc::infer;
|
2016-02-03 14:39:22 +00:00
|
|
|
|
use rustc::lint::{LintContext, LateContext, Level, Lint};
|
2016-04-07 15:46:48 +00:00
|
|
|
|
use rustc::middle::cstore;
|
|
|
|
|
use rustc::session::Session;
|
2016-03-27 18:59:02 +00:00
|
|
|
|
use rustc::traits::ProjectionMode;
|
2016-04-07 15:46:48 +00:00
|
|
|
|
use rustc::traits;
|
2016-03-27 18:59:02 +00:00
|
|
|
|
use rustc::ty::subst::Subst;
|
2016-04-07 15:46:48 +00:00
|
|
|
|
use rustc::ty;
|
2015-08-16 06:54:43 +00:00
|
|
|
|
use std::borrow::Cow;
|
2016-01-18 12:10:13 +00:00
|
|
|
|
use std::mem;
|
|
|
|
|
use std::ops::{Deref, DerefMut};
|
|
|
|
|
use std::str::FromStr;
|
2016-03-07 15:31:38 +00:00
|
|
|
|
use syntax::ast::{self, LitKind, RangeLimits};
|
2016-01-18 12:10:13 +00:00
|
|
|
|
use syntax::codemap::{ExpnInfo, Span, ExpnFormat};
|
2015-12-31 20:39:03 +00:00
|
|
|
|
use syntax::errors::DiagnosticBuilder;
|
2015-12-27 22:15:09 +00:00
|
|
|
|
use syntax::ptr::P;
|
2015-11-18 11:35:18 +00:00
|
|
|
|
|
2016-03-26 05:57:03 +00:00
|
|
|
|
pub mod comparisons;
|
2016-03-06 14:17:51 +00:00
|
|
|
|
pub mod conf;
|
2016-02-06 19:13:25 +00:00
|
|
|
|
mod hir;
|
2016-04-14 16:13:15 +00:00
|
|
|
|
pub mod paths;
|
2016-02-09 14:18:27 +00:00
|
|
|
|
pub use self::hir::{SpanlessEq, SpanlessHash};
|
2015-12-27 22:15:09 +00:00
|
|
|
|
|
2016-04-14 16:13:15 +00:00
|
|
|
|
pub type MethodArgs = HirVec<P<Expr>>;
|
2015-08-21 16:48:36 +00:00
|
|
|
|
|
2015-10-11 21:12:21 +00:00
|
|
|
|
/// Produce a nested chain of if-lets and ifs from the patterns:
|
|
|
|
|
///
|
|
|
|
|
/// if_let_chain! {
|
|
|
|
|
/// [
|
2015-10-12 05:54:44 +00:00
|
|
|
|
/// let Some(y) = x,
|
2015-10-11 21:12:21 +00:00
|
|
|
|
/// y.len() == 2,
|
2015-10-12 05:54:44 +00:00
|
|
|
|
/// let Some(z) = y,
|
2015-10-11 21:12:21 +00:00
|
|
|
|
/// ],
|
|
|
|
|
/// {
|
|
|
|
|
/// block
|
|
|
|
|
/// }
|
|
|
|
|
/// }
|
|
|
|
|
///
|
|
|
|
|
/// becomes
|
|
|
|
|
///
|
|
|
|
|
/// if let Some(y) = x {
|
|
|
|
|
/// if y.len() == 2 {
|
|
|
|
|
/// if let Some(z) = y {
|
|
|
|
|
/// block
|
|
|
|
|
/// }
|
|
|
|
|
/// }
|
|
|
|
|
/// }
|
|
|
|
|
#[macro_export]
|
|
|
|
|
macro_rules! if_let_chain {
|
|
|
|
|
([let $pat:pat = $expr:expr, $($tt:tt)+], $block:block) => {
|
|
|
|
|
if let $pat = $expr {
|
|
|
|
|
if_let_chain!{ [$($tt)+], $block }
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
([let $pat:pat = $expr:expr], $block:block) => {
|
|
|
|
|
if let $pat = $expr {
|
|
|
|
|
$block
|
|
|
|
|
}
|
|
|
|
|
};
|
2016-03-26 22:54:42 +00:00
|
|
|
|
([let $pat:pat = $expr:expr,], $block:block) => {
|
|
|
|
|
if let $pat = $expr {
|
|
|
|
|
$block
|
|
|
|
|
}
|
|
|
|
|
};
|
2015-10-11 21:12:21 +00:00
|
|
|
|
([$expr:expr, $($tt:tt)+], $block:block) => {
|
|
|
|
|
if $expr {
|
|
|
|
|
if_let_chain!{ [$($tt)+], $block }
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
([$expr:expr], $block:block) => {
|
|
|
|
|
if $expr {
|
|
|
|
|
$block
|
|
|
|
|
}
|
|
|
|
|
};
|
2016-03-26 22:54:42 +00:00
|
|
|
|
([$expr:expr,], $block:block) => {
|
|
|
|
|
if $expr {
|
|
|
|
|
$block
|
|
|
|
|
}
|
|
|
|
|
};
|
2015-10-11 21:12:21 +00:00
|
|
|
|
}
|
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Returns true if the two spans come from differing expansions (i.e. one is from a macro and one
|
|
|
|
|
/// isn't).
|
2016-03-01 09:13:54 +00:00
|
|
|
|
pub fn differing_macro_contexts(lhs: Span, rhs: Span) -> bool {
|
|
|
|
|
rhs.expn_id != lhs.expn_id
|
2016-01-02 16:11:48 +00:00
|
|
|
|
}
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Returns true if this `expn_info` was expanded by any macro.
|
2015-11-18 11:35:18 +00:00
|
|
|
|
pub fn in_macro<T: LintContext>(cx: &T, span: Span) -> bool {
|
2016-01-04 04:26:12 +00:00
|
|
|
|
cx.sess().codemap().with_expn_info(span.expn_id, |info| info.is_some())
|
2015-06-01 20:30:34 +00:00
|
|
|
|
}
|
2015-06-07 10:05:14 +00:00
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Returns true if the macro that expanded the crate was outside of the current crate or was a
|
|
|
|
|
/// compiler plugin.
|
2015-09-19 02:53:04 +00:00
|
|
|
|
pub fn in_external_macro<T: LintContext>(cx: &T, span: Span) -> bool {
|
2016-03-19 16:48:29 +00:00
|
|
|
|
/// Invokes `in_macro` with the expansion info of the given span slightly heavy, try to use
|
|
|
|
|
/// this after other checks have already happened.
|
2015-09-19 02:53:04 +00:00
|
|
|
|
fn in_macro_ext<T: LintContext>(cx: &T, opt_info: Option<&ExpnInfo>) -> bool {
|
2015-09-17 05:27:18 +00:00
|
|
|
|
// no ExpnInfo = no macro
|
|
|
|
|
opt_info.map_or(false, |info| {
|
2015-10-11 21:12:21 +00:00
|
|
|
|
if let ExpnFormat::MacroAttribute(..) = info.callee.format {
|
2016-01-04 04:26:12 +00:00
|
|
|
|
// these are all plugins
|
|
|
|
|
return true;
|
2015-09-17 05:27:18 +00:00
|
|
|
|
}
|
|
|
|
|
// no span for the callee = external macro
|
|
|
|
|
info.callee.span.map_or(true, |span| {
|
|
|
|
|
// no snippet = external macro or compiler-builtin expansion
|
2016-01-04 04:26:12 +00:00
|
|
|
|
cx.sess().codemap().span_to_snippet(span).ok().map_or(true, |code| !code.starts_with("macro_rules"))
|
2015-09-17 05:27:18 +00:00
|
|
|
|
})
|
|
|
|
|
})
|
|
|
|
|
}
|
2015-09-06 08:53:55 +00:00
|
|
|
|
|
2016-01-04 04:26:12 +00:00
|
|
|
|
cx.sess().codemap().with_expn_info(span.expn_id, |info| in_macro_ext(cx, info))
|
2015-06-07 10:05:14 +00:00
|
|
|
|
}
|
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Check if a `DefId`'s path matches the given absolute type path usage.
|
|
|
|
|
///
|
|
|
|
|
/// # Examples
|
|
|
|
|
/// ```
|
|
|
|
|
/// match_def_path(cx, id, &["core", "option", "Option"])
|
|
|
|
|
/// ```
|
2015-09-19 02:53:04 +00:00
|
|
|
|
pub fn match_def_path(cx: &LateContext, def_id: DefId, path: &[&str]) -> bool {
|
2016-04-07 15:46:48 +00:00
|
|
|
|
let krate = &cx.tcx.crate_name(def_id.krate);
|
|
|
|
|
if krate != &path[0] {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
let path = &path[1..];
|
|
|
|
|
let other = cx.tcx.def_path(def_id).data;
|
|
|
|
|
|
|
|
|
|
if other.len() != path.len() {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
2016-02-22 19:00:51 +00:00
|
|
|
|
|
2016-04-07 15:46:48 +00:00
|
|
|
|
other.into_iter()
|
|
|
|
|
.map(|e| e.data)
|
|
|
|
|
.zip(path)
|
|
|
|
|
.all(|(nm, p)| nm.as_interned_str() == *p)
|
2015-06-07 10:05:14 +00:00
|
|
|
|
}
|
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Check if type is struct or enum type with given def path.
|
2015-09-19 02:53:04 +00:00
|
|
|
|
pub fn match_type(cx: &LateContext, ty: ty::Ty, path: &[&str]) -> bool {
|
2015-08-21 17:00:33 +00:00
|
|
|
|
match ty.sty {
|
2016-04-14 18:14:03 +00:00
|
|
|
|
ty::TyEnum(ref adt, _) |
|
|
|
|
|
ty::TyStruct(ref adt, _) => match_def_path(cx, adt.did, path),
|
2016-01-04 04:26:12 +00:00
|
|
|
|
_ => false,
|
2015-08-21 17:00:33 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-01-18 12:10:13 +00:00
|
|
|
|
/// Check if the method call given in `expr` belongs to given type.
|
2015-10-17 18:16:54 +00:00
|
|
|
|
pub fn match_impl_method(cx: &LateContext, expr: &Expr, path: &[&str]) -> bool {
|
|
|
|
|
let method_call = ty::MethodCall::expr(expr.id);
|
|
|
|
|
|
2016-01-04 04:26:12 +00:00
|
|
|
|
let trt_id = cx.tcx
|
|
|
|
|
.tables
|
|
|
|
|
.borrow()
|
|
|
|
|
.method_map
|
|
|
|
|
.get(&method_call)
|
|
|
|
|
.and_then(|callee| cx.tcx.impl_of_method(callee.def_id));
|
2015-10-17 18:16:54 +00:00
|
|
|
|
if let Some(trt_id) = trt_id {
|
|
|
|
|
match_def_path(cx, trt_id, path)
|
|
|
|
|
} else {
|
|
|
|
|
false
|
|
|
|
|
}
|
|
|
|
|
}
|
2015-12-27 09:22:53 +00:00
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Check if the method call given in `expr` belongs to given trait.
|
2015-09-19 02:53:04 +00:00
|
|
|
|
pub fn match_trait_method(cx: &LateContext, expr: &Expr, path: &[&str]) -> bool {
|
2015-08-23 14:32:50 +00:00
|
|
|
|
let method_call = ty::MethodCall::expr(expr.id);
|
2016-01-12 22:17:54 +00:00
|
|
|
|
|
2016-01-04 04:26:12 +00:00
|
|
|
|
let trt_id = cx.tcx
|
|
|
|
|
.tables
|
|
|
|
|
.borrow()
|
|
|
|
|
.method_map
|
|
|
|
|
.get(&method_call)
|
|
|
|
|
.and_then(|callee| cx.tcx.trait_of_item(callee.def_id));
|
2015-08-23 14:32:50 +00:00
|
|
|
|
if let Some(trt_id) = trt_id {
|
|
|
|
|
match_def_path(cx, trt_id, path)
|
|
|
|
|
} else {
|
|
|
|
|
false
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Match a `Path` against a slice of segment string literals.
|
|
|
|
|
///
|
|
|
|
|
/// # Examples
|
|
|
|
|
/// ```
|
|
|
|
|
/// match_path(path, &["std", "rt", "begin_unwind"])
|
|
|
|
|
/// ```
|
2015-06-07 10:05:14 +00:00
|
|
|
|
pub fn match_path(path: &Path, segments: &[&str]) -> bool {
|
2016-01-04 04:26:12 +00:00
|
|
|
|
path.segments.iter().rev().zip(segments.iter().rev()).all(|(a, b)| a.identifier.name.as_str() == *b)
|
2015-06-07 10:05:14 +00:00
|
|
|
|
}
|
2015-07-09 15:02:21 +00:00
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Match a `Path` against a slice of segment string literals, e.g.
|
|
|
|
|
///
|
|
|
|
|
/// # Examples
|
|
|
|
|
/// ```
|
|
|
|
|
/// match_path(path, &["std", "rt", "begin_unwind"])
|
|
|
|
|
/// ```
|
2015-10-11 21:12:21 +00:00
|
|
|
|
pub fn match_path_ast(path: &ast::Path, segments: &[&str]) -> bool {
|
2016-01-04 04:26:12 +00:00
|
|
|
|
path.segments.iter().rev().zip(segments.iter().rev()).all(|(a, b)| a.identifier.name.as_str() == *b)
|
2015-10-11 21:12:21 +00:00
|
|
|
|
}
|
|
|
|
|
|
2016-01-18 12:10:13 +00:00
|
|
|
|
/// Get the definition associated to a path.
|
|
|
|
|
/// TODO: investigate if there is something more efficient for that.
|
|
|
|
|
pub fn path_to_def(cx: &LateContext, path: &[&str]) -> Option<cstore::DefLike> {
|
|
|
|
|
let cstore = &cx.tcx.sess.cstore;
|
|
|
|
|
|
|
|
|
|
let crates = cstore.crates();
|
|
|
|
|
let krate = crates.iter().find(|&&krate| cstore.crate_name(krate) == path[0]);
|
|
|
|
|
if let Some(krate) = krate {
|
|
|
|
|
let mut items = cstore.crate_top_level_items(*krate);
|
|
|
|
|
let mut path_it = path.iter().skip(1).peekable();
|
|
|
|
|
|
|
|
|
|
loop {
|
|
|
|
|
let segment = match path_it.next() {
|
|
|
|
|
Some(segment) => segment,
|
2016-01-30 12:48:39 +00:00
|
|
|
|
None => return None,
|
2016-01-18 12:10:13 +00:00
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
for item in &mem::replace(&mut items, vec![]) {
|
|
|
|
|
if item.name.as_str() == *segment {
|
|
|
|
|
if path_it.peek().is_none() {
|
|
|
|
|
return Some(item.def);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
let def_id = match item.def {
|
|
|
|
|
cstore::DefLike::DlDef(def) => def.def_id(),
|
|
|
|
|
cstore::DefLike::DlImpl(def_id) => def_id,
|
|
|
|
|
_ => panic!("Unexpected {:?}", item.def),
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
items = cstore.item_children(def_id);
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2016-01-30 12:48:39 +00:00
|
|
|
|
} else {
|
2016-01-18 12:10:13 +00:00
|
|
|
|
None
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Convenience function to get the `DefId` of a trait by path.
|
|
|
|
|
pub fn get_trait_def_id(cx: &LateContext, path: &[&str]) -> Option<DefId> {
|
|
|
|
|
let def = match path_to_def(cx, path) {
|
|
|
|
|
Some(def) => def,
|
|
|
|
|
None => return None,
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
match def {
|
2016-01-22 12:24:44 +00:00
|
|
|
|
cstore::DlDef(def::Def::Trait(trait_id)) => Some(trait_id),
|
2016-01-18 12:10:13 +00:00
|
|
|
|
_ => None,
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Check whether a type implements a trait.
|
|
|
|
|
/// See also `get_trait_def_id`.
|
2016-01-30 12:48:39 +00:00
|
|
|
|
pub fn implements_trait<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, ty: ty::Ty<'tcx>, trait_id: DefId,
|
2016-03-01 15:25:15 +00:00
|
|
|
|
ty_params: Vec<ty::Ty<'tcx>>)
|
2016-01-30 12:48:39 +00:00
|
|
|
|
-> bool {
|
2016-01-18 12:10:13 +00:00
|
|
|
|
cx.tcx.populate_implementations_for_trait_if_necessary(trait_id);
|
|
|
|
|
|
2016-03-18 18:12:32 +00:00
|
|
|
|
let ty = cx.tcx.erase_regions(&ty);
|
2016-03-16 15:57:11 +00:00
|
|
|
|
let infcx = infer::new_infer_ctxt(cx.tcx, &cx.tcx.tables, None, ProjectionMode::Any);
|
2016-01-18 12:10:13 +00:00
|
|
|
|
let obligation = traits::predicate_for_trait_def(cx.tcx,
|
|
|
|
|
traits::ObligationCause::dummy(),
|
2016-01-30 12:48:39 +00:00
|
|
|
|
trait_id,
|
|
|
|
|
0,
|
|
|
|
|
ty,
|
2016-03-01 15:25:15 +00:00
|
|
|
|
ty_params);
|
2016-01-18 12:10:13 +00:00
|
|
|
|
|
|
|
|
|
traits::SelectionContext::new(&infcx).evaluate_obligation_conservatively(&obligation)
|
|
|
|
|
}
|
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Match an `Expr` against a chain of methods, and return the matched `Expr`s.
|
|
|
|
|
///
|
|
|
|
|
/// For example, if `expr` represents the `.baz()` in `foo.bar().baz()`,
|
|
|
|
|
/// `matched_method_chain(expr, &["bar", "baz"])` will return a `Vec` containing the `Expr`s for
|
|
|
|
|
/// `.bar()` and `.baz()`
|
2015-12-27 22:15:09 +00:00
|
|
|
|
pub fn method_chain_args<'a>(expr: &'a Expr, methods: &[&str]) -> Option<Vec<&'a MethodArgs>> {
|
|
|
|
|
let mut current = expr;
|
|
|
|
|
let mut matched = Vec::with_capacity(methods.len());
|
2016-01-04 04:26:12 +00:00
|
|
|
|
for method_name in methods.iter().rev() {
|
|
|
|
|
// method chains are stored last -> first
|
2015-12-27 22:15:09 +00:00
|
|
|
|
if let ExprMethodCall(ref name, _, ref args) = current.node {
|
2015-12-27 09:22:53 +00:00
|
|
|
|
if name.node.as_str() == *method_name {
|
2015-12-27 22:15:09 +00:00
|
|
|
|
matched.push(args); // build up `matched` backwards
|
|
|
|
|
current = &args[0] // go to parent expression
|
2016-01-04 04:26:12 +00:00
|
|
|
|
} else {
|
2015-12-27 22:15:09 +00:00
|
|
|
|
return None;
|
2015-12-27 09:22:53 +00:00
|
|
|
|
}
|
2016-01-04 04:26:12 +00:00
|
|
|
|
} else {
|
2015-12-27 22:15:09 +00:00
|
|
|
|
return None;
|
2015-12-27 09:22:53 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
2015-12-27 22:15:09 +00:00
|
|
|
|
matched.reverse(); // reverse `matched`, so that it is in the same order as `methods`
|
|
|
|
|
Some(matched)
|
2015-12-27 09:22:53 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Get the name of the item the expression is in, if available.
|
2015-09-19 02:53:04 +00:00
|
|
|
|
pub fn get_item_name(cx: &LateContext, expr: &Expr) -> Option<Name> {
|
2015-09-06 18:57:06 +00:00
|
|
|
|
let parent_id = cx.tcx.map.get_parent(expr.id);
|
|
|
|
|
match cx.tcx.map.find(parent_id) {
|
2016-04-14 18:14:03 +00:00
|
|
|
|
Some(Node::NodeItem(&Item { ref name, .. })) |
|
|
|
|
|
Some(Node::NodeTraitItem(&TraitItem { ref name, .. })) |
|
|
|
|
|
Some(Node::NodeImplItem(&ImplItem { ref name, .. })) => Some(*name),
|
2015-09-06 18:57:06 +00:00
|
|
|
|
_ => None,
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Checks if a `let` decl is from a `for` loop desugaring.
|
2015-10-11 21:12:21 +00:00
|
|
|
|
pub fn is_from_for_desugar(decl: &Decl) -> bool {
|
|
|
|
|
if_let_chain! {
|
|
|
|
|
[
|
|
|
|
|
let DeclLocal(ref loc) = decl.node,
|
|
|
|
|
let Some(ref expr) = loc.init,
|
2015-10-16 23:03:05 +00:00
|
|
|
|
let ExprMatch(_, _, MatchSource::ForLoopDesugar) = expr.node
|
2015-10-11 21:12:21 +00:00
|
|
|
|
],
|
|
|
|
|
{ return true; }
|
|
|
|
|
};
|
|
|
|
|
false
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Convert a span to a code snippet if available, otherwise use default.
|
|
|
|
|
///
|
|
|
|
|
/// # Example
|
|
|
|
|
/// ```
|
|
|
|
|
/// snippet(cx, expr.span, "..")
|
|
|
|
|
/// ```
|
2015-09-19 02:53:04 +00:00
|
|
|
|
pub fn snippet<'a, T: LintContext>(cx: &T, span: Span, default: &'a str) -> Cow<'a, str> {
|
2016-01-16 17:47:45 +00:00
|
|
|
|
cx.sess().codemap().span_to_snippet(span).map(From::from).unwrap_or_else(|_| Cow::Borrowed(default))
|
2015-08-11 13:07:21 +00:00
|
|
|
|
}
|
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Convert a span to a code snippet. Returns `None` if not available.
|
2015-12-08 06:03:01 +00:00
|
|
|
|
pub fn snippet_opt<T: LintContext>(cx: &T, span: Span) -> Option<String> {
|
|
|
|
|
cx.sess().codemap().span_to_snippet(span).ok()
|
|
|
|
|
}
|
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Convert a span (from a block) to a code snippet if available, otherwise use default.
|
|
|
|
|
/// This trims the code of indentation, except for the first line. Use it for blocks or block-like
|
|
|
|
|
/// things which need to be printed as such.
|
|
|
|
|
///
|
|
|
|
|
/// # Example
|
|
|
|
|
/// ```
|
|
|
|
|
/// snippet(cx, expr.span, "..")
|
|
|
|
|
/// ```
|
2015-09-19 02:53:04 +00:00
|
|
|
|
pub fn snippet_block<'a, T: LintContext>(cx: &T, span: Span, default: &'a str) -> Cow<'a, str> {
|
2015-08-12 11:14:14 +00:00
|
|
|
|
let snip = snippet(cx, span, default);
|
|
|
|
|
trim_multiline(snip, true)
|
|
|
|
|
}
|
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Like `snippet_block`, but add braces if the expr is not an `ExprBlock`.
|
|
|
|
|
/// Also takes an `Option<String>` which can be put inside the braces.
|
2016-01-04 04:26:12 +00:00
|
|
|
|
pub fn expr_block<'a, T: LintContext>(cx: &T, expr: &Expr, option: Option<String>, default: &'a str) -> Cow<'a, str> {
|
2015-08-29 09:41:06 +00:00
|
|
|
|
let code = snippet_block(cx, expr.span, default);
|
2016-01-12 22:17:54 +00:00
|
|
|
|
let string = option.unwrap_or_default();
|
2015-08-29 09:41:06 +00:00
|
|
|
|
if let ExprBlock(_) = expr.node {
|
2015-09-27 07:39:42 +00:00
|
|
|
|
Cow::Owned(format!("{}{}", code, string))
|
|
|
|
|
} else if string.is_empty() {
|
2015-08-29 09:41:06 +00:00
|
|
|
|
Cow::Owned(format!("{{ {} }}", code))
|
2015-09-27 07:39:42 +00:00
|
|
|
|
} else {
|
|
|
|
|
Cow::Owned(format!("{{\n{};\n{}\n}}", code, string))
|
2015-08-29 09:41:06 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Trim indentation from a multiline string with possibility of ignoring the first line.
|
2015-08-13 17:50:00 +00:00
|
|
|
|
pub fn trim_multiline(s: Cow<str>, ignore_first: bool) -> Cow<str> {
|
2015-08-21 15:11:34 +00:00
|
|
|
|
let s_space = trim_multiline_inner(s, ignore_first, ' ');
|
|
|
|
|
let s_tab = trim_multiline_inner(s_space, ignore_first, '\t');
|
|
|
|
|
trim_multiline_inner(s_tab, ignore_first, ' ')
|
2015-08-13 07:57:30 +00:00
|
|
|
|
}
|
|
|
|
|
|
2015-08-13 17:50:00 +00:00
|
|
|
|
fn trim_multiline_inner(s: Cow<str>, ignore_first: bool, ch: char) -> Cow<str> {
|
2016-01-04 04:26:12 +00:00
|
|
|
|
let x = s.lines()
|
|
|
|
|
.skip(ignore_first as usize)
|
|
|
|
|
.filter_map(|l| {
|
2016-03-12 20:23:35 +00:00
|
|
|
|
if l.is_empty() {
|
|
|
|
|
None
|
|
|
|
|
} else {
|
2016-01-04 04:26:12 +00:00
|
|
|
|
// ignore empty lines
|
|
|
|
|
Some(l.char_indices()
|
|
|
|
|
.find(|&(_, x)| x != ch)
|
|
|
|
|
.unwrap_or((l.len(), ch))
|
|
|
|
|
.0)
|
|
|
|
|
}
|
|
|
|
|
})
|
|
|
|
|
.min()
|
|
|
|
|
.unwrap_or(0);
|
2015-08-12 11:14:14 +00:00
|
|
|
|
if x > 0 {
|
2016-01-04 04:26:12 +00:00
|
|
|
|
Cow::Owned(s.lines()
|
|
|
|
|
.enumerate()
|
|
|
|
|
.map(|(i, l)| {
|
2016-03-12 20:23:35 +00:00
|
|
|
|
if (ignore_first && i == 0) || l.is_empty() {
|
2016-01-04 04:26:12 +00:00
|
|
|
|
l
|
|
|
|
|
} else {
|
|
|
|
|
l.split_at(x).1
|
|
|
|
|
}
|
|
|
|
|
})
|
|
|
|
|
.collect::<Vec<_>>()
|
|
|
|
|
.join("\n"))
|
2015-08-12 11:14:14 +00:00
|
|
|
|
} else {
|
|
|
|
|
s
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Get a parent expressions if any – this is useful to constrain a lint.
|
2015-09-19 02:53:04 +00:00
|
|
|
|
pub fn get_parent_expr<'c>(cx: &'c LateContext, e: &Expr) -> Option<&'c Expr> {
|
2015-08-11 13:07:21 +00:00
|
|
|
|
let map = &cx.tcx.map;
|
2016-01-04 04:26:12 +00:00
|
|
|
|
let node_id: NodeId = e.id;
|
|
|
|
|
let parent_id: NodeId = map.get_parent_node(node_id);
|
|
|
|
|
if node_id == parent_id {
|
|
|
|
|
return None;
|
|
|
|
|
}
|
|
|
|
|
map.find(parent_id).and_then(|node| {
|
2016-02-03 14:39:22 +00:00
|
|
|
|
if let Node::NodeExpr(parent) = node {
|
2016-01-04 04:26:12 +00:00
|
|
|
|
Some(parent)
|
|
|
|
|
} else {
|
|
|
|
|
None
|
|
|
|
|
}
|
|
|
|
|
})
|
2015-07-09 15:02:21 +00:00
|
|
|
|
}
|
2015-07-16 06:53:02 +00:00
|
|
|
|
|
2015-10-26 22:49:37 +00:00
|
|
|
|
pub fn get_enclosing_block<'c>(cx: &'c LateContext, node: NodeId) -> Option<&'c Block> {
|
|
|
|
|
let map = &cx.tcx.map;
|
|
|
|
|
let enclosing_node = map.get_enclosing_scope(node)
|
|
|
|
|
.and_then(|enclosing_id| map.find(enclosing_id));
|
|
|
|
|
if let Some(node) = enclosing_node {
|
|
|
|
|
match node {
|
2016-02-03 14:39:22 +00:00
|
|
|
|
Node::NodeBlock(ref block) => Some(block),
|
2016-04-14 18:14:03 +00:00
|
|
|
|
Node::NodeItem(&Item { node: ItemFn(_, _, _, _, _, ref block), .. }) => Some(block),
|
2016-01-04 04:26:12 +00:00
|
|
|
|
_ => None,
|
2015-10-26 22:49:37 +00:00
|
|
|
|
}
|
2016-01-04 04:26:12 +00:00
|
|
|
|
} else {
|
|
|
|
|
None
|
|
|
|
|
}
|
2015-10-26 22:49:37 +00:00
|
|
|
|
}
|
|
|
|
|
|
2015-12-31 20:39:03 +00:00
|
|
|
|
pub struct DiagnosticWrapper<'a>(pub DiagnosticBuilder<'a>);
|
|
|
|
|
|
|
|
|
|
impl<'a> Drop for DiagnosticWrapper<'a> {
|
|
|
|
|
fn drop(&mut self) {
|
|
|
|
|
self.0.emit();
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<'a> DerefMut for DiagnosticWrapper<'a> {
|
|
|
|
|
fn deref_mut(&mut self) -> &mut DiagnosticBuilder<'a> {
|
|
|
|
|
&mut self.0
|
2016-01-04 04:26:12 +00:00
|
|
|
|
}
|
2015-12-31 20:39:03 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<'a> Deref for DiagnosticWrapper<'a> {
|
|
|
|
|
type Target = DiagnosticBuilder<'a>;
|
|
|
|
|
fn deref(&self) -> &DiagnosticBuilder<'a> {
|
|
|
|
|
&self.0
|
2016-01-04 04:26:12 +00:00
|
|
|
|
}
|
2015-12-31 20:39:03 +00:00
|
|
|
|
}
|
|
|
|
|
|
2016-01-04 04:26:12 +00:00
|
|
|
|
pub fn span_lint<'a, T: LintContext>(cx: &'a T, lint: &'static Lint, sp: Span, msg: &str) -> DiagnosticWrapper<'a> {
|
2015-12-31 20:39:03 +00:00
|
|
|
|
let mut db = cx.struct_span_lint(lint, sp, msg);
|
2015-08-27 05:39:40 +00:00
|
|
|
|
if cx.current_level(lint) != Level::Allow {
|
2016-01-04 04:26:12 +00:00
|
|
|
|
db.fileline_help(sp,
|
|
|
|
|
&format!("for further information visit https://github.com/Manishearth/rust-clippy/wiki#{}",
|
|
|
|
|
lint.name_lower()));
|
2015-08-27 05:39:40 +00:00
|
|
|
|
}
|
2015-12-31 20:39:03 +00:00
|
|
|
|
DiagnosticWrapper(db)
|
2015-08-11 13:07:21 +00:00
|
|
|
|
}
|
|
|
|
|
|
2016-01-04 04:26:12 +00:00
|
|
|
|
pub fn span_help_and_lint<'a, T: LintContext>(cx: &'a T, lint: &'static Lint, span: Span, msg: &str, help: &str)
|
|
|
|
|
-> DiagnosticWrapper<'a> {
|
2015-12-31 20:39:03 +00:00
|
|
|
|
let mut db = cx.struct_span_lint(lint, span, msg);
|
2015-08-11 13:07:21 +00:00
|
|
|
|
if cx.current_level(lint) != Level::Allow {
|
2016-01-04 04:26:12 +00:00
|
|
|
|
db.fileline_help(span,
|
|
|
|
|
&format!("{}\nfor further information visit \
|
|
|
|
|
https://github.com/Manishearth/rust-clippy/wiki#{}",
|
|
|
|
|
help,
|
|
|
|
|
lint.name_lower()));
|
2015-08-11 13:07:21 +00:00
|
|
|
|
}
|
2015-12-31 20:39:03 +00:00
|
|
|
|
DiagnosticWrapper(db)
|
2015-07-26 14:53:11 +00:00
|
|
|
|
}
|
2015-08-11 18:57:21 +00:00
|
|
|
|
|
2016-01-04 04:26:12 +00:00
|
|
|
|
pub fn span_note_and_lint<'a, T: LintContext>(cx: &'a T, lint: &'static Lint, span: Span, msg: &str, note_span: Span,
|
|
|
|
|
note: &str)
|
|
|
|
|
-> DiagnosticWrapper<'a> {
|
2015-12-31 20:39:03 +00:00
|
|
|
|
let mut db = cx.struct_span_lint(lint, span, msg);
|
2015-09-02 06:19:47 +00:00
|
|
|
|
if cx.current_level(lint) != Level::Allow {
|
|
|
|
|
if note_span == span {
|
2015-12-31 20:39:03 +00:00
|
|
|
|
db.fileline_note(note_span, note);
|
2015-09-02 06:19:47 +00:00
|
|
|
|
} else {
|
2015-12-31 20:39:03 +00:00
|
|
|
|
db.span_note(note_span, note);
|
2015-09-02 06:19:47 +00:00
|
|
|
|
}
|
2016-01-04 04:26:12 +00:00
|
|
|
|
db.fileline_help(span,
|
|
|
|
|
&format!("for further information visit https://github.com/Manishearth/rust-clippy/wiki#{}",
|
|
|
|
|
lint.name_lower()));
|
2015-09-02 06:19:47 +00:00
|
|
|
|
}
|
2015-12-31 20:39:03 +00:00
|
|
|
|
DiagnosticWrapper(db)
|
2015-09-02 06:19:47 +00:00
|
|
|
|
}
|
|
|
|
|
|
2016-01-04 04:26:12 +00:00
|
|
|
|
pub fn span_lint_and_then<'a, T: LintContext, F>(cx: &'a T, lint: &'static Lint, sp: Span, msg: &str, f: F)
|
|
|
|
|
-> DiagnosticWrapper<'a>
|
2016-01-29 00:54:10 +00:00
|
|
|
|
where F: FnOnce(&mut DiagnosticWrapper)
|
2016-01-04 04:26:12 +00:00
|
|
|
|
{
|
2015-12-31 20:39:03 +00:00
|
|
|
|
let mut db = DiagnosticWrapper(cx.struct_span_lint(lint, sp, msg));
|
2015-12-08 16:28:35 +00:00
|
|
|
|
if cx.current_level(lint) != Level::Allow {
|
2015-12-31 20:39:03 +00:00
|
|
|
|
f(&mut db);
|
2016-01-04 04:26:12 +00:00
|
|
|
|
db.fileline_help(sp,
|
|
|
|
|
&format!("for further information visit https://github.com/Manishearth/rust-clippy/wiki#{}",
|
|
|
|
|
lint.name_lower()));
|
2015-12-08 16:28:35 +00:00
|
|
|
|
}
|
2015-12-31 20:39:03 +00:00
|
|
|
|
db
|
2015-12-08 16:28:35 +00:00
|
|
|
|
}
|
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Return the base type for references and raw pointers.
|
2015-08-13 14:28:11 +00:00
|
|
|
|
pub fn walk_ptrs_ty(ty: ty::Ty) -> ty::Ty {
|
2015-08-11 18:57:21 +00:00
|
|
|
|
match ty.sty {
|
2016-04-14 18:14:03 +00:00
|
|
|
|
ty::TyRef(_, ref tm) |
|
|
|
|
|
ty::TyRawPtr(ref tm) => walk_ptrs_ty(tm.ty),
|
2016-01-04 04:26:12 +00:00
|
|
|
|
_ => ty,
|
2015-08-11 18:57:21 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
2015-08-12 05:48:00 +00:00
|
|
|
|
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Return the base type for references and raw pointers, and count reference depth.
|
2015-08-25 16:38:08 +00:00
|
|
|
|
pub fn walk_ptrs_ty_depth(ty: ty::Ty) -> (ty::Ty, usize) {
|
|
|
|
|
fn inner(ty: ty::Ty, depth: usize) -> (ty::Ty, usize) {
|
|
|
|
|
match ty.sty {
|
2016-04-14 18:14:03 +00:00
|
|
|
|
ty::TyRef(_, ref tm) |
|
|
|
|
|
ty::TyRawPtr(ref tm) => inner(tm.ty, depth + 1),
|
2016-01-04 04:26:12 +00:00
|
|
|
|
_ => (ty, depth),
|
2015-08-25 16:38:08 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
inner(ty, 0)
|
|
|
|
|
}
|
|
|
|
|
|
2016-01-14 19:58:32 +00:00
|
|
|
|
/// Check whether the given expression is a constant literal of the given value.
|
2016-01-04 04:26:12 +00:00
|
|
|
|
pub fn is_integer_literal(expr: &Expr, value: u64) -> bool {
|
2015-09-04 13:26:58 +00:00
|
|
|
|
// FIXME: use constant folding
|
|
|
|
|
if let ExprLit(ref spanned) = expr.node {
|
2016-02-12 17:35:44 +00:00
|
|
|
|
if let LitKind::Int(v, _) = spanned.node {
|
2015-09-04 13:26:58 +00:00
|
|
|
|
return v == value;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
false
|
|
|
|
|
}
|
|
|
|
|
|
2015-11-04 03:11:40 +00:00
|
|
|
|
pub fn is_adjusted(cx: &LateContext, e: &Expr) -> bool {
|
|
|
|
|
cx.tcx.tables.borrow().adjustments.get(&e.id).is_some()
|
|
|
|
|
}
|
|
|
|
|
|
2015-11-18 11:35:18 +00:00
|
|
|
|
pub struct LimitStack {
|
|
|
|
|
stack: Vec<u64>,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl Drop for LimitStack {
|
|
|
|
|
fn drop(&mut self) {
|
|
|
|
|
assert_eq!(self.stack.len(), 1);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl LimitStack {
|
|
|
|
|
pub fn new(limit: u64) -> LimitStack {
|
2016-01-04 04:26:12 +00:00
|
|
|
|
LimitStack { stack: vec![limit] }
|
2015-11-18 11:35:18 +00:00
|
|
|
|
}
|
|
|
|
|
pub fn limit(&self) -> u64 {
|
|
|
|
|
*self.stack.last().expect("there should always be a value in the stack")
|
|
|
|
|
}
|
|
|
|
|
pub fn push_attrs(&mut self, sess: &Session, attrs: &[ast::Attribute], name: &'static str) {
|
|
|
|
|
let stack = &mut self.stack;
|
2016-01-04 04:26:12 +00:00
|
|
|
|
parse_attrs(sess, attrs, name, |val| stack.push(val));
|
2015-11-18 11:35:18 +00:00
|
|
|
|
}
|
|
|
|
|
pub fn pop_attrs(&mut self, sess: &Session, attrs: &[ast::Attribute], name: &'static str) {
|
|
|
|
|
let stack = &mut self.stack;
|
2016-01-04 04:26:12 +00:00
|
|
|
|
parse_attrs(sess, attrs, name, |val| assert_eq!(stack.pop(), Some(val)));
|
2015-11-18 11:35:18 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn parse_attrs<F: FnMut(u64)>(sess: &Session, attrs: &[ast::Attribute], name: &'static str, mut f: F) {
|
|
|
|
|
for attr in attrs {
|
|
|
|
|
let attr = &attr.node;
|
2016-01-04 04:26:12 +00:00
|
|
|
|
if attr.is_sugared_doc {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
2016-02-12 17:35:44 +00:00
|
|
|
|
if let ast::MetaItemKind::NameValue(ref key, ref value) = attr.value.node {
|
2015-11-18 11:35:18 +00:00
|
|
|
|
if *key == name {
|
2016-02-12 17:35:44 +00:00
|
|
|
|
if let LitKind::Str(ref s, _) = value.node {
|
2015-11-18 11:35:18 +00:00
|
|
|
|
if let Ok(value) = FromStr::from_str(s) {
|
|
|
|
|
f(value)
|
|
|
|
|
} else {
|
|
|
|
|
sess.span_err(value.span, "not a number");
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
unreachable!()
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2016-01-03 14:49:25 +00:00
|
|
|
|
|
2016-01-29 21:19:14 +00:00
|
|
|
|
/// Return the pre-expansion span if is this comes from an expansion of the macro `name`.
|
2016-03-15 20:02:08 +00:00
|
|
|
|
/// See also `is_direct_expn_of`.
|
2016-01-28 18:29:59 +00:00
|
|
|
|
pub fn is_expn_of(cx: &LateContext, mut span: Span, name: &str) -> Option<Span> {
|
|
|
|
|
loop {
|
2016-02-29 11:19:32 +00:00
|
|
|
|
let span_name_span = cx.tcx
|
|
|
|
|
.sess
|
|
|
|
|
.codemap()
|
|
|
|
|
.with_expn_info(span.expn_id, |expn| expn.map(|ei| (ei.callee.name(), ei.call_site)));
|
2016-01-30 12:48:39 +00:00
|
|
|
|
|
2016-02-01 10:28:39 +00:00
|
|
|
|
match span_name_span {
|
|
|
|
|
Some((mac_name, new_span)) if mac_name.as_str() == name => return Some(new_span),
|
|
|
|
|
None => return None,
|
|
|
|
|
Some((_, new_span)) => span = new_span,
|
|
|
|
|
}
|
2016-01-28 18:29:59 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
2016-02-15 15:59:56 +00:00
|
|
|
|
|
2016-03-15 20:02:08 +00:00
|
|
|
|
/// Return the pre-expansion span if is this directly comes from an expansion of the macro `name`.
|
|
|
|
|
/// The difference with `is_expn_of` is that in
|
|
|
|
|
/// ```rust,ignore
|
|
|
|
|
/// foo!(bar!(42));
|
|
|
|
|
/// ```
|
|
|
|
|
/// `42` is considered expanded from `foo!` and `bar!` by `is_expn_of` but only `bar!` by
|
|
|
|
|
/// `is_direct_expn_of`.
|
|
|
|
|
pub fn is_direct_expn_of(cx: &LateContext, span: Span, name: &str) -> Option<Span> {
|
|
|
|
|
let span_name_span = cx.tcx
|
|
|
|
|
.sess
|
|
|
|
|
.codemap()
|
|
|
|
|
.with_expn_info(span.expn_id, |expn| expn.map(|ei| (ei.callee.name(), ei.call_site)));
|
|
|
|
|
|
|
|
|
|
match span_name_span {
|
|
|
|
|
Some((mac_name, new_span)) if mac_name.as_str() == name => Some(new_span),
|
|
|
|
|
_ => None,
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-19 16:48:29 +00:00
|
|
|
|
/// Return the index of the character after the first camel-case component of `s`.
|
2016-02-15 15:59:56 +00:00
|
|
|
|
pub fn camel_case_until(s: &str) -> usize {
|
|
|
|
|
let mut iter = s.char_indices();
|
|
|
|
|
if let Some((_, first)) = iter.next() {
|
|
|
|
|
if !first.is_uppercase() {
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
let mut up = true;
|
|
|
|
|
let mut last_i = 0;
|
|
|
|
|
for (i, c) in iter {
|
|
|
|
|
if up {
|
|
|
|
|
if c.is_lowercase() {
|
|
|
|
|
up = false;
|
|
|
|
|
} else {
|
|
|
|
|
return last_i;
|
|
|
|
|
}
|
|
|
|
|
} else if c.is_uppercase() {
|
|
|
|
|
up = true;
|
|
|
|
|
last_i = i;
|
|
|
|
|
} else if !c.is_lowercase() {
|
|
|
|
|
return i;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if up {
|
|
|
|
|
last_i
|
|
|
|
|
} else {
|
|
|
|
|
s.len()
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-19 16:48:29 +00:00
|
|
|
|
/// Return index of the last camel-case component of `s`.
|
2016-02-15 15:59:56 +00:00
|
|
|
|
pub fn camel_case_from(s: &str) -> usize {
|
|
|
|
|
let mut iter = s.char_indices().rev();
|
|
|
|
|
if let Some((_, first)) = iter.next() {
|
|
|
|
|
if !first.is_lowercase() {
|
|
|
|
|
return s.len();
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
return s.len();
|
|
|
|
|
}
|
|
|
|
|
let mut down = true;
|
|
|
|
|
let mut last_i = s.len();
|
|
|
|
|
for (i, c) in iter {
|
|
|
|
|
if down {
|
|
|
|
|
if c.is_uppercase() {
|
|
|
|
|
down = false;
|
|
|
|
|
last_i = i;
|
|
|
|
|
} else if !c.is_lowercase() {
|
|
|
|
|
return last_i;
|
|
|
|
|
}
|
|
|
|
|
} else if c.is_lowercase() {
|
|
|
|
|
down = true;
|
|
|
|
|
} else {
|
|
|
|
|
return last_i;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
last_i
|
|
|
|
|
}
|
2016-03-07 15:31:38 +00:00
|
|
|
|
|
2016-03-19 16:48:29 +00:00
|
|
|
|
/// Represent a range akin to `ast::ExprKind::Range`.
|
2016-03-11 19:27:33 +00:00
|
|
|
|
#[derive(Debug, Copy, Clone)]
|
2016-03-07 15:31:38 +00:00
|
|
|
|
pub struct UnsugaredRange<'a> {
|
|
|
|
|
pub start: Option<&'a Expr>,
|
|
|
|
|
pub end: Option<&'a Expr>,
|
|
|
|
|
pub limits: RangeLimits,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Unsugar a `hir` range.
|
|
|
|
|
pub fn unsugar_range(expr: &Expr) -> Option<UnsugaredRange> {
|
|
|
|
|
// To be removed when ranges get stable.
|
|
|
|
|
fn unwrap_unstable(expr: &Expr) -> &Expr {
|
|
|
|
|
if let ExprBlock(ref block) = expr.node {
|
|
|
|
|
if block.rules == BlockCheckMode::PushUnstableBlock || block.rules == BlockCheckMode::PopUnstableBlock {
|
|
|
|
|
if let Some(ref expr) = block.expr {
|
|
|
|
|
return expr;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
expr
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn get_field<'a>(name: &str, fields: &'a [Field]) -> Option<&'a Expr> {
|
|
|
|
|
let expr = &fields.iter()
|
|
|
|
|
.find(|field| field.name.node.as_str() == name)
|
|
|
|
|
.unwrap_or_else(|| panic!("missing {} field for range", name))
|
|
|
|
|
.expr;
|
|
|
|
|
|
|
|
|
|
Some(unwrap_unstable(expr))
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-11 19:27:33 +00:00
|
|
|
|
match unwrap_unstable(&expr).node {
|
|
|
|
|
ExprPath(None, ref path) => {
|
2016-04-14 16:13:15 +00:00
|
|
|
|
if match_path(path, &paths::RANGE_FULL) {
|
2016-04-14 18:14:03 +00:00
|
|
|
|
Some(UnsugaredRange {
|
|
|
|
|
start: None,
|
|
|
|
|
end: None,
|
|
|
|
|
limits: RangeLimits::HalfOpen,
|
|
|
|
|
})
|
2016-03-11 19:27:33 +00:00
|
|
|
|
} else {
|
|
|
|
|
None
|
|
|
|
|
}
|
2016-03-07 15:31:38 +00:00
|
|
|
|
}
|
2016-03-11 19:27:33 +00:00
|
|
|
|
ExprStruct(ref path, ref fields, None) => {
|
2016-04-14 16:13:15 +00:00
|
|
|
|
if match_path(path, &paths::RANGE_FROM) {
|
2016-04-14 18:14:03 +00:00
|
|
|
|
Some(UnsugaredRange {
|
|
|
|
|
start: get_field("start", fields),
|
|
|
|
|
end: None,
|
|
|
|
|
limits: RangeLimits::HalfOpen,
|
|
|
|
|
})
|
2016-04-14 16:13:15 +00:00
|
|
|
|
} else if match_path(path, &paths::RANGE_INCLUSIVE_NON_EMPTY) {
|
2016-04-14 18:14:03 +00:00
|
|
|
|
Some(UnsugaredRange {
|
|
|
|
|
start: get_field("start", fields),
|
|
|
|
|
end: get_field("end", fields),
|
|
|
|
|
limits: RangeLimits::Closed,
|
|
|
|
|
})
|
2016-04-14 16:13:15 +00:00
|
|
|
|
} else if match_path(path, &paths::RANGE) {
|
2016-04-14 18:14:03 +00:00
|
|
|
|
Some(UnsugaredRange {
|
|
|
|
|
start: get_field("start", fields),
|
|
|
|
|
end: get_field("end", fields),
|
|
|
|
|
limits: RangeLimits::HalfOpen,
|
|
|
|
|
})
|
2016-04-14 16:13:15 +00:00
|
|
|
|
} else if match_path(path, &paths::RANGE_TO_INCLUSIVE) {
|
2016-04-14 18:14:03 +00:00
|
|
|
|
Some(UnsugaredRange {
|
|
|
|
|
start: None,
|
|
|
|
|
end: get_field("end", fields),
|
|
|
|
|
limits: RangeLimits::Closed,
|
|
|
|
|
})
|
2016-04-14 16:13:15 +00:00
|
|
|
|
} else if match_path(path, &paths::RANGE_TO) {
|
2016-04-14 18:14:03 +00:00
|
|
|
|
Some(UnsugaredRange {
|
|
|
|
|
start: None,
|
|
|
|
|
end: get_field("end", fields),
|
|
|
|
|
limits: RangeLimits::HalfOpen,
|
|
|
|
|
})
|
2016-03-11 19:27:33 +00:00
|
|
|
|
} else {
|
|
|
|
|
None
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
_ => None,
|
2016-03-07 15:31:38 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
2016-03-01 15:25:15 +00:00
|
|
|
|
|
2016-03-01 19:38:21 +00:00
|
|
|
|
/// Convenience function to get the return type of a function or `None` if the function diverges.
|
2016-03-26 21:14:25 +00:00
|
|
|
|
pub fn return_ty<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, fn_item: NodeId) -> Option<ty::Ty<'tcx>> {
|
|
|
|
|
let parameter_env = ty::ParameterEnvironment::for_item(cx.tcx, fn_item);
|
2016-03-26 23:27:25 +00:00
|
|
|
|
let fn_sig = cx.tcx.node_id_to_type(fn_item).fn_sig().subst(cx.tcx, ¶meter_env.free_substs);
|
|
|
|
|
let fn_sig = cx.tcx.liberate_late_bound_regions(parameter_env.free_id_outlive, &fn_sig);
|
2016-03-26 21:14:25 +00:00
|
|
|
|
if let ty::FnConverging(ret_ty) = fn_sig.output {
|
2016-03-01 19:38:21 +00:00
|
|
|
|
Some(ret_ty)
|
2016-03-01 15:25:15 +00:00
|
|
|
|
} else {
|
2016-03-01 19:38:21 +00:00
|
|
|
|
None
|
2016-03-01 15:25:15 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
2016-03-03 18:46:10 +00:00
|
|
|
|
|
|
|
|
|
/// Check if two types are the same.
|
|
|
|
|
// FIXME: this works correctly for lifetimes bounds (`for <'a> Foo<'a>` == `for <'b> Foo<'b>` but
|
|
|
|
|
// not for type parameters.
|
2016-03-26 21:14:25 +00:00
|
|
|
|
pub fn same_tys<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, a: ty::Ty<'tcx>, b: ty::Ty<'tcx>, parameter_item: NodeId) -> bool {
|
|
|
|
|
let parameter_env = ty::ParameterEnvironment::for_item(cx.tcx, parameter_item);
|
|
|
|
|
let infcx = infer::new_infer_ctxt(cx.tcx, &cx.tcx.tables, Some(parameter_env), ProjectionMode::Any);
|
|
|
|
|
let new_a = a.subst(infcx.tcx, &infcx.parameter_environment.free_substs);
|
|
|
|
|
let new_b = b.subst(infcx.tcx, &infcx.parameter_environment.free_substs);
|
|
|
|
|
infcx.can_equate(&new_a, &new_b).is_ok()
|
2016-03-03 18:46:10 +00:00
|
|
|
|
}
|
2016-03-28 21:32:55 +00:00
|
|
|
|
|
|
|
|
|
/// Recover the essential nodes of a desugared for loop:
|
|
|
|
|
/// `for pat in arg { body }` becomes `(pat, arg, body)`.
|
|
|
|
|
pub fn recover_for_loop(expr: &Expr) -> Option<(&Pat, &Expr, &Expr)> {
|
|
|
|
|
if_let_chain! {
|
|
|
|
|
[
|
|
|
|
|
let ExprMatch(ref iterexpr, ref arms, _) = expr.node,
|
|
|
|
|
let ExprCall(_, ref iterargs) = iterexpr.node,
|
|
|
|
|
iterargs.len() == 1 && arms.len() == 1 && arms[0].guard.is_none(),
|
|
|
|
|
let ExprLoop(ref block, _) = arms[0].body.node,
|
|
|
|
|
block.stmts.is_empty(),
|
|
|
|
|
let Some(ref loopexpr) = block.expr,
|
|
|
|
|
let ExprMatch(_, ref innerarms, MatchSource::ForLoopDesugar) = loopexpr.node,
|
|
|
|
|
innerarms.len() == 2 && innerarms[0].pats.len() == 1,
|
|
|
|
|
let PatKind::TupleStruct(_, Some(ref somepats)) = innerarms[0].pats[0].node,
|
|
|
|
|
somepats.len() == 1
|
|
|
|
|
], {
|
|
|
|
|
return Some((&somepats[0],
|
|
|
|
|
&iterargs[0],
|
|
|
|
|
&innerarms[0].body));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
None
|
|
|
|
|
}
|