rust-clippy/clippy_lints/src/utils/conf.rs

247 lines
10 KiB
Rust
Raw Normal View History

//! Read configurations files.
2018-08-01 20:48:41 +00:00
#![deny(clippy::missing_docs_in_private_items)]
2019-05-14 08:06:21 +00:00
use lazy_static::lazy_static;
2020-03-01 03:23:33 +00:00
use rustc_ast::ast::{LitKind, MetaItemKind, NestedMetaItem};
use rustc_span::source_map;
use source_map::Span;
use std::path::{Path, PathBuf};
2017-05-09 13:23:38 +00:00
use std::sync::Mutex;
use std::{env, fmt, fs, io};
2018-07-19 07:11:15 +00:00
2019-01-31 01:15:29 +00:00
/// Gets the configuration file from arguments.
pub fn file_from_args(args: &[NestedMetaItem]) -> Result<Option<PathBuf>, (&'static str, Span)> {
for arg in args.iter().filter_map(NestedMetaItem::meta_item) {
2019-05-17 21:53:54 +00:00
if arg.check_name(sym!(conf_file)) {
2019-09-27 15:16:06 +00:00
return match arg.kind {
MetaItemKind::Word | MetaItemKind::List(_) => Err(("`conf_file` must be a named value", arg.span)),
MetaItemKind::NameValue(ref value) => {
if let LitKind::Str(ref file, _) = value.kind {
2018-11-27 20:14:15 +00:00
Ok(Some(file.to_string().into()))
} else {
Err(("`conf_file` value must be a string", value.span))
}
2016-12-20 17:21:30 +00:00
},
};
}
}
Ok(None)
}
/// Error from reading a configuration file.
#[derive(Debug)]
2016-06-10 14:17:20 +00:00
pub enum Error {
/// An I/O error.
2016-06-10 14:23:17 +00:00
Io(io::Error),
/// Not valid toml or doesn't fit the expected config format
2017-05-09 13:23:38 +00:00
Toml(String),
}
2016-06-10 14:17:20 +00:00
impl fmt::Display for Error {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
Self::Io(err) => err.fmt(f),
Self::Toml(err) => err.fmt(f),
}
}
}
2016-06-10 14:17:20 +00:00
impl From<io::Error> for Error {
fn from(e: io::Error) -> Self {
Self::Io(e)
}
}
2017-05-09 13:23:38 +00:00
lazy_static! {
static ref ERRORS: Mutex<Vec<Error>> = Mutex::new(Vec::new());
}
2017-05-09 13:23:38 +00:00
macro_rules! define_Conf {
($(#[$doc:meta] ($config:ident, $config_str:literal: $Ty:ty, $default:expr),)+) => {
2017-05-09 13:23:38 +00:00
mod helpers {
use serde::Deserialize;
2017-05-09 13:23:38 +00:00
/// Type used to store lint configuration.
#[derive(Deserialize)]
#[serde(rename_all = "kebab-case", deny_unknown_fields)]
2017-05-09 13:23:38 +00:00
pub struct Conf {
$(
#[$doc]
#[serde(default = $config_str)]
#[serde(with = $config_str)]
pub $config: $Ty,
)+
2017-05-09 13:23:38 +00:00
#[allow(dead_code)]
#[serde(default)]
third_party: Option<::toml::Value>,
}
2017-05-09 13:23:38 +00:00
$(
mod $config {
2017-05-09 13:23:38 +00:00
use serde::Deserialize;
2020-03-23 16:06:15 +00:00
pub fn deserialize<'de, D: serde::Deserializer<'de>>(deserializer: D) -> Result<$Ty, D::Error> {
use super::super::{ERRORS, Error};
Ok(
<$Ty>::deserialize(deserializer).unwrap_or_else(|e| {
ERRORS
.lock()
.expect("no threading here")
.push(Error::Toml(e.to_string()));
super::$config()
})
)
}
}
#[must_use]
fn $config() -> $Ty {
let x = $default;
x
2017-05-09 13:23:38 +00:00
}
)+
}
};
2016-02-22 13:25:51 +00:00
}
pub use self::helpers::Conf;
define_Conf! {
/// Lint: BLACKLISTED_NAME. The list of blacklisted names to lint about. NB: `bar` is not here since it has legitimate uses
(blacklisted_names, "blacklisted_names": Vec<String>, ["foo", "baz", "quux"].iter().map(ToString::to_string).collect()),
/// Lint: COGNITIVE_COMPLEXITY. The maximum cognitive complexity a function can have
(cognitive_complexity_threshold, "cognitive_complexity_threshold": u64, 25),
/// DEPRECATED LINT: CYCLOMATIC_COMPLEXITY. Use the Cognitive Complexity lint instead.
(cyclomatic_complexity_threshold, "cyclomatic_complexity_threshold": Option<u64>, None),
/// Lint: DOC_MARKDOWN. The list of words this lint should not consider as identifiers needing ticks
(doc_valid_idents, "doc_valid_idents": Vec<String>, [
2017-05-06 19:31:54 +00:00
"KiB", "MiB", "GiB", "TiB", "PiB", "EiB",
2016-12-21 11:30:41 +00:00
"DirectX",
"ECMAScript",
2016-12-21 11:30:41 +00:00
"GPLv2", "GPLv3",
"GitHub", "GitLab",
2016-12-21 11:30:41 +00:00
"IPv4", "IPv6",
"ClojureScript", "CoffeeScript", "JavaScript", "PureScript", "TypeScript",
"NaN", "NaNs",
2016-12-21 11:30:41 +00:00
"OAuth",
"OCaml",
"OpenGL", "OpenMP", "OpenSSH", "OpenSSL", "OpenStreetMap",
"TensorFlow",
2016-12-21 11:30:41 +00:00
"TrueType",
"iOS", "macOS",
"TeX", "LaTeX", "BibTeX", "BibLaTeX",
2017-04-25 09:38:37 +00:00
"MinGW",
2018-12-11 18:37:43 +00:00
"CamelCase",
].iter().map(ToString::to_string).collect()),
2016-02-22 13:25:51 +00:00
/// Lint: TOO_MANY_ARGUMENTS. The maximum number of argument a function or method can have
(too_many_arguments_threshold, "too_many_arguments_threshold": u64, 7),
2016-02-22 13:25:51 +00:00
/// Lint: TYPE_COMPLEXITY. The maximum complexity a type can have
(type_complexity_threshold, "type_complexity_threshold": u64, 250),
/// Lint: MANY_SINGLE_CHAR_NAMES. The maximum number of single char bindings a scope may have
(single_char_binding_names_threshold, "single_char_binding_names_threshold": u64, 4),
2016-07-10 13:23:50 +00:00
/// Lint: BOXED_LOCAL. The maximum size of objects (in bytes) that will be linted. Larger objects are ok on the heap
(too_large_for_stack, "too_large_for_stack": u64, 200),
/// Lint: ENUM_VARIANT_NAMES. The minimum number of enum variants for the lints about variant names to trigger
(enum_variant_name_threshold, "enum_variant_name_threshold": u64, 3),
2018-12-07 11:24:59 +00:00
/// Lint: LARGE_ENUM_VARIANT. The maximum size of a enum's variant to avoid box suggestion
(enum_variant_size_threshold, "enum_variant_size_threshold": u64, 200),
/// Lint: VERBOSE_BIT_MASK. The maximum allowed size of a bit mask before suggesting to use 'trailing_zeros'
(verbose_bit_mask_threshold, "verbose_bit_mask_threshold": u64, 1),
2018-01-23 14:29:31 +00:00
/// Lint: DECIMAL_LITERAL_REPRESENTATION. The lower bound for linting decimal literals
(literal_representation_threshold, "literal_representation_threshold": u64, 16384),
/// Lint: TRIVIALLY_COPY_PASS_BY_REF. The maximum size (in bytes) to consider a `Copy` type for passing by value instead of by reference.
(trivial_copy_size_limit, "trivial_copy_size_limit": Option<u64>, None),
2019-01-13 15:19:02 +00:00
/// Lint: TOO_MANY_LINES. The maximum number of lines a function or method can have
(too_many_lines_threshold, "too_many_lines_threshold": u64, 100),
2020-03-23 21:07:46 +00:00
/// Lint: LARGE_STACK_ARRAYS, LARGE_CONST_ARRAYS. The maximum allowed size for arrays on the stack
(array_size_threshold, "array_size_threshold": u64, 512_000),
2020-01-23 14:52:41 +00:00
/// Lint: VEC_BOX. The size of the boxed type in bytes, where boxing in a `Vec` is allowed
(vec_box_size_threshold, "vec_box_size_threshold": u64, 4096),
/// Lint: TYPE_REPETITION_IN_BOUNDS. The maximum number of bounds a trait can have to be linted
(max_trait_bounds, "max_trait_bounds": u64, 3),
2020-02-01 23:49:52 +00:00
/// Lint: STRUCT_EXCESSIVE_BOOLS. The maximum number of bools a struct can have
(max_struct_bools, "max_struct_bools": u64, 3),
/// Lint: FN_PARAMS_EXCESSIVE_BOOLS. The maximum number of bools function parameters can have
(max_fn_params_bools, "max_fn_params_bools": u64, 3),
/// Lint: WILDCARD_IMPORTS. Whether to allow certain wildcard imports (prelude, super in tests).
(warn_on_all_wildcard_imports, "warn_on_all_wildcard_imports": bool, false),
}
impl Default for Conf {
#[must_use]
fn default() -> Self {
toml::from_str("").expect("we never error on empty config files")
}
}
2016-10-25 17:41:24 +00:00
/// Search for the configuration file.
pub fn lookup_conf_file() -> io::Result<Option<PathBuf>> {
2016-10-25 17:41:24 +00:00
/// Possible filename to search for.
const CONFIG_FILE_NAMES: [&str; 2] = [".clippy.toml", "clippy.toml"];
2016-10-25 17:41:24 +00:00
// Start looking for a config file in CLIPPY_CONF_DIR, or failing that, CARGO_MANIFEST_DIR.
// If neither of those exist, use ".".
let mut current = env::var_os("CLIPPY_CONF_DIR")
.or_else(|| env::var_os("CARGO_MANIFEST_DIR"))
.map_or_else(|| PathBuf::from("."), PathBuf::from);
2016-10-25 17:41:24 +00:00
loop {
for config_file_name in &CONFIG_FILE_NAMES {
let config_file = current.join(config_file_name);
match fs::metadata(&config_file) {
// Only return if it's a file to handle the unlikely situation of a directory named
// `clippy.toml`.
Ok(ref md) if !md.is_dir() => return Ok(Some(config_file)),
2016-10-25 17:41:24 +00:00
// Return the error if it's something other than `NotFound`; otherwise we didn't
// find the project file yet, and continue searching.
Err(e) if e.kind() != io::ErrorKind::NotFound => return Err(e),
_ => {},
2016-10-25 17:41:24 +00:00
}
}
// If the current directory has no parent, we're done searching.
if !current.pop() {
return Ok(None);
}
}
}
2017-05-09 14:02:48 +00:00
/// Produces a `Conf` filled with the default values and forwards the errors
///
/// Used internally for convenience
2017-05-09 13:23:38 +00:00
fn default(errors: Vec<Error>) -> (Conf, Vec<Error>) {
(Conf::default(), errors)
2017-05-09 13:23:38 +00:00
}
2016-10-25 17:41:24 +00:00
/// Read the `toml` configuration file.
///
2016-03-06 14:48:56 +00:00
/// In case of error, the function tries to continue as much as possible.
pub fn read(path: &Path) -> (Conf, Vec<Error>) {
let content = match fs::read_to_string(path) {
Ok(content) => content,
2017-05-09 13:23:38 +00:00
Err(err) => return default(vec![err.into()]),
};
2018-11-27 20:14:15 +00:00
assert!(ERRORS.lock().expect("no threading -> mutex always safe").is_empty());
match toml::from_str(&content) {
Ok(toml) => {
let mut errors = ERRORS.lock().expect("no threading -> mutex always safe").split_off(0);
let toml_ref: &Conf = &toml;
let cyc_field: Option<u64> = toml_ref.cyclomatic_complexity_threshold;
if cyc_field.is_some() {
let cyc_err = "found deprecated field `cyclomatic-complexity-threshold`. Please use `cognitive-complexity-threshold` instead.".to_string();
errors.push(Error::Toml(cyc_err));
}
(toml, errors)
},
2017-05-09 13:23:38 +00:00
Err(e) => {
2018-11-27 20:14:15 +00:00
let mut errors = ERRORS.lock().expect("no threading -> mutex always safe").split_off(0);
2017-05-09 13:23:38 +00:00
errors.push(Error::Toml(e.to_string()));
2017-05-09 13:23:38 +00:00
default(errors)
},
}
}