2016-08-23 17:39:36 +00:00
|
|
|
//! Read configurations files.
|
|
|
|
|
2018-08-01 20:48:41 +00:00
|
|
|
#![deny(clippy::missing_docs_in_private_items)]
|
2016-08-23 17:39:36 +00:00
|
|
|
|
2019-05-14 08:06:21 +00:00
|
|
|
use lazy_static::lazy_static;
|
2020-01-04 10:00:00 +00:00
|
|
|
use rustc_span::source_map;
|
2020-02-05 02:06:34 +00:00
|
|
|
use source_map::Span;
|
|
|
|
use std::path::{Path, PathBuf};
|
2017-05-09 13:23:38 +00:00
|
|
|
use std::sync::Mutex;
|
2020-02-05 02:06:34 +00:00
|
|
|
use std::{env, fmt, fs, io};
|
|
|
|
use syntax::ast::{LitKind, MetaItemKind, NestedMetaItem};
|
2018-07-19 07:11:15 +00:00
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
/// Gets the configuration file from arguments.
|
2020-02-05 02:06:34 +00:00
|
|
|
pub fn file_from_args(args: &[NestedMetaItem]) -> Result<Option<PathBuf>, (&'static str, Span)> {
|
|
|
|
for arg in args.iter().filter_map(NestedMetaItem::meta_item) {
|
2019-05-17 21:53:54 +00:00
|
|
|
if arg.check_name(sym!(conf_file)) {
|
2019-09-27 15:16:06 +00:00
|
|
|
return match arg.kind {
|
2020-02-05 02:06:34 +00:00
|
|
|
MetaItemKind::Word | MetaItemKind::List(_) => Err(("`conf_file` must be a named value", arg.span)),
|
|
|
|
MetaItemKind::NameValue(ref value) => {
|
|
|
|
if let LitKind::Str(ref file, _) = value.kind {
|
2018-11-27 20:14:15 +00:00
|
|
|
Ok(Some(file.to_string().into()))
|
|
|
|
} else {
|
|
|
|
Err(("`conf_file` value must be a string", value.span))
|
|
|
|
}
|
2016-12-20 17:21:30 +00:00
|
|
|
},
|
2016-11-23 20:19:03 +00:00
|
|
|
};
|
2016-02-21 19:11:32 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
Ok(None)
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Error from reading a configuration file.
|
|
|
|
#[derive(Debug)]
|
2016-06-10 14:17:20 +00:00
|
|
|
pub enum Error {
|
2016-08-23 17:39:36 +00:00
|
|
|
/// An I/O error.
|
2016-06-10 14:23:17 +00:00
|
|
|
Io(io::Error),
|
2020-02-05 02:06:34 +00:00
|
|
|
/// Not valid toml or doesn't fit the expected config format
|
2017-05-09 13:23:38 +00:00
|
|
|
Toml(String),
|
2016-02-21 19:11:32 +00:00
|
|
|
}
|
|
|
|
|
2016-06-10 14:17:20 +00:00
|
|
|
impl fmt::Display for Error {
|
2020-02-05 02:06:34 +00:00
|
|
|
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
|
|
|
match self {
|
|
|
|
Self::Io(err) => err.fmt(f),
|
|
|
|
Self::Toml(err) => err.fmt(f),
|
2016-02-21 19:11:32 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-06-10 14:17:20 +00:00
|
|
|
impl From<io::Error> for Error {
|
2016-02-21 19:11:32 +00:00
|
|
|
fn from(e: io::Error) -> Self {
|
2019-07-31 00:25:35 +00:00
|
|
|
Self::Io(e)
|
2016-02-21 19:11:32 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-05-09 13:23:38 +00:00
|
|
|
lazy_static! {
|
|
|
|
static ref ERRORS: Mutex<Vec<Error>> = Mutex::new(Vec::new());
|
|
|
|
}
|
2016-02-21 19:11:32 +00:00
|
|
|
|
2017-05-09 13:23:38 +00:00
|
|
|
macro_rules! define_Conf {
|
2020-02-05 02:06:34 +00:00
|
|
|
($(#[$doc:meta] ($config:ident, $config_str:literal: $Ty:ty, $default:expr),)+) => {
|
2017-05-09 13:23:38 +00:00
|
|
|
mod helpers {
|
2019-05-09 17:05:34 +00:00
|
|
|
use serde::Deserialize;
|
2017-05-09 13:23:38 +00:00
|
|
|
/// Type used to store lint configuration.
|
2018-09-03 21:12:50 +00:00
|
|
|
#[derive(Deserialize)]
|
2020-02-05 02:06:34 +00:00
|
|
|
#[serde(rename_all = "kebab-case", deny_unknown_fields)]
|
2017-05-09 13:23:38 +00:00
|
|
|
pub struct Conf {
|
2020-02-05 02:06:34 +00:00
|
|
|
$(
|
|
|
|
#[$doc]
|
|
|
|
#[serde(default = $config_str)]
|
|
|
|
#[serde(with = $config_str)]
|
|
|
|
pub $config: $Ty,
|
|
|
|
)+
|
2017-05-09 13:23:38 +00:00
|
|
|
#[allow(dead_code)]
|
|
|
|
#[serde(default)]
|
|
|
|
third_party: Option<::toml::Value>,
|
2016-02-21 19:11:32 +00:00
|
|
|
}
|
2020-02-05 02:06:34 +00:00
|
|
|
|
2017-05-09 13:23:38 +00:00
|
|
|
$(
|
2020-02-05 02:06:34 +00:00
|
|
|
mod $config {
|
2017-05-09 13:23:38 +00:00
|
|
|
use serde::Deserialize;
|
2020-02-05 02:06:34 +00:00
|
|
|
crate fn deserialize<'de, D: serde::Deserializer<'de>>(deserializer: D) -> Result<$Ty, D::Error> {
|
|
|
|
use super::super::{ERRORS, Error};
|
|
|
|
Ok(
|
|
|
|
<$Ty>::deserialize(deserializer).unwrap_or_else(|e| {
|
|
|
|
ERRORS
|
|
|
|
.lock()
|
|
|
|
.expect("no threading here")
|
|
|
|
.push(Error::Toml(e.to_string()));
|
|
|
|
super::$config()
|
|
|
|
})
|
|
|
|
)
|
2016-02-21 19:11:32 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-09-18 06:37:41 +00:00
|
|
|
#[must_use]
|
2020-02-05 02:06:34 +00:00
|
|
|
fn $config() -> $Ty {
|
|
|
|
let x = $default;
|
|
|
|
x
|
2017-05-09 13:23:38 +00:00
|
|
|
}
|
|
|
|
)+
|
2016-02-21 19:11:32 +00:00
|
|
|
}
|
|
|
|
};
|
2016-02-22 13:25:51 +00:00
|
|
|
}
|
2016-02-21 19:11:32 +00:00
|
|
|
|
2020-02-05 02:06:34 +00:00
|
|
|
pub use self::helpers::Conf;
|
2016-02-21 19:11:32 +00:00
|
|
|
define_Conf! {
|
2016-02-22 13:25:51 +00:00
|
|
|
/// Lint: BLACKLISTED_NAME. The list of blacklisted names to lint about
|
2020-02-05 02:06:34 +00:00
|
|
|
(blacklisted_names, "blacklisted_names": Vec<String>, ["foo", "bar", "baz", "quux"].iter().map(ToString::to_string).collect()),
|
2019-02-23 01:19:50 +00:00
|
|
|
/// Lint: COGNITIVE_COMPLEXITY. The maximum cognitive complexity a function can have
|
2020-02-05 02:06:34 +00:00
|
|
|
(cognitive_complexity_threshold, "cognitive_complexity_threshold": u64, 25),
|
2019-02-23 01:19:50 +00:00
|
|
|
/// DEPRECATED LINT: CYCLOMATIC_COMPLEXITY. Use the Cognitive Complexity lint instead.
|
2020-02-05 02:06:34 +00:00
|
|
|
(cyclomatic_complexity_threshold, "cyclomatic_complexity_threshold": Option<u64>, None),
|
2016-04-04 18:18:17 +00:00
|
|
|
/// Lint: DOC_MARKDOWN. The list of words this lint should not consider as identifiers needing ticks
|
2020-02-05 02:06:34 +00:00
|
|
|
(doc_valid_idents, "doc_valid_idents": Vec<String>, [
|
2017-05-06 19:31:54 +00:00
|
|
|
"KiB", "MiB", "GiB", "TiB", "PiB", "EiB",
|
2016-12-21 11:30:41 +00:00
|
|
|
"DirectX",
|
2017-03-03 11:28:15 +00:00
|
|
|
"ECMAScript",
|
2016-12-21 11:30:41 +00:00
|
|
|
"GPLv2", "GPLv3",
|
2018-01-02 12:51:35 +00:00
|
|
|
"GitHub", "GitLab",
|
2016-12-21 11:30:41 +00:00
|
|
|
"IPv4", "IPv6",
|
|
|
|
"JavaScript",
|
2018-01-02 12:51:35 +00:00
|
|
|
"NaN", "NaNs",
|
2016-12-21 11:30:41 +00:00
|
|
|
"OAuth",
|
2017-11-18 18:13:07 +00:00
|
|
|
"OpenGL", "OpenSSH", "OpenSSL", "OpenStreetMap",
|
2016-12-21 11:30:41 +00:00
|
|
|
"TrueType",
|
|
|
|
"iOS", "macOS",
|
2017-09-18 20:40:00 +00:00
|
|
|
"TeX", "LaTeX", "BibTeX", "BibLaTeX",
|
2017-04-25 09:38:37 +00:00
|
|
|
"MinGW",
|
2018-12-11 18:37:43 +00:00
|
|
|
"CamelCase",
|
2020-02-05 02:06:34 +00:00
|
|
|
].iter().map(ToString::to_string).collect()),
|
2016-02-22 13:25:51 +00:00
|
|
|
/// Lint: TOO_MANY_ARGUMENTS. The maximum number of argument a function or method can have
|
2020-02-05 02:06:34 +00:00
|
|
|
(too_many_arguments_threshold, "too_many_arguments_threshold": u64, 7),
|
2016-02-22 13:25:51 +00:00
|
|
|
/// Lint: TYPE_COMPLEXITY. The maximum complexity a type can have
|
2020-02-05 02:06:34 +00:00
|
|
|
(type_complexity_threshold, "type_complexity_threshold": u64, 250),
|
2016-03-14 13:56:44 +00:00
|
|
|
/// Lint: MANY_SINGLE_CHAR_NAMES. The maximum number of single char bindings a scope may have
|
2020-02-05 02:06:34 +00:00
|
|
|
(single_char_binding_names_threshold, "single_char_binding_names_threshold": u64, 5),
|
2016-07-10 13:23:50 +00:00
|
|
|
/// Lint: BOXED_LOCAL. The maximum size of objects (in bytes) that will be linted. Larger objects are ok on the heap
|
2020-02-05 02:06:34 +00:00
|
|
|
(too_large_for_stack, "too_large_for_stack": u64, 200),
|
2016-08-06 18:59:27 +00:00
|
|
|
/// Lint: ENUM_VARIANT_NAMES. The minimum number of enum variants for the lints about variant names to trigger
|
2020-02-05 02:06:34 +00:00
|
|
|
(enum_variant_name_threshold, "enum_variant_name_threshold": u64, 3),
|
2018-12-07 11:24:59 +00:00
|
|
|
/// Lint: LARGE_ENUM_VARIANT. The maximum size of a enum's variant to avoid box suggestion
|
2020-02-05 02:06:34 +00:00
|
|
|
(enum_variant_size_threshold, "enum_variant_size_threshold": u64, 200),
|
2017-09-26 15:54:08 +00:00
|
|
|
/// Lint: VERBOSE_BIT_MASK. The maximum allowed size of a bit mask before suggesting to use 'trailing_zeros'
|
2020-02-05 02:06:34 +00:00
|
|
|
(verbose_bit_mask_threshold, "verbose_bit_mask_threshold": u64, 1),
|
2018-01-23 14:29:31 +00:00
|
|
|
/// Lint: DECIMAL_LITERAL_REPRESENTATION. The lower bound for linting decimal literals
|
2020-02-05 02:06:34 +00:00
|
|
|
(literal_representation_threshold, "literal_representation_threshold": u64, 16384),
|
2018-05-27 14:04:45 +00:00
|
|
|
/// Lint: TRIVIALLY_COPY_PASS_BY_REF. The maximum size (in bytes) to consider a `Copy` type for passing by value instead of by reference.
|
2020-02-05 02:06:34 +00:00
|
|
|
(trivial_copy_size_limit, "trivial_copy_size_limit": Option<u64>, None),
|
2019-01-13 15:19:02 +00:00
|
|
|
/// Lint: TOO_MANY_LINES. The maximum number of lines a function or method can have
|
2020-02-05 02:06:34 +00:00
|
|
|
(too_many_lines_threshold, "too_many_lines_threshold": u64, 100),
|
2019-11-12 22:22:53 +00:00
|
|
|
/// Lint: LARGE_STACK_ARRAYS. The maximum allowed size for arrays on the stack
|
2020-02-05 02:06:34 +00:00
|
|
|
(array_size_threshold, "array_size_threshold": u64, 512_000),
|
2020-01-23 14:52:41 +00:00
|
|
|
/// Lint: VEC_BOX. The size of the boxed type in bytes, where boxing in a `Vec` is allowed
|
2020-02-05 02:06:34 +00:00
|
|
|
(vec_box_size_threshold, "vec_box_size_threshold": u64, 4096),
|
2016-02-21 19:11:32 +00:00
|
|
|
}
|
|
|
|
|
2018-09-03 21:12:50 +00:00
|
|
|
impl Default for Conf {
|
2019-09-18 06:37:41 +00:00
|
|
|
#[must_use]
|
2018-09-26 09:32:05 +00:00
|
|
|
fn default() -> Self {
|
2018-09-03 21:12:50 +00:00
|
|
|
toml::from_str("").expect("we never error on empty config files")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-10-25 17:41:24 +00:00
|
|
|
/// Search for the configuration file.
|
2020-02-05 02:06:34 +00:00
|
|
|
pub fn lookup_conf_file() -> io::Result<Option<PathBuf>> {
|
2016-10-25 17:41:24 +00:00
|
|
|
/// Possible filename to search for.
|
2017-10-20 12:41:24 +00:00
|
|
|
const CONFIG_FILE_NAMES: [&str; 2] = [".clippy.toml", "clippy.toml"];
|
2016-10-25 17:41:24 +00:00
|
|
|
|
2019-01-27 00:11:30 +00:00
|
|
|
// Start looking for a config file in CLIPPY_CONF_DIR, or failing that, CARGO_MANIFEST_DIR.
|
|
|
|
// If neither of those exist, use ".".
|
2020-02-05 02:06:34 +00:00
|
|
|
let mut current = env::var_os("CLIPPY_CONF_DIR")
|
|
|
|
.or_else(|| env::var_os("CARGO_MANIFEST_DIR"))
|
|
|
|
.map_or_else(|| PathBuf::from("."), PathBuf::from);
|
2016-10-25 17:41:24 +00:00
|
|
|
loop {
|
|
|
|
for config_file_name in &CONFIG_FILE_NAMES {
|
|
|
|
let config_file = current.join(config_file_name);
|
|
|
|
match fs::metadata(&config_file) {
|
|
|
|
// Only return if it's a file to handle the unlikely situation of a directory named
|
|
|
|
// `clippy.toml`.
|
2020-02-05 02:06:34 +00:00
|
|
|
Ok(ref md) if !md.is_dir() => return Ok(Some(config_file)),
|
2016-10-25 17:41:24 +00:00
|
|
|
// Return the error if it's something other than `NotFound`; otherwise we didn't
|
|
|
|
// find the project file yet, and continue searching.
|
2020-02-05 02:06:34 +00:00
|
|
|
Err(e) if e.kind() != io::ErrorKind::NotFound => return Err(e),
|
|
|
|
_ => {},
|
2016-10-25 17:41:24 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// If the current directory has no parent, we're done searching.
|
|
|
|
if !current.pop() {
|
|
|
|
return Ok(None);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-05-09 14:02:48 +00:00
|
|
|
/// Produces a `Conf` filled with the default values and forwards the errors
|
|
|
|
///
|
|
|
|
/// Used internally for convenience
|
2017-05-09 13:23:38 +00:00
|
|
|
fn default(errors: Vec<Error>) -> (Conf, Vec<Error>) {
|
2018-09-03 21:12:50 +00:00
|
|
|
(Conf::default(), errors)
|
2017-05-09 13:23:38 +00:00
|
|
|
}
|
|
|
|
|
2016-10-25 17:41:24 +00:00
|
|
|
/// Read the `toml` configuration file.
|
|
|
|
///
|
2016-03-06 14:48:56 +00:00
|
|
|
/// In case of error, the function tries to continue as much as possible.
|
2020-02-05 02:06:34 +00:00
|
|
|
pub fn read(path: &Path) -> (Conf, Vec<Error>) {
|
|
|
|
let content = match fs::read_to_string(path) {
|
|
|
|
Ok(content) => content,
|
2017-05-09 13:23:38 +00:00
|
|
|
Err(err) => return default(vec![err.into()]),
|
2016-02-21 19:11:32 +00:00
|
|
|
};
|
|
|
|
|
2018-11-27 20:14:15 +00:00
|
|
|
assert!(ERRORS.lock().expect("no threading -> mutex always safe").is_empty());
|
2020-02-05 02:06:34 +00:00
|
|
|
match toml::from_str(&content) {
|
2019-02-23 01:19:50 +00:00
|
|
|
Ok(toml) => {
|
|
|
|
let mut errors = ERRORS.lock().expect("no threading -> mutex always safe").split_off(0);
|
|
|
|
|
|
|
|
let toml_ref: &Conf = &toml;
|
|
|
|
|
|
|
|
let cyc_field: Option<u64> = toml_ref.cyclomatic_complexity_threshold;
|
|
|
|
|
|
|
|
if cyc_field.is_some() {
|
|
|
|
let cyc_err = "found deprecated field `cyclomatic-complexity-threshold`. Please use `cognitive-complexity-threshold` instead.".to_string();
|
|
|
|
errors.push(Error::Toml(cyc_err));
|
|
|
|
}
|
|
|
|
|
|
|
|
(toml, errors)
|
|
|
|
},
|
2017-05-09 13:23:38 +00:00
|
|
|
Err(e) => {
|
2018-11-27 20:14:15 +00:00
|
|
|
let mut errors = ERRORS.lock().expect("no threading -> mutex always safe").split_off(0);
|
2017-05-09 13:23:38 +00:00
|
|
|
errors.push(Error::Toml(e.to_string()));
|
2019-02-23 01:19:50 +00:00
|
|
|
|
2017-05-09 13:23:38 +00:00
|
|
|
default(errors)
|
|
|
|
},
|
2016-02-21 19:11:32 +00:00
|
|
|
}
|
|
|
|
}
|