rust-clippy/clippy_lints/src/utils/conf.rs

255 lines
9.5 KiB
Rust
Raw Normal View History

//! Read configurations files.
#![deny(missing_docs_in_private_items)]
2016-10-25 17:41:24 +00:00
use std::{env, fmt, fs, io, path};
use std::io::Read;
use syntax::{ast, codemap};
use toml;
2017-05-09 13:23:38 +00:00
use std::sync::Mutex;
/// Get the configuration file from arguments.
2017-08-09 07:30:56 +00:00
pub fn file_from_args(
args: &[codemap::Spanned<ast::NestedMetaItemKind>],
) -> Result<Option<path::PathBuf>, (&'static str, codemap::Span)> {
for arg in args.iter().filter_map(|a| a.meta_item()) {
2018-05-03 22:28:02 +00:00
if arg.name() == "conf_file" {
return match arg.node {
2017-09-05 09:33:04 +00:00
ast::MetaItemKind::Word | ast::MetaItemKind::List(_) => {
Err(("`conf_file` must be a named value", arg.span))
},
ast::MetaItemKind::NameValue(ref value) => if let ast::LitKind::Str(ref file, _) = value.node {
Ok(Some(file.to_string().into()))
} else {
Err(("`conf_file` value must be a string", value.span))
2016-12-20 17:21:30 +00:00
},
};
}
}
Ok(None)
}
/// Error from reading a configuration file.
#[derive(Debug)]
2016-06-10 14:17:20 +00:00
pub enum Error {
/// An I/O error.
2016-06-10 14:23:17 +00:00
Io(io::Error),
2017-05-09 13:23:38 +00:00
/// Not valid toml or doesn't fit the expected conf format
Toml(String),
/// Type error.
2017-08-09 07:30:56 +00:00
Type(
/// The name of the key.
&'static str,
/// The expected type.
&'static str,
/// The type we got instead.
2017-09-05 09:33:04 +00:00
&'static str,
2017-08-09 07:30:56 +00:00
),
/// There is an unknown key is the file.
UnknownKey(String),
}
2016-06-10 14:17:20 +00:00
impl fmt::Display for Error {
fn fmt(&self, f: &mut fmt::Formatter) -> Result<(), fmt::Error> {
match *self {
2016-06-10 14:23:17 +00:00
Error::Io(ref err) => err.fmt(f),
2017-05-09 13:23:38 +00:00
Error::Toml(ref err) => err.fmt(f),
2016-08-01 14:59:14 +00:00
Error::Type(key, expected, got) => {
write!(f, "`{}` is expected to be a `{}` but is a `{}`", key, expected, got)
2016-12-20 17:21:30 +00:00
},
2016-06-10 14:17:20 +00:00
Error::UnknownKey(ref key) => write!(f, "unknown key `{}`", key),
}
}
}
2016-06-10 14:17:20 +00:00
impl From<io::Error> for Error {
fn from(e: io::Error) -> Self {
2016-06-10 14:23:17 +00:00
Error::Io(e)
}
}
2017-05-09 13:23:38 +00:00
lazy_static! {
static ref ERRORS: Mutex<Vec<Error>> = Mutex::new(Vec::new());
}
2017-05-09 13:23:38 +00:00
macro_rules! define_Conf {
($(#[$doc: meta] ($rust_name: ident, $rust_name_str: expr, $default: expr => $($ty: tt)+),)+) => {
pub use self::helpers::Conf;
2018-06-25 18:50:20 +00:00
// FIXME(mati865): remove #[allow(rust_2018_idioms)] when it's fixed:
//
// warning: `extern crate` is not idiomatic in the new edition
// --> src/utils/conf.rs:82:22
// |
// 82 | #[derive(Deserialize)]
// | ^^^^^^^^^^^ help: convert it to a `use`
//
#[allow(rust_2018_idioms)]
2017-05-09 13:23:38 +00:00
mod helpers {
2018-07-19 07:02:08 +00:00
use serde_derive::Deserialize;
2017-05-09 13:23:38 +00:00
/// Type used to store lint configuration.
#[derive(Deserialize)]
2018-07-19 07:02:08 +00:00
#[serde(rename_all="kebab-case", deny_unknown_fields)]
2017-05-09 13:23:38 +00:00
pub struct Conf {
$(#[$doc] #[serde(default=$rust_name_str)] #[serde(with=$rust_name_str)]
pub $rust_name: define_Conf!(TY $($ty)+),)+
2017-05-09 13:23:38 +00:00
#[allow(dead_code)]
#[serde(default)]
third_party: Option<::toml::Value>,
}
2017-05-09 13:23:38 +00:00
$(
mod $rust_name {
use serde;
use serde::Deserialize;
2018-06-25 18:50:20 +00:00
crate fn deserialize<'de, D: serde::Deserializer<'de>>(deserializer: D)
-> Result<define_Conf!(TY $($ty)+), D::Error> {
2017-05-09 13:23:38 +00:00
type T = define_Conf!(TY $($ty)+);
Ok(T::deserialize(deserializer).unwrap_or_else(|e| {
2018-05-30 08:15:50 +00:00
crate::utils::conf::ERRORS.lock().expect("no threading here")
.push(crate::utils::conf::Error::Toml(e.to_string()));
2017-05-09 13:23:38 +00:00
super::$rust_name()
}))
}
}
2017-05-09 13:23:38 +00:00
fn $rust_name() -> define_Conf!(TY $($ty)+) {
define_Conf!(DEFAULT $($ty)+, $default)
}
)+
}
};
// hack to convert tts
2016-02-22 13:25:51 +00:00
(TY $ty: ty) => { $ty };
2016-02-22 13:25:51 +00:00
// provide a nicer syntax to declare the default value of `Vec<String>` variables
(DEFAULT Vec<String>, $e: expr) => { $e.iter().map(|&e| e.to_owned()).collect() };
(DEFAULT $ty: ty, $e: expr) => { $e };
}
define_Conf! {
2016-02-22 13:25:51 +00:00
/// Lint: BLACKLISTED_NAME. The list of blacklisted names to lint about
2017-05-09 13:23:38 +00:00
(blacklisted_names, "blacklisted_names", ["foo", "bar", "baz", "quux"] => Vec<String>),
2016-02-22 13:25:51 +00:00
/// Lint: CYCLOMATIC_COMPLEXITY. The maximum cyclomatic complexity a function can have
2017-05-09 13:23:38 +00:00
(cyclomatic_complexity_threshold, "cyclomatic_complexity_threshold", 25 => u64),
/// Lint: DOC_MARKDOWN. The list of words this lint should not consider as identifiers needing ticks
2017-05-09 13:23:38 +00:00
(doc_valid_idents, "doc_valid_idents", [
2017-05-06 19:31:54 +00:00
"KiB", "MiB", "GiB", "TiB", "PiB", "EiB",
2016-12-21 11:30:41 +00:00
"DirectX",
"ECMAScript",
2016-12-21 11:30:41 +00:00
"GPLv2", "GPLv3",
"GitHub", "GitLab",
2016-12-21 11:30:41 +00:00
"IPv4", "IPv6",
"JavaScript",
"NaN", "NaNs",
2016-12-21 11:30:41 +00:00
"OAuth",
"OpenGL", "OpenSSH", "OpenSSL", "OpenStreetMap",
2016-12-21 11:30:41 +00:00
"TrueType",
"iOS", "macOS",
"TeX", "LaTeX", "BibTeX", "BibLaTeX",
2017-04-25 09:38:37 +00:00
"MinGW",
2016-12-21 11:30:41 +00:00
] => Vec<String>),
2016-02-22 13:25:51 +00:00
/// Lint: TOO_MANY_ARGUMENTS. The maximum number of argument a function or method can have
2017-05-09 13:23:38 +00:00
(too_many_arguments_threshold, "too_many_arguments_threshold", 7 => u64),
2016-02-22 13:25:51 +00:00
/// Lint: TYPE_COMPLEXITY. The maximum complexity a type can have
2017-05-09 13:23:38 +00:00
(type_complexity_threshold, "type_complexity_threshold", 250 => u64),
/// Lint: MANY_SINGLE_CHAR_NAMES. The maximum number of single char bindings a scope may have
2017-05-09 13:23:38 +00:00
(single_char_binding_names_threshold, "single_char_binding_names_threshold", 5 => u64),
2016-07-10 13:23:50 +00:00
/// Lint: BOXED_LOCAL. The maximum size of objects (in bytes) that will be linted. Larger objects are ok on the heap
2017-05-09 13:23:38 +00:00
(too_large_for_stack, "too_large_for_stack", 200 => u64),
/// Lint: ENUM_VARIANT_NAMES. The minimum number of enum variants for the lints about variant names to trigger
2017-05-09 13:23:38 +00:00
(enum_variant_name_threshold, "enum_variant_name_threshold", 3 => u64),
/// Lint: LARGE_ENUM_VARIANT. The maximum size of a emum's variant to avoid box suggestion
2017-05-09 13:23:38 +00:00
(enum_variant_size_threshold, "enum_variant_size_threshold", 200 => u64),
/// Lint: VERBOSE_BIT_MASK. The maximum allowed size of a bit mask before suggesting to use 'trailing_zeros'
(verbose_bit_mask_threshold, "verbose_bit_mask_threshold", 1 => u64),
2018-01-23 14:29:31 +00:00
/// Lint: DECIMAL_LITERAL_REPRESENTATION. The lower bound for linting decimal literals
(literal_representation_threshold, "literal_representation_threshold", 16384 => u64),
/// Lint: TRIVIALLY_COPY_PASS_BY_REF. The maximum size (in bytes) to consider a `Copy` type for passing by value instead of by reference.
(trivial_copy_size_limit, "trivial_copy_size_limit", None => Option<u64>),
}
2016-10-25 17:41:24 +00:00
/// Search for the configuration file.
pub fn lookup_conf_file() -> io::Result<Option<path::PathBuf>> {
/// Possible filename to search for.
const CONFIG_FILE_NAMES: [&str; 2] = [".clippy.toml", "clippy.toml"];
2016-10-25 17:41:24 +00:00
2018-03-27 10:14:46 +00:00
let mut current = path::PathBuf::from(env::var("CARGO_MANIFEST_DIR").expect("CARGO_MANIFEST_DIR not set"));
2016-10-25 17:41:24 +00:00
loop {
for config_file_name in &CONFIG_FILE_NAMES {
let config_file = current.join(config_file_name);
match fs::metadata(&config_file) {
// Only return if it's a file to handle the unlikely situation of a directory named
// `clippy.toml`.
Ok(ref md) if md.is_file() => return Ok(Some(config_file)),
// Return the error if it's something other than `NotFound`; otherwise we didn't
// find the project file yet, and continue searching.
2017-09-05 09:33:04 +00:00
Err(e) => if e.kind() != io::ErrorKind::NotFound {
return Err(e);
2016-12-20 17:21:30 +00:00
},
2016-10-25 17:41:24 +00:00
_ => (),
}
}
// If the current directory has no parent, we're done searching.
if !current.pop() {
return Ok(None);
}
}
}
2017-05-09 14:02:48 +00:00
/// Produces a `Conf` filled with the default values and forwards the errors
///
/// Used internally for convenience
2017-05-09 13:23:38 +00:00
fn default(errors: Vec<Error>) -> (Conf, Vec<Error>) {
(toml::from_str("").expect("we never error on empty config files"), errors)
}
2016-10-25 17:41:24 +00:00
/// Read the `toml` configuration file.
///
2016-03-06 14:48:56 +00:00
/// In case of error, the function tries to continue as much as possible.
2016-10-25 17:41:24 +00:00
pub fn read(path: Option<&path::Path>) -> (Conf, Vec<Error>) {
let path = if let Some(path) = path {
path
} else {
2017-05-12 10:09:52 +00:00
return default(Vec::new());
2016-10-25 17:41:24 +00:00
};
let file = match fs::File::open(path) {
Ok(mut file) => {
let mut buf = String::new();
2016-03-06 14:48:56 +00:00
if let Err(err) = file.read_to_string(&mut buf) {
2017-05-12 10:09:52 +00:00
return default(vec![err.into()]);
2016-03-06 14:48:56 +00:00
}
buf
2016-12-20 17:21:30 +00:00
},
2017-05-09 13:23:38 +00:00
Err(err) => return default(vec![err.into()]),
};
2017-08-09 07:30:56 +00:00
assert!(
ERRORS
.lock()
.expect("no threading -> mutex always safe")
.is_empty()
);
2017-05-09 13:23:38 +00:00
match toml::from_str(&file) {
2017-08-09 07:30:56 +00:00
Ok(toml) => (
toml,
ERRORS
.lock()
.expect("no threading -> mutex always safe")
.split_off(0),
),
2017-05-09 13:23:38 +00:00
Err(e) => {
2017-08-09 07:30:56 +00:00
let mut errors = ERRORS
.lock()
.expect("no threading -> mutex always safe")
.split_off(0);
2017-05-09 13:23:38 +00:00
errors.push(Error::Toml(e.to_string()));
default(errors)
},
}
}