Pavle Goloskokovic
|
c84a00e248
|
Removed _rate field as it is now set in BaseSoundManager class
|
2017-11-27 17:37:11 +01:00 |
|
Pavle Goloskokovic
|
28ae0811e6
|
Defining detune property in BaseSound class so it can be used in both Web Audio and HTML5 Audio implementations
|
2017-11-27 17:35:35 +01:00 |
|
Pavle Goloskokovic
|
1c1e75ac85
|
Defining rate property in BaseSound class so it can be used in both Web Audio and HTML5 Audio implementations
|
2017-11-27 17:35:09 +01:00 |
|
Pavle Goloskokovic
|
27ad50d276
|
Setting _detune field in BaseSound class so it can be used in both Web Audio and HTML5 Audio implementations
|
2017-11-27 17:34:27 +01:00 |
|
Pavle Goloskokovic
|
92ac9d41c5
|
Setting _rate field in BaseSound class so it can be used in both Web Audio and HTML5 Audio implementations
|
2017-11-27 17:33:37 +01:00 |
|
Pavle Goloskokovic
|
cf46145d7c
|
Calling super method in setRate method of WebAudioSound class, setting returned value to source playback rate audio param and returning the same value to match method signature
|
2017-11-27 17:32:16 +01:00 |
|
Pavle Goloskokovic
|
f389176362
|
Added setRate method to BaseSound class that contains logic for applying rate and detune settings to sound so it can be reused in both Web Audio and HTML5 Audio implementations
|
2017-11-27 17:30:55 +01:00 |
|
Pavle Goloskokovic
|
881474b7cd
|
Added a TODO to take into account playback rate when pausing and resuming sound
|
2017-11-27 16:50:45 +01:00 |
|
Pavle Goloskokovic
|
ffc205b400
|
Calling setRate method on all sound objects when updating global detune value
|
2017-11-27 16:50:05 +01:00 |
|
Pavle Goloskokovic
|
c57f692c85
|
Calling setRate method on all sound objects when updating global rate value
|
2017-11-27 16:49:28 +01:00 |
|
Pavle Goloskokovic
|
9fffd57ad3
|
Moved sound source not null check from properties' setter methods to setRate method
|
2017-11-27 16:48:20 +01:00 |
|
Pavle Goloskokovic
|
db06b3d742
|
Calling setRate in WebAudioSound detune property's setter method
|
2017-11-27 16:46:42 +01:00 |
|
Pavle Goloskokovic
|
074c60c270
|
Calling setRate in WebAudioSound rate property's setter method
|
2017-11-27 16:45:58 +01:00 |
|
Pavle Goloskokovic
|
1fddd3de2a
|
Added setRate method to WebAudioSound class that calculates and sets playback rate based on sound's and manager's detune and rate values
|
2017-11-27 16:44:23 +01:00 |
|
Pavle Goloskokovic
|
d13fae2260
|
Preventing negative values for source start call
|
2017-11-26 18:12:55 +01:00 |
|
Pavle Goloskokovic
|
93ac04329b
|
Updated WebAudioSound update method docs and signature
|
2017-11-26 17:25:01 +01:00 |
|
Pavle Goloskokovic
|
66dcd9f02f
|
Resetting hasEnded in update method
|
2017-11-26 17:07:56 +01:00 |
|
Pavle Goloskokovic
|
0a078d26f6
|
Setting hasEnded when sound ends
|
2017-11-26 17:07:05 +01:00 |
|
Pavle Goloskokovic
|
f0bc96e68f
|
Checking hasEnded on update in order to call stop method
|
2017-11-26 17:05:24 +01:00 |
|
Pavle Goloskokovic
|
84e6459b59
|
Added hasEnded property to WebAudioSound class
|
2017-11-26 17:03:36 +01:00 |
|
Pavle Goloskokovic
|
94e834fa96
|
Updating all sounds on sound manager update
|
2017-11-26 16:59:12 +01:00 |
|
Pavle Goloskokovic
|
ceeef0368c
|
Added a todo to fix race condition
|
2017-11-26 16:41:46 +01:00 |
|
Pavle Goloskokovic
|
2995b7eaf6
|
Added short logic explanation for onended event handler
|
2017-11-26 16:37:03 +01:00 |
|
Pavle Goloskokovic
|
e13b829ab1
|
Removed redundant check in onended handler and reverted setting source to null before calling stop() on it since it does not invoke onended event handler immediately
|
2017-11-26 16:35:13 +01:00 |
|
Pavle Goloskokovic
|
007a565700
|
Just checking for null sound reference isn't enough since because calling play() on already playing sound is not covered by that condition
|
2017-11-26 16:31:06 +01:00 |
|
Pavle Goloskokovic
|
aab5150016
|
Setting source to null before calling stop on it to determine if onended event was fired when sound ended or when it was stopped by user
|
2017-11-26 16:28:54 +01:00 |
|
Pavle Goloskokovic
|
04eb680d52
|
Checking if source is null before stopping sound on ended handler because it is called also when stop() method is called on it
|
2017-11-26 16:27:39 +01:00 |
|
Pavle Goloskokovic
|
1808fab27e
|
Calling stop method when sound ends
|
2017-11-26 16:24:49 +01:00 |
|
Pavle Goloskokovic
|
53dbf050d4
|
Marked a few methods as private
|
2017-11-26 16:19:56 +01:00 |
|
Pavle Goloskokovic
|
762c6cb147
|
Updated a TODO
|
2017-11-23 13:55:27 +01:00 |
|
Pavle Goloskokovic
|
266ebc4925
|
Taking into account marker start time on resuming sound
|
2017-11-23 13:55:08 +01:00 |
|
Pavle Goloskokovic
|
d369d46e35
|
Taking into account marker start time if marker is currently played
|
2017-11-23 13:53:57 +01:00 |
|
Pavle Goloskokovic
|
0ded9af3a9
|
Resetting current marker if no marker name is provided to play method
|
2017-11-23 13:52:03 +01:00 |
|
Pavle Goloskokovic
|
5f55931d22
|
Completed a TODO by setting BaseSound update method to NOOP
|
2017-11-23 13:19:22 +01:00 |
|
Pavle Goloskokovic
|
a2ceff63f1
|
Returning marker/null instead of boolean in removeMarker
|
2017-11-23 13:14:41 +01:00 |
|
Pavle Goloskokovic
|
b3337b6c51
|
Added validation for non existing marker in removeMarker method
|
2017-11-23 13:13:25 +01:00 |
|
Pavle Goloskokovic
|
c48f51de35
|
Setting marker to null on removeMarker call
|
2017-11-23 13:12:21 +01:00 |
|
Pavle Goloskokovic
|
9d8afee78f
|
Added validation for non existing marker to updateMarker method
|
2017-11-23 12:56:32 +01:00 |
|
Pavle Goloskokovic
|
0e97a18553
|
Added validation for invalid marker name to updateMarker method
|
2017-11-23 12:56:06 +01:00 |
|
Pavle Goloskokovic
|
42735ee09f
|
Added validation for when no marker is provided to updateMarker method
|
2017-11-23 12:55:22 +01:00 |
|
Pavle Goloskokovic
|
17d39f7bab
|
Merging provided marker with existing marker in updateMarker method
|
2017-11-23 12:54:47 +01:00 |
|
Pavle Goloskokovic
|
8a4e439b55
|
Updated logging for addMarker method of BaseSound class
|
2017-11-23 12:52:19 +01:00 |
|
Pavle Goloskokovic
|
6c38853a6f
|
Added update marker method to BaseSound class
|
2017-11-23 12:41:41 +01:00 |
|
Pavle Goloskokovic
|
76a32e20c6
|
Fixed return values for addMarker method
|
2017-11-23 12:37:10 +01:00 |
|
Pavle Goloskokovic
|
1e213e6d86
|
Added validation for existing marker
|
2017-11-23 12:35:55 +01:00 |
|
Pavle Goloskokovic
|
de5689b129
|
Added validation for marker name
|
2017-11-23 12:34:43 +01:00 |
|
Pavle Goloskokovic
|
2bcffe6f2f
|
Merging provided marker with object with default values
|
2017-11-23 12:33:56 +01:00 |
|
Pavle Goloskokovic
|
40b4dc2e6e
|
Adding validation and error handling if no marker is passed
|
2017-11-23 12:31:34 +01:00 |
|
Pavle Goloskokovic
|
084d309efb
|
Adding market to markers array in addMarker method
|
2017-11-23 12:30:24 +01:00 |
|
Pavle Goloskokovic
|
c1b0bc4ee7
|
Added a TODO for scheduled playback
|
2017-11-22 18:07:08 +01:00 |
|