Commit graph

1396 commits

Author SHA1 Message Date
Ross Goldberg
3d264675bf
Move code to more appropriate files.
Partial #533

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-29 00:16:35 -04:00
Ross Goldberg
e639341d11
Refactor to allow install & purchase to report unknown app IDs via console instead of cryptically via a dialog.
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-28 20:18:49 -04:00
Ross Goldberg
e4bc69cf5d
Remove unnecessary tests.
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-28 15:23:20 -04:00
Ross Goldberg
9eef8b6cb8
Improve download functions.
Partial #533

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-28 15:09:20 -04:00
Ross Goldberg
0a05cd438f
Add & use MASError.unknownAppID(AppID).
Partial #533

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-28 14:38:06 -04:00
Ross Goldberg
d59249ac33
Merge pull request #622 from rgoldberg/cleanup
Simplify `open()` extension func for `URL`.
2024-10-28 12:56:55 -04:00
Ross Goldberg
14dbd26d3a
Simplify open() extension func for URL.
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-28 12:49:48 -04:00
Ross Goldberg
7f30214a2d
Merge pull request #621 from rgoldberg/620-external-command
Replace `ExternalCommand` code that starts new processes with Apple library calls
2024-10-28 12:27:33 -04:00
Ross Goldberg
9ebb01805d
Replace clunky ExternalCommand code that starts new processes with Apple library calls.
Resolve #620

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-28 12:19:56 -04:00
Ross Goldberg
a3dbbde513
Merge pull request #618 from rgoldberg/217-open
Open the Mac App Store without any spurious error dialogs.
2024-10-28 10:48:25 -04:00
Ross Goldberg
c0fffeddf3
Open the Mac App Store without any spurious error dialogs.
Use PromiseKit properly.

Don't use `OpenCommand`.

Resolve #217

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-28 10:17:33 -04:00
Ross Goldberg
bb8d742675
Merge pull request #617 from rgoldberg/616-help
Cleanup help.
2024-10-28 01:06:48 -04:00
Ross Goldberg
5bfd83f3c4
Cleanup help.
Resolve #616

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-28 01:00:48 -04:00
Ross Goldberg
9b33ec90f9
Merge pull request #615 from rgoldberg/607-refactor
Refactor `AppStoreSearcher` code.
2024-10-27 15:18:07 -04:00
Ross Goldberg
2a496b1f98
Refactor AppStoreSearcher code.
Move code from `AppStoreSearcher` to `ITunesSearchAppStoreSearcher`.

Improve DocC.

Improve Quick test names.

Resolve #607

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-27 15:07:29 -04:00
Ross Goldberg
99eb91392e
Merge pull request #614 from rgoldberg/613-macos-10.13
Additional improvements enabled by macOS 10.13
2024-10-27 14:58:14 -04:00
Ross Goldberg
e79e6283ac
Use ISO8601DateFormatter.
Resolve #613

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-27 14:54:07 -04:00
Ross Goldberg
705563ced9
Upgrade PromiseKit to 8.1.2.
Partial #613

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-27 14:53:38 -04:00
Ross Goldberg
86f916d4b5
Merge pull request #611 from rgoldberg/578-minimum-macos-10.13
Increase minimum macOS version to 10.13 & upgrade Swift to 5.7.1
2024-10-27 14:04:27 -04:00
Ross Goldberg
f83412bba1
Increase minimum macOS version to 10.13, since Swift 5.7 is already used, which requires Xcode 14+ to compile, which only supports macOS deployment targets 10.13+.
Use Swift 5.7.1, which is the newest version of Swift 5.7.

Resolve #578

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-27 14:01:45 -04:00
Ross Goldberg
b8194881d1
Merge pull request #610 from rgoldberg/543-help
Improve help output.
2024-10-27 12:12:41 -04:00
Ross Goldberg
52a0638f2b
Improve help output.
Make fish shell completions more consistent with the help output.

Resolve #543

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-27 12:09:43 -04:00
Ross Goldberg
a256832b78
Merge pull request #601 from rgoldberg/597-formatted-price
Use `formattedPrice` for prices
2024-10-26 02:23:47 -04:00
Ross Goldberg
fd051eac1f
Require fileSizeBytes & price for SearchResult.
Resolve #597

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-26 02:17:08 -04:00
Ross Goldberg
1b4c97f652
Use formattedPrice instead of price.
Improve price output.

Partial #597

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-26 02:17:07 -04:00
Ross Goldberg
12832f293d
Merge pull request #600 from rgoldberg/585-naming
Improve naming
2024-10-25 23:44:08 -04:00
Ross Goldberg
880843d8e6
Rename *Mock as Mock*.
Resolve #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 23:39:52 -04:00
Ross Goldberg
cc219fe644
Rename MasAppLibrary as SoftwareMapAppLibrary.
Rename `AppLibraryMock` as `MockAppLibrary`.

Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:52:20 -04:00
Ross Goldberg
d7072fc66d
Rename *StoreSearch as *AppStoreSearcher.
Rename `MasStoreSearch` as `ITunesSearchAppStoreSearcher`.

Rename `StoreSearchMock` as `MockAppStoreSearcher`.

Rename variables/parameters of the above types as `searcher`.

Fix 'App Store.app' mention in help.

Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:52:20 -04:00
Ross Goldberg
ab22e22ace
Rename Mas as MAS.
Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:52:20 -04:00
Ross Goldberg
6bf5696093
Chop down multiline guard clauses.
Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:52:19 -04:00
Ross Goldberg
59a642590a
Rename some uses of *Url as *URL.
Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:52:14 -04:00
Ross Goldberg
0b11f3737c
Rename some uses of appName as searchTerm.
Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:51:07 -04:00
Ross Goldberg
0e49da7bf1
Rename *bundleId as *bundleID.
Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:51:07 -04:00
Ross Goldberg
3a5593c12d
Rename *accountId & username as *appleID.
Partial #585

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:51:07 -04:00
Ross Goldberg
2eeff82f11
Merge pull request #599 from rgoldberg/313-uninstall
Fix `uninstall`
2024-10-25 22:49:33 -04:00
Ross Goldberg
98c85ac6d6
Delete apps via Scripting Bridge to Finder.
Resolve #313

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:39:03 -04:00
Ross Goldberg
53c64b1758
Improve errors.
Partial #313

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:39:03 -04:00
Ross Goldberg
06ee9608be
Improve output.
Improve errors.

Simplify code.

Partial #313

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:39:03 -04:00
Ross Goldberg
b0d2f23465
Add appID parameter to MASError.notInstalled().
Partial #313

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:39:03 -04:00
Ross Goldberg
222646159d
Refactor AppLibrary.installedApp(…) as AppLibrary.installedApps(…)
because multiple installed apps can have the same app ID or app name.

Partial #313

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:39:02 -04:00
Ross Goldberg
4e0a471d81
Remove unnecessary function from AppLibrary.
Partial #313

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-25 22:39:01 -04:00
Ross Goldberg
6b27d516e9
Merge pull request #595 from rgoldberg/594-github-runners-macos-15
Improve GitHub runners
2024-10-24 07:54:00 -04:00
Ross Goldberg
cab684ba60
Install swiftlint via Brewfile if macOS >= 13 (install breaks on macOS <= 12).
Only install `peripheryapp/periphery` tap if macOS >= 13 (install breaks on macOS <= 12).

Resolve #594

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-24 07:49:43 -04:00
Ross Goldberg
9e3b079ec8
Update lint.
- Change Swift bird emoji to ensure consistent spacing.

- Suppress output on GitHub runners.

- Simplify `grep` patterns.

Partial #594

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-24 07:46:50 -04:00
Ross Goldberg
417fb824b4
Upgrade GitHub runners from macos-14 to macos-15.
Resolve #594

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 07:56:23 -04:00
Ross Goldberg
bb67ea5e48
Merge pull request #593 from rgoldberg/592-lint-cleanup
Additional linting / cleanup code
2024-10-23 06:23:46 -04:00
Ross Goldberg
c36a797ac2
SwiftLint
opt_in_rules:
- all

Resolve #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 06:18:34 -04:00
Ross Goldberg
4d4dd02cd3
Improve lint configurations.
Partial #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 06:18:34 -04:00
Ross Goldberg
2edd21803b
Improve unwrapping.
Cleanup code.

Partial #592

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-10-23 06:18:34 -04:00