Mirrors/inspec
2
0
Fork 0
mirror of https://github.com/inspec/inspec synced 2024-12-24 20:13:16 +00:00
Code Issues Projects Releases Packages Wiki Activity
9030 commits 459 branches 1909 tags 77 MiB
Commit graph

4433 commits

Author SHA1 Message Date
Chef Expeditor
5f272c283d Bump version to 4.22.19 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-08-24 09:39:46 +00:00
Lance Albertson
08b7e584d7 Fix mysql_session stdout, stderr and exit_status parameters 
A feature introduced in #5124 changed how the mysql_session resource works to
where stdout, stderr, and exit_status no longer worked. The Lines class only
exposes output instead of stdout, stderr and exit_status.

As a work around, this adds backwards compatibilty for stdout, stderr and
exit_status parameters. In addition I updated the documentation to prefer output
over stdout/stderr.

This fixes #5218.

Signed-off-by: Lance Albertson <lance@osuosl.org>
 2020-08-23 18:55:58 -07:00
Chef Expeditor
2f83bc7212 Bump version to 4.22.18 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-08-20 21:07:55 +00:00
Chef Expeditor
40a81a580f Bump version to 4.22.17 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-08-17 15:47:56 +00:00
Thomas Heinen
a613e75971 Add ability to disable input caching for kitchen-inspec use 
Signed-off-by: Thomas Heinen <theinen@tecracer.de>
 2020-08-17 15:49:00 +02:00
Chef Expeditor
270cc7e95d Bump version to 4.22.16 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-08-17 10:48:42 +00:00
Udyrfrykte
fe74f4fd5b Improve apt.rb's read_debs 
Make it better at handling whitespace in bracketed options

Signed-off-by: Benoît Gastinne <Udyrfrykte@users.noreply.github.com>
 2020-08-17 11:38:40 +02:00
Chef Expeditor
80149958e8 Bump version to 4.22.15 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-08-13 20:55:05 +00:00
Chef Expeditor
f425a48f4c Bump version to 4.22.14 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-08-13 18:32:13 +00:00
Chef Expeditor
8a9e339df1 Bump version to 4.22.13 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-08-13 18:24:00 +00:00
Tim Smith
303f530850 Update to Chefstyle 1.2.1 
Update a few cop names
Remove redundant returns

Signed-off-by: Tim Smith <tsmith@chef.io>
 2020-08-12 13:12:26 -07:00
Adam M Dutko
04c3aef004 Fix Issue #5183. 
Signed-off-by: Adam M Dutko <adutko@chef.io>
 2020-08-11 10:34:13 -04:00
Clinton Wolfe
f3bede9b0c Handle sort options slightly diferently per PR feedback 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-08-10 14:47:58 -04:00
Clinton Wolfe
11e0428094 Adjust stringification of input per feedback 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-08-10 14:32:08 -04:00
Clinton Wolfe
a839d4602c Add ability to sort results in reporting phase 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-08-10 14:32:08 -04:00
Clinton Wolfe
3aca12d622 Add option to suppress diff output 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-08-10 14:31:28 -04:00
Clinton Wolfe
ceca77e118 Mark inputs as sensitive 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-08-10 14:30:11 -04:00
Clinton Wolfe
88fdb45501 DRY up reporter-trimming code by placing it in a mixin class 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-08-10 14:29:05 -04:00
Chef Expeditor
fb0be93a00 Bump version to 4.22.12 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-08-10 12:03:22 +00:00
Chef Expeditor
f2b1e131ce Bump version to 4.22.11 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-08-10 11:53:48 +00:00
Nick Schwaderer
ff1e558088
Merge pull request #4979 from tecracer-theinen/theinen/windows_firewall 
Add new windows_firewall and windows_firewall_rule resources
 2020-08-10 12:52:16 +01:00
Chef Expeditor
5974b91b49 Bump version to 4.22.10 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-08-07 17:08:45 +00:00
Nick Schwaderer
cc521b5400
Merge pull request #5084 from inspec/cw/reporter-plugin-junit 
Convert JUnit Reporter to a Plugin
 2020-08-07 18:06:43 +01:00
Chef Expeditor
f4fdb8a8f3 Bump version to 4.22.9 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-08-05 20:34:32 +00:00
Nick Schwaderer
a3ecda5c31
Merge pull request #5188 from inspec/ns/full_build_before_expeditor_merge 
Enforced bump. Fully allow this to build before merge.
 2020-08-05 21:32:45 +01:00
Nick Schwaderer
54b1e335fa Enforced bump. Fully allow this to build before merge. 
Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
 2020-08-05 20:55:45 +01:00
Chef Expeditor
beaad73586 Bump version to 4.22.8 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-08-04 10:34:26 +00:00
Chef Expeditor
fa088c4868 Bump version to 4.22.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-08-04 10:31:40 +00:00
Nick Schwaderer
9af8ec5afe
Merge pull request #5164 from inspec/ns/scientific-resource 
Supports Scientific Linux in service resource
 2020-08-04 11:30:15 +01:00
Chef Expeditor
0197677127 Bump version to 4.22.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-08-04 10:29:09 +00:00
Chef Expeditor
7bf8e9b6e5 Bump version to 4.22.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-08-04 07:55:13 +00:00
Nick Schwaderer
8318e73237 Supports Scientific Linux in service resource 
Currently when using Scientific Linux the user will be prompted with the
unsupported OS error message. As it is based on RHEL, it should be able
to be supported inn the same way.

Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
 2020-07-30 13:44:58 +01:00
Chef Expeditor
024a838a07 Bump version to 4.22.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-07-29 10:57:17 +00:00
Nick Schwaderer
986dd1aafb
Merge pull request #5165 from inspec/ns/messages_should_only_be_noted_as_trunncated_if_they_were_actually_truncated 
Ensure truncate message only returns on truncated values
 2020-07-29 11:55:39 +01:00
Chef Expeditor
15452726af Bump version to 4.22.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-07-29 09:14:01 +00:00
Nick Schwaderer
3129af9db9
Merge pull request #5123 from Perceptyx/fix-freebsd-osfamily-user-group-tests 
Fix freebsd osfamily user group tests
 2020-07-29 10:12:13 +01:00
Nick Schwaderer
d8b06560a1 Ensure truncate message only returns on truncated values 
At the moment we return the "Truncate" text whenever the setting is
utilized. This PR ensures that we only advise truncation when it's been
executed.

Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
 2020-07-29 09:50:25 +01:00
Chef Expeditor
5f7e8797d8 Bump version to 4.22.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-07-28 11:08:47 +00:00
Nick Schwaderer
08d907dc2e
Merge pull request #5124 from Perceptyx/sql-session-sensitive 
feat(sensitive): add sensitive output to mysql and postgres sessions
 2020-07-28 12:06:50 +01:00
Felipe Zipitria
dd8960dbf6
feat(sensitive): add sensitive output to mysql and postgres sessions 
Signed-off-by: Felipe Zipitria <fzipitria@perceptyx.com>
 2020-07-22 14:20:17 -03:00
Felipe Zipitria
d2ae7a7fbf
fix(osfamily): use corresponding family or name for bsd/freebsd 
Signed-off-by: Felipe Zipitria <fzipitria@perceptyx.com>
 2020-07-22 08:43:25 -03:00
Chef Expeditor
06a508e3b4 Bump version to 4.22.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-07-20 14:49:34 +00:00
Thomas Heinen
3e824b5203 Add new windows_firewall and windows_firewall_rule resources 
Signed-off-by: Thomas Heinen <theinen@tecracer.de>
 2020-07-17 13:40:31 +02:00
Chef Expeditor
da8ca846f2 Bump version to 4.22.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-07-15 12:28:39 +00:00
Nick Schwaderer
2744ff43e5
Merge pull request #5128 from james-stocks/js/report_bad_profiles 
Report faulty profiles instead of crashing
 2020-07-15 13:28:17 +01:00
Chef Expeditor
861331b487 Bump version to 4.21.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-07-14 10:49:44 +00:00
Nick Schwaderer
934aa8d49a
Merge pull request #5138 from jrbeilke/bug-apt-cdrom 
skip apt-cdrom repos in apt resource when parsing lists
 2020-07-14 11:49:21 +01:00
Chef Expeditor
c5ee0ea597 Bump version to 4.21.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-07-09 13:37:06 +00:00
James Stocks
9fc3b5e356 Make profile.rb own profile state 
Add a @state ivar to the Profile class to represent state.
Add additional comments to the Metadata class to clarify that it represents metadata but not runtime state.

Signed-off-by: James Stocks <jstocks@chef.io>
 2020-07-09 14:33:51 +01:00
James Stocks
cd077a1247 Improve profile status rendering in html2 reporter 
Signed-off-by: James Stocks <jstocks@chef.io>
 2020-07-09 14:02:42 +01:00
James Stocks
833aac3ef1 Add profile load failure message to CLI reporter 
Signed-off-by: James Stocks <jstocks@chef.io>
 2020-07-09 14:02:42 +01:00
Nick Schwaderer
6d340b323c Allow ‘=‘ character in CLI inputs 
Fixes #5131

Due to the use of `#split(‘=‘)` against inputs supplied via the CLI we had an edge case where inputs with `’=‘` in the value would cause a breakage.

This PR supplies a test for the regression and fixes the bug with a regex solution.

Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
 2020-07-09 12:50:21 +01:00
Jon Beilke
bedef776a6 skip apt-cdrom repos in apt resource when parsing lists 
Signed-off-by: Jon Beilke <Jonathan.Beilke@windlogics.com>
 2020-07-08 14:19:09 -05:00
James Stocks
08398cc3c1 Address linting mistakes. 
Signed-off-by: James Stocks <jstocks@chef.io>
 2020-07-03 15:53:09 +01:00
James Stocks
fd4c501c70 Change profile skip_message to status_message 
Keep a duplicate of the message in skip_message for the JSON reporters, for backwards compaibility.

Signed-off-by: James Stocks <jstocks@chef.io>
 2020-07-03 15:53:09 +01:00
Chef Expeditor
db55f7431c Bump version to 4.21.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-07-02 14:29:47 +00:00
Bryan McLellan
dada8ea074 Add the generic 'darwin' to the service resource 
macOS 11 Big Sur will be released later this year. Current beta versions
return 10.16 as the version, but the product name has changed from 'Mac
OS X' to 'macOS'. Train probably needs to be modified to deprecate
'mac_os_x' as a platform in favor of 'macos' but that would be a
significant downstream change. Train does fall back to 'darwin' on macOS
10.16, so by adding darwin to the list of platform names for the service
resource we are able to work around this for the moment.

This is the only location where mac_os_x is currently being used in
InSpec. Because we're in a case statement on platform rather than the
more generic platform family, we can't simply remove mac_os_x in favor
of darwin.

Signed-off-by: Bryan McLellan <btm@loftninjas.org>
 2020-07-02 09:36:27 -04:00
James Stocks
41087c5ec6 Set profiles that fail to load as failed 
Signed-off-by: James Stocks <jstocks@chef.io>
 2020-07-02 13:33:07 +01:00
Chef Expeditor
7484bfe783 Bump version to 4.21.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-07-02 11:36:22 +00:00
Chef Expeditor
23e9b6565f Bump version to 4.21.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-30 14:00:06 +00:00
James Stocks
b8ca5240e8
Merge pull request #5126 from james-stocks/js/issue_5125 
Log to stderr when using html2 reporter
 2020-06-30 14:59:46 +01:00
James Stocks
d0f00cd716 Log to stderr when using html2 reporter 
Fixes #5125

Signed-off-by: James Stocks <jstocks@chef.io>
 2020-06-30 13:56:33 +01:00
Chef Expeditor
9bdf02ac28 Bump version to 4.21.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-26 09:25:05 +00:00
James Stocks
d94d56c4b9 Ignore intermittent test teardown error 
Occasionally when the `isolated` tests run in CI, this error is seen:

```
inspec-reporter-html2::when run on a basic profile#test_0002_should produce valid HTML:
Errno::ENOENT: No such file or directory @ apply2files - /tmp/temp20200625-1802-2izu7e.html
    /usr/local/lib/ruby/2.6.0/fileutils.rb:1437:in `unlink'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:1437:in `block in remove_file'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:1442:in `platform_support'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:1436:in `remove_file'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:775:in `remove_file'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:562:in `block in rm'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:561:in `each'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:561:in `rm'
    lib/plugins/inspec-reporter-html2/test/functional/inspec_reporter_html2_test.rb:9:in `teardown'
```

It should be OK to ignore the failure to delete the test file - the issue doesn't reproduce on laptops, and CI uses clean VMs each time.

Signed-off-by: James Stocks <jstocks@chef.io>
 2020-06-26 09:23:21 +01:00
Chef Expeditor
88cdff8422 Bump version to 4.21.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-25 10:28:16 +00:00
James Stocks
af5fd7bd03
Merge pull request #5036 from inspec/cw/interface-improvements 
Additions to the interface resource
 2020-06-25 11:27:53 +01:00
Chef Expeditor
1ac816f027 Bump version to 4.21.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-25 10:26:19 +00:00
Clinton Wolfe
ad673fa570 Do not include CIDR range on ipv4_address and ipv6_address 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 15:37:19 -04:00
Clinton Wolfe
502509aa5a Rework IP range filtering for clarity, add 172.16/12 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 15:37:19 -04:00
Clinton Wolfe
d9007588a6 Add an heuristic-based IP lookup property 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 15:37:19 -04:00
Clinton Wolfe
52468e470e Barebones plural interfaces resource 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 15:37:19 -04:00
Clinton Wolfe
c386828e7a Add properties for ipv4 and ipv6 ipaddresses for compat 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 15:37:19 -04:00
Clinton Wolfe
a4000d6912 Adds support for interface on BSD and MacOS 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 15:37:19 -04:00
Mary Jinglewski
ac615db4fb Copyediting 
Signed-off-by: Mary Jinglewski <mjinglewski@chef.io>
 2020-06-18 14:23:54 -04:00
Clinton Wolfe
bd292c9dbb Fix JS execution on Internet Explorer by adding MOTW 
Mark of the Web is a special comment in HTML that IE looks for
to set the JS security zone when running a local HTML file.
See
http://msdn.microsoft.com/en-us/library/ms537628(v=vs.85).aspx

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 14:23:54 -04:00
Clinton Wolfe
e4aa9f1793 Skip HTML validation testing on windows 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 14:23:54 -04:00
Clinton Wolfe
aa824d1b49 Fix a bad interaction involving clearing the plugin registry in unit testing 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 14:23:54 -04:00
Clinton Wolfe
83c7f84290 Add ability to show/hide child profiles, start off hidden 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 14:22:31 -04:00
Clinton Wolfe
adc59ea4ad Correct html validation assertion syntax 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 14:22:31 -04:00
Clinton Wolfe
b8b7e4e848 Add ability to inline alternate JS and CSS 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 14:22:31 -04:00
Clinton Wolfe
e7a5c59b90 Use PRODUCT_NAME from Dist to allow community to rebrand 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 14:21:51 -04:00
Clinton Wolfe
a131067a09 Add functional test, including html validation 
This uses html-proofer, which adds in nokogiri as a testing dep.
I expect we'll be using nokogiri soon anyway for the JUnit reporter.

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 14:21:51 -04:00
Clinton Wolfe
81e2f36fde Basic unit tests for plugin definition 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 14:21:51 -04:00
Clinton Wolfe
bb2dfaa02d First pass at docs 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 14:21:13 -04:00
Clinton Wolfe
c4487f1892 Initial commit of inspec-reporter-html2 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-18 14:21:13 -04:00
Chef Expeditor
5aa0d92794 Bump version to 4.20.10 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-18 16:29:22 +00:00
Chef Expeditor
b5b0d0351a Bump version to 4.20.9 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-18 13:33:27 +00:00
Nick Schwaderer
7068694885 Revert "Make CLI reporter into a plugin" 
Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
 2020-06-18 12:30:15 +01:00
Chef Expeditor
c523a4f50c Bump version to 4.20.8 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-18 11:29:19 +00:00
Chef Expeditor
af7964984b Bump version to 4.20.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-17 17:17:29 +00:00
Nick Schwaderer
dca57b61c0
Merge pull request #4907 from inspec/cw/telemetry-run-context 
Telemetry - determine run context from stack introspection
 2020-06-17 18:17:09 +01:00
Chef Expeditor
c271f439fa Bump version to 4.20.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-17 16:02:27 +00:00
Nick Schwaderer
82c6472444
Merge pull request #5069 from inspec/cw/reporter-plugin-cli 
Make CLI reporter into a plugin
 2020-06-17 17:02:07 +01:00
Chef Expeditor
dfff9d36a8 Bump version to 4.20.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-17 08:51:51 +00:00
Chef Expeditor
7f10acc1ef Bump version to 4.20.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-15 11:25:44 +00:00
Clinton Wolfe
3651f85a7c Use methods to access RunData 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-11 16:46:04 -04:00
Clinton Wolfe
98ae89e6cc Convert JUnit reporter to plugin, RunData is still Hash-based 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-11 16:46:04 -04:00
Chef Expeditor
acda76723f Bump version to 4.20.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-11 11:30:34 +00:00
James Stocks
070823122d
Merge pull request #5062 from inspec/cw/reporter-plugin-jsonmin 
Make the JSON-min Reporter into Plugin
 2020-06-11 12:30:18 +01:00
Chef Expeditor
705d0ffbb6 Bump version to 4.20.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-09 14:02:32 +00:00
Chef Expeditor
62c5cba7ec Bump version to 4.20.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-05 23:14:18 +00:00
Chef Expeditor
52392600d1 Bump version to 4.20.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-05 13:11:07 +00:00
James Stocks
d5f825e716
Merge pull request #5026 from inspec/cw/silence-deprecations 
CLI Option to silence deprecations
 2020-06-05 14:10:50 +01:00
Chef Expeditor
c44eb725fe Bump version to 4.19.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-05 11:28:43 +00:00
Chef Expeditor
b114792fe5 Bump version to 4.19.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-05 11:24:06 +00:00
Nick Schwaderer
fb1aeb0655
Merge pull request #5011 from inspec/cw/complex-cli-inputs 
Boolean, Numeric, and Structured CLI inputs
 2020-06-05 04:23:48 -07:00
Clinton Wolfe
afdcc9d2a1 Add cli to list of valid types explicitly to fix unit tests 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-04 15:03:16 -04:00
Chef Expeditor
144abfb5de Bump version to 4.19.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-04 10:00:27 +00:00
Clinton Wolfe
458a5c4410 Replace Hash RunData access with method calls 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-03 21:51:21 -04:00
Clinton Wolfe
76033c03ff Convert CLI reporter to plugin, RunData is still Hash-based 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-03 21:13:27 -04:00
Clinton Wolfe
935bb81e6f Use RunData object instead of Hash 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-02 15:29:52 -04:00
Clinton Wolfe
402366c219 Convert json-min to be a plugin reporter, rundata is still a Hash 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-02 15:29:52 -04:00
Clinton Wolfe
49f3e94133 Modify Hashlike behavior when values are nil 
Exclude nil-valued keys when RunData acts like a Hash
Add non_nil? for clarity when people are calling key? and meaning not-nil

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-06-02 15:29:01 -04:00
Chef Expeditor
10e28c6895 Bump version to 4.19.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-06-02 16:56:17 +00:00
Chef Expeditor
d6453b82a5 Bump version to 4.19.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-05-27 12:06:41 +00:00
Clinton Wolfe
d5be4c2927 Test kitchen setup to test detection of audit-cookbook 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-25 21:00:24 -04:00
Clinton Wolfe
439c93b115 Add a functional test to check Thor run context detection 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-25 21:00:24 -04:00
Clinton Wolfe
45e3421595 Remove too-brittle frame ranges on stack locations 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-25 21:00:24 -04:00
Clinton Wolfe
4122157542 rename to match class name 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-25 21:00:24 -04:00
Clinton Wolfe
cd9ca19901 stack probe for audit cookbook 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-25 21:00:24 -04:00
Clinton Wolfe
5be4ee913f stack probe for test-kitchen 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-25 21:00:24 -04:00
Clinton Wolfe
e96ddbf2cb Add stack probe for detecting when run as CLI by Thor 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-25 21:00:24 -04:00
Clinton Wolfe
dcc70bc541 Trim log message, make boolean check case insensitive 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-23 00:25:08 -04:00
Chef Expeditor
e90c6e35c4 Bump version to 4.18.118 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-05-22 15:54:55 +00:00
James Stocks
32fa14f1b0
Merge pull request #5039 from james-stocks/js/issue_5037 
Allow for waiver time as well as date
 2020-05-22 16:52:23 +01:00
Chef Expeditor
94c30647ed Bump version to 4.18.117 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-05-22 15:10:46 +00:00
James Stocks
23ed9bcf06
Merge pull request #5007 from inspec/cw/reporters-as-plugins 
Reporters as Plugins
 2020-05-22 16:10:29 +01:00
Chef Expeditor
0794051417 Bump version to 4.18.116 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-05-22 10:29:55 +00:00
James Stocks
7085adf5e5
Merge pull request #5017 from inspec/ns/inspec_json_in_archive 
Stores output of `inspec json` to archive and artifact
 2020-05-22 11:29:35 +01:00
Clinton Wolfe
3184d5ca9e Add an object model for run_data 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-20 13:27:20 -04:00
James Stocks
350c0bfe8f Handle waiver expiration dates being YAML strings 
This is technically incorrect YAML, but if you transcode YAML between several tools you may end up with a date/time value being an explicit string.
It would be helpful if InSpec supported any string value that easily translates to a Time.

Signed-off-by: James Stocks <jstocks@chef.io>
 2020-05-20 15:00:43 +01:00
James Stocks
35e36ad40a Allow for waiver time as well as date 
Fixes #5037

The YAML parser may parse a waiver timestamp as a Time rather than a Date. Even when the user doesn't care about time, they may be using a tool that outputs YAML with trailing zeroes for hour, minutes, seconds etc.

Signed-off-by: James Stocks <jstocks@chef.io>
 2020-05-20 14:59:07 +01:00
Nick Schwaderer
989d86c2ce Stores output of inspec json to archive and artifact 
Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
 2020-05-20 12:34:17 +01:00
Chef Expeditor
e924364565 Bump version to 4.18.115 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-05-20 11:33:26 +00:00
Nick Schwaderer
e882bc727e Update for incoming ruby openSSL deprecations 
Fixes #5031

See above issue for full context, this updates to the latest rubocop requirements for incoming ruby OpenSSL deprecations

Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
 2020-05-19 15:37:24 +01:00
Clinton Wolfe
c5e347bae5 Implement silencing deprecations 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-14 12:17:55 -04:00
Clinton Wolfe
8ec249e0cc Copy in reporter message size limiter code from core reporter base 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-12 17:04:19 -04:00
Clinton Wolfe
36069943c4 Add ability to generate reporter plugins using inspec init 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-12 17:00:44 -04:00
Chef Expeditor
6b45777e81 Bump version to 4.18.114 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-05-11 23:09:52 +00:00
Clinton Wolfe
ee095a244a Soften the exception to a warning when the input is not parseable 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-07 10:47:57 -04:00
Chef Expeditor
caa6a300bc Bump version to 4.18.113 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-05-07 11:54:51 +00:00
James Stocks
2103b52dbe
Merge pull request #4994 from james-stocks/js/json 
Reporter options to truncate message and suppress stacktrace
 2020-05-07 12:54:34 +01:00
James Stocks
1d67349214 Do not inject config to base reporter 
The base reporter class should access the InSpec config cache, instead of the runner needing to inject config into the base reporter

Signed-off-by: James Stocks <jstocks@chef.io>
 2020-05-06 15:24:15 +01:00
Chef Expeditor
12b41fc183 Bump version to 4.18.112 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-05-06 10:50:57 +00:00
Clinton Wolfe
849bd90930 Parse CLI inputs as booleans 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-05 18:17:40 -04:00
Clinton Wolfe
acfda5a735 Clarify names of examples and a method 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-05 17:59:20 -04:00
Clinton Wolfe
e8d80dd3cd Update docs 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>

Linting

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-05 17:37:23 -04:00
Clinton Wolfe
5e69e3bab6 Allow complex inputs on CLI 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-05 17:37:23 -04:00
Clinton Wolfe
d9f2cdb171 Fix for #4977 by adding a cleanup function for CLI inputs 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-05 17:37:23 -04:00
Clinton Wolfe
47baa59ed8 Add comment tracking when reporters will migrate 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-05 16:51:31 +01:00
Clinton Wolfe
5a7a48bb62 Basics of a working reporter plugin system 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-05-05 16:51:31 +01:00
Chef Expeditor
d9e5b65e3d Bump version to 4.18.111 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-05-05 10:28:20 +00:00
Nick Schwaderer
87d7978340
Merge pull request #5001 from inspec/ns/investigate_waivers_and_namespace_clashing 
Allows input and control to have the same name
 2020-05-05 11:28:03 +01:00
Nick Schwaderer
a1129f9efc Allows input and control to have the same name 
In https://github.com/inspec/inspec/issues/4936 the issue was reported that naming an input the same as a control caused an unexpected failure.

In that particular case, the naming was a result of a pre-waivers workaround which is no longer necessary, but ultimately a breakage of that name clash is an unexpected occurrance.

Due to how inputs are named and registered, `__apply_waivers` thinks that an object is a waiver that is not a waiver and tries to process it. On the micro level, it breaks when trying to pass a variable to a string as if it were a Hash.

It is imperative that we preserve 100% of the current featureset, pass our tests, and fix this edge case along with new test coverage for the failure.

This PR updates the code to do a slightly more elegant and small ‘waiver check’ to stop the namespace clash from breaking our code.

Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
 2020-05-05 10:00:19 +01:00
Chef Expeditor
3616ac21dc Bump version to 4.18.110 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-05-04 16:01:32 +00:00
James Stocks
69fb6e0782 Move reporter option handling to base 
They don't need to be json specific, they should apply to any reporter if the user has chosen these settings.

Signed-off-by: James Stocks <jstocks@chef.io>
 2020-05-04 15:24:50 +01:00
James Stocks
ae66aee2b2 (WIP) Reporter options to truncate message and suppress stacktrace 
TODO: Option names are not JSON specific but only json reporter has been implemented.

Signed-off-by: James Stocks <jstocks@chef.io>
 2020-05-04 15:24:50 +01:00
Chef Expeditor
2e887a94af Bump version to 4.18.109 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-05-01 14:22:05 +00:00
Clinton Wolfe
5a7ad0c352 Don't be obnoxious 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-04-30 15:36:25 -04:00
Clinton Wolfe
131d6678de Fix for prematurely warning when checking for input value 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-04-24 16:38:57 -04:00
Clinton Wolfe
e88dab4365 Update message when input has no value 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-04-24 14:13:07 -04:00
Chef Expeditor
b46b68ccd1 Bump version to 4.18.108 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-04-23 15:18:13 +00:00
James Stocks
14a85eba93
Merge pull request #4992 from inspec/ns/bump_method_source_version 
Bumps method_source dependency version
 2020-04-23 16:17:52 +01:00
Chef Expeditor
9200fec420 Bump version to 4.18.107 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-04-22 15:24:06 +00:00
Chef Expeditor
842d276bd3 Bump version to 4.18.106 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-04-22 08:10:56 +00:00
Clinton Wolfe
ad7569103e Alter inspec shell prompt to silence deprecation warning 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-04-21 16:38:21 -04:00
Clinton Wolfe
913dcac4b3 Alter call into Pry::Output to match new API and get shell tests passing 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-04-21 15:36:08 -04:00
John Snow
8d676f6ed2 Fix typo's after review 
Signed-off-by: John Snow <thelunaticscripter@outlook.com>
 2020-04-20 09:50:58 -04:00
John Snow
03c012e3c9 Add additional debug logging for automate login 
Signed-off-by: John Snow <thelunaticscripter@outlook.com>
 2020-04-17 15:50:40 -04:00
Chef Expeditor
7fa8d1ca68 Bump version to 4.18.105 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-04-09 16:18:16 +00:00
Clinton Wolfe
4f61e37395
Fixes for tests under ruby 2.7 (#4970) 
Fixes for tests under ruby 2.7
 2020-04-09 12:17:53 -04:00
Clinton Wolfe
a8b04769ca Ignore deprecation warning in fileutils and rubygems gems under ruby 2.7 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-04-08 10:56:55 -04:00
Chef Expeditor
c6f09eb6fb Bump version to 4.18.104 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-04-07 12:04:57 +00:00
Chef Expeditor
daca7a54a1 Bump version to 4.18.103 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-04-06 09:24:20 +00:00
James Stocks
951fcc9553
Merge pull request #4954 from tecracer-theinen/feature/virtualization-detection 
Improve virtualization resource
 2020-04-06 10:23:58 +01:00
Chef Expeditor
8a001d979d Bump version to 4.18.102 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-04-02 08:46:21 +00:00
James Stocks
502ad67eb8
Merge pull request #4949 from tecracer-theinen/theinen/source-option 
Add support for alternate Gem source for plugin installation/search
 2020-04-02 09:46:00 +01:00
Chef Expeditor
45eb3666c4 Bump version to 4.18.101 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-03-20 14:38:53 +00:00
Thomas Heinen
61646ad3af Add support for alternate Gem sources for plugin installation/search 
Signed-off-by: Thomas Heinen <theinen@tecracer.de>
 2020-03-19 11:40:18 +01:00
Axuba
b36113b7b7 Fix service not working correctly on windows machines 
Signed-off-by: Axuba <ajubanyjuarez@gmail.com>
 2020-03-15 21:14:23 +01:00
Thomas Heinen
6a90c10ae3 Improve virtualization resource 
Signed-off-by: Thomas Heinen <theinen@tecracer.de>
 2020-03-11 17:46:32 +01:00
Chef Expeditor
2f5f919ee1 Bump version to 4.18.100 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-03-03 16:55:47 +00:00
Clinton Wolfe
5f0638d3ed
Fix platform detection on hab (#4934) 
Fix platform detection on hab
 2020-03-03 11:55:28 -05:00
Clinton Wolfe
7939efa58c Switch platform properties to use brackets instead of dot notation 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-03-02 20:43:44 -05:00
Chef Expeditor
dd708effd5 Bump version to 4.18.99 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-03-03 00:59:51 +00:00
Clinton Wolfe
00a9f0966a
Explicitly require the compliance fetcher (#4938) 
Explicitly require the compliance fetcher
 2020-03-02 19:59:34 -05:00
Clinton Wolfe
628b9fb78b Explicitly require the compliance fetcher 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-03-02 17:33:56 -05:00
Chef Expeditor
3102a68a6c Bump version to 4.18.98 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-03-02 20:12:53 +00:00
Clinton Wolfe
505c28eadb Make platform release optional 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-02-27 11:41:43 -05:00
Chef Expeditor
b5e9d3d55f Bump version to 4.18.97 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-24 23:18:11 +00:00
Clinton Wolfe
231c4bf048 Rollback library eval context de-meta-programming 
This broke creation of custom resources in resource packs,
and also made privrivea resource registries too private.

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-02-21 16:36:47 -05:00
Chef Expeditor
366cbd87b0 Bump version to 4.18.96 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-20 18:33:15 +00:00
Chef Expeditor
7888738cc0 Bump version to 4.18.95 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-18 18:04:09 +00:00
Clinton Wolfe
5b81c5ad39
In habitat, train-* are system gems (#4897) 
In habitat, train-* are system gems
 2020-02-18 13:03:49 -05:00
Chef Expeditor
0fc7db1d51 Bump version to 4.18.94 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-14 15:27:25 +00:00
Ross Moles
e7f01151f0 Merge branch 'master' into oracledb_session_resource 2020-02-14 10:50:10 +00:00
Clinton Wolfe
6ca16792e7 Only activate train user plugin gems after we have determined if they are system or user 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-02-13 18:38:55 -05:00
Chef Expeditor
517e0733fe Bump version to 4.18.93 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-13 21:25:34 +00:00
Chef Expeditor
3f05bb1f75 Bump version to 4.18.92 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-13 20:13:07 +00:00
Clinton Wolfe
03d394a51b
Fix auditd resource processing of action and list (#4665) 
Fix auditd resource processing of action and list
 2020-02-13 15:12:47 -05:00
Chef Expeditor
94dbbccfca Bump version to 4.18.91 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-13 18:46:27 +00:00
Ross Moles
71ee45c70e Add missing @ to bin in command builder 
Signed-off-by: Ross Moles <rmoles@chef.io>
 2020-02-13 15:49:26 +00:00
Ross Moles
f0293e0e5a remove send 
Signed-off-by: Ross Moles <rmoles@chef.io>
 2020-02-13 10:29:09 +00:00
Ross Moles
87998c9830 update unit test 
Signed-off-by: Ross Moles <rmoles@chef.io>
 2020-02-12 18:18:54 +00:00
Ross Moles
babd4aebf8 resolve code climate errors 
Signed-off-by: Ross Moles <rmoles@chef.io>
 2020-02-12 17:12:12 +00:00
Ross Moles
f375a471e1 Refactor oracledb_session resource 
Signed-off-by: Ross Moles <rmoles@chef.io>
 2020-02-12 16:24:23 +00:00
Chef Expeditor
b557eaff7e Bump version to 4.18.90 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-11 21:07:54 +00:00
Chef Expeditor
38919fbd18 Bump version to 4.18.89 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-11 03:13:05 +00:00
Ryan Davis
3e3dbdc8f1
Merge pull request #4898 from inspec/zenspider/system-plugin/fixes 
Distinguish between user plugin gems and system gems and load system gems normally.
 2020-02-10 19:12:49 -08:00
Chef Expeditor
2c7336ad32 Bump version to 4.18.88 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-11 02:57:42 +00:00
Chef Expeditor
a27562339b Bump version to 4.18.87 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-11 02:38:50 +00:00
Miah Johnson
7bb0bb2188
Merge pull request #4865 from inspec/jh/schema-improvements 
Jh/schema improvements
 2020-02-10 18:38:28 -08:00
Miah Johnson
bf7931bc76 ui doesn't exist here yet, we're pre-ui'ish. So lets just call exit 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2020-02-10 14:55:27 -08:00
Miah Johnson
8be265772b fixup_train_plugin_status should not activate gems. 
This is handled by load_all already.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2020-02-10 14:52:12 -08:00
Chef Expeditor
969b9056c8 Bump version to 4.18.86 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-10 20:36:23 +00:00
Clinton Wolfe
774b5944fb
Detect install type via install path (#4856) 
Detect install type via install path
 2020-02-10 15:36:04 -05:00
Ryan Davis
3eac105498 Distinguish between core gems and system gems and load system gems normally. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-07 14:40:56 -08:00
Chef Expeditor
961b3662c4 Bump version to 4.18.85 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-06 20:25:55 +00:00
Clinton Wolfe
8a05908a87 Don't try to fool Thor's option type checker for --airgap on archive command 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-02-06 11:02:50 -05:00
Miah Johnson
4f642e0942 Clean up schema PR. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2020-02-05 17:06:55 -08:00
Jacob Henry
724f82237b Revision of schema to JSON Schema draft 7 
Signed-off-by: Jacob Henry <jchenry@mitre.org>
 2020-02-05 17:05:47 -08:00
Clinton Wolfe
f8d99eabb9 Move path_exist test code into test file 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-02-05 12:15:48 -05:00
Chef Expeditor
3f1349b054 Bump version to 4.18.84 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-04 19:54:51 +00:00
Chef Expeditor
9f2b621f9b Bump version to 4.18.83 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-04 00:42:29 +00:00
Ryan Davis
cac6b88c03 Fixed error on ruby 2.4 because define_method was private. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 14:41:37 -08:00
Ryan Davis
89a0b44c64 Refactored and moved Resource.create_dsl to ProfileContext. 
ProfileContext#to_resources_dsl is the only usage of it.
The responsibility for this code should be on ProfileContext.

Refactored a majority of #create_dsl to be a 2-line long Module.new
instead of 36 lines. Much less magic. Still has an anonymous module
but it is now much easier to address and debug.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 14:41:37 -08:00
Ryan Davis
fa3122cbff Removed metaprogramming in Inspec::Backend. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 14:41:37 -08:00
Ryan Davis
cea752a01d Tweak for aws resources to determine if they're still under test. 
Everyone now has an `inspec` method, but the AWS ones still return
nil as their backend hasn't been set up.

This seems wrong...

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 14:41:37 -08:00
Ryan Davis
950c79319e Moved __register down to bookkeeping section. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 14:41:37 -08:00
Ryan Davis
b38a3b05f9 Reworked Resource.__register's metaprogramming to be as small as possible. 
Mostly involved pushing up all the regular initialize code to a
regular method, calling that, THEN doing super up to the resource
initialize.

This brings __register's Class.new to 5 lines.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 14:41:37 -08:00
Ryan Davis
43f520b4a8 Merged Inspec::Plugins::Resource to Inspec::Resource. 
This also removes Inspec::ResourceBehaviors and Inspec::ResourceDSL.

All class methods look like class methods.
All instance methods look like instance methods.

There is still too much clever going on with __register creating
another anonymous subclass, but I think I can work that out/down too.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 14:41:37 -08:00
Ryan Davis
44a006a05a Rename Inspec::Resource.supports to support_registry. 
To fix an already existing name collision between Inspec::Resource and
Inspec::Plugins::Resource.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:19:32 -08:00
Ryan Davis
f0a5ddd4df Simple refactoring + assign __resource_registry to the current if needed. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:19:32 -08:00
Ryan Davis
81dfe21a98 First pass reworking LibraryEvalContext. 
This takes 3 anonymous Class.new w/ no superclasses, no documentation,
and no obvious clue as to what anything is and drops it down to 2
Class.new w/ superclasses, documents what it can, and makes it much
more clear what is going on. (yet, still not clear)

It also actually uses LibraryEvalContext. Having names is important.
Probably more important than any of the rest of this diff.

One extra thing this adds is Module.find_class_instance_variable and
hooks it up to Resource.__resource_registry. This allows it to find a
class-level registry regardless of whether it was hidden in an
anonymous superclass or not.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:19:32 -08:00
Ryan Davis
07631a53e7 Added extra doco on our require method. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:19:32 -08:00
Ryan Davis
d7bae9de30 Mostly minor cleanup, clarification, and comments. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:19:32 -08:00
Ryan Davis
fdc281d19c Clean up the end of our custom require. 
There are only 2 options. Shortcutting one of them with a `require` just
makes it messy. Use `if`. It's really basic. Basic is good. Maybe we
should try to push towards basic and good. It would be work but make
us happier in the long run.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:18:56 -08:00
Ryan Davis
51b65f6c2e Overhaul Platform#supported? 
+ State normal path first.
+ Use Enumerable to state your logic up front, don't build it into
  loops with breaks/returns.
+ Remove nonsensical duplication of key formats. (should push up or remove)
+ Had to add an extra test case that wasn't covered here but was in
  metadata_test.rb (why?!?)

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:18:56 -08:00
Ryan Davis
10cb92da48 Clean up Platform#params. 
State your normal case first, then deal with edge cases, not the other
way around.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:18:56 -08:00
Ryan Davis
aef285a1f6 Don't meta-program if you don't need to. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:18:56 -08:00
Ryan Davis
06ceba3f3d Add test for LEC to expose second-level libraries require. 
Not the best test in the world, but it is better than nothing.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:18:56 -08:00
Chef Expeditor
3cfd35f98f Bump version to 4.18.82 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-01 02:04:23 +00:00
Ryan Davis
2c7101df26 Fix minor style issues. 
I swear... rubocop hates me.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-31 18:01:01 -08:00
Chef Expeditor
4ab4b04bed Bump version to 4.18.81 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-01 01:51:56 +00:00
Chef Expeditor
d09656cdff Bump version to 4.18.80 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-01 01:38:34 +00:00
Ryan Davis
c79245cde3
Merge pull request #4869 from inspec/zenspider/crontab 
Refactored crontab resource
 2020-01-31 17:38:12 -08:00
Chef Expeditor
c3a37ee126 Bump version to 4.18.79 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-01 00:42:32 +00:00
Ryan Davis
c70f73dc96
Merge pull request #4864 from inspec/zenspider/resource/inspect 
Added --inspect option to inspect shell command.
 2020-01-31 16:42:00 -08:00
Chef Expeditor
01b9bacaa1 Bump version to 4.18.78 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-01 00:41:46 +00:00
Ryan Davis
cc1393bb9a
Merge pull request #4822 from PiQuer/master 
make command.exist? POSIX conform
 2020-01-31 16:41:27 -08:00
Chef Expeditor
09e0bc63da Bump version to 4.18.77 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-31 22:29:39 +00:00
Chef Expeditor
d83ead45f9 Bump version to 4.18.76 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-31 01:21:42 +00:00
Chef Expeditor
7e258f8944 Bump version to 4.18.75 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-30 16:04:33 +00:00
Chef Expeditor
f69d76e4a0 Bump version to 4.18.74 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-30 00:36:49 +00:00
Ryan Davis
a79eb417a0 the correct, un-panicked fix. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-29 16:35:11 -08:00
Chef Expeditor
fb81c806b5 Bump version to 4.18.73 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-30 00:25:39 +00:00
Ryan Davis
622ae78d9a bad master merge... rushing this through 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-29 16:24:35 -08:00
Chef Expeditor
5c6be7b936 Bump version to 4.18.72 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-30 00:19:44 +00:00
Ryan Davis
f2155a64ed
Merge pull request #4843 from michaellihs/master 
Add support for yocto linux in service resource
 2020-01-29 16:19:27 -08:00
Ryan Davis
19ce5df589
Merge pull request #4827 from inspec/mj/namespaces 
Move parsers under Utils
 2020-01-29 16:18:43 -08:00
Chef Expeditor
bb70c50961 Bump version to 4.18.71 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-30 00:08:10 +00:00
Ryan Davis
10406545ca
Merge pull request #4862 from inspec/zenspider/resources 
Fix up the platform on etc_hosts, virtualization, ini, and xml resources to fix OS disparity.
 2020-01-29 16:07:47 -08:00
Chef Expeditor
eaf2d7ca5b Bump version to 4.18.70 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-30 00:06:50 +00:00
Chef Expeditor
485aa93d90 Bump version to 4.18.69 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-29 23:50:00 +00:00
Ryan Davis
124b56b6ee
Merge pull request #4825 from inspec/zenspider/tarball 
Properly report errors with bad tarball files.
 2020-01-29 15:49:40 -08:00
Ryan Davis
2ae2bcf6fb
Merge pull request #4818 from JackChance/master 
replaced instances of `have_protocols` with `have_protocol` in docume…
 2020-01-29 15:46:25 -08:00
Ryan Davis
ceab1cbdac Refactored crontab resource 
Specifically the parsing was pretty unreadable. This refactoring
emphasizes using a default hash and merging in the differences for
what was parsed. Everything is funneled through one `merge_crontab`
method that does the actual parsing and the system vs user differences
are merged in after in their respective parse methods.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-29 13:56:11 -08:00
Clinton Wolfe
37455bdd11 Parallelize unit tests 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-29 16:15:58 -05:00
Clinton Wolfe
3419c84233 Make predicates private to reduce namespace pollution; added dockerenv check for docker mode 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-29 11:28:52 -05:00
Chef Expeditor
193905a827 Bump version to 4.18.68 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-29 16:03:44 +00:00
Ryan Davis
15f77941af Some cleanup on the apache_conf resource. 
The biggie to know is that all the extra read_content calls were
needlessly redundant with it also being called in initialize.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-28 14:53:37 -08:00
Ryan Davis
9c051da22b Fix platform on apache_conf to include all unix. 
Now discovers the first available conf file from a list of known
paths. Might have to expand based on various distros.

Had to tweak the tests because the mock loader mocks EVERYTHING every
time. :/

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-28 14:53:37 -08:00
Ryan Davis
8bd2528ef8 Added --inspect option to inspect shell command. 
* Removed Resource#inspect (calling to_s) to make debugging a happy experience.
* Added ResourceBehavior.toggle_inspect to add/remove a basic inspect.
* Added `--inspect` flag to `shell` command. Call toggle_inspect unless --inspect used.
* Cleaned up matchers.rb and removed most explicit calls to inspect.
* Added ResourceInspector to rspec's INSPECTOR_CLASSES.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-28 14:52:04 -08:00
Clinton Wolfe
357cf051b1 PR feedback part 1 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-28 11:06:12 -05:00
Chef Expeditor
41f3927e84 Bump version to 4.18.67 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-28 15:03:18 +00:00
Clinton Wolfe
46ade02401
Use an archive if possible when fetching fails and --airgap is… (#4806) 
Use an archive if possible when fetching fails and --airgap is provided
 2020-01-28 10:02:57 -05:00
Ryan Davis
df31f744f4 Fix up platform on filesystem resource. 
From linux to unix. This should work fine even on AIX, according to
the man pages.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-27 15:34:33 -08:00
Ryan Davis
65c44d22e2 Audited virtualization a bit. 
Cleaned up some code.
Reordered virtualization detection by order of probability.
Added TODOs for obvious problems.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-27 15:31:41 -08:00
Ryan Davis
f830ddeca6 Slimmed up and removed "clever" from file resource description. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-27 15:30:48 -08:00
Ryan Davis
b9d49e0fed Fix up the platform on etc_hosts, virtualization, ini, and xml resources to fix OS disparity. 
+ File format oriented resources should always be `os`.
+ virtualization should (in theory) be any unix (tho, it currently seems wrong).
+ etc_hosts should be any (reasonable) unix.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-27 15:29:52 -08:00
Clinton Wolfe
76a9c3e590 Install-path based install context detection 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-27 13:29:37 -05:00
Clinton Wolfe
eac3b31095 PR feedback re: cache warming 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-27 11:01:15 -05:00
Chef Expeditor
2089bf80c7 Bump version to 4.18.66 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-27 15:51:46 +00:00
Clinton Wolfe
31d2383285
Missing end quote in oracledb_session (#4852) 
Missing end quote in oracledb_session
 2020-01-27 10:51:25 -05:00
Chef Expeditor
cafb4f3e3e Bump version to 4.18.65 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-27 15:31:19 +00:00
Miah Johnson
89549bd884 Missing end quote. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2020-01-24 12:00:00 -08:00
Chef Expeditor
6434009051 Bump version to 4.18.64 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-24 17:40:12 +00:00
Ryan Davis
faf7833559 Clarified service logic logic for redhat flavors. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-23 16:36:44 -08:00
Ryan Davis
ad6ffcccd6 Switch Service#select_service_mgmt from huge if statement to case. 
Having a ton of conditions with `%w{one-string}.include?(platform)` is
incredibly wasteful and slow. Apparently about 17x slower:

```
Calculating -------------------------------------
          include_eh    529.315k (± 3.2%) i/s -      2.675M in   5.058296s
       include_or_eq    909.795k (± 1.5%) i/s -      4.568M in   5.022491s
           case_when      9.043M (± 2.8%) i/s -     45.443M in   5.029499s

Comparison:
           case_when:  9042590.3 i/s
       include_or_eq:   909795.2 i/s - 9.94x  slower
          include_eh:   529315.0 i/s - 17.08x  slower
```

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-23 16:36:36 -08:00
Ryan Davis
8f4bac23eb Refactor some of resources/service.rb 
Starting with: normalizing a huge if in select_service_mgmt to only
use strings.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-23 16:33:15 -08:00
Chef Expeditor
d013ac1e47 Bump version to 4.18.63 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-23 18:09:12 +00:00
Noel Georgi
7ac25401bb
Add: content option for x509_certificate 
Signed-off-by: Noel Georgi <git@frezbo.com>
 2020-01-22 13:49:35 +05:30
Chef Expeditor
7da7c2774b Bump version to 4.18.62 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-21 21:18:34 +00:00
Raimar Sandner
fa2f2c2caa make command.exist? POSIX conform 
With the current implementation, on a Linux system without bash
command.exist? always returns false. 'sh -c' is guaranteed to exist on a
POSIX-conform system [1] whereas 'bash -c' only works if bash is
actually installed.

[1] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/sh.html

Obvious fix.
 2020-01-19 00:05:33 +01:00
Michael Lihs
edd93eea81 Add support for yocto linux in service resource 
Signed-off-by: Michael Lihs <michael.lihs@thoughtworks.com>
 2020-01-18 01:26:16 +01:00
Chef Expeditor
356de23c5c Bump version to 4.18.61 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-15 21:02:41 +00:00
Ryan Davis
9bd07954a6
Merge pull request #4833 from inspec/zenspider/mac/groups 
Fixed duplicate groups on osx by merging members by gid.
 2020-01-15 13:02:24 -08:00
Chef Expeditor
8cede82c20 Bump version to 4.18.60 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-15 20:37:45 +00:00
Clinton Wolfe
4c270efe78
upstream is basic_auth_only not basic_auth (#4834) 
upstream is basic_auth_only not basic_auth
 2020-01-15 15:37:26 -05:00
Chef Expeditor
d4481b82fb Bump version to 4.18.59 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-14 21:07:12 +00:00