mirror of
https://github.com/bevyengine/bevy
synced 2024-11-22 12:43:34 +00:00
e0c296ee14
> Follow up to #11600 and #10588 @mockersf expressed some [valid concerns](https://github.com/bevyengine/bevy/pull/11600#issuecomment-1932796498) about the current system this PR attempts to fix: The `ComputedTextureSlices` reacts to asset change in both `bevy_sprite` and `bevy_ui`, meaning that if the `ImageScaleMode` is inserted by default in the bundles, we will iterate through most 2d items every time an asset is updated. # Solution - `ImageScaleMode` only has two variants: `Sliced` and `Tiled`. I removed the `Stretched` default - `ImageScaleMode` is no longer part of any bundle, but the relevant bundles explain that this additional component can be inserted This way, the *absence* of `ImageScaleMode` means the image will be stretched, and its *presence* will include the entity to the various slicing systems Optional components in bundles would make this more straigthfoward # Additional work Should I add new bundles with the `ImageScaleMode` component ? |
||
|---|---|---|
| .. | ||
| borders.rs | ||
| button.rs | ||
| display_and_visibility.rs | ||
| flex_layout.rs | ||
| font_atlas_debug.rs | ||
| grid.rs | ||
| overflow.rs | ||
| overflow_debug.rs | ||
| relative_cursor_position.rs | ||
| render_ui_to_texture.rs | ||
| size_constraints.rs | ||
| text.rs | ||
| text_debug.rs | ||
| text_wrap_debug.rs | ||
| transparency_ui.rs | ||
| ui.rs | ||
| ui_material.rs | ||
| ui_scaling.rs | ||
| ui_texture_atlas.rs | ||
| ui_texture_slice.rs | ||
| viewport_debug.rs | ||
| window_fallthrough.rs | ||
| z_index.rs | ||