Kurt
f77a8ecfbd
Fix comment
...
wasn't sync'd :(
2021-06-10 23:29:03 -07:00
Kurt
24d6c0d713
Change "Some" EV train rating from [0,127] to (0,127]
2021-06-10 19:18:58 -07:00
Kurt
6b6a517214
Add xmldoc
...
Add some xmldoc to summarize recent changes to these properties.
See:
Co-Authored-By: LukeThe <54759100+LukeThe@users.noreply.github.com>
#3213
#3215
2021-06-10 18:14:38 -07:00
Kurt
f266b4f686
Crop Item sprites, Layer with adjusted X coordinate ( #3215 )
2021-06-10 18:07:26 -07:00
Kurt
6029c15521
Fix incorrect GameVersion reference
2021-06-09 22:56:19 -07:00
Kurt
f984862f48
Extract catchrate check
2021-06-09 22:54:21 -07:00
Kurt
49b7d4522c
Sync missing change
2021-06-09 18:40:17 -07:00
Kurt
2083201ee1
Add ObjectType custom filter logic
2021-06-08 20:28:13 -07:00
Kurt
2abf95cdf8
Minor clean
...
expand some expressions, extract some methods, add comments
2021-06-08 20:14:55 -07:00
Kurt
71fd8b36e9
Enable batch filters for encounter database
2021-06-08 20:14:27 -07:00
Kurt
910fce9812
Change namespace to usual PKHeX.WinForms.Controls
...
no more oddball namespaces
2021-06-07 20:04:01 -07:00
Kurt
f529fd1432
Add xmldoc, split out some operations
2021-06-07 20:03:14 -07:00
Kurt
035584dc7c
Extract templating from EditPKMUtil, rename methods
2021-06-07 20:02:57 -07:00
Kurt
f7423daf7a
Add array sanitization if error was thrown
2021-06-07 19:59:08 -07:00
Kurt
a07549f013
Extract sketch valid check
...
GetCanKnowMove should be checking for Smeargle knowing thousand arrows/waves.
GetNeededMoves should also return 1ka/1kw for needed moves, and then no encounters.
All uses of InvalidSketch are behind that method, so any future Smeargle modifications (like sketching a dummied move) will be checked (yay BDSP considerations).
2021-06-06 23:36:59 -07:00
Kurt
c98717bdc0
Fix namespaces
2021-06-06 23:34:15 -07:00
Lusamine
e66d5eaad5
Remove another duplicated distribution index
...
Index 24 is the same as 26, but they cross epochs from base to DLC1.
Keep the later one since it encompasses all legal Wild Areas.
2021-06-06 21:46:23 -05:00
Kurt
871de4e213
Add more xmldoc
2021-06-06 11:56:54 -07:00
Kurt
bad65dd4ec
Enhance debugging obj->ToString indications for evo checks
2021-06-06 11:49:41 -07:00
Kurt
bf400f27fe
Add optional form param for learn check
2021-06-06 11:49:13 -07:00
Kurt
200bdbd553
Sanity check form prior to yield checks
2021-06-06 11:48:54 -07:00
Alberto Tudela
b173c659d7
Update spanish translations ( #3212 )
2021-06-05 17:21:39 -07:00
Lusamine
72b4975429
Remove inaccessible water nest encounters
2021-06-05 18:11:19 -05:00
Lusamine
aee35cbe81
Clean up duplicated distribution indices
...
Removes duplicates if every encounter in the same index is the same as a
previous index. The following were affected, and only the first index
was retained.
- 5, 7 (Index 2 has 1 move different on 1 mon)
- 3, 4
- 11, 13
- 16, 18
- 27, 28, 30, 32
- 33, 35
- 36, 38
- 42, 44
- 45, 47
- 48, 50, 52
- 53, 55, 57
- 59, 61
2021-06-05 16:33:41 -05:00
Kurt
6ee67e624d
Update gen2/3 setdex's too
2021-06-04 17:29:55 -07:00
Kurt
d30e00ffbe
Clean up SetDex guard clauses
...
add egg checks for gen4-6/8, group species bound checks
2021-06-04 17:26:06 -07:00
Kurt
7ee60d9e98
Update Zukan4.cs
...
Set seen after gender-seen, as we check seen in that method (first or second seen gender).
2021-06-04 17:19:12 -07:00
Kurt
e32daee3f3
Add setting to disable loading plugins
2021-06-04 14:19:22 -07:00
Kurt
3a1fbc9b88
Don't pass key byref
...
Pass byval and return the result; emits less IL
mark for inlining
2021-06-04 14:19:07 -07:00
Kurt
ad79833420
Update EncounterEvent.cs
2021-06-04 13:53:02 -07:00
Kurt
8222297da8
Remove enumerating when loading event templates
...
Just allocate the parent array and pass it to HashSet; having an ICollection, prevents resizing repeatedly and gc'ing the temp array is cheap.
Actually, only create a hashset if we're adding a gift from external DB. Saves on that allocation, and keeps the final result as an array (fastest iterating).
2021-06-04 13:48:02 -07:00
Kurt
041074f26c
Decrypt sav8 blocks in-place
...
Removes 1.5MB of allocation; we don't need to preserve the encrypted state.
Revise savefile clone operation to use its own constructor, as we need to call the base constructor first (backup file clone...) prior to decrypting.
Expose CryptStaticXorpadBytes as GetDecryptedRawData no longer exists.
2021-06-04 13:16:00 -07:00
Kurt
3764e60b37
Show extra details for exported legality results (debug only)
...
same as encdb showing full encounter details, spit them out here too.
2021-06-03 17:59:53 -07:00
Kurt
64039b4070
Force shiny state of raids
...
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-06-03 17:50:48 -07:00
Kurt
5636e1ef4a
Add setting to hide unavailable species.
...
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-06-03 17:48:32 -07:00
Kurt
34ec5416e5
Add setting to disable return-none if empty criteria
...
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-06-03 17:36:16 -07:00
Kurt
9ba683688e
Clear tooltips when changing results
...
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-06-03 17:32:13 -07:00
Kurt
927ccee613
Cache all created regexes
...
Regex objects aren't cheap, and the RegexCache has DefaultMaxCacheSize = 15.
We're checking 4,000 regexes for each unique string, so just keep the created regexes around instead of cycling new through the cache.
+4MB passive consumption, but each IsFiltered call no longer generates >4MB of discarded objects.
My unit tests run >25% faster now... nice?!
2021-06-03 17:24:45 -07:00
Kurt
8ec25da194
Condense expression
...
single bool branch
2021-06-03 17:08:42 -07:00
sora10pls
a2492eddd9
Add Frog distribution raids
2021-06-03 20:07:07 -04:00
Kurt
066aedfc21
Separate scblock ctor's
...
No longer need to set byte[] twice
Add value-setter checks for bad mutations (size change, bool1<->bool2 only)
2021-06-03 12:35:39 -07:00
Kurt
8c970ec991
Minor tweaks
...
no functional change, readability++
add more xmldoc
2021-06-03 12:04:19 -07:00
Kurt
7e32ff9b03
Add settings to toggle loading of saves for pkmdb
...
https://projectpokemon.org/home/forums/topic/58942-question-about-custom-backup-path-pkm-database-path-avoid-to-scan-sub-folders/
2021-06-02 10:52:20 -07:00
Kurt
b81df689e6
Pass gender to moveset dreamworld entries
...
Oops.
ty anubis for notifying me
2021-06-01 13:54:43 -07:00
Kurt
138501da2f
Minor clean
...
Condense some expressions
Use less linq
Rename some fields
2021-05-29 15:31:47 -07:00
sora10pls
ba9e917647
Display typed sprites for Arceus/Silvally formes
2021-05-28 19:22:50 -04:00
Kurt
64dbb9ae74
Abstract filter matching
...
Similar to prior commit adding modifications and suggestions
2021-05-27 14:43:32 -07:00
Kurt
05e37eb073
Extend batch editing to allow for plugins to add new mods
2021-05-27 12:20:00 -07:00
Kurt
7a8d75aec4
Show gender in encounter browser
...
Extract methods, add some comments, simplify array fetch.
2021-05-27 10:27:50 -07:00
Kurt
386d9cc94f
Repoint hall data fetches outside blocks
...
Reverts prior commit repointing which was incorrect; these are outside the sav general/storage blocks.
871f9b0627 (diff-3560dca7e50959e98ae8fa32d9403f8846b9243815d653c78a07f2a3455a1874L481)
Keep the first as General as it's some value index within the General block used to index which extrablock matches it, or something
Closes #3211
2021-05-25 22:16:04 -07:00