Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-23 10:53:10 +00:00
Code Issues Projects Releases Packages Wiki Activity
6870 commits 3 branches 76 tags 119 MiB
Commit graph

2988 commits

Author SHA1 Message Date
Kurt
a88c7c4800 Add more trainer card/status fields & stats 
Closes #2658 ty @CanoeHope !
Mostly just serves as documentation; with the amount of fields being editable increasing, hard-coded GUI might not be optimal here. I'm thinking something like a PropertyGrid based on the selected block which will pull up the Block object if the key matches... for fields, something like a dynamically populated list or something.
 2020-01-23 18:31:10 -08:00
Egzon
a5985536e2 Miscelanous fix on Underground Scores (#2657) 
* UG scores are uint32, with max value up to 999999.

* fixing label position

* another positioning fix!
 2020-01-23 16:37:39 -08:00
Kurt
ecfcbbc4cb Verify full raid result with known seed 2020-01-23 00:11:07 -08:00
Kurt
467045e95c Swap rand call order, rename as overload 2020-01-22 19:04:20 -08:00
Kurt
ba5cc26e83 Add indication to which blocks changed 
Use reflection to grab all const declarations (private and public), and grab the name of that const. Whenever that block is mentioned in our diff, use the name instead of the key.

Helps identify what changed / remove noise if you don't care about that block.
 2020-01-22 17:06:23 -08:00
Kurt
4ea2be250f Add TitleScreen8 and Trainer Card team structs 
Closes #2653 , ty @CanoeHope !

Editable from the Trainer Info button, comes with a Copy From Party button for each.
 2020-01-21 23:23:27 -08:00
Egzon
9cce65e937 Fix Subway Super checks (#2652) 
Oops, it's actually a byte...
 2020-01-21 11:00:09 -08:00
Kurt
d9c162b5cf Fix criteria comparison 
Closes #2651
 2020-01-21 09:05:39 -08:00
Kurt
5be9c6bcc8 Remove unnecessary null handling 
objects are no longer null
 2020-01-20 23:32:05 -08:00
Kurt
5bb51b07ac Check Footprint Ribbon for gen8 
gen7 used same as gen6, we just need to restrict gen!=8
add placeholder LGPE origin check; that'll likely throw a wrench into things when HOME happens (next month?).
 2020-01-20 23:09:28 -08:00
Kurt
b84cae9ff5 Fix box name write for sav8swsh 
only used via the view-all-boxes popup when switching boxes
ty anubis!
 2020-01-20 22:04:52 -08:00
Kurt
6fdc71b2e4 Update tower record set 
Record ID const declaration for reuse
Change 255->300 for streak max
Set record as well (ignore currently set value if modified via dropdown)
Closes #2649

Not sure if Money and BP can get a similar record-set treatment.
 2020-01-20 18:16:46 -08:00
Egzon
1a3d8b1fab Fix Seedot and Nuzleaf swarm moves (#2648) 2020-01-20 14:31:59 -08:00
Archit Date
117bb35621 handle smogon sets with multiple moves (#2647) 
sometimes competitive sets have multiple moves in one slot as optional coverage moves. Handle these cases by splitting and trimming over '/'.  Example: https://pastebin.com/raw/jvPziRdC (The dusk mane set)
 2020-01-19 22:30:09 -08:00
Kurt
40e5cd66da Add block diff for swsh, add bool type toggle 
Apparently my copypaste of the class didn't delete all the old unused controls. Ha!

Move non-gui logic to core as separate classes, in case ppl wanted to reuse them in their own projects.
 2020-01-19 22:29:50 -08:00
Kurt
d788af45cd Unban HA mimikyu 
Only one encounter for mimikyu = A4 }, // Mimikyu
Update manual banlist to permit it
Closes #2646
 2020-01-19 19:02:53 -08:00
Kurt
a98ca2351d Don't SetValue to block if not exportable 
blank saves do not have the type metadata for the blocks that are spoofed, nor do they have all blocks spoofed.

I suspect things might get more difficult as more value-blocks are identified, which would throw a wrench into things. We'll figure that out at that time :)

Add a test to ensure that the blank save can be created correctly

Closes #2644
 2020-01-19 10:25:40 -08:00
Kurt
4567bba03f More elegant block read/write 
Removes TONS of unnecessary allocations, and is more simple
 2020-01-19 00:55:10 -08:00
Kurt
0244cc7489 Add more info to exception message 
Closes #2644
 2020-01-18 19:44:34 -08:00
Egzon Qukovci Jusufi
ab5016bf7d Add Subway Scores edition (#2643) 
* Add Subway Scores edition

* Changing the offsets handling

Simply use the block offset as the base and add them to it. Also allow edition on B2W2.
 2020-01-18 19:31:36 -08:00
Kurt
63ea57436f Make the template IV/contest stat array readonly 
See prior commits
no longer need to clone subarrays, they're shared immutable
 2020-01-18 19:11:29 -08:00
Kurt
643c0c1cc7 null/empty check -> check both 2020-01-18 17:33:19 -08:00
Kurt
843330a375 Remove unnecessary null checks 
this is a null free project /s
dont provide null, else u deserve to get an exception
 2020-01-18 16:57:25 -08:00
Kurt
8312c52cc1 Make Move[] readonly list 
contract: don't modify the template movesets
mystery gift now exposes IRelearn, remove unnecessary type checks
 2020-01-18 16:46:38 -08:00
Kurt
0cd9c47953 Make Relearn array for encounters readonly 
No change em
 2020-01-18 16:31:24 -08:00
Kurt
40c2c483fb Common1-3 => Bool1-3 
Blocks that use Bool1/2 toggle to the other state; evident when comparing between two different saves. The key doesn't change, only the Type is toggled.
 2020-01-18 14:19:01 -08:00
Kurt
9b0b0cb1a6 Add misc value r/w for trainer8 
Closes #2639
casting object to generic T : struct isn't valid, so just cast the get/set appropriately
 2020-01-17 23:25:02 -08:00
Kurt
2a7d475b5b Rearrange key list, add syntax sugar methods 2020-01-17 21:53:51 -08:00
Kurt
e4e1681e1c Clamp roto rally score to 99_999 
https://github.com/kwsch/PKHeX/issues/2639#issuecomment-575863541
 2020-01-17 21:09:54 -08:00
Kurt
e3cafe5cd6 Relocate getsize to extension method 
use sizeof for clarity, add test to ensure bool size is 1 byte (which is always true)
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/operators/sizeof
 2020-01-17 21:09:26 -08:00
Kurt
a590d3713b Refine enum with TypeCode names 
Add GetValue/SetValue/GetType extension methods
 2020-01-17 18:59:45 -08:00
Kurt
ff466826af Flip hgss trade flag state meaning 
Closes #2640
 2020-01-17 16:39:19 -08:00
Kurt
bd9ec72d98 Misc tweaks 
Add more direct legality analysis constructors
evo count is >= 1
fix invalid test message
disallow gen2 moves if transferred from gen1
use ^1 instead of len-1 for netcore test project
 2020-01-16 23:22:54 -08:00
Kurt
c739af4767 Extract item restrictions to separate class 
Move similar classes to folder
 2020-01-16 19:27:29 -08:00
Kurt
baf46f9a3a cache form/species/format on first get 
very minor perf consideration, since those values are immutable (except for cross thread shenanigans)
 2020-01-16 19:23:29 -08:00
Kurt
e97970023a Add swsh battle-only forms 2020-01-16 19:03:47 -08:00
Kurt
8315f740cb Merge branch 'master' of https://github.com/kwsch/PKHeX 2020-01-16 18:54:11 -08:00
Kurt
857124acf0 Swap zen galar -> galar zen 
ty showdown for changing your convention over a month ago
a01e2a26bc (diff-58e367765263b7e21df251b3e7619b70L9307)
 2020-01-16 18:54:09 -08:00
Egzon Qukovci Jusufi
deece433a5 Add SWSH Legends to the Tables (#2637) 2020-01-15 20:49:19 -08:00
Archit Date
22ed59d6a3 sanity check necrozma forms (#2638) 
smogon allows Dusk Mane as well as Dusk-Mane as their form argument
 2020-01-15 20:48:53 -08:00
Kurt
41f909c08a Add Roto Rally score, copy Jersey # to other block 
Closes #2635
 2020-01-15 20:48:19 -08:00
Kurt
aecc08f65c Remove duplicate electrode encounter 
3IV requirement isn't required for wild slots that are also at the same level-location
Closes #2636

ty @dstevenson12 !
 2020-01-14 18:39:25 -08:00
Kurt
f4162d2dce Add another corviknight location 
ty anubis
Closes #2633
 2020-01-13 22:36:00 -08:00
Kurt
726947eaf5 Add HGSS starter const/flags 
Closes #2634 ty @asterysx !
 2020-01-13 20:40:44 -08:00
Kurt
a6aabcdc96 Split out a method before crypto step 
Allows for capturing the obtaining the raw decrypted data via the PKHeX.Core api
 2020-01-13 19:03:27 -08:00
Kurt
2e16fb058c Show form arguments in gen6/7 
Clamp form argument load to current list bounds (used to throw arg range exception if invalid)
 2020-01-13 17:09:03 -08:00
Kurt
11978dab4f Make pgt ranger manaphy IsEgg true 2020-01-12 23:00:32 -08:00
Kurt
81f280f4d1 Update EncounterSuggestion.cs 
weaken legality check, we only check moves
 2020-01-12 20:49:33 -08:00
Kurt
5a20dc707d Rewrite encounter suggestions 
Don't clone legality templates, and keep suggested information minimal -- this isn't automod
 2020-01-12 19:40:36 -08:00
Kurt
eaeebea923 Remove another method shortcut 
EncounterSuggestion needs a facelift anyway
 2020-01-12 17:00:03 -08:00
Kurt
3b5c7062ac Minor perf improvement 
pass in, don't constantly fetch
helps generated IL code be slightly more efficient
 2020-01-12 16:49:12 -08:00
Kurt
a8c28369b6 Add Yamask-1 max hp calc for formArg compare 
Closes #2632 ty @CanoeHope
 2020-01-12 16:22:56 -08:00
Kurt
d5948b9dbe Add relearn moves to Except comparison 
Burn Up ho-oh is dumb
 2020-01-12 16:09:35 -08:00
Kurt
48fd36a9a2 Handle g4 shedinja learn case too 
change 291/292 to Shedinja/Ninjask for easy enum reference check
 2020-01-12 14:34:29 -08:00
Kurt
61ecb52347 Remove unnecessary allocation 2020-01-12 12:06:33 -08:00
Kurt
a305c00ac4 Reorder feebas evo for swsh, patch data 
Updated comment in #2394 with byte swap info
Forgot to check tests when importing patched data :)
 2020-01-12 11:48:42 -08:00
Kurt
82eaf39d45 Remove method alias for init mysterygift db 2020-01-12 11:41:23 -08:00
Kurt
9ed441885a Remove manual personal info fix 
Change FDDC from 47 -> 41
SM is 40, as the tutor isn't possible in that game.
 2020-01-12 11:39:43 -08:00
Kurt
f6fb54aecc Move shedinja/egg evo chain short circuit 
Some routes use the evolutiontree directly instead of this method (with the same name); should probably consolidate but meh

This causes Shedinja to yield the correct evolution chain when called directly (because nothing naturally evolves to shedinja; it's created out of thin air as a clone)

Take the egg short circuit with it to keep things simple
 2020-01-11 21:43:58 -08:00
Kurt
0eca1bbd1c g3 shedinja api usage fix 
see comments in src for justification
need ninjask moves if gen3; dl.Count is guaranteed to be >= 1
 2020-01-11 21:41:24 -08:00
Kurt
7cbf8d0fcf Set gen3 count ribbons appropriately 
ty anubis
 2020-01-11 15:51:25 -08:00
Kurt
7e6edbaded Remove unnecessary constructor 
Make key readonly
 2020-01-11 14:18:11 -08:00
Kurt
95f24a9d36 Revise suggested AV set logic 
Closes #2630
 2020-01-11 11:43:53 -08:00
Kurt
62c35194c3 Remove unnecessary form duration code 
probably misinterpreted the furfrou/hoopa stuff; probably is "SetMaxFormDuration"
d3f6d5935f (commitcomment-36754955)

ty @CanoeHope
 2020-01-10 22:16:30 -08:00
Kurt
d3f6d5935f Add form argument legality checks 
Closes #2611 (Alcremie)
Closes #2604 (Runerigus)
 2020-01-10 16:33:40 -08:00
Kurt
507868ce58 Merge branch 'master' of https://github.com/kwsch/PKHeX 2020-01-10 16:08:51 -08:00
Kurt
fdd321dd8c Make memory 6 fishy if textvar present 
Closes #2621
 2020-01-10 16:08:34 -08:00
Egzon Qukovci Jusufi
fe13b3374d Spanish Translations (#2625) 
* Update LegalityCheckStrings_es.txt

* Update lang_es.txt
 2020-01-10 16:03:28 -08:00
Kurt
be92d4436e Rearrange argument check order 
USUM evo table has Meowstic with Arg=-1, which early aborted.
Closes #2627
 2020-01-10 16:02:22 -08:00
Kurt
f291da8f32 Add 2 bw flags 
Closes #2628
 2020-01-10 15:53:26 -08:00
Kurt
718d00f970 Ban ha slowpoke-1 2020-01-09 23:50:15 -08:00
Kurt
cf06335a22 Update 20.01.10 
Update with latest events from EventsGallery
 2020-01-09 21:13:07 -08:00
Kurt
2915692daa Use more performant block lookup strategy 
Rather than storing a dictionary of keys, we can abuse the fact that the SCBlock[] is stored in order of ascending block key.
Binary Search doesn't require extra memory like a Dictionary would; also, we only need to find a few blocks.
 2020-01-09 19:00:49 -08:00
Kurt
51d2fc9d93 Update with slowpoke-1/new raid data 
TransferVerifier: Revise transfer check to allow slowpoke-1 (slowpoke-0 is flagged via next check)
 2020-01-09 18:44:45 -08:00
Kurt
3fa44361e6 Update block fetch & blank init 
blanks: {key,size}
fetch: get block by key (index isnt the same between patches, as blocks with different keys get added). The savefile stores them as a SortedDictionary (by key), hence the shifting.
 2020-01-09 08:59:26 -08:00
Kurt
bbd1aff5fe Add new lengths 
new format still crashes as block absolute index is now different
should do a different way of loading blocks (key instead of index)
 2020-01-09 08:17:41 -08:00
Kurt
0dd4d1fe7a Remove unnecessary casts 2020-01-06 17:50:18 -08:00
Kurt
efbac28b91 Rework accessors for PKMConverter trainer cache 
Might break downstream users, for the better. Internal behavior had to change!
 2020-01-05 21:51:02 -08:00
Kurt
1906a1040f Relocate console-location data setting to PKMConverter 
When adding data, check if the current Trainer has valid console data; if not, use a default value.
 2020-01-05 21:41:32 -08:00
Kurt
3d581283c2 Minor clean 
move Text.cs manual Courier new() to the designer, have it dispose when form is disposed. Set it as the numericupdown's font and just reuse that :)
 2020-01-05 18:46:30 -08:00
Kurt
7caeebd772 Add formcount for scatterbug/spewpa 
USUM had 20 for both, but XY/AO/SM had only 1 (vivillon had 20); make
them consistent so that our generated evolution paths behave correctly

Add meowstic specific evolution form modifier... so silly
simpler to have it inlined with the sSpecies, for jit optimization

could probably do this with silvally but meh, things work fine now

Closes #2603
 2020-01-04 22:31:46 -08:00
Kurt
e21d108fb2 Split PokeCrypto from PKX 
All logic in PokeCrypto is separate from the rest of the PKHeX.Core
library; makes it easy to just rip this portion out and reuse in other
projects without needing the entirety of PKHeX.Core logic

optimize out the CheckEncrypted to the actual path, separate methods.
Only usages of this method were with hardcoded Format values, so no
impact
 2020-01-04 14:48:39 -08:00
Kurt
68e6644d40 Split off shared nest class, deduplicate logic 
use generics to have shared logic in one spot
Handle downleveled distribution/crystal(soon?) data
 2020-01-04 11:44:16 -08:00
Kurt
308e6fa291 Add temp workaround for version encounter fetch 
PKX.Generation is 8, which returns SWSH evo tree; evo tree doesn't have
non-galar-native species data, so stuff like Ambipom don't get reversed
properly.

use math.max for tree fetch when appropriate:
- egg generator: pre-evolutions like pichu should be allowed if pk1
- don't fetch format twice, just do math.max
 2020-01-04 11:14:25 -08:00
Kurt
ecabbfff53 Add individual Move#_PP $suggest 
#2603
add in "secret" heal/healPP actions -- do ".Heal=$suggest" to refresh
all stats like it was healed at the pokecenter. I can't think of a good
way to handle invoking of methods (">", but what about parameters?)
 2020-01-03 20:21:02 -08:00
Kurt
15779513f5 Add stubs for raid correlation verifiers/generators 
Not going to implement this within the base repo as z3 is too large of a
dependency and is platform specific.

If anyone wants to implement as a plugin project, just inject your new
methods via the setters on the static func/action at the top of the 3
classes.

Since z3's searches aren't instant, I'd recommend caching recent results
in a dictionary, as re-parses are common. Something like the Wordfilter
is what you'd be aiming for :)

Closes #2617
 2020-01-03 20:03:04 -08:00
Kurt
a08ebff699 Add gen8 mimikyu form case 
Closes #2618
 2020-01-03 19:20:16 -08:00
Kurt
0788780404 Add bewear motostoke crossover location 
Closes #2619
 2020-01-03 19:14:03 -08:00
Kurt
852bd2af20 Relocate gui-only text files to WinForms project 
Split up the DataUtil method to load text files so that the caching
functionality can be reused
 2020-01-03 15:53:48 -08:00
Kurt
10b2120b93 Update translations with latest translatable fields 2020-01-03 15:29:31 -08:00
Kurt
350895aba6 Use permissive string search, add indeedee-M case 
Manually modified showdown sets can contain errors (capitalization,
etc). Use the string search api to permit weaker matches, since there's
not going to be any exact-matches-with-different-caps/spaces.
 2020-01-02 15:49:35 -08:00
Kurt
fe8e5e3fd9 Add more string search methods 
exposes some common string search operations that can be useful for
parsing user entered data
 2020-01-02 12:06:58 -08:00
Kurt
35c7195d77 Add custom int/uint parse tests 
Correctly handle negative parsing for int by flipping sign at end
optimize out a compare char digit/hex check
 2020-01-02 11:11:31 -08:00
Kurt
b55dc37e05 Extend some logic 
make summary more accessible
 2020-01-02 10:55:37 -08:00
Kurt
166f8d82e5 Misc clean 
Refactor out some logic, make "en" literals reference one spot (where
appropriate)
 2020-01-01 19:07:21 -08:00
Kurt
7e490b8dcc Add lanturn/bronzong alt locations 
Closes #2613
 2019-12-31 21:47:28 -08:00
Kurt
0002f1d1ad Grab CXD location if encounter is COLO or XD 2019-12-31 12:15:48 -08:00
Kurt
14eae5f62d Add magikarp distribution data 2019-12-30 22:32:12 -08:00
Kurt
3b2b86950f Ignore symbols (apostrophe) for string matching 
Farfetch'd vs Farfetch’d
 2019-12-30 15:39:13 -08:00
Kurt
84c5f6e914 Add another met location for gastro-1 
Closes #2612
 2019-12-30 15:11:54 -08:00
Kurt
9864f23427 Handle Bridge Field->Stony Wilderness berry tree 
Closes #2610
 2019-12-29 12:48:34 -08:00
Kurt
d6471e2b3b Add more pelipper & dusclops strong locs 
ty anubis
 2019-12-29 11:28:29 -08:00
Kurt
ce62d63c5a Fix eggmove fetch for move check 
Closes #2609
 2019-12-29 10:17:07 -08:00
Kurt
f4bafe0809 Add extension methods for gym team get/set for all 
Closes #2607

SAV6XY/AO had GymTeams get/set, this now makes similar logic accessible
for even SAV5BW/B2W2.
 2019-12-28 22:32:45 -08:00
Kurt
be50abcc44 Add SubEventLog block object, etc 
Adds gym team records, remove from savefile properties
update block list documentation
 2019-12-28 21:53:58 -08:00
Kurt
0ce6254cee Add GymTeam records for Gen5 saves 2019-12-28 21:51:10 -08:00
Kurt
bfd9bf6b53 Simplify formchange calls 
Don't use the dex chain for certain checks, it's unnecessary.
 2019-12-28 19:00:01 -08:00
Kurt
8493471793 Add alcremie form change case 2019-12-28 18:59:00 -08:00
Kurt
3280adcb9f Add another location for Golurk & Galvantula 
Closes #2606
 2019-12-28 18:03:20 -08:00
Matt
6f1611f360 Add Gen 4-6 Starter Event Constants (#2608) 2019-12-28 17:39:46 -08:00
Kurt
b294eba181 Fix combee gender check 
silly convoluted checks
#2603
 2019-12-27 19:17:08 -08:00
Kurt
f65e0a96a7 repoint sav4 event constant reads 
should work fine now
 2019-12-27 18:30:39 -08:00
Kurt
940cdccb6b Restrict downleveled to lvl % 5 == 0 2019-12-27 00:17:59 -08:00
Kurt
c7e396ef14 Update 19.12.26 
Update with latest event data from the Events Gallery
 2019-12-26 19:07:04 -08:00
Kurt
ceae77c677 Add load-line overlap location for Den 27/42 
The nest is situated right next to the load line, and may be accessed
from either map (across the load line), resulting in a Dusty Bowl
Pumpkaboo-0.

Many thanks to Anubis on Discord for figuring this (very silly) thing
out !
 2019-12-26 18:59:02 -08:00
Kurt
b255937e86 Revise input parameter names 
pk instead of pkm (consistency)
Lowercase anything that started with uppercase (not static state)
 2019-12-26 18:47:31 -08:00
Kurt
d736f24bb7 Heal PP on transfer 
force everything to their current pp count
 2019-12-26 15:28:04 -08:00
Kurt
5cb3556eee Add Move PP verification 
Eggs already had it, adding now for regular pkm
Closes #2602
 2019-12-26 14:28:01 -08:00
Kurt
9ee2b08ce5 Update rare flag logic 
Closes #2601

Add ComponentModel attributes for properties, add u64 typeconverter for
propertygrid
 2019-12-26 13:39:07 -08:00
Kurt
6c7065fb7b Fix bool compare 
oops
https://github.com/kwsch/PKHeX/issues/2600#issuecomment-569134146
ty @slp32 !
 2019-12-26 13:12:10 -08:00
Kurt
bb7c94dadb Add seismitoad location 
https://github.com/kwsch/PKHeX/issues/2570#issuecomment-568235086
 2019-12-26 13:04:44 -08:00
Kurt
baf0f52f06 Handle downleveled raids 
Closes #2573
- self-hosted raids can be downleveled too (see cufant), probably only
by 1 rank
- min-rank check now checks for downleveled cases

- Add extra gyarados/ferrothorn locations
 2019-12-26 12:59:16 -08:00
Kurt
4740fab5ec Have separate encounter yielder for gen8 
the "Strong" static encounters can be near-matches with wild encounter
slots; example is a evolved Cutiefly->Ribombee with Quiver Dance.

Remove unnecessary IsLink/FriendSafari check for this gen8 method

https://github.com/kwsch/PKHeX/issues/2573#issuecomment-569126371
 2019-12-26 12:32:48 -08:00
Kurt
420307d4bf Make non-exportable saves (fake) act as VC saves 
https://github.com/kwsch/PKHeX/issues/2600#issuecomment-569125853
 2019-12-26 12:21:35 -08:00
Kurt
06348096aa Fix block de-referencing issue 
SCBlock is an input to the individual save blocks; changing the SCBlock
byte[] reference won't change the individual save block reference. Just
copy the data and keep the original reference instead.

Repro: trainer data editor, save-close window, then delete a slot.
Export save; reload. Changes to box data were using old byte[]
reference, and didn't get repointed. Works fine with latest commit now.

I think I wanted to avoid copyto since it's slower than just a reference
change; but that didn't work out perfectly :)
 2019-12-25 23:24:40 -08:00
Kurt
0a8c791e10 Pad with null terminators rather than 0 
Can have a single digit (not forced to 3), so null terminate I assume.
 2019-12-25 21:31:49 -08:00
Kurt
0c7d347a29 Add Delibird distribution data, split files 
ROM nest data definitions are already pretty hefty and won't be revised;
split out the future content
 2019-12-25 14:26:49 -08:00
Kurt
827a7649c1 Export PCD/PGT as encrypted format 
add Write method for writing the data outside the program; only use Data
if you know what you're doing!
 2019-12-24 23:24:28 -08:00
Kurt
9d1bfd67b5 Add braces 
style fix, no functional change
 2019-12-24 23:23:42 -08:00
Kurt
e6dcf64abe Disallow Spiky Ear Pichu eggs 
sneaky gen4 bad hacks are bad
 2019-12-24 13:21:56 -08:00
Kurt
97c3c6b610 Add raid/den detail browser 
Hold alt when hitting activate all to dump instead
I've seen DenType=5 Event=2 for at least one raid so far... not sure if
the event/rare properties are accurate.
 2019-12-23 23:30:21 -08:00
Kurt
bc3e84d30e Check high bound of language when generating wb7/8 
Closes #2599 ty @slp32
 2019-12-23 11:27:36 -08:00
Kurt
3b1cab0ab5 Update translation resources 
things are pretty stabilized, so it seems like a good time to allow
translations
 2019-12-22 13:53:16 -08:00
Kurt
ea5ca7b2d2 Add Ingredients to swsh held item list 
Closes #2597
 2019-12-22 12:16:06 -08:00
Kurt
3b2ebbb84f Add PID check for gen4/5 Combee->Vespiquen evo 
Closes #2593
 2019-12-21 16:52:56 -08:00
Kurt
7edfe4543f Flag eggs with HT string 
Closes #2586
Modify PKM Info already clears it, but if disabled, will be flagged.
 2019-12-21 16:01:51 -08:00
Kurt
ce463d057a Add Pikachu Beach Score editing for YW saves 
Closes #2585
 2019-12-21 15:17:05 -08:00
Kurt
8309060298 Add more egg verification for statnature/techrecord 2019-12-21 14:51:52 -08:00
Kurt
7889a0abe6 Simplify form egg move handling 
Closes #2588
 2019-12-21 13:37:20 -08:00
Kurt
d7bc68d7a5 Add HT case for capture memory check 
#2570
https://github.com/kwsch/PKHeX/issues/2570#issuecomment-568149050
 2019-12-20 19:47:40 -08:00
NotTsunami
a05b38ab39 Legality: Add Nature and Gender to Gen 8 Trades (#2591) 
Closes #2589 
https://bulbapedia.bulbagarden.net/wiki/In-game_trade#Sword_and_Shield
 2019-12-20 10:48:46 -08:00
Kurt
4bf71de621 Minor clean 
automatically update total_watt if insufficient
SAV8 is not SAV8SWSH
#2583
 2019-12-12 22:58:18 -08:00
Atzgi
d9c59666e0 Add watt in trainer data editor (#2583) 2019-12-12 16:27:01 -08:00
Kurt
506e64186a Rearrange & re-do "CanHaveMemory" value check 
Closes #2581
 2019-12-11 19:37:57 -08:00
iiippppk
dfa951d76c Update Gen8 Traditional Chinese Species (#2579) 2019-12-11 06:09:41 -08:00
iiippppk
35c0a4d931 Fix Chinese text error (#2578) 2019-12-11 06:09:12 -08:00
Kurt
802b93bb16 Fix xor order 
oops, upper half gets the star/square xor
no real difference since PID is random
 2019-12-10 22:05:47 -08:00
Kurt
108233b45f Add glalie/skuntank locations 
#2570
 2019-12-10 19:54:26 -08:00
Kurt
fcdd7019d3 Add missing shadow yanma location ID 
Closes #2577 thanks @HoppyShnell ! -- this looks like the final met
location ID?!

Not sure if Murkrow (locked) is missing one; moved duplicate-location
Heracross and made it use the same locks.
 2019-12-10 19:22:46 -08:00
Kurt
e9d127f225 Copy console data, copy OT memories 
still hypothetical; we know that memories exist and console data still
has accessors
HT memories should be replaced, so no need to transfer 'em.
 2019-12-10 19:13:32 -08:00
Kurt
9a87647409 Add more static encounter locations 
Some of these are probably crossovers
#2570
 2019-12-09 19:28:57 -08:00
Kurt
c85c8ded5c Fix crossover location compare, add formchange 
Rotom can change forms, first time it's available in the wild. Fun.
Fix crossover location comparison (was always returning false).
 2019-12-09 19:28:28 -08:00
Kurt
281c1ae744 Skip SWSH untraded link trade eggs if trade-memory 
just read the comments & code, this one is an annoying oversight
untraded pkm /should/ never have HT memory data, but sometimes it do be
like that

Closes #2571
 2019-12-09 16:23:29 -08:00
Kurt
aa2241ba66 Fix unchangeable OT friendship to compare correctly 
Closes #2572 ty @sora10pls for confirming that evo chains are necessary
for VC transfer
 2019-12-09 15:50:03 -08:00
Kurt
0fa25b4c8c Fix VC transfer evo chain population 
Move EncounterOriginal to Legal info; needed in order to pass the
correct encounter to the EvoChain fetch.

The EncounterOriginal 'hack' might be unnecessary with the current state
of the legality checker... maybe can see if it can be removed later.
 2019-12-09 15:48:54 -08:00
Matt
5395cf6bab Update UnreleasedHeldItems_8 (#2575) 2019-12-09 12:35:50 -08:00
Kurt
8e1fe5e305 Don't apply template fake console data if invalid 
pkmeditor only for blank data load
 2019-12-08 20:09:45 -08:00
Kurt
5e1fd36b96 Account for memory feeling off-by-one bug 
If the feeling is zero the game's string formatter will treat it as
null, and will newline before the period.

Gen6 (if I recall correctly) had "it was happy" as index 0
Gen8 (new) has "it was happy" as index 1, with 0 being invalid-bad.

Slice the array differently for gen8 to include the empty line as index
0.

Closes #2549 , ty @crzyc && @architdate for testing index 0 :)
 2019-12-08 18:56:37 -08:00
Kurt
f54bc7bf6f Batch editor updates 
.PID=$shiny0 will do squares
anything else will do stars

.RelearnMoves=$suggestAll will give ALL TR moves, not just the ones for
its current movepool.
.Ribbons=$suggest will give all valid ribbons
.Ribbons=$suggestNone will remove all ribbons (except required ones like
event ribbons)
Closes #2568
 2019-12-08 17:52:17 -08:00
Kurt
8acb336d51 Use enum for species comparisons 
slightly easier to read with named values
 2019-12-08 17:39:19 -08:00
Kurt
475dc02101 Add edge case handling for indeedee shared egg moves 
#2416
 2019-12-08 12:08:21 -08:00
Kurt
5ddd59c9aa Fix runerigus/yamask partial load fail 
320 is max hp (31IV 252EV), is this just -60 from max HP (threshold to
evolve at?)
might need some more research to see what is going on with this

only trycatch in release builds; was confused until I stepped thru and
saw the crash
 2019-12-08 00:03:08 -08:00
Kurt
c6ef2a845d Fix ribbon compare 
oops
 2019-12-07 23:39:32 -08:00
Kurt
4611146807 Update memory verifier 
Adds handling for SW/SH quirks
Closes #2545
 2019-12-07 23:36:39 -08:00
Kurt
19b1564eb2 Split history and memory verifiers 
Rewrite a bunch of the history verification stuff
Fix a few test cases with incorrect OT Friendship (transferred), and
missing GeoCountry

Need to rewrite memory verification next
(All test cases currently pass)
#2545
 2019-12-07 18:12:31 -08:00
Kurt
34452c2818 Add gen8 ribbon verification 2019-12-07 11:58:56 -08:00
Kurt
aa3d63e982 Add Mr. Rime to splitbreed table 
Closes #2567
 2019-12-07 00:04:46 -08:00
Kurt
861d7b6014 Remove unnecessary parameters for species fetch 
#2567
 2019-12-07 00:00:49 -08:00
Kurt
2b1aee7c38 Gen8: Update rules for having BestFriends ribbon 
Closes #2562
ty @iiippppk
 2019-12-06 20:22:23 -08:00
Kurt
d08e3a3f81 Fix form change evolution linking 
GetDestinationForm for gen7+ is fine
gen7 and gen8 use the "form" argument as the destination form; -1 means
don't change
espurr-F just gets forced to 1 in gen7 since it's -1

Closes #2564 ty @iiippppk
 2019-12-06 19:31:18 -08:00
Kurt
d24a09f7c9 Make level min/max virtual for nest 
Closes #2566
be sure to set the correct flawless IV count & dynamax level so that the
encounter matches
 2019-12-06 19:17:26 -08:00
Kurt
862a446eb3 Fix form sanitization for de-evolution 
Better to handle things this way, we know for sure the form it HAS to
originate as.
Closes #2565
ty @iiippppk !
 2019-12-06 19:00:41 -08:00
Kurt
be38a60267 Fix handling for get evolutions method 
only used for Zukan7b, but add in handling so that it works for <=gen6
games, and supports form alterations too!

update style to match GetPreEvolutions

could probably update this to yield tuples (species, form) but LGPE/SWSH
only needs species. If there's the need for tuples later, should be ez
tweak.
 2019-12-06 18:16:11 -08:00
Kurt
314d8f6b58 Update form destination handling 
espurr-F evolves to form-1 from form0, even tho the form arg is -1 (gen7
consideration)
gen8 has 0/1 for the two evolutions, dictating the destination form
 2019-12-06 17:36:36 -08:00
Kurt
f7620908df dummy out empty evo species 2019-12-06 17:21:38 -08:00
Kurt
7b6d2bfa48 Fix trainerID trainer card write 2019-12-06 16:59:54 -08:00
Kurt
f07aed904d add missing pokedex offset spoof for gen3 saves 
https://projectpokemon.org/home/forums/topic/55704-drag-drop-to-boxes-not-working-in-blank-gen-3-save/
ty ICanSnake
 2019-12-05 23:08:01 -08:00
Kurt
eac3804c7b Clean up dexlevel/evocriteria constructor usage 
DexLevel was the initial abstraction, which was expanded/reused for
evolution details

I should probably merge the two classes since everything is passed as
EvoCriteria
The encounter generators do some silly form fuzzy match which can now be
more accurately checked since I've moved Form to DexLevel... maybe a
future commit can clean that up.

encounterarea2 was reusing this class, just use a throwaway readonly
struct as our temp value storage
 2019-12-05 23:04:24 -08:00
Kurt
b49c5a5a8a Rewrite evolution lineage generating 
- Use tail recursion and a lookup table (species | form) for reversing
- generate the reversal lookup by extrapolating all species-form
destination values (EvolutionLink)
All tests pass, and no special handling for forms is required. Kinda
suspicious that it works this simply...

Redo evolution banning (no wormhole for non-Alolan evolutions in SM), in
a style that we can ban the Gigantamax event evolutions
(pika/meowth/eevee). Their evolutions can't be resulted from a pre-evo,
because the in-game routine early aborts if the gigantamax flag is set
for those species.

Update gen4 personal tables (formCount was 0, needs to be a minimum of 1
by default)

Closes #2537
 2019-12-05 22:32:47 -08:00
Kurt
786d9c8f18 Handle shedinja encounter balls 
nincada -> spawn shedinja = pokeball (wild encounter rules if gen3)
shedinja encounter = wild encounter rules
 2019-12-05 16:40:14 -08:00
Kurt
b2fc99e50a Update nest dist/crystal location get/check 2019-12-04 19:04:36 -08:00
Kurt
65b921f806
Only apply 3DS geoloc data for 3DS blank saves 
Closes #2560

Different logic in SimpleTrainerInfo applies it to <=Gen5, but that's fine... 414cb2d39e/PKHeX.Core/Legality/Structures/SimpleTrainerInfo.cs
 2019-12-04 14:00:53 -08:00
Kurt
414cb2d39e don't apply rib-markings on all 
legality concerns
 2019-12-03 23:41:24 -08:00
Kurt
d70a234552 Add $suggest for PKM.Ball 
sets a legal ball, with preference for color matching
 2019-12-03 20:14:36 -08:00
Kurt
e333f9b441 Add orbeetle 65 loc 
thanks @sora10pls
 2019-12-03 19:59:10 -08:00
Kurt
f45d730faf Add TrainerID for trainer card 
Closes #2556
 2019-12-03 19:54:34 -08:00
Kurt
71318c9bd5 Add clarification/notes 2019-12-03 19:54:06 -08:00
Kurt
ab7cf3252e Add snorlax raid dist data 2019-12-03 18:25:06 -08:00
Kurt
a0f2aded02 Use more optimized index find 2019-12-03 18:24:28 -08:00
Archit Date
3526c37f1e update forme to showdown strings (#2558) 
* update forme to showdown strings

Galarian is represented as Galar on PS!
Polteageist has no form atall
galarian now called Galar by default to match with Alola as a forme. changed darmanitan forme-strings in form converter. Added sinistea to the forme ignore list when converting to showdown
 2019-12-03 16:41:52 -08:00
Kurt
e9b9141eda
Fix property name typo 
efec331741 (r36246093)

ty @AnalogMan151
 2019-12-03 10:39:57 -08:00
Kurt
d3f7e7bf07 Minor simplifications 
format >= 6 is always true (early return in entry)
don't double-flag/check memory presence in OTs from gen5 and below (hist
and OT verifier)

rename method; I'll probably rework the flow of things for gen6
verification and gen8 verification since the rules are slightly
different
 2019-12-02 16:36:53 -08:00
Frank
efec331741 add some customization options in MyStatus8 (#2552) 2019-12-02 13:40:09 -08:00
Kurt
a844fb5249 Add strong dubwool location 
https://projectpokemon.org/home/forums/topic/55654-new-pokemon-to-fix-on-pkhex/?tab=comments#comment-251010
 2019-12-01 00:02:02 -08:00
Kurt
594c44f6c0 Set Gender for template 
Closes #2548
 2019-11-30 23:44:47 -08:00
Matt
7b7a161ac9 Minor fixes (#2547) 
Fix Sinistea/Polteageist Form names (as per Strategy Guide)
Add Eternamax menu sprite
 2019-11-30 13:19:22 -08:00
Kurt
f3ecff272c Update HA8 banlist 
Closes #2544
Closes #2543
 2019-11-29 22:33:11 -08:00
Kurt
2ee6fbb7e9 Only flag bred stuff for no-breed 
Closes #2542
 2019-11-29 18:54:07 -08:00
Kurt
c27224830d Rename rs Mystery Gift -> Mystery Event 
Closes #2541

pret pokeruby still calls it Mystery Gift tho

11170ce90c/src/event_data.c (L88)
 2019-11-29 18:48:58 -08:00
Kurt
89b4bc81b9 Update raid structure unknowns 2019-11-29 18:48:12 -08:00
Kurt
3c4e668d9a Add alcremie formArg gui 
Closes #2538
Standardize nomenclature as FormArgument, add interface for those
exposing the property.
 2019-11-29 10:44:52 -08:00
Matt
bc9be36123 Add more Gen 8 static encounter locations (#2540) 
Also add West Sea Shellos/Gastrodon to transfer form banlist
 2019-11-29 10:03:35 -08:00
Kurt
48a87397ec Split daycare8 to its own file 
Add method to fetch daycare seeds from metadata
 2019-11-28 21:13:53 -08:00
Matt
faf936bceb Update Gen 8 transfer banlist (#2536) 
Alolan Forms can't be obtained yet, same with Hoenn Zigzagoon/Linoone and Unova Stunfisk.
 2019-11-28 18:42:22 -08:00
Kurt
f25b36a306 Minor tweaks 
Remove unused stuff
add some comments/xmldoc
Move Trainer1 to classes that use it
 2019-11-28 14:00:55 -08:00
Kurt
ea2f7f338b Add weather indication to detailed parse output 2019-11-28 12:56:26 -08:00
Kurt
5ba396db6e Update shiny comparisons for (traded)eggs 
PID rerolls happen on trade to ensure star/square state is kept
 2019-11-28 12:40:33 -08:00
Kurt
2c0b85ef21 Add form banlist for g8 
Weezing-0 has no de-evolution path (nothing evolves to it)
Just ban these forms existence in SW/SH
 2019-11-28 12:09:55 -08:00
Kurt
f0cf28fbad Flag bred transfer mons 
#2416
 2019-11-28 11:51:23 -08:00
Kurt
e8bdc34a18 Tweak gift generator 
Yield ranger manaphy gift as possible (encmoveset generator)
Move ranger manaphy equals check to PGT
 2019-11-28 10:42:24 -08:00
Archit Date
897b97ceed comment typo fix (#2535) 
lul
 2019-11-28 10:35:18 -08:00
Kurt
7a51e48747 Add wc8 star/square pid types 2019-11-28 09:46:48 -08:00
Kurt
f5307c142b Use format sensitive move knowable check 
Closes #2534
 2019-11-27 23:07:41 -08:00
Kurt
5a1bffb2ba Split wild encounters for crossover & weather 
Certain Mark values (ribbon) are only obtainable if the encounter was
obtained in some weather (I really hope there's no crossover cases for
this), and non-symbol encounters can't wander to another zone.

I wonder if you can wander from one zone with one exclusive weather, to
another zone, and get an 'unobtainable' mark (with the new zone's
weather) on the crossover mon's weather. yikes lmao
 2019-11-27 22:46:14 -08:00
Kurt
a0ee7a3e51 Add route 2 lapras location 
ty Waves (discord)
https://www.serebii.net/pokearth/galar/route2.shtml#xy-lake
 2019-11-27 19:44:14 -08:00
Kurt
5761f03f94 Add OT memory details for gen6 ingame trades 2019-11-27 19:30:28 -08:00
Kurt
c81edac9e5 Fix CGB import 
Trainer1 now unused for this class
Closes #2533
 2019-11-27 18:33:30 -08:00
Kurt
907f036956 Disregard OT memory values on gen7 origin 2019-11-27 16:01:12 -08:00
Kurt
c4951f1650 Add strong piloswine location 
ty wowjinxy
 2019-11-27 11:34:20 -08:00
Kurt
d3bd37a950 tweak last saved string format 
ty @sora10pls for testing
 2019-11-26 23:10:28 -08:00
Kurt
bac6032152 Update last saved parsing 
year is years-since-1900
month is months-since-jan (jan=0)
 2019-11-26 19:15:05 -08:00
Kurt
4cd358833a Add corvisquire static enc location 
https://projectpokemon.org/home/forums/topic/55611-corvisquire-route-3/
thanks ThePunish3D!
 2019-11-26 18:20:52 -08:00
Kurt
b95ab53e92 Finalize unreleased item banlist 2019-11-26 17:16:57 -08:00
Kurt
5b932c961f Merge branch 'master' of https://github.com/kwsch/PKHeX 2019-11-26 16:58:44 -08:00
Kurt
08e293dadc Add SimpleTrainerInfo constructor 
zeroes out console region data if not present in game
 2019-11-26 16:55:28 -08:00
Chris
f23874b1ae
Safari/Sports Ball is also not released 2019-11-27 01:55:15 +01:00
Kurt
4182b22686
Update Unreleased Items(SwSh) (#2529) 
https://www.serebii.net/swordshield/items.shtml

only Pixie Plate & Normal Gem are in the Game yet.
 2019-11-26 16:13:30 -08:00
Kurt
5883acd5b9 Fix florges/floette evo tree 
No personal stats for those evos different from main species
 2019-11-26 16:12:35 -08:00
Chris
ba43631d40
Update Unreleased Items(SwSh) 
https://www.serebii.net/swordshield/items.shtml

only Pixie Plate & Normal Gem are in the Game yet.
 2019-11-27 01:08:31 +01:00
Kurt
9cb56be3dd Add bronzong/galvantula strong loc 
previous Bronzong location is likely a crossover case

ty wowjinxy
 2019-11-26 11:39:17 -08:00
Kurt
b58ff25741 Use stat nature for showdown set export 
thanks @sora10pls
 2019-11-26 11:36:20 -08:00
Kurt
15ef6555a8 Add WC8 memory & fix fallthrough 
ty @sora10pls
 2019-11-26 11:22:01 -08:00
Kurt
ef425af835 Add memory / console region checks for pb7/pk8 
yeah your initial hacks were hacks

It appears there's a bug (in the game) for link trade memories --
applied to the OT memory instead of HT memory?? Fun!
 2019-11-26 11:01:09 -08:00
Kurt
7960f2d748 Don't set console region data for pb7/pk8+ 2019-11-26 10:46:32 -08:00
Kurt
445fdee2ba Add shared memory interface (encounter) 2019-11-26 10:46:16 -08:00
Kurt
6627d7e2f4 Minor clean 2019-11-26 10:45:36 -08:00
Kurt
0f96b3c4d5 Add Species specific arg memories 2019-11-26 10:44:36 -08:00
Kurt
6987edd7a3 Simplify expression 
no allocations
 2019-11-25 23:34:49 -08:00
Kurt
c0270b18e4 Add trainer card number editing 2019-11-25 23:26:01 -08:00
Kurt
e8f5ac8a00 Minor clean 2019-11-25 22:51:07 -08:00
Kurt
87a498ac05 Add flag api 2019-11-25 22:50:53 -08:00
Kurt
7a10311207 Unban scrafty/scraggy HA 
new EncounterStatic8N(Nest87,3,4,4) { Species = 560, Ability = A4 }, //
Scrafty
 2019-11-25 20:31:42 -08:00
Kurt
24ac0d9d4b Fix WasLink comparison 
Closes #2525
G4Celebi & G6Link met location match; Pokémon Link was only available
for Gen6 so just check for that origin.

Ty @Ammako

tbh I shouldn't even have this property ha
 2019-11-25 19:29:12 -08:00
Kurt
c416fc5fa1 Update handling for invalid genNumber 
all edge case movepool stuff is IGeneration; we're fine just using
IGeneration.Generation
 2019-11-25 18:33:38 -08:00
Kurt
5dde0f5c43 Merge Error flag into Parsed 
Simplify some logic with ??=
 2019-11-25 18:32:50 -08:00
Kurt
c5593470df Add 2 more static enc locations, swap yield order 
Private report with 3 specimens, 2 undocumented met locations
The other was a Gigantamax which matched another static encounter,
resulting in a partial match being accepted (the real match came after,
but was never iterated to).

Rather than adding deferrals for Enc8, do nest stuff first since it's
the most restrictive

In the past we didn't really have duplicate static encounters with
slightly different permissions.

Thanks @ReignOfComputer & {reporting user}!
 2019-11-25 17:57:25 -08:00
Kurt
5435a5d93e Minor updates 
Fix mark (ribbon) read for index > 64
Heal party stats on set detail import
Wipe HT Language for eggs/untraded
Extract BST total color logic
 2019-11-25 17:32:10 -08:00
Kurt
22a5df5181 Only set permitted record flags for Move[] 
Closes #2523
 2019-11-25 12:02:30 -08:00
Archit Date
a05bed8f18 updated shiny indicator for xor0 (#2522) 2019-11-25 09:27:42 -08:00
Kurt
b37a0c5bfe Add downleveled regular raid movepool verification 
#2416
Not having enough badges pulls the level of the captured mon down

need more info if the other raid types behave similarly
 2019-11-25 08:52:03 -08:00
Kurt
5dec94d456 Handle banned form eggs with more flexibility 
Closes #2519
better to not generate the encounter as opposed to flagging it after
generation
 2019-11-25 00:16:16 -08:00
Kurt
6ca8571759 Add stomp min level for Steenee 
Closes #2520
 2019-11-24 23:50:10 -08:00
Kurt
b588af8300 Ban meowstic-1 hidden ability 
Closes #2521
 2019-11-24 23:14:42 -08:00
Kurt
0dcd9b744a Include swsh held items to valid items list 
Closes #2518
 2019-11-24 22:34:51 -08:00
Kurt
c446ff5b51 Fix non-galar egg moves passing 
Closes #2516
 2019-11-24 18:18:26 -08:00
Kurt
e1e7bf321b Add South Lake Miloch for den 42 
#2416
 2019-11-24 11:07:31 -08:00
Kurt
aeb3ee6cec Fix shedinja evo chain logic 
#2416
 2019-11-24 09:49:54 -08:00
Kurt
9d02a2c2b1 Simplify comparison 
never null
 2019-11-24 09:48:22 -08:00
Kurt
cf12f7f4bc Fix type comparison 
works fine without this, but this is the correct type comparison
 2019-11-24 06:43:42 -08:00
Kurt
32d8225023 Fix drag slot equality check 
prevents deleting party slots if a slot is dragged into its original
slot (X->X); Equals check only checked reference
 2019-11-24 06:42:41 -08:00
Kurt
64d94903ff Change fixed ability 
0=abil1
1=abil2
2=abil4
3=abil1/2
4=any

probably same as WC8 etc

doesn't have any impact as there's other encounters that allow Hidden
 2019-11-24 06:26:33 -08:00
Kurt
dd51ed707f Update record flags on default showdown import 
Closes #2511
 2019-11-24 06:06:08 -08:00
Kurt
113d16fa5d Fix darumaka->darmanitan blizzard move 
#2416

Looks like the only issues left are:
Shedinja
Crossover/Bleed locations
Static Encounter locations
 2019-11-23 22:48:02 -08:00
Kurt
96f6db0e38 Add recognition for distribution raids 
Closes #2457
 2019-11-23 22:23:43 -08:00
Kurt
52cd8ae855 Revise HA banlist 
https://www.smogon.com/forums/threads/sword-shield-battle-mechanics-research.3655528/post-8291236
 2019-11-23 20:50:56 -08:00
Kurt
09d1d0e799 Add darumaka to galar origin 
lol oops
Closes #2508 thanks @iiippppk !
 2019-11-23 19:45:18 -08:00
Kurt
5df6565597 Add fast ball 
Closes #2507
 2019-11-23 19:12:53 -08:00
Kurt
cccf2a1939 Fix flawless IV count check 
#2506 trapinch
 2019-11-23 14:46:09 -08:00
Kurt
66ebf7cb60 Add $suggest for techrecord & (stat)nature 2019-11-23 12:02:58 -08:00
Archit Date
f96eafa682 grab correct evo stage 1 from evocriteria list (#2503) 
EncounterMovesetGenerator was using the de-evolution order in the passed evocriteria list
 2019-11-23 09:01:09 -08:00
Kurt
e70a2f40b8 Add den crossover via online share 
fix ability deferral for non-HA (eg. A4 mr rime encounter)
 2019-11-23 08:27:50 -08:00
Kurt
b29fc5216e Add shared moveset transfer 
Closes #2501 for now
 2019-11-23 07:27:06 -08:00
Kurt
c27b1d0bb8 Revise hidden ability banlist 
Might need to remove entries once the Distribution raid data is added.
 2019-11-23 07:12:50 -08:00
Kurt
67565aa71d Update structure note comment 2019-11-23 07:12:20 -08:00
Kurt
4a6fa684e6 Fix IsUntraded check 
used the pk6 offsets lol
 2019-11-22 23:00:36 -08:00
Chris
03ee264d0c Add Vanilluxe Multiple Encounters (#2499) 
* Add Vanilluxe Multiple Encounters

Vanilluxe spawns also on any Lake if its snowing
 2019-11-22 21:32:39 -08:00
Kurt
9e4c408ac7 Fix galar form egg move fetch 
Closes #2500
 2019-11-22 21:32:05 -08:00
Kurt
26b21d8603 Rewrite reverse evo lineage rectifier 
Closes #2479
Fixes Silvally in swsh not having evo reversal content for each form
 2019-11-22 21:04:34 -08:00
Kurt
d25f388bf5 Fix dexnav relearn checks 
Closes #2491
Thanks @NinFanBoyFTW !
 2019-11-22 19:59:40 -08:00
Chris
97f156364d Update Multiple Encounters for Lakes (#2498) 
happens also for:

Drifloon, Wingull, Goldeen, Frillish, Magikarp

but theese aren't listed, feel free to add new encounters.
 2019-11-22 18:26:47 -08:00
Archit Date
915f6a5e42 fix toxtricity parsing (#2496) 
Full amped form has no form string, so does not need fixing. Exporting low key form also adds a hyphen, so that does not need fixing either!
 2019-11-22 14:17:52 -08:00
Chris
e90d2fbc29 Also Seaking have multiple Locations (#2495) 
^
 2019-11-22 08:05:46 -08:00
Chris
4c9815c17e Add Multiple Gyarados Spawns (#2493) 
Gyarados Spawns in Area 1:
North/East/South/West Lake Miloch, 

Area 2:
the Lake of Outrage (in a Wild Area)
 2019-11-22 08:04:17 -08:00
Chris
8bdc110e2b Added Multiple Lapras Spawns (#2492) 
Lapras Spawns in Area 1:
North/East/South/West Lake Miloch, 

Area 2:
the Lake of Outrage (in a Wild Area)
 2019-11-22 08:03:16 -08:00
Kurt
5a38e118e8 Add raid spawn initial docs 
linq dump code I used for ez vis:
var sav = new SAV8SWSH(File.ReadAllBytes(@"D:\Kurt\Downloads\main
(7)"));
var blocks = sav.Blocks;
var raid = blocks.Raid;
raid.GetAllRaids().Dump();
 2019-11-21 22:55:21 -08:00
Kurt
1ffee3de02 Add raid/fashion block accessors 
set breakpoint at end of ctor... immediate window dump:
System.IO.File.WriteAllBytes(@"E:\raid.bin", Raid.Data);
 2019-11-21 22:26:24 -08:00
Kurt
4b3d85d5e6 Add multi-location strong encounter handling 
#2484
OH BOY REUSED INDEXES
smart to save space, but a small pain for legality

feels pretty bad breaking up abstractions for every minor difference in
verification...
 2019-11-21 21:44:41 -08:00
Kurt
5235c9b252 Revert "Add lapras encounter location?" 
This reverts commit e4e516d1c2.
 2019-11-21 21:14:45 -08:00
Kurt
e4e516d1c2 Add lapras encounter location? 
#2484
The other lapras encounter was found by @sora10pls and was lv56; we're
assuming this other lapras is the encounter (for now).
 2019-11-21 20:59:24 -08:00
Kurt
4c8dd0cb3a Defer rather than reject 
#2490
 2019-11-21 20:05:20 -08:00
Archit Date
e93bc5e67c Misc Nest Fixes (#2490) 
* fix A3 and A4 ability values

private > internal so it can be used in Encounter Nest matching

* reject ability number 4 if ability is from A3
 2019-11-21 20:03:02 -08:00
Kurt
b9e32c67a0 Add encounter static deferral oop 
We've already been doing something similar for the deferral check; just
merge the logic into the base object
Closes #2489
 2019-11-21 20:02:08 -08:00
Archit Date
93028b3439 modify nest locations based on serebii (#2483) 
https://serebii.net/swordshield/maxraidbattles.shtml
 2019-11-20 23:02:54 -08:00
Kurt
f6c6639078 Add online den location 
There's still the down-leveled issue with high level moves. fun.
 2019-11-20 23:02:31 -08:00
Kurt
a50169d3d2 Add shift-set shinyxor0 pid 
Display xor value on hover, not gonna do alternate stars/square display
Closes #2482
 2019-11-20 20:38:05 -08:00
Kurt
1be9a6f70d Fix sav4 load for daycare / gts slots 
Closes #2481
 2019-11-20 19:16:25 -08:00
Kurt
2aaa3763ee Fix record setting logic 
Thanks @AnalogMan151 ! #2416
Fix method reference lol
 2019-11-20 18:18:33 -08:00
Kurt
f30a14ebf0 Disallow dynamax level on story legends 
ty @sora10pls
 2019-11-20 18:15:21 -08:00
Kurt
473afb8377 Initial rough draft of nest location matching 
nest data doesn't match what's expected, but recognition is ready for
tweaks
 2019-11-20 17:07:55 -08:00
Kurt
c6f515c755 Use more performat array join 2019-11-20 17:07:55 -08:00
Ammako
ee9c91e893 Add G4 Box Flags (#2478) 2019-11-20 11:39:31 -08:00
ReignOfComputer
f19193c66f Static Locations Update (#2475) 
* Static Locations Update

- Removed version lock on Motostoke Stadium Vulpix (may want to investigate Growlithe)
- Wild Area Updates
- Other Static Updates

* Squeeze in 2 more Statics

* Rhydon Static Location

Last one I promise.
 2019-11-20 11:38:25 -08:00
Kurt
8294d77464 Add Carkol static loc 2019-11-19 20:24:12 -08:00
Kurt
2c5a7cd5de Add linoone strong loc 2019-11-19 19:41:30 -08:00
Kurt
feef1c1122 Add 2 more strong locations 2019-11-19 19:27:57 -08:00
Chris
7ef4fce89e Add Eevveelutions Spawns for Lake of Outrage (#2471) 
All Eeveelutions spawns at the Lake of Outrage, based on the weather?
 2019-11-19 19:21:41 -08:00
Kurt
18b20e09d2 Add leafeon location 2019-11-19 19:03:39 -08:00
Kurt
e6476e943b Change Gender to OT Gender 
ty @sora10pls for confirmation
 2019-11-19 18:55:03 -08:00
Kurt
0f4598ff66 Update some comparisons 2019-11-19 18:02:57 -08:00
Kurt
85fa6e0273 Add more strong encounter locations 2019-11-19 17:07:11 -08:00
Archit Date
686f69484d set gigantamax flag from showdown set (#2469) 2019-11-19 15:57:08 -08:00
Matt
ea80718919 Unban GO Shiny Tentacool (#2468) 
* Unban GO Shiny Tentacool

* Also unban GO Shiny Meowth
 2019-11-19 13:54:29 -08:00
Kurt
9734010fcd Add unsorted combolist method 
#2465
 2019-11-19 08:48:44 -08:00
Kurt
256de0380f Swap order of vc1/vc2 in version dropdown 
Closes #2464
 2019-11-19 08:42:31 -08:00
Kurt
fa344208b2 Add crossover location handling 
Closes #2461 by implementing slightly differently

Dictionary instead of new[] every area
Checks original met location first before attempting the dictionary
lookup (missing in pull request)
Easy path forward if LGPE crossover is needed

Potential issues: Since encounter types aren't marked, shaking trees and
fishing encounters are allowed to cross over. Maybe need to have some
marking for encounter slots or something...
 2019-11-19 08:38:18 -08:00
Kurt
1538f04dce Remove unnecessary logic 
rip return frustration, don't need to consider this
 2019-11-19 08:15:58 -08:00
ReignOfComputer
0230dafe2b Wild Area Updates from RoC's PC (#2460) 2019-11-19 08:13:53 -08:00
Kurt
a368b81519 Minor clean 2019-11-18 22:48:03 -08:00
ReignOfComputer
0ef6f024d6 Wild Area Updates from #2416 (#2459) 
https://github.com/kwsch/PKHeX/issues/2416
 2019-11-18 22:21:13 -08:00
Kurt
f88388cb70 Add Form (AltForm) to IEncounterable interface 
All of the encounterable templates have Form anyway; funny that I was
consistent naming them all differently than pkm.AltForm :)

Closes #2452
 2019-11-18 22:20:55 -08:00
iiippppk
4a82b424ce Use simplified Chinese characters (#2458) 2019-11-18 21:35:21 -08:00
ReignOfComputer
6d95fa5884 Wild Area Updates from RoC's PC (#2456) 2019-11-18 20:26:38 -08:00
Kurt
1df90199e3 Rework GetBaseSpecies to return EvoCriteria 
#2452
 2019-11-18 20:26:11 -08:00
Kurt
5a4c026dc7 Restrict egg related species fetch to EvoCriteria 
#2452
 2019-11-18 20:10:39 -08:00
Kurt
535397cf5e Consolidate egg ctor with args 
Form is an absolute requirement for the encounter data.

#2452
 2019-11-18 20:01:48 -08:00
Kurt
2b76fe148d Fix property reference for Darmanitan-G 
lul
Closes #2453
 2019-11-18 19:29:05 -08:00
Kurt
5e1937d8b4 Fix fossil8 to unbreedable 
Not needed in the HA banlist table since it can't breed.

Closes #2451 thanks @iiippppk !
(undiscovered egg group)
 2019-11-18 19:26:01 -08:00
Kurt
1ea3976805 Split up Encounters8 
Nests in their own file
Encounter types in their own files
 2019-11-18 19:23:01 -08:00
Kurt
e9fdc721df Add chewtle 2019-11-18 18:42:10 -08:00
Kurt
86796cd67a Add accessor for TrainerCard block 2019-11-18 17:57:33 -08:00
Kurt
adf33404b3 Add Trainer Card block 2019-11-18 17:57:18 -08:00
Kurt
21c3b4e1b1 Add Ribbon interfaces to WC8 
pretty silly but gets the job done
Closes #2446 by fully implementing all ribbon checks possible
 2019-11-18 17:37:38 -08:00
Kurt
d7d2db8764 Add ribbon index enumeration and extension methods 2019-11-18 17:00:57 -08:00
Kurt
674152aa25 Add Mark interface 2019-11-18 17:00:16 -08:00
Kurt
fac5182d4b Add a ChangeAllCount to current value dropdown 2019-11-18 16:25:27 -08:00
Kurt
5cf58dbb5f Fix dex clearing on setting altform/gender 2019-11-18 16:21:11 -08:00
Ammako
acf5df07be Box Layout fixes (#2449) 
* Enforce box name length in Box Layout

* Fix G4 box renaming

* Fix G7 box renaming
 2019-11-18 16:01:36 -08:00
Kurt
3aa3a29264 Add 3 more static enc locations 2019-11-17 22:04:52 -08:00
Kurt
38abafab99 Catch some evolution edge cases 2019-11-17 22:04:41 -08:00
Kurt
47be249331 Rework evo tree chaining to track form 
Now recognizes & reverses form-changing evolution chains like Sirfetch'd

basically the whole process is to build the tree but point in the
opposite direction (for de-evolution paths)
 2019-11-17 21:45:53 -08:00
Kurt
2c11632a3c gen6 Un-truncate box names 
Closes #2445 ty @Ammako
 2019-11-17 20:41:40 -08:00
Kurt
4bcf60746b Add egg move sharing checks 
Was referencing wild caught mons that are given a single egg move; this
logic handles shared egg moves too via daycare.

Probably need to rework SplitBreed into a dictionary; this might not
catch Mime/etc split breeds if they have different tables.
 2019-11-17 17:14:21 -08:00
Kurt
c2dce518c2 Invert sign of fake met locations 
Suggested encounters check < 0
 2019-11-17 16:03:53 -08:00
Kurt
d4c5919e5e Revisions for some static encounters 
Identified a few more
 2019-11-17 15:50:41 -08:00
Kurt
fa169ff61c Fix box binary / pcbin export 
19784aaa41 (diff-37bd5b548e2b340e5c38fd0961a3eb04L880)

Was just exporting blank data, lol

https://projectpokemon.org/home/forums/topic/55436-issue-with-box-data-binary/
 2019-11-17 14:04:04 -08:00
Kurt
13adc38ee8 Add elemental tutors 
Closes #2443
Capture some array references to avoid re-fetching array -- array
reference is readonly so it probably won't matter
 2019-11-17 11:13:57 -08:00
Kurt
ea822e9fcd Add raid flawless IV check (speculation) 2019-11-17 09:55:27 -08:00
Kurt
86a20afe8e Minor style fix 2019-11-17 09:47:10 -08:00
Kurt
d077d8549e Add alcremie form display for dex edit 
Nothing for the PKM Editor; not sure how I want to handle the reused
FormDuration work value.

For the meantime, just use the Batch Editor for a targeted write.

Closes #2441
 2019-11-17 09:34:04 -08:00
Kurt
23c04cf809 Add beast ball to wild balls 2019-11-16 22:22:21 -08:00