Kurt
c7175fbdb4
Misc reorg
...
bye bye SAVUtil and PKMUtil
2018-07-20 21:32:33 -07:00
Kurt
f27f11bfc8
Clean up pk7/sav6/sav7 simple methods
...
extract GetFormDuration to method, remove unused GetIsCompatible
specialized variant (there's a generalized version in SAVUtil.cs,
IsPKMCompatible -- might do another round of WinForms->Core absorption
2018-07-20 20:25:28 -07:00
Kurt
4b0a2d90b9
Add xmldoc
2018-07-20 20:22:46 -07:00
Kurt
c9abeda508
Update stadium check again
...
#2065
2018-07-20 05:57:57 -07:00
Kurt
1ff8ebf777
Misc overload add/use
...
Some values are already computed; pass them in to overloads for quicker
execution
2018-07-19 19:38:44 -07:00
Kurt
614d2629ce
Remove unnecessary ref passing
...
object is already passed byref, don't need to repoint the reference
2018-07-19 18:09:37 -07:00
Kurt
229dc96c00
Safe convert current level
...
Dry startup can cause a crash if the field is somehow not filled in:
https://projectpokemon.org/home/forums/topic/46313-pkhex-ver-180716-wont-run/
2018-07-19 16:46:56 -07:00
Kurt
9a91619580
Update vc1 invalid transfer pruning
...
Closes #2065 Thanks @WEERSOQUEER !
Single evo species weren't getting flagged in the evolution verification
as they early returned (species matched), just move the sanity check
before that
2018-07-19 16:42:45 -07:00
Kurt
69e7d49d03
Simplify Stadium OT Check
...
TID is always 2000 : #2065
2018-07-19 15:54:34 -07:00
Kurt
33637836f2
Ignore detected saves when displaying backups
2018-07-18 21:26:18 -07:00
Kurt
e5d95bf178
Display autodetected path location better
...
Autodetect location not stored in a button path will show up as "???";
check the typical homebrew autodetect paths, then display the parent
folder
eg, Path.Combine(root, "3ds", "Checkpoint", "saves");
shave off "saves" to return X:\3ds\Checkpoint
add range checks to label translation
2018-07-18 19:32:57 -07:00
Kurt
c69b50daae
Reload savefile from disk when loaded from folder
...
Folderlist stores savefile objects, can open A, edit A, open B, open A,
and all edits from prior are still there. Just re-open the save file
from disk. The folderlist already checks if the path exists prior to
calling it to reopen.
2018-07-18 17:33:03 -07:00
Kurt
ff4ca47ebe
Remove GBEncounterData boxing
...
Interfaces implement enough detail, so can simplify
extract local methods (likely will be inlined)
less obj allocations = faster!
2018-07-18 16:37:21 -07:00
Kurt
1c75093e27
Specify altform for ranch shellos
...
1 not 0
https://projectpokemon.org/home/files/file/336-shellos/?do=findComment&comment=1290&tab=comments
2018-07-18 07:15:46 -07:00
Kurt
e1b983bc59
Fix auto-detect save file on load
...
introduced in
99673706a0
reference the field that stores the full file path
https://projectpokemon.org/home/forums/topic/46293-not-reading-card/
2018-07-17 21:26:25 -07:00
Kurt
01c4ca348f
Allow FolderList to be translated
2018-07-17 21:02:01 -07:00
Kurt
170390b49d
Add datagrid filtering for folderlist view
...
can be a little silly if the tab hasn't been viewed yet, but works fine
2018-07-17 20:52:08 -07:00
Kurt
a100488142
add gen12 generator kadabra catch rate case
...
https://projectpokemon.org/home/forums/topic/46259-yellow-kadabra/
Thanks Cloud AC !
update misc verifier for catchrate to better indicate for
any->nontradeback scenarios
2018-07-17 16:54:23 -07:00
Kurt
fe7fea877b
Replace boolean OrderBy with DeferBy
...
orderby consumes the entire input enumerable in 'sorting' the list;
since we don't care about the order besides a yes/no, just manage the
yield order ourselves.
don't bother using this method more than the spot it's in; was a fun
exercise but other spots are set up for easier debugging
(overall flow is where->deferby->yield), could make things easier to
read but meh
2018-07-17 16:28:42 -07:00
Kurt
e4aa16f396
Fill out gen5 hidden ability banlist
...
now flags gen5 contrary serperior ;)
2018-07-16 21:53:46 -07:00
Kurt
99c790a4b0
Update File name/path/folder fields
...
original file path is not saved with the two listed properties, add
FileFolder and relcoate existing FilePath functions to that field
move some GetVariantSAV usages to the string method instead of byte[]
2018-07-16 21:00:43 -07:00
Kurt
f211f03eaa
Add test case
...
#2062
Thanks @PrometheusG !
2018-07-16 16:18:55 -07:00
Kurt
bdb5aaee36
Ignore mismatch if explicitly permitted by prior check
...
Closes #2062
2018-07-16 16:12:19 -07:00
Kurt
87056aaf7c
Increase save list population speed
2018-07-16 15:31:23 -07:00
Kurt
7ec1cab9a7
Update gen1/2 trade generator to emit gen1 if match
...
Closes #2060
2018-07-16 15:22:40 -07:00
Kurt
f51ac7d1f3
Update translations
...
Internal repositioning to match source
(auto generated changes)
2018-07-16 15:12:40 -07:00
kang1806
afca1b8145
Update MessageStrings_zh.txt ( #2063 )
2018-07-16 15:09:01 -07:00
Kurt
93ed2a8bb9
Restore location suggestion
...
closes #2064
2018-07-16 15:07:20 -07:00
Kurt
6ee534c4b1
Update undo/redo
...
Closes #2059
2018-07-16 06:40:35 -07:00
Kurt
9a1695f319
Update 18.07.16
...
Update event binaries with latest from the Event Gallery
2018-07-15 21:44:50 -07:00
Kurt
921374c8eb
Allow resize, add filename indication
2018-07-15 21:28:27 -07:00
Kurt
a81c28f114
Upgrade FolderList to show recent/backups
...
sortable grid like the ReportGrid for pkm, can open/browse individual
files
2018-07-15 17:48:31 -07:00
Kurt
99673706a0
Rework recent savefile detection
...
return a reference to the savefile rather than the path, since a
SaveFile has a FilePath property.
2018-07-15 13:35:58 -07:00
Kurt
f5bed410b4
sync csproj
2018-07-15 12:25:28 -07:00
Kurt
f3225d1c47
Extract pkm preview to individual files
2018-07-15 11:12:02 -07:00
Kurt
cce7f34f05
Re-add 'unused' qr pattern methods
...
simplify out the floor operations while we're at it
should have been a func array in the base lib but whatever ;)
2018-07-15 10:57:37 -07:00
Kurt
b749db10d8
Null check property value
...
EggMetDate, if none set, returns null.
https://projectpokemon.org/home/forums/topic/46265-batch-editor-bug-systemnullreferenceexception/
2018-07-15 08:46:31 -07:00
Kurt
46ece28f4c
Add vc/gen1-2 search option
...
refactor out some searchable methods
2018-07-14 22:18:24 -07:00
Kurt
cc509de83c
Add lgpe properties
2018-07-14 21:55:45 -07:00
Kurt
8d89776ae9
Remove unused portions of lib
2018-07-14 21:55:26 -07:00
Kurt
0f17445ef4
Update gen3 event pidiv method check for eggs
...
closes #2057
Thanks @kamronbatman !
(nothing currently implemented uses BACD_U_S)
2018-07-14 20:19:13 -07:00
Kurt
fae36e2086
Add layerimage overload
...
transparency=1 is no opacity change
remove Rectangle use, just provide coordinates (looks to be simpler in
the .net src too)
2018-07-14 18:43:46 -07:00
Kurt
cb80c02011
Check Yellow catchrates when updating species
...
https://projectpokemon.org/home/forums/topic/46259-yellow-kadabra/
2018-07-14 18:08:51 -07:00
Kurt
d2eba35504
Update interface parameter names
...
sync to previous
2018-07-14 18:08:30 -07:00
Kurt
6c8374f26f
Extract inner sprite building to class
...
any romhack maker can replace the behavior with their own builder
2018-07-14 17:53:37 -07:00
Kurt
6b7ba49cba
Remove unnecessary logic
...
gamestrings: call but not value used
text.cs: use gamestrings method for auto-filtered, now removes korean in
Gen3 context
2018-07-14 16:53:14 -07:00
Kurt
77c5d13034
Simplify memory ui handling
...
abstract away the details to another class
2018-07-14 16:32:06 -07:00
Kurt
4d73fa70d8
Simplify binding to ComboItem logic
...
could probably look into better binding but meh
2018-07-14 16:00:28 -07:00
Kurt
8c2b74c149
Refactoring
...
max IVs use flawless method directly with 6 IVs specified
move color blend/stat calc to ImageUtil
move potential string to commonedits
expose color properties for pkmeditor
don't constantly create/dispose brushes for drawing legal moves
2018-07-14 15:08:14 -07:00
Kurt
74f36b79af
Extract color config values
...
easier to modify
2018-07-14 13:17:56 -07:00