Thanks RustInPeace for initiating the conversation.
Getting EggLoc needs to call getLocation with eggMet set (for HGSS
mons).
Fixed 0 index for Box/Slot in the identifier; BOX 1 => B1
Should only add the pkm to the list if its checksum is valid.
Big thanks to Siobonbon for finally clearing up the muck that had been
sitting around for so long 👍
The mysterious dex flags are much clearer now, there is no 'via trade'
flag (it's the forms owned flag)
Eggs cannot have memories, and have all edits disabled.
When a pk6 is saved, memories will be cleared if they should not be
present.
Fixed empty regions showing up with data
Fixed not being able to edit the first georegion for an untraded Pokemon
All lock-outs for editing should be correct now.
'pkx' array was dummied out, resulting in the pk6 data not receiving the
party stats for writing.
Old bug: Having a Moveset with 1--4 (gap of two) would only remove one
of the blank move slots. Added method in the PK6 class for the (now
correct) fix-code; other fixes that are done when saving are now done in
separate methods as well.
Same functionality as the previous commit's adding of Max/Min stats for
IV/EV; this one should be easier to do (Control click the textbox to
max, alt to minimize/zero).
Removed SavePKX / OpenPKX; they are only used inside one method and
don't need to be persistent.
Control to modify IVs, Alt to modify EVs
Left click to set to 31 (or max remaining EVs)
Right click to set to 0.
Feels much better with the Key being the IV/EV switch, not the
left/right click (for left/right column editing).
Think of it as L(oad)/R(eset) 👍
Can't find any more problems; found an existing bug when opening the
Memory editor where it did not fetch the current Friendship or set the
final Friendship back.
Introduced the fully editable PK6 class object, which is now used by
PKHeX's pk6 editor, as well as updated the Box Data Report. Readability
should be increased as no
Includes bug fixes:
Odaxis' report regarding Event Flag Editor
Showdown sets using "Trait" instead of "Ability" (old old style) now can
be read.
Imported showdown sets will not use the imported gender label (instead
uses the current style, same 'value')
If the user were to set to the last slot, the setParty method would
trickle the data down, but the getQuickFiller would then make a sprite
appear in the slot it was trickled from.
Since setParty refreshes the party sprites, there's no need to do it for
anything but a party slot.
Remove numerous inter-form dependencies, remove hard-coded offsets,
update a few spots to use better programming practices.
Should increase the readability of PKHeX's source code.
