Kurt
76cac85243
Minor clean
2021-12-27 13:50:21 -08:00
Kurt
cc8ac7a4f1
Remove unnecessary warning suppression
...
fixed dat .editorconfig in vs22
Catching general exceptions is okay because this program handles user modified data that can potentially be corrupt.
2021-12-27 12:09:15 -08:00
Kurt
5f7caf9ca2
Tweak PB8.FixMemories for importing eggs & handler quirk
2021-12-27 01:53:28 -08:00
Kurt
29fd17a6f9
Add friendsafari to HA metadata permission
2021-12-26 23:05:25 -08:00
Kurt
24e1898410
Update gen4 Shedinja handling
...
PK4->PK5 fixes gendered Shedinja -> genderless.
Clean up PK4 ball value setters and expose those 2 properties separately.
Add edge case permission for HG/SS Sport Ball Shedinja being legal if evolved on DP (DP doesn't change 0x86, lol)
Copy PokéathlonStat and ball values individually for BK4<->PK4 conversion
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
2021-12-26 20:13:36 -08:00
Kurt
f50684b794
Remove childless xmldoc
2021-12-26 19:44:04 -08:00
Kurt
749293fc75
Move BoxManip to subfolder
2021-12-26 19:43:42 -08:00
Kurt
3d7967fcfe
Fix recognition for cutecharm Nincada->Shedinja
...
GetGender would return 2, which would abort the Cute Charm check since genderless is not able to be cute-charm'd.
https://projectpokemon.org/home/forums/topic/57375-pkhex-new-update-legality-errors-contribution-page/?do=findComment&comment=271537
2021-12-26 18:22:41 -08:00
Kurt
11039f1119
Extract some event unlocking logic for core
2021-12-26 18:21:34 -08:00
Kurt
76ab09f024
Inline constant value
2021-12-26 01:06:30 -08:00
Kurt
1d0993f852
Remove EvoBase, relocate functions to call sites
...
Utilize FormInfo to remap battle forms into hatch forms so the encounter matches something valid, and is flagged later in FormVerifier
2021-12-26 00:57:40 -08:00
Kurt
b348e38a3e
Don't do DP english->jpn bug for BDSP
2021-12-26 00:06:10 -08:00
Kurt
192ef23052
Allow gen5 deerling and sawsbuck slots to be any form [0,3]
2021-12-26 00:00:38 -08:00
Kurt
49a2cd19d0
template=>pk4: Only ENG->JPN if DP, not Pt
...
Language bug was fixed after ENG DP (for other localizations, and Pt)
2021-12-25 23:59:18 -08:00
Kurt
ac6fd085ba
Update translation files
2021-12-25 19:03:11 -08:00
tastymeatball
2d3fae889b
Update flags_e_en.txt ( #3350 )
...
add a lot of flags to emerald
2021-12-25 18:57:02 -08:00
Kurt
9ce0da6c46
Add bdsp approximations for min sheen calcs
...
Closes #3351
2021-12-25 18:51:02 -08:00
Kurt
fbb9e0bf0e
Flag original catchrates on g1->g2->g1 transfers
...
Closes #3328
2021-12-25 18:44:37 -08:00
Kurt
13e0f35e00
Add munchlax slot checking for DPPt/BDSP honey trees
...
Closes #3352
2021-12-25 13:48:28 -08:00
Kurt
2d34411203
Fix g8 meister magikarp matching
...
5b2ad8703c
2021-12-25 12:57:05 -08:00
Kurt
defae6727d
Check bdsp version exclusive hatch locations
...
lol srsly
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-12-24 18:39:54 -08:00
Lusamine
8612404f84
Add Slippery Slope Weavile static encounter
2021-12-24 20:06:31 -06:00
Kurt
42d24ad183
Add sketch check for bdsp legends signature moves
...
Can't learn these yet
2021-12-23 01:57:53 -08:00
Kurt
46f5a9c29a
Remove inaccessible zone IDs from hatch location list
...
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-12-23 01:25:14 -08:00
Kurt
606818b835
Bounds check sketch move IDs for generation
...
Smeargle no longer permitted to have Eerie Spell in gen6 format :)
2021-12-23 01:24:47 -08:00
Kurt
4e7e23cb88
Add battle tower record editing
2021-12-20 23:48:05 -08:00
Kurt
36a97a6eda
Add misc edit to defeat all trainers & rebattle all
2021-12-20 19:26:07 -08:00
Kurt
39f8e9173e
Add contest stat batch modification
2021-12-20 19:16:23 -08:00
Kurt
1e0ac7fb26
Ban more BDSP egg moves before HOME
...
https: //github.com/kwsch/UnityDPtools/pull/2
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
2021-12-20 19:00:48 -08:00
Kurt
38a4135bcd
Span-ify the unpacking of mini arcs
...
cuts out some of the internal c# sanity checking for better perf
2021-12-20 18:37:45 -08:00
sora10pls
260036a90b
Add Holiday 2021 distribution raid data 🎄
2021-12-16 19:04:28 -05:00
Kurt
98713f4d7b
Move inventory item clearing to class
...
Fixes ClearItem offset being wrong
2021-12-13 18:31:00 -08:00
sora10pls
57efeff0ee
Expose WK_SCENE_GAME_START in Work Values
...
hilarious that you can use this to skip the opening movie
2021-12-13 18:43:31 -05:00
Kurt
6b2ea0894e
Bypass encounter slot check for radar slots
...
https://projectpokemon.org/home/forums/topic/57375-pkhex-new-update-legality-errors-contribution-page/?do=findComment&comment=271406
https://discord.com/channels/401014193211441153/679178558597496872/908489378043686944
2021-12-12 13:16:27 -08:00
sora10pls
3e92d5a85d
Add Dialga/Palkia + Roamer resets to Misc Editor
...
For roamers, go back to Lake Valor/Fullmoon Island, and re-interact with Mesprit/Cresselia so that the game can generate a new one.
Also add Rotom rebattle event flag, and fix consistency with flag labels.
2021-12-12 11:28:48 -05:00
sora10pls
c05b79b532
Handle Route 229 <=> Route 230 crossover case
2021-12-12 09:18:57 -05:00
Kurt
5b2ad8703c
Handle g8 meister magikarp language goofiness
...
Only 5 & 1 language IDs are used
2021-12-11 22:23:05 -08:00
Kurt
47a1fd10e4
Allow surf crossover from r223<->pkmleague
...
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-12-11 21:31:32 -08:00
Kurt
aa968f56aa
File scoped namespace for drawing projects
...
Extract color util to separate class as it's not entirely image related.
2021-12-10 00:15:04 -08:00
Kurt
9f920405df
Revise gen3 sheen max extrapolation
...
any contest stat sum above 73 can have any sheen if you really give it trash blocks, lol
not trying to bruteforce the exact combination of consumed blocks/poffins, so these clamps may permit impossible intermediate values, but these are infrequent and meh.
Closes #3325
2021-12-09 23:33:54 -08:00
Kurt
e5efbdcbf0
Remove head smash from hgss nosepass eggmoves
...
Closes #3327
2021-12-09 22:41:14 -08:00
Kurt
2e20e75168
Temp handling for bdsp case
2021-12-09 19:53:43 -08:00
Kurt
f1fe2f6a8c
Minor clean
2021-12-09 19:30:12 -08:00
Kurt
e84932badd
Remove unnecessary trailing comma
...
nit
2021-12-09 19:10:50 -08:00
Kurt
d7e1f65faa
Add some xmldoc, file scoped namespaces
...
Not much of a git diff history for these files so I don't mind them being reformatted.
2021-12-09 18:58:30 -08:00
Kurt
18469a78aa
Set legal default ball for bdsp bred egg templates
2021-12-09 18:39:03 -08:00
Kurt
22cd12ee8d
Recategorize bdsp Honey Tree encounters from Grass to HoneyTree
...
Now they no longer show as Radar possible (no longer "grass")
2021-12-09 15:55:14 -08:00
Lusamine
e617beb604
Add Lost Tower to zones where Radar can't be used
2021-12-09 11:02:12 -06:00
Kurt
6e0170f938
Update eggmove_bdsp.pkl
...
Of all the available Pokémon in BDSP, the following cannot have these corresponding Egg Moves:
Snorlax: Power-Up Punch
Taillow: Boomburst
Chatot: Boomburst
Revert this commit when HOME is available for BDSP
2021-12-09 01:30:20 -08:00
Kurt
870a38c607
Use primary constructors for some records
2021-12-09 01:08:46 -08:00
Kurt
51c75dd102
Explicitly implement IFixedAbilityNumber on all templates
2021-12-09 00:46:59 -08:00
Kurt
90956f3b05
Flag encounter slots that cannot obtain HA or use ability patch
...
Ex: old chateau Gastly in bdsp cannot have HA as it is not different from base abilities
2021-12-08 23:43:32 -08:00
Kurt
aa78152856
Implement hidden ability (pokeradar) possibility for slots
...
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-12-08 23:41:50 -08:00
Kurt
0bb4534870
Reset contest stats to enc instead of zeroed
...
Can't lower contest stats, but there's no cases of them giving a pkm with contest stats in a game that can't obtain contest stats -- let's just reset instead of zero for futureproofing.
Make them extension methods too; add an overload if you want to purposefully maximize them.
2021-12-08 22:43:56 -08:00
sora10pls
88822b4e68
Update minimum Egg hatch cycle legality
...
0 is legal in most cases except for Gen2 and BDSP!
...it's technically possible to get 0 in BDSP if you have autosave turned on and have an Egg in your party after hatching one before it, but it will hatch immediately on your next game startup, so disallow it anyway.
2021-12-07 20:38:00 -05:00
Kurt
543359fff6
Add contest stat sheen checking
...
Closes #3324
2021-12-07 00:54:39 -08:00
Kurt
fcd97d5989
Don't add TR moves as possible for BDSP origin
2021-12-06 00:01:13 -08:00
Kurt
cacd6e9965
More records/sealing
2021-12-05 23:54:59 -08:00
sora10pls
ffebc74b90
Update National Dex Underground encounter minimum requirements
...
See https://github.com/kwsch/UnityDPtools/pull/1/files for more details.
2021-12-05 12:00:51 -05:00
Kurt
7e4877e7de
Add 3 more useless blocks
...
Spinda registers correctly now, lol
2021-12-04 23:52:33 -08:00
Kurt
40ed5898af
Merge extended property patterns
2021-12-04 18:37:47 -08:00
Kurt
88ddc5822e
c#10: readonly record structs
...
Reduces some boilerplate constructors/equality compares
2021-12-04 18:32:35 -08:00
Kurt
f55c5bea66
Minor clean
...
no functional change
2021-12-04 17:56:56 -08:00
Kurt
9a1b2719ec
Add simple legal item filtering for giveall
...
Closes #3318
Gen8: if held item, only give if can be legally held; if dmax crystal, only give if available.
Gen8b: if held item, only give if can be legally held
Others: unimplemented; pull requests accepted.
2021-12-04 12:24:32 -08:00
Kurt
4cb80b5463
Update memory feeling localization files for gen8
...
Keep the old localizations around for displaying gen6 format memories in their original localization.
I didn't rename the files so the git diff was clean for showing the re-localized lines.
Closes #3302
2021-12-04 11:40:40 -08:00
Kurt
3e59d481c4
Move bred pokeball short circuit to gen-specific function
...
Now flags safari-exclusive species in pokeballs
2021-12-04 10:52:57 -08:00
Lusamine
aef7987f82
Enable SWSH restaurant memory
...
Obtained by eating at the Circhester restaurant in story mode!
2021-12-03 16:58:07 -06:00
Kurt
e50bb8f288
Abstract-ify pouch items; acknowledge sort order
...
Closes #3320
Should better handle bdsp inventory format; shows sort order with the now-zero slots
2021-12-02 23:31:48 -08:00
Kurt
95454246b8
Skip eggs for EncounterTrade check
...
yay reusing Link Trade egg met locations wrong, ty ilca
2021-12-01 10:38:12 -08:00
Matt
483547f631
Update Tables8bs.cs
2021-12-01 06:16:45 -05:00
Kurt
4046ea0840
Handle encrypted pb8 file detection as pb8
2021-11-30 22:08:15 -08:00
Kurt
b74283560d
Add more useless bdsp saveblock objects
2021-11-30 22:05:20 -08:00
Kurt
8c9fb3a872
Add FieldObjectSave browser
2021-11-30 17:31:46 -08:00
Kurt
1c82b707f3
Add xmldoc, add egglevel get central location
2021-11-30 17:09:46 -08:00
Kurt
091e2c28cd
Add safari-only breed balls
2021-11-30 15:41:47 -08:00
Kurt
ef183ca1ff
Rearrange special case
2021-11-30 15:16:04 -08:00
XxPhoenix1996xX
1481831ec6
Update (ES) localization ( #3317 )
...
* Create flag_bdsp_es.txt
* Update flag_bdsp_es.txt
* Update lang_es.txt
* Update flags_c_es.txt
2021-11-30 13:19:06 -08:00
sora10pls
03c3f4a343
Force Poké Ball for all Riolu Eggs
...
Happiny not affected because Chansey is in the wild.
2021-11-30 16:14:53 -05:00
Kurt
1bb3255ab1
Add randomgroup block
...
Still does the same silly ARNG as gen4:
seed = 0x6C078965 * seed + 1;
to advance on each day
Do note that it sets event flag 1711 to true, and sets the absolute value of the "Random" to Work[436]. FLAG_DAILY_RANDOM, WK_DAILY_RANDOM, assumedly for easy use with scripts.
2021-11-28 23:31:01 -08:00
Kurt
4276ee1b9d
No exp gain for nursery
...
I'm not up to date on game mechanics, thanks matt.
2021-11-28 16:30:56 -08:00
Kurt
5b2bd2ef7e
Simplify expression
...
don't need to re-fetch when it's already in the stack
2021-11-28 14:34:28 -08:00
Kurt
488b411716
Check for bdsp traded eggs being re-flagged for Nicknamed
2021-11-28 14:32:41 -08:00
Kurt
73159053e2
Shift x0001 offset textfiles to x0000
...
Removes a lot of the offset-by-1 indexing, notably in the `GameStrings.GetLocationName` method which shifted everything 1. BDSP files we dumped don't replicate this off by 1, and I don't see a reason to maintain this off-by-1 for prior games since it's unnecessary quirks to maintain.
Zero indexed ftw.
2021-11-28 14:32:05 -08:00
Kurt
0189e84263
Clear all flags on seen none
2021-11-28 11:55:31 -08:00
sora10pls
dd6ec251d8
Update item localizations for BDSP
...
Some very minor changes made between SWSH and BDSP.
In BDSP (English), the Seal Case and Seal Bag are now localized to Sticker Case and Sticker Bag respectively, but because those items are unobtainable in BDSP, keep the older strings for Gen4's sake.
2021-11-28 00:26:00 -05:00
sora10pls
dfff798855
Label more BDSP flags/work vals
2021-11-27 23:12:29 -05:00
Kurt
cc34d40120
Update 21.11.27
2021-11-27 10:50:42 -08:00
Kurt
335baf68e6
Reorder poffin names from raw -> indexed
...
StreamingAssets\AssetAssistant\FureaiHiroba\fureai\masterdata\PoffinResult.json indicates which text line is used for a given MstID
Change Taste to Smooth to match community's naming
2021-11-27 10:20:22 -08:00
Kurt
be3af9fba9
Add bdsp poffin editor
...
The RAM is pretty dirty for unallocated poffins; slots that have never been filled will have junk with whatever the unallocated pointer was looking at.
An empty poffin slot is just marked as FF, ignores the stats for that slot. Not sure on the naming, but Matt had a single Level 60 poffin -> must be Mild? Thus, all the names are -1 from the textfile array...
2021-11-27 02:06:35 -08:00
Kurt
b34977d498
Fix feebas prism scale evo criteria ban
2021-11-26 21:16:13 -08:00
Kurt
fd4dd6e2fb
Indicate teamlocks in boxes
2021-11-26 19:54:07 -08:00
Kurt
d9a87f908d
Update RibbonVerifier.cs
2021-11-26 19:37:29 -08:00
sora10pls
60c5b8b766
Merge branch 'master' of https://github.com/kwsch/PKHeX
2021-11-26 22:12:02 -05:00
sora10pls
8bce248d95
Crop BDSP Box Wallpapers, re-tile Grass, and fix off-by-one
2021-11-26 22:11:54 -05:00
Kurt
d7ed6713c5
Update WB8.cs
2021-11-26 19:06:36 -08:00
Kurt
66a2046e5a
Fix move search loop
2021-11-26 16:50:30 -08:00
Kurt
329a663383
Update evos_bs.pkl
...
Closes #3314
Thanks @NinFanBoyFTW !
2021-11-26 15:54:43 -08:00
Kurt
435dbb0b57
Disallow sister version exclusive ribbons for exclusive forms
...
Spiky pichu cannot receive Sinnoh ribbons
Cosplay pikachu cannot receive Kalos ribbons
Closes #3286
Co-Authored-By: Kermalis <29823718+Kermalis@users.noreply.github.com>
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-11-26 15:41:24 -08:00
Kurt
2560d0eb28
Change safari seed to uint
...
matches community handling of seeds
2021-11-26 11:31:00 -08:00
Kurt
5d4a8e5328
Add Mystery Gift records for BDSP
2021-11-26 11:08:51 -08:00