Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-16 17:18:00 +00:00
Code Issues Projects Releases Packages Wiki Activity
4132 commits 3 branches 76 tags 106 MiB
Commit graph

777 commits

Author SHA1 Message Date
Kurt
0aa4dad921 Add species parse edge case 
dashes in species name && dash for forme name, handle edge case.
Closes #1673
 2017-11-30 18:24:31 -08:00
wwwwwwzx
5700adfb59 Update Chinese translations 
- USUM texts CHT -> CHS
- Translate subform names
- Update legality strings
 2017-11-30 18:15:36 -08:00
Kurt
8c675793ba Fix gen4 trade nickname/ot check 
Closes #1672 by changing length check to check the correct dimension
add handling for DP english trades (localization error).
 2017-11-30 18:13:30 -08:00
Kurt
9930e8765a Add frame level checking 
still WIP but should be working fairly well
 2017-11-29 23:20:49 -08:00
Kurt
d3d7d7d50d Add slot level / IsEncounterable beginnings 
dynamic level -> calc level
no sweet scent -> proc available (rock smash/fish)

change frame checking in encountergenerator to save which frame it was
found on (unused but possibly later can capture this for output)
 2017-11-29 21:31:52 -08:00
Kurt
fdc52e2c19 Add pkm league starter EC for gen7 
Closes #1671
 2017-11-29 20:04:01 -08:00
Kurt
4a898b0829 Leave empty item slots for gen7+ 
game depends on an existing value to check for if the item is truly
"New"
Closes #1670

Don't clear count=0 slots for gen7+
For sorting, put all the count=0 at the near top (any feedback on how
this actually works?)
 2017-11-29 19:47:27 -08:00
Kurt
36894a588d Add FRLG unown frame matching 
Turns out there was no documentation anywhere on encounterslot numbers
for the individual forms; some sites had overall rates.
Assuming a human filled out the encounter slots, forms would repeat left
to right until a new form takes over. Below slot numbers match the rates
when summed up.

https://pastebin.com/raw/bQt3ZMbq
 2017-11-29 18:28:20 -08:00
Kurt
8f8cf5bc9a Fix tradepair calculation (link trade eggs) 
returned invalid pair values for gen7 due to 2 unused game IDs between
the gen6&gen7 pairs
 2017-11-29 09:21:17 -08:00
Kurt
acb105b706 Fix platinum altforms not having formcount set 
fix by hex editing the manually altered field in the personal table so
that it matches HGSS
thanks @sora10pls !

fix unused writeback location for saving tmhm data
 2017-11-28 23:14:08 -08:00
Kurt
dc2ef24fcd Handle fixed lang trade name detection explicitly 
edge cases suck
 2017-11-28 22:26:31 -08:00
Kurt
dd7684735a Add Frame mismatch illegal message handling 
encounter will no longer be ignored as valid, will instead show the RNG
frame mismatch message.
 2017-11-28 21:30:53 -08:00
Kurt
c7a59453b1 Fix frlg safari rod slot checks 
tfw whole legit boxes of dratini were flagged -> now legal
 2017-11-28 20:56:21 -08:00
Kurt
fb4fffffa0 Change rse feebas to swarm slottype 
behaves the same as a swarm pkm in terms of proc (50% -> level ->
generate), so have it travel the same code path.
 2017-11-28 19:41:29 -08:00
Kurt
0bc2ee0938 Skip scatterbug static encounter forme check 
closes #1668
add 2/3 pkms provided as test cases (spewpa can be ignored, close
enough. just want an evo & orig).
 2017-11-28 19:29:25 -08:00
Matt
42d6d483f2
Comment out Old Amber Aerodactyl 2017-11-28 19:10:56 -05:00
Kurt
1e0bf7b6ea handle hgss volty pikachu trade lang swap 
en<->fr
not sure what FR has for the pikachu language (is it EN? if so the code
here works fine); if not, the OT should be checked for lang detection.
 2017-11-27 23:21:19 -08:00
Kurt
daa49a23a2
Merge pull request #1666 from sora10pls/master 
Event Flag/Constant revisisons
 2017-11-27 22:54:16 -08:00
Kurt
c5b7ebf50a Add egg forme check 
all other egg formes that are disallowed are checked later; check for
totems here
Closes #1667
 2017-11-27 18:13:54 -08:00
sora10pls
2dc33f5473 Slight fixes 2017-11-27 19:56:03 -05:00
sora10pls
06e6afbacb Revise several event flags/constants 2017-11-27 19:51:49 -05:00
Kurt
f13cc289a7 Move eventflag offset fetch to SAV2Offsets obj 2017-11-27 16:46:14 -08:00
pokecal
e86b8c670f add Crystal GS EventFlags 
have checked with US ver.
 2017-11-28 03:35:55 +09:00
Kurt
b2c3884391 Permit 5->6+ forme mismatch keldeo 
BW tutor -> transfer up doesn't update the form
thanks @wwwwwwzx !
 2017-11-26 22:19:27 -08:00
wwwwwwzx
f70dab1d19 Remove duplicates 
oops..
 2017-11-26 20:45:27 -08:00
wwwwwwzx
5886b3e609 ban beast ball fossils 
- Add G1/G3/G6 fossils to Alolannatives
- Ban all fossils in beast ball
 2017-11-26 20:38:52 -08:00
Kurt
be4d30bb6d Add pokeblock slot filtering 
since there's 300 calls to rand to shuffle, I wouldn't be surprised if
there are vblanks messing up the frames

judging from my data 6 years ago (wow, still wrong, just look at the
frame offsets)

http://www.smogon.com/forums/threads/past-gen-rng-research.61090/page-35#post-4021415

looks like it happens quite erratically. may have to just override this
to return true for all gen3 safari mons as it's entirely unpredictable.
 2017-11-26 20:07:38 -08:00
Kurt
187726b4af Use static/magnet pull values 
reorganize a little for lead use cases
 2017-11-26 16:09:24 -08:00
Kurt
22abce5e16 Update gen3 frame finder 2017-11-26 14:48:55 -08:00
Kurt
0f3529e764 Add gen3 swarm encounter slot call 
via pret/pokeemerald (and pokeruby); rate is set at 50%
swarm pokemon have the ability to have 4 fixed moves, so derive from
EncounterSlot to have moves, and remove special handling from
VerifyCurrentMoves (now picked up by IMoveset pattern
 2017-11-26 11:00:54 -08:00
Kurt
b30cc933e5 Extract festafacility from gui code 
move to core project as a structure/class
 2017-11-26 08:47:25 -08:00
Kurt
61ca9232e2 fix sav3 dexflag get/set 
incorrectly added bit offset twice
Closes #1660
switch /8 to >>3 for consistency with gets
 2017-11-26 08:37:08 -08:00
Kurt
1162ba5b3d update bcc slot table 
https://pastebin.com/Y0VRnJxu
not sure what the 2nd rand value is

still some things to sort out with RoC's PC
 2017-11-25 22:28:38 -08:00
Kurt
2be84b6005 Rework encounterslot location fetch 
store ref to area instead of location, useful for fetching sibling slots
from the parent.
 2017-11-25 18:16:50 -08:00
Kurt
690cbaae79 Unban fossils 
except for aerodactyl (old amber not obtainable)

https://projectpokemon.org/home/forums/topic/42761-fossil-legality-issue-usum/
https://www.serebii.net/itemdex/clawfossil.shtml
etc
 2017-11-25 15:20:45 -08:00
Kurt
ad5e69550e Add hgss safari slot block priority bypass 
allows hgss safari mons regardless of frame call (table is currently all
Slot=0).

may need separate handling down the road:
* switch slot number to an enum for slot codes (>0 = slot number, less
than -> do something else).

not something im interested in right now
 2017-11-25 15:03:37 -08:00
Kurt
fbce8582c7 Add encounter slot checking 
emerald silly stuff like magnet pull not implemented so some stuff may
be not matched.
 2017-11-25 13:53:39 -08:00
Kurt
76903bce9f Fix gen4-6 gen4 origin encounter type defer check 
only check etype if appropriate (not gen7+)
 2017-11-25 09:48:49 -08:00
Kurt
d1bae13250 Add flagging for crystal transfers 
users should know better but best to know
allow gen2 female when from crystal
 2017-11-24 18:19:16 -08:00
Kurt
a7866d3ed0 Simplify crystal detection 
any crystal-only data => crystal
no change in overall function for legal pkms being transferred
 2017-11-24 18:12:30 -08:00
Kurt
1aea5ac7de Switch crystal detect to gender 2017-11-24 16:21:52 -08:00
Kurt
bb5456bf9d Update 17.11.25 
Update event binaries with latest from the Event Gallery
 2017-11-24 14:15:01 -08:00
Kurt
d757282ffe add cxd spanish item names 
thanks JoseAbad !
 2017-11-24 13:19:13 -08:00
Kurt
20cd29c088 remove mind blown for sm 
off by one
Closes #1658, thanks @Ntonio36
 2017-11-24 12:05:08 -08:00
Kurt
3483b4bb91 Clean up vc2 legality/transfer stuff 2017-11-24 10:13:42 -08:00
Matt
c2fa0892f1
Fix Nihilist flag 2017-11-23 16:13:08 -05:00
Matt
71403c3541
Fix Cosmog/Magearna flags 2017-11-23 15:09:19 -05:00
Kurt
c8bd6d8aea misc kor encoding updates 
transporter/bank parsed:
fix 벵벴 swaps (verified ingame)
switch ⋯ for … to match bank
add blank space (u3000) for 0xFF to match bank
note 0xB6C is incorrectly 0xB6D in transporter (=> "."); not an issue as
not a valid char choice ingame.

table data dump: https://pastebin.com/R254mB9p
reproduce via exefs: (kor1-B table followed by english analog
kor_table0)
int ofs0 = 0x1BE3C0;
int ofsK = 0x1BBE48;
int len0 = 0x130;
int lenK = ofs0-ofsK;

A+ parsing: https://pastebin.com/FAxpadxs
 2017-11-23 10:18:09 -08:00
Kurt
b8a5657d5a misc tweaks 
pull out transfer locations to const references
add vc2 & crown beast/celebi met location suggesting
add vc2 crystal sensitive detection
add 2 more usum trainer stats (thanks holla!)
 2017-11-22 21:45:30 -08:00
Kurt
4bbe586981 block ash greninja from USUM game origin 
should really be part of a 'receivable by game' check; not doing any
more of these edge cases. need card hash -> permit bits for future
cases.
 2017-11-22 08:24:54 -08:00
Kurt
d834ae3ccf allow banned pokemon for BattleTreeGreat in USUM 
stupid banlist removal case
master still downlevels/bans
 2017-11-22 08:23:50 -08:00
Kurt
d5411f1453 Add nickname flag override for encountertrade 
closes #1649
 2017-11-22 08:11:53 -08:00
Kurt
9806677d5e EncounterType init update 
move MarkEncounterTypeData back above the area size reduction so that
the mark-by-locationID special handling will work
prevent slottype from becoming overwritten if already defined by special
case handling

add examples provided to automated test cases
closes #1648
 2017-11-22 07:52:17 -08:00
Kurt
f25b4fea9c Add forme range check method to personalinfo 
relocates logic to better location
 2017-11-21 18:32:27 -08:00
Kurt
b2b6df7808 Shuffle encountertype loading around 
add rocksmash type for cianwood
closes #1646
 2017-11-21 18:32:26 -08:00
Ntonio36
0578ec19a9
Light retyping 2017-11-22 01:50:33 +02:00
Kurt
9923dc4a7a Update spanish legality translation text 
https://www.diffchecker.com/nKe4LYso
Thanks JoseAbad !
 2017-11-21 15:37:48 -08:00
Kurt
05f2968c95 Add wormhole species to AlolanCaptureOffspring 
allows apricorn & beast balls
 2017-11-20 17:16:16 -08:00
Kurt
1e5fc96e8e fix gs met location errors 
override current location if format is GB
update GS transfer location ID
 2017-11-20 09:11:37 -08:00
Kurt
8b2ec89c52 Add default value for formecount 
https://projectpokemon.org/home/forums/topic/42632-bug-gsc-titles-support-broken-gs-transfers-not-recognized/?do=findComment&comment=223647
 2017-11-20 08:08:48 -08:00
Kurt
6534ef1919 Refactoring 
Reworks festa facility into a get/set object, simplify some operations
naming convention (PascalCase) for methods/properties
closes #1635
 2017-11-19 21:25:46 -08:00
Kurt
8f5fbeb504 allow pupitar hidden ability on 2->7 
yay
 2017-11-19 19:48:45 -08:00
Kurt
a570d13dc5 Quacklin’ edge case 
can't be bothered remapping the input file to match encoding/decoding
tweaks. best to just handle this one case.
 2017-11-19 19:37:25 -08:00
Kurt
01dacce214 Add gs transfer met location 
30017
 2017-11-19 19:19:35 -08:00
Kurt
70ec1fda5e cleanup 
wasn't able to view the designer layout so I removed & readded to
project -- works fine now.
uppercase method names
 2017-11-19 16:16:44 -08:00
Kurt
a8d5acdd50
Merge pull request #1635 from pokecal/master 
add G7 FestivalPlaza Editor
 2017-11-19 15:27:13 -08:00
Kurt
ef9722153f move evochain fetch outside of location iterator 
also relocate gen12 code so it only runs for gen12
 2017-11-19 15:26:41 -08:00
Kurt
f5aa3c3b0a Fix form not specified check for totems 
Closes #1634
 2017-11-19 14:16:28 -08:00
pokecal
3c85b0ead3 add G7 FestivalPlaza Editor 
There are too many phrases,
I have no plan to complete all list of phrases.
But I think user can edit phrases of each facility
 by using their phrase settings.
 2017-11-20 06:50:39 +09:00
Kurt
237f376354 Add battle style learned flags for usum 
thanks @sora10pls
 2017-11-19 13:30:17 -08:00
Kurt
6d3ee54d44 Reorder case fallthrough 
closes #1631
based on
5859daf1d8
any case -> reverse game order
 2017-11-19 13:15:32 -08:00
Kurt
1b9d657c2f Remove double encounter slot species filtering 
GetValid already filters by species
move some common non-location code out of the method; can be done for
the dexlevel fetching too -- future improvement.
 2017-11-19 12:41:23 -08:00
Kurt
469587bbbd Add Rotom OT name 
"nah lets just store the OT in the save file twice"

add a double check if OT != RotOT to remind the user
 2017-11-18 22:26:57 -08:00
Kurt
5859daf1d8 Add maxspecies checks for gen7 
accesses arrays outside the range for the new USUM species
Closes #1631 , add test case
also adds lycanroc test cases for #1630
 2017-11-18 21:50:48 -08:00
Kurt
6b281cbefe more rockruff 1 handling 
y u do dis gf
Closes #1630
 2017-11-18 20:08:11 -08:00
Kurt
f29529d141 Add spanish legality translation 
Thanks @BlackPyoVic!
 2017-11-18 17:38:06 -08:00
Kurt
3b5e6239de Add usum pelago encounters 
nothing exclusive, but different from sm
https://pastebin.com/NhAA1vJn
 2017-11-18 13:53:51 -08:00
Kurt
6394dac19f Rework mysterygift pkm sprite generation 
don't bother converting to pkm then generating the sprite off that; use
the overload with int/bool

removes sav/pkm dependency for generating gift descriptions, and
standardizes the names a little. maybe a PKMBase interface would be
useful...
 2017-11-18 11:34:23 -08:00
Kurt
f7e20a3c43 Misc tweaks 
fix roamer3 not setting IVs
fix usum z items rightmost pixel getting chopped off
use Gen* instead of GenNumber for specific cases (faster)
add WasGiftEgg location case for Gen7
remove some unnecessary array allocations
 2017-11-17 22:19:23 -08:00
Kurt
6a033b00fc
Merge pull request #1628 from wwwwwwzx/master 
Unban white/orange Flabebe HA
 2017-11-17 20:40:30 -08:00
Kurt
b111b9dad4 Add totem showdown export 
soontm
https://github.com/kwsch/PKHeX/issues/1626#issuecomment-345417263
 2017-11-17 20:38:43 -08:00
wwwwwwzx
f48e6f711a Unban white/orange Flabebe HA 
obtainable from SOS call
 2017-11-17 20:19:41 -08:00
Kurt
311e110f6b Block wild dusk rockruff 
closes #1627
adds test cases
 2017-11-17 20:02:01 -08:00
Kurt
9d1ca22b6d Add usum showdown forme/species i/o 
Closes #1626
 2017-11-17 19:14:27 -08:00
Kurt
523c03606e Add guard check for out of range gen1 species 
Thanks ShadowMario3!
 2017-11-17 17:07:12 -08:00
Michael Scire
d56354822c Fix Magearna gift flag, add can-receive flags 2017-11-17 14:27:28 -08:00
Kurt
61c0bf5271 Fix italian/german b2w2 yancy/curtis OT swap 
https://projectpokemon.org/home/forums/topic/42528-bw2-in-game-trades-yancycurtis-20171117/
 2017-11-17 08:38:38 -08:00
Kurt
5ae7c9a5da
Merge pull request #1623 from ReignOfComputer/master 
Flip Valid Trade OT Compare Operator
 2017-11-17 08:31:30 -08:00
Kamron Batman
eb635c31de Fixes reference in csproj. 2017-11-17 08:16:57 -08:00
Kamron Batman
d2d04075bc Replaces PCD.pkl with WC4.pkl. Tested and working. 2017-11-17 08:11:49 -08:00
ReignOfComputer
69f11ec3bc Flip Valid Trade OT Compare Operator 
Related:
https://projectpokemon.org/home/forums/topic/42528-bw2-in-game-trades-yancycurtis-20171117/
 2017-11-17 23:57:55 +08:00
Kurt
55d8f4aa26 Add rockruff event evo edge case 
different altform IDs
 2017-11-16 21:04:51 -08:00
Kurt
e4b48b2712 Update 17.11.17 
Update event binaries with latest from the Event Gallery
 2017-11-16 19:32:58 -08:00
Kurt
025b8da52c Flag invalid forms on sav compatibility check 
closes #1615
 2017-11-16 14:30:18 -08:00
Kurt
8958646ae6 Fix game specific pair evolution comparison 
US table with SN result in false; just check the even/odd for these (as
they are pair specific).
Closes #1611 , thanks @Ammako !
 2017-11-16 14:20:13 -08:00
sora10pls
a977b722db USUM event flag updates 2017-11-16 16:01:06 -05:00
Michael Scire
e8d1d1f521 Add "IsSMCompatible" helper method to PK7. 
Translated from official game code (PokeRegulation::CheckNijiCompatible).
Potentially for future use in USUM -> SM transfers?
 2017-11-16 12:23:35 -08:00
pokecal
909148a42a add USUM UB flags 
Stakataka APPEARABLE means NOT CAPTURED,
I think the latter will get misunderstand as CAPTURED,
so I adopt former.
 2017-11-17 02:31:36 +09:00
pokecal
33c37370c3 add UltraRide SlidePad flag 
SlidePad will be enabled from the first play.
 2017-11-17 00:06:36 +09:00
Kurt
0cfb79a3e2 handle hacked edge case input 
gen7 pkm version on format5 -> exception on new int[-X]
normally caught via exception suppression but better to handle the
cause.
 2017-11-15 18:13:04 -08:00