Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-27 14:30:56 +00:00
Code Issues Projects Releases Packages Wiki Activity
7671 commits 4 branches 76 tags 107 MiB
Commit graph

1617 commits

Author SHA1 Message Date
Kurt
b242aed429 Add ability to load blank japanese/korean save files 
Detects the language of the currently loaded save file, and passes that info to the blank sav creator

Use a trainer name of "1337" instead of PKHeX for any Japanese save file, because Gen1/2(/3?) character tables don't have regular ascii chars.
 2020-10-03 11:22:06 -07:00
Kurt
52a67f2425 Add Stadium2 Support 
Introducing a new PKM format: SK2
Split ICaughtData2 off of PK2 so it can be shared with SK2 when type-checks occur
Add conversion for PK2<->SK2
Split the split-buffer handling for GBPKM to GBPKML (what a name), so that I can reuse shared accessor logic for SK2.
 2020-10-02 18:08:40 -07:00
Kurt
22f37910f0 Remove unnecessary single-member interfaces 2020-09-27 18:19:28 -07:00
Kurt
82afefa335 Make GP1 expose IEncounterable for metadata 
Make the main loader handle IEncounterable objects
 2020-09-26 11:33:21 -07:00
Kurt
6243135f28 Minor clean 
Move Home8 location to Locations.cs for documentation
Move FestaFacility to correct folder
Remove unnecessary public modifier on interface method
Pass the program's Version to any loaded plugins, if they wanted to check compatibility...?
 2020-09-25 23:55:31 -07:00
Kurt
efc17a1271 Add interface for revised savefile types (patches) 
SWSH is the first common savefile type that has different revisions after official patches. We want to indicate in the Program Title which revision we're currently editing, because people still are not editing latest-format saves and complaining y no urshifu.

Use short descriptions to indicate revision (Base, IoA, CT), rather than magic numbers (v0/v1) or 1.X or 1.X.Y+, because GameFreak can't follow semver rules.

go away ranch platinum update, i might handle you another time
 2020-09-25 23:41:20 -07:00
Kurt
2b7e06e217 Refactoring 
Extract some logic, suppress some compiler messages
 2020-09-18 22:11:13 -07:00
Kurt
7a1c438b74 Minor tweaks 
add method to randomize AVs from interface extension method
revise stat presence check to check ATK since HP is stored in gen1 format
 2020-09-17 18:13:08 -07:00
soopercool101
1a1cfbda4a
Fix Hidden Power Power calculations (and add to UI) (#2989) 
* Fix broken hidden power power calculation

* Fix broken Gen 2 Hidden Power calculation

* Add parentheses

* WIP UI

* Finalize UI, only show on gens 1-5

* Inline some logic to reduce allocations

* Add unit tests for both hidden power calculation cases

Co-authored-by: Kurt <kaphotics@gmail.com>
 2020-09-14 20:06:11 -07:00
soopercool101
63be1fb0e7
Update Underground Editor UI (#2988) 2020-09-14 19:05:49 -07:00
Egzon
4b1a9a89da
Add support for reading and editing Underground Items (#2987) 
Adds a sub-editor with localized support for editing Underground Items.
 2020-09-13 14:55:50 -07:00
Kurt
407c986c89 Update netcore target from 3.0 to 3.1 
.NET 5 is in 2 months, might as well bump things to the current LTS
 2020-09-09 18:27:12 -07:00
Kurt
01fb233e48 Minor tweaks 
Extract some interfaces
Suppress some warning messages with commented reasons if appropriate
 2020-09-09 12:47:24 -07:00
Kurt
5d3bc289b6 seal hunting 
Mark things as sealed as they shouldn't be inherited from or overriden in a derived class.
 2020-09-07 13:51:13 -07:00
Kurt
9191f023a3 Minor clean 
Nullability annotations and some logic simplification
 2020-09-06 11:24:54 -07:00
Kurt
cf9e5ec37f Minor refactoring 
Change Ability array to IReadOnlyList, add method to check ability index in personal data
Suppress some message warnings
Change EvolutionChain short-circuit for VC to jump from gen6 directly down to gen2. There aren't any notradeback 1 situations, so a notradeback1 will always start with g=1, so no need for the other if-continue.

Simplify pk5 conversion
 2020-09-06 10:53:13 -07:00
Kurt
c2ec4d55e4 Minor clean 
Add some xmldoc, remove some empty lines, move some small logic pieces to a better spot
 2020-09-03 14:28:51 -07:00
Kurt
b03a5f2818 Fix pika beach score reading 
fix reads as little endian instead of big endian
fix truncation if editor value from byte => ushort
Closes #2976
 2020-09-01 16:05:52 -07:00
Kurt
9667e86446 Simplify dreamworld encounter init 
precompute result size
set Gen5 as lumped group for common encounters
remove linq usage (besides Sum call, whatever)
GetEncounters now only filters the in-game static encounters rather than the dreamworld too, as those are already filtered by separate arrays.
 2020-08-30 19:51:44 -07:00
Kurt
bd11affa13 Minor clean 2020-08-30 19:24:40 -07:00
Kurt
75da70069c Remove access to modified captured variable 
Get the variable rather than indexing into the array each time

Simplify some expressions in sav7 for readability
Make SAV_EventFlags use comboitem explicitly by type rather than an anonymous type with same member names
 2020-08-30 15:48:11 -07:00
Jonathan Herbert
6eb348848d
Handle Exception When Adding Font File (#2977) 2020-08-25 11:42:08 -07:00
Kurt
890f3375c9 Misc clean 2020-08-18 15:39:45 -07:00
Matt
f9b4c1950b
Add Catch Rate to KChart (#2972) 2020-08-15 16:13:15 -07:00
Kurt
541c9761df Minor clean 
Make flag indexes immutable
Rename some properties for clarity
 2020-08-14 20:23:54 -07:00
Kurt
d8fe197a3a Update 20.08.07 2020-08-06 19:15:16 -07:00
Kurt
12d9397c8c Split GO from "GG" gameversion 
Make Gen7b as the combined ver for that expression
 2020-08-06 18:24:20 -07:00
Kurt
85d1b0e7ad Split gen6/7 affection stats to interface 
not in future formats, doesn't belong
 2020-08-02 11:06:30 -07:00
Regnum
9e40fa132f
Improved Pokewalker Editing (#2958) 
* Added PokeWalker Courses, Watts, and Steps editing

* Use util method for getting bitflags

* Keep old cheat method

Change signature so that the default value passed is to unlock all; can pass 0 instead to lock all

* Pass reference to derived sav4-type object

Wev'e already type-tested once, capture the reference and pass it into the appropriate load/save methods.

* Add control anchoring for window resizing

Also widen the labels for localization (longer strings possibly)
 2020-08-01 09:20:13 -07:00
Kurt
e84ce77008 Split memories from main pkm class to interface 
pk6/7/8, not pb7
 2020-07-31 17:25:14 -07:00
Kurt
b7211000b0 Split Country/Region/ConsoleRegion from ITrainerInfo 
Only present in mainline gen6/7 game pairs, so it's not wise to have it for all games
 2020-07-31 13:53:42 -07:00
Kurt
36684ab867 Minor clean 
Simplify some expressions
 2020-07-31 11:20:48 -07:00
Kurt
27f15d2f20 Split Country/Region/ConsoleRegion to interface 2020-07-31 11:17:31 -07:00
Kurt
a221a27074 Click version/battleversion -> dropdown combobox 
User error help
 2020-07-25 09:58:21 -07:00
Kurt
6bb2612059 Restart program on settings reset 2020-07-25 09:51:56 -07:00
Kurt
318016e9e5 Fix re-layout on grid refresh 
closes #2946
 2020-07-21 23:50:23 -05:00
Alberto Tudela
2bae3e09e0
Spanish minor fixes (#2947) 
Minor Folder list fixes
 2020-07-21 11:59:51 -05:00
Kurt
a6a3c6eaaa Refactoring 
change some expressions for better perf/readability
 2020-07-19 17:48:45 -05:00
Kurt
e4092e64df Relocate gen3 ereader berry logic 2020-07-18 22:51:55 -05:00
Kurt
851d77ed3a Show "NEW" for gen8 item edits 
why not
 2020-07-18 20:27:22 -05:00
Kurt
a21bb09c37 Perserve & Display Favorite flag for items 
Also clamp give all for TMs to 1 instead of whatever the giveall value is, like for prior games' HMs

reuse the "free space" bool; no real benefit in increasing the amount of abstraction (even though that's my current urge for legality)
 2020-07-18 20:15:41 -05:00
Kurt
65ecd3ca9a Sync missing change 2020-07-18 20:07:55 -05:00
Kurt
705822c965 Abstract some gen1/2 encounter types from their parent class 2020-07-18 15:36:30 -05:00
Kurt
5c7f992ea9 Update 20.07.18 2020-07-17 21:45:46 -05:00
Kurt
523edecf7b Get actual value rather than magic index 
logic doesn't really work for gen2/3, so gate it behind gen4+ format only
 2020-07-06 17:32:40 -05:00
Kurt
993673f0de Minor clean 
no functional change
 2020-06-27 23:36:53 -05:00
Kurt
a7ba178005 Remove unreachable/const logic 
Earlier compares result in some logic being unnecessary

The Gen7 level up move compare was actually an oversight, so it's a worthwhile fix :)
 2020-06-27 22:44:14 -05:00
Kurt
0836d3191d Rewrite some magic gender value logic 
it's always been a byte for ratios, but we never know; plus, it's a little more self documenting
 2020-06-27 12:01:28 -05:00
kckxpyr1
38d9bf18c0
Update lang_zh.txt (#2906) 
This is more in line with the Chinese translation, I hope it can be modified
 2020-06-25 07:06:40 -05:00
Kurt
66a797371a add pokedex urshifu gmax translation strings 
copied localization from the other checkbox ;)
 2020-06-24 19:01:15 -05:00
Kurt
6574732380 Update 20.06.22 
Update wc8 binary with events from past month
 2020-06-21 23:06:52 -05:00
Kurt
6fb2ebe039 Minor clean 
add some xmldoc
 2020-06-21 19:46:06 -05:00
gjfkkk
6b506957c9
Update lang_zh.txt (#2876) 
* Update lang_zh.txt
 2020-06-21 09:33:44 -05:00
Kurt
b53a29a0af Add flag for urshifu-1 gmax pokedex 
ty @sora10pls
 2020-06-20 20:00:35 -05:00
Kurt
4f7845547e Minor clean 
Remove met location dynamic sizing for C/XD (already resized for SWSH)
add some xmldoc comments
rename some parameters
 2020-06-20 18:23:03 -05:00
Easy World
c0ee00cb7a
Update Chinese Localization (#2871) 
* Update LegalityCheckStrings_zh.txt

* Update lang_zh.txt
 2020-06-19 21:18:40 -05:00
XxPhoenix1996xX
0839882fda
Update Spanish Localization (#2870) 
* Update LegalityCheckStrings_es.txt

* Update lang_es.txt
 2020-06-19 20:53:21 -05:00
Kurt
e72a58bdee Dump latest translatable strings 2020-06-19 20:18:37 -05:00
Kurt
45a234814b Fix raid seed editing 
Because we pass in a reference to the raid block, rather than obtain the reference from the to-be-edited save file object (which was cloned), we need to restore the unmodified data to the save file instead of copying the modified save data.

Bad explanation, but we've edited the origin save data. Revert to original.
 2020-06-19 20:13:26 -05:00
Kurt
d6c5c6071d Hide armor raids when not available 2020-06-19 19:56:24 -05:00
Kurt
1c1e01bc1a Update 20.06.19 
Now with Isle of Armor support!
Closes #2867 , #2855
 2020-06-19 19:48:38 -05:00
Kurt
86a9711cc1 Show xor & tsv on gen3-5 
TSV/PSV was never abused during these gens, but whatever, show the raw details.
Closes #2868
 2020-06-19 18:59:00 -05:00
Kurt
36dd5ece21 Initial Isle of Armor support 
Co-Authored-By: sciresm <sciresm@users.noreply.github.com>
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
Co-Authored-By: Archit Date <architdate@gmail.com>
 2020-06-19 18:51:15 -05:00
Kurt
ce3f887a97 Handle dragdrop from zip (win explorer) 2020-06-16 21:53:24 -05:00
Kurt
2cdb5d26db Clean up some method signatures 
rename things to be a little more consistent in naming conventions
 2020-06-16 21:46:22 -05:00
Kurt
bfef634a1a Set shiny type regardless of format 
Don't loop if not required to loop
 2020-06-12 11:45:56 -07:00
Kurt
e338fce910 Minor simplification 2020-06-11 09:29:46 -07:00
XxPhoenix1996xX
2bd33dd7de
Update Spanish Translation (#2850) 
* Update MessageStrings_es.txt

* Update lang_es.txt
 2020-06-06 17:11:35 -07:00
Kurt
afa368823e Minor clean 
handle some compiler messages
 2020-05-26 16:59:47 -07:00
Kurt
4f039fe732 Remove duplicate icon 
only one icon file remains

make splash screen smaller since we don't have a 64x64 icon preview anymore (only 32x32 & smaller)
 2020-05-26 14:43:57 -07:00
Kurt
46b443903d Fix SM dex form fetch for spewpa 
Closes #2826

It doesn't find it in the SM table, but didn't return -1
rework logic flow to return when found, rather than after loop finishes.

Also fix display off-by-1 since we're not using zero indexing for our entry numbers.

Thanks @Ammako !
 2020-05-24 20:42:45 -07:00
Kurt
c4326698a5 Add prompt for loading new save with unsaved changes 
Closes #2823

remove old gen6 powersaves decrypted-xorpad strings (unused logic)
remove gen8 save fixing beta-pkhex-caused corruption (behaved for 6months)
 2020-05-24 11:03:23 -07:00
Matt
8c6d674472
Misc changes (#2838) 
Allow for up to 16 characters in SWSH Box Names.
Fix Rockruff-1 big sprite display.
 2020-05-21 16:19:25 -07:00
Kurt
6164884700 Merge IGeneration into IEncounterable 
all but egg exposed it; now, just make egg expose it and remove the unnecessary interface

we still need to Set generation for non-eggs/mgift, so have a separate Settable interface for internal purposes.
 2020-05-17 12:32:28 -07:00
Kurt
9f490a605e Rearrange order/anchoring for main tab 
allows expanding the window to show location names
Closes #2825
 2020-04-29 09:32:29 -07:00
Kurt
8c723b32ee Don't show/modify earned bp on RS saves 
Closes #2819
 2020-04-26 17:53:50 -07:00
Kurt
73045ba7a4 Hide fame time until selected 
Closes #2820
 2020-04-26 17:49:32 -07:00
Kurt
a8f967e935 Disallow scrolling in Trainer Stat/Record 
Unfinished text edits aren't pushed until after the combobox changes index
#2820
can't tell the numericupdown to finalize entry, even with a Focus() call to the combobox (to change focus from the numericupdown).
 2020-04-26 17:49:10 -07:00
Kurt
460062a07c add generic sav block editor 2020-04-26 16:23:06 -07:00
Kurt
8a0295e4e9 Minor clean 
GetLanguageIndex never returns <0
 2020-04-23 20:54:20 -07:00
Kurt
d6171669e4 Add swsh box wallpapers 
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
 2020-04-16 14:50:41 -07:00
Kurt
24edf7efe5 Improve detected savefile load speeds 
Don't discard the initially detected data just to re-load it from the path; keep a reference and load the reference.
 2020-04-16 13:15:35 -07:00
Kurt
b8814d2448 Split GG into LGPE (GP/GE), GG (LGPE||GO) 
Update usages
 2020-04-16 12:48:18 -07:00
Kurt
567b54b10f Update Main.cs 2020-04-14 11:50:33 -07:00
Kurt
546412e410 Rename class/method name 2020-04-14 10:59:16 -07:00
Kurt
ee1cfa8912 Hanle some compiler messages 2020-04-14 10:52:19 -07:00
Kurt
49e4fd396d Remove some unnecessary null checks 2020-04-14 10:08:56 -07:00
Kurt
f22b1c3e52 Update 20.04.14 2020-04-13 10:16:49 -07:00
Kurt
d398ad56d5 Update translations 
Not really much here, but that's all that's been added since last time.
 2020-04-13 09:55:21 -07:00
Kurt
bf47317dd1 Add setting to force large sprites for past gen 
Causes the Other tab (daycare/gts/fused) to look wonky (not scaled), but I'm ok with that being a known flaw for now.
 2020-04-13 09:52:25 -07:00
Kurt
33bdacebe8 Minor tweaks 
Handle some compiler/extension suggestions
 2020-04-12 16:07:59 -07:00
Kurt
e83f2a7dd0 Expand met location combobox 
stupid long met location names in SW/SH; doesn't really hurt.
Not gonna measure all string lengths and dynamically stretch it -- not worth.
 2020-04-12 13:26:35 -07:00
Kurt
0ada4cbd77 Remove some unnecessary null checks 2020-04-12 13:20:40 -07:00
Kurt
30d21e4532 Extract out showdown set interface 2020-04-12 13:05:29 -07:00
Kurt
270d984130 Minor clean 
Remove unnecessary null checks
Mark some methods with nullable type
 2020-04-04 19:30:50 -07:00
Kurt
80bedf2140 Add HomeTracker to list of hideable secrets 2020-03-21 10:56:15 -07:00
XxPhoenix1996xX
d66d761d3c
Update Spanish Translation (#2795) 
* Update lang_es.txt

* Create flags_gg_es.txt

* Update PKHeX.Core.csproj
 2020-03-20 11:42:58 -07:00
Kurt
5e32e9203e Add setting to apply nature to statnature on import 
Co-Authored-By: toim22 <toim22@users.noreply.github.com>

#2794
 2020-03-19 13:47:25 -07:00
Kermalis
5bdfd74862
Fix sav path after exporting to new name (#2791) 2020-03-18 22:15:34 -07:00
XxPhoenix1996xX
8a1405125e
Add Spanish Event Flags Translation / Update Spanish Translation (#2786) 2020-03-18 10:25:22 -07:00
Kurt
68324847bb Update PKMEditor.cs 2020-03-17 10:35:30 -07:00
Kurt
f1beef872f Reorder origin mark returns 
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
 2020-03-17 10:34:23 -07:00
Kurt
696bdf7cae Update 20.03.14 2020-03-14 14:58:36 -07:00
Kurt
a885f6b48f Clean up PID/EC auto-update 
Now loads & saves version-less data fine

Co-Authored-By: lusamine <lusamine@users.noreply.github.com>
 2020-03-13 19:56:53 -07:00
pi1024e
8a1e73e5b3
Change OT_Class to have an expression body (#2759) 2020-03-13 10:28:50 -07:00
Kurt
fbd533092d Fix misspelling of the word "Received" 
Closes #2757

Co-Authored-By: pi1024e <pi1024e@users.noreply.github.com>
 2020-03-12 15:05:34 -07:00
Kurt
dcb7336d92 Hide pika beach on !YW, add a few RS flags 
Closes #2745 , ty @FeralFalcon

hidden items are meh, items can be hacked in.

Co-Authored-By: feralfalcon <feralfalcon@users.noreply.github.com>
 2020-03-11 19:33:17 -07:00
Kurt
0aa6282d73 Sanity check value types via generic method 2020-03-11 16:31:53 -07:00
XxPhoenix1996xX
f6a157b2a1
Update lang_es.txt (#2755) 2020-03-07 20:44:58 -08:00
Kurt
4c226340fe Add shiny sprites, alcremie sprites & big sprites for all 
Keeping the 30x40 for now; might change my mind later.
Kept the gmax sprites but they're unused.
 2020-03-03 20:22:57 -08:00
Kurt
9b30bb8a2f Don't copy PID->EC if bad GenNumber 
Reading raw uncaptured data from RAM
 2020-02-29 10:55:30 -08:00
Kurt
d58426ebf5 Hide affection fields, remove setters for unused 
#2738
 2020-02-27 20:53:33 -08:00
qhq
8d413bb047
Update lang_zh.txt (#2729) 
SAV_Database.L_Version=OT Version: >来源版本:
SAV_Encounters.L_Version=OT Version: >来源版本:
SAV_Database.L_EVTraining=EV Training:>努力值:
 2020-02-20 19:26:51 -08:00
qhq
3d6fd82523
Update lang_zh.txt (#2727) 2020-02-19 22:05:54 -08:00
Easy World
4bfb57836a
Update lang_zh.txt (#2722) 
* AV means 覚醒値(Japanese), Awakening values(English), not the Species strength
* OT means おや(Japanese), Original Trainer(English), not the Trainer
* L_RHeightMin min means minimum not minute
 2020-02-19 06:59:35 -08:00
qhq
79b63b3af1
Update lang_zh.txt (#2718) 
* Update lang_zh.txt
 2020-02-17 20:22:21 -08:00
Kurt
66efbaf407 Add box manip for heal all slots 2020-02-17 19:28:20 -08:00
Kurt
620dd04064 Lock main window panel splitters 
Nobody needs to resize things; was leaving things open for a bit but no more...
 2020-02-16 20:27:24 -08:00
Kurt
fc9d0b4b24 Add hint for pkm with dummied moves 
Closes #2716
 2020-02-16 12:17:36 -08:00
Kurt
0ab63dd20f Update shortcuts.txt 2020-02-15 15:59:54 -08:00
CanoeHope
b7a3d278b2
Update shortcuts.txt (#2712) 
Very useful.
 2020-02-15 15:47:43 -08:00
Kurt
0d4cff81c6 Clean 2020-02-15 14:29:23 -08:00
Kurt
5c845a3875 Hide home tracker on non pk8 formats 2020-02-14 11:54:04 -08:00
Kurt
e8759ee538 Determine shiny as square if fateful && shiny 
regardless of xor value result
gotta make those shinies pop ;)
ty anubis
 2020-02-13 16:51:14 -08:00
Kurt
92b22b9f44
Fix HOME tracker value GUI character entry length 
Closes #2705 
It's recommended that you NOT set a "random" value here; instead, let HOME regenerate one for you.
Clearing it still functions properly.
 2020-02-13 10:52:19 -08:00
Kurt
ff23d094f0 Update 20.02.14 2020-02-13 08:44:07 -08:00
Kurt
6346444db7 Extract home tracker to interface 2020-02-12 18:52:48 -08:00
Kurt
a8a775b39c Move setting update location 2020-02-12 18:22:32 -08:00
Kurt
6ef2950cc4 Add toggleable flag setting for tracker, update translations 2020-02-12 18:14:23 -08:00
Kurt
e77fa205a0 Add tracker editor 2020-02-12 18:10:03 -08:00
ReignOfComputer
fbcbbc7b05
Batch Editor Alert Fix (#2703) 
Running a batch editor job in the same window pops the alert message in incrementing numbers until the window is closed.
 2020-02-12 09:58:46 -08:00
Kurt
8e9664ba6c Update database filters 
Allow if it can exist in SWSH
 2020-02-11 20:23:59 -08:00
Kurt
ebf20d927b More transfer implications 
Totems are downsized to regular
araquanid, togedemaru, and ribombee totems can't transfer (at the moment)
 2020-02-11 20:11:33 -08:00
Kurt
239b2f4b52 Fix entree randomization for encounters with no special move 
https://projectpokemon.org/home/forums/topic/56211-error-an-unhandled-exception-has-ocurred/

ty Pocket Monsters
 2020-02-08 20:56:16 -08:00
Kurt
fe092ce043 Update changelog.txt 
muh spell check
 2020-02-07 23:39:32 -08:00
Kurt
fb640505a5 Update 20.02.08 
No event gallery updates since last release :)
 2020-02-07 23:38:28 -08:00
Yurical
a4e579c49b
Update Korean translation (#2680) 2020-02-04 07:36:40 -08:00
Kurt
0e8ce7427a Move using to release build option 
am not using reflection for debug, gets rid of a warning
 2020-02-02 10:20:51 -08:00
Kurt
d260249b5e Apply met location before suggestion check 
Closes #2667
 2020-01-28 18:29:05 -08:00
Kurt
dd07126d83 Relocate level suggestions to EncounterSuggestion 2020-01-28 16:21:38 -08:00
Kurt
e40f739494 Update tab ordering 
Closes #2665
 2020-01-27 17:15:58 -08:00
Kurt
410fcee85b Sort sav sub-editors on load 2020-01-27 17:14:18 -08:00
matty
06522c2235 quality of life improvements on the mystery gift form (#2664) 
* delete received items with the delete key

mass selection of received items for mass deletion as well
improved index selection on deletion

* tab indexing for the form
 2020-01-26 11:19:58 -08:00
Kurt
1ba271db50 Fix block dump changing type on load 
Loading the window and assigning the datasource fired the index changed event, changing the first block (array) to the (selected index of type), which was bool1. Exporting the save caused a bad block type write, yielding a bad size.

Only add the event after the constructor is finished, so that it only fires via user interaction.

Similarly reported but not exactly noticed in #2658
Closes #2663

Gonna update the release with a hotfix
 2020-01-26 09:24:00 -08:00
Evan Dixon
4ef48a4e79 Add check for old PKHeX.Core.dll (#2662) 2020-01-26 08:55:13 -08:00
Kurt
a3e9649f09 Update 20.01.26 
Update with latest events from EventsGallery
 2020-01-26 00:35:31 -08:00
Kurt
c301ce88ab Update Random to be a bit more thread safe 
Random isn't thread safe; users of PKHeX.Core.dll might run multithreaded operations (see PKSM + ALM), so we need to have a thread-specific RNG available.

Thread Local get; to improve performance, save the random object locally whenever it is used more than once in the method.

https://docs.microsoft.com/en-us/dotnet/api/system.threading.threadlocal-1?redirectedfrom=MSDN&view=netframework-4.8
https://stackoverflow.com/questions/18333885/threadstatic-v-s-threadlocalt-is-generic-better-than-attribute/18337158#18337158
 2020-01-25 21:49:52 -08:00
Kurt
1520210e68 Revert overload usage 
yay core/framework enhancements
 2020-01-25 18:12:58 -08:00
Kurt
38759be662 Update gui translations with latest 
For dev update utility, move them to the new location in PKHeX.WinForms project
 2020-01-25 18:06:04 -08:00
Kurt
b5d48bc14f Split up portions of CommonEdits 
Cuts out about half the size; there's still a bunch of apply-value logic but it's not really big enough for a separate class.

Rename BallRandomizer->BallApplicator
 2020-01-25 16:47:44 -08:00