Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-24 04:53:08 +00:00
Code Issues Projects Releases Packages Wiki Activity
5505 commits 3 branches 76 tags 106 MiB
Commit graph

1859 commits

Author SHA1 Message Date
Kurt
adeaaea0b4 Allow folder import to import mystery gifts & gp1 
Closes #2176
 2018-11-23 12:22:51 -08:00
Kurt
ab4c3fc7ac Add go park slot delete (&all) 
Closes #2179
 2018-11-23 12:15:25 -08:00
Kurt
17b3732a7d Rework filename / nickname checks 
Closes #2178
 2018-11-23 10:31:55 -08:00
Kurt
71f1e6238a Misc fixes 2018-11-23 10:15:49 -08:00
Kurt
f27816e622 Add party pointer sort 
Pulls party members (and follower index if not already in party?) to the
first slot(s) in the (current/all) box.
 2018-11-22 23:02:57 -08:00
Kurt
1d27f64235 Allow currentbox to be changed if not overriden 
Now allows modifying/deleting 'current' box.
 2018-11-22 10:55:20 -08:00
Kurt
f358c0e4cf Handle all deviating met location string versions 2018-11-22 10:11:51 -08:00
Kurt
6a62075c47 Fix version check 
Encounter browser entered infinite loop waiting for valid version
 2018-11-22 10:10:25 -08:00
Kurt
6c0ad30b9a Add gp1-pb7 conversion 
Add drop to pkmeditor & drop to saveditor
 2018-11-21 20:48:55 -08:00
Kurt
9cf46d5bcb Add CP and Date to GP1 properties 
thanks theslayer
 2018-11-21 15:25:50 -08:00
Kurt
cfbdb7c26c Add parameter-less constructors 
Removes null check for hot path where data is actually provided
 2018-11-21 14:15:48 -08:00
Kurt
95776d8520 Set default savefile to gg 2018-11-21 13:51:26 -08:00
Kurt
03dd61bc58 Reset CP on common modifications 2018-11-21 12:31:05 -08:00
Kurt
58080f36c9 Add WB7 and legality detection logic 
Derived from WC7 with minor alterations (dynamic OT/Nickname which is
stored in the Full data). Since the 0x108 is not stored in the save
file, just keep the full data around.
 2018-11-21 12:24:41 -08:00
Kurt
0cc82edc48 Reset CP on import 2018-11-20 23:57:38 -08:00
Kurt
0ebfb38717 Add Route 20 to sky encounter rarespawn list 
Thanks @ReignOfComputer !
 2018-11-20 23:00:16 -08:00
Kurt
eb6e3fbbe9 Don't reset friendship, only for this format 
Friendship affects stats, keep current friendship when updating the
trainer.
 2018-11-20 19:15:38 -08:00
Kurt
7bd3bfc52e Update rarespawn restrictions for birds 2018-11-20 13:38:49 -08:00
Kurt
3e711acd05 Disallow egg moves in suggestions for cxd/gg encs 
https://projectpokemon.org/home/forums/topic/48547-remove-eggmoves-from-green-learnables-move-in-lets-go/
 2018-11-20 13:38:05 -08:00
Kurt
916ac84a98 Force clear EVs on showdown import pb7 
Closes #2173
 2018-11-19 18:26:46 -08:00
Kurt
ec7fc8e2f0 Fix maxgameID for pkm reference 
threw a snag in pkm generator since it doesn't reference savefile max
 2018-11-19 16:15:09 -08:00
Kurt
ba1a7c2bcf Fix broken tests 
rework getblank for version specific
 2018-11-19 16:14:49 -08:00
Kurt
4022d7fea9 Add check for invalid pgo shiny transfer 
Thanks @sora10pls !
 2018-11-19 13:07:21 -08:00
Kurt
3841df1234 Temp workaround for cp calc precision 
float -> decimal

https://projectpokemon.org/home/forums/topic/48524-cp-height-weight-calculations/
 2018-11-18 23:14:08 -08:00
Kurt
70fe7f58ee Remove eevee, revert porygon 2018-11-18 20:39:15 -08:00
Kurt
34f8a71ad0 Always writeback pointer data 
User sort isn't tracked, and reorganizes pointers. Set it back always,
no harm as values should always be sensical.

Closes #2171
 2018-11-18 20:32:55 -08:00
Kurt
67cc6bdead Account for wild catch combo/lure level boost 
Route 4 sandshrew captured at level 13 (12 is max)
+1 for now, not sure if it can go higher
 2018-11-18 16:17:39 -08:00
Matt
04de361792 Update GG flag names (#2169) 
* Update GG flag names
 2018-11-18 16:07:44 -08:00
Kurt
65febae125 Clamp max CP at 10k 
ingame max is 10k
 2018-11-18 15:32:47 -08:00
Kurt
b818aff48a Remove evo tree sanitization 
Evo data doesn't provide evolution values for these, fortunately.
 2018-11-18 15:25:03 -08:00
Kurt
a1cc1a95c2 Fix species fetch, add altform 
Thanks theSLAYER!
 2018-11-18 13:54:47 -08:00
Kurt
17348c1808 Add bird rare spawns 2018-11-18 10:36:28 -08:00
Kurt
1c0b2488ef Update lapras/porygon gift locationIDs 
Thanks Asia81!
 2018-11-18 09:41:52 -08:00
Kurt
c268d5ad05 Set party format values always 2018-11-17 19:42:48 -08:00
Kurt
edce01a857 More strict egg nickname length check 
only fishy if it was traded & within bounds
 2018-11-17 18:29:05 -08:00
Kurt
029e0e0a08 Manually add rare slot locations 
placeholder; hopefully this isn't permanent
 2018-11-17 15:12:32 -08:00
Kurt
cff1ec68fd Update filter 
savedata.bin, not extensionless
cosmetic fix for the dialog window
Closes #2166
 2018-11-16 22:17:18 -08:00
Kurt
d3534781db Allow premier ball for captures 2018-11-16 18:59:18 -08:00
Kurt
1c26c7713f Fix starter bypass 
lol oops, hotfix inc
 2018-11-16 18:17:01 -08:00
Kurt
e619ba41fe Update 18.11.16 
Update event binaries with latest from the Event Gallery
 2018-11-16 17:53:44 -08:00
Kurt
013bc70ed9 Add more pb7 legality checks 
can give nicknames to chinese mons now! Encoding looks the same
@wwwwwwzx :)
 2018-11-16 17:42:50 -08:00
Kurt
a2eef9deae Misc fixes 
it is version exclusive; fix magikarp speed IV
 2018-11-16 16:44:25 -08:00
Kurt
43ffde0918 Differentiate past gen moves with same names 
Not sure if there'll be ones for other languages, hopefully not.

dupe checker:

var langs = new string[] {"en", "ja", "ko", "es", "it", "de", "fr",
"zh"};
foreach (var l in langs)
{
var names = new GameStrings(l).itemlist;
var dupe = names
.Select((z, i) => new {Index = i, Value = z})
.GroupBy(z => z.Value)
.Where(z => z.Key != "???")
.Where(z => z.Key != "？？？")
.Where(z => z.Key != "(?)")
.Where(z => z.Count() >= 2)
.ToArray();
if (dupe.Length == 0)
continue;

l.Dump();
dupe.Dump();
}
 2018-11-16 15:15:42 -08:00
Kurt
ea4d9861c8 Disallow starter friendship move in learnset 
Joycon shake only, never actually in moveset
 2018-11-16 14:56:20 -08:00
Kurt
720e04ff91 Allow 7b trades to be shiny 
remove the todo, thanks twittersphere

remove version exclusivity for puppycat (can be done on either ver)
 2018-11-16 14:20:06 -08:00
Kurt
dae4a0a0ae Add EV/AV verification for pb7 2018-11-16 14:19:24 -08:00
Kurt
7da46623b8 Ignore ball check for invalid encounters 
Defaulting to pokeball isn't entirely appropriate
 2018-11-15 18:40:08 -08:00
Kurt
ed5abbd686 Add puppycat NPC location 
Thanks (twitter) thelostdogg!
 2018-11-15 18:39:30 -08:00
Kurt
95c5ce08d5 Fix movepool suggestion for go transfers 
needed dict references
 2018-11-15 17:37:25 -08:00
Kurt
5652e76728 Split go entities and go storage, rename classes 2018-11-15 17:36:29 -08:00
Kurt
94b924fdfc Add ingame trade IVs and random AV notes 
exclusive maximum, not inclusive
 2018-11-15 17:35:34 -08:00
Kurt
93ff395875 Add more succinct go park IV check string 2018-11-15 17:35:11 -08:00
Kurt
43a9d4eb99 Add gg evolution tree 
turns out it was totally needed; am glad I didn't do the silly stuff of
past gen evo tables (gen6/7 is just raw evo data)
 2018-11-15 17:34:54 -08:00
Kurt
22063d3907 Add ingame trade met locations 2018-11-14 23:04:40 -08:00
Kurt
6a0a6aa82a Add methods for 7b quirks 
nidoran m/f when sanitized with the old way show the gender symbols as
'?'
 2018-11-14 22:51:53 -08:00
Kurt
bf9344087e Update slot storage compression algo 
now iterates for all boxes, and restores to the correct offset at the
end
update direct offset pointers to box specific (so that it can work on
gen3 rsefrlg saves if ever used on them).
 2018-11-14 22:33:30 -08:00
Kurt
644fa4e929 Call slot compression 
Doesn't work correctly (data shifted down still persists)
 2018-11-14 22:20:59 -08:00
Kurt
1feecef874 Add go park summarizer 2018-11-14 22:02:01 -08:00
Kurt
fc44022836 Add gopkm block/abstraction 2018-11-14 19:34:21 -08:00
Kurt
a64d08e7e9 Add GO transfer IV verification 2018-11-14 18:25:43 -08:00
Kurt
830c2cbb29 Add GO encounter area/slots 
Level ranges per species TBD
 2018-11-14 17:40:41 -08:00
Kurt
adb6b345be Treat GameVersion.GO like other GG vers 2018-11-14 17:40:11 -08:00
Kurt
0b9b0d5317 Add bulbasaur candy to valid candies 
oops
 2018-11-14 17:06:13 -08:00
Kurt
7abe0c8a9e Add candy pouch type 
reusing free space icon hides the give all button; just add another
sprite.
 2018-11-13 20:46:48 -08:00
Kurt
1f985d8112 Remove unnecessary/incorrect flags 
copypaste from sm lol uops
 2018-11-13 20:46:03 -08:00
Kurt
2fb698805d Use latest personal table as master 2018-11-13 19:20:37 -08:00
Kurt
181e75818c Use agreed upon lgpe starter forme name 
Thanks @Marty-D !
 2018-11-13 19:20:21 -08:00
Kurt
24c541eeef Get savefile-context sensitive pkm 
Generating a IEncounterable -> SAV for pb7 can't start with pk7
 2018-11-13 19:19:20 -08:00
Kurt
13e1debe3e Add sav7b object & detection util 2018-11-13 19:18:29 -08:00
Kurt
f62e3f43b3 Add eventwork editing abstractions 2018-11-13 19:18:04 -08:00
Kurt
5f456d705c Add misc setup objects 2018-11-13 19:16:14 -08:00
Kurt
025a290bc9 Update saveblock template for stored offset fetch 2018-11-13 19:15:27 -08:00
Kurt
486445897e Add 7b inventory r/w object 2018-11-13 19:15:11 -08:00
Kurt
707f7b5893 Fix displayed dex index for g7 
off by 1 starting with formes
 2018-11-13 19:14:42 -08:00
Kurt
49c4043e19 Update dex abstractions, add gg dex 2018-11-13 19:14:23 -08:00
Kurt
5f9afe83d6 Add pb7 sorting methods 2018-11-13 19:10:43 -08:00
Kurt
28fec9882b Add pkm variant for beluga 2018-11-13 19:10:31 -08:00
Kurt
f11fa8752c Use pkm format specific evolutions, gg deviations 
GG has slightly different evos from usum, don't bother adding a new
binary.
 2018-11-13 19:04:58 -08:00
Kurt
1adbc270ce Scrub unused data 
empty movesets, empty tmhm

bool IsInvalid(int x)
{
int[] banned = {918, 933, 959, 960, 961,962,963,964,965};
if (banned.Contains(x))
return true;

var index = baseForms[x];
if ((x > 151 && x < 808))
return true;
if ((index > 151 && index < 808))
return true;
return false;
}
 2018-11-12 18:58:02 -08:00
Kurt
6495dc41af Add move/enc/loc references 2018-11-11 22:49:17 -08:00
Kurt
ac314fe0d7 add dumped encounters/levelup moves 
waza_oboe was lz4 compressed (gfpak), encounters were in a flatbuffer
 2018-11-11 22:46:56 -08:00
Kurt
5abbe6dceb Add fetching for lgpe encounters (legality checks) 2018-11-11 22:46:03 -08:00
Kurt
101149eb2e Skip eggs for gg (like cxd) 2018-11-11 14:19:02 -08:00
Kurt
9d2be1da9f Add beginnings for 7b encounter asset fetch 2018-11-11 13:12:24 -08:00
Kurt
00af735afd Add personal table for gg 2018-11-11 13:11:07 -08:00
Kurt
1827b32d8f Add init function for wc7 gg files 
pretty sure these will pop up soon as the pball plus doesn't send the
mew itself
 2018-11-11 13:09:04 -08:00
Kurt
5ddf6f62ce Add eventflag notes 
there's some "AHTB" files which contain the internal enum names; dump
out a few that seem useful
note they come from different tables, will need to figure out spacing &
if their order is absolute or uses that weird hash in front???
 2018-11-10 21:53:25 -08:00
Kurt
f38c46f5ec Misc updates 2018-11-10 21:07:31 -08:00
Kurt
010134f6ff Add references for GG tutoring 
Only pikachu/eevee forms so far, probably none else
 2018-11-10 21:04:48 -08:00
Kurt
98ebf4c5cb Add sort pointer repointing 
LGPE uses a list of pkm for boxes, and has pointers indicating where
each party member is at
need some logic for handling the sorting. Had suspected this a while
back so this pre-work came in handy (untested tho)

make eventflags offset ptr virtual, I might end up doing things
differently for event flags
 2018-11-10 21:04:24 -08:00
Kurt
73ee5e5afd Add personal info structure update changes 
One field added to indicate the GO species or whatever; the 891/892
meltan values match here. Might not be only for GO species translation,
might be for fetching models idk
 2018-11-10 20:59:55 -08:00
Kurt
94c8b348c8 Add legal tables for gg 
field_pocket.dat ez pouch indexes
 2018-11-10 20:58:41 -08:00
Kurt
e6a9014243 Add text dumps from GG 2018-11-10 20:25:26 -08:00
Kurt
113eb550d4 Add IAwakened interface for future PB7 format 2018-11-10 20:21:36 -08:00
Kurt
453f43edd8 Allow shiny xd duking gifts 
https://projectpokemon.org/home/forums/topic/48279-issue-with-ribbon-legality-shiny-dukings-and-japanese-text/
 2018-11-08 18:58:52 -08:00
Evan Dixon
9c87ad2977 Port tests to .Net Core (#2156) 
* Rewrite tests with XUnit and .Net Core
* Add better "because" message
* Skipping test that was not ready & convert the fact to a theory
* Tweak casing
* Convert select date tests to theories
* Make the GetStringList load lock safer
 2018-11-06 15:25:35 -08:00
Kurt
d5c22b1e51 Add gen3 wc3 fixed OT egg length case 
unhatched egg:
https://projectpokemon.org/home/forums/topic/48226-pichu-event-ilegal/
 2018-11-03 12:44:03 -07:00
Kurt
daf41da91b Add more pokewalker moves 
Thanks theSlayer!
 2018-11-03 12:42:11 -07:00
Admiral-Fish
69b6ea57a3 More nature lock data (#2154) 
* Fix lock data

Don't have data on Speal phenac, Spheal post, and Ursaring from colo so can't verify that.

* Fix e-reader data
 2018-11-01 22:38:33 -07:00
Kurt
fe989d48fe Misc prep updates 
Update comments / xmldoc
Add a savefile storage compressor (ie array[] with empty interstitials
-> list); return true if the compression moved anything (repopulate
views), and the count of occupied slots in the list.
Add saveblock base class; I haven't really liked how SAV6/7 do all the
logic; I'll still expose properties that will then point to a saveblock.
Cuts down clutter.
Add template Dex manipulator, with gen6/7 implementations
Speculate sequential gp/ge gameversion IDs
 2018-11-01 15:38:09 -07:00
Kurt
b53cc1b7f8 Merge branch 'master' of https://github.com/kwsch/PKHeX 2018-11-01 15:20:45 -07:00
Kurt
43d20581e4 Update some string resources 
In anticipation of 2wks from now, might as well get some easy tedious
stuff out of the way
 2018-11-01 15:18:33 -07:00
Admiral-Fish
6a5ee7bf6d Fix Electabuzz data (#2151) 2018-10-31 23:16:13 -07:00
Kurt
f709448220 Update 18.11.01 
Update event binaries with latest from the Event Gallery
 2018-10-31 14:08:58 -07:00
Kurt
8f9cc6cd7e Fix xmldoc ampersands 2018-10-31 13:52:09 -07:00
Kurt
7a021781e0 Add xmldoc, misc fixes 
Fix compile error (lol github editing)
Add XD check CPU-PSV for nonshiny.
rename l->current for clearer intent
 2018-10-30 17:45:21 -07:00
Kurt
bc788beef0
Fix spelling mistake in var name 
Unused after assignment, but if I rework the validation check to return the teamlock result instead of a bool I can spit out the Species-PID generated list as extra info. Helps identify the as-generated conditions if there are multiple teamlocks possible for an encounter (multiple shadow mons, seen vs unseen).
 2018-10-30 09:21:32 -07:00
Kurt
908c98b876 Switch lock checks to newer more complete check obj 
Now accounts for the shiny locks & associated restrictions, abusing the
recursion by setting & unsetting the required CPU Trainer's shiny value.

Repoint all test methods to use the new obj methods
 2018-10-29 22:49:04 -07:00
Kurt
ef16e7037a Add lock check result object 
A lot of internal information is nice to have saved; create a copy of
the static class's logic and pepper in some state variables (Required
CPU Shiny Value) to account for the weird edge cases.

Code is essentially the same as the static methods, except for more
fleshed out logic in the AllLock interrupt checking and the eventual
Trainer checks.
 2018-10-29 21:28:22 -07:00
Kurt
b124a6e70d Extract seedframe to separate file 
soon tm
 2018-10-29 21:03:29 -07:00
Kurt
afffaaa43c Enable full shadow lock checks 
If you find any edge cases (the code does not account for shiny locks
yet) pls lmk, would be nice to have confirmed tests :) :)
 2018-10-29 19:44:30 -07:00
Kurt
35143630a0 Add ereader locks 2018-10-29 19:43:32 -07:00
Kurt
1b57acc6a7 Check all locks for legality checking 
Single->All
 2018-10-28 20:28:56 -07:00
Kurt
a728e97d40 Fix Butterfree lock 
Ninetales is female
 2018-10-28 20:28:02 -07:00
Kurt
7c0a74337e Update shadow lock checks 
Passes all 3 lock3 cases in addition to some bulk checks
(VerifyPIDResults).
Lock4 has an issue on one; will have to investigate why.
 2018-10-28 20:10:35 -07:00
Kurt
4268239c12 Continue work on shadow lock checks 
Now gets count=2 tests working

yield return new SeedFrame { FrameID = ctr + (l.Seen ? 5 : 7), PID = pid
};
used to be ctr + 6, needs to alternate even-odd
all 2 lock cases pass, but didn't make lock3's pass. Something else is
still amiss :)

break out some classes for the solidified lock objects
 2018-10-28 11:15:40 -07:00
Kurt
39f98a4a94 Misc qol updates 
Check max case for level first, then iterate upwards (eliminates inner
if)
change wc* nature to sbyte (update comparisons, 0xFF too magic-y)
use Rand.Next(x) instead of (0, x)
 2018-10-27 21:59:31 -07:00
Kurt
ed3699fbb4 Update Ho-Oh mattle check 
More languages than Italian have a rule-breaking name. Rework checks a
bit
Flag eggs more accurately
Update force hatch to move Link Trade met location to Egg Location

fix Ho-oh -> Ho-Oh text strings (correctness is key!)
 2018-10-27 16:06:06 -07:00
Kurt
a3e7c4837e Rewrite trade OT/Nick verification, g4 shuckie 
Shuckie in HG is not the same as Shuckie in SS.
Use the relatively-recent Nick/OT properties instead of digging through
the encounter table & strings. Ends up being slightly faster.

Thanks theSlayer!

https://projectpokemon.org/home/files/file/3048-kirks-shuckie/?tab=comments#comment-1424
 2018-10-27 13:37:03 -07:00
Kurt
ed180f1b5f Allow traded eggs when checking g6+ receivability 
As noted in the EncounterEgg generator, Gen6+ update the origin game to
the OT's when hatched.
Thanks Zaskarel!
 2018-10-27 09:44:47 -07:00
Kurt
f91a1c1d31 Add gg species / maximum placeholder 
Will eventually have to fill these in during gg update
pretty sure they've revealed all the new species; total move/item count
still unknown
 2018-10-27 09:08:39 -07:00
Kurt
359a529870 Misc updates 
Move some logic around, fix style warnings
 2018-10-27 08:53:09 -07:00
Kurt
e8ad1e227f Update shadow lock table 
Thanks @ijuintekka ! Closes #2148
Will check later for commented out tests that should pass.

May end up turning on the first-shadow-lock check feature prior to
release.
 2018-10-26 11:14:42 -05:00
Kurt
3d0d8fa649 Add first shadow lock check 
Currently toggled off, can be optionally toggled on (I'm not sure that
it's perfect? Random save files have stuff flagged since they don't
match the lock; will have to investigate later)
 2018-10-21 21:07:33 -05:00
Kurt
8c4a17335f Add first shadow lock test method 
Everything should always pass the first lock check; will add shortly to
any cxd encounter checks
 2018-10-21 20:55:02 -05:00
Ntonio36
ee3889b184 French translation update (#2147) 2018-10-21 08:27:33 -05:00
Kurt
66f082e4a0 Add shadow lugia sprite 
Closes #2145
 2018-10-20 23:05:15 -05:00
Kurt
c0aae6ab78 Add cxd lock check info & begin troubleshooting 
commented out test calls = not working
will have to debug in more detail later; the first lock is always
working at least.

data sourced from
https://github.com/ijuintekka/Eligor/blob/master/Eligor/Spread.cs , not
sure if it's perfect.

can't cleanly condense deviating team appearances as double-shadow leads
can't be selectively encountered. didn't feel like modding lockfinder's
recursive algo to be smarter.
 2018-10-20 21:03:04 -05:00
Kurt
06cca185e4 Add edge case for pidiv kor g4 pichu 
Closes #2144
미케나 pichu 12179/20300
 2018-10-19 22:27:18 -05:00
Kurt
93af3e61b7 Add handling for Mt Battle Ho-Oh (italian) edgecase 
https://projectpokemon.org/home/forums/topic/47917-colosseum-italian-ho-oh/

there's no shadow ID, so it can have both the short (transferred back)
or full name (never transferred) as CK3 without side effects.

allow 10chars in pkmeditor
 2018-10-13 08:07:15 -07:00
Kurt
f7f5d78beb Misc perf tweaks 
hopefully resolves the image corruption issue (dont use unsafe?)
remove some linq
 2018-10-13 08:02:55 -07:00
Kurt
b7acb7fa1d Add memory rarity table 2018-10-12 17:45:52 -07:00
Kurt
e8552affca More gb restriction relocations 2018-10-10 16:32:02 -07:00
Kurt
2db8daa07b Add specified ability no-hidden check 
ability=0 allowed abil1/2 but not 4; catch that scenario
 2018-10-10 16:31:40 -07:00
Kurt
2ad103dd46 Extract gb specific core logic to separate class 2018-10-09 21:07:13 -07:00
Kurt
0a62506e11 Micro optimization 
wow such use
length eq to max will always pass
 2018-10-09 19:28:18 -07:00
Kurt
b481358e92 Add number count check for OT/nick 
https://projectpokemon.org/home/forums/topic/47850-legality-issue-names-with-multiple-numbers/
let me know if there's any implications for transferred content (name
reset on 1-3=>n?)
 2018-10-08 17:57:34 -07:00
Kurt
47f20b8c0e Update fixed ability comparison for 6+ 
4aa44c90c1 only updated it for gens 3-5
Closes #2136
 2018-10-08 15:26:43 -07:00
Kurt
f65bc2e984 Reduce allocations for gen1 move parse 
use shared interfaces
 2018-10-07 15:36:32 -07:00
Kurt
4aa44c90c1 Update fixed ability comparison 
ignores <= 0 now
 2018-10-07 15:36:04 -07:00
Kurt
fd1009476e Minor logic simplifications 
reduce size of encountermoves, split into separate object
only execute gb movedata adjustments for gb
 2018-10-06 19:44:50 -07:00
Kurt
4deb5080d1 Misc tweaks 
rearrange getmove with respect to tutors; verifycurrentmoves was getting
tutor moves in levelup
extract not-found hint fetch
Expose gen5 block objects (so I can play with saves in linqpad)
 2018-10-06 18:45:15 -07:00
Kurt
dc839333b7 Add more parse settings 
allows consumers to tweak debatable settings
 2018-10-06 13:43:05 -07:00
Kurt
66faa43e03 Add gen6+ fixed ability hot path 
Closes #2135
 2018-10-06 11:24:46 -07:00
Kurt
f507ab7081 Misc parse settings reorg 
makes it more centralized for defining parsing settings, maybe can have
flags to change severity of certain preferential checks
 2018-10-05 19:58:30 -07:00
Kurt
59af7fef35 Remove unnecessary properties 2018-10-05 19:57:45 -07:00
Kurt
ce9d3abbe4 Misc reorganization 
Move logical checks using encounter data out of Core.cs

might be possible to excise legality checking objects from
Legal/PKHeX.Core so that a 'slimmer' core can be made
 2018-10-04 18:52:00 -07:00
Kurt
03a05364ab Update colo suicune ++ 
location ID was originally added by:

afde4514e2 (diff-83a32d69355a64376bc77bd07e338a33R446)

I
have another save file that uses met location 110 (like this one) so I
assume it was originally a copypaste error from Sudowoodo.

Change Trade strings to not allocate separate empty arrays.
 2018-10-04 08:14:53 -07:00
Kurt
4bbb1f54b9 Change burned tower suicune encounter type 
was initially set by this commit

0e3815b048

field test resulted in Cave/HoO type
https://projectpokemon.org/home/files/file/2953-burned-tower-suicune/
 2018-10-03 16:46:55 -07:00
Kurt
4fe1a5b4e0 Add more frlg flags 
https://www.pokecommunity.com/showthread.php?t=302347
 2018-09-30 21:53:06 -07:00