Commit graph

7477 commits

Author SHA1 Message Date
Kaphotics
4c66f66963 Merge remote-tracking branch 'origin/master'
# Conflicts:
#	PKX/f1-Main.cs

why
2016-07-09 14:22:43 -07:00
Kaphotics
9f554fe76e Ability out of range check
badly hacked pokemon with no abiltiy
2016-07-09 14:21:28 -07:00
Kaphotics
818a45cf28 Use func/action for pkm field manipulation
Gonna move the generation-specific methods to a separate file
eventually.
2016-07-09 14:01:31 -07:00
Kaphotics
689e7cec4b SAV4 Fix trainer coordinates 2016-07-09 13:54:49 -07:00
Kaphotics
0a8dc20de1 Add gen3 items list
english only
2016-07-08 18:38:40 -07:00
Kaphotics
edbd1a71d7 Revise assemblyinfo
Long forgotten
2016-07-08 18:37:09 -07:00
Kaphotics
6a514df63d Merge pull request #131 from Tsunamical/master
Small Code Improvements
2016-07-08 18:34:14 -07:00
Tyler Dunn
6b92806d70 Small code improvement in Program.cs
Give them their proper types
2016-07-08 21:14:15 -04:00
Tyler Dunn
5a73217c23 Remove safe cast in favor of direct cast 2016-07-08 21:11:21 -04:00
Kaphotics
ba6eec70ba Code formatting
Some stuff can be abstract / sealed.
2016-07-07 05:44:43 -07:00
Kaphotics
7fe2a56d21 Visually separate PCD from PGT
Cards 19-21 are not visible, move the 3 PCD cards to that location.

Resolves #130 , thanks @sora10pls !
2016-07-05 19:12:18 -07:00
Kaphotics
21621bb988 Display legal ability list gen3-5 2016-07-04 23:53:35 -07:00
Kaphotics
f0503540a0 Safety check
negative species/formestatsindex returns species
2016-07-04 23:53:15 -07:00
Kaphotics
52c87c8c5f Fix ability retrieval
incorrect offset
2016-07-04 23:52:50 -07:00
Kaphotics
edc9bb7046 Fix SAV3 party & info loading
forgot 0x1000
2016-07-04 23:52:37 -07:00
Kaphotics
55d89952dd Simplification of set/delete/view
Add comments. DEV_Ability is now used for past gen pkm abilities (for
the moment).

DEV_Ability was obfuscation, can modify slots (such as the battle box)
while in HaX mode.

Behave.
2016-07-04 20:11:28 -07:00
Kaphotics
c09a541b25 Fix Party slot Set/Delete
PartyCount now updates, added new logic to SaveFile class to perform the
deletion.

Should behave cleaner than the working solution from months previous.

Resolves #129 , thanks Favna!
2016-07-04 20:04:43 -07:00
Kaphotics
005d1abfa6 Fix main blank save init parameters 2016-07-04 16:16:34 -07:00
Kaphotics
e21037c57e Change converter country
31 should have been 0x31 == 49 (USA).

Ha.
2016-07-04 16:11:03 -07:00
Kaphotics
8dd5c40a93 Fix multiple matched cards
Charizardite Y with Inferno fixed, just add a break to get out of the
loop.
2016-07-04 16:06:07 -07:00
Kaphotics
8276c6fcc1 Add SAV4 dex flag setting 2016-07-04 13:06:01 -07:00
Kaphotics
6463201286 Add SAV5 dex flag setting
No formes flag setting tho
2016-07-04 11:56:30 -07:00
Kaphotics
bd2a1af0f8 Add Gen3 dex set captured/seen 2016-07-03 22:21:45 -07:00
Kaphotics
1f1f3b8720 Add gender legality check
dirty cheaters

Tweaked ECPID to not bypass illegal flag checking if EC/PID were 0.
2016-07-03 18:36:04 -07:00
Kaphotics
1e2ef19d9a Tweak detection of pk6 party file 2016-07-03 18:27:12 -07:00
Kaphotics
1779420af1 Add gen3 personal info, move object refs
All PersonalInfo arrays are referenced from PersonalInfo's class instead
of Legal

Fixed a few bugs in the process (species translation, gen switch)
2016-07-03 15:05:15 -07:00
Kaphotics
4568bdc576 Add gen3 personal struct
Gen4 is the same struct, move to earlier game's class.

Still need to unshuffle the personals by natdex ID for gen3 games.
Tutors/TMHM aren't referenced so they can be appended if (n)ever desired
2016-07-03 13:41:50 -07:00
Kaphotics
7bff9b781a Fix out of range forme index request
Break up logic
2016-07-03 13:04:07 -07:00
Kaphotics
f1fa64ff11 Fix gen5 map position coords
Lazy c/p & edit from SAV6
2016-07-02 20:49:47 -07:00
Kaphotics
ce73469575 Gen5 bak name use specific version name 2016-07-02 20:38:13 -07:00
Kaphotics
7d767ee600 Re-add Clone-Delete
Thanks Wanderer1391!
2016-07-02 20:30:20 -07:00
Kaphotics
190382d5b6 Sync remaining
Missed the last bugfix
2016-07-02 20:25:47 -07:00
Kaphotics
54bc0b320d Add PersonalInfo for gens4/5
Abstracted the PersonalInfo class to the multi-generation format.
Structure hasn't changed since BW sans a few additions.
2016-07-02 20:24:17 -07:00
Kaphotics
795e0e005b Fix ability display
Thanks Odaxis!
2016-07-02 10:59:22 -07:00
Easy World
3ded274079 Merge pull request #5 from kwsch/master
merge
2016-07-02 20:02:01 +08:00
Kaphotics
c129c0d663 Fix cast
should have been included in the previous commit
2016-07-01 21:21:15 -07:00
Kaphotics
418f1c772d Fix gen3 pouch set 2016-07-01 17:06:45 -07:00
Kaphotics
67e7d3edaf Simplify control finding for translation
Figured I'd rewrite this to remove the gotos
2016-06-30 22:36:54 -07:00
Kaphotics
537246d4b9 Add SAV3 inventory code
Still need to figure out how I want to handle the different-index item
numbers.
2016-06-30 21:53:24 -07:00
Kaphotics
08ccec7a07 Fix pk3 sprite helditem fetch
g3item is raw value (gen 3 index), HeldItem returns the equivalent gen4
item.

In the future the populatefields(PK3) method will use the gen3 index
(list needs to be init first) but the display is always the helditem.
2016-06-30 18:10:09 -07:00
Kaphotics
053657c3be Error check on invalid legality
Check fails -> flag instead of error.
2016-06-29 22:59:20 -07:00
Kaphotics
8a8926bcca Split up setforms
individual forms do it themselves, allows for main window to handle more
generations
2016-06-29 22:58:02 -07:00
Kaphotics
9e4fa6bec9 Save Language default -1 (none) 2016-06-29 22:57:26 -07:00
Kaphotics
fa9ca3ea59 Flag Legality of Battle Primals
Mark as illegal.

Thanks Asia81!
2016-06-29 17:42:00 -07:00
Kaphotics
d8ed96fd69 Fix drag&drop save file
Missed a 'return', the logic afterwards handles loading a PKM (which we
know the file is NOT).

Thanks @Favna

Previous two commits & this one resolve #127
2016-06-29 17:36:03 -07:00
Kaphotics
c14b87fcd9 Fix PCBin/BoxBin setters
Thanks @Favna
2016-06-29 17:31:52 -07:00
Kaphotics
a0bade7dc0 Fix Save Version get/set
Short circuited -> rewritten, removed sav5 getter for Version (handled
by abstract parent class)

Thanks @Favna
2016-06-29 17:21:59 -07:00
Kaphotics
9d36976860 Remove unused itempouch resources
Was never used, will never use.
2016-06-28 17:54:07 -07:00
Kaphotics
8e62803897 Tweak savefile enumeration
Use one enum to denote Version across all code, also identifies if data
is invalid
Move some SAV code to virtual members in abstract class
(BAK/Exportable/Footer)

Few minor bugfixes here and there (hiding Characteristic label, loading
pk6 to sav3, sav3 version detection via gamecode)
2016-06-27 23:03:57 -07:00
Kaphotics
744c5b927b Isolate secret base ability code
Was referencing main form code; this is gen6 only so do it gen6 only.
Main form will change to handle all generations.
2016-06-27 22:27:53 -07:00