Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-27 22:40:22 +00:00
Code Issues Projects Releases Packages Wiki Activity
4234 commits 4 branches 76 tags 107 MiB
Commit graph

4234 commits

This branch
This branch
All branches
Author SHA1 Message Date
Kurt
4f489a720f Refactoring 
move logic back to cgearbackground, initialize the bg regardless of
psk/cgb input format
cache background data to return psk (potentially unintended side effects
if importing bw psk to b2w2, will have to fix cgb->psk first then undo
this tempfix)
#1699
 2018-01-09 23:30:44 -08:00
Kurt
f332e41869 misc updates 
#1699
generally pertaining to detecting a de-obfuscated input (cgb) vs native
(psk)
still issues with saving data (deobf->native)
 2018-01-09 21:47:04 -08:00
Kurt
84a755a8c9 minor simplifications 
#1699
 2018-01-08 22:40:34 -08:00
Kurt
d187370671 fix checksum/footer set 
#1699
checksum in the +0x100 was missing the +SAV.CGearDataOffset
add a few more modifications for better parity

still not 100% fixed
 2018-01-08 22:40:34 -08:00
Kurt
4967acc829
Merge pull request #1752 from kwsch/b/url 
Fix URLs
 2018-01-08 17:40:33 -08:00
Evan Dixon
5a4ddd685c Update Project Pokemon URLs in comment 2018-01-08 13:15:19 -06:00
Evan Dixon
90e3c4a42e Fix thread URL in changelog 
It's probably better to fix this on the server side, but this is easier
 2018-01-08 13:14:52 -06:00
Kurt
701edbc592 Remove KOR language from gen3 selection 
add flag for non japanese lang gen3 eggs
Closes #1747
 2018-01-06 22:43:48 -08:00
Kurt
63a983749e Don't generate encounter slots for eggs 
Closes #1749
 2018-01-06 21:51:58 -08:00
Kurt
659f2098a9 Fix sav4 coin read 
#1746
 2018-01-06 21:36:44 -08:00
Kurt
26015b44bc Add max cap difference for dppt 
#1746
 2018-01-06 14:12:28 -08:00
Kurt
218c20d804 Add sav4 coin edits to misc4 
closes #1746
 2018-01-06 14:02:55 -08:00
Kurt
8cf97f3761 Add pom-pom edge case 
dash was stripped out during conversion
closes #1744
 2018-01-06 09:40:30 -08:00
Kurt
c006c0cad9 Update pid/ect on showdownset import 
closes #1745
 2018-01-06 09:35:22 -08:00
Kurt
c6089a183c fix designer deletion of sav editor control 
custom constructor parameters aren't expected, needs a default without
optional

(no usages were using a sav provided anyway)
 2018-01-02 23:00:52 -08:00
Kurt
7705c158a9 Allow shiny sprite turning off 
lul oops
 2018-01-02 17:23:43 -08:00
Kurt
1417a6d576 Add shiny sprite fetch & fallback 
pseudo future proofing in the event new species sprites are added and
recolored variants are not
Closes #1735 , thanks @trainboy2019 !
(reimplemented alterations with GUI-saved settings)
 2018-01-02 17:17:30 -08:00
Kurt
853f5f3ce9 Add shiny sprites 
Thanks @msikma (dada)!
Update readme with asset attribution
#1735
 2018-01-02 17:14:22 -08:00
Kurt
ef0453ecf6 Add shiny sprite toggle setting 
not functional yet
#1735
 2018-01-02 17:08:14 -08:00
Kurt
6a9e2ed4b9 Refactoring 
improve speed for resource fetch, add optional Shiny parameter
(currently unused)
#1735
 2018-01-02 16:53:39 -08:00
Kurt
0f21fc2217 add location interface for verbose analysis output 
indicates met location for transferred mons
most gen1/2 encounters won't show values due to the location not being
stored respective to the string tables (anyone wanna do a location remap
after initial load?)
 2018-01-02 12:00:41 -08:00
Kurt
5888898e7d fix gen2 egg met level mod 
https://projectpokemon.org/home/forums/topic/43278-gen-2-hitmonlee-and-hitmonchan-flagged-as-illegal-if-location-is-mt-mortar-at-level-10/?tab=comments#comment-225577
 2018-01-01 21:51:36 -08:00
Kurt
76385a6b4a Fix gsc pre-evo species chain filtering 
simplify gsc check to do only once

https://projectpokemon.org/home/forums/topic/43278-gen-2-hitmonlee-and-hitmonchan-flagged-as-illegal-if-location-is-mt-mortar-at-level-10/
 2018-01-01 13:53:28 -08:00
Kurt
e79a35d387 Fix long OT name length setting 
StringLength is the raw buffer size, needs to be offset by 1 as the
string length enforced does not consider the terminator

12char OT name in sav7 loaded to tabs -> load gen1/2 save = exception
(now fixed)
 2018-01-01 11:27:45 -08:00
Kurt
cfe78a7a0c Add rby power plant static encounters 
https://projectpokemon.org/home/forums/topic/43272-small-electrode-legality-bug/?tab=comments#comment-225537
 2018-01-01 10:38:38 -08:00
Kurt
09180ab795
Merge pull request #1733 from sora10pls/master 
Update misc images to match Gen 7
 2017-12-31 21:28:35 -08:00
sora10pls
92854b54f0 Update misc images to match Gen 7 2017-12-31 22:43:08 -05:00
Kurt
1b409dd327 Ban phione egg in non-pokeball 
Thanks Davil!
https://projectpokemon.org/home/forums/topic/43262-bug-phione-ball/
 2017-12-31 09:56:27 -08:00
Kurt
d8f70dfd93
Merge pull request #1732 from lilymaniac/update-ko 
Update Korean translation
 2017-12-30 22:54:26 -08:00
lilymaniac
e58696cd56 Update Korean translation 2017-12-31 15:17:04 +09:00
Kurt
14821dfb82 Fix catchrate set auto-fix 
https://projectpokemon.org/home/forums/topic/43252-pk1-pokémon-files-arent-holding-items-when-imported-to-gen-2/?tab=comments#comment-225459
 2017-12-30 10:40:28 -08:00
Kurt
fa90ae21df Fix variable reference 
#1731
 2017-12-29 18:30:13 -08:00
Kurt
648f250303 Fix party/other tab loading for sav loads 
loading pbr/rsbox -> loading a game that has party & daycare causes the
daycare tab to be loaded in the incorrect spot.
PartyTab needs to be calculated closer to its use
 2017-12-29 16:50:55 -08:00
Kurt
ca20e78269 pkm crypto Refactoring r2 
condense repeated logic, reduce overall operations
removes 1 array alloc for pkm encryption (shuffle clones the array, so
don't clone->clone)
removes 1 array alloc for pkm decryption (mutate encrypted array), be
aware that no current use cases input an encrypted region and expect the
reference to stay encrypted (always was a temp array).
remove duplicate bounds checks (early return & for loop)
 2017-12-29 15:29:31 -08:00
Kurt
0c2b16391f fix spanish ranch gift name check 
oops
 2017-12-29 13:08:06 -08:00
Kurt
90260187f7 Add light of ruin & plasma fists as invalid sketch 
moves not available for sketch without hacking a specimen in

https://projectpokemon.org/home/forums/topic/43244-two-problems/?tab=comments#comment-225421
 2017-12-29 12:00:06 -08:00
Kurt
34188f275a misc perf improvements 
reduce linq usage / reduce obj creation in tight loops
speed++
 2017-12-29 10:40:00 -08:00
Kurt
45eee8575a Only promt roto-OT if OT is changed 
reduces nag
closes #1731
 2017-12-29 10:00:32 -08:00
Kurt
1d405d63c8 speed up pkm crypt 
GetBytes returns an array that is immediately discarded (GC pressure)
reduces overhead when loading large pkm collections from save files
(shaved off a couple seconds from my loading from 200+ bak saves)

could probably go faster with unsafe code to r/w ushort directly
then again im profiling under debug but i'd assume the improvements made
actually do improve speed for release builds
 2017-12-28 23:24:12 -08:00
Kurt
dccad6c2f4 Simplify/fix UnSanitizeString 
Species and Nicknamed params were never used; foreign always resulted in
true for cases when it actually mattered.

Filter to the non-fullwidth characters, check the char type (latin base
vs jp/zh/ko) in order to determine if the full/half symbols should be
squished

could be faster replacing char instead of string, so change those

add two test cases for half width & full width string
sanitization/unsanitization
 2017-12-28 22:50:32 -08:00
Kurt
43cb0e8d7d Provide more accurate met level for eggs 
Gen6 egg with met level != 1 (ie 98) will use the gen3-4 metlevel
branch.
fuzzed input from #1728 to be hacked (met level = 98)
 2017-12-28 10:01:48 -08:00
Kurt
a1f2f8708a Refactoring 
pass identifier on cloning pkm
remove unnecessary ref for passing Data (not modifying array reference)
const some magic numbers
 2017-12-27 16:36:24 -08:00
Kurt
61b65198f2 Allow box name editing on gen2 2017-12-27 15:52:29 -08:00
Kurt
1e388fb85a Add first unown seen on dex set 
immediately after unown dex:

c2a7216d9b/wram.asm (L2714-L2722)

per discussion on forums:

https://projectpokemon.org/home/forums/topic/43179-bug-unown-sprite-glitched-in-pokédex-in-gen2/?tab=comments#comment-225342

expose some useful properties for the pkhex.core api (unlock all, unlock
individual, define which unown shows up)
 2017-12-27 09:56:04 -08:00
Kurt
3445b46526 Remove unnecessary array cloning 
new objects would always clone the input array; only clone on object
cloning (keep the original array reference on initial creation from
bytes)
 2017-12-26 21:38:19 -08:00
Kurt
5ec99b6c1c Refactoring 
expose individual types, items, and abilities
 2017-12-26 18:54:08 -08:00
Kurt
dbe000d08e Add some overloads for non-specified generation 
fetches current gen if used without generation parameter
 2017-12-26 18:54:07 -08:00
Kurt
5580d6a7d4 Extend set obj to apply to pkm data 
var psimSet = new ShowdownSet(Clipboard.GetText());
psimSet.ApplyToPKM(pkm);
 2017-12-26 18:54:07 -08:00
Kurt
cdaba6eb26
Merge pull request #1724 from sora10pls/master 
Add XY gift Lapras ability check
 2017-12-23 16:25:23 -08:00
sora10pls
c3d5266b89 Add XY gift Lapras ability check 2017-12-23 18:28:00 -05:00