Commit graph

4461 commits

Author SHA1 Message Date
Kurt
b69a6df6e7 Add roamer glitch IV collision detection
M1 is checked before M1R. A M1R PIDIV can also be a M1 PIDIV, so check
that collision.

https://projectpokemon.org/home/forums/topic/43567-gen-3-suicune-unaffected-by-roamers-glitch/
2018-01-24 19:07:03 -08:00
Kurt
0edefedc2b Remove gen2->7 auto filtering
closes #1768
(<7)->7 is now possible so no need to filter further
2018-01-24 09:19:20 -08:00
Kurt
b16a2f9ad2 Add box rearranging
enables the left/right arrows on each box to allow switching with the
adjacent box
2018-01-23 22:37:55 -08:00
Kurt
713e9ea209 Compress box padding 2018-01-23 17:18:37 -08:00
Kurt
18421c66a9 Set box view owner
shifting focus to another app and back will cause the parent form to be
brought back to the top as well
2018-01-22 22:39:12 -08:00
Kurt
d65393c6f6 Minor behavior tweaks (preference)
fix initial box width to 4 with scrollbar, remove always-on-top for main
window
2018-01-22 21:58:53 -08:00
Kurt
f073585592 Add all-boxes viewer
removed ability to have multiple single box popups
double click the Box tab when holding shift to bring it up
resize to preferences: https://i.imgur.com/XB2978R.png
2018-01-22 21:38:42 -08:00
Kurt
6eb0cd17cb fix slot bg image with multiple boxviews open
main window ignores box, and other windows don't clear. fix both for
accurate indication of what slot was just used by the pkmeditor.
2018-01-22 21:31:42 -08:00
Kurt
0ee36a655a Simplify bitmap generation
stride is bpp*width + padding bytes; 0x20 worked for the old code since
8*4=0x20 (width of tile).
2018-01-21 17:22:31 -08:00
Kurt
f690f4885c Change slot indexing to use an enum
Still need to figure out how to reconfigure everything to support
ancillary slot displays (3x fused in USUM)
2018-01-21 15:30:57 -08:00
Kurt
b229a947f2 Fix pt/hgss egg location handling 4->5
Closes #1766
pt/hgss egg location data is lost on transfer, retaining faraway place
only.
2c8e2176e9 fix was incorrect
2018-01-21 11:57:34 -08:00
Kurt
e616b56bfa Remove uncatchable grubbin static encounter
#1763
2018-01-18 14:06:17 -08:00
Kurt
2063cef3e4 Fix arrays not being cloned
don't use the existing data array silly -- i was paranoid long ago for a
reason
all other SAV clone methods don't return the Data array, only these
#1764 additional behavior noted
2018-01-18 14:05:34 -08:00
Kurt
c015c5a337 Shift super training record IDs by 2
closes #1764 and fix odd behavior by adding an editing flag
2018-01-18 14:01:58 -08:00
Kurt
387030e16f Fix 7th gen pikachu altform check
https://projectpokemon.org/home/forums/topic/43498-bug-about-event-pikachu/
2018-01-18 13:50:29 -08:00
Kurt
69896a3a04 Hide gen1 second daycare slot
is duplicate with first
the slot is properly hidden but then set visible when the preview is
loaded for it. im sure the set-visible was a very old design decision
2018-01-16 19:32:54 -08:00
Kurt
c118dc4dae Add SlotList control
unused, i dont like the saveditor indexing slots from a fixed list
2018-01-16 19:32:54 -08:00
Kurt
75c67b02b9
Merge pull request #1760 from smileynation/patch-11
Update flags_dp_ja.txt
2018-01-16 19:32:41 -08:00
Kurt
b74bf7d499 Misc simplification
no functional change, just compute hash over array span instead
2018-01-15 17:51:33 -08:00
Kurt
17e4bdbe3a Add pikachu7 forme nongift check
other branch was unhandled, flag if we have a mismatch
closes #1762
2018-01-15 17:50:33 -08:00
smileynation
d01ad5c4ae
Update flags_dp_ja.txt 2018-01-14 15:55:47 +09:00
Kurt
06733d6e34 Refactoring
Split up c-gear skin bitmap, move generic handling to core
2018-01-13 21:31:02 -08:00
Kurt
4fb3c22b1c Remove usages of System.Drawing.Color
Eventually need to remove usages of bitmap
2018-01-13 19:09:43 -08:00
Kurt
6caefef181 Add cgb->psk & misc clarifications
Closes #1699
tested on black2 & white, skin isn't corrupt on game boot and appears
correctly

still don't like setpixel/System.Drawing reliance (maybe split logic to
CGearSkin & CGearSkinVisualizer) for PKHeX.Core compat
2018-01-13 16:32:57 -08:00
Kurt
029539003b FormChange check: use original form not current form
Closes #1758
noticing the different usage for species (encounter species vs current),
iterating over possible dexlevels (unnecessary?)
2018-01-13 12:10:17 -08:00
Kurt
fb6738f18b Add unown 2->7+ shiny check
closes #1755

also:
fix vc transfer checks not being called (EncounterOriginalGB is no
longer GBEncounterData).
remove usages of GBEncounterData -- class is (as of a ~~month ago) now
never leaked out of the EncounterGenerator -- always returns the actual
encounter data as the wrapper is not needed.
simplify logic flow / references
2018-01-10 16:16:35 -08:00
Kurt
c751c987a9 Add DebutGeneration get
https://projectpokemon.org/home/forums/topic/43378-generation-search-in-pkmdb-andor-batch-editor/

(less than) < and (greater than) > not currently supported (no plan to
add, would need to rewrite value eval logic)
2018-01-10 15:40:33 -08:00
Kurt
4f489a720f Refactoring
move logic back to cgearbackground, initialize the bg regardless of
psk/cgb input format
cache background data to return psk (potentially unintended side effects
if importing bw psk to b2w2, will have to fix cgb->psk first then undo
this tempfix)
#1699
2018-01-09 23:30:44 -08:00
Kurt
f332e41869 misc updates
#1699
generally pertaining to detecting a de-obfuscated input (cgb) vs native
(psk)
still issues with saving data (deobf->native)
2018-01-09 21:47:04 -08:00
Kurt
84a755a8c9 minor simplifications
#1699
2018-01-08 22:40:34 -08:00
Kurt
d187370671 fix checksum/footer set
#1699
checksum in the +0x100 was missing the +SAV.CGearDataOffset
add a few more modifications for better parity

still not 100% fixed
2018-01-08 22:40:34 -08:00
Kurt
4967acc829
Merge pull request #1752 from kwsch/b/url
Fix URLs
2018-01-08 17:40:33 -08:00
Evan Dixon
5a4ddd685c Update Project Pokemon URLs in comment 2018-01-08 13:15:19 -06:00
Evan Dixon
90e3c4a42e Fix thread URL in changelog
It's probably better to fix this on the server side, but this is easier
2018-01-08 13:14:52 -06:00
Kurt
701edbc592 Remove KOR language from gen3 selection
add flag for non japanese lang gen3 eggs
Closes #1747
2018-01-06 22:43:48 -08:00
Kurt
63a983749e Don't generate encounter slots for eggs
Closes #1749
2018-01-06 21:51:58 -08:00
Kurt
659f2098a9 Fix sav4 coin read
#1746
2018-01-06 21:36:44 -08:00
Kurt
26015b44bc Add max cap difference for dppt
#1746
2018-01-06 14:12:28 -08:00
Kurt
218c20d804 Add sav4 coin edits to misc4
closes #1746
2018-01-06 14:02:55 -08:00
Kurt
8cf97f3761 Add pom-pom edge case
dash was stripped out during conversion
closes #1744
2018-01-06 09:40:30 -08:00
Kurt
c006c0cad9 Update pid/ect on showdownset import
closes #1745
2018-01-06 09:35:22 -08:00
Kurt
c6089a183c fix designer deletion of sav editor control
custom constructor parameters aren't expected, needs a default without
optional

(no usages were using a sav provided anyway)
2018-01-02 23:00:52 -08:00
Kurt
7705c158a9 Allow shiny sprite turning off
lul oops
2018-01-02 17:23:43 -08:00
Kurt
1417a6d576 Add shiny sprite fetch & fallback
pseudo future proofing in the event new species sprites are added and
recolored variants are not
Closes #1735 , thanks @trainboy2019 !
(reimplemented alterations with GUI-saved settings)
2018-01-02 17:17:30 -08:00
Kurt
853f5f3ce9 Add shiny sprites
Thanks @msikma (dada)!
Update readme with asset attribution
#1735
2018-01-02 17:14:22 -08:00
Kurt
ef0453ecf6 Add shiny sprite toggle setting
not functional yet
#1735
2018-01-02 17:08:14 -08:00
Kurt
6a9e2ed4b9 Refactoring
improve speed for resource fetch, add optional Shiny parameter
(currently unused)
#1735
2018-01-02 16:53:39 -08:00
Kurt
0f21fc2217 add location interface for verbose analysis output
indicates met location for transferred mons
most gen1/2 encounters won't show values due to the location not being
stored respective to the string tables (anyone wanna do a location remap
after initial load?)
2018-01-02 12:00:41 -08:00
Kurt
5888898e7d fix gen2 egg met level mod
https://projectpokemon.org/home/forums/topic/43278-gen-2-hitmonlee-and-hitmonchan-flagged-as-illegal-if-location-is-mt-mortar-at-level-10/?tab=comments#comment-225577
2018-01-01 21:51:36 -08:00
Kurt
76385a6b4a Fix gsc pre-evo species chain filtering
simplify gsc check to do only once

https://projectpokemon.org/home/forums/topic/43278-gen-2-hitmonlee-and-hitmonchan-flagged-as-illegal-if-location-is-mt-mortar-at-level-10/
2018-01-01 13:53:28 -08:00