Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-11-24 04:53:08 +00:00
Code Issues Projects Releases Packages Wiki Activity
4971 commits 3 branches 76 tags 106 MiB
Commit graph

869 commits

Author SHA1 Message Date
Kurt
232427d002 Rework slot interactivity a little 
decentralize some logic, individual view providers now provide the
details rather than detecting from a huge array.

#1925
 2018-05-05 08:07:22 -07:00
Kurt
02dc49641c Rearrange version changing logic 
set the new version, then update the controls
#1923 ; exist logic overrode rby/gsc to gen7 locations, which didn't
trigger the TID view update.
 2018-05-04 17:59:04 -07:00
Kurt
676b5905bf Show other TID/SID in hover tooltip 2018-05-03 22:44:39 -07:00
Kurt
d15b0b439c Show SID for vc->7+ 
#1923
sometimes (hacked data) can have SID values; don't exclusively follow
the GB era TID only rule.
 2018-05-02 22:28:41 -07:00
Kurt
21cb931123 Repoint old delete/sort shortcuts 
Closes #1923 , actual controls are nested 1 deeper.
 2018-05-02 17:57:40 -07:00
Matt
77276302a5 Add Past Generation deleter (#1922) 
4b6ee3fbf5 (commitcomment-28822553) ;)
 2018-05-02 10:07:09 -07:00
Kurt
7303ace32a Add simple shiny sort 
again, hold ctrl to revese sort
add inverse clear for eggs (clears all but eggs if ctrl held)
 2018-05-01 22:35:37 -07:00
Kurt
4b6ee3fbf5 Update 'sorter' 
Adds IV count sorting
Adds Itemless & Illegal deleting
Adds Max level modding, item clearing. Handle egg cases sensitively.

remove final sortby for reversal case as the incremental integer
prevents further ordering.

Any suggestions? Keep in mind that some modifications can be done by the
Batch Editor scripts; smart deletions & sorts are highest value
additions ;)
 2018-05-01 19:24:47 -07:00
Kurt
9fd0432c41 Reference check translatable object string 
Closes #1921 by only setting the string if it is updated.
 2018-05-01 18:42:56 -07:00
Kurt
4c9177fcb3 Add sort force-reverse 
hold control when triggering the sort
sneaky linq to reverse a sort by:
* re-doing the initial sort, then
* reversing the sorted pkm data by using a throwaway increment
* re-doing the final sort
 2018-04-30 21:39:12 -07:00
Kurt
8dcee4e0ee Add 3 more advanced sorters 
Primary->Secondary typing
Generation->Version
Base Stat Total
 2018-04-30 21:20:28 -07:00
Kurt
116f600cb7 Apply default language if none 
Closes #1920
 2018-04-30 18:48:21 -07:00
Kurt
bbcbdd80a1 Update 'sorter' with more functionality 
Nest item choices into separated groups (based on their overall
function).

Adds 3 more deletion options: eggs, untrained, or not-matching-savefile.
Adds 1 more modification option: Max Friendship of current handler
 2018-04-30 17:32:23 -07:00
Kurt
df4fc96f4d Add legality sorter 
Closes #1919
 2018-04-29 09:55:26 -07:00
Kurt
f060bab844 Use new trainer ID editing control in SAV_Trainer7 2018-04-28 11:52:48 -07:00
Kurt
71faaee31c Refactor savefile tid/sid to int 
can now use TrainerID editor control on a savefile... soon?
 2018-04-28 11:06:58 -07:00
Kurt
43507a5ae5 Add TrainerID control 
Now shows tid7/sid7 when gen7+
 2018-04-28 09:34:54 -07:00
Kurt
294a61c4c1 Update pkmeditor GB gui loop behavior 
updating HP causes SPD to be updated, which is based on SPA; since SPA
is yet to be updated, we trigger constant updates on an SPA > 15 until
we crash.

just use the SPD IV which is already capped by the pkmdata
(this shouldn't refresh fields anyway when loading... whatever).

Closes #1914
 2018-04-25 20:17:58 -07:00
Kurt
3f6b1acc93 Add fixed gender checks for non-GBA/NDS games 
Closes #1912 , genderless ~= fixed gender I guess; shouldn't get these
gender-errors unless it's manually tampered data/ShowdownSet

remove unnecessary code in:
* PKMEditor (>=255 is already covered by == 255 and the fact that gt is
always <= 255)
* VerifyGender (3 <= x <= 5) check is already early-returned via
PIDGender check above

Update IsGenderValid knowing that VC mons have a gennumber <= 2
 2018-04-23 19:58:29 -07:00
Kurt
15ce1acfdb update box manipulation 
closes #1911 , changes end to be inclusive rather than exclusive. abuse
the optional to let it fill in the end caps.
 2018-04-23 19:11:55 -07:00
Kurt
a6903953a0 Re-add old boxtab clicks 
#1910
 2018-04-23 18:55:58 -07:00
Kurt
e25e3fcc19 update joyful dodrio berry offset 
bc90a4fc1d/include/global.h (L276)

u32 bestScore;
u16 berriesPicked;
u16 berriesPickedInRow;
 2018-04-22 20:11:25 -07:00
Kurt
9e874a0784 Add modify handling to 'sorter' dropdown 
adds hatch all eggs in box(es, with shift)
 2018-04-22 12:43:18 -07:00
Kurt
762c5e5cae Add random sorter 
closes #1909
 2018-04-22 12:16:08 -07:00
Matt
7db2c484ea Update sort menu labels (#1907) 2018-04-22 11:37:01 -07:00
Kurt
f6dda90f52 Add icons 
icons are credit to Dave Gandy's Font Awesome pack on flaticon.com
https://www.flaticon.com/packs/font-awesome
 2018-04-21 22:31:11 -07:00
Kurt
e2405346a4 Update usage sorting 
sort friendship delta with high values to front
reference correct method for usage sort
 2018-04-21 21:15:19 -07:00
Kurt
7649d2ef95 Update contextmenu names 
copypasta ftw
 2018-04-21 19:24:50 -07:00
Kurt
df75543f2a Implement pkm sort option control 
right click the box tab
* no longer silly key-combos to initiate a clear/sort
* provides multiple sorting options
Advanced sorting includes:
* Recieved Date
* Friendship usage (using it raises friendship, more used pkm will be
sorted to the top)
* Ownership (current SAV's first, then by other OTs)
 2018-04-21 16:31:41 -07:00
Kurt
e91cb806e5 Extract extension->prefer format method 
fails for 'pkx' (returned 8 instead of 6); establish standard behavior
 2018-04-21 14:38:18 -07:00
Kurt
7a245278ea Relocate mg description parse to core 2018-04-21 09:55:27 -07:00
Kurt
cb930fcaab Show g7 tid on mystery gifts originating from g7+ 2018-04-21 09:18:53 -07:00
Kurt
cee43a3c4b Fix translating non-translatables 
addnew adds a key when not found in original translation, which results
in translating to the old value when flipping back to that language. can
result in invalid values if the control is used as any data display (ie
Gender label)

https://projectpokemon.org/home/forums/topic/44926-when-i-changed-the-language-a-bug-about-gender-occurred/
 2018-04-19 15:36:43 -07:00
Kurt
7cbd0e5d10 Update 18.04.18 
Update event binaries with latest from the Event Gallery
 2018-04-17 20:53:13 -07:00
Kurt
bb03505144 Better handle g2 unown form changing 
Closes #1897
 2018-04-16 16:01:30 -07:00
Kurt
b8a5ccdf7d Simplify shedinja evo move check 
Closes #1895 , re-verified with pkm provided in #1805
there's no shedinja gift, always is an evolution

seal some forms to remove virt call in constructor warning
 2018-04-10 17:00:28 -07:00
Kurt
508f056d33 Clear move pp on move deletion 
closes #1894
 2018-04-09 06:10:26 -07:00
Kurt
335379bd2e Remove unneeded string 
#1893
 2018-04-08 17:54:09 -07:00
Kurt
6ac8ed0098 Update translations 
all supported langs now have all 3 translatable resources; translate
away!
 2018-04-08 09:19:19 -07:00
Kurt
2acef4eaf7 Add messagestring dumper 
untested, will monkey with later
 2018-04-06 22:51:10 -07:00
Kurt
41653490c1 add better legality string file updater 
may want to make the export location smarter so that they dump back to
the compiled resource location, meh

assume that english is already loaded; restore english before next so
that new languages use english as the base language for untranslated
strings
 2018-04-06 22:06:15 -07:00
Kurt
1d4e815689 Extract more mesage strings 
all common strings in forms used by multiple generations

would rather rework the individual generation strings to be unnecessary
with better interaction instead (if possible), as translating hundreds
of limited exposure strings is a drag.
 2018-04-06 21:23:09 -07:00
Archit Date
400344a0e1 Fix compile error on non debug builds (#1889) 2018-04-06 05:55:46 -07:00
Kurt
5e96c6e035 Extract main window strings to translatable class 
Similar to LegalityCheckStrings
no resource files yet, will generate those tomorrow(?)

some strings are not translatable (useless gen6 passerby export text),
not really worth
 2018-04-05 21:25:18 -07:00
Kurt
83c06b1ace Add missing undo/redo events 
lol
 2018-04-05 18:53:09 -07:00
wwwwwwzx
8710c7a517 Translations update (#1887) 
* Update Chinese translation file - 2

* Fix up base stats label translations
 2018-04-04 22:45:14 -07:00
Kurt
48cf658abd Update translations 
#1885
removes content not present, moves dev code to separate debug-only class
 2018-04-03 18:46:32 -07:00
Kurt
1777a09bde Update translation files with all translatables 
Closes #1883

Some controls could be manually pruned (like Gender labels), but nah
 2018-04-02 20:55:10 -07:00
Kurt
9ed2c594f2 Reorder form init 2018-04-02 20:36:13 -07:00
Kurt
3052855a70 Add more trainer records 2018-04-01 11:47:02 -07:00
Kurt
e026a8ab49 Add default trainer info 
use in pkmeditor and utilize
 2018-03-28 18:52:50 -07:00
Kurt
d794e71175 Extend contest-affection check to pre-gen6 transfer 
Closes #1881
Thanks @ijuintekka !
Thanks @sora10pls !
 2018-03-28 16:07:03 -07:00
Kurt
99a4c55579 Relocate some logic to core 
party stats set when setting a slot to a save file
simplify set/delete slotchange duplicate logic
suggest better met locations beyond VC transfers
hatching a gen6 egg applies memories automatically
 2018-03-25 19:05:49 -07:00
Kurt
a24e5aa742 Update personalinfo usages 
less temp array usages, add methods for cleaner understanding
 2018-03-25 13:54:30 -07:00
Kurt
828636856c Change coin cap to fixed 50000 
#1746

https://projectpokemon.org/home/forums/topic/44503-bug-report-gen-4-coin-counts/
max is 50000
https://bulbapedia.bulbagarden.net/wiki/Coin_Case

The Coin Case can hold up to 9,999 coins in Generations I, II, and III,
and up to 50,000 coins in Generation IV.
 2018-03-24 17:29:48 -07:00
Kurt
3548e103fd Fix gen4 box name swap 
Thanks smileynation!

https://projectpokemon.org/home/forums/topic/44481-bug-report-gen-4-box-wallpaper/
 2018-03-24 08:03:43 -07:00
Kurt
17b771632e Add settings editor to main navigation 
shortcut ctrl-n (CoNfig)
Closes #1864
add debug lines for triggering translations to update
 2018-03-23 22:54:26 -07:00
Kurt
55ccb83d5f Allow SettingsEditor to blacklist property names 2018-03-23 22:37:33 -07:00
Kurt
dd17ba0d3a Add master settings window 
#1864
need to hook into main window & delete old logic; when the logic flow
returns after closing the form, all the propagated settings will need to
be copied (ie where the setting is actually used).
translateinterface will translate the control text to a longform
descriptor per the current language.
 2018-03-22 23:04:04 -07:00
Kurt
aedc0092b4 Rework translations 
instead of:
controls on form->dict of names, look up line to find control
now:
dict of names->look up control to find name

faster overall, simpler, and updates the dictionary with new control
entries. browse thru forms that call translateinterface with one
language (english), then updateall(en) and dump to get the updated
translation files.

#1864
 2018-03-20 22:34:44 -07:00
ReignOfComputer
bf1b685705 Translate Showdown Markings & Fix PT Selection (#1872) 
Added translation strings for Apply Showdown Markings in CHS, French,
and Korean. International schools ftw.

Additionally, Portuguese was not accessible as it is Index 9 ("zh2",
which I assume is CHT, is at 8), so I've just hardcoded this bit since I
don't know if anything else relies on lang_val.
 2018-03-20 08:36:15 -07:00
Kurt
42f5f9b051 Add smart move[] setter 
Closes #1871 (smart-move setting is also done by batch editor)
 2018-03-20 08:35:41 -07:00
Kurt
e4c2b5d77a Split PPMax & PPCurrent edit methods 
As noted in #1866
 2018-03-19 16:21:29 -07:00
Kurt
dc0cf34ed5 Inherit sizing mode 
as noted:

https://projectpokemon.org/home/forums/topic/44417-messed-stat-screen-in-new-version/
 2018-03-19 16:15:46 -07:00
ReignOfComputer
a03a54a331 Fix Suggested Move Set (#1866) 
* Use FieldsLoaded to stop updates
 2018-03-19 09:03:27 -07:00
ReignOfComputer
d41df2420f Fix HaX Mode (#1869) 
- Pass HaX to StatEditor once everything else loads
- Fix Hacked Stats enabled check
 2018-03-19 08:10:20 -07:00
ReignOfComputer
430938d131 Showdown Markings Toggle (#1868) 
Perhaps we could have a temporary toggle while waiting for a master
settings page? :) Related: https://github.com/kwsch/PKHeX/issues/1864
https://github.com/kwsch/PKHeX/issues/1862
 2018-03-19 07:52:16 -07:00
Kurt
9bb4120ff9 add faster pkm slot presence check 
instead of checking if the array is empty, only check PID and species
 2018-03-18 16:22:21 -07:00
Kurt
b0dcdf0948 Update 18.03.19 
Update event binaries with latest from the Event Gallery
 2018-03-18 13:42:29 -07:00
Kurt
26cc266dd1 Move type sprite fetch remapping to pkmutil 
I still don't like it 100%
 2018-03-18 11:25:57 -07:00
Kurt
f55028c1a0 Fix KChart errors 
gen1 & gen2 types aren't laid out contiguously (yay bird type and extra
types)
fix gen2 type accessors looking at the wrong byte

type sprites now load correctly, and 3rd ability no longer throws an
error (forced to None).
 2018-03-18 11:22:20 -07:00
Kurt
1aa70a16a4 Reduce bst green scalar 
average*2 resulted in a value that was too-green relative to the stats.
use the rescaling from KChart
 2018-03-18 11:21:00 -07:00
Kurt
56bd39b336 Add base stat indication (with colors) 
Thanks @zaksabeast for feedback in IRC
 2018-03-18 10:38:29 -07:00
Kurt
d65d9e0b79 Add missing = 
lul oops
 2018-03-16 17:57:24 -07:00
Kurt
d1a789eeab Fix some pokedex4 behavior 
https://projectpokemon.org/home/forums/topic/44347-gen-4-pokédex-forms-incorrectly-readwritten/
 2018-03-16 17:54:47 -07:00
Kurt
102550174e Simplification 
invalid/unknown usages were incorrectly interchangable; dex-sets were
looking at Unknown which was impossible for some cases.

only use GameVersion.Unknown as a temp placeholder for later resolution
by the user.
 2018-03-11 18:07:48 -07:00
Kurt
2bd9d99d9e Refactoring 
WinForms->Core logic absorbing (CommonEdits)
loading ShowdownSet now applies properties to PKM instead of PKMEditor
Contest/IVs for Static/Trades are no longer set by default (less object
allocations), and are now checked by the encounter generator
 2018-03-10 18:03:09 -08:00
Kurt
cbf4038a95 Refactoring 
relocate gift data storage out of legal.cs
 2018-03-05 22:19:56 -08:00
Kurt
e4210e2b3e Misc api improvements 
extract common nature amp logic
generic ienumerable copyto which now returns count of elements copied
(maybe useful later). prior usages never tried to copy an enumerable
larger than the dest array (now length checked).
 2018-02-28 21:50:50 -08:00
Kurt
24982fe8c5 Misc simplifications 2018-02-28 21:05:50 -08:00
ReignOfComputer
faab067f80 Fix Inverted Max PP Shortcut (#1855) 
https://github.com/kwsch/PKHeX/issues/1854#issuecomment-369270152
 2018-02-28 08:58:04 -08:00
Kurt
9fb7268434 Fix hidden power combobox 
closes #1852
 2018-02-27 17:48:19 -08:00
Kurt
1411933e27 Relocate pkm stat controls to separate usercontrol 
splits the logic up
change hypertrain from ctrl (prevents 30/31 setting) to shift (allows)
 2018-02-26 21:22:35 -08:00
Kurt
934757eac1 Add Bank7 r/w 2018-02-24 13:03:32 -08:00
Kurt
f9002c6cc9 Add trashbyte copy for OT import on gen1/2 
Closes #1849
NAME_LENGTH is 11 for both gens and the offsets don't vary between
languages, so it's a simple fetch.
 2018-02-22 22:42:50 -08:00
Kurt
8e0ec17e9f Misc refactoring 
no functional changes
 2018-02-21 20:35:07 -08:00
Kurt
d62b34f140 Don't set HiddenAbility if HaX 
have user specify via 0x42 extrabyte as it can only be updated from
there.
closes #1846
 2018-02-19 23:34:07 -08:00
Kurt
26ca111630 Fix SetHPIVs order 
speed IV last -> speed IV first
closes #1844
 2018-02-18 09:54:17 -08:00
Kurt
d7271768b2 Only hyper train if the set level is adequate 
Closes #1841
wasn't clearing if level below
 2018-02-17 16:34:55 -08:00
Kurt
b75313cd87 Sync unsaved changes 
closes #1840
 2018-02-16 17:24:07 -08:00
Kurt
0a0b944de1 Use explicit generation param for forme fetch 
closes #1837
 2018-02-16 16:38:07 -08:00
Kurt
d706d825a9 Handle legal pichu form values 
Closes #1828 , thanks @SpiredMoth !

slightly optimize batrev key init
fix exception for pkm loading switching between gen3->4 saves
 2018-02-10 17:43:00 -08:00
Kurt
033d5baa06 Check EC-PID same for gen1/2 transfers 
Fix PID->EC on gen<3 transfers

https://projectpokemon.org/home/forums/topic/43779-about-vc-pokemons-pid-and-encryptionconstant/
 2018-02-08 18:47:52 -08:00
Evan Dixon
392f01cb3e Fix build error (#1816) 
IEnumerable doesn't support LINQ methods, only the generic variant does. So this commit changes SAV_GameSelect's parameter to a generic IEnumerable of the only type being passed into it. I didn't realize it until afterward, but this is 100% the way it should have been because the databinding members expect ComboItems.
 2018-02-05 12:12:42 -08:00
Pete Rolph
32c650c053 Fix a crash bug when loading Gen 3 saves on mono (#1815) 2018-02-05 07:48:47 -08:00
Kurt
1a5d4efdfe Add database/mgdb -> save importing 
Closes #1804
 2018-02-01 17:29:07 -08:00
Kurt
fabb64705b Split folder->import to multiple overloads 
path, paths, gifts, pkms
removed conversion counter because meh
#1804
 2018-01-31 23:37:01 -08:00
Kurt
afe16dd1a7 Hide mailbox on gc/batrev 
closes #1802
 2018-01-31 20:21:47 -08:00
Kurt
1ca9180e21
use SlotList view to dynamically show slots (#1798) 
Closes #1795 by redoing the controls

Allows for a specified slot type & offset to be passed, can easily add extra slots by updating the GetExtraSlots extension method.
 2018-01-30 18:52:55 -08:00
Kurt
e472bfe278 Refactoring 
move slotchange to core
 2018-01-29 17:52:21 -08:00
Kurt
d7eae51c1f Use showdown specific gender culture for formID 
Closes #1793 , the form was returning -1 because it was expecting ♀ not
F
 2018-01-29 17:20:12 -08:00
Kurt
9085dfd950 Allow backwards conversion on hax 
works somewhat on drag&drop individual files, not guaranteed to work for
all pkm formats
https://i.imgur.com/v3i3ON9.png

Closes #1792
 2018-01-28 22:47:03 -08:00
Kurt
ddf319c713 Set stat level on load 
Closes #1790
lul
 2018-01-28 14:11:12 -08:00
Kurt
2828c89497 Update 18.01.28 
Update event binaries with latest from the Event Gallery
 2018-01-28 00:31:35 -08:00
Kurt
eb505303bb Fix vc backups acting like gb era saves 
ends with .dat only works if the real file ends with dat
load the filename data after stripping off the bak filename data
#1787
 2018-01-28 00:03:49 -08:00
Kurt
3935311988 Add rockruff-1 shiny sprite 
could just add it to the 'sprites don't differ' list instead but
whatever

https://projectpokemon.org/home/forums/topic/43617-usum-bug-report-rockruff-shiny-dusk-form-sprite/
 2018-01-27 18:24:44 -08:00
Kurt
5458b94e50 Resize coin entry 
change 9999 to 65535 for dppt, max gets set on load anyway but just do
it for layout visualization
 2018-01-27 17:50:59 -08:00
Kurt
523dfa32aa Unflip level search <> 
closes #1785
 2018-01-27 13:24:16 -08:00
Kurt
79add8dff1 Update modified check 
takes negligibly longer but accomplishes the necessary task
Closes #1782
 2018-01-27 10:15:56 -08:00
Kurt
f104df6386 Ignore party stats on pkm compare 
Stats were recently added to be calculated on load, thus not matching
the all-zeros when obtained from the save.
Closes #1781
 2018-01-26 21:09:12 -08:00
Kurt
c066df243f Misc fixes/updates 
Fix crystal lacking met level<->current level checks
Fix met location loading for gen2 saves (gen7 sav loaded gen1/2 pkm ->
load gen2 sav)
refactor some logic with pattern matching/consistent method names
 2018-01-26 09:19:20 -08:00
Kurt
98dead5664 Remove out of range box name for no-saves 
oops
closes #1774
 2018-01-25 18:45:11 -08:00
sora10pls
c57f55f31c Fix updated markings not appearing 2018-01-25 17:39:05 -05:00
Kurt
bb20ec49cc load stats prior to searching 
https://projectpokemon.org/home/forums/topic/43579-bug-pkhex-number-fields/
 2018-01-25 09:17:39 -08:00
Kurt
959d598d76 Fix esv searching in database 
only way the filter used to execute was if ESV textbox was empty, which
would throw an exception lul

sync dead code removal for prior pkrs commit (never executes)
475acfaeac
 2018-01-25 08:54:29 -08:00
Kurt
475acfaeac Fix pkrs checkbox behavior 
infecting was incrementing days while the days visibility was hidden

https://projectpokemon.org/home/forums/topic/43518-pokerus/?do=findComment&comment=226611
 2018-01-25 08:48:49 -08:00
Kurt
0edefedc2b Remove gen2->7 auto filtering 
closes #1768
(<7)->7 is now possible so no need to filter further
 2018-01-24 09:19:20 -08:00
Kurt
b16a2f9ad2 Add box rearranging 
enables the left/right arrows on each box to allow switching with the
adjacent box
 2018-01-23 22:37:55 -08:00
Kurt
713e9ea209 Compress box padding 2018-01-23 17:18:37 -08:00
Kurt
18421c66a9 Set box view owner 
shifting focus to another app and back will cause the parent form to be
brought back to the top as well
 2018-01-22 22:39:12 -08:00
Kurt
d65393c6f6 Minor behavior tweaks (preference) 
fix initial box width to 4 with scrollbar, remove always-on-top for main
window
 2018-01-22 21:58:53 -08:00
Kurt
f073585592 Add all-boxes viewer 
removed ability to have multiple single box popups
double click the Box tab when holding shift to bring it up
resize to preferences: https://i.imgur.com/XB2978R.png
 2018-01-22 21:38:42 -08:00
Kurt
6eb0cd17cb fix slot bg image with multiple boxviews open 
main window ignores box, and other windows don't clear. fix both for
accurate indication of what slot was just used by the pkmeditor.
 2018-01-22 21:31:42 -08:00
Kurt
0ee36a655a Simplify bitmap generation 
stride is bpp*width + padding bytes; 0x20 worked for the old code since
8*4=0x20 (width of tile).
 2018-01-21 17:22:31 -08:00
Kurt
f690f4885c Change slot indexing to use an enum 
Still need to figure out how to reconfigure everything to support
ancillary slot displays (3x fused in USUM)
 2018-01-21 15:30:57 -08:00
Kurt
c015c5a337 Shift super training record IDs by 2 
closes #1764 and fix odd behavior by adding an editing flag
 2018-01-18 14:01:58 -08:00
Kurt
69896a3a04 Hide gen1 second daycare slot 
is duplicate with first
the slot is properly hidden but then set visible when the preview is
loaded for it. im sure the set-visible was a very old design decision
 2018-01-16 19:32:54 -08:00
Kurt
c118dc4dae Add SlotList control 
unused, i dont like the saveditor indexing slots from a fixed list
 2018-01-16 19:32:54 -08:00
Kurt
06733d6e34 Refactoring 
Split up c-gear skin bitmap, move generic handling to core
 2018-01-13 21:31:02 -08:00
Kurt
4fb3c22b1c Remove usages of System.Drawing.Color 
Eventually need to remove usages of bitmap
 2018-01-13 19:09:43 -08:00
Kurt
6caefef181 Add cgb->psk & misc clarifications 
Closes #1699
tested on black2 & white, skin isn't corrupt on game boot and appears
correctly

still don't like setpixel/System.Drawing reliance (maybe split logic to
CGearSkin & CGearSkinVisualizer) for PKHeX.Core compat
 2018-01-13 16:32:57 -08:00
Kurt
4f489a720f Refactoring 
move logic back to cgearbackground, initialize the bg regardless of
psk/cgb input format
cache background data to return psk (potentially unintended side effects
if importing bw psk to b2w2, will have to fix cgb->psk first then undo
this tempfix)
#1699
 2018-01-09 23:30:44 -08:00
Kurt
f332e41869 misc updates 
#1699
generally pertaining to detecting a de-obfuscated input (cgb) vs native
(psk)
still issues with saving data (deobf->native)
 2018-01-09 21:47:04 -08:00
Kurt
84a755a8c9 minor simplifications 
#1699
 2018-01-08 22:40:34 -08:00
Kurt
d187370671 fix checksum/footer set 
#1699
checksum in the +0x100 was missing the +SAV.CGearDataOffset
add a few more modifications for better parity

still not 100% fixed
 2018-01-08 22:40:34 -08:00
Evan Dixon
90e3c4a42e Fix thread URL in changelog 
It's probably better to fix this on the server side, but this is easier
 2018-01-08 13:14:52 -06:00
Kurt
701edbc592 Remove KOR language from gen3 selection 
add flag for non japanese lang gen3 eggs
Closes #1747
 2018-01-06 22:43:48 -08:00
Kurt
26015b44bc Add max cap difference for dppt 
#1746
 2018-01-06 14:12:28 -08:00
Kurt
218c20d804 Add sav4 coin edits to misc4 
closes #1746
 2018-01-06 14:02:55 -08:00
Kurt
c006c0cad9 Update pid/ect on showdownset import 
closes #1745
 2018-01-06 09:35:22 -08:00
Kurt
c6089a183c fix designer deletion of sav editor control 
custom constructor parameters aren't expected, needs a default without
optional

(no usages were using a sav provided anyway)
 2018-01-02 23:00:52 -08:00
Kurt
7705c158a9 Allow shiny sprite turning off 
lul oops
 2018-01-02 17:23:43 -08:00
Kurt
1417a6d576 Add shiny sprite fetch & fallback 
pseudo future proofing in the event new species sprites are added and
recolored variants are not
Closes #1735 , thanks @trainboy2019 !
(reimplemented alterations with GUI-saved settings)
 2018-01-02 17:17:30 -08:00
Kurt
853f5f3ce9 Add shiny sprites 
Thanks @msikma (dada)!
Update readme with asset attribution
#1735
 2018-01-02 17:14:22 -08:00
Kurt
ef0453ecf6 Add shiny sprite toggle setting 
not functional yet
#1735
 2018-01-02 17:08:14 -08:00
sora10pls
92854b54f0 Update misc images to match Gen 7 2017-12-31 22:43:08 -05:00
Kurt
fa90ae21df Fix variable reference 
#1731
 2017-12-29 18:30:13 -08:00
Kurt
648f250303 Fix party/other tab loading for sav loads 
loading pbr/rsbox -> loading a game that has party & daycare causes the
daycare tab to be loaded in the incorrect spot.
PartyTab needs to be calculated closer to its use
 2017-12-29 16:50:55 -08:00
Kurt
45eee8575a Only promt roto-OT if OT is changed 
reduces nag
closes #1731
 2017-12-29 10:00:32 -08:00
Kurt
61b65198f2 Allow box name editing on gen2 2017-12-27 15:52:29 -08:00
Kurt
985883e6ae Refactoring 
pull out ability list generating
refactor showdown set to an Action that can be overwritten from
elsewhere
 2017-12-21 22:55:33 -08:00
Kurt
9457db9059 Fix mystery gift qr export text 
closes #1720
 2017-12-21 09:49:40 -08:00
Kurt
9429bc6961 Fix showdown import on gen3 
https://projectpokemon.org/home/forums/topic/43126-problems-with-importing-rse-showdown-files-from-clipboard-in-pkhex/

Sceptile @ Leftovers
EVs: 4 Def / 252 SpA / 252 Spe
Timid Nature
- Leaf Blade
- Leech Seed
- Substitute
- Hidden Power Ice

also fix apricorn form title
 2017-12-19 15:33:23 -08:00
Kurt
9263856845 Add apricorn pouch editing 2017-12-18 09:36:53 -08:00
Kurt
2dbdb35955 Misc tweaks 
possibly fix UI not-1x scaling screwing up drawn pkm images with
items/shiny/illegal.
simplify some logic -> speed improvements (wow so noticable /s)
 2017-12-16 18:29:10 -08:00
Kurt
18796d6f92 Misc tweaks 
fix bk4 ribbon checks (lacked interface inheritance)
change MN -> UM for get blank save (unused in PKHeX solution)
prevent inheriting from derived pkm classes
 2017-12-16 14:11:41 -08:00
Kurt
e5aa39a6bb Refactoring 
get language list now doesn't return new objects (or re-enumerate)
update rand usage to be inclusive for top bound, extend shuffle to
collections
remove unnecessary location overrides (already overriden in legal fetch)
 2017-12-14 20:58:55 -08:00
Kurt
dd21f9375f Misc updates 
Disallow sandygast on US
Add 2 more records
thanks @feralfalcon
Closes #1698
 2017-12-08 08:54:00 -08:00
Kurt
f3cc29df57 Update 17.12.05 
Update event binaries with latest from the Event Gallery
 2017-12-05 09:04:59 -08:00
Kurt
eff8855729 Allow throw type changes to be saved 
move SM/USUM branch inside the method
closes #1695
 2017-12-05 07:26:55 -08:00
Kurt
3d7b2a2b29 Misc tweaks 
RNG frame mismatch -> fishy (for now)
fix xmldoc copypaste
clean up some resharper warnings
 2017-12-04 16:26:26 -08:00
Kurt
a5dbdf91bd Misc tweaks 
detect antishiny cxd
remove unused using
don't set caught for seenAll (gen7 dex)
 2017-12-04 13:18:28 -08:00
pokecal
0f52f94222 fix MailBoxEditor 
add Mail5, almost same as Mail4.
 2017-12-04 00:00:14 +09:00
Kurt
bdc9d7edce fix plaza get set 
closes #1684
 2017-12-02 21:37:46 -08:00
Kurt
2d3203fc1a Refactoring 
extract out Mail classes to core
 2017-12-02 19:12:04 -08:00
pokecal
3e5e49219b fix MailBoxEditor 
fix Gen4 Controls
add Mail .Empty for LegalCheck
add Mail SetBlank() for make BlankMail
 2017-12-03 11:24:57 +09:00
pokecal
c4ca3aba75 add MailBox Editor 
I just wanted to fix PK3 heldMailID.
 2017-12-03 07:21:07 +09:00
Kurt
431c0fc205 Fix hover frost missing pixel 
add alternate coloration for a slot that already has a background color
 2017-11-30 20:35:45 -08:00
Kurt
fdc52e2c19 Add pkm league starter EC for gen7 
Closes #1671
 2017-11-29 20:04:01 -08:00
Kurt
4a898b0829 Leave empty item slots for gen7+ 
game depends on an existing value to check for if the item is truly
"New"
Closes #1670

Don't clear count=0 slots for gen7+
For sorting, put all the count=0 at the near top (any feedback on how
this actually works?)
 2017-11-29 19:47:27 -08:00
Kurt
fa78154df7 Save current facility on save action 
unsaved combobox choices only are saved when the current index is
changed, need to save when the form is closed (saved).
 2017-11-29 08:38:32 -08:00
pokecal
e86b8c670f add Crystal GS EventFlags 
have checked with US ver.
 2017-11-28 03:35:55 +09:00
Kurt
b30cc933e5 Extract festafacility from gui code 
move to core project as a structure/class
 2017-11-26 08:47:25 -08:00
pokecal
8fe81e8610 update FestaPlazaEditor 
add BattleAgent Grade30 reward giving
 2017-11-26 19:40:18 +09:00
Kurt
2be84b6005 Rework encounterslot location fetch 
store ref to area instead of location, useful for fetching sibling slots
from the parent.
 2017-11-25 18:16:50 -08:00
Kurt
bb5456bf9d Update 17.11.25 
Update event binaries with latest from the Event Gallery
 2017-11-24 14:15:01 -08:00
Kurt
0a0a54b59e
Merge pull request #1657 from pokecal/master 
update FestaPlazaEditor
 2017-11-24 12:07:45 -08:00
Kurt
66c038e301 rework program exception handling / detection 
focus the dll not found check to FileNotFoundException for filename
(dll) check; existing checked for targetsite which didn't trigger

define out release methods for debug builds
 2017-11-24 12:03:57 -08:00
pokecal
2c15170844 update FestaPlazaEditor 
Add Result of FortuneTeller
and found that the Unknown Value of FestaID(not introduced)
was mistake, contaminate NPCs.
 2017-11-25 03:14:55 +09:00
Kurt
5ae408c316 cleanup 
no functional changes
 2017-11-23 09:43:43 -08:00
Kurt
5be401cc73
Merge pull request #1652 from pokecal/master 
update FestaPlazaEditor
 2017-11-22 22:12:29 -08:00
Kurt
d57b5a343a sync missing change 
nj resharper; changed sig -> didn't update
 2017-11-22 22:06:08 -08:00
Kurt
b8a5657d5a misc tweaks 
pull out transfer locations to const references
add vc2 & crown beast/celebi met location suggesting
add vc2 crystal sensitive detection
add 2 more usum trainer stats (thanks holla!)
 2017-11-22 21:45:30 -08:00
pokecal
c3716440e6 update FestaPlazaEditor 
I think the form contains almost all controls that needed.
 2017-11-23 09:49:53 +09:00
Kurt
5fd1e85ce6 Refactoring 
are the ace trainer genders swapped? removed the iteration loop in favor
of precomputed values

(pattern goes m/f *n?)

add wormhole max dist val
 2017-11-21 19:08:31 -08:00
Kurt
193c3e8d59 set box info for right click box legality checks 
slot/box data wasn't being set, causing any 'party only' forme checks to
be prevented
 2017-11-21 18:32:27 -08:00
Kurt
f25b4fea9c Add forme range check method to personalinfo 
relocates logic to better location
 2017-11-21 18:32:27 -08:00
Kurt
15496aa9be
Merge pull request #1642 from pokecal/master 
add USUM BattleAgency control
 2017-11-21 15:38:43 -08:00
Kurt
486e5dc4fe Move forme check after species check 
compatibility message of 803-807 dex pkm on S/M needs to say species
first rather than checking forme first
Closes #1643
 2017-11-21 15:22:33 -08:00
pokecal
8c08ec1328 add USUM BattleAgency control 
the NOTE(Giovanni alert) is a little excessive I think,
I will remove it after detect a list of upcoming trainers.
 2017-11-22 03:37:40 +09:00
pokecal
7799450193 fix FestaPlazaEdit value 
When the facility is NOT introduced with visitors
and start FestaPlaza after latest started date,
VisitorFesID become unknown small value.(0/5/7/9/11)
So I stop auto-deletion of visitor data.(and put delete button)
 2017-11-21 05:15:32 +09:00
Kurt
1e5fc96e8e fix gs met location errors 
override current location if format is GB
update GS transfer location ID
 2017-11-20 09:11:37 -08:00
pokecal
16a0abaf62 fix FestaPlazaEdit value 
found "misc value" as used stats.
exchange left count is also up to 255.
(value 0x83 shows "?", 0x103 shows "3")
fix dye#5(blue) color value
 2017-11-20 19:08:41 +09:00
Kurt
6534ef1919 Refactoring 
Reworks festa facility into a get/set object, simplify some operations
naming convention (PascalCase) for methods/properties
closes #1635
 2017-11-19 21:25:46 -08:00
Kurt
2970348de6 fix vc transfer location suggesting 
also fix linux builds case sensitivity
 2017-11-19 20:35:36 -08:00
Kurt
70ec1fda5e cleanup 
wasn't able to view the designer layout so I removed & readded to
project -- works fine now.
uppercase method names
 2017-11-19 16:16:44 -08:00
pokecal
3c85b0ead3 add G7 FestivalPlaza Editor 
There are too many phrases,
I have no plan to complete all list of phrases.
But I think user can edit phrases of each facility
 by using their phrase settings.
 2017-11-20 06:50:39 +09:00
Kurt
469587bbbd Add Rotom OT name 
"nah lets just store the OT in the save file twice"

add a double check if OT != RotOT to remind the user
 2017-11-18 22:26:57 -08:00
Kurt
243f94f02b Add map coordinate writeback check 
same as sav7; apparently some areas in gen6 are also truncation prone
 2017-11-18 12:22:54 -08:00
Kurt
6394dac19f Rework mysterygift pkm sprite generation 
don't bother converting to pkm then generating the sprite off that; use
the overload with int/bool

removes sav/pkm dependency for generating gift descriptions, and
standardizes the names a little. maybe a PKMBase interface would be
useful...
 2017-11-18 11:34:23 -08:00