433 commits

Author	SHA1	Message	Date
Kurt	94811d9052	Split up IEncounterable generators ... Can break the filtering out into smaller methods such that the generator can return results with less strict filtering	2018-03-10 19:51:09 -08:00
Kurt	2bd9d99d9e	Refactoring ... WinForms->Core logic absorbing (CommonEdits) loading ShowdownSet now applies properties to PKM instead of PKMEditor Contest/IVs for Static/Trades are no longer set by default (less object allocations), and are now checked by the encounter generator	2018-03-10 18:03:09 -08:00
Kurt	9da1913f1b	Only check static IVs if original IVs still exist ... https://projectpokemon.org/home/forums/topic/44319-bug-vc-mew/ Thanks Davil!	2018-03-09 20:00:13 -08:00
Kurt	cda2cfcefd	Clean up EncounterLink ... no new gen6 pkm link gifts, simplify usages	2018-03-09 18:58:00 -08:00
Kurt	452ffe2369	Refactoring ... relocate location of stuff	2018-03-08 21:18:32 -08:00
Kurt	cbf4038a95	Refactoring ... relocate gift data storage out of legal.cs	2018-03-05 22:19:56 -08:00
Kurt	21cdf4f642	Reorganization ... wonder if it's possible to provide a more lightweight core by pulling out legality stuff to a separate project?	2018-03-05 20:49:45 -08:00
Kurt	e33bd4c327	Add Dialga/Palkia headbutt location ... turns out route 47 (below route 48) also yields dialgapalkia, which also has a tall grass patch that can be headbutted from. Closes #1833	2018-02-15 19:40:42 -08:00
Kurt	89248b30a9	Re-add rufflet pelago for sn ... Thanks @wwwwwwzx !	2018-02-12 17:38:31 -08:00
wwwwwwzx	9187be8177	Update CHS translation files (#1827) ... * Update CHS translation files * Fix crabrawler outliers Double check the wild encounters level range again.	2018-02-10 15:29:22 -08:00
Kurt	f289249b2d	Add oddball crabrawler berry pile levels ... thanks @wwwwwwzx !	2018-02-09 21:26:28 -08:00
Kurt	d6fbd0f0d7	Reorder gsc encounters ... new string resources have shuckle last thanks @sora10pls	2018-02-08 17:05:15 -08:00
Kurt	05c4a0f286	partner cap pikachu update ... great job gamefreak allow current handler to be 0, remove static encounter as the data was sneakily faked as a WC7 in the events gallery. Closes #1817 ; still needs to update with new pikachu pid method allowing shinies (next update).	2018-02-07 19:56:02 -08:00
Kurt	9408255bee	Add other international (non english) gen2 tradeOTs	2018-02-06 23:09:00 -08:00
Matt	1b2aded412	Allow shiny Partner Cap Pikachu (#1820) ... good job Game Freak https://twitter.com/wwwwwwzx/status/961057063198539778	2018-02-06 18:54:45 -08:00
Kurt	05355f3566	Fix gsc shuckle jp name ... Closes #1818 strengthen language specific checks (JP or INT, not any)	2018-02-05 20:55:10 -08:00
Kurt	246b9d46a9	Add GSC fishing swarm encounters ... Closes #1814	2018-02-04 23:14:12 -08:00
Kurt	2a638a957f	Refactoring ... compress some ideas	2018-02-04 19:17:44 -08:00
Kurt	35e5dbfb32	Add eterna forest honey tree location ... Closes #1812 , thanks @ultima-soul !	2018-02-04 14:03:35 -08:00
Kurt	04888a5c39	Add crabrawler berry pile scripted encounter ... https://projectpokemon.org/home/forums/topic/43628-crabawler-bug/ doesn't exist in static encounters, maybe is set up like the swooping encounters of gen6.	2018-02-04 13:04:45 -08:00
Kurt	14fc71a5d2	Fix Zygarde Aura Break formechange detect ... original was AltForm != 1, 0 is also invalid so >1 suffices. remove parameter from method & update usages	2018-02-03 21:12:36 -08:00
Kurt	0a22ccdb2b	Disallow invalid pelago levels ... simplify pelago slot generation too linq for now; can be silly and make it a for loop but meh	2018-02-02 20:52:44 -08:00
Kurt	382c94c348	drop sm pelago exclusives back to 1-55 not 37-55 ... https://projectpokemon.org/home/forums/topic/43711-vullaby-invalid-error/	2018-02-02 20:10:43 -08:00
Kurt	b603bc87b8	Update shedinja ninjask move checks ... check level of source moves for any incompatibility in non-bred cases. Closes #1805	2018-02-01 19:57:02 -08:00
Kurt	999427f484	Update gen2 egg generator ... Level = Level is equivalent to Level = 0 update EggInfoSource to use Level instead of LevelMin (LevelMin returns Level, just be clear on usage) update VerifyCurrentMoves so that only gen1/2 do the gen1/2 move update methods. Recently extended all encounters to have a generation property; we only care about gen1/2 here. https://projectpokemon.org/home/forums/topic/43655-pokemon-crystal-egg-mark-as-not-legit/	2018-01-30 20:36:22 -08:00
Kurt	74f185591a	Fix shiny/nonshiny egg mysterygift link trade checks ... thanks @Admiral-Fish for finding this case	2018-01-28 23:40:57 -08:00
Kurt	2365e2394c	Add eggcycles override for Odd Eggs ... not gonna bother checking for exp < 125 because after transfer these are indistinguishable from regular eggs.	2018-01-28 09:46:11 -08:00
Kurt	13e7d8ff85	Fix dragonair ingame trade genders ... #1787	2018-01-27 23:23:10 -08:00
Kurt	282676e2f2	Refactoring ... reduces mental footprint	2018-01-27 17:49:18 -08:00
Kurt	ca2898d648	Rework gbc celebi detection ... disallow outside jp games	2018-01-27 11:46:51 -08:00
Kurt	c066df243f	Misc fixes/updates ... Fix crystal lacking met level<->current level checks Fix met location loading for gen2 saves (gen7 sav loaded gen1/2 pkm -> load gen2 sav) refactor some logic with pattern matching/consistent method names	2018-01-26 09:19:20 -08:00
Kurt	48564d7e30	Fix celebi iv check ... update version ID as well Closes #1775	2018-01-25 20:39:32 -08:00
Kurt	58e374bcc6	Add celebi / more crystal legality handling ... Closes #1772	2018-01-25 19:25:10 -08:00
Kurt	5472f869cf	Remove some crystal vc checks ... now legal assuming x->kor7 sets the language val based on the cart language, should be good for the kor crystal checks.	2018-01-25 09:14:25 -08:00
Kurt	713e9ea209	Compress box padding	2018-01-23 17:18:37 -08:00
Kurt	b229a947f2	Fix pt/hgss egg location handling 4->5 ... Closes #1766 pt/hgss egg location data is lost on transfer, retaining faraway place only. 2c8e2176e9 fix was incorrect	2018-01-21 11:57:34 -08:00
Kurt	e616b56bfa	Remove uncatchable grubbin static encounter ... #1763	2018-01-18 14:06:17 -08:00
Kurt	029539003b	FormChange check: use original form not current form ... Closes #1758 noticing the different usage for species (encounter species vs current), iterating over possible dexlevels (unnecessary?)	2018-01-13 12:10:17 -08:00
Kurt	fb6738f18b	Add unown 2->7+ shiny check ... closes #1755 also: fix vc transfer checks not being called (EncounterOriginalGB is no longer GBEncounterData). remove usages of GBEncounterData -- class is (as of a ~~month ago) now never leaked out of the EncounterGenerator -- always returns the actual encounter data as the wrapper is not needed. simplify logic flow / references	2018-01-10 16:16:35 -08:00
Kurt	63a983749e	Don't generate encounter slots for eggs ... Closes #1749	2018-01-06 21:51:58 -08:00
Kurt	0f21fc2217	add location interface for verbose analysis output ... indicates met location for transferred mons most gen1/2 encounters won't show values due to the location not being stored respective to the string tables (anyone wanna do a location remap after initial load?)	2018-01-02 12:00:41 -08:00
Kurt	5888898e7d	fix gen2 egg met level mod ... https://projectpokemon.org/home/forums/topic/43278-gen-2-hitmonlee-and-hitmonchan-flagged-as-illegal-if-location-is-mt-mortar-at-level-10/?tab=comments#comment-225577	2018-01-01 21:51:36 -08:00
Kurt	76385a6b4a	Fix gsc pre-evo species chain filtering ... simplify gsc check to do only once https://projectpokemon.org/home/forums/topic/43278-gen-2-hitmonlee-and-hitmonchan-flagged-as-illegal-if-location-is-mt-mortar-at-level-10/	2018-01-01 13:53:28 -08:00
Kurt	cfe78a7a0c	Add rby power plant static encounters ... https://projectpokemon.org/home/forums/topic/43272-small-electrode-legality-bug/?tab=comments#comment-225537	2018-01-01 10:38:38 -08:00
Kurt	0c2b16391f	fix spanish ranch gift name check ... oops	2017-12-29 13:08:06 -08:00
Kurt	43cb0e8d7d	Provide more accurate met level for eggs ... Gen6 egg with met level != 1 (ie 98) will use the gen3-4 metlevel branch. fuzzed input from #1728 to be hacked (met level = 98)	2017-12-28 10:01:48 -08:00
sora10pls	c3d5266b89	Add XY gift Lapras ability check	2017-12-23 18:28:00 -05:00
Kurt	ea76d6a899	Misc tweaks ... minor perf improvements (don't ToList for encounter slots, store all slots incrementally); has better performance for legal pkm checks	2017-12-23 11:49:20 -08:00
Kurt	7f21728e84	Add area->location references to remaining slots	2017-12-23 11:48:10 -08:00
Kurt	5e59e20ea1	Store matched encounter generation ... previously was only defined for gen1/2, why not all gens can now query encounters in Core for encounters per generation via reflection; can help group encounters for data vis or be faster than getting individual gen numbers	2017-12-18 16:17:21 -08:00
Kurt	80baaea3b7	add b2w2 n's pokemon PIDs ... add b2w2 fixed PID encounters (N's Pokemon), move nsparkle to this class redo static encounter cloning	2017-12-18 15:25:40 -08:00
Kurt	24b5cc48ed	Fix gb encounter move comparison ... don't calc NoMoveReminder for non-gen2 formats, also fix comparisons (gen1 || gen2&&noRemind) Closes #1707	2017-12-17 21:26:31 -08:00
Kurt	21c1dde3a7	Fix static encounter gift / egg edge case ... extract EncounterStatic match determination; in doing so fixes "lvl" by passing byval. Pichu encounters (2) come before the Gift level 25 pikachu, causing lvl to be dropped to 5. When pikachu comes around, it compares 5==25 -> bad; pulling out the method and passing byval allows it to be 25 at the start of every new encounterstatic checked.	2017-12-16 18:24:03 -08:00
Kurt	0b58d4ffe9	Add form/nature checks for gen5 trades ... altform wasn't checked for EncounterTrade nature wasn't checked for gen5 origin (decoupled from PID, but forced) #1702	2017-12-16 14:09:03 -08:00
Kurt	e5aa39a6bb	Refactoring ... get language list now doesn't return new objects (or re-enumerate) update rand usage to be inclusive for top bound, extend shuffle to collections remove unnecessary location overrides (already overriden in legal fetch)	2017-12-14 20:58:55 -08:00
Kurt	b5640de538	Misc tweaks ... reorder some args, reuse some standard methods; add spanish for gen1/2 egg name case	2017-12-14 16:16:47 -08:00
Kurt	9a39f818f9	Misc fixes ... #1700 dp personal: add wormadam/deoxys manual forme count values generator: bcc handling for pkm present in & out of bcc, and static/wild duplicates util: fix incorrect variable reference	2017-12-13 16:17:02 -08:00
Kurt	816ebf6b0e	Refactoring ... no functional change	2017-12-11 16:01:24 -08:00
Kurt	dd21f9375f	Misc updates ... Disallow sandygast on US Add 2 more records thanks @feralfalcon Closes #1698	2017-12-08 08:54:00 -08:00
Kurt	5bc2e6da88	Refactoring ... de-linq some areas where direct accessing is possible (list/array)	2017-12-04 20:16:54 -08:00
Kurt	3d7b2a2b29	Misc tweaks ... RNG frame mismatch -> fishy (for now) fix xmldoc copypaste clean up some resharper warnings	2017-12-04 16:26:26 -08:00
Kurt	1007c5ddb8	don't flag pokespot for frame not matching ... #1693	2017-12-04 16:05:21 -08:00
Kurt	6773a2801d	update static/magnet slot permutations ... using certain slot modifiers (swarm/game pak) causes different arrangements of slots for different static/magnet pull groups to pull from store a list of permuted/different slots and add them to the table at the end with the rest move static/magnet pull marking into gen4 methods (only leave for gen3) move trophy slot generation into gen4dppt area fetch (necessary for static/magnet permuting) fix electric off-by-one (yay for curse ??? type shifting everything)	2017-12-03 12:20:53 -08:00
Kurt	133cc22f50	Add bypass for gen4 unown ... meh	2017-12-02 19:54:50 -08:00
Kurt	5d74096243	Apply static/magnet groups by slot type ... only apply for emerald (only game in gen3 that supports it)	2017-11-30 22:34:57 -08:00
Kurt	d3d7d7d50d	Add slot level / IsEncounterable beginnings ... dynamic level -> calc level no sweet scent -> proc available (rock smash/fish) change frame checking in encountergenerator to save which frame it was found on (unused but possibly later can capture this for output)	2017-11-29 21:31:52 -08:00
Kurt	36894a588d	Add FRLG unown frame matching ... Turns out there was no documentation anywhere on encounterslot numbers for the individual forms; some sites had overall rates. Assuming a human filled out the encounter slots, forms would repeat left to right until a new form takes over. Below slot numbers match the rates when summed up. https://pastebin.com/raw/bQt3ZMbq	2017-11-29 18:28:20 -08:00
Kurt	8f8cf5bc9a	Fix tradepair calculation (link trade eggs) ... returned invalid pair values for gen7 due to 2 unused game IDs between the gen6&gen7 pairs	2017-11-29 09:21:17 -08:00
Kurt	dd7684735a	Add Frame mismatch illegal message handling ... encounter will no longer be ignored as valid, will instead show the RNG frame mismatch message.	2017-11-28 21:30:53 -08:00
Kurt	fb4fffffa0	Change rse feebas to swarm slottype ... behaves the same as a swarm pkm in terms of proc (50% -> level -> generate), so have it travel the same code path.	2017-11-28 19:41:29 -08:00
Kurt	0bc2ee0938	Skip scatterbug static encounter forme check ... closes #1668 add 2/3 pkms provided as test cases (spewpa can be ignored, close enough. just want an evo & orig).	2017-11-28 19:29:25 -08:00
Matt	42d6d483f2	Comment out Old Amber Aerodactyl	2017-11-28 19:10:56 -05:00
Kurt	187726b4af	Use static/magnet pull values ... reorganize a little for lead use cases	2017-11-26 16:09:24 -08:00
Kurt	0f3529e764	Add gen3 swarm encounter slot call ... via pret/pokeemerald (and pokeruby); rate is set at 50% swarm pokemon have the ability to have 4 fixed moves, so derive from EncounterSlot to have moves, and remove special handling from VerifyCurrentMoves (now picked up by IMoveset pattern	2017-11-26 11:00:54 -08:00
Kurt	1162ba5b3d	update bcc slot table ... https://pastebin.com/Y0VRnJxu not sure what the 2nd rand value is still some things to sort out with RoC's PC	2017-11-25 22:28:38 -08:00
Kurt	2be84b6005	Rework encounterslot location fetch ... store ref to area instead of location, useful for fetching sibling slots from the parent.	2017-11-25 18:16:50 -08:00
Kurt	fbce8582c7	Add encounter slot checking ... emerald silly stuff like magnet pull not implemented so some stuff may be not matched.	2017-11-25 13:53:39 -08:00
Kurt	76903bce9f	Fix gen4-6 gen4 origin encounter type defer check ... only check etype if appropriate (not gen7+)	2017-11-25 09:48:49 -08:00
Kurt	d1bae13250	Add flagging for crystal transfers ... users should know better but best to know allow gen2 female when from crystal	2017-11-24 18:19:16 -08:00
Kurt	3483b4bb91	Clean up vc2 legality/transfer stuff	2017-11-24 10:13:42 -08:00
Kurt	b8a5657d5a	misc tweaks ... pull out transfer locations to const references add vc2 & crown beast/celebi met location suggesting add vc2 crystal sensitive detection add 2 more usum trainer stats (thanks holla!)	2017-11-22 21:45:30 -08:00
Kurt	4bbe586981	block ash greninja from USUM game origin ... should really be part of a 'receivable by game' check; not doing any more of these edge cases. need card hash -> permit bits for future cases.	2017-11-22 08:24:54 -08:00
Kurt	d5411f1453	Add nickname flag override for encountertrade ... closes #1649	2017-11-22 08:11:53 -08:00
Kurt	9806677d5e	EncounterType init update ... move MarkEncounterTypeData back above the area size reduction so that the mark-by-locationID special handling will work prevent slottype from becoming overwritten if already defined by special case handling add examples provided to automated test cases closes #1648	2017-11-22 07:52:17 -08:00
Kurt	b2b6df7808	Shuffle encountertype loading around ... add rocksmash type for cianwood closes #1646	2017-11-21 18:32:26 -08:00
Kurt	01dacce214	Add gs transfer met location ... 30017	2017-11-19 19:19:35 -08:00
Kurt	ef9722153f	move evochain fetch outside of location iterator ... also relocate gen12 code so it only runs for gen12	2017-11-19 15:26:41 -08:00
Kurt	1b9d657c2f	Remove double encounter slot species filtering ... GetValid already filters by species move some common non-location code out of the method; can be done for the dexlevel fetching too -- future improvement.	2017-11-19 12:41:23 -08:00
Kurt	6b281cbefe	more rockruff 1 handling ... y u do dis gf Closes #1630	2017-11-18 20:08:11 -08:00
Kurt	3b5e6239de	Add usum pelago encounters ... nothing exclusive, but different from sm https://pastebin.com/NhAA1vJn	2017-11-18 13:53:51 -08:00
Kurt	6394dac19f	Rework mysterygift pkm sprite generation ... don't bother converting to pkm then generating the sprite off that; use the overload with int/bool removes sav/pkm dependency for generating gift descriptions, and standardizes the names a little. maybe a PKMBase interface would be useful...	2017-11-18 11:34:23 -08:00
Kurt	f7e20a3c43	Misc tweaks ... fix roamer3 not setting IVs fix usum z items rightmost pixel getting chopped off use Gen* instead of GenNumber for specific cases (faster) add WasGiftEgg location case for Gen7 remove some unnecessary array allocations	2017-11-17 22:19:23 -08:00
Kurt	311e110f6b	Block wild dusk rockruff ... closes #1627 adds test cases	2017-11-17 20:02:01 -08:00
Kurt	61c0bf5271	Fix italian/german b2w2 yancy/curtis OT swap ... https://projectpokemon.org/home/forums/topic/42528-bw2-in-game-trades-yancycurtis-20171117/	2017-11-17 08:38:38 -08:00
Kurt	55d8f4aa26	Add rockruff event evo edge case ... different altform IDs	2017-11-16 21:04:51 -08:00
Kurt	0cfb79a3e2	handle hacked edge case input ... gen7 pkm version on format5 -> exception on new int[-X] normally caught via exception suppression but better to handle the cause.	2017-11-15 18:13:04 -08:00
Kurt	897ed84933	update milotic specific evolution checks ... verifier: return true if detectably traded check: invert condition to skip out if it is verified traded	2017-11-15 08:36:09 -08:00
Kurt	3832a8afd4	Fix noibat trade gender ... closes #1608	2017-11-15 08:23:45 -08:00
Kurt	5e6b2f43c2	Update wild/egg generators for totem cases ... so wonky edge cases	2017-11-14 08:43:04 -08:00
Kurt	8b5803781d	Add bewear location ... All static encounters have been found! Closes #1577	2017-11-13 20:50:10 -08:00
Kurt	4341dc1775	Add Galactic Key to usum key items permitted ... add zygarde cube reconstructs gifts, thanks @sora10pls !	2017-11-12 21:56:08 -08:00
Kurt	9b61c94402	Add ditto5 natures ... thanks @wwwwwwzx for pointing this out remove others that have encounter details forced (for totem battles)	2017-11-12 12:15:08 -08:00
Kurt	55c31cb598	Update encounters ... add ability locks for sm gifts add poipole secondary location add magearna details	2017-11-12 10:59:23 -08:00
Matt	6ecc7f2efb	Update USUM static encounter list	2017-11-12 12:08:48 -05:00
ReignOfComputer	0b95f7d4b8	Porygon/Zygarde/Trainer School Encounters	2017-11-12 22:29:21 +08:00
ReignOfComputer	f1e7c0f759	Hypno Trio Encounter at Hau'oli City PD	2017-11-12 18:33:06 +08:00
Kurt	dea70bf243	Add cosmog & zygarde gift locations ... thanks @architdate ! (thanks @bui for the pikachu!) porygon remains	2017-11-11 17:24:49 -08:00
Kurt	d674ea4f39	Add surf pikachu details ... Closes #1589 Thanks @PolarPeridot !	2017-11-11 17:16:31 -08:00
Kurt	5d90e9dc53	Refactoring ... check alolan forms for forme matching, break up large method to something a little more understandable.	2017-11-11 09:35:07 -08:00
Kurt	f5a6f23161	Add more static enc data ... clear out unused (highly certain) SM encounters add solgaleo/lunala locations add partner form pikachu	2017-11-10 19:43:31 -08:00
sora10pls	6cd2a08238	Fix Type: Null location	2017-11-10 13:19:47 -05:00
sora10pls	1d44c45fe0	Fix indenting	2017-11-10 13:16:43 -05:00
sora10pls	6f58698187	Add more static encounter locations	2017-11-10 13:08:36 -05:00
ReignOfComputer	7dd8dd970f	Normal Pokemon @ Ultra Space Wilds	2017-11-10 17:29:20 +08:00
ReignOfComputer	ec6e485c50	Sandygast @ Route 15	2017-11-10 13:14:18 +08:00
Kurt	23d57f8807	Add ditto5, necrozma ... fix tab for oras flag resource	2017-11-09 21:11:19 -08:00
Matt	c1de054c7f	Add several Ultra Warp Ride locations ... - Cresselia - Swanna - Drapion - Audino - Medicham - Magcargo - Quagsire	2017-11-09 20:27:14 -05:00
Kurt	4deb24cc95	Add gender locks ... lots of totems with fixed genders (not capturable), but some other slightly important ones needing enforcement.	2017-11-09 16:32:09 -08:00
Kurt	55820246cf	Misc tweaks ... mark SOS slots for usum, only permit varied alolan evos to be forme changed (blocks totem raticate from being matched to non totem forme inputs)	2017-11-09 16:18:30 -08:00
Matt	82a7502cf4	Add Poipole location	2017-11-09 19:10:11 -05:00
Matt	273231ad00	Add USUM Pinsir on Exeggutor Island locations	2017-11-09 16:56:10 -05:00
Kurt	ccdb84b851	update for some errors ... restore ekans values, re-add antishiny for yungoos set	2017-11-09 07:22:34 -08:00
Kurt	b615ef0057	Update static7 with more data	2017-11-09 07:17:36 -08:00
Kurt	ae0122254a	Add abilities & IV3 flags for usum gifts	2017-11-09 06:43:11 -08:00
sora10pls	38cbf160ec	Add Totem-Sized gift ability/version checks	2017-11-09 02:01:09 -05:00
Matt	a8000608f2	Add more USUM static encounter locations ... Totems @ Heahea Beach, Island Scan. Grovyle is Akala-Friday @ Route 5, as is Bellsprout in SM; assume locations were unchanged.	2017-11-08 22:56:13 -05:00
Kurt	115c611120	add surf to gift pikachu moveset ... only gift pkm with special move	2017-11-08 19:51:04 -08:00
Kurt	93b49928a0	add lvl/egg move tables for usum ... add a few met locations for static encounters, recognizes torracat with double kick correctly!	2017-11-08 19:31:07 -08:00
Kurt	93bd974249	Add EncounterStatic data ... sourced from Ultra Moon, location IDs are not known (need manual docs). Many of these may be unused, like last gen. Will eventually remove unused ones once crowdsourced effort finishes.	2017-11-08 18:43:55 -08:00
Kurt	800ba6cf90	encounter additions ... add ingame trade data add placeholder SOS data containers add refs to all wild encounters (pelago is same as sm) unmark some todo's	2017-11-08 15:07:04 -08:00
Kurt	f959179e1a	add more colo encounter locations ... dogs had hypothetical met locations, now fixed (y u so weird cxd) Closes #1556	2017-11-03 21:33:48 -07:00
Kurt	f48afaf12d	Switch slottype to flags ... simplifies some logic, adds some documentation, speeds up loading very slightly	2017-11-03 17:14:18 -07:00
Kurt	d7300ce68f	Cleanup ... add amoongus route22 encounter fix typos in comments resharper suggestions for recent pr	2017-11-02 21:37:28 -07:00
Kurt	495eb26740	Rework colo starter PIDIV detection ... force colo starters to be male only use some c# lang features for EncounterType flags add edge case PIDIV detection for starter gender/shiny lock scenario adds a little documentation for those unfamiliar with the NPC PKM generation quirks. Colosseum Starters will now be recognized with a different PIDIV type which is specific to them & them only.	2017-11-01 21:12:44 -07:00
Kurt	e9cebf933c	Fix headbutt encountertype fetch ... future improvement can be detecting when "none" is appropriate, but for now, whatever. Closes #1502	2017-10-29 20:19:49 -07:00
Kurt	da9e316cd8	Add rock smash encounter type flagging ... I don't believe rock smash (EncounterType 1) exists, tests at Route 19 and Vermillion yielded None & City. Closes #1379 Opens #1502	2017-10-29 19:17:53 -07:00
Kurt	3f533399f2	Simplify slot type loading ... instead of 2 similar methods, use params to achieve a flexible method for both situations isolate rock smash / headbutt type loading	2017-10-29 18:09:30 -07:00
Kurt	afde4514e2	Add realgam tower / deep colosseum locs ... sudowoodo & gsc dogs closes #1549 fix loading issue for abilities in gen3 format, copy the gen4 sanitization	2017-10-29 10:41:12 -07:00
Kurt	9ada593af9	add gen7 nick ot (trades) ... #1249 todo usum table when appropriate	2017-10-28 23:04:02 -07:00
Kurt	d2ebb6340e	Add gen5 nick/OT info (trades) ... #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.	2017-10-28 21:43:47 -07:00
Kurt	e4319fd929	Add gen3 nick/OT info ... #1249	2017-10-28 19:51:55 -07:00
Kurt	2c73e130af	Add gen4 nick/OT info ... #1249	2017-10-28 19:02:18 -07:00
Kurt	9d0b153eab	Add egg hatch suggestion for b2w2	2017-10-28 14:00:44 -07:00
Kurt	a401db608e	Split trade encounter nick/OT verification methods ... #1249	2017-10-28 13:15:51 -07:00
Kurt	0e9960909b	Refactor encountertype check to bitflags ... #1379 need to double check none permissive later	2017-10-27 23:57:21 -07:00
Kurt	00a4c1adf5	Add multilang c/xd ingame gifts ... save space by just using a loop closes #1529 , pokespot proc discussion relocated to associated issue (as previously noted in comments)	2017-10-25 21:53:55 -07:00
Kurt	a6ef105544	Update gen3/4 encounter generators ... revisit for simplification now that EncounterTrade matching is more precise (PID required to match). #1249	2017-10-24 22:25:52 -07:00
Kurt	59319a614a	Add PID values for Gen3/4 ingame trades ... #1249	2017-10-24 22:24:29 -07:00
Kurt	933bfba8e1	Misc cleanup ... check gen2 stadium names, use pkm.Japanese when favorable	2017-10-24 18:27:40 -07:00
Kurt	69cf1eaa9c	add more pkhex.core xml documentation ... adds a bunch of documentation useful for those unfamiliar with the core library	2017-10-23 23:12:58 -07:00
Kurt	60562fb44e	Use empty enumerable when appropriate ... no allocation == no pressure for garbage collector	2017-10-23 15:44:01 -07:00
Kurt	a03ac10fc5	Misc refactoring ... no functional change	2017-10-22 23:26:37 -07:00
Kurt	515a694afa	Add LanguageID enum ... no functional change, just less-magic-numbers for easier to understand src	2017-10-22 21:01:08 -07:00
Kurt	096f6bbd18	Add RANDY Gen2 ingame trade ... closes #1538 rename pid deferral to pidiv deferral for clarity	2017-10-22 10:41:27 -07:00
Kurt	c5b0ed6c35	Move encountertype deferral to main generator ... gen4->gen5/6 electrode will match static & wild slots, but deferral only defers within the same IEncounterable group.	2017-10-22 09:42:15 -07:00
Kurt	39279a7ad4	Add VC transfer checks ... checks were previously only performed when finding the encounter, once found, the GB encounter was validated. the transfer encounter is derived after all encounter checks, thus remaining unchecked (really, only for Locations). Move generating logic to the generator, and double check the locations are valid. #1535 Thanks @DJPanda065 !	2017-10-20 21:07:15 -07:00
Kurt	ae0bf5c75c	remove (None) egg gen4 hatch location	2017-10-19 22:00:31 -07:00
Kurt	a75614ed77	Modify eggmove fetch ... fetch is exclusively done with version already known; there are cases where version can change for eggs so it's safer this way. version change reference (gen6+): 212a489335	2017-10-19 21:20:47 -07:00
Kurt	a53e8ddb7e	Fix grotto mienfoo level range ... Thanks paf!	2017-10-18 21:16:52 -07:00
Kurt	5a09cd9122	Add deferral case for gen6 magmar classic ribbon ... use "when" for easy src code Thanks Nessus!	2017-10-18 18:28:17 -07:00
Kurt	4d91aad876	Flag gen2 egg moves when transferred from gen1 ... move must be removed 2->1 so cannot be permitted as egg move. remove unreachable code (ParseMovesRelearn only is called for Generation >= 6, and thus Format != 2).	2017-10-16 17:24:19 -07:00
Kurt	b63e444e15	Add hatch location check for static egg gifts ... to match mysterygift check	2017-10-08 14:48:35 -07:00
Kurt	c7dfc3d9b0	Cleanup ... union / count usages remove unnecessary stuff	2017-10-06 21:03:23 -07:00
Kurt	a816f4cea6	Misc event egg tweaks ... Thanks Kirzi!	2017-10-05 23:13:48 -07:00
wwwwwwzx	384605b127	Misc gen1/gen2 fixes ... - G1/G2 only have Hiragana letter he -> fixed Houndoom(ヘルガー) /Heracross (ヘラクロス) default name mismatch - Fixed Stadium2 Farfetch'd move (Thrash -> Slash) - Added VC Mew TID check - Update Chinese legality strings	2017-10-04 00:14:50 -07:00
Kurt	593f31ff02	hashset contains over array contains ... faster++, reduces some linq ToArray() allocations	2017-09-30 14:08:35 -07:00
Kurt	3552e6396c	Move pidivmatches check outside secondary check ... gen3/4 generators auto-defer bad PIDIVs to end, so no need to keep skipping to the very end	2017-09-30 13:42:57 -07:00
Kurt	1e377c2963	interpolation++ ... no functional change (assumed)	2017-09-29 22:58:25 -07:00
Kurt	212a489335	Add gen6+ link trade egg edge case ... slakoth with play rough with x/y version why u modify game origin when hatched???	2017-09-28 17:11:30 -07:00
Kurt	a52f88dd5c	Add ice punch feraligatr non-relearn link gift move ... Thanks cicciochiave!	2017-09-27 08:32:35 -07:00
Kurt	9699cdefae	Gen2 egg gift bypass fix ... Gen4+ static encounter eggs could slide through the VC case prevent empty moves from appearing before suggested moves (relearnbase being empty)	2017-09-26 20:09:18 -07:00
Kurt	1b354624b1	Korean move validation fixes ... Korean g/s cannot access gen1 movesets, so pruning gen1 was necessary. Rather than rebuilding the array (slow), just futureproof the entire method to not rely on '7' (in case this code is ever used on Gen8).	2017-09-24 10:52:39 -07:00
Kurt	16341b4d91	Add SPA/ENG Oct16 Diancie collision handling ... Card 0525 was accidentally uploaded without the 3 flawless IVs setting; sometimes when the internal event binary is built, the 3IV card comes before the 0IV. Play favorites with the 0IV.	2017-09-23 17:11:19 -07:00
Kurt	7974943bcf	Refactoring ... slight simplification related to #1486	2017-09-23 16:24:22 -07:00
javierhimura	f3743e490b	Korean language restrictions ... Restriction happens because Korean can not trade with non-Korean GB era games - There is no Korean release for gen 1 pokemon, included VC - With no gen1 pokemon means any Korean gen2 is Gen2_NotTradeback, that means no gen1 origin nor moves are Legal - Crystal was never released in Korean - Pokemon Stadium 2 was never released in Korean, that means no move reminder for gen 2 korean pokemon - Generation 4 can not trade between Korean and not Korean games, but Korean games can use the palpark with any language Chinese language restrictions There is no Chinese release for gen 1 and 2 pokemon games, VC Chinese games are in Japanese	2017-09-23 20:46:10 +02:00
Kurt	496da9e4ab	Add ranch ingame trades ... debut of the long awaited EncounterTradePID class gist to generate trades from folder (using LINQPad): https://gist.github.com/kwsch/d778f1f63e4c393e5440dfb0e14cfcc3 Closes #1458 , although Mew/Phione's PIDIV method is unknown.	2017-09-20 21:28:29 -07:00
Kurt	69e8c071f7	Misc tweaks (apostrophe & vc2 pre) ... farfetch'd apostrophe mapping disabled for gen5 and prior Closes #1474 flag gen2 new moves as not obtainable if transferred from RBY (VC1) as they must be removed before transferring 2->1.	2017-09-20 16:19:50 -07:00
Kurt	1149845db5	Misc database fixes ... Initialize move array for WC3 if none are present Closes #1472 More gracefully handle invalid version pkms in a given format (gen5 origin version pkm on gen4 format no longer throws an exception).	2017-09-20 09:04:30 -07:00
Kurt	b63e53af95	misc tweaks ... no functional changes	2017-09-19 23:19:22 -07:00
Kurt	ddb496692d	Fix yellow starter pikachu catch rate check ... Closes #1470	2017-09-19 22:55:05 -07:00
Kurt	c23cc81212	More usum prep ... I think egg hatch location checking is wrong for traded eggs (see gen3 vs future games, origin game shouldn't change but could hatch ORAS egg on XY at XY location?)	2017-09-19 21:35:30 -07:00
Kurt	eafc28422e	Misc gen4 handling updates ... Cross-game trading for egg locations (duh) Volt Tackle AND Fakeout pikachu from yellow forest Nidoran fullwidth handling in gen4 Thanks Britty! https://projectpokemon.org/home/forums/topic/41407-pkhex-legality-errors-on-gen-6-updated/?do=findComment&comment=220094 Replicate gen4's string setter for the bigendian variant	2017-09-16 09:58:06 -07:00
Kurt	aa3393e5b2	Misc languageID legality checking update ... Checks for max language ID on transferred pkm (gen5 pkm on gen7 can't have CHS/CHT etc) handles edge case for JPN B/W ingame trades update pk5->pk6 transfer logic to bump langID 0 to 1. Thanks HaxAras & Britty for providing samples!	2017-09-15 17:43:31 -07:00
Kurt	5665481cab	Reduce machoke trade minlvl gen1 ... Thanks Mewtwo! https://projectpokemon.org/home/forums/topic/41636-ricky-machamp-unable-to-match-encounter https://bulbapedia.bulbagarden.net/wiki/Kanto_Safari_Zone	2017-09-15 06:42:00 -07:00
Kurt	387d9375c3	Refactor split gender breeding logic ... Inherit Levelup moves & hidden ability (gen5) issues addressed	2017-09-14 18:52:34 -07:00
Kurt	1769bcd306	Add no-deferred early break for gen3 ... c627a86f said it added for both 3 & 4, but was only added for gen4.	2017-09-09 19:27:28 -07:00
Kurt	fd2da22d3a	Update PKMConverter internals ... [insert lenny face here]	2017-09-07 23:18:04 -07:00
Kurt	f78e017e47	Fix GSC table loading ... Was ignoring G/S slots (only had crystal) thus some special G/S encounters (underleveled examples being Magmar lvl14) were not recognized. Thanks HaxAras! https://projectpokemon.org/forums/forums/topic/41579-pokemon-silver-under-leveled-pokemon-flagged-as-illegal/	2017-09-06 20:03:36 -07:00
Kurt	76ff629006	Flag invalid nsparkle ... previously would only flag if it was missing on npokemon also fix gen5 traded egg locations move egg ribbon verification to the new class	2017-09-05 20:32:07 -07:00
Kurt	47ca69f92b	Legality edge case fixes ... Some incorrect IDs, some additions (unbreedable hidden abilities in genV) https://projectpokemon.org/forums/forums/topic/41407-pkhex-legality-errors-on-gen-6-updated/?tab=comments#comment-219459	2017-09-05 18:28:38 -07:00
Kurt	6fe926d1f6	Refactoring ... readability++	2017-09-04 13:48:10 -07:00
Kurt	0b4e6a0733	Refactoring ... relocate ribbon checks/class to more focused location reduce amount of GenNumber checks (use stored Generation value instead)	2017-09-03 19:51:29 -07:00
Kurt	6589869b35	More refactoring ... simplify some expressions, reduce repeat operations	2017-09-01 23:45:47 -07:00
Kurt	d1aa02fb31	Refactoring ... split up current move parsing a little	2017-09-01 23:15:57 -07:00
Kurt	84c90e973e	usum prep ... Copied binaries from sm, references set up for saving time later I assume not much will change in terms of structures, so it should just be a file replacement & filling in static encounter table => 'working' legality checks	2017-08-31 22:37:28 -07:00
Kurt	578ab137e2	Refactoring ... Flag Korean Ranger Manaphy (never distributed) extract pk1 catch rate verification	2017-08-30 21:30:07 -07:00
Kurt	072f1ba83d	Refactor level-evolution checks slightly ... Allows evolution met level check to be skipped Adds minimum level constraint for evolution chain generating Closes #1430 also adds deferral to the gen3 encounter generator as encounterstatic gifts can collide with wild encounters when transferred	2017-08-28 18:12:57 -07:00
Kurt	c627a86f8c	Fix g4 move tutor lookup ... personalinfo setup wasn't populating info for form indexes remove erroneous pid-type mismatch message on gen3/4 non-matching if there are no deferred encounters	2017-08-27 11:04:31 -07:00
Kurt	a62e2a95ad	Invert PCD return value on match ... Result of refactoring and manually flipping all the returns Closes #1421	2017-08-25 17:29:14 -07:00
javierhimura	f889a6ce7f	Fix generation 1/2 encounters for pokemon with different initial moves in yellow/crystal than r/b/g/s ... The encounter generator was returning always RBY and GSC and that make the ParseMovesGenGB to check only for rb and gs learnset for initial moves, the game returned should be the game for the encounter to make ParseMovesGenGB use the correct learnset table for the initial moves Closes #1417	2017-08-25 16:25:59 +02:00