Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-18 16:33:24 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/PKM/PK7.cs

658 lines
42 KiB
C#
Raw Normal View History

Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
using System;
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
using System.Collections.Generic;
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
Split winforms to separate project resources still are associated with winforms, eh program still runs fine and I've replicated the mono build options. lmk if this breaks stuff
2017-01-08 07:54:09 +00:00
namespace PKHeX.Core
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
{
add more pkhex.core xml documentation adds a bunch of documentation useful for those unfamiliar with the core library
2017-10-24 06:12:58 +00:00
/// <summary> Generation 7 <see cref="PKM"/> format. </summary>
Add alcremie formArg gui Closes #2538 Standardize nomenclature as FormArgument, add interface for those exposing the property.
2019-11-29 18:44:52 +00:00
public sealed class PK7 : G6PKM, IRibbonSetEvent3, IRibbonSetEvent4, IRibbonSetCommon3, IRibbonSetCommon4, IRibbonSetCommon6, IRibbonSetCommon7, IContestStats, IHyperTrain, IGeoTrack, ISuperTrain, IFormArgument
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
{
Sword/Shield Update
2019-11-16 01:34:18 +00:00
private static readonly ushort[] Unused =
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
{
Misc refactoring more usum prep don't allocate empty array on every savefile creation (use linq All comparison) add percent seen/caught savefile properties for data analysis purposes
2017-10-31 16:24:54 +00:00
0x2A, // Old Marking Value (PelagoEventStatus)
Add placeholder strings Still need to add met location information
2016-10-25 03:05:22 +00:00
// 0x36, 0x37, // Unused Ribbons
Update unused byte usage knowledge DistByte is actually 16bits; no point changing the name. The 32bits afterwards are form duration (Hoopa/Furfrou only), and only exist while the PKM is in the player's party. The game sets an initial value with days to exist in the form before reverting (probably on game restart), checking the delta between days saved. Either way, just set a base value when writing it to the party, else clear the value if it is not supposed to be used. Thanks @SciresM !
2017-06-07 05:13:12 +00:00
0x58, 0x59, 0x73, 0x90, 0x91, 0x9E, 0x9F, 0xA0, 0xA1, 0xA7, 0xAA, 0xAB, 0xAC, 0xAD, 0xC8, 0xC9, 0xD7, 0xE4, 0xE5, 0xE6, 0xE7
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
};
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Sword/Shield Update
2019-11-16 01:34:18 +00:00
public override IReadOnlyList<ushort> ExtraBytes => Unused;
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override int Format => 7;
more usum prep species added requires the 'latest personal table' reference to be USUM's; the other referencs for .SM are fine as there's no possibility to have a species ID high enough for it to matter.
2017-09-19 05:36:06 +00:00
public override PersonalInfo PersonalInfo => PersonalTable.USUM.GetFormeEntry(Species, AltForm);
Add personalinfo references per PKM format Fix possible hang in pk6/pk7 if country/region is unset (continues loop). PersonalInfo references are not to be used when calculating stats (use the savefile table instead)
2016-10-24 05:01:39 +00:00
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
public override byte[] Data { get; }
Split PokeCrypto from PKX All logic in PokeCrypto is separate from the rest of the PKHeX.Core library; makes it easy to just rip this portion out and reuse in other projects without needing the entirety of PKHeX.Core logic optimize out the CheckEncrypted to the actual path, separate methods. Only usages of this method were with hardcoded Format values, so no impact
2020-01-04 22:48:39 +00:00
public PK7() => Data = new byte[PokeCrypto.SIZE_6PARTY];
Add parameter-less constructors Removes null check for hot path where data is actually provided
2018-11-21 22:15:48 +00:00
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
public PK7(byte[] data)
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
{
Split PokeCrypto from PKX All logic in PokeCrypto is separate from the rest of the PKHeX.Core library; makes it easy to just rip this portion out and reuse in other projects without needing the entirety of PKHeX.Core logic optimize out the CheckEncrypted to the actual path, separate methods. Only usages of this method were with hardcoded Format values, so no impact
2020-01-04 22:48:39 +00:00
PokeCrypto.DecryptIfEncrypted67(ref data);
if (data.Length != PokeCrypto.SIZE_6PARTY)
Array.Resize(ref data, PokeCrypto.SIZE_6PARTY);
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
Data = data;
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Simplify pkm constructors remove Identifier param. 99% of the time, identifier is not provided, resulting in a useless call end result: provide 'create new' and 'create from' constructors
2019-03-17 01:41:56 +00:00
public override PKM Clone() => new PK7((byte[])Data.Clone()){Identifier = Identifier};
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
Convert chinese string only if species name Resolves charmap duplications in the chinese char tables: 多边兽Ｚ (Porygon-Z) 属性：空 (Type Null) 谜拟Ｑ (Mimikyu) 卡璞・鸣鸣 (Tapu-Koko) Games cannot have a nickname/OT in chinese as of current date... I assume this will be fixed down the road
2017-10-04 01:15:15 +00:00
private string GetString(int Offset, int Count) => StringConverter.GetString7(Data, Offset, Count);
private byte[] SetString(string value, int maxLength, bool chinese = false) => StringConverter.SetString7(value, maxLength, Language, chinese: chinese);
String editing refactor Move all sanitization operations from PK* and SAV* to PKX; add general method for fetching a generation specific string Changes the Text subform editor to show trash bytes when appropriate. Special characters to be shown can be easily inserted in the future.
2017-04-09 21:06:50 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
// Structure
#region Block A
public override uint EncryptionConstant
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt32(Data, 0x00);
set => BitConverter.GetBytes(value).CopyTo(Data, 0x00);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override ushort Sanity
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt16(Data, 0x04);
set => BitConverter.GetBytes(value).CopyTo(Data, 0x04);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override ushort Checksum
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt16(Data, 0x06);
set => BitConverter.GetBytes(value).CopyTo(Data, 0x06);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override int Species
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt16(Data, 0x08);
set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x08);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override int HeldItem
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt16(Data, 0x0A);
set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x0A);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override int TID
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt16(Data, 0x0C);
set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x0C);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override int SID
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt16(Data, 0x0E);
set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x0E);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override uint EXP
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt32(Data, 0x10);
set => BitConverter.GetBytes(value).CopyTo(Data, 0x10);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int Ability { get => Data[0x14]; set => Data[0x14] = (byte)value; }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public override int AbilityNumber { get => Data[0x15] & 7; set => Data[0x15] = (byte)((Data[0x15] & ~7) | (value & 7)); }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int MarkValue { get => BitConverter.ToUInt16(Data, 0x16); protected set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x16); }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override uint PID
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt32(Data, 0x18);
set => BitConverter.GetBytes(value).CopyTo(Data, 0x18);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int Nature { get => Data[0x1C]; set => Data[0x1C] = (byte)value; }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public override bool FatefulEncounter { get => (Data[0x1D] & 1) == 1; set => Data[0x1D] = (byte)((Data[0x1D] & ~0x01) | (value ? 1 : 0)); }
public override int Gender { get => (Data[0x1D] >> 1) & 0x3; set => Data[0x1D] = (byte)((Data[0x1D] & ~0x06) | (value << 1)); }
public override int AltForm { get => Data[0x1D] >> 3; set => Data[0x1D] = (byte)((Data[0x1D] & 0x07) | (value << 3)); }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int EV_HP { get => Data[0x1E]; set => Data[0x1E] = (byte)value; }
public override int EV_ATK { get => Data[0x1F]; set => Data[0x1F] = (byte)value; }
public override int EV_DEF { get => Data[0x20]; set => Data[0x20] = (byte)value; }
public override int EV_SPE { get => Data[0x21]; set => Data[0x21] = (byte)value; }
public override int EV_SPA { get => Data[0x22]; set => Data[0x22] = (byte)value; }
public override int EV_SPD { get => Data[0x23]; set => Data[0x23] = (byte)value; }
Simplify IContestStats usage remove new[] creating for checking if any contest stats exist (HasContestStats)
2018-06-03 04:19:03 +00:00
public int CNT_Cool { get => Data[0x24]; set => Data[0x24] = (byte)value; }
public int CNT_Beauty { get => Data[0x25]; set => Data[0x25] = (byte)value; }
public int CNT_Cute { get => Data[0x26]; set => Data[0x26] = (byte)value; }
public int CNT_Smart { get => Data[0x27]; set => Data[0x27] = (byte)value; }
public int CNT_Tough { get => Data[0x28]; set => Data[0x28] = (byte)value; }
public int CNT_Sheen { get => Data[0x29]; set => Data[0x29] = (byte)value; }
Add pelago status value check + etc 0, [9,19] are set (didn't see 15), but there's also a switch case which references all values 0-19. these values are used by a 80 sbyte array (4*20) in the Resort.cro remove usages of "goto case"
2018-08-28 03:44:26 +00:00
public byte ResortEventStatus { get => Data[0x2A]; set => Data[0x2A] = value; }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
private byte PKRS { get => Data[0x2B]; set => Data[0x2B] = value; }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public override int PKRS_Days { get => PKRS & 0xF; set => PKRS = (byte)((PKRS & ~0xF) | value); }
public override int PKRS_Strain { get => PKRS >> 4; set => PKRS = (byte)((PKRS & 0xF) | value << 4); }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
private byte ST1 { get => Data[0x2C]; set => Data[0x2C] = value; }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public bool Unused0 { get => (ST1 & (1 << 0)) == 1 << 0; set => ST1 = (byte)((ST1 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public bool Unused1 { get => (ST1 & (1 << 1)) == 1 << 1; set => ST1 = (byte)((ST1 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public bool SuperTrain1_SPA { get => (ST1 & (1 << 2)) == 1 << 2; set => ST1 = (byte)((ST1 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public bool SuperTrain1_HP { get => (ST1 & (1 << 3)) == 1 << 3; set => ST1 = (byte)((ST1 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public bool SuperTrain1_ATK { get => (ST1 & (1 << 4)) == 1 << 4; set => ST1 = (byte)((ST1 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public bool SuperTrain1_SPD { get => (ST1 & (1 << 5)) == 1 << 5; set => ST1 = (byte)((ST1 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public bool SuperTrain1_SPE { get => (ST1 & (1 << 6)) == 1 << 6; set => ST1 = (byte)((ST1 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public bool SuperTrain1_DEF { get => (ST1 & (1 << 7)) == 1 << 7; set => ST1 = (byte)((ST1 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
private byte ST2 { get => Data[0x2D]; set => Data[0x2D] = value; }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public bool SuperTrain2_SPA { get => (ST2 & (1 << 0)) == 1 << 0; set => ST2 = (byte)((ST2 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public bool SuperTrain2_HP { get => (ST2 & (1 << 1)) == 1 << 1; set => ST2 = (byte)((ST2 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public bool SuperTrain2_ATK { get => (ST2 & (1 << 2)) == 1 << 2; set => ST2 = (byte)((ST2 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public bool SuperTrain2_SPD { get => (ST2 & (1 << 3)) == 1 << 3; set => ST2 = (byte)((ST2 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public bool SuperTrain2_SPE { get => (ST2 & (1 << 4)) == 1 << 4; set => ST2 = (byte)((ST2 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public bool SuperTrain2_DEF { get => (ST2 & (1 << 5)) == 1 << 5; set => ST2 = (byte)((ST2 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public bool SuperTrain3_SPA { get => (ST2 & (1 << 6)) == 1 << 6; set => ST2 = (byte)((ST2 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public bool SuperTrain3_HP { get => (ST2 & (1 << 7)) == 1 << 7; set => ST2 = (byte)((ST2 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
private byte ST3 { get => Data[0x2E]; set => Data[0x2E] = value; }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public bool SuperTrain3_ATK { get => (ST3 & (1 << 0)) == 1 << 0; set => ST3 = (byte)((ST3 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public bool SuperTrain3_SPD { get => (ST3 & (1 << 1)) == 1 << 1; set => ST3 = (byte)((ST3 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public bool SuperTrain3_SPE { get => (ST3 & (1 << 2)) == 1 << 2; set => ST3 = (byte)((ST3 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public bool SuperTrain3_DEF { get => (ST3 & (1 << 3)) == 1 << 3; set => ST3 = (byte)((ST3 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public bool SuperTrain4_1 { get => (ST3 & (1 << 4)) == 1 << 4; set => ST3 = (byte)((ST3 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public bool SuperTrain5_1 { get => (ST3 & (1 << 5)) == 1 << 5; set => ST3 = (byte)((ST3 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public bool SuperTrain5_2 { get => (ST3 & (1 << 6)) == 1 << 6; set => ST3 = (byte)((ST3 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public bool SuperTrain5_3 { get => (ST3 & (1 << 7)) == 1 << 7; set => ST3 = (byte)((ST3 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
private byte ST4 { get => Data[0x2F]; set => Data[0x2F] = value; }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public bool SuperTrain5_4 { get => (ST4 & (1 << 0)) == 1 << 0; set => ST4 = (byte)((ST4 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public bool SuperTrain6_1 { get => (ST4 & (1 << 1)) == 1 << 1; set => ST4 = (byte)((ST4 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public bool SuperTrain6_2 { get => (ST4 & (1 << 2)) == 1 << 2; set => ST4 = (byte)((ST4 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public bool SuperTrain6_3 { get => (ST4 & (1 << 3)) == 1 << 3; set => ST4 = (byte)((ST4 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public bool SuperTrain7_1 { get => (ST4 & (1 << 4)) == 1 << 4; set => ST4 = (byte)((ST4 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public bool SuperTrain7_2 { get => (ST4 & (1 << 5)) == 1 << 5; set => ST4 = (byte)((ST4 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public bool SuperTrain7_3 { get => (ST4 & (1 << 6)) == 1 << 6; set => ST4 = (byte)((ST4 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public bool SuperTrain8_1 { get => (ST4 & (1 << 7)) == 1 << 7; set => ST4 = (byte)((ST4 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
public uint SuperTrainBitFlags { get => BitConverter.ToUInt32(Data, 0x2C); set => BitConverter.GetBytes(value).CopyTo(Data); }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
private byte RIB0 { get => Data[0x30]; set => Data[0x30] = value; } // Ribbons are read as uints, but let's keep them per byte.
private byte RIB1 { get => Data[0x31]; set => Data[0x31] = value; }
private byte RIB2 { get => Data[0x32]; set => Data[0x32] = value; }
private byte RIB3 { get => Data[0x33]; set => Data[0x33] = value; }
private byte RIB4 { get => Data[0x34]; set => Data[0x34] = value; }
private byte RIB5 { get => Data[0x35]; set => Data[0x35] = value; }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
private byte RIB6 { get => Data[0x36]; set => Data[0x36] = value; }
//private byte RIB7 { get => Data[0x37]; set => Data[0x37] = value; } // Unused
public bool RibbonChampionKalos { get => (RIB0 & (1 << 0)) == 1 << 0; set => RIB0 = (byte)((RIB0 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public bool RibbonChampionG3Hoenn { get => (RIB0 & (1 << 1)) == 1 << 1; set => RIB0 = (byte)((RIB0 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public bool RibbonChampionSinnoh { get => (RIB0 & (1 << 2)) == 1 << 2; set => RIB0 = (byte)((RIB0 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public bool RibbonBestFriends { get => (RIB0 & (1 << 3)) == 1 << 3; set => RIB0 = (byte)((RIB0 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public bool RibbonTraining { get => (RIB0 & (1 << 4)) == 1 << 4; set => RIB0 = (byte)((RIB0 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public bool RibbonBattlerSkillful { get => (RIB0 & (1 << 5)) == 1 << 5; set => RIB0 = (byte)((RIB0 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public bool RibbonBattlerExpert { get => (RIB0 & (1 << 6)) == 1 << 6; set => RIB0 = (byte)((RIB0 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public bool RibbonEffort { get => (RIB0 & (1 << 7)) == 1 << 7; set => RIB0 = (byte)((RIB0 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
public bool RibbonAlert { get => (RIB1 & (1 << 0)) == 1 << 0; set => RIB1 = (byte)((RIB1 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public bool RibbonShock { get => (RIB1 & (1 << 1)) == 1 << 1; set => RIB1 = (byte)((RIB1 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public bool RibbonDowncast { get => (RIB1 & (1 << 2)) == 1 << 2; set => RIB1 = (byte)((RIB1 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public bool RibbonCareless { get => (RIB1 & (1 << 3)) == 1 << 3; set => RIB1 = (byte)((RIB1 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public bool RibbonRelax { get => (RIB1 & (1 << 4)) == 1 << 4; set => RIB1 = (byte)((RIB1 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public bool RibbonSnooze { get => (RIB1 & (1 << 5)) == 1 << 5; set => RIB1 = (byte)((RIB1 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public bool RibbonSmile { get => (RIB1 & (1 << 6)) == 1 << 6; set => RIB1 = (byte)((RIB1 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public bool RibbonGorgeous { get => (RIB1 & (1 << 7)) == 1 << 7; set => RIB1 = (byte)((RIB1 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
public bool RibbonRoyal { get => (RIB2 & (1 << 0)) == 1 << 0; set => RIB2 = (byte)((RIB2 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public bool RibbonGorgeousRoyal { get => (RIB2 & (1 << 1)) == 1 << 1; set => RIB2 = (byte)((RIB2 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public bool RibbonArtist { get => (RIB2 & (1 << 2)) == 1 << 2; set => RIB2 = (byte)((RIB2 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public bool RibbonFootprint { get => (RIB2 & (1 << 3)) == 1 << 3; set => RIB2 = (byte)((RIB2 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public bool RibbonRecord { get => (RIB2 & (1 << 4)) == 1 << 4; set => RIB2 = (byte)((RIB2 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public bool RibbonLegend { get => (RIB2 & (1 << 5)) == 1 << 5; set => RIB2 = (byte)((RIB2 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public bool RibbonCountry { get => (RIB2 & (1 << 6)) == 1 << 6; set => RIB2 = (byte)((RIB2 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public bool RibbonNational { get => (RIB2 & (1 << 7)) == 1 << 7; set => RIB2 = (byte)((RIB2 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
public bool RibbonEarth { get => (RIB3 & (1 << 0)) == 1 << 0; set => RIB3 = (byte)((RIB3 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public bool RibbonWorld { get => (RIB3 & (1 << 1)) == 1 << 1; set => RIB3 = (byte)((RIB3 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public bool RibbonClassic { get => (RIB3 & (1 << 2)) == 1 << 2; set => RIB3 = (byte)((RIB3 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public bool RibbonPremier { get => (RIB3 & (1 << 3)) == 1 << 3; set => RIB3 = (byte)((RIB3 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public bool RibbonEvent { get => (RIB3 & (1 << 4)) == 1 << 4; set => RIB3 = (byte)((RIB3 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public bool RibbonBirthday { get => (RIB3 & (1 << 5)) == 1 << 5; set => RIB3 = (byte)((RIB3 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public bool RibbonSpecial { get => (RIB3 & (1 << 6)) == 1 << 6; set => RIB3 = (byte)((RIB3 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public bool RibbonSouvenir { get => (RIB3 & (1 << 7)) == 1 << 7; set => RIB3 = (byte)((RIB3 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
public bool RibbonWishing { get => (RIB4 & (1 << 0)) == 1 << 0; set => RIB4 = (byte)((RIB4 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public bool RibbonChampionBattle { get => (RIB4 & (1 << 1)) == 1 << 1; set => RIB4 = (byte)((RIB4 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public bool RibbonChampionRegional { get => (RIB4 & (1 << 2)) == 1 << 2; set => RIB4 = (byte)((RIB4 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public bool RibbonChampionNational { get => (RIB4 & (1 << 3)) == 1 << 3; set => RIB4 = (byte)((RIB4 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public bool RibbonChampionWorld { get => (RIB4 & (1 << 4)) == 1 << 4; set => RIB4 = (byte)((RIB4 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
Sword/Shield Update
2019-11-16 01:34:18 +00:00
public bool HasContestMemoryRibbon { get => (RIB4 & (1 << 5)) == 1 << 5; set => RIB4 = (byte)((RIB4 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public bool HasBattleMemoryRibbon { get => (RIB4 & (1 << 6)) == 1 << 6; set => RIB4 = (byte)((RIB4 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public bool RibbonChampionG6Hoenn { get => (RIB4 & (1 << 7)) == 1 << 7; set => RIB4 = (byte)((RIB4 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
public bool RibbonContestStar { get => (RIB5 & (1 << 0)) == 1 << 0; set => RIB5 = (byte)((RIB5 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public bool RibbonMasterCoolness { get => (RIB5 & (1 << 1)) == 1 << 1; set => RIB5 = (byte)((RIB5 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public bool RibbonMasterBeauty { get => (RIB5 & (1 << 2)) == 1 << 2; set => RIB5 = (byte)((RIB5 & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public bool RibbonMasterCuteness { get => (RIB5 & (1 << 3)) == 1 << 3; set => RIB5 = (byte)((RIB5 & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public bool RibbonMasterCleverness { get => (RIB5 & (1 << 4)) == 1 << 4; set => RIB5 = (byte)((RIB5 & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public bool RibbonMasterToughness { get => (RIB5 & (1 << 5)) == 1 << 5; set => RIB5 = (byte)((RIB5 & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public bool RibbonChampionAlola { get => (RIB5 & (1 << 6)) == 1 << 6; set => RIB5 = (byte)((RIB5 & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public bool RibbonBattleRoyale { get => (RIB5 & (1 << 7)) == 1 << 7; set => RIB5 = (byte)((RIB5 & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
public bool RibbonBattleTreeGreat { get => (RIB6 & (1 << 0)) == 1 << 0; set => RIB6 = (byte)((RIB6 & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public bool RibbonBattleTreeMaster { get => (RIB6 & (1 << 1)) == 1 << 1; set => RIB6 = (byte)((RIB6 & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public bool RIB6_2 { get => (RIB6 & (1 << 2)) == 1 << 2; set => RIB6 = (byte)((RIB6 & ~(1 << 2)) | (value ? 1 << 2 : 0)); } // Unused
public bool RIB6_3 { get => (RIB6 & (1 << 3)) == 1 << 3; set => RIB6 = (byte)((RIB6 & ~(1 << 3)) | (value ? 1 << 3 : 0)); } // Unused
public bool RIB6_4 { get => (RIB6 & (1 << 4)) == 1 << 4; set => RIB6 = (byte)((RIB6 & ~(1 << 4)) | (value ? 1 << 4 : 0)); } // Unused
public bool RIB6_5 { get => (RIB6 & (1 << 5)) == 1 << 5; set => RIB6 = (byte)((RIB6 & ~(1 << 5)) | (value ? 1 << 5 : 0)); } // Unused
public bool RIB6_6 { get => (RIB6 & (1 << 6)) == 1 << 6; set => RIB6 = (byte)((RIB6 & ~(1 << 6)) | (value ? 1 << 6 : 0)); } // Unused
public bool RIB6_7 { get => (RIB6 & (1 << 7)) == 1 << 7; set => RIB6 = (byte)((RIB6 & ~(1 << 7)) | (value ? 1 << 7 : 0)); } // Unused
Sword/Shield Update
2019-11-16 01:34:18 +00:00
public int RibbonCountMemoryContest { get => Data[0x38]; set => HasContestMemoryRibbon = (Data[0x38] = (byte)value) != 0; }
public int RibbonCountMemoryBattle { get => Data[0x39]; set => HasBattleMemoryRibbon = (Data[0x39] = (byte)value) != 0; }
Update unused byte usage knowledge DistByte is actually 16bits; no point changing the name. The 32bits afterwards are form duration (Hoopa/Furfrou only), and only exist while the PKM is in the player's party. The game sets an initial value with days to exist in the form before reverting (probably on game restart), checking the delta between days saved. Either way, just set a base value when writing it to the party, else clear the value if it is not supposed to be used. Thanks @SciresM !
2017-06-07 05:13:12 +00:00
private ushort DistByte { get => BitConverter.ToUInt16(Data, 0x3A); set => BitConverter.GetBytes(value).CopyTo(Data, 0x3A); }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public bool DistSuperTrain1 { get => (DistByte & (1 << 0)) == 1 << 0; set => DistByte = (byte)((DistByte & ~(1 << 0)) | (value ? 1 << 0 : 0)); }
public bool DistSuperTrain2 { get => (DistByte & (1 << 1)) == 1 << 1; set => DistByte = (byte)((DistByte & ~(1 << 1)) | (value ? 1 << 1 : 0)); }
public bool DistSuperTrain3 { get => (DistByte & (1 << 2)) == 1 << 2; set => DistByte = (byte)((DistByte & ~(1 << 2)) | (value ? 1 << 2 : 0)); }
public bool DistSuperTrain4 { get => (DistByte & (1 << 3)) == 1 << 3; set => DistByte = (byte)((DistByte & ~(1 << 3)) | (value ? 1 << 3 : 0)); }
public bool DistSuperTrain5 { get => (DistByte & (1 << 4)) == 1 << 4; set => DistByte = (byte)((DistByte & ~(1 << 4)) | (value ? 1 << 4 : 0)); }
public bool DistSuperTrain6 { get => (DistByte & (1 << 5)) == 1 << 5; set => DistByte = (byte)((DistByte & ~(1 << 5)) | (value ? 1 << 5 : 0)); }
public bool Dist7 { get => (DistByte & (1 << 6)) == 1 << 6; set => DistByte = (byte)((DistByte & ~(1 << 6)) | (value ? 1 << 6 : 0)); }
public bool Dist8 { get => (DistByte & (1 << 7)) == 1 << 7; set => DistByte = (byte)((DistByte & ~(1 << 7)) | (value ? 1 << 7 : 0)); }
Add alcremie formArg gui Closes #2538 Standardize nomenclature as FormArgument, add interface for those exposing the property.
2019-11-29 18:44:52 +00:00
public uint FormArgument { get => BitConverter.ToUInt32(Data, 0x3C); set => BitConverter.GetBytes(value).CopyTo(Data, 0x3C); }
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
#endregion
#region Block B
nickname edge case evolved on a foreign language can't rely on stored language ID, have to detect it
2017-10-04 02:21:17 +00:00
public override string Nickname
{
get => GetString(0x40, 24);
set
{
if (!IsNicknamed)
{
Extract logic from PKX Extract Species Name logic to SpeciesName Extract Language logic to Language Remove FormConverter wrapper for string[] fetch Rearrange some logic to more appropriate locations, update access modifiers / types Move some pkm array methods to arrayutil, make generic PKX.GetVCLanguage was a dupe of _K12.GuessedLanguage() so just expose the method PKX is now back to pkm data manip only
2019-09-19 02:58:23 +00:00
int lang = SpeciesName.GetSpeciesNameLanguage(Species, Language, value, 7);
if (lang == (int)LanguageID.ChineseS || lang == (int)LanguageID.ChineseT)
nickname edge case evolved on a foreign language can't rely on stored language ID, have to detect it
2017-10-04 02:21:17 +00:00
{
StringConverter.SetString7(value, 12, lang, chinese: true).CopyTo(Data, 0x40);
return;
}
}
SetString(value, 12).CopyTo(Data, 0x40);
}
}
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override int Move1
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt16(Data, 0x5A);
set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x5A);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override int Move2
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt16(Data, 0x5C);
set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x5C);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override int Move3
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt16(Data, 0x5E);
set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x5E);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override int Move4
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt16(Data, 0x60);
set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x60);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int Move1_PP { get => Data[0x62]; set => Data[0x62] = (byte)value; }
public override int Move2_PP { get => Data[0x63]; set => Data[0x63] = (byte)value; }
public override int Move3_PP { get => Data[0x64]; set => Data[0x64] = (byte)value; }
public override int Move4_PP { get => Data[0x65]; set => Data[0x65] = (byte)value; }
public override int Move1_PPUps { get => Data[0x66]; set => Data[0x66] = (byte)value; }
public override int Move2_PPUps { get => Data[0x67]; set => Data[0x67] = (byte)value; }
public override int Move3_PPUps { get => Data[0x68]; set => Data[0x68] = (byte)value; }
public override int Move4_PPUps { get => Data[0x69]; set => Data[0x69] = (byte)value; }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override int RelearnMove1
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt16(Data, 0x6A);
set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x6A);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override int RelearnMove2
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt16(Data, 0x6C);
set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x6C);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override int RelearnMove3
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt16(Data, 0x6E);
set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x6E);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public override int RelearnMove4
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => BitConverter.ToUInt16(Data, 0x70);
set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0x70);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
public bool SecretSuperTrainingUnlocked { get => (Data[0x72] & 1) == 1; set => Data[0x72] = (byte)((Data[0x72] & ~1) | (value ? 1 : 0)); }
public bool SecretSuperTrainingComplete { get => (Data[0x72] & 2) == 2; set => Data[0x72] = (byte)((Data[0x72] & ~2) | (value ? 2 : 0)); }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public byte _0x73 { get => Data[0x73]; set => Data[0x73] = value; }
private uint IV32 { get => BitConverter.ToUInt32(Data, 0x74); set => BitConverter.GetBytes(value).CopyTo(Data, 0x74); }
use u/L use 'u' to denote uint values, so that less IL ops are required ~(21->17) in the case of IVs no functional change, just a fun exercise looking at generated IL and finding ways to use less ops
2019-02-23 23:36:26 +00:00
public override int IV_HP { get => (int)(IV32 >> 00) & 0x1F; set => IV32 = (IV32 & ~(0x1Fu << 00)) | ((value > 31 ? 31u : (uint)value) << 00); }
public override int IV_ATK { get => (int)(IV32 >> 05) & 0x1F; set => IV32 = (IV32 & ~(0x1Fu << 05)) | ((value > 31 ? 31u : (uint)value) << 05); }
public override int IV_DEF { get => (int)(IV32 >> 10) & 0x1F; set => IV32 = (IV32 & ~(0x1Fu << 10)) | ((value > 31 ? 31u : (uint)value) << 10); }
public override int IV_SPE { get => (int)(IV32 >> 15) & 0x1F; set => IV32 = (IV32 & ~(0x1Fu << 15)) | ((value > 31 ? 31u : (uint)value) << 15); }
public override int IV_SPA { get => (int)(IV32 >> 20) & 0x1F; set => IV32 = (IV32 & ~(0x1Fu << 20)) | ((value > 31 ? 31u : (uint)value) << 20); }
public override int IV_SPD { get => (int)(IV32 >> 25) & 0x1F; set => IV32 = (IV32 & ~(0x1Fu << 25)) | ((value > 31 ? 31u : (uint)value) << 25); }
public override bool IsEgg { get => ((IV32 >> 30) & 1) == 1; set => IV32 = (IV32 & ~0x40000000u) | (value ? 0x40000000u : 0u); }
public override bool IsNicknamed { get => ((IV32 >> 31) & 1) == 1; set => IV32 = (IV32 & 0x7FFFFFFFu) | (value ? 0x80000000u : 0u); }
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
#endregion
#region Block C
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public override string HT_Name { get => GetString(0x78, 24); set => SetString(value, 12).CopyTo(Data, 0x78); }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int HT_Gender { get => Data[0x92]; set => Data[0x92] = (byte)value; }
public override int CurrentHandler { get => Data[0x93]; set => Data[0x93] = (byte)value; }
Extract geolocation logic to interface mixins would be nice but I guess extensions cover this
2018-07-14 17:34:34 +00:00
public int Geo1_Region { get => Data[0x94]; set => Data[0x94] = (byte)value; }
public int Geo1_Country { get => Data[0x95]; set => Data[0x95] = (byte)value; }
public int Geo2_Region { get => Data[0x96]; set => Data[0x96] = (byte)value; }
public int Geo2_Country { get => Data[0x97]; set => Data[0x97] = (byte)value; }
public int Geo3_Region { get => Data[0x98]; set => Data[0x98] = (byte)value; }
public int Geo3_Country { get => Data[0x99]; set => Data[0x99] = (byte)value; }
public int Geo4_Region { get => Data[0x9A]; set => Data[0x9A] = (byte)value; }
public int Geo4_Country { get => Data[0x9B]; set => Data[0x9B] = (byte)value; }
public int Geo5_Region { get => Data[0x9C]; set => Data[0x9C] = (byte)value; }
public int Geo5_Country { get => Data[0x9D]; set => Data[0x9D] = (byte)value; }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public byte _0x9E { get => Data[0x9E]; set => Data[0x9E] = value; }
public byte _0x9F { get => Data[0x9F]; set => Data[0x9F] = value; }
public byte _0xA0 { get => Data[0xA0]; set => Data[0xA0] = value; }
public byte _0xA1 { get => Data[0xA1]; set => Data[0xA1] = value; }
public override int HT_Friendship { get => Data[0xA2]; set => Data[0xA2] = (byte)value; }
public override int HT_Affection { get => Data[0xA3]; set => Data[0xA3] = (byte)value; }
public override int HT_Intensity { get => Data[0xA4]; set => Data[0xA4] = (byte)value; }
public override int HT_Memory { get => Data[0xA5]; set => Data[0xA5] = (byte)value; }
public override int HT_Feeling { get => Data[0xA6]; set => Data[0xA6] = (byte)value; }
public byte _0xA7 { get => Data[0xA7]; set => Data[0xA7] = value; }
public override int HT_TextVar { get => BitConverter.ToUInt16(Data, 0xA8); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0xA8); }
public byte _0xAA { get => Data[0xAA]; set => Data[0xAA] = value; }
public byte _0xAB { get => Data[0xAB]; set => Data[0xAB] = value; }
public byte _0xAC { get => Data[0xAC]; set => Data[0xAC] = value; }
public byte _0xAD { get => Data[0xAD]; set => Data[0xAD] = value; }
public override byte Fullness { get => Data[0xAE]; set => Data[0xAE] = value; }
public override byte Enjoyment { get => Data[0xAF]; set => Data[0xAF] = value; }
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
#endregion
#region Block D
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public override string OT_Name { get => GetString(0xB0, 24); set => SetString(value, 12).CopyTo(Data, 0xB0); }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int OT_Friendship { get => Data[0xCA]; set => Data[0xCA] = (byte)value; }
public override int OT_Affection { get => Data[0xCB]; set => Data[0xCB] = (byte)value; }
public override int OT_Intensity { get => Data[0xCC]; set => Data[0xCC] = (byte)value; }
public override int OT_Memory { get => Data[0xCD]; set => Data[0xCD] = (byte)value; }
public override int OT_TextVar { get => BitConverter.ToUInt16(Data, 0xCE); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0xCE); }
public override int OT_Feeling { get => Data[0xD0]; set => Data[0xD0] = (byte)value; }
public override int Egg_Year { get => Data[0xD1]; set => Data[0xD1] = (byte)value; }
public override int Egg_Month { get => Data[0xD2]; set => Data[0xD2] = (byte)value; }
public override int Egg_Day { get => Data[0xD3]; set => Data[0xD3] = (byte)value; }
public override int Met_Year { get => Data[0xD4]; set => Data[0xD4] = (byte)value; }
public override int Met_Month { get => Data[0xD5]; set => Data[0xD5] = (byte)value; }
public override int Met_Day { get => Data[0xD6]; set => Data[0xD6] = (byte)value; }
public byte _0xD7 { get => Data[0xD7]; set => Data[0xD7] = value; }
public override int Egg_Location { get => BitConverter.ToUInt16(Data, 0xD8); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0xD8); }
public override int Met_Location { get => BitConverter.ToUInt16(Data, 0xDA); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0xDA); }
public override int Ball { get => Data[0xDC]; set => Data[0xDC] = (byte)value; }
public override int Met_Level { get => Data[0xDD] & ~0x80; set => Data[0xDD] = (byte)((Data[0xDD] & 0x80) | value); }
public override int OT_Gender { get => Data[0xDD] >> 7; set => Data[0xDD] = (byte)((Data[0xDD] & ~0x80) | (value << 7)); }
Relocate hypertraining properties to interface lessen temp array creation, speed++
2018-06-06 04:31:42 +00:00
public int HyperTrainFlags { get => Data[0xDE]; set => Data[0xDE] = (byte)value; }
public bool HT_HP { get => ((HyperTrainFlags >> 0) & 1) == 1; set => HyperTrainFlags = (HyperTrainFlags & ~(1 << 0)) | ((value ? 1 : 0) << 0); }
public bool HT_ATK { get => ((HyperTrainFlags >> 1) & 1) == 1; set => HyperTrainFlags = (HyperTrainFlags & ~(1 << 1)) | ((value ? 1 : 0) << 1); }
public bool HT_DEF { get => ((HyperTrainFlags >> 2) & 1) == 1; set => HyperTrainFlags = (HyperTrainFlags & ~(1 << 2)) | ((value ? 1 : 0) << 2); }
public bool HT_SPA { get => ((HyperTrainFlags >> 3) & 1) == 1; set => HyperTrainFlags = (HyperTrainFlags & ~(1 << 3)) | ((value ? 1 : 0) << 3); }
public bool HT_SPD { get => ((HyperTrainFlags >> 4) & 1) == 1; set => HyperTrainFlags = (HyperTrainFlags & ~(1 << 4)) | ((value ? 1 : 0) << 4); }
public bool HT_SPE { get => ((HyperTrainFlags >> 5) & 1) == 1; set => HyperTrainFlags = (HyperTrainFlags & ~(1 << 5)) | ((value ? 1 : 0) << 5); }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int Version { get => Data[0xDF]; set => Data[0xDF] = (byte)value; }
public override int Country { get => Data[0xE0]; set => Data[0xE0] = (byte)value; }
public override int Region { get => Data[0xE1]; set => Data[0xE1] = (byte)value; }
public override int ConsoleRegion { get => Data[0xE2]; set => Data[0xE2] = (byte)value; }
public override int Language { get => Data[0xE3]; set => Data[0xE3] = (byte)value; }
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
#endregion
#region Battle Stats
Add Heal, make status_condition a pkm property also split out battle box slot offset fetch if anyone finds where colo&xd store their status bits, lmk :+1:
2019-01-12 06:25:48 +00:00
public override int Status_Condition { get => BitConverter.ToInt32(Data, 0xE8); set => BitConverter.GetBytes(value).CopyTo(Data, 0xE8); }
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int Stat_Level { get => Data[0xEC]; set => Data[0xEC] = (byte)value; }
Update personalinfo usages less temp array usages, add methods for cleaner understanding
2018-03-25 20:53:48 +00:00
public byte DirtType { get => Data[0xED]; set => Data[0xED] = value; }
public byte DirtLocation { get => Data[0xEE]; set => Data[0xEE] = value; }
// 0xEF unused
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int Stat_HPCurrent { get => BitConverter.ToUInt16(Data, 0xF0); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0xF0); }
public override int Stat_HPMax { get => BitConverter.ToUInt16(Data, 0xF2); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0xF2); }
public override int Stat_ATK { get => BitConverter.ToUInt16(Data, 0xF4); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0xF4); }
public override int Stat_DEF { get => BitConverter.ToUInt16(Data, 0xF6); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0xF6); }
public override int Stat_SPE { get => BitConverter.ToUInt16(Data, 0xF8); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0xF8); }
public override int Stat_SPA { get => BitConverter.ToUInt16(Data, 0xFA); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0xFA); }
public override int Stat_SPD { get => BitConverter.ToUInt16(Data, 0xFC); set => BitConverter.GetBytes((ushort)value).CopyTo(Data, 0xFC); }
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
#endregion
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
public int SuperTrainingMedalCount(int maxCount = 30)
Next round of ribbon checking Returned messages are slightly misleading since missing/invalid are mixed together with the static method. #1250 ~322 lines to check ribbons, on top of the interface abstraction... so much required... kinda understandable as there's over 100 ribbons to check.
2017-06-21 04:57:00 +00:00
{
Clean up super training medal checks Futureproof with transfer considerations This is just a guess; gen7 didn't update the medal count and if we assume pk8 overhauls the structure for a new console, they'll drop old data. With c#8 later next week, will move SuperTrainingMedalCount() to a default interface method ez.
2019-09-21 03:55:36 +00:00
uint value = SuperTrainBitFlags;
Next round of ribbon checking Returned messages are slightly misleading since missing/invalid are mixed together with the static method. #1250 ~322 lines to check ribbons, on top of the interface abstraction... so much required... kinda understandable as there's over 100 ribbons to check.
2017-06-21 04:57:00 +00:00
int TrainCount = 0;
value >>= 2;
for (int i = 0; i < maxCount; i++)
{
if ((value & 1) != 0)
TrainCount++;
value >>= 1;
}
return TrainCount;
}
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public bool IsUntradedEvent6 => Geo1_Country == 0 && Geo1_Region == 0 && Met_Location / 10000 == 4 && Gen6;
MarkByte => MarkValue Includes marking coloring for main form as well changes type from byte to int
2016-10-31 02:15:48 +00:00
public override int[] Markings
{
get
{
int[] marks = new int[8];
int val = MarkValue;
for (int i = 0; i < marks.Length; i++)
Fix g7 marking get Thanks ArcticLoveBunny!
2016-11-09 06:38:38 +00:00
marks[i] = ((val >> (i*2)) & 3) % 3;
MarkByte => MarkValue Includes marking coloring for main form as well changes type from byte to int
2016-10-31 02:15:48 +00:00
return marks;
}
set
{
if (value.Length > 8)
return;
int v = 0;
for (int i = 0; i < value.Length; i++)
Preliminary Sun/Moon support Still a few things like missing forms and unobtainable moves. Will work more on this later.
2016-11-08 16:43:57 +00:00
v |= (value[i] % 3) << (i*2);
MarkByte => MarkValue Includes marking coloring for main form as well changes type from byte to int
2016-10-31 02:15:48 +00:00
MarkValue = v;
}
}
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
public void FixMemories()
{
if (IsEgg) // No memories if is egg.
{
HT_Friendship = HT_Affection = HT_TextVar = HT_Memory = HT_Intensity = HT_Feeling =
/* OT_Friendship */ OT_Affection = OT_TextVar = OT_Memory = OT_Intensity = OT_Feeling = 0;
Extract geolocation logic to interface mixins would be nice but I guess extensions cover this
2018-07-14 17:34:34 +00:00
this.ClearGeoLocationData();
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
// Clear Handler
"" -> string.Empty be explicit that the string is empty rather than possibly missing disallow encrypted export for BK4 (they're not encrypted), removes type check simplify replaceall in showdownset (don't call ReplaceAll 4x, just get valid chars and rebuild) simplify get ribbon sprite name (precompute ToLower and appended values
2019-02-08 05:40:20 +00:00
HT_Name = string.Empty.PadRight(11, '\0');
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
return;
}
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
if (IsUntraded)
HT_Friendship = HT_Affection = HT_TextVar = HT_Memory = HT_Intensity = HT_Feeling = 0;
Fix gen7 affection set Closes #365
2016-11-11 06:11:53 +00:00
if (GenNumber < 6)
Extend contest-affection check to pre-gen6 transfer Closes #1881 Thanks @ijuintekka ! Thanks @sora10pls !
2018-03-28 23:07:03 +00:00
/* OT_Affection = */ OT_TextVar = OT_Memory = OT_Intensity = OT_Feeling = 0;
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
Extract geolocation logic to interface mixins would be nice but I guess extensions cover this
2018-07-14 17:34:34 +00:00
this.SanitizeGeoLocationData();
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
if (GenNumber < 7) // must be transferred via bank, and must have memories
Don't fix memories on g7 delete em Closes #564
2016-12-03 06:08:52 +00:00
{
Fix 6->7 ~ memories Yay for pokebank giving gen7 format files memories (including gen7 origin pkm) Add in a geolocation validity check; PKHeX doesn't screw this up but may catch other editors down the road. Legality checks updated accordingly.
2017-01-27 13:59:08 +00:00
TradeMemory(Bank: true);
Misc legality updates Add ゲーフリ to valid 151 OTs Revise logic for split-forme egg moves (Closes #777) Save config on closing instead of option change Remove geolocation setting for 6->7 and associated legality check, move geolocation validity check higher (Closes #776)
2017-01-31 01:49:28 +00:00
// georegions cleared on 6->7, no need to set
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
}
Simplify trade trainer parameters Bank was always false, don't try to minimalize gets by fetching before call (be simple) remove unreachable branches now that dust has settled
2019-03-31 05:05:28 +00:00
protected override bool TradeOT(ITrainerInfo tr)
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
{
// Check to see if the OT matches the SAV's OT info.
Simplify trade trainer parameters Bank was always false, don't try to minimalize gets by fetching before call (be simple) remove unreachable branches now that dust has settled
2019-03-31 05:05:28 +00:00
if (!(tr.OT == OT_Name && tr.TID == TID && tr.SID == SID && tr.Gender == OT_Gender))
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
return false;
CurrentHandler = 0;
return true;
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Simplify trade trainer parameters Bank was always false, don't try to minimalize gets by fetching before call (be simple) remove unreachable branches now that dust has settled
2019-03-31 05:05:28 +00:00
protected override void TradeHT(ITrainerInfo tr)
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
{
Simplify trade trainer parameters Bank was always false, don't try to minimalize gets by fetching before call (be simple) remove unreachable branches now that dust has settled
2019-03-31 05:05:28 +00:00
if (tr.OT != HT_Name || tr.Gender != HT_Gender || (Geo1_Country == 0 && Geo1_Region == 0 && !IsUntradedEvent6))
Extract geolocation logic to interface mixins would be nice but I guess extensions cover this
2018-07-14 17:34:34 +00:00
{
Simplify trade trainer parameters Bank was always false, don't try to minimalize gets by fetching before call (be simple) remove unreachable branches now that dust has settled
2019-03-31 05:05:28 +00:00
// No geolocations are set ingame -- except for bank transfers. Don't emulate bank transfers
// this.TradeGeoLocation(tr.Country, tr.SubRegion);
Extract geolocation logic to interface mixins would be nice but I guess extensions cover this
2018-07-14 17:34:34 +00:00
}
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
Simplify trade trainer parameters Bank was always false, don't try to minimalize gets by fetching before call (be simple) remove unreachable branches now that dust has settled
2019-03-31 05:05:28 +00:00
if (HT_Name != tr.OT)
Fix HT trade logic TradeFriendshipAffection never triggered as TradeHT sets the HT_Name just move the modification within the TradeHT method.
2016-12-21 01:54:48 +00:00
{
HT_Friendship = PersonalInfo.BaseFriendship;
HT_Affection = 0;
Simplify trade trainer parameters Bank was always false, don't try to minimalize gets by fetching before call (be simple) remove unreachable branches now that dust has settled
2019-03-31 05:05:28 +00:00
HT_Name = tr.OT;
Fix HT trade logic TradeFriendshipAffection never triggered as TradeHT sets the HT_Name just move the modification within the TradeHT method.
2016-12-21 01:54:48 +00:00
}
Mirror order of operations from pb7 see prior commit; this doesn't make any difference since CurrentFriendship isn't being called; but we're just matching the flow. Closes #2235
2019-01-09 02:35:26 +00:00
CurrentHandler = 1;
Simplify trade trainer parameters Bank was always false, don't try to minimalize gets by fetching before call (be simple) remove unreachable branches now that dust has settled
2019-03-31 05:05:28 +00:00
HT_Gender = tr.Gender;
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
Split out common 6+ pkm format to abstract class Didn't really feel like pulling out the shared structure get/set operations, only the derived properties & overall fixer methods. Should be easier to maintain if any handling updates. Clean up pb7 unused stuff; removes ribbon logic since none are used. c# 8.0 interface defaults can maybe pull out more logic (ex making FixRelearn and relearn moves into an interface); multiple inheritance can be useful as features are added/dropped between generations.
2018-12-26 06:56:32 +00:00
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
// Misc Updates
Split out common 6+ pkm format to abstract class Didn't really feel like pulling out the shared structure get/set operations, only the derived properties & overall fixer methods. Should be easier to maintain if any handling updates. Clean up pb7 unused stuff; removes ribbon logic since none are used. c# 8.0 interface defaults can maybe pull out more logic (ex making FixRelearn and relearn moves into an interface); multiple inheritance can be useful as features are added/dropped between generations.
2018-12-26 06:56:32 +00:00
public override void TradeMemory(bool Bank)
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
{
Split out common 6+ pkm format to abstract class Didn't really feel like pulling out the shared structure get/set operations, only the derived properties & overall fixer methods. Should be easier to maintain if any handling updates. Clean up pb7 unused stuff; removes ribbon logic since none are used. c# 8.0 interface defaults can maybe pull out more logic (ex making FixRelearn and relearn moves into an interface); multiple inheritance can be useful as features are added/dropped between generations.
2018-12-26 06:56:32 +00:00
if (Bank)
base.TradeMemory(true);
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
// Maximums
misc tweaks dictionary species check, max deviation beginnings for USUM simplification for gen1/2 pokemonlists
2017-10-06 05:37:45 +00:00
public override int MaxMoveID => Legal.MaxMoveID_7_USUM;
public override int MaxSpeciesID => Legal.MaxSpeciesID_7_USUM;
Misc tweaks allows loading of species > 720 lol still nowhere near done (large task is resource acquisition)
2017-11-08 08:51:08 +00:00
public override int MaxAbilityID => Legal.MaxAbilityID_7_USUM;
Split item cap for usum prep
2017-10-11 02:30:55 +00:00
public override int MaxItemID => Legal.MaxItemID_7_USUM;
Refactor main form into smaller pieces pkm editor, sav editor, menus, and a manager to glue the storage slots together decouples the pkm/sav editors from a static savefile reference. improves dragdrop/click view/set/delete indication, hides unavailable contextmenuitems, and fixes a few incorrect references. Box Subviewer slots now have all the indication/events that the main save editor slots have. pls report behavior bugs :+1:
2017-05-23 04:55:05 +00:00
public override int MaxBallID => Legal.MaxBallID_7;
public override int MaxGameID => Legal.MaxGameID_7;
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
public PK8 ConvertToPK8()
{
var pk8 = new PK8
{
EncryptionConstant = EncryptionConstant,
Species = Species,
TID = TID,
SID = SID,
EXP = EXP,
PID = PID,
Ability = Ability,
AbilityNumber = AbilityNumber,
Markings = Markings,
Language = Language,
EV_HP = EV_HP,
EV_ATK = EV_ATK,
EV_DEF = EV_DEF,
EV_SPA = EV_SPA,
EV_SPD = EV_SPD,
EV_SPE = EV_SPE,
Move1 = Move1,
Move2 = Move2,
Move3 = Move3,
Move4 = Move4,
Move1_PPUps = Move1_PPUps,
Move2_PPUps = Move2_PPUps,
Move3_PPUps = Move3_PPUps,
Move4_PPUps = Move4_PPUps,
RelearnMove1 = RelearnMove1,
RelearnMove2 = RelearnMove2,
RelearnMove3 = RelearnMove3,
RelearnMove4 = RelearnMove4,
IV_HP = IV_HP,
IV_ATK = IV_ATK,
IV_DEF = IV_DEF,
IV_SPA = IV_SPA,
IV_SPD = IV_SPD,
IV_SPE = IV_SPE,
IsEgg = IsEgg,
IsNicknamed = IsNicknamed,
FatefulEncounter = FatefulEncounter,
Gender = Gender,
AltForm = AltForm,
Nature = Nature,
Nickname = Nickname,
Version = Version,
OT_Name = OT_Name,
MetDate = MetDate,
EggMetDate = EggMetDate,
Met_Location = Met_Location,
Egg_Location = Egg_Location,
Ball = Ball,
Met_Level = Met_Level,
OT_Gender = OT_Gender,
HyperTrainFlags = HyperTrainFlags,
Don't transfer locale
2020-02-12 03:04:00 +00:00
// Locale does not transfer. All Zero
// Country = Country,
// Region = Region,
// ConsoleRegion = ConsoleRegion,
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
// todo: memories
Copy console data, copy OT memories still hypothetical; we know that memories exist and console data still has accessors HT memories should be replaced, so no need to transfer 'em.
2019-12-11 03:13:32 +00:00
OT_Memory = OT_Memory,
OT_TextVar = OT_TextVar,
OT_Feeling = OT_Feeling,
OT_Intensity = OT_Intensity,
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
PKRS_Strain = PKRS_Strain,
PKRS_Days = PKRS_Days,
CNT_Cool = CNT_Cool,
CNT_Beauty = CNT_Beauty,
CNT_Cute = CNT_Cute,
CNT_Smart = CNT_Smart,
CNT_Tough = CNT_Tough,
CNT_Sheen = CNT_Sheen,
RibbonChampionG3Hoenn = RibbonChampionG3Hoenn,
RibbonChampionSinnoh = RibbonChampionSinnoh,
RibbonEffort = RibbonEffort,
RibbonAlert = RibbonAlert,
RibbonShock = RibbonShock,
RibbonDowncast = RibbonDowncast,
RibbonCareless = RibbonCareless,
RibbonRelax = RibbonRelax,
RibbonSnooze = RibbonSnooze,
RibbonSmile = RibbonSmile,
RibbonGorgeous = RibbonGorgeous,
RibbonRoyal = RibbonRoyal,
RibbonGorgeousRoyal = RibbonGorgeousRoyal,
RibbonArtist = RibbonArtist,
RibbonFootprint = RibbonFootprint,
RibbonRecord = RibbonRecord,
RibbonLegend = RibbonLegend,
RibbonCountry = RibbonCountry,
RibbonNational = RibbonNational,
RibbonEarth = RibbonEarth,
RibbonWorld = RibbonWorld,
RibbonClassic = RibbonClassic,
RibbonPremier = RibbonPremier,
RibbonEvent = RibbonEvent,
RibbonBirthday = RibbonBirthday,
RibbonSpecial = RibbonSpecial,
RibbonSouvenir = RibbonSouvenir,
RibbonWishing = RibbonWishing,
RibbonChampionBattle = RibbonChampionBattle,
RibbonChampionRegional = RibbonChampionRegional,
RibbonChampionNational = RibbonChampionNational,
RibbonChampionWorld = RibbonChampionWorld,
RibbonChampionKalos = RibbonChampionKalos,
RibbonChampionG6Hoenn = RibbonChampionG6Hoenn,
RibbonBestFriends = RibbonBestFriends,
RibbonTraining = RibbonTraining,
RibbonBattlerSkillful = RibbonBattlerSkillful,
RibbonBattlerExpert = RibbonBattlerExpert,
RibbonContestStar = RibbonContestStar,
RibbonMasterCoolness = RibbonMasterCoolness,
RibbonMasterBeauty = RibbonMasterBeauty,
RibbonMasterCuteness = RibbonMasterCuteness,
RibbonMasterCleverness = RibbonMasterCleverness,
RibbonMasterToughness = RibbonMasterToughness,
RibbonCountMemoryContest = RibbonCountMemoryContest,
RibbonCountMemoryBattle = RibbonCountMemoryBattle,
RibbonChampionAlola = RibbonChampionAlola,
RibbonBattleRoyale = RibbonBattleRoyale,
RibbonBattleTreeGreat = RibbonBattleTreeGreat,
RibbonBattleTreeMaster = RibbonBattleTreeMaster,
Update p*7 transfer logic Add scalars & stat natures Do note: there is more data that is set and can potentially be used to flag you for cheats. Beware.
2020-02-12 02:05:07 +00:00
Continued comparisons & implications pk7->pk8 doesnt assign height/weight (zero), require zero for legal p*7->pk8 assigns a tracker value, enforce something is present for legal copy OT friendship (oops)
2020-02-12 02:35:54 +00:00
OT_Friendship = OT_Friendship,
Update p*7 transfer logic Add scalars & stat natures Do note: there is more data that is set and can potentially be used to flag you for cheats. Beware.
2020-02-12 02:05:07 +00:00
// No Ribbons or Markings on transfer.
StatNature = Nature,
Continued comparisons & implications pk7->pk8 doesnt assign height/weight (zero), require zero for legal p*7->pk8 assigns a tracker value, enforce something is present for legal copy OT friendship (oops)
2020-02-12 02:35:54 +00:00
// HeightScalar = 0,
// WeightScalar = 0,
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
};
More transfer implications Totems are downsized to regular araquanid, togedemaru, and ribombee totems can't transfer (at the moment)
2020-02-12 04:11:33 +00:00
// Wipe Totem Forms
if (FormConverter.IsTotemForm(Species, AltForm, 7))
pk8.AltForm = FormConverter.GetTotemBaseForm(Species, AltForm);
Add swsh content placeholders (#2392) placeholder content until real data is dumped
2019-09-23 23:56:47 +00:00
// Fix PP
pk8.HealPP();
// Fix Checksum
pk8.RefreshChecksum();
return pk8; // Done!
}
Initial Sun/Moon Support Loads the save file, still not finished.
2016-10-20 01:19:01 +00:00
}
}
Reference in a new issue Copy permalink