Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-02 16:59:15 +00:00
Code Issues Projects Releases Packages Wiki Activity
PKHeX/PKHeX.Core/Saves/SAV2.cs

769 lines
28 KiB
C#
Raw Normal View History

Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
using System;
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
using System.Collections.Generic;
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
using static System.Buffers.Binary.BinaryPrimitives;
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
Split winforms to separate project resources still are associated with winforms, eh program still runs fine and I've replicated the mono build options. lmk if this breaks stuff
2017-01-08 07:54:09 +00:00
namespace PKHeX.Core
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
add more pkhex.core xml documentation adds a bunch of documentation useful for those unfamiliar with the core library
2017-10-24 06:12:58 +00:00
/// <summary>
/// Generation 2 <see cref="SaveFile"/> object.
/// </summary>
Minor clean Remove some unnecessary properties from SaveFile Enumerate checksum flag results for GC memcard checking Remove unnecessary checks on savefile type Add some documentation Decapitalize some method parameters
2019-07-14 22:06:45 +00:00
public sealed class SAV2 : SaveFile, ILangDeviantSave
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
Extract metadata/state tracking from SaveFile obj
2020-12-05 13:36:23 +00:00
protected internal override string ShortSummary => $"{OT} ({Version}) - {PlayTimeString}";
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public override string Extension => ".sav";
Startup Enhancements, Gen1/2 Save Indication, Export SAV cleaned up (#3275) * Providing pkm/sav files via command line (dragging files onto exe / associated file launched) will more intelligently source a partner sav/pkm object if not provided. * Gen1/2 mainline save files now indicate if they are VC era or GB era (legality implications) in the program title bar. * Fixes loading VC era save backups not being recognized as VC era (`.bak` extension hides `.dat`) * Export BAK moved to the SAV tab, which allows Export main to be deleted and Export SAV to be used as the single-click for exporting saves. `CTRL-E` is still the hotkey.
2021-10-22 05:13:21 +00:00
public bool IsVirtualConsole => State.Exportable && Metadata.FileName is { } s && s.StartsWith("sav") && s.Contains(".dat"); // default to GB-Era for non-exportable
Add notation for language-specific save types
2020-09-26 20:30:17 +00:00
public int SaveRevision => Japanese ? 0 : !Korean ? 1 : 2;
Startup Enhancements, Gen1/2 Save Indication, Export SAV cleaned up (#3275) * Providing pkm/sav files via command line (dragging files onto exe / associated file launched) will more intelligently source a partner sav/pkm object if not provided. * Gen1/2 mainline save files now indicate if they are VC era or GB era (legality implications) in the program title bar. * Fixes loading VC era save backups not being recognized as VC era (`.bak` extension hides `.dat`) * Export BAK moved to the SAV tab, which allows Export main to be deleted and Export SAV to be used as the single-click for exporting saves. `CTRL-E` is still the hotkey.
2021-10-22 05:13:21 +00:00
public string SaveRevisionString => (Japanese ? "J" : !Korean ? "U" : "K") + (IsVirtualConsole ? "VC" : "GB");
Minor clean Remove some unnecessary properties from SaveFile Enumerate checksum flag results for GC memcard checking Remove unnecessary checks on savefile type Add some documentation Decapitalize some method parameters
2019-07-14 22:06:45 +00:00
public bool Japanese { get; }
public bool Korean { get; }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
public override PersonalTable Personal { get; }
public override IReadOnlyList<ushort> HeldItems => Legal.HeldItems_GSC;
Replace more linq usage
2021-08-06 05:39:38 +00:00
public override IReadOnlyList<string> PKMExtensions => Array.FindAll(PKM.Extensions, f =>
Improve supported extension openfiledialog Existing code supported 3-x, wasn't updated for gen1/2. Allows gens1/2 to override to their own gen format filter, and allows gen7 to allow finding of pk1 files (not yet converted). Noticed the backup would overwrite an existing backup; thus we only back up if the target file exists AND the backup doesn't already exist.
2017-01-05 06:22:50 +00:00
{
Minor tweaks Muh infinitesimally small perf gainz found while waiting for next dota match
2021-07-27 06:33:56 +00:00
int gen = f[^1] - 0x30;
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
if (Korean)
return gen == 2;
Simplify some repeated comparisons with expressions Less prone for bugs since it uses the same value for all comparisons without re-specifying
2020-12-29 08:37:59 +00:00
return gen is 1 or 2;
Replace more linq usage
2021-08-06 05:39:38 +00:00
});
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
Minor tweaks, no functional change
2019-07-21 19:30:21 +00:00
public SAV2(GameVersion version = GameVersion.C, LanguageID lang = LanguageID.English) : base(SaveUtil.SIZE_G2RAW_J)
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
Minor tweaks, no functional change
2019-07-21 19:30:21 +00:00
Version = version;
Split gen5-7 saves with inheritance (#2319) refer to pull request comments for summary
2019-06-09 02:56:11 +00:00
switch (lang)
{
case LanguageID.Japanese:
Japanese = true;
break;
case LanguageID.Korean:
Korean = true;
break;
// otherwise, both false
}
Offsets = new SAV2Offsets(this);
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
Personal = Version == GameVersion.GS ? PersonalTable.GS : PersonalTable.C;
Split gen5-7 saves with inheritance (#2319) refer to pull request comments for summary
2019-06-09 02:56:11 +00:00
Initialize();
ClearBoxes();
}
Refactoring & fixes Fix blank sav creation for gens 1-3 (data vs Data references, version overrides) Fix main form init with gen2 first (check for altform usage like all other gens) Use GameVersion specific blank fetch instead of generation ID
2017-01-15 00:43:16 +00:00
Split gen5-7 saves with inheritance (#2319) refer to pull request comments for summary
2019-06-09 02:56:11 +00:00
public SAV2(byte[] data, GameVersion versionOverride = GameVersion.Any) : base(data)
{
Version = versionOverride != GameVersion.Any ? versionOverride : SaveUtil.GetIsG2SAV(Data);
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
Japanese = SaveUtil.GetIsG2SAVJ(Data) != GameVersion.Invalid;
Only check Korean if game isn't recognized as Crystal https://projectpokemon.org/home/forums/topic/57203-pkhex-error-crystal-save-dont-load/
2020-05-31 16:18:45 +00:00
if (Version != GameVersion.C && !Japanese)
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
Korean = SaveUtil.GetIsG2SAVK(Data) != GameVersion.Invalid;
Full Gen II Save editing for US GSC, JP C (JP GS to come)
2016-09-04 01:57:54 +00:00
Split gen5-7 saves with inheritance (#2319) refer to pull request comments for summary
2019-06-09 02:56:11 +00:00
Offsets = new SAV2Offsets(this);
PKHeX.Core Nullable cleanup (#2401) * Handle some nullable cases Refactor MysteryGift into a second abstract class (backed by a byte array, or fake data) Make some classes have explicit constructors instead of { } initialization * Handle bits more obviously without null * Make SaveFile.BAK explicitly readonly again * merge constructor methods to have readonly fields * Inline some properties * More nullable handling * Rearrange box actions define straightforward classes to not have any null properties * Make extrabyte reference array immutable * Move tooltip creation to designer * Rearrange some logic to reduce nesting * Cache generated fonts * Split mystery gift album purpose * Handle more tooltips * Disallow null setters * Don't capture RNG object, only type enum * Unify learnset objects Now have readonly properties which are never null don't new() empty learnsets (>800 Learnset objects no longer created, total of 2400 objects since we also new() a move & level array) optimize g1/2 reader for early abort case * Access rewrite Initialize blocks in a separate object, and get via that object removes a couple hundred "might be null" warnings since blocks are now readonly getters some block references have been relocated, but interfaces should expose all that's needed put HoF6 controls in a groupbox, and disable * Readonly personal data * IVs non nullable for mystery gift * Explicitly initialize forced encounter moves * Make shadow objects readonly & non-null Put murkrow fix in binary data resource, instead of on startup * Assign dex form fetch on constructor Fixes legality parsing edge cases also handle cxd parse for valid; exit before exception is thrown in FrameGenerator * Remove unnecessary null checks * Keep empty value until init SetPouch sets the value to an actual one during load, but whatever * Readonly team lock data * Readonly locks Put locked encounters at bottom (favor unlocked) * Mail readonly data / offset Rearrange some call flow and pass defaults Add fake classes for SaveDataEditor mocking Always party size, no need to check twice in stat editor use a fake save file as initial data for savedata editor, and for gamedata (wow i found a usage) constrain eventwork editor to struct variable types (uint, int, etc), thus preventing null assignment errors
2019-10-17 01:47:31 +00:00
Personal = Version == GameVersion.GS ? PersonalTable.GS : PersonalTable.C;
Split gen5-7 saves with inheritance (#2319) refer to pull request comments for summary
2019-06-09 02:56:11 +00:00
Initialize();
}
private void Initialize()
{
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
Box = Data.Length;
Array.Resize(ref Data, Data.Length + SIZE_RESERVED);
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
Party = GetPartyOffset(0);
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
// Stash boxes after the save file's end.
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
int splitAtIndex = (Japanese ? 6 : 7);
int stored = SIZE_STOREDBOX;
int baseDest = Data.Length - SIZE_RESERVED;
var capacity = Japanese ? PokeListType.StoredJP : PokeListType.Stored;
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
for (int i = 0; i < BoxCount; i++)
{
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
int ofs = GetBoxRawDataOffset(i, splitAtIndex);
var box = GetData(ofs, stored);
var boxDest = baseDest + (i * SIZE_BOX);
var boxPL = new PokeList2(box, capacity, Japanese);
for (int j = 0; j < boxPL.Pokemon.Length; j++)
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
var dest = boxDest + (j * SIZE_STORED);
var pkDat = (j < boxPL.Count)
? new PokeList2(boxPL[j]).Write()
: new byte[PokeList2.GetDataLength(PokeListType.Single, Japanese)];
pkDat.CopyTo(Data, dest);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
}
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
var current = GetData(Offsets.CurrentBox, stored);
var curBoxPL = new PokeList2(current, capacity, Japanese);
var curDest = baseDest + (CurrentBox * SIZE_BOX);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
for (int i = 0; i < curBoxPL.Pokemon.Length; i++)
{
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
var dest = curDest + (i * SIZE_STORED);
var pkDat = i < curBoxPL.Count
? new PokeList2(curBoxPL[i]).Write()
: new byte[PokeList2.GetDataLength(PokeListType.Single, Japanese)];
pkDat.CopyTo(Data, dest);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
var party = GetData(Offsets.Party, SIZE_STOREDPARTY);
var partyPL = new PokeList2(party, PokeListType.Party, Japanese);
for (int i = 0; i < partyPL.Pokemon.Length; i++)
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
var dest = GetPartyOffset(i);
var pkDat = i < partyPL.Count
? new PokeList2(partyPL[i]).Write()
: new byte[PokeList2.GetDataLength(PokeListType.Single, Japanese)];
pkDat.CopyTo(Data, dest);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
Full Gen II Save editing for US GSC, JP C (JP GS to come)
2016-09-04 01:57:54 +00:00
Add sav2 daycare view tfw they store full egg data there too -- show that in the sidebar Tested on C & GS (english), assumedly works fine for other languages (based on the disassembly?)
2018-07-08 22:46:37 +00:00
if (Offsets.Daycare >= 0)
{
int offset = Offsets.Daycare;
Split gen5-7 saves with inheritance (#2319) refer to pull request comments for summary
2019-06-09 02:56:11 +00:00
DaycareFlags[0] = Data[offset];
offset++;
Add sav2 daycare view tfw they store full egg data there too -- show that in the sidebar Tested on C & GS (english), assumedly works fine for other languages (based on the disassembly?)
2018-07-08 22:46:37 +00:00
var pk1 = ReadPKMFromOffset(offset); // parent 1
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
var daycare1 = new PokeList2(pk1);
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
offset += (StringLength * 2) + 0x20; // nick/ot/pkm
Split gen5-7 saves with inheritance (#2319) refer to pull request comments for summary
2019-06-09 02:56:11 +00:00
DaycareFlags[1] = Data[offset];
offset++;
Cleanup handle messages for dirty cleaning :)
2019-10-26 19:33:58 +00:00
//byte steps = Data[offset];
Split gen5-7 saves with inheritance (#2319) refer to pull request comments for summary
2019-06-09 02:56:11 +00:00
offset++;
Cleanup handle messages for dirty cleaning :)
2019-10-26 19:33:58 +00:00
//byte BreedMotherOrNonDitto = Data[offset];
Split gen5-7 saves with inheritance (#2319) refer to pull request comments for summary
2019-06-09 02:56:11 +00:00
offset++;
Add sav2 daycare view tfw they store full egg data there too -- show that in the sidebar Tested on C & GS (english), assumedly works fine for other languages (based on the disassembly?)
2018-07-08 22:46:37 +00:00
var pk2 = ReadPKMFromOffset(offset); // parent 2
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
var daycare2 = new PokeList2(pk2);
Split PokeCrypto from PKX All logic in PokeCrypto is separate from the rest of the PKHeX.Core library; makes it easy to just rip this portion out and reuse in other projects without needing the entirety of PKHeX.Core logic optimize out the CheckEncrypted to the actual path, separate methods. Only usages of this method were with hardcoded Format values, so no impact
2020-01-04 22:48:39 +00:00
offset += (StringLength * 2) + PokeCrypto.SIZE_2STORED; // nick/ot/pkm
Add sav2 daycare view tfw they store full egg data there too -- show that in the sidebar Tested on C & GS (english), assumedly works fine for other languages (based on the disassembly?)
2018-07-08 22:46:37 +00:00
var pk3 = ReadPKMFromOffset(offset); // egg!
pk3.IsEgg = true;
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
var daycare3 = new PokeList2(pk3);
Add sav2 daycare view tfw they store full egg data there too -- show that in the sidebar Tested on C & GS (english), assumedly works fine for other languages (based on the disassembly?)
2018-07-08 22:46:37 +00:00
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
daycare1.Write().CopyTo(Data, GetPartyOffset(7 + (0 * 2)));
daycare2.Write().CopyTo(Data, GetPartyOffset(7 + (1 * 2)));
daycare3.Write().CopyTo(Data, GetPartyOffset(7 + (2 * 2)));
Simplify block property names [...]Block -> [...] since it's kinda redundant, we already know by its type. Rename offset ints that collide
2019-10-19 03:42:03 +00:00
DaycareOffset = Offsets.Daycare;
Add sav2 daycare view tfw they store full egg data there too -- show that in the sidebar Tested on C & GS (english), assumedly works fine for other languages (based on the disassembly?)
2018-07-08 22:46:37 +00:00
}
Full Gen II Save editing for US GSC, JP C (JP GS to come)
2016-09-04 01:57:54 +00:00
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
// Enable Pokedex editing
PokeDex = 0;
Move eventflag offset fetch to SAV2Offsets obj
2017-11-28 00:46:14 +00:00
EventFlag = Offsets.EventFlag;
Add gs event flags https://projectpokemon.org/home/forums/topic/49717-pkhex-flag-editing/?tab=comments#comment-240804 via pret repo; looks like 2000 event flags, and 0x100 event consts/work-vals (byte) add more rebattle toggles
2019-03-06 07:06:05 +00:00
EventConst = Offsets.EventConst;
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
Add sav2 daycare view tfw they store full egg data there too -- show that in the sidebar Tested on C & GS (english), assumedly works fine for other languages (based on the disassembly?)
2018-07-08 22:46:37 +00:00
private PK2 ReadPKMFromOffset(int offset)
{
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
var stringLength = StringLength;
var span = Data.AsSpan(offset);
Add sav2 daycare view tfw they store full egg data there too -- show that in the sidebar Tested on C & GS (english), assumedly works fine for other languages (based on the disassembly?)
2018-07-08 22:46:37 +00:00
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
var pkData = span.Slice(stringLength * 2, PokeCrypto.SIZE_2STORED).ToArray();
var pk = new PK2(pkData, jp: Japanese);
Add sav2 daycare view tfw they store full egg data there too -- show that in the sidebar Tested on C & GS (english), assumedly works fine for other languages (based on the disassembly?)
2018-07-08 22:46:37 +00:00
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
var nick = span[..stringLength];
var ot = span.Slice(stringLength, stringLength);
nick.CopyTo(pk.RawNickname);
ot.CopyTo(pk.RawOT);
return pk;
Add sav2 daycare view tfw they store full egg data there too -- show that in the sidebar Tested on C & GS (english), assumedly works fine for other languages (based on the disassembly?)
2018-07-08 22:46:37 +00:00
}
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
private const int SIZE_RESERVED = 0x8000; // unpacked box data
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
private readonly SAV2Offsets Offsets;
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
private int GetBoxRawDataOffset(int i, int splitAtIndex)
{
if (i < splitAtIndex)
return 0x4000 + (i * (SIZE_STOREDBOX + 2));
return 0x6000 + ((i - splitAtIndex) * (SIZE_STOREDBOX + 2));
}
Misc tweak to savefile export Use flags to request header/footer in the output gets rid of the DSV/GCI bool arguments
2019-02-19 05:59:57 +00:00
protected override byte[] GetFinalData()
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
int splitAtIndex = (Japanese ? 6 : 7);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
for (int i = 0; i < BoxCount; i++)
{
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
var boxPL = new PokeList2(Japanese ? PokeListType.StoredJP : PokeListType.Stored, Japanese);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
int slot = 0;
for (int j = 0; j < boxPL.Pokemon.Length; j++)
{
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
PK2 boxPK = (PK2) GetPKM(GetData(GetBoxOffset(i) + (j * SIZE_STORED), SIZE_STORED));
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
if (boxPK.Species > 0)
boxPL[slot++] = boxPK;
}
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
int src = GetBoxRawDataOffset(i, splitAtIndex);
boxPL.Write().CopyTo(Data, src);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
if (i == CurrentBox)
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
boxPL.Write().CopyTo(Data, Offsets.CurrentBox);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
var partyPL = new PokeList2(PokeListType.Party, Japanese);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
int pSlot = 0;
for (int i = 0; i < 6; i++)
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
PK2 partyPK = (PK2)GetPKM(GetData(GetPartyOffset(i), SIZE_STORED));
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
if (partyPK.Species > 0)
partyPL[pSlot++] = partyPK;
}
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
partyPL.Write().CopyTo(Data, Offsets.Party);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
SetChecksums();
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
if (Japanese)
Full Gen II Save editing for US GSC, JP C (JP GS to come)
2016-09-04 01:57:54 +00:00
{
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
switch (Version)
{
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
case GameVersion.GS: Data.AsSpan(Offsets.Trainer1, 0xC83).CopyTo(Data.AsSpan(0x7209)); break;
case GameVersion.C: Data.AsSpan(Offsets.Trainer1, 0xADA).CopyTo(Data.AsSpan(0x7209)); break;
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
}
Full Gen II Save editing for US GSC, JP C (JP GS to come)
2016-09-04 01:57:54 +00:00
}
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
else if (Korean)
Full Gen II Save editing for US GSC, JP C (JP GS to come)
2016-09-04 01:57:54 +00:00
{
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
// Calculate oddball checksum
ushort sum = 0;
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
Span<(ushort, ushort)> offsetpairs = stackalloc (ushort,ushort)[]
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
{
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
(0x106B, 0x1533),
(0x1534, 0x1A12),
(0x1A13, 0x1C38),
(0x3DD8, 0x3F79),
(0x7E39, 0x7E6A),
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
};
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
foreach (var p in offsetpairs)
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
{
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
for (int i = p.Item1; i < p.Item2; i++)
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
sum += Data[i];
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
}
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
WriteUInt16LittleEndian(Data.AsSpan(0x7E6B), sum);
Full Gen II Save editing for US GSC, JP C (JP GS to come)
2016-09-04 01:57:54 +00:00
}
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
else
Japanese G/S support.
2016-09-04 06:15:09 +00:00
{
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
switch (Version)
{
case GameVersion.GS:
Array.Copy(Data, 0x2009, Data, 0x15C7, 0x222F - 0x2009);
Array.Copy(Data, 0x222F, Data, 0x3D69, 0x23D9 - 0x222F);
Array.Copy(Data, 0x23D9, Data, 0x0C6B, 0x2856 - 0x23D9);
Array.Copy(Data, 0x2856, Data, 0x7E39, 0x288A - 0x2856);
Array.Copy(Data, 0x288A, Data, 0x10E8, 0x2D69 - 0x288A);
break;
case GameVersion.C:
Array.Copy(Data, 0x2009, Data, 0x1209, 0xB7A);
break;
}
Japanese G/S support.
2016-09-04 06:15:09 +00:00
}
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
byte[] outData = new byte[Data.Length - SIZE_RESERVED];
Array.Copy(Data, outData, outData.Length);
return outData;
}
// Configuration
Extract metadata/state tracking from SaveFile obj
2020-12-05 13:36:23 +00:00
protected override SaveFile CloneInternal() => new SAV2(Write(), Version);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
Fix entire-box swaps by using correct lengths Add SIZE_BOXSLOT and update usages Make SIZE_STORED protected like SIZE_PARTY probably need to redesign how slot metadata is presented within the savefile... Closes #2961 ty @Kermalis !
2020-08-07 23:16:10 +00:00
protected override int SIZE_STORED => Japanese ? PokeCrypto.SIZE_2JLIST : PokeCrypto.SIZE_2ULIST;
Split PokeCrypto from PKX All logic in PokeCrypto is separate from the rest of the PKHeX.Core library; makes it easy to just rip this portion out and reuse in other projects without needing the entirety of PKHeX.Core logic optimize out the CheckEncrypted to the actual path, separate methods. Only usages of this method were with hardcoded Format values, so no impact
2020-01-04 22:48:39 +00:00
protected override int SIZE_PARTY => Japanese ? PokeCrypto.SIZE_2JLIST : PokeCrypto.SIZE_2ULIST;
Refactoring pass identifier on cloning pkm remove unnecessary ref for passing Data (not modifying array reference) const some magic numbers
2017-12-28 00:36:24 +00:00
public override PKM BlankPKM => new PK2(jp: Japanese);
PBR support (#290) * Initial (still buggy) PBR commit * Basic save slot support
2016-09-26 23:14:11 +00:00
public override Type PKMType => typeof(PK2);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
Improve supported extension openfiledialog Existing code supported 3-x, wasn't updated for gen1/2. Allows gens1/2 to override to their own gen format filter, and allows gen7 to allow finding of pk1 files (not yet converted). Noticed the backup would overwrite an existing backup; thus we only back up if the target file exists AND the backup doesn't already exist.
2017-01-05 06:22:50 +00:00
private int SIZE_BOX => BoxSlotCount*SIZE_STORED;
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
private int SIZE_STOREDBOX => PokeList2.GetDataLength(Japanese ? PokeListType.StoredJP : PokeListType.Stored, Japanese);
private int SIZE_STOREDPARTY => PokeList2.GetDataLength(PokeListType.Party, Japanese);
Improve supported extension openfiledialog Existing code supported 3-x, wasn't updated for gen1/2. Allows gens1/2 to override to their own gen format filter, and allows gen7 to allow finding of pk1 files (not yet converted). Noticed the backup would overwrite an existing backup; thus we only back up if the target file exists AND the backup doesn't already exist.
2017-01-05 06:22:50 +00:00
Add pk6/pk7 differentiation Moves a lot of const values from SAV to Legal for reuse. Closes #754
2017-01-27 03:18:20 +00:00
public override int MaxMoveID => Legal.MaxMoveID_2;
Use added maxspecies from legal Instead of a hard-coded number. Maybe I should have a species/move/Ability/Item/Ball enum
2016-10-24 04:59:27 +00:00
public override int MaxSpeciesID => Legal.MaxSpeciesID_2;
Add pk6/pk7 differentiation Moves a lot of const values from SAV to Legal for reuse. Closes #754
2017-01-27 03:18:20 +00:00
public override int MaxAbilityID => Legal.MaxAbilityID_2;
public override int MaxItemID => Legal.MaxItemID_2;
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
public override int MaxBallID => 0; // unused
public override int MaxGameID => 99; // unused
MaxMoney capping 1-4 Closes #245 Thanks @sora10pls !
2016-09-09 03:20:32 +00:00
public override int MaxMoney => 999999;
Fix gen1/2 coin set & gen2 TM capping now writes coin count correctly (uint != ushort) and TMs are capped at 99; HMs shouldn't be allowed beyond 1 but oh well.
2017-02-04 20:13:54 +00:00
public override int MaxCoins => 9999;
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
public override bool IsPKMPresent(ReadOnlySpan<byte> data) => PKX.IsPKMPresentGB(data);
add faster pkm slot presence check instead of checking if the array is empty, only check PID and species
2018-03-18 23:22:21 +00:00
Add gs event flags https://projectpokemon.org/home/forums/topic/49717-pkhex-flag-editing/?tab=comments#comment-240804 via pret repo; looks like 2000 event flags, and 0x100 event consts/work-vals (byte) add more rebattle toggles
2019-03-06 07:06:05 +00:00
protected override int EventConstMax => 0x100;
protected override int EventFlagMax => 2000;
add Crystal GS EventFlags have checked with US ver.
2017-11-27 18:35:49 +00:00
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public override int BoxCount => Japanese ? 9 : 14;
public override int MaxEV => 65535;
public override int MaxIV => 15;
public override int Generation => 2;
protected override int GiftCountMax => 0;
Save all 5 korean OT characters Closes #1545, thanks @Bl4ckSh4rk !
2017-10-25 01:49:51 +00:00
public override int OTLength => Japanese || Korean ? 5 : 7;
public override int NickLength => Japanese || Korean ? 5 : 10;
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public override int BoxSlotCount => Japanese ? 30 : 20;
public override bool HasParty => true;
Allow box name editing on gen2
2017-12-27 23:52:29 +00:00
public override bool HasNamableBoxes => true;
Minor clean Condense some expressions Use less linq Rename some fields
2021-05-29 22:31:47 +00:00
private int StringLength => Japanese ? GBPKML.StringLengthJapanese : GBPKML.StringLengthNotJapan;
Remove trailing whitespace
2018-05-12 15:13:39 +00:00
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
// Checksums
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
private ushort GetChecksum()
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
Misc perf tweaks hopefully resolves the image corruption issue (dont use unsafe?) remove some linq
2018-10-13 15:02:55 +00:00
ushort sum = 0;
for (int i = Offsets.Trainer1; i <= Offsets.AccumulatedChecksumEnd; i++)
sum += Data[i];
return sum;
Japanese checksum fix & refactoring Simplify checksum code (-50 lines) set the bitflag on set, and clear on clear; don't clear and re-set if setting. Remove ToArray in favor of getData array fetch.
2017-02-25 07:01:07 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
protected override void SetChecksums()
Japanese checksum fix & refactoring Simplify checksum code (-50 lines) set the bitflag on set, and clear on clear; don't clear and re-set if setting. Remove ToArray in favor of getData array fetch.
2017-02-25 07:01:07 +00:00
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
ushort accum = GetChecksum();
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
WriteUInt16LittleEndian(Data.AsSpan(Offsets.OverallChecksumPosition), accum);
WriteUInt16LittleEndian(Data.AsSpan(Offsets.OverallChecksumPosition2), accum);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public override bool ChecksumsValid
{
get
{
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
ushort accum = GetChecksum();
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
ushort actual = ReadUInt16LittleEndian(Data.AsSpan(Offsets.OverallChecksumPosition));
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
return accum == actual;
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
}
Full Gen II Save editing for US GSC, JP C (JP GS to come)
2016-09-04 01:57:54 +00:00
Misc cleanup ( ͡° ͜ʖ ͡°)
2016-09-04 06:54:11 +00:00
public override string ChecksumInfo => ChecksumsValid ? "Checksum valid." : "Checksum invalid";
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
// Trainer Info
public override GameVersion Version { get; protected set; }
public override string OT
{
Save all 5 korean OT characters Closes #1545, thanks @Bl4ckSh4rk !
2017-10-25 01:49:51 +00:00
get => GetString(Offsets.Trainer1 + 2, (Korean ? 2 : 1) * OTLength);
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
set => SetString(Data.AsSpan(Offsets.Trainer1 + 2, (Korean ? 2 : 1) * OTLength), value.AsSpan(), 8, StringConverterOption.Clear50);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Revise EncounterArea and EncounterType for clarity (#3228) EncounterArea now stores a more specific type'd array for encounter slots. Better iteration and less casting, as the nonspecific `Slots` fetch is rarely referenced. EncounterType renamed to GroundTile to reflect how it actually works in Gen4. Was previously an ambiguous field that was clarified a little; we can describe it a little better now. Keep the GUI the same to not scare the end users. Change Trash Byte properties to get/set a Span. Trash Byte legality checking easier on the garbage collector?
2021-06-30 03:58:06 +00:00
public Span<byte> OT_Trash
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
{
Add Crystal blue card points get/set Co-Authored-By: FeralFalcon <33670476+FeralFalcon@users.noreply.github.com> #3258
2021-09-16 20:16:12 +00:00
get => Data.AsSpan(Offsets.Trainer1 + 2, StringLength);
Revise EncounterArea and EncounterType for clarity (#3228) EncounterArea now stores a more specific type'd array for encounter slots. Better iteration and less casting, as the nonspecific `Slots` fetch is rarely referenced. EncounterType renamed to GroundTile to reflect how it actually works in Gen4. Was previously an ambiguous field that was clarified a little; we can describe it a little better now. Keep the GUI the same to not scare the end users. Change Trash Byte properties to get/set a Span. Trash Byte legality checking easier on the garbage collector?
2021-06-30 03:58:06 +00:00
set { if (value.Length == StringLength) value.CopyTo(Data.AsSpan(Offsets.Trainer1 + 2)); }
Cleanup handle messages for dirty cleaning :)
2019-10-26 19:33:58 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add rival string editing for all remaining games Block Editor for direct edits, no GUI Co-Authored-By: FeralFalcon <33670476+FeralFalcon@users.noreply.github.com>
2021-10-10 23:11:46 +00:00
public string Rival
{
get => GetString(Offsets.Rival, (Korean ? 2 : 1) * OTLength);
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
set => SetString(Data.AsSpan(Offsets.Rival, (Korean ? 2 : 1) * OTLength), value.AsSpan(), 8, StringConverterOption.Clear50);
Add rival string editing for all remaining games Block Editor for direct edits, no GUI Co-Authored-By: FeralFalcon <33670476+FeralFalcon@users.noreply.github.com>
2021-10-10 23:11:46 +00:00
}
public Span<byte> Rival_Trash
{
get => Data.AsSpan(Offsets.Rival, StringLength);
set { if (value.Length == StringLength) value.CopyTo(Data.AsSpan(Offsets.Rival)); }
}
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public override int Gender
{
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
get => Version == GameVersion.C ? Data[Offsets.Gender] : 0;
Full Gen II Save editing for US GSC, JP C (JP GS to come)
2016-09-04 01:57:54 +00:00
set
{
if (Version != GameVersion.C)
return;
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
Data[Offsets.Gender] = (byte) value;
Data[Offsets.Palette] = (byte) value;
Full Gen II Save editing for US GSC, JP C (JP GS to come)
2016-09-04 01:57:54 +00:00
}
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Refactor savefile tid/sid to int can now use TrainerID editor control on a savefile... soon?
2018-04-28 18:06:58 +00:00
public override int TID
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
get => ReadUInt16BigEndian(Data.AsSpan(Offsets.Trainer1));
set => WriteUInt16BigEndian(Data.AsSpan(Offsets.Trainer1), (ushort)value);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Refactor savefile tid/sid to int can now use TrainerID editor control on a savefile... soon?
2018-04-28 18:06:58 +00:00
public override int SID { get => 0; set { } }
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public override int PlayedHours
{
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
get => ReadUInt16BigEndian(Data.AsSpan(Offsets.TimePlayed));
set => WriteUInt16BigEndian(Data.AsSpan(Offsets.TimePlayed), (ushort)value);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public override int PlayedMinutes
{
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
get => Data[Offsets.TimePlayed + 2];
set => Data[Offsets.TimePlayed + 2] = (byte)value;
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public override int PlayedSeconds
{
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
get => Data[Offsets.TimePlayed + 3];
set => Data[Offsets.TimePlayed + 3] = (byte)value;
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
public int Badges
{
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
get => ReadUInt16LittleEndian(Data.AsSpan(Offsets.JohtoBadges));
set { if (value < 0) return; WriteUInt16LittleEndian(Data.AsSpan(Offsets.JohtoBadges), (ushort)value); }
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
private byte Options
{
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
get => Data[Offsets.Options];
set => Data[Offsets.Options] = value;
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public bool BattleEffects
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => (Options & 0x80) == 0;
set => Options = (byte)((Options & 0x7F) | (value ? 0 : 0x80));
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public bool BattleStyleSwitch
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => (Options & 0x40) == 0;
set => Options = (byte)((Options & 0xBF) | (value ? 0 : 0x40));
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public int Sound
{
Switch to c# 7 get/set expressions Add gen5 battle box locked flags no functional change otherwise, just shorter
2017-05-13 03:32:36 +00:00
get => (Options & 0x30) >> 4;
Misc reductions same stuff as previous commit but for Gen2 EventConstMax is always > 0, remove guards
2019-03-30 23:38:52 +00:00
set => Options = (byte)((Options & 0xCF) | ((value != 0 ? 2 : 0) << 4)); // Stereo 2, Mono 0
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public int TextSpeed
{
Allow box name editing on gen2
2017-12-27 23:52:29 +00:00
get => Options & 0x7;
Misc reductions same stuff as previous commit but for Gen2 EventConstMax is always > 0, remove guards
2019-03-30 23:38:52 +00:00
set => Options = (byte)((Options & 0xF8) | (value & 7));
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add more sav1/2 option properties Closes #2321 Closes #2322 no gui as SimpleTrainer is kinda getting overloaded; use linqpad or wait for someone to make a GUI for the specific games
2019-06-09 21:15:42 +00:00
public bool SaveFileExists
{
get => Data[Offsets.Options + 1] == 1;
Revert implicit casting Looks like netstandard2.0 wasn't meant to receive that new c#9 goodie
2021-03-29 07:14:44 +00:00
set => Data[Offsets.Options + 1] = value ? (byte)1 : (byte)0;
Add more sav1/2 option properties Closes #2321 Closes #2322 no gui as SimpleTrainer is kinda getting overloaded; use linqpad or wait for someone to make a GUI for the specific games
2019-06-09 21:15:42 +00:00
}
public int TextBoxFrame // 3bits
{
get => Data[Offsets.Options + 2] & 0b0000_0111;
set => Data[Offsets.Options + 2] = (byte)((Data[Offsets.Options + 2] & 0b1111_1000) | (value & 0b0000_0111));
}
public int TextBoxFlags { get => Data[Offsets.Options + 3]; set => Data[Offsets.Options + 3] = (byte)value; }
public bool TextBoxFrameDelay1 // bit 0
{
get => (TextBoxFlags & 0x01) == 0x01;
set => TextBoxFlags = (TextBoxFlags & ~0x01) | (value ? 0x01 : 0);
}
public bool TextBoxFrameDelayNone // bit 4
{
get => (TextBoxFlags & 0x10) == 0x10;
set => TextBoxFlags = (TextBoxFlags & ~0x10) | (value ? 0x10 : 0);
}
public byte GBPrinterBrightness { get => Data[Offsets.Options + 4]; set => Data[Offsets.Options + 4] = value; }
public bool MenuAccountOn
{
get => Data[Offsets.Options + 5] == 1;
Revert implicit casting Looks like netstandard2.0 wasn't meant to receive that new c#9 goodie
2021-03-29 07:14:44 +00:00
set => Data[Offsets.Options + 5] = value ? (byte)1 : (byte)0;
Add more sav1/2 option properties Closes #2321 Closes #2322 no gui as SimpleTrainer is kinda getting overloaded; use linqpad or wait for someone to make a GUI for the specific games
2019-06-09 21:15:42 +00:00
}
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
// 3 bytes
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public override uint Money
{
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
get => ReadUInt32BigEndian(Data.AsSpan(Offsets.Money)) >> 8;
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
set
{
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
var clamp = (uint)Math.Min(value, MaxMoney);
var toWrite = (clamp << 8) | Data[Offsets.Money + 3];
WriteUInt32BigEndian(Data.AsSpan(Offsets.Money), toWrite);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public uint Coin
{
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
get => ReadUInt16BigEndian(Data.AsSpan(Offsets.Money + 7));
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
set
{
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
var clamped = (ushort)Math.Min(value, MaxCoins);
WriteUInt16BigEndian(Data.AsSpan(Offsets.Money + 7), clamped);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
}
Add Crystal blue card points get/set Co-Authored-By: FeralFalcon <33670476+FeralFalcon@users.noreply.github.com> #3258
2021-09-16 20:16:12 +00:00
public byte BlueCardPoints
{
get
{
int ofs = Offsets.BlueCardPoints;
if (ofs == -1)
return 0;
return Data[ofs];
}
set
{
int ofs = Offsets.BlueCardPoints;
if (ofs == -1)
return;
Data[ofs] = value;
}
}
Cleanup handle messages for dirty cleaning :)
2019-10-26 19:33:58 +00:00
private static ushort[] LegalItems => Legal.Pouch_Items_GSC;
Fix Gen. 2 key items and balls (#2432)
2019-11-16 21:15:09 +00:00
private ushort[] LegalKeyItems => Version == GameVersion.C? Legal.Pouch_Key_C : Legal.Pouch_Key_GS;
private static ushort[] LegalBalls => Legal.Pouch_Ball_GSC;
Cleanup handle messages for dirty cleaning :)
2019-10-26 19:33:58 +00:00
private static ushort[] LegalTMHMs => Legal.Pouch_TMHM_GSC;
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Change signatures to use readonly if possible Extract get/set team methods for battle video
2020-12-05 14:09:33 +00:00
public override IReadOnlyList<InventoryPouch> Inventory
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
get
{
Split InventoryPouch to inheriting classes
2018-07-29 20:55:07 +00:00
InventoryPouch[] pouch =
Full Gen II Save editing for US GSC, JP C (JP GS to come)
2016-09-04 01:57:54 +00:00
{
Split InventoryPouch to inheriting classes
2018-07-29 20:55:07 +00:00
new InventoryPouchGB(InventoryType.TMHMs, LegalTMHMs, 99, Offsets.PouchTMHM, 57),
new InventoryPouchGB(InventoryType.Items, LegalItems, 99, Offsets.PouchItem, 20),
new InventoryPouchGB(InventoryType.KeyItems, LegalKeyItems, 99, Offsets.PouchKey, 26),
new InventoryPouchGB(InventoryType.Balls, LegalBalls, 99, Offsets.PouchBall, 12),
Trailing commas No functional change
2021-08-20 20:49:20 +00:00
new InventoryPouchGB(InventoryType.PCItems, ArrayUtil.ConcatAll(LegalItems, LegalKeyItems, LegalBalls, LegalTMHMs), 99, Offsets.PouchPC, 50),
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
};
Consolidate pouch load/set
2019-03-30 23:10:14 +00:00
return pouch.LoadAll(Data);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
Consolidate pouch load/set
2019-03-30 23:10:14 +00:00
set => value.SaveAll(Data);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
Add sav2 daycare view tfw they store full egg data there too -- show that in the sidebar Tested on C & GS (english), assumedly works fine for other languages (based on the disassembly?)
2018-07-08 22:46:37 +00:00
private readonly byte[] DaycareFlags = new byte[2];
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
public override int GetDaycareSlotOffset(int loc, int slot) => GetPartyOffset(7 + (slot * 2));
Add sav2 daycare view tfw they store full egg data there too -- show that in the sidebar Tested on C & GS (english), assumedly works fine for other languages (based on the disassembly?)
2018-07-08 22:46:37 +00:00
public override uint? GetDaycareEXP(int loc, int slot) => null;
public override bool? IsDaycareOccupied(int loc, int slot) => (DaycareFlags[slot] & 1) != 0;
public override void SetDaycareEXP(int loc, int slot, uint EXP) { }
public override void SetDaycareOccupied(int loc, int slot, bool occupied) { }
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
// Storage
public override int PartyCount
{
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
get => Data[Offsets.Party]; protected set => Data[Offsets.Party] = (byte)value;
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public override int GetBoxOffset(int box)
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
return Data.Length - SIZE_RESERVED + (box * SIZE_BOX);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public override int GetPartyOffset(int slot)
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
return Data.Length - SIZE_RESERVED + (BoxCount * SIZE_BOX) + (slot * SIZE_STORED);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
public override int CurrentBox
{
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
get => Data[Offsets.CurrentBoxIndex] & 0x7F; set => Data[Offsets.CurrentBoxIndex] = (byte)((Data[Offsets.OtherCurrentBox] & 0x80) | (value & 0x7F));
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public override string GetBoxName(int box)
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
Update kor offsets & r/w operations Closes #1451 , was caused by empty party writebacks (was reading from wrong offset dex caught/owned offset was listed as 0x28AE in the thread, is at 0x2AAE instead (-0x20 from seen) should have correct offsets and handling now :)
2017-09-13 02:47:37 +00:00
int len = Korean ? 17 : 9;
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
return GetString(Offsets.BoxNames + (box * len), len);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
public override void SetBoxName(int box, string value)
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
Allow box name editing on gen2
2017-12-27 23:52:29 +00:00
int len = Korean ? 17 : 9;
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
var span = Data.AsSpan(Offsets.BoxNames + (box * len), len);
SetString(span, value.AsSpan(), 8, StringConverterOption.Clear50);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
Simplify get/decrypt pkm access
2019-03-30 02:43:33 +00:00
protected override PKM GetPKM(byte[] data)
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
if (data.Length == SIZE_STORED)
Extract PokemonList* to inherited class Logic is essentially identical; implement a base class and have the generation specific structures implment the differences. Reduce the verbosity a little
2018-08-06 00:28:54 +00:00
return new PokeList2(data, PokeListType.Single, Japanese)[0];
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
return new PK2(data);
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Simplify get/decrypt pkm access
2019-03-30 02:43:33 +00:00
protected override byte[] DecryptPKM(byte[] data)
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
return data;
}
// Pokédex
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
protected override void SetDex(PKM pkm)
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
{
Pokédex refactoring Add ability to get SeenCount & CaughtCount switch gen1/2/3 get/set to use int species (since that's all they end up using), removes the need to create a pk6 template for setting the flag via the dex editor.
2017-03-15 05:41:15 +00:00
int species = pkm.Species;
Update gen2/3 setdex's too
2021-06-05 00:29:55 +00:00
if (species is 0 or > Legal.MaxSpeciesID_2)
return;
if (pkm.IsEgg)
Pokédex refactoring Add ability to get SeenCount & CaughtCount switch gen1/2/3 get/set to use int species (since that's all they end up using), removes the need to create a pk6 template for setting the flag via the dex editor.
2017-03-15 05:41:15 +00:00
return;
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
Refactoring mostly renaming things, includes a little bit of added sugar and splitting methods to simplify the codebase. all methods are now PascalCase
2017-06-18 01:37:19 +00:00
SetCaught(pkm.Species, true);
SetSeen(pkm.Species, true);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
private void SetUnownFormFlags()
{
Pokédex refactoring Add ability to get SeenCount & CaughtCount switch gen1/2/3 get/set to use int species (since that's all they end up using), removes the need to create a pk6 template for setting the flag via the dex editor.
2017-03-15 05:41:15 +00:00
// Give all Unown caught to prevent a crash on pokedex view
for (int i = 1; i <= 26; i++)
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
Data[Offsets.PokedexSeen + 0x1F + i] = (byte)i;
Add first unown seen on dex set immediately after unown dex: https://github.com/pret/pokecrystal/blob/c2a7216d9b8689591ede817015bf96f263396bb8/wram.asm#L2714-L2722 per discussion on forums: https://projectpokemon.org/home/forums/topic/43179-bug-unown-sprite-glitched-in-pokédex-in-gen2/?tab=comments#comment-225342 expose some useful properties for the pkhex.core api (unlock all, unlock individual, define which unown shows up)
2017-12-27 17:56:04 +00:00
if (UnownFirstSeen == 0) // Invalid
UnownFirstSeen = 1; // A
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add first unown seen on dex set immediately after unown dex: https://github.com/pret/pokecrystal/blob/c2a7216d9b8689591ede817015bf96f263396bb8/wram.asm#L2714-L2722 per discussion on forums: https://projectpokemon.org/home/forums/topic/43179-bug-unown-sprite-glitched-in-pokédex-in-gen2/?tab=comments#comment-225342 expose some useful properties for the pkhex.core api (unlock all, unlock individual, define which unown shows up)
2017-12-27 17:56:04 +00:00
/// <summary>
/// Toggles the availability of Unown letter groups in the Wild
/// </summary>
/// <remarks>
/// Max value of 0x0F, 4 bitflags
/// 1 lsh 0: A, B, C, D, E, F, G, H, I, J, K
/// 1 lsh 1: L, M, N, O, P, Q, R
/// 1 lsh 2: S, T, U, V, W
/// 1 lsh 3: X, Y, Z
/// </remarks>
public int UnownUnlocked
{
get => Data[Offsets.PokedexSeen + 0x1F + 27];
set => Data[Offsets.PokedexSeen + 0x1F + 27] = (byte)value;
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add first unown seen on dex set immediately after unown dex: https://github.com/pret/pokecrystal/blob/c2a7216d9b8689591ede817015bf96f263396bb8/wram.asm#L2714-L2722 per discussion on forums: https://projectpokemon.org/home/forums/topic/43179-bug-unown-sprite-glitched-in-pokédex-in-gen2/?tab=comments#comment-225342 expose some useful properties for the pkhex.core api (unlock all, unlock individual, define which unown shows up)
2017-12-27 17:56:04 +00:00
/// <summary>
/// Unlocks all Unown letters/forms in the wild.
/// </summary>
public void UnownUnlockAll() => UnownUnlocked = 0x0F; // all 4 bitflags
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add first unown seen on dex set immediately after unown dex: https://github.com/pret/pokecrystal/blob/c2a7216d9b8689591ede817015bf96f263396bb8/wram.asm#L2714-L2722 per discussion on forums: https://projectpokemon.org/home/forums/topic/43179-bug-unown-sprite-glitched-in-pokédex-in-gen2/?tab=comments#comment-225342 expose some useful properties for the pkhex.core api (unlock all, unlock individual, define which unown shows up)
2017-12-27 17:56:04 +00:00
/// <summary>
/// Flag that determines if Unown Letters are available in the wild: A, B, C, D, E, F, G, H, I, J, K
/// </summary>
public bool UnownUnlocked0
{
get => (UnownUnlocked & 1 << 0) == 1 << 0;
Fix erroneous value setters
2021-05-18 20:12:43 +00:00
set => UnownUnlocked = (UnownUnlocked & ~(1 << 0)) | ((value ? 1 : 0) << 0);
Add first unown seen on dex set immediately after unown dex: https://github.com/pret/pokecrystal/blob/c2a7216d9b8689591ede817015bf96f263396bb8/wram.asm#L2714-L2722 per discussion on forums: https://projectpokemon.org/home/forums/topic/43179-bug-unown-sprite-glitched-in-pokédex-in-gen2/?tab=comments#comment-225342 expose some useful properties for the pkhex.core api (unlock all, unlock individual, define which unown shows up)
2017-12-27 17:56:04 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add first unown seen on dex set immediately after unown dex: https://github.com/pret/pokecrystal/blob/c2a7216d9b8689591ede817015bf96f263396bb8/wram.asm#L2714-L2722 per discussion on forums: https://projectpokemon.org/home/forums/topic/43179-bug-unown-sprite-glitched-in-pokédex-in-gen2/?tab=comments#comment-225342 expose some useful properties for the pkhex.core api (unlock all, unlock individual, define which unown shows up)
2017-12-27 17:56:04 +00:00
/// <summary>
/// Flag that determines if Unown Letters are available in the wild: L, M, N, O, P, Q, R
/// </summary>
public bool UnownUnlocked1
{
get => (UnownUnlocked & 1 << 1) == 1 << 1;
Fix erroneous value setters
2021-05-18 20:12:43 +00:00
set => UnownUnlocked = (UnownUnlocked & ~(1 << 1)) | ((value ? 1 : 0) << 1);
Add first unown seen on dex set immediately after unown dex: https://github.com/pret/pokecrystal/blob/c2a7216d9b8689591ede817015bf96f263396bb8/wram.asm#L2714-L2722 per discussion on forums: https://projectpokemon.org/home/forums/topic/43179-bug-unown-sprite-glitched-in-pokédex-in-gen2/?tab=comments#comment-225342 expose some useful properties for the pkhex.core api (unlock all, unlock individual, define which unown shows up)
2017-12-27 17:56:04 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add first unown seen on dex set immediately after unown dex: https://github.com/pret/pokecrystal/blob/c2a7216d9b8689591ede817015bf96f263396bb8/wram.asm#L2714-L2722 per discussion on forums: https://projectpokemon.org/home/forums/topic/43179-bug-unown-sprite-glitched-in-pokédex-in-gen2/?tab=comments#comment-225342 expose some useful properties for the pkhex.core api (unlock all, unlock individual, define which unown shows up)
2017-12-27 17:56:04 +00:00
/// <summary>
/// Flag that determines if Unown Letters are available in the wild: S, T, U, V, W
/// </summary>
public bool UnownUnlocked2
{
get => (UnownUnlocked & 1 << 2) == 1 << 2;
Fix erroneous value setters
2021-05-18 20:12:43 +00:00
set => UnownUnlocked = (UnownUnlocked & ~(1 << 2)) | ((value ? 1 : 0) << 2);
Add first unown seen on dex set immediately after unown dex: https://github.com/pret/pokecrystal/blob/c2a7216d9b8689591ede817015bf96f263396bb8/wram.asm#L2714-L2722 per discussion on forums: https://projectpokemon.org/home/forums/topic/43179-bug-unown-sprite-glitched-in-pokédex-in-gen2/?tab=comments#comment-225342 expose some useful properties for the pkhex.core api (unlock all, unlock individual, define which unown shows up)
2017-12-27 17:56:04 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add first unown seen on dex set immediately after unown dex: https://github.com/pret/pokecrystal/blob/c2a7216d9b8689591ede817015bf96f263396bb8/wram.asm#L2714-L2722 per discussion on forums: https://projectpokemon.org/home/forums/topic/43179-bug-unown-sprite-glitched-in-pokédex-in-gen2/?tab=comments#comment-225342 expose some useful properties for the pkhex.core api (unlock all, unlock individual, define which unown shows up)
2017-12-27 17:56:04 +00:00
/// <summary>
/// Flag that determines if Unown Letters are available in the wild: X, Y, Z
/// </summary>
public bool UnownUnlocked3
{
get => (UnownUnlocked & 1 << 3) == 1 << 3;
Fix erroneous value setters
2021-05-18 20:12:43 +00:00
set => UnownUnlocked = (UnownUnlocked & ~(1 << 3)) | ((value ? 1 : 0) << 3);
Add first unown seen on dex set immediately after unown dex: https://github.com/pret/pokecrystal/blob/c2a7216d9b8689591ede817015bf96f263396bb8/wram.asm#L2714-L2722 per discussion on forums: https://projectpokemon.org/home/forums/topic/43179-bug-unown-sprite-glitched-in-pokédex-in-gen2/?tab=comments#comment-225342 expose some useful properties for the pkhex.core api (unlock all, unlock individual, define which unown shows up)
2017-12-27 17:56:04 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add first unown seen on dex set immediately after unown dex: https://github.com/pret/pokecrystal/blob/c2a7216d9b8689591ede817015bf96f263396bb8/wram.asm#L2714-L2722 per discussion on forums: https://projectpokemon.org/home/forums/topic/43179-bug-unown-sprite-glitched-in-pokédex-in-gen2/?tab=comments#comment-225342 expose some useful properties for the pkhex.core api (unlock all, unlock individual, define which unown shows up)
2017-12-27 17:56:04 +00:00
/// <summary>
/// Chooses which Unown sprite to show in the regular Pokédex View
/// </summary>
public int UnownFirstSeen
{
get => Data[Offsets.PokedexSeen + 0x1F + 28];
set => Data[Offsets.PokedexSeen + 0x1F + 28] = (byte)value;
Pokédex refactoring Add ability to get SeenCount & CaughtCount switch gen1/2/3 get/set to use int species (since that's all they end up using), removes the need to create a pk6 template for setting the flag via the dex editor.
2017-03-15 05:41:15 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Misc reductions same stuff as previous commit but for Gen2 EventConstMax is always > 0, remove guards
2019-03-30 23:38:52 +00:00
public override bool GetSeen(int species) => GetDexFlag(Offsets.PokedexSeen, species);
public override bool GetCaught(int species) => GetDexFlag(Offsets.PokedexCaught, species);
public override void SetSeen(int species, bool seen) => SetDexFlag(Offsets.PokedexSeen, species, seen);
public override void SetCaught(int species, bool caught)
{
SetDexFlag(Offsets.PokedexCaught, species, caught);
Use enum for species comparisons slightly easier to read with named values
2019-12-09 01:39:19 +00:00
if (caught && species == (int)Species.Unown)
Misc reductions same stuff as previous commit but for Gen2 EventConstMax is always > 0, remove guards
2019-03-30 23:38:52 +00:00
SetUnownFormFlags();
}
private bool GetDexFlag(int region, int species)
Pokédex refactoring Add ability to get SeenCount & CaughtCount switch gen1/2/3 get/set to use int species (since that's all they end up using), removes the need to create a pk6 template for setting the flag via the dex editor.
2017-03-15 05:41:15 +00:00
{
int bit = species - 1;
int ofs = bit >> 3;
Misc reductions same stuff as previous commit but for Gen2 EventConstMax is always > 0, remove guards
2019-03-30 23:38:52 +00:00
return GetFlag(region + ofs, bit & 7);
Pokédex refactoring Add ability to get SeenCount & CaughtCount switch gen1/2/3 get/set to use int species (since that's all they end up using), removes the need to create a pk6 template for setting the flag via the dex editor.
2017-03-15 05:41:15 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Misc reductions same stuff as previous commit but for Gen2 EventConstMax is always > 0, remove guards
2019-03-30 23:38:52 +00:00
private void SetDexFlag(int region, int species, bool value)
Pokédex refactoring Add ability to get SeenCount & CaughtCount switch gen1/2/3 get/set to use int species (since that's all they end up using), removes the need to create a pk6 template for setting the flag via the dex editor.
2017-03-15 05:41:15 +00:00
{
int bit = species - 1;
int ofs = bit >> 3;
Misc reductions same stuff as previous commit but for Gen2 EventConstMax is always > 0, remove guards
2019-03-30 23:38:52 +00:00
SetFlag(region + ofs, bit & 7, value);
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
String editing refactor Move all sanitization operations from PK* and SAV* to PKX; add general method for fetching a generation specific string Changes the Text subform editor to show trash bytes when appropriate. Special characters to be shown can be easily inserted in the future.
2017-04-09 21:06:50 +00:00
Add gs event flags https://projectpokemon.org/home/forums/topic/49717-pkhex-flag-editing/?tab=comments#comment-240804 via pret repo; looks like 2000 event flags, and 0x100 event consts/work-vals (byte) add more rebattle toggles
2019-03-06 07:06:05 +00:00
/// <summary>All Event Constant values for the save file</summary>
/// <remarks>These are all bytes</remarks>
Change signatures to use readonly if possible Extract get/set team methods for battle video
2020-12-05 14:09:33 +00:00
public override ushort[] GetEventConsts()
Add gs event flags https://projectpokemon.org/home/forums/topic/49717-pkhex-flag-editing/?tab=comments#comment-240804 via pret repo; looks like 2000 event flags, and 0x100 event consts/work-vals (byte) add more rebattle toggles
2019-03-06 07:06:05 +00:00
{
Change signatures to use readonly if possible Extract get/set team methods for battle video
2020-12-05 14:09:33 +00:00
ushort[] Constants = new ushort[EventConstMax];
for (int i = 0; i < Constants.Length; i++)
Constants[i] = Data[EventConst + i];
return Constants;
}
Add gs event flags https://projectpokemon.org/home/forums/topic/49717-pkhex-flag-editing/?tab=comments#comment-240804 via pret repo; looks like 2000 event flags, and 0x100 event consts/work-vals (byte) add more rebattle toggles
2019-03-06 07:06:05 +00:00
Change signatures to use readonly if possible Extract get/set team methods for battle video
2020-12-05 14:09:33 +00:00
/// <summary>All Event Constant values for the save file</summary>
/// <remarks>These are all bytes</remarks>
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
public override void SetEventConsts(ReadOnlySpan<ushort> value)
Change signatures to use readonly if possible Extract get/set team methods for battle video
2020-12-05 14:09:33 +00:00
{
if (value.Length != EventConstMax)
return;
for (int i = 0; i < value.Length; i++)
Data[EventConst + i] = Math.Min(byte.MaxValue, (byte)value[i]);
Add gs event flags https://projectpokemon.org/home/forums/topic/49717-pkhex-flag-editing/?tab=comments#comment-240804 via pret repo; looks like 2000 event flags, and 0x100 event consts/work-vals (byte) add more rebattle toggles
2019-03-06 07:06:05 +00:00
}
Add RTC ResetKey calc
2017-09-23 23:03:59 +00:00
// Misc
public ushort ResetKey => GetResetKey();
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add RTC ResetKey calc
2017-09-23 23:03:59 +00:00
private ushort GetResetKey()
{
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
var value = (TID >> 8) + (TID & 0xFF) + ((Money >> 16) & 0xFF) + ((Money >> 8) & 0xFF) + (Money & 0xFF);
Replace more linq usage
2021-08-06 05:39:38 +00:00
var ot = Data.AsSpan(Offsets.Trainer1 + 2, 5);
var sum = 0;
foreach (var b in ot)
{
if (b == StringConverter12.G1TerminatorCode)
break;
sum += b;
}
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
return (ushort)(value + sum);
Add RTC ResetKey calc
2017-09-23 23:03:59 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Add RTC reset, allows game to define on continue Closes #2273 , thanks @SatoMew !
2019-03-30 19:34:51 +00:00
/// <summary>
/// Sets the "Time Not Set" flag to the RTC Flag list.
/// </summary>
public void ResetRTC() => Data[Offsets.RTCFlags] |= 0x80;
Add all deco unlock #1819 not exposed via GUI
2018-02-08 02:29:45 +00:00
public void UnlockAllDecorations()
{
for (int i = 676; i <= 721; i++)
SetEventFlag(i, true);
}
Add RTC ResetKey calc
2017-09-23 23:03:59 +00:00
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
public override string GetString(ReadOnlySpan<byte> data)
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
{
if (Korean)
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
return StringConverter2KOR.GetString(data);
return StringConverter12.GetString(data, Japanese);
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
}
style updates should be pretty much it
2018-09-15 05:37:47 +00:00
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
public override int SetString(Span<byte> destBuffer, ReadOnlySpan<char> value, int maxLength, StringConverterOption option)
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
{
if (Korean)
Refactoring: Span-based value writes and method signatures (#3361) Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
2022-01-03 05:35:59 +00:00
return StringConverter2KOR.SetString(value, destBuffer, maxLength, option);
return StringConverter12.SetString(destBuffer, value, maxLength, Japanese, option);
Add gen2 korean handling hypothetical for now, feel free to submit PRs to fix anything that breaks / was incorrect in the implementation
2017-09-11 02:56:21 +00:00
}
Add more sav1/2 option properties Closes #2321 Closes #2322 no gui as SimpleTrainer is kinda getting overloaded; use linqpad or wait for someone to make a GUI for the specific games
2019-06-09 21:15:42 +00:00
public bool IsGBMobileAvailable => Japanese && Version == GameVersion.C;
public bool IsGBMobileEnabled => Japanese && Enum.IsDefined(typeof(GBMobileCableColor), GBMobileCable);
public GBMobileCableColor GBMobileCable
{
get => (GBMobileCableColor) Data[0xE800];
set
{
Data[0xE800] = (byte)value;
Data[0x9000] = (byte)(0xFF - value);
}
}
}
public enum GBMobileCableColor : byte
{
None = 0,
Blue = 1,
Yellow = 2,
Green = 3,
Red = 4,
Debug = 0x81,
Initial (pretty broken) US SAV2 loading/viewing
2016-09-02 21:20:39 +00:00
}
}
Reference in a new issue Copy permalink