mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-24 21:54:01 +00:00
771cb4d58b
In case fitImage support is disabled, and image_locate_script() is
passed a fitImage, then the 'data' variable is used uninitialized.
Drop into the default: branch of the switch-case statement and do
not return the uninitialized data, and do not modify the return
pointer either, just print an error message.
Reported by clang build:
"
$ make HOSTCC=clang CC=clang KCFLAGS=-Werror sandbox64_defconfig && make HOSTCC=clang CC=clang KCFLAGS=-Werror
...
boot/image-board.c:1006:7: error: variable 'data' is used uninitialized whenever switch case is taken [-Werror,-Wsometimes-uninitialized]
case IMAGE_FORMAT_LEGACY:
^~~~~~~~~~~~~~~~~~~
include/image.h:608:29: note: expanded from macro 'IMAGE_FORMAT_LEGACY'
^~~~
boot/image-board.c:1128:19: note: uninitialized use occurs here
*datap = (char *)data;
^~~~
boot/image-board.c:1001:11: note: initialize the variable 'data' to silence this warning
u32 *data;
^
= NULL
"
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
|
||
|---|---|---|
| .. | ||
| android_ab.c | ||
| boot_fit.c | ||
| bootdev-uclass.c | ||
| bootflow.c | ||
| bootflow_internal.h | ||
| bootflow_menu.c | ||
| bootm.c | ||
| bootm_os.c | ||
| bootmeth-uclass.c | ||
| bootmeth_distro.c | ||
| bootmeth_efi.c | ||
| bootmeth_efi_mgr.c | ||
| bootmeth_pxe.c | ||
| bootmeth_qfw.c | ||
| bootmeth_sandbox.c | ||
| bootmeth_script.c | ||
| bootretry.c | ||
| bootstd-uclass.c | ||
| common_fit.c | ||
| expo.c | ||
| fdt_region.c | ||
| image-android-dt.c | ||
| image-android.c | ||
| image-board.c | ||
| image-cipher.c | ||
| image-fdt.c | ||
| image-fit-sig.c | ||
| image-fit.c | ||
| image-host.c | ||
| image-pre-load.c | ||
| image-sig.c | ||
| image.c | ||
| Kconfig | ||
| Makefile | ||
| pxe_utils.c | ||
| scene.c | ||
| scene_internal.h | ||
| scene_menu.c | ||
| vbe.c | ||
| vbe_request.c | ||
| vbe_simple.c | ||
| vbe_simple.h | ||
| vbe_simple_fw.c | ||
| vbe_simple_os.c | ||